| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
| |
Added a comment to help the discovery of this.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- I mostly don’t care about this, but there are a couple of things that
Standard does that I disagree with. They are inherited from Rubocop,
but Standard fixes many of Rubocop’s nonsense rules.
- Array literal wrappers %i[], %w[], etc. are just ugly and never
should have become any sort of standard. I would be happier if this
part of standard were just completely disabled, because it‘s
unnecessary and wrong.
- Quote literals having to be %q() is equally wrong. I’ve avoided the
issue here because the generated gemspec uses both "unnecessary"
quote literals (it’s necessary if I say it’s necessary) and the
wrong wrappers (I wouldn’t use %q<>, but this is generated code).
- I still think that short hashes can be `{ foo: "bar" }`, but I’m
mostly using Elixir these days, so I don’t mind `%{foo: "bar"}`, so
I can get used to it in Ruby. It still feels wrong, almost 20 years
in.
- There are semantic differences between and / &&, or / ||, but in some
cases the reformatted code is substantially _worse_ to read. Again,
I mostly don’t _care_ about this difference, but Rubocop’s insistence
is silly; these should only be replaced where there _is_ ambiguity.
- Replacing `x = foo or next` should never be replaced with `(x = foo)
|| next`. That’s replacing something that is somewhat readable with
something damned-near unreadable. Both should be replaced with:
```ruby
x = foo
next unless x
```
- YAML.safe_load works differently between Psych 2.x and Psych 3.x, so
some updates have been made to make that work cleanly.
Overall, this introduces a lot of churn, but I think will be easier to
deal with updates to `standardrb` instead of the rapid churn that has
been Rubocop.
|
| |
|
|
|
|
|
|
|
|
| |
- Added Ruby 3.0 to the CI test matrix. Added `windows/jruby` to the
CI exclusion list; it refuses to run successfully.
- Update History.md and Contributing.md documentation with the most
recent updates in a `NEXT` release (there are no changes as of yet
that require a new release).
|
|
|
|
|
| |
* Update rdoc overview to match README.
* Fix a typo.
* Update `simplified` docs to match new semantics.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This PR suppress the following Ruby 2.7's warnings.
```console
% cd path/to/mime-types/ruby-mime-types
% ruby -v
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-darwin17]
% bundle exec rake
(snip)
/Users/koic/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/rake-12.3.3/lib/rake/file_utils_ext.rb:35:
warning: Using the last argument as keyword parameters is deprecated;
maybe ** should be added to the call
/Users/koic/.rbenv/versions/2.7.0/lib/ruby/2.7.0/fileutils.rb:644:
warning: The called method `rm_rf' is defined here
/Users/koic/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/rake-12.3.3/lib/rake/file_utils_ext.rb:35:
warning: Using the last argument as keyword parameters is deprecated;
maybe ** should be added to the call
/Users/koic/.rbenv/versions/2.7.0/lib/ruby/2.7.0/fileutils.rb:622:
warning: The called method `rm_r' is defined here
rm -rf doc
rm -r pkg
/Users/koic/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/rake-12.3.3/lib/rake/clean.rb:34:
warning: Using the last argument as keyword parameters is deprecated;
maybe ** should be added to the call
/Users/koic/.rbenv/versions/2.7.0/lib/ruby/2.7.0/fileutils.rb:622:
warning: The called method `rm_r' is defined here
```
For Ruby 2.8.0-dev (Ruby 3.0) the warnings will be `ArgumentError`.
```console
% cd path/to/mime-types/ruby-mime-types
% ruby -v
ruby 2.8.0dev (2020-01-05T05:35:14Z master 54fd50c951) [x86_64-darwin17]
% bundle exec rake
(snip)
rake aborted!
ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/koic/.rbenv/versions/2.8.0-dev/bin/bundle:23:in `load'
/Users/koic/.rbenv/versions/2.8.0-dev/bin/bundle:23:in `<main>'
Tasks: TOP => default => mime-types.gemspec => clobber => clean =>
clobber_docs
(See full trace by running task with --trace)
```
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
- Administrative and Ruby 2.7 bugfix
|
|
|
|
| |
versions.
|
|\
| |
| | |
CI: Drop unused sudo: false Travis directive
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- Clean up the code to be a bit more like what I write.
- Create a .rubocop.yml that disables bone-headed defaults and
sets things I agree with.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
- https://github.com/joshuaclayton/unused
- All of the reported items are present because they are required for
implementation or they are present because they are used by tools outside of
mime-types itself (e.g., the mime-types-data tools).
Also remove .freeze methods on strings from all files because of the frozen
string magic comment.
|
| |
|
|\
| |
| | |
Remove unintentional debugging code
|
|/ |
|
| |
|
|
|
|
|
| |
implementation detail. Continue to exclude it from docuemntation as it is not
part of the public API.
|
| |
|
| |
|
|
|
|
| |
Fully resolves #117, #127, and #134.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Some MIME types are in the same family, but their #simplified values
aren't the same. One such example are "text/comma-separated-values" and
"text/csv" MIME types. The former is obsolete and unregistered, while
the latter is not obsolete and registered, but mime-types would still
rank "text/comma-separated-values" higher because it just looks at the
alphabetic order.
|
| |
|
| |
|
|
|
|
|
|
| |
* fast_finish is to get the Travis result as faster
without waiting the result of the "allow_failures" items.
See https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* 3 bug fixes
* A test for MIME::Types::Cache fails under Ruby 2.3 because of frozen
strings #118. This has been fixed.
* The JSON data has been incorrectly encoded since the release of
mime-types 3 on the +xrefs+ field, because of the switch to using a Set
to store cross-reference information. This has been fixed.
* A tentative fix for #117 has been applied, removing the only circular
require dependencies that exist (and for which there was code to
prevent, but the current fix is simpler). I have no way to verify this
fix and depending on how things are loaded by `delayed_job`, this fix
may not be sufficient.
* 1 governance change
* Updated to Contributor Covenant 1.4.
|
| |
|
|\
| |
| | |
Use retina badges
|
|/ |
|
|
|
|
|
| |
Taken liberally from @schneems gist for top fifty dependencies.
https://gist.github.com/schneems/e09c95da37a8c50047a8
|
| |
|
| |
|
| |
|
|\
| |
| | |
mime-types 3.0
|