Reject :varargs parameters for callbacks. Fixes #161

2 files changed, 14 insertions, 2 deletions

diff --git a/lib/ffi/library.rb b/lib/ffi/library.rb
index 6612263..3aa781f 100644
--- a/lib/ffi/library.rb
+++ b/lib/ffi/library.rb
@@ -361,10 +361,12 @@ code
         [ nil, args[0], args[1] ]
       end
 
+      native_params = params.map { |e| find_type(e) }
+      raise ArgumentError, "callbacks cannot have variadic parameters" if native_params.include?(FFI::Type::VARARGS)
       options = Hash.new
       options[:convention] = ffi_convention
       options[:enums] = @ffi_enums if defined?(@ffi_enums)
-      cb = FFI::CallbackInfo.new(find_type(ret), params.map { |e| find_type(e) }, options)
+      cb = FFI::CallbackInfo.new(find_type(ret), native_params, options)
 
       # Add to the symbol -> type map (unless there was no name)
       unless name.nil?
diff --git a/spec/ffi/callback_spec.rb b/spec/ffi/callback_spec.rb
index 463e5e3..bec0121 100644
--- a/spec/ffi/callback_spec.rb
+++ b/spec/ffi/callback_spec.rb
@@ -665,4 +665,14 @@ describe "Callback with " do
     v.pointer.should eq FFI::Pointer::NULL
   end
 
-end # unless true
+  it "varargs parameters are rejected" do
+    lambda {
+      Module.new do
+        extend FFI::Library
+        ffi_lib TestLibrary::PATH
+        callback :cbVrL, [ :varargs ], :long
+      end
+    }.should raise_error(ArgumentError)
+  end
+
+end