| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
The `usermod` binary in SUSE 12.1 no longer throws an error if you
attempt to unlock a user account that has no password.
Signed-off-by: Tom Duffield <tom@chef.io>
|
| |
|
|
|
|
|
| |
userdel -r will not remove a homedir not owned by the user, have
to manually rm -rf it.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
|
|
|
| |
try to document it a bit better so i don't accidentally delete it
again.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| | |
|
| |
|
|
| |
instance_eval ran into namespace issues
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
|
|
| |
mac always gets dscl, windows always gets windows
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
| |\
| |
| | |
Autofixing new Perf cops in 0.37.2
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
6 Performance/Casecmp
18 Performance/Detect
1 Performance/RangeInclude
27 Performance/RedundantBlockCall
6 Performance/RedundantMatch
5 Performance/RedundantMerge
18 Performance/StringReplacement
|
| |/
|
|
|
|
|
| |
artursitarski/change-shell-for-locked-user"
This reverts commit 94494e761763b877c3ef3b52eee9ac9df2186340, reversing
changes made to a95a87d50c9e5af2fbd583afcf972880656d1a4b.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
252 Style/TrailingCommaInLiteral
84 Style/TrailingCommaInArguments
15 Style/SpaceAroundKeyword
--
351 Total
We already dealt with SpaceAroundKeyword under its old name
SpaceBeforeModifierKeyword, it looks like it got stricter about
spaces after keywords.
TrailingComma also got split, and it looks like the
TrailingCommaInArguments behavior is new?
|
| | |
|
| | |
|
| |\
| |
| | |
Change shell for locked user.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Style/NegatedWhile
Style/ParenthesesAroundCondition
Style/WhileUntilDo
Style/WordArray
Performance/ReverseEach
Style/ColonMethodCall
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
| | |
| |
| | |
Generated via git ls-files | xargs perl -pi -e "s/(Author.*?<[^@]+@)(?:opscode\\.com|getchef\\.com)(>)/\\1chef.io\\2/gi"
|
| | |
| |
| | |
Created via git ls-files | xargs perl -pi -e "s/(Copyright.*?), Opscode(,)? Inc(\.)?/\\1, Chef Software Inc./gi"
|
| |/
|
| |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to https://abcofaix.wordpress.com/tag/usermod/, the value
can be up to 200. We were seeing tests on our aix testers fail with
```
1) Chef::Provider::User::Useradd action :create when the user does not exist beforehand when a system user is specified ensures the user has the properties of a system user
Failure/Error: expect(pw_entry.uid.to_i).to be < uid_min.to_i
expected: < 100
got: 101
# ./spec/functional/resource/user/useradd_spec.rb:306:in `block (5 levels) in <top (required)>'
```
|
| |
|
|
| |
home directory is expected
|
| |
|
|
| |
uppercase users
|
| |
|
|
|
|
| |
See chef/chefstyle#11 for analysis and discussion. We select '{}' since
audit of our source code shows that is the most common, and that used to
be the dominant learning paradigm (e.g. in ruby 1.9 pickaxe book.
|
| |
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
| |
|
|
| |
chefstyle -a fixed 1044 occurrances
|
| | |
|
| |
|
|
|
| |
Otherwise we run useradd provider prior to the before block with the
example-level `skip` being called.
|
| | |
|
| |
|
|
| |
RSpec isn't a bug database
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are seeing failures in our CI relating to state not being cleaned
up in a previous run:
```
1) Chef::Provider::User::Useradd action :create when the user already exists and home directory is updated and manage_home is enabled moves the home directory to the new location
Failure/Error: user_resource.run_action(:create)
Mixlib::ShellOut::ShellCommandFailed:
user[TEST USER RESOURCE] (dynamically defined) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '12'
---- Begin output of ["usermod", "-d", "/home/bar", "-m", "cf-test"] ----
STDOUT:
STDERR: usermod: directory /home/bar exists
---- End output of ["usermod", "-d", "/home/bar", "-m", "cf-test"] ----
Ran ["usermod", "-d", "/home/bar", "-m", "cf-test"] returned 12
# ./lib/chef/mixin/shell_out.rb:56:in `shell_out!'
# ./lib/chef/provider/user/useradd.rb:42:in `manage_user'
# ./lib/chef/provider/user.rb:137:in `block in action_create'
# ./lib/chef/mixin/why_run.rb:52:in `call'
# ./lib/chef/mixin/why_run.rb:52:in `add_action'
# ./lib/chef/provider.rb:180:in `converge_by'
# ./lib/chef/provider/user.rb:136:in `action_create'
# ./lib/chef/provider.rb:145:in `run_action'
# ./lib/chef/resource.rb:561:in `run_action'
# ./spec/functional/resource/user/useradd_spec.rb:336:in `block (4 levels) in <top (required)>'
```
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
See https://github.com/chef/chef/commit/f445869cfa26b17e22a4266c58907b3619b749ae#commitcomment-9471756
|
| | |
|
| | |
|
| | |
|