summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Solaris users are locked only if *LK*COOL-413/getent-on-solaris-doesnt-workTom Duffield2016-10-312-2/+3
| | | | | | | | | According to `man shadow` on Solaris 10 and 11, an account is only locked if the first four characters in the password field are `*LK*`. The same is true for SmartOS (the OS for which the initial code was contributed). Signed-off-by: Tom Duffield <tom@chef.io>
* Properly check lock status of user on solaris2Tom Duffield2016-10-312-20/+39
| | | | | | | | | On Solaris, the 'shadow' database does not exist within `getent`, so the checking for the username there won't return accurate results. As the Solaris provider assumes user management via /etc/shadow, we can very easily parse the contents of the file directly. Signed-off-by: Tom Duffield <tom@chef.io>
* Bump version of chef to 12.16.22 by Chef Versioner.v12.16.22Chef Versioner2016-10-244-8/+8
|
* Merge pull request #5483 from chef/lcg/package-inline-resourcesLamont Granquist2016-10-242-8/+10
|\ | | | | Core: set use_inline_resources in package superclass
| * remove excessive mockinglcg/package-inline-resourcesLamont Granquist2016-10-211-3/+3
| | | | | | | | | | | | | | we have too much collaboration and state in our objects to write pure unit tests. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * set use_inline_resources in package superclassLamont Granquist2016-10-211-5/+7
| | | | | | | | | | | | | | allows subclasses to use_inline_resources (hab_package will most likely want this) Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Bump version of chef to 12.16.21 by Chef Versioner.v12.16.21Chef Versioner2016-10-244-8/+8
| |
* | Merge pull request #5482 from chef/COOL-597/use-all-for-assertionTom Duffield2016-10-242-1/+2
|\ \ | |/ |/| Use `all?` instead of `any?` to check for SUSE users
| * Mock users in functional group testsCOOL-597/use-all-for-assertionTom Duffield2016-10-211-0/+1
| | | | | | | | | | | | | | Because `Provider::Group::Suse` expects users to exist, we need to mock out the `Etc` call that checks for our non-existent spec users. Signed-off-by: Tom Duffield <tom@chef.io>
| * Use `all?` instead of `any?` to check for SUSE usersTom Duffield2016-10-211-1/+1
|/ | | | | | Using `all?` will return `false` when the array is empty. Signed-off-by: Tom Duffield <tom@chef.io>
* Bump version of chef to 12.16.20 by Chef Versioner.v12.16.20Chef Versioner2016-10-214-8/+8
|
* Merge pull request #5476 from tas50/copyrightsLamont Granquist2016-10-2121-44/+44
|\ | | | | Fix copyrights and update a few more Opscode references to Chef
| * More Opscode -> Chef updatesTim Smith2016-10-2013-36/+36
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Fix a few bad copyrightsTim Smith2016-10-208-8/+8
| | | | | | | | | | | | I think this happened when we merged the Opscode and Chef copyrights Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #5475 from tas50/spec_typoLamont Granquist2016-10-211-1/+1
|\ \ | | | | | | Fix a typo in the apt_repository spec
| * | Fix spec typoTim Smith2016-10-191-1/+1
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Merge pull request #5474 from tas50/yum_propertyLamont Granquist2016-10-211-1/+1
|\ \ \ | | | | | | | | Use property vs. attribute in yum_repository
| * | | Use property vs. attribute in yum_propertyTim Smith2016-10-191-1/+1
| |/ / | | | | | | | | | | | | | | | We just auto replace the attribute call with a property call here. We might as well use the right one to start with. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Bump version of chef to 12.16.19 by Chef Versioner.v12.16.19Chef Versioner2016-10-214-8/+8
| | |
* | | Merge pull request #5472 from chef/COOL-597/address-suse-test-failuresTom Duffield2016-10-213-6/+117
|\ \ \ | | | | | | | | Address test failures in SUSE 11.4 and 12.1
| * | | Raise error if suse group manager adds non-existent userCOOL-597/address-suse-test-failuresTom Duffield2016-10-202-4/+113
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The expected behavior of chef, as defined by our tests, is that if a user specified in a group resource does not exist than chef should raise an error. On suse, we use groupmod which will not raise an error if you attempt to add a non-existent user to a group. This change adds in a simple check that will raise an error if the specified does not exist. Signed-off-by: Tom Duffield <tom@chef.io>
| * | | Update useradd test to account for new SUSE 12.1 behaviorTom Duffield2016-10-201-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The `usermod` binary in SUSE 12.1 no longer throws an error if you attempt to unlock a user account that has no password. Signed-off-by: Tom Duffield <tom@chef.io>
* | | | Bump version of chef to 12.16.18 by Chef Versioner.v12.16.18Chef Versioner2016-10-204-8/+8
| | | |
* | | | Merge pull request #5479 from chef/lcg/rubocop-0.44.1Lamont Granquist2016-10-206-10/+11
|\ \ \ \ | | | | | | | | | | fixes for rubocop 0.44.1 engine
| * | | | fixes for rubocop 0.44.1 enginelcg/rubocop-0.44.1Lamont Granquist2016-10-206-10/+11
| | |_|/ | |/| | | | | | | | | | | | | | | | | | a few cops we have enabled got a little more accurate/stricter Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | Bump version of chef to 12.16.17 by Chef Versioner.v12.16.17Chef Versioner2016-10-204-8/+8
| | | |
* | | | Merge pull request #5481 from chef/lcg/node-testsLamont Granquist2016-10-201-0/+28
|\ \ \ \ | |_|/ / |/| | | Attributes: add tests for regression in 12.0 fixed recently
| * | | Attributes: add tests for regression in 12.0 fixed recentlyLamont Granquist2016-10-201-0/+28
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tests for the issue that led up to https://github.com/chef/chef/issues/5447 The Hash tests actually pass against 12.13.37 so it appearly that only broke the Immutable array objects in 12.0. This both explains why we didn't have any existing tests that caught it, and why it went uncaught for so long. It also adds some ammunition to the argument that fixing this in 12.14.x was not a major breaking change to users that had been relying on the buggy 12.0 behavior. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Bump version of chef to 12.16.16 by Chef Versioner.v12.16.16Chef Versioner2016-10-204-8/+8
| | |
* | | Merge pull request #5471 from chef/lcg/make-scm-password-sensitiveThom May2016-10-201-7/+1
|\ \ \ | |/ / |/| | convert svn_password to property + make sensitive
| * | the password is also not desired_statelcg/make-scm-password-sensitiveLamont Granquist2016-10-191-1/+1
| | | | | | | | | | | | | | | | | | should property-ize the rest of this as well Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | convert scm_password to property + make sensitiveLamont Granquist2016-10-191-7/+1
| | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | Bump version of chef to 12.16.15 by Chef Versioner.v12.16.15Chef Versioner2016-10-194-8/+8
| | |
* | | Merge pull request #5466 from pwalz/fix-crontab-rewritesLamont Granquist2016-10-191-1/+1
|\ \ \ | |/ / |/| | Cron Provider: Eliminate crontab rewrite that happens with every chef-client run
| * | Style fix - change single quotes to doublePeter Walz2016-10-181-1/+1
| | | | | | | | | | | | Signed-off-by: Peter Walz <pnw@umn.edu>
| * | Remove leading and trailing quotes when reading certain environment variablesPeter Walz2016-10-181-1/+1
| | | | | | | | | | | | | | | | | | | | | Fixes a side effect of #5127 where if a `cron` resource sets MAILTO, PATH, SHELL, or HOME, it gets updated with every chef-client run. Signed-off-by: Peter Walz <pnw@umn.edu>
* | | Bump version of chef to 12.16.14 by Chef Versioner.v12.16.14Chef Versioner2016-10-194-8/+8
| | |
* | | Merge pull request #5465 from chef/rhass/COOL-541_update-ec2-tagsTom Duffield2016-10-191-1/+3
|\ \ \ | | | | | | | | Update EC2 tags for internal standards compliance.
| * | | Update EC2 tags for internal standards compliance.rhass/COOL-541_update-ec2-tagsRyan Hass2016-10-181-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Signed-off-by: Ryan Hass <rhass@chef.io>
* | | | Bump version of chef to 12.16.13 by Chef Versioner.v12.16.13Chef Versioner2016-10-194-8/+8
| | | |
* | | | Merge pull request #5463 from chef/tm/last_json_deprecationsThom May2016-10-192-4/+5
|\ \ \ \ | | | | | | | | | | [Knife] Fix deprecation warning when creating data bag items
| * | | | Return a raw hash when creating objectstm/last_json_deprecationsThom May2016-10-182-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes chef/chef-vault#215 Signed-off-by: Thom May <thom@may.lt>
* | | | | Bump version of chef to 12.16.12 by Chef Versioner.v12.16.12Chef Versioner2016-10-194-8/+8
| | | | |
* | | | | Merge pull request #5464 from chef/lcg/less-global-stateLamont Granquist2016-10-182-1/+13
|\ \ \ \ \ | | | | | | | | | | | | remove dependency on Chef.run_context global state
| * | | | | feed chefstyleLamont Granquist2016-10-181-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | | add root_run_context to CHILD_STATElcg/less-global-stateLamont Granquist2016-10-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
| * | | | | remove dependency on Chef.run_context global stateLamont Granquist2016-10-182-1/+14
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | introduce run_context.root_run_context that avoids global state Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | | | | Bump version of chef to 12.16.11 by Chef Versioner.v12.16.11Chef Versioner2016-10-194-8/+8
| | | | |
* | | | | Merge pull request #5468 from chef/rhass/COOL-595_omnibus-dep-bumpLamont Granquist2016-10-181-6/+6
|\ \ \ \ \ | | | | | | | | | | | | Bump omnibus deps once more.
| * | | | | Bump omnibus deps once more.rhass/COOL-595_omnibus-dep-bumpRyan Hass2016-10-181-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Ryan Hass <rhass@chef.io>