comments are always good.

It's tough to understand this fix, thus putting some descriptive
comments.

1 files changed, 9 insertions, 0 deletions

diff --git a/lib/chef/util/windows/net_user.rb b/lib/chef/util/windows/net_user.rb
index 69f18d8dc6..256fdc5f24 100644
--- a/lib/chef/util/windows/net_user.rb
+++ b/lib/chef/util/windows/net_user.rb
@@ -37,6 +37,11 @@ class Chef::Util::Windows::NetUser < Chef::Util::Windows
   #[:symbol_name, default_val]
   #default_val duals as field type
   #array index duals as structure offset
+
+  #OC-8391
+  #Changing [:password, nil], to [:password, ""],
+  #if :password is set to nil, windows user creation api ignores the password policy applied
+  #thus initializing it with empty string value.
   USER_INFO_3 = [
     [:name, nil],
     [:password, ""],
@@ -183,6 +188,8 @@ class Chef::Util::Windows::NetUser < Chef::Util::Windows
   def disable_account
     user_modify do |user|
       user[:flags] |= UF_ACCOUNTDISABLE
+      #This does not set the password to nil. It (for some reason) means to ignore updating the field.
+      #please refer to https://github.com/jmccann/chef/commit/ff732aab4f7e79f215567bcc3dc4e4f7295207ee#commitcomment-3413715
       user[:password] = nil
     end
   end
@@ -190,6 +197,8 @@ class Chef::Util::Windows::NetUser < Chef::Util::Windows
   def enable_account
     user_modify do |user|
       user[:flags] &= ~UF_ACCOUNTDISABLE
+      #This does not set the password to nil. It (for some reason) means to ignore updating the field.
+      #please refer to https://github.com/jmccann/chef/commit/ff732aab4f7e79f215567bcc3dc4e4f7295207ee#commitcomment-3413715
       user[:password] = nil
     end
   end