diff options
| author | Martin Pool <mbp@samba.org> | 2002-02-21 00:45:48 +0000 |
|---|---|---|
| committer | Martin Pool <mbp@samba.org> | 2002-02-21 00:45:48 +0000 |
| commit | 7583ded808be86e0267a83b558892b29ee278e15 (patch) | |
| tree | 280dd21db9546c1cf270634aca25f1f6515769be /clientserver.c | |
| parent | 78818f44653a94a4eb1d157cc9c93f9a67d5a86c (diff) | |
| download | rsync-7583ded808be86e0267a83b558892b29ee278e15.tar.gz | |
Make setgroups(0,0) unconditional -- accidentally thinking we have
don't it on a machine that does have supplementary groups would be a
security hole. If this breaks anything we'll fix it later.
Diffstat (limited to 'clientserver.c')
| -rw-r--r-- | clientserver.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/clientserver.c b/clientserver.c index 2bab6aa9..93a1eefb 100644 --- a/clientserver.c +++ b/clientserver.c @@ -285,7 +285,6 @@ static int rsync_module(int fd, int i) } if (am_root) { -#ifdef HAVE_SETGROUPS /* Get rid of any supplementary groups this process * might have inheristed. */ if (setgroups(0, NULL)) { @@ -293,7 +292,6 @@ static int rsync_module(int fd, int i) io_printf(fd, "@ERROR: setgroups failed\n"); return -1; } -#endif /* XXXX: You could argue that if the daemon is started * by a non-root user and they explicitly specify a |