diff options
| author | Pavlina Moravcova Varekova <pmoravco@redhat.com> | 2019-07-29 08:37:13 +0200 |
|---|---|---|
| committer | Florian Festi <ffesti@redhat.com> | 2019-07-29 16:12:25 +0200 |
| commit | 7b76b2c0624492cd06d5d1d61f438beb1e4ef3be (patch) | |
| tree | f8a4b2ccef2fb437cda58b697b3c54440cac78d1 /scripts | |
| parent | 0fcf8c2b8692fbe06b0bb353247f9d70c91c14a1 (diff) | |
| download | rpm-7b76b2c0624492cd06d5d1d61f438beb1e4ef3be.tar.gz | |
Prefer '[] && []' to '[ -a ]' in test in find-debuginfo.sh (RhBug:1720590)
Spotted by covscan:
warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. [SC2166]
Originally introduced in commit 9aae21d.
Thanks to Florian Festi for spotting this and proposing the solution.
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/find-debuginfo.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh index 2e9d76531..295226023 100755 --- a/scripts/find-debuginfo.sh +++ b/scripts/find-debuginfo.sh @@ -213,7 +213,7 @@ if test -n "$build_id_seed" -a "$no_recompute_build_id" = "true"; then exit 2 fi -if [ "$strip_g" = "true" -a "$strip_glibs" = "true" ]; then +if [ "$strip_g" = "true" ] && [ "$strip_glibs" = "true" ]; then echo >&2 "*** ERROR: -g and --g-libs cannot be used together" exit 2 fi |