summaryrefslogtreecommitdiff
path: root/plugins
diff options
context:
space:
mode:
authorPanu Matilainen <pmatilai@redhat.com>2019-10-16 11:40:01 +0300
committerPanu Matilainen <pmatilai@redhat.com>2019-10-16 14:08:13 +0300
commit9b512ac829a01157feb45124d22e35747eff7125 (patch)
treef97f9c86bb06e584fe1eb90abc0f0eed5c28b255 /plugins
parent8671726738885f91f1eac725c8bbb76c9f433868 (diff)
downloadrpm-9b512ac829a01157feb45124d22e35747eff7125.tar.gz
Revert "Fully shutdown DBUS on systemd_inhibit cleanup (RhBug:1714657)"
Turns out this isn't a safe thing to do, as an API user could have their own dbus connections in the same process and shutting those down is a rather impolite thing to do (and causes crash, burn and other injuries, eg RhBug:1750575) This reverts commit d5f201345f6d27b6280750e5c6502f4418614fbc.
Diffstat (limited to 'plugins')
-rw-r--r--plugins/systemd_inhibit.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/plugins/systemd_inhibit.c b/plugins/systemd_inhibit.c
index 9cb722761..0ddca9cd8 100644
--- a/plugins/systemd_inhibit.c
+++ b/plugins/systemd_inhibit.c
@@ -82,11 +82,6 @@ static rpmRC systemd_inhibit_init(rpmPlugin plugin, rpmts ts)
return RPMRC_NOTFOUND;
}
-static void systemd_inhibit_cleanup(rpmPlugin plugin)
-{
- dbus_shutdown();
-}
-
static rpmRC systemd_inhibit_tsm_pre(rpmPlugin plugin, rpmts ts)
{
if (rpmtsFlags(ts) & (RPMTRANS_FLAG_TEST|RPMTRANS_FLAG_BUILD_PROBS))
@@ -113,7 +108,6 @@ static rpmRC systemd_inhibit_tsm_post(rpmPlugin plugin, rpmts ts, int res)
struct rpmPluginHooks_s systemd_inhibit_hooks = {
.init = systemd_inhibit_init,
- .cleanup = systemd_inhibit_cleanup,
.tsm_pre = systemd_inhibit_tsm_pre,
.tsm_post = systemd_inhibit_tsm_post,
};