summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOlaf Kirch <okir@suse.de>2008-09-30 14:43:13 -0400
committerSteve Dickson <steved@redhat.com>2008-09-30 14:43:13 -0400
commit62a20676c31a1887f8151a5b0ca42932205c4f4b (patch)
tree6871842042dd6bd47e05afa0d5cd3f9275ade389
parent3d9f63a9c308b305dfca745dafae63d8f96b313c (diff)
downloadrpcbind-62a20676c31a1887f8151a5b0ca42932205c4f4b.tar.gz
Fix debug output in pmap_set/unset
The debugging code in pmapproc_change prints the contents of the "struct pmap" argument before decoding it, which results in random garbage being displayed. Signed-off-by: Olaf Kirch <okir@suse.de> Signed-off-by: Steve Dickson <steved@redhat.com>
-rw-r--r--src/pmap_svc.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/pmap_svc.c b/src/pmap_svc.c
index 7a4f059..6562687 100644
--- a/src/pmap_svc.c
+++ b/src/pmap_svc.c
@@ -175,16 +175,16 @@ pmapproc_change(struct svc_req *rqstp /*__unused*/, SVCXPRT *xprt, unsigned long
uid_t uid;
char uidbuf[32];
+ if (!svc_getargs(xprt, (xdrproc_t) xdr_pmap, (char *)&reg)) {
+ svcerr_decode(xprt);
+ return (FALSE);
+ }
#ifdef RPCBIND_DEBUG
if (debugging)
fprintf(stderr, "%s request for (%lu, %lu) : ",
op == PMAPPROC_SET ? "PMAP_SET" : "PMAP_UNSET",
reg.pm_prog, reg.pm_vers);
#endif
- if (!svc_getargs(xprt, (xdrproc_t) xdr_pmap, (char *)&reg)) {
- svcerr_decode(xprt);
- return (FALSE);
- }
if (!check_access(xprt, op, &reg, PMAPVERS)) {
svcerr_weakauth(xprt);