diff options
| author | Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com> | 2020-04-08 17:11:18 +0200 |
|---|---|---|
| committer | Jean-Sébastien Pédron <jean-sebastien@rabbitmq.com> | 2020-04-09 10:21:19 +0200 |
| commit | e13fbe5519930c3726e3d711b27f9c7b84f53909 (patch) | |
| tree | 8c1267632dae4d82e6202b65bd1e1c99418c4622 | |
| parent | 63a533df6788abecbda5823080125ebe2812367d (diff) | |
| download | rabbitmq-server-git-e13fbe5519930c3726e3d711b27f9c7b84f53909.tar.gz | |
rabbit_feature_flags: Add a FIXME to try_to_write_enabled_feature_flags_list()
We need to handle concurrent calls to this function to avoid any issues
with parallel read/modify/write operations.
| -rw-r--r-- | src/rabbit_feature_flags.erl | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/rabbit_feature_flags.erl b/src/rabbit_feature_flags.erl index 0c3f2e182b..cf2715a724 100644 --- a/src/rabbit_feature_flags.erl +++ b/src/rabbit_feature_flags.erl @@ -1447,6 +1447,8 @@ try_to_write_enabled_feature_flags_list(FeatureNames) -> %% are unknown feature flags in that file, we want to keep their %% state, even though they are unsupported at this time. It could be %% that a plugin was disabled in the meantime. + %% + %% FIXME: Lock this code to fix concurrent read/modify/write. PreviouslyEnabled = case try_to_read_enabled_feature_flags_list() of {error, _} -> []; List -> List |