| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Use Q_FALLTHOUGH instead of comments, and use it consistently.
Change-Id: Ieaf4867b612e624774011275b90cdd3678a29fe9
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
|
|
|
|
|
| |
Change-Id: I92ab00eb63a5baac80c0ecc328141396bf7331bd
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
|
|
|
|
|
| |
Change-Id: I4f34c217bc997e24b0a13a432cb803d09f6fe314
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The previous fix, 82c5cc6532ac5d0323ecda94b6767e1fdaef2639, wasn't
handling properly double conversion to string, this change is rather
going through the characters instead. It also adds new test cases.
Task-number: QTBUG-58245
Change-Id: I1563d541b0c9fef1254b5fb728308fb2517ed3aa
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
|
|
|
|
|
|
|
| |
Added binary compatibility file for qtxmlpatterns
Change-Id: I4a879e0211635a5f69dd092d203651186cfd8f09
Reviewed-by: Sergio Ahumada <sahumada@texla.cl>
|
|\
| |
| |
| | |
Change-Id: I49449c321d5ca3df584db712409ed6677f548e9d
|
| |
| |
| |
| |
| | |
Change-Id: Ib834d859af93bf7541fad0609e2605b41ec98458
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
fractionDigits were counting also the trailing 0s, which is against the
standard https://www.w3.org/TR/xmlschema-2/#rf-fractionDigits
Task-number: QTBUG-58245
Change-Id: I9175d4870de82e25c4df2317394ccfba8048fb48
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
|
|/
|
|
| |
Change-Id: I688c3aaeeb12570544f3de32cb9585f8ebc5f74b
|
|\
| |
| |
| | |
Change-Id: Ib366f5432976104caca78f57e02990e6b91c61e2
|
| |\
| | |
| | |
| | | |
Change-Id: I71b83950080f0bd18f2bafbb675816a50fa06a28
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
the CI obtains them from the qt5 super repo nowadays.
Change-Id: If13877a687aba659675274e8a06be2ca9c9a50c9
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We can't have the ExpressionVariableReference/TemplateParameterReference
holding a Ptr of VariableDeclaration because the VariableDeclaration
holds a Ptr of them (in the references member) so they were referencing
eachother and the reference count never reaches 0.
Task-number: QTBUG-32745
Change-Id: I4cda6d9eccad123984f4ad35db3e56da01d4d5b1
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Amends 5a160606aefa5b07909faba55af53d1c95368486.
Change-Id: I4dd6523f4015922e4c5c76c5bf907e3f6c5b3b43
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix build warnings about missing qfeatures.
Change-Id: I577b78fcf2037877f15d87006e279e61e4d86945
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add script and update README of qtokenautomaton
accordingly.
Change-Id: If18167a413280c4b65d8fff49eb0aa3cf05eb23e
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Java-style iterators are slower than STL-style ones, so
they should not be used in library code.
Replaced them with STL iterator loops.
In one case, a QMutableHashIterator actually needn't be
mutable, so ported to const_iterator, like all others.
Change-Id: Ib7fd1fa5fca2df2c288a61925ee68a5df11caf62
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Java-style iterators are slower than STL-style ones, so they
should not be used in library code.
Replaced them with C++11 ranged for loops, adding qAsConst()
as needed.
Change-Id: I21b59daceafc62b94ebba56bfef1f050988b9c9f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In network-settings.h, replaced a few QList of static size with
C arrays.
Change-Id: Iac32e68f76e3c53fa03b6a2943e1dfb5adbe6fad
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I4fd97dcbc433aab9f2929c3336d7e26decbf634b
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
TargetNode::fieldsAreEqual() is symmetric, so diagonalize the
nested loops to avoid both checking for identity as well as
re-checking (A, B) if we already checked (B, A).
Change-Id: I67668415b1f509e6119ea61b76213700e8b49b56
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use QChar::unicode() instead.
Change-Id: Iaeff83259e4beb6672cf0da1657694b3903f3436
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fix warnings
In file included from .../qtbase/include/QtCore/qchar.h:1:0,
from .../qtbase/include/QtCore/../../src/corelib/tools/qstring.h:48,
from .../qtbase/include/QtCore/qstring.h:1,
from .../qtbase/include/QtCore/QString:1,
from schema/qxsdschematoken_p.h:56,
from schema/qxsdschematoken.cpp:42:
.../qtbase/include/QtCore/../../src/corelib/tools/qchar.h:586:1: note: declared here
schema/qxsdschematoken.cpp:1733:37: warning: 'constexpr typename std::enable_if<std::is_same<typename std::remove_cv< <template-parameter-1-1> >::type, int>::value, bool>::type operator==(QChar, T) [with T = int; typename std::enable_if<std::is_same<typename std::remove_cv< <template-parameter-1-1> >::type, int>::value, bool>::type = bool]' is deprecated: don't compare ints to QChars, compare them to QChar::unicode() instead [-Wdeprecated-declarations]
In file included from .../qtbase/include/QtCore/qchar.h:1:0,
from .../qtbase/include/QtCore/../../src/corelib/tools/qstring.h:48,
from .../qtbase/include/QtCore/qstring.h:1,
from .../qtbase/include/QtCore/QString:1,
from schema/qxsdschematoken_p.h:56,
from schema/qxsdschematoken.cpp:42:
.../qtbase/include/QtCore/../../src/corelib/tools/qchar.h:586:1: note: declared here
Change-Id: I1117cffac6e5b4d51a3f53818ac9c4e366b9d4ba
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
|
|\ \ \
| |/ /
| | |
| | | |
Change-Id: I7462160852a7e396cb060efa3b71e3cd56a04b73
|
| |\ \
| | |/
| | |
| | | |
Change-Id: If65b4b8c4b328f64ca21ffb289bb9c4b7cb48a9c
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Added binary compatibility data files for tst_bic test
Change-Id: I4cda6d9eccad1dec74f4ad35db3e56da01d4d5b1
Reviewed-by: Sergio Ahumada <sahumada@texla.cl>
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Added the generated data files for the binary compatibility tests
for QtXmlPatterns for Qt 5.7.
Change-Id: Ia64f5d943c91313182cb0cc6f743440b6bd53602
Reviewed-by: Sergio Ahumada <sahumada@texla.cl>
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
|
|\ \ \
| |/ /
| | |
| | | |
Change-Id: I624be339147ef7bd6889ee69be38bbd7b3e1714a
|
| |\ \
| | |/
| | |
| | | |
Change-Id: Id00802d52ac29efcabb422f0e48f20dcf9044d38
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Creating a URL like "file:fileToOpen=globals.gccxml" makes no sense,
and breaks QUrl::resolved since qtbase commit 8a33077.
Change-Id: Icab4fac92db2e7c3d922f548462c3345b8addd83
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | | |
Conflicts:
.qmake.conf
Change-Id: If96447854450a284f77e5ec087e76b866ef1bb06
|
| |\ \
| | |/
| | |
| | | |
Change-Id: I0653ca8dd6a9b6ee2314911c7679a1c056dc3709
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
m_resourceLoader is a QExplicitlySharedPointer<DeviceResourceLoader>, and
ResourceDelegator inherits DeviceResourceLoader, but the newly-allocated
object was constructed into a QExplicitlySharedPointer<ResourceLoader>.
Benign, but wrong. Found while trying to compile the module without
QT_ENABLE_QEXPLICITLYSHAREDDATAPOINTER_STATICCAST.
Change-Id: I6f0e7bd50488ae6db6ab6c7022503332cd8523f1
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As reported by UBSan:
src/corelib/tools/qshareddata.h:167:13: runtime error: downcast of address 0x0000023ce510 which does not point to an object of type 'DayTimeDuration'
0x0000023ce510: note: object is of type 'QPatternist::YearMonthDuration'
00 00 00 00 90 6c 52 5b 1f 2b 00 00 01 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 31 00 00 00
^~~~~~~~~~~~~~~~~~~~~~~
vptr for 'QPatternist::YearMonthDuration'
Another victim of QT_ENABLE_QEXPLICITLYSHAREDDATAPOINTER_STATICCAST...
Change-Id: I121433e0d2ad8b203ccf9d9f08bd166b39502cbb
Reviewed-by: Tobias Koenig <tobias.koenig@kdab.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As reported by UBSan:
qtbase/src/corelib/tools/qshareddata.h:167:13: runtime error: downcast of address 0x2ac9a801a410 which does not point to an object of type 'GenericStaticContext'
0x2ac9a801a410: note: object is of type 'QPatternist::StaticFocusContext'
00 00 00 00 28 95 b7 9d c9 2a 00 00 01 00 00 00 c9 2a 00 00 f0 a1 01 a8 c9 2a 00 00 70 fa 0b 02
^~~~~~~~~~~~~~~~~~~~~~~
vptr for 'QPatternist::StaticFocusContext'
I had no idea how the QExplicitlySharedDataPointer conversion
could ever compile, until I saw that this module defines
QT_ENABLE_QEXPLICITLYSHAREDDATAPOINTER_STATICCAST
which is, of course, utterly broken.
Change-Id: Ie392ba74438b6c75fde9fabe09f9b0e655489cd9
Reviewed-by: Tobias Koenig <tobias.koenig@kdab.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: I32927731c73b5335f2589c0754ffef2cf0d5ed3f
Reviewed-by: Tobias Koenig <tobias.koenig@kdab.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As reported by UBSan:
xmlpatterns/expr/qorderby_p.h:78:15: runtime error: load of value 11181584, which is not a valid value for type 'Direction'
xmlpatterns/expr/qorderby_p.h:78:15: runtime error: load of value 32766, which is not a valid value for type 'OrderingEmptySequence'
xmlpatterns/schema/qxsdstatemachine_p.h:66:11: runtime error: load of value 2979516404, which is not a valid value for type 'NodeName'
xmlpatterns/schema/qxsdschemaparser.cpp:340:67: runtime error: load of value 40, which is not a valid value for type 'bool'
The init values are chosen to match what zero-initialization
would have chosen.
Change-Id: Iaf69720476cfe6c117dc2c91f39801a0be8bde54
Reviewed-by: Tobias Koenig <tobias.koenig@kdab.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
GCC's undefined-behavior sanitizer checks that the
declared type of the object is a base class of the
dynamic type of the object on each access to a
member of a class type.
It therefore requires the typeinfo for these types,
which for polymorphic types is emitted in the TU
where the vtable is emitted, too.
QtPatternist::AtomicValue is a polymorphic non-
exported class, so this failed at link-time. Ditto
for the other cases.
Fix by autotest-exporting the classes.
Also, where applicable, de-inline the dtors, so the
vtable (and typeinfo) are pinned to one TU.
Change-Id: I5c47be779a3833433a7108a79a57d61a93ab5494
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This bit of error handling is actually not checking what was originally
intended - doing manual pluralization of the error message.
Fix it to at least compile with -Werror (gcc 6.1.1).
parser/qmaintainingreader_tpl_p.h:204:26: error: duplicated ‘if’ condition [-Werror=duplicated-cond]
Change-Id: Ia81ad3c8c1393d08da0a229c4625504faf56c184
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
|
| | |
| | |
| | |
| | | |
Change-Id: I22e272219f6ee9ca874c981f60a8ef3c1972e8bb
|
|\ \ \
| |/ /
| | |
| | | |
Change-Id: Ib03766c50f8ecf7c8acc52eff9a721efeef10825
|
| |\ \
| | |/
| | |
| | | |
Change-Id: I0b372947924113abfb00d77a655d71c43324ef99
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
See http://comments.gmane.org/gmane.comp.lib.qt.devel/25771
Change-Id: Ibe92a94aa0812c01c99b16391605c30068225a83
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Coverity (CID 22275) pointed out it wasn't initialized in the
constructor. It isn't even accessed; and the method that sets it
claims the parameter it sets it to is unused. So just remove it.
Change-Id: Id48f45a89b7a2d3d44e92b785d425592f1bc6467
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As pointed out by Coverity (CID 22378).
Change-Id: Ibeb06c49b8ead1925bc0377bcaef6109f7f8e53c
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
it's done centrally now.
Change-Id: Ie60ba6b42399c100745e8f5856749311bb30dde2
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |\ \
| | | |
| | | |
| | | | |
Change-Id: I0c1e5104f8300e9edf6a6b6cbab0e4ee6af4e315
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: If926a689cf167c12ea2fdc9a8ee2f4d9f4c16d49
Task-number: QTBUG-53913
Reviewed-by: Sami Makkonen <sami.makkonen@qt.io>
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I97a0e33e1f42ffe8662ba961dc1b1366dd831782
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Simplify long and strange 'if(){return} else if () {return} else {return }
dead_code; return' - as suggested by Coverity, CID 21875.
Change-Id: I8a28b14003c6a533237163e44a549ac374344946
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
|