diff options
author | Sami Rosendahl <ext-sami.1.rosendahl@nokia.com> | 2012-01-24 10:43:25 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-02-01 13:42:28 +0100 |
commit | f42f82f435d738339ad85c1380d1167338517247 (patch) | |
tree | 8d1c68a9e32aea78cd54538ea284b92c118e199e /tools | |
parent | 2772027a20551d26364c2816e51fcabb20773e74 (diff) | |
download | qtxmlpatterns-f42f82f435d738339ad85c1380d1167338517247.tar.gz |
Fix access to uninitialized values in QtXmlPatterns
Fixes valgrind warning like below when executing tst_QXmlQuery::copyConstructor()
Conditional jump or move depends on uninitialised value(s)
at: QPatternist::NodeIndexStorage::operator!=(QPatternist::NodeIndexStorage const&) const (qabstractxmlnodemodel.cpp:1220)
by: QXmlItem::operator=(QXmlItem const&) (qabstractxmlnodemodel.cpp:1228)
Reason for the warning is that QPatternist::NodeIndexStorage::operator!=
accesses all fields of NodeIndexStorage, which are all not intialized in
every execution path of QXmlItem::QXmlItem(const QVariant &) and class
QPatternist::Item constructors.
Fixed by adding NodeIndexStorage::reset() function that resets all fields
and put a call to that function where NodeIndexStorage objects were
previously incompletely initialized. Note that unfortunately class
NodeIndexStorage cannot have a default constructor, because it is used as
a union field.
Change-Id: I758df57551ec49ce8c8b357794177b4e6c454d2f
Sanity-Review: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Dmitry Trofimov
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions