summaryrefslogtreecommitdiff
path: root/tests/auto/qabstractxmlnodemodel
diff options
context:
space:
mode:
authorJason McDonald <jason.mcdonald@nokia.com>2011-05-05 17:36:59 +1000
committerRohan McGovern <rohan.mcgovern@nokia.com>2011-05-18 11:04:38 +1000
commit10ea2f65241baf8f414ab9dc1c52d9fdb5103c68 (patch)
tree3216ee5090441138dd990787795654d3373d8ddd /tests/auto/qabstractxmlnodemodel
parente80ce483655c5a01f6fae73a623332535ba961c0 (diff)
downloadqtxmlpatterns-10ea2f65241baf8f414ab9dc1c52d9fdb5103c68.tar.gz
Remove Q_ASSERT from qabstractxmlnodemodel test
When no content can be loaded to create the model, return a null model (which will make the test fail gracefully) rather than aborting in a debug build and failing silently in a release build. Change-Id: I28f0bb92c617c8dafd1089d0b3dafcfef0c0da53 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern (cherry picked from commit 416d45caa9feefe8337795adc4b93a8148d57a3a)
Diffstat (limited to 'tests/auto/qabstractxmlnodemodel')
-rw-r--r--tests/auto/qabstractxmlnodemodel/LoadingModel.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/auto/qabstractxmlnodemodel/LoadingModel.cpp b/tests/auto/qabstractxmlnodemodel/LoadingModel.cpp
index 054fd69..cf85486 100644
--- a/tests/auto/qabstractxmlnodemodel/LoadingModel.cpp
+++ b/tests/auto/qabstractxmlnodemodel/LoadingModel.cpp
@@ -53,7 +53,6 @@ LoadingModel::LoadingModel(const Node::Vector &content,
const QXmlNamePool &np) : QSimpleXmlNodeModel(np)
, m_nodes(content)
{
- Q_ASSERT(!content.isEmpty());
/*
foreach(const Node *n, content)
qDebug() << "this:" << n
@@ -354,6 +353,11 @@ QAbstractXmlNodeModel::Ptr LoadingModel::create(const QXmlNamePool &np)
{
Loader loader(np);
loader.load();
+ if (loader.m_result.isEmpty()) {
+ qWarning("%s: attempt to create model with no content", Q_FUNC_INFO);
+ return Ptr(0);
+ }
+
return Ptr(new LoadingModel(loader.m_result, np));
}
#endif //QTEST_XMLPATTERNS