diff options
| author | Albert Astals Cid <albert.astals@canonical.com> | 2016-10-27 17:43:43 +0200 |
|---|---|---|
| committer | Albert Astals Cid <albert.astals@canonical.com> | 2016-11-02 09:21:50 +0000 |
| commit | 6b6f7db32e7c9ca4bdda0341994dca1212b53e20 (patch) | |
| tree | 26e2790d4f8dec77e162ffeeeb9c407839e0cc40 /src/xmlpatterns/parser/qquerytransformparser.cpp | |
| parent | 66be7fd267fa432f79a9f2bb6edc6a76285a7f39 (diff) | |
| download | qtxmlpatterns-6b6f7db32e7c9ca4bdda0341994dca1212b53e20.tar.gz | |
Fix memory leak
We can't have the ExpressionVariableReference/TemplateParameterReference
holding a Ptr of VariableDeclaration because the VariableDeclaration
holds a Ptr of them (in the references member) so they were referencing
eachother and the reference count never reaches 0.
Task-number: QTBUG-32745
Change-Id: I4cda6d9eccad123984f4ad35db3e56da01d4d5b1
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
Diffstat (limited to 'src/xmlpatterns/parser/qquerytransformparser.cpp')
| -rw-r--r-- | src/xmlpatterns/parser/qquerytransformparser.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/xmlpatterns/parser/qquerytransformparser.cpp b/src/xmlpatterns/parser/qquerytransformparser.cpp index 5497fb8..fe2c3bb 100644 --- a/src/xmlpatterns/parser/qquerytransformparser.cpp +++ b/src/xmlpatterns/parser/qquerytransformparser.cpp @@ -1086,7 +1086,7 @@ static Expression::Ptr resolveVariable(const QXmlName &name, * mechanism must. */ case VariableDeclaration::ExpressionVariable: { - retval = create(new ExpressionVariableReference(var->slot, var), sourceLocator, parseInfo); + retval = create(new ExpressionVariableReference(var->slot, var.data()), sourceLocator, parseInfo); break; } case VariableDeclaration::FunctionArgument: @@ -1101,7 +1101,7 @@ static Expression::Ptr resolveVariable(const QXmlName &name, } case VariableDeclaration::TemplateParameter: { - retval = create(new TemplateParameterReference(var), sourceLocator, parseInfo); + retval = create(new TemplateParameterReference(var.data()), sourceLocator, parseInfo); break; } case VariableDeclaration::ExternalVariable: |