diff options
| author | Kurt Pattyn <pattyn.kurt@gmail.com> | 2014-01-25 20:09:24 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-02-01 17:01:19 +0100 |
| commit | 4a82737e06cf89b7293425952906416729fffbc7 (patch) | |
| tree | 797850e05d3f90c3cecb7389f7df45b33b5e6308 | |
| parent | 33e2f4e5715f5f3c83ebd08eea682890d81f9403 (diff) | |
| download | qtwebsockets-4a82737e06cf89b7293425952906416729fffbc7.tar.gz | |
Add TODOs for improvements
Change-Id: Ifc8cef479147de9fdd9c382ff09be21056cb3e68
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
| -rw-r--r-- | src/websockets/qwebsocket_p.cpp | 2 | ||||
| -rw-r--r-- | src/websockets/qwebsockethandshakeresponse.cpp | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/src/websockets/qwebsocket_p.cpp b/src/websockets/qwebsocket_p.cpp index 41c37eb..5d64f8f 100644 --- a/src/websockets/qwebsocket_p.cpp +++ b/src/websockets/qwebsocket_p.cpp @@ -148,6 +148,7 @@ QWebSocketPrivate::QWebSocketPrivate(QTcpSocket *pTcpSocket, QWebSocketProtocol: void QWebSocketPrivate::init() { Q_ASSERT(q_ptr); + //TODO: need a better randomizer qsrand(static_cast<uint>(QDateTime::currentMSecsSinceEpoch())); } @@ -739,6 +740,7 @@ qint64 QWebSocketPrivate::doWriteFrames(const QByteArray &data, bool isBinary) */ quint32 QWebSocketPrivate::generateRandomNumber() const { + //TODO: need a better randomizer return quint32((double(qrand()) / RAND_MAX) * std::numeric_limits<quint32>::max()); } diff --git a/src/websockets/qwebsockethandshakeresponse.cpp b/src/websockets/qwebsockethandshakeresponse.cpp index cc1844d..37c0636 100644 --- a/src/websockets/qwebsockethandshakeresponse.cpp +++ b/src/websockets/qwebsockethandshakeresponse.cpp @@ -150,6 +150,8 @@ QString QWebSocketHandshakeResponse::getHandshakeResponse( const QString acceptKey = calculateAcceptKey(request.key()); const QList<QString> matchingProtocols = supportedProtocols.toSet().intersect(request.protocols().toSet()).toList(); + //TODO: extensions must be kept in the order in which they arrive + //cannot use set.intersect() to get the supported extensions const QList<QString> matchingExtensions = supportedExtensions.toSet().intersect(request.extensions().toSet()).toList(); QList<QWebSocketProtocol::Version> matchingVersions = |