summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergio Ahumada <sahumada@blackberry.com>2014-03-01 17:16:43 +0100
committerThe Qt Project <gerrit-noreply@qt-project.org>2014-03-01 21:46:40 +0100
commit06c27bdb5e90445b6ab89ea4315b3af235826152 (patch)
tree784e91411d6d77d7a4397ad8da9d405d73d0e8f8
parentcb52b7857ce0a4cc5448d0abfabb62090933439e (diff)
downloadqtwebsockets-06c27bdb5e90445b6ab89ea4315b3af235826152.tar.gz
Use const & for your foreach variables
Change-Id: I6096111284f02f07e1e7864b8795236563d4f6c1 Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
-rw-r--r--src/websockets/qwebsockethandshakeresponse.cpp2
-rw-r--r--tests/manual/websockets/tst_websockets.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/websockets/qwebsockethandshakeresponse.cpp b/src/websockets/qwebsockethandshakeresponse.cpp
index d244000..aa9a881 100644
--- a/src/websockets/qwebsockethandshakeresponse.cpp
+++ b/src/websockets/qwebsockethandshakeresponse.cpp
@@ -207,7 +207,7 @@ QString QWebSocketHandshakeResponse::getHandshakeResponse(
if (Q_UNLIKELY(!m_canUpgrade)) {
response << QStringLiteral("HTTP/1.1 400 Bad Request");
QStringList versions;
- Q_FOREACH (QWebSocketProtocol::Version version, supportedVersions)
+ Q_FOREACH (const QWebSocketProtocol::Version &version, supportedVersions)
versions << QString::number(static_cast<int>(version));
response << QStringLiteral("Sec-WebSocket-Version: ")
% versions.join(QStringLiteral(", "));
diff --git a/tests/manual/websockets/tst_websockets.cpp b/tests/manual/websockets/tst_websockets.cpp
index c2fbc6b..b9a7f5e 100644
--- a/tests/manual/websockets/tst_websockets.cpp
+++ b/tests/manual/websockets/tst_websockets.cpp
@@ -169,7 +169,7 @@ void tst_WebSocketsTest::testPeerAddress()
QVERIFY(addresses.length() > 0);
QHostAddress peer = m_pWebSocket->peerAddress();
bool found = false;
- Q_FOREACH(QHostAddress a, addresses)
+ Q_FOREACH (const QHostAddress &a, addresses)
{
if (a == peer)
{