summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Alpert <alan.alpert@bluescape.com>2017-08-22 00:09:54 (GMT)
committerLiang Qi <liang.qi@qt.io>2017-08-29 17:56:14 (GMT)
commitdad63663fcc6590353ec426337b0126b967da173 (patch)
treed81659b8e9f302181d3c17ffbdf1ca4f24dbabf1
parentfb71c823a7ae823345518ca33ccfe273fcf76494 (diff)
downloadqtwebsockets-dad63663fcc6590353ec426337b0126b967da173.tar.gz
Fix releaseConnections
The overload selected when you pass a single object pointer is to disconnect all signals with that object as a receiver. We want to disconnect all signals with that object as a sender, which is done most easily by passing no explicit arguments. Task-number: QTBUG-62667 Change-Id: I3dd9c5aced9160510bff527355ecfbedded690aa Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io> Reviewed-by: Romain Pokrzywka <romain.pokrzywka@gmail.com> Reviewed-by: Liang Qi <liang.qi@qt.io>
-rw-r--r--src/websockets/qwebsocket_p.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/websockets/qwebsocket_p.cpp b/src/websockets/qwebsocket_p.cpp
index f36056c..11b33c5 100644
--- a/src/websockets/qwebsocket_p.cpp
+++ b/src/websockets/qwebsocket_p.cpp
@@ -633,7 +633,7 @@ void QWebSocketPrivate::makeConnections(const QTcpSocket *pTcpSocket)
void QWebSocketPrivate::releaseConnections(const QTcpSocket *pTcpSocket)
{
if (Q_LIKELY(pTcpSocket))
- pTcpSocket->disconnect(pTcpSocket);
+ pTcpSocket->disconnect();
m_dataProcessor.disconnect();
}