diff options
| author | Simon Hausmann <simon.hausmann@digia.com> | 2012-10-16 14:56:46 +0200 |
|---|---|---|
| committer | Simon Hausmann <simon.hausmann@digia.com> | 2012-10-16 14:57:30 +0200 |
| commit | b297e0fa5c217c9467033b7c8b46891a52870120 (patch) | |
| tree | 43fc14689295e9e64f2719d05aad94e3049f6cd7 /Source/WebKit/chromium | |
| parent | 69d517dbfa69903d8593cc1737f0474b21e3251e (diff) | |
| download | qtwebkit-b297e0fa5c217c9467033b7c8b46891a52870120.tar.gz | |
Revert "Imported WebKit commit 0dc6cd75e1d4836eaffbb520be96fac4847cc9d2 (http://svn.webkit.org/repository/webkit/trunk@131300)"
This reverts commit 5466563f4b5b6b86523e3f89bb7f77e5b5270c78.
Caused OOM issues on some CI machines :(
Diffstat (limited to 'Source/WebKit/chromium')
192 files changed, 21719 insertions, 24255 deletions
diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog index 7627a4e48..4a3edec9e 100644 --- a/Source/WebKit/chromium/ChangeLog +++ b/Source/WebKit/chromium/ChangeLog @@ -1,539 +1,3979 @@ -2012-10-14 Sam Weinig <sam@webkit.org> +2012-09-25 Alpha Lam <hclam@chromium.org> - Make UserScript and UserStyleSheet value objects that are copyable - https://bugs.webkit.org/show_bug.cgi?id=99275 + Unreviewed. Roll DEPS for Chromium. - Reviewed by Tim Horton. + * DEPS: + +2012-09-25 Beth Dakin <bdakin@apple.com> + + https://bugs.webkit.org/show_bug.cgi?id=95397 + Need to merge didFirstVisuallyNonEmptyLayout and + didNewFirstVisuallyNonEmptyLayout + -and corresponding- + <rdar://problem/10791680> + + Reviewed by Sam Weinig. + Remove dispatchDidFirstLayout, + dispatchDidFirstVisuallyNonEmptyLayout, and + dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality + is now replaced by dispatchDidLayout(LayoutMilestoneOptions) + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::dispatchDidLayout): + * src/FrameLoaderClientImpl.h: + (FrameLoaderClientImpl): + + It is now necessary to opt into getting any of the + "layout milestone" notifications. + * src/WebHelperPluginImpl.cpp: + (WebKit::WebHelperPluginImpl::initPage): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::initPage): * src/WebViewImpl.cpp: - (WebKit::WebView::addUserScript): - (WebKit::WebView::addUserStyleSheet): - Update for new PageGroup function signatures. + (WebKit::WebViewImpl::WebViewImpl): -2012-10-12 Adam Barth <abarth@webkit.org> +2012-09-25 Joshua Bell <jsbell@chromium.org> - [Chromium] Remove used frameForEnteredContext API - https://bugs.webkit.org/show_bug.cgi?id=99201 + IndexedDB: One transaction coordinator per database + https://bugs.webkit.org/show_bug.cgi?id=97501 - Reviewed by Eric Seidel. + Reviewed by Tony Chang. - No one in Chromium-land understands the difference between - frameForEnteredContext and frameForCurrentContext. Rather than give - folks a confusing choice, let's just expose the one we most often want - to use. + Remove obsolete argument. - I've already removed all callers of frameForEnteredContext downstream. + * tests/IDBDatabaseBackendTest.h: - * public/WebFrame.h: - * src/WebFrameImpl.cpp: +2012-09-25 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r129517. + http://trac.webkit.org/changeset/129517 + https://bugs.webkit.org/show_bug.cgi?id=97582 + + Link errors in chromium (Requested by alecf on #webkit). + + * public/WebUserMediaRequest.h: + (WebUserMediaRequest): + * src/WebUserMediaRequest.cpp: + +2012-09-25 Dominic Mazzoni <dmazzoni@google.com> + + AX: Chromium doesn't pass accessibility text range and line number tests + https://bugs.webkit.org/show_bug.cgi?id=97246 + + Reviewed by Chris Fleizach. + + Use improved implementation of AccessibilityRenderObject::lineBreaks + and implement methods to get the line number of the selection and + to set the text range. + + Enables four existing tests to pass on Chromium: + Tests: accessibility/textarea-insertion-point-line-number.html + accessibility/textarea-line-for-index.html + accessibility/textarea-selected-text-range.html + accessibility/textbox-role-reports-selection.html + + * public/WebAccessibilityObject.h: + (WebAccessibilityObject): + * src/WebAccessibilityObject.cpp: + (WebKit::WebAccessibilityObject::selectionEndLineNumber): (WebKit): + (WebKit::WebAccessibilityObject::selectionStartLineNumber): + (WebKit::WebAccessibilityObject::setSelectedTextRange): + (WebKit::WebAccessibilityObject::lineBreaks): -2012-10-12 Joshua Bell <jsbell@chromium.org> +2012-09-25 Tommy Widenflycht <tommyw@google.com> - [Chromium] IndexedDB: WebKit API plumbing to pass abort reason code/message to script - https://bugs.webkit.org/show_bug.cgi?id=99193 + MediaStream API: Update getUserMedia to match the latest specification + https://bugs.webkit.org/show_bug.cgi?id=97540 Reviewed by Adam Barth. - Add database error (code, message) to payload for back-end to front-end abort call, - so that scripts can determine why the abort occurred - e.g. ConstraintError during - indexing. This API change allows the Chromium plumbing to land; the real implementation - is in http://webkit.org/b/99097 and will land later. + http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia + Navigator.getUserMedia is changed so that the audio and video members can either + be a bool or a constraints object. - * public/WebIDBTransactionCallbacks.h: + * public/WebUserMediaRequest.h: (WebKit): - (WebIDBTransactionCallbacks): - (WebKit::WebIDBTransactionCallbacks::onAbort): + (WebUserMediaRequest): + * src/WebUserMediaRequest.cpp: + (WebKit::WebUserMediaRequest::audioConstraints): + (WebKit): + (WebKit::WebUserMediaRequest::videoConstraints): + +2012-09-24 Andrey Kosyakov <caseq@chromium.org> + + [chromium] adding a page overlay causes endless update loop when accelerated compositing is used + https://bugs.webkit.org/show_bug.cgi?id=97466 -2012-10-12 Sheriff Bot <webkit.review.bot@gmail.com> + Reviewed by James Robinson. + + Do not update overlays in composite() -- doing so ultimately causes invalidation + of the view, hence another update and another call do composite(). Overlays should be + updated only when their content changes. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::composite): + +2012-09-21 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: extract Vector instrumentation from core NMI code into MemoryInstrumentationVector.h header. + https://bugs.webkit.org/show_bug.cgi?id=96650 + + Reviewed by Vsevolod Vlasov. + + Test for instrumented vector. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::InstrumentedOwner::InstrumentedOwner): + (WebCore::TEST): + (WebCore): + +2012-09-24 Benjamin Poulain <bpoulain@apple.com> + + Fix Geolocation error reporting in the test support + https://bugs.webkit.org/show_bug.cgi?id=97386 + + Reviewed by Sam Weinig. + + * public/WebGeolocationClientMock.h: + (WebGeolocationClientMock): + * src/WebGeolocationClientMock.cpp: + (WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError): + +2012-09-24 Kent Tamura <tkent@chromium.org> + + [Chromium] Implement ValidationMessageClient for Chromium + https://bugs.webkit.org/show_bug.cgi?id=97167 + + Reviewed by Hajime Morita. + + Introduce ValidationMessageClientImpl. However actual popup + implementation should be done in WebViewClient. + + * WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}. + * public/WebViewClient.h: + (WebKit::WebViewClient::showValidationMessage): Added. + (WebKit::WebViewClient::hideValidationMessage): Added. + * src/ValidationMessageClientImpl.cpp: Added. + (WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl): + (WebKit::ValidationMessageClientImpl::create): + (WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl): + Make sure that a popup is closed. + (WebKit::ValidationMessageClientImpl::showValidationMessage): + Implementataion of ValidationMessageClient::showValidationMessage. + minimumSecondToShowValidationMessage and secondPerCharacter are same as + the corresponding values in the current Shadow DOM implementation. + (WebKit::ValidationMessageClientImpl::hideValidationMessage): + Implementataion of ValidationMessageClient::hideValidationMessage. + (WebKit::ValidationMessageClientImpl::isValidationMessageVisible): + Implementataion of ValidationMessageClient::isValidationMessageVisible. + (WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage): + This is a callback function for the timer. + * src/ValidationMessageClientImpl.h: Added. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + - Initialize m_validationMessage. + - Add a comment for PageClients. + * src/WebViewImpl.h: + Add m_validationMessage. + +2012-09-24 Mihai Parparita <mihaip@chromium.org> + + [Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled} + https://bugs.webkit.org/show_bug.cgi?id=97506 + + Reviewed by Adam Barth. + + These methods have been no-ops since r127674. All Chromium code that + called them was removed with http://crrev.com/155205. + + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): + * src/WebRuntimeFeatures.cpp: + +2012-09-24 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium][Mac] Remove loadFont from PlatformSupport + https://bugs.webkit.org/show_bug.cgi?id=97360 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-09-24 Tony Chang <tony@chromium.org> Unreviewed. Rolled DEPS. * DEPS: -2012-10-12 Sheriff Bot <webkit.review.bot@gmail.com> +2012-09-24 Dana Jansens <danakj@chromium.org> + + [chromium] Add setters to WebFilterOperation for IPC pickling + https://bugs.webkit.org/show_bug.cgi?id=97147 + + Reviewed by James Robinson. + + * tests/FilterOperationsTest.cpp: + (WebKit): + (WebKit::TEST): + +2012-09-24 Patrick Gansterer <paroga@webkit.org> + + Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files + https://bugs.webkit.org/show_bug.cgi?id=97412 + + Reviewed by Adam Barth. + + * src/WebPageSerializerImpl.cpp: + (WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append(). + (WebKit::WebPageSerializerImpl::endTagToString): Ditto. + +2012-09-24 Yury Semikhatsky <yurys@chromium.org> + + Unreviewed, rolling out r122243. + http://trac.webkit.org/changeset/129243 + https://bugs.webkit.org/show_bug.cgi?id=97441 + + WebFilterOperationsTest.saveAndRestore added in the change is failing. + + * tests/FilterOperationsTest.cpp: + +2012-09-23 Keishi Hattori <keishi@webkit.org> + + Add suggestionPicker to CalendarPicker + https://bugs.webkit.org/show_bug.cgi?id=97201 + + Reviewed by Kent Tamura. + + * src/DateTimeChooserImpl.cpp: + (WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args. + +2012-09-21 Kenichi Ishibashi <bashi@chromium.org> + + [Chromium] Use OpenTypeVerticalData on Linux + https://bugs.webkit.org/show_bug.cgi?id=97277 + + Reviewed by Tony Chang. + + * features.gypi: Enable OPENTYPE_VERTICAL on linux and android. + +2012-09-21 Dirk Pranke <dpranke@chromium.org> + + Roll Chromium DEPS to r158095 to pick up typo fix in test_expectations.txt + + Unreviewed, rolled DEPS. + + * DEPS: + +2012-09-21 Dirk Pranke <dpranke@chromium.org> + + Roll Chromium DEPS to r158060 + + Unreviewed, rolled DEPS. + + * DEPS: + +2012-09-21 Chris Rogers <crogers@google.com> + + Add Web Audio support for deprecated/legacy APIs + https://bugs.webkit.org/show_bug.cgi?id=97050 + + Reviewed by Eric Carlson. + + * features.gypi: + +2012-09-21 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] remove getFontFamilyForCharacters from PlatformSupport + https://bugs.webkit.org/show_bug.cgi?id=96282 + + Reviewed by Tony Chang. + + Migrating away from PlatformSupport. getFontFamilyForCharacters is + moved to FontCache.h and overridden by the two platforms that + need it (Chromium Linux and Blackberry). New files for the overrides. + Part of a larger refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-09-21 Dana Jansens <danakj@chromium.org> + + [chromium] Add setters to WebFilterOperation for IPC pickling + https://bugs.webkit.org/show_bug.cgi?id=97147 + + Reviewed by James Robinson. + + * tests/FilterOperationsTest.cpp: + (WebKit): + (WebKit::TEST): + +2012-09-21 Tony Chang <tony@chromium.org> + + [chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico. + + * WebKit.gyp: + +2012-09-21 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed. Rolled DEPS. * DEPS: -2012-10-11 Kenichi Ishibashi <bashi@chromium.org> +2012-09-21 Sami Kyostila <skyostil@chromium.org> - [Chromium] Use harfbuzz-ng by default on Linux - https://bugs.webkit.org/show_bug.cgi?id=97281 + [chromium] Add test for ScrollingCoordinatorChromium + https://bugs.webkit.org/show_bug.cgi?id=96657 + + Reviewed by James Robinson. + + Add tests for ScrollingCoordinatorChromium. These tests mainly verify that + fast (non-main thread) scrolling is enabled when necessary and that a proper + compositing layer structure is created for fixed position and accelerated + scrolling layers. + + Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault + ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition + ScrollingCoordinatorChromiumTest.nonFastScrollableRegion + ScrollingCoordinatorChromiumTest.wheelEventHandler + ScrollingCoordinatorChromiumTest.touchOverflowScrolling + + * WebKit.gypi: + * tests/ScrollingCoordinatorChromiumTest.cpp: Added. + (WebKit): + (MockWebViewClient): + (ScrollingCoordinatorChromiumTest): + (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest): + (WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl): + (WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad): + (WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer): + (WebKit::TEST_F): + * tests/data/fixed_position.html: Added. + * tests/data/non_fast_scrollable.html: Added. + * tests/data/touch_overflow_scrolling.html: Added. + * tests/data/wheel_event_handler.html: Added. + +2012-09-20 Peter Beverloo <peter@chromium.org> + + Leverage Chromium's code to set up FIFOs for Chromium Android layout tests + https://bugs.webkit.org/show_bug.cgi?id=97227 Reviewed by Tony Chang. - * features.gypi: Enable WTF_USE_HARFBUZZ_NG when use_x11 == 1. + Remove all fifo-related code together with the io_stream_forwarder_android + target defined in WebKitUnitTests.gyp. + + * WebKitUnitTests.gyp: + * tests/ForwardIOStreamsAndroid.cpp: Removed. + * tests/ForwardIOStreamsAndroid.h: Removed. + * tests/RunAllTests.cpp: + (main): -2012-10-11 Nat Duca <nduca@chromium.org> +2012-09-21 Peter Beverloo <peter@chromium.org> - Expose high-resolution on requestAnimationFrame callback - https://bugs.webkit.org/show_bug.cgi?id=66683 + Unreviewed. Rolled DEPS. + + * DEPS: - This changes requestAnimationFrame's animationStartTime argument - to be a high resolution DOM timestamp, per disucssion here: - http://lists.w3.org/Archives/Public/public-web-perf/2012Apr/0004.html +2012-09-21 Keishi Hattori <keishi@webkit.org> + + Add datalist suggestions into DateTimeChooserParameters + https://bugs.webkit.org/show_bug.cgi?id=97292 + + Reviewed by Kent Tamura. + + * src/DateTimeChooserImpl.cpp: + (WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker. + +2012-09-20 Tony Chang <tony@chromium.org> + + [chromium] Unreviewed build fix. webkit_unit_tests have global constructors. + + * WebKitUnitTests.gyp: Remove -Wglobal-constructors. + +2012-09-20 Tony Chang <tony@chromium.org> + + [chromium] Enable more clang warnings + https://bugs.webkit.org/show_bug.cgi?id=97257 Reviewed by James Robinson. - * src/PageWidgetDelegate.cpp: - (WebKit::PageWidgetDelegate::animate): + * WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations. + * WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter. + +2012-09-20 David Grogan <dgrogan@chromium.org> + + Fix IndexedDB unit tests + https://bugs.webkit.org/show_bug.cgi?id=97149 + + Reviewed by Tony Chang. + + * tests/IDBDatabaseBackendTest.cpp: + Specify a desired version of -1 so that no version change transaction + is run. + +2012-09-20 Dirk Pranke <dpranke@chromium.org> + + roll Chromium to r157829. + + Unreviewed, deps change. + + * DEPS: + +2012-09-20 Nate Chapin <japhet@chromium.org> + + Unreviewed, chromium win build fix. + Remove spurious reference to the non-existent + tests/LayerPainterChromium.h in WebKit.gypi. + + * WebKit.gypi: + +2012-09-20 James Robinson <jamesr@chromium.org> + + [chromium] Remove unused copy of chromium compositor implementation files + https://bugs.webkit.org/show_bug.cgi?id=97255 + + Reviewed by Adam Barth. + + * WebKit.gyp: + * WebKit.gypi: + * WebKitUnitTests.gyp: + * src/WebAnimationCurveCommon.cpp: Removed. + * src/WebAnimationCurveCommon.h: Removed. + * src/WebAnimationImpl.cpp: Removed. + * src/WebAnimationImpl.h: Removed. + * src/WebContentLayerImpl.cpp: Removed. + * src/WebContentLayerImpl.h: Removed. + * src/WebExternalTextureLayerImpl.cpp: Removed. + * src/WebExternalTextureLayerImpl.h: Removed. + * src/WebFloatAnimationCurveImpl.cpp: Removed. + * src/WebFloatAnimationCurveImpl.h: Removed. + * src/WebIOSurfaceLayerImpl.cpp: Removed. + * src/WebIOSurfaceLayerImpl.h: Removed. + * src/WebImageLayerImpl.cpp: Removed. + * src/WebImageLayerImpl.h: Removed. + * src/WebLayerImpl.cpp: Removed. + * src/WebLayerImpl.h: Removed. + * src/WebLayerTreeViewImpl.cpp: Removed. + * src/WebLayerTreeViewImpl.h: Removed. + * src/WebScrollbarLayerImpl.cpp: Removed. + * src/WebScrollbarLayerImpl.h: Removed. + * src/WebSolidColorLayerImpl.cpp: Removed. + * src/WebSolidColorLayerImpl.h: Removed. + * src/WebToCCInputHandlerAdapter.cpp: Removed. + * src/WebToCCInputHandlerAdapter.h: Removed. + * src/WebTransformAnimationCurveImpl.cpp: Removed. + * src/WebTransformAnimationCurveImpl.h: Removed. + * src/WebVideoLayerImpl.cpp: Removed. + * src/WebVideoLayerImpl.h: Removed. + * tests/CCActiveAnimationTest.cpp: Removed. + * tests/CCAnimationTestCommon.cpp: Removed. + * tests/CCAnimationTestCommon.h: Removed. + * tests/CCDamageTrackerTest.cpp: Removed. + * tests/CCDelayBasedTimeSourceTest.cpp: Removed. + * tests/CCDrawQuadTest.cpp: Removed. + * tests/CCFrameRateControllerTest.cpp: Removed. + * tests/CCGeometryTestUtils.cpp: Removed. + * tests/CCGeometryTestUtils.h: Removed. + * tests/CCHeadsUpDisplayTest.cpp: Removed. + * tests/CCKeyframedAnimationCurveTest.cpp: Removed. + * tests/CCLayerAnimationControllerTest.cpp: Removed. + * tests/CCLayerImplTest.cpp: Removed. + * tests/CCLayerIteratorTest.cpp: Removed. + * tests/CCLayerQuadTest.cpp: Removed. + * tests/CCLayerSorterTest.cpp: Removed. + * tests/CCLayerTestCommon.cpp: Removed. + * tests/CCLayerTestCommon.h: Removed. + * tests/CCLayerTreeHostCommonTest.cpp: Removed. + * tests/CCLayerTreeHostImplTest.cpp: Removed. + * tests/CCLayerTreeHostTest.cpp: Removed. + * tests/CCMathUtilTest.cpp: Removed. + * tests/CCOcclusionTrackerTest.cpp: Removed. + * tests/CCOcclusionTrackerTestCommon.h: Removed. + * tests/CCPrioritizedTextureTest.cpp: Removed. + * tests/CCQuadCullerTest.cpp: Removed. + * tests/CCRenderPassTest.cpp: Removed. + * tests/CCRenderSurfaceFiltersTest.cpp: Removed. + * tests/CCRenderSurfaceTest.cpp: Removed. + * tests/CCRendererGLTest.cpp: Removed. + * tests/CCResourceProviderTest.cpp: Removed. + * tests/CCSchedulerStateMachineTest.cpp: Removed. + * tests/CCSchedulerTest.cpp: Removed. + * tests/CCSchedulerTestCommon.h: Removed. + * tests/CCScopedTextureTest.cpp: Removed. + * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: Removed. + * tests/CCSolidColorLayerImplTest.cpp: Removed. + * tests/CCTestCommon.h: Removed. + * tests/CCTextureUpdateControllerTest.cpp: Removed. + * tests/CCThreadTaskTest.cpp: Removed. + * tests/CCThreadedTest.cpp: Removed. + * tests/CCThreadedTest.h: Removed. + * tests/CCTiledLayerImplTest.cpp: Removed. + * tests/CCTiledLayerTestCommon.cpp: Removed. + * tests/CCTiledLayerTestCommon.h: Removed. + * tests/CCTimerTest.cpp: Removed. + * tests/ContentLayerChromiumTest.cpp: Removed. + * tests/FakeCCLayerTreeHostClient.h: Removed. + * tests/FakeGraphicsContext3DTest.cpp: Removed. + * tests/FakeWebScrollbarThemeGeometry.h: Removed. + * tests/FloatQuadTest.cpp: Removed. + * tests/GraphicsLayerChromiumTest.cpp: + * tests/ImageLayerChromiumTest.cpp: + * tests/LayerChromiumTest.cpp: Removed. + * tests/MockCCQuadCuller.h: Removed. + * tests/ScrollbarLayerChromiumTest.cpp: Removed. + * tests/TextureCopierTest.cpp: Removed. + * tests/TextureLayerChromiumTest.cpp: Removed. + * tests/ThrottledTextureUploaderTest.cpp: Removed. + * tests/TiledLayerChromiumTest.cpp: Removed. + * tests/TreeSynchronizerTest.cpp: Removed. + * tests/WebAnimationTest.cpp: Removed. + * tests/WebFloatAnimationCurveTest.cpp: Removed. + * tests/WebLayerTest.cpp: Removed. + * tests/WebLayerTreeViewTest.cpp: Removed. + * tests/WebTransformAnimationCurveTest.cpp: Removed. + * tests/WebTransformOperationsTest.cpp: Removed. + * tests/WebTransformationMatrixTest.cpp: Removed. + +2012-09-20 Tommy Widenflycht <tommyw@google.com> + + MediaStream API: Extend UserMediaRequest with a ownerDocument method + https://bugs.webkit.org/show_bug.cgi?id=97095 + + Reviewed by Adam Barth. + + Chromium need to know exactly which frame called getUserMedia so that it can clean + away the stream when the frame goes away. + Since that information is available in webkit add an accessor method. + + Also taking the opportunity to remove an unused deprecated method, + and adding asserts in case the object is empty. + + * public/WebUserMediaRequest.h: + (WebKit): + (WebUserMediaRequest): + * src/WebUserMediaRequest.cpp: + (WebKit::WebUserMediaRequest::ownerDocument): + +2012-09-20 Mike West <mkwst@google.com> + + [chromium] Adding the 'google_apis' directory to .gitignore. + https://bugs.webkit.org/show_bug.cgi?id=97187 + + Reviewed by Jochen Eisinger. + + 'chromium/google_apis' should be ignored, as it's not in the git repo. + + * .gitignore: + +2012-09-19 Adam Barth <abarth@webkit.org> + + Remove webkitPostMessage + https://bugs.webkit.org/show_bug.cgi?id=96577 + + Reviewed by Ojan Vafai. + + Actually disable webkitPostMessage. See + http://trac.webkit.org/changeset/128658 for more information. + + * features.gypi: + +2012-09-19 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Remove "current transaction" concept from backing store + https://bugs.webkit.org/show_bug.cgi?id=96663 + + Reviewed by Tony Chang. + + Update fake class with new method signatures. + + * tests/IDBFakeBackingStore.h: + +2012-09-19 Terry Anderson <tdanderson@chromium.org> + + [chromium] Store the contents scale factor in PlatformContextSkia on initialization + https://bugs.webkit.org/show_bug.cgi?id=96137 + + Reviewed by Stephen White. + + Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used + for the skia patch here: https://codereview.appspot.com/6506099/. + Also added two new unit tests. + + * features.gypi: + * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: + (WebCore): + (WebCore::HintingScaleCallback::HintingScaleCallback): + (HintingScaleCallback): + (WebCore::HintingScaleCallback::operator()): + (WebCore::TEST_F): + * tests/PlatformContextSkiaTest.cpp: + (WebCore): + (WebCore::TEST): + +2012-09-19 David Grogan <dgrogan@chromium.org> + + Disable some failing IDB tests + https://bugs.webkit.org/show_bug.cgi?id=97135 + + Reviewed by Nate Chapin. + + They were broken in r129037. + + * tests/IDBDatabaseBackendTest.cpp: + +2012-09-19 Alpha Lam <hclam@chromium.org> + + [chromium] Unreviewed. Build fix. + + Not building WebImageTest.cpp for component build. + + * WebKit.gyp: + +2012-09-19 Alpha Lam <hclam@chromium.org> + + [chromium] WebImage should use ImageDecoder directly + https://bugs.webkit.org/show_bug.cgi?id=96135 + + Reviewed by Adam Barth. + + This patch is for preparation of deferred image decoding. + ImageSource will be used as a portal to access deferred image decoder + by BitmapImage, it should not be accessible through WebKit APIs. + + WebImage now calls ImageDecoder directly which is the actual + implementation of an image decoder. + + Tests: WebImageTest.PNGImage + WebImageTest.ICOImage + WebImageTest.BadImage + + * WebKit.gypi: + * src/WebImageSkia.cpp: + (WebKit::WebImage::fromData): + (WebKit::WebImage::framesFromData): + * tests/WebImageTest.cpp: Added. + (WebKit): + (WebKit::readFile): + (WebKit::TEST): + * tests/data/black-and-white.ico: Added. + * tests/data/white-1x1.png: Added. + +2012-09-19 Oli Lan <olilan@chromium.org> + + [chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent. + https://bugs.webkit.org/show_bug.cgi?id=96112 + + Reviewed by Adam Barth. + + Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent. + + This will be used by the Android port to implement platform-specific gesture behaviour. + + This is tested by the new test WebViewTest.ClientTapHandlers. + + * public/WebViewClient.h: + (WebViewClient): + (WebKit::WebViewClient::didHandleGestureEvent): * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::updateAnimations): + (WebKit::WebViewImpl::handleGestureEvent): + * tests/WebViewTest.cpp: + +2012-09-19 Robert Flack <flackr@chromium.org> -2012-10-11 Jay Civelli <jcivelli@chromium.org> + [chromium] Support high DPI scroll bar on top level web frame. + https://bugs.webkit.org/show_bug.cgi?id=95134 - Test for a fix for a crasher when generating MHTML for a page containing SVG images. - https://bugs.webkit.org/show_bug.cgi?id=99105 + Reviewed by Adrienne Walker. + + Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled. + + * src/NonCompositedContentHost.cpp: + (WebKit::setScrollbarBoundsContainPageScale): + (WebKit): + (WebKit::NonCompositedContentHost::setViewport): + +2012-09-19 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move notifyJSOutOfMemory out of PlatformSupport + https://bugs.webkit.org/show_bug.cgi?id=97116 Reviewed by Adam Barth. - * page/PageSerializer.cpp: - (WebCore::PageSerializer::serializeCSSStyleSheet): - (WebCore::PageSerializer::addImageToResources): + Part of a refactoring series. See tracking bug 82948. + + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript): + (WebKit): + * src/FrameLoaderClientImpl.h: + (FrameLoaderClientImpl): + * src/PlatformSupport.cpp: + (WebCore): -2012-10-11 Adam Barth <abarth@webkit.org> +2012-09-19 Mark Pilgrim <pilgrim@chromium.org> - [Chromium] Improve the comment describing mainWorldScriptContext - https://bugs.webkit.org/show_bug.cgi?id=99092 + [Chromium] Remove unused popupsAllowed function from PlatformSupport + https://bugs.webkit.org/show_bug.cgi?id=96521 - Reviewed by James Robinson. + Reviewed by Eric Seidel. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-09-19 Kent Tamura <tkent@chromium.org> + + [Chromium] Fix crash in WebFrameImpl::loadHistoryItem + https://bugs.webkit.org/show_bug.cgi?id=96352 + + Reviewed by Adam Barth. + + We have some crash reports with the following stack: + - HistoryItem::shouldDoSameDocumentNavigationTo. + - WebFrameImpl::loadHistoryItem + ... + + We don't have reproducible steps, and not sure what's the root + cause. Anyway we should check nullness of currentItem because + HistoryController::m_currentItem can be 0. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::loadHistoryItem): + Check nullness of currentItem. + +2012-09-18 Sailesh Agrawal <sail@chromium.org> + + Chromium: Scrollbar with tickmarks doesn't respond to clicks + https://bugs.webkit.org/show_bug.cgi?id=96049 + + Reviewed by Beth Dakin. + + Pipe isAlphaLocked and setIsAlphaLocked. + + * src/WebPluginScrollbarImpl.cpp: + (WebKit::WebPluginScrollbarImpl::isAlphaLocked): + (WebKit): + (WebKit::WebPluginScrollbarImpl::setIsAlphaLocked): + * src/WebPluginScrollbarImpl.h: + (WebPluginScrollbarImpl): + * src/WebScrollbarThemeClientImpl.cpp: + (WebKit::WebScrollbarThemeClientImpl::isAlphaLocked): + (WebKit): + (WebKit::WebScrollbarThemeClientImpl::setIsAlphaLocked): + * src/WebScrollbarThemeClientImpl.h: + (WebScrollbarThemeClientImpl): + * tests/ScrollbarLayerChromiumTest.cpp: + +2012-09-18 Alpha Lam <hclam@chromium.org> + + Unreviewed, rolling out r128939. + http://trac.webkit.org/changeset/128939 + https://bugs.webkit.org/show_bug.cgi?id=96135 + + Failing test_shell_tests. + + * WebKit.gypi: + * src/WebImageSkia.cpp: + (WebKit::WebImage::fromData): + (WebKit::WebImage::framesFromData): + * tests/WebImageTest.cpp: Removed. + * tests/data/black-and-white.ico: Removed. + * tests/data/white-1x1.png: Removed. + +2012-09-18 Alpha Lam <hclam@chromium.org> + + [chromium] WebImage should use ImageDecoder directly + https://bugs.webkit.org/show_bug.cgi?id=96135 + + Reviewed by Adam Barth. + + This patch is for preparation of deferred image decoding. + ImageSource will be used as a portal to access deferred image decoder + by BitmapImage, it should not be accessible through WebKit APIs. + + WebImage now calls ImageDecoder directly which is the actual + implementation of an image decoder. + + Tests: WebImageTest.PNGImage + WebImageTest.ICOImage + + * WebKit.gypi: + * src/WebImageSkia.cpp: + (WebKit::WebImage::fromData): + (WebKit::WebImage::framesFromData): + * tests/WebImageTest.cpp: Added. + (WebKit): + (WebKit::readFile): + (WebKit::TEST): + * tests/data/black-and-white.ico: Added. + * tests/data/white-1x1.png: Added. + +2012-09-18 Tommy Widenflycht <tommyw@google.com> + + MediaStream API: Create a flag to enable PeerConnection00 + https://bugs.webkit.org/show_bug.cgi?id=96989 + + Reviewed by Adam Barth. + + Adding the functionality to separately enable/disable PeerConnection00. + For now it is enabled by default. + + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enableDeprecatedPeerConnection): + (WebKit): + (WebKit::WebRuntimeFeatures::isDeprecatedPeerConnectionEnabled): + +2012-09-18 Iain Merrick <husky@google.com> + + [Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange + https://bugs.webkit.org/show_bug.cgi?id=96508 + + Reviewed by Ryosuke Niwa. + + These methods had "start" and "end" parameters, but this is incorrect. + selectRange() actually takes base and extent (where the user actually + touched), and selectionBounds() returns anchor and focus (base and extent + expanded to account for the selection granularity). + + This patch fixes the parameter names, and updates selectRange, its test + and its documentation to reflect the correct usage. It also removes + moveSelectionStart/moveSelectionEnd/moveCaret (which aren't being used + yet), and updates WebFrameTest to show how these can be implemented via + selectRange. * public/WebFrame.h: (WebFrame): - - Add some more text about what this API does so that folks who - call it know what they need to worry about. + * public/WebWidget.h: + (WebWidget): + (WebKit::WebWidget::selectionBounds): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::selectRange): + * src/WebFrameImpl.h: + (WebFrameImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::selectionBounds): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/WebFrameTest.cpp: + +2012-09-18 Terry Anderson <tdanderson@chromium.org> + + Roll chromium DEPS to r157342 + https://bugs.webkit.org/show_bug.cgi?id=96963 + + Reviewed by Stephen White. + + Roll chromium DEPS to r157342. Also include the top-level directory + google_apis as a dependency, which was required for r157130. + + * DEPS: + +2012-09-17 Brian Anderson <brianderson@chromium.org> + + [chromium] Add rendering commit statistics + https://bugs.webkit.org/show_bug.cgi?id=96938 + + Reviewed by James Robinson. + + Adds total commit time and total commit count to WebRenderingStats. + Allows us to caculate average commit time in performance tests. + + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::renderingStats): + +2012-09-17 James Robinson <jamesr@chromium.org> + + [chromium] Move a FilterOperationsTest and WebInputEventConversionTest back to webkit_unittest_files variable + https://bugs.webkit.org/show_bug.cgi?id=96964 + + Reviewed by Adrienne Walker. + + These targets are really webkit unit tests and shouldn't be guarded by use_libcc_for_compositor. + + * WebKit.gypi: + +2012-09-17 Rick Byers <rbyers@chromium.org> + + Send GestureTapDownCancel to WebCore + https://bugs.webkit.org/show_bug.cgi?id=96060 + + Reviewed by Antonio Gomes. + + Plumb WebInputEvent::GetsureTapCancel to + PlatformInputEvent::GestureTapDownCancel. After all the chromium code + was landed, it was suggested that 'TapDownCancel' was a better name + than 'TapCancel' since you can't cancel a Tap. I'm not changing the + WebInputEvent definition here because that would be a breaking change + to chromium, but I can do that as a series of follow-up CLs. + * src/WebInputEventConversion.cpp: + (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::handleInputEvent): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): -2012-10-11 Sheriff Bot <webkit.review.bot@gmail.com> +2012-09-17 Alec Flett <alecflett@chromium.org> + + IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor + https://bugs.webkit.org/show_bug.cgi?id=95409 + + Reviewed by Kentaro Hara. + + This removes a bunch of tests that have been migrated to + LayoutTests, in https://bugs.webkit.org/show_bug.cgi?id=96818. + + * tests/IDBBindingUtilitiesTest.cpp: + (WebCore::checkKeyFromValueAndKeyPathInternal): + (WebCore::checkKeyPathNullValue): + (WebCore::injectKey): + (WebCore::checkInjection): + (WebCore::checkInjectionFails): + (WebCore::checkKeyPathStringValue): + (WebCore::checkKeyPathNumberValue): + (WebCore::TEST): + * tests/IDBKeyPathTest.cpp: + +2012-09-17 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Fix cases where find-in-page doesn't send a final update + https://bugs.webkit.org/show_bug.cgi?id=96402 + + Fix some issues in the WebKit implementation that prevented to send a final + reportFindInPageMatchCount message. + + Reviewed by Adam Barth. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::scopeStringMatches): + (WebKit): + (WebKit::WebFrameImpl::finishCurrentScopingEffort): + (WebKit::WebFrameImpl::cancelPendingScopingEffort): + (WebKit::WebFrameImpl::WebFrameImpl): + (WebKit::WebFrameImpl::shouldScopeMatches): + * src/WebFrameImpl.h: + +2012-09-17 Joshua Bell <jsbell@chromium.org> + + [Chromium] IndexedDB: Remove legacy two-phase open() API members + https://bugs.webkit.org/show_bug.cgi?id=96802 + + Reviewed by Tony Chang. + + Following http://webkit.org/b/90411 and subsequent cleanup on the Chromium side, + these entry points are no longer needed. + + * public/WebIDBDatabase.h: Delete old second-phase open(db-callbacks) + * public/WebIDBFactory.h: Delete old first-phase open() w/o db-callbacks + * src/WebIDBDatabaseImpl.cpp: No longer need to account for a close between phases. + (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): + (WebKit::WebIDBDatabaseImpl::close): + (WebKit::WebIDBDatabaseImpl::forceClose): + * src/WebIDBDatabaseImpl.h: + (WebIDBDatabaseImpl): + +2012-09-17 Ilya Tikhonovsky <loislo@chromium.org> + + Unreviewed. Temporary disable visited set counter check. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::TEST): + +2012-09-17 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: NMI: now when we can detect instrumented classes we can + remove addInstrumentedMember and use addMember for everything. + https://bugs.webkit.org/show_bug.cgi?id=96913 + + Reviewed by Yury Semikhatsky. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::InstrumentedDOM::reportMemoryUsage): + (WebCore::NonVirtualInstrumented::reportMemoryUsage): + (WebCore::InstrumentedOwner::reportMemoryUsage): + +2012-09-17 Ilya Tikhonovsky <loislo@chromium.org> + + Unreviewed single line fix for mac chromium canary bot. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::TEST): + +2012-09-15 Yury Semikhatsky <yurys@chromium.org> + + Web Inspector: automatically detect if class has reportMemoryUsage method + https://bugs.webkit.org/show_bug.cgi?id=96756 + + Reviewed by Alexander Pavlov. + + Test that reportMemoryUsage method will be called on the instrumented object + even if it is a template. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore): + (InstrumentedTemplate): + (WebCore::InstrumentedTemplate::InstrumentedTemplate): + (WebCore::InstrumentedTemplate::reportMemoryUsage): + (WebCore::TEST): + +2012-09-14 Yury Semikhatsky <yurys@chromium.org> + + Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by the memory instrumentation + https://bugs.webkit.org/show_bug.cgi?id=96791 + + Reviewed by Alexander Pavlov. + + Test that pointers to RefPtr and OwnPtr won't be double counted by + the memory instrumentation. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore): + (TwoPointersToRefPtr): + (WebCore::TwoPointersToRefPtr::TwoPointersToRefPtr): + (WebCore::TwoPointersToRefPtr::reportMemoryUsage): + (WebCore::TEST): + (TwoPointersToOwnPtr): + (WebCore::TwoPointersToOwnPtr::TwoPointersToOwnPtr): + (WebCore::TwoPointersToOwnPtr::reportMemoryUsage): + +2012-09-16 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed. Rolled DEPS. * DEPS: -2012-10-11 Mihai Balan <mibalan@adobe.com> +2012-09-14 Julien Chaffraix <jchaffraix@webkit.org> - Always enable the experiments tab for WebKit nightly + Revert r127457 and following fixes due to several hit-testing regressions + https://bugs.webkit.org/show_bug.cgi?id=96830 - Web Inspector: Enabling experiments tab in WebKit nightly. - https://bugs.webkit.org/show_bug.cgi?id=98923 + Reviewed by Antonio Gomes. - Reviewed by Pavel Feldman. + This change reverts r127457, r127863 and r128505. - Enabling Web Inspector experiments tab in WebKit nightly. This is done by adding a new - Preference key, Preferences.experimentsEnabled. Default values are true for WebKit and false - for Chromium. They can also be overridden as before (in Chromium) + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): - * src/js/DevTools.js: +2012-09-14 Ojan Vafai <ojan@chromium.org> -2012-10-11 Kent Tamura <tkent@chromium.org> + Provide a runtime setting to disable position:sticky + https://bugs.webkit.org/show_bug.cgi?id=96827 - Introduce Localizer::isRTL, and use it in DateTimeChooserImpl - https://bugs.webkit.org/show_bug.cgi?id=98992 + Reviewed by James Robinson. - * tests/LocalizedDateICUTest.cpp: - (TEST_F): Re-enabled isRTL test. + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setCSSStickyPositionEnabled): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-09-14 Adam Barth <abarth@webkit.org> + + Remove webkitPostMessage + https://bugs.webkit.org/show_bug.cgi?id=96577 + + Reviewed by Ojan Vafai. + + Add ENABLE_LEGACY_VENDOR_PREFIXES flag. + + * features.gypi: -2012-10-11 Kent Tamura <tkent@chromium.org> +2012-09-14 Sheriff Bot <webkit.review.bot@gmail.com> - [Chromium] Disable LocalizedDateICUTest.isRTL - https://bugs.webkit.org/show_bug.cgi?id=98992 + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-09-14 Rick Byers <rbyers@chromium.org> + + [chromium] add touch area to gestureTapDown data + https://bugs.webkit.org/show_bug.cgi?id=96806 + + Reviewed by Adam Barth. + + Add width/height for GestureTapDown as for GestureTap/LongPress so that + we can eventually do fuzzing on it. + * public/WebInputEvent.h: + * src/WebInputEventConversion.cpp: + (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): + +2012-09-14 Peter Beverloo <peter@chromium.org> + + [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=96687 + + Reviewed by Tony Chang. + + Android's DumpRenderTree currently supports these arguments, implemented + as part of TestShellAndroid: + http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496 + + They're used by the layout test runner to get the STDOUT and STDERR while + a layout test run is in process, which is a safer alternative to parsing + all the logcat output manually. The implementation can be seen here: + http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590 + + This patch generalizes parsing of and applying the effects of these arguments + so that they can be used for TestWebKitAPI and webkit_unit_tests as well. + After this patch, this will make it possible to pull out the output-reading + code from Android's layout test port and generalize it so it can be re-used + in the new test-runner for the other two test suites. + + This has no effect when compiling and running these tests as part of Chromium + code, which has a much more advanced test-runner that does parse complete log + output, but also directly depends on code licensed under Apache 2. + + * WebKit.gypi: + * tests/ForwardIOStreamsAndroid.cpp: Added. + (WebKit): + (WebKit::maybeInitIOStreamForwardingForAndroid): + * tests/ForwardIOStreamsAndroid.h: Added. + (WebKit): + * tests/RunAllTests.cpp: + (main): + +2012-09-14 Keishi Hattori <keishi@webkit.org> + + Make time input lang attribute aware for testing + https://bugs.webkit.org/show_bug.cgi?id=96728 + + Reviewed by Kent Tamura. * tests/LocalizedDateICUTest.cpp: - (TEST_F): Disabled. + (LocalizedDateICUTest::localizedDateFormatText): + (LocalizedDateICUTest::localizedShortDateFormatText): -2012-10-11 Kent Tamura <tkent@chromium.org> +2012-09-14 Keishi Hattori <keishi@webkit.org> - [Chromium] Attempt to fix LocalizedDateICUTest.isRTL - https://bugs.webkit.org/show_bug.cgi?id=98992 + Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods + https://bugs.webkit.org/show_bug.cgi?id=96726 + Reviewed by Kent Tamura. + + * tests/LocaleMacTest.cpp: + (LocaleMacTest::timeFormat): + (LocaleMacTest::shortTimeFormat): + (TEST_F): + * tests/LocaleWinTest.cpp: + (LocaleWinTest::timeFormat): + (LocaleWinTest::shortTimeFormat): + (TEST_F): * tests/LocalizedDateICUTest.cpp: + (LocalizedDateICUTest::localizedDateFormatText): + (LocalizedDateICUTest::localizedShortDateFormatText): + +2012-09-14 Keishi Hattori <keishi@webkit.org> + + LocaleMac should fallback to defaultLanguage for an invalid locale + https://bugs.webkit.org/show_bug.cgi?id=96744 + + Reviewed by Kent Tamura. + + * tests/LocaleMacTest.cpp: (TEST_F): -2012-10-11 Kent Tamura <tkent@chromium.org> +2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> - Introduce Localizer::isRTL, and use it in DateTimeChooserImpl - https://bugs.webkit.org/show_bug.cgi?id=98992 + Unreviewed, rolling out r128543. + http://trac.webkit.org/changeset/128543 + https://bugs.webkit.org/show_bug.cgi?id=96722 - Reviewed by Kentaro Hara. + Caused LocaleWinTest.localizedNumberRoundTrip to fail + (Requested by keishi on #webkit). - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): Use Localizer::isRTL. + * tests/LocaleWinTest.cpp: + (testNumberIsReversible): + (testNumbers): + (TEST_F): + +2012-09-13 Keishi Hattori <keishi@webkit.org> + + Create Localizer factory method for LocaleWin + https://bugs.webkit.org/show_bug.cgi?id=96667 + + Reviewed by Kent Tamura. - * tests/LocaleMacTest.cpp: - (LocaleMacTest::isRTL): Added a helper function. - (TEST_F): Added tests. * tests/LocaleWinTest.cpp: - (LocaleWinTest::isRTL): Added a helper function. - (TEST_F): Added tests. - * tests/LocalizedDateICUTest.cpp: - (LocalizedDateICUTest::isRTL): Added a helper function. - (TEST_F): Added tests. + (testNumberIsReversible): + (testNumbers): -2012-10-10 Kent Tamura <tkent@chromium.org> +2012-09-13 Joshua Bell <jsbell@chromium.org> - [Chromium] Calendar picker: should use consistent Localizer object - https://bugs.webkit.org/show_bug.cgi?id=98983 + IndexedDB: Consolidate two-phase connection to avoid race conditions + https://bugs.webkit.org/show_bug.cgi?id=90411 - Reviewed by Kentaro Hara. + Reviewed by Tony Chang. - In Source/WebKit/chromium/src/DateTimeChooserImpl.cpp, we used two - Localizer objects, one was m_localizer and another was 'localizer' local - object in writeDocument. We should use single Localizer object. + API plumbing for simplified single-phase connection opening, and tests updated + to exercise the new APIs. - Also, Localizer::create(nullAtom) had unexpected behaviors in ICU - environment; e.g. Month labels in a calendar picker were numeric. This - patch fixes it, and this is covered by - fast/forms/date/calendar-picker-appearance.html. + * public/WebIDBDatabase.h: + (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API. + * public/WebIDBFactory.h: + (WebKit): + (WebIDBFactory): + (WebKit::WebIDBFactory::open): New overload that takes db-callbacks. + * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier. + (WebKit::IDBCallbacksProxy::onSuccess): + (WebKit::IDBCallbacksProxy::onUpgradeNeeded): + (WebKit): + (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to + the db-callbacks and hook it up when the onSuccess callback comes through. + * src/IDBCallbacksProxy.h: + (WebKit): + (IDBCallbacksProxy): + * src/IDBDatabaseBackendProxy.cpp: + * src/IDBDatabaseBackendProxy.h: + (IDBDatabaseBackendProxy): + * src/IDBFactoryBackendProxy.cpp: + (WebKit::IDBFactoryBackendProxy::open): + * src/IDBFactoryBackendProxy.h: + (IDBFactoryBackendProxy): + * src/WebIDBDatabaseImpl.cpp: + (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): + (WebKit::WebIDBDatabaseImpl::close): + * src/WebIDBDatabaseImpl.h: + (WebIDBDatabaseImpl): + * src/WebIDBFactoryImpl.cpp: + (WebKit::WebIDBFactoryImpl::open): + * src/WebIDBFactoryImpl.h: + (WebIDBFactoryImpl): + * tests/IDBAbortOnCorruptTest.cpp: + (FakeIDBDatabaseCallbacks): + (WebCore::FakeIDBDatabaseCallbacks::create): + (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks): + (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks): + (WebCore): + (WebCore::TEST): Updated connection sequence. + * tests/IDBDatabaseBackendTest.cpp: Ditto. - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): - Use m_localizer. +2012-09-13 James Robinson <jamesr@chromium.org> -2012-10-10 Justin Novosad <junov@chromium.org> + PlatformGestureCurveTest compile fix pt 2 - [Chromium] Smoother animation for non-RAF 2D canvas animations - https://bugs.webkit.org/show_bug.cgi?id=97918 + * tests/PlatformGestureCurveTest.cpp: - Reviewed by Stephen White. +2012-09-13 James Robinson <jamesr@chromium.org> - New unit test to verify the automatic flushing of deferred 2d canvas - layers when scripted animations are more than one full frame ahead - of the compositor. Also verifies that automatic flushing does not - kick-in when the skip on clear optimization fires + Fix compile warning/error on windows - literal that isn't exactly representable as a float needs "f" suffix. - * DEPS: - * tests/Canvas2DLayerManagerTest.cpp: - (FakeCanvas2DLayerBridge::fakeSkipPendingDrawCommands): - To fake the skip on clear optimization - (FakeCanvas2DLayerBridge): - (Canvas2DLayerManagerTest): - (Canvas2DLayerManagerTest::doDeferredFrameTestTask): - Method that simulates a javascript scheduled action that draws to - a 2D canvas layer - (DeferredFrameTestTask): - Task object to simulate a scheduled action. This is so the unit - test can cover the TaskObserver behavior of Canvas2DLayerManager. - (Canvas2DLayerManagerTest::DeferredFrameTestTask::DeferredFrameTestTask): - (Canvas2DLayerManagerTest::deferredFrameTest): - The unit test implementation, which uses the WebThread run loop to - post tasks that touch the canvas layer. + * tests/PlatformGestureCurveTest.cpp: -2012-10-10 Leandro Gracia Gil <leandrogracia@chromium.org> +2012-09-13 Julien Chaffraix <jchaffraix@webkit.org> - [Chromium] Update selection on long press to match normal delimiters. - https://bugs.webkit.org/show_bug.cgi?id=98947 + [Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place + https://bugs.webkit.org/show_bug.cgi?id=96593 Reviewed by Adam Barth. - Make the long press selection behaviour consistent. + After r127457, the HitTestResult stored in ContextMenuController is in window coordinates. + Trying to convert it again to window coordinates will result in adding the containing frame's + position twice, thus the wrong placing. - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - (WebKit::WebViewImpl::detectContentOnTouch): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/WebViewTest.cpp: + Chromium Mac wasn't impacted by the regression and I manually checked that the fix doesn't impact Mac. + + Unfortunately, no test as I don't think we have a way of testing context menu position. + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): + +2012-09-13 Robert Kroeger <rjkroege@chromium.org> + + [chromium] alter fling animation parameters. + https://bugs.webkit.org/show_bug.cgi?id=96666 + + Reviewed by Adrienne Walker. + + Corrected the test to be non-fragile in the presence of altered fling + curve parameters. + + * tests/PlatformGestureCurveTest.cpp: + +2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r128489. + http://trac.webkit.org/changeset/128489 + https://bugs.webkit.org/show_bug.cgi?id=96686 + + Does not compile on windows (Requested by jamesr on #webkit). + + * public/WebIDBDatabase.h: + * public/WebIDBFactory.h: + (WebIDBFactory): + * src/IDBCallbacksProxy.cpp: + (WebKit::IDBCallbacksProxy::onSuccess): + (WebKit::IDBCallbacksProxy::onUpgradeNeeded): + * src/IDBCallbacksProxy.h: + (WebKit): + (IDBCallbacksProxy): + * src/IDBDatabaseBackendProxy.cpp: + (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks): + (WebKit): + * src/IDBDatabaseBackendProxy.h: + (IDBDatabaseBackendProxy): + * src/IDBFactoryBackendProxy.cpp: + (WebKit::IDBFactoryBackendProxy::open): + * src/IDBFactoryBackendProxy.h: + (IDBFactoryBackendProxy): + * src/WebIDBDatabaseImpl.cpp: + (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): + (WebKit::WebIDBDatabaseImpl::close): + (WebKit::WebIDBDatabaseImpl::open): + (WebKit): + * src/WebIDBDatabaseImpl.h: + (WebIDBDatabaseImpl): + * src/WebIDBFactoryImpl.cpp: + (WebKit::WebIDBFactoryImpl::open): + * src/WebIDBFactoryImpl.h: + (WebIDBFactoryImpl): + * tests/IDBAbortOnCorruptTest.cpp: + (WebCore::TEST): + * tests/IDBDatabaseBackendTest.cpp: + +2012-09-13 Glenn Hartmann <hartmanng@chromium.org> + + Add new accelerated compositing for overflow scroll setting. + https://bugs.webkit.org/show_bug.cgi?id=95885 + + Reviewed by James Robinson. + + wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which + currently returns true if we're overflow scrolling and the element has + been styled with '-webkit-overflow-scrolling: touch'. If this is true, + we get promoted to a composited layer, the associated RenderLayerBacking + gets special scrolling layers and in response to RenderLayer::scrollTo() + we no longer have to invalidate everything to get the scrolled content + in the right spot, thereby avoiding very expensive repaints. It's + unfortunate that we require -webkit-overflow-scrolling: touch, though. + It would be nice if RenderLayer::usesCompositedScrolling() returned true + if the page would continue to behave correctly. This is what + wkb.ug/94743 is intended to do. Unfortunately, when we become a + composited layer, we switch from subpixel to grayscale anti-aliasing. We + only want to auto-opt into composited scrolling if we don't mind the + change in anti-aliasing, so we need a flag to enable/disable this + feature. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-09-13 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Consolidate two-phase connection to avoid race conditions + https://bugs.webkit.org/show_bug.cgi?id=90411 + + Reviewed by Tony Chang. -2012-10-10 Sheriff Bot <webkit.review.bot@gmail.com> + API plumbing for simplified single-phase connection opening, and tests updated + to exercise the new APIs. + + * public/WebIDBDatabase.h: + (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API. + * public/WebIDBFactory.h: + (WebKit): + (WebIDBFactory): + (WebKit::WebIDBFactory::open): New overload that takes db-callbacks. + * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier. + (WebKit::IDBCallbacksProxy::onSuccess): + (WebKit::IDBCallbacksProxy::onUpgradeNeeded): + (WebKit): + (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to + the db-callbacks and hook it up when the onSuccess callback comes through. + * src/IDBCallbacksProxy.h: + (WebKit): + (IDBCallbacksProxy): + * src/IDBDatabaseBackendProxy.cpp: + * src/IDBDatabaseBackendProxy.h: + (IDBDatabaseBackendProxy): + * src/IDBFactoryBackendProxy.cpp: + (WebKit::IDBFactoryBackendProxy::open): + * src/IDBFactoryBackendProxy.h: + (IDBFactoryBackendProxy): + * src/WebIDBDatabaseImpl.cpp: + (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): + (WebKit::WebIDBDatabaseImpl::close): + * src/WebIDBDatabaseImpl.h: + (WebIDBDatabaseImpl): + * src/WebIDBFactoryImpl.cpp: + (WebKit::WebIDBFactoryImpl::open): + * src/WebIDBFactoryImpl.h: + (WebIDBFactoryImpl): + * tests/IDBAbortOnCorruptTest.cpp: + (FakeIDBDatabaseCallbacks): + (WebCore::FakeIDBDatabaseCallbacks::create): + (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks): + (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks): + (WebCore): + (WebCore::TEST): Updated connection sequence. + * tests/IDBDatabaseBackendTest.cpp: Ditto. + +2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed. Rolled DEPS. * DEPS: -2012-10-10 Jon Lee <jonlee@apple.com> +2012-09-13 Ilya Tikhonovsky <loislo@chromium.org> - [WK2] Activate plugins when user clicks on snapshot - https://bugs.webkit.org/show_bug.cgi?id=98328 - <rdar://problem/12426681> + Web Inspector: NMI: instrument KURL directly. + https://bugs.webkit.org/show_bug.cgi?id=96624 - Reviewed by Brady Eidson. + Reviewed by Yury Semikhatsky. - * src/FrameLoaderClientImpl.h: - (WebKit::FrameLoaderClientImpl::recreatePlugin): Stub implementation of recreatePlugin(). + I replaced traits based instrumentation of KURL with reportMemoryUsage functions. + CString* were also instrumented. + + Drive by fix: Instrumentation code in QualifiedName was moved to cpp. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore): + (InstrumentedOwner): + (WebCore::InstrumentedOwner::InstrumentedOwner): + (WebCore::InstrumentedOwner::reportMemoryUsage): + (WebCore::TEST): + +2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r128409. + http://trac.webkit.org/changeset/128409 + https://bugs.webkit.org/show_bug.cgi?id=96622 + + It broke Chromium browser_tests (Requested by tkent on + #webkit). + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::scopeStringMatches): + (WebKit::WebFrameImpl::shouldScopeMatches): + +2012-09-13 Taiju Tsuiki <tzik@chromium.org> + + Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call. + https://bugs.webkit.org/show_bug.cgi?id=96601 + + Reviewed by Kent Tamura. + + m_webFrame might be already deleted after terminateWorkerContext call. + This patch ensure it be NULL and change to avoid using it. + + Test: fast/filesystem/workers/detached-frame-crash.html + + * src/WebWorkerClientImpl.cpp: + (WebKit::WebWorkerClientImpl::terminateWorkerContext): + (WebKit::WebWorkerClientImpl::openFileSystem): + +2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Fix cases where find-in-page doesn't send a final update + https://bugs.webkit.org/show_bug.cgi?id=96402 + + Fix some issues in the WebKit implementation that prevented to send a final + reportFindInPageMatchCount message. + + Reviewed by Adam Barth. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::scopeStringMatches): + (WebKit::WebFrameImpl::shouldScopeMatches): + +2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r127876. + http://trac.webkit.org/changeset/127876 + https://bugs.webkit.org/show_bug.cgi?id=96600 + + mouse click doesn't work for spin button if spin button in + iframe (Requested by yosin on #webkit). + + * src/ContextMenuClientImpl.cpp: + (WebKit::selectMisspelledWord): + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::characterIndexForPoint): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::isRectTopmost): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleMouseUp): + (WebKit::WebViewImpl::computeBlockBounds): + +2012-09-12 Rick Byers <rbyers@chromium.org> + + [chromium] Remove unused WebGestureEvent fields + https://bugs.webkit.org/show_bug.cgi?id=95496 + + Reviewed by Adam Barth. + + Remove the no-longer used fields from WebGestureEvent, now that + chromium has been updated to use the per-event-type fields instead. + This depends on crrev.com/156346 in chromium. + + * public/WebInputEvent.h: + (WebKit::WebGestureEvent::WebGestureEvent): + * public/android/WebInputEventFactory.h: + * src/WebInputEvent.cpp: + (SameSizeAsWebGestureEvent): + * src/android/WebInputEventFactory.cpp: + (WebKit): + (WebKit::WebInputEventFactory::gestureEvent): + +2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r128351. + http://trac.webkit.org/changeset/128351 + https://bugs.webkit.org/show_bug.cgi?id=96573 + + Broke FindInPage browser_tests (Requested by jamesr_ on + #webkit). + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::scopeStringMatches): + (WebKit::WebFrameImpl::cancelPendingScopingEffort): + (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): + (WebKit::WebFrameImpl::shouldScopeMatches): + +2012-09-12 Adrienne Walker <enne@google.com> + + [chromium] Fix search tickmarks not disappearing when compositing is enabled + https://bugs.webkit.org/show_bug.cgi?id=96536 + + Reviewed by James Robinson. + + view->invalidateRect() on the root frame just invalidates the + contents, since WebViewImpl doesn't know anything about scrollbar + layers. This causes an "InvalidateAll" to not actually invalidate the + scrollbars. + + To fix this, make WebFrameImpl explicitly invalidate the + scrollbars when required. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::invalidateArea): + +2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org> -2012-10-10 David Barton <dbarton@mathscribe.com> + [Chromium] Fix cases where find-in-page doesn't send a final update + https://bugs.webkit.org/show_bug.cgi?id=96402 - Turn on ENABLE_MATHML for Chromium - https://bugs.webkit.org/show_bug.cgi?id=96960 + Fix some issues in the WebKit implementation that prevented to send a final + reportFindInPageMatchCount message. Also, fix a buggy reset of the active match + when calling the stopFinding method. Reviewed by Adam Barth. + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::scopeStringMatches): + (WebKit::WebFrameImpl::cancelPendingScopingEffort): + (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): + (WebKit::WebFrameImpl::shouldScopeMatches): + +2012-09-12 Sami Kyostila <skyostil@google.com> + + Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING + https://bugs.webkit.org/show_bug.cgi?id=96251 + + Reviewed by Simon Fraser. + + Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe + the feature it controls. + * features.gypi: -2012-10-10 Varun Jain <varunjain@chromium.org> +2012-09-12 Christopher Cameron <ccameron@chromium.org> - [chromium] Spelling and grammar markers are pixelated in hidpi. - https://bugs.webkit.org/show_bug.cgi?id=98339 + [chromium] Evict textures through the texture manager instead of the resource provider + https://bugs.webkit.org/show_bug.cgi?id=96463 - Reviewed by Stephen White. + Reviewed by James Robinson. - We create separate bitmaps for markers in normal and hidpi mode as per - specification from UX and choose the right bitmap based on the current - device scale factor. + Update layer tree host impl test to include the extra interface functions + added to CCLayerTreeHostImplClient. - * src/PageWidgetDelegate.cpp: - (WebKit::PageWidgetDelegate::paint): + * tests/CCLayerTreeHostImplTest.cpp: + +2012-09-12 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: NMI move String* instrumentation to wtf. + https://bugs.webkit.org/show_bug.cgi?id=96405 + + Reviewed by Yury Semikhatsky. + + This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream. + + Tested by webkit_unit_tests. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::TEST): + +2012-09-12 Philippe Liard <pliard@google.com> + + Depend on {base,net} GYP targets rather than {base,net}_java. + https://bugs.webkit.org/show_bug.cgi?id=95690 + + Reviewed by Adam Barth. + + {base,net}_java became 'private' targets on the Chromium side that + clients should not depend on (see + https://chromiumcodereview.appspot.com/10913083/). + This also adds the missing 'chromium_net.jar' to |input_jars_paths| + that was magically included in Chrome for Android downstream but not + upstream. It's needed to register JNI for 'net' in webkit_unit_tests. + + + * WebKitUnitTests.gyp: + +2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r128279. + http://trac.webkit.org/changeset/128279 + https://bugs.webkit.org/show_bug.cgi?id=96487 + + "Snow Leopard compilation broken" (Requested by yurys on + #webkit). + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::InstrumentedUndefined::reportMemoryUsage): + (WebCore::TEST): + +2012-09-12 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: NMI move String* instrumentation to wtf. + https://bugs.webkit.org/show_bug.cgi?id=96405 + + Reviewed by Yury Semikhatsky. + + This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream. + + Tested by webkit_unit_tests. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::InstrumentedUndefined::reportMemoryUsage): + (WebCore::TEST): + +2012-09-12 Jochen Eisinger <jochen@chromium.org> + + [chromium] consumable user gesture count off for input events + https://bugs.webkit.org/show_bug.cgi?id=96373 + + Reviewed by Adam Barth. + + Don't create a UserGestureIndicator in the chromium layer, as it will + already be created by webcore's event handler. Creating multiple + UserGestureIndicator objects for the same object would allow to execute + multiple user-gesture-gated actions per user gesture such as opening a + new window. + + * public/WebInputEvent.h: * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::paintRootLayer): + (WebKit::WebViewImpl::handleInputEvent): + +2012-09-12 Alexandre Elias <aelias@chromium.org> + + [chromium] Flip Y and swizzle inside compositeAndReadback implementation + https://bugs.webkit.org/show_bug.cgi?id=96458 + + Reviewed by James Robinson. + + Currently, compositeAndReadback API assumes a GL-style texture + and is converted to the normal software format in WebViewImpl. + For the software implementation, this API would result in two + redundant conversions. This patch makes the conversion inside + CCRendererGL instead. I rolled my own for loop as I didn't find the + appropriate function within raw Skia. + + No new tests (covered by existing layout tests). + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::doPixelReadbackToCanvas): + +2012-09-11 Taiju Tsuiki <tzik@chromium.org> + + WebFrameImpl::client() needs NULL check in WebWorkerClientImpl::openFileSystem + https://bugs.webkit.org/show_bug.cgi?id=96354 + + Reviewed by Kent Tamura. + + Ensure non-NULL before using WebFrameImpl::client(). + + Test: fast/filesystem/workers/detached-frame-crash.html + + * src/WebWorkerClientImpl.cpp: + (WebKit::WebWorkerClientImpl::openFileSystem): + +2012-09-11 Keishi Hattori <keishi@webkit.org> + + Create Localizer factory method for LocaleICU + https://bugs.webkit.org/show_bug.cgi?id=96363 + + Reviewed by Kent Tamura. + + * tests/LocalizedNumberICUTest.cpp: + (testNumberIsReversible): + (testDecimalSeparator): + +2012-09-11 Christopher Cameron <ccameron@chromium.org> + + [chromium] Make prioritized texture manager not touch backings array on the main thread + https://bugs.webkit.org/show_bug.cgi?id=96114 + + Reviewed by James Robinson. + + Take a snapshot of the textures' priorities from the main thread, + and save it in their backings for access by the impl thread. + Update functions that access the sorted backings array to use the + snapshotted values instead of the values that the main thread may + have computed for the next frame. + + Make the main thread not touch the m_backings array. Split + prioritizeTextures into a updateBackingsPriorities function. + In places where the main thread would have touched m_backings, + set a flag specifying that m_backings needs to be re-sorted + before any function that requires it be sorted by priority be + executed. + + Update the two functions that require sorted order (acquireBacking + and reduceMemory) to sort the backings array (if needed) before + traversing it. + + Updated tests to set correct thread during asserts. Add a test to + verify that requestLate is correctly incorporated into the backing + sorting. + + * tests/CCPrioritizedTextureTest.cpp: + (WTF::CCPrioritizedTextureTest::validateTexture): + +2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-09-11 Iain Merrick <husky@chromium.org> + + [chromium] Fix double call to scrollBegin() when handling scroll gesture + https://bugs.webkit.org/show_bug.cgi?id=95322 + + Reviewed by James Robinson. + + WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its + client, then if the result is ScrollStarted, it creates a PlatformGestureCurve + object to handle the fling animation. This patch adds a matching scrollEnd() + before the animation starts. + + Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all + unexpected calls into test failures. This ensures that scrollBegin / scrollEnd + happen exactly when we want and at no other times. + + * src/WebCompositorInputHandlerImpl.cpp: + (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): + * tests/WebCompositorInputHandlerImplTest.cpp: + (WebCompositorInputHandlerImplTest): + (WebKit::TEST_F): + +2012-09-11 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-09-11 Keishi Hattori <keishi@webkit.org> + + Create Localizer factory method for LocaleMac + https://bugs.webkit.org/show_bug.cgi?id=96355 + + Reviewed by Kent Tamura. + + * tests/LocaleMacTest.cpp: + (testNumberIsReversible): Use Localizer::create. + (testNumbers): + +2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com> -2012-10-10 Simon Fraser <simon.fraser@apple.com> + Unreviewed, rolling out r128150. + http://trac.webkit.org/changeset/128150 + https://bugs.webkit.org/show_bug.cgi?id=96357 - Store a visible rect in GraphicsLayers, and optionally dump it in layerTreeAsText - https://bugs.webkit.org/show_bug.cgi?id=98839 + it broke chromium compilation (Requested by loislo on + #webkit). + + * DEPS: + +2012-09-10 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-09-10 Joanmarie Diggs <jdiggs@igalia.com> + + Properly expose <legend> elements to ATs + https://bugs.webkit.org/show_bug.cgi?id=84137 + + Reviewed by Chris Fleizach. + + Created a new WebCore Accessibility Role, LegendRole. Used it to map to + the expected platform role, ATK_ROLE_LABEL. Also established the needed + AtkRelation pair, label-for/labelled-by between the legend and fieldset. + + * public/WebAccessibilityRole.h: added WebAccessibilityRoleLegend + * src/AssertMatchingEnums.cpp: added the assert matching rule for + WebAccessibilityRoleLegend and LegendRole + +2012-09-10 Beth Dakin <bdakin@apple.com> + + https://bugs.webkit.org/show_bug.cgi?id=96158 + Need API to suppress scrollbar animations + -and corresponding- + <rdar://problem/12210972> Reviewed by Sam Weinig. - Add a flag to layerTreeAsText() so that tests can optionally include this visible rect in - layer tree dumps. This output will be platform-specific, so we don't want to do it unconditionally. + ScrollableArea::isOnActivePage() has been re-named to + ScrollableArea:: scrollbarsCanBeActive(). + * src/ScrollbarGroup.cpp: + (WebKit::ScrollbarGroup::scrollbarsCanBeActive): + * src/ScrollbarGroup.h: + * tests/GraphicsLayerChromiumTest.cpp: + * tests/ScrollAnimatorNoneTest.cpp: + (MockScrollableArea): + +2012-09-10 Dan Alcantara <dfalcantara@chromium.org> + + [chromium, android] Reloading a page with a different user agent can cause the page to be zoomed in + https://bugs.webkit.org/show_bug.cgi?id=90222 + + Reviewed by Adam Barth. + + When reloading a page with an overridden URL, the page's scroll and zoom + state will be restored once the reload is complete. This is problematic + in situations when switching between mobile and desktop versions of the + same site because it will zoom back in on a random part of alternate page. + This CL just avoids that situation by resetting the zoom and scale whenever + this type of reload occurs. + + Chromium half: https://chromiumcodereview.appspot.com/10889019 + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::resetScrollAndScaleState): + (WebKit): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-09-10 Adam Barth <abarth@chromium.org> + + [V8] V8AuxiliaryContext used by IDB leaks memory + https://bugs.webkit.org/show_bug.cgi?id=96317 + + Reviewed by Tony Chang. + + Call the V8 APIs directly instead of using a helper class. + + * tests/IDBBindingUtilitiesTest.cpp: + (WebCore::TEST): + +2012-09-10 Adam Barth <abarth@chromium.org> + + [V8] Inline firstFrame and currentFrame into their unique callers + https://bugs.webkit.org/show_bug.cgi?id=96309 + + Reviewed by Eric Seidel. + + This patch just lines these WebCore functions because we only call them + from here. * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::layerTreeAsText): + (WebKit::WebFrame::frameForEnteredContext): + (WebKit::WebFrame::frameForCurrentContext): -2012-10-08 Kent Tamura <tkent@chromium.org> +2012-09-10 Rick Byers <rbyers@chromium.org> - [Chromium] Add WebElement::hasHTMLTagName, and deprecate hasTagName - https://bugs.webkit.org/show_bug.cgi?id=98714 + [chromium] Add unused GestureTapCancel + https://bugs.webkit.org/show_bug.cgi?id=96183 - Reviewed by Abhishek Arya. + Reviewed by Adam Barth. - * public/WebElement.h: - (WebElement): - - Add a comment to tagName(). - - Add a comment to hasTagName(). - - Declare hasHTMLTagName(), which is useful to check HTML tags. - * src/WebElement.cpp: - (WebKit::WebElement::hasHTMLTagName): Added. + This adds a new 'tap cancel' gesture type. This is temporarily unused, + so that we can change chromium to start sending the gesture type + without breaking anything. + + * public/WebInputEvent.h: + * src/PageWidgetDelegate.cpp: + (WebKit::PageWidgetDelegate::handleInputEvent): + * src/WebInputEventConversion.cpp: + (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::handleInputEvent): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): -2012-10-09 Jian Li <jianli@chromium.org> +2012-09-10 Mark Pilgrim <pilgrim@chromium.org> - Update the CSS property used to support draggable regions. - https://bugs.webkit.org/show_bug.cgi?id=97156 + [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository() + https://bugs.webkit.org/show_bug.cgi?id=95861 Reviewed by Adam Barth. - Update the code to use the new name annotatedRegions to work for - both features. + Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport. - * public/WebDraggableRegion.h: Rename dashboardRegions to annotatedRegions. - (WebDraggableRegion): - * src/ChromeClientImpl.cpp: Rename dashboardRegions to annotatedRegions. - (WebKit::ChromeClientImpl::annotatedRegionsChanged): - * src/ChromeClientImpl.h: Rename dashboardRegions to annotatedRegions. - (ChromeClientImpl): - * src/WebDocument.cpp: Rename dashboardRegions to annotatedRegions. - (WebKit::WebDocument::draggableRegions): + * public/WebSharedWorkerRepository.h: + (WebKit): + * src/SharedWorkerRepository.cpp: + (WebKit): + (WebKit::setSharedWorkerRepository): + (WebKit::sharedWorkerRepository): + (WebCore::SharedWorkerRepository::isAvailable): + (WebCore::SharedWorkerRepository::connect): + (WebCore::SharedWorkerRepository::documentDetached): + (WebCore::SharedWorkerRepository::hasSharedWorkers): + +2012-09-10 Catalin Badea <badea@adobe.com> + + webkit build for 64-bit Mac chromium + https://bugs.webkit.org/show_bug.cgi?id=95977 + + Reviewed by Eric Seidel. + + Ensure header completeness and use the correct include order. This fixes a compilation issues noticeable when building chromium for 64-bit Mac. + + * public/mac/WebSubstringUtil.h: + * src/mac/WebSubstringUtil.mm: + +2012-09-10 Adrienne Walker <enne@google.com> + + [chromium] Fix deadlock between WebMediaPlayerClientImpl dtor and PutCurrentFrame + https://bugs.webkit.org/show_bug.cgi?id=96010 -2012-10-09 Sadrul Habib Chowdhury <sadrul@chromium.org> + Reviewed by James Robinson. - [chromium] Add drop event for plugins. - https://bugs.webkit.org/show_bug.cgi?id=98827 + The key fix here is that the destructor no longer has a mutex. + The m_compositingMutex was supposedly protecting races between + ~WebMediaPlayerClientImpl and setVideoFrameProviderClient. The + former is only called from the main thread and the latter is called + from the compositor thread only when the main thread is blocked (and + it already asserts that this is the case). + + In addition, the m_providerMutex in CCVideoLayerImpl prevents the + destruction of WebMediaPlayerClientImpl, thus keeping the frame + acquired via getCurrentFrame alive until putCurrentFrame is called. + These functions are only called by the client, and comments are added + to the interface to better document this. + + To prevent a race between load() and getCurrentFrame/putCurrentFrame + (which are called from different threads) a new m_webMediaPlayerMutex + to replace part of what the old m_compositingMutex was doing. + + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): + (WebKit::WebMediaPlayerClientImpl::load): + (WebKit::WebMediaPlayerClientImpl::loadInternal): + (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient): + (WebKit::WebMediaPlayerClientImpl::getCurrentFrame): + (WebKit::WebMediaPlayerClientImpl::putCurrentFrame): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-09-10 Rick Byers <rbyers@chromium.org> + + [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment + https://bugs.webkit.org/show_bug.cgi?id=95996 Reviewed by Adam Barth. - Add conversion for drop events. + Switch from WebGestureEvent.boundingBox to new gesture-type specific + data fields. + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): - * public/WebDragStatus.h: - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::handleDragEvent): +2012-09-09 Keishi Hattori <keishi@webkit.org> -2012-10-09 Sheriff Bot <webkit.review.bot@gmail.com> + REGRESSION(r127558): Fix a crash in DateTimeChooserImpl::didClosePopup + https://bugs.webkit.org/show_bug.cgi?id=96222 - Unreviewed, rolling out r130811 and r130821. - http://trac.webkit.org/changeset/130811 - http://trac.webkit.org/changeset/130821 - https://bugs.webkit.org/show_bug.cgi?id=98831 + Reviewed by Kent Tamura. - Broke date-suggestion-picker-appearance-with-scroll-bar.html - (Requested by abarth|gardening on #webkit). + DateTimeChooserClient will delete DateTimeChooserImpl inside didEndChooser() + so we shouldn't be changing the members after that. + + Testing covered by fast/forms/date/calendar-picker-appearance-pre-100.html. + + * src/DateTimeChooserImpl.cpp: + (WebKit::DateTimeChooserImpl::didClosePopup): + +2012-09-09 Kenichi Ishibashi <bashi@chromium.org> + + [Chromium] Unreviewed gardening after r127907 + + Fix CCRenderPassTest::copyShouldBeIdenticalExceptIdAndQuads + + * tests/CCRenderPassTest.cpp: + (CCRenderPassSize): Changed type of m_id + +2012-09-09 Emil A Eklund <eae@chromium.org> + + Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect + https://bugs.webkit.org/show_bug.cgi?id=81413 + + Reviewed by David Hyatt. + + Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::computeBlockBounds): + (WebKit::WebViewImpl::applyAutofillSuggestions): + (WebKit::WebViewImpl::refreshAutofillPopup): + +2012-09-09 James Robinson <jamesr@chromium.org> + + [chromium] webkit_platform should only be linked into the webkit target + https://bugs.webkit.org/show_bug.cgi?id=96213 + + Reviewed by Adrienne Walker. + + The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only + makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it. + + * WebKit.gyp: + +2012-09-09 James Robinson <jamesr@chromium.org> + + [chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest + https://bugs.webkit.org/show_bug.cgi?id=96212 + + Reviewed by Adrienne Walker. + + The static ::create()s the test references currently are going away soon. + + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + (WebKit::TEST_F): + +2012-09-07 Benjamin Poulain <benjamin@webkit.org> + + Unreviewed prospective build fix. + + * tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include. + Remove the using directive from r127959. + +2012-09-07 Simon Hausmann <simon.hausmann@nokia.com> + + Unreviewed prospective build fix. + + Use WTF namespace like in other files in the same directory to resolve unqualified + adoptPtr correctly. + + * tests/WebCompositorInputHandlerImplTest.cpp: + +2012-09-07 James Robinson <jamesr@chromium.org> + + [chromium] Remove transitional WebCompositorSupport fallback code + https://bugs.webkit.org/show_bug.cgi?id=96155 + + Reviewed by Adrienne Walker. - * src/FindInPageCoordinates.cpp: - (WebKit::toNormalizedRect): * src/LinkHighlight.cpp: - (WebKit::convertTargetSpaceQuadToCompositedLayer): - * src/WebInputEventConversion.cpp: - (WebKit::convertLocationForRenderObject): + (WebKit::LinkHighlight::LinkHighlight): + (WebKit::LinkHighlight::startHighlightAnimation): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): -2012-10-09 Ben Murdoch <benm@google.com> +2012-09-07 James Robinson <jamesr@chromium.org> - [chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources() - https://bugs.webkit.org/show_bug.cgi?id=97689 + [chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals + https://bugs.webkit.org/show_bug.cgi?id=96151 - Reviewed by Adam Barth. + Reviewed by Adrienne Walker. + + Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals. + WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is + provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC. + + WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl + and storing its identifier for the didActivateCompositor call. From this point on the setup is the same as + before. + + WCIHI changes covered by unit tests, overall scrolling behavior manually tested. + + * WebKit.gypi: + * src/WebCompositorInputHandlerImpl.cpp: + (WebKit::WebCompositorInputHandlerImpl::fromIdentifier): + (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl): + (WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl): + (WebKit::WebCompositorInputHandlerImpl::setClient): + (WebKit::WebCompositorInputHandlerImpl::handleInputEvent): + (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): + (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): + (WebKit::WebCompositorInputHandlerImpl::bindToClient): + * src/WebCompositorInputHandlerImpl.h: + (WebCompositorInputHandlerImpl): + (WebKit::WebCompositorInputHandlerImpl::identifier): + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::createInputHandler): + (WebKit): + * src/WebLayerTreeViewImpl.h: + (WebLayerTreeViewImpl): + * src/WebToCCInputHandlerAdapter.cpp: Added. + (WebKit): + (WebKit::WebToCCInputHandlerAdapter::create): + (WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter): + (WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter): + (WebToCCInputHandlerAdapter::ClientAdapter): + (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter): + (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter): + (WebKit::WebToCCInputHandlerAdapter::bindToClient): + (WebKit::WebToCCInputHandlerAdapter::animate): + * src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h. + (WebKit): + (WebToCCInputHandlerAdapter): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): + (WebKit::WebViewImpl::createInputHandler): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/CCThreadedTest.cpp: + * tests/FakeCCLayerTreeHostClient.h: + * tests/WebCompositorInputHandlerImplTest.cpp: + (MockWebInputHandlerClient): + (WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient): + (WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient): + (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest): + (WebCompositorInputHandlerImplTest): + (WebKit::TEST_F): + +2012-09-07 David Reveman <reveman@chromium.org> + + [Chromium] Multiple commits without invalidation allowed per redraw. + https://bugs.webkit.org/show_bug.cgi?id=95661 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostTest.cpp: + (CCLayerTreeHostTestContinuousCommit): + (WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit): + (WebKitTests): + (WebKitTests::TEST_F): + (CCLayerTreeHostTestContinuousInvalidate): + (WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate): + (CCLayerTreeHostTestContinuousAnimate): + (WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate): + * tests/CCSchedulerStateMachineTest.cpp: + (WebCore::TEST): + +2012-09-07 Dominic Mazzoni <dmazzoni@google.com> + + AX: WebCore accessibility roles should be cross-platform + https://bugs.webkit.org/show_bug.cgi?id=94870 + + Reviewed by Chris Fleizach. - This change exposes the WebCore::SecurityOrigin::grantLoadLocalResources() - function to the Chromium WebKit API layer. This is needed in Chromium - to implement the Android WebView.loadDataWithBaseUrl function in a - compatible manner. + Add a new accessibility role. - Please see crbug.com/152223 for further information and the chromium - side patch. + * public/WebAccessibilityRole.h: + * src/AssertMatchingEnums.cpp: - * public/WebSecurityOrigin.h: - (WebSecurityOrigin): Add grantLoadLocalResources() API. - * src/WebSecurityOrigin.cpp: - (WebKit::WebSecurityOrigin::grantLoadLocalResources): - Implement the API by calling through to the WebCore function - of the same name. +2012-09-07 Dominic Mazzoni <dmazzoni@google.com> + + AX: Chromium needs access to canvasHasFallbackContent + https://bugs.webkit.org/show_bug.cgi?id=96124 + + Reviewed by Chris Fleizach. + + Expose canvasHasFallbackContent on Chromium. + + * public/WebAccessibilityObject.h: + (WebAccessibilityObject): + * src/WebAccessibilityObject.cpp: + (WebKit::WebAccessibilityObject::canvasHasFallbackContent): (WebKit): -2012-10-09 Julien Chaffraix <jchaffraix@webkit.org> +2012-09-07 Robert Kroeger <rjkroege@chromium.org> - [Chromium] Chromium DEPS has a stray directory, turning our Win bots red - https://bugs.webkit.org/show_bug.cgi?id=98817 + [chromium] Add touchscreen specific fling curve parametrization + https://bugs.webkit.org/show_bug.cgi?id=95997 - Reviewed by Dirk Pranke. + Reviewed by James Robinson. - * DEPS: Removed the stray directory which solved the redness on several of our bots. + Added a new set of fling curve parameters with a good feel for touchscreen + initiated flings. Renamed TouchpadFlingPlatformGestureCurve to + TouchFlingPlatformGestureCurve to better reflect that the class + can serve for both touchscreen and touchpad flings when appropriately + parametrized. Updated build files as necessary for the rename. -2012-10-09 Sadrul Habib Chowdhury <sadrul@chromium.org> + No new tests - existing tests apply. - [chromium] Make sure events are transformed correctly for plugins. - https://bugs.webkit.org/show_bug.cgi?id=89250 - Reviewed by Tony Chang. + * tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor. - The events arriving in WebPluginContainerImpl are in the coordinate - space of the page containing the plugin. Before the events are - dispatched to the plugin, it is necessary to convert them into the - plugin's own coordinate system. +2012-09-07 Dana Jansens <danakj@chromium.org> - * src/WebInputEventConversion.cpp: - (WebKit::convertLocationForRenderObject): Transforms an event location for the specified RenderObject. + [chromium] Make RenderPass ids hold both generating layer id and an index + https://bugs.webkit.org/show_bug.cgi?id=95500 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCRendererGLTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + +2012-09-07 Joshua Bell <jsbell@chromium.org> + + [Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect + https://bugs.webkit.org/show_bug.cgi?id=96122 + + Reviewed by Adam Barth. + + Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory + open() method now takes the "database callbacks", rather than being sent through + in a later call. + + Also, delete an obsolete method. + + * public/WebIDBFactory.h: (WebKit): - (WebKit::updateWebMouseEventFromWebCoreMouseEvent): Refactored code to reduce code-duplication for mouse and wheel events. - (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): - (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder): - (WebKit::addTouchPoints): - (WebKit::WebTouchEventBuilder::WebTouchEventBuilder): - (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): - * src/WebInputEventConversion.h: + (WebIDBFactory): Delete pre-version overload of open(). + (WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks. + +2012-09-07 Sami Kyostila <skyostil@google.com> + + [Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing + https://bugs.webkit.org/show_bug.cgi?id=95932 + + Reviewed by James Robinson. + + Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to + properly scroll it. + + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit::TEST_F): Re-enable the test. + +2012-09-07 James Robinson <jamesr@chromium.org> + + [chromium] Move some CC unit tests into correct gyp variable + https://bugs.webkit.org/show_bug.cgi?id=96048 + + Reviewed by Adrienne Walker. + + These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable. + + * WebKit.gypi: + +2012-09-07 James Robinson <jamesr@chromium.org> + + [chromium] Remove dead CCActiveGestureAnimation code and related classes + https://bugs.webkit.org/show_bug.cgi?id=96075 + + Reviewed by Adrienne Walker. + + Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily + evaluate the curve itself without intermediate classes. + + * src/WebCompositorInputHandlerImpl.cpp: + (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): + (WebKit::WebCompositorInputHandlerImpl::animate): + (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling): + * src/WebCompositorInputHandlerImpl.h: (WebCore): + (WebCompositorInputHandlerImpl): + * tests/PlatformGestureCurveTest.cpp: + * tests/WebCompositorInputHandlerImplTest.cpp: + +2012-09-07 James Robinson <jamesr@chromium.org> + + [chromium] Clean up dependencies in ScrollbarLayerChromiumTest + https://bugs.webkit.org/show_bug.cgi?id=96052 + + Reviewed by Adrienne Walker. + + Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest: + *) WebScrollbarImpl.h is #included, but not use + *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if + WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test. + + * tests/ScrollbarLayerChromiumTest.cpp: + (WebCore::TEST): + +2012-09-07 Dominic Mazzoni <dmazzoni@google.com> + + AX: ARIA spin button should support range value attributes + https://bugs.webkit.org/show_bug.cgi?id=96076 + + Reviewed by Chris Fleizach. + + Expose supportsRangeValue to simplify Chromium logic for when to + extract a value from a range. + + * public/WebAccessibilityObject.h: + (WebAccessibilityObject): + * src/WebAccessibilityObject.cpp: + (WebKit::WebAccessibilityObject::supportsRangeValue): (WebKit): - (WebMouseEventBuilder): - (WebMouseWheelEventBuilder): - (WebTouchEventBuilder): - (WebGestureEventBuilder): + +2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com> + + Simplify hitTestResultAtPoint and nodesFromRect APIs + https://bugs.webkit.org/show_bug.cgi?id=95720 + + Reviewed by Antonio Gomes. + + Update calls to new API. + + * src/ContextMenuClientImpl.cpp: + (WebKit::selectMisspelledWord): + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::characterIndexForPoint): * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::handleMouseEvent): - (WebKit::WebPluginContainerImpl::handleWheelEvent): + (WebKit::WebPluginContainerImpl::isRectTopmost): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleMouseUp): + (WebKit::WebViewImpl::computeBlockBounds): -2012-10-09 Garrett Casto <gcasto@chromium.org> +2012-09-07 Ilya Tikhonovsky <loislo@chromium.org> - Allow users to specify a different hover image for TextFieldDecorationElement - https://bugs.webkit.org/show_bug.cgi?id=93662 + Web Inspector: NMI: move WebCore specific code to separate header + https://bugs.webkit.org/show_bug.cgi?id=96101 - Reviewed by Kent Tamura. + Reviewed by Yury Semikhatsky. - * public/WebTextFieldDecoratorClient.h: - (WebTextFieldDecoratorClient): - (WebKit::WebTextFieldDecoratorClient::imageNameForHoverState): Allow users to specify the name of the image for mouseover. - * src/TextFieldDecoratorImpl.cpp: - (WebKit::TextFieldDecoratorImpl::imageForReadonlyState): - (WebKit::TextFieldDecoratorImpl::imageForHoverState): + I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h + + * tests/MemoryInstrumentationTest.cpp: + +2012-09-07 Ian Vollick <vollick@chromium.org> + + [chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed. + https://bugs.webkit.org/show_bug.cgi?id=95855 + + Reviewed by James Robinson. + + Added the following unit tests: + AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix + AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform + + * tests/AnimationTranslationUtilTest.cpp: + (WebKit::TEST): (WebKit): - * src/TextFieldDecoratorImpl.h: - (TextFieldDecoratorImpl): -2012-10-09 Keishi Hattori <keishi@webkit.org> +2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com> + + X11 Global Selection + https://bugs.webkit.org/show_bug.cgi?id=88238 + + Reviewed by Tony Chang. + + Use new editor command for pasting global selection. - Page popup should be smarter about its layout - https://bugs.webkit.org/show_bug.cgi?id=98499 + * src/EditorClientImpl.cpp: + (WebKit::EditorClientImpl::supportsGlobalSelection): + * src/EditorClientImpl.h: + (EditorClientImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleMouseUp): + +2012-09-07 Yoshifumi Inoue <yosin@chromium.org> + + We should have a localized string of empty for date time field + https://bugs.webkit.org/show_bug.cgi?id=96081 Reviewed by Kent Tamura. - * src/ColorChooserUIController.cpp: - (WebKit::ColorChooserUIController::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView. - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): Send anchorRectInScreen, rootViewRectInScreen, and confineToRootView. - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::init): We keep the originBoundsInRootView argument for MockPagePopupDriver. - (WebKit::WebPagePopupImpl::resize): WebPagePopupImpl isn't in charge of setting the popup position any more. - * src/WebPagePopupImpl.h: - (WebPagePopupImpl): + This patch add a function for getting localized string of empty field + value of date time fields for accessibility inside + ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. -2012-10-08 Dirk Pranke <dpranke@chromium.org> + These functions will be used by derived classes of DateTimeFieldElement. - Chromium DEPS roll r160657:160764. + Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name + to support "date", "datetime", "month" and "week" multiple fields input + UI. - Unreviewed. + * src/LocalizedStrings.cpp: + (WebCore::AXDateTimeFieldEmptyValueText): Added. + +2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r127822. + http://trac.webkit.org/changeset/127822 + https://bugs.webkit.org/show_bug.cgi?id=96073 + + It broke compilation on chromium debug bots (Requested by + loislo on #webkit). + + * tests/CCDrawQuadTest.cpp: + (WebCore::TEST): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCRenderPassTest.cpp: + (WebCore::TEST): + * tests/CCRenderSurfaceTest.cpp: + * tests/CCRendererGLTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + +2012-09-06 Dana Jansens <danakj@chromium.org> + + [chromium] Make RenderPass ids hold both generating layer id and an index + https://bugs.webkit.org/show_bug.cgi?id=95500 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCRendererGLTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + +2012-09-06 Yoshifumi Inoue <yosin@chromium.org> + + We should have localized strings of date time fields for accessibility + https://bugs.webkit.org/show_bug.cgi?id=96050 + + Reviewed by Kent Tamura. + + This patch adds functions for getting localized strings of date time + fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. + + These functions will be used by derived classes of DateTimeFieldElement. + + Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name + to support "date", "datetime", "month" and "week" multiple fields input + UI. + + * src/LocalizedStrings.cpp: + (WebCore::AXAMPMFieldText): Added. + (WebCore::AXDayOfMonthFieldText): Added. + (WebCore::AXHourFieldText): Added. + (WebCore::AXMillisecondFieldText): Added. + (WebCore::AXMinuteFieldText): Added. + (WebCore::AXMonthFieldText): Added. + (WebCore::AXSecondFieldText): Added. + (WebCore::AXWeekOfYearFieldText): Added. + (WebCore::AXYearFieldText): Added. + +2012-09-06 James Robinson <jamesr@chromium.org> + + [chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1 + https://bugs.webkit.org/show_bug.cgi?id=96024 + + Reviewed by Adam Barth. + + When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport. + We don't need to link anything in to WebKit.dll. + + * WebKit.gyp: + +2012-09-06 James Robinson <jamesr@chromium.org> + + [chromium] Use WebCompositorSupport functions instead of WebCompositor statics + https://bugs.webkit.org/show_bug.cgi?id=96007 + + Reviewed by Adrienne Walker. + + Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a + WebCompositorInitializer RAII class to simplify this somewhat tedious process. + + * WebKit.gypi: + * public/WebCompositorInputHandlerClient.h: + (WebCompositorInputHandlerClient): + * src/WebCompositorInputHandlerImpl.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::composite): + (WebKit::WebViewImpl::scheduleAnimation): + (WebKit::WebViewImpl::scheduleComposite): + * tests/CCPrioritizedTextureTest.cpp: + (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): + (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest): + (CCPrioritizedTextureTest): + * tests/CCRendererGLTest.cpp: + (CCRendererGLTest::CCRendererGLTest): + (CCRendererGLTest::SetUp): + (CCRendererGLTest): + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCThreadedTest.cpp: + (WebKitTests::CCThreadedTest::runTest): + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): + * tests/LayerChromiumTest.cpp: + * tests/LinkHighlightTest.cpp: + (WebCore::TEST): + * tests/TextureLayerChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + * tests/WebCompositorInitializer.h: Added. + (WebKit): + (WebKitTests): + (WebCompositorInitializer): + (WebKitTests::WebCompositorInitializer::WebCompositorInitializer): + (WebKitTests::WebCompositorInitializer::~WebCompositorInitializer): + * tests/WebCompositorInputHandlerImplTest.cpp: + (WebKit::TEST): + (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest): + (WebCompositorInputHandlerImplTest): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. * DEPS: -2012-10-08 Alec Flett <alecflett@chromium.org> +2012-09-06 Alec Flett <alecflett@chromium.org> - IndexedDB: remove autogenerated objectStore/index id code - https://bugs.webkit.org/show_bug.cgi?id=98085 + IndexedDB: make IDBKeyPath's string and array constructors explicit + https://bugs.webkit.org/show_bug.cgi?id=96004 Reviewed by Tony Chang. - Remove support for unused createObjectStore/createIndex. These - methods will go away entirely when - https://bugs.webkit.org/show_bug.cgi?id=98682 is fixed. + Fix test to use explicit constructor for IDBKeyPath. - * src/IDBDatabaseBackendProxy.cpp: - (WebKit::IDBDatabaseBackendProxy::createObjectStore): - * src/WebIDBDatabaseImpl.cpp: - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - * src/WebIDBObjectStoreImpl.cpp: - * src/WebIDBObjectStoreImpl.h: - (WebIDBObjectStoreImpl): + * tests/IDBDatabaseBackendTest.cpp: -2012-10-08 Sami Kyostila <skyostil@chromium.org> +2012-09-06 Adrienne Walker <enne@google.com> - Some non-scrollable elements are added to non-fast-scrollable region - https://bugs.webkit.org/show_bug.cgi?id=97927 + [chromium] Remove GraphicsContext references from ContentLayerChromiumTest + https://bugs.webkit.org/show_bug.cgi?id=96002 Reviewed by James Robinson. - Test that a non-scrollable RenderLayer isn't added to the non-fast scrollable - region. + This is a compositor unit test, so it shouldn't reference things + outside of the compositor like GraphicsContext. The + OpaqueRectTrackingContentLayerDelegateTest already tests opaque + tracking right at the time of paint. This test is about verifying that + transformed canvases work properly, so can just fake the opaque rect + coming back from the paint. + + * tests/ContentLayerChromiumTest.cpp: + (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient): + (WebKit::TEST): + +2012-09-06 Jeff Timanus <twiz@chromium.org> + + [Chromium] Remove contentsScale and related logic from GraphicsLayerChromium. + https://bugs.webkit.org/show_bug.cgi?id=95094 + + Reviewed by Adrienne Walker. + + In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to + try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of + contentsScale behaviour. + This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium. + + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + Inform the layer associated with the NCCH that it is to disregard the page scale factor. + Also remove now unused m_deviceScaleFactor and associated routines. + (WebKit::NonCompositedContentHost::setViewport): + * src/NonCompositedContentHost.h: + (NonCompositedContentHost): + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::setBoundsContainPageScale): + (WebKit): + (WebKit::WebContentLayerImpl::boundsContainPageScale): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::updateLayerTreeViewport): + * tests/CCLayerTreeHostTest.cpp: + (NoScaleContentLayerChromium): + (WebKitTests::NoScaleContentLayerChromium::create): + (WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium): + (WebKitTests): + (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers): + Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the + scale on the draw transforms remain identity. + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit): Remove now obsolete unit-test. + +2012-09-06 Adrienne Walker <enne@google.com> + + [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest + https://bugs.webkit.org/show_bug.cgi?id=95994 + + Reviewed by James Robinson. + + This compositor test shouldn't depend on code outside the compositor. + + * tests/ScrollbarLayerChromiumTest.cpp: + (WebCore::FakeWebScrollbar::create): + (FakeWebScrollbar): + (WebCore::TEST): + +2012-09-06 James Robinson <jamesr@chromium.org> + + [chromium] Put chromium implementations of WTF symbols in separate static library + https://bugs.webkit.org/show_bug.cgi?id=95933 + + Reviewed by Adam Barth. + + A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These + implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the + component build is a DLL. This moves these files into a static library that webkit depends on so targets can + statically link in wtf and these support files without depending directly on webkit. + + * WebKit.gyp: + +2012-09-06 Iain Merrick <husky@chromium.org> + + [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret + https://bugs.webkit.org/show_bug.cgi?id=93998 + + Reviewed by Adam Barth. + + These provide the same functionality selectRange(WebPoint, WebPoint), + with finer-grained control needed on the Android platform. By passing + allowCollapsedSelection=false, we can ensure the selection stays at + least one character wide. + + I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by + calling the new methods. The existing test passes, and I've added new + tests for the new methods. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::selectRange): + (WebKit): + (WebKit::WebFrameImpl::moveSelectionStart): + (WebKit::WebFrameImpl::moveSelectionEnd): + (WebKit::WebFrameImpl::moveCaret): + * src/WebFrameImpl.h: + (WebFrameImpl): + * tests/WebFrameTest.cpp: + * tests/data/text_selection.html: Added. + +2012-09-06 Robert Kroeger <rjkroege@chromium.org> + + [chromium] Enable different fling behaviour for touchscreen and touchpad + https://bugs.webkit.org/show_bug.cgi?id=95756 + + Reviewed by James Robinson. + + Add support for a flag on WebGestureEvents that differentiates GestureFlingStart + events by their originating device and pass this flag to a factory that produces + different device specific fling curves based on the value of the flag. + + * public/WebActiveWheelFlingParameters.h: + (WebActiveWheelFlingParameters): Store source device for transfer to mainthread. + (WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters): + * public/WebInputEvent.h: Added source device flag to WebGestureEvent. + * src/WebCompositorInputHandlerImpl.cpp: + (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to + obtain device-appropriate fling curve. + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate + fling curve. + (WebKit::WebViewImpl::transferActiveWheelFlingAnimation): + +2012-09-05 Sam Weinig <sam@webkit.org> + + Part 2 of removing PlatformString.h, remove PlatformString.h + https://bugs.webkit.org/show_bug.cgi?id=95931 + + Reviewed by Adam Barth. + + Remove PlatformString.h + + * src/ContextMenuClientImpl.cpp: + * src/EditorClientImpl.cpp: + * src/InspectorFrontendClientImpl.cpp: + * src/LocalFileSystemChromium.cpp: + * src/SpeechInputClientImpl.cpp: + * src/SpeechRecognitionClientProxy.h: + * src/WebDevToolsAgentImpl.cpp: + * src/WebDevToolsFrontendImpl.cpp: + * src/WebDevToolsFrontendImpl.h: + * src/WebEntities.h: + * src/WebFrameImpl.h: + * src/WorkerFileSystemCallbacksBridge.h: + * tests/UniscribeHelperTest.cpp: + +2012-09-06 Dana Jansens <danakj@chromium.org> + + [chromium] Add a customized copy() method to CCRenderPassDrawQuad + https://bugs.webkit.org/show_bug.cgi?id=95871 + + Reviewed by Adrienne Walker. + + * tests/CCDrawQuadTest.cpp: + (WebCore): + (WebCore::TEST): + +2012-09-06 Ilya Tikhonovsky <loislo@chromium.org> + + Unreviewed Web Inspector: test fix. + + * tests/MemoryInstrumentationTest.cpp: + (StringOwnerInstrumented): + (WebCore::StringOwnerInstrumented::StringOwnerInstrumented): + (WebCore::StringOwnerInstrumented::reportMemoryUsage): + (WebCore): + (WebCore::TEST): + +2012-09-06 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol. + https://bugs.webkit.org/show_bug.cgi?id=95957 + + Reviewed by Yury Semikhatsky. + + Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol + instead of MemoryBlockNames hardcoded in InspectorMemoryAgent.. + At a later stage, when each memory type is counted in MemoryInstrumentation + we will build the blocks hierarchy for the front-end automatically. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::InstrumentedUndefined::InstrumentedUndefined): + (WebCore::InstrumentedUndefined::reportMemoryUsage): + (WebCore::InstrumentedDOM::InstrumentedDOM): + (WebCore::InstrumentedDOM::reportMemoryUsage): + (InstrumentedDOM): + (WebCore::TEST): + +2012-09-06 Kenichi Ishibashi <bashi@chromium.org> + + [Chromium] Win build fix attempt after r127715 + + * tests/CCRenderPassTest.cpp: + (WebCore::TEST): + +2012-09-06 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-09-06 Dana Jansens <danakj@chromium.org> + + [chromium] Add a copy() method to CCRenderPass + https://bugs.webkit.org/show_bug.cgi?id=95485 + + Reviewed by Adrienne Walker. + + * WebKit.gypi: + * tests/CCRenderPassTest.cpp: Added. + (CCTestRenderPass): + (CCTestRenderPass::quadList): + (CCTestRenderPass::sharedQuadStateList): + (CCRenderPassSize): + (TEST): + +2012-09-06 Peter Beverloo <peter@chromium.org> + + [Chromium] Chromium Mac build fix after revision r127711 + https://bugs.webkit.org/show_bug.cgi?id=95958 - The test in this patch consists of a web page where both the html and - body elements clip horizontal overflow. This results in a hierarchy - where the body element gets a scrollable RenderLayer. However, that - layer isn't (interactively) scrollable because while the scroll geometry - is calculated based on the amount of overflow, the scroll bars are - hidden because of the "overflow-x: hidden" style. + Unreviewed build fix. - Previously this layer would have made the entire page part of the - non-fast scrollable region. With this patch, - RenderLayer::allowScrolling() is used as a pre-requisite for expanding - the region, thus avoiding the problem. + This is a clear typo in the source file, so changing the function to + call locationModifiersFromWindowsKeyCode instead. - * tests/ScrollingCoordinatorChromiumTest.cpp: + * src/mac/WebInputEventFactory.mm: + (WebKit::WebInputEventFactory::keyboardEvent): + +2012-09-06 Raymes Khoury <raymes@chromium.org> + + Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents + https://bugs.webkit.org/show_bug.cgi?id=94142 + + Reviewed by Tony Chang. + + Previously we distinguished between left/right Shift/Ctrl/Alt in + WebInputEvents by using the location-specific virtual keycodes (e.g. + VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events + always returns the non-locational version (e.g. VK_SHIFT). + Furthermore, KeyboardEvent also returns + non-locational keycodes and separates the location information which + matches the behavior described in the DOM3 + spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We + should be consistent with this in our representation of key events. + This patch changes WebInputEvents so they always store the + non-locational keycode and location information is stored in + modifiers. Since this only changes internal representation, no new + tests are added. + + This patch also ensures that when KeyboardEvents are converted back to + WebInputEvents location information is preserved (which was not + happening before). This is important so that key location information + is passed on to plugins. A unittest is added for this. + + * WebKit.gypi: + * public/WebInputEvent.h: + (WebKeyboardEvent): + * src/WebInputEvent.cpp: + (WebKit): + (WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation): + (WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode): + * src/WebInputEventConversion.cpp: + (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): + (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): + * src/android/WebInputEventFactory.cpp: + (WebKit::WebInputEventFactory::keyboardEvent): + * src/gtk/WebInputEventFactory.cpp: + (WebKit::WebInputEventFactory::keyboardEvent): + * src/mac/WebInputEventFactory.mm: + (WebKit::WebInputEventFactory::keyboardEvent): + * src/win/WebInputEventFactory.cpp: + (WebKit::getLocationModifier): + (WebKit::WebInputEventFactory::keyboardEvent): + * tests/WebInputEventConversionTest.cpp: Added. + +2012-09-06 Adam Barth <abarth@webkit.org> + + Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly. + https://bugs.webkit.org/show_bug.cgi?id=91110 + + Reviewed by Tony Chang. + + Prior to this patch, we were ignoring the user-scalable property of + viewport meta tags. This patch enforces the user-scalable property by + claming the minimum-scale and maximum-scale values, effectively + preventing user scaling. This approach isn't perfect, as discussed in + https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement + over the status quo. + + This approach is also used by EFL, GTK, and Qt. + + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): + +2012-09-05 Dana Jansens <danakj@chromium.org> + + [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState + https://bugs.webkit.org/show_bug.cgi?id=95374 + + Reviewed by Adrienne Walker. + + * WebKit.gypi: + * tests/CCDrawQuadTest.cpp: Added. + (TEST): + (createSharedQuadState): + (compareDrawQuad): + +2012-09-05 Kenichi Ishibashi <bashi@chromium.org> + + [Chromium] Unreviewed gardening + + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit::TEST_F): Disabled applyScrollToScrollableArea() + +2012-09-05 Tony Chang <tony@chromium.org> + + [chromium] Remove dependency on webkit_user_agent + https://bugs.webkit.org/show_bug.cgi?id=95886 + + Reviewed by Adam Barth. + + The code isn't used by webkit_unit_tests. + + * WebKitUnitTests.gyp: + +2012-09-05 Nate Chapin <japhet@chromium.org> + + Test for https://bugs.webkit.org/show_bug.cgi?id=91685 + + Reviewed by Adam Barth. + + * tests/WebFrameTest.cpp: + +2012-09-05 Rick Byers <rbyers@chromium.org> + + Use new type-specific WebGestureEvent fields + https://bugs.webkit.org/show_bug.cgi?id=95573 + + Reviewed by James Robinson. + + Chromium has been updated to store gesture-type specific details in the + new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and + crrev.com/154959), so we can now rely on them. + + * src/WebCompositorInputHandlerImpl.cpp: + Update the compositor scroll, pinch and fling handling to use these new fields. + (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): + (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): + * src/WebInputEventConversion.cpp: + Update PlatformGestureEvent/WebGestureEvent conversion to use the new + fields, storing into the existing overloaded PlatformGestureEvent + fields (which will be cleaned up in my next CL). + (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): + (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + Update fling scrolling implementation for correct location of velocity. + * tests/WebCompositorInputHandlerImplTest.cpp: (WebKit::TEST_F): + Update tests to use the new fields. + + +2012-09-05 James Robinson <jamesr@chromium.org> + + [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test + https://bugs.webkit.org/show_bug.cgi?id=95819 + + Reviewed by Adam Barth. + + This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode + upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from + webkit.dll in the component build. + + * tests/WebLayerTest.cpp: + +2012-09-05 Victoria Kirst <vrk@chromium.org> + + Add the duration attribute to MediaSource + https://bugs.webkit.org/show_bug.cgi?id=95149 + + Reviewed by Eric Carlson. + + Add support for the duration attribute recently added to the MediaSource spec. + http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration + + * public/WebMediaPlayer.h: + (WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition. + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer. (WebKit): - * tests/data/clipped-body.html: Added. + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-09-05 Mihai Parparita <mihaip@chromium.org> + + [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime + https://bugs.webkit.org/show_bug.cgi?id=95865 -2012-10-08 Sailesh Agrawal <sail@chromium.org> + Reviewed by Darin Fisher. - Mac Chromium: Ignore system numpad modifier - https://bugs.webkit.org/show_bug.cgi?id=97161 + Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into + no-ops. + + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enablePushState): + (WebKit::WebRuntimeFeatures::isPushStateEnabled): + +2012-09-05 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Remove getRenderStyleForStrike from PlatformSupport + https://bugs.webkit.org/show_bug.cgi?id=95363 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * public/linux/WebFontInfo.h: + * public/linux/WebFontRenderStyle.h: + * src/PlatformSupport.cpp: + (WebCore): + +2012-09-05 Ilya Tikhonovsky <loislo@chromium.org> + + Unreviewed: WebInspector: remove accidentally committed speed test. + + * tests/MemoryInstrumentationTest.cpp: + +2012-09-05 Sami Kyostila <skyostil@chromium.org> + + [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium + https://bugs.webkit.org/show_bug.cgi?id=95679 + + Reviewed by James Robinson. + + Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer. + + * src/WebLayerImpl.cpp: + (WebKit::WebLayerImpl::setMaxScrollPosition): + (WebKit): + (WebKit::WebLayerImpl::setScrollClient): + (WebKit::WebLayerImpl::scrollBy): + * src/WebLayerImpl.h: + (WebLayerImpl): + * tests/CCLayerTreeHostTest.cpp: + * tests/GraphicsLayerChromiumTest.cpp: + (MockScrollableArea): + (WebKit): + (WebKit::TEST_F): + * tests/WebLayerTest.cpp: + +2012-09-05 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation. + https://bugs.webkit.org/show_bug.cgi?id=95850 + + Reviewed by Yury Semikhatsky. + + I'd like to extract MemoryObjectTypes into separate classes. + After that we will be able to move core NMI instrumentation code to WTF. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::Instrumented::reportMemoryUsage): + (WebCore::InstrumentedRefPtr::reportMemoryUsage): + (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): + (WebCore::InstrumentedOther::reportMemoryUsage): + (WebCore::InstrumentedDOM::reportMemoryUsage): + (WebCore::TEST): + (WebCore::NonVirtualInstrumented::reportMemoryUsage): + +2012-09-05 Peter Beverloo <peter@chromium.org> + + Unreviewed, rolling out r127590. + http://trac.webkit.org/changeset/127590 + + Broke the Chromium bots because of a compile error in the compositor. + + * DEPS: + +2012-09-05 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-09-04 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers. + https://bugs.webkit.org/show_bug.cgi?id=95739 + + Reviewed by Yury Semikhatsky. + + When we go deeper into different parts of browser like skia, chromium itself etc. + we can't use a single enum for all reported object types. + The current idea is to use plain simple strings as ObjectType identifiers. + In the future patches we will extract these identifiers into separate class or namespace + and and split it between components. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::TEST): + (WebCore): + +2012-09-04 Keishi Hattori <keishi@webkit.org> + + Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer + https://bugs.webkit.org/show_bug.cgi?id=95681 + + Reviewed by Kent Tamura. + + * WebKit.gyp: + * src/ChromeClientImpl.cpp: + (WebKit): + (WebKit::ChromeClientImpl::openDateTimeChooser): + * src/ChromeClientImpl.h: + (WebCore): + (ChromeClientImpl): + * src/DateTimeChooserImpl.cpp: Added. + (WebKit): + (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): + (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl): + (WebKit::DateTimeChooserImpl::endChooser): + (WebKit::DateTimeChooserImpl::contentSize): + (WebKit::DateTimeChooserImpl::writeDocument): + (WebKit::DateTimeChooserImpl::setValueAndClosePopup): + (WebKit::DateTimeChooserImpl::didClosePopup): + * src/DateTimeChooserImpl.h: + (WebCore): + (WebKit): + (DateTimeChooserImpl): + +2012-09-04 Adam Barth <abarth@chromium.org> + + Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS + https://bugs.webkit.org/show_bug.cgi?id=95798 + + Reviewed by Eric Seidel. + + * src/WebAccessibilityObject.cpp: + (WebKit::WebAccessibilityObject::keyboardShortcut): + - Remove use of WTF::String::operator+= + * src/WebPageSerializerImpl.cpp: + - Whitelist use of WTF::String::operator+=. Remove this use will take + some more careful thought. + +2012-09-04 Alec Flett <alecflett@chromium.org> + + IndexedDB: remove final createIndex backend glue + https://bugs.webkit.org/show_bug.cgi?id=95385 + + Reviewed by Adam Barth. + + Remove chromium glue for old key-generation code. + + * public/WebIDBKey.h: + (WebIDBKey): + * src/WebIDBKey.cpp: + +2012-09-04 Tien-Ren Chen <trchen@chromium.org> + + [chromium] Rename WebViewClient::handleDisambiguationPopup + https://bugs.webkit.org/show_bug.cgi?id=95529 + + Reviewed by Adam Barth. + + Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it. + + * public/WebViewClient.h: + (WebKit::WebViewClient::didTapMultipleTargets): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + * tests/WebFrameTest.cpp: + +2012-09-03 Tao Bai <michaelbai@chromium.org> + + Added ANDROID_GDBSERVER definition for Ant + https://bugs.webkit.org/show_bug.cgi?id=95265 + + Reviewed by Adam Barth. + + ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN + is only used for finding the gdbserver. + + * WebKitUnitTests.gyp: + +2012-09-03 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-09-03 Tommy Widenflycht <tommyw@google.com> + + MediaStream API: Add Ice-related functionality to RTCPeerConnection + https://bugs.webkit.org/show_bug.cgi?id=95565 + + Reviewed by Adam Barth. + + * src/AssertMatchingEnums.cpp: + +2012-09-01 James Robinson <jamesr@chromium.org> + + Unreviewed chromium buildfix when use_libcc_for_compositor=1 + + This gyp target was renamed downstream. + + * WebKit.gyp: + +2012-09-01 Tommy Widenflycht <tommyw@google.com> + + MediaStream API: Add MediaStream management to RTCPeerConnection + https://bugs.webkit.org/show_bug.cgi?id=95543 + + Reviewed by Adam Barth. + + * src/AssertMatchingEnums.cpp: + +2012-08-31 Koji Ishii <kojiishi@gmail.com> + + Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows + https://bugs.webkit.org/show_bug.cgi?id=51450 Reviewed by Tony Chang. - On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms. + When writing-mode is vertical-*, Chromium Win does not render glyphs correctly. + http://dev.w3.org/csswg/css3-writing-modes/#writing-mode + Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name, + and vertical alternate glyphs (OpenType 'vert' feature) is not enabled. + CJK characters drawn at wrong baseline position is also fixed. + In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty + in Chromium Win but they were implemented because they were needed to draw vertical flow correctly. + + Note that this patch does not address issues in vertical flow for complex code path. + The issue is under discussion with Google people and it will not be fixed in short term. + + Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations. + + * features.gypi: ENABLE_OPENTYPE_VERTICAL=1. + +2012-08-31 W. James MacLean <wjmaclean@chromium.org> + + [chromium] Make link highlighter use same node selection criteria as Chromium for Android. + https://bugs.webkit.org/show_bug.cgi?id=95371 + + Reviewed by James Robinson. + + This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android. + + * src/WebViewImpl.cpp: + (WebKit::highlightConditions): + (WebKit::WebViewImpl::bestTouchLinkNode): + * tests/data/test_touch_link_highlight.html: + +2012-08-31 James Robinson <jamesr@chromium.org> + + [chromium] Consolidate geometry unit testing functions for cc + https://bugs.webkit.org/show_bug.cgi?id=95526 + + Reviewed by Julien Chaffraix. + + This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for + testing rect equality. + + * WebKit.gypi: + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCGeometryTestUtils.cpp: Added. + (WebKitTests): + (WebKitTests::ExpectTransformationMatrixEq): + * tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h. + (WebKit): + (WebKitTests): + * tests/CCLayerTreeHostTest.cpp: + * tests/CCMathUtilTest.cpp: + (WebKit::TEST): + * tests/TiledLayerChromiumTest.cpp: + +2012-08-31 James Robinson <jamesr@chromium.org> + + [chromium] Clean up Web*Layer initialization paths + https://bugs.webkit.org/show_bug.cgi?id=95523 + + Reviewed by Darin Fisher. + + Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling + implementation. Also normalizes naming conventions in these files. + + * src/WebAnimationImpl.cpp: + (WebKit::WebAnimation::create): + (WebKit::WebAnimationImpl::WebAnimationImpl): + * src/WebAnimationImpl.h: + (WebAnimationImpl): + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::WebContentLayerImpl): + (WebKit::WebContentLayerImpl::~WebContentLayerImpl): + (WebKit::WebContentLayerImpl::layer): + (WebKit::WebContentLayerImpl::setDoubleSided): + (WebKit::WebContentLayerImpl::setContentsScale): + (WebKit::WebContentLayerImpl::setUseLCDText): + (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebFloatAnimationCurveImpl.cpp: + (WebKit::WebFloatAnimationCurve::create): + (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl): + * src/WebFloatAnimationCurveImpl.h: + (WebFloatAnimationCurveImpl): + * src/WebIOSurfaceLayerImpl.cpp: + (WebKit::WebIOSurfaceLayer::create): + (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): + * src/WebIOSurfaceLayerImpl.h: + (WebIOSurfaceLayerImpl): + * src/WebImageLayerImpl.cpp: + (WebKit::WebImageLayer::create): + (WebKit::WebImageLayerImpl::WebImageLayerImpl): + * src/WebImageLayerImpl.h: + (WebImageLayerImpl): + * src/WebLayerImpl.cpp: + (WebKit::WebLayer::create): + (WebKit): + (WebKit::WebLayerImpl::WebLayerImpl): + * src/WebLayerImpl.h: + (WebLayerImpl): + * src/WebScrollbarLayerImpl.cpp: + (WebKit::WebScrollbarLayer::create): + (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): + * src/WebScrollbarLayerImpl.h: + (WebScrollbarLayerImpl): + * src/WebSolidColorLayerImpl.cpp: + (WebKit::WebSolidColorLayer::create): + (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): + * src/WebSolidColorLayerImpl.h: + (WebSolidColorLayerImpl): + * src/WebTransformAnimationCurveImpl.cpp: + (WebKit::WebTransformAnimationCurve::create): + (WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl): + * src/WebTransformAnimationCurveImpl.h: + (WebTransformAnimationCurveImpl): + * src/WebVideoLayerImpl.cpp: + (WebKit::WebVideoLayer::create): + (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): + * src/WebVideoLayerImpl.h: + (WebVideoLayerImpl): + +2012-08-31 Tony Chang <tony@chromium.org> + + Remove ENABLE_CSS3_FLEXBOX compile time flag + https://bugs.webkit.org/show_bug.cgi?id=95382 + + Reviewed by Ojan Vafai. + + Everyone is already enabling this by default and the spec has stablized. + + * features.gypi: + +2012-08-31 Christopher Cameron <ccameron@chromium.org> + + [chromium] Add main versus impl thread asserts + https://bugs.webkit.org/show_bug.cgi?id=95596 + + Reviewed by James Robinson. + + Add asserts to prioritized texture manager that specify that a + function be called on the main or impl thread. + + Add debug signs that the main thread is blocked to the threaded + proxy. + + Add a mechanism to simultaneously set the thread to the impl thread + and indicate that the main thread is blocked. + + Update tests that hit asserts in the prioritized texture manager to + set their impl thread and main thread blocked state correctly. + + * tests/CCPrioritizedTextureTest.cpp: + (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): + (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest): + (WTF::CCPrioritizedTextureTest::validateTexture): + (WTF::TEST_F): + * tests/TiledLayerChromiumTest.cpp: + +2012-08-30 James Robinson <jamesr@chromium.org> + + [chromium] Put compositor client interfaces in separate headers, normalize naming + https://bugs.webkit.org/show_bug.cgi?id=95522 + + Reviewed by Adam Barth. + + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::~WebContentLayerImpl): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebExternalTextureLayerImpl.h: + * src/WebLayerTreeViewImpl.h: + (WebCore): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WebKitTests::ContentLayerChromiumWithUpdateTracking::create): + (WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking): + (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers): + (WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit): + (WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate): + (WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources): + (CCLayerTreeHostTestLostContextWhileUpdatingResources): + * tests/ContentLayerChromiumTest.cpp: + (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient): + (WebKit::TEST): + +2012-08-31 Gavin Peters <gavinp@chromium.org> + + [chromium] DEPS roll with a test skip. + https://bugs.webkit.org/show_bug.cgi?id=95601 + + Unreviewed gardening & DEPS roll. + + + fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this) + + * DEPS: + +2012-08-31 Gavin Peters <gavinp@chromium.org> + + [chromium] Disable WebViewTest.AutoResizeMinimumSize + https://bugs.webkit.org/show_bug.cgi?id=95571 + + Unreviewed gardening. + + Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this. + + * tests/WebViewTest.cpp: + +2012-08-30 James Robinson <jamesr@chromium.org> + + [chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected + https://bugs.webkit.org/show_bug.cgi?id=95520 + + Reviewed by Darin Fisher. - My fix is to only rely on keycode to decide when to set the numpad modifier. + Adopt the return value of WebCompositorSupport explicitly. - This code is not exersided by layout tests so I added a new unit test for this. + * src/LinkHighlight.cpp: + (WebKit::LinkHighlight::LinkHighlight): + (WebKit::LinkHighlight::startHighlightAnimation): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + +2012-08-30 James Robinson <jamesr@chromium.org> + + [chromium] Make webkit_compositor specific unit test compilation conditional on gyp var + https://bugs.webkit.org/show_bug.cgi?id=95401 + + Reviewed by Dirk Pranke. + + If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere. + * WebKit.gyp: * WebKit.gypi: * WebKitUnitTests.gyp: - * src/mac/WebInputEventFactory.mm: - (WebKit::isKeypadEvent): Removed check for numpad modifier. - * tests/WebInputEventFactoryTestMac.mm: Added. - (TEST): Added new test for WebInputEventFactory::keyboardEvent(). -2012-10-08 Sheriff Bot <webkit.review.bot@gmail.com> +2012-08-27 James Robinson <jamesr@chromium.org> + + [chromium] Add CompositorSupport interface for constructing compositor classes + https://bugs.webkit.org/show_bug.cgi?id=95040 + + Reviewed by Darin Fisher. + + * src/LinkHighlight.cpp: + (WebKit::LinkHighlight::LinkHighlight): + (WebKit::LinkHighlight::startHighlightAnimation): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + * src/WebMediaPlayerClientImpl.h: + (WebKit): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + * src/WebPluginContainerImpl.h: + (WebKit): + +2012-08-30 Gavin Peters <gavinp@chromium.org> + + [chromium] Disable CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread + https://bugs.webkit.org/show_bug.cgi?id=95472 + + Unreviewed gardening. + + When landing r127079, this test was re-enabled, and has not passed since. I'm disabling it, and created bug 95473 to track fixing this issue. + + * tests/CCLayerTreeHostTest.cpp: + (WebKitTests::TEST_F): + +2012-08-30 James Robinson <jamesr@chromium.org> + + [chromium] Clean up some webkit compositor unit tests + https://bugs.webkit.org/show_bug.cgi?id=95410 + + Reviewed by Adrienne Walker. + + This adds includes that were implicitly being picked up, removes ones that weren't being used, removes + dead code, adds OVERRIDE on functions that OVERRIDE, and deinlines virtuals that the chromium clang style + plugin is unhappy about. + + * tests/CCAnimationTestCommon.cpp: + (WebKitTests::FakeFloatAnimationCurve::duration): + (WebKitTests): + (WebKitTests::FakeFloatAnimationCurve::getValue): + (WebKitTests::FakeTransformTransition::duration): + (WebKitTests::FakeFloatTransition::duration): + (WebKitTests::FakeLayerAnimationControllerClient::id): + (WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation): + (WebKitTests::FakeLayerAnimationControllerClient::opacity): + (WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation): + (WebKitTests::FakeLayerAnimationControllerClient::transform): + * tests/CCAnimationTestCommon.h: + (FakeFloatAnimationCurve): + (FakeTransformTransition): + (FakeFloatTransition): + (FakeLayerAnimationControllerClient): + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat): + (WebKitTests): + (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds): + (WebKitTests::FakeTiledLayerChromium::textureManager): + (WebKitTests::FakeTiledLayerChromium::textureUpdater): + (WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds): + (WebKitTests::FakeTextureUploader::isBusy): + (WebKitTests::FakeTextureUploader::uploadTexture): + * tests/CCTiledLayerTestCommon.h: + (FakeLayerTextureUpdater): + (FakeTiledLayerChromium): + (FakeTiledLayerWithScaledBounds): + (FakeTextureUploader): + * tests/FakeWebCompositorOutputSurface.h: + * tests/TextureCopierTest.cpp: + (MockContext): + (TEST): + * tests/ThrottledTextureUploaderTest.cpp: + (WebKit::TEST): + * tests/WebLayerTreeViewTest.cpp: + +2012-08-29 Hironori Bono <hbono@chromium.org> + + Fix Chromium builds (Win and Mac) + https://bugs.webkit.org/show_bug.cgi?id=95421 + + Reviewed by James Robinson. + + This change replaces 'class WebRect' with 'struct WebRect' to fix build breaks + on the "Chromium Mac Release" and the "Chromium Win Release" bot caused by + r127095. + + * public/WebViewClient.h: + (WebKit): + +2012-08-29 Nat Duca <nduca@chromium.org> + + [chromium] setNeedsAnimate should not cause commitRequested to become true + https://bugs.webkit.org/show_bug.cgi?id=95393 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostTest.cpp: + (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested): + (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested): + +2012-08-29 Tien-Ren Chen <trchen@chromium.org> + + [chromium] Implement disambiguation popup (a.k.a. Link Preview) + https://bugs.webkit.org/show_bug.cgi?id=94182 + + Reviewed by Adam Barth. + + In this new implementation, we add a new WebViewClient::handleDisambiguationPopup delegate. + The disambiguation sequence will be initiated by the gesture event handler + in WebViewImpl if an ambiguous tap is detected, then + m_client->handleDisambiguationPopup will be called, so the embedder can + decide whether to swallow the touch event and show a popup. + + New test: WebFrameTest.DisambiguationPopupTest + + * WebKit.gyp: + * features.gypi: + * public/WebInputEvent.h: + (WebGestureEvent): + (WebKit::WebGestureEvent::WebGestureEvent): + * public/WebTouchCandidatesInfo.h: Removed. + * public/WebView.h: + (WebKit): + * public/WebViewClient.h: + (WebKit): + (WebViewClient): + (WebKit::WebViewClient::triggersLinkPreview): + * src/WebInputEvent.cpp: + (SameSizeAsWebGestureEvent): + * src/WebViewImpl.cpp: + (WebKit): + (WebKit::WebViewImpl::handleGestureEventWithLinkPreview): + (WebKit::WebViewImpl::handleGestureEvent): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-29 Dominic Mazzoni <dmazzoni@google.com> + + AX: Canvas should have a distinct role + https://bugs.webkit.org/show_bug.cgi?id=95248 + + Reviewed by Chris Fleizach. + + Add support for canvas accessibility role. + + * public/WebAccessibilityRole.h: + * src/AssertMatchingEnums.cpp: + +2012-08-29 Alex Sakhartchouk <alexst@chromium.org> + + [chromium] CCLayerTreeHost::finishCommitOnImplThread wrong setter order + https://bugs.webkit.org/show_bug.cgi?id=94828 + + Reviewed by Adrienne Walker. + + Testing that setDeviceScaleFactor properly changes maxScrollPosition + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-29 James Robinson <jamesr@chromium.org> + + Unreviewed, rolling out r126956. + http://trac.webkit.org/changeset/126956 + https://bugs.webkit.org/show_bug.cgi?id=94721 + + Breaks several unit tests + + * tests/CCSchedulerTest.cpp: + (WebKitTests::FakeCCSchedulerClient::reset): + (WebKitTests::FakeCCSchedulerClient::setHasMoreResourceUpdates): + (WebKitTests::TEST): + * tests/CCTextureUpdateControllerTest.cpp: + +2012-08-29 James Robinson <jamesr@chromium.org> + + [chromium] Register/unregister contents layers with GraphicsLayerChromium + https://bugs.webkit.org/show_bug.cgi?id=95379 + + Reviewed by Adrienne Walker. + + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): + +2012-08-29 W. James MacLean <wjmaclean@chromium.org> + + [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights. + https://bugs.webkit.org/show_bug.cgi?id=95119 + + Reviewed by Adam Barth. + + Add support to WebSettings for flag to enable/disable gesture tap highlights. Relies on existing tests. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::WebSettingsImpl): + (WebKit::WebSettingsImpl::setGestureTapHighlightEnabled): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + (WebKit::WebSettingsImpl::gestureTapHighlightEnabled): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + +2012-08-29 Dana Jansens <danakj@chromium.org> + + [chromium] Remove HUD layer when rootLayer is set to null + https://bugs.webkit.org/show_bug.cgi?id=95257 + + Reviewed by James Robinson. + + * WebKit.gypi: + * tests/CCHeadsUpDisplayTest.cpp: Added. + (CCHeadsUpDisplayTest): + (DrawsContentLayerChromium): + (DrawsContentLayerChromium::create): + (DrawsContentLayerChromium::DrawsContentLayerChromium): + (CCHudWithRootLayerChange): + (CCHudWithRootLayerChange::CCHudWithRootLayerChange): + (TEST_F): + * tests/CCLayerTreeHostTest.cpp: + * tests/CCThreadedTest.cpp: + (WebKitTests::CCThreadedTest::runTest): + * tests/CCThreadedTest.h: + (WebKitTests::CCThreadedTest::initializeSettings): + (CCThreadedTest): + +2012-08-29 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Add more unit test coverage for semantics of drawableContentRect and visibleContentRect + https://bugs.webkit.org/show_bug.cgi?id=94542 + + Reviewed by Adrienne Walker. + + To make upcoming refactors safer, it was appropriate to (finally) + add unit tests that check the behavior of drawableContentRect and + visibleContentRect computations in calculateDrawTransforms. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-08-29 W. James MacLean <wjmaclean@chromium.org> + + [chromium] Link highlight should clear on page navigation. + https://bugs.webkit.org/show_bug.cgi?id=95129 + + Reviewed by James Robinson. + + Modified WebViewImpl to clear link highlight when navigating to new url. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::didCommitLoad): + +2012-08-29 James Robinson <jamesr@chromium.org> + + [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1 + https://bugs.webkit.org/show_bug.cgi?id=94995 + + Reviewed by Adam Barth. + + * WebKit.gyp: + +2012-08-28 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Do not clip root layer's subtree to viewport + https://bugs.webkit.org/show_bug.cgi?id=95235 + + Reviewed by Adrienne Walker. + + Existing tests updated, and otherwise this change is already + covered by layout and unit tests. + + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): + (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): + +2012-08-29 Julien Chaffraix <jchaffraix@webkit.org> + + [Chromium] CCLayerTreeHostTestScrollChildLayer makes the wrong assumptions + https://bugs.webkit.org/show_bug.cgi?id=95358 + + Unreviewed gardening. + + * tests/CCLayerTreeHostTest.cpp: + Disabled the test until it is fixed. + +2012-08-29 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126972. + http://trac.webkit.org/changeset/126972 + https://bugs.webkit.org/show_bug.cgi?id=95349 + + accessibility/canvas-description-and-role.html has been + failing consistently on several bots and Dominic needs some + time to investigate why (Requested by jchaffraix on #webkit). + + * public/WebAccessibilityRole.h: + * src/AssertMatchingEnums.cpp: + +2012-08-29 Peter Beverloo <peter@chromium.org> Unreviewed. Rolled DEPS. * DEPS: -2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> +2012-08-29 Dominic Mazzoni <dmazzoni@google.com> + + AX: Canvas should have a distinct role + https://bugs.webkit.org/show_bug.cgi?id=95248 + + Reviewed by Chris Fleizach. + + Add support for canvas accessibility role. + + * public/WebAccessibilityRole.h: + * src/AssertMatchingEnums.cpp: + +2012-08-28 David Reveman <reveman@chromium.org> + + [Chromium] Scheduler will never process a commit until it receives a vsync tick. + https://bugs.webkit.org/show_bug.cgi?id=94721 + + Reviewed by James Robinson. + + * tests/CCSchedulerTest.cpp: + (WebKitTests::FakeCCSchedulerClient::reset): + (WebKitTests::TEST): + * tests/CCTextureUpdateControllerTest.cpp: + +2012-08-28 Adam Barth <abarth@webkit.org> + + Fix ASSERT in fast/events/touch/gesture/context-menu-on-two-finger-tap.html + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::detectContentOnTouch): + +2012-08-28 Leandro Gracia Gil <leandrogracia@chromium.org> + + Content detection should not disrupt the page behaviour + https://bugs.webkit.org/show_bug.cgi?id=94727 + + Reviewed by Adam Barth. + + Triggers content detection in the embedder on tap gestures and + add checks for the appropriate event listeners in order to prevent + triggering content detection when it would disrupt the page's behaviour. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + (WebKit::WebViewImpl::detectContentOnTouch): + * tests/WebViewTest.cpp: + * tests/data/content_listeners.html: Added. + +2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126933. + http://trac.webkit.org/changeset/126933 + https://bugs.webkit.org/show_bug.cgi?id=95261 + + Turns out we do need this! (Requested by abarth on #webkit). + + * public/WebWidget.h: + (WebKit::WebWidget::paint): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::paint): + * src/WebPagePopupImpl.h: + (WebPagePopupImpl): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::paint): + * src/WebPopupMenuImpl.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::paint): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-28 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Remove decodeAudioFileData from PlatformSupport + https://bugs.webkit.org/show_bug.cgi?id=95250 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126344. + http://trac.webkit.org/changeset/126344 + https://bugs.webkit.org/show_bug.cgi?id=95253 + + This change is no longer needed (Requested by abarth on + #webkit). + + * public/WebWidget.h: + (WebKit::WebWidget::paint): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::paint): + * src/WebPagePopupImpl.h: + (WebPagePopupImpl): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::paint): + * src/WebPopupMenuImpl.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::paint): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-28 Dominic Mazzoni <dmazzoni@google.com> + + AX: Crash due to object getting deleted inside updateBackingStore + https://bugs.webkit.org/show_bug.cgi?id=94619 + + Reviewed by Chris Fleizach. + + Chromium now calls updateBackingStoreAndCheckValidity explicitly, + so we can now get rid of calls to updateBackingStore in the + method implementations, and just make sure we're checking isDetached. + + * public/WebAccessibilityObject.h: + (WebAccessibilityObject): + * src/WebAccessibilityObject.cpp: + (WebKit::WebAccessibilityObject::axID): + (WebKit::WebAccessibilityObject::accessibilityDescription): + (WebKit::WebAccessibilityObject::actionVerb): + (WebKit::WebAccessibilityObject::canSetFocusAttribute): + (WebKit::WebAccessibilityObject::canSetValueAttribute): + (WebKit::WebAccessibilityObject::childCount): + (WebKit::WebAccessibilityObject::childAt): + (WebKit::WebAccessibilityObject::firstChild): + (WebKit::WebAccessibilityObject::focusedChild): + (WebKit::WebAccessibilityObject::lastChild): + (WebKit::WebAccessibilityObject::nextSibling): + (WebKit::WebAccessibilityObject::parentObject): + (WebKit::WebAccessibilityObject::previousSibling): + (WebKit::WebAccessibilityObject::canSetSelectedAttribute): + (WebKit::WebAccessibilityObject::isAnchor): + (WebKit::WebAccessibilityObject::isAriaReadOnly): + (WebKit::WebAccessibilityObject::isButtonStateMixed): + (WebKit::WebAccessibilityObject::isChecked): + (WebKit::WebAccessibilityObject::isCollapsed): + (WebKit::WebAccessibilityObject::isControl): + (WebKit::WebAccessibilityObject::isEnabled): + (WebKit::WebAccessibilityObject::isFocused): + (WebKit::WebAccessibilityObject::isHovered): + (WebKit::WebAccessibilityObject::isIndeterminate): + (WebKit::WebAccessibilityObject::isLinked): + (WebKit::WebAccessibilityObject::isLoaded): + (WebKit::WebAccessibilityObject::isMultiSelectable): + (WebKit::WebAccessibilityObject::isOffScreen): + (WebKit::WebAccessibilityObject::isPasswordField): + (WebKit::WebAccessibilityObject::isPressed): + (WebKit::WebAccessibilityObject::isReadOnly): + (WebKit::WebAccessibilityObject::isRequired): + (WebKit::WebAccessibilityObject::isSelected): + (WebKit::WebAccessibilityObject::isSelectedOptionActive): + (WebKit::WebAccessibilityObject::isVertical): + (WebKit::WebAccessibilityObject::isVisible): + (WebKit::WebAccessibilityObject::isVisited): + (WebKit::WebAccessibilityObject::accessKey): + (WebKit::WebAccessibilityObject::ariaHasPopup): + (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic): + (WebKit::WebAccessibilityObject::ariaLiveRegionBusy): + (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant): + (WebKit::WebAccessibilityObject::ariaLiveRegionStatus): + (WebKit::WebAccessibilityObject::boundingBoxRect): + (WebKit::WebAccessibilityObject::estimatedLoadingProgress): + (WebKit::WebAccessibilityObject::helpText): + (WebKit::WebAccessibilityObject::headingLevel): + (WebKit::WebAccessibilityObject::hierarchicalLevel): + (WebKit::WebAccessibilityObject::hitTest): + (WebKit::WebAccessibilityObject::keyboardShortcut): + (WebKit::WebAccessibilityObject::performDefaultAction): + (WebKit::WebAccessibilityObject::roleValue): + (WebKit::WebAccessibilityObject::selectionEnd): + (WebKit::WebAccessibilityObject::selectionStart): + (WebKit::WebAccessibilityObject::stringValue): + (WebKit::WebAccessibilityObject::title): + (WebKit::WebAccessibilityObject::titleUIElement): + (WebKit::WebAccessibilityObject::url): + (WebKit::WebAccessibilityObject::valueDescription): + (WebKit::WebAccessibilityObject::valueForRange): + (WebKit::WebAccessibilityObject::maxValueForRange): + (WebKit::WebAccessibilityObject::minValueForRange): + (WebKit::WebAccessibilityObject::node): + (WebKit::WebAccessibilityObject::document): + (WebKit::WebAccessibilityObject::accessibilityIsIgnored): + (WebKit::WebAccessibilityObject::lineBreaks): + (WebKit::WebAccessibilityObject::columnCount): + (WebKit::WebAccessibilityObject::rowCount): + (WebKit::WebAccessibilityObject::cellForColumnAndRow): + (WebKit::WebAccessibilityObject::cellColumnIndex): + (WebKit::WebAccessibilityObject::cellColumnSpan): + (WebKit::WebAccessibilityObject::cellRowIndex): + (WebKit::WebAccessibilityObject::cellRowSpan): + (WebKit::WebAccessibilityObject::scrollToMakeVisible): + (WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus): + (WebKit::WebAccessibilityObject::scrollToGlobalPoint): + +2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126914. + http://trac.webkit.org/changeset/126914 + https://bugs.webkit.org/show_bug.cgi?id=95239 + + it breaks everything and fixes nothing (Requested by pizlo on + #webkit). + + * src/WebGeolocationPermissionRequestManager.cpp: + (WebGeolocationPermissionRequestManager::remove): + * src/WebIDBMetadata.cpp: + (WebKit::WebIDBMetadata::WebIDBMetadata): + * src/WebIntent.cpp: + (WebKit::WebIntent::extrasValue): + * tests/WebSocketExtensionDispatcherTest.cpp: + (WebCore::TEST_F): + +2012-08-28 W. James MacLean <wjmaclean@chromium.org> + + [unreviewed] Compile fix: windows compiler expects float but find double. + + Need to specify a float literal when initialising the highlight animation duration. + + * src/LinkHighlight.cpp: + (WebKit::LinkHighlight::startHighlightAnimation): + +2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> Rename first/second to key/value in HashMap iterators https://bugs.webkit.org/show_bug.cgi?id=82784 @@ -546,535 +3986,16155 @@ (WebKit::WebIDBMetadata::WebIDBMetadata): * src/WebIntent.cpp: (WebKit::WebIntent::extrasValue): - * tests/MemoryInstrumentationTest.cpp: * tests/WebSocketExtensionDispatcherTest.cpp: (WebCore::TEST_F): -2012-10-06 Ilya Tikhonovsky <loislo@chromium.org> +2012-08-28 W. James MacLean <wjmaclean@chromium.org> - Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964 - https://bugs.webkit.org/show_bug.cgi?id=98500 + [chromium] Drastically shorten the link highlight duration. + https://bugs.webkit.org/show_bug.cgi?id=95216 - Reviewed by Benjamin Poulain. + Reviewed by James Robinson. - Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter(). - Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1. + Parameter change; covered by existing layout tests. - * tests/MemoryInstrumentationTest.cpp: + * src/LinkHighlight.cpp: + (WebKit::LinkHighlight::startHighlightAnimation): + +2012-08-27 Tien-Ren Chen <trchen@chromium.org> + + [Chromium] Remove stub for WebView::getTouchHighlightQuads() + https://bugs.webkit.org/show_bug.cgi?id=95164 + + Reviewed by Adam Barth. + + Reverts https://bugs.webkit.org/show_bug.cgi?id=92997 + We're uploading a new implementation that no longer uses this API. + See https://bugs.webkit.org/show_bug.cgi?id=94182 + + * WebKit.gyp: + * public/WebTouchCandidatesInfo.h: Removed. + * public/WebView.h: + (WebKit): + * src/WebViewImpl.cpp: + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-27 Ian Vollick <vollick@chromium.org> + + [chromium] Should accelerate rotations of >= 180 degrees + https://bugs.webkit.org/show_bug.cgi?id=94860 + + Reviewed by James Robinson. + + Added new unit tests: + WebTransformOperationTest.transformTypesAreUnique + WebTransformOperationTest.matchTypesSameLength + WebTransformOperationTest.identityAlwaysMatches + WebTransformOperationTest.largeRotationsWithSameAxis + WebTransformOperationTest.largeRotationsWithSameAxisInDifferentDirection + WebTransformOperationTest.largeRotationsWithDifferentAxes + WebTransformOperationTest.blendRotationFromIdentity + WebTransformOperationTest.blendTranslationFromIdentity + WebTransformOperationTest.blendScaleFromIdentity + WebTransformOperationTest.blendSkewFromIdentity + WebTransformOperationTest.blendPerspectiveFromIdentity + WebTransformOperationTest.blendRotationToIdentity + WebTransformOperationTest.blendTranslationToIdentity + WebTransformOperationTest.blendScaleToIdentity + WebTransformOperationTest.blendSkewToIdentity + WebTransformOperationTest.blendPerspectiveToIdentity + AnimationTranslationUtilTest.createTransformAnimationWithBigRotation + AnimationTranslationUtilTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList + + * tests/AnimationTranslationUtilTest.cpp: + (WebKit::TEST): + * tests/WebTransformOperationsTest.cpp: + (TEST): + (getIdentityOperations): + +2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126836. + http://trac.webkit.org/changeset/126836 + https://bugs.webkit.org/show_bug.cgi?id=95163 -2012-10-05 Terry Anderson <tdanderson@chromium.org> + Broke all Apple ports, EFL, and Qt. (Requested by tkent on + #webkit). - [chromium] Only define SK_SUPPORT_HINTING_SCALE_FACTOR when building for chromeOS - https://bugs.webkit.org/show_bug.cgi?id=98526 + * src/WebGeolocationPermissionRequestManager.cpp: + (WebGeolocationPermissionRequestManager::remove): + * src/WebIDBMetadata.cpp: + (WebKit::WebIDBMetadata::WebIDBMetadata): + * src/WebIntent.cpp: + (WebKit::WebIntent::extrasValue): + * tests/WebSocketExtensionDispatcherTest.cpp: + (WebCore::TEST_F): + +2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> + + Rename first/second to key/value in HashMap iterators + https://bugs.webkit.org/show_bug.cgi?id=82784 + + Reviewed by Eric Seidel. + + * src/WebGeolocationPermissionRequestManager.cpp: + (WebGeolocationPermissionRequestManager::remove): + * src/WebIDBMetadata.cpp: + (WebKit::WebIDBMetadata::WebIDBMetadata): + * src/WebIntent.cpp: + (WebKit::WebIntent::extrasValue): + * tests/WebSocketExtensionDispatcherTest.cpp: + (WebCore::TEST_F): + +2012-08-27 David Reveman <reveman@chromium.org> + + [Chromium] Stop texture updates when context is lost. + https://bugs.webkit.org/show_bug.cgi?id=94983 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostTest.cpp: + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext): + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::create): + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::setContextLostCallback): + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::isContextLost): + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::beginQueryEXT): + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::endQueryEXT): + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::getQueryObjectuivEXT): + (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext): + (CCLayerTreeHostTestLostContextWhileUpdatingResources): + (CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources): + (CCLayerTreeHostTestLostContextWhileUpdatingResources::createOutputSurface): + (CCLayerTreeHostTestLostContextWhileUpdatingResources::beginTest): + (CCLayerTreeHostTestLostContextWhileUpdatingResources::commitCompleteOnCCThread): + (CCLayerTreeHostTestLostContextWhileUpdatingResources::layout): + (CCLayerTreeHostTestLostContextWhileUpdatingResources::afterTest): + (TEST_F): + +2012-08-27 Dana Jansens <danakj@chromium.org> + + [chromium] A general mechanism for passing data into and out of appendQuads and quadCuller via CCAppendQuadsData + https://bugs.webkit.org/show_bug.cgi?id=95109 + + Reviewed by Adrienne Walker. + + Update tests to use the new data structure. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + (CCLayerTestCommon::getQuads): + * tests/MockCCQuadCuller.h: + +2012-08-24 James Robinson <jamesr@chromium.org> + + [chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer + https://bugs.webkit.org/show_bug.cgi?id=94996 + + Reviewed by Adrienne Walker. + + Fix up tests for API changes. + + * WebKit.gyp: + * src/WebScrollbarLayerImpl.cpp: + (WebKit::WebScrollbarLayer::create): + * tests/ScrollbarLayerChromiumTest.cpp: + (WebCore::TEST): + +2012-08-27 Adrienne Walker <enne@google.com> + + [chromium] Prevent scrollbar thumb size from changing during compositor zoom + https://bugs.webkit.org/show_bug.cgi?id=94859 + + Reviewed by James Robinson. + + Update test. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-27 Dana Jansens <danakj@chromium.org> + + [chromium] Have RenderSurface create and add its own generated RenderPass + https://bugs.webkit.org/show_bug.cgi?id=94957 + + Reviewed by Adrienne Walker. + + Test that a RenderSurface generates the RenderPass that we expect. + + * tests/CCRenderSurfaceTest.cpp: + +2012-08-27 Justin Novosad <junov@chromium.org> + + [Chromium] Fixing infinite recursion in Canvas2DLayerManager + https://bugs.webkit.org/show_bug.cgi?id=95110 + + Reviewed by Stephen White. + + Breaking recursion cycle by not reporting a change in memory allocation + when no memory is freed in FakeCanvas2DLayer::freeMemoryIfPossible. + + * tests/Canvas2DLayerManagerTest.cpp: + +2012-08-27 Justin Novosad <junov@chromium.org> + + [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases + https://bugs.webkit.org/show_bug.cgi?id=94386 Reviewed by Stephen White. - This is causing some problems with picture serialization between chrome - and the mainline skia tools. (Once this change lands and is gardened in, - I will make the corresponding change in chromium/skia/skia.gyp) + Adding unit tests for WebCore::Canvas2DLayerManager + + * WebKit.gypi: + +2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> + + Rename RegisterProtocolHandler API to NavigatorContentUtils + https://bugs.webkit.org/show_bug.cgi?id=94920 + + Reviewed by Adam Barth. + + Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed. + RegisterProtocolHandlerClientImpl is renamed to NavigatorContentUtilsClientImpl. * features.gypi: + * src/ChromeClientImpl.cpp: + (WebKit): + (WebKit::NavigatorContentUtilsClientImpl::create): + (WebKit::NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl): + (WebKit::NavigatorContentUtilsClientImpl::registerProtocolHandler): + * src/ChromeClientImpl.h: + (NavigatorContentUtilsClientImpl): + (WebKit::NavigatorContentUtilsClientImpl::~NavigatorContentUtilsClientImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + * src/WebViewImpl.h: -2012-10-05 Adam Barth <abarth@webkit.org> +2012-08-27 Johnny Ding <jnd@chromium.org> - Unreviewed. + [Chromium-Android]Move webkit_unit_tests_apk and TestWebKitAPI_apk into a + condition block:['OS=="android" and gtest_target_type == "shared_library"']. + https://bugs.webkit.org/show_bug.cgi?id=95049 + + Reviewed by Adam Barth. - Disable WebFrameTest.DivScrollIntoEditableTest. The test depends on - some code that is conditionally compiled and therefore fails in some - configurations. + Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library" - * tests/WebFrameTest.cpp: + * All.gyp: -2012-10-05 W. James MacLean <wjmaclean@chromium.org> +2012-08-24 Dominic Mazzoni <dmazzoni@google.com> - [chromium] Enhance support for transforms in LinkHighlight. - https://bugs.webkit.org/show_bug.cgi?id=94355 + Chromium: WebAccessibilityObject should expose updateBackingStore + https://bugs.webkit.org/show_bug.cgi?id=94611 + + Reviewed by Chris Fleizach. + + This change just exposes a method, with no new tests. Next, Chromium + will be modified to call this new method, and this will be followed + by a change that gets rid of calls to updateBackingStore under the + hood. That last change may add a test or update an existing test. + + * public/WebAccessibilityObject.h: + (WebAccessibilityObject): + * src/WebAccessibilityObject.cpp: + (WebKit::WebAccessibilityObject::updateBackingStoreAndCheckValidity): + (WebKit): + +2012-08-24 W. James MacLean <wjmaclean@chromium.org> + + [chromium] WebViewImpl::enableTouchHighlight() should always clear any existing highlight when invoked. + https://bugs.webkit.org/show_bug.cgi?id=94978 + + Reviewed by James Robinson. + + Modified WebViewImpl::enableTouchHighlight() so it always clears any existing highlight, even if no new + highlight target is found. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::enableTouchHighlight): + +2012-08-23 James Robinson <jamesr@chromium.org> + + [chromium] Convert WebLayerTreeView interface into pure virtual + https://bugs.webkit.org/show_bug.cgi?id=94866 Reviewed by Adrienne Walker. - Improved handling of transformed highlight targets, where the transform goes beyond simple translation. + Updates WebLayerTreeView implementation and callers to new interface. The createGraphicsContext3D() wrapper + stuff can just go away now since downstream has updated to createOutputSurface(). - * src/LinkHighlight.cpp: - (WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates. + * WebKit.gypi: + * src/WebLayerTreeView.cpp: Removed. + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeView::create): + (WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl): + (WebKit::WebLayerTreeViewImpl::initialize): (WebKit): - (WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path. - (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms. + (WebKit::WebLayerTreeViewImpl::setSurfaceReady): + (WebKit::WebLayerTreeViewImpl::setRootLayer): + (WebKit::WebLayerTreeViewImpl::clearRootLayer): + (WebKit::WebLayerTreeViewImpl::compositorIdentifier): + (WebKit::WebLayerTreeViewImpl::setViewportSize): + (WebKit::WebLayerTreeViewImpl::layoutViewportSize): + (WebKit::WebLayerTreeViewImpl::deviceViewportSize): + (WebKit::WebLayerTreeViewImpl::setDeviceScaleFactor): + (WebKit::WebLayerTreeViewImpl::deviceScaleFactor): + (WebKit::WebLayerTreeViewImpl::setBackgroundColor): + (WebKit::WebLayerTreeViewImpl::setHasTransparentBackground): + (WebKit::WebLayerTreeViewImpl::setVisible): + (WebKit::WebLayerTreeViewImpl::setPageScaleFactorAndLimits): + (WebKit::WebLayerTreeViewImpl::startPageScaleAnimation): + (WebKit::WebLayerTreeViewImpl::setNeedsAnimate): + (WebKit::WebLayerTreeViewImpl::setNeedsRedraw): + (WebKit::WebLayerTreeViewImpl::commitRequested): + (WebKit::WebLayerTreeViewImpl::composite): + (WebKit::WebLayerTreeViewImpl::updateAnimations): + (WebKit::WebLayerTreeViewImpl::compositeAndReadback): + (WebKit::WebLayerTreeViewImpl::finishAllRendering): + (WebKit::WebLayerTreeViewImpl::renderingStats): + (WebKit::WebLayerTreeViewImpl::setFontAtlas): + (WebKit::WebLayerTreeViewImpl::loseCompositorContext): + (WebKit::WebLayerTreeViewImpl::willBeginFrame): + (WebKit::WebLayerTreeViewImpl::didBeginFrame): + (WebKit::WebLayerTreeViewImpl::animate): + (WebKit::WebLayerTreeViewImpl::layout): + (WebKit::WebLayerTreeViewImpl::applyScrollAndScale): + (WebKit::WebLayerTreeViewImpl::createOutputSurface): + (WebKit::WebLayerTreeViewImpl::didRecreateOutputSurface): + (WebKit::WebLayerTreeViewImpl::willCommit): + (WebKit::WebLayerTreeViewImpl::didCommit): + (WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame): + (WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers): + (WebKit::WebLayerTreeViewImpl::scheduleComposite): + * src/WebLayerTreeViewImpl.h: + (WebLayerTreeViewImpl): * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::bestTouchLinkNode): + (WebKit::WebViewImpl::renderingStats): + (WebKit::WebViewImpl::startPageScaleAnimation): + (WebKit::WebViewImpl::setCompositorSurfaceReady): + (WebKit::WebViewImpl::animate): + (WebKit::WebViewImpl::doPixelReadbackToCanvas): + (WebKit::WebViewImpl::paint): + (WebKit::WebViewImpl::composite): + (WebKit::WebViewImpl::setNeedsRedraw): + (WebKit::WebViewImpl::isInputThrottled): + (WebKit::WebViewImpl::loseCompositorContext): + (WebKit::WebViewImpl::setDeviceScaleFactor): + (WebKit::WebViewImpl::computePageScaleFactorLimits): + (WebKit::WebViewImpl::setIsTransparent): + (WebKit::WebViewImpl::setRootGraphicsLayer): + (WebKit::WebViewImpl::scheduleCompositingLayerSync): + (WebKit::WebViewImpl::invalidateRootLayerRect): + (WebKit::WebViewImpl::setBackgroundColor): + (WebKit::WebViewImpl::scheduleAnimation): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): + (WebKit::WebViewImpl::updateLayerTreeViewport): + (WebKit::WebViewImpl::setVisibilityState): + * src/WebViewImpl.h: + (WebKit): + * tests/CCLayerTreeHostTest.cpp: + * tests/CCThreadedTest.cpp: + * tests/CCThreadedTest.h: + (WebKitTests::TestHooks::animate): + * tests/FakeCCLayerTreeHostClient.h: + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): + (GraphicsLayerChromiumTest): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + * tests/WebLayerTreeViewTestCommon.h: + (MockWebLayerTreeViewClient): + +2012-08-24 Sheriff Bot <webkit.review.bot@gmail.com> -2012-10-05 Julien Chaffraix <jchaffraix@webkit.org> + Unreviewed. Rolled DEPS. - Unreviewed build fix after r130545. + * DEPS: - * tests/WebFrameTest.cpp: - Avoid a warning about truncating the double constant on Windows. While touching the variable, changed - it to be proper camelCase. +2012-08-24 James Robinson <jamesr@chromium.org> -2012-10-05 Oli Lan <olilan@chromium.org> + [chromium] Clean up WebAnimation animationId/groupId generation + https://bugs.webkit.org/show_bug.cgi?id=94973 - Allow EventHandler to handle longpress gestures, including longpress selection on Android. - https://bugs.webkit.org/show_bug.cgi?id=98173 + Reviewed by Adrienne Walker. - Reviewed by Ryosuke Niwa. + * src/WebAnimationImpl.cpp: + (WebKit::WebAnimation::create): + (WebKit::WebAnimationImpl::WebAnimationImpl): + (WebKit::WebAnimationImpl::id): + (WebKit): + * src/WebAnimationImpl.h: + (WebAnimationImpl): + * tests/AnimationTranslationUtilTest.cpp: + (WebKit::animationCanBeTranslated): + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit::TEST_F): + +2012-08-24 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Remove visitedLinkHash from PlatformSupport + https://bugs.webkit.org/show_bug.cgi?id=94965 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-08-24 Sheriff Bot <webkit.review.bot@gmail.com> - This patch changes the longpress gesture handling code in WebViewImpl to call EventHandler::handleGestureEvent. - The WebCore part of this patch adds longpress handling to that method, including the long press selection behaviour - required for Android. This means that a long press gesture performed on word (that is not part of a link) - selects the word, without generating a context menu event. + Unreviewed, rolling out r126620. + http://trac.webkit.org/changeset/126620 + https://bugs.webkit.org/show_bug.cgi?id=94976 - A new test, WebViewTest.LongPressSelection has been added to test this. + ASSERT((intptr_t)m_bytesAllocated + deltaBytes > 0) is + triggering on the bots (Requested by jchaffraix on #webkit). + + * WebKit.gypi: + * tests/Canvas2DLayerManagerTest.cpp: Removed. + +2012-08-24 Justin Novosad <junov@chromium.org> + + [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases + https://bugs.webkit.org/show_bug.cgi?id=94386 + + Reviewed by Stephen White. + + Adding unit tests for WebCore::Canvas2DLayerManager + + * WebKit.gypi: + * tests/Canvas2DLayerManagerTest.cpp: Added. + (FakeCanvas2DLayerBridge): + (FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge): + (FakeCanvas2DLayerBridge::fakeFreeableBytes): + (Canvas2DLayerManagerTest): + (Canvas2DLayerManagerTest::storageAllocationTrackingTest): + (Canvas2DLayerManagerTest::evictionTest): + (Canvas2DLayerManagerTest::flushEvictionTest): + +2012-08-24 Cris Neckar <cdn@chromium.org> + + Plumb consumeUserGesture() to the chromium platform layer. + https://bugs.webkit.org/show_bug.cgi?id=9475294867 + + Reviewed by Adam Barth. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::consumeUserGesture): + (WebKit): + * src/WebFrameImpl.h: + (WebFrameImpl): + +2012-08-24 W. James MacLean <wjmaclean@chromium.org> + + [chromium] gestureTapDown should not select a RenderView node as target. + https://bugs.webkit.org/show_bug.cgi?id=94956 + + Reviewed by James Robinson. + + Add check to prevent selecting a RenderView node as a highlight target. * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - (WebViewImpl): - * tests/WebViewTest.cpp: - * tests/data/longpress_selection.html: Added. + (WebKit::WebViewImpl::bestTouchLinkNode): -2012-10-05 Yusuf Ozuysal <yusufo@google.com> +2012-08-24 Tommy Widenflycht <tommyw@google.com> - [chromium] Support zooming focused node for mobile devices - https://bugs.webkit.org/show_bug.cgi?id=97958 + MediaStream API: Add readyState functionality to RTCPeerConnection + https://bugs.webkit.org/show_bug.cgi?id=94813 Reviewed by Adam Barth. - This unforks the Android version of scrollFocusedNodeIntoRect().A new setting - autoZoomFocusedNodeToLegibleScale was added to turn it on, since not all - platforms with ENABLE(GESTURE_EVENTS) want this. + * src/AssertMatchingEnums.cpp: - Test: WebFrameTest.DivScrollIntoEditableTest +2012-08-24 Dan Carney <dcarney@google.com> + + [V8] Refactor away IsolatedWorld + https://bugs.webkit.org/show_bug.cgi?id=93971 + + Reviewed by Kentaro Hara. + + Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld. - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::WebSettingsImpl): - (WebKit::WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - (WebKit::WebSettingsImpl::autoZoomFocusedNodeToLegibleScale): * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::scrollFocusedNodeIntoRect): - * tests/WebFrameTest.cpp: - * tests/data/get_scale_for_zoom_into_editable_test.html: Added. + (WebKit::WebView::addUserScript): + (WebKit::WebView::addUserStyleSheet): + +2012-08-23 Antoine Labour <piman@chromium.org> + + [chromium] Fix lost context when textures are evicted + https://bugs.webkit.org/show_bug.cgi?id=94892 + + Reviewed by James Robinson. + + After eviction, the CCPrioritizedTextureManager is in a limbo state + where all its resources are invalid. If we try to release them we will + double-destroy them. + + New test: CCLayerTreeHostTestLostContextAfterEvictTextures. + + * tests/CCLayerTreeHostTest.cpp: + (CCLayerTreeHostTestLostContextAfterEvictTextures): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest): + (EvictTexturesAndLoseContextTask): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface): + (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest): + (WTF): + (WTF::TEST_F): + +2012-08-23 Antoine Labour <piman@chromium.org> + + [chromium] Add OVERRIDEs in test code + https://bugs.webkit.org/show_bug.cgi?id=94894 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostTest.cpp: + +2012-08-23 Joshua Bell <jsbell@chromium.org> -2012-10-05 W. James MacLean <wjmaclean@chromium.org> + IndexedDB: Expose mechanism for database to force a connection to close + https://bugs.webkit.org/show_bug.cgi?id=91010 - [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel. - https://bugs.webkit.org/show_bug.cgi?id=97355 + Reviewed by Tony Chang. + + In Chromium, the browsing data deleter has a WebIDBDatabase handle which + it can use to terminate a connection. This handles forcefully closing + the front end connections and the back end, to unblock disk cleanup. + + * public/WebIDBDatabase.h: + (WebKit::WebIDBDatabase::forceClose): Entry point. + * public/WebIDBDatabaseCallbacks.h: + (WebKit::WebIDBDatabaseCallbacks::onForcedClose): Plumbing back to front. + * src/IDBDatabaseCallbacksProxy.cpp: + (WebKit::IDBDatabaseCallbacksProxy::onForcedClose): Plumbing back to front. + (WebKit): + * src/IDBDatabaseCallbacksProxy.h: + (IDBDatabaseCallbacksProxy): Plumbing. + * src/WebIDBDatabaseCallbacksImpl.cpp: + (WebKit::WebIDBDatabaseCallbacksImpl::onForcedClose): Plumbing back to front. + (WebKit): + * src/WebIDBDatabaseCallbacksImpl.h: + (WebIDBDatabaseCallbacksImpl): Plumbing back to front. + * src/WebIDBDatabaseImpl.cpp: + (WebKit::WebIDBDatabaseImpl::close): Tidy up dropping the callback reference. + (WebKit): + (WebKit::WebIDBDatabaseImpl::forceClose): Terminate the connection by notifying + the back end and the front end, while avoid re-entrant badness. + * src/WebIDBDatabaseImpl.h: Header tweak for unit test. + (WebIDBDatabaseImpl): + * tests/IDBDatabaseBackendTest.cpp: Added unit test to exercise connections. + +2012-08-23 James Robinson <jamesr@chromium.org> + + [chromium] Convert WebAnimationCurve subtypes into pure virtual + https://bugs.webkit.org/show_bug.cgi?id=94068 Reviewed by Adrienne Walker. - This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if - interrupted by GestureTap, and animate away if interrupted by GestureTapCancel. + Updates the implementations, some callers and tests of Web*AnimationCurve to its new interface. + + * WebKit.gyp: + * src/WebAnimation.cpp: + (WebKit::WebAnimation::initialize): + * src/WebFloatAnimationCurveImpl.cpp: Renamed from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp. + (WebKit): + (WebKit::WebFloatAnimationCurve::create): + (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl): + (WebKit::WebFloatAnimationCurveImpl::~WebFloatAnimationCurveImpl): + (WebKit::WebFloatAnimationCurveImpl::type): + (WebKit::WebFloatAnimationCurveImpl::add): + (WebKit::WebFloatAnimationCurveImpl::getValue): + (WebKit::WebFloatAnimationCurveImpl::cloneToCCAnimationCurve): + * src/WebTransformAnimationCurve.cpp: Removed. + * tests/WebAnimationTest.cpp: + (WebKit::TEST): + * tests/WebFloatAnimationCurveTest.cpp: + (WebKit::TEST): + * tests/WebTransformAnimationCurveTest.cpp: + (WebKit::TEST): + +2012-08-23 Kentaro Hara <haraken@chromium.org> + + [V8] Remove V8Proxy.{h,cpp} + https://bugs.webkit.org/show_bug.cgi?id=94794 + + Reviewed by Dimitri Glazkov. + + Now V8Proxy is no longer used. We can completely remove V8Proxy from the codebase. + + No tests. No change in behavior. + + * src/ChromeClientImpl.cpp: + * src/WebBindings.cpp: + * src/WebDOMMessageEvent.cpp: + * src/WebDevToolsAgentImpl.cpp: + * src/WebMediaPlayerClientImpl.cpp: + +2012-08-23 Dana Jansens <danakj@chromium.org> + + [chromium] Don't require a RenderSurface* in order to create a RenderPass + https://bugs.webkit.org/show_bug.cgi?id=94862 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCRendererGLTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + +2012-08-22 James Robinson <jamesr@chromium.org> + + [chromium] Remove WebLayer::setChildren API + https://bugs.webkit.org/show_bug.cgi?id=94749 + + Reviewed by Adrienne Walker. + + * src/WebLayer.cpp: + +2012-08-23 Dana Jansens <danakj@chromium.org> + + [chromium] Create sharedQuadState at same time as creating quads and give them to the quadSink + https://bugs.webkit.org/show_bug.cgi?id=94752 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::EvictionTestLayerImpl::appendQuads): + * tests/CCQuadCullerTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + (CCLayerTestCommon::getQuads): + (CCLayerTestCommon::coverageVisibleRectOnTileBoundaries): + (CCLayerTestCommon::coverageVisibleRectIntersectsTiles): + (CCLayerTestCommon::coverageVisibleRectIntersectsBounds): + * tests/MockCCQuadCuller.h: + (WebCore::MockCCQuadCuller::MockCCQuadCuller): + (MockCCQuadCuller): + (WebCore::MockCCQuadCuller::quadList): + (WebCore::MockCCQuadCuller::sharedQuadStateList): + +2012-08-23 Pavel Feldman <pfeldman@chromium.org> + + Not reviewed - fixing input list for timeline inspector module. + https://bugs.webkit.org/show_bug.cgi?id=94829 + + * WebKit.gyp: + +2012-08-23 Alexandre Elias <aelias@chromium.org> + + [chromium] Rename LayerRendererChromium to GL-specific name + https://bugs.webkit.org/show_bug.cgi?id=94835 + + Reviewed by James Robinson. + + Over time, LayerRendererChromium has evolved to be a GL-specific + subclass of CCRenderer that has no awareness of layers (as it operates + only with drawQuads). + + This patch renames LayerRendererChromium to CCRendererGL, replaces all + instances of "layerRenderer" with just "renderer", and removes a + few unnecessary includes of LayerRendererChromium.h. + + * WebKit.gypi: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): + (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): + (WTF::CCLayerTreeHostTestManySurfaces::beginTest): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread): + * tests/CCRendererGLTest.cpp: Renamed from Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp. + (FrameCountingMemoryAllocationSettingContext): + (FrameCountingMemoryAllocationSettingContext::FrameCountingMemoryAllocationSettingContext): + (FrameCountingMemoryAllocationSettingContext::prepareTexture): + (FrameCountingMemoryAllocationSettingContext::setMemoryAllocationChangedCallbackCHROMIUM): + (FrameCountingMemoryAllocationSettingContext::getString): + (FrameCountingMemoryAllocationSettingContext::frameCount): + (FrameCountingMemoryAllocationSettingContext::setMemoryAllocation): + (FakeCCRendererClient): + (FakeCCRendererClient::FakeCCRendererClient): + (FakeCCRendererClient::setFullRootLayerDamageCount): + (FakeCCRendererClient::rootRenderPass): + (FakeCCRendererClient::renderPassesInDrawOrder): + (FakeCCRendererClient::renderPasses): + (FakeCCRendererClient::memoryAllocationLimitBytes): + (FakeCCRendererGL): + (FakeCCRendererGL::FakeCCRendererGL): + (CCRendererGLTest): + (CCRendererGLTest::CCRendererGLTest): + (CCRendererGLTest::SetUp): + (CCRendererGLTest::TearDown): + (CCRendererGLTest::swapBuffers): + (CCRendererGLTest::context): + (TEST_F): + (ForbidSynchronousCallContext): + (ForbidSynchronousCallContext::ForbidSynchronousCallContext): + (ForbidSynchronousCallContext::getActiveAttrib): + (ForbidSynchronousCallContext::getActiveUniform): + (ForbidSynchronousCallContext::getAttachedShaders): + (ForbidSynchronousCallContext::getAttribLocation): + (ForbidSynchronousCallContext::getBooleanv): + (ForbidSynchronousCallContext::getBufferParameteriv): + (ForbidSynchronousCallContext::getContextAttributes): + (ForbidSynchronousCallContext::getError): + (ForbidSynchronousCallContext::getFloatv): + (ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv): + (ForbidSynchronousCallContext::getIntegerv): + (ForbidSynchronousCallContext::getProgramiv): + (ForbidSynchronousCallContext::getShaderiv): + (ForbidSynchronousCallContext::getString): + (ForbidSynchronousCallContext::getProgramInfoLog): + (ForbidSynchronousCallContext::getRenderbufferParameteriv): + (ForbidSynchronousCallContext::getShaderInfoLog): + (ForbidSynchronousCallContext::getShaderPrecisionFormat): + (ForbidSynchronousCallContext::getShaderSource): + (ForbidSynchronousCallContext::getTexParameterfv): + (ForbidSynchronousCallContext::getTexParameteriv): + (ForbidSynchronousCallContext::getUniformfv): + (ForbidSynchronousCallContext::getUniformiv): + (ForbidSynchronousCallContext::getUniformLocation): + (ForbidSynchronousCallContext::getVertexAttribfv): + (ForbidSynchronousCallContext::getVertexAttribiv): + (ForbidSynchronousCallContext::getVertexAttribOffset): + (TEST): + (LoseContextOnFirstGetContext): + (LoseContextOnFirstGetContext::LoseContextOnFirstGetContext): + (ContextThatDoesNotSupportMemoryManagmentExtensions): + (ContextThatDoesNotSupportMemoryManagmentExtensions::ContextThatDoesNotSupportMemoryManagmentExtensions): + (ContextThatDoesNotSupportMemoryManagmentExtensions::prepareTexture): + (ContextThatDoesNotSupportMemoryManagmentExtensions::setMemoryAllocationChangedCallbackCHROMIUM): + (ContextThatDoesNotSupportMemoryManagmentExtensions::getString): + (ClearCountingContext): + (ClearCountingContext::ClearCountingContext): + (ClearCountingContext::clear): + (ClearCountingContext::clearCount): + * tests/TiledLayerChromiumTest.cpp: + +2012-08-23 Stephen White <senorblanco@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-23 Wei Jia <wjia@chromium.org> + + create different WebKit::WebMediaPlayer based on URL + https://bugs.webkit.org/show_bug.cgi?id=91301 + + Reviewed by Adam Barth. + + Pass URL to WebFrameClient::createMediaPlayer(). This allows creation + of different WebMediaPlayer implementations based on the URL. + + * public/WebFrameClient.h: + (WebKit::WebFrameClient::createMediaPlayer): add URL as additional argument. + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::createWebMediaPlayer): add URL as additional argument. + (WebKit::WebMediaPlayerClientImpl::loadInternal): + +2012-08-23 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest + https://bugs.webkit.org/show_bug.cgi?id=94757 + + Reviewed by Tony Chang. + + Drop onSuccess(IDBDatabaseBackendImpl) overload from test, as it is no longer + implemented by IDBRequest. + + * tests/IDBRequestTest.cpp: + (WebCore::TEST): + +2012-08-23 Kenneth Russell <kbr@google.com> + + Convert ScrollableArea ASSERT_NOT_REACHED virtuals into pure virtuals + https://bugs.webkit.org/show_bug.cgi?id=93306 + + Unreviewed build fix. + + * src/ScrollbarGroup.h: + +2012-08-23 Adrienne Walker <enne@google.com> + + Convert ScrollableArea ASSERT_NOT_REACHED virtuals + https://bugs.webkit.org/show_bug.cgi?id=93306 + + Reviewed by Darin Adler. + + Add implementations where necessary to make derived classes concrete. + Add OVERRIDE for ScrollableArea functions. + * src/ScrollbarGroup.h: + (ScrollbarGroup): + (WebKit::ScrollbarGroup::scrollCornerRect): + * tests/ScrollAnimatorNoneTest.cpp: + (MockScrollableArea): + +2012-08-23 David Reveman <reveman@chromium.org> + + [Chromium] Unnecessary delay when starting to update resources with an inactive vsync timer. + https://bugs.webkit.org/show_bug.cgi?id=94719 + + Reviewed by James Robinson. + + * tests/CCSchedulerTestCommon.h: + +2012-08-23 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-22 Alec Flett <alecflett@chromium.org> + + IndexedDB: tests for injection/extraction of idb keys + https://bugs.webkit.org/show_bug.cgi?id=94653 + + Reviewed by Tony Chang. + Added unit tests for key injection/extraction using + SerializedScriptValue. These were moved from chromium, now + that all uses of the API are through WebKit. + + * tests/IDBKeyPathTest.cpp: + (WebCore): + (WebCore::TEST): + +2012-08-22 James Robinson <jamesr@chromium.org> + + [chromium] Change WebLayer from a concrete type to a pure virtual interface + https://bugs.webkit.org/show_bug.cgi?id=94174 + + Reviewed by Adrienne Walker. + + This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl / + NonCompositedContentHost / LinkHighlight. + + * WebKit.gypi: * src/LinkHighlight.cpp: (WebKit::LinkHighlight::LinkHighlight): - (WebKit::LinkHighlight::startHighlightAnimationIfNeeded): + (WebKit::LinkHighlight::contentLayer): + (WebKit::LinkHighlight::clipLayer): + (WebKit::LinkHighlight::releaseResources): + (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): + (WebKit::LinkHighlight::startHighlightAnimation): + (WebKit::LinkHighlight::updateGeometry): * src/LinkHighlight.h: (LinkHighlight): + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setScrollLayer): + (WebKit::NonCompositedContentHost::setViewport): + (WebKit::NonCompositedContentHost::scrollLayer): + * src/NonCompositedContentHost.h: + * src/WebContentLayer.cpp: Removed. + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayer::create): + (WebKit::WebContentLayerImpl::WebContentLayerImpl): + (WebKit::WebContentLayerImpl::~WebContentLayerImpl): + (WebKit::WebContentLayerImpl::layer): + (WebKit): + (WebKit::WebContentLayerImpl::setDoubleSided): + (WebKit::WebContentLayerImpl::setContentsScale): + (WebKit::WebContentLayerImpl::setUseLCDText): + (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): + (WebKit::WebContentLayerImpl::paintContents): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp. + (WebKit): + (WebKit::WebExternalTextureLayer::create): + (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::layer): + (WebKit::WebExternalTextureLayerImpl::setTextureId): + (WebKit::WebExternalTextureLayerImpl::setFlipped): + (WebKit::WebExternalTextureLayerImpl::setUVRect): + (WebKit::WebExternalTextureLayerImpl::setOpaque): + (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha): + (WebKit::WebExternalTextureLayerImpl::willModifyTexture): + (WebKit::WebExternalTextureLayerImpl::setRateLimitContext): + (WebTextureUpdaterImpl): + (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): + (WebKit::WebExternalTextureLayerImpl::prepareTexture): + (WebKit::WebExternalTextureLayerImpl::context): + * src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h. + (WebKit): + (WebExternalTextureLayerImpl): + * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp. + (WebKit): + (WebKit::WebIOSurfaceLayer::create): + (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): + (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl): + (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties): + (WebKit::WebIOSurfaceLayerImpl::layer): + * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h. + (WebCore): + (WebKit): + (WebIOSurfaceLayerImpl): + * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp. + (WebKit): + (WebKit::WebImageLayer::create): + (WebKit::WebImageLayerImpl::WebImageLayerImpl): + (WebKit::WebImageLayerImpl::~WebImageLayerImpl): + (WebKit::WebImageLayerImpl::layer): + (WebKit::WebImageLayerImpl::setBitmap): + * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp. + (WebCore): + (WebKit): + (WebImageLayerImpl): + * src/WebLayer.cpp: Removed. + * src/WebLayerImpl.cpp: + (WebKit::WebLayer::create): + (WebKit::WebLayerImpl::WebLayerImpl): + (WebKit::WebLayerImpl::~WebLayerImpl): + (WebKit): + (WebKit::WebLayerImpl::id): + (WebKit::WebLayerImpl::invalidateRect): + (WebKit::WebLayerImpl::invalidate): + (WebKit::WebLayerImpl::addChild): + (WebKit::WebLayerImpl::insertChild): + (WebKit::WebLayerImpl::replaceChild): + (WebKit::WebLayerImpl::setChildren): + (WebKit::WebLayerImpl::removeFromParent): + (WebKit::WebLayerImpl::removeAllChildren): + (WebKit::WebLayerImpl::setAnchorPoint): + (WebKit::WebLayerImpl::anchorPoint): + (WebKit::WebLayerImpl::setAnchorPointZ): + (WebKit::WebLayerImpl::anchorPointZ): + (WebKit::WebLayerImpl::setBounds): + (WebKit::WebLayerImpl::bounds): + (WebKit::WebLayerImpl::setMasksToBounds): + (WebKit::WebLayerImpl::masksToBounds): + (WebKit::WebLayerImpl::setMaskLayer): + (WebKit::WebLayerImpl::setReplicaLayer): + (WebKit::WebLayerImpl::setOpacity): + (WebKit::WebLayerImpl::opacity): + (WebKit::WebLayerImpl::setOpaque): + (WebKit::WebLayerImpl::opaque): + (WebKit::WebLayerImpl::setPosition): + (WebKit::WebLayerImpl::position): + (WebKit::WebLayerImpl::setSublayerTransform): + (WebKit::WebLayerImpl::sublayerTransform): + (WebKit::WebLayerImpl::setTransform): + (WebKit::WebLayerImpl::transform): + (WebKit::WebLayerImpl::setDrawsContent): + (WebKit::WebLayerImpl::drawsContent): + (WebKit::WebLayerImpl::setPreserves3D): + (WebKit::WebLayerImpl::setUseParentBackfaceVisibility): + (WebKit::WebLayerImpl::setBackgroundColor): + (WebKit::WebLayerImpl::setFilters): + (WebKit::WebLayerImpl::setBackgroundFilters): + (WebKit::WebLayerImpl::setDebugBorderColor): + (WebKit::WebLayerImpl::setDebugBorderWidth): + (WebKit::WebLayerImpl::setDebugName): + (WebKit::WebLayerImpl::setAnimationDelegate): + (WebKit::WebLayerImpl::addAnimation): + (WebKit::WebLayerImpl::removeAnimation): + (WebKit::WebLayerImpl::pauseAnimation): + (WebKit::WebLayerImpl::suspendAnimations): + (WebKit::WebLayerImpl::resumeAnimations): + (WebKit::WebLayerImpl::hasActiveAnimation): + (WebKit::WebLayerImpl::transferAnimationsTo): + (WebKit::WebLayerImpl::setForceRenderSurface): + (WebKit::WebLayerImpl::setScrollPosition): + (WebKit::WebLayerImpl::setScrollable): + (WebKit::WebLayerImpl::setHaveWheelEventHandlers): + (WebKit::WebLayerImpl::setShouldScrollOnMainThread): + (WebKit::WebLayerImpl::setNonFastScrollableRegion): + (WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers): + (WebKit::WebLayerImpl::setFixedToContainerLayer): + (WebKit::WebLayerImpl::layer): + * src/WebLayerImpl.h: + (WebCore): + (WebLayerImpl): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setRootLayer): + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::create): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + (WebKit::WebMediaPlayerClientImpl::repaint): + (WebKit::WebMediaPlayerClientImpl::setOpaque): + (WebKit::WebMediaPlayerClientImpl::platformLayer): + (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + (WebKit::WebPluginContainerImpl::commitBackingTexture): + (WebKit::WebPluginContainerImpl::setOpaque): + (WebKit::WebPluginContainerImpl::platformLayer): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + * src/WebScrollableLayer.cpp: Removed. + * src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp. + (WebKit): + (WebKit::WebScrollbarLayer::create): + (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): + (WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl): + (WebKit::WebScrollbarLayerImpl::layer): + (WebKit::WebScrollbarLayerImpl::setScrollLayer): + * src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h. + (WebCore): + (WebKit): + (WebScrollbarLayerImpl): + * src/WebSolidColorLayerImpl.cpp: + (WebKit::WebSolidColorLayer::create): + (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): + (WebKit::WebSolidColorLayerImpl::layer): + (WebKit): + (WebKit::WebSolidColorLayerImpl::setBackgroundColor): + * src/WebSolidColorLayerImpl.h: + (WebCore): + (WebKit): + (WebSolidColorLayerImpl): + * src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp. + (WebKit): + (WebKit::WebVideoLayer::create): + (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): + (WebKit::WebVideoLayerImpl::~WebVideoLayerImpl): + (WebKit::WebVideoLayerImpl::layer): + (WebKit::WebVideoLayerImpl::active): + * src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp. + (WebCore): + (WebKit): + (WebVideoLayerImpl): * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - (WebKit::WebViewImpl::enableTouchHighlight): + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setRootGraphicsLayer): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): + * src/WebViewImpl.h: + * tests/ImageLayerChromiumTest.cpp: + (WebCore::TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-22 Alejandro Piñeiro <apinheiro@igalia.com> + + Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON + https://bugs.webkit.org/show_bug.cgi?id=73819 + + Reviewed by Chris Fleizach. + + Added a new role, Toggle Button, based on whether aria-pressed is present. + http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed + + * public/WebAccessibilityRole.h: added WebAccessibilityRoleToggleButton that + matchs with WebCore ToggleButtonRole + * src/AssertMatchingEnums.cpp: added the assert matching rule for + WebAccessibilityRoleToggleButton and ToggleButtonRole -2012-10-05 Mark Pilgrim <pilgrim@chromium.org> +2012-08-17 Jeffrey Pfau <jpfau@apple.com> - [Chromium] Update some more #includes for Platform/ directory - https://bugs.webkit.org/show_bug.cgi?id=98534 + Allow blocking of Web SQL databases in third-party web workers + https://bugs.webkit.org/show_bug.cgi?id=94170 Reviewed by Adam Barth. - Part of a refactoring series. See tracking bug 82948. + Web workers did not previously know anything about the document that + spawned them. This is undefined for shared workers, but for dedicated + workers, we now pipe the information through. + + + * src/WebWorkerClientImpl.cpp: + (WebKit::WebWorkerClientImpl::startWorkerContext): Pass top document's origin + +2012-08-22 Kentaro Hara <haraken@chromium.org> + + [V8] Move context() from V8Proxy to ScriptController + https://bugs.webkit.org/show_bug.cgi?id=94593 + + Reviewed by Adam Barth. + + To kill V8Proxy, we can move context() from V8Proxy to ScriptController. + + No tests. No change in behavior. + + * src/InspectorFrontendClientImpl.cpp: + (WebKit::InspectorFrontendClientImpl::windowObjectCleared): + * src/WebDevToolsFrontendImpl.cpp: + (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): + +2012-08-22 Nikhil Bhargava <nbhargava@google.com> + + Reduce Font.h includes across project -- improves RenderObject.h compile time + https://bugs.webkit.org/show_bug.cgi?id=93629 + + Reviewed by Eric Seidel. + + Adds includes due to change in RenderStyle.h - * src/WebFormElement.cpp: * src/WebFrameImpl.cpp: - * src/WebGeolocationClientMock.cpp: - * src/WebGeolocationError.cpp: - * src/WebGeolocationPermissionRequest.cpp: - * src/WebHistoryItem.cpp: - * src/WebHitTestResult.cpp: - * src/WebIDBTransactionImpl.h: - * src/WebIconLoadingCompletionImpl.h: - * src/WebImageDecoder.cpp: - * src/WebImageSkia.cpp: - * src/WebInputElement.cpp: - * src/WebKit.cpp: - * src/WebLabelElement.cpp: - * src/WebMediaStreamRegistry.cpp: - * src/WebNode.cpp: - * src/WebNotification.cpp: - * src/WebOptionElement.cpp: - * src/WebPageSerializer.cpp: - * src/WebPageSerializerImpl.cpp: - * src/WebPageSerializerImpl.h: - * src/WebPluginListBuilderImpl.cpp: - * src/WebPluginLoadObserver.h: + * src/mac/WebSubstringUtil.mm: + +2012-08-22 Nikhil Bhargava <nbhargava@google.com> + + Speed up compilation of tests involving WebTransformationMatrix + https://bugs.webkit.org/show_bug.cgi?id=94639 + + Reviewed by James Robinson. + + EXPECT_TRANSFORMATION_MATRIX_EQ was changed to become mainly a function. + As a macro that expanded into 16 other macros, it caused an unneeded + slow down of close to 45s in the compile time of CCLayerTreeHostCommonTest + Bugs have been filed to clang and gcc noting the errant behavior: + http://llvm.org/bugs/show_bug.cgi?id=13651 and http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54337 + + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeTestCommon.h: + (WebKitTests): + (WebKitTests::ExpectTransformationMatrixEq): + * tests/WebTransformOperationsTest.cpp: + (TEST): + (checkProgress): + * tests/WebTransformationMatrixTest.cpp: + (WebKit::TEST): + +2012-08-22 Alexandre Elias <aelias@google.com> + + [chromium] Add software bitmap resources to CCResourceProvider + https://bugs.webkit.org/show_bug.cgi?id=93677 + + Reviewed by Adrienne Walker. + + Second commit after revert. + + This adds the ability to CCResourceProvider to use software bitmaps. + They are allocated as plain-old-memory, and exposed as Skia objects. + + We want the ResourceProvider to be able to handle different resource + types at the same time. In practice, a default resource type is + desired for most uses within a single compositor instance, which is + specified by the default resource type. Default resource types are + expected to be mostly 1-to-1 with CCRenderer types. + + New tests added by parametrizing existing CCResourceProvider tests. + + * tests/CCResourceProviderTest.cpp: + (WebKit::CCResourceProviderTest::getResourcePixels): + +2012-08-22 W. James MacLean <wjmaclean@chromium.org> + + [chromium] Add touch link highlight animation layers. + https://bugs.webkit.org/show_bug.cgi?id=84487 + + Reviewed by James Robinson. + + Adds support for creating composited touch link highlights in renderer thread. Clipping not yet + implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported. + Transform support currently limited to translation. + + Unit tests for LinkHighlight revised. + + * WebKit.gyp: + * src/LinkHighlight.cpp: Added. + (WebKit): + (WebKit::LinkHighlight::create): + (WebKit::LinkHighlight::LinkHighlight): + (WebKit::LinkHighlight::~LinkHighlight): + (WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight. + (WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight. + (WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers. + (WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to. + (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates. + (WebKit::LinkHighlight::paintContents): If highlight active, paints highlight. + (WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation. + (WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium. + (WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate. + (WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes. + (WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position. + Computations proceed only if preceded by call to invalidate(). + (WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid. + (WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout(). + (WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium. + * src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h. + (WebCore): + (WebKit): + (LinkHighlight): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + (WebKit): + (WebKit::highlightConditions): + (WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location. + (WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location. + (WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry(). + * src/WebViewImpl.h: + (WebKit): + (WebViewImpl): + (WebKit::WebViewImpl::linkHighlight): + * tests/LinkHighlightTest.cpp: + (WebCore): + (WebCore::TEST): + * tests/data/test_touch_link_highlight.html: Added. + +2012-08-22 Adam Barth <abarth@webkit.org> + + WebWidget should be able to paint into a zoomed canvas without aliasing + https://bugs.webkit.org/show_bug.cgi?id=92043 + + Reviewed by James Robinson. + + If accelerated compositing is enabled, WebWidget::paint reads back from + the compositor rather than re-painting the widget. That approach works + well if the canvas we're rendering into is at a similar resolution to + the pixels in the compositor, but if the canvas has been scaled (e.g., + to help the user disambiguate links), then reading back from the + compositor will cause aliasing artifacts. + + This patch adds an option to paint to let the embedder request a + software re-rendering of the widget to avoid these aliasing artifacts. + + * public/WebWidget.h: + (WebKit::WebWidget::paint): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::paint): + * src/WebPagePopupImpl.h: + (WebPagePopupImpl): * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::paint): * src/WebPopupMenuImpl.h: - * src/WebRange.cpp: - * src/WebRegularExpression.cpp: - * src/WebScriptController.cpp: - * src/WebSecurityOrigin.cpp: - * src/WebSecurityPolicy.cpp: - * src/WebSelectElement.cpp: - * src/WebSerializedScriptValue.cpp: - * src/WebSessionDescriptionDescriptor.cpp: - * src/WebSettingsImpl.cpp: - * src/WebSocketImpl.cpp: - * src/WebSocketImpl.h: - * src/WebStorageEventDispatcherImpl.cpp: - * src/WebSurroundingText.cpp: - * src/WebURLLoadTiming.cpp: - * src/WorkerAsyncFileWriterChromium.cpp: - * src/WorkerFileSystemCallbacksBridge.cpp: + * src/WebViewImpl.cpp: + (WebKit::canvasBackgroundForTransparencey): + (WebKit): + (WebKit::WebViewImpl::paint): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-22 Eric Penner <epenner@google.com> + + [chromium] Simplify updateContentRect, removing rect parameter, refactor unit tests. + https://bugs.webkit.org/show_bug.cgi?id=94165 + + Reviewed by Adrienne Walker. -2012-10-05 Sadrul Habib Chowdhury <sadrul@chromium.org> + Refactored tests to remove lots of boilerplate code. - [chromium] Allow dragging into plugins. - https://bugs.webkit.org/show_bug.cgi?id=98277 + * tests/CCTiledLayerTestCommon.cpp: + * tests/CCTiledLayerTestCommon.h: + (FakeTiledLayerChromium): + * tests/TiledLayerChromiumTest.cpp: + +2012-08-22 Iain Merrick <husky@chromium.org> + + [chromium] Remove WebFrame::setSelectionToRange + https://bugs.webkit.org/show_bug.cgi?id=94685 + + Reviewed by Adam Barth. + + It has basically the same functionality as WebFrame::selectRange. + The calling code was removed in Chromium patch 152608. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + * src/WebFrameImpl.h: + (WebFrameImpl): + +2012-08-22 Kenneth Russell <kbr@google.com> + + Unreviewed, rolling out r126319. + http://trac.webkit.org/changeset/126319 + https://bugs.webkit.org/show_bug.cgi?id=84487 + + Broke Chromium Mac build + + * WebKit.gyp: + * src/LinkHighlight.cpp: Removed. + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + (WebKit::WebViewImpl::computeScaleAndScrollForHitRect): + (WebKit::WebViewImpl::layout): + * src/WebViewImpl.h: + (WebKit): + (WebViewImpl): + * tests/LinkHighlightTest.cpp: + * tests/data/test_touch_link_highlight.html: Removed. + +2012-08-22 W. James MacLean <wjmaclean@chromium.org> + + [chromium] Add touch link highlight animation layers. + https://bugs.webkit.org/show_bug.cgi?id=84487 + + Reviewed by James Robinson. + + Adds support for creating composited touch link highlights in renderer thread. Clipping not yet + implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported. + Transform support currently limited to translation. + + Unit tests for LinkHighlight revised. + + * WebKit.gyp: + * src/LinkHighlight.cpp: Added. + (WebKit): + (WebKit::LinkHighlight::create): + (WebKit::LinkHighlight::LinkHighlight): + (WebKit::LinkHighlight::~LinkHighlight): + (WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight. + (WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight. + (WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers. + (WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to. + (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates. + (WebKit::LinkHighlight::paintContents): If highlight active, paints highlight. + (WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation. + (WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium. + (WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate. + (WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes. + (WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position. + Computations proceed only if preceded by call to invalidate(). + (WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid. + (WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout(). + (WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium. + * src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h. + (WebCore): + (WebKit): + (LinkHighlight): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + (WebKit): + (WebKit::highlightConditions): + (WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location. + (WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location. + (WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry(). + * src/WebViewImpl.h: + (WebKit): + (WebViewImpl): + (WebKit::WebViewImpl::linkHighlight): + * tests/LinkHighlightTest.cpp: + (WebCore): + (WebCore::TEST): + * tests/data/test_touch_link_highlight.html: Added. + +2012-08-22 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-21 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126202. + http://trac.webkit.org/changeset/126202 + https://bugs.webkit.org/show_bug.cgi?id=94657 + + Causes assertion failures on Chromium Linux dbg compositing + layout tests (Requested by dominicc on #webkit). + + * tests/CCResourceProviderTest.cpp: + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + (WebKit::CCResourceProviderTest::getResourcePixels): + (WebKit::TEST_F): + +2012-08-21 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Find-in-page coordinates should use containingBlock + https://bugs.webkit.org/show_bug.cgi?id=94343 + + Reviewed by Julien Chaffraix. + + The current implementation uses the container method to climb the render tree. + However, it would be more correct and convenient to use containingBlock instead. + Also, this patch introduces new tests for find-in-page coordinates in tables. + + * src/FindInPageCoordinates.cpp: + (WebKit::toNormalizedRect): use containingBlock and get rid of the output parameter as it's not required now. + (WebKit::findInPageRectFromAbsoluteRect): use containingBlock introduce some simplifications. + * tests/WebFrameTest.cpp: add new tests for tables. + * tests/data/find_in_page.html: + * tests/data/find_in_page_frame.html: new tests for tables. + +2012-08-21 Alexandre Elias <aelias@google.com> + + [chromium] Add software bitmap resources to CCResourceProvider + https://bugs.webkit.org/show_bug.cgi?id=93677 + + Reviewed by Adrienne Walker. + + This adds the ability to CCResourceProvider to use software bitmaps. + They are allocated as plain-old-memory, and exposed as Skia objects. + + We want the ResourceProvider to be able to handle different resource + types at the same time. In practice, a default resource type is + desired for most uses within a single compositor instance, which is + specified by the default resource type. Default resource types are + expected to be mostly 1-to-1 with CCRenderer types. + + New tests added by parametrizing existing CCResourceProvider tests. + + * tests/CCResourceProviderTest.cpp: + (WebKit::CCResourceProviderTest::getResourcePixels): + +2012-08-21 Oli Lan <olilan@chromium.org> + + [chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndDelete. + https://bugs.webkit.org/show_bug.cgi?id=93724 + + Reviewed by Ryosuke Niwa. + + This adds two new methods to WebViewImpl. + + 1) setCompositionFromExistingText creates a new composition from the existing text + in the currently focused input field. The new composition is between the two offsets + provided, relative to the rootEditableElement. The current selection is left unchanged. + + 2) extendSelectionAndDelete extends the selection by the specified number of characters + before and after, and then deletes the selection. If the selection is just a caret, the effect + is to delete the specified number of characters before and after the current editing point. + + These methods will be used e.g. by the Android port to implement IME functionality. + + New tests WebViewTest.ExtendSelectionAndDelete and WebViewTest.SetCompositionFromExistingText + test the two new methods. + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setComposingRegion): + (WebKit): + (WebKit::extendSelectionAndDelete): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/WebViewTest.cpp: + +2012-08-21 Alec Flett <alecflett@chromium.org> + + IndexedDB: remove old update/openCursor glue + https://bugs.webkit.org/show_bug.cgi?id=94378 Reviewed by Tony Chang. - Allow plugins to receive drag events. This will make it possible to - perform drag-n-drop into browser plugins (and other plugins if desired). + Remove Chromium/WebKit API for old methods that have now been + removed from chromium proper. + + * public/WebIDBObjectStore.h: + * src/IDBObjectStoreBackendProxy.cpp: + * src/IDBObjectStoreBackendProxy.h: + (IDBObjectStoreBackendProxy): + * src/WebIDBObjectStoreImpl.h: + (WebIDBObjectStoreImpl): + +2012-08-21 James Robinson <jamesr@chromium.org> + + [chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer + https://bugs.webkit.org/show_bug.cgi?id=94631 - * public/WebDragStatus.h: Added. + Reviewed by Adrienne Walker. + + Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash. + + * tests/LayerChromiumTest.cpp: + +2012-08-21 James Robinson <jamesr@chromium.org> + + Unreviewed, rolling out r126170. + http://trac.webkit.org/changeset/126170 + https://bugs.webkit.org/show_bug.cgi?id=94614 + + I spoke too soon + + * WebKit.gypi: + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setScrollLayer): + (WebKit::NonCompositedContentHost::setViewport): + (WebKit::NonCompositedContentHost::scrollLayer): + * src/NonCompositedContentHost.h: + * src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp. (WebKit): - * public/WebPlugin.h: + (WebKit::WebContentLayer::create): + (WebKit::WebContentLayer::clearClient): + (WebKit::WebContentLayer::setDoubleSided): + (WebKit::WebContentLayer::setContentsScale): + (WebKit::WebContentLayer::setUseLCDText): + (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles): + (WebKit::WebContentLayer::WebContentLayer): + (WebKit::WebContentLayer::operator=): + (WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>): + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::create): + (WebKit::WebContentLayerImpl::WebContentLayerImpl): + (WebKit::WebContentLayerImpl::~WebContentLayerImpl): + (WebKit::WebContentLayerImpl::paintContents): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp. (WebKit): - (WebPlugin): + (WebTextureUpdaterImpl): + (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): + (WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayer::create): + (WebKit::WebExternalTextureLayer::clearClient): + (WebKit::WebExternalTextureLayer::setTextureId): + (WebKit::WebExternalTextureLayer::setFlipped): + (WebKit::WebExternalTextureLayer::setUVRect): + (WebKit::WebExternalTextureLayer::setOpaque): + (WebKit::WebExternalTextureLayer::setPremultipliedAlpha): + (WebKit::WebExternalTextureLayer::willModifyTexture): + (WebKit::WebExternalTextureLayer::setRateLimitContext): + (WebKit::WebExternalTextureLayer::WebExternalTextureLayer): + * src/WebExternalTextureLayerImpl.h: Removed. + * src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp. + (WebKit): + (WebKit::WebIOSurfaceLayer::create): + (WebKit::WebIOSurfaceLayer::setIOSurfaceProperties): + (WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer): + * src/WebIOSurfaceLayerImpl.h: Removed. + * src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h. + (WebKit): + (WebKit::WebImageLayer::create): + (WebKit::WebImageLayer::WebImageLayer): + (WebKit::WebImageLayer::setBitmap): + * src/WebLayer.cpp: Added. + (WebKit): + (WebKit::WebLayer::create): + (WebKit::WebLayer::reset): + (WebKit::WebLayer::assign): + (WebKit::WebLayer::equals): + (WebKit::WebLayer::invalidateRect): + (WebKit::WebLayer::invalidate): + (WebKit::WebLayer::addChild): + (WebKit::WebLayer::insertChild): + (WebKit::WebLayer::replaceChild): + (WebKit::WebLayer::setChildren): + (WebKit::WebLayer::removeFromParent): + (WebKit::WebLayer::removeAllChildren): + (WebKit::WebLayer::setAnchorPoint): + (WebKit::WebLayer::anchorPoint): + (WebKit::WebLayer::setAnchorPointZ): + (WebKit::WebLayer::anchorPointZ): + (WebKit::WebLayer::setBounds): + (WebKit::WebLayer::bounds): + (WebKit::WebLayer::setMasksToBounds): + (WebKit::WebLayer::masksToBounds): + (WebKit::WebLayer::setMaskLayer): + (WebKit::WebLayer::setReplicaLayer): + (WebKit::WebLayer::setOpacity): + (WebKit::WebLayer::opacity): + (WebKit::WebLayer::setOpaque): + (WebKit::WebLayer::opaque): + (WebKit::WebLayer::setPosition): + (WebKit::WebLayer::position): + (WebKit::WebLayer::setSublayerTransform): + (WebKit::WebLayer::sublayerTransform): + (WebKit::WebLayer::setTransform): + (WebKit::WebLayer::transform): + (WebKit::WebLayer::setDrawsContent): + (WebKit::WebLayer::drawsContent): + (WebKit::WebLayer::setPreserves3D): + (WebKit::WebLayer::setUseParentBackfaceVisibility): + (WebKit::WebLayer::setBackgroundColor): + (WebKit::WebLayer::setFilters): + (WebKit::WebLayer::setBackgroundFilters): + (WebKit::WebLayer::setDebugBorderColor): + (WebKit::WebLayer::setDebugBorderWidth): + (WebKit::WebLayer::setDebugName): + (WebKit::WebLayer::setAnimationDelegate): + (WebKit::WebLayer::addAnimation): + (WebKit::WebLayer::removeAnimation): + (WebKit::WebLayer::pauseAnimation): + (WebKit::WebLayer::suspendAnimations): + (WebKit::WebLayer::resumeAnimations): + (WebKit::WebLayer::hasActiveAnimation): + (WebKit::WebLayer::transferAnimationsTo): + (WebKit::WebLayer::setForceRenderSurface): + (WebKit::WebLayer::clearRenderSurface): + (WebKit::WebLayer::WebLayer): + (WebKit::WebLayer::operator=): + (WebKit::WebLayer::operator PassRefPtr<LayerChromium>): + * src/WebLayerImpl.cpp: + (WebKit::WebLayerImpl::create): + (WebKit::WebLayerImpl::WebLayerImpl): + (WebKit::WebLayerImpl::~WebLayerImpl): + * src/WebLayerImpl.h: + (WebLayerImpl): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setRootLayer): + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::create): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + (WebKit::WebMediaPlayerClientImpl::repaint): + (WebKit::WebMediaPlayerClientImpl::setOpaque): + (WebKit::WebMediaPlayerClientImpl::platformLayer): + (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + (WebKit::WebPluginContainerImpl::commitBackingTexture): + (WebKit::WebPluginContainerImpl::setOpaque): + (WebKit::WebPluginContainerImpl::platformLayer): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + * src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp. + (WebKit): + (WebKit::WebScrollableLayer::setScrollPosition): + (WebKit::WebScrollableLayer::setScrollable): + (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): + (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): + (WebKit::WebScrollableLayer::setNonFastScrollableRegion): + (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): + (WebKit::WebScrollableLayer::setFixedToContainerLayer): + * src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp. + (WebKit): + (WebKit::WebScrollbarLayer::setScrollLayer): + (WebKit::WebScrollbarLayer::create): + (WebKit::WebScrollbarLayer::WebScrollbarLayer): + (WebKit::WebScrollbarLayer::operator=): + (WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>): + * src/WebScrollbarLayerImpl.h: Removed. + * src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h. + (WebKit): + (WebKit::WebSolidColorLayer::create): + (WebKit::WebSolidColorLayer::WebSolidColorLayer): + (WebKit::WebSolidColorLayer::setBackgroundColor): + * src/WebSolidColorLayerImpl.cpp: + (WebKit::WebSolidColorLayerImpl::create): + (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): + * src/WebSolidColorLayerImpl.h: + (WebSolidColorLayerImpl): + * src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h. + (WebKit): + (WebKit::WebVideoLayer::create): + (WebKit::WebVideoLayer::WebVideoLayer): + (WebKit::WebVideoLayer::active): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setRootGraphicsLayer): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): + * src/WebViewImpl.h: + * tests/ImageLayerChromiumTest.cpp: + (WebCore::TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-21 James Robinson <jamesr@chromium.org> + + Unreviewed, rolling out r126169. + http://trac.webkit.org/changeset/126169 + https://bugs.webkit.org/show_bug.cgi?id=94614 + + Crashes already fixed downstream + + * WebKit.gypi: + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setScrollLayer): + (WebKit::NonCompositedContentHost::setViewport): + (WebKit::NonCompositedContentHost::scrollLayer): + * src/NonCompositedContentHost.h: + * src/WebContentLayer.cpp: Removed. + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayer::create): + (WebKit::WebContentLayerImpl::WebContentLayerImpl): + (WebKit::WebContentLayerImpl::~WebContentLayerImpl): + (WebKit::WebContentLayerImpl::layer): + (WebKit): + (WebKit::WebContentLayerImpl::setDoubleSided): + (WebKit::WebContentLayerImpl::setContentsScale): + (WebKit::WebContentLayerImpl::setUseLCDText): + (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): + (WebKit::WebContentLayerImpl::paintContents): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp. + (WebKit): + (WebKit::WebExternalTextureLayer::create): + (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::layer): + (WebKit::WebExternalTextureLayerImpl::setTextureId): + (WebKit::WebExternalTextureLayerImpl::setFlipped): + (WebKit::WebExternalTextureLayerImpl::setUVRect): + (WebKit::WebExternalTextureLayerImpl::setOpaque): + (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha): + (WebKit::WebExternalTextureLayerImpl::willModifyTexture): + (WebKit::WebExternalTextureLayerImpl::setRateLimitContext): + (WebTextureUpdaterImpl): + (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): + (WebKit::WebExternalTextureLayerImpl::prepareTexture): + (WebKit::WebExternalTextureLayerImpl::context): + * src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h. + (WebKit): + (WebExternalTextureLayerImpl): + * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp. + (WebKit): + (WebKit::WebIOSurfaceLayer::create): + (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): + (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl): + (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties): + (WebKit::WebIOSurfaceLayerImpl::layer): + * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h. + (WebCore): + (WebKit): + (WebIOSurfaceLayerImpl): + * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp. + (WebKit): + (WebKit::WebImageLayer::create): + (WebKit::WebImageLayerImpl::WebImageLayerImpl): + (WebKit::WebImageLayerImpl::~WebImageLayerImpl): + (WebKit::WebImageLayerImpl::layer): + (WebKit::WebImageLayerImpl::setBitmap): + * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp. + (WebCore): + (WebKit): + (WebImageLayerImpl): + * src/WebLayer.cpp: Removed. + * src/WebLayerImpl.cpp: + (WebKit::WebLayer::create): + (WebKit::WebLayerImpl::WebLayerImpl): + (WebKit::WebLayerImpl::~WebLayerImpl): + (WebKit): + (WebKit::WebLayerImpl::id): + (WebKit::WebLayerImpl::invalidateRect): + (WebKit::WebLayerImpl::invalidate): + (WebKit::WebLayerImpl::addChild): + (WebKit::WebLayerImpl::insertChild): + (WebKit::WebLayerImpl::replaceChild): + (WebKit::WebLayerImpl::setChildren): + (WebKit::WebLayerImpl::removeFromParent): + (WebKit::WebLayerImpl::removeAllChildren): + (WebKit::WebLayerImpl::setAnchorPoint): + (WebKit::WebLayerImpl::anchorPoint): + (WebKit::WebLayerImpl::setAnchorPointZ): + (WebKit::WebLayerImpl::anchorPointZ): + (WebKit::WebLayerImpl::setBounds): + (WebKit::WebLayerImpl::bounds): + (WebKit::WebLayerImpl::setMasksToBounds): + (WebKit::WebLayerImpl::masksToBounds): + (WebKit::WebLayerImpl::setMaskLayer): + (WebKit::WebLayerImpl::setReplicaLayer): + (WebKit::WebLayerImpl::setOpacity): + (WebKit::WebLayerImpl::opacity): + (WebKit::WebLayerImpl::setOpaque): + (WebKit::WebLayerImpl::opaque): + (WebKit::WebLayerImpl::setPosition): + (WebKit::WebLayerImpl::position): + (WebKit::WebLayerImpl::setSublayerTransform): + (WebKit::WebLayerImpl::sublayerTransform): + (WebKit::WebLayerImpl::setTransform): + (WebKit::WebLayerImpl::transform): + (WebKit::WebLayerImpl::setDrawsContent): + (WebKit::WebLayerImpl::drawsContent): + (WebKit::WebLayerImpl::setPreserves3D): + (WebKit::WebLayerImpl::setUseParentBackfaceVisibility): + (WebKit::WebLayerImpl::setBackgroundColor): + (WebKit::WebLayerImpl::setFilters): + (WebKit::WebLayerImpl::setBackgroundFilters): + (WebKit::WebLayerImpl::setDebugBorderColor): + (WebKit::WebLayerImpl::setDebugBorderWidth): + (WebKit::WebLayerImpl::setDebugName): + (WebKit::WebLayerImpl::setAnimationDelegate): + (WebKit::WebLayerImpl::addAnimation): + (WebKit::WebLayerImpl::removeAnimation): + (WebKit::WebLayerImpl::pauseAnimation): + (WebKit::WebLayerImpl::suspendAnimations): + (WebKit::WebLayerImpl::resumeAnimations): + (WebKit::WebLayerImpl::hasActiveAnimation): + (WebKit::WebLayerImpl::transferAnimationsTo): + (WebKit::WebLayerImpl::setForceRenderSurface): + (WebKit::WebLayerImpl::setScrollPosition): + (WebKit::WebLayerImpl::setScrollable): + (WebKit::WebLayerImpl::setHaveWheelEventHandlers): + (WebKit::WebLayerImpl::setShouldScrollOnMainThread): + (WebKit::WebLayerImpl::setNonFastScrollableRegion): + (WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers): + (WebKit::WebLayerImpl::setFixedToContainerLayer): + (WebKit::WebLayerImpl::layer): + * src/WebLayerImpl.h: + (WebCore): + (WebLayerImpl): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setRootLayer): + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::create): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + (WebKit::WebMediaPlayerClientImpl::repaint): + (WebKit::WebMediaPlayerClientImpl::setOpaque): + (WebKit::WebMediaPlayerClientImpl::platformLayer): + (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::handleMouseEvent): - (WebKit::WebPluginContainerImpl::handleDragEvent): + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + (WebKit::WebPluginContainerImpl::commitBackingTexture): + (WebKit::WebPluginContainerImpl::setOpaque): + (WebKit::WebPluginContainerImpl::platformLayer): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + * src/WebScrollableLayer.cpp: Removed. + * src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp. + (WebKit): + (WebKit::WebScrollbarLayer::create): + (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): + (WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl): + (WebKit::WebScrollbarLayerImpl::layer): + (WebKit::WebScrollbarLayerImpl::setScrollLayer): + * src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h. + (WebCore): + (WebKit): + (WebScrollbarLayerImpl): + * src/WebSolidColorLayerImpl.cpp: + (WebKit::WebSolidColorLayer::create): + (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): + (WebKit::WebSolidColorLayerImpl::layer): + (WebKit): + (WebKit::WebSolidColorLayerImpl::setBackgroundColor): + * src/WebSolidColorLayerImpl.h: + (WebCore): (WebKit): + (WebSolidColorLayerImpl): + * src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp. + (WebKit): + (WebKit::WebVideoLayer::create): + (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): + (WebKit::WebVideoLayerImpl::~WebVideoLayerImpl): + (WebKit::WebVideoLayerImpl::layer): + (WebKit::WebVideoLayerImpl::active): + * src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp. + (WebCore): + (WebKit): + (WebVideoLayerImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setRootGraphicsLayer): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): + * src/WebViewImpl.h: + * tests/ImageLayerChromiumTest.cpp: + (WebCore::TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-21 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126076, r126099, and r126106. + http://trac.webkit.org/changeset/126076 + http://trac.webkit.org/changeset/126099 + http://trac.webkit.org/changeset/126106 + https://bugs.webkit.org/show_bug.cgi?id=94614 + + Caused crashes during compositor shutdown in Aura builds of + Chromium (Requested by kbr_google on #webkit). + + * WebKit.gypi: + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setScrollLayer): + (WebKit::NonCompositedContentHost::setViewport): + (WebKit::NonCompositedContentHost::scrollLayer): + * src/NonCompositedContentHost.h: + * src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp. + (WebKit): + (WebKit::WebContentLayer::create): + (WebKit::WebContentLayer::clearClient): + (WebKit::WebContentLayer::setDoubleSided): + (WebKit::WebContentLayer::setContentsScale): + (WebKit::WebContentLayer::setUseLCDText): + (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles): + (WebKit::WebContentLayer::WebContentLayer): + (WebKit::WebContentLayer::operator=): + (WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>): + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::create): + (WebKit::WebContentLayerImpl::WebContentLayerImpl): + (WebKit::WebContentLayerImpl::~WebContentLayerImpl): + (WebKit::WebContentLayerImpl::paintContents): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp. + (WebKit): + (WebTextureUpdaterImpl): + (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): + (WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayer::create): + (WebKit::WebExternalTextureLayer::clearClient): + (WebKit::WebExternalTextureLayer::setTextureId): + (WebKit::WebExternalTextureLayer::setFlipped): + (WebKit::WebExternalTextureLayer::setUVRect): + (WebKit::WebExternalTextureLayer::setOpaque): + (WebKit::WebExternalTextureLayer::setPremultipliedAlpha): + (WebKit::WebExternalTextureLayer::willModifyTexture): + (WebKit::WebExternalTextureLayer::setRateLimitContext): + (WebKit::WebExternalTextureLayer::WebExternalTextureLayer): + * src/WebExternalTextureLayerImpl.h: Removed. + * src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp. + (WebKit): + (WebKit::WebIOSurfaceLayer::create): + (WebKit::WebIOSurfaceLayer::setIOSurfaceProperties): + (WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer): + * src/WebIOSurfaceLayerImpl.h: Removed. + * src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h. + (WebKit): + (WebKit::WebImageLayer::create): + (WebKit::WebImageLayer::WebImageLayer): + (WebKit::WebImageLayer::setBitmap): + * src/WebLayer.cpp: Added. + (WebKit): + (WebKit::WebLayer::create): + (WebKit::WebLayer::reset): + (WebKit::WebLayer::assign): + (WebKit::WebLayer::equals): + (WebKit::WebLayer::invalidateRect): + (WebKit::WebLayer::invalidate): + (WebKit::WebLayer::addChild): + (WebKit::WebLayer::insertChild): + (WebKit::WebLayer::replaceChild): + (WebKit::WebLayer::setChildren): + (WebKit::WebLayer::removeFromParent): + (WebKit::WebLayer::removeAllChildren): + (WebKit::WebLayer::setAnchorPoint): + (WebKit::WebLayer::anchorPoint): + (WebKit::WebLayer::setAnchorPointZ): + (WebKit::WebLayer::anchorPointZ): + (WebKit::WebLayer::setBounds): + (WebKit::WebLayer::bounds): + (WebKit::WebLayer::setMasksToBounds): + (WebKit::WebLayer::masksToBounds): + (WebKit::WebLayer::setMaskLayer): + (WebKit::WebLayer::setReplicaLayer): + (WebKit::WebLayer::setOpacity): + (WebKit::WebLayer::opacity): + (WebKit::WebLayer::setOpaque): + (WebKit::WebLayer::opaque): + (WebKit::WebLayer::setPosition): + (WebKit::WebLayer::position): + (WebKit::WebLayer::setSublayerTransform): + (WebKit::WebLayer::sublayerTransform): + (WebKit::WebLayer::setTransform): + (WebKit::WebLayer::transform): + (WebKit::WebLayer::setDrawsContent): + (WebKit::WebLayer::drawsContent): + (WebKit::WebLayer::setPreserves3D): + (WebKit::WebLayer::setUseParentBackfaceVisibility): + (WebKit::WebLayer::setBackgroundColor): + (WebKit::WebLayer::setFilters): + (WebKit::WebLayer::setBackgroundFilters): + (WebKit::WebLayer::setDebugBorderColor): + (WebKit::WebLayer::setDebugBorderWidth): + (WebKit::WebLayer::setDebugName): + (WebKit::WebLayer::setAnimationDelegate): + (WebKit::WebLayer::addAnimation): + (WebKit::WebLayer::removeAnimation): + (WebKit::WebLayer::pauseAnimation): + (WebKit::WebLayer::suspendAnimations): + (WebKit::WebLayer::resumeAnimations): + (WebKit::WebLayer::hasActiveAnimation): + (WebKit::WebLayer::transferAnimationsTo): + (WebKit::WebLayer::setForceRenderSurface): + (WebKit::WebLayer::clearRenderSurface): + (WebKit::WebLayer::WebLayer): + (WebKit::WebLayer::operator=): + (WebKit::WebLayer::operator PassRefPtr<LayerChromium>): + * src/WebLayerImpl.cpp: + (WebKit::WebLayerImpl::create): + (WebKit::WebLayerImpl::WebLayerImpl): + (WebKit::WebLayerImpl::~WebLayerImpl): + * src/WebLayerImpl.h: + (WebLayerImpl): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setRootLayer): + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::create): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + (WebKit::WebMediaPlayerClientImpl::repaint): + (WebKit::WebMediaPlayerClientImpl::setOpaque): + (WebKit::WebMediaPlayerClientImpl::platformLayer): + (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + (WebKit::WebPluginContainerImpl::commitBackingTexture): + (WebKit::WebPluginContainerImpl::setOpaque): + (WebKit::WebPluginContainerImpl::platformLayer): * src/WebPluginContainerImpl.h: (WebPluginContainerImpl): + * src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp. + (WebKit): + (WebKit::WebScrollableLayer::setScrollPosition): + (WebKit::WebScrollableLayer::setScrollable): + (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): + (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): + (WebKit::WebScrollableLayer::setNonFastScrollableRegion): + (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): + (WebKit::WebScrollableLayer::setFixedToContainerLayer): + * src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp. + (WebKit): + (WebKit::WebScrollbarLayer::setScrollLayer): + (WebKit::WebScrollbarLayer::create): + (WebKit::WebScrollbarLayer::WebScrollbarLayer): + (WebKit::WebScrollbarLayer::operator=): + (WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>): + * src/WebScrollbarLayerImpl.h: Removed. + * src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h. + (WebKit): + (WebKit::WebSolidColorLayer::create): + (WebKit::WebSolidColorLayer::WebSolidColorLayer): + (WebKit::WebSolidColorLayer::setBackgroundColor): + * src/WebSolidColorLayerImpl.cpp: + (WebKit::WebSolidColorLayerImpl::create): + (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): + * src/WebSolidColorLayerImpl.h: + (WebSolidColorLayerImpl): + * src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h. + (WebKit): + (WebKit::WebVideoLayer::create): + (WebKit::WebVideoLayer::WebVideoLayer): + (WebKit::WebVideoLayer::active): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setRootGraphicsLayer): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): + * src/WebViewImpl.h: + * tests/ImageLayerChromiumTest.cpp: + (WebCore::TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: -2012-10-04 Kenichi Ishibashi <bashi@chromium.org> +2012-08-21 Ilya Tikhonovsky <loislo@chromium.org> - [WebSocket] ExtensionParser should have its own file - https://bugs.webkit.org/show_bug.cgi?id=98475 + Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember. + https://bugs.webkit.org/show_bug.cgi?id=94580 - Reviewed by Yuta Kitamura. + Reviewed by Yury Semikhatsky. - Add a test for parsing Sec-WebSocket-Extensions field. + Drive by fix: immutable ElementAttrybuteData uses the same trick with placement new as in StylePropertySet. - * tests/WebSocketExtensionDispatcherTest.cpp: + * tests/MemoryInstrumentationTest.cpp: + (WebCore::TEST): (WebCore): - (WebCore::TEST_F): -2012-10-04 Kenichi Ishibashi <bashi@chromium.org> +2012-08-21 Peter Beverloo <peter@chromium.org> - [Chromium] Improve SocketStreamHandle::send() stability - https://bugs.webkit.org/show_bug.cgi?id=98459 + Unreviewed. Rolled DEPS. - Reviewed by Yuta Kitamura. + * DEPS: - Avoid null dereference in SocketStreamHandleInternal::send(). - No changes in behavior. +2012-08-20 Kent Tamura <tkent@chromium.org> - * src/SocketStreamHandle.cpp: - (WebCore::SocketStreamHandleInternal::send): + [Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date] + https://bugs.webkit.org/show_bug.cgi?id=94281 -2012-10-04 Dirk Pranke <dpranke@chromium.org> + Reviewed by Hajime Morita. - Chromium DEPS roll r160281:160322 + * tests/LocaleWinTest.cpp: + (TEST_F): Added formatting and parsing tests for Persian locale to check + native digit behavior. - Unreviewed. +2012-08-20 Kent Tamura <tkent@chromium.org> + + [Chromium] Make the popup positioning code testable + https://bugs.webkit.org/show_bug.cgi?id=94086 + + Reviewed by Hajime Morita. + + * WebKit.gypi: Add PopupContainerTest.cpp. + * tests/PopupContainerTest.cpp: Added. + (MockPopupContent): + (calculatePosition): + (TEST): + +2012-08-20 Scott Graham <scottmg@chromium.org> + + [Chromium] Fix warnings on Windows builds + https://bugs.webkit.org/show_bug.cgi?id=94543 + + Reviewed by Adrienne Walker. + + * tests/CCMathUtilTest.cpp: + +2012-08-20 Adam Klein <adamk@chromium.org> + + Allow MutationEvents to be enabled/disabled per context + https://bugs.webkit.org/show_bug.cgi?id=94016 + + Reviewed by Ojan Vafai. + + Add Chromium/WebKit API for enabling/disabling MutationEvents via + WebPermissionClient. + + * public/WebPermissionClient.h: + (WebPermissionClient): + (WebKit::WebPermissionClient::allowMutationEvents): + * src/ContextFeaturesClientImpl.cpp: + (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): + +2012-08-20 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126095. + http://trac.webkit.org/changeset/126095 + https://bugs.webkit.org/show_bug.cgi?id=94555 + + Breaks compilation of downstream WebWidget::paint + implementations (Requested by jamesr on #webkit). + + * public/WebWidget.h: + (WebKit::WebWidget::paint): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::paint): + * src/WebPagePopupImpl.h: + (WebPagePopupImpl): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::paint): + * src/WebPopupMenuImpl.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::paint): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-20 Kentaro Hara <haraken@chromium.org> + + [V8] Move instrumentedCallFunction() from V8Proxy to ScriptController + https://bugs.webkit.org/show_bug.cgi?id=94456 + + Reviewed by Adam Barth. + + To kill V8Proxy, this patch moves instrumentedCallFunction() from V8Proxy + to ScriptController. Also this patch renames instrumentedCallFunction() + to callFunctionWithInstrumentation(), for consistency with callFunction(). + + No tests. No change in behavior. + + * src/WebDevToolsFrontendImpl.cpp: + (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): + +2012-08-20 Kentaro Hara <haraken@chromium.org> + + [V8] Move retrieve{Window,Frame,PerContextData}() from V8Proxy to V8Binding + https://bugs.webkit.org/show_bug.cgi?id=94460 + + Reviewed by Adam Barth. + + To kill V8Proxy, we move retrieve{Window,Frame,PerContextData}() + from V8Proxy to V8Binding. Also, this patch renames these methods as follows: + + - retrieveWindow() -> toDOMWindow() + - retrieveFrame() -> toFrameIfNotDetached() + - retrievePerContextData() -> perContextDataForCurrentWorld() + + No tests. No change in behavior. + + * src/WebBindings.cpp: + (WebKit::makeIntArrayImpl): + (WebKit::makeStringArrayImpl): + * src/WebFrameImpl.cpp: + (WebKit::WebFrame::frameForContext): + +2012-08-20 James Robinson <jamesr@chromium.org> + + [chromium] REGRESSION(126076) Should not touch old GraphicsLayerChromium::m_contentsLayer when setting up a new contents layer + https://bugs.webkit.org/show_bug.cgi?id=94544 + + Reviewed by Adrienne Walker. + + * src/WebLayerImpl.cpp: + (WebKit::WebLayerImpl::id): + (WebKit): + * src/WebLayerImpl.h: + (WebLayerImpl): + +2012-08-20 Kentaro Hara <haraken@chromium.org> + + [V8] Move collectGarbage() from ScriptController to V8GCController + https://bugs.webkit.org/show_bug.cgi?id=94455 + + Reviewed by Adam Barth. + + - This patch moves collectGarbage() from ScriptController to V8GCController. + - This patch makes collectGarbage() a static method. + - This patch removes ScriptController::lowMemoryNotification() + since it is not used at all. + + No tests. No change in behavior. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::collectGarbage): + +2012-08-20 Adam Barth <abarth@webkit.org> + + WebWidget should be able to paint into a zoomed canvas without aliasing + https://bugs.webkit.org/show_bug.cgi?id=92043 + + Reviewed by James Robinson. + + If accelerated compositing is enabled, WebWidget::paint reads back from + the compositor rather than re-painting the widget. That approach works + well if the canvas we're rendering into is at a similar resolution to + the pixels in the compositor, but if the canvas has been scaled (e.g., + to help the user disambiguate links), then reading back from the + compositor will cause aliasing artifacts. + + This patch adds an option to paint to let the embedder request a + software re-rendering of the widget to avoid these aliasing artifacts. + + * public/WebWidget.h: + (WebKit::WebWidget::paint): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::paint): + * src/WebPagePopupImpl.h: + (WebPagePopupImpl): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::paint): + * src/WebPopupMenuImpl.h: + * src/WebViewImpl.cpp: + (WebKit::canvasBackgroundForTransparencey): + (WebKit): + (WebKit::WebViewImpl::paint): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-20 James Robinson <jamesr@chromium.org> + + Unreviewed. Roll WebKit chromium DEPS forward. * DEPS: -2012-10-04 Alexandre Elias <aelias@chromium.org> +2012-08-20 Kentaro Hara <haraken@chromium.org> - [chromium] Scale plugin container by frameScaleFactor - https://bugs.webkit.org/show_bug.cgi?id=98468 + [V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptController + https://bugs.webkit.org/show_bug.cgi?id=94459 Reviewed by Adam Barth. - Plugin containers (for invalid plugins) weren't taking into account - frameScaleFactor, looking cut off when that was non-1. + To kill V8Proxy, we can move clearForClose() and + clearForNavigation() from V8Proxy to ScriptController. + + No tests. No change in behavior. + + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::detachedFromParent3): + +2012-08-20 Kentaro Hara <haraken@chromium.org> + + [V8] Move mainWorldContext() from V8Proxy to ScriptController + https://bugs.webkit.org/show_bug.cgi?id=94453 + + Reviewed by Adam Barth. + + This patch moves mainWorldContext() from V8Proxy to ScriptController. + In addition, this patch removes dependency on V8Proxy from WorldContextHandle. + + No tests. No change in behavior. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::mainWorldScriptContext): + +2012-08-20 Adam Klein <adamk@chromium.org> + + Remove redundant TOUCH_LISTENER event type + https://bugs.webkit.org/show_bug.cgi?id=94524 + + Reviewed by Ryosuke Niwa. * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::paint): + (WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): Remove + bookkeeping for TOUCH_LISTENER. + +2012-08-16 James Robinson <jamesr@chromium.org> + + [chromium] Change WebLayer from a concrete type to a pure virtual interface + https://bugs.webkit.org/show_bug.cgi?id=94174 + + Reviewed by Adrienne Walker. + + This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl / + NonCompositedContentHost. + + * WebKit.gyp: + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setScrollLayer): + (WebKit::NonCompositedContentHost::setViewport): + (WebKit::NonCompositedContentHost::scrollLayer): + * src/NonCompositedContentHost.h: + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayer::create): + (WebKit::WebContentLayerImpl::WebContentLayerImpl): + (WebKit::WebContentLayerImpl::~WebContentLayerImpl): + (WebKit::WebContentLayerImpl::layer): + (WebKit): + (WebKit::WebContentLayerImpl::clearClient): + (WebKit::WebContentLayerImpl::setDoubleSided): + (WebKit::WebContentLayerImpl::setContentsScale): + (WebKit::WebContentLayerImpl::setUseLCDText): + (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): + (WebKit::WebContentLayerImpl::paintContents): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebExternalTextureLayer.cpp: Removed. + * src/WebExternalTextureLayerImpl.cpp: Added. + (WebKit): + (WebKit::WebExternalTextureLayer::create): + (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::layer): + (WebKit::WebExternalTextureLayerImpl::clearClient): + (WebKit::WebExternalTextureLayerImpl::setTextureId): + (WebKit::WebExternalTextureLayerImpl::setFlipped): + (WebKit::WebExternalTextureLayerImpl::setUVRect): + (WebKit::WebExternalTextureLayerImpl::setOpaque): + (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha): + (WebKit::WebExternalTextureLayerImpl::willModifyTexture): + (WebKit::WebExternalTextureLayerImpl::setRateLimitContext): + (WebTextureUpdaterImpl): + (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): + (WebKit::WebExternalTextureLayerImpl::prepareTexture): + (WebKit::WebExternalTextureLayerImpl::context): + * src/WebExternalTextureLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebContentLayer.cpp. + (WebKit): + (WebExternalTextureLayerImpl): + * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp. + (WebKit): + (WebKit::WebIOSurfaceLayer::create): + (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): + (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl): + (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties): + (WebKit::WebIOSurfaceLayerImpl::layer): + * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h. + (WebCore): + (WebKit): + (WebIOSurfaceLayerImpl): + * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp. + (WebKit): + (WebKit::WebImageLayer::create): + (WebKit::WebImageLayerImpl::WebImageLayerImpl): + (WebKit::WebImageLayerImpl::~WebImageLayerImpl): + (WebKit::WebImageLayerImpl::layer): + (WebKit::WebImageLayerImpl::setBitmap): + * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp. + (WebCore): + (WebKit): + (WebImageLayerImpl): + * src/WebLayer.cpp: Removed. + * src/WebLayerImpl.cpp: + (WebKit::WebLayer::create): + (WebKit::WebLayerImpl::WebLayerImpl): + (WebKit::WebLayerImpl::~WebLayerImpl): + (WebKit): + (WebKit::WebLayerImpl::invalidateRect): + (WebKit::WebLayerImpl::invalidate): + (WebKit::WebLayerImpl::addChild): + (WebKit::WebLayerImpl::insertChild): + (WebKit::WebLayerImpl::replaceChild): + (WebKit::WebLayerImpl::setChildren): + (WebKit::WebLayerImpl::removeFromParent): + (WebKit::WebLayerImpl::removeAllChildren): + (WebKit::WebLayerImpl::setAnchorPoint): + (WebKit::WebLayerImpl::anchorPoint): + (WebKit::WebLayerImpl::setAnchorPointZ): + (WebKit::WebLayerImpl::anchorPointZ): + (WebKit::WebLayerImpl::setBounds): + (WebKit::WebLayerImpl::bounds): + (WebKit::WebLayerImpl::setMasksToBounds): + (WebKit::WebLayerImpl::masksToBounds): + (WebKit::WebLayerImpl::setMaskLayer): + (WebKit::WebLayerImpl::setReplicaLayer): + (WebKit::WebLayerImpl::setOpacity): + (WebKit::WebLayerImpl::opacity): + (WebKit::WebLayerImpl::setOpaque): + (WebKit::WebLayerImpl::opaque): + (WebKit::WebLayerImpl::setPosition): + (WebKit::WebLayerImpl::position): + (WebKit::WebLayerImpl::setSublayerTransform): + (WebKit::WebLayerImpl::sublayerTransform): + (WebKit::WebLayerImpl::setTransform): + (WebKit::WebLayerImpl::transform): + (WebKit::WebLayerImpl::setDrawsContent): + (WebKit::WebLayerImpl::drawsContent): + (WebKit::WebLayerImpl::setPreserves3D): + (WebKit::WebLayerImpl::setUseParentBackfaceVisibility): + (WebKit::WebLayerImpl::setBackgroundColor): + (WebKit::WebLayerImpl::setFilters): + (WebKit::WebLayerImpl::setBackgroundFilters): + (WebKit::WebLayerImpl::setDebugBorderColor): + (WebKit::WebLayerImpl::setDebugBorderWidth): + (WebKit::WebLayerImpl::setDebugName): + (WebKit::WebLayerImpl::setAnimationDelegate): + (WebKit::WebLayerImpl::addAnimation): + (WebKit::WebLayerImpl::removeAnimation): + (WebKit::WebLayerImpl::pauseAnimation): + (WebKit::WebLayerImpl::suspendAnimations): + (WebKit::WebLayerImpl::resumeAnimations): + (WebKit::WebLayerImpl::hasActiveAnimation): + (WebKit::WebLayerImpl::transferAnimationsTo): + (WebKit::WebLayerImpl::setForceRenderSurface): + (WebKit::WebLayerImpl::clearRenderSurface): + (WebKit::WebLayerImpl::setScrollPosition): + (WebKit::WebLayerImpl::setScrollable): + (WebKit::WebLayerImpl::setHaveWheelEventHandlers): + (WebKit::WebLayerImpl::setShouldScrollOnMainThread): + (WebKit::WebLayerImpl::setNonFastScrollableRegion): + (WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers): + (WebKit::WebLayerImpl::setFixedToContainerLayer): + (WebKit::WebLayerImpl::layer): + * src/WebLayerImpl.h: + (WebCore): + (WebLayerImpl): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setRootLayer): + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::create): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::readyStateChanged): + (WebKit::WebMediaPlayerClientImpl::repaint): + (WebKit::WebMediaPlayerClientImpl::setOpaque): + (WebKit::WebMediaPlayerClientImpl::platformLayer): + (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setBackingTextureId): + (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): + (WebKit::WebPluginContainerImpl::commitBackingTexture): + (WebKit::WebPluginContainerImpl::setOpaque): + (WebKit::WebPluginContainerImpl::platformLayer): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + * src/WebScrollableLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollableLayer.cpp. + (WebKit): + (WebKit::WebScrollableLayer::setScrollPosition): + (WebKit::WebScrollableLayer::setScrollable): + (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): + (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): + (WebKit::WebScrollableLayer::setNonFastScrollableRegion): + (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): + (WebKit::WebScrollableLayer::setFixedToContainerLayer): + * src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp. + (WebKit): + (WebKit::WebScrollbarLayer::create): + (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): + (WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl): + (WebKit::WebScrollbarLayerImpl::layer): + (WebKit::WebScrollbarLayerImpl::setScrollLayer): + * src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h. + (WebCore): + (WebKit): + (WebScrollbarLayerImpl): + * src/WebSolidColorLayerImpl.cpp: + (WebKit::WebSolidColorLayer::create): + (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): + (WebKit::WebSolidColorLayerImpl::layer): + (WebKit): + (WebKit::WebSolidColorLayerImpl::setBackgroundColor): + * src/WebSolidColorLayerImpl.h: + (WebCore): + (WebKit): + (WebSolidColorLayerImpl): + * src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp. + (WebKit): + (WebKit::WebVideoLayer::create): + (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): + (WebKit::WebVideoLayerImpl::~WebVideoLayerImpl): + (WebKit::WebVideoLayerImpl::layer): + (WebKit::WebVideoLayerImpl::active): + * src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp. + (WebCore): + (WebKit): + (WebVideoLayerImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setRootGraphicsLayer): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit): + * src/WebViewImpl.h: + * tests/ImageLayerChromiumTest.cpp: + (WebCore::TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-20 Shawn Singh <shawnsingh@chromium.org> + + [chromium] CCMathUtilTest.smallestAngleBetweenVectors unit test failing + https://bugs.webkit.org/show_bug.cgi?id=94502 + + Reviewed by Kenneth Russell. + + The test needed to use EXPECT_FLOAT_EQ instead of EXPECT_EQ. In + this patch, the test is also re-enabled. + + * tests/CCMathUtilTest.cpp: + +2012-08-20 Leandro Gracia Gil <leandrogracia@chromium.org> + + Move transformFriendlyBoundingBox out of Range + https://bugs.webkit.org/show_bug.cgi?id=94366 + + Reviewed by Ryosuke Niwa. + + Update the WebKit code that makes use of transformFriendlyBoundingBox. + + * src/FindInPageCoordinates.cpp: + (WebKit::findInPageRectFromRange): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::find): + (WebKit::WebFrameImpl::selectFindMatch): + +2012-08-20 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] detectContentIntentAround has a misleading name + https://bugs.webkit.org/show_bug.cgi?id=94349 + + Reviewed by Adam Barth. + + The current WebViewClient API exposes a method named detectContentIntentAround. + However, this is not designed to detect any "content intent", but to allow the embedder + to detect content around a position and fire Android intents if appropriate. + + This patch also disables content detection if the touched node listens to events + that consume the tap action like clicks, touch events or mouse events. + + * public/WebViewClient.h: + (WebViewClient): + (WebKit::WebViewClient::detectContentAround): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::detectContentOnTouch): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-20 Hans Wennborg <hans@chromium.org> + + Respect runtime flags for Device Orientation and Device Motion + https://bugs.webkit.org/show_bug.cgi?id=94479 + + Reviewed by Adam Barth. + + WebRuntimeFeatures::enableDeviceMotion should not be hard-coded to + false. + + * src/WebViewImpl.cpp: + (WebKit::WebView::create): + +2012-08-20 David Reveman <reveman@chromium.org> + + [Chromium] Schedule texture uploads based on hard-coded timer and vsync. + https://bugs.webkit.org/show_bug.cgi?id=84281 + + Reviewed by James Robinson. + + * tests/CCSchedulerTest.cpp: + (WebKitTests::TEST): + * tests/CCSchedulerTestCommon.h: + (WebKitTests::FakeCCTimeSource::FakeCCTimeSource): + (WebKitTests::FakeCCTimeSource::setNextTickTime): + (FakeCCTimeSource): + * tests/CCTextureUpdateControllerTest.cpp: + +2012-08-20 Kenneth Russell <kbr@google.com> + + Unreviewed Chromium rebaselining and test failure suppressions. + + https://bugs.webkit.org/show_bug.cgi?id=94502 + + * tests/CCMathUtilTest.cpp: + +2012-08-20 Ian Vollick <vollick@chromium.org> + + [chromium] Add tracing for active composited animations + https://bugs.webkit.org/show_bug.cgi?id=84210 + + Reviewed by James Robinson. + + This patch issues the trace events from the animations. Animations will + report when they start and finish on the main and impl threads (via + TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they + change state. + + * src/WebAnimationImpl.cpp: + (WebKit::WebAnimationImpl::cloneToCCAnimation): + * tests/CCAnimationTestCommon.h: + +2012-08-20 Sami Kyostila <skyostil@chromium.org> + + [chromium] Convert screen space scroll gestures to layer space + https://bugs.webkit.org/show_bug.cgi?id=92499 + + Reviewed by James Robinson. + + Added new tests for verifying transformed layer scrolling: + + CCLayerTreeHostImplTest.scrollAxisAlignedRotatedLayer + CCLayerTreeHostImplTest.scrollNonAxisAlignedRotatedLayer + CCLayerTreeHostImplTest.scrollScaledLayer + + Also some tests for the introduced math utilities: + + CCMathUtilTest.smallestAngleBetweenVectors + CCMathUtilTest.vectorProjection + + * src/WebCompositorInputHandlerImpl.cpp: + (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): + (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): + * tests/CCLayerTreeHostImplTest.cpp: Adjusted scroll delta in scrollChildBeyondLimit to avoid triggering the 45 degree rule. + * tests/CCLayerTreeHostTest.cpp: + * tests/CCMathUtilTest.cpp: + * tests/WebCompositorInputHandlerImplTest.cpp: + (MockCCInputHandlerClient): + (WebKit::TEST_F): + +2012-08-20 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: load scripts panel lazily + https://bugs.webkit.org/show_bug.cgi?id=94416 + + Reviewed by Vsevolod Vlasov. + + * WebKit.gyp: + +2012-08-19 Kentaro Hara <haraken@chromium.org> + + [V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController + https://bugs.webkit.org/show_bug.cgi?id=94446 + + Reviewed by Adam Barth. + + To kill V8Proxy, we can move contextDebugId() and setContextDebugId() + from V8Proxy to ScriptController. + + No tests. No change in behavior. + + * src/WebDevToolsAgentImpl.cpp: + (WebKit::WebDevToolsAgentImpl::didCreateScriptContext): + +2012-08-20 Kentaro Hara <haraken@chromium.org> + + [V8] Move V8Proxy::m_extensions to ScriptController + https://bugs.webkit.org/show_bug.cgi?id=94444 + + Reviewed by Adam Barth. + + To kill V8Proxy, this patch moves V8Proxy::m_extensions to ScriptController. + + No tests. No change in behavior. + + * src/WebScriptController.cpp: + (WebKit::WebScriptController::registerExtension): + +2012-08-19 James Robinson <jamesr@chromium.org> + + [chromium] Put webkit compositor binding files in separate conditionally included gyp section + https://bugs.webkit.org/show_bug.cgi?id=94392 + + Reviewed by Dirk Pranke. + + This allows the use_libcc_for_compositor gyp variable to control whether the webkit bindings are pulled from the + WebKit repository or an external target. + + * WebKit.gyp: + * WebKit.gypi: + +2012-08-19 Rick Byers <rbyers@chromium.org> + + [chromium] Add additional fields to WebGestureEvent + https://bugs.webkit.org/show_bug.cgi?id=94238 + + Reviewed by James Robinson. + + Add a union to WebGestureEvent with per-event-type data, as a first + step to eliminating the overloaded delta fields. + + * public/WebInputEvent.h: + (WebGestureEvent): + (WebKit::WebGestureEvent::WebGestureEvent): + * src/WebInputEvent.cpp: + (SameSizeAsWebGestureEvent): + +2012-08-19 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: load network panel lazily + https://bugs.webkit.org/show_bug.cgi?id=94414 + + Reviewed by Vsevolod Vlasov. + + * WebKit.gyp: + +2012-08-18 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: make profiles panel a lazily loaded module. + https://bugs.webkit.org/show_bug.cgi?id=94351 + + Reviewed by Yury Semikhatsky. + + * WebKit.gyp: + +2012-08-18 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: load panels code on demand + https://bugs.webkit.org/show_bug.cgi?id=94326 + + Reviewed by Vsevolod Vlasov. + + * WebKit.gyp: + * scripts/concatenate_js_files.py: + (OrderedJSFilesExtractor.handle_starttag): + * scripts/inline_js_imports.py: + (main): + +2012-08-17 Dirk Pranke <dpranke@chromium.org> + + Unreviewed, rolling out r125897. + http://trac.webkit.org/changeset/125897 + https://bugs.webkit.org/show_bug.cgi?id=94326 + + this patch seems to have broken the inspector on the apple mac bots. + + * WebKit.gyp: + * scripts/concatenate_js_files.py: + (OrderedJSFilesExtractor.handle_starttag): + * scripts/inline_js_imports.py: + (main): + +2012-08-17 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r125922. + http://trac.webkit.org/changeset/125922 + https://bugs.webkit.org/show_bug.cgi?id=94389 + + "Causing failing/crashing tests on Mac bots" (Requested by + bradee-oh on #webkit). + + * WebKit.gyp: + +2012-08-16 James Robinson <jamesr@chromium.org> + + [chromium] Add Source/WebCore/platform/graphics/chromium/cc/ to include path and remove cc/ prefix from includes + https://bugs.webkit.org/show_bug.cgi?id=94279 + + Reviewed by Adam Barth. + + * src/WebAnimationCurveCommon.cpp: + * src/WebAnimationImpl.cpp: + * src/WebCompositorInputHandlerImpl.cpp: + * src/WebCompositorInputHandlerImpl.h: + * src/WebExternalTextureLayer.cpp: + * src/WebFloatAnimationCurve.cpp: + * src/WebLayerTreeView.cpp: + * src/WebLayerTreeViewImpl.cpp: + * src/WebTransformAnimationCurve.cpp: + * tests/CCActiveAnimationTest.cpp: + * tests/CCAnimationTestCommon.cpp: + * tests/CCAnimationTestCommon.h: + * tests/CCDamageTrackerTest.cpp: + * tests/CCDelayBasedTimeSourceTest.cpp: + * tests/CCFrameRateControllerTest.cpp: + * tests/CCKeyframedAnimationCurveTest.cpp: + * tests/CCLayerAnimationControllerTest.cpp: + * tests/CCLayerImplTest.cpp: + * tests/CCLayerIteratorTest.cpp: + * tests/CCLayerQuadTest.cpp: + * tests/CCLayerSorterTest.cpp: + * tests/CCLayerTestCommon.cpp: + * tests/CCLayerTestCommon.h: + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCMathUtilTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + * tests/CCOcclusionTrackerTestCommon.h: + * tests/CCPrioritizedTextureTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/CCRenderSurfaceFiltersTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCResourceProviderTest.cpp: + * tests/CCSchedulerStateMachineTest.cpp: + * tests/CCSchedulerTest.cpp: + * tests/CCSchedulerTestCommon.h: + * tests/CCScopedTextureTest.cpp: + * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + * tests/CCTestCommon.h: + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCThreadTaskTest.cpp: + * tests/CCThreadedTest.cpp: + * tests/CCThreadedTest.h: + * tests/CCTiledLayerImplTest.cpp: + * tests/CCTiledLayerTestCommon.h: + * tests/CCTimerTest.cpp: + * tests/ContentLayerChromiumTest.cpp: + * tests/FakeCCGraphicsContext.h: + * tests/FakeCCLayerTreeHostClient.h: + * tests/FloatQuadTest.cpp: + * tests/GraphicsLayerChromiumTest.cpp: + * tests/LayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + * tests/MockCCQuadCuller.h: + * tests/PlatformGestureCurveTest.cpp: + * tests/ScrollbarLayerChromiumTest.cpp: + * tests/TextureLayerChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + * tests/TreeSynchronizerTest.cpp: + * tests/WebCompositorInputHandlerImplTest.cpp: + * tests/WebFloatAnimationCurveTest.cpp: + * tests/WebTransformAnimationCurveTest.cpp: + +2012-08-17 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: make profiles panel a lazily loaded module. + https://bugs.webkit.org/show_bug.cgi?id=94351 + + Reviewed by Yury Semikhatsky. + + * WebKit.gyp: + +2012-08-17 Keishi Hattori <keishi@webkit.org> + + [Chromium] Turn off ENABLE_DATALIST_ELEMENT for Android + https://bugs.webkit.org/show_bug.cgi?id=94337 + + Reviewed by Kent Tamura. + + We shouldn't have turned ENABLE_DATALIST_ELEMENT on for Android. + + * features.gypi: -2012-10-04 Alpha Lam <hclam@chromium.org> +2012-08-17 Sheriff Bot <webkit.review.bot@gmail.com> - Unreviewd. Chromium DEPS roll. Update to r160281. + Unreviewed, rolling out r125892. + http://trac.webkit.org/changeset/125892 + https://bugs.webkit.org/show_bug.cgi?id=94350 + + Broke windows build (Requested by vollick on #webkit). + + * src/WebAnimationImpl.cpp: + (WebKit::WebAnimationImpl::cloneToCCAnimation): + +2012-08-17 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. * DEPS: -2012-10-04 Mark Pilgrim <pilgrim@chromium.org> +2012-08-17 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: load panels code on demand + https://bugs.webkit.org/show_bug.cgi?id=94326 + + Reviewed by Vsevolod Vlasov. + + * WebKit.gyp: + * scripts/concatenate_js_files.py: + (OrderedJSFilesExtractor.handle_starttag): + * scripts/inline_js_imports.py: + (main): + +2012-08-17 Ian Vollick <vollick@chromium.org> + + [chromium] Add tracing for active composited animations + https://bugs.webkit.org/show_bug.cgi?id=84210 + + Reviewed by James Robinson. + + This patch issues the trace events from the animations. Animations will + report when they start and finish on the main and impl threads (via + TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they + change state. + + * src/WebAnimationImpl.cpp: + (WebKit::WebAnimationImpl::cloneToCCAnimation): + +2012-08-16 Antoine Labour <piman@chromium.org> + + [chromium] Add resource transfer functions to CCResourceProvider + https://bugs.webkit.org/show_bug.cgi?id=93524 + + Reviewed by James Robinson. + + This adds methods to CCResourceProvider to be able to transport + resources from a child to a parent. + + Added test to CCResourceProviderTest. + + * tests/CCResourceProviderTest.cpp: + (WebKit::textureSize): + (WebKit): + (WebKit::Texture::Texture): + (Texture): + (ContextSharedData): + (WebKit::ContextSharedData::create): + (WebKit::ContextSharedData::insertSyncPoint): + (WebKit::ContextSharedData::genMailbox): + (WebKit::ContextSharedData::produceTexture): + (WebKit::ContextSharedData::consumeTexture): + (WebKit::ContextSharedData::ContextSharedData): + (WebKit::ResourceProviderContext::create): + (ResourceProviderContext): + (WebKit::ResourceProviderContext::insertSyncPoint): + (WebKit::ResourceProviderContext::waitSyncPoint): + (WebKit::ResourceProviderContext::genMailboxCHROMIUM): + (WebKit::ResourceProviderContext::produceTextureCHROMIUM): + (WebKit::ResourceProviderContext::consumeTextureCHROMIUM): + (WebKit::ResourceProviderContext::ResourceProviderContext): + (PendingProduceTexture): + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + (CCResourceProviderTest): + (WebKit::TEST_F): + +2012-08-16 David Grogan <dgrogan@chromium.org> + + IndexedDB: Frontend and plumbing for integer versions + https://bugs.webkit.org/show_bug.cgi?id=92897 + + Reviewed by Tony Chang. + + * src/IDBCallbacksProxy.cpp: + (WebKit::IDBCallbacksProxy::onBlocked): + (WebKit): + (WebKit::IDBCallbacksProxy::onUpgradeNeeded): + * src/IDBCallbacksProxy.h: + (IDBCallbacksProxy): + * src/IDBDatabaseBackendProxy.cpp: + (WebKit::IDBDatabaseBackendProxy::setVersion): + * src/IDBDatabaseCallbacksProxy.cpp: + (WebKit::IDBDatabaseCallbacksProxy::onVersionChange): + (WebKit): + * src/IDBDatabaseCallbacksProxy.h: + (IDBDatabaseCallbacksProxy): + * src/IDBFactoryBackendProxy.cpp: + (WebKit::IDBFactoryBackendProxy::open): + * src/IDBFactoryBackendProxy.h: + (IDBFactoryBackendProxy): + * src/IDBTransactionCallbacksProxy.cpp: + (WebKit::IDBTransactionCallbacksProxy::onComplete): + * src/WebIDBCallbacksImpl.cpp: + (WebKit::WebIDBCallbacksImpl::WebIDBCallbacksImpl): + (WebKit::WebIDBCallbacksImpl::onSuccess): + We don't want to create IDBDatabaseBackendProxy again if we've already + created it during upgradeNeeded. This makes + IDBRequest::onSuccess(IDBDatabaseBackend) reuse its previous + IDBDatabaseBackendInterface if it has one. + + (WebKit::WebIDBCallbacksImpl::onBlocked): + (WebKit): + (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): + * src/WebIDBCallbacksImpl.h: + (WebIDBCallbacksImpl): + * src/WebIDBDatabaseCallbacksImpl.cpp: + (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange): + (WebKit): + * src/WebIDBDatabaseCallbacksImpl.h: + (WebIDBDatabaseCallbacksImpl): + * src/WebIDBDatabaseImpl.cpp: + (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): + (WebKit::WebIDBDatabaseImpl::close): + (WebKit::WebIDBDatabaseImpl::open): + * src/WebIDBDatabaseImpl.h: + (WebIDBDatabaseImpl): + * src/WebIDBFactoryImpl.cpp: + (WebKit::WebIDBFactoryImpl::open): + * src/WebIDBFactoryImpl.h: + (WebIDBFactoryImpl): + * src/WebIDBTransactionCallbacksImpl.cpp: + (WebKit::WebIDBTransactionCallbacksImpl::onComplete): + * tests/IDBAbortOnCorruptTest.cpp: + (WebCore::TEST): + * tests/IDBDatabaseBackendTest.cpp: + +2012-08-16 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r125838. + http://trac.webkit.org/changeset/125838 + https://bugs.webkit.org/show_bug.cgi?id=94283 + + Breaks Mac compile due to bug 74625 (Requested by enne on + #webkit). + + * tests/CCResourceProviderTest.cpp: + (WebKit::ResourceProviderContext::create): + (WebKit::ResourceProviderContext::textureSize): + (ResourceProviderContext): + (WebKit::ResourceProviderContext::ResourceProviderContext): + (WebKit::ResourceProviderContext::Texture::Texture): + (Texture): + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + (CCResourceProviderTest): + (WebKit::TEST_F): + +2012-08-16 Kenneth Russell <kbr@google.com> + + Unreviewed, rolling out r125800. + http://trac.webkit.org/changeset/125800 + https://bugs.webkit.org/show_bug.cgi?id=84281 + + Hypothesis that this change caused gpu_throughput_tests to + start timing out on all platforms on the Chromium GPU + canaries. + + * tests/CCSchedulerTest.cpp: + (WebKitTests::TEST): + * tests/CCSchedulerTestCommon.h: + (WebKitTests::FakeCCTimeSource::FakeCCTimeSource): + (FakeCCTimeSource): + * tests/CCTextureUpdateControllerTest.cpp: + +2012-08-16 Antoine Labour <piman@chromium.org> + + [chromium] Add resource transfer functions to CCResourceProvider + https://bugs.webkit.org/show_bug.cgi?id=93524 + + Reviewed by James Robinson. + + This adds methods to CCResourceProvider to be able to transport + resources from a child to a parent. + + Added test to CCResourceProviderTest. + + * tests/CCResourceProviderTest.cpp: + (WebKit::textureSize): + (WebKit): + (WebKit::Texture::Texture): + (Texture): + (ContextSharedData): + (WebKit::ContextSharedData::create): + (WebKit::ContextSharedData::insertSyncPoint): + (WebKit::ContextSharedData::genMailbox): + (WebKit::ContextSharedData::produceTexture): + (WebKit::ContextSharedData::consumeTexture): + (WebKit::ContextSharedData::ContextSharedData): + (WebKit::ResourceProviderContext::create): + (ResourceProviderContext): + (WebKit::ResourceProviderContext::insertSyncPoint): + (WebKit::ResourceProviderContext::waitSyncPoint): + (WebKit::ResourceProviderContext::genMailboxCHROMIUM): + (WebKit::ResourceProviderContext::produceTextureCHROMIUM): + (WebKit::ResourceProviderContext::consumeTextureCHROMIUM): + (WebKit::ResourceProviderContext::ResourceProviderContext): + (PendingProduceTexture): + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + (CCResourceProviderTest): + (WebKit::TEST_F): + +2012-08-16 Alexandre Elias <aelias@google.com> + + [chromium] Replace destRect with destOffset in texture upload + https://bugs.webkit.org/show_bug.cgi?id=94154 + + Reviewed by James Robinson. + + Previously, texture upload code implicitly assumed that sourceRect and + destRect have the same size. The behavior is undefined if they are + different, since they are used interchangeably and there's no support + for scaling from one rect to the other. This patch enforces that + constraint at the interface level by replacing all instances of + "IntRect destRect" by "IntSize destOffset". + + * tests/CCResourceProviderTest.cpp: + (WebKit::TEST_F): + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): + * tests/CCTiledLayerTestCommon.h: + (Texture): + (WebKitTests::FakeTextureUploader::uploadTexture): + +2012-08-16 James Robinson <jamesr@chromium.org> + + [chromium] Remove unnecessary tree hierarchy inspection APIs from WebLayer + https://bugs.webkit.org/show_bug.cgi?id=94229 + + Reviewed by Adrienne Walker. + + Remove dead WebLayer function implementations and tests of same. + + * src/WebLayer.cpp: + * tests/WebLayerTest.cpp: + +2012-08-16 David Reveman <reveman@chromium.org> + + [Chromium] Avoid aliasing global symbol monotonicallyIncreasingTime(). + https://bugs.webkit.org/show_bug.cgi?id=94233 + + Reviewed by James Robinson. + + * tests/CCDelayBasedTimeSourceTest.cpp: + (WebKitTests::TEST): + * tests/CCFrameRateControllerTest.cpp: + (WebKitTests::TEST): + * tests/CCSchedulerTestCommon.h: + (WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicTimeNow): + (WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource): + (FakeCCDelayBasedTimeSource): + +2012-08-16 David Reveman <reveman@chromium.org> + + [Chromium] Schedule texture uploads based on hard-coded timer and vsync. + https://bugs.webkit.org/show_bug.cgi?id=84281 + + Reviewed by James Robinson. - [Chromium] Update some #includes for Platform directory - https://bugs.webkit.org/show_bug.cgi?id=98440 + * tests/CCSchedulerTest.cpp: + (WebKitTests::TEST): + * tests/CCSchedulerTestCommon.h: + (WebKitTests::FakeCCTimeSource::FakeCCTimeSource): + (WebKitTests::FakeCCTimeSource::setNextTickTime): + (FakeCCTimeSource): + * tests/CCTextureUpdateControllerTest.cpp: + +2012-08-16 Dana Jansens <danakj@chromium.org> + + [chromium] Impl scrolling crashes when the renderer's initialization failed + https://bugs.webkit.org/show_bug.cgi?id=94232 + + Reviewed by James Robinson. + + Also updated the finishAllRenderingAfterContextLost to properly fail + renderer initialization. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-16 Peter Beverloo <peter@chromium.org> + + [Chromium] Pass the --strip-binary argument to the apk test generator + https://bugs.webkit.org/show_bug.cgi?id=94224 Reviewed by Adam Barth. - Part of a refactoring series. See tracking bug 82948. + The native test generator currently relies on the $STRIP environment + variable to be available, which it shouldn't do. Instead, pass it as an + argument to the script. The $STRIP variable is being deprecated. - * src/ApplicationCacheHost.cpp: - * src/AssociatedURLLoader.h: - * src/AsyncFileWriterChromium.cpp: + * WebKitUnitTests.gyp: + +2012-08-16 James Robinson <jamesr@chromium.org> + + [chromium] Remove alwaysReserveTextures code - it doesn't do anything + https://bugs.webkit.org/show_bug.cgi?id=94183 + + Reviewed by Dimitri Glazkov. + + Stops attempting to find the scrollbar layers and call setAlwaysReserveTextures() on them since the call doesn't + do anything. + + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::setViewport): + * src/WebLayer.cpp: + +2012-08-16 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-16 Keishi Hattori <keishi@webkit.org> + + DOMWindowPagePopup needs to be installed before loading the html inside the page popup + https://bugs.webkit.org/show_bug.cgi?id=94193 + + Reviewed by Kent Tamura. + + We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html. + + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::initPage): + +2012-08-16 Marja Hölttä <marja@chromium.org> + + WebHistoryItem: Enable reading selected file names from document state + https://bugs.webkit.org/show_bug.cgi?id=91231 + + Reviewed by Jochen Eisinger. + + This change enables Chromium to set up file permissions properly when + the session restore feature restores a page with selected files. + + * public/WebHistoryItem.h: + (WebHistoryItem): Added getReferencedFilePaths. + * src/WebHistoryItem.cpp: + (WebKit::WebHistoryItem::getReferencedFilePaths): Extracts selected and posted file paths from a document state. + (WebKit): + +2012-08-15 Shawn Singh <shawnsingh@chromium.org> + + [chromium] set scissorRect per quad so that quads are correctly clipped + https://bugs.webkit.org/show_bug.cgi?id=94050 + + Reviewed by Adrienne Walker. + + Updated two unit tests to reflect that we need to always scissor, + until we refactor so that quads do not depend on scissoring. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-16 Hironori Bono <hbono@chromium.org> + + Prevent showing suggestions when right-clicking a selection range. + https://bugs.webkit.org/show_bug.cgi?id=94189 + + Reviewed by Hajime Morita. + + To emulate Safari, my r120810 changes selection when right-clicking a misspelled + word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange + and it changes the existing selection when right-clicking a selection which + includes a misspelled word. This change uses VisibleSelection::isCaret to + prevent showing suggestions when right-clicking a selection range. (Neither does + Safari show suggestions when there is a selection range.) + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): + +2012-08-15 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-15 Ryosuke Niwa <rniwa@webkit.org> + + Update manual tests and comments to refer to TestRunner instead of LayoutTestController + https://bugs.webkit.org/show_bug.cgi?id=94168 + + Reviewed by Kent Tamura. + + * public/WebDevToolsAgent.h: + (WebDevToolsAgent): + * public/WebView.h: + (WebView): + +2012-08-15 Alec Flett <alecflett@chromium.org> + + IndexedDB: generate index keys for existing data in createIndex in front end + https://bugs.webkit.org/show_bug.cgi?id=91125 + + Reviewed by Tony Chang. + + Add Chromium API methods to let the renderer process tell the + browser process about indexing progress. + + * public/WebIDBObjectStore.h: + (WebKit::WebIDBObjectStore::openCursor): + * src/IDBObjectStoreBackendProxy.cpp: + (WebKit::IDBObjectStoreBackendProxy::setIndexKeys): + (WebKit): + (WebKit::IDBObjectStoreBackendProxy::setIndexesReady): + (WebKit::IDBObjectStoreBackendProxy::openCursor): + * src/IDBObjectStoreBackendProxy.h: + (IDBObjectStoreBackendProxy): + * src/WebIDBObjectStoreImpl.cpp: + (WebKit::WebIDBObjectStoreImpl::setIndexKeys): + (WebKit): + (WebKit::WebIDBObjectStoreImpl::setIndexesReady): + (WebKit::WebIDBObjectStoreImpl::openCursor): + * src/WebIDBObjectStoreImpl.h: + (WebIDBObjectStoreImpl): + +2012-08-15 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> + + [css3-text] Add CSS3 Text decoration compile flag + https://bugs.webkit.org/show_bug.cgi?id=93863 + + Reviewed by Julien Chaffraix. + + This patch handles the compile flag implementation, which will come disabled by + default, thus not exposing the CSS3 text decoration features to the web, unless + when explicitly enabling it with "--css3-text-decoration" build parameter. + + * features.gypi: + +2012-08-15 Iain Merrick <husky@chromium.org> + + Refactoring: move EventHandler::targetNode into HitTestResult + https://bugs.webkit.org/show_bug.cgi?id=94107 + + Reviewed by Dimitri Glazkov. + + This static helper method in EventHandler was made public so that + WebFrameImpl can call it. That's untidy because EventHandler isn't + really involved. This patch turns it into an instance method of + HitTestResult (with a wrapper in MouseEventWithHitTestResult for + convenience). + + Pure refactoring, no behavior change, no new test needed. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::visiblePositionForWindowPoint): + +2012-08-15 David Grogan <dgrogan@chromium.org> + + IndexedDB: Add some ASSERTs + https://bugs.webkit.org/show_bug.cgi?id=94055 + + Reviewed by Ojan Vafai. + + * src/IDBDatabaseBackendProxy.cpp: + (WebKit::IDBDatabaseBackendProxy::setVersion): + +2012-08-15 Ian Vollick <vollick@chromium.org> + + [chromium] Must account for empty transformation lists when checking for big rotations. + https://bugs.webkit.org/show_bug.cgi?id=93975 + + Reviewed by James Robinson. + + Adds a test to check that creating an animation with a big (> 180 + degree) rotation, where the transform operations list in the 1st + keyframe is empty fails as expected. + + * tests/AnimationTranslationUtilTest.cpp: + (WebKit::TEST): + (WebKit): + +2012-08-15 Joshua Bell <jsbell@chromium.org> + + [chromium] IndexedDB: Delete unused WebKit API cursor accessors + https://bugs.webkit.org/show_bug.cgi?id=94134 + + Reviewed by Adam Barth. + + Last bit of refactor work from http://webkit.org/b/92278 that ships the + cursor key/primaryKey/value to the front end via success messages, eliminating + the need for these accessors and the old success messages. + + * public/WebIDBCallbacks.h: + * public/WebIDBCursor.h: + +2012-08-15 Anna Cavender <annacc@chromium.org> + + Add the timestampOffset attribute to SourceBuffer. + https://bugs.webkit.org/show_bug.cgi?id=93303 + + Reviewed by Dimitri Glazkov. + + On the 30 July 2012 version of the Media Source Extensions spec, a timestampOffset + attribute was added to the SourceBuffer object: + http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#dom-timestampoffset + + * public/WebMediaPlayer.h: + (WebKit::WebMediaPlayer::sourceSetTimestampOffset): Add the new method. + * src/WebMediaPlayerClientImpl.cpp: + (WebKit): + (WebKit::WebMediaPlayerClientImpl::sourceSetTimestampOffset): Forward the call. + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-08-15 Peter Beverloo <peter@chromium.org> + + [Chromium] Roll WebKit Chromium DEPS to r151672 + https://bugs.webkit.org/show_bug.cgi?id=94091 + + Unreviewed DEPS roll. + + This also adds the new dependency on third_party/skia/gyp/, as was + introduced in Chromium's revision 151463. + + * DEPS: + +2012-08-14 Keishi Hattori <keishi@webkit.org> + + Share common code between calendar picker and color suggestion picker + https://bugs.webkit.org/show_bug.cgi?id=93802 + + Reviewed by Kent Tamura. + + * src/ColorChooserUIController.cpp: + (WebKit::ColorChooserUIController::writeDocument): + +2012-08-14 Scott Graham <scottmg@chromium.org> + + [Chromium] Fix warnings on Windows build + https://bugs.webkit.org/show_bug.cgi?id=93997 + + Reviewed by Kentaro Hara. + + Fixes truncation from 'double' to 'float' warnings on Chromium Windows + build. + + * tests/CCRenderSurfaceFiltersTest.cpp: + (WebKit::TEST): + * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: + (WebCore::TEST_F): + +2012-08-14 Chris Rogers <crogers@google.com> + + Implement new synchronized audio I/O render method in chromium + https://bugs.webkit.org/show_bug.cgi?id=93510 + + Reviewed by Kenneth Russell. + + The chromium implementation of AudioDestination is being upgraded to + support synchronized audio I/O. Other changes on the chromium-side + can then be tested against something that works in WebKit. + + * src/AudioDestinationChromium.cpp: + (WebCore::AudioDestinationChromium::AudioDestinationChromium): + (WebCore::AudioDestinationChromium::render): + (WebCore): + (WebCore::AudioDestinationChromium::provideInput): * src/AudioDestinationChromium.h: - * src/AutofillPopupMenuClient.cpp: + (WebCore): + (AudioDestinationChromium): + +2012-08-14 Adam Barth <abarth@webkit.org> + + Delete Frame::domWindow() and Frame::existingDOMWindow() + https://bugs.webkit.org/show_bug.cgi?id=93990 + + Reviewed by Eric Seidel. + + * src/StorageAreaProxy.cpp: + (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): + (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): + * src/WebDOMMessageEvent.cpp: + (WebKit::WebDOMMessageEvent::initMessageEvent): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::performance): + (WebKit::WebFrameImpl::addMessageToConsole): + (WebKit::WebFrameImpl::unloadListenerCount): + (WebKit::WebFrameImpl::addEventListener): + (WebKit::WebFrameImpl::removeEventListener): + (WebKit::WebFrameImpl::dispatchEvent): + (WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck): + (WebKit::WebFrameImpl::deliverIntent): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::initPage): + +2012-08-14 Iain Merrick <husky@chromium.org> + + [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint. + https://bugs.webkit.org/show_bug.cgi?id=93108 + + Reviewed by Adam Barth. + + Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange, + and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is + used by selectRange. + + The test uses sample files that contain selected text on load. The test uses + WebViewImpl::selectionBounds to get the coordinates, deselects all, then + calls WebFrameImpl::selectRange to attempt to reselect the same text. + + Four cases are tested: + - the basic case + - the case where the selected text is offscreen due to a scroll + - the case where the selected text is in an iframe + - the case where the selected text is in an editable element + + * tests/WebFrameTest.cpp: + * tests/data/select_range_basic.html: Added. + * tests/data/select_range_editable.html: Added. + * tests/data/select_range_iframe.html: Added. + * tests/data/select_range_scroll.html: Added. + +2012-08-14 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Pass cursor continue results back in callback + https://bugs.webkit.org/show_bug.cgi?id=92278 + + Reviewed by Tony Chang. + + Supply the updated cursor key/primaryKey/value in the success callback, + rather than forcing the callee to make three calls into the back end to + fetch them. Callbacks onSuccess(cursor) and onSuccessWithContinuation() + are given the three new payload parameters (and the latter is renamed.) + + * public/WebIDBCallbacks.h: + (WebIDBCallbacks): + (WebKit::WebIDBCallbacks::onSuccess): Replace with no-op stub. + (WebKit::WebIDBCallbacks::onSuccessWithContinuation): Ditto. + * public/WebIDBCursor.h: + (WebIDBCursor): Methods can be removed once Chromium is cleaned up. + * src/IDBCallbacksProxy.cpp: Updated callbacks. + (WebKit::IDBCallbacksProxy::onSuccess): + (WebKit): + * src/IDBCallbacksProxy.h: Updated callbacks. + (IDBCallbacksProxy): + * src/IDBCursorBackendProxy.cpp: Remove back end accessors. + * src/IDBCursorBackendProxy.h: + (IDBCursorBackendProxy): + * src/WebIDBCallbacksImpl.cpp: Updated callbacks. + (WebKit::WebIDBCallbacksImpl::onSuccess): + * src/WebIDBCallbacksImpl.h: Updated callbacks. + (WebIDBCallbacksImpl): + * src/WebIDBCursorImpl.cpp: Remove back end accessors. + * src/WebIDBCursorImpl.h: Remove back end accessors. + (WebIDBCursorImpl): + * tests/IDBAbortOnCorruptTest.cpp: Update test stubs. + (WebCore::MockIDBCallbacks::onSuccess): + * tests/IDBDatabaseBackendTest.cpp: Ditto. + * tests/IDBRequestTest.cpp: Ditto. + +2012-08-14 Peter Beverloo <peter@chromium.org> + + [Chromium] Remove unneeded build logic for Android + https://bugs.webkit.org/show_bug.cgi?id=93962 + + Reviewed by Dimitri Glazkov. + + The Android SDK and NDK have been checked in to the Chromium tree, which + allows WebKit to leverage those as well. They will already be pulled in + through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT + environment variable, the envsetup.sh will set the project files up + appropriately for us. + + * DEPS: + +2012-08-14 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-14 Peter Beverloo <peter@chromium.org> + + [Chromium] Fix apk generation for the Android platform + https://bugs.webkit.org/show_bug.cgi?id=93841 + + Unreviewed build fix (step 2). + + The path from webkit_unit_tests isn't robust enough. Use the same + convention as the Chromium side, i.e. walk up from the ant_build_out path. + One-line Android-only gyp change. + + * WebKitUnitTests.gyp: + +2012-08-14 Peter Beverloo <peter@chromium.org> + + [Chromium] Fix apk generation for the Android platform + https://bugs.webkit.org/show_bug.cgi?id=93841 + + Unreviewed build fix. + + APK generation was broken as the configuration file assumed compilation + would only occur in the Chromium tree. Pass the path to Chromium's source + base directory as a property to ant. + + * WebKitUnitTests.gyp: + +2012-08-13 Tom Sepez <tsepez@chromium.org> + + [chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach. + https://bugs.webkit.org/show_bug.cgi?id=93283 + + Reviewed by Eric Seidel. + + Change the client redirectDataToPlugin method(s) to expect the possibility of + a NULL argument, NULLing Chromium's refptr that needs to be NULLed. + + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::redirectDataToPlugin): + +2012-08-13 Eric Penner <epenner@google.com> + + [chromium] Paint animated layers immediately to avoid animation hiccups. + https://bugs.webkit.org/show_bug.cgi?id=93028 + + Reviewed by Adrienne Walker. + + Replaced one test. Test painting full animated layer. + + * tests/TiledLayerChromiumTest.cpp: + +2012-08-12 Shawn Singh <shawnsingh@chromium.org> + + [chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds + https://bugs.webkit.org/show_bug.cgi?id=93795 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-08-13 James Robinson <jamesr@chromium.org> + + [chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols + https://bugs.webkit.org/show_bug.cgi?id=93907 + + Reviewed by Darin Fisher. + + Adds a WebAnimationImpl implementation of the WebAnimation interface. + + * WebKit.gyp: + * src/WebAnimationImpl.cpp: Renamed from Source/WebKit/chromium/src/WebAnimation.cpp. + (WebKit): + (WebKit::WebAnimation::create): + (WebKit::WebAnimationImpl::targetProperty): + (WebKit::WebAnimationImpl::iterations): + (WebKit::WebAnimationImpl::setIterations): + (WebKit::WebAnimationImpl::startTime): + (WebKit::WebAnimationImpl::setStartTime): + (WebKit::WebAnimationImpl::timeOffset): + (WebKit::WebAnimationImpl::setTimeOffset): + (WebKit::WebAnimationImpl::alternatesDirection): + (WebKit::WebAnimationImpl::setAlternatesDirection): + (WebKit::WebAnimationImpl::cloneToCCAnimation): + * src/WebAnimationImpl.h: Added. + (WebCore): + (WebKit): + (WebAnimationImpl): + (WebKit::WebAnimationImpl::WebAnimationImpl): + (WebKit::WebAnimationImpl::~WebAnimationImpl): + * src/WebLayer.cpp: + (WebKit::WebLayer::addAnimation): + * tests/WebAnimationTest.cpp: + (WebKit::TEST): + +2012-08-10 James Robinson <jamesr@chromium.org> + + [chromium] Clean up dependencies for Canvas2DLayerBridgeTest and GraphicsLayerChromiumTest unit tests + https://bugs.webkit.org/show_bug.cgi?id=93757 + + Reviewed by Adrienne Walker. + + Breaks up some unit tests and removes unused code to avoid unit tests depending on both non-compositor WebCore + logic and compositor internals. Canvas2DLayerBridgeTest had some vestigal includes and local variables that + weren't being used, those are removed. GraphicsLayerChromiumTest was reaching into CC types, but could mostly + use Platform API types for testing. + + GraphicsLayerChromiumTest had some tests that were verifying that we could correctly translate WebCore + animation lists into CCAnimation types - these have been moved into AnimationTranslationUtilTest.cpp, since the + logic under test is in AnimationTranslationUtil. Currently these only test that we accept / reject animations as + expected. They could be expanded to verify that the animation was translated faithfully, but that would require + expanding the information exposed on WebAnimation. + + * WebKit.gypi: + * src/WebLayer.cpp: + (WebKit::WebLayer::hasActiveAnimation): + (WebKit): + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + * tests/GraphicsLayerChromiumTest.cpp: + (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): + (GraphicsLayerChromiumTest): + (WebKit::TEST_F): + * tests/WebLayerTreeViewTest.cpp: + * tests/WebLayerTreeViewTestCommon.h: Added. + (WebKit): + (MockWebLayerTreeViewClient): + +2012-08-13 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r125422. + http://trac.webkit.org/changeset/125422 + https://bugs.webkit.org/show_bug.cgi?id=93902 + + Broke the Android canary build (Requested by fmalita on + #webkit). + + * WebKitUnitTests.gyp: + +2012-08-13 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Fix nits in the find-in-page match rects API + https://bugs.webkit.org/show_bug.cgi?id=93817 + + Reviewed by Adam Barth. + + This patch fixes a few pending nits from 93111. + + * src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument. + (WebKit::toNormalizedRect): + (WebKit::findInPageRectFromAbsoluteRect): + +2012-08-13 Peter Beverloo <peter@chromium.org> + + [Chromium] Fix apk generation for the Android platform + https://bugs.webkit.org/show_bug.cgi?id=93841 + + Reviewed by Dimitri Glazkov. + + APK generation was broken as the configuration file assumed compilation + would only occur in the Chromium tree. Pass the path to Chromium's source + base directory as a property to ant. + + * WebKitUnitTests.gyp: + +2012-08-13 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-13 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-13 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-10 Kinuko Yasuda <kinuko@chromium.org> + + Support creating File object from FileSystem URL for files in FileSystem API + https://bugs.webkit.org/show_bug.cgi?id=93706 + + Reviewed by Darin Fisher. + + * src/WebBlobData.cpp: + (WebKit::WebBlobData::itemAt): + +2012-08-12 Yuta Kitamura <yutak@google.com> + + Unreviewed. Fix Chromium's Android build. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::find): Needs parentheses for a function call. + +2012-08-12 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Implement the find-in-page match rects API + https://bugs.webkit.org/show_bug.cgi?id=93111 + + Reviewed by Adam Barth. + + Implement the funcionality of the find-in-page match rects API in WebFrame. + These methods keep a cache of the match rects in a special coordinate system + (find-in-page coordinates) and update them on size changes. They also allow + to recover the match closest to a given point, therefore enabling to move + to find matches when tapping on their corresponding tickmarks. + + * WebKit.gyp: add FindInPageCoordinates.h / cpp. * src/ChromeClientImpl.cpp: - * src/ContextMenuClientImpl.cpp: - * src/DeliveredIntentClientImpl.h: - * src/DragClientImpl.cpp: - * src/DragScrollTimer.h: + (WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl. + * src/FindInPageCoordinates.cpp: Added. + (WebKit): + (WebKit::toNormalizedRect): auxiliary internal function. + (WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function. + (WebKit::findInPageRectFromRange): convenience conversion function for Ranges. + * src/FindInPageCoordinates.h: Added. + (WebCore): + (WebKit): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor. + (WebKit): + (WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port. + (WebKit::WebFrameImpl::stopFinding): clear matches cache. + (WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache. + (WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version. + (WebKit::WebFrameImpl::resetMatchCount): update the matches cache version. + (WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version. + (WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache. + (WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree. + (WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required. + (WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates. + (WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates. + (WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames. + (WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates. + (WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame. + (WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache. + (WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables. + (WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes. + * src/WebFrameImpl.h: + (WebCore): + (WebFrameImpl): + (WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const. + (WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing. + (FindMatch): cache structure for find matches. + * tests/WebFrameTest.cpp: new test case for find-in-page match rects. + * tests/data/find_in_page.html: Added. Test case layout. + * tests/data/find_in_page_frame.html: Added. Test case layout. + +2012-08-09 James Robinson <jamesr@chromium.org> + + [chromium] Remove forwarding headers for compositor-related WebKit API and update includes + https://bugs.webkit.org/show_bug.cgi?id=93669 + + Reviewed by Adam Barth. + + This updates all includes for compositor-related headers to refer consistently to the Platform API location and + removes the now-unneeded forwarding headers in the client API location. I also updated and resorted other + platform API includes in modified header blocks. + + * WebKit.gyp: + * public/WebCompositor.h: Removed. + * public/platform/WebContentLayer.h: Removed. + * public/platform/WebContentLayerClient.h: Removed. + * public/platform/WebExternalTextureLayer.h: Removed. + * public/platform/WebLayer.h: Removed. + * public/platform/WebLayerTreeView.h: Removed. + * public/platform/WebLayerTreeViewClient.h: Removed. + * public/platform/WebSolidColorLayer.h: Removed. + * src/WebCompositorInputHandlerImpl.h: + * src/WebContentLayerImpl.cpp: + * src/WebLayer.cpp: + * src/WebLayerTreeView.cpp: + * src/WebLayerTreeViewImpl.cpp: + * src/WebLayerTreeViewImpl.h: + * src/WebSolidColorLayer.cpp: + * src/WebViewImpl.h: + * tests/Canvas2DLayerBridgeTest.cpp: + * tests/GraphicsLayerChromiumTest.cpp: + * tests/TextureLayerChromiumTest.cpp: + +2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-10 Iain Merrick <husky@google.com> + + [chromium] Upstream Android changes to WebFrameImpl::selectRange + https://bugs.webkit.org/show_bug.cgi?id=92513 + + Reviewed by Ryosuke Niwa. + + This change is driven by the Chromium port on the Android platform, + but it should be suitable for other touch-based platforms. We reuse + selectionExtentRespectingEditingBoundary (extracted from EventHandler + into VisibleSelection). + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::selectRange): + (WebKit::WebFrameImpl::visiblePositionForWindowPoint): + +2012-08-10 Dana Jansens <danakj@chromium.org> + + [chromium] Remove targetSurface pointer from CCRenderPass + https://bugs.webkit.org/show_bug.cgi?id=93734 + + Reviewed by Adrienne Walker. + + Use the RenderPass's damageRect instead of the surface's damageRect + directly to test the same things without requiring a pointer to + the surface that generated the RenderPass. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r125310. + http://trac.webkit.org/changeset/125310 + https://bugs.webkit.org/show_bug.cgi?id=93739 + + The DEPS roll broke Android. One does not simply break + Android. (Requested by fmalita_ on #webkit). + + * DEPS: + +2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-10 Dana Jansens <danakj@chromium.org> + + [chromium] Remove scissor from the namings in CCOcclusionTracker + https://bugs.webkit.org/show_bug.cgi?id=93630 + + Reviewed by Adrienne Walker. + + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::TestCCOcclusionTrackerWithClip::TestCCOcclusionTrackerWithClip): + (WebKitTests::TestCCOcclusionTrackerWithClip::setLayerClipRect): + (WebKitTests::TestCCOcclusionTrackerWithClip::useDefaultLayerClipRect): + (WebKitTests::TestCCOcclusionTrackerWithClip::layerClipRectInTarget): + (TestCCOcclusionTrackerWithClip): + (WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest): + (WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): + (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerClipRectOutsideChild::runMyTest): + (WebKitTests): + (WebKitTests::CCOcclusionTrackerTestViewportRectOutsideChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerClipRectOverChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestViewportRectOverChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerClipRectPartlyOverChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestViewportRectPartlyOverChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerClipRectOverNothing::runMyTest): + (WebKitTests::CCOcclusionTrackerTestViewportRectOverNothing::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerClipRectForLayerOffOrigin::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest): + (WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest): + (WebKitTests::CCOcclusionTrackerTestUnsorted3dLayers::runMyTest): + (WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest): + (WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToViewport::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest): + * tests/TiledLayerChromiumTest.cpp: + +2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r125230 and r125238. + http://trac.webkit.org/changeset/125230 + http://trac.webkit.org/changeset/125238 + https://bugs.webkit.org/show_bug.cgi?id=93698 + + Broke ChromiumOS browser tests. (Requested by yutak on + #webkit). + + * tests/TiledLayerChromiumTest.cpp: + +2012-08-09 Eric Penner <epenner@google.com> + + [chromium] Paint animated layers immediately to avoid animation hiccups. + https://bugs.webkit.org/show_bug.cgi?id=93028 + + Reviewed by Adrienne Walker. + + Replaced one test. Test painting full animated layer. + + * tests/TiledLayerChromiumTest.cpp: + +2012-08-09 Nat Duca <nduca@chromium.org> + + [chromium] Remove missing files from WebKit.gyp introduced by r125219 + https://bugs.webkit.org/show_bug.cgi?id=93671 + + Unreviewed. Fixing windows build. + + * WebKit.gyp: + +2012-08-09 Alec Flett <alecflett@chromium.org> + + IndexedDB: add AssertMatchingEnums for Direction and TaskType + https://bugs.webkit.org/show_bug.cgi?id=93618 + + Reviewed by Tony Chang. + + These chromium enums were introduced in a separate patch. + + * src/AssertMatchingEnums.cpp: + +2012-08-06 Nat Duca <nduca@chromium.org> + + [chromium] Expose CCGraphicsContext as WebCompositorOutputSurface + https://bugs.webkit.org/show_bug.cgi?id=92890 + + Reviewed by James Robinson. + + * WebKit.gyp: + * WebKit.gypi: + * public/WebSettings.h: + * public/WebViewClient.h: + (WebKit): + (WebViewClient): + (WebKit::WebViewClient::createOutputSurface): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): + * src/WebLayerTreeViewImpl.cpp: + (WebKit): + (WebGraphicsContextToOutputSurfaceAdapter): + (WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter): + (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::WebSettingsImpl): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit::WebViewImpl::createOutputSurface): + (WebKit): + (WebKit::WebViewImpl::didRebindGraphicsContext): + (WebKit::WebViewImpl::didRecreateOutputSurface): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF): + (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface): + (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface): + * tests/CCResourceProviderTest.cpp: + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCThreadedTest.cpp: + (WebKitTests::TestHooks::createOutputSurface): + * tests/CCThreadedTest.h: + (WebKitTests::TestHooks::didRecreateOutputSurface): + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + * tests/FakeCCGraphicsContext.h: + (WebKit::createFakeCCGraphicsContext): + * tests/FakeCCLayerTreeHostClient.h: + * tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h. + (WebKit): + (FakeWebCompositorOutputSurface): + (WebKit::FakeWebCompositorOutputSurface::create): + (WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface): + * tests/LayerRendererChromiumTest.cpp: + (LayerRendererChromiumTest::LayerRendererChromiumTest): + (TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-09 Nat Duca <nduca@chromium.org> + + Unreviewed, rolling out r125212. + http://trac.webkit.org/changeset/125212 + https://bugs.webkit.org/show_bug.cgi?id=92890 + + Compile failure on mac dbg builder + + * WebKit.gyp: + * WebKit.gypi: + * public/WebSettings.h: + * public/WebViewClient.h: + (WebKit): + (WebViewClient): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::WebSettingsImpl): + (WebKit::WebSettingsImpl::setForceSoftwareCompositing): + (WebKit): + * src/WebSettingsImpl.h: + (WebKit::WebSettingsImpl::forceSoftwareCompositing): + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit::WebViewImpl::createCompositorGraphicsContext3D): + (WebKit::WebViewImpl::createContext3D): + (WebKit::WebViewImpl::didRebindGraphicsContext): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF): + (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateContext): + (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateContext): + * tests/CCResourceProviderTest.cpp: + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCThreadedTest.cpp: + (WebKitTests::TestHooks::createContext): + * tests/CCThreadedTest.h: + (WebKitTests::TestHooks::didRecreateContext): + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + * tests/FakeCCGraphicsContext.h: + (WebKit::createFakeCCGraphicsContext): + * tests/FakeCCLayerTreeHostClient.h: + * tests/FakeWebCompositorOutputSurface.h: Removed. + * tests/LayerRendererChromiumTest.cpp: + (LayerRendererChromiumTest::LayerRendererChromiumTest): + (TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-09 Kentaro Hara <haraken@chromium.org> + + [V8] Rename V8BindingPerIsolateData to V8PerIsolateData + https://bugs.webkit.org/show_bug.cgi?id=93592 + + Reviewed by Adam Barth. + + For a better name. See discussion in bug 93333. + + No tests. No change in behavior. + + * src/WebKit.cpp: + (WebKit::initialize): + +2012-08-06 Nat Duca <nduca@chromium.org> + + [chromium] Expose CCGraphicsContext as WebCompositorOutputSurface + https://bugs.webkit.org/show_bug.cgi?id=92890 + + Reviewed by James Robinson. + + * WebKit.gyp: + * WebKit.gypi: + * public/WebSettings.h: + * public/WebViewClient.h: + (WebKit): + (WebViewClient): + (WebKit::WebViewClient::createOutputSurface): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): + * src/WebLayerTreeViewImpl.cpp: + (WebKit): + (WebGraphicsContextToOutputSurfaceAdapter): + (WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter): + (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::WebSettingsImpl): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit::WebViewImpl::createOutputSurface): + (WebKit): + (WebKit::WebViewImpl::didRebindGraphicsContext): + (WebKit::WebViewImpl::didRecreateOutputSurface): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF): + (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface): + (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface): + * tests/CCResourceProviderTest.cpp: + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCThreadedTest.cpp: + (WebKitTests::TestHooks::createOutputSurface): + * tests/CCThreadedTest.h: + (WebKitTests::TestHooks::didRecreateOutputSurface): + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + * tests/FakeCCGraphicsContext.h: + (WebKit::createFakeCCGraphicsContext): + * tests/FakeCCLayerTreeHostClient.h: + * tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h. + (WebKit): + (FakeWebCompositorOutputSurface): + (WebKit::FakeWebCompositorOutputSurface::create): + (WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface): + * tests/LayerRendererChromiumTest.cpp: + (LayerRendererChromiumTest::LayerRendererChromiumTest): + (TEST): + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-09 Alec Flett <alecflett@chromium.org> + + IndexedDB: additional chromium signature for openCursor + https://bugs.webkit.org/show_bug.cgi?id=93637 + + Reviewed by Adam Barth. + + Stub out the TaskType-based openCursor in the chromium API. + + * src/WebIDBObjectStoreImpl.cpp: + (WebKit::WebIDBObjectStoreImpl::openCursor): + * src/WebIDBObjectStoreImpl.h: + (WebKit::WebIDBObjectStoreImpl::openCursor): + (WebIDBObjectStoreImpl): + +2012-08-09 Dana Jansens <danakj@chromium.org> + + [chromium] Do partial-swap scissoring on quads during draw instead of on layers + https://bugs.webkit.org/show_bug.cgi?id=91800 + + Reviewed by Adrienne Walker. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::executeCalculateDrawTransformsAndVisibility): + * tests/CCLayerIteratorTest.cpp: + * tests/CCLayerTreeHostCommonTest.cpp: + Removed tests of the scissor rect here, as they are no longer + computed within CCLayerTreeHostCommon. Verify that the scissor + does not affect texture caching in CCLayerTreeHostImplTest now. + Previous scissor would affect the texture cache decisions, but + this was incorrect, as damaged areas are always inside the + scissor rect, and anything outside the scissor rect should + be considered as valid and complete (assuming no external + occlusion, which is computed outside the scissor rect now also). + + * tests/CCLayerTreeHostImplTest.cpp: + Removed didDrawNotCalledOnScissoredLayer test, as this no longer + applies. didDraw will be called on layers that are outside the + partial swap rect, regardless. + + Removed partialSwapNoUpdate test, and merged its functionality into + the partialSwap test while updating its expectations. + + Added textureCachingWithScissor, which is loosely based on the + CCLayerTreeHostCommonTest.scissorRectWithClip test. + + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): + (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): + * tests/CCQuadCullerTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::createLayer): + * tests/LayerRendererChromiumTest.cpp: + (LayerRendererChromiumTest::swapBuffers): + (TEST_F): + (TEST): + * tests/TiledLayerChromiumTest.cpp: + +2012-08-09 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Pass mask scale and offset to shaders for correct masking + https://bugs.webkit.org/show_bug.cgi?id=93558 + + Reviewed by Adrienne Walker. + + Updated one unit test that needed additional args in a + constructor, but no change in behavior of the test. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-09 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: add codemirror library as an experiment + https://bugs.webkit.org/show_bug.cgi?id=93620 + + Reviewed by Vsevolod Vlasov. + + * WebKit.gyp: + +2012-08-09 Peter Beverloo <peter@chromium.org> + + Unreviewed, rolling out r125171. + http://trac.webkit.org/changeset/125171 + + Broke the Chromium Android build. + + * DEPS: + +2012-08-09 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-09 Keishi Hattori <keishi@webkit.org> + + Page popups can show up at wrong locations + https://bugs.webkit.org/show_bug.cgi?id=93556 + + Reviewed by Kent Tamura. + + We were showing the popup at wrong positions. When there isn't enough + room below and above the element it adjusts the position but we weren't + resetting the adjustment when we resize the popup. This patch will make + the popup adjust the popup position each time we resize. + + * src/ColorChooserUIController.cpp: + (WebKit::ColorChooserUIController::contentSize): + * src/WebPagePopupImpl.cpp: + (WevKit::PagePopupChromeClient::setWindowRect): + (WebKit::WebPagePopupImpl::init): Use reposition(). + (WebKit::WebPagePopupImpl::reposition): Repositions the page popup based on the popup size. + (WebKit): + (WebKit::WebPagePopupImpl::resize): Use reposition(). + * src/WebPagePopupImpl.h: + (WebPagePopupImpl): + +2012-08-09 Peter Beverloo <peter@chromium.org> + + [Chromium] Pull in the android_tools directory for Android + https://bugs.webkit.org/show_bug.cgi?id=84843 + + Reviewed by Jochen Eisinger. + + Pull in the android_tools directory for Chromium Android checkouts. This + repository, living in Chromium's, contains checked in versions of the + Android NDK and SDK meant to make builds and updates easier. + + * DEPS: + +2012-08-08 Shane Stephens <shanestephens@google.com> + + Compile flag for CSS Hierarchies + https://bugs.webkit.org/show_bug.cgi?id=92433 + + Reviewed by Tony Chang. + + * features.gypi: + +2012-08-08 Kent Tamura <tkent@chromium.org> + + [Chromium-mac] Switch to LocalizedNumberMac from LocalizedNumberICU + https://bugs.webkit.org/show_bug.cgi?id=93432 + + Reviewed by Hajime Morita. + + * tests/LocaleMacTest.cpp: + Add some tests for number localization. They are similar to tests in + LocaleWinTest and LocalizedNumberICUTest.cpp + (LocaleMacTest): + (LocaleMacTest::decimalSeparator): + (TEST_F): + (testNumberIsReversible): + (testNumbers): + +2012-08-08 Adrienne Walker <enne@google.com> + + [chromium] Move scrollbar pointer into WebScrollbarThemePainter + https://bugs.webkit.org/show_bug.cgi?id=93541 + + Reviewed by James Robinson. + + Fix WebScrollbarThemePainter implementation to make direct calls on + the scrollbar rather than through the WebScrollbarThemeClientImpl + adapter. + + * src/WebScrollbarThemePainter.cpp: + (WebKit::WebScrollbarThemePainter::assign): + (WebKit::WebScrollbarThemePainter::paintScrollbarBackground): + (WebKit::WebScrollbarThemePainter::paintTrackBackground): + (WebKit::WebScrollbarThemePainter::paintBackTrackPart): + (WebKit::WebScrollbarThemePainter::paintForwardTrackPart): + (WebKit::WebScrollbarThemePainter::paintBackButtonStart): + (WebKit::WebScrollbarThemePainter::paintBackButtonEnd): + (WebKit::WebScrollbarThemePainter::paintForwardButtonStart): + (WebKit::WebScrollbarThemePainter::paintForwardButtonEnd): + (WebKit::WebScrollbarThemePainter::paintTickmarks): + (WebKit::WebScrollbarThemePainter::paintThumb): + (WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter): + * tests/ScrollbarLayerChromiumTest.cpp: + (WebCore::TEST): + +2012-08-08 Alexei Svitkine <asvitkine@chromium.org> + + [chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8 + https://bugs.webkit.org/show_bug.cgi?id=93535 + + Reviewed by Dimitri Glazkov. + + This enables putting two fingers on the track pad to show overlay scroll bars on 10.8+. + + * src/mac/WebInputEventFactory.mm: + (WebKit::phaseForNSEventPhase): + +2012-08-08 James Robinson <jamesr@chromium.org> + + [chromium] Fix up includes and types in chromium compositor unit tests + https://bugs.webkit.org/show_bug.cgi?id=93553 + + Reviewed by Adrienne Walker. + + This removes some unused GraphicsContext3DPrivate.h includes and adds some includes that were being implicitely + depending upon - mostly for wtf/PassOwnPtr.h. + + * tests/CCLayerTreeHostTest.cpp: + (::CCLayerTreeHostTestCommit::beginTest): + (::CCLayerTreeHostTestCommit::commitCompleteOnCCThread): + * tests/CCRenderSurfaceFiltersTest.cpp: + * tests/CompositorFakeWebGraphicsContext3D.h: + * tests/FakeGraphicsContext3DTest.cpp: + * tests/FakeWebScrollbarThemeGeometry.h: + * tests/TextureCopierTest.cpp: + * tests/ThrottledTextureUploaderTest.cpp: + +2012-08-08 Eric Penner <epenner@google.com> + + [chromium] Refactor tile flags. + https://bugs.webkit.org/show_bug.cgi?id=93059 + + Reviewed by Adrienne Walker. + + Minor fixes to existing tests. + + * tests/TiledLayerChromiumTest.cpp: + +2012-08-08 James Robinson <jamesr@chromium.org> + + [chromium] Clean up WebKit.h and WebKitPlatformSupport.h includes in chromium/src + https://bugs.webkit.org/show_bug.cgi?id=93539 + + Reviewed by Adam Barth. + + Most of these files don't need either WebKit.h or WebKitPlatformSupport.h. Some need <public/Platform.h>, and + some are relying on the forwarding headers. This updates includes to what is actually needed and points platform + includes at <public/Foo.h> instead of "platform/Foo.h" where possible. + + * src/ApplicationCacheHostInternal.h: + * src/AssociatedURLLoader.cpp: + * src/AsyncFileSystemChromium.cpp: + (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium): + * src/BlobRegistryProxy.cpp: + * src/ChromiumCurrentTime.cpp: + * src/ChromiumOSRandomSource.cpp: + * src/ChromiumThreading.cpp: + * src/EditorClientImpl.cpp: * src/FrameLoaderClientImpl.cpp: - * src/InspectorClientImpl.cpp: - * src/InspectorClientImpl.h: + * src/IDBFactoryBackendProxy.cpp: + * src/LocalizedStrings.cpp: + * src/PlatformMessagePortChannel.cpp: + * src/WebCompositorInputHandlerImpl.cpp: + * src/WebMediaPlayerClientImpl.cpp: + * src/WebPluginContainerImpl.cpp: + * src/WebViewImpl.cpp: + * src/WebWorkerClientImpl.cpp: + * src/WorkerAsyncFileSystemChromium.cpp: + * src/WorkerFileWriterCallbacksBridge.cpp: + +2012-08-08 James Robinson <jamesr@chromium.org> + + [chromium] Clean up includes in compositor unit tests + https://bugs.webkit.org/show_bug.cgi?id=93531 + + Reviewed by Adrienne Walker. + + This removes unused includes and updates Platform API headers to use the <public/Web...> style paths. + + * tests/CCAnimationTestCommon.cpp: + * tests/CCKeyframedAnimationCurveTest.cpp: + * tests/CCLayerAnimationControllerTest.cpp: + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): + * tests/CCOcclusionTrackerTest.cpp: + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCThreadedTest.cpp: + * tests/FakeWebGraphicsContext3D.h: + * tests/LayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + * tests/WebCompositorInputHandlerImplTest.cpp: + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: + +2012-08-07 James Robinson <jamesr@chromium.org> + + [chromium] Only use public Platform API in NonCompositedContentHost + https://bugs.webkit.org/show_bug.cgi?id=93423 + + Reviewed by Adrienne Walker. + + Switches to using Web*Layer APIs in NonCompositedContentHost instead of reaching in to the LayerChromium and + updates unit tests for the nonCompositedContent->useLCDText flag rename. + + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + * src/WebContentLayer.cpp: + (WebKit::WebContentLayer::setUseLCDText): + (WebKit): + (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles): + * src/WebViewImpl.cpp: + * tests/CCLayerImplTest.cpp: + (WebCore::TEST): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/LayerChromiumTest.cpp: + +2012-08-08 Alec Flett <alecflett@chromium.org> + + IndexedDB: new enums and openCursor stub + https://bugs.webkit.org/show_bug.cgi?id=93410 + + Reviewed by Adam Barth. + + This stubs out the TaskType and Direction enums that will be + required to land the chromium side of + https://bugs.webkit.org/show_bug.cgi?id=91125. + + * public/WebIDBCursor.h: + * public/WebIDBObjectStore.h: + (WebKit::WebIDBObjectStore::setIndexKeys): + (WebKit::WebIDBObjectStore::setIndexesReady): + (WebIDBObjectStore): + (WebKit::WebIDBObjectStore::openCursor): + * public/WebIDBTransaction.h: + +2012-08-08 Dana Jansens <danakj@chromium.org> + + [chromium] Enable occlusion tracker in the occlusion tests for surface cacheing + https://bugs.webkit.org/show_bug.cgi?id=93500 + + Reviewed by Adrienne Walker. + + The occlusion tracker is not being used in these tests except to do + scissoring. We want to test occlusion with these occlusion tests, + and when scissoring is not part of occlusion tracker, these + tests would become useless otherwise. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-08 Adam Barth <abarth@webkit.org> + + Crash when reloading a Chromium "platform" app + https://bugs.webkit.org/show_bug.cgi?id=93497 + + Reviewed by Eric Seidel. + + Test that we don't crash when executing script during the + didCreateScriptContext callback. + + * tests/WebFrameTest.cpp: + * tests/data/hello_world.html: Added. + +2012-08-07 Joshua Bell <jsbell@chromium.org> + + Layout Test storage/indexeddb/intversion-omit-parameter.html is flaky + https://bugs.webkit.org/show_bug.cgi?id=92952 + + Reviewed by Tony Chang. + + Added test to exercise WebCore::IDBRequest event callbacks after + the script context has stopped and ensure no asserts are hit. + + * WebKit.gypi: + * tests/IDBRequestTest.cpp: Added. + (WebCore): + (WebCore::TEST): + +2012-08-07 Fady Samuel <fsamuel@chromium.org> + + Allow plugins to decide whether they are keyboard focusable + https://bugs.webkit.org/show_bug.cgi?id=88958 + + Reviewed by Anders Carlsson. + + * public/WebPlugin.h: + (WebKit::WebPlugin::supportsKeyboardFocus): + * src/WebInputEventConversion.cpp: + (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::supportsKeyboardFocus): + (WebKit): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + +2012-08-07 Kentaro Hara <haraken@chromium.org> + + [V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods + https://bugs.webkit.org/show_bug.cgi?id=93209 + + Reviewed by Adam Barth. + + By implementing V8Proxy::registerExtensionIfNeeded(), we can remove + registeredExtensionWithV8() and registerExtension(). + + No tests. No change in behavior. + + * src/WebScriptController.cpp: + (WebKit::WebScriptController::registerExtension): + +2012-08-07 James Robinson <jamesr@chromium.org> + + [chromium] Add new gclient-managed cc directory to Source/WebKit/chromium/.gitignore + https://bugs.webkit.org/show_bug.cgi?id=93403 + + Reviewed by Eric Seidel. + + * .gitignore: + +2012-08-07 Mihai Parparita <mihaip@chromium.org> + + [Chromium] Clean up WebScriptController.h comments + https://bugs.webkit.org/show_bug.cgi?id=93399 + + Reviewed by Adam Barth. + + Remove references to overloaded WebScriptController::registerExtension + variants. They were removed in r68666. + + * public/WebScriptController.h: + (WebScriptController): + +2012-08-07 Kentaro Hara <haraken@chromium.org> + + [V8] Remove #include Frame.h from V8Binding.h + https://bugs.webkit.org/show_bug.cgi?id=93326 + + Reviewed by Adam Barth. + + We want to remove unnecessary #include in V8Binding.h + to avoid circular include dependency. + + No tests. No change in behavior. + + * src/WebBindings.cpp: + +2012-08-07 James Robinson <jamesr@chromium.org> + + [chromium] Switch PlatformLayer typedef to Platform API type for PLATFORM(CHROMIUM) + https://bugs.webkit.org/show_bug.cgi?id=93335 + + Reviewed by Adrienne Walker. + + Update for new PlatformLayer typedef. This removes knowledge of WebCore::LayerChromium from all classes + except for NonCompositedContentHost, which still punches through for a few minor APIs that I'll address + in a separate patch. + + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setScrollLayer): + (WebKit::NonCompositedContentHost::scrollLayer): + (WebKit::NonCompositedContentHost::notifySyncRequired): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::platformLayer): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::platformLayer): + * src/WebPluginContainerImpl.h: + (WebCore): + (WebPluginContainerImpl): + * src/WebScrollableLayer.cpp: + (WebKit::WebScrollableLayer::setNonFastScrollableRegion): + (WebKit): + (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): + (WebKit::WebScrollableLayer::setFixedToContainerLayer): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setRootGraphicsLayer): + * tests/Canvas2DLayerBridgeTest.cpp: + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + (WebKitTests::TEST_F): + +2012-08-07 James Robinson <jamesr@chromium.org> + + [chromium] Use WebCompositor interface in Platform API instead of CCProxy to query threaded compositor status + https://bugs.webkit.org/show_bug.cgi?id=93398 + + Reviewed by Adam Barth. + + Converts non-compositor code that cares about threaded compositing status over to query WebCompositor instead of + CCProxy. + + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::supportsType): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::composite): + (WebKit::WebViewImpl::scheduleAnimation): + (WebKit::WebViewImpl::scheduleComposite): + +2012-08-07 James Robinson <jamesr@chromium.org> + + [chromium] Move WebCompositor interface into Platform AP + https://bugs.webkit.org/show_bug.cgi?id=93391 + + Reviewed by Adam Barth. + + * WebKit.gyp: + * public/WebCompositor.h: + * src/WebLayerTreeViewImpl.cpp: + +2012-08-07 Joshua Bell <jsbell@chromium.org> + + REGRESSION(r124865): It broke the ARM Chromium build + https://bugs.webkit.org/show_bug.cgi?id=93364 + + Reviewed by Csaba Osztrogonác. + + Mark large constant with LL to satisfy a picky compiler. + + * tests/IDBLevelDBCodingTest.cpp: + (IDBLevelDBCoding::TEST): + +2012-08-07 Alexei Filippov <alexeif@chromium.org> + + Web Inspector: make the MemoryClassInfo class a not-template + https://bugs.webkit.org/show_bug.cgi?id=93265 + + Reviewed by Yury Semikhatsky. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::Instrumented::reportMemoryUsage): + (WebCore::InstrumentedRefPtr::reportMemoryUsage): + (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): + (WebCore::InstrumentedOther::reportMemoryUsage): + (WebCore::InstrumentedDOM::reportMemoryUsage): + (WebCore::NonVirtualInstrumented::reportMemoryUsage): + +2012-08-06 Yuta Kitamura <yutak@chromium.org> + + WebSocket.send() should accept ArrayBufferView + https://bugs.webkit.org/show_bug.cgi?id=90877 + + Reviewed by Kent Tamura. + + * src/WebSocketImpl.cpp: + (WebKit::WebSocketImpl::sendArrayBuffer): + Apply change in function signature of WebSocketChannel::send(). + +2012-08-06 James Robinson <jamesr@chromium.org> + + [chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp + https://bugs.webkit.org/show_bug.cgi?id=93319 + + Reviewed by Adrienne Walker. + + * src/WebLayer.cpp: + (WebKit::WebLayer::setChildren): + (WebKit): + (WebKit::WebLayer::setReplicaLayer): + (WebKit::WebLayer::setDebugName): + (WebKit::WebLayer::clearRenderSurface): + +2012-08-06 Adrienne Walker <enne@google.com> + + [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface + https://bugs.webkit.org/show_bug.cgi?id=93308 + + Reviewed by James Robinson. + + Now that WebScrollbarThemeGeometry can have different implementations, + create a FakeWebScrollbarThemeGeometry for testing purposes rather + than just overriding a geometry-related virtual. + + * WebKit.gyp: + * WebKit.gypi: + * src/WebScrollbarLayer.cpp: + (WebKit::WebScrollbarLayer::create): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/FakeWebScrollbarThemeGeometry.h: Added. + (WebKit): + (FakeWebScrollbarThemeGeometry): + (WebKit::FakeWebScrollbarThemeGeometry::create): + * tests/ScrollbarLayerChromiumTest.cpp: + (WebCore::TEST): + +2012-08-06 James Robinson <jamesr@chromium.org> + + [chromium] Update chromium DEPS r150037 -> r150169 + https://bugs.webkit.org/show_bug.cgi?id=93309 + + As the title says. Unreviewed. + + * DEPS: + +2012-08-06 David Reveman <reveman@chromium.org> + + [Chromium] Rename CCTextureUpdater to CCTextureUpdateQueue. + https://bugs.webkit.org/show_bug.cgi?id=93293 + + Reviewed by Adrienne Walker. + + * src/WebExternalTextureLayer.cpp: + (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): + (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): + (WTF::CCLayerTreeHostTestManySurfaces::beginTest): + * tests/CCTextureUpdateControllerTest.cpp: + * tests/CCThreadedTest.cpp: + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeTiledLayerChromium::update): + * tests/CCTiledLayerTestCommon.h: + (FakeTiledLayerChromium): + * tests/Canvas2DLayerBridgeTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-08-06 Bear Travis <betravis@adobe.com> + + [CSS Exclusions] Add a command-line flag to enable / disable exclusions + https://bugs.webkit.org/show_bug.cgi?id=91420 + + Reviewed by Dimitri Glazkov. + + Adding the interface code to expose the css exclusions runtime flag to + Chromium. + + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): Adding getters/setters for cssExclusions + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enableCSSExclusions): + (WebKit): + (WebKit::WebRuntimeFeatures::isCSSExclusionsEnabled): + +2012-08-06 Adam Barth <abarth@webkit.org> + + [Chromium] WebTouchCandidatesInfo should be part of the Client API + https://bugs.webkit.org/show_bug.cgi?id=93088 + + Reviewed by Eric Seidel. + + * WebKit.gyp: + * public/WebTouchCandidatesInfo.h: Copied from Source/Platform/chromium/public/WebTouchCandidatesInfo.h. + * src/WebViewImpl.cpp: + +2012-08-06 Adrienne Walker <enne@google.com> + + [chromium] REGRESSION(r124714): webkit_unit_tests asserts in Debug + https://bugs.webkit.org/show_bug.cgi?id=93297 + + Reviewed by James Robinson. + + This is a quick fix to get debug unit tests working again by + implementing a virtual function that has ASSERT_NOT_REACHED in the + base class version. + + * tests/ScrollAnimatorNoneTest.cpp: + (MockScrollableArea::scrollPosition): + +2012-08-06 Nasko Oskov <nasko@chromium.org> + + Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy. + https://bugs.webkit.org/show_bug.cgi?id=93127 + + Reviewed by Adam Barth. + + Add support in the API to monitor and create frame hierarchy to allow replicating it + across different instances of WebKit. + + * public/WebDocument.h: + (WebDocument): Added createElement. + * public/WebFrame.h: Added assignedName. + * public/WebFrameClient.h: + (WebFrameClient): + (WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created. + (WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter. + * public/WebNode.h: + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent): + * src/WebDocument.cpp: + (WebKit::WebDocument::createElement): Added to allow for creating frame elements. + (WebKit): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API. + (WebKit): + (WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed + to the unique name, generated by WebKit. + (WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame. + * src/WebFrameImpl.h: + (WebFrameImpl): + * src/WebNode.cpp: + (WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM. + (WebKit): + * tests/WebFrameTest.cpp: + +2012-08-06 David Reveman <reveman@chromium.org> + + [Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController. + https://bugs.webkit.org/show_bug.cgi?id=92596 + + Reviewed by Adrienne Walker. + + * WebKit.gypi: + * src/WebExternalTextureLayer.cpp: + * tests/CCTextureUpdateControllerTest.cpp: Renamed from Source/WebKit/chromium/tests/CCTextureUpdaterTest.cpp. + * tests/CCTiledLayerTestCommon.h: + (WebKitTests::FakeTextureCopier::copyTexture): + (WebKitTests::FakeTextureUploader::uploadTexture): + * tests/TextureCopierTest.cpp: + (TEST): + * tests/TiledLayerChromiumTest.cpp: + +2012-08-06 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Non-preserves-3d requires explicit flattening of screen-space transform. + https://bugs.webkit.org/show_bug.cgi?id=85808 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-08-06 Yury Semikhatsky <yurys@chromium.org> + + Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error + https://bugs.webkit.org/show_bug.cgi?id=92545 + + Reviewed by Pavel Feldman. + + Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers() + that tells if inspector front-end on the given platform can launch dedicated worker + front-end. + * src/InspectorFrontendClientImpl.cpp: - * src/NotificationPresenterImpl.cpp: - * src/PageWidgetDelegate.h: - * src/SocketStreamHandle.cpp: - * src/SocketStreamHandleInternal.h: - * src/SpeechInputClientImpl.cpp: - * src/StorageAreaProxy.cpp: - * src/StorageNamespaceProxy.cpp: - * src/UserMediaClientImpl.cpp: - * src/WebAccessibilityObject.cpp: - * src/WebAnimationControllerImpl.cpp: - * src/WebCommon.cpp: - * src/WebDOMEventListenerPrivate.h: - * src/WebDOMMessageEvent.cpp: - * src/WebDOMStringList.cpp: - * src/WebDataSourceImpl.cpp: - * src/WebDatabase.cpp: + (WebKit::InspectorFrontendClientImpl::canInspectWorkers): + (WebKit): + * src/InspectorFrontendClientImpl.h: + (InspectorFrontendClientImpl): + * src/js/DevTools.js: + +2012-08-06 Keishi Hattori <keishi@webkit.org> + + Remove minimum window size for PagePopup + https://bugs.webkit.org/show_bug.cgi?id=93100 + + Reviewed by Kent Tamura. + + * src/WebPagePopupImpl.cpp: Returns 0x0 so the page popup can be smaller than 100x100. + +2012-08-05 Kent Tamura <tkent@chromium.org> + + [Chromium-win] Use system locale for number representation + https://bugs.webkit.org/show_bug.cgi?id=93085 + + Reviewed by Hajime Morita. + + * WebKit.gypi: + Don't include Localized*ICUTest.cpp in Windows and OSX. They are unnecessary. + * tests/LocaleWinTest.cpp: + (LocaleWinTest): Add some LCID symbols. + (LocaleWinTest::decimalSeparator): + A helper for LocaleWinTest.decimalSeparator. + (TEST_F(LocaleWinTest, decimalSeparator)): + A test for LocaleWin::localizedDecimalSeparator(). This is a copy of the + corresponding test in LocalizedNumberICUTest.cpp. + (testNumberIsReversible): + A test helper LocaleWinTest.localizedNumberRoundTrip. This is a copy of + the corresponding test in LocalizedNumberICUTest.cpp. + (testNumbers): ditto. + (TEST_F(LocaleWinTest, localizedNumberRoundTrip)): + Tests for LocaleWin changes. This is a copy of the corresponding tests + in LocalizedNumberICUTest.cpp. + +2012-08-04 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-03 Nico Weber <thakis@chromium.org> + + [chromium] Add API to make it possible to request all variants of a WebImage + https://bugs.webkit.org/show_bug.cgi?id=92933 + + Reviewed by Adam Barth. + + Part of http://crbug.com/138550 + + * src/WebImageSkia.cpp: + (WebKit::WebImage::framesFromData): + (WebKit): + +2012-08-03 Yaron Friedman <yfriedman@chromium.org> + + [Chrome-Android] - Prepare apk tests for switch to checked in SDK. + https://bugs.webkit.org/show_bug.cgi?id=92931 + + Reviewed by Adam Barth. + + Pass Android-specific gyp variables to the native test generator + avoiding any dependencies on environment variables during build time. + + * WebKitUnitTests.gyp: + +2012-08-03 David Grogan <dgrogan@chromium.org> + + IndexedDB: Core upgradeneeded logic + https://bugs.webkit.org/show_bug.cgi?id=92558 + + Reviewed by Ojan Vafai. + + Update overridden methods to match new signatures. + + * tests/IDBAbortOnCorruptTest.cpp: + (WebCore::FailingBackingStore::createIDBDatabaseMetaData): + * tests/IDBFakeBackingStore.h: + +2012-08-03 Rick Byers <rbyers@chromium.org> + + Double tap gesture should send dblclick event + https://bugs.webkit.org/show_bug.cgi?id=92412 + + Reviewed by Adam Barth. + + Tweak comment to more completely describe the (lame) overloaded use + of deltaX in WebGestureEvent, and add a FIXME with the bug to track + cleaning it up. + * public/WebInputEvent.h: + (WebGestureEvent): + +2012-08-03 Dave Tu <dtu@chromium.org> + + [chromium] Remove assert when getting hardware renderingStats in software mode. + https://bugs.webkit.org/show_bug.cgi?id=92325 + + Reviewed by Adrienne Walker. + + If a page caused hardware mode to be turned on, then off, the hardware stats are still valid, so we don't need to assert that we're in hardware mode. Checking if the LayerTreeView is null should be sufficient. + + * public/WebWidget.h: + (WebWidget): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::renderingStats): + (WebKit::WebViewImpl::paint): + * src/WebViewImpl.h: + +2012-08-03 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-03 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r124632. + http://trac.webkit.org/changeset/124632 + https://bugs.webkit.org/show_bug.cgi?id=93154 + + Added new WebFrameTest.SelectRange which fails on bots + (Requested by dimich on #webkit). + + * tests/WebFrameTest.cpp: + * tests/data/select_range_basic.html: Removed. + * tests/data/select_range_iframe.html: Removed. + * tests/data/select_range_scroll.html: Removed. + +2012-08-03 Terry Anderson <tdanderson@chromium.org> + + Apply target fuzzing when sending a context menu event + https://bugs.webkit.org/show_bug.cgi?id=92914 + + Reviewed by Antonio Gomes. + + When constructing a PlatformEvent::GestureLongPress in WebInputEventConversion.cpp, + use |boundingBox| to specify |m_area|. + + * src/WebInputEventConversion.cpp: + (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): + +2012-08-03 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Add stubs for the find-in-page match rects API + https://bugs.webkit.org/show_bug.cgi?id=93110 + + Reviewed by Adam Barth. + + The Android port allows tapping on the find-in-page result tickmarks taking + the user to the corresponding matches. This patch introduces stubs for the + new required methods in order to achieve WebKit API compatibility for this + port as soon as possible. The implementation of these methods will be added + later in https://bugs.webkit.org/show_bug.cgi?id=93111. + + * public/WebFrame.h: + (WebKit): + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::findMatchMarkersVersion): + (WebKit): + (WebKit::WebFrameImpl::activeFindMatchRect): + (WebKit::WebFrameImpl::findMatchRects): + (WebKit::WebFrameImpl::selectNearestFindMatch): + * src/WebFrameImpl.h: + (WebFrameImpl): + +2012-08-03 Mike West <mkwst@chromium.org> + + Blocking a plugin via CSP should result in one (and only one) console message. + https://bugs.webkit.org/show_bug.cgi?id=92649 + + Reviewed by Adam Barth. + + * src/LocalizedStrings.cpp: + (WebCore::blockedPluginByContentSecurityPolicyText): + (WebCore): + Adding a stub for the newly added string. + +2012-08-03 Oli Lan <olilan@chromium.org> + + [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint. + https://bugs.webkit.org/show_bug.cgi?id=93108 + + Reviewed by Adam Barth. + + Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange, and also + serves to test WebFrameImpl::visiblePositionForWindowPoint as it is used by selectRange. + + The test uses sample files that contain selected text on load. The test uses + WebViewImpl::selectionBounds to retrieve the ends of the selection, then unselects + and calls WebFrameImpl::selectRange to attempt to reselect the same text. + + Three cases are tested: the normal case, the case where the selected text is offscreen + due to a scroll, and the case where the selected text is in an iframe. This allows the + problem cases and fix in https://bugs.webkit.org/show_bug.cgi?id=79117 to be tested. + + * tests/WebFrameTest.cpp: + * tests/data/select_range_basic.html: Added. + * tests/data/select_range_iframe.html: Added. + * tests/data/select_range_scroll.html: Added. + +2012-08-03 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: eliminate visitBaseClass method from NMI. It introduces unnecessary complexity. + https://bugs.webkit.org/show_bug.cgi?id=93129 + + Reviewed by Yury Semikhatsky. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): + +2012-08-03 Adam Barth <abarth@webkit.org> + + V8Proxy::retrieve(*) leads to really obfuscated code and should be removed + https://bugs.webkit.org/show_bug.cgi?id=93072 + + Reviewed by Eric Seidel. + * src/WebDevToolsAgentImpl.cpp: - * src/WebDevToolsAgentImpl.h: + (WebKit::WebDevToolsAgentImpl::didCreateScriptContext): + +2012-08-02 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: extend test coverage for nmi code and fix 2 bugs. + https://bugs.webkit.org/show_bug.cgi?id=92994 + + Reviewed by Yury Semikhatsky. + + 1) owner object type propagation. + If a class with object-type DOM has an instrumented member with object-type Other then it has to be recorded as DOM. + Sample: We have SharedBuffer class and we don't know the object-type for it but we know that it is owned by an object with object-type CachedResourceImage. + + 2) the first member of an instrumented non virtual class was skipped even if it was reported properly. + it happened because the first member has the same address as it's owner + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::TEST): + (WebCore): + (InstrumentedOther): + (WebCore::InstrumentedOther::InstrumentedOther): + (WebCore::InstrumentedOther::reportMemoryUsage): + (InstrumentedDOM): + (WebCore::InstrumentedDOM::InstrumentedDOM): + (WebCore::InstrumentedDOM::reportMemoryUsage): + (NonVirtualInstrumented): + (WebCore::NonVirtualInstrumented::reportMemoryUsage): + +2012-08-02 Alec Flett <alecflett@chromium.org> + + IndexedDB: remove leftover chromium stubs from putIndexWithKeys + https://bugs.webkit.org/show_bug.cgi?id=93032 + + Reviewed by Darin Fisher. + + Remove old chromium APIs that are no longer called by chrome. + + * public/WebIDBCursor.h: + * public/WebIDBObjectStore.h: + * public/WebIDBTransaction.h: + +2012-08-02 Antoine Labour <piman@chromium.org> + + [chromium] add lost context test case for HW video decoder + https://bugs.webkit.org/show_bug.cgi?id=93057 + + Reviewed by Adrienne Walker. + + We check that we don't use resources after a lost context (assuming + proper WebVideoFrameProvider behavior). + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-02 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r124540. + http://trac.webkit.org/changeset/124540 + https://bugs.webkit.org/show_bug.cgi?id=93055 + + Broke compile on Chromium Win bot (Requested by dimich on + #webkit). + + * tests/IDBAbortOnCorruptTest.cpp: + (WebCore::FailingBackingStore::createIDBDatabaseMetaData): + * tests/IDBFakeBackingStore.h: + +2012-08-02 Alexandre Elias <aelias@google.com> + + [chromium] deviceViewportSize cleanup + https://bugs.webkit.org/show_bug.cgi?id=92794 + + Reviewed by Adrienne Walker. + + In the future, CSS layout size will become increasingly disassociated + from physical device size, and it will become impossible to infer one + from the other inside the compositor. Therefore, this patch allows + deviceViewportSize to be explicitly passed in by the outside client. + + I also renamed the existing viewportSize field to "layoutViewportSize" + for clarity, and converted its uses to deviceViewportSize since + that is more appropriate. + + I had to add some default-value scaffolding to WebLayerTreeView in + order to avoid breaking ui/compositor. We can delete it once that's + updated. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setViewportSize): + (WebKit::WebLayerTreeView::layoutViewportSize): + (WebKit): + (WebKit::WebLayerTreeView::deviceViewportSize): + (WebKit::WebLayerTreeView::setDeviceScaleFactor): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::paint): + (WebKit::WebViewImpl::updateLayerTreeViewport): + +2012-08-02 Adam Barth <abarth@webkit.org> + + V8Proxy::currentContext() doesn't do anything and should be removed + https://bugs.webkit.org/show_bug.cgi?id=93041 + + Reviewed by Eric Seidel. + + * src/WebBindings.cpp: + (WebKit::makeIntArrayImpl): + (WebKit::makeStringArrayImpl): + +2012-08-02 David Grogan <dgrogan@chromium.org> + + IndexedDB: Core upgradeneeded logic + https://bugs.webkit.org/show_bug.cgi?id=92558 + + Reviewed by Ojan Vafai. + + Update overridden methods to match new signatures. + + * tests/IDBAbortOnCorruptTest.cpp: + (WebCore::FailingBackingStore::createIDBDatabaseMetaData): + * tests/IDBFakeBackingStore.h: + +2012-08-02 Vincent Scheib <scheib@chromium.org> + + Remove old Pointer Lock API. + https://bugs.webkit.org/show_bug.cgi?id=88892 + + Reviewed by Adam Barth. + + * src/WebViewImpl.cpp: + Removed #include to old API header. + +2012-08-02 Tien-Ren Chen <trchen@chromium.org> + + [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation + https://bugs.webkit.org/show_bug.cgi?id=91688 + + Reviewed by Adrienne Walker. + + New unit test ScrollbarLayerChromiumTest.scrollOffsetSynchronization to verify + scroll offset is updated during tree synchronization and threaded scrolling. + Another new unit test CCScrollbarAnimationControllerLinearFadeTest to verify + opacity animates as intended. + + * tests/ScrollbarLayerChromiumTest.cpp: + +2012-08-02 Adrienne Walker <enne@google.com> + + [chromium] Make CCScrollbarLayerImpl handle lost contexts properly + https://bugs.webkit.org/show_bug.cgi?id=93021 + + Reviewed by James Robinson. + + Add CCScrollbarLayerImpl to the dontUseOldResourceAfterLostContext + test. Additionally, modify this test so that stale resource ids + properly point at invalid texture ids so that the test actually tests + what it is supposed to be testing. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-02 Adam Barth <abarth@webkit.org> + + The generic bindings shouldn't use templates + https://bugs.webkit.org/show_bug.cgi?id=93016 + + Reviewed by Eric Seidel. + + Update #include. + + * src/WebBindings.cpp: + +2012-08-02 Peter Beverloo <peter@chromium.org> + + [Chromium] Add a stub for WebView::getTouchHighlightQuads() + https://bugs.webkit.org/show_bug.cgi?id=92997 + + Reviewed by Adam Barth. + + Chrome on Android will be using this method for the link preview + implementation, discussion about which is available in Bug 79150. Since + that system is fairly big, will require refactoring, and the unavailable + APIs are blocking API compatibility, add a stub for now. + + Together with the WebView API, also add the "WebTouchCandidatesInfo" + structure which is being used by it. + + * public/WebView.h: + (WebKit): + (WebView): + * src/WebViewImpl.cpp: + (WebKit): + (WebKit::WebViewImpl::getTouchHighlightQuads): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-02 Hans Wennborg <hans@chromium.org> + + Speech JavaScript API: Fire speech start event at the same time as sound start event + https://bugs.webkit.org/show_bug.cgi?id=92971 + + Reviewed by Adam Barth. + + Chromium's speech recognizer doesn't differentiate between "sound + started" and "speech started". Just fire those events at the same + time, and don't provide functions for them in + WebSpeechRecognizerClient. + + * public/WebSpeechRecognizerClient.h: + * src/SpeechRecognitionClientProxy.cpp: + (WebKit::SpeechRecognitionClientProxy::didStartSound): + (WebKit::SpeechRecognitionClientProxy::didEndSound): + * src/SpeechRecognitionClientProxy.h: + (SpeechRecognitionClientProxy): + +2012-08-02 Adam Barth <abarth@webkit.org> + + [Chromium] WebViewImpl::showTouchHighlightQuads isn't needed for Android + https://bugs.webkit.org/show_bug.cgi?id=92921 + + Reviewed by Nate Chapin. + + We originally added a stub implementation of this function to make + merging detectContentOnTouch easier, but showTouchHighlightQuads is + being removed from the chromium-android branch in favor of the code in + https://bugs.webkit.org/show_bug.cgi?id=84487. This patch removes the + stub. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::detectContentIntentOnTouch): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-08-02 Peter Beverloo <peter@chromium.org> + + [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI + https://bugs.webkit.org/show_bug.cgi?id=92858 + + Reviewed by Adam Barth. + + Now that the sdk_build variable is available, we can remove these two differences + as well. This goes together with Adam's bug 90920. + + After this patch, the whole Tools/ directory will be unforked :-). + + * WebKitUnitTests.gyp: + +2012-08-02 Alexei Filippov <alexeif@chromium.org> + + Web Inspector: count RenderStyle objects in the native memory profiler + https://bugs.webkit.org/show_bug.cgi?id=91759 + + Reviewed by Yury Semikhatsky. + + Add a test for DataRef<T> wrapped member instrumentation. + + * tests/MemoryInstrumentationTest.cpp: + (WebCore::InstrumentedRefPtr::create): + (WebCore::TEST): + (WebCore): + +2012-08-02 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-08-01 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: test native memory instrumentation code with help of unittests + https://bugs.webkit.org/show_bug.cgi?id=92743 + + Reviewed by Yury Semikhatsky. + + Test a part of existing Native Memory Instrumentation code with help of unit tests. + 6 tests were added and two bugs were fixed. + a drive-by improvement: the method MemoryInstrumentation::addInstrumentedObject + was marked as private and addRootObject was introduced instead of it. + The new function also calls processDeferedPointers. + + * WebKit.gypi: + * tests/MemoryInstrumentationTest.cpp: Added. + (WebCore): + (NotInstrumented): + (Instrumented): + (WebCore::Instrumented::Instrumented): + (WebCore::Instrumented::~Instrumented): + (WebCore::Instrumented::reportMemoryUsage): + (WebCore::TEST): + (InstrumentedWithOwnPtr): + (WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr): + (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): + +2012-08-01 Xingnan Wang <xingnan.wang@intel.com> + + IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type + https://bugs.webkit.org/show_bug.cgi?id=92725 + + Reviewed by Kentaro Hara. + + Add two new tests in IDBLevelDBCodingTest.cpp. One for an added function decodeByte() and + another for verifying that encodeByte() and encodeVarInt() are indentical when the encoded + values are <= 127. + + * tests/IDBLevelDBCodingTest.cpp: + (IDBLevelDBCoding::TEST): + (IDBLevelDBCoding): + +2012-08-01 James Robinson <jamesr@chromium.org> + + [chromium] Use new-style tracing macros with explicit category + https://bugs.webkit.org/show_bug.cgi?id=92928 + + Reviewed by Adam Barth. + + Set the category explicitly in traces. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::updateAnimations): + (WebKit::WebViewImpl::layout): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + +2012-08-01 James Robinson <jamesr@chromium.org> + + [chromium] Move compositor HUD font atlas initialization code out of compositor core + https://bugs.webkit.org/show_bug.cgi?id=92924 + + Reviewed by Adrienne Walker. + + This initializes the compositor's font atlas when initialization the compositor if the "Show FPS counter" or + "Show layer tree" settings are true. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setFontAtlas): + (WebKit): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + +2012-08-01 Jian Li <jianli@chromium.org> + + [chromium] Make WebKit API support draggable region change update + https://bugs.webkit.org/show_bug.cgi?id=92813 + + Reviewed by Adam Barth. + + Introduce WebDraggableRegion and delegate the draggable region update + call to the new method draggableRegionsChanged in WebViewClient. + + * public/WebDocument.h: + (WebDocument): + * public/WebDraggableRegion.h: Added. + (WebKit): + (WebDraggableRegion): + * public/WebViewClient.h: + (WebViewClient): + (WebKit::WebViewClient::draggableRegionsChanged): + * src/ChromeClientImpl.cpp: + (WebKit): + (WebKit::ChromeClientImpl::dashboardRegionsChanged): + * src/ChromeClientImpl.h: + (ChromeClientImpl): * src/WebDocument.cpp: - * src/WebDocumentType.cpp: - * src/WebDragData.cpp: - * src/WebElement.cpp: - * src/WebEntities.cpp: - * src/WebFileChooserCompletionImpl.h: - * src/WebFileSystemCallbacksImpl.cpp: - * src/WebFontImpl.cpp: + (WebKit::WebDocument::draggableRegions): + (WebKit): + +2012-08-01 Antoine Labour <piman@chromium.org> + + [chromium] factor out the optimization pass in CCRenderSurfaceFilters::apply + https://bugs.webkit.org/show_bug.cgi?id=92453 + + Reviewed by James Robinson. + + This separates the "optimization" pass in CCRenderSurfaceFilters::apply + to resolve a succession of color matrix filters into a single operation. + This allows testing of that code. + This introduces a new generic color matrix WebFilterOperation, which can + also be used on its own. + + * WebKit.gypi: + * tests/CCRenderSurfaceFiltersTest.cpp: Added. + (WebKit): + (WebKit::isCombined): + (WebKit::TEST): + +2012-08-01 Daniel Murphy <dmurph@chromium.org> + + Fix for drawing invalid layers in WebViewBenchmarkSupportImpl + https://bugs.webkit.org/show_bug.cgi?id=92920 + + Reviewed by Adrienne Walker. + + The GraphicsLayers without content needed to be skipped. + + * src/WebViewBenchmarkSupportImpl.cpp: + (WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped): + +2012-08-01 Jian Li <jianli@chromium.org> + + Add new CSS property "-webkit-widget-region" to expose dashboard region support for other port + https://bugs.webkit.org/show_bug.cgi?id=90298 + + Reviewed by Adam Barth. + + * features.gypi: Add ENABLE_WIDGET_REGION define. + +2012-08-01 Antoine Labour <piman@chromium.org> + + [chromium] Fix lost context handling on hud layer + https://bugs.webkit.org/show_bug.cgi?id=92915 + + Reviewed by Adrienne Walker. + + On lost context we need to release CCScopedTextures, otherwise later on + we will try to re-allocate it using a stale CCResourceProvider. + + Test CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext + extended. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-08-01 Nico Weber <thakis@chromium.org> + + [chromium/mac] Delete WebImageCG.cpp + https://bugs.webkit.org/show_bug.cgi?id=92910 + + Reviewed by James Robinson. + + It's been unused since the switch to skia. + Also remove now-unneeded *CG.cpp exclusion rule. + + * WebKit.gyp: + * src/WebImageCG.cpp: Removed. + +2012-08-01 Joshua Bell <jsbell@chromium.org> + + [Chromium] IndexedDB: API stubs to simplify WebIDBCursor API + https://bugs.webkit.org/show_bug.cgi?id=92414 + + Reviewed by Adam Barth. + + Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land. + Adds no-op methods which will later be implemented; during the landing sequence, + Chromium will call both the new methods and the old ones. The end goal is that + the success callbacks for cursors will include the new key/primaryKey/value rather + than requiring the callee to call back into the cursor backend to fetch them. + + * public/WebIDBCallbacks.h: + (WebIDBCallbacks): + (WebKit::WebIDBCallbacks::onSuccess): + +2012-08-01 Peter Beverloo <peter@chromium.org> + + [Text Autosizing] Provide an API for influencing the font scale factor + https://bugs.webkit.org/show_bug.cgi?id=92882 + + Reviewed by Adam Barth. + + Add an API to change Text Autosizing's font scale factor. + + The font scale factor applied to Text Autosizing influences the sizing + of text, and will influence the scaling of boosted blocks once the + implementation progresses. For Android, it will be set to the font size + chosen in the user's system-wide preferences. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setTextAutosizingFontScaleFactor): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-08-01 Dirk Pranke <dpranke@chromium.org> + + Roll chromium DEPS to 149416. + + Unreviewed. + + * DEPS: + +2012-08-01 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r124334. + http://trac.webkit.org/changeset/124334 + https://bugs.webkit.org/show_bug.cgi?id=92879 + + Broke MemoryInstrumentationTest.sizeOf from webkit_unit_tests + on Chromium canaries (Requested by apavlov1 on #webkit). + + * WebKit.gypi: + * tests/MemoryInstrumentationTest.cpp: Removed. + +2012-08-01 Ilya Tikhonovsky <loislo@chromium.org> + + Web Inspector: test native memory instrumentation code with help of unittests + https://bugs.webkit.org/show_bug.cgi?id=92743 + + Reviewed by Yury Semikhatsky. + + Test a part of existing Native Memory Instrumentation code with help of unit tests. + 6 tests were added and two bugs were fixed. + + * WebKit.gypi: + * tests/MemoryInstrumentationTest.cpp: Added. + (WebCore): + (MemoryInstrumentationImpl): + (WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl): + (WebCore::MemoryInstrumentationImpl::reportedSize): + (WebCore::MemoryInstrumentationImpl::countObjectSize): + (WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers): + (NotInstrumented): + (Instrumented): + (WebCore::Instrumented::Instrumented): + (WebCore::Instrumented::~Instrumented): + (WebCore::Instrumented::reportMemoryUsage): + (WebCore::TEST): + (InstrumentedWithOwnPtr): + (WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr): + (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): + +2012-08-01 Alexei Filippov <alexeif@chromium.org> + + Web Inspector: count DOM storage cache memory for native snapshot + https://bugs.webkit.org/show_bug.cgi?id=91617 + + Reviewed by Yury Semikhatsky. + + Add memory size used for DOM storage cache reporting interface. + + * src/StorageAreaProxy.cpp: + (WebCore::StorageAreaProxy::memoryBytesUsedByCache): + (WebCore): + * src/StorageAreaProxy.h: + (StorageAreaProxy): + +2012-07-31 Yoshifumi Inoue <yosin@chromium.org> + + [Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS + https://bugs.webkit.org/show_bug.cgi?id=92822 + + Reviewed by Kent Tamura. + + This patch enables ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS for Chromium + port except for Android. + + * features.gypi: Add ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS=1 to "feature_defines" + block of OS != "android". + +2012-07-31 Yusuf Ozuysal <yusufo@google.com> + + [chromium]Upstream WebViewImpl:StartPageScaleAnimation changes for Chrome for Android + https://bugs.webkit.org/show_bug.cgi?id=92698 + + Reviewed by Adam Barth. + + Enforce the maximum and minimum scroll positions after the scale has changed. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::startPageScaleAnimation): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-31 Terry Anderson <tdanderson@chromium.org> + + [chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap + https://bugs.webkit.org/show_bug.cgi?id=92151 + + Reviewed by Darin Fisher. + + Now that gesture events store a bounding box, use |boundingBox| instead of + |deltaX| and |deltaY| when specifying |m_area|. + + * public/WebInputEvent.h: + (WebGestureEvent): + * src/WebInputEventConversion.cpp: + (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): + +2012-07-31 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-31 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Hit test points are being clipped by layers that should not clip + https://bugs.webkit.org/show_bug.cgi?id=92786 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostCommonTest.cpp: adds a test where the + hit-testable layer does not overlap its parent. The parent does + not clip, so the layer should still be hittable. + +2012-07-31 Chris Rogers <crogers@google.com> + + Allow AudioDestination to support local/live audio input + https://bugs.webkit.org/show_bug.cgi?id=90318 + + Reviewed by Kenneth Russell. + + * src/AudioDestinationChromium.cpp: + (WebCore::AudioDestination::create): + (WebCore::AudioDestinationChromium::AudioDestinationChromium): + (WebCore::AudioDestinationChromium::provideInput): + (WebCore): + * src/AudioDestinationChromium.h: + (AudioDestinationChromium): + +2012-07-31 Adam Barth <abarth@webkit.org> + + [Chromium-Android] We should hueristically detect content intents on touch + https://bugs.webkit.org/show_bug.cgi?id=92346 + + Reviewed by Nate Chapin. + + On Android, when the user touches a block of text, we run a bunch of + OS-provided hueristics to detect content intents, such as telephone + numbers and mailing addresses. + + This patch introduces the WebViewClient functions and the + detectContentIntentOnTouch function, but does not wire the code into + the event system. There are some decisions to make about how to wire it + into the event system, we'll tackle in the next patch. + + * public/WebViewClient.h: + (WebKit::WebViewClient::detectContentIntentAround): + (WebViewClient): + (WebKit::WebViewClient::scheduleContentIntent): + (WebKit::WebViewClient::cancelScheduledContentIntents): + * src/WebViewImpl.cpp: + (WebKit): + (WebKit::tapHighlightColorForNode): + (WebKit::WebViewImpl::showTouchHighlightQuads): + (WebKit::WebViewImpl::detectContentIntentOnTouch): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-31 Ian Vollick <vollick@chromium.org> + + [chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTranslationUtil + https://bugs.webkit.org/show_bug.cgi?id=90468 + + Reviewed by James Robinson. + + * src/WebAnimation.cpp: + (WebKit::WebAnimation::targetProperty): + (WebKit): + (WebKit::WebAnimation::initialize): + * src/WebLayer.cpp: + (WebKit::WebLayer::setAnimationDelegate): + (WebKit): + (WebKit::WebLayer::addAnimation): + (WebKit::WebLayer::removeAnimation): + (WebKit::WebLayer::pauseAnimation): + (WebKit::WebLayer::suspendAnimations): + (WebKit::WebLayer::resumeAnimations): + (WebKit::WebLayer::transferAnimationsTo): + * tests/CCThreadedTest.cpp: + * tests/CCThreadedTest.h: + (TestHooks): + * tests/WebAnimationTest.cpp: + (WebKit::TEST): + +2012-07-30 Adam Barth <abarth@webkit.org> + + Typo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp + https://bugs.webkit.org/show_bug.cgi?id=92135 + + Reviewed by Kentaro Hara. + + This patch fixes a typo. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::animateZoomAroundPoint): + +2012-07-31 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r124179. + http://trac.webkit.org/changeset/124179 + https://bugs.webkit.org/show_bug.cgi?id=92730 + + Breaks Chromium Linux 32 bots with "error: integer constant is + too large for 'long' type" in IDBLevelDBCodingTest.cpp + (Requested by apavlov on #webkit). + + * tests/IDBLevelDBCodingTest.cpp: + (IDBLevelDBCoding::TEST): + +2012-07-30 Keishi Hattori <keishi@webkit.org> + + Implement datalist UI for input type color for Chromium + https://bugs.webkit.org/show_bug.cgi?id=92075 + + Reviewed by Kent Tamura. + + Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController. + ColorChooserUIController can control whether to open the color suggestion picker + popup or the color chooser depending on the responses from ColorChooserClient. + + * WebKit.gyp: + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser. + (WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium. + * src/ChromeClientImpl.h: + (WebKit): + (ChromeClientImpl): + * src/ColorChooserProxy.cpp: Removed. + * src/ColorChooserProxy.h: Removed. + * src/ColorChooserUIController.cpp: Added. + (WebKit): + (WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient. + (WebKit::ColorChooserUIController::~ColorChooserUIController): + (WebKit::ColorChooserUIController::setSelectedColor): + (WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser. + (WebKit::ColorChooserUIController::didChooseColor): + (WebKit::ColorChooserUIController::didEndChooser): + (WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size. + (WebKit::ColorChooserUIController::writeDocument): + (WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue. + (WebKit::ColorChooserUIController::didClosePopup): + (WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup. + (WebKit::ColorChooserUIController::closePopup): + (WebKit::ColorChooserUIController::openColorChooser): Opens color chooser. + * src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h. + (WebCore): + (WebKit): + (ColorChooserUIController): + * src/WebColorChooserClientImpl.cpp: Removed. + +2012-07-30 Ryosuke Niwa <rniwa@webkit.org> + + Roll out the DEPS roll (r124164) for now since it broke Chromium Mac builds. + + * DEPS: + +2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-30 Adrienne Walker <enne@google.com> + + [chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer + https://bugs.webkit.org/show_bug.cgi?id=91032 + + Reviewed by James Robinson. + + Add implementation of WebScrollbarLayer to the client API. + + * WebKit.gyp: + * src/WebScrollbarLayer.cpp: Added. + (WebKit): + (WebKit::WebScrollbarLayer::setScrollLayer): + (WebKit::WebScrollbarLayer::create): + (WebKit::WebScrollbarLayer::WebScrollbarLayer): + (WebKit::WebScrollbarLayer::operator=): + (WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>): + +2012-07-30 Sadrul Habib Chowdhury <sadrul@chromium.org> + + Propagate gesture events to plugins. + https://bugs.webkit.org/show_bug.cgi?id=92281 + + Reviewed by Adam Barth. + + Propagate gesture events to plugins. + + * src/WebInputEventConversion.cpp: + (WebKit): + (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): + * src/WebInputEventConversion.h: + (WebCore): + (WebKit): + (WebGestureEventBuilder): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::handleEvent): + * src/WebPluginContainerImpl.h: + (WebCore): + (WebPluginContainerImpl): + +2012-07-30 John Bates <jbates@google.com> + + Plumb vsync-enabled flag up to compositor thread and support disable-vsync + https://bugs.webkit.org/show_bug.cgi?id=92323 + + Reviewed by James Robinson. + + * public/WebSettings.h: + * tests/CCFrameRateControllerTest.cpp: + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::WebSettingsImpl): + (WebKit::WebSettingsImpl::setRenderVSyncEnabled): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + (WebKit::WebSettingsImpl::renderVSyncEnabled): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + +2012-07-30 Adrienne Walker <enne@google.com> + + [chromium] Remove dependency on ScrollbarTheme from the compositor + https://bugs.webkit.org/show_bug.cgi?id=90528 + + Reviewed by James Robinson. + + Add implementations for WebScrollbarThemeGeometry and + WebScrollbarThemePainter. Fill out additional API calls for + WebPluginScrollbarImpl since it derives from WebScrollbar. + + Add WebScrollbarImpl to the client API to wrap and own an existing + WebCore Scrollbar object and provide the WebScrollbar interface. + + By keeping WebScrollbar separate from WebScrollbarThemeGeometry, the + compositor thread can create its own thread-safe data bag version of a + WebScrollbar (CCScrollbarLayerImpl::CCScrollbar), but this requires + WebScrollbarThemeClientImpl. + + WebScrollbarThemeClientImpl does the reverse of WebScrollbarImpl; it + wraps a WebScrollbar and provides the ScrollbarThemeClient interface. + This is so that a WebScrollbar can be passed to the geometry and + painter functions. Then, internally the WebScrollbarThemeClientImpl + can be used to adapt the WebScrollbar to the ScrollbarThemeClient + interface so the geometry and painter functions can call direct + functions on ScrollbarThemeComposite. + + * WebKit.gyp: + * src/AssertMatchingEnums.cpp: + * src/ExternalPopupMenu.h: + (WebKit): + * src/WebPluginScrollbarImpl.cpp: + (WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl): + (WebKit::WebPluginScrollbarImpl::location): + (WebKit): + (WebKit::WebPluginScrollbarImpl::size): + (WebKit::WebPluginScrollbarImpl::enabled): + (WebKit::WebPluginScrollbarImpl::maximum): + (WebKit::WebPluginScrollbarImpl::totalSize): + (WebKit::WebPluginScrollbarImpl::isScrollViewScrollbar): + (WebKit::WebPluginScrollbarImpl::isScrollableAreaActive): + (WebKit::WebPluginScrollbarImpl::getTickmarks): + (WebKit::WebPluginScrollbarImpl::controlSize): + (WebKit::WebPluginScrollbarImpl::pressedPart): + (WebKit::WebPluginScrollbarImpl::hoveredPart): + (WebKit::WebPluginScrollbarImpl::scrollbarOverlayStyle): + (WebKit::WebPluginScrollbarImpl::orientation): + (WebKit::WebPluginScrollbarImpl::isCustomScrollbar): + (WebKit::WebPluginScrollbarImpl::onMouseUp): + (WebKit::WebPluginScrollbarImpl::onMouseMove): + (WebKit::WebPluginScrollbarImpl::onMouseLeave): + * src/WebPluginScrollbarImpl.h: + (WebPluginScrollbarImpl): + * src/WebScrollbarImpl.cpp: Added. + (WebKit): + (WebKit::WebScrollbar::create): + (WebKit::WebScrollbarImpl::WebScrollbarImpl): + (WebKit::WebScrollbarImpl::isOverlay): + (WebKit::WebScrollbarImpl::value): + (WebKit::WebScrollbarImpl::location): + (WebKit::WebScrollbarImpl::size): + (WebKit::WebScrollbarImpl::enabled): + (WebKit::WebScrollbarImpl::maximum): + (WebKit::WebScrollbarImpl::totalSize): + (WebKit::WebScrollbarImpl::isScrollViewScrollbar): + (WebKit::WebScrollbarImpl::isScrollableAreaActive): + (WebKit::WebScrollbarImpl::getTickmarks): + (WebKit::WebScrollbarImpl::controlSize): + (WebKit::WebScrollbarImpl::pressedPart): + (WebKit::WebScrollbarImpl::hoveredPart): + (WebKit::WebScrollbarImpl::scrollbarOverlayStyle): + (WebKit::WebScrollbarImpl::orientation): + (WebKit::WebScrollbarImpl::isCustomScrollbar): + * src/WebScrollbarImpl.h: Copied from Source/Platform/chromium/public/WebScrollbar.h. + (WebCore): + (WebKit): + (WebScrollbarImpl): + * src/WebScrollbarThemeClientImpl.cpp: Added. + (WebKit): + (WebKit::WebScrollbarThemeClientImpl::WebScrollbarThemeClientImpl): + (WebKit::WebScrollbarThemeClientImpl::x): + (WebKit::WebScrollbarThemeClientImpl::y): + (WebKit::WebScrollbarThemeClientImpl::width): + (WebKit::WebScrollbarThemeClientImpl::height): + (WebKit::WebScrollbarThemeClientImpl::size): + (WebKit::WebScrollbarThemeClientImpl::location): + (WebKit::WebScrollbarThemeClientImpl::parent): + (WebKit::WebScrollbarThemeClientImpl::root): + (WebKit::WebScrollbarThemeClientImpl::setFrameRect): + (WebKit::WebScrollbarThemeClientImpl::frameRect): + (WebKit::WebScrollbarThemeClientImpl::invalidate): + (WebKit::WebScrollbarThemeClientImpl::invalidateRect): + (WebKit::WebScrollbarThemeClientImpl::scrollbarOverlayStyle): + (WebKit::WebScrollbarThemeClientImpl::getTickmarks): + (WebKit::WebScrollbarThemeClientImpl::isScrollableAreaActive): + (WebKit::WebScrollbarThemeClientImpl::isScrollViewScrollbar): + (WebKit::WebScrollbarThemeClientImpl::convertFromContainingWindow): + (WebKit::WebScrollbarThemeClientImpl::isCustomScrollbar): + (WebKit::WebScrollbarThemeClientImpl::orientation): + (WebKit::WebScrollbarThemeClientImpl::value): + (WebKit::WebScrollbarThemeClientImpl::currentPos): + (WebKit::WebScrollbarThemeClientImpl::visibleSize): + (WebKit::WebScrollbarThemeClientImpl::totalSize): + (WebKit::WebScrollbarThemeClientImpl::maximum): + (WebKit::WebScrollbarThemeClientImpl::controlSize): + (WebKit::WebScrollbarThemeClientImpl::lineStep): + (WebKit::WebScrollbarThemeClientImpl::pageStep): + (WebKit::WebScrollbarThemeClientImpl::pressedPart): + (WebKit::WebScrollbarThemeClientImpl::hoveredPart): + (WebKit::WebScrollbarThemeClientImpl::styleChanged): + (WebKit::WebScrollbarThemeClientImpl::enabled): + (WebKit::WebScrollbarThemeClientImpl::setEnabled): + (WebKit::WebScrollbarThemeClientImpl::isOverlayScrollbar): + * src/WebScrollbarThemeClientImpl.h: Added. + (WebCore): + (WebKit): + (WebScrollbarThemeClientImpl): + * src/WebScrollbarThemeGeometry.cpp: Added. + (WebKit): + (WebKit::WebScrollbarThemeGeometry::assign): + (WebKit::WebScrollbarThemeGeometry::thumbPosition): + (WebKit::WebScrollbarThemeGeometry::thumbLength): + (WebKit::WebScrollbarThemeGeometry::trackPosition): + (WebKit::WebScrollbarThemeGeometry::trackLength): + (WebKit::WebScrollbarThemeGeometry::hasButtons): + (WebKit::WebScrollbarThemeGeometry::hasThumb): + (WebKit::WebScrollbarThemeGeometry::trackRect): + (WebKit::WebScrollbarThemeGeometry::thumbRect): + (WebKit::WebScrollbarThemeGeometry::minimumThumbLength): + (WebKit::WebScrollbarThemeGeometry::scrollbarThickness): + (WebKit::WebScrollbarThemeGeometry::backButtonStartRect): + (WebKit::WebScrollbarThemeGeometry::backButtonEndRect): + (WebKit::WebScrollbarThemeGeometry::forwardButtonStartRect): + (WebKit::WebScrollbarThemeGeometry::forwardButtonEndRect): + (WebKit::WebScrollbarThemeGeometry::constrainTrackRectToTrackPieces): + (WebKit::WebScrollbarThemeGeometry::splitTrack): + (WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry): + * src/WebScrollbarThemePainter.cpp: Added. + (WebKit): + (WebKit::WebScrollbarThemePainter::assign): + (WebKit::WebScrollbarThemePainter::paintScrollbarBackground): + (WebKit::WebScrollbarThemePainter::paintTrackBackground): + (WebKit::WebScrollbarThemePainter::paintBackTrackPart): + (WebKit::WebScrollbarThemePainter::paintForwardTrackPart): + (WebKit::WebScrollbarThemePainter::paintBackButtonStart): + (WebKit::WebScrollbarThemePainter::paintBackButtonEnd): + (WebKit::WebScrollbarThemePainter::paintForwardButtonStart): + (WebKit::WebScrollbarThemePainter::paintForwardButtonEnd): + (WebKit::WebScrollbarThemePainter::paintTickmarks): + (WebKit::WebScrollbarThemePainter::paintThumb): + (WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter): + * tests/ScrollbarLayerChromiumTest.cpp: + (WebCore::MockScrollbar::convertFromContainingWindow): + (WebCore::MockScrollbar::isOverlayScrollbar): + (MockScrollbar): + (WebCore::TEST): + +2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r124025. + http://trac.webkit.org/changeset/124025 + https://bugs.webkit.org/show_bug.cgi?id=92658 + + Causes color-suggestion-picker-appearance layout test to time + out on all Chromium platforms (Requested by tomhudson_ on + #webkit). + + * WebKit.gyp: + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::createColorChooser): + * src/ChromeClientImpl.h: + (WebCore): + (ChromeClientImpl): + * src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebKit): + (WebKit::ColorChooserProxy::ColorChooserProxy): + (WebKit::ColorChooserProxy::~ColorChooserProxy): + (WebKit::ColorChooserProxy::setSelectedColor): + (WebKit::ColorChooserProxy::endChooser): + * src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebKit): + (ColorChooserProxy): + * src/ColorChooserUIController.cpp: Removed. + * src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebKit): + (WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl): + (WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl): + (WebKit::WebColorChooserClientImpl::didChooseColor): + (WebKit::WebColorChooserClientImpl::didEndChooser): + * src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebCore): + (WebKit): + (WebColorChooserClientImpl): + +2012-07-30 Keishi Hattori <keishi@webkit.org> + + Implement datalist UI for input type color for Chromium + https://bugs.webkit.org/show_bug.cgi?id=92075 + + Reviewed by Kent Tamura. + + Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController. + ColorChooserUIController can control whether to open the color suggestion picker + popup or the color chooser depending on the responses from ColorChooserClient. + + * WebKit.gyp: + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser. + (WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium. + * src/ChromeClientImpl.h: + (WebKit): + (ChromeClientImpl): + * src/ColorChooserProxy.cpp: Removed. + * src/ColorChooserProxy.h: Removed. + * src/ColorChooserUIController.cpp: Added. + (WebKit): + (WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient. + (WebKit::ColorChooserUIController::~ColorChooserUIController): + (WebKit::ColorChooserUIController::setSelectedColor): + (WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser. + (WebKit::ColorChooserUIController::didChooseColor): + (WebKit::ColorChooserUIController::didEndChooser): + (WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size. + (WebKit::ColorChooserUIController::writeDocument): + (WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue. + (WebKit::ColorChooserUIController::didClosePopup): + (WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup. + (WebKit::ColorChooserUIController::closePopup): + (WebKit::ColorChooserUIController::openColorChooser): Opens color chooser. + * src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h. + (WebCore): + (WebKit): + (ColorChooserUIController): + * src/WebColorChooserClientImpl.cpp: Removed. + +2012-07-30 Kaustubh Atrawalkar <kaustubh@motorola.com> + + [DRT] LTC:: pageNumberForElementById() could be moved to Internals + https://bugs.webkit.org/show_bug.cgi?id=92091 + + Reviewed by Hajime Morita. + + Move the pageNumberForElementById from LayoutTestCotroller to Internals and + remove the old platform specific implementations as it exclusively tests WebCore functionality. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit): + * src/WebFrameImpl.h: + (WebFrameImpl): + +2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r124004. + http://trac.webkit.org/changeset/124004 + https://bugs.webkit.org/show_bug.cgi?id=92622 + + Broke Android build (Requested by keishi on #webkit). + + * WebKit.gyp: + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::createColorChooser): + * src/ChromeClientImpl.h: + (WebCore): + (ChromeClientImpl): + * src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebKit): + (WebKit::ColorChooserProxy::ColorChooserProxy): + (WebKit::ColorChooserProxy::~ColorChooserProxy): + (WebKit::ColorChooserProxy::setSelectedColor): + (WebKit::ColorChooserProxy::endChooser): + * src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebKit): + (ColorChooserProxy): + * src/ColorChooserUIController.cpp: Removed. + * src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebKit): + (WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl): + (WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl): + (WebKit::WebColorChooserClientImpl::didChooseColor): + (WebKit::WebColorChooserClientImpl::didEndChooser): + * src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h. + (WebCore): + (WebKit): + (WebColorChooserClientImpl): + +2012-07-30 Keishi Hattori <keishi@webkit.org> + + Implement datalist UI for input type color for Chromium + https://bugs.webkit.org/show_bug.cgi?id=92075 + + Reviewed by Kent Tamura. + + Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController. + ColorChooserUIController can control whether to open the color suggestion picker + popup or the color chooser depending on the responses from ColorChooserClient. + + * WebKit.gyp: + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser. + (WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium. + * src/ChromeClientImpl.h: + (WebKit): + (ChromeClientImpl): + * src/ColorChooserProxy.cpp: Removed. + * src/ColorChooserProxy.h: Removed. + * src/ColorChooserUIController.cpp: Added. + (WebKit): + (WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient. + (WebKit::ColorChooserUIController::~ColorChooserUIController): + (WebKit::ColorChooserUIController::setSelectedColor): + (WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser. + (WebKit::ColorChooserUIController::didChooseColor): + (WebKit::ColorChooserUIController::didEndChooser): + (WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size. + (WebKit::ColorChooserUIController::writeDocument): + (WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue. + (WebKit::ColorChooserUIController::didClosePopup): + (WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup. + (WebKit::ColorChooserUIController::closePopup): + (WebKit::ColorChooserUIController::openColorChooser): Opens color chooser. + * src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h. + (WebCore): + (WebKit): + (ColorChooserUIController): + * src/WebColorChooserClientImpl.cpp: Removed. + +2012-07-29 Lu Guanqun <guanqun.lu@intel.com> + + [chromium] pass acceleratePainting info to settings + https://bugs.webkit.org/show_bug.cgi?id=92467 + + Reviewed by Eric Seidel. + + The acceleratePainting info is not passed into settings correctly so + that GPU composition would not use the code path of accelerated painting. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): + +2012-07-29 Rik Cabanier <cabanier@adobe.com> + + Add ENABLE_CSS_COMPOSITING flag + https://bugs.webkit.org/show_bug.cgi?id=92553 + + Reviewed by Dirk Schulze. + + Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html + + * features.gypi: + +2012-07-28 Peter Kasting <pkasting@google.com> + + Sigh. Just disable all the AutoResize tests after the first three. + https://bugs.webkit.org/show_bug.cgi?id=92318 + + Unreviewed, making bots happier. + + * tests/WebViewTest.cpp: + +2012-07-28 Peter Kasting <pkasting@google.com> + + Try disabling different test in hopes of tracking down the real problem. + https://bugs.webkit.org/show_bug.cgi?id=92318 + + Unreviewed, making bots happier. + + * tests/WebViewTest.cpp: + +2012-07-27 Peter Kasting <pkasting@google.com> + + Disable failing test. + https://bugs.webkit.org/show_bug.cgi?id=92318 -2012-10-04 Alec Flett <alecflett@chromium.org> + Unreviewed, making bots happier. - IndexedDB: promote objectstore/index backend ids to the frontend - https://bugs.webkit.org/show_bug.cgi?id=97834 + * tests/WebViewTest.cpp: + +2012-07-27 Scott Graham <scottmg@chromium.org> + + Change navigator.webkitGamepads[] to navigator.webkitGetGamepads() + https://bugs.webkit.org/show_bug.cgi?id=92533 + + Reviewed by Adam Barth. + + Renames for updated access point. + + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enableGamepad): + (WebKit::WebRuntimeFeatures::isGamepadEnabled): + +2012-07-27 Kevin Ellis <kevers@chromium.org> + + [chromium] Calendar for input type=date should be larger on devices that support touch input. + https://bugs.webkit.org/show_bug.cgi?id=92424 + + Reviewed by Kent Tamura. + + Plumbs the deviceSupportsTouch setting through to the popup page so + that the Calendar popup can be enlarged on screens that support touch + input. + + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::initPage): + +2012-07-27 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-27 Oli Lan <olilan@chromium.org> + + [chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes). + https://bugs.webkit.org/show_bug.cgi?id=79117 + + Fix two issues in WebFrameImpl::visiblePositionForWindowPoint. + + 1) If the point is off-screen, the visiblePosition is clipped to the screen. + - The fix is to add HitTestRequest::IgnoreClipping. + + 2) The result is incorrect if the point is within an iframe. + - This is because we are calling convertFromContainingWindow twice: once in windowToContents, + and then explicitly as well. + - This patch removes the explicit call to convertFromContainingWindow. + + Reviewed by Adam Barth. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::visiblePositionForWindowPoint): + +2012-07-27 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-27 Alec Flett <alecflett@chromium.org> + + IndexedDB: inject index keys on cursor/objectstore/index get success handlers + https://bugs.webkit.org/show_bug.cgi?id=91123 Reviewed by Tony Chang. - Support for marshalling additional IDBMetadata and new calls to - createObjectStore/createIndex. + Remove method no longer used. - * public/WebIDBDatabase.h: - (WebKit::WebIDBDatabase::createObjectStore): - * public/WebIDBMetadata.h: - (ObjectStore): - (Index): - * public/WebIDBObjectStore.h: - (WebKit::WebIDBObjectStore::createIndex): - * src/IDBDatabaseBackendProxy.cpp: - (WebKit::IDBDatabaseBackendProxy::createObjectStore): + * tests/IDBFakeBackingStore.h: + +2012-07-26 Yoshifumi Inoue <yosin@chromium.org> + + [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week + https://bugs.webkit.org/show_bug.cgi?id=92339 + + Reviewed by Kent Tamura. + + To detect compilation errors and test failure earlier, I would like + build and run tests for input type datetime, datetime-local, month, + time and week with runtime feature flags to avoid behavior changes + on chromium browser. + + This patch adds query and change functions for runtime features of + input type datetime, datetime-local, month, time and week to WebRuntimeFeatures + class for exposing DRT and chromium browser expermental flags. + + * features.gypi: Turn on ENABLE_INPUT_TYPE_DATETIME, ENABLE_INPUT_TYPE_DATETIMELOCAL, + ENABLE_INPUT_TYPE_MONTH, ENABLE_INPUT_TYPE_TIME, and ENABLE_INPUT_TYPE_WEEK for all OS. + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enableInputTypeDateTime): Added. + (WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled): Added. + (WebKit::WebRuntimeFeatures::enableInputTypeDateTimeLocal): Added. + (WebKit::WebRuntimeFeatures::isInputTypeDateTimeLocalEnabled): Added. + (WebKit::WebRuntimeFeatures::enableInputTypeMonth): Added. + (WebKit::WebRuntimeFeatures::isInputTypeMonthEnabled): Added. + (WebKit::WebRuntimeFeatures::enableInputTypeTime): Added. + (WebKit::WebRuntimeFeatures::isInputTypeTimeEnabled): Added. + (WebKit::WebRuntimeFeatures::enableInputTypeWeek): Added. + (WebKit::WebRuntimeFeatures::isInputTypeWeekEnabled): Added. + +2012-07-26 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r123799. + http://trac.webkit.org/changeset/123799 + https://bugs.webkit.org/show_bug.cgi?id=92431 + + broke the Apple Mac build (Requested by bweinstein on + #webkit). + + * src/WebInputEventConversion.cpp: (WebKit): - * src/IDBDatabaseBackendProxy.h: - (IDBDatabaseBackendProxy): - * src/IDBObjectStoreBackendProxy.cpp: - (WebKit::IDBObjectStoreBackendProxy::createIndex): + * src/WebInputEventConversion.h: (WebKit): - * src/IDBObjectStoreBackendProxy.h: - (IDBObjectStoreBackendProxy): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::handleEvent): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + +2012-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org> + + Propagate gesture events to plugins. + https://bugs.webkit.org/show_bug.cgi?id=92281 + + Reviewed by Adam Barth. + + Propagate gesture events to plugins. + + * src/WebInputEventConversion.cpp: + (WebKit): + (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): + * src/WebInputEventConversion.h: + (WebCore): + (WebKit): + (WebGestureEventBuilder): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::handleEvent): + * src/WebPluginContainerImpl.h: + (WebCore): + (WebPluginContainerImpl): + +2012-07-26 Adrienne Walker <enne@google.com> + + [chromium] Remove redundant surface origin transforms + https://bugs.webkit.org/show_bug.cgi?id=91815 + + Reviewed by Stephen White. + + Clean up use of origin transforms in tests. Where possible, test + against the equivalent draw transform. + + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + +2012-07-25 David Grogan <dgrogan@chromium.org> + + IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events + https://bugs.webkit.org/show_bug.cgi?id=92203 + + Reviewed by Adam Barth. + + This is the beginning of our typical three-sided-patch process. + + * public/WebIDBCallbacks.h: + (WebKit::WebIDBCallbacks::onBlocked): + (WebKit::WebIDBCallbacks::onUpgradeNeeded): + * public/WebIDBDatabaseCallbacks.h: + (WebKit::WebIDBDatabaseCallbacks::onVersionChange): + * public/WebIDBFactory.h: + (WebIDBFactory): + (WebKit::WebIDBFactory::open): + * src/WebIDBFactoryImpl.cpp: + (WebKit::WebIDBFactoryImpl::open): + (WebKit): + * src/WebIDBFactoryImpl.h: + (WebIDBFactoryImpl): + +2012-07-19 Adrienne Walker <enne@google.com> + + [chromium] Make all compositor screen space transforms operate on content rects + https://bugs.webkit.org/show_bug.cgi?id=91807 + + Reviewed by Kenneth Russell. + + Update tests that deal with screen space transforms to reflect this change. + + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-07-25 Andrew Wilson <atwilson@chromium.org> + + Unreviewed chromium change to disable failing WebViewTest.AutoResizeInBetweenSizes. + https://bugs.webkit.org/show_bug.cgi?id=92318 + + * tests/WebViewTest.cpp: + +2012-07-25 Scott Graham <scottmg@chromium.org> + + [Chromium] fix double->float warnings in CCLayerTreeHostCommonTest.cpp + https://bugs.webkit.org/show_bug.cgi?id=92271 + + Reviewed by Adrienne Walker. + + Fix compile warnings on Windows. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-07-25 Dana Jansens <danakj@chromium.org> + + [chromium] Move WebFilterOperations from RenderPassDrawQuad to RenderPass + https://bugs.webkit.org/show_bug.cgi?id=91885 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + (FakeCCRendererClient::rootRenderPass): + (FakeCCRendererClient::renderPassesInDrawOrder): + (FakeCCRendererClient::renderPasses): + (FakeCCRendererClient): + (TEST_F): + (TEST): + +2012-07-24 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Refactor CCLayerTreeHostCommon: move root layer special case initialization into internal code. + https://bugs.webkit.org/show_bug.cgi?id=88953 + + Reviewed by Adrienne Walker. + + Unit tests updated to account for the new less-special root layer setup. + - most test cases just needed to remove root->renderSurface()->setContentBounds(), createRenderSurface(), and renderSurfaceLayerList.append(). + - some test cases originally relied on setting some awkward unconventional bounds of the rootLayer that were different than the rootLayer's renderSurface. these tests are updated. + - a few minor cleanups otherwise. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::executeCalculateDrawTransformsAndVisibility): + * tests/CCLayerIteratorTest.cpp: + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): + +2012-07-25 Taiju Tsuiki <tzik@chromium.org> + + FileSystem should provide a way to delete filesystem. + https://bugs.webkit.org/show_bug.cgi?id=91861 + + Reviewed by Adam Barth. + + * public/WebFrameClient.h: + (WebFrameClient): + (WebKit::WebFrameClient::deleteFileSystem): + * src/LocalFileSystemChromium.cpp: Add deleteFileSystem + (WebCore::deleteFileSystemNotAllowed): + (WebCore): + (WebCore::LocalFileSystem::deleteFileSystem): + +2012-07-25 Alok Priyadarshi <alokp@chromium.org> + + [chromium] WebViewBenchmarkSupport::paint API does not work with recording canvas + https://bugs.webkit.org/show_bug.cgi?id=92008 + + Reviewed by Darin Fisher. + + Moved the ownership of canvas to WebViewBenchmarkSupport::PaintClient. + + * public/WebViewBenchmarkSupport.h: + (PaintClient): + (WebKit::WebViewBenchmarkSupport::PaintClient::willPaint): + (WebKit::WebViewBenchmarkSupport::PaintClient::didPaint): + * src/WebViewBenchmarkSupportImpl.cpp: + (WebKit::WebViewBenchmarkSupportImpl::paintLayer): + (WebKit::WebViewBenchmarkSupportImpl::softwarePaint): + +2012-07-24 Dana Jansens <danakj@chromium.org> + + [chromium] Turn the debug HUD into a layer so that it can be drawn as a WebCompositorQuad + https://bugs.webkit.org/show_bug.cgi?id=92182 + + Reviewed by Adrienne Walker. + + * tests/LayerRendererChromiumTest.cpp: + (TEST): + +2012-07-25 Adrienne Walker <enne@google.com> + + [chromium] Unify compositor quadTransform/drawTransform/originTransform + https://bugs.webkit.org/show_bug.cgi?id=91417 + + Reviewed by Kenneth Russell. + + Clean up tests to refer to the new draw transform semantics. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::createTestTreeWithOneSurface): + (WebKitTests::createTestTreeWithTwoSurfaces): + (WebKitTests::TEST_F): + * tests/CCLayerSorterTest.cpp: + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread): + * tests/CCQuadCullerTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-07-25 Kevin Ellis <kevers@chromium.org> + + [chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1. + https://bugs.webkit.org/show_bug.cgi?id=92177 + + Manually tested at deviceScaleFactor = 1 and 2. + + Reviewed by Kent Tamura. + + The device scale factor was not being set for the calendar popup. + As a result, the popup was rendered too small on hidpi displays. + This patch sets the device scale factor for any page popup. + + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::initPage): + +2012-07-25 MORITA Hajime <morrita@google.com> + + Another unreviewed win build fix against r123569. + + * tests/IDBAbortOnCorruptTest.cpp: + +2012-07-25 MORITA Hajime <morrita@google.com> + + Unreviewed win build fix against r123569. + + * tests/IDBAbortOnCorruptTest.cpp: + * tests/IDBDatabaseBackendTest.cpp: + +2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-24 Dave Tu <dtu@chromium.org> + + [chromium] Move renderingStats from WebView to WebWidget. + https://bugs.webkit.org/show_bug.cgi?id=92184 + + Reviewed by Adam Barth. + + We are going to add some rendering stats that work in non-composited mode, so the renderingStats() method should be moved from WebView to WebWidget. + + * public/WebView.h: + (WebKit): + (WebView): + * public/WebWidget.h: + (WebKit): + (WebWidget): + (WebKit::WebWidget::renderingStats): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-24 Alec Flett <alecflett@chromium.org> + + IndexedDB: fix #include dependencies so IDBRequest isn't an include root + https://bugs.webkit.org/show_bug.cgi?id=92167 + + Reviewed by Tony Chang. + + Remove implicit dependencies due to using IDBRequest.h, and fix all + places that break as a result. + + * src/IDBCallbacksProxy.cpp: * src/WebIDBDatabaseImpl.cpp: - (WebKit::WebIDBDatabaseImpl::createObjectStore): + * src/WebIDBTransactionImpl.cpp: + +2012-07-24 Adam Barth <abarth@webkit.org> + + [Chromium] Support scrolling and zooming to focused input elements + https://bugs.webkit.org/show_bug.cgi?id=91661 + + Reviewed by Darin Fisher. + + This patch introduces saveScrollAndScaleState and + restoreScrollAndScaleState, which can be used to save and restore the + scroll and scale state of the WebView, respectively. These functions + will be used by Chromium on Android to save the scale and scrolls state + before zoom into a text field so that we can "undo" the zoom if the + user didn't mean to zoom into the text field. + + I wanted to write unit tests for these functions, but it wasn't clear + to me how to write the test because startPageScaleAnimation appears to + complete asynchronously. + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::saveScrollAndScaleState): (WebKit): - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): + (WebKit::WebViewImpl::restoreScrollAndScaleState): + (WebKit::WebViewImpl::resetSavedScrollAndScaleState): + (WebKit::WebViewImpl::didCommitLoad): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-24 Dave Tu <dtu@chromium.org> + + [chromium] Add time spent painting to GPU benchmarking renderingStats() API. + https://bugs.webkit.org/show_bug.cgi?id=90019 + + Reviewed by Adrienne Walker. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::renderingStats): + * tests/CCLayerTreeHostTest.cpp: + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect): + (WebKitTests::FakeTiledLayerChromium::update): + * tests/CCTiledLayerTestCommon.h: + (Texture): + (FakeTiledLayerChromium): + * tests/Canvas2DLayerBridgeTest.cpp: + * tests/ContentLayerChromiumTest.cpp: + (WebKit::TEST): + * tests/TiledLayerChromiumTest.cpp: + +2012-07-24 Jian Li <jianli@chromium.org> + + Add per-context setting for html notifications + https://bugs.webkit.org/show_bug.cgi?id=91295 + + Reviewed by Adam Barth. + + Add new per-context feature for chromium port. + + * public/WebPermissionClient.h: + (WebPermissionClient): + (WebKit::WebPermissionClient::allowHTMLNotifications): + * src/ContextFeaturesClientImpl.cpp: + (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): + +2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r123499. + http://trac.webkit.org/changeset/123499 + https://bugs.webkit.org/show_bug.cgi?id=92161 + + Android fails to compile (Requested by zhenyao on #webkit). + + * src/AssertMatchingEnums.cpp: + +2012-07-24 Terry Anderson <tdanderson@chromium.org> + + [chromium] Add a bounding box member in WebGestureEvent + https://bugs.webkit.org/show_bug.cgi?id=92144 + + Reviewed by Adam Barth. + + The new |boundingBox| member will be used to store the touch region for a WebGestureEvent. + This will be useful for gesture target fuzzing across multiple different gesture types + (tap, long press, scroll, etc.) + + * public/WebInputEvent.h: + (WebGestureEvent): + * src/WebInputEvent.cpp: + (SameSizeAsWebGestureEvent): + +2012-07-24 Nico Weber <thakis@chromium.org> + + [chromium/mac] Add cursor resource pngs to the pak file. + https://bugs.webkit.org/show_bug.cgi?id=92148 + + Reviewed by Tony Chang. + + Once https://chromiumcodereview.appspot.com/10817031/ has landed, they can be + removed from WebCore.gyp's mac_bundle_resources. Part of http://crbug.com/137588 + + * WebKit.grd: + +2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r123472. + http://trac.webkit.org/changeset/123472 + https://bugs.webkit.org/show_bug.cgi?id=92134 + + Revert roll to v8 version that crashes sporadically (Requested + by atwilson on #webkit). + + * DEPS: + +2012-07-24 Keishi Hattori <keishi@webkit.org> + + [Chromium] Page popup should close on mouse down + https://bugs.webkit.org/show_bug.cgi?id=92092 + + Reviewed by Kent Tamura. + + Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that + we can hook to hide the page popup when the user clicks on the page. + + * src/WebPagePopupImpl.h: + (WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client. + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the + mouse down event opened the same popup we just closed. + +2012-07-24 Jochen Eisinger <jochen@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r123463. + http://trac.webkit.org/changeset/123463 + https://bugs.webkit.org/show_bug.cgi?id=92110 + + Broke Android build (Requested by keishi on #webkit). + + * src/WebPagePopupImpl.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleMouseDown): + +2012-07-24 Keishi Hattori <keishi@webkit.org> + + [Chromium] Page popup should close on mouse down + https://bugs.webkit.org/show_bug.cgi?id=92092 + + Reviewed by Kent Tamura. + + Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that + we can hook to hide the page popup when the user clicks on the page. + + * src/WebPagePopupImpl.h: + (WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client. + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the + mouse down event opened the same popup we just closed. + +2012-07-24 Anthony Scian <ascian@rim.com> + + Web Inspector [JSC]: Enable initiator column in network panel. + https://bugs.webkit.org/show_bug.cgi?id=65533 + + Reviewed by Vsevolod Vlasov. + + With 40118 fixed for webkit, Preferences.displayInitiator should be set to true. + Removed references to it since the optionality is no longer required. + + Test: http/tests/inspector/network/network-initiator.html + + * src/js/DevTools.js: + +2012-07-24 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-23 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move layoutTestMode to WebCore + https://bugs.webkit.org/show_bug.cgi?id=92010 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + * src/WebKit.cpp: + (WebKit::setLayoutTestMode): + (WebKit::layoutTestMode): + +2012-07-23 Dave Tu <dtu@chromium.org> + + [chromium] Add droppedFrameCount to renderingStats. + https://bugs.webkit.org/show_bug.cgi?id=91694 + + Reviewed by Adrienne Walker. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::renderingStats): + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread): + +2012-07-23 Brian Anderson <brianderson@chromium.org> + + [chromium] Use shallow flushes that don't glFlush + https://bugs.webkit.org/show_bug.cgi?id=90325 + + Reviewed by Kenneth Russell. + + Changed CCTextureUpdaterTest to recognize shallowFlushCHROMIUM(). + + * tests/CCTextureUpdaterTest.cpp: + +2012-07-23 Adrienne Walker <enne@google.com> + + [chromium] Add more compositor unit tests for high DPI transforms + https://bugs.webkit.org/show_bug.cgi?id=91917 + + Reviewed by Kenneth Russell. + + The current set of high DPI tests only deal with layers in a render + surface. Add some extra tests for non-surface layers. Also add a test + to make sure that an owning layer in a surface doesn't differ from a + non-owning layer in high DPI circumstances. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-07-23 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Fix unit tests in debug mode after r123375 + https://bugs.webkit.org/show_bug.cgi?id=92030 + + Reviewed by Adrienne Walker. + + Fixed two unit tests that were causing debug assertions because + they gave calcDrawTransforms an empty sized root layer. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-07-23 Simon Fraser <simon.fraser@apple.com> + + Part 2 of: Implement sticky positioning + https://bugs.webkit.org/show_bug.cgi?id=90046 + + Reviewed by Ojan Vafai. + + Turn on ENABLE_CSS_STICKY_POSITION. + + * features.gypi: + +2012-07-23 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect design + https://bugs.webkit.org/show_bug.cgi?id=80622 + + Reviewed by Adrienne Walker. + + Many tests needed to be updated because the semantics of the layer tree have changed: + - a few tests that were no longer applicable were removed. + - many tests needed to have fixed initialization, properly + setting surface contentRect and rootLayer bounds. + - because clipRect and usesLayerClipping no longer exists, those places in code had to be removed/changed + - the scissorRect tests needed to have updated expectations + because after this patch, the rootLayer Surface now clips + to its contentBounds. + - the clipRect tests were changed to test the layer's new semantics for the drawableContentRect instead. + + * tests/CCLayerImplTest.cpp: + (WebCore::TEST): + * tests/CCLayerIteratorTest.cpp: + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): + * tests/LayerChromiumTest.cpp: + +2012-07-23 Daniel Cheng <dcheng@chromium.org> + + [chromium] Fix build on Ubuntu Precise. + https://bugs.webkit.org/show_bug.cgi?id=92021 + + Reviewed by Adrienne Walker. + + Remove an array that's written but never read. + + * tests/CCResourceProviderTest.cpp: + (WebKit::TEST_F): + +2012-07-23 Nate Chapin <japhet@chromium.org> + + Add WebTextInputType enum values for text areas and + content-editable. + https://bugs.webkit.org/show_bug.cgi?id=91654 + + Reviewed by Adam Barth. + + No new tests, no behavior change without corresponding chromium.org changes. + + * public/WebTextInputType.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::textInputType): + +2012-07-23 Pierre Rossi <pierre.rossi@gmail.com> + + Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client + https://bugs.webkit.org/show_bug.cgi?id=91006 + + Reviewed by Ryosuke Niwa. + + Rename the functions to follow a more boolean logic. + + * public/WebViewClient.h: + (WebKit::WebViewClient::hasTouchEventHandlers): + * src/ChromeClientImpl.cpp: + (WebKit): + (WebKit::ChromeClientImpl::needTouchEvents): + * src/ChromeClientImpl.h: + (ChromeClientImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::hasTouchEventHandlers): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-23 Simon Fraser <simon.fraser@apple.com> + + Implement sticky positioning + https://bugs.webkit.org/show_bug.cgi?id=90046 + + Reviewed by Ojan Vafai. + + Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially. + + * features.gypi: + +2012-07-23 Peter Beverloo <peter@chromium.org> + + [Chromium] Buildfix for fixing gclient on the Chromium Windows bot + https://bugs.webkit.org/show_bug.cgi?id=91977 + + Unreviewed build fix. + + Add the tools/isolate directory to the Windows checkout as these files + currently are missing during gyp generation. maruel introduced the need + for these in this isolate refactoring, specifically this Chromium CL: + http://src.chromium.org/viewvc/chrome?view=rev&revision=147689 + + * DEPS: + +2012-07-22 Kent Tamura <tkent@chromium.org> + + [Chromium-Mac] Fix a build error. + + * DEPS: Add third_party/GTM. + +2012-07-23 Kent Tamura <tkent@chromium.org> + + Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively + https://bugs.webkit.org/show_bug.cgi?id=91941 + + Reviewed by Kentaro Hara. + + A flag name for an elmement should be ENABLE_*_ELEMENT. + + * features.gypi: + +2012-07-22 Kent Tamura <tkent@chromium.org> + + Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT + https://bugs.webkit.org/show_bug.cgi?id=91928 + + Reviewed by Kentaro Hara. + + A flag name for an elmement should be ENABLE_*_ELEMENT. + + * features.gypi: + +2012-07-21 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-20 Kent Tamura <tkent@chromium.org> + + Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT + https://bugs.webkit.org/show_bug.cgi?id=91846 + + Reviewed by Kentaro Hara. + + A flag name for an elmement should be ENABLE_*_ELEMENT. + + * features.gypi: + * src/WebInputElement.cpp: + (WebKit::WebInputElement::dataListOptions): + +2012-07-20 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Simplify backend interface classes + https://bugs.webkit.org/show_bug.cgi?id=91901 + + Reviewed by Tony Chang. + + Remove unnecessary method stubs from proxy class. + + * src/IDBTransactionBackendProxy.cpp: + * src/IDBTransactionBackendProxy.h: + (IDBTransactionBackendProxy): + +2012-07-20 Scott Graham <scottmg@chromium.org> + + Add windows native versions of bison, flex and gperf. + + Reviewed by Tony Chang. + + * DEPS: + +2012-07-20 David Grogan <dgrogan@chromium.org> + + IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types + https://bugs.webkit.org/show_bug.cgi?id=91414 + + Reviewed by Adam Barth. + + * src/AssertMatchingEnums.cpp: * src/WebIDBMetadata.cpp: (WebKit::WebIDBMetadata::WebIDBMetadata): (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): + +2012-07-20 Robert Sesek <rsesek@chromium.org> + + [chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6 + https://bugs.webkit.org/show_bug.cgi?id=91752 + + Reviewed by Eric Seidel. + + Use 10.6 NSScreen/NSColorSpace APIs to determine if the screen is + monochrome rather than comparing against deprecated colorspace names. + + * src/mac/WebScreenInfoFactory.mm: + (WebKit::WebScreenInfoFactory::screenInfo): + +2012-07-20 Daniel Murphy <dmurph@chromium.org> + + Introduce WebViewBenchmarkSupport for performance experiments on a real WebView + https://bugs.webkit.org/show_bug.cgi?id=88271 + + Reviewed by Darin Fisher. + + * WebKit.gyp: + * public/WebView.h: + (WebKit): + (WebView): + (WebKit::WebView::benchmarkSupport): + * public/WebViewBenchmarkSupport.h: Added. + (WebKit): + (WebViewBenchmarkSupport): + (PaintClient): + (WebKit::WebViewBenchmarkSupport::PaintClient::willPaint): + (WebKit::WebViewBenchmarkSupport::PaintClient::didPaint): + (WebKit::WebViewBenchmarkSupport::PaintClient::~PaintClient): + (WebKit::WebViewBenchmarkSupport::~WebViewBenchmarkSupport): + * src/WebViewBenchmarkSupportImpl.cpp: Added. + (WebKit): + (WebKit::WebViewBenchmarkSupportImpl::paintLayer): + (WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped): + (WebKit::WebViewBenchmarkSupportImpl::softwarePaint): + (WebKit::WebViewBenchmarkSupportImpl::paint): + * src/WebViewBenchmarkSupportImpl.h: Added. + (WebCore): + (WebKit): + (WebViewBenchmarkSupportImpl): + (WebKit::WebViewBenchmarkSupportImpl::WebViewBenchmarkSupportImpl): + (WebKit::WebViewBenchmarkSupportImpl::~WebViewBenchmarkSupportImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::benchmarkSupport): + (WebKit): + (WebKit::WebViewImpl::rootGraphicsLayer): + * src/WebViewImpl.h: + (WebKit): + (WebViewImpl): + +2012-07-20 Han Shen <shenhan@google.com> + + [Chromium] Compilation fails under gcc 4.7 + https://bugs.webkit.org/show_bug.cgi?id=90227 + + Reviewed by Tony Chang. + + Disable warnings about c++0x compatibility in gcc newer than 4.6. + + * WebKit.gyp: + * WebKitUnitTests.gyp: + +2012-07-20 Adam Barth <abarth@webkit.org> + + [Chromium] Add WebView::zoomToFindInPageRect for Android + https://bugs.webkit.org/show_bug.cgi?id=91801 + + Reviewed by Tony Chang. + + On Android, when you find in page, we scale the viewport to reveal what + you've found (because the screen is small). This function instructs the + WebView to zoom to display a given rect. + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::animateZoomAroundPoint): + - This function is a bit more general than necessary for this patch + because it is also used in other cases for animating a zoom + around a given point (e.g., double-tap to zoom). These uses will + be upstreamed in later patches. + (WebKit::WebViewImpl::zoomToFindInPageRect): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-19 Luke Macpherson <macpherson@chromium.org> + + Enable CSS variables compile time flag in Chrome. + https://bugs.webkit.org/show_bug.cgi?id=91708 + + Reviewed by Dimitri Glazkov. + + Flips the ENABLE_CSS_VARIABLES compile flag on for Chrome. There is also a run-time flag that is off by default, + so this should not have a user visible effect other than making the variables runtime flag visible at chrome://flags/ + + * features.gypi: + +2012-07-19 Wei James <james.wei@intel.com> + + enable Web Audio for chromium android port + https://bugs.webkit.org/show_bug.cgi?id=89428 + + Reviewed by Kenneth Russell. + + * features.gypi: + +2012-07-19 Adam Barth <abarth@webkit.org> + + [Chromium] Support external autofill popups + https://bugs.webkit.org/show_bug.cgi?id=91651 + + Reviewed by Darin Fisher. + + This looks like the last piece needed to support external autofill + popups. This function just lets the embedder select an index + (presumably because the user picked an index from the external autofill + popup). + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::selectAutofillSuggestionAtIndex): + (WebKit): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-19 Zeev Lieber <zlieber@chromium.org> + + [Chromium] Textures drawn during occlusion are incorrectly re-used when unoccluded. + https://bugs.webkit.org/show_bug.cgi?id=91537 + + Reviewed by Adrienne Walker. + + Added unit tests to test texture caching with clipping and + occlusion. Removed some minor code duplication when initializing + layers for various scenarios. + + MockCCQuadCuller can now implement CCQuadSink. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/MockCCQuadCuller.h: + (WebCore::MockCCQuadCuller::MockCCQuadCuller): + +2012-07-19 Adam Barth <abarth@webkit.org> + + [Chromium] WebView is missing isSelectionEditable and backgroundColor which are used by chromium-android + https://bugs.webkit.org/show_bug.cgi?id=91671 + + Reviewed by Darin Fisher. + + I haven't studied what these APIs are used for downstream, but they + seem harmless enough. + + * public/WebView.h: + (WebView): + * public/WebWidget.h: + (WebWidget): + (WebKit::WebWidget::backgroundColor): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::isSelectionEditable): + (WebKit): + (WebKit::WebViewImpl::backgroundColor): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-19 Andrew Scherkus <scherkus@chromium.org> + + [chromium] Move WebAudioSourceProvider destructor from public to protected + https://bugs.webkit.org/show_bug.cgi?id=91669 + + Reviewed by Darin Fisher. + + The lifetime of a WebAudioSourceProvider is managed by the implementor + and should never be deallocted by WebKit. + + * public/WebAudioSourceProvider.h: + (WebAudioSourceProvider): + +2012-07-19 Tony Chang <tony@chromium.org> + + Unreviewed, rolling out r123036. + http://trac.webkit.org/changeset/123036 + https://bugs.webkit.org/show_bug.cgi?id=91555 + + Triggers some DCHECKs in Chromium browser_tests + + * public/WebTextInputType.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::textInputType): + +2012-07-19 Joshua Bell <jsbell@chromium.org> + + Roll out r121610 and r122487 which may have been causing flaky crashes + https://bugs.webkit.org/show_bug.cgi?id=91637 + + Reviewed by Kentaro Hara. + + Flaky crashes started in random tests following r121610. It's not clear + that r121610 is to blame, but we'd like to prove or disprove it. + If this doesn't resolve the crashes, this patch should be rolled out. + + * src/WebBindings.cpp: + (WebKit::getRangeImpl): + (WebKit::getElementImpl): + (WebKit::getArrayBufferImpl): + (WebKit::getArrayBufferViewImpl): + (WebKit::WebBindings::toV8Value): + +2012-07-19 Sami Kyostila <skyostil@chromium.org> + + [chromium] Remove duplicate mock CCLayerTreeHostClient + https://bugs.webkit.org/show_bug.cgi?id=89457 + + Reviewed by Adrienne Walker. + + This test can reuse the existing CCFakeLayerTreeHostClient. + + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::MockLayerTreeHost::create): + +2012-07-19 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-18 Ryosuke Niwa <rniwa@webkit.org> + + Chromium build fix attempt. Don't use anonymous namespace. + + * tests/TextureCopierTest.cpp: + +2012-07-18 Antoine Labour <piman@chromium.org> + + [chromium] Introduce CCResourceProvider, replacing TextureAllocator and hiding textures from clients to allow transport + https://bugs.webkit.org/show_bug.cgi?id=91044 + + Reviewed by Adrienne Walker. + + This does several things: + - Add a CCResourceProvider class, that hides textures and the 3D context + from layers (except those that need it). Instead layers manage + "resources". In the future, resources are expected to be transportable + to a "parent" CCResourceProvider to allow flattening of nested + compositors. + - Replace texture ids by resource ids in DrawQuads (allowing them to be + serializable). + - Replace TextureAllocator uses by the CCResourceProvider class. + - Upload of data is done through the CCResourceProvider instead of + explicit GL calls. + - External textures are wrapped into a resource at draw time (see + caveat/FIXME in CCTextureLayerImpl). + - Rendering with the resources is done through an explicit + beginRenderFrom/endRenderFrom that exposes the texture only between that + pair. + - Merge all the LayerTextureSubImage instances (one per layer), into a + single instance on the CCResourceProvider. + + Added CCResourceProviderTest, the refactoring is covered by existing tests. + + * WebKit.gypi: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCPrioritizedTextureTest.cpp: + (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): + (WTF::CCPrioritizedTextureTest::createManager): + (WTF::CCPrioritizedTextureTest::validateTexture): + (WTF::CCPrioritizedTextureTest::resourceProvider): + (CCPrioritizedTextureTest): + (WTF::TEST_F): + * tests/CCQuadCullerTest.cpp: + * tests/CCResourceProviderTest.cpp: Added. + (WebKit): + (ResourceProviderContext): + (WebKit::ResourceProviderContext::create): + (WebKit::ResourceProviderContext::bindTexture): + (WebKit::ResourceProviderContext::createTexture): + (WebKit::ResourceProviderContext::deleteTexture): + (WebKit::ResourceProviderContext::texStorage2DEXT): + (WebKit::ResourceProviderContext::texImage2D): + (WebKit::ResourceProviderContext::texSubImage2D): + (WebKit::ResourceProviderContext::getPixels): + (WebKit::ResourceProviderContext::textureCount): + (WebKit::ResourceProviderContext::textureSize): + (WebKit::ResourceProviderContext::ResourceProviderContext): + (WebKit::ResourceProviderContext::Texture::Texture): + (Texture): + (WebKit::ResourceProviderContext::allocateTexture): + (WebKit::ResourceProviderContext::setPixels): + (CCResourceProviderTest): + (WebKit::CCResourceProviderTest::CCResourceProviderTest): + (WebKit::CCResourceProviderTest::context): + (WebKit::CCResourceProviderTest::getResourcePixels): + (WebKit::TEST_F): + * tests/CCScopedTextureTest.cpp: + (WebKitTests::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::createLayer): + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): + * tests/CCTiledLayerTestCommon.h: + (Texture): + (WebKitTests::FakeTextureCopier::copyTexture): + (WebKitTests::FakeTextureCopier::flush): + (WebKitTests::FakeTextureUploader::uploadTexture): + * tests/ContentLayerChromiumTest.cpp: + (WebKit::TEST): + * tests/FakeCCGraphicsContext.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTexture.h. + (WebKit): + (WebKit::createFakeCCGraphicsContext): + * tests/LayerRendererChromiumTest.cpp: + (FakeLayerRendererChromium::FakeLayerRendererChromium): + (LayerRendererChromiumTest::LayerRendererChromiumTest): + (LayerRendererChromiumTest::context): + (LayerRendererChromiumTest): + (TEST_F): + (TEST): + * tests/TextureCopierTest.cpp: + * tests/TextureManagerTest.cpp: + (WTF::TextureManagerTest::TextureManagerTest): + (WTF::TextureManagerTest::createTextureManager): + (WTF::TextureManagerTest::requestTexture): + (TextureManagerTest): + * tests/TiledLayerChromiumTest.cpp: + +2012-07-18 David Grogan <dgrogan@chromium.org> + + IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h + https://bugs.webkit.org/show_bug.cgi?id=91408 + + Reviewed by Adam Barth. + + This is in support of the new upgradeneeded versioning api. + intVersion will eventually replace the WebString version member. + + * public/WebIDBMetadata.h: + (WebKit::WebIDBMetadata::WebIDBMetadata): + The spec uses unsigned long long for version numbers but we use signed + long long so that we can use -1 as a sentinel. It indicates that a + database still uses a string version. + +2012-07-18 Adam Barth <abarth@webkit.org> + + Disable printing on chromium-android + https://bugs.webkit.org/show_bug.cgi?id=91550 + + Reviewed by Tony Chang. + + We don't implement printing on Android. + + * features.gypi: + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::printPage): + +2012-07-18 Alexandre Elias <aelias@google.com> + + [chromium] Ubercomp: add id to SharedQuadState + https://bugs.webkit.org/show_bug.cgi?id=91670 + + Reviewed by Adrienne Walker. + + This assigns an integer ID to SharedQuadState objects and a + corresponding ID to quads. This ID is unique only within a + RenderPass and currently is just set to the index in the shared quad + state list. This is redundant with the pointer and exists to + simplify serialization. + + I found out that pointer rewriting within a pickler is blocked by + pointers to memory being const there, so the reassignment will have to + be performed in the application layer anyway. In that case, it's + simplest to add some ID integers. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + (CCLayerTestCommon::getQuads): + +2012-07-18 Nate Chapin <japhet@chromium.org> + + Add WebTextInputType enum values for text areas and + content-editable. + https://bugs.webkit.org/show_bug.cgi?id=91654 + + Reviewed by Adam Barth. + + No new tests, no behavior change without corresponding chromium.org changes. + + * public/WebTextInputType.h: + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::textInputType): + +2012-07-18 Alexandre Elias <aelias@google.com> + + [chromium] Ubercomp: clean up CCRenderer interface + https://bugs.webkit.org/show_bug.cgi?id=91555 + + Reviewed by Adrienne Walker. + + I replaced the one-by-one RenderPass calls with a new drawFrame() + method that directly takes a CCRenderPassList, and moved a small + amount of code from CCLayerTreeHostImpl to implement it. In ubercomp + mode, we will produce a frame bundle rather than a command-stream, so + the full list is easier to work with. + + Also, give empty default implementations for the methods that don't + need to do anything in a non-GL context, and make private + setScissorToRect. + + * tests/LayerRendererChromiumTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + (FakeCCRendererClient::renderPasses): + (FakeCCRendererClient): + (TEST_F): + (TEST): + +2012-07-18 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Fix some coding style violations + https://bugs.webkit.org/show_bug.cgi?id=91565 + + Reviewed by Tony Chang. + + * tests/IDBLevelDBCodingTest.cpp: + (IDBLevelDBCoding::TEST): + +2012-07-18 Tony Chang <tony@chromium.org> + + [chromium] Unreviewed, fix some MSVC compile warnings. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-07-18 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Call SQLiteFileSystem-related functions directly + https://bugs.webkit.org/show_bug.cgi?id=91631 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * public/platform/WebKitPlatformSupport.h: + (WebKitPlatformSupport): + * src/PlatformSupport.cpp: + (WebCore): + +2012-07-18 Tony Chang <tony@chromium.org> + + [chromium] Unreviewed, more compile fixes on Chromium Win. + + * tests/WebTransformationMatrixTest.cpp: + (WebKit::TEST): + +2012-07-18 Tony Chang <tony@chromium.org> + + [chromium] Fix compile on Windows. + + 148>tests\LayerChromiumTest.cpp(510): warning C4305: 'argument' : truncation from 'double' to 'float' + + * tests/LayerChromiumTest.cpp: + +2012-07-18 Alec Flett <alecflett@chromium.org> + + Implement putIndexKeys in WebIDBObjectStoreImpl + https://bugs.webkit.org/show_bug.cgi?id=91546 + + Reviewed by Darin Fisher. + + Implement putIndexKeys in the chromium API, so it is callable + from chromium. + * src/WebIDBObjectStoreImpl.cpp: - (WebKit::WebIDBObjectStoreImpl::createIndex): + (WebKit::WebIDBObjectStoreImpl::putWithIndexKeys): (WebKit): * src/WebIDBObjectStoreImpl.h: (WebIDBObjectStoreImpl): -2012-10-04 Simon Fraser <simon.fraser@apple.com> - Standardize on "flush" terminology for compositing layer flushing/syncing - https://bugs.webkit.org/show_bug.cgi?id=98321 +2012-07-18 Tony Chang <tony@chromium.org> - Reviewed by Simon Fraser. + [chromium] Unreviewed compile fix for Android. - Rename compositing-related methods that refer to "syncing" to instead - refer to "flushing". + More sqrt fixes. - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::scheduleCompositingLayerFlush): + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-07-18 Tony Chang <tony@chromium.org> + + [chromium] Unreviewed compile fix for Android. + + Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual void<unnamed>::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()': + Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + +2012-07-18 Varun Jain <varunjain@chromium.org> + + [chromium] Drag image for image elements should be scaled with device scale factor. + https://bugs.webkit.org/show_bug.cgi?id=89688 + + Reviewed by Adam Barth. + + * src/DragClientImpl.cpp: + (WebKit::DragClientImpl::startDrag): + * tests/DragImageTest.cpp: + (WebCore::TEST): + +2012-07-18 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Fix style for numeric literals in chromium unit test code + https://bugs.webkit.org/show_bug.cgi?id=91635 + + Reviewed by Adrienne Walker. + + Where possible, removed ".0" and "f" suffixes on numeric literals, + to be more consistent with WebKit style rules. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCLayerQuadTest.cpp: + (WebCore::TEST): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/LayerChromiumTest.cpp: + * tests/WebTransformationMatrixTest.cpp: + (WebKit::TEST): + +2012-07-17 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Remove awkward anchorPoint usage that implicity affects layer position + https://bugs.webkit.org/show_bug.cgi?id=91472 + + Reviewed by Adrienne Walker. + + Unit tests were updated to account for the fact that anchorPoint + and position are now separated. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-07-18 Yoshifumi Inoue <yosin@chromium.org> + + Decimal::toString should not round integer value. + https://bugs.webkit.org/show_bug.cgi?id=91481 + + Reviewed by Kent Tamura. + + This patch adds a new test cases for Decimal::toString() for failed + value and maximum coefficient value with various exponent. + + * tests/DecimalTest.cpp: + (TEST_F): DecimalTest.toString: Add test cases for big coefficient values. + +2012-07-18 Hans Wennborg <hans@chromium.org> + + Add copy constructor to WebSpeechGrammar.h + https://bugs.webkit.org/show_bug.cgi?id=91484 + + Reviewed by Adam Barth. + + Provide user-defined copy constructor (and assign function) for WebSpeechGrammar. + Without this, we were hitting the implicit copy constructor, which in + turn used the implicit copy constructor of WebPrivatePtr. This was bad, + because the implicit copy constructor wouldn't increace the reference + count on the wrapped object, causing us to crash. + + Also add one for WebSpeechRecognitionResult; haven't seen any problems + here, but I noticed it was missing. + + * public/WebSpeechGrammar.h: + (WebKit::WebSpeechGrammar::WebSpeechGrammar): + (WebSpeechGrammar): + * public/WebSpeechRecognitionResult.h: + (WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult): + (WebSpeechRecognitionResult): + * src/WebSpeechGrammar.cpp: + (WebKit::WebSpeechGrammar::assign): + (WebKit): + +2012-07-17 Yoshifumi Inoue <yosin@chromium.org> + + Decimal constructor with 99999999999999999 loses last digit + https://bugs.webkit.org/show_bug.cgi?id=91579 + + Reviewed by Kent Tamura. + + This patch adds test cases for Decimal::EncodedData constructors for + testing edge cases in addition to common cases which they aren't + covered by other test cases. + + * tests/DecimalTest.cpp: + (EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of + writing test cases for verifying components of Decimal::EncodedData. + (TEST_F): Added a new test entry DecimalTest.Constructor. + +2012-07-17 Yoshifumi Inoue <yosin@chromium.org> + + Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case + https://bugs.webkit.org/show_bug.cgi?id=91572 + + Reviewed by Kent Tamura. + + This patch introduces EXPECT_DECIMAL_STREQ macro to replace EXPECT_EQ + with String class for displaying text string rather than object dump + for ease of debugging test cases. + + * tests/DecimalTest.cpp: + (DecimalTest::stepDown): Changed to return Decimal instead of String + to use EXPECT_DECIMAL_STREQ. + (DecimalTest::stepUp): ditto. + (TEST_F): Replaced EXPECT_EQ + String class to EXPECT_DECIMAL_STREQ. + +2012-07-17 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Key generator state not maintained across connections + https://bugs.webkit.org/show_bug.cgi?id=91456 + + Reviewed by Tony Chang. + + Add stub method implementations to test class. + + * tests/IDBFakeBackingStore.h: + +2012-07-17 Tony Chang <tony@chromium.org> + + Unreviewed, rolling out r122884. + http://trac.webkit.org/changeset/122884 + https://bugs.webkit.org/show_bug.cgi?id=91408 + + Broke the chromium-win build. + + * public/WebIDBMetadata.h: + (WebIDBMetadata): + (WebKit::WebIDBMetadata::WebIDBMetadata): + +2012-07-17 David Grogan <dgrogan@chromium.org> + + IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h + https://bugs.webkit.org/show_bug.cgi?id=91408 + + Reviewed by Adam Barth. + + This is in support of the new upgradeneeded versioning api. + intVersion will eventually replace the WebString version member. + + * public/WebIDBMetadata.h: + (WebIDBMetadata): The spec uses unsigned long long for version + numbers but we use int64_t here so that we can use -1 as a sentinel. + It indicates that a database still uses a string version. + +2012-07-17 Tony Chang <tony@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-17 Vivek Galatage <vivekgalatage@gmail.com> + + Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel. + https://bugs.webkit.org/show_bug.cgi?id=91196 + + Reviewed by Pavel Feldman. + + Refactoring InspectorClients. InspectorClient::openInspectorFrontend + now returning the InspectorFrontendChannel. + + * src/InspectorClientImpl.cpp: + (WebKit::InspectorClientImpl::openInspectorFrontend): + * src/InspectorClientImpl.h: + (InspectorClientImpl): + * src/WebDevToolsAgentImpl.cpp: + (WebKit::WebDevToolsAgentImpl::reattach): + (WebKit::WebDevToolsAgentImpl::openInspectorFrontend): + * src/WebDevToolsAgentImpl.h: + (WebDevToolsAgentImpl): + +2012-07-16 Adam Barth <abarth@webkit.org> + + Unreviewed. Remove two empty directories. + + * public/linuxish: Removed. + * src/linuxish: Removed. + +2012-07-16 Gyuyoung Kim <gyuyoung.kim@samsung.com> + + Add RegisterProtocolHandlerClient to the Modules/protocolhandler + https://bugs.webkit.org/show_bug.cgi?id=90940 + + Reviewed by Hajime Morita. + + As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs + to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for + protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient. + + In order to support this, RegisterProtocolHandlerClientImpl class is added to ChromeClientImpl files. + + In addition, existing functions related to protocol handler in ChromeClientImpl class are moved to + RegisterProtocolHandlerClientImpl class. + + * WebKit.gyp: + * src/ChromeClientImpl.cpp: Implement RegisterProtocolHandlerClientImpl class. + (WebKit): + (WebKit::RegisterProtocolHandlerClientImpl::create): + (WebKit::RegisterProtocolHandlerClientImpl::RegisterProtocolHandlerClientImpl): + (WebKit::RegisterProtocolHandlerClientImpl::registerProtocolHandler): * src/ChromeClientImpl.h: (ChromeClientImpl): + (RegisterProtocolHandlerClientImpl): + (WebKit::RegisterProtocolHandlerClientImpl::~RegisterProtocolHandlerClientImpl): + (WebKit): + * src/WebViewImpl.cpp: Register RegisterProtocolHandlerClientImpl in order to support supplement. + (WebKit::WebViewImpl::WebViewImpl): + * src/WebViewImpl.h: + +2012-07-16 Yoshifumi Inoue <yosin@chromium.org> + + REGRESSION(r122552): DecimalTest tests (CeilingSmallExponent and FloorSmallExponent) started failing. + https://bugs.webkit.org/show_bug.cgi?id=91244 + + Reviewed by Kent Tamura. + + This patch enables and updates disabled test cases of DecimalTest + caused by fixes in r122552 of Decimal::ceiling() and Decimal::floor() + for small fraction numbers and added test cases. Fixes in r122552 + itself is correct however, it didn't update existing tests for very small + fraction numbers. + + * tests/DecimalTest.cpp: + (TEST_F): CeilingSmallExponent: Change expected value to 1 for ceiling(1e-1000), + ceiling rounds number toward positive infinity. + (TEST_F): FloorSmallExponent: Change expected value to -1 for floor(-1e-1000), + floor rounds number toward negative infinity. + +2012-07-16 Koji Ishii <kojiishi@gmail.com> + + Vertical alternate glyph (GSUB) support for OpenTypeVerticalData + https://bugs.webkit.org/show_bug.cgi?id=81389 + + Reviewed by Tony Chang. + + Tests for pointer validations for OpenType tables. + + * WebKit.gypi: + * tests/OpenTypeVerticalDataTest.cpp: Added. + (WebCore): + (TestTable): + (WebCore::TestTable::validateOffset): + (WebCore::TEST): + +2012-07-16 Alexandre Elias <aelias@google.com> + + [chromium] Fix WebFrameTest flakiness due to synthetic mouse events + https://bugs.webkit.org/show_bug.cgi?id=91428 + + Reviewed by Adam Barth. + + Synthetic mouse move events on scrolling can cause segfaults in + WebFrameTest due to delayed callbacks on the message loop after + state destruction. This is currently only affecting + the Android port, but has the potential to affect other platforms in the + future. + + We can avoid the issue by disabling the deviceSupportsMouse + setting, which shouldn't be needed by any WebFrameTest. + + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::createWebViewAndLoad): + +2012-07-16 Alec Flett <alecflett@chromium.org> + + IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer + https://bugs.webkit.org/show_bug.cgi?id=90923 + + Reviewed by Darin Fisher. + + Stub out implementations of putWithIndexKeys(), already implemented + on the chromium side. + + * public/WebIDBObjectStore.h: + (WebKit::WebIDBObjectStore::putWithIndexKeys): + * src/IDBObjectStoreBackendProxy.cpp: + (WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys): + (WebKit): + * src/IDBObjectStoreBackendProxy.h: + (IDBObjectStoreBackendProxy): + +2012-07-16 Adrienne Walker <enne@google.com> + + [chromium] Unify compositor quad transforms into content space + https://bugs.webkit.org/show_bug.cgi?id=91350 + + Reviewed by Kenneth Russell. + + Update tests to add bounds/contentBounds properties to layers. This + exposed a bug in the quad culler tests where the draw transform was + incorrectly being set to the origin transform rather than being a + transform that operates on centered layer rects. Fixed this bug. + + * tests/CCQuadCullerTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::createLayer): + +2012-07-16 Adrienne Walker <enne@google.com> + + [chromium] Unify compositor quad transforms into content space + https://bugs.webkit.org/show_bug.cgi?id=91350 + + Reviewed by Kenneth Russell. + + Update tests to add bounds/contentBounds properties to layers. This + exposed a bug in the quad culler tests where the draw transform was + incorrectly being set to the origin transform rather than being a + transform that operates on centered layer rects. Fixed this bug. + + * tests/CCQuadCullerTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::createLayer): + +2012-07-16 Dana Jansens <danakj@chromium.org> + + [chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into + https://bugs.webkit.org/show_bug.cgi?id=91288 + + Reviewed by Adrienne Walker. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCLayerImplTest.cpp: + (WebCore::TEST): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): + * tests/CCQuadCullerTest.cpp: + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeTiledLayerChromium::setTexturePriorities): + * tests/LayerChromiumTest.cpp: + +2012-07-16 Sami Kyostila <skyostil@chromium.org> + + [chromium] Only apply page scale delta to root scroll layer + https://bugs.webkit.org/show_bug.cgi?id=91374 + + Reviewed by Adrienne Walker. + + New unit test + CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly to verify + the transformation of child layer while pinch zooming. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-07-16 Kihong Kwon <kihong.kwon@samsung.com> + + Remove setController from BatteryClient + https://bugs.webkit.org/show_bug.cgi?id=90944 + + Reviewed by Adam Barth. + + Remove virtual identifier from setController because setController is removed from WebCore::BatteryClient. + In addition, BatteryController is set to instance of BatteryClientImpl in the constructor of WebViewImpl. + + * src/BatteryClientImpl.h: + (BatteryClientImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + +2012-07-16 Dana Jansens <danakj@chromium.org> + + [chromium] Incorrect assertion: Replicas will cause a RenderPass to be removed twice + https://bugs.webkit.org/show_bug.cgi?id=91328 + + Reviewed by Adrienne Walker. + + Add replicas to the surfaces in the test. + + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest): + (CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): + +2012-07-13 Eric Penner <epenner@google.com> + + [chromium] Add 'self-managed' option to CCPrioritizedTexture to enable render-surface and canvas use cases. + https://bugs.webkit.org/show_bug.cgi?id=91177 + + Reviewed by Adrienne Walker. + + * tests/CCPrioritizedTextureTest.cpp: + (WTF::TEST_F): + * tests/TiledLayerChromiumTest.cpp: + +2012-07-13 Brian Anderson <brianderson@chromium.org> + + Add flushes to CCTextureUpdater::update + https://bugs.webkit.org/show_bug.cgi?id=89035 + + Reviewed by Adrienne Walker. + + CCTextureUpdaterTest added to verify texture upload/flushing patterns. + + * WebKit.gypi: + * tests/CCTextureUpdaterTest.cpp: Added. + +2012-07-13 David Grogan <dgrogan@chromium.org> + + IndexedDB: Re-enable indexeddb in test_shell + https://bugs.webkit.org/show_bug.cgi?id=91161 + + Reviewed by Tony Chang. + + IDB used to be allowed to run if webView->permissionClient() was NULL, + as is the case in test_shell. This was inadvertently changed in + http://wkb.ug/90310. + + We still don't have an automated test for this (http://crbug.com/113738) + Tested manually: + + * In test_shell: + 1) Open an IDB page + 2) Verify IDB has permission to open a DB + + * In chrome: + 1) Open an IDB page + 2) Verify IDB has permission to open a DB + 3) Revoke IDB permissions in chrome://chrome/settings/content + 4) Reload the IDB page + 5) Verify IDB doesn't have permission to open a DB + + * src/IDBFactoryBackendProxy.cpp: + (WebKit::IDBFactoryBackendProxy::allowIndexedDB): + +2012-07-13 Wei James <james.wei@intel.com> + + enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support + https://bugs.webkit.org/show_bug.cgi?id=91194 + + Reviewed by Adam Barth. -2012-10-05 Kent Tamura <tkent@chromium.org> + * WebKitUnitTests.gyp: + +2012-07-13 Dana Jansens <danakj@chromium.org> + + webkit_unit_test CCLayerTreeHostImplTest.testRemoveRenderPasses started failing. + https://bugs.webkit.org/show_bug.cgi?id=91245 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-07-13 Vsevolod Vlasov <vsevik@chromium.org> + + Unreviewed gardening: skip failing webkit unit test. - [Chromium] Enable the multiple fields UI for input[type=date] - https://bugs.webkit.org/show_bug.cgi?id=98351 + * tests/CCLayerTreeHostImplTest.cpp: + +2012-07-13 Vsevolod Vlasov <vsevik@chromium.org> + + Unreviewed gardening, skip failing webkit_unit_tests. + + * tests/DecimalTest.cpp: + (TEST_F): + +2012-07-13 Kent Tamura <tkent@chromium.org> + + Make calendar pickers testable + https://bugs.webkit.org/show_bug.cgi?id=84827 Reviewed by Hajime Morita. + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::ChromeClientImpl): + Initialize m_pagePopupDriver with the WebViewImpl. + (WebKit::ChromeClientImpl::openPagePopup): + Just calls PagePoupDriver::openPagePopup(). + (WebKit::ChromeClientImpl::closePagePopup): + Just calls PagePoupDriver::closePagePopup(). + (WebKit::ChromeClientImpl::setPagePopupDriver): + * src/ChromeClientImpl.h: + (ChromeClientImpl): Add setPagePopupDriver + * src/WebViewImpl.h: + (WebViewImpl): + WebViewImpl implements PagePopupDriver. openPagePopup() and + closePagePopup() override members of PagePopupDriver. + +2012-07-13 Yoshifumi Inoue <yosin@chromium.org> + + REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched + https://bugs.webkit.org/show_bug.cgi?id=91197 + + Reviewed by Kent Tamura. + + This patch adds test cases for Decimal::ceiling() and floor() of + positive/negative small fractional numbers. + + * tests/DecimalTest.cpp: + (TEST_F): + +2012-07-12 Adrienne Walker <enne@google.com> + + [chromium] Root invalidations for RTL pages need to be in the right space + https://bugs.webkit.org/show_bug.cgi?id=91155 + + Reviewed by Kenneth Russell. + + The root layer has a translation on it when placed in the tree, so any + invalidations on this layer likewise need to be adjusted. + + This adjustment is due to the fact that compositor layers all have the + origin in the upper left corner of the layer, but this is not always + the origin for graphics layers. Rather than making compositor layers + have to deal with a potential offset, we change the transform when + inserting the layer into the tree. Invalidations need to be similarly + transformed from document space into compositor layer space. + + The need for this offset is due to the definition of the initial + containing block. RTL pages (pages with dir=RTL on the body) start + scrolled all the way to the right, and the origin is in the upper left + hand corner of this initial viewport. Thus on RTL pages with + horizontal overflow, the left of the document is in negative CSS + space. + + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::invalidateRect): + +2012-07-12 Dana Jansens <danakj@chromium.org> + + [chromium] Remove the RenderPass pointer from RenderPassDrawQuad + https://bugs.webkit.org/show_bug.cgi?id=91023 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-07-12 Adam Barth <abarth@webkit.org> + + [Chromium] WebSettings should be sorted + https://bugs.webkit.org/show_bug.cgi?id=91157 + + Reviewed by Eric Seidel. + + This might be my OCD, but IMHO this file would be cleaner if we listed + the settings in alphabetic order. + + * public/WebSettings.h: + * src/WebSettingsImpl.h: + (WebSettingsImpl): + (WebKit::WebSettingsImpl::forceSoftwareCompositing): + (WebKit::WebSettingsImpl::viewportEnabled): + (WebKit::WebSettingsImpl::maxUntiledLayerSize): + +2012-07-12 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Enable IDBFactory.deleteDatabase() and webkitGetDatabaseNames() in Workers + https://bugs.webkit.org/show_bug.cgi?id=90310 + + Reviewed by Tony Chang. + + * src/IDBFactoryBackendProxy.cpp: + (WebKit::IDBFactoryBackendProxy::allowIndexedDB): Consolidates user-prompting logic. + (WebKit::getWebFrame): Helper to dig out frame from Document, or null for Worker. + (WebKit::IDBFactoryBackendProxy::getDatabaseNames): + (WebKit): + (WebKit::IDBFactoryBackendProxy::open): + (WebKit::IDBFactoryBackendProxy::deleteDatabase): + * src/IDBFactoryBackendProxy.h: Update method signatures to match interface. + (WebCore): + (IDBFactoryBackendProxy): + +2012-07-12 Dana Jansens <danakj@chromium.org> + + [chromium] The root layer should not try create a second RenderSurface for itself + https://bugs.webkit.org/show_bug.cgi?id=91124 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-07-12 Eric Penner <epenner@google.com> + + [chromium] Use CCTexture/TextureAllocator and remove TextureManager + https://bugs.webkit.org/show_bug.cgi?id=91001 + + Reviewed by Adrienne Walker. + + Deleting old texture manager tests. + + * WebKit.gypi: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCPrioritizedTextureTest.cpp: + (WTF::CCPrioritizedTextureTest::texturesMemorySize): + * tests/CCThreadedTest.cpp: + * tests/CCTiledLayerTestCommon.h: + * tests/Canvas2DLayerBridgeTest.cpp: + * tests/TextureManagerTest.cpp: Removed. + +2012-07-12 Robert Sesek <rsesek@chromium.org> + + [chromium][Mac] r122400 broke 10.6 build + https://bugs.webkit.org/show_bug.cgi?id=91103 + + Reviewed by Tony Chang. + + Use the right availability macros for forward-declaring methods and + defining constants. + + * src/mac/WebInputEventFactory.mm: + +2012-07-12 Tony Chang <tony@chromium.org> + + [chromium] Remove drag and drop API methods that are no longer used + https://bugs.webkit.org/show_bug.cgi?id=90996 + + Reviewed by Adam Barth. + + In r117327, we added a parameter for modifier keys to these methods. + Chromium has since switched to using the methods that require the + extra parameter so we can remove these methods. + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::dragTargetDragEnter): + (WebKit::WebViewImpl::dragTargetDragOver): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-12 Tony Chang <tony@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-12 Adam Barth <abarth@webkit.org> + + [Chromium] Delete last mention of Hixie76 in WebKit/chromium + https://bugs.webkit.org/show_bug.cgi?id=91099 + + Reviewed by Tony Chang. + + This deprecated API is no longer used anywhere. + + * public/WebSettings.h: + (WebKit::WebSettings::setDefaultDeviceScaleFactor): + +2012-07-12 Tony Chang <tony@chromium.org> + + Unreviewed, rolling out r122477. + http://trac.webkit.org/changeset/122477 + https://bugs.webkit.org/show_bug.cgi?id=91103 + + Broke Chromium Mac build + + * src/mac/WebInputEventFactory.mm: + +2012-07-12 Robert Sesek <rsesek@chromium.org> + + [chromium][Mac] r122400 broke 10.6 build + https://bugs.webkit.org/show_bug.cgi?id=91103 + + Reviewed by Tony Chang. + + Use the right availability macros for forward-declaring methods and + defining constants. + + * src/mac/WebInputEventFactory.mm: + +2012-07-12 Peter Beverloo <peter@chromium.org> + + [Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=90989 + + Reviewed by Adam Barth. + + Add dependencies on the webkit_unit_tests_apk and TestWebKitAPI_apk + targets for Android, making sure that we're generating the packages. + + * All.gyp: + +2012-07-12 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Remove unrequired API in WebSurroundingText. + https://bugs.webkit.org/show_bug.cgi?id=91067 + + Reviewed by Adam Barth. + + Remove the unused first initialize method from WebSurroundingText. + Now both Chromium and LayoutTestController use the second method. + + * public/WebSurroundingText.h: + (WebSurroundingText): + * src/WebSurroundingText.cpp: + +2012-07-11 Mark Rowe <mrowe@apple.com> + + <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros + + This removal was handled by a script that translates the relevant macros in to the equivalent checks + using the system availability macros. + + Reviewed by Filip Pizlo. + + * src/mac/WebInputEventFactory.mm: + +2012-07-11 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-11 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r122358. + http://trac.webkit.org/changeset/122358 + https://bugs.webkit.org/show_bug.cgi?id=91037 + + Build break on WebKit Win (Requested by hayato on #webkit). + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::dragTargetDragEnter): + (WebKit): + (WebKit::WebViewImpl::dragTargetDragOver): + (WebKit::WebViewImpl::dragTargetDrop): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-07-11 Alexandre Elias <aelias@google.com> + + [chromium] Move compositor quads to Platform/chromium/public + https://bugs.webkit.org/show_bug.cgi?id=90582 + + Reviewed by Adrienne Walker. + + This moves CCSharedQuadState, CCDrawQuad, and all but two CC*DrawQuad + classes to the WebKit namespace, as a first step to pushing them + across the process boundary for the ubercompositor. + + - The intent is to serialize the class hierarchy using the same + mechanism as WebInputEvent. In order to do this, there are three + requirements: pure POD data, a method returning size, and a packing + pragma. + + - Private data members are fine with this kind of serializer, and a + default constructor is not needed. Because of that, we can maintain + the same encapsulation and convenient APIs (behind + WEBKIT_IMPLEMENTATION) as the original classes. To ease the + transition, the original WebCore headers still exist and typedef to + the new classes. + + - However, SharedQuadState will be serialized using the normal + IPC_STRUCT_TRAITS macro, so I made its members public. A custom + serializer (on quad lists) will maintain the pointers from quads to + SharedQuadStates. + + - I converted the Material casting mechanism to materialCast() methods + living in the derived classes. That way, the WebCompositorQuad header + doesn't need to know about all its derived classes. + + - Quad classes not yet transitioned can still be used in + non-ubercompositor mode. CCRenderPassDrawQuad and CCYUVVideoDrawQuad + are currently non-POD and I left them in their original files. + + This approach is the best I've found so far, since it preserves all + WebCore-facing APIs and avoids unnecessary code duplication (new quad + types or members can be added by modifying only one place). There + also should not be an unreasonable amount of custom serializer code + required. + + * tests/CCLayerTestCommon.cpp: + (CCLayerTestCommon::verifyQuadsExactlyCoverRect): + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + +2012-07-11 Dana Jansens <danakj@chromium.org> + + [chromium] Rename layerRect to contentRect for rects that live in content space + https://bugs.webkit.org/show_bug.cgi?id=90843 + + Reviewed by Adrienne Walker. + + * tests/CCLayerImplTest.cpp: + (WebCore::TEST): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): + * tests/CCQuadCullerTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/CCTiledLayerImplTest.cpp: + (CCLayerTestCommon::createLayer): + (CCLayerTestCommon::TEST): + (CCLayerTestCommon::getQuads): + (CCLayerTestCommon::coverageVisibleRectIntersectsTiles): + (CCLayerTestCommon::coverageVisibleRectIntersectsBounds): + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::prepareToUpdate): + (WebKitTests::FakeTiledLayerChromium::update): + * tests/CCTiledLayerTestCommon.h: + (FakeTiledLayerChromium): + * tests/LayerChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-07-11 Dana Jansens <danakj@chromium.org> + + [chromium] Minimum size used for occlusion tracking should be a setting on CCLayerTreeHost + https://bugs.webkit.org/show_bug.cgi?id=90993 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-07-11 Adam Barth <abarth@webkit.org> + + [Chromium] Enable LEGACY_VIEWPORT_ADAPTION + https://bugs.webkit.org/show_bug.cgi?id=90991 + + Reviewed by Tony Chang. + + Chromium wishes to support LEGACY_VIEWPORT_ADAPTION. I actually thought + this was enabled before, but the enable bit got lost in the shuffle. + * features.gypi: - Disable ENABLE_INPUT_TYPE_DATE_LEGACY_UI. -2012-10-04 Kent Tamura <tkent@chromium.org> +2012-07-11 Tony Chang <tony@chromium.org> - Add code for input[type=date] with the multiple fields UI - https://bugs.webkit.org/show_bug.cgi?id=98340 + [chromium] Remove drag and drop API methods that are no longer used + https://bugs.webkit.org/show_bug.cgi?id=90996 - Reviewed by Hajime Morita. + Reviewed by Adam Barth. + + In r117327, we added a parameter for modifier keys to these methods. + Chromium has since switched to using the methods that require the + extra parameter so we can remove these methods. + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::dragTargetDragEnter): + (WebKit::WebViewImpl::dragTargetDragOver): + * src/WebViewImpl.h: + (WebViewImpl): - * features.gypi: Add ENABLE_INPUT_TYPE_DATE_LEGACY_UI=1 for non-Android. +2012-07-11 Shawn Singh <shawnsingh@chromium.org> -2012-10-03 Keishi Hattori <keishi@webkit.org> + Unreviewed build fix, forgot to add URLTestHelpers.* when landing r122344 - Implement localizeValue for TimeInputType - https://bugs.webkit.org/show_bug.cgi?id=98237 + * tests/URLTestHelpers.cpp: Added. + (URLTestHelpers): + (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): + (WebKit::URLTestHelpers::registerMockedURLLoad): + * tests/URLTestHelpers.h: Added. + (WebKit): + (URLTestHelpers): + (WebKit::URLTestHelpers::toKURL): + +2012-07-11 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=90094 + + Reviewed by Adrienne Walker. + + This patch adds the WEBKIT_IMPLEMENTATION = 1 define to + WebKitUnitTests.gyp. To get it to compile correctly, some string + and URL code was refactored and fixed, in particular GURL usage is + replaced with KURL usage. + + * WebKit.gyp: + added WEBKIT_IMPLEMENTATION == 1 for unit test code when in shared library + added URLTestHelpers to exclusion in shared library build, because it depends on webkit_support + + * WebKit.gypi: + added URLTestHelpers.h and .cpp to the build process + + * WebKitUnitTests.gyp: + added WEBKIT_IMPLEMENTATION == 1 for unit test code when not in shared library. + note that in shared library build, RunAllTests.cpp does not have WEBKIT_IMPLEMENTATION == 1. + + * public/WebDOMMessageEvent.h: + (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): + * tests/AssociatedURLLoaderTest.cpp: + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::loadFrame): + * tests/FrameTestHelpers.h: + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/PopupMenuTest.cpp: + * tests/RunAllTests.cpp: + * tests/URLTestHelpers.cpp: Added. + (URLTestHelpers): + (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): + (WebKit::URLTestHelpers::registerMockedURLLoad): + * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. + (WebKit): + (URLTestHelpers): + (WebKit::URLTestHelpers::toKURL): + * tests/WebFrameTest.cpp: + * tests/WebPageNewSerializerTest.cpp: + * tests/WebPageSerializerTest.cpp: + * tests/WebViewTest.cpp: + +2012-07-10 Pavel Feldman <pfeldman@chromium.org> + + Web Inspector: migrate from background images to CSS for statusbar rendering. + https://bugs.webkit.org/show_bug.cgi?id=90902 + + Reviewed by Vsevolod Vlasov. + + * WebKit.gypi: + * src/js/Images/statusbarBackgroundChromium.png: Removed. + * src/js/Images/statusbarBottomBackgroundChromium.png: Removed. + * src/js/Images/statusbarButtonsChromium.png: Removed. + * src/js/Images/statusbarMenuButtonChromium.png: Removed. + * src/js/Images/statusbarMenuButtonSelectedChromium.png: Removed. + * src/js/devTools.css: + (.status-bar-background): + +2012-07-11 Kenichi Ishibashi <bashi@chromium.org> + + [Chromium] Adding HarfBuzz-ng for Linux + https://bugs.webkit.org/show_bug.cgi?id=90362 + + Reviewed by Tony Chang. + + * features.gypi: Added use_harfbuzz_ng variable. If the value is set, USE(HARFBUZZ_NG) is defined. + +2012-07-10 Hayato Ito <hayato@chromium.org> + + Unreviewed gardening. + + Android builder started to fail after r122292. + My best guess is that '--ant-compile' does not take an argument. + + * WebKitUnitTests.gyp: + +2012-07-10 Yoshifumi Inoue <yosin@chromium.org> + + [Chromium-Windows] Implement functions for localized time format information + https://bugs.webkit.org/show_bug.cgi?id=90236 + + Reviewed by Kent Tamura. + + This patch introduces test cases for date and time format related + functions in LocaleWin. + + * tests/LocaleWinTest.cpp: + (LocaleWinTest): + (LocaleWinTest::dateComponents): Added. + (LocaleWinTest::msForDate): Moved inside class LocaleWinTest. + (LocaleWinTest::formatDate): Added. + (LocaleWinTest::parseDate): Added. + (LocaleWinTest::dateFormatText): Added. + (LocaleWinTest::firstDayOfWeek): Added. + (LocaleWinTest::monthLabel): Added. + (LocaleWinTest::weekDayShortLabel): Added. + (LocaleWinTest::timeFormatText): Added. + (LocaleWinTest::shortTimeFormatText): Added. + (LocaleWinTest::timeAMPMLabel): Added. + (TEST_F): + +2012-07-10 Adam Barth <abarth@webkit.org> + + [Chromium-Android] Add apk test targets for webkit_unit_tests and TestWebKitAPI + https://bugs.webkit.org/show_bug.cgi?id=90918 + + Reviewed by Tony Chang. + + The rules are similar to what we have added for DumpRenderTree apk. + All references to gtest_target_type can be removed once we enable APK + tests on the all bots. + + * WebKitUnitTests.gyp: + +2012-07-10 Kevin Ellis <kevers@chromium.org> + + Input elements with type=range do not have default touch handlers. + https://bugs.webkit.org/show_bug.cgi?id=88807 + + Reviewed by Antonio Gomes. + + Adds flag to enable native handling of touch events for input elements + with type=range. + + * features.gypi: + +2012-07-10 Adam Klein <adamk@chromium.org> + + [Chromium] REGRESSION(r121909): m_currentInputEvent never set + https://bugs.webkit.org/show_bug.cgi?id=90914 + + Reviewed by Abhishek Arya. + + The always-null m_currentInputEvent causes a regression when + middle-clicking on a link that calls window.open('...', '_blank'); + that new tab should open in the background, but instead opens in the + foreground (see code in ChromeClientImpl::getNavigationPolicy()). + + Fix usage of TemporaryChange to specify a local variable name so that + m_currentInputEvent is actually set for the duration of handleInputEvent. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleInputEvent): Name the TemporaryChange instance. + +2012-07-10 Adam Barth <abarth@webkit.org> + + WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed + https://bugs.webkit.org/show_bug.cgi?id=90910 + + Reviewed by Eric Seidel. + + * public/WebSettings.h: + (WebKit::WebSettings::setHixie76WebSocketProtocolEnabled): + * src/WebSettingsImpl.cpp: + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebSharedWorkerImpl.cpp: + (WebKit::WebSharedWorkerImpl::initializeLoader): + +2012-07-09 Dana Jansens <danakj@chromium.org> + + [chromium] Replace use of ManagedTexture with CCScopedTexture for impl thread and remove implTextureManager from LayerRendererChromium + https://bugs.webkit.org/show_bug.cgi?id=90841 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-07-10 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium-Android] Use default font rendering styles in FontPlatformData::querySystemForRenderStyle() + https://bugs.webkit.org/show_bug.cgi?id=90826 + + Reviewed by Adam Barth. + + * WebKit.gyp: + * src/PlatformSupport.cpp: + (WebCore::PlatformSupport::getRenderStyleForStrike): Call style.setDefault() on Android or when the font is not specified. + +2012-07-10 Dana Jansens <danakj@chromium.org> + + [chromium] Avoid allocating render pass textures that have no content + https://bugs.webkit.org/show_bug.cgi?id=90702 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking): + (CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::didCommit): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread): + (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest): + (WTF): + +2012-07-10 Leandro Gracia Gil <leandrogracia@chromium.org> + + Unreviewed Chromium build fix for mac-release. + + Fixing clang build after https://bugs.webkit.org/show_bug.cgi?id=90807 + + * public/WebSurroundingText.h: + (WebKit): + +2012-07-10 Leandro Gracia Gil <leandrogracia@chromium.org> + + WebSurroundingText layout tests should use the same code path as the rest of the feature. + https://bugs.webkit.org/show_bug.cgi?id=90807 + + Reviewed by Adam Barth. + + Replace the offset-based initialize method used only by LayoutTestController + with a point-based version to follow the same code path. + + * public/WebSurroundingText.h: + (WebKit): + (WebSurroundingText): + * src/WebSurroundingText.cpp: + (WebKit::WebSurroundingText::initialize): + +2012-07-10 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r122207. + http://trac.webkit.org/changeset/122207 + https://bugs.webkit.org/show_bug.cgi?id=90874 + + Broke the cr-windows bot (Requested by beverloo on #webkit). + + * DEPS: + +2012-07-10 Jochen Eisinger <jochen@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-09 Matt Falkenhagen <falken@chromium.org> + + Add ENABLE_DIALOG_ELEMENT and skeleton files + https://bugs.webkit.org/show_bug.cgi?id=90521 + + Reviewed by Kent Tamura. + + * features.gypi: + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enableDialogElement): + (WebKit): + (WebKit::WebRuntimeFeatures::isDialogElementEnabled): + +2012-07-09 Yoshifumi Inoue <yosin@chromium.org> + + [Chromium-Mac] Implement functions for localized time format information + https://bugs.webkit.org/show_bug.cgi?id=90237 Reviewed by Kent Tamura. * tests/LocaleMacTest.cpp: - (LocaleMacTest::timeComponents): (LocaleMacTest): - (LocaleMacTest::formatTime): Tests formatDateTime() for time. + (LocaleMacTest::timeFormatText): + (LocaleMacTest::shortTimeFormatText): + (LocaleMacTest::timeAMPMLabel): (TEST_F): -2012-10-03 Dirk Pranke <dpranke@chromium.org> +2012-07-09 Eric Penner <epenner@google.com> - Roll chromium to r160008 + [chromium] Merge updates and idle updates into one pass + https://bugs.webkit.org/show_bug.cgi?id=90324 - Unreviewed, deps roll. + Reviewed by Adrienne Walker. - * DEPS: + * tests/CCLayerTreeHostTest.cpp: + (WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount): + (WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking): + (ContentLayerChromiumWithUpdateTracking): + (WTF::CCLayerTreeHostTestOpacityChange::afterTest): + * tests/CCTiledLayerTestCommon.h: + (FakeTiledLayerChromium): + * tests/TiledLayerChromiumTest.cpp: -2012-10-03 Adam Barth <abarth@webkit.org> +2012-07-09 Yoshifumi Inoue <yosin@chromium.org> - Remove support for ENABLE(LEGACY_WEBKIT_BLOB_BUILDER) - https://bugs.webkit.org/show_bug.cgi?id=98301 + [Platform] Introduce LocaleMac class + https://bugs.webkit.org/show_bug.cgi?id=90248 - Reviewed by Eric Seidel. + Reviewed by Kent Tamura. + + This patch added tests for LocaleMac class. + + * WebKit.gypi: + * tests/LocaleMacTest.cpp: Added. + (LocaleMacTest): + (LocaleMacTest::dateComponents): + (LocaleMacTest::msForDate): + (LocaleMacTest::formatDate): + (LocaleMacTest::parseDate): + (LocaleMacTest::dateFormatText): + (LocaleMacTest::firstDayOfWeek): + (LocaleMacTest::monthLabel): + (LocaleMacTest::weekDayShortLabel): + (TEST_F): + +2012-07-09 Dana Jansens <danakj@chromium.org> + + [chromium] Create CCScopedTexture class for creating/freeing textures + https://bugs.webkit.org/show_bug.cgi?id=89485 + + Reviewed by Adrienne Walker. + + * WebKit.gypi: + * tests/CCScopedTextureTest.cpp: Added. + (WebKitTests): + (WebKitTests::TEST): + (TrackingTextureAllocator): + (WebKitTests::TrackingTextureAllocator::TrackingTextureAllocator): + (WebKitTests::TrackingTextureAllocator::numTextures): + +2012-07-09 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Remove obsolete accessor plumbing + https://bugs.webkit.org/show_bug.cgi?id=90812 + + Reviewed by Tony Chang. + + * public/WebIDBCursor.h: Remove direction. + * public/WebIDBDatabase.h: Remove name, version, objectStoreNames; + (WebKit::WebIDBDatabase::metadata): + * public/WebIDBIndex.h: Remove name, keyPath, unique, multiEntry; + * public/WebIDBObjectStore.h: Remove name, keyPath, indexNames, autoIncrement; + * src/IDBDatabaseBackendProxy.cpp: Remove plumbing. + * src/IDBDatabaseBackendProxy.h: Remove plumbing. + (IDBDatabaseBackendProxy): + * src/IDBIndexBackendProxy.cpp: Remove plumbing. + * src/IDBIndexBackendProxy.h: Remove plumbing. + (IDBIndexBackendProxy): + * src/IDBObjectStoreBackendProxy.cpp: Remove plumbing. + * src/IDBObjectStoreBackendProxy.h: Remove plumbing. + (IDBObjectStoreBackendProxy): + * src/IDBTransactionBackendProxy.cpp: Remove plumbing. + * src/IDBTransactionBackendProxy.h: Assert stub is not used - only needed + by real IDBTransactionBackendImpl + (WebKit::IDBTransactionBackendProxy::mode): + * src/WebIDBTransactionImpl.cpp: Remove plumbing. + * src/WebIDBTransactionImpl.h: Remove plumbing. + +2012-07-09 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r122161. + http://trac.webkit.org/changeset/122161 + https://bugs.webkit.org/show_bug.cgi?id=90837 + + failed to compile on chromium webkit linux bot (Requested by + shawnsingh on #webkit). + + * WebKit.gypi: + * WebKitUnitTests.gyp: + * public/WebDOMMessageEvent.h: + * tests/AssociatedURLLoaderTest.cpp: + (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): + (WebKit::AssociatedURLLoaderTest::SetUp): + (WebKit::AssociatedURLLoaderTest::CheckMethodFails): + (WebKit::AssociatedURLLoaderTest::CheckHeaderFails): + (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders): + (WebKit::TEST_F): + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::registerMockedURLLoad): + (FrameTestHelpers): + (WebKit::FrameTestHelpers::loadFrame): + * tests/FrameTestHelpers.h: + (FrameTestHelpers): + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/PopupMenuTest.cpp: + (WebKit::SelectPopupMenuTest::registerMockedURLLoad): + (WebKit::SelectPopupMenuTest::loadFrame): + (WebKit::TEST_F): + * tests/RunAllTests.cpp: + * tests/URLTestHelpers.cpp: Removed. + * tests/URLTestHelpers.h: Removed. + * tests/WebFrameTest.cpp: + (WebKit::WebFrameTest::registerMockedHttpURLLoad): + (WebKit::WebFrameTest::registerMockedChromeURLLoad): + (WebKit::TEST_F): + * tests/WebPageNewSerializerTest.cpp: + (WebKit::WebPageNewSerializeTest::registerMockedURLLoad): + (WebPageNewSerializeTest): + (WebKit::WebPageNewSerializeTest::setUpCSSTestPage): + (WebKit::WebPageNewSerializeTest::loadURLInTopFrame): + (WebKit::WebPageNewSerializeTest::resourceVectorContains): + (WebKit::TEST_F): + * tests/WebPageSerializerTest.cpp: + (WebKit::WebPageSerializerTest::registerMockedURLLoad): + (WebKit::WebPageSerializerTest::loadURLInTopFrame): + (WebKit::WebPageSerializerTest::webVectorContains): + (WebKit::TEST_F): + * tests/WebViewTest.cpp: + (WebKit::TEST_F): + (WebKit::WebViewTest::testAutoResize): + (WebKit::WebViewTest::testTextInputType): + +2012-07-09 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=90094 + + Reviewed by Adam Barth. + + This patch adds the WEBKIT_IMPLEMENTATION = 1 define to + WebKitUnitTests.gyp. To get it to compile correctly, some string + and URL code was refactored, and GURL types were replaced with KURL types. + + * WebKit.gypi: + * WebKitUnitTests.gyp: + * public/WebDOMMessageEvent.h: + (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): + * tests/AssociatedURLLoaderTest.cpp: + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::loadFrame): + * tests/FrameTestHelpers.h: + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/PopupMenuTest.cpp: + * tests/RunAllTests.cpp: + * tests/URLTestHelpers.cpp: Added. + (URLTestHelpers): + (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): + (WebKit::URLTestHelpers::registerMockedURLLoad): + * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. + (WebKit): + (URLTestHelpers): + (WebKit::URLTestHelpers::toKURL): + * tests/WebFrameTest.cpp: + * tests/WebPageNewSerializerTest.cpp: + * tests/WebPageSerializerTest.cpp: + * tests/WebViewTest.cpp: + +2012-07-09 Dana Jansens <danakj@chromium.org> + + [chromium] Decouple RenderPass drawing from CCRenderSurface + https://bugs.webkit.org/show_bug.cgi?id=90573 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + +2012-07-09 Adam Klein <adamk@chromium.org> + + Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver + https://bugs.webkit.org/show_bug.cgi?id=90810 + + Reviewed by Ojan Vafai. + + * src/WebKit.cpp: + +2012-07-09 Leandro Gracia Gil <leandrogracia@chromium.org> + + SurroundingText should not advance character iterators if they are at end. + https://bugs.webkit.org/show_bug.cgi?id=90560 + + Reviewed by Ryosuke Niwa. + + Moving the check for null visible positions to WebCore as it makes no + sense to be in a platform-specific code. + + * src/WebSurroundingText.cpp: + (WebKit::WebSurroundingText::initialize): + +2012-07-09 Dana Jansens <danakj@chromium.org> + + [chromium] Create render surfaces on main thread only for the current frame + https://bugs.webkit.org/show_bug.cgi?id=89793 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-07-02 Ryosuke Niwa <rniwa@webkit.org> + + Make HTMLCollection RefCounted + https://bugs.webkit.org/show_bug.cgi?id=90414 + + Reviewed by Sam Weinig. + + * src/WebPageSerializer.cpp: + (WebCore::retrieveResourcesForFrame): + * src/WebPageSerializerImpl.cpp: + (WebKit::WebPageSerializerImpl::collectTargetFrames): + +2012-07-09 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r122107. + http://trac.webkit.org/changeset/122107 + https://bugs.webkit.org/show_bug.cgi?id=90794 + + Build failure on Mac debug bots (Requested by falken_ on + #webkit). * features.gypi: + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): + * src/WebRuntimeFeatures.cpp: + +2012-07-09 Matt Falkenhagen <falken@chromium.org> + + Add ENABLE_DIALOG_ELEMENT and skeleton files + https://bugs.webkit.org/show_bug.cgi?id=90521 + + Reviewed by Kent Tamura. + + * features.gypi: + * public/WebRuntimeFeatures.h: + (WebRuntimeFeatures): + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enableDialogElement): + (WebKit): + (WebKit::WebRuntimeFeatures::isDialogElementEnabled): -2012-10-03 Jeff Timanus <twiz@chromium.org> +2012-07-09 MORITA Hajime <morrita@google.com> - [chromium] Expose settings value to conditionally enable pinch-zoom scaling in the Chromium compositor. The - flag defaults to disabled, so this change should be a no-op for scaling/scrolling behaviour. - https://bugs.webkit.org/show_bug.cgi?id=93292 + [Chromium] ContextFeaturesClient::isEnabled is slow + https://bugs.webkit.org/show_bug.cgi?id=90367 + + Reviewed by Kent Tamura. + + ContextFeaturesClientImpl::isEnabled touches a heavy part in chrome + where locks are acquired for each invocation. + + This change introduces a set of caches to avoid such slow calls. + The cache class ContextFeaturesCache is implemented as a + Supplement of ScriptExecutionContext because the flag bits + depend on the domain of each Document. + + * src/ContextFeaturesClientImpl.cpp: + (ContextFeaturesCache): Added. + (Entry): Added. + (WebKit::ContextFeaturesCache::Entry::Entry): + (WebKit::ContextFeaturesCache::Entry::isEnabled): + (WebKit::ContextFeaturesCache::Entry::set): + (WebKit::ContextFeaturesCache::Entry::needsRefresh): + (WebKit::ContextFeaturesCache::entryFor): + (WebKit): + (WebKit::ContextFeaturesCache::supplementName): + (WebKit::ContextFeaturesCache::from): + (WebKit::ContextFeaturesCache::refreshAgainst): + (WebKit::ContextFeaturesClientImpl::isEnabled): + (WebKit::ContextFeaturesClientImpl::urlDidChange): Added to invoke refrshAgainst. + (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): + * src/ContextFeaturesClientImpl.h: + (ContextFeaturesClientImpl): + +2012-07-09 Vsevolod Vlasov <vsevik@chromium.org> + + Unreviewed chromium inspector test fix. + + * src/js/Tests.js: + (.TestSuite.prototype.nonAnonymousUISourceCodes_): + +2012-07-05 Yoshifumi Inoue <yosin@chromium.org> + + Unreviewed Chromium gardening. Roll Chromium DEPS + + * DEPS: 145501 => 145569 + +2012-07-05 Yoshifumi Inoue <yosin@chromium.org> + + Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows. + https://bugs.webkit.org/show_bug.cgi?id=90651 + + * tests/WebAnimationTest.cpp: + (WebKit): + (WebKit::TEST): + +2012-07-05 Ian Vollick <vollick@chromium.org> + + [chromium] Create a WebKit::Web* wrapper for the cc animation classes + https://bugs.webkit.org/show_bug.cgi?id=90303 Reviewed by James Robinson. + * WebKit.gyp: + * WebKit.gypi: + * src/WebAnimation.cpp: Added. + (WebKit): + (WebKit::WebAnimation::iterations): + (WebKit::WebAnimation::setIterations): + (WebKit::WebAnimation::startTime): + (WebKit::WebAnimation::setStartTime): + (WebKit::WebAnimation::timeOffset): + (WebKit::WebAnimation::setTimeOffset): + (WebKit::WebAnimation::alternatesDirection): + (WebKit::WebAnimation::setAlternatesDirection): + (WebKit::WebAnimation::toCCActiveAnimation): + (WebKit::WebAnimation::initialize): + (WebKit::WebAnimation::destroy): + * src/WebAnimationCurveCommon.cpp: Added. + (WebKit): + (WebKit::createTimingFunction): + * src/WebAnimationCurveCommon.h: Added. + (WebCore): + (WebKit): + * src/WebFloatAnimationCurve.cpp: Added. + (WebKit): + (WebKit::WebFloatAnimationCurve::add): + (WebKit::WebFloatAnimationCurve::toCCAnimationCurve): + (WebKit::WebFloatAnimationCurve::initialize): + (WebKit::WebFloatAnimationCurve::destroy): + * src/WebTransformAnimationCurve.cpp: Added. + (WebKit): + (WebKit::WebTransformAnimationCurve::add): + (WebKit::WebTransformAnimationCurve::toCCAnimationCurve): + (WebKit::WebTransformAnimationCurve::initialize): + (WebKit::WebTransformAnimationCurve::destroy): + * tests/WebAnimationTest.cpp: Added. + * tests/WebFloatAnimationCurveTest.cpp: Added. + * tests/WebTransformAnimationCurveTest.cpp: Added. + +2012-07-05 Vincent Scheib <scheib@chromium.org> + + [Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent(). + https://bugs.webkit.org/show_bug.cgi?id=90391 + + WebViewImpl::handleInputEvent was keeping a pointer to an input event that would + later be accessed. When in pointer lock, that pointer was not being cleared. + Code modified to use TemporaryChange to automatically clear the pointer at all + method exit points. + + Reviewed by Abhishek Arya. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleInputEvent): + +2012-07-05 John Mellor <johnme@chromium.org> + + Text Autosizing: Add test framework and simple test. + https://bugs.webkit.org/show_bug.cgi?id=90561 + + ENABLE(TEXT_AUTOSIZING) is now on in Chromium (but disabled at runtime). + This allows it to be used in Layout Tests (and in future by Web + Inspector's mobile device emulation). + + Reviewed by Adam Barth. + + * features.gypi: + +2012-07-05 Oli Lan <olilan@chromium.org> + + [chromium] Add a method didChangeFormState to WebViewClient. + https://bugs.webkit.org/show_bug.cgi?id=90563 + + Reviewed by Adam Barth. + + This patch adds a new method didChangeFormState to WebViewClient, + and calls it from ChromeClientImpl::formStateDidChange with the changed node. + + This new method can be used for example by the Android port to update the browser's + IME when the state of the currently focused text node has changed. To facilitate this + usage, a focused() method has been added to WebNode. + + A new test has been added to WebViewTest. This test checks that didChangeFormState + is called when an input's value is changed, and also checks that WebNode::focused() returns + the correct value for the provided node, in both the focused and non-focused cases. + + * public/WebNode.h: + * public/WebViewClient.h: + (WebKit::WebViewClient::didChangeFormState): + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::formStateDidChange): + * src/WebNode.cpp: + (WebKit::WebNode::focused): + (WebKit): + * tests/WebViewTest.cpp: + (FormChangeWebViewClient): + (WebKit::FormChangeWebViewClient::didChangeFormState): + (WebKit::FormChangeWebViewClient::reset): + (WebKit::FormChangeWebViewClient::called): + (WebKit::FormChangeWebViewClient::focused): + (WebKit): + (WebKit::TEST_F): + * tests/data/input_field_set_value_while_focused.html: Added. + * tests/data/input_field_set_value_while_not_focused.html: Added. + +2012-07-04 Yoshifumi Inoue <yosin@chromium.org> + + Unreviewed, Chromium gardening. Roll Chromium DEPS. + + * DEPS: chromium_rev: 145322 => 145501 + +2012-07-04 Dana Jansens <danakj@chromium.org> + + [chromium] Respect memory needed for RenderSurfaces when reserving contents textures + https://bugs.webkit.org/show_bug.cgi?id=89901 + + Reviewed by Adrienne Walker. + + * tests/CCPrioritizedTextureTest.cpp: + (WTF::CCPrioritizedTextureTest::createManager): + (WTF::TEST_F): + (WTF): + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeTiledLayerChromium::setTexturePriorities): + (WebKitTests): + * tests/CCTiledLayerTestCommon.h: + (FakeTiledLayerChromium): + * tests/TiledLayerChromiumTest.cpp: + +2012-07-04 Dana Jansens <danakj@chromium.org> + + [chromium] Clear RenderSurfaces still when no idle paint will be done + https://bugs.webkit.org/show_bug.cgi?id=90553 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostTest.cpp: + (CCLayerTreeHostTestCompositeAndReadbackCleanup): + (WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::CCLayerTreeHostTestCompositeAndReadbackCleanup): + (WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::beginTest): + (WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::afterTest): + (WTF): + +2012-07-04 Dana Jansens <danakj@chromium.org> + + [chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests + https://bugs.webkit.org/show_bug.cgi?id=90556 + + Reviewed by Adrienne Walker. + + Currently many tests that run both single and threaded versions subclass + from CCLayerTreeHostTestThreadOnly just from copy/pasting. The class + only adds a runTestThreaded() which calls runTest(true). Many other + tests do run only in threaded mode call runTest(true) themselves, making + for an inconsistent mess. + + We remove CCLayerTreeHostTestThreadOnly class, so we don't have tests + inheriting it that are not thread-only. And now all tests that are + thread-only call runTest(true) consistently. + + * tests/CCLayerTreeHostTest.cpp: + (WTF::TEST_F): + +2012-07-04 John Mellor <johnme@chromium.org> + + Text Autosizing: Add compile flag and runtime setting + https://bugs.webkit.org/show_bug.cgi?id=87394 + + This patch renames Font Boosting to Text Autosizing and adds compile guards around the runtime setting. + + Reviewed by Adam Barth. + + * features.gypi: * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setTextAutosizingEnabled): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-07-04 Ian Vollick <vollick@chromium.org> + + [chromium] Correctly reject accelerated animations with certain rotations. + https://bugs.webkit.org/show_bug.cgi?id=89768 + + Reviewed by James Robinson. + + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::TEST_F): + (WebKitTests): + +2012-07-03 Alex Sakhartchouk <alexst@chromium.org> + + [chromium] Avoid calling getUniformLocation??() in the compositor startup + https://bugs.webkit.org/show_bug.cgi?id=90217 + + Reviewed by Adrienne Walker. + + Fixing the build error. + + * tests/TextureCopierTest.cpp: + +2012-07-03 Erik Arvidsson <arv@chromium.org> + + [V8] Remove enableFasterDOMStoreAccess which is never used + https://bugs.webkit.org/show_bug.cgi?id=90489 + + Reviewed by Adam Barth. + + * src/WebScriptController.cpp: + (WebKit::WebScriptController::enableV8SingleThreadMode): + +2012-07-03 Tony Chang <tony@chromium.org> + + [chromium] Unreviewed, update .gitignore to handle VS2010 files. + + * .gitignore: + +2012-07-03 Tony Chang <tony@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-03 Charles Wei <charles.wei@torchmobile.com.cn> + + IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath + https://bugs.webkit.org/show_bug.cgi?id=88338 + + Reviewed by David Levin. + + * src/WebSharedWorkerImpl.cpp: + (WebKit::WebSharedWorkerImpl::startWorkerContext): + * src/WebWorkerClientImpl.cpp: + (WebKit::WebWorkerClientImpl::startWorkerContext): + +2012-07-02 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-07-02 Leandro Gracia Gil <leandrogracia@chromium.org> + + [Chromium] Implement a Layout Test for editing/SurroundingText + https://bugs.webkit.org/show_bug.cgi?id=82461 + + Reviewed by Ryosuke Niwa. + + Allow passing nodes as arguments for layout test methods. + + * public/WebBindings.h: + (WebBindings): + * src/WebBindings.cpp: + (WebKit::getNodeImpl): + (WebKit): + (WebKit::WebBindings::getNode): + +2012-07-02 Benjamin Poulain <bpoulain@apple.com> + + Do not do any logging initialization when logging is disabled + https://bugs.webkit.org/show_bug.cgi?id=90228 + + Reviewed by Simon Fraser. + + * src/WebKit.cpp: + (WebKit::enableLogChannel): + +2012-07-01 Keishi Hattori <keishi@webkit.org> + + Unreviewed, rolling out r121650. + http://trac.webkit.org/changeset/121650 + https://bugs.webkit.org/show_bug.cgi?id=90303 + + runhooks is failing for chromium win bots and + WebAnimationTest.DefaultSettings is crashing + + * WebKit.gyp: + * WebKit.gypi: + * src/WebAnimation.cpp: Removed. + * src/WebAnimationCurveCommon.cpp: Removed. + * src/WebAnimationCurveCommon.h: Removed. + * src/WebFloatAnimationCurve.cpp: Removed. + * src/WebTransformAnimationCurve.cpp: Removed. + * tests/WebAnimationTest.cpp: Removed. + * tests/WebFloatAnimationCurveTest.cpp: Removed. + * tests/WebTransformAnimationCurveTest.cpp: Removed. + +2012-07-01 Ian Vollick <vollick@chromium.org> + + [chromium] Create a WebKit::Web* wrapper for the cc animation classes + https://bugs.webkit.org/show_bug.cgi?id=90303 + + Reviewed by James Robinson. + + * WebKit.gyp: + * WebKit.gypi: + * src/WebAnimation.cpp: Added. + (WebKit): + (WebKit::WebAnimation::iterations): + (WebKit::WebAnimation::setIterations): + (WebKit::WebAnimation::startTime): + (WebKit::WebAnimation::setStartTime): + (WebKit::WebAnimation::timeOffset): + (WebKit::WebAnimation::setTimeOffset): + (WebKit::WebAnimation::alternatesDirection): + (WebKit::WebAnimation::setAlternatesDirection): + (WebKit::WebAnimation::toCCActiveAnimation): + (WebKit::WebAnimation::initialize): + (WebKit::WebAnimation::destroy): + * src/WebAnimationCurveCommon.cpp: Added. + (WebKit): + (WebKit::createTimingFunction): + * src/WebAnimationCurveCommon.h: Added. + (WebCore): + (WebKit): + * src/WebFloatAnimationCurve.cpp: Added. + (WebKit): + (WebKit::WebFloatAnimationCurve::add): + (WebKit::WebFloatAnimationCurve::toCCAnimationCurve): + (WebKit::WebFloatAnimationCurve::initialize): + (WebKit::WebFloatAnimationCurve::destroy): + * src/WebTransformAnimationCurve.cpp: Added. + (WebKit): + (WebKit::WebTransformAnimationCurve::add): + (WebKit::WebTransformAnimationCurve::toCCAnimationCurve): + (WebKit::WebTransformAnimationCurve::initialize): + (WebKit::WebTransformAnimationCurve::destroy): + * tests/WebAnimationTest.cpp: Added. + * tests/WebFloatAnimationCurveTest.cpp: Added. + * tests/WebTransformAnimationCurveTest.cpp: Added. + +2012-06-30 Ian Vollick <vollick@chromium.org> + + [chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space. + https://bugs.webkit.org/show_bug.cgi?id=90092 + + The CanvasLayerTextureUpdater currently receives its opaque rects in + layer space, but is expected to return them in content space and does + not convert them. This patch adds this conversion. To avoid numerical + errors, this patch also switches to using float rects to store opaque + rects where appropriate. + + Reviewed by Adrienne Walker. + + * WebKit.gypi: + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::paintContents): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::TestOpacityChangeLayerDelegate::paintContents): + (WTF::MockContentLayerDelegate::paintContents): + * tests/ContentLayerChromiumTest.cpp: Added. + (WebKit): + (OpaqueRectDrawingGraphicsContextPainter): + (WebKit::OpaqueRectDrawingGraphicsContextPainter::OpaqueRectDrawingGraphicsContextPainter): + (WebKit::OpaqueRectDrawingGraphicsContextPainter::~OpaqueRectDrawingGraphicsContextPainter): + (MockContentLayerDelegate): + (WebKit::MockContentLayerDelegate::MockContentLayerDelegate): + (WebKit::TEST): + * tests/LayerChromiumTest.cpp: + * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: + (WebCore::TEST_F): + * tests/TiledLayerChromiumTest.cpp: + * tests/WebLayerTest.cpp: + +2012-06-29 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Keep direction on IDBCursor to avoid calls to back end + https://bugs.webkit.org/show_bug.cgi?id=90114 + + Stop plumbing IDBCursorBackendInterface::direction() through API. + + Reviewed by Tony Chang. + + * src/IDBCursorBackendProxy.cpp: + * src/IDBCursorBackendProxy.h: + (IDBCursorBackendProxy): + * src/WebIDBCursorImpl.cpp: + * src/WebIDBCursorImpl.h: + (WebIDBCursorImpl): + +2012-06-29 Adam Barth <abarth@webkit.org> + + [Chromium] WebFontRendering.cpp requires some OS(ANDROID) ifdefs to build downstream + https://bugs.webkit.org/show_bug.cgi?id=90292 + + Reviewed by Nate Chapin. + + These ifdefs are required to build this file downstream. There's some + sublte difference between how the OS flags are set upstream and + downstream. This is on our list of issues to resolve, but in the + meantime, this patch makes these files identical upstream and + downstream to reduce noise in the upstreaming queue. + + * src/linux/WebFontRendering.cpp: + (WebKit::WebFontRendering::setSubpixelPositioning): + +2012-06-29 Eric Penner <epenner@google.com> + + [chromium] Adding PrioritizedTexture and replacing ContentsTextureManager + https://bugs.webkit.org/show_bug.cgi?id=84308 + + Reviewed by Adrienne Walker. + + * WebKit.gypi: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread): + * tests/CCPrioritizedTextureTest.cpp: Added. + (WTF): + (CCPrioritizedTextureTest): + (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): + (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest): + (WTF::CCPrioritizedTextureTest::texturesMemorySize): + (WTF::CCPrioritizedTextureTest::createManager): + (WTF::CCPrioritizedTextureTest::validateTexture): + (WTF::CCPrioritizedTextureTest::allocator): + (WTF::TEST_F): + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::Texture::Texture): + (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): + (WebKitTests::FakeLayerTextureUpdater::createTexture): + (WebKitTests::FakeTiledLayerChromium::FakeTiledLayerChromium): + (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds): + * tests/CCTiledLayerTestCommon.h: + (Texture): + (FakeLayerTextureUpdater): + (FakeTiledLayerChromium): + (FakeTiledLayerWithScaledBounds): + * tests/TiledLayerChromiumTest.cpp: + +2012-06-29 Ian Vollick <vollick@chromium.org> + + [chromium] Roll chromium rev to 144906 + https://bugs.webkit.org/show_bug.cgi?id=90278 + + Unreviewed. Deps roll. + + * DEPS: + +2012-06-29 Alexander Pavlov <apavlov@chromium.org> + + Web Inspector: [Device Metrics] "Fit window" option inhibits adjusting the page zoom factor + https://bugs.webkit.org/show_bug.cgi?id=90187 + + Reviewed by Vsevolod Vlasov. + + This change fixes the stale zoom factor, which does not get updated upon browser window resize in the "Fit window" mode. + The expected test results have little to do with actual dimensions of the test page in Chrome on a real mobile device, + since Chrome on the mobile uses a different zooming technique (pageScaleFactor-based viewport using layout width + rather than plain pageZoomFactor) and font boosting, which has not been upstreamed yet. + + * src/WebDevToolsAgentImpl.cpp: + (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): + (WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor): + +2012-06-29 Konrad Piascik <kpiascik@rim.com> + + Don't hardcode target dpi of 160 (it should be 96 on desktop) + https://bugs.webkit.org/show_bug.cgi?id=88114 + + Reviewed by Adam Barth. + + Updated the call to computeViewportAttributes. + + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): + +2012-06-29 Amy Ousterhout <aousterh@chromium.org> + + Deleting unused function in WebDeviceOrientation + https://bugs.webkit.org/show_bug.cgi?id=90185 + + Reviewed by Adam Barth. + + Deleting the unused copy assignment function in WebDeviceOrientation. + + * public/WebDeviceOrientation.h: + (WebDeviceOrientation): + * src/WebDeviceOrientation.cpp: + +2012-06-29 Yoshifumi Inoue <yosin@chromium.org> + + [Platform] Implement Date Time format parser + https://bugs.webkit.org/show_bug.cgi?id=89963 + + Reviewed by Kent Tamura. + + This patch adds an unit test for date time format parser if + ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is true. + + * tests/DateTimeFormatTest.cpp: Added. + (DateTimeFormatTest): + (Token): + (DateTimeFormatTest::Token::Token): + (DateTimeFormatTest::Token::operator==): + (DateTimeFormatTest::Token::toString): + (Tokens): + (DateTimeFormatTest::Tokens::Tokens): + (DateTimeFormatTest::Tokens::operator==): + (DateTimeFormatTest::Tokens::toString): + (DateTimeFormatTest::parse): + (DateTimeFormatTest::single): + (TokenHandler): + (DateTimeFormatTest::TokenHandler::~TokenHandler): + (DateTimeFormatTest::TokenHandler::fieldType): + (DateTimeFormatTest::TokenHandler::tokens): + (DateTimeFormatTest::TokenHandler::visitField): + (DateTimeFormatTest::TokenHandler::visitLiteral): + (operator<<): + (TEST_F): + +2012-06-28 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Implement IDBTransaction internal active flag + https://bugs.webkit.org/show_bug.cgi?id=89379 + + Reviewed by Tony Chang. + + To match the IDB spec, transactions that have had no requests + filed against them should commit, not abort. This requires plumbing + through the commit() call from front-end to back-end. + + * src/IDBTransactionBackendProxy.cpp: + (WebKit::IDBTransactionBackendProxy::commit): + (WebKit): + * src/IDBTransactionBackendProxy.h: + (IDBTransactionBackendProxy): + * src/WebIDBTransactionImpl.cpp: + (WebKit::WebIDBTransactionImpl::commit): + (WebKit): + * src/WebIDBTransactionImpl.h: + +2012-06-28 Adrienne Walker <enne@google.com> + + [chromium] Split WebScrollbar into WebPluginScrollbar and WebScrollbar + https://bugs.webkit.org/show_bug.cgi?id=90117 + + Reviewed by James Robinson. + + Convert WebScrollbar/WebScrollbarClient/WebScrollbarImpl to be + WebPluginScrollbar, WebPluginScrollbarClient, and + WebPluginScrollbarImpl. Modify ScrollbarGroup + to use this instead. + + WebScrollbar is now the base interface for a pre-existing scrollbar + that is accessed in a const manner. It also provides all of the common + WebKit ScrollTypes.h enums. WebPluginScrollbar is now a scrollbar that + has been externally created and is externally modified in terms of its + position, invalidation, and painting. + + This is a pre-refactoring for adding Web versions of ScrollbarTheme + into the Platform directory which will operate on WebScrollbar, but + that don't need all of what WebPluginScrollbar provides. + + As WebScrollbar is moved to Platform, WebKit.gyp now must depend on + Platform as well. + + * WebKit.gyp: + * public/WebPluginScrollbar.h: + (WebKit): + (WebPluginScrollbar): + (WebKit::WebPluginScrollbar::~WebPluginScrollbar): + * public/WebPluginScrollbarClient.h: + (WebKit): + (WebPluginScrollbarClient): + * public/WebScrollbar.h: Removed. + * public/WebScrollbarClient.h: Removed. + * src/AssertMatchingEnums.cpp: + * src/ScrollbarGroup.cpp: + (WebKit::ScrollbarGroup::scrollbarCreated): + (WebKit::ScrollbarGroup::scrollbarDestroyed): + (WebKit::ScrollbarGroup::scrollSize): + (WebKit::ScrollbarGroup::scrollPosition): + (WebKit::ScrollbarGroup::contentsSize): + * src/ScrollbarGroup.h: + (WebKit): + (ScrollbarGroup): + * src/WebPluginScrollbarImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.cpp. + (WebKit): + (WebKit::WebPluginScrollbar::createForPlugin): + (WebKit::WebPluginScrollbar::defaultThickness): + (WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl): + (WebKit::WebPluginScrollbarImpl::~WebPluginScrollbarImpl): + (WebKit::WebPluginScrollbarImpl::setScrollOffset): + (WebKit::WebPluginScrollbarImpl::invalidateScrollbarRect): + (WebKit::WebPluginScrollbarImpl::getTickmarks): + (WebKit::WebPluginScrollbarImpl::convertFromContainingViewToScrollbar): + (WebKit::WebPluginScrollbarImpl::scrollbarStyleChanged): + (WebKit::WebPluginScrollbarImpl::isOverlay): + (WebKit::WebPluginScrollbarImpl::value): + (WebKit::WebPluginScrollbarImpl::setLocation): + (WebKit::WebPluginScrollbarImpl::setValue): + (WebKit::WebPluginScrollbarImpl::setDocumentSize): + (WebKit::WebPluginScrollbarImpl::scroll): + (WebKit::WebPluginScrollbarImpl::paint): + (WebKit::WebPluginScrollbarImpl::handleInputEvent): + (WebKit::WebPluginScrollbarImpl::onMouseDown): + (WebKit::WebPluginScrollbarImpl::onMouseUp): + (WebKit::WebPluginScrollbarImpl::onMouseMove): + (WebKit::WebPluginScrollbarImpl::onMouseLeave): + (WebKit::WebPluginScrollbarImpl::onMouseWheel): + (WebKit::WebPluginScrollbarImpl::onKeyDown): + * src/WebPluginScrollbarImpl.h: Added. + (WebCore): + (WebKit): + (WebPluginScrollbarImpl): + (WebKit::WebPluginScrollbarImpl::scrollOffset): + (WebKit::WebPluginScrollbarImpl::scrollbar): + * src/WebScrollbarImpl.h: Removed. + +2012-06-28 Adam Barth <abarth@webkit.org> + + [Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page + https://bugs.webkit.org/show_bug.cgi?id=90210 + + Reviewed by Dimitri Glazkov. + + This patch introduces a function that asks the embedder to analyze the + region around a hit test result for interesting content, like phone + numbers, email addresses, or physical addresses. The embedder then + responds with the "most interesting" content, together with an intent + URL for enacting the intent embodied by that content. + + This function will be used in a subsequent patch to detect content + after touch events. + + * WebKit.gyp: + * public/WebContentDetectionResult.h: Added. + (WebKit): + (WebContentDetectionResult): + (WebKit::WebContentDetectionResult::WebContentDetectionResult): + (WebKit::WebContentDetectionResult::isValid): + (WebKit::WebContentDetectionResult::range): + (WebKit::WebContentDetectionResult::string): + (WebKit::WebContentDetectionResult::intent): + * public/WebViewClient.h: + (WebViewClient): + (WebKit::WebViewClient::detechContentAround): + +2012-06-28 Alec Flett <alecflett@chromium.org> + + IndexedDB: Hook up render-side key ASSERTing for get() + https://bugs.webkit.org/show_bug.cgi?id=90001 + + Reviewed by Tony Chang. + + Hook up Chromium WebKit API to new onSuccess handler. + + * src/WebIDBCallbacksImpl.cpp: + (WebKit::WebIDBCallbacksImpl::onSuccess): + * tests/IDBAbortOnCorruptTest.cpp: + (WebCore::MockIDBCallbacks::onSuccess): + * tests/IDBDatabaseBackendTest.cpp: + +2012-06-28 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-28 Alpha Lam <hclam@chromium.org> + + Unreviewed, rolling out r121463. + http://trac.webkit.org/changeset/121463 + https://bugs.webkit.org/show_bug.cgi?id=90094 + + Broke Windows build. + + * WebKit.gypi: + * WebKitUnitTests.gyp: + * public/WebDOMMessageEvent.h: + * tests/AssociatedURLLoaderTest.cpp: + (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): + (WebKit::AssociatedURLLoaderTest::SetUp): + (WebKit::AssociatedURLLoaderTest::CheckMethodFails): + (WebKit::AssociatedURLLoaderTest::CheckHeaderFails): + (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders): + (WebKit::TEST_F): + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::registerMockedURLLoad): + (FrameTestHelpers): + (WebKit::FrameTestHelpers::loadFrame): + * tests/FrameTestHelpers.h: + (FrameTestHelpers): + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/PopupMenuTest.cpp: + (WebKit::SelectPopupMenuTest::registerMockedURLLoad): + (WebKit::SelectPopupMenuTest::loadFrame): + (WebKit::TEST_F): + * tests/RunAllTests.cpp: + * tests/URLTestHelpers.cpp: Removed. + * tests/URLTestHelpers.h: Removed. + * tests/WebFrameTest.cpp: + (WebKit::WebFrameTest::registerMockedHttpURLLoad): + (WebKit::WebFrameTest::registerMockedChromeURLLoad): + (WebKit::TEST_F): + * tests/WebPageNewSerializerTest.cpp: + (WebKit::WebPageNewSerializeTest::registerMockedURLLoad): + (WebPageNewSerializeTest): + (WebKit::WebPageNewSerializeTest::setUpCSSTestPage): + (WebKit::WebPageNewSerializeTest::loadURLInTopFrame): + (WebKit::WebPageNewSerializeTest::resourceVectorContains): + (WebKit::TEST_F): + * tests/WebPageSerializerTest.cpp: + (WebKit::WebPageSerializerTest::registerMockedURLLoad): + (WebKit::WebPageSerializerTest::loadURLInTopFrame): + (WebKit::WebPageSerializerTest::webVectorContains): + (WebKit::TEST_F): + * tests/WebViewTest.cpp: + (WebKit::TEST_F): + (WebKit::WebViewTest::testAutoResize): + (WebKit::WebViewTest::testTextInputType): + +2012-06-28 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=90094 + + Reviewed by Adam Barth. + + This patch adds the WEBKIT_IMPLEMENTATION = 1 define to + WebKitUnitTests.gyp. To get it to compile correctly, some string + and URL code was refactored and fixed. + + * WebKit.gypi: + * WebKitUnitTests.gyp: + * public/WebDOMMessageEvent.h: + (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): + * tests/AssociatedURLLoaderTest.cpp: + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::loadFrame): + * tests/FrameTestHelpers.h: + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/PopupMenuTest.cpp: + * tests/RunAllTests.cpp: + * tests/URLTestHelpers.cpp: Added. + (URLTestHelpers): + (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): + (WebKit::URLTestHelpers::registerMockedURLLoad): + * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. + (WebKit): + (URLTestHelpers): + (WebKit::URLTestHelpers::toKURL): + * tests/WebFrameTest.cpp: + * tests/WebPageNewSerializerTest.cpp: + * tests/WebPageSerializerTest.cpp: + * tests/WebViewTest.cpp: + +2012-06-28 Oli Lan <olilan@chromium.org> + + [chromium] Change WebViewImpl::textInputInfo to use root editable element. + https://bugs.webkit.org/show_bug.cgi?id=90179 + + Reviewed by Adam Barth. + + WebViewImpl::textInputInfo currently returns text value and offsets relative to the + focused node. For contenteditable nodes, this may not give the expected result. + + This patch changes the method to return value and offsets for the root editable element. + This also allows the implementation to be simplified somewhat. + + This also ensures that the offsets returned will use the same basis as the recently added + method Editor::setSelectionOffsets (and WebViewImpl::setEditableSelectionOffsets). + + Testing for textInputInfo has been added to WebViewTest. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::textInputInfo): + * tests/WebViewTest.cpp: + (WebKit::TEST_F): + +2012-06-28 James Robinson <jamesr@chromium.org> + + [chromium] Should schedule a commit when dropping contents textures + https://bugs.webkit.org/show_bug.cgi?id=90031 + + Reviewed by Adrienne Walker. + + Adds a somewhat vacuous test unit test for committing when releasing textures. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-27 Dana Jansens <danakj@chromium.org> + + [chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and CanvasLayerTextureUpdater + https://bugs.webkit.org/show_bug.cgi?id=90103 + + Reviewed by Adrienne Walker. + + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::prepareToUpdate): + * tests/CCTiledLayerTestCommon.h: + (FakeTiledLayerChromium): + * tests/TiledLayerChromiumTest.cpp: + +2012-06-28 Dan Alcantara <dfalcantara@chromium.org> + + [chromium] Introduce way to reload a page using the original request URL + https://bugs.webkit.org/show_bug.cgi?id=89788 + + Reviewed by Adam Barth. + + Adds a new reload method for cases where we need to override the URL + when reloading a page. This is needed for situations where a server + redirects navigation based on information that may have changed since + the last time the page was loaded. + + User agents, for example, can cause a server to redirect to the mobile + version of a page. Changing to the desktop version by switching user agents + requires loading a URL from before the redirect occurred. + + Also adds a unit test to confirm that scroll position and page scale are + saved when the reload occurs. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::reloadWithGivenURL): + (WebKit): + * src/WebFrameImpl.h: + (WebFrameImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setClearPageScaleFactorOnLoad): + (WebKit): + (WebKit::WebViewImpl::didCommitLoad): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-06-28 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r121395. + http://trac.webkit.org/changeset/121395 + https://bugs.webkit.org/show_bug.cgi?id=90143 + + Patch causes crashes in fast/workers/worker-context-gc.html + (Requested by zdobersek on #webkit). + + * src/WebSharedWorkerImpl.cpp: + (WebKit::WebSharedWorkerImpl::startWorkerContext): + * src/WebWorkerClientImpl.cpp: + (WebKit::WebWorkerClientImpl::startWorkerContext): + +2012-06-28 Yoshifumi Inoue <yosin@chromium.org> + + [Platform] Implement functions for localized time format information + https://bugs.webkit.org/show_bug.cgi?id=89965 + + Reviewed by Kent Tamura. + + This patch adds new test LocalizedDateICUTest if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) + is true. + + * WebKit.gypi: + * tests/LocalizedDateICUTest.cpp: Added. + (LocalizedDateICUTest): + (Labels): + (LocalizedDateICUTest::Labels::Labels): + (LocalizedDateICUTest::Labels::operator==): + (LocalizedDateICUTest::Labels::toString): + (LocalizedDateICUTest::labels): + (LocalizedDateICUTest::localizedDateFormatText): + (LocalizedDateICUTest::localizedShortDateFormatText): + (LocalizedDateICUTest::timeAMPMLabels): + (operator<<): + (TEST_F): + +2012-06-27 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r121405. + http://trac.webkit.org/changeset/121405 + https://bugs.webkit.org/show_bug.cgi?id=90135 + + broke windows build (Requested by shawnsingh_ on #webkit). + + * WebKit.gypi: + * WebKitUnitTests.gyp: + * public/WebDOMMessageEvent.h: + * tests/AssociatedURLLoaderTest.cpp: + (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): + (WebKit::AssociatedURLLoaderTest::SetUp): + (WebKit::AssociatedURLLoaderTest::CheckMethodFails): + (WebKit::AssociatedURLLoaderTest::CheckHeaderFails): + (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders): + (WebKit::TEST_F): + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::registerMockedURLLoad): + (FrameTestHelpers): + (WebKit::FrameTestHelpers::loadFrame): + * tests/FrameTestHelpers.h: + (FrameTestHelpers): + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/PopupMenuTest.cpp: + (WebKit::SelectPopupMenuTest::registerMockedURLLoad): + (WebKit::SelectPopupMenuTest::loadFrame): + * tests/RunAllTests.cpp: + * tests/URLTestHelpers.cpp: Removed. + * tests/URLTestHelpers.h: Removed. + * tests/WebFrameTest.cpp: + (WebKit::WebFrameTest::registerMockedHttpURLLoad): + (WebKit::WebFrameTest::registerMockedChromeURLLoad): + (WebKit::TEST_F): + * tests/WebPageNewSerializerTest.cpp: + (WebKit::WebPageNewSerializeTest::registerMockedURLLoad): + (WebPageNewSerializeTest): + (WebKit::WebPageNewSerializeTest::setUpCSSTestPage): + (WebKit::WebPageNewSerializeTest::loadURLInTopFrame): + (WebKit::WebPageNewSerializeTest::resourceVectorContains): + (WebKit::TEST_F): + * tests/WebPageSerializerTest.cpp: + (WebKit::WebPageSerializerTest::registerMockedURLLoad): + (WebKit::WebPageSerializerTest::loadURLInTopFrame): + (WebKit::WebPageSerializerTest::webVectorContains): + (WebKit::TEST_F): + * tests/WebViewTest.cpp: + (WebKit::TEST_F): + (WebKit::WebViewTest::testAutoResize): + (WebKit::WebViewTest::testTextInputType): + +2012-06-27 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=90094 + + Reviewed by James Robinson. + + This patch adds the WEBKIT_IMPLEMENTATION = 1 define to + WebKitUnitTests.gyp. To get it to compile correctly, some string + and URL code was refactored and fixed. + + * WebKit.gypi: + * WebKitUnitTests.gyp: + * public/WebDOMMessageEvent.h: + (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): + * tests/AssociatedURLLoaderTest.cpp: + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::loadFrame): + * tests/FrameTestHelpers.h: + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/PopupMenuTest.cpp: + * tests/RunAllTests.cpp: + * tests/URLTestHelpers.cpp: Added. + (URLTestHelpers): + (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): + (WebKit::URLTestHelpers::registerMockedURLLoad): + * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. + (WebKit): + (URLTestHelpers): + (WebKit::URLTestHelpers::toKURL): + * tests/WebFrameTest.cpp: + * tests/WebPageNewSerializerTest.cpp: + * tests/WebPageSerializerTest.cpp: + * tests/WebViewTest.cpp: + +2012-06-27 Yoshifumi Inoue <yosin@chromium.org> + + [Platform] Implement localizedDecimalSeparator function + https://bugs.webkit.org/show_bug.cgi?id=90036 + + Reviewed by Kent Tamura. + + This patch adds test case for localizedDecimalSeparator(). + + * tests/LocalizedNumberICUTest.cpp: + (testDecimalSeparator): + (TEST): + +2012-06-27 Yusuke Sato <yusukes@chromium.org> + + [chromium] Improve keyboardEvent() so a web page could receive a DOM3 spec compliant keyboard event. + https://bugs.webkit.org/show_bug.cgi?id=89637 + + Reviewed by Tony Chang. + + This is a Gtk port of http://crrev.com/142209. + + Normalizes event->state to make it Windows/Mac compatible. Since the + way of setting modifier mask on X is very different than Windows/Mac + as shown in http://crbug.com/127142#c8, the normalization is necessary. + + * src/gtk/WebInputEventFactory.cpp: + (WebKit): + (WebKit::normalizeEventState): + (WebKit::WebInputEventFactory::keyboardEvent): + +2012-06-27 James Robinson <jamesr@chromium.org> + + [chromium] Use SkColor in compositor internals + https://bugs.webkit.org/show_bug.cgi?id=90108 + + Reviewed by Adrienne Walker. + * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setBackgroundColor): + * tests/CCLayerImplTest.cpp: + (WebCore::TEST): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCSolidColorLayerImplTest.cpp: + (CCLayerTestCommon::TEST): + * tests/LayerChromiumTest.cpp: + +2012-06-27 Charles Wei <charles.wei@torchmobile.com.cn> + + IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath + https://bugs.webkit.org/show_bug.cgi?id=88338 + + Reviewed by David Levin. + + * src/WebSharedWorkerImpl.cpp: + (WebKit::WebSharedWorkerImpl::startWorkerContext): + * src/WebWorkerClientImpl.cpp: + (WebKit::WebWorkerClientImpl::startWorkerContext): + +2012-06-27 Joshua Bell <jsbell@chromium.org> + + [Chromium] IndexedDB: Expose WebIDBTransaction::commit() method in public API + https://bugs.webkit.org/show_bug.cgi?id=90089 + + Reviewed by James Robinson. + + Prep work for http://webkit.org/b/89379 which requires empty transactions to + trigger a commit from the front-end. + + * public/WebIDBTransaction.h: + (WebKit::WebIDBTransaction::commit): + +2012-06-27 Josh Horwich <jhorwich@chromium.org> + + [chromium] Expose device scale factor in WebPluginContainer + https://bugs.webkit.org/show_bug.cgi?id=87874 + + Reviewed by Adam Barth. + + * public/WebPluginContainer.h: + (WebPluginContainer): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::deviceScaleFactor): + (WebKit): + (WebKit::WebPluginContainerImpl::pageScaleFactor): + (WebKit::WebPluginContainerImpl::pageZoomFactor): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + +2012-06-27 Robert Kroeger <rjkroege@chromium.org> + + [chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor + https://bugs.webkit.org/show_bug.cgi?id=90006 + + The assert in WebViewImpl::setDeviceScaleFactor should test for non-scaling + after we have set both m_DeviceScaleInCompositor and page()->deviceScaleFactor() + instead of in between. + + Reviewed by James Robinson. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setDeviceScaleFactor): + +2012-06-26 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-26 James Robinson <jamesr@chromium.org> + + [chromium] Remove WebView::graphicsContext3D getter + https://bugs.webkit.org/show_bug.cgi?id=89916 + + Reviewed by Adrienne Walker. + + Removes WebView::graphicsContext3D getter. This getter was used to access the compositor's context, which is an + inherently dangerous operation since the compositor context may not be safe to use on the main thread and has + somewhat complicated creation / recreation semantics. A shared context is exposed + (WebView::sharedGraphicsContext3D) for callers who may want access to a context in a share group with the + compositor. + + * public/WebView.h: + (WebView): + * src/WebLayerTreeView.cpp: + * src/WebViewImpl.cpp: + * src/WebViewImpl.h: + (WebViewImpl): + +2012-06-26 Peter Beverloo <peter@chromium.org> + + [Chromium] Decrease the number of conditional blocks in features.gypi + https://bugs.webkit.org/show_bug.cgi?id=90013 + + Reviewed by Adam Barth. + + Consolidate two Android-specific and accelerated-compositing-specific + conditional blocks into other blocks which serve an identical purpose. + + * features.gypi: + +2012-06-26 Dave Tu <dtu@chromium.org> + + [chromium] Expose rendering statistics to WebWidget. + https://bugs.webkit.org/show_bug.cgi?id=88268 + + Reviewed by James Robinson. + + The WebKit side of a basic framework for exposing rendering statistics + to Chromium's --enable-benchmarking extension. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::renderingStatistics): + (WebKit): + +2012-06-25 James Robinson <jamesr@chromium.org> + + [chromium] Add WebLayer API for scrolling + https://bugs.webkit.org/show_bug.cgi?id=89913 + + Reviewed by Adrienne Walker. + + Use WebScrollableLayer type in NonCompositedContentHost. + + * WebKit.gyp: + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::setScrollLayer): + (WebKit::reserveScrollbarLayers): + (WebKit::NonCompositedContentHost::setViewport): + (WebKit::NonCompositedContentHost::haveScrollLayer): + (WebKit): + (WebKit::NonCompositedContentHost::scrollLayer): + * src/NonCompositedContentHost.h: + (WebCore): + * src/WebContentLayer.cpp: + (WebKit::WebContentLayer::WebContentLayer): + * src/WebLayer.cpp: + (WebKit::WebLayer::numberOfChildren): + (WebKit): + (WebKit::WebLayer::childAt): + (WebKit::WebLayer::setAlwaysReserveTextures): + * src/WebScrollableLayer.cpp: + (WebKit): + (WebKit::WebScrollableLayer::setScrollPosition): + (WebKit::WebScrollableLayer::setScrollable): + (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): + (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): + +2012-06-26 Ian Vollick <vollick@chromium.org> + + [chromium] The single thread proxy should not automatically tick new animations. + https://bugs.webkit.org/show_bug.cgi?id=89996 + + Reviewed by James Robinson. + + * WebKit.gypi: + * tests/CCSingleThreadProxyTest.cpp: Removed. + +2012-06-26 Ian Vollick <vollick@chromium.org> + + [chromium] Layer chromium should need a redraw after getting its first non-empty bounds. + https://bugs.webkit.org/show_bug.cgi?id=89784 + + Reviewed by James Robinson. + + Previously, we'd only set needs redraw if the old bounds were zero, + and the new bounds were non-zero, but we should actually have + checked that the old bounds were non-empty. + + * tests/LayerChromiumTest.cpp: + +2012-06-26 James Robinson <jamesr@chromium.org> + + [chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium + https://bugs.webkit.org/show_bug.cgi?id=89933 + + Reviewed by Kenneth Russell. + + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + +2012-06-26 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements + https://bugs.webkit.org/show_bug.cgi?id=89931 + + Reviewed by James Robinson. + + WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of + #ifdef or #if have different behavior. There are some places in + the code that use "#ifdef WEBKIT_IMLPEMENTATION", but they should + actually be "#if WEBKIT_IMPLEMENTATION". This patch fixes those + #ifdef statements. + + * public/WebTextRun.h: + (WebTextRun): + * public/linux/WebFontRenderStyle.h: + +2012-06-26 Jun Mukai <mukai@chromium.org> + + Allow using <input type="color"> UI in ChromeOS. + https://bugs.webkit.org/show_bug.cgi?id=89944 + + Reviewed by Kent Tamura. + + http://crrev.com/144111 adds the UI of <input type="color"> for + ChromeOS, so now we can set its flag too. + + * features.gypi: + +2012-06-25 Ryosuke Niwa <rniwa@webkit.org> + + Get rid of firstItem and nextItem from HTMLCollection + https://bugs.webkit.org/show_bug.cgi?id=89923 + + Reviewed by Andreas Kling. + + Re-implement WebNodeCollection::firstItem() and WebNodeCollection::nextItem() in WebKit code + because we got rid of it from WebCore implementation. + + This is an extremely poor API and we shouldn't be exposing it in the future. + + * public/WebNodeCollection.h: + (WebKit::WebNodeCollection::WebNodeCollection): + (WebNodeCollection): + * src/WebNodeCollection.cpp: + (WebKit::WebNodeCollection::nextItem): + (WebKit::WebNodeCollection::firstItem): + * src/WebPageSerializerImpl.cpp: + (WebKit::WebPageSerializerImpl::collectTargetFrames): + +2012-06-25 Luke Macpherson <macpherson@chromium.org> + + Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). + https://bugs.webkit.org/show_bug.cgi?id=89542 + + Reviewed by Dimitri Glazkov. + + * features.gypi: + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-06-25 Adrienne Walker <enne@google.com> + + [chromium] Add WebPluginScrollbar and WebPluginScrollbarClient stub implementations + https://bugs.webkit.org/show_bug.cgi?id=89928 + + Reviewed by Darin Fisher. + + These classes are just typedef'd to be the non-Plugin version. The + next step is to change Chromium to use the Plugin version, then move + most of WebPluginScrollbar to a WebScrollbar in Platform to separate + out the base functionality, while providing the same top level API. + + * WebKit.gyp: + * public/WebPluginScrollbar.h: Added. + (WebKit): + * public/WebPluginScrollbarClient.h: Added. + (WebKit): + +2012-06-25 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-25 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r121206. + http://trac.webkit.org/changeset/121206 + https://bugs.webkit.org/show_bug.cgi?id=89935 + + [chromium] webkit_unit_tests + WebViewTest.MHTMLWithMissingResourceFinishesLoading crash + (Requested by ukai on #webkit). + + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (WebKit::FrameTestHelpers::registerMockedURLLoad): + (WebKit::FrameTestHelpers::createWebViewAndLoad): + * tests/FrameTestHelpers.h: + (FrameTestHelpers): + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/WebFrameTest.cpp: + (WebKit::WebFrameTest::registerMockedHttpURLLoad): + (WebKit::WebFrameTest::registerMockedChromeURLLoad): + * tests/WebViewTest.cpp: + (WebKit::TEST_F): + (WebKit::WebViewTest::testAutoResize): + (WebKit::WebViewTest::testTextInputType): + +2012-06-25 Adam Barth <abarth@webkit.org> + + [Chromium] Let the embedder override the max page scale factor set by the page + https://bugs.webkit.org/show_bug.cgi?id=89406 + + Reviewed by James Robinson. + + Chrome on Android has an option to force the web site to allow page + scaling (for accessibility). This patch adds + WebView::setIgnoreViewportTagMaximumScale, which instructs the WebView + to ignore the maximum scale factor supplied by by the page in the + viewport meta tag. + + This patch is a bit different from how this is implemented on the + chromium-android branch, but I'll clean up the branch once this patch + lands. + + * public/WebView.h: + (WebView): + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setIgnoreViewportTagMaximumScale): + (WebKit): + * src/WebViewImpl.h: + (WebViewImpl): + (WebKit::WebViewImpl::ignoreViewportTagMaximumScale): + * tests/WebFrameTest.cpp: + (WebKit::TEST_F): + (WebKit): + +2012-06-25 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r121176. + http://trac.webkit.org/changeset/121176 + https://bugs.webkit.org/show_bug.cgi?id=89934 + + [chromium] browser_tests assert failed: + FATAL:native_theme_win.cc(1541)] Check failed: false. Invalid + part: 16 (Requested by ukai on #webkit). + + * src/PlatformSupport.cpp: + +2012-06-25 Jay Civelli <jcivelli@chromium.org> + + Fix progress load reporting for MHTML documents. + + MHTML documents containing references to resources they don't include + never finish loading. + https://bugs.webkit.org/show_bug.cgi?id=71859 + + Reviewed by Nate Chapin. + + * tests/EventListenerTest.cpp: + * tests/FrameTestHelpers.cpp: + (FrameTestHelpers): + (WebKit::FrameTestHelpers::registerMockedURLLoad): + (WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML): + (WebKit::FrameTestHelpers::createWebViewAndLoad): + * tests/FrameTestHelpers.h: + (FrameTestHelpers): + * tests/ListenerLeakTest.cpp: + (WebKit::ListenerLeakTest::RunTest): + * tests/WebFrameTest.cpp: + (WebKit::WebFrameTest::registerMockedHttpURLLoad): + (WebKit::WebFrameTest::registerMockedChromeURLLoad): + * tests/WebViewTest.cpp: + (WebKit::TEST_F): + (WebKit::WebViewTest::testAutoResize): + (WebKit::WebViewTest::testTextInputType): + (TestWebViewClient): + (WebKit::TestWebViewClient::TestWebViewClient): + (WebKit::TestWebViewClient::didStartLoading): + (WebKit::TestWebViewClient::didStopLoading): + (WebKit::TestWebViewClient::didChangeLoadProgress): + (WebKit::TestWebViewClient::loadingStarted): + (WebKit::TestWebViewClient::loadingStopped): + (WebKit::TestWebViewClient::loadProgress): + (WebKit): + +2012-06-25 James Robinson <jamesr@chromium.org> + + [chromium] Use WebGraphicsContext3D in compositor implementation + https://bugs.webkit.org/show_bug.cgi?id=89700 + + Reviewed by Adrienne Walker. + + Updates tests for refactor, mostly by removing unnecessary GraphicsContext3D wrapper around mock contexts. + + * WebKit.gypi: + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::context): + * src/WebLayerTreeViewImpl.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread): + (WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread): + (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread): + (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread): + * tests/CCSingleThreadProxyTest.cpp: + * tests/CCThreadedTest.cpp: + (WebKitTests::TestHooks::createContext): + * tests/CCThreadedTest.h: + (TestHooks): + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + * tests/CompositorFakeGraphicsContext3D.h: Removed. + * tests/DrawingBufferChromiumTest.cpp: Removed. + * tests/FakeCCLayerTreeHostClient.h: + * tests/FakeGraphicsContext3DTest.cpp: + (TEST): + * tests/GraphicsLayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (FakeLayerRendererChromium::FakeLayerRendererChromium): + (LayerRendererChromiumTest::LayerRendererChromiumTest): + (LayerRendererChromiumTest): + (TEST_F): + (TEST): + * tests/TextureCopierTest.cpp: + * tests/ThrottledTextureUploaderTest.cpp: + (WebKit::TEST): + * tests/TiledLayerChromiumTest.cpp: + +2012-06-25 Kausalya Madhusudhanan <kmadhusu@chromium.org> + + [Chromium] Add a chromium-webkit API to create a serializable file system. + https://bugs.webkit.org/show_bug.cgi?id=89776 + + In order to send a DOMFileSystem as part of WebIntent payload data it + should be serializable. Therefore, I added an API that allows us to + create serializable file system in chromium code. + + Reviewed by Adam Barth. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::createSerializableFileSystem): + (WebKit): + * src/WebFrameImpl.h: + (WebFrameImpl): + +2012-06-25 Alpha Lam <hclam@chromium.org> + + Unreviewed, rolling out r121178. + http://trac.webkit.org/changeset/121178 + https://bugs.webkit.org/show_bug.cgi?id=89784 + + New unit test added is failing on WebKit Linux (dbg) + + * tests/LayerChromiumTest.cpp: + +2012-06-25 Alpha Lam <hclam@chromium.org> + + Unreviewed, rolling out r121129. + http://trac.webkit.org/changeset/121129 + https://bugs.webkit.org/show_bug.cgi?id=89542 + + Chromium ASan failure: crbug.com/134402 + + * features.gypi: + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-06-25 Alpha Lam <hclam@chromium.org> + + Roll Chromium DEPS to r144020 + https://bugs.webkit.org/show_bug.cgi?id=89912 + + Build fixed now! Unreviewed. + + Rolled DEPS to fix chromium build. + Patch by Scott Graham <scottmg@chromium.org>. + + * DEPS: + +2012-06-25 Alec Flett <alecflett@chromium.org> + + IndexedDB: Stub out new onSuccess() handler for chromium + https://bugs.webkit.org/show_bug.cgi?id=89895 + + This is the chromium side of a refactor which will + introduce an onSuccess() method which includes the raw + SerializedScriptValue to the frontend, so the primaryKey + injection can happen in the front end, rather than + the V8 helper process. + + Reviewed by Darin Fisher. + + * public/WebIDBCallbacks.h: + (WebKit): + (WebKit::WebIDBCallbacks::onSuccess): + * src/IDBCallbacksProxy.cpp: + (WebKit::IDBCallbacksProxy::onSuccess): + * src/IDBCallbacksProxy.h: + (IDBCallbacksProxy): + * src/WebIDBCallbacksImpl.cpp: + (WebKit::WebIDBCallbacksImpl::onSuccess): + (WebKit): + * src/WebIDBCallbacksImpl.h: + (WebIDBCallbacksImpl): + +2012-06-25 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Remove unused backend property accessors + https://bugs.webkit.org/show_bug.cgi?id=89893 + + Reviewed by Darin Fisher. + + Following the "metadata" API addition in trac.webkit.org/changeset/121059 + per-property accessors can be removed from the Chromium WebKit API. + + * src/WebIDBDatabaseImpl.cpp: Removed name, version, objectStoreNames. + * src/WebIDBDatabaseImpl.h: + (WebIDBDatabaseImpl): + * src/WebIDBIndexImpl.cpp: Removed name, keyPath, unique, multiEntry. + * src/WebIDBIndexImpl.h: + (WebIDBIndexImpl): + * src/WebIDBObjectStoreImpl.cpp: Removed name, keyPath, autoIncrement, indexNames. + * src/WebIDBObjectStoreImpl.h: + (WebIDBObjectStoreImpl): + +2012-06-25 Ian Vollick <vollick@chromium.org> + + [chromium] Layer chromium should need a redraw after getting its first non-empty bounds. + https://bugs.webkit.org/show_bug.cgi?id=89784 + + Reviewed by James Robinson. + + Previously, we'd only set needs redraw if the old bounds were zero, + and the new bounds were non-zero, but we should actually have + checked that the old bounds were non-empty. + + * tests/LayerChromiumTest.cpp: + +2012-06-25 Scott Graham <scottmg@chromium.org> + + Plumb Scrollbar button dimensions down to WebThemeEngine + https://bugs.webkit.org/show_bug.cgi?id=89264 + + Reviewed by James Robinson. + + Rather than making the height of the scrollbar buttons the same as the + width of the scrollbar, delegate to the WebThemeEngine. This allows + matching the Aura theme rather than the standard Windows theme. + + * src/PlatformSupport.cpp: + (WebCore::PlatformSupport::getThemePartSize): + (WebCore): + +2012-06-25 Zeev Lieber <zlieber@chromium.org> + + [Chromium] RenderPass textures are evicted at the end of every frame + https://bugs.webkit.org/show_bug.cgi?id=89786 + + Reviewed by Adrienne Walker. + + Added unit tests to verify large textures are staying in memory + and available for render pass optimization. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-25 Kinuko Yasuda <kinuko@chromium.org> + + Heap-use-after-free in WebKit::MainThreadFileSystemCallbacks + https://bugs.webkit.org/show_bug.cgi?id=87019 + + Reviewed by David Levin. + + Should not access the CallbacksBridge's member field after it's freed. + + * src/WorkerFileSystemCallbacksBridge.cpp: + (WebKit::WorkerFileSystemCallbacksBridge::cleanUpAfterCallback): + +2012-06-24 Luke Macpherson <macpherson@chromium.org> + + Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). + https://bugs.webkit.org/show_bug.cgi?id=89542 + + Reviewed by Dimitri Glazkov. + + * features.gypi: + * public/WebSettings.h: * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setApplyPageScaleFactorInCompositor): + (WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled): (WebKit): - (WebKit::WebSettingsImpl::applyPageScaleFactorInCompositor): * src/WebSettingsImpl.h: (WebSettingsImpl): + +2012-06-23 Kwang Yul Seo <skyul@company100.net> + + [chromium] Return has value, in function returning void + https://bugs.webkit.org/show_bug.cgi?id=89822 + + Reviewed by Adam Barth. + + A followup for r121091. + + * src/WebHistoryItem.cpp: + (WebKit::WebHistoryItem::setPageScaleFactor): + * src/WebImageLayer.cpp: + (WebKit::WebImageLayer::setBitmap): + * src/WebLayer.cpp: + (WebKit::WebLayer::setMaskLayer): + * src/WebOptionElement.cpp: + (WebKit::WebOptionElement::setValue): + (WebKit::WebOptionElement::setDefaultSelected): + +2012-06-23 Kwang Yul Seo <skyul@company100.net> + + [chromium] Return has value, in function returning void + https://bugs.webkit.org/show_bug.cgi?id=89805 + + Reviewed by Adam Barth. + + Make WebFrameImpl::replaceSelection not return a value because it is a function returning void. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::replaceSelection): + +2012-06-22 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-22 David Grogan <dgrogan@chromium.org> + + IndexedDB: Avoid infinite loop if we try to encode -1 for leveldb + https://bugs.webkit.org/show_bug.cgi?id=89625 + + Reviewed by Tony Chang. + + * tests/IDBLevelDBCodingTest.cpp: + (IDBLevelDBCoding::TEST): + +2012-06-22 Michael Nordman <michaeln@google.com> + + [chromium] WebKit API plumbing for applicationCache.abort() + https://bugs.webkit.org/show_bug.cgi?id=89792 + + Reviewed by Darin Fisher. + + * public/WebApplicationCacheHost.h: + (WebKit::WebApplicationCacheHost::abort): + * src/ApplicationCacheHost.cpp: + (WebCore::ApplicationCacheHost::abort): + +2012-06-22 James Robinson <jamesr@chromium.org> + + [chromium] LayerRendererChromium is not getting visibility messages in single threaded compositing mode. + https://bugs.webkit.org/show_bug.cgi?id=89045 + + Reviewed by Adrienne Walker. + + Based on patch by Michal Mocny <mmocny@google.com>. + + Update various test fixtures and tests to cover scheduling, visibility, and resource allocation changes. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (CCLayerTreeHostTestAbortFrameWhenInvisible): + (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::CCLayerTreeHostTestAbortFrameWhenInvisible): + (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::beginTest): + (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::afterTest): + (WTF): + (WTF::TEST_F): + (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): + (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): + (WTF::CCLayerTreeHostTestManySurfaces::beginTest): + * tests/CCSchedulerStateMachineTest.cpp: + (WebCore::TEST): + * tests/CCTiledLayerTestCommon.h: + * tests/FakeWebGraphicsContext3D.h: + (WebKit::FakeWebGraphicsContext3D::FakeWebGraphicsContext3D): + (FakeWebGraphicsContext3D): + (WebKit::FakeWebGraphicsContext3D::createTexture): + * tests/LayerRendererChromiumTest.cpp: + (TEST_F): + * tests/TiledLayerChromiumTest.cpp: + + +2012-06-22 Sadrul Habib Chowdhury <sadrul@chromium.org> + + [chromium] Notify the document if a plugin accepts touch input events + https://bugs.webkit.org/show_bug.cgi?id=89769 + + Reviewed by Adam Barth. + + The browser sends touch events to webkit only if webkit has any touch-event handlers. So it is + necessary to notify the document when a plugin starts accepting touch-events so that it can in + turn tell the browser to send it touch events. + + * public/WebPluginContainer.h: + (WebPluginContainer): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): + (WebKit): + (WebKit::WebPluginContainerImpl::WebPluginContainerImpl): + (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): + * src/WebPluginContainerImpl.h: + (WebPluginContainerImpl): + +2012-06-22 Kenneth Russell <kbr@google.com> + + Unreviewed, rolling out r121064. + http://trac.webkit.org/changeset/121064 + https://bugs.webkit.org/show_bug.cgi?id=88268 + + Broke Chromium Mac build. + + * public/WebView.h: + (WebKit): + (WebView): + * src/WebLayerTreeView.cpp: + * src/WebViewImpl.cpp: + * src/WebViewImpl.h: + (WebViewImpl): + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestScrollSimple::layout): + (WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit): + +2012-06-22 Dave Tu <dtu@chromium.org> + + [chromium] Expose rendering statistics to WebWidget. + https://bugs.webkit.org/show_bug.cgi?id=88268 + + Reviewed by James Robinson. + + The WebKit side of a basic framework for exposing rendering statistics + to Chromium's --enable-benchmarking extension. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::renderingStatistics): + (WebKit): + +2012-06-22 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Do not accumulate occlusion from 3d layers on the main thread + https://bugs.webkit.org/show_bug.cgi?id=89704 + + Reviewed by James Robinson. + + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): + (WebKitTests): + (CCOcclusionTrackerTestUnsorted3dLayers): + (WebKitTests::CCOcclusionTrackerTestUnsorted3dLayers::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): + +2012-06-22 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Snapshot metadata in front end to avoid IPC round-trips + https://bugs.webkit.org/show_bug.cgi?id=88467 + + Reviewed by Tony Chang. + + Add conversions to/from WebCore IDB metadata type and plumbing for routing the + IDBDatabaseBackendInterface::metadata() call through the public API.. + + * WebKit.gyp: New file added. + * public/WebIDBMetadata.h: Conversion functions. + (WebCore): + (WebIDBMetadata): + * src/IDBDatabaseBackendProxy.cpp: Plumbing. + (WebKit::IDBDatabaseBackendProxy::metadata): + (WebKit): + * src/IDBDatabaseBackendProxy.h: Plumbing. + (IDBDatabaseBackendProxy): + * src/WebIDBDatabaseImpl.cpp: Plumbing. + (WebKit::WebIDBDatabaseImpl::metadata): + (WebKit): + * src/WebIDBDatabaseImpl.h: Plumbing. + (WebKit): + (WebIDBDatabaseImpl): + * src/WebIDBMetadata.cpp: Added - conversion functions. + (WebKit): + (WebKit::WebIDBMetadata::WebIDBMetadata): + (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): + +2012-06-22 Fady Samuel <fsamuel@chromium.org> + + [Chromium] Browser Plugin: Expose advanceFocus to WebKit API so that guests can advance focus of theirs embedders + https://bugs.webkit.org/show_bug.cgi?id=88827 + + Reviewed by Darin Fisher. + + A browser plugin needs to be able to tells its embedder when the guest + is done tabbing through controls and wants its embedder to advance its + tab position. + + * public/WebView.h: + (WebView): + (WebKit::WebView::advanceFocus): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::advanceFocus): + (WebKit): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-06-22 Jeff Timanus <twiz@chromium.org> + + [Chromium] Change implementing a fast-path for copying GPU-accelerated Canvas2D instances to WebGL textures. + https://bugs.webkit.org/show_bug.cgi?id=86275 + + This change adds the necessary plumbing to the various rendering contexts to copy the backing store texture of + a Canvas2D instance to be copied to a WebGL texture. The GL_CHROMIUM_copy_texture extension is necessary + because the backing-store for a GPU-accelerated skia Canvas2D is normally in BGRA format, which is not supported + by glCopyTexImage. + + Reviewed by Kenneth Russell. + + * DEPS: Rolled chromium to 143630 to fix chromium-linux ews failures. + +2012-06-22 Kenneth Russell <kbr@google.com> + + Unreviewed, rolling out r121025. + http://trac.webkit.org/changeset/121025 + https://bugs.webkit.org/show_bug.cgi?id=89580 + + Caused crash in + EventHandler.shouldTurnVerticalTicksIntoHorizontal webkit unit + test on 10.7 + + * WebKit.gypi: + * tests/EventHandlerTest.cpp: Removed. + +2012-06-22 Peter Beverloo <peter@chromium.org> + + [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android + https://bugs.webkit.org/show_bug.cgi?id=88853 + + Reviewed by Steve Block. + + The Android exclusions were necessary to fix a gyp generation error, as + the gcc_version variable wasn't being defined for Android. Remove these + exceptions when Chromium is able to define the gcc_version variable. + + * WebKit.gyp: + * WebKitUnitTests.gyp: + +2012-06-22 Robert Kroeger <rjkroege@chromium.org> + + Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true + https://bugs.webkit.org/show_bug.cgi?id=89580 + + WebKit GTK and Chromium Linux force vertical wheel events to + scroll horizontally when over horizontal scroll bars. This is + undesirable for touchpad scrolling with hasPreciseScrollingDeltas() == true. + + Added unit tests to show that + EventHandler::shouldTurnVerticalTicksIntoHorizontal() is true + only for PlatformWheelEvents when !hasPreciseScrollingDeltas(). + + Reviewed by Adam Barth. + + * WebKit.gypi: + * tests/EventHandlerTest.cpp: Added. + (MockScrollbar): + (MockScrollbar::MockScrollbar): + (MockScrollbar::~MockScrollbar): + (MockHitTestResult): + (MockHitTestResult::MockHitTestResult): + (MockHitTestResult::scrollbar): + (MockPlatformWheelEvent): + (MockPlatformWheelEvent::MockPlatformWheelEvent): + (EventHandlerTest): + (EventHandlerTest::EventHandlerTest): + (EventHandlerTest::externalShouldTurnVerticalTicksIntoHorizontal): + (TEST): + +2012-06-22 Amy Ousterhout <aousterh@chromium.org> + + Renamed DeviceOrientation to DeviceOrientationData + https://bugs.webkit.org/show_bug.cgi?id=88663 + + Reviewed by Steve Block. + + Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation. + This change makes DeviceOrientationData consistent with DeviceMotionData. + + * public/WebDeviceOrientation.h: + (WebDeviceOrientation): + * src/DeviceOrientationClientProxy.cpp: + (WebKit::DeviceOrientationClientProxy::lastOrientation): + * src/DeviceOrientationClientProxy.h: + (DeviceOrientationClientProxy): + * src/WebDeviceOrientation.cpp: + (WebKit::WebDeviceOrientation::WebDeviceOrientation): + (WebKit::WebDeviceOrientation::operator=): + (WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientationData>): + * src/WebDeviceOrientationController.cpp: + (WebKit::WebDeviceOrientationController::didChangeDeviceOrientation): + +2012-06-22 Joseph Pecoraro <pecoraro@apple.com> + + Web Inspector: InspectorState::updateCookie should not do JSON serialization if unsupported + https://bugs.webkit.org/show_bug.cgi?id=89743 + + The Chromium port does want InspectorState updates. + + Reviewed by Yury Semikhatsky. + + * src/InspectorClientImpl.h: + (WebKit::InspectorClientImpl::supportsInspectorStateUpdates): + * src/WebDevToolsAgentImpl.h: + (WebKit::WebDevToolsAgentImpl::supportsInspectorStateUpdates): + +2012-06-21 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120982. + http://trac.webkit.org/changeset/120982 + https://bugs.webkit.org/show_bug.cgi?id=89740 + + [chromium] ASSERTION FAILED: + m_allocatedTextureIds.contains(textureId) (Requested by ukai + on #webkit). + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest): + (WTF): + (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): + (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): + (WTF::CCLayerTreeHostTestManySurfaces::beginTest): + * tests/CCSchedulerStateMachineTest.cpp: + (WebCore::TEST): + * tests/CCTiledLayerTestCommon.h: + (WebKitTests::FakeTextureAllocator::createTexture): + (WebKitTests::FakeTextureAllocator::deleteTexture): + * tests/FakeWebGraphicsContext3D.h: + (WebKit::FakeWebGraphicsContext3D::createTexture): + (FakeWebGraphicsContext3D): + * tests/LayerRendererChromiumTest.cpp: + (TEST_F): + * tests/TiledLayerChromiumTest.cpp: + +2012-06-21 James Robinson <jamesr@chromium.org> + + [chromium] Initialize compositor's visibility state upon initialization + https://bugs.webkit.org/show_bug.cgi?id=89712 + + Reviewed by Adrienne Walker. + + A given WebViewImpl's visibility state might change any number of times before compositing is enabled. If the + visibility state is not the default (visible) when the compositor is initialized, we need to let it know the + correct visibility state or it will start ticking uselessly in threaded mode. + + Tested manually, there's no way to create a new WebViewImpl in a non-visible state in a WebKit test that I know + of. + * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setPageScaleFactor): - (WebKit::WebViewImpl::applyScrollAndScale): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + +2012-06-21 Sadrul Habib Chowdhury <sadrul@chromium.org> + + [chromium] Add touch-event support for WebPluginContainerImpl + https://bugs.webkit.org/show_bug.cgi?id=89089 + + Reviewed by Adam Barth. + + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::handleEvent): + * src/WebPluginContainerImpl.h: + (WebCore): + (WebPluginContainerImpl): + +2012-06-21 Oli Lan <olilan@chromium.org> + + Add methods to select between offsets in an editable field. + https://bugs.webkit.org/show_bug.cgi?id=89098 + + Reviewed by Ryosuke Niwa. + + Reviewed by Ryosuke Niwa. + + This adds a new method WebViewImpl::setEditableSelectionOffsets, which + can be used to select between two character positions in the node + currently beign edited. + + The offsets are assumed to be relative to the rootEditableElement. + + This can be used for IME features that require the ability to manipulate + the selection, for example on Android where the method InputConnection#setSelection + is used. + + This method calls a new method Editor::setSelectionOffsets. + + The method works for inputs/textareas (i.e. text form controls) and + contenteditable nodes, and the new test in WebViewTest tests both these cases. + + * public/WebView.h: + (WebView): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setEditableSelectionOffsets): + (WebKit): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/WebViewTest.cpp: + (WebKit::TEST_F): + (WebKit): + * tests/data/content_editable_populated.html: Added. + * tests/data/input_field_populated.html: Added. + +2012-06-19 James Robinson <jamesr@chromium.org> + + [chromium] LayerRendererChromium is not getting visibility messages in single threaded compositing mode. + https://bugs.webkit.org/show_bug.cgi?id=89045 + + Reviewed by Adrienne Walker. + + Based on patch by Michal Mocny <mmocny@google.com>. + + Update various test fixtures and tests to cover scheduling, visibility, and resource allocation changes. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (CCLayerTreeHostTestAbortFrameWhenInvisible): + (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::CCLayerTreeHostTestAbortFrameWhenInvisible): + (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::beginTest): + (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::afterTest): + (WTF): + (WTF::TEST_F): + (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): + (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): + (WTF::CCLayerTreeHostTestManySurfaces::beginTest): + * tests/CCSchedulerStateMachineTest.cpp: + (WebCore::TEST): + * tests/CCTiledLayerTestCommon.h: + * tests/FakeWebGraphicsContext3D.h: + (WebKit::FakeWebGraphicsContext3D::FakeWebGraphicsContext3D): + (FakeWebGraphicsContext3D): + (WebKit::FakeWebGraphicsContext3D::createTexture): + * tests/LayerRendererChromiumTest.cpp: + (TEST_F): + * tests/TiledLayerChromiumTest.cpp: + + +2012-06-21 Mike West <mkwst@chromium.org> + + [Chromium] Enable CSP_NEXT on the Chromium port. + https://bugs.webkit.org/show_bug.cgi?id=89683 + + Reviewed by Adam Barth. -2012-10-03 Hans Wennborg <hans@chromium.org> + Enable CSP 1.1 on the Chromium port. This has zero practical effect, + as no CSP 1.1 patches have landed yet. But it will. Oh it will. - Speech JavaScript API: Add SpeechRecognition.interimResults attribute - https://bugs.webkit.org/show_bug.cgi?id=98279 + * features.gypi: ENABLE_CSP_NEXT=1 + +2012-06-21 Alec Flett <alecflett@chromium.org> + + IndexedDB: Implement spec behavior for multiEntry indexes with invalid/duplicate subkeys + https://bugs.webkit.org/show_bug.cgi?id=86123 + + Reviewed by Darin Fisher. + + Add matching isValid() to WebIDBKey to match the one in IDBKey. + + * public/WebIDBKey.h: + * src/WebIDBKey.cpp: + (WebKit::WebIDBKey::isValid): + (WebKit): + * src/WebIDBKeyRange.cpp: + (WebKit::WebIDBKeyRange::assign): + +2012-06-21 Ian Vollick <vollick@chromium.org> + + [chromium] Overlays when using the web inspector are blurry with device scale factor > 1 + https://bugs.webkit.org/show_bug.cgi?id=89676 + + Reviewed by James Robinson. + + Whenever we construct a GraphicsLayerChromium, make initialize the + device and page scale factors, if possible. + + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::TEST_F): + (WebKitTests): + +2012-06-21 Min Qin <qinmin@chromium.org> + + remove ENABLE_FULLSCREEN_MEDIA_CONTROL flag + https://bugs.webkit.org/show_bug.cgi?id=89614 + + Reviewed by Eric Carlson. + + Since desktop chrome now has fullscreen button, we don't need this flag anymore + + * features.gypi: + +2012-06-20 Zeev Lieber <zlieber@chromium.org> + + [Chromium] Damage tracker is not used without partial swap, causing valid render passes to be removed + https://bugs.webkit.org/show_bug.cgi?id=89589 + + Reviewed by Adrienne Walker. + + Added unit tests to check surface texture caching when partial + swap is not used. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-20 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120889. + http://trac.webkit.org/changeset/120889 + https://bugs.webkit.org/show_bug.cgi?id=89630 + + [Chromium] webkit_unit_tests didDrawNotCalledOnHiddenLayer + start failing (Requested by ukai on #webkit). + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-20 Zeev Lieber <zlieber@chromium.org> + + [Chromium] Damage tracker is not used without partial swap, causing valid render passes to be removed + https://bugs.webkit.org/show_bug.cgi?id=89589 + + Reviewed by Adrienne Walker. + + Added unit tests to check surface texture caching when partial + swap is not used. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-20 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Remove redundant IDBObjectStore.delete() overloads + https://bugs.webkit.org/show_bug.cgi?id=89587 + + Reviewed by Darin Fisher. + + * public/WebIDBObjectStore.h: Add note to remove overload when Chromium is updated. + (WebIDBObjectStore): + * src/IDBObjectStoreBackendProxy.cpp: Delete IDBKey overload. + * src/IDBObjectStoreBackendProxy.h: Delete IDBKey overload. + (IDBObjectStoreBackendProxy): + * src/WebIDBObjectStoreImpl.cpp: Delete IDBKey overload. + * src/WebIDBObjectStoreImpl.h: Delete IDBKey overload. + (WebIDBObjectStoreImpl): + +2012-06-20 Garret Kelly <gdk@chromium.org> + + Moving cookieEnabled/setCookieEnabled from Page to Settings, and + exposing through WebSettings. + https://bugs.webkit.org/show_bug.cgi?id=89545 Reviewed by Adam Barth. - Plumb interimResults through to Chromium. + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setCookieEnabled): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-06-20 Raymes Khoury <raymes@chromium.org> + + Perform hit-test from correct frame in isRectTopmost() + https://bugs.webkit.org/show_bug.cgi?id=89492 + + Reviewed by Levi Weintraub. + + Hit-testing was being performed from the main frame, which gave the + incorrect result if the plugin was in a different frame. + + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::isRectTopmost): + +2012-06-20 Alexandre Elias <aelias@google.com> + + [chromium] Support mobile device rotation resizing + https://bugs.webkit.org/show_bug.cgi?id=86819 + + Reviewed by Adam Barth. + + Resizes on a mobile device are caused either by rotation or + on-screen-keyboard bringup, and need different treatment to remain + naturally laid out, scaled and scrolled without disorienting the user. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::resize): + +2012-06-19 James Robinson <jamesr@chromium.org> + + [chromium] Separate LayerRenderer initialization from updateLayers + https://bugs.webkit.org/show_bug.cgi?id=89525 + + Reviewed by Adrienne Walker. + + Update tests to call initializeLayerRendererIfNeeded() before calling updateLayers() to reflect what the proxies + do. + + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): + (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): + (WTF::CCLayerTreeHostTestManySurfaces::beginTest): + * tests/TiledLayerChromiumTest.cpp: + +2012-06-20 Christopher Cameron <ccameron@chromium.org> + + [chromium] webkit-backface-visibility doesn't work with video + https://bugs.webkit.org/show_bug.cgi?id=88908 + + When determining a contents layer's backface culling, use the parent + layer's transform and backface-visibility properties. Track which + layers need this special treatment with useParentBackfaceVisibility + and setUseParentBackfaceVisibility functions in WebCore::LayerChromium, + WebKit::WebLayer, and WebCore::CCLayerImpl. + + Reviewed by Adrienne Walker. + + * src/WebLayer.cpp: + (WebKit::WebLayer::setUseParentBackfaceVisibility): + Add an accessor to specify that a layer should use its parent's + backface culling behavior. + +2012-06-20 Ian Vollick <vollick@chromium.org> + + [chromium] Make sure that render surfaces are not pixel doubled with a device scale factor of 2 + https://bugs.webkit.org/show_bug.cgi?id=86882 + + Reviewed by Adrienne Walker. + + To ensure that render surfaces are not pixel doubled when device scale factor is + two, the render surface's owning layer's draw transform is scaled by the + contents scale (in the same way that the parent matrix is scaled by the device + scale factor). The transformedLayerRect's dimensions also need to be in pixel + space. The surface origin transform should not scale, but needs to offset the + correct number of pixels, and the replica transforms need to be modified to + account for the scaling. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-06-20 Joshua Bell <jsbell@chromium.org> + + Unreviewed build fix. + + * tests/IDBDatabaseBackendTest.cpp: + (WebCore::MockIDBCallbacks::~MockIDBCallbacks): + (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks): + +2012-06-20 Joshua Bell <jsbell@chromium.org> + + [Chromium] IndexedDB: Don't close database if pending connections are in flight + https://bugs.webkit.org/show_bug.cgi?id=89512 + + Reviewed by Tony Chang. + + * tests/IDBDatabaseBackendTest.cpp: + (MockIDBCallbacks): + (WebCore::MockIDBCallbacks::create): + (WebCore::MockIDBCallbacks::MockIDBCallbacks): + (WebCore): + (FakeIDBDatabaseCallbacks): + (WebCore::FakeIDBDatabaseCallbacks::create): + (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks): + (WebCore::TEST): + +2012-06-20 Zeev Lieber <zlieber@chromium.org> + + [Chromium] Remove redundant #includes in compositor + https://bugs.webkit.org/show_bug.cgi?id=89503 + + Reviewed by Adrienne Walker. + + Minor adjustments to #include statements to remove + dependencies. No new tests. + + * src/WebCompositorImpl.cpp: + * src/WebLayerTreeView.cpp: + * tests/CCLayerTestCommon.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/CCTiledLayerImplTest.cpp: + * tests/ImageLayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-06-20 Hans Wennborg <hans@chromium.org> + + Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute + https://bugs.webkit.org/show_bug.cgi?id=89459 + + Reviewed by Eric Seidel. + + Plumbing for the maxAlternatives attribute. * public/WebSpeechRecognitionParams.h: (WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams): - (WebKit::WebSpeechRecognitionParams::interimResults): + (WebKit::WebSpeechRecognitionParams::maxAlternatives): (WebSpeechRecognitionParams): * src/SpeechRecognitionClientProxy.cpp: (WebKit::SpeechRecognitionClientProxy::start): * src/SpeechRecognitionClientProxy.h: (SpeechRecognitionClientProxy): -2012-10-03 Hans Wennborg <hans@chromium.org> +2012-06-20 Hironori Bono <hbono@chromium.org> + + [chromium] Select the marker range when right-clicking on a marker. + https://bugs.webkit.org/show_bug.cgi?id=89331 + + Reviewed by Hajime Morita. + + Chromium always selects only one word when right-clicking on a spelling marker. + This prevents selecting whole region specified by a marker if the marker + consists of two or more words. This change retrieves a range coverted by a + marker and select the range. This emulates the behavior of Mac Chromium and it + does not need any workarounds for Mac. + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): + +2012-06-19 Kenneth Russell <kbr@google.com> + + Unreviewed, rolling out r120772. + http://trac.webkit.org/changeset/120772 + https://bugs.webkit.org/show_bug.cgi?id=89503 + + Broke build on Chromium Mac + + * src/WebCompositorImpl.cpp: + * src/WebLayerTreeView.cpp: + * tests/CCLayerTestCommon.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/CCTiledLayerImplTest.cpp: + * tests/ImageLayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-06-19 Zeev Lieber <zlieber@chromium.org> + + [Chromium] Remove redundant #includes in compositor + https://bugs.webkit.org/show_bug.cgi?id=89503 + + Reviewed by Adrienne Walker. + + Minor adjustments to #include statements to remove + dependencies. No new tests. + + * src/WebCompositorImpl.cpp: + * src/WebLayerTreeView.cpp: + * tests/CCLayerTestCommon.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + * tests/CCQuadCullerTest.cpp: + * tests/CCTiledLayerImplTest.cpp: + * tests/ImageLayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + +2012-06-19 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Add new type (and chromium webkit API) for metadata snapshot + https://bugs.webkit.org/show_bug.cgi?id=88678 - Speech JavaScript API: Remove resultdeleted event - https://bugs.webkit.org/show_bug.cgi?id=98272 + Reviewed by Darin Fisher. + + * WebKit.gyp: + * public/WebIDBDatabase.h: + (WebKit::WebIDBDatabase::metadata): + * public/WebIDBKeyPath.h: + (WebIDBKeyPath): + (WebKit::WebIDBKeyPath::WebIDBKeyPath): + (WebKit::WebIDBKeyPath::~WebIDBKeyPath): + (WebKit::WebIDBKeyPath::operator=): Used by Chromium backend. + * public/WebIDBMetadata.h: Added new type. + (WebKit): + (WebIDBMetadata): + (WebKit::WebIDBMetadata::WebIDBMetadata): + (ObjectStore): + (WebKit::WebIDBMetadata::ObjectStore::ObjectStore): + (Index): + (WebKit::WebIDBMetadata::Index::Index): + * src/WebIDBKeyPath.cpp: Conform to normal WebXXX patern. + (WebKit::WebIDBKeyPath::assign): + (WebKit): + (WebKit::WebIDBKeyPath::reset): + +2012-06-19 Amy Ousterhout <aousterh@chromium.org> + + [Chromium] Style Fix in WebDeviceOrientationController + https://bugs.webkit.org/show_bug.cgi?id=89337 + + Reviewed by Steve Block. + + Changing a local variable from a PassRefPtr to a RefPtr in order to be consistent with the style guide. + + * src/WebDeviceOrientationController.cpp: + (WebKit::WebDeviceOrientationController::didChangeDeviceOrientation): + +2012-06-19 Peter Wang <peter.wang@torchmobile.com.cn> + + Remove the function ScriptDebugServer::supportsNativeBreakpoints() + https://bugs.webkit.org/show_bug.cgi?id=88759 + + Reviewed by Pavel Feldman. + + * src/js/DevTools.js: + +2012-06-19 Yury Semikhatsky <yurys@chromium.org> + + [Chromium] Web Inspector: remove unnecessary indirection from message loop instrumentation + https://bugs.webkit.org/show_bug.cgi?id=89443 + + Removed start/stopMainThreadMonitoring methods from WebDevToolsAgentClient + and WebDevToolsAgentImpl. The functionality is now implemented inside + InspectorClientImpl. + + Reviewed by Vsevolod Vlasov. + + * public/WebDevToolsAgentClient.h: + * src/InspectorClientImpl.cpp: + (WebKit::InspectorClientImpl::clearBrowserCookies): + (WebKit::InspectorClientImpl::startMainThreadMonitoring): + (WebKit::InspectorClientImpl::stopMainThreadMonitoring): + (WebKit::InspectorClientImpl::willProcessTask): + (WebKit): + (WebKit::InspectorClientImpl::didProcessTask): + * src/InspectorClientImpl.h: + (InspectorClientImpl): + * src/WebDevToolsAgentImpl.cpp: + * src/WebDevToolsAgentImpl.h: + (WebDevToolsAgentImpl): + +2012-06-19 Mike West <mkwst@chromium.org> + + Introduce ENABLE_CSP_NEXT configuration flag. + https://bugs.webkit.org/show_bug.cgi?id=89300 Reviewed by Adam Barth. - Remove didDeleteResult. This was never used, and has been removed from - the spec draft. + The 1.0 draft of the Content Security Policy spec is just about to + move to Last Call. We'll hide work on the upcoming 1.1 spec behind + this ENABLE flag, disabled by default. - * public/WebSpeechRecognizerClient.h: - * src/SpeechRecognitionClientProxy.cpp: - * src/SpeechRecognitionClientProxy.h: - (SpeechRecognitionClientProxy): + Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html -2012-10-02 Anders Carlsson <andersca@apple.com> + * features.gypi: - Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory - https://bugs.webkit.org/show_bug.cgi?id=98217 +2012-06-19 Sheriff Bot <webkit.review.bot@gmail.com> - Reviewed by Andreas Kling. + Unreviewed, rolling out r120586. + http://trac.webkit.org/changeset/120586 + https://bugs.webkit.org/show_bug.cgi?id=89444 + + doesn't fix mac issue (Requested by morrita on #webkit). + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::replaceMisspelledRange): + +2012-06-19 Mike West <mkwst@chromium.org> + + Add a scheme registry for bypassing Content Security Policy. + https://bugs.webkit.org/show_bug.cgi?id=89373 + + Reviewed by Adam Barth. + + * public/WebSecurityPolicy.h: + (WebSecurityPolicy): + * src/WebSecurityPolicy.cpp: + (WebKit::WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy): + (WebKit): + +2012-06-18 Adam Barth <abarth@webkit.org> + + [Chromium] GesturePinchBegin and friends are gesture events + https://bugs.webkit.org/show_bug.cgi?id=89398 + + Reviewed by James Robinson. + + * public/WebInputEvent.h: + (WebKit::WebInputEvent::isGestureEventType): + +2012-06-18 Amy Ousterhout <aousterh@chromium.org> + + [Chromium] DeviceOrientation Cleanup + https://bugs.webkit.org/show_bug.cgi?id=89354 + + Reviewed by Kent Tamura. + + * public/WebDeviceOrientation.h: added const-qualifiers to getters, simplified an overly-complicated parameter to two functions + (WebKit::WebDeviceOrientation::isNull): + (WebKit::WebDeviceOrientation::canProvideAlpha): + (WebKit::WebDeviceOrientation::alpha): + (WebKit::WebDeviceOrientation::canProvideBeta): + (WebKit::WebDeviceOrientation::beta): + (WebKit::WebDeviceOrientation::canProvideGamma): + (WebKit::WebDeviceOrientation::gamma): + (WebKit::WebDeviceOrientation::canProvideAbsolute): + (WebKit::WebDeviceOrientation::absolute): + (WebDeviceOrientation): + * public/WebDeviceOrientationClient.h: added WEBKIT_ASSERT_NOT_REACHED to virtual functions + (WebKit::WebDeviceOrientationClient::setController): + (WebKit::WebDeviceOrientationClient::startUpdating): + (WebKit::WebDeviceOrientationClient::stopUpdating): + (WebKit::WebDeviceOrientationClient::lastOrientation): + * public/WebDeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions + (WebDeviceOrientationClientMock): + * src/DeviceOrientationClientProxy.h: designated functions as 'virtual' and added OVERRIDE specifier + (DeviceOrientationClientProxy): + * src/WebDeviceOrientation.cpp: simplified overly-complicated parameter to two functions + (WebKit::WebDeviceOrientation::WebDeviceOrientation): + (WebKit::WebDeviceOrientation::operator=): + +2012-06-18 Ami Fischman <fischman@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-14 James Robinson <jamesr@chromium.org> + + [chromium] Use WebImageLayer in GraphicsLayerChromium for image layers + https://bugs.webkit.org/show_bug.cgi?id=89150 + + Reviewed by Adrienne Walker. + + Implementation of WebImageLayer. Note: This could (should?) live in WebCore/platform/chromium/support/, but it's + here to be next to the other Web*Layer.cpp implementation files. + + * WebKit.gyp: + * src/WebImageLayer.cpp: Added. + (WebKit): + (WebKit::WebImageLayer::create): + (WebKit::WebImageLayer::WebImageLayer): + (WebKit::WebImageLayer::setBitmap): + +2012-06-14 James Robinson <jamesr@chromium.org> + + [chromium] GraphicsLayerChromium should use WebContentLayer directly + https://bugs.webkit.org/show_bug.cgi?id=89145 + + Reviewed by Adrienne Walker. + + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::paintContents): + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTestMainThreadTypes::createLayer): + * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: + (WebCore): + (WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest): + (WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect): + (WebCore::TEST_F): + * tests/WebLayerTest.cpp: + +2012-06-18 Ilya Sherman <isherman@chromium.org> + + [Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox() + Also update existing code to use updateLayoutIgnorePendingStylesheets() + https://bugs.webkit.org/show_bug.cgi?id=89258 + + Reviewed by James Robinson. + + * src/WebNode.cpp: + (WebKit::WebNode::isFocusable): Use updateLayoutIgnorePendingStylesheets() + (WebKit::WebNode::hasNonEmptyBoundingBox): Force layout before checking the bounding box + +2012-06-18 Ian Vollick <vollick@chromium.org> + + [chromium] Ensure that skipping frames during an accelerated animation doesn't cause starvation + https://bugs.webkit.org/show_bug.cgi?id=87766 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostTest.cpp: + (WTF): + (CCLayerTreeHostTestCheckerboardDoesNotStarveDraws): + (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws): + (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::beginTest): + (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::afterTest): + (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::animateLayers): + (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::drawLayersOnCCThread): + (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::prepareToDrawOnCCThread): + (WTF::TEST_F): + * tests/CCSchedulerStateMachineTest.cpp: + (WebCore::TEST): + (WebCore): + * tests/CCThreadedTest.cpp: + (WebKitTests::MockLayerTreeHostImpl::prepareToDraw): + * tests/CCThreadedTest.h: + (WebKitTests::TestHooks::prepareToDrawOnCCThread): + +2012-06-18 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android + https://bugs.webkit.org/show_bug.cgi?id=89228 + + Reviewed by Tony Chang. + + * WebKit.gyp: + * public/linux/WebFontRendering.h: + (WebKit): + (WebFontRendering): + * public/linuxish/WebFontRendering.h: Removed. + * src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. + (WebKit): + (WebKit::WebFontRendering::setHinting): + (WebKit::WebFontRendering::setAutoHint): + (WebKit::WebFontRendering::setUseBitmaps): + (WebKit::WebFontRendering::setAntiAlias): + (WebKit::WebFontRendering::setSubpixelRendering): + (WebKit::WebFontRendering::setSubpixelPositioning): + (WebKit::WebFontRendering::setLCDOrder): + (WebKit::WebFontRendering::setLCDOrientation): + +2012-06-18 Hironori Bono <hbono@chromium.org> + + [chromium] Spellchecker should show suggestions only when right-clicking a misspelled word. + https://bugs.webkit.org/show_bug.cgi?id=89331 + + Reviewed by Hajime Morita. + + When a selection includes two or more misspelled words, it is not so easy to + select one word from them and to show its suggestions. To avoid this problem, + this change shows suggestions only when the selection is collapsed. For this + case, we can use Range::setStart and setEnd to convert a DocumentMarker to a + Range. + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a check that the selection is collapsed. + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::replaceMisspelledRange): Added a check that the selection is collapsed. Also, use Range::setStart() and Range::setEnd() to get the marker range to emulate the behavior of DocumentMarker::markersInRange(). + +2012-06-14 Kinuko Yasuda <kinuko@chromium.org> + + [chromium] Cleanup: remove PlatformSupport::createAsyncFileSystem as it's no longer used + https://bugs.webkit.org/show_bug.cgi?id=89083 + + Reviewed by Kentaro Hara. + + * src/PlatformSupport.cpp: + +2012-06-15 Kinuko Yasuda <kinuko@chromium.org> + + XHR_RESPONSE_BLOB is not enabled on some platforms + https://bugs.webkit.org/show_bug.cgi?id=88859 + + Reviewed by Adam Barth. + + Removing XHR_RESPONSE_BLOB since the current implementation has + no platform-specific part. + + * src/PlatformSupport.cpp: + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enableXHRResponseBlob): + (WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled): + +2012-06-17 MORITA Hajime <morrita@google.com> + Unreviewed build fix. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-17 Zeev Lieber <zlieber@chromium.org> + + [Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged + https://bugs.webkit.org/show_bug.cgi?id=88482 + + Reviewed by Adrienne Walker. + + Added tests to verify quad removal algorithm. Added infrastructure + code to generate custom render passes out of a script encoded as C + string. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCLayerImplTest.cpp: + (WebCore): + (WebCore::TEST): + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-16 Robert Kroeger <rjkroege@chromium.org> + + [chromium] Make the deviceScaleFactor dynamically adjustable. + https://bugs.webkit.org/show_bug.cgi?id=88916 + + Reviewed by James Robinson. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCSettings): Removed unused + static deviceScaleFactor. + (WebKit::WebLayerTreeView::setDeviceScaleFactor): + (WebKit): + (WebKit::WebLayerTreeView::deviceScaleFactor): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setDeviceScaleFactor): Push the dynamic deviceScaleFactor + to the compositor as required. + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + * tests/CCLayerTreeHostTest.cpp: Tests use dynamic setDeviceScaleFactor. + (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers): + (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest): + (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread): + +2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120536. + http://trac.webkit.org/changeset/120536 + https://bugs.webkit.org/show_bug.cgi?id=89296 + + Does not compile on chromium-linux (Requested by abarth on + #webkit). + + * WebKit.gyp: + * public/linux/WebFontRendering.h: + * public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h. + (WebKit): + (WebFontRendering): + * src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp. + (WebKit): + (WebKit::WebFontRendering::setHinting): + (WebKit::WebFontRendering::setAutoHint): + (WebKit::WebFontRendering::setUseBitmaps): + (WebKit::WebFontRendering::setAntiAlias): + (WebKit::WebFontRendering::setSubpixelRendering): + (WebKit::WebFontRendering::setSubpixelPositioning): + (WebKit::WebFontRendering::setLCDOrder): + (WebKit::WebFontRendering::setLCDOrientation): + +2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120539. + http://trac.webkit.org/changeset/120539 + https://bugs.webkit.org/show_bug.cgi?id=89295 + + Does not compile on chromium-mac (Requested by abarth on + #webkit). + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCLayerImplTest.cpp: + (WebCore): + (WebCore::TEST): + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-16 Zeev Lieber <zlieber@chromium.org> + + [Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged + https://bugs.webkit.org/show_bug.cgi?id=88482 + + Reviewed by Adrienne Walker. + + Added tests to verify quad removal algorithm. Added infrastructure + code to generate custom render passes out of a script + encoded as C string. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + * tests/CCLayerImplTest.cpp: + (WebCore): + (WebCore::TEST): + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-16 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory + https://bugs.webkit.org/show_bug.cgi?id=89228 + + Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering + so that WebKit::WebFontRendering can be platform-independent. + + This also avoids the ambiguous name 'linuxish'. + + Reviewed by Tony Chang. + + * WebKit.gyp: + * public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION. + (WebFontRendering): + * public/linux/WebFontRendering.h: + * public/linuxish: Removed. + * public/linuxish/WebFontRendering.h: Removed. + * src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters. + (WebKit): + (WebKit::WebFontRendering::setHinting): + (WebKit::WebFontRendering::hinting): + (WebKit::WebFontRendering::setAutoHint): + (WebKit::WebFontRendering::autoHint): + (WebKit::WebFontRendering::setUseBitmaps): + (WebKit::WebFontRendering::useBitmaps): + (WebKit::WebFontRendering::setAntiAlias): + (WebKit::WebFontRendering::antiAlias): + (WebKit::WebFontRendering::setSubpixelRendering): + (WebKit::WebFontRendering::subpixelRendering): + (WebKit::WebFontRendering::setSubpixelPositioning): + (WebKit::WebFontRendering::subpixelPositioning): + * src/linuxish: Removed. + * src/linuxish/WebFontRendering.cpp: Removed. + +2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-16 Dan Alcantara <dfalcantara@chromium.org> + + [chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument + https://bugs.webkit.org/show_bug.cgi?id=89233 + + Reviewed by Darin Fisher. + + Adds a WebFrame* to the WebFrameClient::userAgentOverride() function. + + * public/WebFrameClient.h: + (WebKit::WebFrameClient::userAgentOverride): + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::userAgent): + * tests/FrameLoaderClientImplTest.cpp: + +2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120511. + http://trac.webkit.org/changeset/120511 + https://bugs.webkit.org/show_bug.cgi?id=89255 + + Breaks at least Android builder (Requested by wangxianzhu on + #webkit). + + * WebKit.gyp: + * public/linux/WebFontRendering.h: + * public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h. + (WebKit): + (WebFontRendering): + * src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp. + (WebKit): + (WebKit::WebFontRendering::setHinting): + (WebKit::WebFontRendering::setAutoHint): + (WebKit::WebFontRendering::setUseBitmaps): + (WebKit::WebFontRendering::setAntiAlias): + (WebKit::WebFontRendering::setSubpixelRendering): + (WebKit::WebFontRendering::setSubpixelPositioning): + (WebKit::WebFontRendering::setLCDOrder): + (WebKit::WebFontRendering::setLCDOrientation): + +2012-06-15 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory + https://bugs.webkit.org/show_bug.cgi?id=89228 + + Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering + so that WebKit::WebFontRendering can be platform-independent. + + This also avoids the ambiguous name 'linuxish'. + + Reviewed by Tony Chang. + + * WebKit.gyp: + * public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION. + (WebFontRendering): + * public/linux/WebFontRendering.h: + * public/linuxish: Removed. + * public/linuxish/WebFontRendering.h: Removed. + * src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters. + (WebKit): + (WebKit::WebFontRendering::setHinting): + (WebKit::WebFontRendering::hinting): + (WebKit::WebFontRendering::setAutoHint): + (WebKit::WebFontRendering::autoHint): + (WebKit::WebFontRendering::setUseBitmaps): + (WebKit::WebFontRendering::useBitmaps): + (WebKit::WebFontRendering::setAntiAlias): + (WebKit::WebFontRendering::antiAlias): + (WebKit::WebFontRendering::setSubpixelRendering): + (WebKit::WebFontRendering::subpixelRendering): + (WebKit::WebFontRendering::setSubpixelPositioning): + (WebKit::WebFontRendering::subpixelPositioning): + * src/linuxish: Removed. + * src/linuxish/WebFontRendering.cpp: Removed. + +2012-06-15 Tony Chang <tony@chromium.org> + + [chromium] Remove WebKit/chromium/public/gtk/WebFontInfo.h since it's no longer referenced. + https://bugs.webkit.org/show_bug.cgi?id=89251 + + Reviewed by Adam Barth. + + This was a forwarding header when we moved the file to public/linux. + + * public/gtk/WebFontInfo.h: Removed. + +2012-06-15 Bill Budge <bbudge@chromium.org> + + AssociatedURLLoader should allow trusted clients to read all headers, not just exposed ones. + https://bugs.webkit.org/show_bug.cgi?id=89185 + + Reviewed by Adam Barth. + + This change adds an option to turn off whitelist filtering of response headers for CORS loads, + and modifies AssociatedURLLoader check for that before filtering. + + * public/WebURLLoaderOptions.h: + (WebKit::WebURLLoaderOptions::WebURLLoaderOptions): + (WebURLLoaderOptions): + * src/AssociatedURLLoader.cpp: + (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): + * tests/AssociatedURLLoaderTest.cpp: + (WebKit): + (WebKit::TEST_F): + +2012-06-15 Sami Kyostila <skyostil@chromium.org> + + [chromium] Allow scrolling non-root layers in the compositor thread + https://bugs.webkit.org/show_bug.cgi?id=73350 + + Reviewed by James Robinson. + + New unit tests to verify layer scrolling behavior and the associated + utility functions. + + * src/WebCompositorInputHandlerImpl.cpp: + (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): + (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::MockContentLayerDelegate::paintContents): + (CCLayerTreeHostTestScrollChildLayer): + (WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer): + (WTF::CCLayerTreeHostTestScrollChildLayer::beginTest): + (WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale): + (WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread): + (WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread): + (WTF::CCLayerTreeHostTestScrollChildLayer::afterTest): + (WTF): + (WTF::TEST_F): + * tests/WebCompositorInputHandlerImplTest.cpp: + (WebKit::TEST_F): + +2012-06-15 Hironori Bono <hbono@chromium.org> + + Allow platforms to choose whether to remove markers on editing + https://bugs.webkit.org/show_bug.cgi?id=88838 + + Reviewed by Hajime Morita. + + This change implements EditorClientImpl::checkGrammarOfString so + DumpRenderTree can run grammar tests. + + * src/EditorClientImpl.cpp: + (WebKit::EditorClientImpl::isGrammarCheckingEnabled): Return true also when unified text-checking is enabled. + (WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection): ditto. + (WebKit::EditorClientImpl::checkGrammarOfString): Implement this function with our unified text-checker. + +2012-06-14 Kent Tamura <tkent@chromium.org> + + Support file extensions in HTMLInputElement::accept + https://bugs.webkit.org/show_bug.cgi?id=88298 + + Reviewed by Hajime Morita. + + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::runOpenPanel): + Use FileChooserSettings::acceptTypes() to get both of MIME types and file extensions. + +2012-06-14 Kaustubh Atrawalkar <kaustubh@motorola.com> + + Remove support for counterValueForElementById from chromium port + https://bugs.webkit.org/show_bug.cgi?id=88851 + + Reviewed by Adam Barth. + + Moved the counterValueForElementById from LayoutTestCotroller to Internals so + remove the old platform specific implementations as it exclusively tests WebCore functionality. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit): + * src/WebFrameImpl.h: + (WebFrameImpl): + +2012-06-14 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium-Android] Initialize font rendering in DumpRenderTree + https://bugs.webkit.org/show_bug.cgi?id=89133 + + Reviewed by Adam Barth. + + * src/linuxish/WebFontRendering.cpp: + (WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites. + +2012-06-14 Tony Chang <tony@chromium.org> + + [chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=89132 + + Reviewed by Adam Barth. + + This test is currently in src/webkit/glue/iframe_redirect_unittest.cc + and uses test_shell's layoutTestController. Moving this will make + it easier to get rid of layoutTestController in test_shell. + + * tests/WebFrameTest.cpp: + (WebKit::TEST_F): + (WebKit): + * tests/data/iframe_redirect.html: Added. + +2012-06-14 David Reveman <reveman@chromium.org> + + [Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background. + https://bugs.webkit.org/show_bug.cgi?id=89033 + + Reviewed by James Robinson. + + Add canvas background argument to PageWidgetDelegate::paint and call + PlatformCanvasSkia::setDrawingToImageBuffer to ensure that sub-pixel + rendering is only used when WebView has opaque background. + + * src/PageWidgetDelegate.cpp: + (WebKit::PageWidgetDelegate::paint): + * src/PageWidgetDelegate.h: + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::paint): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::paint): + +2012-06-14 Shawn Singh <shawnsingh@chromium.org> + + [chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug + https://bugs.webkit.org/show_bug.cgi?id=89065 + + Reviewed by James Robinson. + + A debug assertion was being triggered in the hit-testing unit + tests because I accidentally forgot to set the + DebugScopedSetImplThread for the tests. + + This patch also re-enables the disabled broken test. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-06-14 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering + https://bugs.webkit.org/show_bug.cgi?id=89014 + + Reviewed by James Robinson. + + * public/linuxish/WebFontRendering.h: + (WebFontRendering): + * src/linuxish/WebFontRendering.cpp: + (WebKit): + (WebKit::WebFontRendering::setAutoHint): + (WebKit::WebFontRendering::setUseBitmaps): + (WebKit::WebFontRendering::setAntiAlias): + +2012-06-14 Daniel Erat <derat@chromium.org> + + [chromium/linux] Drop deprecated WebFontRenderStyle::useSubpixel + https://bugs.webkit.org/show_bug.cgi?id=88263 + + Reviewed by Adam Barth. + + This removes the useSubpixel member, which was replaced by + useSubpixelRendering. Chrome has been updated to set only the + useSubpixelRendering field. + + No test updates since the existing behavior shouldn't change. + + * public/linux/WebFontInfo.h: + (WebFontInfo): + * public/linux/WebFontRenderStyle.h: + * src/linux/WebFontInfo.cpp: + (WebKit::WebFontInfo::renderStyleForStrike): + * src/linux/WebFontRenderStyle.cpp: + (WebKit::WebFontRenderStyle::toFontRenderStyle): + (WebKit::WebFontRenderStyle::setDefaults): + +2012-06-14 Shawn Singh <shawnsingh@chromium.org> + + [chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it. + https://bugs.webkit.org/show_bug.cgi?id=89049 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-06-14 Ian Vollick <vollick@chromium.org> + + [chromium] Certain settings in CCSettings could be global + https://bugs.webkit.org/show_bug.cgi?id=88384 + + Reviewed by James Robinson. + + * WebKit.gypi: + * public/WebCompositor.h: + (WebCompositor): + * public/WebSettings.h: + * src/WebCompositorImpl.cpp: + (WebKit::WebCompositor::shutdown): + (WebKit): + (WebKit::WebCompositor::setPerTilePaintingEnabled): + (WebKit::WebCompositor::setPartialSwapEnabled): + (WebKit::WebCompositor::setAcceleratedAnimationEnabled): + * src/WebLayerTreeView.cpp: + (WebKit): + (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): + * src/WebSettingsImpl.cpp: + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF): + (CCLayerTreeHostTestShortlived1): + (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): + (WTF::CCLayerTreeHostTestShortlived1::beginTest): + (WTF::CCLayerTreeHostTestShortlived1::afterTest): + * tests/CCTestCommon.h: Added. + (WebKitTests): + (CCScopedSettings): + (WebKitTests::CCScopedSettings::CCScopedSettings): + (WebKitTests::CCScopedSettings::~CCScopedSettings): + * tests/CCThreadedTest.cpp: + (WebKitTests::MockLayerTreeHostImpl::create): + (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (WebKitTests::CCThreadedTest::runTest): + * tests/CCThreadedTest.h: + (CCThreadedTest): + (MockLayerTreeHostImpl): + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + * tests/LayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (LayerRendererChromiumTest): + (TEST_F): + (TEST): + * tests/TextureLayerChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + * tests/TreeSynchronizerTest.cpp: + (WebKitTests::TEST): + +2012-06-14 James Robinson <jamesr@chromium.org> + + [chromium] Move opaque rectangle tracking logic out of compositor core + https://bugs.webkit.org/show_bug.cgi?id=89031 + + Reviewed by Adrienne Walker. + + Moves the grayscale/subpixel AA text decision into NonCompositedContentHost and removes one layer of indirection + betwen NCCH and WVI that existed only for historical reasons. + + Ports the opaque rect tracking tests that were in LayerTextureUpdaterTest to + OpaquerectTrackingContentLayerDelegateTest to reflect the move in responsibilities. + + * WebKit.gypi: * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): + (WebKit::NonCompositedContentHost::setOpaque): + (WebKit::NonCompositedContentHost::paintContents): + * src/NonCompositedContentHost.h: + (WebCore): + (WebKit): + (WebKit::NonCompositedContentHost::create): + (NonCompositedContentHost): + * src/WebContentLayerImpl.cpp: + (WebKit::WebContentLayerImpl::paintContents): + * src/WebContentLayerImpl.h: + (WebContentLayerImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::paintRootLayer): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/CCLayerTreeHostTest.cpp: + (WTF::TestOpacityChangeLayerDelegate::paintContents): + (WTF::MockContentLayerDelegate::paintContents): + * tests/LayerChromiumTest.cpp: + * tests/LayerTextureUpdaterTest.cpp: Removed. + * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: Added. + (WebCore): + (PaintCallback): + (TestLayerPainterChromium): + (WebCore::TestLayerPainterChromium::TestLayerPainterChromium): + (WebCore::PaintFillAlpha::operator()): + (WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque): + (PaintFillPartialOpaque): + (WebCore::PaintFillPartialOpaque::operator()): + (OpaqueRectTrackingContentLayerDelegateTest): + (WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest): + (WebCore::OpaqueRectTrackingContentLayerDelegateTest::skCanvas): + (WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect): + (WebCore::TEST_F): + +2012-06-14 Justin Novosad <junov@chromium.org> + + [Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw + https://bugs.webkit.org/show_bug.cgi?id=89018 + + Reviewed by Stephen White. + + Rolling chromium DEPS to 141884 + + * DEPS: + +2012-06-14 Alexander Pavlov <apavlov@chromium.org> + + [Chromium] Unreviewed, build fix for Mac 10.5 + + * src/WebDevToolsAgentImpl.cpp: + (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): + +2012-06-14 Eugene Klyuchnikov <eustas.bug@gmail.com> + + Web Inspector: Refactor message loop instrumentation. + https://bugs.webkit.org/show_bug.cgi?id=88978 + + Reviewed by Pavel Feldman. + + 1) Remove "messageLoop" term + 2) Reuse WebThread::TaskObserver interface + 3) Move implementation (from embedder) to platform code. + + * public/WebDevToolsAgent.h: + (WebDevToolsAgent): + * public/WebDevToolsAgentClient.h: + (WebDevToolsAgentClient): + (WebKit::WebDevToolsAgentClient::startMainThreadMonitoring): Renamed medthod. + (WebKit::WebDevToolsAgentClient::stopMainThreadMonitoring): Ditto. + * src/InspectorClientImpl.cpp: + (WebKit::InspectorClientImpl::startMainThreadMonitoring): Ditto. + (WebKit::InspectorClientImpl::stopMainThreadMonitoring): Ditto. + * src/InspectorClientImpl.h: + (InspectorClientImpl): + * src/WebDevToolsAgentImpl.cpp: + (WebKit::WebDevToolsAgentImpl::startMainThreadMonitoring): Use platform threading. + (WebKit::WebDevToolsAgentImpl::stopMainThreadMonitoring): Ditto. + (WebKit::WebDevToolsAgentImpl::willProcessTask): Renamed medthod. + (WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto. + * src/WebDevToolsAgentImpl.h: + (WebDevToolsAgentImpl): + * src/WebKit.cpp: -2012-10-03 Tommy Widenflycht <tommyw@google.com> +2012-06-14 Alexander Pavlov <apavlov@chromium.org> - MediaStream API: RTCPeerConnection should send down its handler via the FrameLoaderClient directly after creation. - https://bugs.webkit.org/show_bug.cgi?id=98149 + Web Inspector: [Device Metrics] "Fit window" results in duplicate rescaling in WebDevToolsAgentImpl::autoZoomPageToFitWidth() + https://bugs.webkit.org/show_bug.cgi?id=89092 + + Reviewed by Pavel Feldman. + + Do not apply the sizeRatio after it has been applied in scaledEmulatedFrameSize(). + + * src/WebDevToolsAgentImpl.cpp: + (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): + (WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor): + +2012-06-14 Yoshifumi Inoue <yosin@chromium.org> + + [Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi + https://bugs.webkit.org/show_bug.cgi?id=89062 + + Reviewed by Kent Tamura. + + This patch removes ENABLE_INPUT_TYPE_*=0 from default entry of feature_defines to + allows us overriding by ~/.gyp/include.gypi + + * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME=0, ENABLE_INPUT_TYPE_DATETIMELOCAL=0, + and so on. + +2012-06-14 Min Qin <qinmin@google.com> + + Remove the const keyword from MediaPlayerPrivate::enterFullscreen() + https://bugs.webkit.org/show_bug.cgi?id=89044 + + Reviewed by Adam Barth. + + enterFullscreen() should be treated similarly as exitFullscreen() as it could alter the player state. + This reverts the change from r120213. + + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::enterFullscreen): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-06-14 Dan Alcantara <dfalcantara@chromium.org> + + [chromium] Rename WebFrameClient::userAgent() to better reflect what it does + https://bugs.webkit.org/show_bug.cgi?id=89028 Reviewed by Adam Barth. - Adding willStartUsingPeerConnectionHandler to the WebFrameClient. + Renames WebFrameClient::userAgent() to userAgentOverride() and makes it return + the user agent override string directly. * public/WebFrameClient.h: - (WebKit): (WebFrameClient): - (WebKit::WebFrameClient::willStartUsingPeerConnectionHandler): + (WebKit::WebFrameClient::userAgentOverride): * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::userAgent): + * tests/FrameLoaderClientImplTest.cpp: + +2012-06-13 Jesse Greenwald <jgreenwald@google.com> + + [Chromium] Add WebDocument.images + https://bugs.webkit.org/show_bug.cgi?id=88837 + + Reviewed by Adam Barth. + + This method is needed on Android to support the existing + WebView.documentHasImages Java API. + + * public/WebDocument.h: + (WebDocument): + * src/WebDocument.cpp: + (WebKit::WebDocument::images): (WebKit): - (WebKit::FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler): + +2012-06-13 Dominic Cooney <dominicc@chromium.org> + + Unreviewed: Disable verifyHitTestingForSingleLayer. + https://bugs.webkit.org/show_bug.cgi?id=89065 + + It is failing on canary debug bots. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-06-13 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120268. + http://trac.webkit.org/changeset/120268 + https://bugs.webkit.org/show_bug.cgi?id=89060 + + WebCompositor::setPerTilePaintingEnabled hits an assertion in + DEBUG (Requested by dominicc|work on #webkit). + + * WebKit.gypi: + * public/WebCompositor.h: + (WebCompositor): + * public/WebSettings.h: + * src/WebCompositorImpl.cpp: + (WebKit::WebCompositor::shutdown): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCSettings): + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setPerTilePaintingEnabled): + (WebKit): + (WebKit::WebSettingsImpl::setPartialSwapEnabled): + (WebKit::WebSettingsImpl::setThreadedAnimationEnabled): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + * tests/CCTestCommon.h: Removed. + * tests/CCThreadedTest.cpp: + (WebKitTests::MockLayerTreeHostImpl::create): + (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (WebKitTests::CCThreadedTest::runTest): + * tests/CCThreadedTest.h: + (CCThreadedTest): + (MockLayerTreeHostImpl): + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + * tests/LayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (LayerRendererChromiumTest): + (TEST_F): + (TEST): + * tests/TextureLayerChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + * tests/TreeSynchronizerTest.cpp: + (WebKitTests::TEST): + +2012-06-13 Hironori Bono <hbono@chromium.org> + + [chromium] Add WebFrame::replaceMisspelledRange + https://bugs.webkit.org/show_bug.cgi?id=88618 + + Reviewed by Kent Tamura. + + This change adds WebFrame::replaceMisspelledRange, which replaces the range of a + misspelled marker with text so Chromium can use it for replacing misspelled + words with suggetions. + + * public/WebFrame.h: + (WebFrame): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::replaceMisspelledRange): + (WebKit): + * src/WebFrameImpl.h: + (WebFrameImpl): + +2012-06-13 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium] Let Android and Linux share WebFontRendering decl/impl. + https://bugs.webkit.org/show_bug.cgi?id=88802 + + Reviewed by Adam Barth. + + * WebKit.gyp: + * public/linux/WebFontRendering.h: Temporarily forwards to the new file under linuxish. + * public/linuxish: Added. + * public/linuxish/WebFontRendering.h: Copied from chromium/public/linux/WebFontRendering.h. + * src/linux/WebFontRendering.cpp: Removed. + * src/linuxish: Added. + * src/linuxish/WebFontRendering.cpp: Copied from chromium/src/linux/WebFontRendering.cpp. + +2012-06-13 Ian Vollick <vollick@chromium.org> + + [chromium] Certain settings in CCSettings could be global + https://bugs.webkit.org/show_bug.cgi?id=88384 + + Reviewed by James Robinson. + + * WebKit.gypi: + * public/WebCompositor.h: + (WebCompositor): + * public/WebSettings.h: + * src/WebCompositorImpl.cpp: + (WebKit::WebCompositor::shutdown): + (WebKit): + (WebKit::WebCompositor::setPerTilePaintingEnabled): + (WebKit::WebCompositor::setPartialSwapEnabled): + (WebKit::WebCompositor::setAcceleratedAnimationEnabled): + * src/WebLayerTreeView.cpp: + (WebKit): + (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): + * src/WebSettingsImpl.cpp: + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::WebViewImpl): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF): + (CCLayerTreeHostTestShortlived1): + (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): + (WTF::CCLayerTreeHostTestShortlived1::beginTest): + (WTF::CCLayerTreeHostTestShortlived1::afterTest): + * tests/CCTestCommon.h: Added. + (WebKitTests): + (CCScopedSettings): + (WebKitTests::CCScopedSettings::CCScopedSettings): + (WebKitTests::CCScopedSettings::~CCScopedSettings): + * tests/CCThreadedTest.cpp: + (WebKitTests::MockLayerTreeHostImpl::create): + (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (WebKitTests::CCThreadedTest::runTest): + * tests/CCThreadedTest.h: + (CCThreadedTest): + (MockLayerTreeHostImpl): + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + * tests/LayerChromiumTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (LayerRendererChromiumTest): + (TEST_F): + (TEST): + * tests/TextureLayerChromiumTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + * tests/TreeSynchronizerTest.cpp: + (WebKitTests::TEST): + +2012-06-13 Dana Jansens <danakj@chromium.org> + + [chromium] Assert if iterating an invalid RenderSurfaceLayerList, where a layer in the list has no RenderSurface + https://bugs.webkit.org/show_bug.cgi?id=89004 + + Reviewed by Adrienne Walker. + + * tests/CCLayerIteratorTest.cpp: + +2012-06-13 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Implement hit-testing for impl-side input handling in accelerated compositor + https://bugs.webkit.org/show_bug.cgi?id=88972 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-06-13 David Reveman <reveman@chromium.org> + + [Chromium] Crash when WebViewImpl::setIsTransparent is called before the WebLayerTreeView has been initialized. + https://bugs.webkit.org/show_bug.cgi?id=89013 + + Reviewed by James Robinson. + + Add !m_layerTreeView.isNull() check to WebViewImpl::setIsTransparent. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsTransparent): + +2012-06-13 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120220. + http://trac.webkit.org/changeset/120220 + https://bugs.webkit.org/show_bug.cgi?id=89021 + + The patch broke build Chromium Win Release (Requested by + wangxianzhu on #webkit). + + * WebKit.gyp: + * public/linux/WebFontRendering.h: + (WebKit): + (WebFontRendering): + * public/linuxish/WebFontRendering.h: Removed. + * src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. + (WebKit): + (WebKit::WebFontRendering::setHinting): + (WebKit::WebFontRendering::setAntiAlias): + (WebKit::WebFontRendering::setSubpixelGlyphs): + (WebKit::WebFontRendering::setSubpixelRendering): + (WebKit::WebFontRendering::setSubpixelPositioning): + (WebKit::WebFontRendering::setLCDOrder): + (WebKit::WebFontRendering::setLCDOrientation): + +2012-06-13 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium] Let Android and Linux share WebFontRendering decl/impl. + https://bugs.webkit.org/show_bug.cgi?id=88802 + + Reviewed by Adam Barth. + + * WebKit.gyp: + * public/linux/WebFontRendering.h: Temporarily forwards to the new file under linuxish. + * public/linuxish: Added. + * public/linuxish/WebFontRendering.h: Copied from chromium/public/linux/WebFontRendering.h. + * src/linux/WebFontRendering.cpp: Removed. + * src/linuxish: Added. + * src/linuxish/WebFontRendering.cpp: Copied from chromium/src/linux/WebFontRendering.cpp. + +2012-06-13 Martin Kosiba <mkosiba@google.com> + + [Chromium] WebFrameImpl::find doesn't work for searching from a selection. + https://bugs.webkit.org/show_bug.cgi?id=88885 + + Reviewed by Adam Barth. + + Remember the active match not just until the seatchText changes but for the entire find session. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::find): + (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): + +2012-06-13 Peter Beverloo <peter@chromium.org> + + [Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1 + https://bugs.webkit.org/show_bug.cgi?id=88987 + + Reviewed by Simon Hausmann. + + The enterFullscreen method is declared as const by MediaPlayerPrivateInterface, + so this one should be declared as such as well. + + Patch by Evgeniy Stepanov <eugenis@google.com> + + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::enterFullscreen): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-06-13 MORITA Hajime <morrita@google.com> + + REGRESSION(r118098): <content> element does not render distributed children when cloned from another document + https://bugs.webkit.org/show_bug.cgi?id=88148 + + Reviewed by Dimitri Glazkov. + + - Added ContextFeaturesClientImpl which implements WebCore::ContextFeaturesClient. + - Replaced PagePopupFrameLoaderClient with PagePopupFeaturesClient. + + * WebKit.gyp: + * public/WebPermissionClient.h: + (WebKit): + (WebKit::WebPermissionClient::allowWebComponents): + * src/ContextFeaturesClientImpl.cpp: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.cpp. + (WebKit): + (WebKit::ContextFeaturesClientImpl::isEnabled): + * src/ContextFeaturesClientImpl.h: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.h. + (WebKit): + (ContextFeaturesClientImpl): + (WebKit::ContextFeaturesClientImpl::ContextFeaturesClientImpl): + (WebKit::ContextFeaturesClientImpl::setPermissionClient): + * src/FrameLoaderClientImpl.cpp: + * src/FrameLoaderClientImpl.h: + (FrameLoaderClientImpl): + * src/WebPagePopupImpl.cpp: + (PagePopupFeaturesClient): + (WebKit::PagePopupFeaturesClient::isEnabled): + (WebKit): + (WebKit::WebPagePopupImpl::initPage): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setPermissionClient): + (WebKit::WebViewImpl::WebViewImpl): + * src/WebViewImpl.h: + (WebKit): + +2012-06-12 Ian Vollick <vollick@chromium.org> + + [chromium] Roll chromium rev in DEPS + https://bugs.webkit.org/show_bug.cgi?id=88934 + + Reviewed by James Robinson. + + Rolling to 141410 + + * DEPS: + +2012-06-12 James Robinson <jamesr@chromium.org> + + [chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer + https://bugs.webkit.org/show_bug.cgi?id=88597 + + Reviewed by Adrienne Walker. + + Implementations for new WebExternalTextureLayer APIs, updates test. + + * src/WebExternalTextureLayer.cpp: + (WebKit::WebExternalTextureLayer::willModifyTexture): + (WebKit): + (WebKit::WebExternalTextureLayer::setRateLimitContext): + * tests/Canvas2DLayerBridgeTest.cpp: + (Canvas2DLayerBridgeTest::fullLifecycleTest): + +2012-06-12 Adrienne Walker <enne@google.com> + + [chromium] Paint scrollbars on WebKit thread and composite those textures + https://bugs.webkit.org/show_bug.cgi?id=88145 + + Reviewed by James Robinson. + + Remove scrollbarLayerLostContext test that no longer makes sense. The + compositor won't draw at all after a lost context if it has no + contents. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-12 Joshua Bell <jsbell@chromium.org> + + IndexedDB: ObjectStore/Index shouldn't hold reference to backing store + https://bugs.webkit.org/show_bug.cgi?id=83074 + + Reviewed by Tony Chang. + + * WebKit.gypi: + * tests/IDBDatabaseBackendTest.cpp: Added. + (WebCore): + (WebCore::TEST): + +2012-06-12 Dana Jansens <danakj@chromium.org> + + [chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests + https://bugs.webkit.org/show_bug.cgi?id=88903 + + Reviewed by Adrienne Walker. + + Without setting the contentBounds() on impl layers, the visibleLayerRect + will be wrong. This is not the case for main-thread layers, which most + of the tests in this file use. But this is a potential serious confusion + for future test implementors so I'd like to make it explicit now. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-06-12 Dana Jansens <danakj@chromium.org> + + [chromium] Return empty visibleLayerRect for layers with empty content bounds + https://bugs.webkit.org/show_bug.cgi?id=88901 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-12 Mark Mentovai <mark@chromium.org> + + [chromium mac] Don't #include things in subframeworks of + ApplicationServices.framework. + + #including the umbrella <ApplicatonServices/ApplicationServices.h> + exposed an ambiguous name, FontMetrics, that needs to be fully + qualified as WebCore::FontMetrics. + + https://bugs.webkit.org/show_bug.cgi?id=88569 + + Reviewed by Stephen White. + + * src/WebFontImpl.cpp: + (WebKit::WebFontImpl::estimateTextBounds): + +2012-06-12 James Robinson <jamesr@chromium.org> + + [chromium] REGRESSION(119769): Canvas2DLayerBridge may go away before its TextureLayerChromium + https://bugs.webkit.org/show_bug.cgi?id=88910 + + Reviewed by Adrienne Walker. + + New unit test to verify that we can still update a TextureLayerChromium after the bridge owning it has gone + away. + + * tests/Canvas2DLayerBridgeTest.cpp: + +2012-06-12 Adrienne Walker <enne@google.com> + + [chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages + https://bugs.webkit.org/show_bug.cgi?id=88887 + + Reviewed by James Robinson. + + The scroll position on layers needs to take into account the scroll + origin, since RTL pages start scrolled all the way to the right. + Otherwise, when scrolling left the scroll position incorrectly will go + negative, causing havok in scrollbar theme code that just assumes that + it's always scrolled all the way to the left. + + Also, now that the scroll origin is passed into NCCH, handle + scrollOrigin.y() for layer adjusting. This is always zero in practice, + but it seemed awkward to just drop it and that assumption could always + change in the future. + + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::setViewport): + (WebKit::NonCompositedContentHost::paintContents): + * src/NonCompositedContentHost.h: + (NonCompositedContentHost): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::updateLayerTreeViewport): + +2012-06-12 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Make damage tracking more robust to early exits + https://bugs.webkit.org/show_bug.cgi?id=84803 + + Reviewed by James Robinson. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::clearDamageForAllSurfaces): + (WebKitTests::TEST_F): + +2012-06-12 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r120051. + http://trac.webkit.org/changeset/120051 + https://bugs.webkit.org/show_bug.cgi?id=88852 + + some tests are crashing (Requested by morrita on #webkit). + + * WebKit.gyp: + * public/WebPermissionClient.h: + (WebKit::WebPermissionClient::allowWebComponents): + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::allowShadowDOM): + (WebKit): + (WebKit::FrameLoaderClientImpl::allowStyleScoped): * src/FrameLoaderClientImpl.h: (FrameLoaderClientImpl): + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::initPage): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setPermissionClient): + (WebKit::WebViewImpl::WebViewImpl): + * src/WebViewImpl.h: + (WebKit): + +2012-06-12 MORITA Hajime <morrita@google.com> + + REGRESSION(r118098): <content> element does not render distributed children when cloned from another document + https://bugs.webkit.org/show_bug.cgi?id=88148 + + Reviewed by Dimitri Glazkov. + + - Added ContextFeaturesClientImpl which implements WebCore::ContextFeaturesClient. + - Replaced PagePopupFrameLoaderClient with PagePopupFeaturesClient. + + * WebKit.gyp: + * public/WebPermissionClient.h: + (WebKit): + (WebKit::WebPermissionClient::allowWebComponents): + * src/ContextFeaturesClientImpl.cpp: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.cpp. + (WebKit): + (WebKit::ContextFeaturesClientImpl::isEnabled): + * src/ContextFeaturesClientImpl.h: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.h. + (WebKit): + (ContextFeaturesClientImpl): + (WebKit::ContextFeaturesClientImpl::ContextFeaturesClientImpl): + (WebKit::ContextFeaturesClientImpl::setPermissionClient): + * src/FrameLoaderClientImpl.cpp: + * src/FrameLoaderClientImpl.h: + (FrameLoaderClientImpl): + * src/WebPagePopupImpl.cpp: + (PagePopupFeaturesClient): + (WebKit::PagePopupFeaturesClient::isEnabled): + (WebKit): + (WebKit::WebPagePopupImpl::initPage): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setPermissionClient): + (WebKit::WebViewImpl::WebViewImpl): + * src/WebViewImpl.h: + (WebKit): + +2012-06-11 Nico Weber <thakis@chromium.org> + + Remove unused member variables found by clang's -Wunused-private-field + https://bugs.webkit.org/show_bug.cgi?id=88812 + + Reviewed by Anders Carlsson. + + * src/AudioDestinationChromium.cpp: + (WebCore::AudioDestinationChromium::AudioDestinationChromium): + * src/AudioDestinationChromium.h: + (AudioDestinationChromium): + * src/InspectorFrontendClientImpl.cpp: + (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): + * src/InspectorFrontendClientImpl.h: + (InspectorFrontendClientImpl): + * src/WebFrameImpl.cpp: + (ChromePluginPrintContext): + * src/WebInputEvent.cpp: + * src/WorkerAsyncFileSystemChromium.cpp: + (WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge): + * src/WorkerAsyncFileWriterChromium.cpp: + (WebCore::WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium): + * src/WorkerAsyncFileWriterChromium.h: + (WorkerAsyncFileWriterChromium): + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestSetVisible::CCLayerTreeHostTestSetVisible): + (CCLayerTreeHostTestSetVisible): + +2012-06-11 Vincent Scheib <scheib@chromium.org> + + Consolidate Pointer Lock runtime enabled flags to just one. + https://bugs.webkit.org/show_bug.cgi?id=88810 + + Reviewed by Dimitri Glazkov. + + * src/WebRuntimeFeatures.cpp: + (WebKit::WebRuntimeFeatures::enablePointerLock): + (WebKit::WebRuntimeFeatures::isPointerLockEnabled): + +2012-06-11 Alexis Menard <alexis.menard@openbossa.org> + + [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag. + https://bugs.webkit.org/show_bug.cgi?id=88804 + + Reviewed by Tony Chang. + + Protect box-decoration-break behind a feature flag enabled by default. + + * features.gypi: + +2012-05-11 James Robinson <jamesr@chromium.org> + + [chromium] Port DrawingBufferChromium from TextureLayerChromium over to WebExternalTextureLayer + https://bugs.webkit.org/show_bug.cgi?id=86273 + + Reviewed by Adrienne Walker. + + * src/WebExternalTextureLayer.cpp: + (WebTextureUpdaterImpl): + (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): + (WebKit): + (WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): + (WebKit::WebExternalTextureLayer::create): + (WebKit::WebExternalTextureLayer::clearClient): + (WebKit::WebExternalTextureLayer::setOpaque): + (WebKit::WebExternalTextureLayer::setPremultipliedAlpha): + +2012-06-11 Dana Jansens <danakj@chromium.org> + + [chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad + https://bugs.webkit.org/show_bug.cgi?id=88363 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCTiledLayerTestCommon.h: + (WebKitTests::FakeTextureCopier::copyToTexture): + * tests/Canvas2DLayerChromiumTest.cpp: + +2012-06-11 Joshua Bell <jsbell@chromium.org> + + IndexedDB: Object stores are not successfully deleted + https://bugs.webkit.org/show_bug.cgi?id=88788 + + Reviewed by Tony Chang. + + * tests/IDBLevelDBCodingTest.cpp: + (IDBLevelDBCoding::TEST): -2012-10-03 Peter Kotwicz <pkotwicz@google.com> +2012-06-11 Shawn Singh <shawnsingh@chromium.org> - WebImage::framesFromData should skip corrupted frames - https://bugs.webkit.org/show_bug.cgi?id=98214 + [chromium] Implement position:fixed in compositor thread + https://bugs.webkit.org/show_bug.cgi?id=70103 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + +2012-06-11 Sam Weinig <sam@webkit.org> + + Remove support for disconnected/excluded from search frames, they are not used by Safari anymore + https://bugs.webkit.org/show_bug.cgi?id=88723 + + Reviewed by Dan Bernstein. + + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::scopeStringMatches): + +2012-06-11 Varun Jain <varunjain@chromium.org> + + [chromium] WebInputEvent::isGestureEventType should return true for GestureTwoFingerTap + https://bugs.webkit.org/show_bug.cgi?id=88789 Reviewed by Adam Barth. - WebImage::framesFromData() should only return bitmaps for valid frames - of a .ico file. + * public/WebInputEvent.h: + (WebKit::WebInputEvent::isGestureEventType): - * src/WebImageSkia.cpp: - (WebKit::WebImage::framesFromData): - * tests/WebImageTest.cpp: +2012-06-11 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Call shared timer functions directly + https://bugs.webkit.org/show_bug.cgi?id=88781 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-06-11 Amy Ousterhout <aousterh@chromium.org> + + [Chromium] Removing long WebDeviceOrientation constructor + https://bugs.webkit.org/show_bug.cgi?id=88779 + + Reviewed by Adam Barth. + + Removing the WebDeviceOrientation constructor with nine parameters. + Chromium has been changed to use the default constructor and setter + functions instead (see https://chromiumcodereview.appspot.com/10542025/). + + * public/WebDeviceOrientation.h: + +2012-06-11 David Dorwin <ddorwin@chromium.org> + + [chromium] Provide access to the WebPlugin created by the helper plugin widget + https://bugs.webkit.org/show_bug.cgi?id=88028 + + Reviewed by Adam Barth. + + A WebPlugin is created when the document created by createHelperPlugin() is laid out. + Expose it so the embedder can interact with the plugin instance. + + * public/WebHelperPlugin.h: + (WebKit): + (WebHelperPlugin): + * public/WebMediaPlayerClient.h: + (WebKit): + * public/WebPlugin.h: + (WebKit::WebPlugin::isPlaceholder): + (WebPlugin): + * src/WebHelperPluginImpl.cpp: + (WebKit::WebHelperPluginImpl::WebHelperPluginImpl): + (WebKit): + (WebKit::WebHelperPluginImpl::getPlugin): + (WebKit::WebHelperPluginImpl::initPage): + (WebKit::WebHelperPluginImpl::close): + * src/WebHelperPluginImpl.h: + (WebKit): + (WebHelperPluginImpl): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::createHelperPlugin): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + * src/WebPagePopupImpl.cpp: + +2012-06-05 Dana Jansens <danakj@chromium.org> + + [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed + https://bugs.webkit.org/show_bug.cgi?id=88371 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-11 Kent Tamura <tkent@chromium.org> + + [Chromium] Should call frameDetached() in WebPagePopupImpl::close() + https://bugs.webkit.org/show_bug.cgi?id=88754 + + Reviewed by Adam Barth. + + * src/WebPagePopupImpl.cpp: + (WebKit::WebPagePopupImpl::close): Calls FrameLoader::frameDetached(). + +2012-06-11 Min Qin <qinmin@google.com> + + Adding a flag to show fullscreen media controls in chromium + https://bugs.webkit.org/show_bug.cgi?id=88266 + + Reviewed by Adam Barth. + + Adding a flag to the gyp file so that we can enable fullscreen media control + + * features.gypi: + +2012-06-09 Eugene Klyuchnikov <eustas.bug@gmail.com> + + Web Inspector: Add message loop instrumentation to public API and timeline agent + https://bugs.webkit.org/show_bug.cgi?id=88639 + + Reviewed by Vsevolod Vlasov. + + Message loop instrumentation will show when the render thread is busy. + That way developer can discover if a render thread business causes low fps, or not. + + * public/WebDevToolsAgent.h: + (WebDevToolsAgent): + * public/WebDevToolsAgentClient.h: + (WebDevToolsAgentClient): + (WebKit::WebDevToolsAgentClient::startMessageLoopMonitoring): + Request message loop notifications. + (WebKit::WebDevToolsAgentClient::stopMessageLoopMonitoring): + Cancel message loop notifications. + * src/InspectorClientImpl.cpp: + (WebKit::InspectorClientImpl::startMessageLoopMonitoring): + Request message loop notifications. + (WebKit): + (WebKit::InspectorClientImpl::stopMessageLoopMonitoring): + Cancel message loop notifications. + * src/InspectorClientImpl.h: + (InspectorClientImpl): + * src/WebDevToolsAgentImpl.cpp: + (WebKit::WebDevToolsAgentImpl::startMessageLoopMonitoring): + Request message loop notifications. + (WebKit): + (WebKit::WebDevToolsAgentImpl::stopMessageLoopMonitoring): + Cancel message loop notifications. + (WebKit::WebDevToolsAgentImpl::instrumentWillProcessTask): + Message loop notification. + (WebKit::WebDevToolsAgentImpl::instrumentDidProcessTask): + Ditto. + * src/WebDevToolsAgentImpl.h: + (WebDevToolsAgentImpl): + +2012-06-08 David Reveman <reveman@chromium.org> + + [Chromium] Compositor doesn't support translucent root layers. + https://bugs.webkit.org/show_bug.cgi?id=87821 + + Reviewed by James Robinson. + + * src/NonCompositedContentHost.cpp: + (WebKit::NonCompositedContentHost::setOpaque): + (WebKit): + * src/NonCompositedContentHost.h: + (NonCompositedContentHost): + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setHasTransparentBackground): + (WebKit): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsTransparent): + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + * tests/CCLayerTreeHostImplTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (ClearCountingContext): + (ClearCountingContext::ClearCountingContext): + (ClearCountingContext::clear): + (ClearCountingContext::clearCount): + (TEST): + +2012-06-08 Ian Vollick <vollick@chromium.org> + + [chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized + https://bugs.webkit.org/show_bug.cgi?id=88668 + + Reviewed by James Robinson. + + * WebKit.gypi: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest): + (WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread): + (WTF): + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation): + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::didAddAnimation): + (CCLayerTreeHostTestLayerAddedWithAnimation): + * tests/CCSingleThreadProxyTest.cpp: Added. + (FakeWebGraphicsContext3DMakeCurrentFails): + (FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent): + (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation): + (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation): + (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::beginTest): + (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers): + (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext): + (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::afterTest): + (TEST_F): + (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer): + (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer): + (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::beginTest): + (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::animateLayers): + (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didRecreateContext): + (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didAddAnimation): + (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::afterTest): + * tests/CCThreadedTest.cpp: Added. + (WebKitTests): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::create): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures): + (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking): + (WebKitTests::TestHooks::createContext): + (WebKitTests::MockLayerTreeHostImpl::create): + (WebKitTests::MockLayerTreeHostImpl::beginCommit): + (WebKitTests::MockLayerTreeHostImpl::commitComplete): + (WebKitTests::MockLayerTreeHostImpl::prepareToDraw): + (WebKitTests::MockLayerTreeHostImpl::drawLayers): + (WebKitTests::MockLayerTreeHostImpl::animateLayers): + (WebKitTests::MockLayerTreeHostImpl::lowFrequencyAnimationInterval): + (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): + (MockLayerTreeHost): + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (MockLayerTreeHostClient): + (WebKitTests::MockLayerTreeHostClient::create): + (WebKitTests::MockLayerTreeHostClient::MockLayerTreeHostClient): + (TimeoutTask): + (WebKitTests::TimeoutTask::TimeoutTask): + (WebKitTests::TimeoutTask::clearTest): + (WebKitTests::TimeoutTask::~TimeoutTask): + (WebKitTests::TimeoutTask::run): + (BeginTask): + (WebKitTests::BeginTask::BeginTask): + (WebKitTests::BeginTask::~BeginTask): + (WebKitTests::BeginTask::run): + (EndTestTask): + (WebKitTests::EndTestTask::EndTestTask): + (WebKitTests::EndTestTask::~EndTestTask): + (WebKitTests::EndTestTask::clearTest): + (WebKitTests::EndTestTask::run): + (WebKitTests::CCThreadedTest::CCThreadedTest): + (WebKitTests::CCThreadedTest::endTest): + (WebKitTests::CCThreadedTest::endTestAfterDelay): + (WebKitTests::CCThreadedTest::postSetNeedsAnimateToMainThread): + (WebKitTests::CCThreadedTest::postAddAnimationToMainThread): + (WebKitTests::CCThreadedTest::postAddInstantAnimationToMainThread): + (WebKitTests::CCThreadedTest::postSetNeedsCommitToMainThread): + (WebKitTests::CCThreadedTest::postAcquireLayerTextures): + (WebKitTests::CCThreadedTest::postSetNeedsRedrawToMainThread): + (WebKitTests::CCThreadedTest::postSetNeedsAnimateAndCommitToMainThread): + (WebKitTests::CCThreadedTest::postSetVisibleToMainThread): + (WebKitTests::CCThreadedTest::postDidAddAnimationToMainThread): + (WebKitTests::CCThreadedTest::doBeginTest): + (WebKitTests::CCThreadedTest::timeout): + (WebKitTests::CCThreadedTest::scheduleComposite): + (WebKitTests::CCThreadedTest::onEndTest): + (WebKitTests::CCThreadedTest::dispatchSetNeedsAnimate): + (WebKitTests::CCThreadedTest::dispatchAddInstantAnimation): + (WebKitTests::CCThreadedTest::dispatchAddAnimation): + (WebKitTests::CCThreadedTest::dispatchSetNeedsAnimateAndCommit): + (WebKitTests::CCThreadedTest::dispatchSetNeedsCommit): + (WebKitTests::CCThreadedTest::dispatchAcquireLayerTextures): + (WebKitTests::CCThreadedTest::dispatchSetNeedsRedraw): + (WebKitTests::CCThreadedTest::dispatchSetVisible): + (WebKitTests::CCThreadedTest::dispatchSetInvisible): + (WebKitTests::CCThreadedTest::dispatchComposite): + (WebKitTests::CCThreadedTest::dispatchDidAddAnimation): + (WebKitTests::CCThreadedTest::runTest): + * tests/CCThreadedTest.h: Added. + (WebCore): + (WebKit): + (WebKitTests): + (TestHooks): + (WebKitTests::TestHooks::beginCommitOnCCThread): + (WebKitTests::TestHooks::commitCompleteOnCCThread): + (WebKitTests::TestHooks::prepareToDrawOnCCThread): + (WebKitTests::TestHooks::drawLayersOnCCThread): + (WebKitTests::TestHooks::animateLayers): + (WebKitTests::TestHooks::willAnimateLayers): + (WebKitTests::TestHooks::applyScrollAndScale): + (WebKitTests::TestHooks::updateAnimations): + (WebKitTests::TestHooks::layout): + (WebKitTests::TestHooks::didRecreateContext): + (WebKitTests::TestHooks::didAddAnimation): + (WebKitTests::TestHooks::didCommit): + (WebKitTests::TestHooks::didCommitAndDrawFrame): + (WebKitTests::TestHooks::scheduleComposite): + (WebKitTests::TestHooks::notifyAnimationStarted): + (WebKitTests::TestHooks::notifyAnimationFinished): + (CCThreadedTest): + (WebKitTests::CCThreadedTest::clearTimeout): + (WebKitTests::CCThreadedTest::clearEndTestTask): + (WebKitTests::CCThreadedTest::layerTreeHost): + (CCThreadedTestThreadOnly): + (WebKitTests::CCThreadedTestThreadOnly::runTestThreaded): + (MockLayerTreeHostImpl): + (CompositorFakeWebGraphicsContext3DWithTextureTracking): + +2012-06-08 David Grogan <dgrogan@chromium.org> + + IndexedDB: rename some instances of open to registerFrontendCallbacks + https://bugs.webkit.org/show_bug.cgi?id=88611 + + Reviewed by Tony Chang. + + * src/IDBDatabaseBackendProxy.cpp: + (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks): + * src/IDBDatabaseBackendProxy.h: + (IDBDatabaseBackendProxy): + * src/WebIDBDatabaseImpl.cpp: + (WebKit::WebIDBDatabaseImpl::open): + * src/WebIDBDatabaseImpl.h: + (WebIDBDatabaseImpl): + +2012-06-08 Dana Jansens <danakj@chromium.org> + + [chromium] Skip willDraw() and didDraw() on fully occluded layers + https://bugs.webkit.org/show_bug.cgi?id=88435 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-08 James Robinson <jamesr@chromium.org> + + [chromium] Clean up some unnecessary LayerChromium.h includes + https://bugs.webkit.org/show_bug.cgi?id=88599 + + Reviewed by Adam Barth. + + Removes unused include, update comment. + + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::platformLayer): + (WebKit::WebMediaPlayerClientImpl::paint): + +2012-06-08 Jochen Eisinger <jochen@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-08 Ian Vollick <vollick@chromium.org> + + [chromium] Accelerated animations should use WebTransformOperations + https://bugs.webkit.org/show_bug.cgi?id=87686 + + Reviewed by James Robinson. + + CCTransformKeyframe new owns a WebTransformOperations rather than a + TransformOperations. LayerChromium's API has been changed so that + LayerChromium::addAnimation should take only a CCActiveAnimation. + GraphicsLayerChromium is new responsible for translating to + WebTransformOperations and creating CCActiveAnimations. Tests that use + the public API (that is, they call addAnimation with KeyframeValueList + and Animation arguments) have been moved to GraphicsLayerChromiumTest. + + * tests/CCAnimationTestCommon.cpp: + (WebCore::addOpacityTransition): + (WebCore::addAnimatedTransform): + (WebKitTests::FakeTransformTransition::getValue): + * tests/CCAnimationTestCommon.h: + * tests/CCKeyframedAnimationCurveTest.cpp: + * tests/CCLayerAnimationControllerTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): + * tests/GraphicsLayerChromiumTest.cpp: + (MockLayerTreeHostClient): + (WebKitTests): + (MockLayerTreeHost): + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (GraphicsLayerChromiumTest): + (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + (WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): + (WebKitTests::GraphicsLayerChromiumTest::expectTranslateX): + (WebKitTests::TEST_F): + * tests/LayerChromiumTest.cpp: + +2012-06-08 Robert Kroeger <rjkroege@chromium.org> + + More than 8 fingers get ignored by touch + https://bugs.webkit.org/show_bug.cgi?id=88359 + + Reviewed by James Robinson. + + * public/WebInputEvent.h: Increase of TouchPoints per TouchEvent from 8 to 12. + +2012-06-08 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-08 Taiju Tsuiki <tzik@chromium.org> + + Add FileSystem item to storage tree. + https://bugs.webkit.org/show_bug.cgi?id=72691 + + Reviewed by Vsevolod Vlasov. + + * src/js/DevTools.js: + +2012-06-08 Peter Beverloo <peter@chromium.org> + + [Chromium] Re-enable SHARED_WORKERS for Android until a build fix has been resolved. + https://bugs.webkit.org/show_bug.cgi?id=88637 + + Unreviewed build fix. + + Linking content_shell on the Chromium side fails due to an unresolved + call to WebSharedWorker::create(). Since this blocks WebKit rolls, + temporarily re-enable the feature until this has been solved. + + * features.gypi: + +2012-06-07 Nico Weber <thakis@chromium.org> + + [chromium/mac] Improve deviceDPI, rect, and availableRect computation + https://bugs.webkit.org/show_bug.cgi?id=88596 + + Reviewed by Adam Barth. + + Set deviceDPI to 160 for normal displays and 320 for HiDPI displays. + (Why 160? That's what chromium's render_view.cc assumes as default + single-resolution resolution at the moment. The only other place + where this number gets used is fixed layout mode, which is currently + not enabled.) + + Also fix rect and availableRect computations: They get returned in + user space already. + + Needed for http://crbug.com/31960. + + * src/mac/WebScreenInfoFactory.mm: + (WebKit::toUserSpace): + (WebKit::deviceScaleFactor): + (WebKit): + (WebKit::WebScreenInfoFactory::screenInfo): + +2012-06-07 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move didStartWorkerRunLoop to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=88562 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-06-05 James Robinson <jamesr@chromium.org> + + [chromium] Move deferral-related logic out of Canvas2DLayerChromium + https://bugs.webkit.org/show_bug.cgi?id=86050 + + Reviewed by Stephen White. + + * WebKit.gypi: + * tests/Canvas2DLayerBridgeTest.cpp: Renamed from tests/Canvas2DLayerChromiumTest + (Canvas2DLayerBridgeTest): + (Canvas2DLayerBridgeTest::fullLifecycleTest): + +2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r119744. + http://trac.webkit.org/changeset/119744 + https://bugs.webkit.org/show_bug.cgi?id=88584 + + Fails assertions in debug builds (Requested by jamesr_ on + #webkit). + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-07 Adam Barth <abarth@webkit.org> + + Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor + https://bugs.webkit.org/show_bug.cgi?id=88375 + + Reviewed by James Robinson. + + * public/WebSettings.h: + (WebKit::WebSettings::setDefaultDeviceScaleFactor): + (WebSettings): + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): + * src/WebSettingsImpl.cpp: + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + * tests/WebFrameTest.cpp: + (WebKit::TEST_F): + +2012-06-07 Peter Beverloo <peter@chromium.org> + + [Chromium] features.gypi should have the correct definitions for Android + https://bugs.webkit.org/show_bug.cgi?id=88533 + + Reviewed by Adam Barth. + + Make all features which are enabled on Android but disabled on other platforms, + or are disabled on Android while enabled on other platforms, conditional. This + also means that the selection of code compiled for Android will slightly change. + + This change also removes the enable_viewport variable as the value of this is + no longer respected by WebKit - it's enabled by default for all of Chromium. + Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again. + + * features.gypi: + +2012-06-07 Dana Jansens <danakj@chromium.org> + + [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed + https://bugs.webkit.org/show_bug.cgi?id=88371 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-07 Ami Fischman <fischman@chromium.org> + + Plumb CORS attribute information from HTMLMediaElement to media players so it can be used + https://bugs.webkit.org/show_bug.cgi?id=88349 + + Reviewed by Adam Barth. + + * public/WebMediaPlayer.h: + (WebMediaPlayer): + * src/AssertMatchingEnums.cpp: + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::loadInternal): + (WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck): + (WebKit): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-06-07 Daniel Erat <derat@chromium.org> + + Add setting to enable subpixel-positioned text on Linux. + https://bugs.webkit.org/show_bug.cgi?id=88263 + + Reviewed by Tony Chang. + + Add subpixel positioning field to WebFontRenderStyle and rename + subpixel rendering field. Make similar changes in + WebFontRendering. + + Also add global WebFontInfo::setSubpixelPositioning() to turn + subpixel positioning on or off (there's not currently a + well-defined way to configure subpixel positioning via FontConfig). + + * public/linux/WebFontInfo.h: + (WebFontInfo): + * public/linux/WebFontRenderStyle.h: + * public/linux/WebFontRendering.h: + (WebFontRendering): + * src/linux/WebFontInfo.cpp: + (WebKit): + (WebKit::WebFontInfo::setSubpixelPositioning): + (WebKit::WebFontInfo::renderStyleForStrike): + * src/linux/WebFontRenderStyle.cpp: + (WebKit::WebFontRenderStyle::toFontRenderStyle): + (WebKit::WebFontRenderStyle::setDefaults): + * src/linux/WebFontRendering.cpp: + (WebKit::WebFontRendering::setSubpixelGlyphs): + (WebKit): + (WebKit::WebFontRendering::setSubpixelRendering): + (WebKit::WebFontRendering::setSubpixelPositioning): + +2012-06-06 Dana Jansens <danakj@chromium.org> + + [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called + https://bugs.webkit.org/show_bug.cgi?id=88469 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r119694. + http://trac.webkit.org/changeset/119694 + https://bugs.webkit.org/show_bug.cgi?id=88529 + + it broke PrerenderBrowserTest.PrerenderHTML5VideoNetwork + (Requested by loislo on #webkit). + + * public/WebMediaPlayer.h: + (WebMediaPlayer): + * src/AssertMatchingEnums.cpp: + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::loadInternal): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r119689. + http://trac.webkit.org/changeset/119689 + https://bugs.webkit.org/show_bug.cgi?id=88516 + + it broke didDrawNotCalledOnScissoredLayer webkit_unit_test + (Requested by loislo on #webkit). + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-07 Ami Fischman <fischman@chromium.org> + + Plumb CORS attribute information from HTMLMediaElement to media players so it can be used + https://bugs.webkit.org/show_bug.cgi?id=88349 + + Reviewed by Adam Barth. + + * public/WebMediaPlayer.h: + (WebMediaPlayer): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::loadInternal): + +2012-06-07 Yoshifumi Inoue <yosin@chromium.org> + + [Platform] Introduce conversion from/to Deciaml to/from double and helper functions + https://bugs.webkit.org/show_bug.cgi?id=88480 + + Reviewed by Kent Tamura. + + This patch added tests for Decimal::fromDouble, isInfinity, toDouble. + + * tests/DecimalTest.cpp: + (TEST_F): + +2012-06-07 Ami Fischman <fischman@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-06 Dana Jansens <danakj@chromium.org> + + [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called + https://bugs.webkit.org/show_bug.cgi?id=88469 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-06 Kent Tamura <tkent@chromium.org> + + Unreviewed, rolling out r60044. + http://trac.webkit.org/changeset/60044 + + It made a regression, crbug.com/114922. + + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll): Do not hide popups by scrolling. + (WebKit::ChromeClientImpl::scroll): ditto. + +2012-06-06 Noel Gordon <noel.gordon@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: Roll to chromium 140955. + +2012-06-06 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r119683. + http://trac.webkit.org/changeset/119683 + https://bugs.webkit.org/show_bug.cgi?id=88505 + + it broke webkit-unit-test + WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac + (Requested by loislo on #webkit). + + * tests/CCLayerTreeHostTest.cpp: + (WTF::MockLayerTreeHost::create): + * tests/Canvas2DLayerChromiumTest.cpp: + (Canvas2DLayerChromiumTest::fullLifecycleTest): + +2012-06-06 Robert Kroeger <rjkroege@chromium.org> + + [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows + https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for precise + scrolling deltas on all Chromium platforms. + + Reviewed by James Robinson. + + * src/WebInputEventConversion.cpp: + (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): Create PlatformWheelEvents + with m_hasPreciseScrollingDelta flag as required. + * tests/ScrollAnimatorNoneTest.cpp: Added new unit test condiiton for precise scrolling. + (TEST): + +2012-06-06 Michal Mocny <mmocny@google.com> + + [chromium] Stop dropping texture limits when the layer tree host becomes invisible, and initialize with 0 allocation. + https://bugs.webkit.org/show_bug.cgi?id=87747 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostTest.cpp: + (WTF::MockLayerTreeHost::create): + * tests/Canvas2DLayerChromiumTest.cpp: + (Canvas2DLayerChromiumTest::fullLifecycleTest): + +2012-06-06 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move createMessagePortChannel to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=85764 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * WebKit.gyp: + * public/WebFrame.h: + (WebFrame): + * public/WebMessagePortChannel.h: + * public/WebMessagePortChannelClient.h: + * public/WebSharedWorkerClient.h: + (WebSharedWorkerClient): + * public/platform/WebKitPlatformSupport.h: + (WebKit): + (WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue): + * src/PlatformMessagePortChannel.cpp: + (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): + * src/PlatformMessagePortChannel.h: + * src/SharedWorkerRepository.cpp: + * src/WebSharedWorkerImpl.cpp: + +2012-06-06 Amy Ousterhout <aousterh@chromium.org> + + [Chromium] DeviceOrientation cleanup + https://bugs.webkit.org/show_bug.cgi?id=88406 + + Reviewed by Kent Tamura. + + Made default constructor public and added a set function for each property. + This will allow us to remove the 8-parameter constructor. + + * public/WebDeviceOrientation.h: + (WebKit::WebDeviceOrientation::WebDeviceOrientation): + (WebKit::WebDeviceOrientation::setNull): + (WebKit::WebDeviceOrientation::setAlpha): + (WebKit::WebDeviceOrientation::setBeta): + (WebKit::WebDeviceOrientation::setGamma): + (WebKit::WebDeviceOrientation::setAbsolute): + (WebDeviceOrientation): + +2012-06-06 James Robinson <jamesr@chromium.org> + + [chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support + https://bugs.webkit.org/show_bug.cgi?id=86257 + + Reviewed by Kenneth Russell. + + * WebKit.gyp: + +2012-06-06 James Robinson <jamesr@chromium.org> + + [chromium] Unreviewed build fix, add an apparently used include of OwnArrayPtr.h back to GraphicsContext3DPrivate.h + https://bugs.webkit.org/show_bug.cgi?id=88468 + + * src/GraphicsContext3DPrivate.h: + +2012-06-06 James Robinson <jamesr@chromium.org> + + [chromium] Clean up GraphicsContext3D implementation + https://bugs.webkit.org/show_bug.cgi?id=88460 + + Reviewed by Kenneth Russell. + + Chromium's implementation of the GraphicsContext3D implementation has been somewhat messy for historical + reasons. The actual implementation of the majority of these functions is done by delegating to the Platform API + WebGraphicsContext3D. A few bits of functionality - extension mapping, some compositor functionality, a readback + utility - are implemented by code in WebKit. Previously, all GraphicsContext3D functions delegates to a clone of + the interface in GraphicsContext3DPrivate which in turn delegated to WebGraphicsContext3D. This required + duplicating the entire GraphicsContext3D interface and made updating the interface an epic pain in the rear. + + This patch provides the implementations of GraphicsContext3D functions in GraphicsContext3DChromium.cpp. Most of + these functions delegate directly to WebGraphicsContext3D. The ones that do not delegate to + GraphicsContext3DPrivate, which now has a dedicated header and cpp file. GraphicsContext3DPrivate.cpp implements + all GraphicsContext3DPrivate functions. I've also reordered the implementation files so that the function order + matches the associated header file and normalized the names of callback adapters. + + Refactor only, no change in functionality. Existing tests apply. + + * WebKit.gyp: + * src/Extensions3DChromium.cpp: + (WebCore::Extensions3DChromium::ensureEnabled): + (WebCore::Extensions3DChromium::getGraphicsResetStatusARB): + (WebCore::Extensions3DChromium::blitFramebuffer): + (WebCore::Extensions3DChromium::renderbufferStorageMultisample): + (WebCore::Extensions3DChromium::postSubBufferCHROMIUM): + (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM): + (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM): + (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM): + (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM): + (WebCore::Extensions3DChromium::setVisibilityCHROMIUM): + (WebCore::Extensions3DChromium::discardFramebufferEXT): + (WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM): + (WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE): + (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM): + (WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM): + (WebCore::Extensions3DChromium::texStorage2DEXT): + (WebCore::Extensions3DChromium::createQueryEXT): + (WebCore::Extensions3DChromium::deleteQueryEXT): + (WebCore::Extensions3DChromium::isQueryEXT): + (WebCore::Extensions3DChromium::beginQueryEXT): + (WebCore::Extensions3DChromium::endQueryEXT): + (WebCore::Extensions3DChromium::getQueryivEXT): + (WebCore::Extensions3DChromium::getQueryObjectuivEXT): + * src/GraphicsContext3DChromium.cpp: + (WebCore::GraphicsContext3D::GraphicsContext3D): + (WebCore::GraphicsContext3D::~GraphicsContext3D): + (WebCore::GraphicsContext3D::setContextLostCallback): + (WebCore::GraphicsContext3D::setErrorMessageCallback): + (WebCore::GraphicsContext3D::create): + (WebCore::GraphicsContext3D::platformGraphicsContext3D): + (WebCore::GraphicsContext3D::platformTexture): + (WebCore::GraphicsContext3D::grContext): + (WebCore::GraphicsContext3D::platformLayer): + (WebCore): + (WebCore::GraphicsContext3D::isGLES2Compliant): + (WebCore::GraphicsContext3D::isResourceSafe): + (WebCore::GraphicsContext3D::bindAttribLocation): + (WebCore::GraphicsContext3D::bufferData): + (WebCore::GraphicsContext3D::getActiveAttrib): + (WebCore::GraphicsContext3D::getActiveUniform): + (WebCore::GraphicsContext3D::getAttribLocation): + (WebCore::GraphicsContext3D::getContextAttributes): + (WebCore::GraphicsContext3D::getProgramInfoLog): + (WebCore::GraphicsContext3D::getShaderInfoLog): + (WebCore::GraphicsContext3D::getShaderSource): + (WebCore::GraphicsContext3D::getString): + (WebCore::GraphicsContext3D::getUniformLocation): + (WebCore::GraphicsContext3D::shaderSource): + (WebCore::GraphicsContext3D::texImage2D): + (WebCore::GraphicsContext3D::texSubImage2D): + (WebCore::GraphicsContext3D::reshape): + (WebCore::GraphicsContext3D::markContextChanged): + (WebCore::GraphicsContext3D::layerComposited): + (WebCore::GraphicsContext3D::markLayerComposited): + (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): + (WebCore::GraphicsContext3D::paintRenderingResultsToImageData): + (WebCore::GraphicsContext3D::paintCompositedResultsToCanvas): + (WebCore::GraphicsContext3D::getExtensions): + (WebCore::GraphicsContext3D::getInternalFramebufferSize): + * src/GraphicsContext3DPrivate.cpp: Added. + (WebCore): + (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate): + (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate): + (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext): + (WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D): + (GrMemoryAllocationChangedCallback): + (WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback): + (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged): + (WebCore::GraphicsContext3DPrivate::grContext): + (WebCore::GraphicsContext3DPrivate::markContextChanged): + (WebCore::GraphicsContext3DPrivate::layerComposited): + (WebCore::GraphicsContext3DPrivate::markLayerComposited): + (WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas): + (GraphicsContextLostCallbackAdapter): + (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter): + (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter): + (WebCore::GraphicsContextLostCallbackAdapter::onContextLost): + (WebCore::GraphicsContext3DPrivate::setContextLostCallback): + (GraphicsErrorMessageCallbackAdapter): + (WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter): + (WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter): + (WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage): + (WebCore::GraphicsContext3DPrivate::setErrorMessageCallback): + (WebCore::GraphicsContext3DPrivate::getExtensions): + (WebCore::GraphicsContext3DPrivate::initializeExtensions): + (WebCore::GraphicsContext3DPrivate::supportsExtension): + (WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled): + (WebCore::GraphicsContext3DPrivate::isExtensionEnabled): + (WebCore::GraphicsContext3DPrivate::isResourceSafe): + (GraphicsContext3DSwapBuffersCompleteCallbackAdapter): + (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter): + (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter): + (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete): + (WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM): + (GraphicsContext3DMemoryAllocationChangedCallbackAdapter): + (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter): + (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter): + (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged): + (WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM): + * src/GraphicsContext3DPrivate.h: + (GraphicsContext3DPrivate): + (WebCore::GraphicsContext3DPrivate::webContext): + (WebCore::GraphicsContext3DPrivate::preserveDrawingBuffer): + +2012-06-06 Sadrul Habib Chowdhury <sadrul@chromium.org> + + [chromium] Avoid limiting page-scale-factor when device-scale-factor is applied in the compositor. + https://bugs.webkit.org/show_bug.cgi?id=88417 + + Reviewed by James Robinson. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + +2012-06-06 Ami Fischman <fischman@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-06 Nico Weber <thakis@chromium.org> + + [chromium] Expose setPictographFontFamily through the chromium webkit api. + https://bugs.webkit.org/show_bug.cgi?id=88393 + + Reviewed by Adam Barth. + + This was added to WebCore in + https://bugs.webkit.org/show_bug.cgi?id=65197 + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setPictographFontFamily): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-06-06 Ryosuke Niwa <rniwa@webkit.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-06 Kinuko Yasuda <kinuko@chromium.org> + + Roll Chromium DEPS from r140700 to r140711. + + * DEPS: + +2012-06-06 Ami Fischman <fischman@chromium.org> + + [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349 + https://bugs.webkit.org/show_bug.cgi?id=88388 + + Reviewed by Darin Fisher. + + * public/WebMediaPlayer.h: + +2012-06-05 Ryosuke Niwa <rniwa@webkit.org> + + Roll Chromium DEPS from r140653 to r140700. + + * DEPS: + +2012-06-05 Kentaro Hara <haraken@chromium.org> + + Unreviewed, rolling out r119494. + http://trac.webkit.org/changeset/119494 + https://bugs.webkit.org/show_bug.cgi?id=87911 + + We found similar APIs are already implemented + + * public/WebWidget.h: + * src/WebViewImpl.cpp: + * src/WebViewImpl.h: + (WebViewImpl): + * tests/WebViewTest.cpp: + * tests/data/textarea.html: Removed. + +2012-06-05 Ryosuke Niwa <rniwa@webkit.org> + + Roll Chromium DEPS from r140528 to r140653. + + * DEPS: + +2012-06-05 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move createLocalStorageNamespace to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=85766 + + Reviewed by James Robinson. + + Part of a refactoring series. See tracking bug 82948. + + * WebKit.gyp: + * public/WebStorageArea.h: + * public/WebStorageNamespace.h: + * public/platform/WebKitPlatformSupport.h: + (WebKit): + (WebKitPlatformSupport): + +2012-06-05 Greg Billock <gbillock@google.com> + + New constructor for WebIntent to be used for delivery + https://bugs.webkit.org/show_bug.cgi?id=87143 + + Reviewed by Darin Fisher. + + When delivering an intent to webkit, the caller needs to be able to + provide the action, type, and data, and also extra data and ports. + + * public/WebIntent.h: + (WebIntent): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::deliverIntent): + * src/WebIntent.cpp: + (WebKit::WebIntent::WebIntent): + (WebKit): + (WebKit::WebIntent::reset): + (WebKit::WebIntent::messagePortChannelsRelease): + +2012-06-05 Ryosuke Niwa <rniwa@webkit.org> + + Roll Chromium DEPS from r140492 to r140528. + + * DEPS: + +2012-06-05 Seigo Nonaka <nona@chromium.org> + + [chromium] There is no way to retrieve composition character rectangle in WebKit/chromium + https://bugs.webkit.org/show_bug.cgi?id=87911 + + Reviewed by Ryosuke Niwa. + + Add an API for retreieving each character bounds in composition text. + This API is necessary for implementing IMR_QUERYCHARPOSITION message in Windows. + The message is used by Japanese IME for showing their window at the correct position. + + * public/WebWidget.h: + (WebWidget): + (WebKit::WebWidget::compositionCharacterBounds): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::compositionCharacterBounds): + (WebKit): + * src/WebViewImpl.h: + (WebViewImpl): + +2012-06-05 Dongwoo Im <dw.im@samsung.com> + + Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'. + https://bugs.webkit.org/show_bug.cgi?id=73176 + + Reviewed by Adam Barth. + + Two more APIs are added in Custom Scheme Handler specification. + http://dev.w3.org/html5/spec/Overview.html#custom-handlers + One is 'isProtocolHandlerRegistered' to query whether the specific URL + is registered or not. + The other is 'unregisterProtocolHandler' to remove the registered URL. + + * features.gypi: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'. + +2012-06-05 Kent Tamura <tkent@chromium.org> + + Move some function definitions in EmptyClients.h to EmptyClients.cpp + https://bugs.webkit.org/show_bug.cgi?id=88285 + + Reviewed by Ryosuke Niwa. + + * src/WebHelperPluginImpl.cpp: Remove unnecessary #includes, and add necessary #includes. + * src/WebPagePopupImpl.cpp: ditto. + +2012-06-05 Noel Gordon <noel.gordon@gmail.com> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-05 Adam Barth <abarth@webkit.org> + + EventHandler shouldn't dispatch fake mousemove events when scrolling on devices that don't have a mouse + https://bugs.webkit.org/show_bug.cgi?id=88270 + + Reviewed by James Robinson. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setDeviceSupportsMouse): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-06-04 Dana Jansens <danakj@chromium.org> + + [chromium] Remove redundant setNeedsCommit when prepareToDraw fails + https://bugs.webkit.org/show_bug.cgi?id=88246 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostImplTest.cpp: + +2012-06-04 Dana Jansens <danakj@chromium.org> + + [chromium] Allow CCLayerImpl to find its layer tree host, and use this for CCVideoLayerImpl instead of always-null pointer. + https://bugs.webkit.org/show_bug.cgi?id=88252 + + Reviewed by James Robinson. + + * tests/ScrollbarLayerChromiumTest.cpp: + (WebCore::TEST): + * tests/TreeSynchronizerTest.cpp: + (WebKitTests::expectTreesAreIdentical): + (WebKitTests::TEST): + +2012-06-04 Ryosuke Niwa <rniwa@webkit.org> + + yet another build fix attempt. + + * src/WebHelperPluginImpl.cpp: + +2012-06-04 Ryosuke Niwa <rniwa@webkit.org> + + Another Chromium Windows build fix attempt after r119411. + + * src/WebHelperPluginImpl.cpp: + +2012-06-04 Shawn Singh <shawnsingh@chromium.org> + + [chromium] CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer needs to be cleaner + https://bugs.webkit.org/show_bug.cgi?id=85245 + + Reviewed by James Robinson. + + Updated CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer + so that the test is clearer and cleaner. The original test was + covering what it needed, but in a confusing and not-so-practical + way. This patch adds comments and performs a tighter test so that + the intent is a bit more clear. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::TEST_F): + +2012-06-04 Ryosuke Niwa <rniwa@webkit.org> + + Fix attempt after r119411. + + * src/WebHelperPluginImpl.cpp: + +2012-06-04 Sadrul Habib Chowdhury <sadrul@chromium.org> + + [chromium] Fix software rendering for larger device-scale-factor + https://bugs.webkit.org/show_bug.cgi?id=88136 + + Reviewed by Darin Fisher. + + The fix is to apply the device-scale factor on the GraphicsContext. + (and add a WebWidgetClient::deviceScaleFactor method to facilitate that). + + * public/WebWidgetClient.h: + (WebWidgetClient): + (WebKit::WebWidgetClient::deviceScaleFactor): + * src/PageWidgetDelegate.cpp: + (WebKit::PageWidgetDelegate::paint): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::paint): + +2012-06-04 Sadrul Habib Chowdhury <sadrul@chromium.org> + + Combobox options and autofill options should not be scaled for device-scale factor. + https://bugs.webkit.org/show_bug.cgi?id=87921 + + Reviewed by Darin Fisher. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::applyAutofillSuggestions): + +2012-06-04 Dana Jansens <danakj@chromium.org> + + [chromium] Make LayerRendererChromium use RenderPasses instead of RenderSurfaces + https://bugs.webkit.org/show_bug.cgi?id=88132 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostImplTest.cpp: + * tests/LayerRendererChromiumTest.cpp: + (FakeCCRendererClient::FakeCCRendererClient): + (FakeCCRendererClient::rootRenderPass): + (FakeCCRendererClient): + (TEST_F): + +2012-06-04 David Dorwin <ddorwin@chromium.org> + + Enable Chromium media player to instantiate a plugin + https://bugs.webkit.org/show_bug.cgi?id=87399 + + Reviewed by Kent Tamura. + + Adds WebHelperPlugin, an off-screen widget that contains an <object> tag. + + * WebKit.gyp: + * public/WebHelperPlugin.h: Copied from Source/WebKit/chromium/public/WebPopupType.h. + (WebKit): + (WebHelperPlugin): + (WebKit::WebHelperPlugin::~WebHelperPlugin): + * public/WebMediaPlayerClient.h: + (WebKit): + * public/WebPopupType.h: + * public/WebView.h: + * public/WebViewClient.h: + (WebKit): + (WebViewClient): + (WebKit::WebViewClient::initializeHelperPluginWebFrame): + * src/WebFrameImpl.cpp: + (WebKit::WebFrameImpl::WebFrameImpl): + (WebKit::WebFrameImpl::initializeAsMainFrame): + * src/WebFrameImpl.h: + (WebFrameImpl): + * src/WebHelperPluginImpl.cpp: Added. + (WebKit): + (WebKit::addString): + (WebKit::writeDocument): + (HelperPluginChromeClient): + (WebKit::HelperPluginChromeClient::HelperPluginChromeClient): + (WebKit::WebHelperPluginImpl::WebHelperPluginImpl): + (WebKit::WebHelperPluginImpl::~WebHelperPluginImpl): + (WebKit::WebHelperPluginImpl::init): + (WebKit::WebHelperPluginImpl::initializeFrame): + (WebKit::WebHelperPluginImpl::initPage): + (WebKit::WebHelperPluginImpl::setCompositorSurfaceReady): + (WebKit::WebHelperPluginImpl::composite): + (WebKit::WebHelperPluginImpl::layout): + (WebKit::WebHelperPluginImpl::setFocus): + (WebKit::WebHelperPluginImpl::close): + (WebKit::WebHelperPluginImpl::closeHelperPlugin): + (WebKit::WebHelperPlugin::create): + * src/WebHelperPluginImpl.h: Copied from Source/WebKit/chromium/public/WebPopupType.h. + (WebCore): + (WebKit): + (WebHelperPluginImpl): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): + (WebKit::WebMediaPlayerClientImpl::createHelperPlugin): + (WebKit): + (WebKit::WebMediaPlayerClientImpl::closeHelperPlugin): + * src/WebMediaPlayerClientImpl.h: + (WebKit): + (WebMediaPlayerClientImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::initializeMainFrame): + (WebKit::WebViewImpl::initializeHelperPluginFrame): + (WebKit): + (WebKit::WebViewImpl::createHelperPlugin): + * src/WebViewImpl.h: + (WebKit): + (WebViewImpl): + +2012-06-04 Raymes Khoury <raymes@chromium.org> + + Remove obsolete acceptMIMETypes member. + https://bugs.webkit.org/show_bug.cgi?id=88241 + + Reviewed by Darin Fisher. + + Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=87271 and http://codereview.chromium.org/10414085/. + + * public/WebFileChooserParams.h: + (WebFileChooserParams): + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::runOpenPanel): + +2012-06-04 Zeev Lieber <zlieber@chromium.org> + + [chromium] Cleanup scissor rect computation/use with damage + https://bugs.webkit.org/show_bug.cgi?id=87167 + + Reviewed by Adrienne Walker. + + Added unit tests to CCLayerTreeHostImpl using mock graphic context + to verify end-to-end quad drawing. + + Added more test cases to CCLayerTreeHostCommon to verify clip and + scissor rect computations. + + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::executeCalculateDrawTransformsAndVisibility): + * tests/CCLayerIteratorTest.cpp: + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostImplTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): + * tests/CCRenderSurfaceTest.cpp: + +2012-06-03 Ryosuke Niwa <rniwa@webkit.org> + + Roll Chromium DEPS from r140222 to r140260. + + * DEPS: + +2012-06-03 Ryosuke Niwa <rniwa@webkit.org> + + Roll Chromium DEPS from r140000 to r140222. + + * DEPS: + +2012-06-03 Varun Jain <varunjain@google.com> + + [chromium] Add new gesture type (two finger tap) that triggers context menu. + https://bugs.webkit.org/show_bug.cgi?id=88173 + + Reviewed by Adam Barth. + + * public/WebInputEvent.h: + * src/PageWidgetDelegate.cpp: + (WebKit::PageWidgetDelegate::handleInputEvent): + * src/WebInputEventConversion.cpp: + (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): + * src/WebPopupMenuImpl.cpp: + (WebKit::WebPopupMenuImpl::handleInputEvent): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleGestureEvent): + +2012-06-03 Robert Kroeger <rjkroege@chromium.org> + + [chromium] replace isScrollGestureEventType with isGestureEventType + https://bugs.webkit.org/show_bug.cgi?id=88097 + + This change replaces the unused and incorrect isScrollGestureEventType + method with a correct and useful isGestureEventType method. + + Reviewed by Adam Barth. + + * public/WebInputEvent.h: + (WebInputEvent): + (WebKit::WebInputEvent::isGestureEventType): + +2012-06-01 Alexandre Elias <aelias@google.com> + + [chromium] Software compositor initialization and base classes + https://bugs.webkit.org/show_bug.cgi?id=87920 + + Reviewed by James Robinson. + + Add a new setting to force software compositing. In this mode, + no GraphicsContext3D should ever be created. + + * public/WebSettings.h: + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::Settings::operator CCSettings): + (WebKit::WebLayerTreeView::context): + * src/WebLayerTreeViewImpl.cpp: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::WebSettingsImpl): + (WebKit::WebSettingsImpl::setForceSoftwareCompositing): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + (WebKit::WebSettingsImpl::forceSoftwareCompositing): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): + (WebKit::WebViewImpl::createCompositorGraphicsContext3D): + (WebKit::WebViewImpl::createContext3D): + * tests/CCLayerTreeHostImplTest.cpp: + (WebKitTests::CCLayerTreeHostImplTest::createContext): + (WebKitTests::TEST_F): + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread): + (WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread): + (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread): + (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread): + * tests/CCTiledLayerTestCommon.cpp: + (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): + * tests/CCTiledLayerTestCommon.h: + (Texture): + (WebKitTests::FakeTextureCopier::copyTexture): + (WebKitTests::FakeTextureUploader::uploadTexture): + * tests/Canvas2DLayerChromiumTest.cpp: + (Canvas2DLayerChromiumTest::fullLifecycleTest): + * tests/FakeCCLayerTreeHostClient.h: + * tests/LayerRendererChromiumTest.cpp: + (FakeLayerRendererChromium::FakeLayerRendererChromium): + (LayerRendererChromiumTest::LayerRendererChromiumTest): + (LayerRendererChromiumTest): + (TEST): + * tests/TextureCopierTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + (WTF::TEST): + +2012-06-01 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r119283, r119287, and r119291. + http://trac.webkit.org/changeset/119283 + http://trac.webkit.org/changeset/119287 + http://trac.webkit.org/changeset/119291 + https://bugs.webkit.org/show_bug.cgi?id=88159 + + Not only broke compilation in the initial commit but also + broke LayerChromiumTest.basicCreateAndDestroy (Requested by + rniwa on #webkit). + + * tests/CCAnimationTestCommon.cpp: + (WebCore::addOpacityTransition): + (WebCore::addAnimatedTransform): + (WebKitTests::FakeTransformTransition::getValue): + * tests/CCAnimationTestCommon.h: + * tests/CCKeyframedAnimationCurveTest.cpp: + * tests/CCLayerAnimationControllerTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted): + (WebKitTests::MockGraphicsLayerClient::notifySyncRequired): + (WebKitTests::MockGraphicsLayerClient::paintContents): + (WebKitTests::MockGraphicsLayerClient::showDebugBorders): + (WebKitTests::MockGraphicsLayerClient::showRepaintCounter): + (WebKitTests::TEST): + +2012-06-01 Ryosuke Niwa <rniwa@webkit.org> + + Use fully qualified name for Fixed to avoid the collision with "typedef SInt32 Fixed" in MacTypes.h + + * tests/GraphicsLayerChromiumTest.cpp: + (WebKitTests::TEST_F): + +2012-06-01 James Robinson <jamesr@chromium.org> + + [chromium] Unreviewed compile fix for r119283 + + For the record, Dana Jensens <danakj@chromium.org> wrote this slightly faster than I did. + + * tests/CCAnimationTestCommon.h: + +2012-06-01 Ian Vollick <vollick@chromium.org> + + [chromium] Accelerated animations should use WebTransformOperations + https://bugs.webkit.org/show_bug.cgi?id=87686 + + Reviewed by James Robinson. + + CCTransformKeyframe new owns a WebTransformOperations rather than a + TransformOperations. LayerChromium's API has been changed so that + LayerChromium::addAnimation should take only a CCActiveAnimation. + GraphicsLayerChromium is new responsible for translating to + WebTransformOperations and creating CCActiveAnimations. Tests that use + the public API (that is, they call addAnimation with KeyframeValueList + and Animation arguments) have been moved to GraphicsLayerChromiumTest. + + * tests/CCAnimationTestCommon.cpp: + (WebCore::addOpacityTransition): + (WebCore::addAnimatedTransform): + (WebKitTests::FakeTransformTransition::getValue): + * tests/CCAnimationTestCommon.h: + * tests/CCKeyframedAnimationCurveTest.cpp: + (WebCore::TEST): + * tests/CCLayerAnimationControllerTest.cpp: + (WebKitTests::TEST): + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): + * tests/GraphicsLayerChromiumTest.cpp: + (MockLayerTreeHostClient): + (WebKitTests): + (MockLayerTreeHost): + (WebKitTests::MockLayerTreeHost::create): + (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): + (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): + (GraphicsLayerChromiumTest): + (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): + (WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): + (WebKitTests::GraphicsLayerChromiumTest::expectTranslateX): + (WebKitTests::TEST_F): + +2012-06-01 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Call clipboard methods directly + https://bugs.webkit.org/show_bug.cgi?id=88038 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/AssertMatchingEnums.cpp: + * src/PlatformSupport.cpp: + (WebCore::getCookieJar): + +2012-06-01 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-06-01 Yoshifumi Inoue <yosin@chromium.org> + + [Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order + https://bugs.webkit.org/show_bug.cgi?id=88044 + + Reviewed by Kent Tamura. + + * tests/DecimalTest.cpp: + (TEST_F): Add a new test for multiplication. + +2012-05-31 Hajime Morrita <morrita@chromium.org> + + REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac + https://bugs.webkit.org/show_bug.cgi?id=86859 + + Removed a port specific fix which was introduced at r117572. + + Reviewed by Ryosuke Niwa. + + * src/EditorClientImpl.cpp: + (WebKit::EditorClientImpl::frameWillDetachPage): + (WebKit::EditorClientImpl::requestCheckingOfString): + * src/EditorClientImpl.h: + (WebCore): + (EditorClientImpl): + * src/WebTextCheckingCompletionImpl.cpp: + (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText): + (WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText): + * src/WebTextCheckingCompletionImpl.h: + (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl): + (WebTextCheckingCompletionImpl): + +2012-05-31 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r119146. + http://trac.webkit.org/changeset/119146 + https://bugs.webkit.org/show_bug.cgi?id=88035 + + android breakage fixed in http://crrev.com/139945 (Requested + by fischman on #webkit). + + * public/WebMediaPlayer.h: + (WebMediaPlayer): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::didLoadingProgress): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-05-31 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Migrate to WebTransformationMatrix + https://bugs.webkit.org/show_bug.cgi?id=87788 + + Reviewed by James Robinson. + + * src/WebLayer.cpp: + (WebKit::WebLayer::setSublayerTransform): + (WebKit::WebLayer::setTransform): + * tests/CCAnimationTestCommon.cpp: + (WebKitTests::FakeTransformTransition::getValue): + * tests/CCAnimationTestCommon.h: + * tests/CCDamageTrackerTest.cpp: + (WebKitTests::executeCalculateDrawTransformsAndVisibility): + (WebKitTests::TEST_F): + * tests/CCKeyframedAnimationCurveTest.cpp: + * tests/CCLayerAnimationControllerTest.cpp: + * tests/CCLayerImplTest.cpp: + (WebCore::TEST): + * tests/CCLayerIteratorTest.cpp: + * tests/CCLayerSorterTest.cpp: + * tests/CCLayerTreeHostCommonTest.cpp: + * tests/CCLayerTreeHostTest.cpp: + (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread): + (WTF::setLayerPropertiesForTesting): + (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest): + (WTF::setTestLayerPropertiesForTesting): + (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): + (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): + (WTF::CCLayerTreeHostTestManySurfaces::beginTest): + * tests/CCLayerTreeTestCommon.h: + (WebKitTests): + * tests/CCMathUtilTest.cpp: + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTest::createRoot): + (WebKitTests::CCOcclusionTrackerTest::createLayer): + (WebKitTests::CCOcclusionTrackerTest::createSurface): + (WebKitTests::CCOcclusionTrackerTest::createDrawingLayer): + (WebKitTests::CCOcclusionTrackerTest::createReplicaLayer): + (WebKitTests::CCOcclusionTrackerTest::createDrawingSurface): + (CCOcclusionTrackerTest): + (WebKitTests::CCOcclusionTrackerTest::setBaseProperties): + (WebKitTests::CCOcclusionTrackerTest::setProperties): + (WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): + (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): + (WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest): + (WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest): + (WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest): + * tests/CCQuadCullerTest.cpp: + * tests/CCRenderSurfaceTest.cpp: + * tests/FloatQuadTest.cpp: + * tests/LayerChromiumTest.cpp: + * tests/LinkHighlightTest.cpp: + * tests/TiledLayerChromiumTest.cpp: + * tests/WebTransformationMatrixTest.cpp: (WebKit::TEST): (WebKit): - * tests/data/valid_header_missing_bitmap.ico: Added. -2012-10-02 Yury Semikhatsky <yurys@chromium.org> +2012-05-31 Ian Vollick <vollick@chromium.org> - Provide memory instrumentation for HashCountedSet - https://bugs.webkit.org/show_bug.cgi?id=98138 + [chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized + https://bugs.webkit.org/show_bug.cgi?id=87873 - Reviewed by Pavel Feldman. + Reviewed by James Robinson. - Added unit test for HashCountedSet memory instrumentation. + When the layer renderer fails to initialize, be sure to stop the animation timer. + + * tests/CCLayerTreeHostTest.cpp: + (CompositorFakeWebGraphicsContext3DWithTextureTracking): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures): + (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking): + (WTF): + (WTF::TestHooks::didRecreateContext): + (TestHooks): + (WTF::TestHooks::createContext): + (CCLayerTreeHostTest): + (WTF::CCLayerTreeHostTest::clearEndTestTask): + (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): + (EndTestTask): + (WTF::CCLayerTreeHostTest::EndTestTask::EndTestTask): + (WTF::CCLayerTreeHostTest::EndTestTask::~EndTestTask): + (WTF::CCLayerTreeHostTest::EndTestTask::clearTest): + (WTF::CCLayerTreeHostTest::EndTestTask::run): + (WTF::CCLayerTreeHostTest::runTest): + (WTF::CCLayerTreeHostTest::endTestAfterDelay): + (FakeWebGraphicsContext3DMakeCurrentFails): + (WTF::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent): + (CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation): + (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation): + (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::beginTest): + (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers): + (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext): + (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::afterTest): + (WTF::TEST_F): + +2012-05-15 Brett Wilson <brettw@chromium.org> + + Hook up GTK IsKeyPad flag for keyboard events, and preserve this flag + on all platforms when converting back to a WebKeyboardEvent. + + https://bugs.webkit.org/show_bug.cgi?id=86514 + + Reviewed by Dimitri Glazkov. - * tests/MemoryInstrumentationTest.cpp: + * src/WebInputEventConversion.cpp: + (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): + * src/gtk/WebInputEventFactory.cpp: + (WebKit::WebInputEventFactory::keyboardEvent): + * tests/WebInputEventFactoryTestGtk.cpp: + +2012-05-31 Alec Flett <alecflett@chromium.org> + + IndexedDB: Implement IDBTransaction.error and IDBRequest.error + https://bugs.webkit.org/show_bug.cgi?id=87865 + + Reviewed by Tony Chang. + + IDBDatabaseError now honors IDB-specific DOMException codes, + so make sure that's how they are passed to/from chromium. + + * src/WebIDBDatabaseError.cpp: + (WebKit::WebIDBDatabaseError::assign): + +2012-05-31 James Robinson <jamesr@chromium.org> + + [chromium] Assertion failures during compositor startup in lost context situations + https://bugs.webkit.org/show_bug.cgi?id=87912 + + Reviewed by Adrienne Walker. + + Adds a unit test verifying that even if we lose our context during or before initialization we get through the + rest of the path without failing ASSERT()s. + + * tests/LayerRendererChromiumTest.cpp: + (LoseContextOnFirstGetContext): + (LoseContextOnFirstGetContext::LoseContextOnFirstGetContext): + (TEST): + +2012-05-31 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r119125. + http://trac.webkit.org/changeset/119125 + https://bugs.webkit.org/show_bug.cgi?id=88007 + + Will break android build if rolled (Requested by rafaelw_ on + #webkit). + + * public/WebMediaPlayer.h: + (WebMediaPlayer): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::bytesLoaded): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-05-31 Dana Jansens <danakj@chromium.org> + + [chromium] Move drawing code for RenderSurfaces into LayerRendererChromium + https://bugs.webkit.org/show_bug.cgi?id=87877 + + Reviewed by James Robinson. + + * tests/CCRenderSurfaceTest.cpp: + (WebCore::TEST): + +2012-05-31 Ami Fischman <fischman@chromium.org> + + Replace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress() + https://bugs.webkit.org/show_bug.cgi?id=86113 + + Reviewed by Eric Carlson. + + * public/WebMediaPlayer.h: + (WebMediaPlayer): + * src/WebMediaPlayerClientImpl.cpp: + (WebKit::WebMediaPlayerClientImpl::didLoadingProgress): + * src/WebMediaPlayerClientImpl.h: + (WebMediaPlayerClientImpl): + +2012-05-31 Ian Vollick <vollick@chromium.org> + + [chromium] create WebTransformOperation interface for chromium platform + https://bugs.webkit.org/show_bug.cgi?id=87510 + + Reviewed by James Robinson. + + * WebKit.gypi: + * tests/WebTransformOperationsTest.cpp: Added. + (TEST): + (checkProgress): + +2012-05-31 Alexander Pavlov <apavlov@chromium.org> + + Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint + https://bugs.webkit.org/show_bug.cgi?id=87871 + + Reviewed by Yury Semikhatsky. + + When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report + these events as NOT handled by the WebKit, so that the browser can handle them appropriately + (on MacOS, switching between the application windows is done through the default key event handler, so if you run + event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`). + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::handleInputEvent): + +2012-05-31 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-05-30 Peter Beverloo <peter@chromium.org> + + [Chromium] Automatically install 64-bit linker for Android + https://bugs.webkit.org/show_bug.cgi?id=79780 + + Reviewed by Adam Barth. + + Change the Android-specific dependencies to inherit their revision from + Chromium's DEPS file, like many other dependencies do, solving the + versioning problem that we're running in to right now. These are listed + in Chromium's main DEPS file starting Chromium r139529. + + * DEPS: + +2012-05-31 Yoshifumi Inoue <yosin@chromium.org> + + Build fix for Chromium Linux (Tests) after r119073. + + * tests/DecimalTest.cpp: + (TEST_F): + +2012-05-31 Yoshifumi Inoue <yosin@chromium.org> + + [Platform] Introduce Decimal class for Number/Range input type. + https://bugs.webkit.org/show_bug.cgi?id=87360 + + Reviewed by Kent Tamura. + + This patch added unit test for Decimal class. + + * WebKit.gypi: + * tests/DecimalTest.cpp: Added. + (WebCore): + (WebCore::operator<<): Output Decimal for unit test debugging + (DecimalStepRange): + (DecimalStepRange::DecimalStepRange): + (DecimalStepRange::clampValue): + (DecimalTest): + (DecimalTest::encode): + (DecimalTest::fromString): + (DecimalTest::stepDown): + (DecimalTest::stepUp): + (TEST_F): + +2012-05-30 Yury Semikhatsky <yurys@chromium.org> + + Web Inspector: add MemoryUsageSupport::processMemorySizesInBytes + https://bugs.webkit.org/show_bug.cgi?id=87830 + + Reviewed by James Robinson. + + * public/platform/WebKitPlatformSupport.h: pulled getProcessMemorySize up + to the Source/Platform/chromium/public/Platform.h + * src/PlatformSupport.cpp: + +2012-05-31 Kent Tamura <tkent@chromium.org> + + Unreviewed, rolling out r119062 and r119064. + http://trac.webkit.org/changeset/119062 + http://trac.webkit.org/changeset/119064 + https://bugs.webkit.org/show_bug.cgi?id=87360 + + Broke build on Lion, SnowLoepard, Chromium Windows, and + Chromium Linux 32 + + * WebKit.gypi: + * tests/DecimalTest.cpp: Removed. + +2012-05-30 Yoshifumi Inoue <yosin@chromium.org> + + [Platform] Introduce Decimal class for Number/Range input type. + https://bugs.webkit.org/show_bug.cgi?id=87360 + + Reviewed by Kent Tamura. + + This patch added unit test for Decimal class. + + * WebKit.gypi: + * tests/DecimalTest.cpp: Added. + (WebCore): + (WebCore::operator<<): Output Decimal for unit test debugging + (DecimalStepRange): + (DecimalStepRange::DecimalStepRange): + (DecimalStepRange::clampValue): + (DecimalTest): + (DecimalTest::encode): + (DecimalTest::fromString): + (DecimalTest::stepDown): + (DecimalTest::stepUp): + (TEST_F): + +2012-05-30 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Fix min/max bounds error in CCMathUtil.cpp + https://bugs.webkit.org/show_bug.cgi?id=87915 + + Reviewed by James Robinson. + + * tests/CCMathUtilTest.cpp: + (WebCore::TEST): + (WebCore): + +2012-05-30 Ami Fischman <fischman@chromium.org> + + Roll chromium DEPS from r139300 to r139542. Unreviewed. + https://bugs.webkit.org/show_bug.cgi?id=87868 + + * DEPS: + +2012-05-30 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Call fileUtilities methods directly + https://bugs.webkit.org/show_bug.cgi?id=87852 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-05-30 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r118986. + http://trac.webkit.org/changeset/118986 + https://bugs.webkit.org/show_bug.cgi?id=87914 + + Caused several IndexedDB browser_test failures on Chromium + canary builders (Requested by rafaelw_ on #webkit). + + * src/WebIDBDatabaseError.cpp: + (WebKit::WebIDBDatabaseError::assign): + +2012-05-30 Dominic Mazzoni <dmazzoni@google.com> + + AX: Chromium WebAccessibilityObject should check if an AccessibilityObject is detached + https://bugs.webkit.org/show_bug.cgi?id=87778 + + Reviewed by Adam Barth. + + Pretty simple - all places that previously just checked for null + now also check if the wrapped AccessibilityObject is detached. + + * public/WebAccessibilityObject.h: + (WebAccessibilityObject): + * src/WebAccessibilityObject.cpp: + (WebKit::WebAccessibilityObject::isDetached): + (WebKit): + (WebKit::WebAccessibilityObject::axID): + (WebKit::WebAccessibilityObject::accessibilityDescription): + (WebKit::WebAccessibilityObject::actionVerb): + (WebKit::WebAccessibilityObject::canSetFocusAttribute): + (WebKit::WebAccessibilityObject::canSetValueAttribute): + (WebKit::WebAccessibilityObject::isValid): + (WebKit::WebAccessibilityObject::childCount): + (WebKit::WebAccessibilityObject::childAt): + (WebKit::WebAccessibilityObject::firstChild): + (WebKit::WebAccessibilityObject::focusedChild): + (WebKit::WebAccessibilityObject::lastChild): + (WebKit::WebAccessibilityObject::nextSibling): + (WebKit::WebAccessibilityObject::parentObject): + (WebKit::WebAccessibilityObject::previousSibling): + (WebKit::WebAccessibilityObject::canSetSelectedAttribute): + (WebKit::WebAccessibilityObject::isAnchor): + (WebKit::WebAccessibilityObject::isAriaReadOnly): + (WebKit::WebAccessibilityObject::isButtonStateMixed): + (WebKit::WebAccessibilityObject::isChecked): + (WebKit::WebAccessibilityObject::isCollapsed): + (WebKit::WebAccessibilityObject::isControl): + (WebKit::WebAccessibilityObject::isEnabled): + (WebKit::WebAccessibilityObject::isFocused): + (WebKit::WebAccessibilityObject::isHovered): + (WebKit::WebAccessibilityObject::isIndeterminate): + (WebKit::WebAccessibilityObject::isLinked): + (WebKit::WebAccessibilityObject::isLoaded): + (WebKit::WebAccessibilityObject::isMultiSelectable): + (WebKit::WebAccessibilityObject::isOffScreen): + (WebKit::WebAccessibilityObject::isPasswordField): + (WebKit::WebAccessibilityObject::isPressed): + (WebKit::WebAccessibilityObject::isReadOnly): + (WebKit::WebAccessibilityObject::isRequired): + (WebKit::WebAccessibilityObject::isSelected): + (WebKit::WebAccessibilityObject::isSelectedOptionActive): + (WebKit::WebAccessibilityObject::isVertical): + (WebKit::WebAccessibilityObject::isVisible): + (WebKit::WebAccessibilityObject::isVisited): + (WebKit::WebAccessibilityObject::accessKey): + (WebKit::WebAccessibilityObject::ariaHasPopup): + (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic): + (WebKit::WebAccessibilityObject::ariaLiveRegionBusy): + (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant): + (WebKit::WebAccessibilityObject::ariaLiveRegionStatus): + (WebKit::WebAccessibilityObject::boundingBox): + (WebKit::WebAccessibilityObject::estimatedLoadingProgress): + (WebKit::WebAccessibilityObject::helpText): + (WebKit::WebAccessibilityObject::headingLevel): + (WebKit::WebAccessibilityObject::hierarchicalLevel): + (WebKit::WebAccessibilityObject::hitTest): + (WebKit::WebAccessibilityObject::keyboardShortcut): + (WebKit::WebAccessibilityObject::performDefaultAction): + (WebKit::WebAccessibilityObject::roleValue): + (WebKit::WebAccessibilityObject::selectionEnd): + (WebKit::WebAccessibilityObject::selectionStart): + (WebKit::WebAccessibilityObject::setFocused): + (WebKit::WebAccessibilityObject::stringValue): + (WebKit::WebAccessibilityObject::title): + (WebKit::WebAccessibilityObject::titleUIElement): + (WebKit::WebAccessibilityObject::url): + (WebKit::WebAccessibilityObject::valueDescription): + (WebKit::WebAccessibilityObject::valueForRange): + (WebKit::WebAccessibilityObject::maxValueForRange): + (WebKit::WebAccessibilityObject::minValueForRange): + (WebKit::WebAccessibilityObject::node): + (WebKit::WebAccessibilityObject::document): + (WebKit::WebAccessibilityObject::hasComputedStyle): + (WebKit::WebAccessibilityObject::computedStyleDisplay): + (WebKit::WebAccessibilityObject::accessibilityIsIgnored): + (WebKit::WebAccessibilityObject::lineBreaks): + (WebKit::WebAccessibilityObject::columnCount): + (WebKit::WebAccessibilityObject::rowCount): + +2012-05-30 Shawn Singh <shawnsingh@chromium.org> + + Simplify TransformationMatrix rotation code to improve precision + https://bugs.webkit.org/show_bug.cgi?id=86666 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + (WebKitTests::TEST): + * tests/WebTransformationMatrixTest.cpp: + (WebKit::TEST): + (WebKit): + +2012-05-30 Alec Flett <alecflett@chromium.org> + + IndexedDB: Implement IDBTransaction.error and IDBRequest.error + https://bugs.webkit.org/show_bug.cgi?id=87865 + + Reviewed by Tony Chang. + + IDBDatabaseError now honors IDB-specific DOMException codes, + so make sure that's how they are passed to/from chromium. + + * src/WebIDBDatabaseError.cpp: + (WebKit::WebIDBDatabaseError::assign): + +2012-05-30 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Merge shared code in CCOcclusionTrackerTest + https://bugs.webkit.org/show_bug.cgi?id=87798 + + Reviewed by Adrienne Walker. + + This patch simple uses a different existing macro function so that + the same thing doesn't exist in multiple places, and so that the + naming is more consistent with gtest's conventions. + + * tests/CCOcclusionTrackerTest.cpp: + (WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest): + (WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): + (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest): + (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest): + (WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest): + (WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest): + (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest): + (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest): + (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest): + (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest): + (WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest): + +2012-05-30 Tony Chang <tony@chromium.org> + + [chromium] port webframe_unittest.cc to webkit_unit_tests + https://bugs.webkit.org/show_bug.cgi?id=87796 + + Reviewed by James Robinson. + + Move WebFrameTest.GetContentAsPlainText and WebFrameTest.GetFullHtmlOfPage to webkit_unit_tests. + + * tests/WebFrameTest.cpp: + (WebKit::TEST_F): + (WebKit): Add tests. + +2012-05-30 Jochen Eisinger <jochen@chromium.org> + + Match Firefox restrictions to window.blur and window.focus + https://bugs.webkit.org/show_bug.cgi?id=86969 + + Reviewed by Adam Barth. + + Allow window.focus() during the dispatch of the click event on + notifications. + + * src/WebNotification.cpp: + (WebKit::WebNotification::dispatchClickEvent): + +2012-05-29 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move fileExists to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=87531 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * src/PlatformSupport.cpp: + (WebCore): + +2012-05-29 Alec Flett <alecflett@chromium.org> + + IndexedDB: Align codes and names for IDB-specific and DOM-specific errors/exceptions + https://bugs.webkit.org/show_bug.cgi?id=87276 + + Reviewed by Tony Chang. -2012-10-02 Kent Tamura <tkent@chromium.org> + * public/WebIDBDatabaseException.h: + * src/AssertMatchingEnums.cpp: - [Chromium-Win] Implement LocaleWin::dateFormat - https://bugs.webkit.org/show_bug.cgi?id=98117 +2012-05-29 Rafael Weinstein <rafaelw@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-05-29 Dana Jansens <danakj@chromium.org> + + [chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect + https://bugs.webkit.org/show_bug.cgi?id=87677 + + Reviewed by Adrienne Walker. + + * tests/CCOcclusionTrackerTest.cpp: + (CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor): + (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest): + (WebKitTests): + +2012-05-29 David Barr <davidbarr@chromium.org> + + Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag + https://bugs.webkit.org/show_bug.cgi?id=87685 + + Reviewed by Eric Seidel. + + Add a configuration option for CSS image-resolution support, disabling it by default. + + * features.gypi: + +2012-05-29 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-05-29 Hironori Bono <hbono@chromium.org> + + Use WebSpellCheckClient::spellcheck to retrieve suggestions. + https://bugs.webkit.org/show_bug.cgi?id=87690 + + Reviewed by Hajime Morita. + + This change uses WebSpellCheckClient::spellcheck as a fallback method to + retrieve suggestions when a marker does not have any suggestions. (It consumes + lots of CPU power to get suggestions for misspelled word, i.e. Chromium cannot + afford to attach suggestions to all spelling markers.) + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Retrieve suggestions if markers do not have any. + +2012-05-28 Takashi Toyoshima <toyoshim@chromium.org> + + [WebSocket] Receiving reserved close codes, 1005, 1006, and 1015 must appear as code=1006 and wasClean=false + https://bugs.webkit.org/show_bug.cgi?id=87084 + + Reviewed by Kent Tamura. + + Update close event codes corresponding to WebSocketChannel::CloseEventCode. + + * public/WebSocket.h: Update on newly defined close event codes + +2012-05-28 MORITA Hajime <morrita@google.com> + + Rename FrameLoaderClient::shadowDOMAllowed() to allowShadowDOM() + https://bugs.webkit.org/show_bug.cgi?id=87101 Reviewed by Kentaro Hara. - * tests/LocaleWinTest.cpp: - (TEST_F): Add tests for LocaleWin::dateFormat. + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::allowShadowDOM): + * src/FrameLoaderClientImpl.h: + (FrameLoaderClientImpl): + +2012-05-28 Rob Flack <flackr@chromium.org> + + [chromium] Only increase size of Combo Box Options when displayed on touch screen + https://bugs.webkit.org/show_bug.cgi?id=85921 + + Reviewed by Adam Barth. + + Adds a flag to set whether the current device is a touch screen, independent of whether touch events are supported and use this for the combo box sizing. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::defaultDeviceScaleFactor): + (WebKit): + (WebKit::WebSettingsImpl::setDeviceSupportsTouch): + (WebKit::WebSettingsImpl::deviceSupportsTouch): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::applyAutofillSuggestions): + * tests/PopupMenuTest.cpp: + (WebKit::SelectPopupMenuTest::SetUp): + (WebKit::SelectPopupMenuTest::TearDown): + (SelectPopupMenuTest): + (WebKit::TEST_F): + +2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> + + WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled + https://bugs.webkit.org/show_bug.cgi?id=42328 + + Reviewed by Eric Seidel. + + Removed private APIs that were only being used by DRT. + + * public/WebDevToolsAgent.h: + (WebDevToolsAgent): + * src/WebDevToolsAgentImpl.cpp: + * src/WebDevToolsAgentImpl.h: + (WebDevToolsAgentImpl): + +2012-05-28 Peter Beverloo <peter@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-05-28 Peter Beverloo <peter@chromium.org> + + [Chromium] Build fix for the Android bot, set CXX_target at gyp generation-time + https://bugs.webkit.org/show_bug.cgi?id=87649 + + Unreviewed build fix. + + Chromium Android builds were broken because v8 tried to compile files + for target with the "-m32" flag. This was caused by a v8 check falling + back to using "which g++" to find the right compiler, whereas it should + have used the $CXX_target environment variable. This isn't being set + for Android builds. + + * gyp_webkit: Set the CXX_target environment variable. Annotate the fix + with a FIXME comment too. + +2012-05-28 Keishi Hattori <keishi@webkit.org> + + Expose value localization function of HTMLInputElement + https://bugs.webkit.org/show_bug.cgi?id=84356 + + Reviewed by Kent Tamura. + + * public/WebInputElement.h: + (WebInputElement): + * src/WebInputElement.cpp: + (WebKit::WebInputElement::localizeValue): + (WebKit): + +2012-05-28 MORITA Hajime <morrita@google.com> + + Unreviewed Mac Chromium build fix. + + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::allowStyleScoped): + +2012-05-28 MORITA Hajime <morrita@google.com> + + https://bugs.webkit.org/show_bug.cgi?id=87609 + [Chromium] FrameLoaderClient::allowStyleScoped() should be implemented interms of WebPermissionClient + + Reviewed by Kent Tamura. + + Added allowStyleScoped() implementation which is essentially same as shadowDOMAllowed(). + + * src/FrameLoaderClientImpl.cpp: + * src/FrameLoaderClientImpl.h: + (FrameLoaderClientImpl): + +2012-05-25 Ryosuke Niwa <rniwa@webkit.org> + + Roll chromium DEPS from r139156 to r139184. + + * DEPS: + +2012-05-25 Garrett Casto <gcasto@chromium.org> + + Allow WebTextFieldDecoratorClient to see applied decorations. + https://bugs.webkit.org/show_bug.cgi?id=86557 + + Reviewed by Kent Tamura. + + * WebKit.gyp: Added new files. + * public/WebInputElement.h: + (WebKit::WebInputElement::decorationElementFor): Returns the + WebElement attached to the WebInputElement by the given + WebTextFieldDecoratorClient, if one exists. + * src/TextFieldDecoratorImpl.cpp: + (WebKit): + * src/TextFieldDecoratorImpl.h: + (TextFieldDecoratorImpl::decoratorClient): Get the + WebTextFieldDecoratorClient owned by this object. + +2012-05-25 Mihai Parparita <mihaip@chromium.org> + + Allow synchronous XHRs to be disabled in documents + https://bugs.webkit.org/show_bug.cgi?id=87540 + + Reviewed by Eric Seidel. + + Synchronous XMLHttpRequests are a problematic API, since they result + in blocked UI threads. Some clients may wish to always disable them; + give them a setting to do so (see also r103629 for other cases where + synchronous XHRs are disabled). + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setSyncXHRInDocumentsEnabled): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-05-25 Kinuko Yasuda <kinuko@chromium.org> + + [chromium] Deprecate FileUtilities::getFileSize and getFileModifiedTime in favor of getFileMetadata + https://bugs.webkit.org/show_bug.cgi?id=87492 + + Reviewed by Adam Barth. + + * src/PlatformSupport.cpp: + (WebCore::PlatformSupport::getFileMetadata): + +2012-05-25 Ryosuke Niwa <rniwa@webkit.org> + + Roll Chromium DEPS from r139024 to r139156 in an attempt to fix Chromium Win builds. + + * DEPS: + +2012-05-25 Mark Pilgrim <pilgrim@chromium.org> + + [Chomium] Move sandboxSupport to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=87518 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * WebKit.gyp: + * public/platform/WebKitPlatformSupport.h: + (WebKit): + (WebKitPlatformSupport): + * public/platform/android/WebSandboxSupport.h: + * public/platform/linux/WebFontFamily.h: + * public/platform/linux/WebSandboxSupport.h: + * public/platform/mac/WebSandboxSupport.h: + * public/platform/win/WebSandboxSupport.h: + * src/PlatformSupport.cpp: + (WebCore::PlatformSupport::ensureFontLoaded): + (WebCore::PlatformSupport::loadFont): + (WebCore::PlatformSupport::getFontFamilyForCharacters): + (WebCore::PlatformSupport::getRenderStyleForStrike): + +2012-05-25 Dana Jansens <danakj@chromium.org> + + [chromium] WebLayerTreeViewImpl should not hide methods in CCLayerTreeHost with signatures that match the Client interface + https://bugs.webkit.org/show_bug.cgi?id=87301 + + Reviewed by James Robinson. + + Most methods in the CCLayerTreeHostClient interface have a matching + method signature on CCLayerTreeHost that simply calls the client, if + one exists at all. However, CCLayerTreeHost::updateAnimations() does + important work in addition to calling the client. + + Currently WebLayerTreeViewImpl itself implements the interface for + CCLayerTreeHostClient as well as CCLayerTreeHost, and simply forwards + any call to a method in the client interface to its own client. This + blocks WebViewImpl from calling CCLayerTreeHost::updateAnimations, since + the method is also in the client interface. + + We change WebLayerTreeViewImpl to own a CCLayerTreeHost and a + WebLayerTreeHostClientAdapter. This fixes the shadowing by making + the two interfaces separate, and resolves lifetime issues by + ensuring that the CCLayerTreeHost is destroyed before its client. + + * src/WebLayerTreeView.cpp: + (WebKit::WebLayerTreeView::setSurfaceReady): + (WebKit::WebLayerTreeView::setRootLayer): + (WebKit::WebLayerTreeView::compositorIdentifier): + (WebKit::WebLayerTreeView::setViewportSize): + (WebKit::WebLayerTreeView::viewportSize): + (WebKit::WebLayerTreeView::setBackgroundColor): + (WebKit::WebLayerTreeView::setVisible): + (WebKit::WebLayerTreeView::setPageScaleFactorAndLimits): + (WebKit::WebLayerTreeView::startPageScaleAnimation): + (WebKit::WebLayerTreeView::setNeedsAnimate): + (WebKit::WebLayerTreeView::setNeedsRedraw): + (WebKit::WebLayerTreeView::commitRequested): + (WebKit::WebLayerTreeView::composite): + (WebKit::WebLayerTreeView::updateAnimations): + (WebKit::WebLayerTreeView::compositeAndReadback): + (WebKit::WebLayerTreeView::finishAllRendering): + (WebKit::WebLayerTreeView::context): + (WebKit::WebLayerTreeView::loseCompositorContext): + * src/WebLayerTreeViewImpl.cpp: + (WebKit): + (WebLayerTreeViewClientAdapter): + (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): + (WebKit::WebLayerTreeViewClientAdapter::~WebLayerTreeViewClientAdapter): + (WebKit::WebLayerTreeViewImpl::create): + (WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl): + (WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl): + * src/WebLayerTreeViewImpl.h: + (WebCore): + (WebKit): + (WebKit::WebLayerTreeViewImpl::layerTreeHost): + (WebLayerTreeViewImpl): + +2012-05-25 Kinuko Yasuda <kinuko@chromium.org> + + Unreviewed; rolling chromium deps. + + * DEPS: + +2012-05-25 W. James MacLean <wjmaclean@chromium.org> + + [chromium] LayerChromium should recognise existing layer active animations when the layer is added. + https://bugs.webkit.org/show_bug.cgi?id=87166 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostTest.cpp: + (WTF::MockLayerTreeHost::didAddAnimationWasCalled): + (MockLayerTreeHost): + (WTF::MockLayerTreeHost::MockLayerTreeHost): + (WTF): + (CCLayerTreeHostTestLayerAddedWithAnimation): + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation): + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): + (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::afterTest): + +2012-05-17 Andrey Kosyakov <caseq@chromium.org> + + [chromium] add instrumentation for compositing + https://bugs.webkit.org/show_bug.cgi?id=83928 + + Reviewed by James Robinson. + + - plumb willCommit() and didComposite() to inspector instrumentation via WebViewImpl. + + * WebKit.gypi: Added WebLayerTreeViewTest + * src/WebLayerTreeViewImpl.cpp: + (WebKit::WebLayerTreeViewImpl::didBeginFrame): + (WebKit): + (WebKit::WebLayerTreeViewImpl::willCommit): + * src/WebLayerTreeViewImpl.h: + (WebLayerTreeViewImpl): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::didBeginFrame): + (WebKit): + (WebKit::WebViewImpl::willCommit): + * src/WebViewImpl.h: + (WebViewImpl): + * tests/CCLayerTreeHostTest.cpp: + * tests/FakeCCLayerTreeHostClient.h: + * tests/WebLayerTest.cpp: + * tests/WebLayerTreeViewTest.cpp: Added. + +2012-05-25 Peter Beverloo <peter@chromium.org> + + [Chromium] Pull in Android tools from Chromium's repo through the DEPS file + https://bugs.webkit.org/show_bug.cgi?id=87478 + + Reviewed by Kent Tamura. + + Chromium's r122048 added the forwarder tool, which forwards a TCP port + listening on the device to a port on the host. This now is a required + dependency of DumpRenderTree, so pull it in. + + Since it's likely that more tools will be required, pull in the entire + tools/android/ directory in case the Chromium port for Android is being + checked out or updated. + + * DEPS: Added Android-specific dependency on tools/android/ + +2012-05-25 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r118461. + http://trac.webkit.org/changeset/118461 + https://bugs.webkit.org/show_bug.cgi?id=87468 + + Breaks two chromium browser_tests. (Requested by vsevik on + #webkit). + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::resize): + +2012-05-24 Tim Horton <timothy_horton@apple.com> + + Add feature defines for web-facing parts of CSS Regions and Exclusions + https://bugs.webkit.org/show_bug.cgi?id=87442 + <rdar://problem/10887709> + + Reviewed by Dan Bernstein. + + * features.gypi: + +2012-05-24 Kent Tamura <tkent@chromium.org> + + PAGE_POPUP: window.setValueAndClosePopup should be moved to a + per-context property of DOMWindow. + https://bugs.webkit.org/show_bug.cgi?id=87086 + + Reviewed by Adam Barth. + + * src/WebPagePopupImpl.cpp: + (WebKit): Add PagePopupFrameLoaderClient, which allows window.pagePopupController. + (WebKit::WebPagePopupImpl::initPage): + - Use PagePopupFrameLoaderClient + - Remove the call of ScriptController::installFunctionsForPagePopup(). + - Call DOMWindowPagePopup::install() to inform m_popupClient to a + DOMWindowPagePopup object for the DOMWindow. + +2012-05-21 Kinuko Yasuda <kinuko@chromium.org> + + Cleanup: add a file system call which captures the file metadata at once. + https://bugs.webkit.org/show_bug.cgi?id=86995 + + Reviewed by David Levin. + + * src/PlatformSupport.cpp: + (WebCore::PlatformSupport::getFileMetadata): + (WebCore): + +2012-05-24 Hironori Bono <hbono@chromium.org> + + Enable grammar checking on Chromium when we paste text (Take 2) + https://bugs.webkit.org/show_bug.cgi?id=74393 + + Reviewed by Ryosuke Niwa. + + This change enables grammar checking on Chromium and implements a mock grammar + checker to fix a failing test. + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Show suggestions when we right-click grammatically-misspelled words. + * src/EditorClientImpl.cpp: + (WebKit::EditorClientImpl::isGrammarCheckingEnabled): Enable grammar checking when we enable asynchronous spellchecking. + (WebKit::EditorClientImpl::checkGrammarOfString): set badGrammarLocation to -1 to avoid an assertion error. + * src/WebTextCheckingResult.cpp: + (WebKit::WebTextCheckingResult::operator TextCheckingResult): Fill GrammarDetails for grammatical errors. + +2012-05-24 Alexandre Elias <aelias@google.com> + + [chromium] Support mobile device rotation resizing + https://bugs.webkit.org/show_bug.cgi?id=86819 + + Reviewed by Adam Barth. + + Resizes on a mobile device are caused either by rotation or + on-screen-keyboard bringup, and need different treatment to remain + naturally laid out, scaled and scrolled without disorienting the user. + + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::resize): + +2012-05-24 Antoine Labour <piman@chromium.org> + + [chromium] Add a setForceRenderSurface to WebLayer for test/bench purpose + https://bugs.webkit.org/show_bug.cgi?id=87436 + + Reviewed by James Robinson. + + * src/WebLayer.cpp: + (WebKit::WebLayer::setForceRenderSurface): + (WebKit): + (WebKit::WebLayer::forceRenderSurface): + * tests/CCLayerTreeHostCommonTest.cpp: + (WebKitTests::TEST): + (WebKitTests): + * tests/LayerChromiumTest.cpp: + +2012-05-24 Adam Barth <abarth@webkit.org> + + Fix the chromium-android build. + + * features.gypi: + +2012-05-24 John Mellor <johnme@chromium.org> + + Font Boosting: Add compile flag and runtime setting + https://bugs.webkit.org/show_bug.cgi?id=87394 + + Reviewed by Adam Barth. + + Expose fontBoostingEnabled runtime setting via WebSettings. + + * features.gypi: + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setFontBoostingEnabled): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-05-24 Kinuko Yasuda <kinuko@chromium.org> + + Cleanup: introduce toFile() to reduce static cast from Blob to File + https://bugs.webkit.org/show_bug.cgi?id=87234 + + Reviewed by Eric Seidel. + + * src/WebDragData.cpp: + (WebKit::WebDragData::items): + +2012-05-24 Lu Guanqun <guanqun.lu@intel.com> + + use built-in data type DashArray + https://bugs.webkit.org/show_bug.cgi?id=87344 + + Reviewed by Eric Seidel. + + * tests/PlatformContextSkiaTest.cpp: + (WebCore::TEST): + +2012-05-24 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move queryLocalizedString to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=85762 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * WebKit.gyp: + * public/platform/WebKitPlatformSupport.h: + (WebKit::WebKitPlatformSupport::getPluginList): + * public/platform/WebLocalizedString.h: + * src/LocalizedStrings.cpp: + (WebCore::query): + +2012-05-24 Dana Jansens <danakj@chromium.org> + + [chromium] Only display frames created with memory allocations meant to be displayed + https://bugs.webkit.org/show_bug.cgi?id=85108 + + Reviewed by Adrienne Walker. + + Removing code to protect visible textures when a tab becomes invisible, + as we want to reduce our memory limit for invisible tabs and these + textures should not be saved. + + * src/NonCompositedContentHost.cpp: + * src/NonCompositedContentHost.h: + (NonCompositedContentHost): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::setVisibilityState): + * tests/CCLayerTreeHostTest.cpp: + (WTF::TestHooks::didCommit): + (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): + (WTF::CCLayerTreeHostTest::scheduleComposite): + (WTF::CCLayerTreeHostTest::dispatchComposite): + (CCLayerTreeHostTest): + (WTF::CCLayerTreeHostTest::doBeginTest): + (CCLayerTreeHostTestTickAnimationWhileBackgrounded): + (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::willAnimateLayers): + (CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread): + (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest): + (WTF): + +2012-05-24 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r118352. + http://trac.webkit.org/changeset/118352 + https://bugs.webkit.org/show_bug.cgi?id=87390 + + Caused 6 editing/spelling tests crash/fail on chromium in + debug. (Requested by vsevik on #webkit). + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): + * src/EditorClientImpl.cpp: + (WebKit::EditorClientImpl::isGrammarCheckingEnabled): + * src/WebTextCheckingResult.cpp: + (WebKit::WebTextCheckingResult::operator TextCheckingResult): + +2012-05-24 Ian Vollick <vollick@chromium.org> + + [chromium] Forcibly sync running animations in the waiting state when synchronized start times are needed. + https://bugs.webkit.org/show_bug.cgi?id=87153 + + Reviewed by James Robinson. + + * tests/CCLayerAnimationControllerTest.cpp: + (WebKitTests::TEST): + (WebKitTests): + +2012-05-23 Yury Semikhatsky <yurys@chromium.org> + + Web Inspector: add a command to InspectorMemoryAgent for getting process memory break down + https://bugs.webkit.org/show_bug.cgi?id=87263 + + Reviewed by Pavel Feldman. + + Added an API for retrieving render process private and shared memory in bytes. + + * public/platform/WebKitPlatformSupport.h: + (WebKitPlatformSupport): + (WebKit::WebKitPlatformSupport::getProcessMemorySize): + * src/PlatformSupport.cpp: + (WebCore::PlatformSupport::getProcessMemorySize): + (WebCore): + +2012-05-24 Hironori Bono <hbono@chromium.org> + + Enable grammar checking on Chromium when we paste text. + https://bugs.webkit.org/show_bug.cgi?id=74393 + + Reviewed by Hajime Morita. + + This change enables grammar checking on Chromium and implements a mock grammar + checker to fix a failing test. + + * src/ContextMenuClientImpl.cpp: + (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Show suggestions when we right-click grammatically-misspelled words. + * src/EditorClientImpl.cpp: + (WebKit::EditorClientImpl::isGrammarCheckingEnabled): Enable grammar checking when we enable asynchronous spellchecking. + * src/WebTextCheckingResult.cpp: + (WebKit::WebTextCheckingResult::operator TextCheckingResult): Fill GrammarDetails for grammatical errors. + +2012-05-24 Vivek Galatage <vivekgalatage@gmail.com> + + Web Inspector: localStorage items are not updated when the storage changes + https://bugs.webkit.org/show_bug.cgi?id=83012 + + Reviewed by Pavel Feldman. + + Instrumented the DOM Storage Events in order to update the frontend. + + * src/StorageAreaProxy.cpp: + (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): + (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): + +2012-05-23 Ojan Vafai <ojan@chromium.org> + + add back the ability to disable flexbox + https://bugs.webkit.org/show_bug.cgi?id=87147 + + Reviewed by Tony Chang. + + * features.gypi: + +2012-05-23 Dana Jansens <danakj@chromium.org> + + [chromium] Enable the CCLayerTreeHostTestCanDrawBlocksDrawing test in single-threaded mode + https://bugs.webkit.org/show_bug.cgi?id=87308 + + Reviewed by James Robinson. + + Chromium bug: http://crbug.com/127481 + + Unit test: CCLayerTreeHostTestCanDrawBlocksDrawing.runSingleThread + + * tests/CCLayerTreeHostTest.cpp: + (WTF::TestHooks::didCommit): + (WTF): + (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommit): + +2012-05-23 James Robinson <jamesr@chromium.org> + + Add a Setting to make position:fixed form a new stacking context + https://bugs.webkit.org/show_bug.cgi?id=87186 + + Reviewed by Adam Barth. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setFixedPositionCreatesStackingContext): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-05-23 James Robinson <jamesr@chromium.org> + + [chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port + https://bugs.webkit.org/show_bug.cgi?id=87177 + + Reviewed by Eric Seidel. + + Removes ENABLE(OVERFLOW_SCROLLING) from the set of enables set by Chromium. This guards a new non-standard + CSS property, -webkit-overflow-scrolling, that was introduced by iOS5 intended for mobile browsers. This + property is very partially implemented in Chromium but the way it's implemented does cause new stacking contexts + to be created that otherwise would not be, breaking "desktop" pages. + + This turns the feature off until we can figure out how to deal with the compatibility issues. + + * features.gypi: + +2012-05-23 Jay Civelli <jcivelli@chromium.org> + + [chromium] Provides a way to cancel an external popup menu before it is shown. + https://bugs.webkit.org/show_bug.cgi?id=83474 + + Reviewed by Kent Tamura. + + * src/ExternalPopupMenu.cpp: + (WebKit::ExternalPopupMenu::show): + +2012-05-23 Michael Nordman <michaeln@google.com> + + [chromium] DomStorage events handling needs TLC (3) + https://bugs.webkit.org/show_bug.cgi?id=87031 + https://code.google.com/p/chromium/issues/detail?id=128482 + Only queue storage events for Documents which have allocated + a WebCore::Storage instance since pages that have attached onstorage + event handlers must have a non-null Storage instance. + + Reviewed by Adam Barth. + + * src/StorageAreaProxy.cpp: + (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): + (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): + (WebCore::StorageAreaProxy::isEventSource): + +2012-05-23 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r118218. + http://trac.webkit.org/changeset/118218 + https://bugs.webkit.org/show_bug.cgi?id=87299 + + breaks webkit win builder (Requested by pilgrim_google__ on + #webkit). + + * WebKit.gyp: + * public/platform/WebKitPlatformSupport.h: + (WebKitPlatformSupport): + (WebKit::WebKitPlatformSupport::queryLocalizedString): + * public/platform/WebLocalizedString.h: + (WebKit): + * src/LocalizedStrings.cpp: + (WebCore::query): + +2012-05-23 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move themeEngine to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=87268 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * WebKit.gyp: + * public/platform/WebKitPlatformSupport.h: + (WebKit): + (WebKit::WebKitPlatformSupport::sandboxSupport): + * public/platform/android/WebThemeEngine.h: + * public/platform/linux/WebThemeEngine.h: + * public/platform/mac/WebThemeEngine.h: + * public/platform/win/WebThemeEngine.h: + * src/AssertMatchingEnums.cpp: + * src/PlatformSupport.cpp: + (WebCore::PlatformSupport::paintButton): + (WebCore::PlatformSupport::paintMenuList): + (WebCore::PlatformSupport::paintScrollbarArrow): + (WebCore::PlatformSupport::paintScrollbarThumb): + (WebCore::PlatformSupport::paintScrollbarTrack): + (WebCore::PlatformSupport::paintSpinButton): + (WebCore::PlatformSupport::paintTextField): + (WebCore::PlatformSupport::paintTrackbar): + (WebCore::PlatformSupport::paintProgressBar): + (WebCore::PlatformSupport::getThemePartSize): + (WebCore::PlatformSupport::paintThemePart): + +2012-05-23 Raymes Khoury <raymes@chromium.org> + + Change acceptMIMETypes member to acceptTypes now that file extensions are legal accept types + https://bugs.webkit.org/show_bug.cgi?id=87271 + + Reviewed by Darin Fisher. + + * public/WebFileChooserParams.h: + (WebFileChooserParams): + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::runOpenPanel): + +2012-05-23 Dana Jansens <danakj@chromium.org> + + [chromium] Layers on main thread should get a RenderSurface for animating transform only if masksToBounds is true also + https://bugs.webkit.org/show_bug.cgi?id=87184 + + Reviewed by James Robinson. + + * tests/CCLayerTreeHostCommonTest.cpp: + (WebKitTests::TEST): + +2012-05-23 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move queryLocalizedString to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=85762 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * WebKit.gyp: + * public/platform/WebKitPlatformSupport.h: + (WebKit::WebKitPlatformSupport::getPluginList): + * public/platform/WebLocalizedString.h: + * src/LocalizedStrings.cpp: + (WebCore::query): + +2012-05-23 Antti Koivisto <antti@apple.com> + + Build fix. + + Not reviewed. + + * src/WebDocument.cpp: + (WebKit::WebDocument::insertUserStyleSheet): + +2012-05-22 Alexandre Elias <aelias@google.com> + + [chromium] Apply viewport tag initial-scale only once + https://bugs.webkit.org/show_bug.cgi?id=82949 + + Reviewed by Adam Barth. + + First, check that isPageScaleFactorSet return false before setting + initial-scale. We need to call dispatchViewportPropertiesDidChange() + when the viewport width changes, since that's an input to the viewport + tag calculation. When this happens, we shouldn't pop back to initial + scale. + + Second, check that isNewNavigation is true when deciding to clear + isPageScaleFactorIsSet in didCommitLoad. We only want to clear it on + the very first commit, otherwise we'll pop back to initial scale if + the user zooms in before the load is complete. + + New test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale. + + * src/ChromeClientImpl.cpp: + (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): + * src/WebViewImpl.cpp: + (WebKit::WebViewImpl::didCommitLoad): + +2012-05-21 Shawn Singh <shawnsingh@chromium.org> + + Improve W3C conformance of backface-visibility + https://bugs.webkit.org/show_bug.cgi?id=84195 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + (WebKitTests::TEST): + (WebKitTests): + +2012-05-22 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r118095. + http://trac.webkit.org/changeset/118095 + https://bugs.webkit.org/show_bug.cgi?id=87201 + + "Causing crashes on Mac in + WebCore::StyleResolver::adjustRenderStyle (Requested by + sundiamonde on #webkit). + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-05-22 Xianzhu Wang <wangxianzhu@chromium.org> + + [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part) + https://bugs.webkit.org/show_bug.cgi?id=86922 + + Reviewed by Kent Tamura. + + * All.gyp: Added DumpRenderTree_apk into dependencies for Android. + +2012-05-22 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Call canAccelerate2dCanvas directly + https://bugs.webkit.org/show_bug.cgi?id=86893 + + Reviewed by James Robinson. + + Part of a refactoring series. See tracking bug 82948. + + * public/platform/WebKitPlatformSupport.h: + (WebKitPlatformSupport): + * src/PlatformSupport.cpp: + (WebCore): + +2012-05-22 Dana Jansens <danakj@chromium.org> + + [chromium] Don't drop children of a RenderSurface from the renderSurfaceLayerList when then position of the surface in its clipRect is not known + https://bugs.webkit.org/show_bug.cgi?id=87181 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + (WebKitTests::TEST): + (WebKitTests): + +2012-05-22 MORITA Hajime <morrita@google.com> + + [Chromium][API] Introduce WebPermissionClient::allowWebComponents() + https://bugs.webkit.org/show_bug.cgi?id=87097 + + Reviewed by Kent Tamura. + + - Added WebPermissionClient::allowWebComponents(), and + - Implemented FrameLoaderClientImpl::shadowDOMAllowed() using it. + + * public/WebPermissionClient.h: + (WebPermissionClient): + (WebKit::WebPermissionClient::allowWebComponents): + * src/FrameLoaderClientImpl.cpp: + (WebKit::FrameLoaderClientImpl::shadowDOMAllowed): + (WebKit): + * src/FrameLoaderClientImpl.h: + (FrameLoaderClientImpl): + +2012-05-22 James Robinson <jamesr@chromium.org> + + Add a Setting to make position:fixed form a new stacking context + https://bugs.webkit.org/show_bug.cgi?id=87186 + + Reviewed by Adam Barth. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setFixedPositionCreatesStackingContext): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-05-22 Dana Jansens <danakj@chromium.org> + + [chromium] Don't force the visibleLayerRect to be empty for animating layers whose front face is not visible + https://bugs.webkit.org/show_bug.cgi?id=86886 + + Reviewed by Adrienne Walker. + + * tests/CCLayerTreeHostCommonTest.cpp: + (WebKitTests::TEST): + +2012-05-22 Mark Pilgrim <pilgrim@chromium.org> + + [Chromium] Move cookieJar to Platform.h + https://bugs.webkit.org/show_bug.cgi?id=86755 + + Reviewed by Adam Barth. + + Part of a refactoring series. See tracking bug 82948. + + * WebKit.gyp: + * public/platform/WebCookie.h: + * public/platform/WebCookieJar.h: + * public/platform/WebKitPlatformSupport.h: + (WebKit): + (WebKit::WebKitPlatformSupport::themeEngine): + * src/PlatformSupport.cpp: + (WebCore::getCookieJar): + +2012-05-22 Jochen Eisinger <jochen@chromium.org> + + Unreviewed. Rolled DEPS. + + * DEPS: + +2012-05-22 Kausalya Madhusudhanan <kmadhusu@chromium.org> + + [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality. + https://bugs.webkit.org/show_bug.cgi?id=86684 + + Reviewed by Darin Fisher. + + * public/WebFrame.h: + (WebFrame): + * public/WebPlugin.h: + (WebPlugin): + * public/WebPrintParams.h: + (WebKit::WebPrintParams::WebPrintParams): + (WebPrintParams): + * src/WebFrameImpl.cpp: + (WebKit): + * src/WebFrameImpl.h: + (WebFrameImpl): + * src/WebPluginContainerImpl.cpp: + (WebKit::WebPluginContainerImpl::printBegin): + +2012-05-22 Adam Barth <abarth@webkit.org> + + [Chromium] Expose setMediaPlaybackRequiresUserGesture via WebSettings + https://bugs.webkit.org/show_bug.cgi?id=87164 + + Reviewed by Eric Seidel. + + This is used by the Chromium Android port. + + * public/WebSettings.h: + * src/WebSettingsImpl.cpp: + (WebKit::WebSettingsImpl::setMediaPlaybackRequiresUserGesture): + (WebKit): + * src/WebSettingsImpl.h: + (WebSettingsImpl): + +2012-05-21 Shawn Singh <shawnsingh@chromium.org> + + [chromium] Add unit testing for WebTransformationMatrix::blend() + https://bugs.webkit.org/show_bug.cgi?id=87066 + + Reviewed by Adrienne Walker. + + 8 more unit tests added: + WebTransformationMatrixTest.verifyBlendForTranslation + WebTransformationMatrixTest.verifyBlendForScale + WebTransformationMatrixTest.verifyBlendForSkewX + WebTransformationMatrixTest.verifyBlendForSkewY + WebTransformationMatrixTest.verifyBlendForRotationAboutX + WebTransformationMatrixTest.verifyBlendForRotationAboutY + WebTransformationMatrixTest.verifyBlendForRotationAboutZ + WebTransformationMatrixTest.verifyBlendForCompositeTransform + + * tests/WebTransformationMatrixTest.cpp: + (WebKit::TEST): + (WebKit): + (WebKit::printTransform): -== Rolled over to ChangeLog-2012-10-02 == +== Rolled over to ChangeLog-2012-05-22 == diff --git a/Source/WebKit/chromium/ChangeLog-2012-10-02 b/Source/WebKit/chromium/ChangeLog-2012-10-02 deleted file mode 100644 index db050c28a..000000000 --- a/Source/WebKit/chromium/ChangeLog-2012-10-02 +++ /dev/null @@ -1,21142 +0,0 @@ -2012-10-02 Sadrul Habib Chowdhury <sadrul@chromium.org> - - [chromium] Make sure the touch-points in the touch-events have the correct state. - https://bugs.webkit.org/show_bug.cgi?id=98110 - - Reviewed by Adam Barth. - - It is necessary for the WebTouchPoints in the reconstructed WebTouchEvent - to have the correct state. Without this change, the states were always - unknown. - - * src/WebInputEventConversion.cpp: - (WebKit::toWebTouchPointState): - (WebKit): - (WebKit::addTouchPoints): - (WebKit::WebTouchEventBuilder::WebTouchEventBuilder): - -2012-10-02 Brian White <bcwhite@chromium.org> - - WebDocument doesn't export document language to outside users. - https://bugs.webkit.org/show_bug.cgi?id=98066 - - Reviewed by Adam Barth. - - Chromium uses the document language to offer translation. It's been doing - its own detection of this property but it would be better to get it from - existing extraction code. - - * public/WebDocument.h: - (WebDocument): - * src/WebDocument.cpp: - (WebKit::WebDocument::contentLanguage): - (WebKit): - -2012-10-02 Vangelis Kokkevis <vangelis@chromium.org> - - Remove call to FinishAllRendering when in force-compositing-mode. - https://bugs.webkit.org/show_bug.cgi?id=98111 - - It's not needed and makes the renderer synchronously wait for a glFinish - to happen in the gpu process. - - Reviewed by James Robinson. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - -2012-09-29 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI make String* instrumentation non intrusive - https://bugs.webkit.org/show_bug.cgi?id=97964 - - Reviewed by Yury Semikhatsky. - - The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - -2012-10-02 Jochen Eisinger <jochen@chromium.org> - - Use correct gtest macros for tests for true/false - - Unreviewed build-fix. - - Using EXPECT_EQ(true, ...) makes clang trip when it tries to convert - true to a pointer. Tests should use EXPECT_TRUE instead. - - * tests/WebFrameTest.cpp: - -2012-10-02 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r130129. - http://trac.webkit.org/changeset/130129 - https://bugs.webkit.org/show_bug.cgi?id=98125 - - broke 4 webkit_unit_tests - (MemoryInstrumentationTest.hashMapWith*) (Requested by caseq - on #webkit). - - * tests/MemoryInstrumentationTest.cpp: - -2012-09-29 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI make String* instrumentation non intrusive - https://bugs.webkit.org/show_bug.cgi?id=97964 - - Reviewed by Yury Semikhatsky. - - The expectations were fixed because old instrumentation had wrong detector for BufferInternal type of storage. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - -2012-10-01 Yoshifumi Inoue <yosin@chromium.org> - - REGRESSION(r130116): Need to update DateTimeFormatTest - https://bugs.webkit.org/show_bug.cgi?id=98120 - - Reviewed by Kent Tamura. - - This patch updates test cases for week of month and week of year type - specifiers in DateTimeFormat class. This tests should be updated - within r130116. - - * tests/DateTimeFormatTest.cpp: - (TEST_F): Changed test cases for changes of enum field value changes. - -2012-10-01 Keishi Hattori <keishi@webkit.org> - - Calendar picker should use zero as default step base - https://bugs.webkit.org/show_bug.cgi?id=97976 - - Reviewed by Kent Tamura. - - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): stepBase needs 11 digits of precision when setting maximum possible date. - -2012-10-01 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest - https://bugs.webkit.org/show_bug.cgi?id=94757 - - Reviewed by Tony Chang. - - * tests/IDBRequestTest.cpp: Ensure IDBRequest can handle Error after abort. - (WebCore::TEST): Added AbortAfter - -2012-10-01 Ilya Tikhonovsky <loislo@chromium.org> - - Unreviewed single line compilation fix for Canary Debug Mac. - - * tests/MemoryInstrumentationTest.cpp: - -2012-10-01 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: provide memory instrumentation for HashMap - https://bugs.webkit.org/show_bug.cgi?id=98005 - - Reviewed by Pavel Feldman. - - Added unit tests for HashMap memory instrumentation. - - * tests/MemoryInstrumentationTest.cpp: - (WTF): - -2012-10-01 Alexander Pavlov <apavlov@chromium.org> - - Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay - https://bugs.webkit.org/show_bug.cgi?id=97799 - - Reviewed by Pavel Feldman. - - - Dispatch the webViewResized() event on InspectorController, which is necessary to update the InspectorOverlay. - - Remove the gutter overlay painting code. - - * src/WebDevToolsAgentImpl.cpp: - (WebKit::DeviceMetricsSupport::DeviceMetricsSupport): - (WebKit::DeviceMetricsSupport::~DeviceMetricsSupport): - (WebKit::WebDevToolsAgentImpl::attach): - (WebKit::WebDevToolsAgentImpl::webViewResized): - (WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics): - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - * src/WebDevToolsAgentPrivate.h: - (WebDevToolsAgentPrivate): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::resize): - -2012-09-28 Jian Li <jianli@chromium.org> - - Add draggable property to WebDraggableRegion. - https://bugs.webkit.org/show_bug.cgi?id=97950 - - Reviewed by Adam Barth. - - This needs to be done before we can land the patch to use new syntax for - draggable regions. This is because Chromium side code cannot enable - the changes to support new syntax side by side when this property is - not present. - - * public/WebDraggableRegion.h: - (WebDraggableRegion): - -2012-09-28 Adam Barth <abarth@webkit.org> - - [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver - https://bugs.webkit.org/show_bug.cgi?id=97934 - - Reviewed by James Robinson. - - After http://trac.webkit.org/changeset/129910, WebFrameImpl inherits - from FrameDestructionObserver, which means it no longer need to manage - its own weak pointer to WebCore::Frame. - - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::frameLoaderDestroyed): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::WebFrameImpl): - (WebKit::WebFrameImpl::setWebCoreFrame): - * src/WebFrameImpl.h: - (WebKit::WebFrameImpl::frameView): - -2012-09-28 Stephen Chenney <schenney@chromium.org> - - Unreviewed Chromium Win build fix. - - * src/WebViewImpl.cpp: Added "f" on initializers for floats. - (WebKit): - * tests/WebFrameTest.cpp: Added "f" on initializers for floats. - -2012-09-28 Yusuf Ozuysal <yusufo@google.com> - - [Chromium]Add DoubleTap gesture - https://bugs.webkit.org/show_bug.cgi?id=90316 - - Reviewed by Adam Barth. - - Added doubleTapGesture implementation and hooked it to an already present function computeScaleAndScrollForHitRect. Added 2 new tests and changed one based on the new implementation. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::handleGestureEvent): - (WebKit::WebViewImpl::computeScaleAndScrollForHitRect): - (WebKit::WebViewImpl::animateZoomAroundPoint): - (WebKit::WebViewImpl::didCommitLoad): - (WebKit::WebViewImpl::applyScrollAndScale): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/WebFrameTest.cpp: - * tests/data/get_multiple_divs_for_auto_zoom_test.html: Added. - * tests/data/get_scale_bounds_check_for_auto_zoom_test.html: Added. - * tests/data/get_scale_for_auto_zoom_into_div_test.html: - -2012-09-28 Adam Barth <abarth@webkit.org> - - [Chromium] WebFrameImpl.cpp could use a style cleanup - https://bugs.webkit.org/show_bug.cgi?id=97924 - - Reviewed by Dimitri Glazkov. - - This file is very old and contains a large number of style errors that - are confusing folks contributing new code to this file. Most of these - styles are Chromium-isms that crept in when the file was forked in the - Chromium repository. - - * src/WebFrameImpl.cpp: - (WebKit): - (WebKit::frameContentAsPlainText): - (ChromePrintContext): - (WebKit::ChromePrintContext::spoolPage): - (WebKit::ChromePrintContext::spoolAllPagesWithBoundaries): - (ChromePluginPrintContext): - (WebKit::ChromePluginPrintContext::spoolPage): - (WebKit::WebFrameImpl::DeferredScopeStringMatches::DeferredScopeStringMatches): - (WebKit::WebFrameImpl::DeferredScopeStringMatches::doTimeout): - (WebKit::WebFrame::fromFrameOwnerElement): - (WebKit::WebFrameImpl::uniqueName): - (WebKit::WebFrameImpl::assignedName): - (WebKit::WebFrameImpl::setName): - (WebKit::WebFrameImpl::iconURLs): - (WebKit::WebFrameImpl::scrollOffset): - (WebKit::WebFrameImpl::minimumScrollOffset): - (WebKit::WebFrameImpl::maximumScrollOffset): - (WebKit::WebFrameImpl::contentsPreferredWidth): - (WebKit::WebFrameImpl::documentElementScrollHeight): - (WebKit::WebFrameImpl::hasHorizontalScrollbar): - (WebKit::WebFrameImpl::hasVerticalScrollbar): - (WebKit::WebFrameImpl::opener): - (WebKit::WebFrameImpl::setOpener): - (WebKit::WebFrameImpl::parent): - (WebKit::WebFrameImpl::top): - (WebKit::WebFrameImpl::firstChild): - (WebKit::WebFrameImpl::lastChild): - (WebKit::WebFrameImpl::nextSibling): - (WebKit::WebFrameImpl::previousSibling): - (WebKit::WebFrameImpl::traverseNext): - (WebKit::WebFrameImpl::traversePrevious): - (WebKit::WebFrameImpl::findChildByName): - (WebKit::WebFrameImpl::findChildByExpression): - (WebKit::WebFrameImpl::document): - (WebKit::WebFrameImpl::performance): - (WebKit::WebFrameImpl::windowObject): - (WebKit::WebFrameImpl::bindToWindowObject): - (WebKit::WebFrameImpl::executeScript): - (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): - (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin): - (WebKit::WebFrameImpl::collectGarbage): - (WebKit::WebFrameImpl::checkIfRunInsecureContent): - (WebKit::WebFrameImpl::executeScriptAndReturnValue): - (WebKit::WebFrameImpl::callFunctionEvenIfScriptDisabled): - (WebKit::WebFrameImpl::mainWorldScriptContext): - (WebKit::WebFrameImpl::createFileSystem): - (WebKit::WebFrameImpl::createSerializableFileSystem): - (WebKit::WebFrameImpl::createFileEntry): - (WebKit::WebFrameImpl::reload): - (WebKit::WebFrameImpl::reloadWithOverrideURL): - (WebKit::WebFrameImpl::loadRequest): - (WebKit::WebFrameImpl::loadHistoryItem): - (WebKit::WebFrameImpl::loadData): - (WebKit::WebFrameImpl::loadHTMLString): - (WebKit::WebFrameImpl::isLoading): - (WebKit::WebFrameImpl::stopLoading): - (WebKit::WebFrameImpl::provisionalDataSource): - (WebKit::WebFrameImpl::dataSource): - (WebKit::WebFrameImpl::previousHistoryItem): - (WebKit::WebFrameImpl::currentHistoryItem): - (WebKit::WebFrameImpl::enableViewSourceMode): - (WebKit::WebFrameImpl::isViewSourceModeEnabled): - (WebKit::WebFrameImpl::setReferrerForRequest): - (WebKit::WebFrameImpl::dispatchWillSendRequest): - (WebKit::WebFrameImpl::commitDocumentData): - (WebKit::WebFrameImpl::insertText): - (WebKit::WebFrameImpl::setMarkedText): - (WebKit::WebFrameImpl::firstRectForCharacterRange): - (WebKit::WebFrameImpl::executeCommand): - (WebKit::WebFrameImpl::requestTextChecking): - (WebKit::WebFrameImpl::selectWordAroundPosition): - (WebKit::WebFrameImpl::selectRange): - (WebKit::WebFrameImpl::visiblePositionForWindowPoint): - (WebKit::WebFrameImpl::printBegin): - (WebKit::WebFrameImpl::getPrintPageShrink): - (WebKit::WebFrameImpl::printPage): - (WebKit::WebFrameImpl::printEnd): - (WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin): - (WebKit::WebFrameImpl::pageSizeAndMarginsInPixels): - (WebKit::WebFrameImpl::pageProperty): - (WebKit::WebFrameImpl::find): - (WebKit::WebFrameImpl::scopeStringMatches): - (WebKit::WebFrameImpl::reportFindInPageSelection): - (WebKit::WebFrameImpl::sendOrientationChangeEvent): - (WebKit::WebFrameImpl::addEventListener): - (WebKit::WebFrameImpl::removeEventListener): - (WebKit::WebFrameImpl::dispatchEvent): - (WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck): - (WebKit::WebFrameImpl::isActiveMatchFrameValid): - (WebKit::WebFrameImpl::deliverIntent): - (WebKit::WebFrameImpl::contentAsText): - (WebKit::WebFrameImpl::contentAsMarkup): - (WebKit::WebFrameImpl::renderTreeAsText): - (WebKit::WebFrameImpl::printPagesWithBoundaries): - (WebKit::WebFrameImpl::selectionBoundsRect): - (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor): - (WebKit::WebFrameImpl::layerTreeAsText): - (WebKit::WebFrameImpl::initializeAsMainFrame): - (WebKit::WebFrameImpl::createChildFrame): - (WebKit::WebFrameImpl::createFrameView): - (WebKit::WebFrameImpl::fromFrame): - (WebKit::WebFrameImpl::fromFrameOwnerElement): - (WebKit::WebFrameImpl::viewImpl): - (WebKit::WebFrameImpl::setCanHaveScrollbars): - (WebKit::WebFrameImpl::setMarkerActive): - (WebKit::WebFrameImpl::ordinalOfFirstMatchForFrame): - (WebKit::WebFrameImpl::scopeStringMatchesSoon): - (WebKit::WebFrameImpl::callScopeStringMatches): - (WebKit::WebFrameImpl::invalidateIfNecessary): - (WebKit::WebFrameImpl::loadJavaScriptURL): - -2012-09-28 Kent Tamura <tkent@chromium.org> - - Add parseDateTime, formatDateTime, and dateFormatText to Localizer - https://bugs.webkit.org/show_bug.cgi?id=97885 - - Reviewed by Kentaro Hara. - - * tests/LocaleMacTest.cpp: Follow renaming of LocaleMac functions. - (LocaleMacTest::formatDate): - (LocaleMacTest::parseDate): - * tests/LocaleWinTest.cpp: Follow renaming of LocaleWin functions. - (LocaleWinTest::formatDate): - (LocaleWinTest::parseDate): - -2012-09-28 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Fix the find-in-page implementation for detaching frames. - https://bugs.webkit.org/show_bug.cgi?id=97807 - - Reviewed by Adam Barth. - - Follow-up of 97688. Introduces proper test coverage for the find-in-page - feature in detaching/detached frame situations, fixing a few crashes and - ensuring that a final reply is always sent. - - * public/WebNode.h: - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::find): - (WebKit::WebFrameImpl::scopeStringMatches): - (WebKit::WebFrameImpl::flushCurrentScopingEffort): - (WebKit): - (WebKit::WebFrameImpl::finishCurrentScopingEffort): - (WebKit::WebFrameImpl::cancelPendingScopingEffort): - (WebKit::WebFrameImpl::WebFrameImpl): - (WebKit::WebFrameImpl::setWebCoreFrame): - (WebKit::WebFrameImpl::initializeAsMainFrame): - (WebKit::WebFrameImpl::createChildFrame): - (WebKit::WebFrameImpl::shouldScopeMatches): - (WebKit::WebFrameImpl::willDetachPage): - * src/WebFrameImpl.h: - (WebFrameImpl): - * src/WebNode.cpp: - (WebKit::WebNode::remove): - (WebKit): - * tests/WebFrameTest.cpp: - * tests/data/find_in_page.html: - -2012-09-28 Kent Tamura <tkent@chromium.org> - - Clean up Localizer-related functions - https://bugs.webkit.org/show_bug.cgi?id=97899 - - Reviewed by Kentaro Hara. - - * src/ColorChooserUIController.cpp: - (WebKit::ColorChooserUIController::ColorChooserUIController): - Use Localizer::createDefault - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): ditto. - -2012-09-28 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r129882. - http://trac.webkit.org/changeset/129882 - https://bugs.webkit.org/show_bug.cgi?id=97913 - - Repaint is incorrect on many tests (Requested by schenney on - #webkit). - - * src/WebDevToolsAgentImpl.cpp: - (OverlayZOrders): - (WebKit::DeviceMetricsSupport::DeviceMetricsSupport): - (WebKit::DeviceMetricsSupport::~DeviceMetricsSupport): - (WebKit::DeviceMetricsSupport::restore): - (WebKit::DeviceMetricsSupport::paintPageOverlay): - (DeviceMetricsSupport): - (WebKit::WebDevToolsAgentImpl::attach): - (WebKit::WebDevToolsAgentImpl::webViewResized): - (WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics): - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - * src/WebDevToolsAgentPrivate.h: - (WebDevToolsAgentPrivate): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::resize): - -2012-09-28 Kentaro Hara <haraken@chromium.org> - - Unreviewed, rolling out r129825. - http://trac.webkit.org/changeset/129825 - https://bugs.webkit.org/show_bug.cgi?id=97474 - - DOMWindow.resizeTo() is broken. Asked by Mark Pilgrim. - - * public/WebScreenInfo.h: - (WebKit): - (WebScreenInfo): - (WebKit::WebScreenInfo::WebScreenInfo): - * src/ChromeClientImpl.cpp: - * src/ChromeClientImpl.h: - (WebKit): - (WebKit::ChromeClientImpl::platformPageClient): - (ChromeClientImpl): - * src/PlatformSupport.cpp: - (WebCore::toWebWidgetClient): - (WebCore): - (WebCore::PlatformSupport::screenHorizontalDPI): - (WebCore::PlatformSupport::screenVerticalDPI): - (WebCore::PlatformSupport::screenDepth): - (WebCore::PlatformSupport::screenDepthPerComponent): - (WebCore::PlatformSupport::screenIsMonochrome): - (WebCore::PlatformSupport::screenRect): - (WebCore::PlatformSupport::screenAvailableRect): - -2012-09-27 Alexander Pavlov <apavlov@chromium.org> - - Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay - https://bugs.webkit.org/show_bug.cgi?id=97799 - - Reviewed by Pavel Feldman. - - - Dispatch the webViewResized() event on InspectorController, which is necessary to update the InspectorOverlay. - - Remove the gutter overlay painting code. - - * src/WebDevToolsAgentImpl.cpp: - (WebKit::DeviceMetricsSupport::DeviceMetricsSupport): - (WebKit::DeviceMetricsSupport::~DeviceMetricsSupport): - (WebKit::WebDevToolsAgentImpl::attach): - (WebKit::WebDevToolsAgentImpl::webViewResized): - (WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics): - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - * src/WebDevToolsAgentPrivate.h: - (WebDevToolsAgentPrivate): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::resize): - -2012-09-28 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: [chromium] remove devtools_frontend.zip - https://bugs.webkit.org/show_bug.cgi?id=97650 - - Reviewed by Yury Semikhatsky. - - This change removes the devtools_frontend zip generation and migrates to proper resource bundle for debug mode creation. - - * WebKit.gyp: - * scripts/generate_devtools_zip.py: Removed. - -2012-09-28 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: make HashSet memory instrumentation non-intrusive - https://bugs.webkit.org/show_bug.cgi?id=97879 - - Reviewed by Vsevolod Vlasov. - - Update the test for HashSet memory instrumentation. We don't add - HashSet's private objects into the set of visited objects any more - and should update the expectation accordingly. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - -2012-09-27 Kent Tamura <tkent@chromium.org> - - Use Localizer in PagePopupController - https://bugs.webkit.org/show_bug.cgi?id=97862 - - Reviewed by Hajime Morita. - - We need to implement PagePopupClient::localizer. The current - implementations of localizer functions always return Localizer objects - for the browser locale. It's ok because other locale-dependent stuff in - PagePopup uses the browser locale, not element locale. We might want to - update this behavior later for testing i18n behavior in PagePopup. - - * src/ColorChooserUIController.cpp: - (WebKit::ColorChooserUIController::ColorChooserUIController): - Initialize m_localizer with the browser default locale. - (WebKit::ColorChooserUIController::localizer): - Returns m_localizer. - * src/ColorChooserUIController.h: - (ColorChooserUIController): Declare localizer function and m_localizer. - - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): - Initialize m_localizer with the browser default locale. - (WebKit::DateTimeChooserImpl::localizer): - Returns m_localizer. - * src/DateTimeChooserImpl.h: - (DateTimeChooserImpl): Declare localizer function and m_localizer. - -2012-09-28 Kent Tamura <tkent@chromium.org> - - Switch monthLabels, weekDayShortLabels, and firstDayOfWeek to Localizer - https://bugs.webkit.org/show_bug.cgi?id=97874 - - Reviewed by Kentaro Hara. - - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): - Use Localizer for the browser locale. - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Update WebVector.h references - https://bugs.webkit.org/show_bug.cgi?id=97855 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/ApplicationCacheHost.cpp: - * src/AudioDestinationChromium.h: - * src/AutofillPopupMenuClient.cpp: - * src/CompositionUnderlineBuilder.h: - * src/CompositionUnderlineVectorBuilder.h: - * src/ContextMenuClientImpl.cpp: - * src/ExternalPopupMenu.cpp: - * src/FrameLoaderClientImpl.cpp: - * src/PlatformSupport.cpp: - * src/WebDataSourceImpl.cpp: - * src/WebDragData.cpp: - * src/WebFileChooserCompletionImpl.h: - * src/WebFileSystemCallbacksImpl.h: - * src/WebFrameImpl.cpp: - * src/WebHistoryItem.cpp: - * src/WebIDBKeyPath.cpp: - * src/WebIDBMetadata.cpp: - * src/WebNode.cpp: - * src/WebPageSerializer.cpp: - * src/WebPageSerializerImpl.cpp: - * src/WebTextCheckingCompletionImpl.cpp: - * src/WorkerFileSystemCallbacksBridge.h: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Update comment in WebFrameClient to point to new userAgent() function - https://bugs.webkit.org/show_bug.cgi?id=97854 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * public/WebFrameClient.h: - (WebFrameClient): - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Remove unused PlatformSupport reference in ChromeClientImpl - https://bugs.webkit.org/show_bug.cgi?id=97853 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/ChromeClientImpl.cpp: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Clean up includes in DateTimeChooserImpl - https://bugs.webkit.org/show_bug.cgi?id=97847 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/DateTimeChooserImpl.cpp: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Clean up includes in ColorChooserUIController - https://bugs.webkit.org/show_bug.cgi?id=97849 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/ColorChooserUIController.cpp: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Clean up includes in PaintAggregator - https://bugs.webkit.org/show_bug.cgi?id=97848 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/painting/PaintAggregator.cpp: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Clean up includes in SocketStreamHandle - https://bugs.webkit.org/show_bug.cgi?id=97843 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/SocketStreamHandle.cpp: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Clean up includes in AudioDestinationChromium - https://bugs.webkit.org/show_bug.cgi?id=97845 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/AudioDestinationChromium.cpp: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Remove unused PlatformSupport reference in WebFrameImpl - https://bugs.webkit.org/show_bug.cgi?id=97842 - - Reviewed by Kentaro Hara. - - Part of a refactoring series. See tracking bug 82948. - - * src/WebFrameImpl.cpp: - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Remove screen-related functions from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=97474 - - Reviewed by Adam Barth. - - Screen-related functions like screenHorizontalDPI that - used to be on PlatformSupport are now accessed through a new - PlatformPageClient attached to Widget in WebCore-land, which is - implemented by ChromeClientImpl in WebKit-land, which proxies - calls to WebWidgetClient, which is actually implemented in - Chromium-land. - - * public/WebScreenInfo.h: - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::screenInfo): - (WebKit): - * src/ChromeClientImpl.h: - (WebKit): - (WebKit::ChromeClientImpl::platformPageClient): - (ChromeClientImpl): - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-27 Nasko Oskov <nasko@chromium.org> - - Remove unused methods from Chromium WebKit API. - https://bugs.webkit.org/show_bug.cgi?id=95254 - - Reviewed by Adam Barth. - - Removing methods, which are no longer in use. - - * public/WebFrame.h: - * public/WebFrameClient.h: - (WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): - * src/WebFrameImpl.cpp: - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium][Mac] Move Mac-specific theme functions out of PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=97817 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. We're calling WebThemeEngine directly now instead of proxying through PlatformSupport. - - * src/AssertMatchingEnums.cpp: - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-27 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move UNIX-specific theme functions out of PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=96516 - - Reviewed by Adam Barth. - - Call WebThemeEngine functions and use WebThemeEngine enums - directly from the new Platform/ directly; remove all - intermediate functions and enums and conversion functions from - PlatformSupport. - Part of a refactoring series; see tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-27 Andrey Kosyakov <caseq@chromium.org> - - Page overlays are not updated when WebView is resized - https://bugs.webkit.org/show_bug.cgi?id=97789 - - Reviewed by Vsevolod Vlasov. - - Invalidate page overlays when view is resized. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::sendResizeEventAndRepaint): - -2012-09-27 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-27 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: move visited and countObjectSize methods implementation into separate class. - https://bugs.webkit.org/show_bug.cgi?id=97461 - - Reviewed by Yury Semikhatsky. - - These methods and the data collected by them need to be used in the instrumentation code for other components. - As example when we are visiting bitmaps we need to visit platform specific objects. - These objects will be instrumented with help of component's own instrumentation code - but we have to keep the single set of visited objects and the map of counters. - - * tests/MemoryInstrumentationTest.cpp: - (InstrumentationTestHelper): - (WebCore::InstrumentationTestHelper::InstrumentationTestHelper): - (WebCore::InstrumentationTestHelper::addRootObject): - (WebCore::InstrumentationTestHelper::reportedSizeForAllTypes): - (WebCore::InstrumentationTestHelper::visitedObjects): - (WebCore::InstrumentationTestHelper::totalSize): - (WebCore): - (WebCore::TEST): - -2012-09-27 Allan Sandfeld Jensen <allan.jensen@digia.com> - - Unify event handling of middle mouse button. - https://bugs.webkit.org/show_bug.cgi?id=97690 - - Reviewed by Tony Chang. - - Remove port specific handling of middle mouse button press. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleMouseUp): - -2012-09-27 Tommy Widenflycht <tommyw@google.com> - - MediaStream API: Update getUserMedia to match the latest specification - https://bugs.webkit.org/show_bug.cgi?id=97540 - - Reviewed by Adam Barth. - - http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia - Navigator.getUserMedia is changed so that the audio and video members can either - be a bool or a constraints object. - - * public/WebUserMediaRequest.h: - (WebKit): - (WebUserMediaRequest): - * src/WebUserMediaRequest.cpp: - (WebKit::WebUserMediaRequest::audioConstraints): - (WebKit): - (WebKit::WebUserMediaRequest::videoConstraints): - -2012-09-27 Keishi Hattori <keishi@webkit.org> - - SuggestionPicker should support rtl - https://bugs.webkit.org/show_bug.cgi?id=97555 - - Reviewed by Kent Tamura. - - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): - -2012-09-26 Yoshifumi Inoue <yosin@chromium.org> - - [Forms] Adding localization texts for multiple fields date/time input UI - https://bugs.webkit.org/show_bug.cgi?id=97633 - - Reviewed by Kent Tamura. - - This patch adds functions for getting localized strings used in - multiple fields date/time input UI inside ENABLE_INPUT_MULTIPLE_FIELDS_UI. - - These functions will be used by DateInputType, DateTimeInputType, - DateTimeLocalInputType, MonthInputTypee, and WeekInputType. - - * src/LocalizedStrings.cpp: - (WebCore::placeholderForDayOfMonthField): Added. - (WebCore::placeholderForMonthField): Added. - (WebCore::placeholderForYearField): Added. - (WebCore::monthFormatInLDML): Added. - (WebCore::weekFormatInLDML): Added. - -2012-09-26 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r129673. - http://trac.webkit.org/changeset/129673 - https://bugs.webkit.org/show_bug.cgi?id=97723 - - Causing window build breakage (Requested by alecf on #webkit). - - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::ensureFontLoaded): - -2012-09-26 Sadrul Habib Chowdhury <sadrul@chromium.org> - - [chromium] Do not dispatch touch-events to plugins unless they explicitly request for touch-events. - https://bugs.webkit.org/show_bug.cgi?id=97685 - - Reviewed by Adam Barth. - - Plugins need to call setIsAcceptingTouchEvents if they want to receive touch-events. So - avoid dispatching touch-events to plugins unless they have explicitly requested for them. - - * src/WebPluginContainerImpl.cpp: - -2012-09-26 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium][Win] Remove ensureFontLoaded from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=97696 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::ensureFontLoaded): - -2012-09-26 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Fix find-in-page corner case for detached frames - https://bugs.webkit.org/show_bug.cgi?id=97688 - - Reviewed by Adam Barth. - - Adds a check to prevent crashes when running find-in-page requests - on detached frames. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::scopeStringMatches): - -2012-09-26 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: replace manual JS external resources counting with MemoryInstrumentation - https://bugs.webkit.org/show_bug.cgi?id=97662 - - Reviewed by Yury Semikhatsky. - - Old schema used sizeInBytes method on StringImpl. This method works incorrect for substrings. - Also we'd like to know exact pointers to strings and buffers for verification purposes. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - (WebCore): - -2012-09-25 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: extract HashSet instrumentation from core NMI code and put it into MemoryInstrumentationHashSet.h - https://bugs.webkit.org/show_bug.cgi?id=97198 - - Reviewed by Yury Semikhatsky. - - Current implementation has overloads for HashSet. - This prevents us from instrumenting complex cases like Vector<HashSet<...> >. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - (WebCore): - -2012-09-25 Andrey Kosyakov <caseq@chromium.org> - - Web Inspector: [chromium] add a test for inspector overlay update frequency - https://bugs.webkit.org/show_bug.cgi?id=97567 - - Reviewed by Yury Semikhatsky. - - Added a test for reasonable number of frames caused by inspector page overlay. - We expect changes in nodes being inspected to cause an update, while just idling - should not cause large numbers of unexpected updates. - - * src/js/Tests.js: - (.TestSuite.prototype.testPageOverlayUpdate): - (.TestSuite.prototype.testPageOverlayUpdate.innerAddRecord): - (.TestSuite.prototype.testPageOverlayUpdate.populatePage): - (.TestSuite.prototype.testPageOverlayUpdate.step2): - (.TestSuite.prototype.testPageOverlayUpdate.step4): - (.TestSuite.prototype.testPageOverlayUpdate.step5): - -2012-09-26 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: compare objects counted by the memory instrumentation with those allocated in the heap - https://bugs.webkit.org/show_bug.cgi?id=97641 - - Reviewed by Pavel Feldman. - - Added code that allows to check if all objects counted by the memory instrumentation - were allocated by the underlying memory allocator. It requires support - from the memory allocator this is why WebDevToolsAgentClient API is extended with a - method that allows to visit pointers to all live heap objects if the memory allocator - supports that. - - The code should only be used for debugging purposes. - - * public/WebDevToolsAgentClient.h: - (AllocatedObjectVisitor): - (WebKit::WebDevToolsAgentClient::AllocatedObjectVisitor::~AllocatedObjectVisitor): - (WebKit::WebDevToolsAgentClient::visitAllocatedObjects): - (WebDevToolsAgentClient): - * src/InspectorClientImpl.cpp: - (WebKit): - (WebKit::InspectorClientImpl::getAllocatedObjects): - * src/InspectorClientImpl.h: - (InspectorClientImpl): - * src/WebDevToolsAgentImpl.cpp: - (WebKit): - (WebKit::WebDevToolsAgentImpl::getAllocatedObjects): - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - -2012-09-26 Yoshifumi Inoue <yosin@chromium.org> - - Rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI - https://bugs.webkit.org/show_bug.cgi?id=97640 - - Reviewed by Kent Tamura. - - This patch renames ENABLE_INPUT_TYPE_TIME MULTIPLE_FIELDS feature - flag to ENABLE_INPUT_MULTIPLE_FIELDS_UI for implementing multiple - fields date/time input UI other than input type "time". - - * features.gypi: - * src/LocalizedStrings.cpp: - (WebCore): - * tests/DateTimeFormatTest.cpp: - * tests/LocaleMacTest.cpp: - (LocaleMacTest): - * tests/LocaleWinTest.cpp: - (LocaleWinTest): - * tests/LocalizedDateICUTest.cpp: - * tests/LocalizedNumberICUTest.cpp: - -2012-09-25 Alpha Lam <hclam@chromium.org> - - Unreviewed. Roll DEPS for Chromium. - - * DEPS: - -2012-09-25 Beth Dakin <bdakin@apple.com> - - https://bugs.webkit.org/show_bug.cgi?id=95397 - Need to merge didFirstVisuallyNonEmptyLayout and - didNewFirstVisuallyNonEmptyLayout - -and corresponding- - <rdar://problem/10791680> - - Reviewed by Sam Weinig. - - Remove dispatchDidFirstLayout, - dispatchDidFirstVisuallyNonEmptyLayout, and - dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality - is now replaced by dispatchDidLayout(LayoutMilestoneOptions) - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::dispatchDidLayout): - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - - It is now necessary to opt into getting any of the - "layout milestone" notifications. - * src/WebHelperPluginImpl.cpp: - (WebKit::WebHelperPluginImpl::initPage): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::initPage): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - -2012-09-25 Joshua Bell <jsbell@chromium.org> - - IndexedDB: One transaction coordinator per database - https://bugs.webkit.org/show_bug.cgi?id=97501 - - Reviewed by Tony Chang. - - Remove obsolete argument. - - * tests/IDBDatabaseBackendTest.h: - -2012-09-25 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r129517. - http://trac.webkit.org/changeset/129517 - https://bugs.webkit.org/show_bug.cgi?id=97582 - - Link errors in chromium (Requested by alecf on #webkit). - - * public/WebUserMediaRequest.h: - (WebUserMediaRequest): - * src/WebUserMediaRequest.cpp: - -2012-09-25 Dominic Mazzoni <dmazzoni@google.com> - - AX: Chromium doesn't pass accessibility text range and line number tests - https://bugs.webkit.org/show_bug.cgi?id=97246 - - Reviewed by Chris Fleizach. - - Use improved implementation of AccessibilityRenderObject::lineBreaks - and implement methods to get the line number of the selection and - to set the text range. - - Enables four existing tests to pass on Chromium: - Tests: accessibility/textarea-insertion-point-line-number.html - accessibility/textarea-line-for-index.html - accessibility/textarea-selected-text-range.html - accessibility/textbox-role-reports-selection.html - - * public/WebAccessibilityObject.h: - (WebAccessibilityObject): - * src/WebAccessibilityObject.cpp: - (WebKit::WebAccessibilityObject::selectionEndLineNumber): - (WebKit): - (WebKit::WebAccessibilityObject::selectionStartLineNumber): - (WebKit::WebAccessibilityObject::setSelectedTextRange): - (WebKit::WebAccessibilityObject::lineBreaks): - -2012-09-25 Tommy Widenflycht <tommyw@google.com> - - MediaStream API: Update getUserMedia to match the latest specification - https://bugs.webkit.org/show_bug.cgi?id=97540 - - Reviewed by Adam Barth. - - http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia - Navigator.getUserMedia is changed so that the audio and video members can either - be a bool or a constraints object. - - * public/WebUserMediaRequest.h: - (WebKit): - (WebUserMediaRequest): - * src/WebUserMediaRequest.cpp: - (WebKit::WebUserMediaRequest::audioConstraints): - (WebKit): - (WebKit::WebUserMediaRequest::videoConstraints): - -2012-09-24 Andrey Kosyakov <caseq@chromium.org> - - [chromium] adding a page overlay causes endless update loop when accelerated compositing is used - https://bugs.webkit.org/show_bug.cgi?id=97466 - - Reviewed by James Robinson. - - Do not update overlays in composite() -- doing so ultimately causes invalidation - of the view, hence another update and another call do composite(). Overlays should be - updated only when their content changes. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::composite): - -2012-09-21 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: extract Vector instrumentation from core NMI code into MemoryInstrumentationVector.h header. - https://bugs.webkit.org/show_bug.cgi?id=96650 - - Reviewed by Vsevolod Vlasov. - - Test for instrumented vector. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::InstrumentedOwner::InstrumentedOwner): - (WebCore::TEST): - (WebCore): - -2012-09-24 Benjamin Poulain <bpoulain@apple.com> - - Fix Geolocation error reporting in the test support - https://bugs.webkit.org/show_bug.cgi?id=97386 - - Reviewed by Sam Weinig. - - * public/WebGeolocationClientMock.h: - (WebGeolocationClientMock): - * src/WebGeolocationClientMock.cpp: - (WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError): - -2012-09-24 Kent Tamura <tkent@chromium.org> - - [Chromium] Implement ValidationMessageClient for Chromium - https://bugs.webkit.org/show_bug.cgi?id=97167 - - Reviewed by Hajime Morita. - - Introduce ValidationMessageClientImpl. However actual popup - implementation should be done in WebViewClient. - - * WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}. - * public/WebViewClient.h: - (WebKit::WebViewClient::showValidationMessage): Added. - (WebKit::WebViewClient::hideValidationMessage): Added. - * src/ValidationMessageClientImpl.cpp: Added. - (WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl): - (WebKit::ValidationMessageClientImpl::create): - (WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl): - Make sure that a popup is closed. - (WebKit::ValidationMessageClientImpl::showValidationMessage): - Implementataion of ValidationMessageClient::showValidationMessage. - minimumSecondToShowValidationMessage and secondPerCharacter are same as - the corresponding values in the current Shadow DOM implementation. - (WebKit::ValidationMessageClientImpl::hideValidationMessage): - Implementataion of ValidationMessageClient::hideValidationMessage. - (WebKit::ValidationMessageClientImpl::isValidationMessageVisible): - Implementataion of ValidationMessageClient::isValidationMessageVisible. - (WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage): - This is a callback function for the timer. - * src/ValidationMessageClientImpl.h: Added. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - - Initialize m_validationMessage. - - Add a comment for PageClients. - * src/WebViewImpl.h: - Add m_validationMessage. - -2012-09-24 Mihai Parparita <mihaip@chromium.org> - - [Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled} - https://bugs.webkit.org/show_bug.cgi?id=97506 - - Reviewed by Adam Barth. - - These methods have been no-ops since r127674. All Chromium code that - called them was removed with http://crrev.com/155205. - - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): - * src/WebRuntimeFeatures.cpp: - -2012-09-24 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium][Mac] Remove loadFont from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=97360 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-24 Tony Chang <tony@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-24 Dana Jansens <danakj@chromium.org> - - [chromium] Add setters to WebFilterOperation for IPC pickling - https://bugs.webkit.org/show_bug.cgi?id=97147 - - Reviewed by James Robinson. - - * tests/FilterOperationsTest.cpp: - (WebKit): - (WebKit::TEST): - -2012-09-24 Patrick Gansterer <paroga@webkit.org> - - Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files - https://bugs.webkit.org/show_bug.cgi?id=97412 - - Reviewed by Adam Barth. - - * src/WebPageSerializerImpl.cpp: - (WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append(). - (WebKit::WebPageSerializerImpl::endTagToString): Ditto. - -2012-09-24 Yury Semikhatsky <yurys@chromium.org> - - Unreviewed, rolling out r122243. - http://trac.webkit.org/changeset/129243 - https://bugs.webkit.org/show_bug.cgi?id=97441 - - WebFilterOperationsTest.saveAndRestore added in the change is failing. - - * tests/FilterOperationsTest.cpp: - -2012-09-23 Keishi Hattori <keishi@webkit.org> - - Add suggestionPicker to CalendarPicker - https://bugs.webkit.org/show_bug.cgi?id=97201 - - Reviewed by Kent Tamura. - - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args. - -2012-09-21 Kenichi Ishibashi <bashi@chromium.org> - - [Chromium] Use OpenTypeVerticalData on Linux - https://bugs.webkit.org/show_bug.cgi?id=97277 - - Reviewed by Tony Chang. - - * features.gypi: Enable OPENTYPE_VERTICAL on linux and android. - -2012-09-21 Dirk Pranke <dpranke@chromium.org> - - Roll Chromium DEPS to r158095 to pick up typo fix in test_expectations.txt - - Unreviewed, rolled DEPS. - - * DEPS: - -2012-09-21 Dirk Pranke <dpranke@chromium.org> - - Roll Chromium DEPS to r158060 - - Unreviewed, rolled DEPS. - - * DEPS: - -2012-09-21 Chris Rogers <crogers@google.com> - - Add Web Audio support for deprecated/legacy APIs - https://bugs.webkit.org/show_bug.cgi?id=97050 - - Reviewed by Eric Carlson. - - * features.gypi: - -2012-09-21 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] remove getFontFamilyForCharacters from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=96282 - - Reviewed by Tony Chang. - - Migrating away from PlatformSupport. getFontFamilyForCharacters is - moved to FontCache.h and overridden by the two platforms that - need it (Chromium Linux and Blackberry). New files for the overrides. - Part of a larger refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-21 Dana Jansens <danakj@chromium.org> - - [chromium] Add setters to WebFilterOperation for IPC pickling - https://bugs.webkit.org/show_bug.cgi?id=97147 - - Reviewed by James Robinson. - - * tests/FilterOperationsTest.cpp: - (WebKit): - (WebKit::TEST): - -2012-09-21 Tony Chang <tony@chromium.org> - - [chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico. - - * WebKit.gyp: - -2012-09-21 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-21 Sami Kyostila <skyostil@chromium.org> - - [chromium] Add test for ScrollingCoordinatorChromium - https://bugs.webkit.org/show_bug.cgi?id=96657 - - Reviewed by James Robinson. - - Add tests for ScrollingCoordinatorChromium. These tests mainly verify that - fast (non-main thread) scrolling is enabled when necessary and that a proper - compositing layer structure is created for fixed position and accelerated - scrolling layers. - - Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault - ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition - ScrollingCoordinatorChromiumTest.nonFastScrollableRegion - ScrollingCoordinatorChromiumTest.wheelEventHandler - ScrollingCoordinatorChromiumTest.touchOverflowScrolling - - * WebKit.gypi: - * tests/ScrollingCoordinatorChromiumTest.cpp: Added. - (WebKit): - (MockWebViewClient): - (ScrollingCoordinatorChromiumTest): - (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest): - (WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl): - (WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad): - (WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer): - (WebKit::TEST_F): - * tests/data/fixed_position.html: Added. - * tests/data/non_fast_scrollable.html: Added. - * tests/data/touch_overflow_scrolling.html: Added. - * tests/data/wheel_event_handler.html: Added. - -2012-09-20 Peter Beverloo <peter@chromium.org> - - Leverage Chromium's code to set up FIFOs for Chromium Android layout tests - https://bugs.webkit.org/show_bug.cgi?id=97227 - - Reviewed by Tony Chang. - - Remove all fifo-related code together with the io_stream_forwarder_android - target defined in WebKitUnitTests.gyp. - - * WebKitUnitTests.gyp: - * tests/ForwardIOStreamsAndroid.cpp: Removed. - * tests/ForwardIOStreamsAndroid.h: Removed. - * tests/RunAllTests.cpp: - (main): - -2012-09-21 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-21 Keishi Hattori <keishi@webkit.org> - - Add datalist suggestions into DateTimeChooserParameters - https://bugs.webkit.org/show_bug.cgi?id=97292 - - Reviewed by Kent Tamura. - - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker. - -2012-09-20 Tony Chang <tony@chromium.org> - - [chromium] Unreviewed build fix. webkit_unit_tests have global constructors. - - * WebKitUnitTests.gyp: Remove -Wglobal-constructors. - -2012-09-20 Tony Chang <tony@chromium.org> - - [chromium] Enable more clang warnings - https://bugs.webkit.org/show_bug.cgi?id=97257 - - Reviewed by James Robinson. - - * WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations. - * WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter. - -2012-09-20 David Grogan <dgrogan@chromium.org> - - Fix IndexedDB unit tests - https://bugs.webkit.org/show_bug.cgi?id=97149 - - Reviewed by Tony Chang. - - * tests/IDBDatabaseBackendTest.cpp: - Specify a desired version of -1 so that no version change transaction - is run. - -2012-09-20 Dirk Pranke <dpranke@chromium.org> - - roll Chromium to r157829. - - Unreviewed, deps change. - - * DEPS: - -2012-09-20 Nate Chapin <japhet@chromium.org> - - Unreviewed, chromium win build fix. - Remove spurious reference to the non-existent - tests/LayerPainterChromium.h in WebKit.gypi. - - * WebKit.gypi: - -2012-09-20 James Robinson <jamesr@chromium.org> - - [chromium] Remove unused copy of chromium compositor implementation files - https://bugs.webkit.org/show_bug.cgi?id=97255 - - Reviewed by Adam Barth. - - * WebKit.gyp: - * WebKit.gypi: - * WebKitUnitTests.gyp: - * src/WebAnimationCurveCommon.cpp: Removed. - * src/WebAnimationCurveCommon.h: Removed. - * src/WebAnimationImpl.cpp: Removed. - * src/WebAnimationImpl.h: Removed. - * src/WebContentLayerImpl.cpp: Removed. - * src/WebContentLayerImpl.h: Removed. - * src/WebExternalTextureLayerImpl.cpp: Removed. - * src/WebExternalTextureLayerImpl.h: Removed. - * src/WebFloatAnimationCurveImpl.cpp: Removed. - * src/WebFloatAnimationCurveImpl.h: Removed. - * src/WebIOSurfaceLayerImpl.cpp: Removed. - * src/WebIOSurfaceLayerImpl.h: Removed. - * src/WebImageLayerImpl.cpp: Removed. - * src/WebImageLayerImpl.h: Removed. - * src/WebLayerImpl.cpp: Removed. - * src/WebLayerImpl.h: Removed. - * src/WebLayerTreeViewImpl.cpp: Removed. - * src/WebLayerTreeViewImpl.h: Removed. - * src/WebScrollbarLayerImpl.cpp: Removed. - * src/WebScrollbarLayerImpl.h: Removed. - * src/WebSolidColorLayerImpl.cpp: Removed. - * src/WebSolidColorLayerImpl.h: Removed. - * src/WebToCCInputHandlerAdapter.cpp: Removed. - * src/WebToCCInputHandlerAdapter.h: Removed. - * src/WebTransformAnimationCurveImpl.cpp: Removed. - * src/WebTransformAnimationCurveImpl.h: Removed. - * src/WebVideoLayerImpl.cpp: Removed. - * src/WebVideoLayerImpl.h: Removed. - * tests/CCActiveAnimationTest.cpp: Removed. - * tests/CCAnimationTestCommon.cpp: Removed. - * tests/CCAnimationTestCommon.h: Removed. - * tests/CCDamageTrackerTest.cpp: Removed. - * tests/CCDelayBasedTimeSourceTest.cpp: Removed. - * tests/CCDrawQuadTest.cpp: Removed. - * tests/CCFrameRateControllerTest.cpp: Removed. - * tests/CCGeometryTestUtils.cpp: Removed. - * tests/CCGeometryTestUtils.h: Removed. - * tests/CCHeadsUpDisplayTest.cpp: Removed. - * tests/CCKeyframedAnimationCurveTest.cpp: Removed. - * tests/CCLayerAnimationControllerTest.cpp: Removed. - * tests/CCLayerImplTest.cpp: Removed. - * tests/CCLayerIteratorTest.cpp: Removed. - * tests/CCLayerQuadTest.cpp: Removed. - * tests/CCLayerSorterTest.cpp: Removed. - * tests/CCLayerTestCommon.cpp: Removed. - * tests/CCLayerTestCommon.h: Removed. - * tests/CCLayerTreeHostCommonTest.cpp: Removed. - * tests/CCLayerTreeHostImplTest.cpp: Removed. - * tests/CCLayerTreeHostTest.cpp: Removed. - * tests/CCMathUtilTest.cpp: Removed. - * tests/CCOcclusionTrackerTest.cpp: Removed. - * tests/CCOcclusionTrackerTestCommon.h: Removed. - * tests/CCPrioritizedTextureTest.cpp: Removed. - * tests/CCQuadCullerTest.cpp: Removed. - * tests/CCRenderPassTest.cpp: Removed. - * tests/CCRenderSurfaceFiltersTest.cpp: Removed. - * tests/CCRenderSurfaceTest.cpp: Removed. - * tests/CCRendererGLTest.cpp: Removed. - * tests/CCResourceProviderTest.cpp: Removed. - * tests/CCSchedulerStateMachineTest.cpp: Removed. - * tests/CCSchedulerTest.cpp: Removed. - * tests/CCSchedulerTestCommon.h: Removed. - * tests/CCScopedTextureTest.cpp: Removed. - * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: Removed. - * tests/CCSolidColorLayerImplTest.cpp: Removed. - * tests/CCTestCommon.h: Removed. - * tests/CCTextureUpdateControllerTest.cpp: Removed. - * tests/CCThreadTaskTest.cpp: Removed. - * tests/CCThreadedTest.cpp: Removed. - * tests/CCThreadedTest.h: Removed. - * tests/CCTiledLayerImplTest.cpp: Removed. - * tests/CCTiledLayerTestCommon.cpp: Removed. - * tests/CCTiledLayerTestCommon.h: Removed. - * tests/CCTimerTest.cpp: Removed. - * tests/ContentLayerChromiumTest.cpp: Removed. - * tests/FakeCCLayerTreeHostClient.h: Removed. - * tests/FakeGraphicsContext3DTest.cpp: Removed. - * tests/FakeWebScrollbarThemeGeometry.h: Removed. - * tests/FloatQuadTest.cpp: Removed. - * tests/GraphicsLayerChromiumTest.cpp: - * tests/ImageLayerChromiumTest.cpp: - * tests/LayerChromiumTest.cpp: Removed. - * tests/MockCCQuadCuller.h: Removed. - * tests/ScrollbarLayerChromiumTest.cpp: Removed. - * tests/TextureCopierTest.cpp: Removed. - * tests/TextureLayerChromiumTest.cpp: Removed. - * tests/ThrottledTextureUploaderTest.cpp: Removed. - * tests/TiledLayerChromiumTest.cpp: Removed. - * tests/TreeSynchronizerTest.cpp: Removed. - * tests/WebAnimationTest.cpp: Removed. - * tests/WebFloatAnimationCurveTest.cpp: Removed. - * tests/WebLayerTest.cpp: Removed. - * tests/WebLayerTreeViewTest.cpp: Removed. - * tests/WebTransformAnimationCurveTest.cpp: Removed. - * tests/WebTransformOperationsTest.cpp: Removed. - * tests/WebTransformationMatrixTest.cpp: Removed. - -2012-09-20 Tommy Widenflycht <tommyw@google.com> - - MediaStream API: Extend UserMediaRequest with a ownerDocument method - https://bugs.webkit.org/show_bug.cgi?id=97095 - - Reviewed by Adam Barth. - - Chromium need to know exactly which frame called getUserMedia so that it can clean - away the stream when the frame goes away. - Since that information is available in webkit add an accessor method. - - Also taking the opportunity to remove an unused deprecated method, - and adding asserts in case the object is empty. - - * public/WebUserMediaRequest.h: - (WebKit): - (WebUserMediaRequest): - * src/WebUserMediaRequest.cpp: - (WebKit::WebUserMediaRequest::ownerDocument): - -2012-09-20 Mike West <mkwst@google.com> - - [chromium] Adding the 'google_apis' directory to .gitignore. - https://bugs.webkit.org/show_bug.cgi?id=97187 - - Reviewed by Jochen Eisinger. - - 'chromium/google_apis' should be ignored, as it's not in the git repo. - - * .gitignore: - -2012-09-19 Adam Barth <abarth@webkit.org> - - Remove webkitPostMessage - https://bugs.webkit.org/show_bug.cgi?id=96577 - - Reviewed by Ojan Vafai. - - Actually disable webkitPostMessage. See - http://trac.webkit.org/changeset/128658 for more information. - - * features.gypi: - -2012-09-19 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Remove "current transaction" concept from backing store - https://bugs.webkit.org/show_bug.cgi?id=96663 - - Reviewed by Tony Chang. - - Update fake class with new method signatures. - - * tests/IDBFakeBackingStore.h: - -2012-09-19 Terry Anderson <tdanderson@chromium.org> - - [chromium] Store the contents scale factor in PlatformContextSkia on initialization - https://bugs.webkit.org/show_bug.cgi?id=96137 - - Reviewed by Stephen White. - - Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used - for the skia patch here: https://codereview.appspot.com/6506099/. - Also added two new unit tests. - - * features.gypi: - * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: - (WebCore): - (WebCore::HintingScaleCallback::HintingScaleCallback): - (HintingScaleCallback): - (WebCore::HintingScaleCallback::operator()): - (WebCore::TEST_F): - * tests/PlatformContextSkiaTest.cpp: - (WebCore): - (WebCore::TEST): - -2012-09-19 David Grogan <dgrogan@chromium.org> - - Disable some failing IDB tests - https://bugs.webkit.org/show_bug.cgi?id=97135 - - Reviewed by Nate Chapin. - - They were broken in r129037. - - * tests/IDBDatabaseBackendTest.cpp: - -2012-09-19 Alpha Lam <hclam@chromium.org> - - [chromium] Unreviewed. Build fix. - - Not building WebImageTest.cpp for component build. - - * WebKit.gyp: - -2012-09-19 Alpha Lam <hclam@chromium.org> - - [chromium] WebImage should use ImageDecoder directly - https://bugs.webkit.org/show_bug.cgi?id=96135 - - Reviewed by Adam Barth. - - This patch is for preparation of deferred image decoding. - ImageSource will be used as a portal to access deferred image decoder - by BitmapImage, it should not be accessible through WebKit APIs. - - WebImage now calls ImageDecoder directly which is the actual - implementation of an image decoder. - - Tests: WebImageTest.PNGImage - WebImageTest.ICOImage - WebImageTest.BadImage - - * WebKit.gypi: - * src/WebImageSkia.cpp: - (WebKit::WebImage::fromData): - (WebKit::WebImage::framesFromData): - * tests/WebImageTest.cpp: Added. - (WebKit): - (WebKit::readFile): - (WebKit::TEST): - * tests/data/black-and-white.ico: Added. - * tests/data/white-1x1.png: Added. - -2012-09-19 Oli Lan <olilan@chromium.org> - - [chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent. - https://bugs.webkit.org/show_bug.cgi?id=96112 - - Reviewed by Adam Barth. - - Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent. - - This will be used by the Android port to implement platform-specific gesture behaviour. - - This is tested by the new test WebViewTest.ClientTapHandlers. - - * public/WebViewClient.h: - (WebViewClient): - (WebKit::WebViewClient::didHandleGestureEvent): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - * tests/WebViewTest.cpp: - -2012-09-19 Robert Flack <flackr@chromium.org> - - [chromium] Support high DPI scroll bar on top level web frame. - https://bugs.webkit.org/show_bug.cgi?id=95134 - - Reviewed by Adrienne Walker. - - Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled. - - * src/NonCompositedContentHost.cpp: - (WebKit::setScrollbarBoundsContainPageScale): - (WebKit): - (WebKit::NonCompositedContentHost::setViewport): - -2012-09-19 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move notifyJSOutOfMemory out of PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=97116 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript): - (WebKit): - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-19 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Remove unused popupsAllowed function from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=96521 - - Reviewed by Eric Seidel. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-19 Kent Tamura <tkent@chromium.org> - - [Chromium] Fix crash in WebFrameImpl::loadHistoryItem - https://bugs.webkit.org/show_bug.cgi?id=96352 - - Reviewed by Adam Barth. - - We have some crash reports with the following stack: - - HistoryItem::shouldDoSameDocumentNavigationTo. - - WebFrameImpl::loadHistoryItem - ... - - We don't have reproducible steps, and not sure what's the root - cause. Anyway we should check nullness of currentItem because - HistoryController::m_currentItem can be 0. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::loadHistoryItem): - Check nullness of currentItem. - -2012-09-18 Sailesh Agrawal <sail@chromium.org> - - Chromium: Scrollbar with tickmarks doesn't respond to clicks - https://bugs.webkit.org/show_bug.cgi?id=96049 - - Reviewed by Beth Dakin. - - Pipe isAlphaLocked and setIsAlphaLocked. - - * src/WebPluginScrollbarImpl.cpp: - (WebKit::WebPluginScrollbarImpl::isAlphaLocked): - (WebKit): - (WebKit::WebPluginScrollbarImpl::setIsAlphaLocked): - * src/WebPluginScrollbarImpl.h: - (WebPluginScrollbarImpl): - * src/WebScrollbarThemeClientImpl.cpp: - (WebKit::WebScrollbarThemeClientImpl::isAlphaLocked): - (WebKit): - (WebKit::WebScrollbarThemeClientImpl::setIsAlphaLocked): - * src/WebScrollbarThemeClientImpl.h: - (WebScrollbarThemeClientImpl): - * tests/ScrollbarLayerChromiumTest.cpp: - -2012-09-18 Alpha Lam <hclam@chromium.org> - - Unreviewed, rolling out r128939. - http://trac.webkit.org/changeset/128939 - https://bugs.webkit.org/show_bug.cgi?id=96135 - - Failing test_shell_tests. - - * WebKit.gypi: - * src/WebImageSkia.cpp: - (WebKit::WebImage::fromData): - (WebKit::WebImage::framesFromData): - * tests/WebImageTest.cpp: Removed. - * tests/data/black-and-white.ico: Removed. - * tests/data/white-1x1.png: Removed. - -2012-09-18 Alpha Lam <hclam@chromium.org> - - [chromium] WebImage should use ImageDecoder directly - https://bugs.webkit.org/show_bug.cgi?id=96135 - - Reviewed by Adam Barth. - - This patch is for preparation of deferred image decoding. - ImageSource will be used as a portal to access deferred image decoder - by BitmapImage, it should not be accessible through WebKit APIs. - - WebImage now calls ImageDecoder directly which is the actual - implementation of an image decoder. - - Tests: WebImageTest.PNGImage - WebImageTest.ICOImage - - * WebKit.gypi: - * src/WebImageSkia.cpp: - (WebKit::WebImage::fromData): - (WebKit::WebImage::framesFromData): - * tests/WebImageTest.cpp: Added. - (WebKit): - (WebKit::readFile): - (WebKit::TEST): - * tests/data/black-and-white.ico: Added. - * tests/data/white-1x1.png: Added. - -2012-09-18 Tommy Widenflycht <tommyw@google.com> - - MediaStream API: Create a flag to enable PeerConnection00 - https://bugs.webkit.org/show_bug.cgi?id=96989 - - Reviewed by Adam Barth. - - Adding the functionality to separately enable/disable PeerConnection00. - For now it is enabled by default. - - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enableDeprecatedPeerConnection): - (WebKit): - (WebKit::WebRuntimeFeatures::isDeprecatedPeerConnectionEnabled): - -2012-09-18 Iain Merrick <husky@google.com> - - [Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange - https://bugs.webkit.org/show_bug.cgi?id=96508 - - Reviewed by Ryosuke Niwa. - - These methods had "start" and "end" parameters, but this is incorrect. - selectRange() actually takes base and extent (where the user actually - touched), and selectionBounds() returns anchor and focus (base and extent - expanded to account for the selection granularity). - - This patch fixes the parameter names, and updates selectRange, its test - and its documentation to reflect the correct usage. It also removes - moveSelectionStart/moveSelectionEnd/moveCaret (which aren't being used - yet), and updates WebFrameTest to show how these can be implemented via - selectRange. - - * public/WebFrame.h: - (WebFrame): - * public/WebWidget.h: - (WebWidget): - (WebKit::WebWidget::selectionBounds): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::selectRange): - * src/WebFrameImpl.h: - (WebFrameImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::selectionBounds): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/WebFrameTest.cpp: - -2012-09-18 Terry Anderson <tdanderson@chromium.org> - - Roll chromium DEPS to r157342 - https://bugs.webkit.org/show_bug.cgi?id=96963 - - Reviewed by Stephen White. - - Roll chromium DEPS to r157342. Also include the top-level directory - google_apis as a dependency, which was required for r157130. - - * DEPS: - -2012-09-17 Brian Anderson <brianderson@chromium.org> - - [chromium] Add rendering commit statistics - https://bugs.webkit.org/show_bug.cgi?id=96938 - - Reviewed by James Robinson. - - Adds total commit time and total commit count to WebRenderingStats. - Allows us to caculate average commit time in performance tests. - - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::renderingStats): - -2012-09-17 James Robinson <jamesr@chromium.org> - - [chromium] Move a FilterOperationsTest and WebInputEventConversionTest back to webkit_unittest_files variable - https://bugs.webkit.org/show_bug.cgi?id=96964 - - Reviewed by Adrienne Walker. - - These targets are really webkit unit tests and shouldn't be guarded by use_libcc_for_compositor. - - * WebKit.gypi: - -2012-09-17 Rick Byers <rbyers@chromium.org> - - Send GestureTapDownCancel to WebCore - https://bugs.webkit.org/show_bug.cgi?id=96060 - - Reviewed by Antonio Gomes. - - Plumb WebInputEvent::GetsureTapCancel to - PlatformInputEvent::GestureTapDownCancel. After all the chromium code - was landed, it was suggested that 'TapDownCancel' was a better name - than 'TapCancel' since you can't cancel a Tap. I'm not changing the - WebInputEvent definition here because that would be a breaking change - to chromium, but I can do that as a series of follow-up CLs. - * src/WebInputEventConversion.cpp: - (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::handleInputEvent): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - -2012-09-17 Alec Flett <alecflett@chromium.org> - - IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor - https://bugs.webkit.org/show_bug.cgi?id=95409 - - Reviewed by Kentaro Hara. - - This removes a bunch of tests that have been migrated to - LayoutTests, in https://bugs.webkit.org/show_bug.cgi?id=96818. - - * tests/IDBBindingUtilitiesTest.cpp: - (WebCore::checkKeyFromValueAndKeyPathInternal): - (WebCore::checkKeyPathNullValue): - (WebCore::injectKey): - (WebCore::checkInjection): - (WebCore::checkInjectionFails): - (WebCore::checkKeyPathStringValue): - (WebCore::checkKeyPathNumberValue): - (WebCore::TEST): - * tests/IDBKeyPathTest.cpp: - -2012-09-17 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Fix cases where find-in-page doesn't send a final update - https://bugs.webkit.org/show_bug.cgi?id=96402 - - Fix some issues in the WebKit implementation that prevented to send a final - reportFindInPageMatchCount message. - - Reviewed by Adam Barth. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::scopeStringMatches): - (WebKit): - (WebKit::WebFrameImpl::finishCurrentScopingEffort): - (WebKit::WebFrameImpl::cancelPendingScopingEffort): - (WebKit::WebFrameImpl::WebFrameImpl): - (WebKit::WebFrameImpl::shouldScopeMatches): - * src/WebFrameImpl.h: - -2012-09-17 Joshua Bell <jsbell@chromium.org> - - [Chromium] IndexedDB: Remove legacy two-phase open() API members - https://bugs.webkit.org/show_bug.cgi?id=96802 - - Reviewed by Tony Chang. - - Following http://webkit.org/b/90411 and subsequent cleanup on the Chromium side, - these entry points are no longer needed. - - * public/WebIDBDatabase.h: Delete old second-phase open(db-callbacks) - * public/WebIDBFactory.h: Delete old first-phase open() w/o db-callbacks - * src/WebIDBDatabaseImpl.cpp: No longer need to account for a close between phases. - (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): - (WebKit::WebIDBDatabaseImpl::close): - (WebKit::WebIDBDatabaseImpl::forceClose): - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - -2012-09-17 Ilya Tikhonovsky <loislo@chromium.org> - - Unreviewed. Temporary disable visited set counter check. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - -2012-09-17 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: now when we can detect instrumented classes we can - remove addInstrumentedMember and use addMember for everything. - https://bugs.webkit.org/show_bug.cgi?id=96913 - - Reviewed by Yury Semikhatsky. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::InstrumentedDOM::reportMemoryUsage): - (WebCore::NonVirtualInstrumented::reportMemoryUsage): - (WebCore::InstrumentedOwner::reportMemoryUsage): - -2012-09-17 Ilya Tikhonovsky <loislo@chromium.org> - - Unreviewed single line fix for mac chromium canary bot. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - -2012-09-15 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: automatically detect if class has reportMemoryUsage method - https://bugs.webkit.org/show_bug.cgi?id=96756 - - Reviewed by Alexander Pavlov. - - Test that reportMemoryUsage method will be called on the instrumented object - even if it is a template. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore): - (InstrumentedTemplate): - (WebCore::InstrumentedTemplate::InstrumentedTemplate): - (WebCore::InstrumentedTemplate::reportMemoryUsage): - (WebCore::TEST): - -2012-09-14 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by the memory instrumentation - https://bugs.webkit.org/show_bug.cgi?id=96791 - - Reviewed by Alexander Pavlov. - - Test that pointers to RefPtr and OwnPtr won't be double counted by - the memory instrumentation. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore): - (TwoPointersToRefPtr): - (WebCore::TwoPointersToRefPtr::TwoPointersToRefPtr): - (WebCore::TwoPointersToRefPtr::reportMemoryUsage): - (WebCore::TEST): - (TwoPointersToOwnPtr): - (WebCore::TwoPointersToOwnPtr::TwoPointersToOwnPtr): - (WebCore::TwoPointersToOwnPtr::reportMemoryUsage): - -2012-09-16 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-14 Julien Chaffraix <jchaffraix@webkit.org> - - Revert r127457 and following fixes due to several hit-testing regressions - https://bugs.webkit.org/show_bug.cgi?id=96830 - - Reviewed by Antonio Gomes. - - This change reverts r127457, r127863 and r128505. - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): - -2012-09-14 Ojan Vafai <ojan@chromium.org> - - Provide a runtime setting to disable position:sticky - https://bugs.webkit.org/show_bug.cgi?id=96827 - - Reviewed by James Robinson. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setCSSStickyPositionEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-09-14 Adam Barth <abarth@webkit.org> - - Remove webkitPostMessage - https://bugs.webkit.org/show_bug.cgi?id=96577 - - Reviewed by Ojan Vafai. - - Add ENABLE_LEGACY_VENDOR_PREFIXES flag. - - * features.gypi: - -2012-09-14 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-14 Rick Byers <rbyers@chromium.org> - - [chromium] add touch area to gestureTapDown data - https://bugs.webkit.org/show_bug.cgi?id=96806 - - Reviewed by Adam Barth. - - Add width/height for GestureTapDown as for GestureTap/LongPress so that - we can eventually do fuzzing on it. - * public/WebInputEvent.h: - * src/WebInputEventConversion.cpp: - (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): - -2012-09-14 Peter Beverloo <peter@chromium.org> - - [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=96687 - - Reviewed by Tony Chang. - - Android's DumpRenderTree currently supports these arguments, implemented - as part of TestShellAndroid: - http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496 - - They're used by the layout test runner to get the STDOUT and STDERR while - a layout test run is in process, which is a safer alternative to parsing - all the logcat output manually. The implementation can be seen here: - http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590 - - This patch generalizes parsing of and applying the effects of these arguments - so that they can be used for TestWebKitAPI and webkit_unit_tests as well. - After this patch, this will make it possible to pull out the output-reading - code from Android's layout test port and generalize it so it can be re-used - in the new test-runner for the other two test suites. - - This has no effect when compiling and running these tests as part of Chromium - code, which has a much more advanced test-runner that does parse complete log - output, but also directly depends on code licensed under Apache 2. - - * WebKit.gypi: - * tests/ForwardIOStreamsAndroid.cpp: Added. - (WebKit): - (WebKit::maybeInitIOStreamForwardingForAndroid): - * tests/ForwardIOStreamsAndroid.h: Added. - (WebKit): - * tests/RunAllTests.cpp: - (main): - -2012-09-14 Keishi Hattori <keishi@webkit.org> - - Make time input lang attribute aware for testing - https://bugs.webkit.org/show_bug.cgi?id=96728 - - Reviewed by Kent Tamura. - - * tests/LocalizedDateICUTest.cpp: - (LocalizedDateICUTest::localizedDateFormatText): - (LocalizedDateICUTest::localizedShortDateFormatText): - -2012-09-14 Keishi Hattori <keishi@webkit.org> - - Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods - https://bugs.webkit.org/show_bug.cgi?id=96726 - - Reviewed by Kent Tamura. - - * tests/LocaleMacTest.cpp: - (LocaleMacTest::timeFormat): - (LocaleMacTest::shortTimeFormat): - (TEST_F): - * tests/LocaleWinTest.cpp: - (LocaleWinTest::timeFormat): - (LocaleWinTest::shortTimeFormat): - (TEST_F): - * tests/LocalizedDateICUTest.cpp: - (LocalizedDateICUTest::localizedDateFormatText): - (LocalizedDateICUTest::localizedShortDateFormatText): - -2012-09-14 Keishi Hattori <keishi@webkit.org> - - LocaleMac should fallback to defaultLanguage for an invalid locale - https://bugs.webkit.org/show_bug.cgi?id=96744 - - Reviewed by Kent Tamura. - - * tests/LocaleMacTest.cpp: - (TEST_F): - -2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r128543. - http://trac.webkit.org/changeset/128543 - https://bugs.webkit.org/show_bug.cgi?id=96722 - - Caused LocaleWinTest.localizedNumberRoundTrip to fail - (Requested by keishi on #webkit). - - * tests/LocaleWinTest.cpp: - (testNumberIsReversible): - (testNumbers): - (TEST_F): - -2012-09-13 Keishi Hattori <keishi@webkit.org> - - Create Localizer factory method for LocaleWin - https://bugs.webkit.org/show_bug.cgi?id=96667 - - Reviewed by Kent Tamura. - - * tests/LocaleWinTest.cpp: - (testNumberIsReversible): - (testNumbers): - -2012-09-13 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Consolidate two-phase connection to avoid race conditions - https://bugs.webkit.org/show_bug.cgi?id=90411 - - Reviewed by Tony Chang. - - API plumbing for simplified single-phase connection opening, and tests updated - to exercise the new APIs. - - * public/WebIDBDatabase.h: - (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API. - * public/WebIDBFactory.h: - (WebKit): - (WebIDBFactory): - (WebKit::WebIDBFactory::open): New overload that takes db-callbacks. - * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier. - (WebKit::IDBCallbacksProxy::onSuccess): - (WebKit::IDBCallbacksProxy::onUpgradeNeeded): - (WebKit): - (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to - the db-callbacks and hook it up when the onSuccess callback comes through. - * src/IDBCallbacksProxy.h: - (WebKit): - (IDBCallbacksProxy): - * src/IDBDatabaseBackendProxy.cpp: - * src/IDBDatabaseBackendProxy.h: - (IDBDatabaseBackendProxy): - * src/IDBFactoryBackendProxy.cpp: - (WebKit::IDBFactoryBackendProxy::open): - * src/IDBFactoryBackendProxy.h: - (IDBFactoryBackendProxy): - * src/WebIDBDatabaseImpl.cpp: - (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): - (WebKit::WebIDBDatabaseImpl::close): - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - * src/WebIDBFactoryImpl.cpp: - (WebKit::WebIDBFactoryImpl::open): - * src/WebIDBFactoryImpl.h: - (WebIDBFactoryImpl): - * tests/IDBAbortOnCorruptTest.cpp: - (FakeIDBDatabaseCallbacks): - (WebCore::FakeIDBDatabaseCallbacks::create): - (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks): - (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks): - (WebCore): - (WebCore::TEST): Updated connection sequence. - * tests/IDBDatabaseBackendTest.cpp: Ditto. - -2012-09-13 James Robinson <jamesr@chromium.org> - - PlatformGestureCurveTest compile fix pt 2 - - * tests/PlatformGestureCurveTest.cpp: - -2012-09-13 James Robinson <jamesr@chromium.org> - - Fix compile warning/error on windows - literal that isn't exactly representable as a float needs "f" suffix. - - * tests/PlatformGestureCurveTest.cpp: - -2012-09-13 Julien Chaffraix <jchaffraix@webkit.org> - - [Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place - https://bugs.webkit.org/show_bug.cgi?id=96593 - - Reviewed by Adam Barth. - - After r127457, the HitTestResult stored in ContextMenuController is in window coordinates. - Trying to convert it again to window coordinates will result in adding the containing frame's - position twice, thus the wrong placing. - - Chromium Mac wasn't impacted by the regression and I manually checked that the fix doesn't impact Mac. - - Unfortunately, no test as I don't think we have a way of testing context menu position. - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): - -2012-09-13 Robert Kroeger <rjkroege@chromium.org> - - [chromium] alter fling animation parameters. - https://bugs.webkit.org/show_bug.cgi?id=96666 - - Reviewed by Adrienne Walker. - - Corrected the test to be non-fragile in the presence of altered fling - curve parameters. - - * tests/PlatformGestureCurveTest.cpp: - -2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r128489. - http://trac.webkit.org/changeset/128489 - https://bugs.webkit.org/show_bug.cgi?id=96686 - - Does not compile on windows (Requested by jamesr on #webkit). - - * public/WebIDBDatabase.h: - * public/WebIDBFactory.h: - (WebIDBFactory): - * src/IDBCallbacksProxy.cpp: - (WebKit::IDBCallbacksProxy::onSuccess): - (WebKit::IDBCallbacksProxy::onUpgradeNeeded): - * src/IDBCallbacksProxy.h: - (WebKit): - (IDBCallbacksProxy): - * src/IDBDatabaseBackendProxy.cpp: - (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks): - (WebKit): - * src/IDBDatabaseBackendProxy.h: - (IDBDatabaseBackendProxy): - * src/IDBFactoryBackendProxy.cpp: - (WebKit::IDBFactoryBackendProxy::open): - * src/IDBFactoryBackendProxy.h: - (IDBFactoryBackendProxy): - * src/WebIDBDatabaseImpl.cpp: - (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): - (WebKit::WebIDBDatabaseImpl::close): - (WebKit::WebIDBDatabaseImpl::open): - (WebKit): - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - * src/WebIDBFactoryImpl.cpp: - (WebKit::WebIDBFactoryImpl::open): - * src/WebIDBFactoryImpl.h: - (WebIDBFactoryImpl): - * tests/IDBAbortOnCorruptTest.cpp: - (WebCore::TEST): - * tests/IDBDatabaseBackendTest.cpp: - -2012-09-13 Glenn Hartmann <hartmanng@chromium.org> - - Add new accelerated compositing for overflow scroll setting. - https://bugs.webkit.org/show_bug.cgi?id=95885 - - Reviewed by James Robinson. - - wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which - currently returns true if we're overflow scrolling and the element has - been styled with '-webkit-overflow-scrolling: touch'. If this is true, - we get promoted to a composited layer, the associated RenderLayerBacking - gets special scrolling layers and in response to RenderLayer::scrollTo() - we no longer have to invalidate everything to get the scrolled content - in the right spot, thereby avoiding very expensive repaints. It's - unfortunate that we require -webkit-overflow-scrolling: touch, though. - It would be nice if RenderLayer::usesCompositedScrolling() returned true - if the page would continue to behave correctly. This is what - wkb.ug/94743 is intended to do. Unfortunately, when we become a - composited layer, we switch from subpixel to grayscale anti-aliasing. We - only want to auto-opt into composited scrolling if we don't mind the - change in anti-aliasing, so we need a flag to enable/disable this - feature. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-09-13 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Consolidate two-phase connection to avoid race conditions - https://bugs.webkit.org/show_bug.cgi?id=90411 - - Reviewed by Tony Chang. - - API plumbing for simplified single-phase connection opening, and tests updated - to exercise the new APIs. - - * public/WebIDBDatabase.h: - (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API. - * public/WebIDBFactory.h: - (WebKit): - (WebIDBFactory): - (WebKit::WebIDBFactory::open): New overload that takes db-callbacks. - * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier. - (WebKit::IDBCallbacksProxy::onSuccess): - (WebKit::IDBCallbacksProxy::onUpgradeNeeded): - (WebKit): - (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to - the db-callbacks and hook it up when the onSuccess callback comes through. - * src/IDBCallbacksProxy.h: - (WebKit): - (IDBCallbacksProxy): - * src/IDBDatabaseBackendProxy.cpp: - * src/IDBDatabaseBackendProxy.h: - (IDBDatabaseBackendProxy): - * src/IDBFactoryBackendProxy.cpp: - (WebKit::IDBFactoryBackendProxy::open): - * src/IDBFactoryBackendProxy.h: - (IDBFactoryBackendProxy): - * src/WebIDBDatabaseImpl.cpp: - (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): - (WebKit::WebIDBDatabaseImpl::close): - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - * src/WebIDBFactoryImpl.cpp: - (WebKit::WebIDBFactoryImpl::open): - * src/WebIDBFactoryImpl.h: - (WebIDBFactoryImpl): - * tests/IDBAbortOnCorruptTest.cpp: - (FakeIDBDatabaseCallbacks): - (WebCore::FakeIDBDatabaseCallbacks::create): - (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks): - (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks): - (WebCore): - (WebCore::TEST): Updated connection sequence. - * tests/IDBDatabaseBackendTest.cpp: Ditto. - -2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-13 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: instrument KURL directly. - https://bugs.webkit.org/show_bug.cgi?id=96624 - - Reviewed by Yury Semikhatsky. - - I replaced traits based instrumentation of KURL with reportMemoryUsage functions. - CString* were also instrumented. - - Drive by fix: Instrumentation code in QualifiedName was moved to cpp. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore): - (InstrumentedOwner): - (WebCore::InstrumentedOwner::InstrumentedOwner): - (WebCore::InstrumentedOwner::reportMemoryUsage): - (WebCore::TEST): - -2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r128409. - http://trac.webkit.org/changeset/128409 - https://bugs.webkit.org/show_bug.cgi?id=96622 - - It broke Chromium browser_tests (Requested by tkent on - #webkit). - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::scopeStringMatches): - (WebKit::WebFrameImpl::shouldScopeMatches): - -2012-09-13 Taiju Tsuiki <tzik@chromium.org> - - Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call. - https://bugs.webkit.org/show_bug.cgi?id=96601 - - Reviewed by Kent Tamura. - - m_webFrame might be already deleted after terminateWorkerContext call. - This patch ensure it be NULL and change to avoid using it. - - Test: fast/filesystem/workers/detached-frame-crash.html - - * src/WebWorkerClientImpl.cpp: - (WebKit::WebWorkerClientImpl::terminateWorkerContext): - (WebKit::WebWorkerClientImpl::openFileSystem): - -2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Fix cases where find-in-page doesn't send a final update - https://bugs.webkit.org/show_bug.cgi?id=96402 - - Fix some issues in the WebKit implementation that prevented to send a final - reportFindInPageMatchCount message. - - Reviewed by Adam Barth. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::scopeStringMatches): - (WebKit::WebFrameImpl::shouldScopeMatches): - -2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r127876. - http://trac.webkit.org/changeset/127876 - https://bugs.webkit.org/show_bug.cgi?id=96600 - - mouse click doesn't work for spin button if spin button in - iframe (Requested by yosin on #webkit). - - * src/ContextMenuClientImpl.cpp: - (WebKit::selectMisspelledWord): - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::characterIndexForPoint): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::isRectTopmost): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleMouseUp): - (WebKit::WebViewImpl::computeBlockBounds): - -2012-09-12 Rick Byers <rbyers@chromium.org> - - [chromium] Remove unused WebGestureEvent fields - https://bugs.webkit.org/show_bug.cgi?id=95496 - - Reviewed by Adam Barth. - - Remove the no-longer used fields from WebGestureEvent, now that - chromium has been updated to use the per-event-type fields instead. - This depends on crrev.com/156346 in chromium. - - * public/WebInputEvent.h: - (WebKit::WebGestureEvent::WebGestureEvent): - * public/android/WebInputEventFactory.h: - * src/WebInputEvent.cpp: - (SameSizeAsWebGestureEvent): - * src/android/WebInputEventFactory.cpp: - (WebKit): - (WebKit::WebInputEventFactory::gestureEvent): - -2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r128351. - http://trac.webkit.org/changeset/128351 - https://bugs.webkit.org/show_bug.cgi?id=96573 - - Broke FindInPage browser_tests (Requested by jamesr_ on - #webkit). - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::scopeStringMatches): - (WebKit::WebFrameImpl::cancelPendingScopingEffort): - (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): - (WebKit::WebFrameImpl::shouldScopeMatches): - -2012-09-12 Adrienne Walker <enne@google.com> - - [chromium] Fix search tickmarks not disappearing when compositing is enabled - https://bugs.webkit.org/show_bug.cgi?id=96536 - - Reviewed by James Robinson. - - view->invalidateRect() on the root frame just invalidates the - contents, since WebViewImpl doesn't know anything about scrollbar - layers. This causes an "InvalidateAll" to not actually invalidate the - scrollbars. - - To fix this, make WebFrameImpl explicitly invalidate the - scrollbars when required. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::invalidateArea): - -2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Fix cases where find-in-page doesn't send a final update - https://bugs.webkit.org/show_bug.cgi?id=96402 - - Fix some issues in the WebKit implementation that prevented to send a final - reportFindInPageMatchCount message. Also, fix a buggy reset of the active match - when calling the stopFinding method. - - Reviewed by Adam Barth. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::scopeStringMatches): - (WebKit::WebFrameImpl::cancelPendingScopingEffort): - (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): - (WebKit::WebFrameImpl::shouldScopeMatches): - -2012-09-12 Sami Kyostila <skyostil@google.com> - - Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING - https://bugs.webkit.org/show_bug.cgi?id=96251 - - Reviewed by Simon Fraser. - - Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe - the feature it controls. - - * features.gypi: - -2012-09-12 Christopher Cameron <ccameron@chromium.org> - - [chromium] Evict textures through the texture manager instead of the resource provider - https://bugs.webkit.org/show_bug.cgi?id=96463 - - Reviewed by James Robinson. - - Update layer tree host impl test to include the extra interface functions - added to CCLayerTreeHostImplClient. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-09-12 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI move String* instrumentation to wtf. - https://bugs.webkit.org/show_bug.cgi?id=96405 - - Reviewed by Yury Semikhatsky. - - This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream. - - Tested by webkit_unit_tests. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - -2012-09-12 Philippe Liard <pliard@google.com> - - Depend on {base,net} GYP targets rather than {base,net}_java. - https://bugs.webkit.org/show_bug.cgi?id=95690 - - Reviewed by Adam Barth. - - {base,net}_java became 'private' targets on the Chromium side that - clients should not depend on (see - https://chromiumcodereview.appspot.com/10913083/). - This also adds the missing 'chromium_net.jar' to |input_jars_paths| - that was magically included in Chrome for Android downstream but not - upstream. It's needed to register JNI for 'net' in webkit_unit_tests. - - - * WebKitUnitTests.gyp: - -2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r128279. - http://trac.webkit.org/changeset/128279 - https://bugs.webkit.org/show_bug.cgi?id=96487 - - "Snow Leopard compilation broken" (Requested by yurys on - #webkit). - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::InstrumentedUndefined::reportMemoryUsage): - (WebCore::TEST): - -2012-09-12 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI move String* instrumentation to wtf. - https://bugs.webkit.org/show_bug.cgi?id=96405 - - Reviewed by Yury Semikhatsky. - - This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream. - - Tested by webkit_unit_tests. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::InstrumentedUndefined::reportMemoryUsage): - (WebCore::TEST): - -2012-09-12 Jochen Eisinger <jochen@chromium.org> - - [chromium] consumable user gesture count off for input events - https://bugs.webkit.org/show_bug.cgi?id=96373 - - Reviewed by Adam Barth. - - Don't create a UserGestureIndicator in the chromium layer, as it will - already be created by webcore's event handler. Creating multiple - UserGestureIndicator objects for the same object would allow to execute - multiple user-gesture-gated actions per user gesture such as opening a - new window. - - * public/WebInputEvent.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleInputEvent): - -2012-09-12 Alexandre Elias <aelias@chromium.org> - - [chromium] Flip Y and swizzle inside compositeAndReadback implementation - https://bugs.webkit.org/show_bug.cgi?id=96458 - - Reviewed by James Robinson. - - Currently, compositeAndReadback API assumes a GL-style texture - and is converted to the normal software format in WebViewImpl. - For the software implementation, this API would result in two - redundant conversions. This patch makes the conversion inside - CCRendererGL instead. I rolled my own for loop as I didn't find the - appropriate function within raw Skia. - - No new tests (covered by existing layout tests). - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::doPixelReadbackToCanvas): - -2012-09-11 Taiju Tsuiki <tzik@chromium.org> - - WebFrameImpl::client() needs NULL check in WebWorkerClientImpl::openFileSystem - https://bugs.webkit.org/show_bug.cgi?id=96354 - - Reviewed by Kent Tamura. - - Ensure non-NULL before using WebFrameImpl::client(). - - Test: fast/filesystem/workers/detached-frame-crash.html - - * src/WebWorkerClientImpl.cpp: - (WebKit::WebWorkerClientImpl::openFileSystem): - -2012-09-11 Keishi Hattori <keishi@webkit.org> - - Create Localizer factory method for LocaleICU - https://bugs.webkit.org/show_bug.cgi?id=96363 - - Reviewed by Kent Tamura. - - * tests/LocalizedNumberICUTest.cpp: - (testNumberIsReversible): - (testDecimalSeparator): - -2012-09-11 Christopher Cameron <ccameron@chromium.org> - - [chromium] Make prioritized texture manager not touch backings array on the main thread - https://bugs.webkit.org/show_bug.cgi?id=96114 - - Reviewed by James Robinson. - - Take a snapshot of the textures' priorities from the main thread, - and save it in their backings for access by the impl thread. - Update functions that access the sorted backings array to use the - snapshotted values instead of the values that the main thread may - have computed for the next frame. - - Make the main thread not touch the m_backings array. Split - prioritizeTextures into a updateBackingsPriorities function. - In places where the main thread would have touched m_backings, - set a flag specifying that m_backings needs to be re-sorted - before any function that requires it be sorted by priority be - executed. - - Update the two functions that require sorted order (acquireBacking - and reduceMemory) to sort the backings array (if needed) before - traversing it. - - Updated tests to set correct thread during asserts. Add a test to - verify that requestLate is correctly incorporated into the backing - sorting. - - * tests/CCPrioritizedTextureTest.cpp: - (WTF::CCPrioritizedTextureTest::validateTexture): - -2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-11 Iain Merrick <husky@chromium.org> - - [chromium] Fix double call to scrollBegin() when handling scroll gesture - https://bugs.webkit.org/show_bug.cgi?id=95322 - - Reviewed by James Robinson. - - WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its - client, then if the result is ScrollStarted, it creates a PlatformGestureCurve - object to handle the fling animation. This patch adds a matching scrollEnd() - before the animation starts. - - Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all - unexpected calls into test failures. This ensures that scrollBegin / scrollEnd - happen exactly when we want and at no other times. - - * src/WebCompositorInputHandlerImpl.cpp: - (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): - * tests/WebCompositorInputHandlerImplTest.cpp: - (WebCompositorInputHandlerImplTest): - (WebKit::TEST_F): - -2012-09-11 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-11 Keishi Hattori <keishi@webkit.org> - - Create Localizer factory method for LocaleMac - https://bugs.webkit.org/show_bug.cgi?id=96355 - - Reviewed by Kent Tamura. - - * tests/LocaleMacTest.cpp: - (testNumberIsReversible): Use Localizer::create. - (testNumbers): - -2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r128150. - http://trac.webkit.org/changeset/128150 - https://bugs.webkit.org/show_bug.cgi?id=96357 - - it broke chromium compilation (Requested by loislo on - #webkit). - - * DEPS: - -2012-09-10 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-10 Joanmarie Diggs <jdiggs@igalia.com> - - Properly expose <legend> elements to ATs - https://bugs.webkit.org/show_bug.cgi?id=84137 - - Reviewed by Chris Fleizach. - - Created a new WebCore Accessibility Role, LegendRole. Used it to map to - the expected platform role, ATK_ROLE_LABEL. Also established the needed - AtkRelation pair, label-for/labelled-by between the legend and fieldset. - - * public/WebAccessibilityRole.h: added WebAccessibilityRoleLegend - * src/AssertMatchingEnums.cpp: added the assert matching rule for - WebAccessibilityRoleLegend and LegendRole - -2012-09-10 Beth Dakin <bdakin@apple.com> - - https://bugs.webkit.org/show_bug.cgi?id=96158 - Need API to suppress scrollbar animations - -and corresponding- - <rdar://problem/12210972> - - Reviewed by Sam Weinig. - - ScrollableArea::isOnActivePage() has been re-named to - ScrollableArea:: scrollbarsCanBeActive(). - * src/ScrollbarGroup.cpp: - (WebKit::ScrollbarGroup::scrollbarsCanBeActive): - * src/ScrollbarGroup.h: - * tests/GraphicsLayerChromiumTest.cpp: - * tests/ScrollAnimatorNoneTest.cpp: - (MockScrollableArea): - -2012-09-10 Dan Alcantara <dfalcantara@chromium.org> - - [chromium, android] Reloading a page with a different user agent can cause the page to be zoomed in - https://bugs.webkit.org/show_bug.cgi?id=90222 - - Reviewed by Adam Barth. - - When reloading a page with an overridden URL, the page's scroll and zoom - state will be restored once the reload is complete. This is problematic - in situations when switching between mobile and desktop versions of the - same site because it will zoom back in on a random part of alternate page. - This CL just avoids that situation by resetting the zoom and scale whenever - this type of reload occurs. - - Chromium half: https://chromiumcodereview.appspot.com/10889019 - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::resetScrollAndScaleState): - (WebKit): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-09-10 Adam Barth <abarth@chromium.org> - - [V8] V8AuxiliaryContext used by IDB leaks memory - https://bugs.webkit.org/show_bug.cgi?id=96317 - - Reviewed by Tony Chang. - - Call the V8 APIs directly instead of using a helper class. - - * tests/IDBBindingUtilitiesTest.cpp: - (WebCore::TEST): - -2012-09-10 Adam Barth <abarth@chromium.org> - - [V8] Inline firstFrame and currentFrame into their unique callers - https://bugs.webkit.org/show_bug.cgi?id=96309 - - Reviewed by Eric Seidel. - - This patch just lines these WebCore functions because we only call them - from here. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrame::frameForEnteredContext): - (WebKit::WebFrame::frameForCurrentContext): - -2012-09-10 Rick Byers <rbyers@chromium.org> - - [chromium] Add unused GestureTapCancel - https://bugs.webkit.org/show_bug.cgi?id=96183 - - Reviewed by Adam Barth. - - This adds a new 'tap cancel' gesture type. This is temporarily unused, - so that we can change chromium to start sending the gesture type - without breaking anything. - - * public/WebInputEvent.h: - * src/PageWidgetDelegate.cpp: - (WebKit::PageWidgetDelegate::handleInputEvent): - * src/WebInputEventConversion.cpp: - (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::handleInputEvent): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - -2012-09-10 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository() - https://bugs.webkit.org/show_bug.cgi?id=95861 - - Reviewed by Adam Barth. - - Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport. - - * public/WebSharedWorkerRepository.h: - (WebKit): - * src/SharedWorkerRepository.cpp: - (WebKit): - (WebKit::setSharedWorkerRepository): - (WebKit::sharedWorkerRepository): - (WebCore::SharedWorkerRepository::isAvailable): - (WebCore::SharedWorkerRepository::connect): - (WebCore::SharedWorkerRepository::documentDetached): - (WebCore::SharedWorkerRepository::hasSharedWorkers): - -2012-09-10 Catalin Badea <badea@adobe.com> - - webkit build for 64-bit Mac chromium - https://bugs.webkit.org/show_bug.cgi?id=95977 - - Reviewed by Eric Seidel. - - Ensure header completeness and use the correct include order. This fixes a compilation issues noticeable when building chromium for 64-bit Mac. - - * public/mac/WebSubstringUtil.h: - * src/mac/WebSubstringUtil.mm: - -2012-09-10 Adrienne Walker <enne@google.com> - - [chromium] Fix deadlock between WebMediaPlayerClientImpl dtor and PutCurrentFrame - https://bugs.webkit.org/show_bug.cgi?id=96010 - - Reviewed by James Robinson. - - The key fix here is that the destructor no longer has a mutex. - The m_compositingMutex was supposedly protecting races between - ~WebMediaPlayerClientImpl and setVideoFrameProviderClient. The - former is only called from the main thread and the latter is called - from the compositor thread only when the main thread is blocked (and - it already asserts that this is the case). - - In addition, the m_providerMutex in CCVideoLayerImpl prevents the - destruction of WebMediaPlayerClientImpl, thus keeping the frame - acquired via getCurrentFrame alive until putCurrentFrame is called. - These functions are only called by the client, and comments are added - to the interface to better document this. - - To prevent a race between load() and getCurrentFrame/putCurrentFrame - (which are called from different threads) a new m_webMediaPlayerMutex - to replace part of what the old m_compositingMutex was doing. - - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): - (WebKit::WebMediaPlayerClientImpl::load): - (WebKit::WebMediaPlayerClientImpl::loadInternal): - (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient): - (WebKit::WebMediaPlayerClientImpl::getCurrentFrame): - (WebKit::WebMediaPlayerClientImpl::putCurrentFrame): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-09-10 Rick Byers <rbyers@chromium.org> - - [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment - https://bugs.webkit.org/show_bug.cgi?id=95996 - - Reviewed by Adam Barth. - - Switch from WebGestureEvent.boundingBox to new gesture-type specific - data fields. - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - -2012-09-09 Keishi Hattori <keishi@webkit.org> - - REGRESSION(r127558): Fix a crash in DateTimeChooserImpl::didClosePopup - https://bugs.webkit.org/show_bug.cgi?id=96222 - - Reviewed by Kent Tamura. - - DateTimeChooserClient will delete DateTimeChooserImpl inside didEndChooser() - so we shouldn't be changing the members after that. - - Testing covered by fast/forms/date/calendar-picker-appearance-pre-100.html. - - * src/DateTimeChooserImpl.cpp: - (WebKit::DateTimeChooserImpl::didClosePopup): - -2012-09-09 Kenichi Ishibashi <bashi@chromium.org> - - [Chromium] Unreviewed gardening after r127907 - - Fix CCRenderPassTest::copyShouldBeIdenticalExceptIdAndQuads - - * tests/CCRenderPassTest.cpp: - (CCRenderPassSize): Changed type of m_id - -2012-09-09 Emil A Eklund <eae@chromium.org> - - Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect - https://bugs.webkit.org/show_bug.cgi?id=81413 - - Reviewed by David Hyatt. - - Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::computeBlockBounds): - (WebKit::WebViewImpl::applyAutofillSuggestions): - (WebKit::WebViewImpl::refreshAutofillPopup): - -2012-09-09 James Robinson <jamesr@chromium.org> - - [chromium] webkit_platform should only be linked into the webkit target - https://bugs.webkit.org/show_bug.cgi?id=96213 - - Reviewed by Adrienne Walker. - - The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only - makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it. - - * WebKit.gyp: - -2012-09-09 James Robinson <jamesr@chromium.org> - - [chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest - https://bugs.webkit.org/show_bug.cgi?id=96212 - - Reviewed by Adrienne Walker. - - The static ::create()s the test references currently are going away soon. - - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - (WebKit::TEST_F): - -2012-09-07 Benjamin Poulain <benjamin@webkit.org> - - Unreviewed prospective build fix. - - * tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include. - Remove the using directive from r127959. - -2012-09-07 Simon Hausmann <simon.hausmann@nokia.com> - - Unreviewed prospective build fix. - - Use WTF namespace like in other files in the same directory to resolve unqualified - adoptPtr correctly. - - * tests/WebCompositorInputHandlerImplTest.cpp: - -2012-09-07 James Robinson <jamesr@chromium.org> - - [chromium] Remove transitional WebCompositorSupport fallback code - https://bugs.webkit.org/show_bug.cgi?id=96155 - - Reviewed by Adrienne Walker. - - * src/LinkHighlight.cpp: - (WebKit::LinkHighlight::LinkHighlight): - (WebKit::LinkHighlight::startHighlightAnimation): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - -2012-09-07 James Robinson <jamesr@chromium.org> - - [chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals - https://bugs.webkit.org/show_bug.cgi?id=96151 - - Reviewed by Adrienne Walker. - - Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals. - WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is - provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC. - - WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl - and storing its identifier for the didActivateCompositor call. From this point on the setup is the same as - before. - - WCIHI changes covered by unit tests, overall scrolling behavior manually tested. - - * WebKit.gypi: - * src/WebCompositorInputHandlerImpl.cpp: - (WebKit::WebCompositorInputHandlerImpl::fromIdentifier): - (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl): - (WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl): - (WebKit::WebCompositorInputHandlerImpl::setClient): - (WebKit::WebCompositorInputHandlerImpl::handleInputEvent): - (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): - (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): - (WebKit::WebCompositorInputHandlerImpl::bindToClient): - * src/WebCompositorInputHandlerImpl.h: - (WebCompositorInputHandlerImpl): - (WebKit::WebCompositorInputHandlerImpl::identifier): - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::createInputHandler): - (WebKit): - * src/WebLayerTreeViewImpl.h: - (WebLayerTreeViewImpl): - * src/WebToCCInputHandlerAdapter.cpp: Added. - (WebKit): - (WebKit::WebToCCInputHandlerAdapter::create): - (WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter): - (WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter): - (WebToCCInputHandlerAdapter::ClientAdapter): - (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter): - (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter): - (WebKit::WebToCCInputHandlerAdapter::bindToClient): - (WebKit::WebToCCInputHandlerAdapter::animate): - * src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h. - (WebKit): - (WebToCCInputHandlerAdapter): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - (WebKit::WebViewImpl::createInputHandler): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/CCThreadedTest.cpp: - * tests/FakeCCLayerTreeHostClient.h: - * tests/WebCompositorInputHandlerImplTest.cpp: - (MockWebInputHandlerClient): - (WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient): - (WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient): - (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest): - (WebCompositorInputHandlerImplTest): - (WebKit::TEST_F): - -2012-09-07 David Reveman <reveman@chromium.org> - - [Chromium] Multiple commits without invalidation allowed per redraw. - https://bugs.webkit.org/show_bug.cgi?id=95661 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostTest.cpp: - (CCLayerTreeHostTestContinuousCommit): - (WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit): - (WebKitTests): - (WebKitTests::TEST_F): - (CCLayerTreeHostTestContinuousInvalidate): - (WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate): - (CCLayerTreeHostTestContinuousAnimate): - (WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate): - * tests/CCSchedulerStateMachineTest.cpp: - (WebCore::TEST): - -2012-09-07 Dominic Mazzoni <dmazzoni@google.com> - - AX: WebCore accessibility roles should be cross-platform - https://bugs.webkit.org/show_bug.cgi?id=94870 - - Reviewed by Chris Fleizach. - - Add a new accessibility role. - - * public/WebAccessibilityRole.h: - * src/AssertMatchingEnums.cpp: - -2012-09-07 Dominic Mazzoni <dmazzoni@google.com> - - AX: Chromium needs access to canvasHasFallbackContent - https://bugs.webkit.org/show_bug.cgi?id=96124 - - Reviewed by Chris Fleizach. - - Expose canvasHasFallbackContent on Chromium. - - * public/WebAccessibilityObject.h: - (WebAccessibilityObject): - * src/WebAccessibilityObject.cpp: - (WebKit::WebAccessibilityObject::canvasHasFallbackContent): - (WebKit): - -2012-09-07 Robert Kroeger <rjkroege@chromium.org> - - [chromium] Add touchscreen specific fling curve parametrization - https://bugs.webkit.org/show_bug.cgi?id=95997 - - Reviewed by James Robinson. - - Added a new set of fling curve parameters with a good feel for touchscreen - initiated flings. Renamed TouchpadFlingPlatformGestureCurve to - TouchFlingPlatformGestureCurve to better reflect that the class - can serve for both touchscreen and touchpad flings when appropriately - parametrized. Updated build files as necessary for the rename. - - No new tests - existing tests apply. - - - * tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor. - -2012-09-07 Dana Jansens <danakj@chromium.org> - - [chromium] Make RenderPass ids hold both generating layer id and an index - https://bugs.webkit.org/show_bug.cgi?id=95500 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCRendererGLTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - -2012-09-07 Joshua Bell <jsbell@chromium.org> - - [Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect - https://bugs.webkit.org/show_bug.cgi?id=96122 - - Reviewed by Adam Barth. - - Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory - open() method now takes the "database callbacks", rather than being sent through - in a later call. - - Also, delete an obsolete method. - - * public/WebIDBFactory.h: - (WebKit): - (WebIDBFactory): Delete pre-version overload of open(). - (WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks. - -2012-09-07 Sami Kyostila <skyostil@google.com> - - [Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing - https://bugs.webkit.org/show_bug.cgi?id=95932 - - Reviewed by James Robinson. - - Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to - properly scroll it. - - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit::TEST_F): Re-enable the test. - -2012-09-07 James Robinson <jamesr@chromium.org> - - [chromium] Move some CC unit tests into correct gyp variable - https://bugs.webkit.org/show_bug.cgi?id=96048 - - Reviewed by Adrienne Walker. - - These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable. - - * WebKit.gypi: - -2012-09-07 James Robinson <jamesr@chromium.org> - - [chromium] Remove dead CCActiveGestureAnimation code and related classes - https://bugs.webkit.org/show_bug.cgi?id=96075 - - Reviewed by Adrienne Walker. - - Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily - evaluate the curve itself without intermediate classes. - - * src/WebCompositorInputHandlerImpl.cpp: - (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): - (WebKit::WebCompositorInputHandlerImpl::animate): - (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling): - * src/WebCompositorInputHandlerImpl.h: - (WebCore): - (WebCompositorInputHandlerImpl): - * tests/PlatformGestureCurveTest.cpp: - * tests/WebCompositorInputHandlerImplTest.cpp: - -2012-09-07 James Robinson <jamesr@chromium.org> - - [chromium] Clean up dependencies in ScrollbarLayerChromiumTest - https://bugs.webkit.org/show_bug.cgi?id=96052 - - Reviewed by Adrienne Walker. - - Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest: - *) WebScrollbarImpl.h is #included, but not use - *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if - WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test. - - * tests/ScrollbarLayerChromiumTest.cpp: - (WebCore::TEST): - -2012-09-07 Dominic Mazzoni <dmazzoni@google.com> - - AX: ARIA spin button should support range value attributes - https://bugs.webkit.org/show_bug.cgi?id=96076 - - Reviewed by Chris Fleizach. - - Expose supportsRangeValue to simplify Chromium logic for when to - extract a value from a range. - - * public/WebAccessibilityObject.h: - (WebAccessibilityObject): - * src/WebAccessibilityObject.cpp: - (WebKit::WebAccessibilityObject::supportsRangeValue): - (WebKit): - -2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com> - - Simplify hitTestResultAtPoint and nodesFromRect APIs - https://bugs.webkit.org/show_bug.cgi?id=95720 - - Reviewed by Antonio Gomes. - - Update calls to new API. - - * src/ContextMenuClientImpl.cpp: - (WebKit::selectMisspelledWord): - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::characterIndexForPoint): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::isRectTopmost): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleMouseUp): - (WebKit::WebViewImpl::computeBlockBounds): - -2012-09-07 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: move WebCore specific code to separate header - https://bugs.webkit.org/show_bug.cgi?id=96101 - - Reviewed by Yury Semikhatsky. - - I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h - - * tests/MemoryInstrumentationTest.cpp: - -2012-09-07 Ian Vollick <vollick@chromium.org> - - [chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed. - https://bugs.webkit.org/show_bug.cgi?id=95855 - - Reviewed by James Robinson. - - Added the following unit tests: - AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix - AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform - - * tests/AnimationTranslationUtilTest.cpp: - (WebKit::TEST): - (WebKit): - -2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com> - - X11 Global Selection - https://bugs.webkit.org/show_bug.cgi?id=88238 - - Reviewed by Tony Chang. - - Use new editor command for pasting global selection. - - * src/EditorClientImpl.cpp: - (WebKit::EditorClientImpl::supportsGlobalSelection): - * src/EditorClientImpl.h: - (EditorClientImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleMouseUp): - -2012-09-07 Yoshifumi Inoue <yosin@chromium.org> - - We should have a localized string of empty for date time field - https://bugs.webkit.org/show_bug.cgi?id=96081 - - Reviewed by Kent Tamura. - - This patch add a function for getting localized string of empty field - value of date time fields for accessibility inside - ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. - - These functions will be used by derived classes of DateTimeFieldElement. - - Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name - to support "date", "datetime", "month" and "week" multiple fields input - UI. - - * src/LocalizedStrings.cpp: - (WebCore::AXDateTimeFieldEmptyValueText): Added. - -2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r127822. - http://trac.webkit.org/changeset/127822 - https://bugs.webkit.org/show_bug.cgi?id=96073 - - It broke compilation on chromium debug bots (Requested by - loislo on #webkit). - - * tests/CCDrawQuadTest.cpp: - (WebCore::TEST): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCRenderPassTest.cpp: - (WebCore::TEST): - * tests/CCRenderSurfaceTest.cpp: - * tests/CCRendererGLTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - -2012-09-06 Dana Jansens <danakj@chromium.org> - - [chromium] Make RenderPass ids hold both generating layer id and an index - https://bugs.webkit.org/show_bug.cgi?id=95500 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCRendererGLTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - -2012-09-06 Yoshifumi Inoue <yosin@chromium.org> - - We should have localized strings of date time fields for accessibility - https://bugs.webkit.org/show_bug.cgi?id=96050 - - Reviewed by Kent Tamura. - - This patch adds functions for getting localized strings of date time - fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. - - These functions will be used by derived classes of DateTimeFieldElement. - - Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name - to support "date", "datetime", "month" and "week" multiple fields input - UI. - - * src/LocalizedStrings.cpp: - (WebCore::AXAMPMFieldText): Added. - (WebCore::AXDayOfMonthFieldText): Added. - (WebCore::AXHourFieldText): Added. - (WebCore::AXMillisecondFieldText): Added. - (WebCore::AXMinuteFieldText): Added. - (WebCore::AXMonthFieldText): Added. - (WebCore::AXSecondFieldText): Added. - (WebCore::AXWeekOfYearFieldText): Added. - (WebCore::AXYearFieldText): Added. - -2012-09-06 James Robinson <jamesr@chromium.org> - - [chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1 - https://bugs.webkit.org/show_bug.cgi?id=96024 - - Reviewed by Adam Barth. - - When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport. - We don't need to link anything in to WebKit.dll. - - * WebKit.gyp: - -2012-09-06 James Robinson <jamesr@chromium.org> - - [chromium] Use WebCompositorSupport functions instead of WebCompositor statics - https://bugs.webkit.org/show_bug.cgi?id=96007 - - Reviewed by Adrienne Walker. - - Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a - WebCompositorInitializer RAII class to simplify this somewhat tedious process. - - * WebKit.gypi: - * public/WebCompositorInputHandlerClient.h: - (WebCompositorInputHandlerClient): - * src/WebCompositorInputHandlerImpl.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::composite): - (WebKit::WebViewImpl::scheduleAnimation): - (WebKit::WebViewImpl::scheduleComposite): - * tests/CCPrioritizedTextureTest.cpp: - (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): - (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest): - (CCPrioritizedTextureTest): - * tests/CCRendererGLTest.cpp: - (CCRendererGLTest::CCRendererGLTest): - (CCRendererGLTest::SetUp): - (CCRendererGLTest): - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCThreadedTest.cpp: - (WebKitTests::CCThreadedTest::runTest): - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): - * tests/LayerChromiumTest.cpp: - * tests/LinkHighlightTest.cpp: - (WebCore::TEST): - * tests/TextureLayerChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - * tests/WebCompositorInitializer.h: Added. - (WebKit): - (WebKitTests): - (WebCompositorInitializer): - (WebKitTests::WebCompositorInitializer::WebCompositorInitializer): - (WebKitTests::WebCompositorInitializer::~WebCompositorInitializer): - * tests/WebCompositorInputHandlerImplTest.cpp: - (WebKit::TEST): - (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest): - (WebCompositorInputHandlerImplTest): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-06 Alec Flett <alecflett@chromium.org> - - IndexedDB: make IDBKeyPath's string and array constructors explicit - https://bugs.webkit.org/show_bug.cgi?id=96004 - - Reviewed by Tony Chang. - - Fix test to use explicit constructor for IDBKeyPath. - - * tests/IDBDatabaseBackendTest.cpp: - -2012-09-06 Adrienne Walker <enne@google.com> - - [chromium] Remove GraphicsContext references from ContentLayerChromiumTest - https://bugs.webkit.org/show_bug.cgi?id=96002 - - Reviewed by James Robinson. - - This is a compositor unit test, so it shouldn't reference things - outside of the compositor like GraphicsContext. The - OpaqueRectTrackingContentLayerDelegateTest already tests opaque - tracking right at the time of paint. This test is about verifying that - transformed canvases work properly, so can just fake the opaque rect - coming back from the paint. - - * tests/ContentLayerChromiumTest.cpp: - (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient): - (WebKit::TEST): - -2012-09-06 Jeff Timanus <twiz@chromium.org> - - [Chromium] Remove contentsScale and related logic from GraphicsLayerChromium. - https://bugs.webkit.org/show_bug.cgi?id=95094 - - Reviewed by Adrienne Walker. - - In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to - try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of - contentsScale behaviour. - This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - Inform the layer associated with the NCCH that it is to disregard the page scale factor. - Also remove now unused m_deviceScaleFactor and associated routines. - (WebKit::NonCompositedContentHost::setViewport): - * src/NonCompositedContentHost.h: - (NonCompositedContentHost): - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::setBoundsContainPageScale): - (WebKit): - (WebKit::WebContentLayerImpl::boundsContainPageScale): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::updateLayerTreeViewport): - * tests/CCLayerTreeHostTest.cpp: - (NoScaleContentLayerChromium): - (WebKitTests::NoScaleContentLayerChromium::create): - (WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium): - (WebKitTests): - (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers): - Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the - scale on the draw transforms remain identity. - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit): Remove now obsolete unit-test. - -2012-09-06 Adrienne Walker <enne@google.com> - - [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest - https://bugs.webkit.org/show_bug.cgi?id=95994 - - Reviewed by James Robinson. - - This compositor test shouldn't depend on code outside the compositor. - - * tests/ScrollbarLayerChromiumTest.cpp: - (WebCore::FakeWebScrollbar::create): - (FakeWebScrollbar): - (WebCore::TEST): - -2012-09-06 James Robinson <jamesr@chromium.org> - - [chromium] Put chromium implementations of WTF symbols in separate static library - https://bugs.webkit.org/show_bug.cgi?id=95933 - - Reviewed by Adam Barth. - - A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These - implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the - component build is a DLL. This moves these files into a static library that webkit depends on so targets can - statically link in wtf and these support files without depending directly on webkit. - - * WebKit.gyp: - -2012-09-06 Iain Merrick <husky@chromium.org> - - [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret - https://bugs.webkit.org/show_bug.cgi?id=93998 - - Reviewed by Adam Barth. - - These provide the same functionality selectRange(WebPoint, WebPoint), - with finer-grained control needed on the Android platform. By passing - allowCollapsedSelection=false, we can ensure the selection stays at - least one character wide. - - I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by - calling the new methods. The existing test passes, and I've added new - tests for the new methods. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::selectRange): - (WebKit): - (WebKit::WebFrameImpl::moveSelectionStart): - (WebKit::WebFrameImpl::moveSelectionEnd): - (WebKit::WebFrameImpl::moveCaret): - * src/WebFrameImpl.h: - (WebFrameImpl): - * tests/WebFrameTest.cpp: - * tests/data/text_selection.html: Added. - -2012-09-06 Robert Kroeger <rjkroege@chromium.org> - - [chromium] Enable different fling behaviour for touchscreen and touchpad - https://bugs.webkit.org/show_bug.cgi?id=95756 - - Reviewed by James Robinson. - - Add support for a flag on WebGestureEvents that differentiates GestureFlingStart - events by their originating device and pass this flag to a factory that produces - different device specific fling curves based on the value of the flag. - - * public/WebActiveWheelFlingParameters.h: - (WebActiveWheelFlingParameters): Store source device for transfer to mainthread. - (WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters): - * public/WebInputEvent.h: Added source device flag to WebGestureEvent. - * src/WebCompositorInputHandlerImpl.cpp: - (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to - obtain device-appropriate fling curve. - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate - fling curve. - (WebKit::WebViewImpl::transferActiveWheelFlingAnimation): - -2012-09-05 Sam Weinig <sam@webkit.org> - - Part 2 of removing PlatformString.h, remove PlatformString.h - https://bugs.webkit.org/show_bug.cgi?id=95931 - - Reviewed by Adam Barth. - - Remove PlatformString.h - - * src/ContextMenuClientImpl.cpp: - * src/EditorClientImpl.cpp: - * src/InspectorFrontendClientImpl.cpp: - * src/LocalFileSystemChromium.cpp: - * src/SpeechInputClientImpl.cpp: - * src/SpeechRecognitionClientProxy.h: - * src/WebDevToolsAgentImpl.cpp: - * src/WebDevToolsFrontendImpl.cpp: - * src/WebDevToolsFrontendImpl.h: - * src/WebEntities.h: - * src/WebFrameImpl.h: - * src/WorkerFileSystemCallbacksBridge.h: - * tests/UniscribeHelperTest.cpp: - -2012-09-06 Dana Jansens <danakj@chromium.org> - - [chromium] Add a customized copy() method to CCRenderPassDrawQuad - https://bugs.webkit.org/show_bug.cgi?id=95871 - - Reviewed by Adrienne Walker. - - * tests/CCDrawQuadTest.cpp: - (WebCore): - (WebCore::TEST): - -2012-09-06 Ilya Tikhonovsky <loislo@chromium.org> - - Unreviewed Web Inspector: test fix. - - * tests/MemoryInstrumentationTest.cpp: - (StringOwnerInstrumented): - (WebCore::StringOwnerInstrumented::StringOwnerInstrumented): - (WebCore::StringOwnerInstrumented::reportMemoryUsage): - (WebCore): - (WebCore::TEST): - -2012-09-06 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol. - https://bugs.webkit.org/show_bug.cgi?id=95957 - - Reviewed by Yury Semikhatsky. - - Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol - instead of MemoryBlockNames hardcoded in InspectorMemoryAgent.. - At a later stage, when each memory type is counted in MemoryInstrumentation - we will build the blocks hierarchy for the front-end automatically. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::InstrumentedUndefined::InstrumentedUndefined): - (WebCore::InstrumentedUndefined::reportMemoryUsage): - (WebCore::InstrumentedDOM::InstrumentedDOM): - (WebCore::InstrumentedDOM::reportMemoryUsage): - (InstrumentedDOM): - (WebCore::TEST): - -2012-09-06 Kenichi Ishibashi <bashi@chromium.org> - - [Chromium] Win build fix attempt after r127715 - - * tests/CCRenderPassTest.cpp: - (WebCore::TEST): - -2012-09-06 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-06 Dana Jansens <danakj@chromium.org> - - [chromium] Add a copy() method to CCRenderPass - https://bugs.webkit.org/show_bug.cgi?id=95485 - - Reviewed by Adrienne Walker. - - * WebKit.gypi: - * tests/CCRenderPassTest.cpp: Added. - (CCTestRenderPass): - (CCTestRenderPass::quadList): - (CCTestRenderPass::sharedQuadStateList): - (CCRenderPassSize): - (TEST): - -2012-09-06 Peter Beverloo <peter@chromium.org> - - [Chromium] Chromium Mac build fix after revision r127711 - https://bugs.webkit.org/show_bug.cgi?id=95958 - - Unreviewed build fix. - - This is a clear typo in the source file, so changing the function to - call locationModifiersFromWindowsKeyCode instead. - - * src/mac/WebInputEventFactory.mm: - (WebKit::WebInputEventFactory::keyboardEvent): - -2012-09-06 Raymes Khoury <raymes@chromium.org> - - Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents - https://bugs.webkit.org/show_bug.cgi?id=94142 - - Reviewed by Tony Chang. - - Previously we distinguished between left/right Shift/Ctrl/Alt in - WebInputEvents by using the location-specific virtual keycodes (e.g. - VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events - always returns the non-locational version (e.g. VK_SHIFT). - Furthermore, KeyboardEvent also returns - non-locational keycodes and separates the location information which - matches the behavior described in the DOM3 - spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We - should be consistent with this in our representation of key events. - This patch changes WebInputEvents so they always store the - non-locational keycode and location information is stored in - modifiers. Since this only changes internal representation, no new - tests are added. - - This patch also ensures that when KeyboardEvents are converted back to - WebInputEvents location information is preserved (which was not - happening before). This is important so that key location information - is passed on to plugins. A unittest is added for this. - - * WebKit.gypi: - * public/WebInputEvent.h: - (WebKeyboardEvent): - * src/WebInputEvent.cpp: - (WebKit): - (WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation): - (WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode): - * src/WebInputEventConversion.cpp: - (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): - (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): - * src/android/WebInputEventFactory.cpp: - (WebKit::WebInputEventFactory::keyboardEvent): - * src/gtk/WebInputEventFactory.cpp: - (WebKit::WebInputEventFactory::keyboardEvent): - * src/mac/WebInputEventFactory.mm: - (WebKit::WebInputEventFactory::keyboardEvent): - * src/win/WebInputEventFactory.cpp: - (WebKit::getLocationModifier): - (WebKit::WebInputEventFactory::keyboardEvent): - * tests/WebInputEventConversionTest.cpp: Added. - -2012-09-06 Adam Barth <abarth@webkit.org> - - Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly. - https://bugs.webkit.org/show_bug.cgi?id=91110 - - Reviewed by Tony Chang. - - Prior to this patch, we were ignoring the user-scalable property of - viewport meta tags. This patch enforces the user-scalable property by - claming the minimum-scale and maximum-scale values, effectively - preventing user scaling. This approach isn't perfect, as discussed in - https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement - over the status quo. - - This approach is also used by EFL, GTK, and Qt. - - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): - -2012-09-05 Dana Jansens <danakj@chromium.org> - - [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState - https://bugs.webkit.org/show_bug.cgi?id=95374 - - Reviewed by Adrienne Walker. - - * WebKit.gypi: - * tests/CCDrawQuadTest.cpp: Added. - (TEST): - (createSharedQuadState): - (compareDrawQuad): - -2012-09-05 Kenichi Ishibashi <bashi@chromium.org> - - [Chromium] Unreviewed gardening - - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit::TEST_F): Disabled applyScrollToScrollableArea() - -2012-09-05 Tony Chang <tony@chromium.org> - - [chromium] Remove dependency on webkit_user_agent - https://bugs.webkit.org/show_bug.cgi?id=95886 - - Reviewed by Adam Barth. - - The code isn't used by webkit_unit_tests. - - * WebKitUnitTests.gyp: - -2012-09-05 Nate Chapin <japhet@chromium.org> - - Test for https://bugs.webkit.org/show_bug.cgi?id=91685 - - Reviewed by Adam Barth. - - * tests/WebFrameTest.cpp: - -2012-09-05 Rick Byers <rbyers@chromium.org> - - Use new type-specific WebGestureEvent fields - https://bugs.webkit.org/show_bug.cgi?id=95573 - - Reviewed by James Robinson. - - Chromium has been updated to store gesture-type specific details in the - new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and - crrev.com/154959), so we can now rely on them. - - * src/WebCompositorInputHandlerImpl.cpp: - Update the compositor scroll, pinch and fling handling to use these new fields. - (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): - (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): - * src/WebInputEventConversion.cpp: - Update PlatformGestureEvent/WebGestureEvent conversion to use the new - fields, storing into the existing overloaded PlatformGestureEvent - fields (which will be cleaned up in my next CL). - (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): - (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - Update fling scrolling implementation for correct location of velocity. - * tests/WebCompositorInputHandlerImplTest.cpp: - (WebKit::TEST_F): - Update tests to use the new fields. - - -2012-09-05 James Robinson <jamesr@chromium.org> - - [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test - https://bugs.webkit.org/show_bug.cgi?id=95819 - - Reviewed by Adam Barth. - - This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode - upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from - webkit.dll in the component build. - - * tests/WebLayerTest.cpp: - -2012-09-05 Victoria Kirst <vrk@chromium.org> - - Add the duration attribute to MediaSource - https://bugs.webkit.org/show_bug.cgi?id=95149 - - Reviewed by Eric Carlson. - - Add support for the duration attribute recently added to the MediaSource spec. - http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration - - * public/WebMediaPlayer.h: - (WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition. - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer. - (WebKit): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-09-05 Mihai Parparita <mihaip@chromium.org> - - [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime - https://bugs.webkit.org/show_bug.cgi?id=95865 - - Reviewed by Darin Fisher. - - Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into - no-ops. - - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enablePushState): - (WebKit::WebRuntimeFeatures::isPushStateEnabled): - -2012-09-05 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Remove getRenderStyleForStrike from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=95363 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * public/linux/WebFontInfo.h: - * public/linux/WebFontRenderStyle.h: - * src/PlatformSupport.cpp: - (WebCore): - -2012-09-05 Ilya Tikhonovsky <loislo@chromium.org> - - Unreviewed: WebInspector: remove accidentally committed speed test. - - * tests/MemoryInstrumentationTest.cpp: - -2012-09-05 Sami Kyostila <skyostil@chromium.org> - - [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium - https://bugs.webkit.org/show_bug.cgi?id=95679 - - Reviewed by James Robinson. - - Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer. - - * src/WebLayerImpl.cpp: - (WebKit::WebLayerImpl::setMaxScrollPosition): - (WebKit): - (WebKit::WebLayerImpl::setScrollClient): - (WebKit::WebLayerImpl::scrollBy): - * src/WebLayerImpl.h: - (WebLayerImpl): - * tests/CCLayerTreeHostTest.cpp: - * tests/GraphicsLayerChromiumTest.cpp: - (MockScrollableArea): - (WebKit): - (WebKit::TEST_F): - * tests/WebLayerTest.cpp: - -2012-09-05 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation. - https://bugs.webkit.org/show_bug.cgi?id=95850 - - Reviewed by Yury Semikhatsky. - - I'd like to extract MemoryObjectTypes into separate classes. - After that we will be able to move core NMI instrumentation code to WTF. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::Instrumented::reportMemoryUsage): - (WebCore::InstrumentedRefPtr::reportMemoryUsage): - (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): - (WebCore::InstrumentedOther::reportMemoryUsage): - (WebCore::InstrumentedDOM::reportMemoryUsage): - (WebCore::TEST): - (WebCore::NonVirtualInstrumented::reportMemoryUsage): - -2012-09-05 Peter Beverloo <peter@chromium.org> - - Unreviewed, rolling out r127590. - http://trac.webkit.org/changeset/127590 - - Broke the Chromium bots because of a compile error in the compositor. - - * DEPS: - -2012-09-05 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-04 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers. - https://bugs.webkit.org/show_bug.cgi?id=95739 - - Reviewed by Yury Semikhatsky. - - When we go deeper into different parts of browser like skia, chromium itself etc. - we can't use a single enum for all reported object types. - The current idea is to use plain simple strings as ObjectType identifiers. - In the future patches we will extract these identifiers into separate class or namespace - and and split it between components. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - (WebCore): - -2012-09-04 Keishi Hattori <keishi@webkit.org> - - Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer - https://bugs.webkit.org/show_bug.cgi?id=95681 - - Reviewed by Kent Tamura. - - * WebKit.gyp: - * src/ChromeClientImpl.cpp: - (WebKit): - (WebKit::ChromeClientImpl::openDateTimeChooser): - * src/ChromeClientImpl.h: - (WebCore): - (ChromeClientImpl): - * src/DateTimeChooserImpl.cpp: Added. - (WebKit): - (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): - (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl): - (WebKit::DateTimeChooserImpl::endChooser): - (WebKit::DateTimeChooserImpl::contentSize): - (WebKit::DateTimeChooserImpl::writeDocument): - (WebKit::DateTimeChooserImpl::setValueAndClosePopup): - (WebKit::DateTimeChooserImpl::didClosePopup): - * src/DateTimeChooserImpl.h: - (WebCore): - (WebKit): - (DateTimeChooserImpl): - -2012-09-04 Adam Barth <abarth@chromium.org> - - Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS - https://bugs.webkit.org/show_bug.cgi?id=95798 - - Reviewed by Eric Seidel. - - * src/WebAccessibilityObject.cpp: - (WebKit::WebAccessibilityObject::keyboardShortcut): - - Remove use of WTF::String::operator+= - * src/WebPageSerializerImpl.cpp: - - Whitelist use of WTF::String::operator+=. Remove this use will take - some more careful thought. - -2012-09-04 Alec Flett <alecflett@chromium.org> - - IndexedDB: remove final createIndex backend glue - https://bugs.webkit.org/show_bug.cgi?id=95385 - - Reviewed by Adam Barth. - - Remove chromium glue for old key-generation code. - - * public/WebIDBKey.h: - (WebIDBKey): - * src/WebIDBKey.cpp: - -2012-09-04 Tien-Ren Chen <trchen@chromium.org> - - [chromium] Rename WebViewClient::handleDisambiguationPopup - https://bugs.webkit.org/show_bug.cgi?id=95529 - - Reviewed by Adam Barth. - - Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it. - - * public/WebViewClient.h: - (WebKit::WebViewClient::didTapMultipleTargets): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - * tests/WebFrameTest.cpp: - -2012-09-03 Tao Bai <michaelbai@chromium.org> - - Added ANDROID_GDBSERVER definition for Ant - https://bugs.webkit.org/show_bug.cgi?id=95265 - - Reviewed by Adam Barth. - - ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN - is only used for finding the gdbserver. - - * WebKitUnitTests.gyp: - -2012-09-03 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-09-03 Tommy Widenflycht <tommyw@google.com> - - MediaStream API: Add Ice-related functionality to RTCPeerConnection - https://bugs.webkit.org/show_bug.cgi?id=95565 - - Reviewed by Adam Barth. - - * src/AssertMatchingEnums.cpp: - -2012-09-01 James Robinson <jamesr@chromium.org> - - Unreviewed chromium buildfix when use_libcc_for_compositor=1 - - This gyp target was renamed downstream. - - * WebKit.gyp: - -2012-09-01 Tommy Widenflycht <tommyw@google.com> - - MediaStream API: Add MediaStream management to RTCPeerConnection - https://bugs.webkit.org/show_bug.cgi?id=95543 - - Reviewed by Adam Barth. - - * src/AssertMatchingEnums.cpp: - -2012-08-31 Koji Ishii <kojiishi@gmail.com> - - Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows - https://bugs.webkit.org/show_bug.cgi?id=51450 - - Reviewed by Tony Chang. - - When writing-mode is vertical-*, Chromium Win does not render glyphs correctly. - http://dev.w3.org/csswg/css3-writing-modes/#writing-mode - Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name, - and vertical alternate glyphs (OpenType 'vert' feature) is not enabled. - CJK characters drawn at wrong baseline position is also fixed. - In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty - in Chromium Win but they were implemented because they were needed to draw vertical flow correctly. - - Note that this patch does not address issues in vertical flow for complex code path. - The issue is under discussion with Google people and it will not be fixed in short term. - - Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations. - - * features.gypi: ENABLE_OPENTYPE_VERTICAL=1. - -2012-08-31 W. James MacLean <wjmaclean@chromium.org> - - [chromium] Make link highlighter use same node selection criteria as Chromium for Android. - https://bugs.webkit.org/show_bug.cgi?id=95371 - - Reviewed by James Robinson. - - This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android. - - * src/WebViewImpl.cpp: - (WebKit::highlightConditions): - (WebKit::WebViewImpl::bestTouchLinkNode): - * tests/data/test_touch_link_highlight.html: - -2012-08-31 James Robinson <jamesr@chromium.org> - - [chromium] Consolidate geometry unit testing functions for cc - https://bugs.webkit.org/show_bug.cgi?id=95526 - - Reviewed by Julien Chaffraix. - - This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for - testing rect equality. - - * WebKit.gypi: - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCGeometryTestUtils.cpp: Added. - (WebKitTests): - (WebKitTests::ExpectTransformationMatrixEq): - * tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h. - (WebKit): - (WebKitTests): - * tests/CCLayerTreeHostTest.cpp: - * tests/CCMathUtilTest.cpp: - (WebKit::TEST): - * tests/TiledLayerChromiumTest.cpp: - -2012-08-31 James Robinson <jamesr@chromium.org> - - [chromium] Clean up Web*Layer initialization paths - https://bugs.webkit.org/show_bug.cgi?id=95523 - - Reviewed by Darin Fisher. - - Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling - implementation. Also normalizes naming conventions in these files. - - * src/WebAnimationImpl.cpp: - (WebKit::WebAnimation::create): - (WebKit::WebAnimationImpl::WebAnimationImpl): - * src/WebAnimationImpl.h: - (WebAnimationImpl): - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::WebContentLayerImpl): - (WebKit::WebContentLayerImpl::~WebContentLayerImpl): - (WebKit::WebContentLayerImpl::layer): - (WebKit::WebContentLayerImpl::setDoubleSided): - (WebKit::WebContentLayerImpl::setContentsScale): - (WebKit::WebContentLayerImpl::setUseLCDText): - (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebFloatAnimationCurveImpl.cpp: - (WebKit::WebFloatAnimationCurve::create): - (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl): - * src/WebFloatAnimationCurveImpl.h: - (WebFloatAnimationCurveImpl): - * src/WebIOSurfaceLayerImpl.cpp: - (WebKit::WebIOSurfaceLayer::create): - (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): - * src/WebIOSurfaceLayerImpl.h: - (WebIOSurfaceLayerImpl): - * src/WebImageLayerImpl.cpp: - (WebKit::WebImageLayer::create): - (WebKit::WebImageLayerImpl::WebImageLayerImpl): - * src/WebImageLayerImpl.h: - (WebImageLayerImpl): - * src/WebLayerImpl.cpp: - (WebKit::WebLayer::create): - (WebKit): - (WebKit::WebLayerImpl::WebLayerImpl): - * src/WebLayerImpl.h: - (WebLayerImpl): - * src/WebScrollbarLayerImpl.cpp: - (WebKit::WebScrollbarLayer::create): - (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): - * src/WebScrollbarLayerImpl.h: - (WebScrollbarLayerImpl): - * src/WebSolidColorLayerImpl.cpp: - (WebKit::WebSolidColorLayer::create): - (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): - * src/WebSolidColorLayerImpl.h: - (WebSolidColorLayerImpl): - * src/WebTransformAnimationCurveImpl.cpp: - (WebKit::WebTransformAnimationCurve::create): - (WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl): - * src/WebTransformAnimationCurveImpl.h: - (WebTransformAnimationCurveImpl): - * src/WebVideoLayerImpl.cpp: - (WebKit::WebVideoLayer::create): - (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): - * src/WebVideoLayerImpl.h: - (WebVideoLayerImpl): - -2012-08-31 Tony Chang <tony@chromium.org> - - Remove ENABLE_CSS3_FLEXBOX compile time flag - https://bugs.webkit.org/show_bug.cgi?id=95382 - - Reviewed by Ojan Vafai. - - Everyone is already enabling this by default and the spec has stablized. - - * features.gypi: - -2012-08-31 Christopher Cameron <ccameron@chromium.org> - - [chromium] Add main versus impl thread asserts - https://bugs.webkit.org/show_bug.cgi?id=95596 - - Reviewed by James Robinson. - - Add asserts to prioritized texture manager that specify that a - function be called on the main or impl thread. - - Add debug signs that the main thread is blocked to the threaded - proxy. - - Add a mechanism to simultaneously set the thread to the impl thread - and indicate that the main thread is blocked. - - Update tests that hit asserts in the prioritized texture manager to - set their impl thread and main thread blocked state correctly. - - * tests/CCPrioritizedTextureTest.cpp: - (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): - (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest): - (WTF::CCPrioritizedTextureTest::validateTexture): - (WTF::TEST_F): - * tests/TiledLayerChromiumTest.cpp: - -2012-08-30 James Robinson <jamesr@chromium.org> - - [chromium] Put compositor client interfaces in separate headers, normalize naming - https://bugs.webkit.org/show_bug.cgi?id=95522 - - Reviewed by Adam Barth. - - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::~WebContentLayerImpl): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebExternalTextureLayerImpl.h: - * src/WebLayerTreeViewImpl.h: - (WebCore): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WebKitTests::ContentLayerChromiumWithUpdateTracking::create): - (WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking): - (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers): - (WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit): - (WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate): - (WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources): - (CCLayerTreeHostTestLostContextWhileUpdatingResources): - * tests/ContentLayerChromiumTest.cpp: - (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient): - (WebKit::TEST): - -2012-08-31 Gavin Peters <gavinp@chromium.org> - - [chromium] DEPS roll with a test skip. - https://bugs.webkit.org/show_bug.cgi?id=95601 - - Unreviewed gardening & DEPS roll. - - - fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this) - - * DEPS: - -2012-08-31 Gavin Peters <gavinp@chromium.org> - - [chromium] Disable WebViewTest.AutoResizeMinimumSize - https://bugs.webkit.org/show_bug.cgi?id=95571 - - Unreviewed gardening. - - Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this. - - * tests/WebViewTest.cpp: - -2012-08-30 James Robinson <jamesr@chromium.org> - - [chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected - https://bugs.webkit.org/show_bug.cgi?id=95520 - - Reviewed by Darin Fisher. - - Adopt the return value of WebCompositorSupport explicitly. - - * src/LinkHighlight.cpp: - (WebKit::LinkHighlight::LinkHighlight): - (WebKit::LinkHighlight::startHighlightAnimation): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - -2012-08-30 James Robinson <jamesr@chromium.org> - - [chromium] Make webkit_compositor specific unit test compilation conditional on gyp var - https://bugs.webkit.org/show_bug.cgi?id=95401 - - Reviewed by Dirk Pranke. - - If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere. - - * WebKit.gyp: - * WebKit.gypi: - * WebKitUnitTests.gyp: - -2012-08-27 James Robinson <jamesr@chromium.org> - - [chromium] Add CompositorSupport interface for constructing compositor classes - https://bugs.webkit.org/show_bug.cgi?id=95040 - - Reviewed by Darin Fisher. - - * src/LinkHighlight.cpp: - (WebKit::LinkHighlight::LinkHighlight): - (WebKit::LinkHighlight::startHighlightAnimation): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - * src/WebMediaPlayerClientImpl.h: - (WebKit): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - * src/WebPluginContainerImpl.h: - (WebKit): - -2012-08-30 Gavin Peters <gavinp@chromium.org> - - [chromium] Disable CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread - https://bugs.webkit.org/show_bug.cgi?id=95472 - - Unreviewed gardening. - - When landing r127079, this test was re-enabled, and has not passed since. I'm disabling it, and created bug 95473 to track fixing this issue. - - * tests/CCLayerTreeHostTest.cpp: - (WebKitTests::TEST_F): - -2012-08-30 James Robinson <jamesr@chromium.org> - - [chromium] Clean up some webkit compositor unit tests - https://bugs.webkit.org/show_bug.cgi?id=95410 - - Reviewed by Adrienne Walker. - - This adds includes that were implicitly being picked up, removes ones that weren't being used, removes - dead code, adds OVERRIDE on functions that OVERRIDE, and deinlines virtuals that the chromium clang style - plugin is unhappy about. - - * tests/CCAnimationTestCommon.cpp: - (WebKitTests::FakeFloatAnimationCurve::duration): - (WebKitTests): - (WebKitTests::FakeFloatAnimationCurve::getValue): - (WebKitTests::FakeTransformTransition::duration): - (WebKitTests::FakeFloatTransition::duration): - (WebKitTests::FakeLayerAnimationControllerClient::id): - (WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation): - (WebKitTests::FakeLayerAnimationControllerClient::opacity): - (WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation): - (WebKitTests::FakeLayerAnimationControllerClient::transform): - * tests/CCAnimationTestCommon.h: - (FakeFloatAnimationCurve): - (FakeTransformTransition): - (FakeFloatTransition): - (FakeLayerAnimationControllerClient): - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat): - (WebKitTests): - (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds): - (WebKitTests::FakeTiledLayerChromium::textureManager): - (WebKitTests::FakeTiledLayerChromium::textureUpdater): - (WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds): - (WebKitTests::FakeTextureUploader::isBusy): - (WebKitTests::FakeTextureUploader::uploadTexture): - * tests/CCTiledLayerTestCommon.h: - (FakeLayerTextureUpdater): - (FakeTiledLayerChromium): - (FakeTiledLayerWithScaledBounds): - (FakeTextureUploader): - * tests/FakeWebCompositorOutputSurface.h: - * tests/TextureCopierTest.cpp: - (MockContext): - (TEST): - * tests/ThrottledTextureUploaderTest.cpp: - (WebKit::TEST): - * tests/WebLayerTreeViewTest.cpp: - -2012-08-29 Hironori Bono <hbono@chromium.org> - - Fix Chromium builds (Win and Mac) - https://bugs.webkit.org/show_bug.cgi?id=95421 - - Reviewed by James Robinson. - - This change replaces 'class WebRect' with 'struct WebRect' to fix build breaks - on the "Chromium Mac Release" and the "Chromium Win Release" bot caused by - r127095. - - * public/WebViewClient.h: - (WebKit): - -2012-08-29 Nat Duca <nduca@chromium.org> - - [chromium] setNeedsAnimate should not cause commitRequested to become true - https://bugs.webkit.org/show_bug.cgi?id=95393 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostTest.cpp: - (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested): - (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested): - -2012-08-29 Tien-Ren Chen <trchen@chromium.org> - - [chromium] Implement disambiguation popup (a.k.a. Link Preview) - https://bugs.webkit.org/show_bug.cgi?id=94182 - - Reviewed by Adam Barth. - - In this new implementation, we add a new WebViewClient::handleDisambiguationPopup delegate. - The disambiguation sequence will be initiated by the gesture event handler - in WebViewImpl if an ambiguous tap is detected, then - m_client->handleDisambiguationPopup will be called, so the embedder can - decide whether to swallow the touch event and show a popup. - - New test: WebFrameTest.DisambiguationPopupTest - - * WebKit.gyp: - * features.gypi: - * public/WebInputEvent.h: - (WebGestureEvent): - (WebKit::WebGestureEvent::WebGestureEvent): - * public/WebTouchCandidatesInfo.h: Removed. - * public/WebView.h: - (WebKit): - * public/WebViewClient.h: - (WebKit): - (WebViewClient): - (WebKit::WebViewClient::triggersLinkPreview): - * src/WebInputEvent.cpp: - (SameSizeAsWebGestureEvent): - * src/WebViewImpl.cpp: - (WebKit): - (WebKit::WebViewImpl::handleGestureEventWithLinkPreview): - (WebKit::WebViewImpl::handleGestureEvent): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-29 Dominic Mazzoni <dmazzoni@google.com> - - AX: Canvas should have a distinct role - https://bugs.webkit.org/show_bug.cgi?id=95248 - - Reviewed by Chris Fleizach. - - Add support for canvas accessibility role. - - * public/WebAccessibilityRole.h: - * src/AssertMatchingEnums.cpp: - -2012-08-29 Alex Sakhartchouk <alexst@chromium.org> - - [chromium] CCLayerTreeHost::finishCommitOnImplThread wrong setter order - https://bugs.webkit.org/show_bug.cgi?id=94828 - - Reviewed by Adrienne Walker. - - Testing that setDeviceScaleFactor properly changes maxScrollPosition - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-29 James Robinson <jamesr@chromium.org> - - Unreviewed, rolling out r126956. - http://trac.webkit.org/changeset/126956 - https://bugs.webkit.org/show_bug.cgi?id=94721 - - Breaks several unit tests - - * tests/CCSchedulerTest.cpp: - (WebKitTests::FakeCCSchedulerClient::reset): - (WebKitTests::FakeCCSchedulerClient::setHasMoreResourceUpdates): - (WebKitTests::TEST): - * tests/CCTextureUpdateControllerTest.cpp: - -2012-08-29 James Robinson <jamesr@chromium.org> - - [chromium] Register/unregister contents layers with GraphicsLayerChromium - https://bugs.webkit.org/show_bug.cgi?id=95379 - - Reviewed by Adrienne Walker. - - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): - -2012-08-29 W. James MacLean <wjmaclean@chromium.org> - - [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights. - https://bugs.webkit.org/show_bug.cgi?id=95119 - - Reviewed by Adam Barth. - - Add support to WebSettings for flag to enable/disable gesture tap highlights. Relies on existing tests. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::WebSettingsImpl): - (WebKit::WebSettingsImpl::setGestureTapHighlightEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - (WebKit::WebSettingsImpl::gestureTapHighlightEnabled): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - -2012-08-29 Dana Jansens <danakj@chromium.org> - - [chromium] Remove HUD layer when rootLayer is set to null - https://bugs.webkit.org/show_bug.cgi?id=95257 - - Reviewed by James Robinson. - - * WebKit.gypi: - * tests/CCHeadsUpDisplayTest.cpp: Added. - (CCHeadsUpDisplayTest): - (DrawsContentLayerChromium): - (DrawsContentLayerChromium::create): - (DrawsContentLayerChromium::DrawsContentLayerChromium): - (CCHudWithRootLayerChange): - (CCHudWithRootLayerChange::CCHudWithRootLayerChange): - (TEST_F): - * tests/CCLayerTreeHostTest.cpp: - * tests/CCThreadedTest.cpp: - (WebKitTests::CCThreadedTest::runTest): - * tests/CCThreadedTest.h: - (WebKitTests::CCThreadedTest::initializeSettings): - (CCThreadedTest): - -2012-08-29 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Add more unit test coverage for semantics of drawableContentRect and visibleContentRect - https://bugs.webkit.org/show_bug.cgi?id=94542 - - Reviewed by Adrienne Walker. - - To make upcoming refactors safer, it was appropriate to (finally) - add unit tests that check the behavior of drawableContentRect and - visibleContentRect computations in calculateDrawTransforms. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-08-29 W. James MacLean <wjmaclean@chromium.org> - - [chromium] Link highlight should clear on page navigation. - https://bugs.webkit.org/show_bug.cgi?id=95129 - - Reviewed by James Robinson. - - Modified WebViewImpl to clear link highlight when navigating to new url. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::didCommitLoad): - -2012-08-29 James Robinson <jamesr@chromium.org> - - [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1 - https://bugs.webkit.org/show_bug.cgi?id=94995 - - Reviewed by Adam Barth. - - * WebKit.gyp: - -2012-08-28 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Do not clip root layer's subtree to viewport - https://bugs.webkit.org/show_bug.cgi?id=95235 - - Reviewed by Adrienne Walker. - - Existing tests updated, and otherwise this change is already - covered by layout and unit tests. - - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): - (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): - -2012-08-29 Julien Chaffraix <jchaffraix@webkit.org> - - [Chromium] CCLayerTreeHostTestScrollChildLayer makes the wrong assumptions - https://bugs.webkit.org/show_bug.cgi?id=95358 - - Unreviewed gardening. - - * tests/CCLayerTreeHostTest.cpp: - Disabled the test until it is fixed. - -2012-08-29 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126972. - http://trac.webkit.org/changeset/126972 - https://bugs.webkit.org/show_bug.cgi?id=95349 - - accessibility/canvas-description-and-role.html has been - failing consistently on several bots and Dominic needs some - time to investigate why (Requested by jchaffraix on #webkit). - - * public/WebAccessibilityRole.h: - * src/AssertMatchingEnums.cpp: - -2012-08-29 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-29 Dominic Mazzoni <dmazzoni@google.com> - - AX: Canvas should have a distinct role - https://bugs.webkit.org/show_bug.cgi?id=95248 - - Reviewed by Chris Fleizach. - - Add support for canvas accessibility role. - - * public/WebAccessibilityRole.h: - * src/AssertMatchingEnums.cpp: - -2012-08-28 David Reveman <reveman@chromium.org> - - [Chromium] Scheduler will never process a commit until it receives a vsync tick. - https://bugs.webkit.org/show_bug.cgi?id=94721 - - Reviewed by James Robinson. - - * tests/CCSchedulerTest.cpp: - (WebKitTests::FakeCCSchedulerClient::reset): - (WebKitTests::TEST): - * tests/CCTextureUpdateControllerTest.cpp: - -2012-08-28 Adam Barth <abarth@webkit.org> - - Fix ASSERT in fast/events/touch/gesture/context-menu-on-two-finger-tap.html - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::detectContentOnTouch): - -2012-08-28 Leandro Gracia Gil <leandrogracia@chromium.org> - - Content detection should not disrupt the page behaviour - https://bugs.webkit.org/show_bug.cgi?id=94727 - - Reviewed by Adam Barth. - - Triggers content detection in the embedder on tap gestures and - add checks for the appropriate event listeners in order to prevent - triggering content detection when it would disrupt the page's behaviour. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - (WebKit::WebViewImpl::detectContentOnTouch): - * tests/WebViewTest.cpp: - * tests/data/content_listeners.html: Added. - -2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126933. - http://trac.webkit.org/changeset/126933 - https://bugs.webkit.org/show_bug.cgi?id=95261 - - Turns out we do need this! (Requested by abarth on #webkit). - - * public/WebWidget.h: - (WebKit::WebWidget::paint): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::paint): - * src/WebPagePopupImpl.h: - (WebPagePopupImpl): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::paint): - * src/WebPopupMenuImpl.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::paint): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-28 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Remove decodeAudioFileData from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=95250 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126344. - http://trac.webkit.org/changeset/126344 - https://bugs.webkit.org/show_bug.cgi?id=95253 - - This change is no longer needed (Requested by abarth on - #webkit). - - * public/WebWidget.h: - (WebKit::WebWidget::paint): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::paint): - * src/WebPagePopupImpl.h: - (WebPagePopupImpl): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::paint): - * src/WebPopupMenuImpl.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::paint): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-28 Dominic Mazzoni <dmazzoni@google.com> - - AX: Crash due to object getting deleted inside updateBackingStore - https://bugs.webkit.org/show_bug.cgi?id=94619 - - Reviewed by Chris Fleizach. - - Chromium now calls updateBackingStoreAndCheckValidity explicitly, - so we can now get rid of calls to updateBackingStore in the - method implementations, and just make sure we're checking isDetached. - - * public/WebAccessibilityObject.h: - (WebAccessibilityObject): - * src/WebAccessibilityObject.cpp: - (WebKit::WebAccessibilityObject::axID): - (WebKit::WebAccessibilityObject::accessibilityDescription): - (WebKit::WebAccessibilityObject::actionVerb): - (WebKit::WebAccessibilityObject::canSetFocusAttribute): - (WebKit::WebAccessibilityObject::canSetValueAttribute): - (WebKit::WebAccessibilityObject::childCount): - (WebKit::WebAccessibilityObject::childAt): - (WebKit::WebAccessibilityObject::firstChild): - (WebKit::WebAccessibilityObject::focusedChild): - (WebKit::WebAccessibilityObject::lastChild): - (WebKit::WebAccessibilityObject::nextSibling): - (WebKit::WebAccessibilityObject::parentObject): - (WebKit::WebAccessibilityObject::previousSibling): - (WebKit::WebAccessibilityObject::canSetSelectedAttribute): - (WebKit::WebAccessibilityObject::isAnchor): - (WebKit::WebAccessibilityObject::isAriaReadOnly): - (WebKit::WebAccessibilityObject::isButtonStateMixed): - (WebKit::WebAccessibilityObject::isChecked): - (WebKit::WebAccessibilityObject::isCollapsed): - (WebKit::WebAccessibilityObject::isControl): - (WebKit::WebAccessibilityObject::isEnabled): - (WebKit::WebAccessibilityObject::isFocused): - (WebKit::WebAccessibilityObject::isHovered): - (WebKit::WebAccessibilityObject::isIndeterminate): - (WebKit::WebAccessibilityObject::isLinked): - (WebKit::WebAccessibilityObject::isLoaded): - (WebKit::WebAccessibilityObject::isMultiSelectable): - (WebKit::WebAccessibilityObject::isOffScreen): - (WebKit::WebAccessibilityObject::isPasswordField): - (WebKit::WebAccessibilityObject::isPressed): - (WebKit::WebAccessibilityObject::isReadOnly): - (WebKit::WebAccessibilityObject::isRequired): - (WebKit::WebAccessibilityObject::isSelected): - (WebKit::WebAccessibilityObject::isSelectedOptionActive): - (WebKit::WebAccessibilityObject::isVertical): - (WebKit::WebAccessibilityObject::isVisible): - (WebKit::WebAccessibilityObject::isVisited): - (WebKit::WebAccessibilityObject::accessKey): - (WebKit::WebAccessibilityObject::ariaHasPopup): - (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic): - (WebKit::WebAccessibilityObject::ariaLiveRegionBusy): - (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant): - (WebKit::WebAccessibilityObject::ariaLiveRegionStatus): - (WebKit::WebAccessibilityObject::boundingBoxRect): - (WebKit::WebAccessibilityObject::estimatedLoadingProgress): - (WebKit::WebAccessibilityObject::helpText): - (WebKit::WebAccessibilityObject::headingLevel): - (WebKit::WebAccessibilityObject::hierarchicalLevel): - (WebKit::WebAccessibilityObject::hitTest): - (WebKit::WebAccessibilityObject::keyboardShortcut): - (WebKit::WebAccessibilityObject::performDefaultAction): - (WebKit::WebAccessibilityObject::roleValue): - (WebKit::WebAccessibilityObject::selectionEnd): - (WebKit::WebAccessibilityObject::selectionStart): - (WebKit::WebAccessibilityObject::stringValue): - (WebKit::WebAccessibilityObject::title): - (WebKit::WebAccessibilityObject::titleUIElement): - (WebKit::WebAccessibilityObject::url): - (WebKit::WebAccessibilityObject::valueDescription): - (WebKit::WebAccessibilityObject::valueForRange): - (WebKit::WebAccessibilityObject::maxValueForRange): - (WebKit::WebAccessibilityObject::minValueForRange): - (WebKit::WebAccessibilityObject::node): - (WebKit::WebAccessibilityObject::document): - (WebKit::WebAccessibilityObject::accessibilityIsIgnored): - (WebKit::WebAccessibilityObject::lineBreaks): - (WebKit::WebAccessibilityObject::columnCount): - (WebKit::WebAccessibilityObject::rowCount): - (WebKit::WebAccessibilityObject::cellForColumnAndRow): - (WebKit::WebAccessibilityObject::cellColumnIndex): - (WebKit::WebAccessibilityObject::cellColumnSpan): - (WebKit::WebAccessibilityObject::cellRowIndex): - (WebKit::WebAccessibilityObject::cellRowSpan): - (WebKit::WebAccessibilityObject::scrollToMakeVisible): - (WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus): - (WebKit::WebAccessibilityObject::scrollToGlobalPoint): - -2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126914. - http://trac.webkit.org/changeset/126914 - https://bugs.webkit.org/show_bug.cgi?id=95239 - - it breaks everything and fixes nothing (Requested by pizlo on - #webkit). - - * src/WebGeolocationPermissionRequestManager.cpp: - (WebGeolocationPermissionRequestManager::remove): - * src/WebIDBMetadata.cpp: - (WebKit::WebIDBMetadata::WebIDBMetadata): - * src/WebIntent.cpp: - (WebKit::WebIntent::extrasValue): - * tests/WebSocketExtensionDispatcherTest.cpp: - (WebCore::TEST_F): - -2012-08-28 W. James MacLean <wjmaclean@chromium.org> - - [unreviewed] Compile fix: windows compiler expects float but find double. - - Need to specify a float literal when initialising the highlight animation duration. - - * src/LinkHighlight.cpp: - (WebKit::LinkHighlight::startHighlightAnimation): - -2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> - - Rename first/second to key/value in HashMap iterators - https://bugs.webkit.org/show_bug.cgi?id=82784 - - Reviewed by Eric Seidel. - - * src/WebGeolocationPermissionRequestManager.cpp: - (WebGeolocationPermissionRequestManager::remove): - * src/WebIDBMetadata.cpp: - (WebKit::WebIDBMetadata::WebIDBMetadata): - * src/WebIntent.cpp: - (WebKit::WebIntent::extrasValue): - * tests/WebSocketExtensionDispatcherTest.cpp: - (WebCore::TEST_F): - -2012-08-28 W. James MacLean <wjmaclean@chromium.org> - - [chromium] Drastically shorten the link highlight duration. - https://bugs.webkit.org/show_bug.cgi?id=95216 - - Reviewed by James Robinson. - - Parameter change; covered by existing layout tests. - - * src/LinkHighlight.cpp: - (WebKit::LinkHighlight::startHighlightAnimation): - -2012-08-27 Tien-Ren Chen <trchen@chromium.org> - - [Chromium] Remove stub for WebView::getTouchHighlightQuads() - https://bugs.webkit.org/show_bug.cgi?id=95164 - - Reviewed by Adam Barth. - - Reverts https://bugs.webkit.org/show_bug.cgi?id=92997 - We're uploading a new implementation that no longer uses this API. - See https://bugs.webkit.org/show_bug.cgi?id=94182 - - * WebKit.gyp: - * public/WebTouchCandidatesInfo.h: Removed. - * public/WebView.h: - (WebKit): - * src/WebViewImpl.cpp: - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-27 Ian Vollick <vollick@chromium.org> - - [chromium] Should accelerate rotations of >= 180 degrees - https://bugs.webkit.org/show_bug.cgi?id=94860 - - Reviewed by James Robinson. - - Added new unit tests: - WebTransformOperationTest.transformTypesAreUnique - WebTransformOperationTest.matchTypesSameLength - WebTransformOperationTest.identityAlwaysMatches - WebTransformOperationTest.largeRotationsWithSameAxis - WebTransformOperationTest.largeRotationsWithSameAxisInDifferentDirection - WebTransformOperationTest.largeRotationsWithDifferentAxes - WebTransformOperationTest.blendRotationFromIdentity - WebTransformOperationTest.blendTranslationFromIdentity - WebTransformOperationTest.blendScaleFromIdentity - WebTransformOperationTest.blendSkewFromIdentity - WebTransformOperationTest.blendPerspectiveFromIdentity - WebTransformOperationTest.blendRotationToIdentity - WebTransformOperationTest.blendTranslationToIdentity - WebTransformOperationTest.blendScaleToIdentity - WebTransformOperationTest.blendSkewToIdentity - WebTransformOperationTest.blendPerspectiveToIdentity - AnimationTranslationUtilTest.createTransformAnimationWithBigRotation - AnimationTranslationUtilTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList - - * tests/AnimationTranslationUtilTest.cpp: - (WebKit::TEST): - * tests/WebTransformOperationsTest.cpp: - (TEST): - (getIdentityOperations): - -2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126836. - http://trac.webkit.org/changeset/126836 - https://bugs.webkit.org/show_bug.cgi?id=95163 - - Broke all Apple ports, EFL, and Qt. (Requested by tkent on - #webkit). - - * src/WebGeolocationPermissionRequestManager.cpp: - (WebGeolocationPermissionRequestManager::remove): - * src/WebIDBMetadata.cpp: - (WebKit::WebIDBMetadata::WebIDBMetadata): - * src/WebIntent.cpp: - (WebKit::WebIntent::extrasValue): - * tests/WebSocketExtensionDispatcherTest.cpp: - (WebCore::TEST_F): - -2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> - - Rename first/second to key/value in HashMap iterators - https://bugs.webkit.org/show_bug.cgi?id=82784 - - Reviewed by Eric Seidel. - - * src/WebGeolocationPermissionRequestManager.cpp: - (WebGeolocationPermissionRequestManager::remove): - * src/WebIDBMetadata.cpp: - (WebKit::WebIDBMetadata::WebIDBMetadata): - * src/WebIntent.cpp: - (WebKit::WebIntent::extrasValue): - * tests/WebSocketExtensionDispatcherTest.cpp: - (WebCore::TEST_F): - -2012-08-27 David Reveman <reveman@chromium.org> - - [Chromium] Stop texture updates when context is lost. - https://bugs.webkit.org/show_bug.cgi?id=94983 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostTest.cpp: - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext): - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::create): - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::setContextLostCallback): - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::isContextLost): - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::beginQueryEXT): - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::endQueryEXT): - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::getQueryObjectuivEXT): - (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext): - (CCLayerTreeHostTestLostContextWhileUpdatingResources): - (CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources): - (CCLayerTreeHostTestLostContextWhileUpdatingResources::createOutputSurface): - (CCLayerTreeHostTestLostContextWhileUpdatingResources::beginTest): - (CCLayerTreeHostTestLostContextWhileUpdatingResources::commitCompleteOnCCThread): - (CCLayerTreeHostTestLostContextWhileUpdatingResources::layout): - (CCLayerTreeHostTestLostContextWhileUpdatingResources::afterTest): - (TEST_F): - -2012-08-27 Dana Jansens <danakj@chromium.org> - - [chromium] A general mechanism for passing data into and out of appendQuads and quadCuller via CCAppendQuadsData - https://bugs.webkit.org/show_bug.cgi?id=95109 - - Reviewed by Adrienne Walker. - - Update tests to use the new data structure. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - (CCLayerTestCommon::getQuads): - * tests/MockCCQuadCuller.h: - -2012-08-24 James Robinson <jamesr@chromium.org> - - [chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer - https://bugs.webkit.org/show_bug.cgi?id=94996 - - Reviewed by Adrienne Walker. - - Fix up tests for API changes. - - * WebKit.gyp: - * src/WebScrollbarLayerImpl.cpp: - (WebKit::WebScrollbarLayer::create): - * tests/ScrollbarLayerChromiumTest.cpp: - (WebCore::TEST): - -2012-08-27 Adrienne Walker <enne@google.com> - - [chromium] Prevent scrollbar thumb size from changing during compositor zoom - https://bugs.webkit.org/show_bug.cgi?id=94859 - - Reviewed by James Robinson. - - Update test. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-27 Dana Jansens <danakj@chromium.org> - - [chromium] Have RenderSurface create and add its own generated RenderPass - https://bugs.webkit.org/show_bug.cgi?id=94957 - - Reviewed by Adrienne Walker. - - Test that a RenderSurface generates the RenderPass that we expect. - - * tests/CCRenderSurfaceTest.cpp: - -2012-08-27 Justin Novosad <junov@chromium.org> - - [Chromium] Fixing infinite recursion in Canvas2DLayerManager - https://bugs.webkit.org/show_bug.cgi?id=95110 - - Reviewed by Stephen White. - - Breaking recursion cycle by not reporting a change in memory allocation - when no memory is freed in FakeCanvas2DLayer::freeMemoryIfPossible. - - * tests/Canvas2DLayerManagerTest.cpp: - -2012-08-27 Justin Novosad <junov@chromium.org> - - [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases - https://bugs.webkit.org/show_bug.cgi?id=94386 - - Reviewed by Stephen White. - - Adding unit tests for WebCore::Canvas2DLayerManager - - * WebKit.gypi: - -2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> - - Rename RegisterProtocolHandler API to NavigatorContentUtils - https://bugs.webkit.org/show_bug.cgi?id=94920 - - Reviewed by Adam Barth. - - Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed. - RegisterProtocolHandlerClientImpl is renamed to NavigatorContentUtilsClientImpl. - - * features.gypi: - * src/ChromeClientImpl.cpp: - (WebKit): - (WebKit::NavigatorContentUtilsClientImpl::create): - (WebKit::NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl): - (WebKit::NavigatorContentUtilsClientImpl::registerProtocolHandler): - * src/ChromeClientImpl.h: - (NavigatorContentUtilsClientImpl): - (WebKit::NavigatorContentUtilsClientImpl::~NavigatorContentUtilsClientImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - * src/WebViewImpl.h: - -2012-08-27 Johnny Ding <jnd@chromium.org> - - [Chromium-Android]Move webkit_unit_tests_apk and TestWebKitAPI_apk into a - condition block:['OS=="android" and gtest_target_type == "shared_library"']. - https://bugs.webkit.org/show_bug.cgi?id=95049 - - Reviewed by Adam Barth. - - Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library" - - * All.gyp: - -2012-08-24 Dominic Mazzoni <dmazzoni@google.com> - - Chromium: WebAccessibilityObject should expose updateBackingStore - https://bugs.webkit.org/show_bug.cgi?id=94611 - - Reviewed by Chris Fleizach. - - This change just exposes a method, with no new tests. Next, Chromium - will be modified to call this new method, and this will be followed - by a change that gets rid of calls to updateBackingStore under the - hood. That last change may add a test or update an existing test. - - * public/WebAccessibilityObject.h: - (WebAccessibilityObject): - * src/WebAccessibilityObject.cpp: - (WebKit::WebAccessibilityObject::updateBackingStoreAndCheckValidity): - (WebKit): - -2012-08-24 W. James MacLean <wjmaclean@chromium.org> - - [chromium] WebViewImpl::enableTouchHighlight() should always clear any existing highlight when invoked. - https://bugs.webkit.org/show_bug.cgi?id=94978 - - Reviewed by James Robinson. - - Modified WebViewImpl::enableTouchHighlight() so it always clears any existing highlight, even if no new - highlight target is found. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::enableTouchHighlight): - -2012-08-23 James Robinson <jamesr@chromium.org> - - [chromium] Convert WebLayerTreeView interface into pure virtual - https://bugs.webkit.org/show_bug.cgi?id=94866 - - Reviewed by Adrienne Walker. - - Updates WebLayerTreeView implementation and callers to new interface. The createGraphicsContext3D() wrapper - stuff can just go away now since downstream has updated to createOutputSurface(). - - * WebKit.gypi: - * src/WebLayerTreeView.cpp: Removed. - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeView::create): - (WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl): - (WebKit::WebLayerTreeViewImpl::initialize): - (WebKit): - (WebKit::WebLayerTreeViewImpl::setSurfaceReady): - (WebKit::WebLayerTreeViewImpl::setRootLayer): - (WebKit::WebLayerTreeViewImpl::clearRootLayer): - (WebKit::WebLayerTreeViewImpl::compositorIdentifier): - (WebKit::WebLayerTreeViewImpl::setViewportSize): - (WebKit::WebLayerTreeViewImpl::layoutViewportSize): - (WebKit::WebLayerTreeViewImpl::deviceViewportSize): - (WebKit::WebLayerTreeViewImpl::setDeviceScaleFactor): - (WebKit::WebLayerTreeViewImpl::deviceScaleFactor): - (WebKit::WebLayerTreeViewImpl::setBackgroundColor): - (WebKit::WebLayerTreeViewImpl::setHasTransparentBackground): - (WebKit::WebLayerTreeViewImpl::setVisible): - (WebKit::WebLayerTreeViewImpl::setPageScaleFactorAndLimits): - (WebKit::WebLayerTreeViewImpl::startPageScaleAnimation): - (WebKit::WebLayerTreeViewImpl::setNeedsAnimate): - (WebKit::WebLayerTreeViewImpl::setNeedsRedraw): - (WebKit::WebLayerTreeViewImpl::commitRequested): - (WebKit::WebLayerTreeViewImpl::composite): - (WebKit::WebLayerTreeViewImpl::updateAnimations): - (WebKit::WebLayerTreeViewImpl::compositeAndReadback): - (WebKit::WebLayerTreeViewImpl::finishAllRendering): - (WebKit::WebLayerTreeViewImpl::renderingStats): - (WebKit::WebLayerTreeViewImpl::setFontAtlas): - (WebKit::WebLayerTreeViewImpl::loseCompositorContext): - (WebKit::WebLayerTreeViewImpl::willBeginFrame): - (WebKit::WebLayerTreeViewImpl::didBeginFrame): - (WebKit::WebLayerTreeViewImpl::animate): - (WebKit::WebLayerTreeViewImpl::layout): - (WebKit::WebLayerTreeViewImpl::applyScrollAndScale): - (WebKit::WebLayerTreeViewImpl::createOutputSurface): - (WebKit::WebLayerTreeViewImpl::didRecreateOutputSurface): - (WebKit::WebLayerTreeViewImpl::willCommit): - (WebKit::WebLayerTreeViewImpl::didCommit): - (WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame): - (WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers): - (WebKit::WebLayerTreeViewImpl::scheduleComposite): - * src/WebLayerTreeViewImpl.h: - (WebLayerTreeViewImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::renderingStats): - (WebKit::WebViewImpl::startPageScaleAnimation): - (WebKit::WebViewImpl::setCompositorSurfaceReady): - (WebKit::WebViewImpl::animate): - (WebKit::WebViewImpl::doPixelReadbackToCanvas): - (WebKit::WebViewImpl::paint): - (WebKit::WebViewImpl::composite): - (WebKit::WebViewImpl::setNeedsRedraw): - (WebKit::WebViewImpl::isInputThrottled): - (WebKit::WebViewImpl::loseCompositorContext): - (WebKit::WebViewImpl::setDeviceScaleFactor): - (WebKit::WebViewImpl::computePageScaleFactorLimits): - (WebKit::WebViewImpl::setIsTransparent): - (WebKit::WebViewImpl::setRootGraphicsLayer): - (WebKit::WebViewImpl::scheduleCompositingLayerSync): - (WebKit::WebViewImpl::invalidateRootLayerRect): - (WebKit::WebViewImpl::setBackgroundColor): - (WebKit::WebViewImpl::scheduleAnimation): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - (WebKit::WebViewImpl::updateLayerTreeViewport): - (WebKit::WebViewImpl::setVisibilityState): - * src/WebViewImpl.h: - (WebKit): - * tests/CCLayerTreeHostTest.cpp: - * tests/CCThreadedTest.cpp: - * tests/CCThreadedTest.h: - (WebKitTests::TestHooks::animate): - * tests/FakeCCLayerTreeHostClient.h: - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): - (GraphicsLayerChromiumTest): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - * tests/WebLayerTreeViewTestCommon.h: - (MockWebLayerTreeViewClient): - -2012-08-24 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-24 James Robinson <jamesr@chromium.org> - - [chromium] Clean up WebAnimation animationId/groupId generation - https://bugs.webkit.org/show_bug.cgi?id=94973 - - Reviewed by Adrienne Walker. - - * src/WebAnimationImpl.cpp: - (WebKit::WebAnimation::create): - (WebKit::WebAnimationImpl::WebAnimationImpl): - (WebKit::WebAnimationImpl::id): - (WebKit): - * src/WebAnimationImpl.h: - (WebAnimationImpl): - * tests/AnimationTranslationUtilTest.cpp: - (WebKit::animationCanBeTranslated): - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit::TEST_F): - -2012-08-24 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Remove visitedLinkHash from PlatformSupport - https://bugs.webkit.org/show_bug.cgi?id=94965 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-08-24 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126620. - http://trac.webkit.org/changeset/126620 - https://bugs.webkit.org/show_bug.cgi?id=94976 - - ASSERT((intptr_t)m_bytesAllocated + deltaBytes > 0) is - triggering on the bots (Requested by jchaffraix on #webkit). - - * WebKit.gypi: - * tests/Canvas2DLayerManagerTest.cpp: Removed. - -2012-08-24 Justin Novosad <junov@chromium.org> - - [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases - https://bugs.webkit.org/show_bug.cgi?id=94386 - - Reviewed by Stephen White. - - Adding unit tests for WebCore::Canvas2DLayerManager - - * WebKit.gypi: - * tests/Canvas2DLayerManagerTest.cpp: Added. - (FakeCanvas2DLayerBridge): - (FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge): - (FakeCanvas2DLayerBridge::fakeFreeableBytes): - (Canvas2DLayerManagerTest): - (Canvas2DLayerManagerTest::storageAllocationTrackingTest): - (Canvas2DLayerManagerTest::evictionTest): - (Canvas2DLayerManagerTest::flushEvictionTest): - -2012-08-24 Cris Neckar <cdn@chromium.org> - - Plumb consumeUserGesture() to the chromium platform layer. - https://bugs.webkit.org/show_bug.cgi?id=9475294867 - - Reviewed by Adam Barth. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::consumeUserGesture): - (WebKit): - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-08-24 W. James MacLean <wjmaclean@chromium.org> - - [chromium] gestureTapDown should not select a RenderView node as target. - https://bugs.webkit.org/show_bug.cgi?id=94956 - - Reviewed by James Robinson. - - Add check to prevent selecting a RenderView node as a highlight target. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::bestTouchLinkNode): - -2012-08-24 Tommy Widenflycht <tommyw@google.com> - - MediaStream API: Add readyState functionality to RTCPeerConnection - https://bugs.webkit.org/show_bug.cgi?id=94813 - - Reviewed by Adam Barth. - - * src/AssertMatchingEnums.cpp: - -2012-08-24 Dan Carney <dcarney@google.com> - - [V8] Refactor away IsolatedWorld - https://bugs.webkit.org/show_bug.cgi?id=93971 - - Reviewed by Kentaro Hara. - - Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld. - - * src/WebViewImpl.cpp: - (WebKit::WebView::addUserScript): - (WebKit::WebView::addUserStyleSheet): - -2012-08-23 Antoine Labour <piman@chromium.org> - - [chromium] Fix lost context when textures are evicted - https://bugs.webkit.org/show_bug.cgi?id=94892 - - Reviewed by James Robinson. - - After eviction, the CCPrioritizedTextureManager is in a limbo state - where all its resources are invalid. If we try to release them we will - double-destroy them. - - New test: CCLayerTreeHostTestLostContextAfterEvictTextures. - - * tests/CCLayerTreeHostTest.cpp: - (CCLayerTreeHostTestLostContextAfterEvictTextures): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest): - (EvictTexturesAndLoseContextTask): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface): - (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest): - (WTF): - (WTF::TEST_F): - -2012-08-23 Antoine Labour <piman@chromium.org> - - [chromium] Add OVERRIDEs in test code - https://bugs.webkit.org/show_bug.cgi?id=94894 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostTest.cpp: - -2012-08-23 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Expose mechanism for database to force a connection to close - https://bugs.webkit.org/show_bug.cgi?id=91010 - - Reviewed by Tony Chang. - - In Chromium, the browsing data deleter has a WebIDBDatabase handle which - it can use to terminate a connection. This handles forcefully closing - the front end connections and the back end, to unblock disk cleanup. - - * public/WebIDBDatabase.h: - (WebKit::WebIDBDatabase::forceClose): Entry point. - * public/WebIDBDatabaseCallbacks.h: - (WebKit::WebIDBDatabaseCallbacks::onForcedClose): Plumbing back to front. - * src/IDBDatabaseCallbacksProxy.cpp: - (WebKit::IDBDatabaseCallbacksProxy::onForcedClose): Plumbing back to front. - (WebKit): - * src/IDBDatabaseCallbacksProxy.h: - (IDBDatabaseCallbacksProxy): Plumbing. - * src/WebIDBDatabaseCallbacksImpl.cpp: - (WebKit::WebIDBDatabaseCallbacksImpl::onForcedClose): Plumbing back to front. - (WebKit): - * src/WebIDBDatabaseCallbacksImpl.h: - (WebIDBDatabaseCallbacksImpl): Plumbing back to front. - * src/WebIDBDatabaseImpl.cpp: - (WebKit::WebIDBDatabaseImpl::close): Tidy up dropping the callback reference. - (WebKit): - (WebKit::WebIDBDatabaseImpl::forceClose): Terminate the connection by notifying - the back end and the front end, while avoid re-entrant badness. - * src/WebIDBDatabaseImpl.h: Header tweak for unit test. - (WebIDBDatabaseImpl): - * tests/IDBDatabaseBackendTest.cpp: Added unit test to exercise connections. - -2012-08-23 James Robinson <jamesr@chromium.org> - - [chromium] Convert WebAnimationCurve subtypes into pure virtual - https://bugs.webkit.org/show_bug.cgi?id=94068 - - Reviewed by Adrienne Walker. - - Updates the implementations, some callers and tests of Web*AnimationCurve to its new interface. - - * WebKit.gyp: - * src/WebAnimation.cpp: - (WebKit::WebAnimation::initialize): - * src/WebFloatAnimationCurveImpl.cpp: Renamed from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp. - (WebKit): - (WebKit::WebFloatAnimationCurve::create): - (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl): - (WebKit::WebFloatAnimationCurveImpl::~WebFloatAnimationCurveImpl): - (WebKit::WebFloatAnimationCurveImpl::type): - (WebKit::WebFloatAnimationCurveImpl::add): - (WebKit::WebFloatAnimationCurveImpl::getValue): - (WebKit::WebFloatAnimationCurveImpl::cloneToCCAnimationCurve): - * src/WebTransformAnimationCurve.cpp: Removed. - * tests/WebAnimationTest.cpp: - (WebKit::TEST): - * tests/WebFloatAnimationCurveTest.cpp: - (WebKit::TEST): - * tests/WebTransformAnimationCurveTest.cpp: - (WebKit::TEST): - -2012-08-23 Kentaro Hara <haraken@chromium.org> - - [V8] Remove V8Proxy.{h,cpp} - https://bugs.webkit.org/show_bug.cgi?id=94794 - - Reviewed by Dimitri Glazkov. - - Now V8Proxy is no longer used. We can completely remove V8Proxy from the codebase. - - No tests. No change in behavior. - - * src/ChromeClientImpl.cpp: - * src/WebBindings.cpp: - * src/WebDOMMessageEvent.cpp: - * src/WebDevToolsAgentImpl.cpp: - * src/WebMediaPlayerClientImpl.cpp: - -2012-08-23 Dana Jansens <danakj@chromium.org> - - [chromium] Don't require a RenderSurface* in order to create a RenderPass - https://bugs.webkit.org/show_bug.cgi?id=94862 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCRendererGLTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - -2012-08-22 James Robinson <jamesr@chromium.org> - - [chromium] Remove WebLayer::setChildren API - https://bugs.webkit.org/show_bug.cgi?id=94749 - - Reviewed by Adrienne Walker. - - * src/WebLayer.cpp: - -2012-08-23 Dana Jansens <danakj@chromium.org> - - [chromium] Create sharedQuadState at same time as creating quads and give them to the quadSink - https://bugs.webkit.org/show_bug.cgi?id=94752 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::EvictionTestLayerImpl::appendQuads): - * tests/CCQuadCullerTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - (CCLayerTestCommon::getQuads): - (CCLayerTestCommon::coverageVisibleRectOnTileBoundaries): - (CCLayerTestCommon::coverageVisibleRectIntersectsTiles): - (CCLayerTestCommon::coverageVisibleRectIntersectsBounds): - * tests/MockCCQuadCuller.h: - (WebCore::MockCCQuadCuller::MockCCQuadCuller): - (MockCCQuadCuller): - (WebCore::MockCCQuadCuller::quadList): - (WebCore::MockCCQuadCuller::sharedQuadStateList): - -2012-08-23 Pavel Feldman <pfeldman@chromium.org> - - Not reviewed - fixing input list for timeline inspector module. - https://bugs.webkit.org/show_bug.cgi?id=94829 - - * WebKit.gyp: - -2012-08-23 Alexandre Elias <aelias@chromium.org> - - [chromium] Rename LayerRendererChromium to GL-specific name - https://bugs.webkit.org/show_bug.cgi?id=94835 - - Reviewed by James Robinson. - - Over time, LayerRendererChromium has evolved to be a GL-specific - subclass of CCRenderer that has no awareness of layers (as it operates - only with drawQuads). - - This patch renames LayerRendererChromium to CCRendererGL, replaces all - instances of "layerRenderer" with just "renderer", and removes a - few unnecessary includes of LayerRendererChromium.h. - - * WebKit.gypi: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): - (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): - (WTF::CCLayerTreeHostTestManySurfaces::beginTest): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread): - * tests/CCRendererGLTest.cpp: Renamed from Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp. - (FrameCountingMemoryAllocationSettingContext): - (FrameCountingMemoryAllocationSettingContext::FrameCountingMemoryAllocationSettingContext): - (FrameCountingMemoryAllocationSettingContext::prepareTexture): - (FrameCountingMemoryAllocationSettingContext::setMemoryAllocationChangedCallbackCHROMIUM): - (FrameCountingMemoryAllocationSettingContext::getString): - (FrameCountingMemoryAllocationSettingContext::frameCount): - (FrameCountingMemoryAllocationSettingContext::setMemoryAllocation): - (FakeCCRendererClient): - (FakeCCRendererClient::FakeCCRendererClient): - (FakeCCRendererClient::setFullRootLayerDamageCount): - (FakeCCRendererClient::rootRenderPass): - (FakeCCRendererClient::renderPassesInDrawOrder): - (FakeCCRendererClient::renderPasses): - (FakeCCRendererClient::memoryAllocationLimitBytes): - (FakeCCRendererGL): - (FakeCCRendererGL::FakeCCRendererGL): - (CCRendererGLTest): - (CCRendererGLTest::CCRendererGLTest): - (CCRendererGLTest::SetUp): - (CCRendererGLTest::TearDown): - (CCRendererGLTest::swapBuffers): - (CCRendererGLTest::context): - (TEST_F): - (ForbidSynchronousCallContext): - (ForbidSynchronousCallContext::ForbidSynchronousCallContext): - (ForbidSynchronousCallContext::getActiveAttrib): - (ForbidSynchronousCallContext::getActiveUniform): - (ForbidSynchronousCallContext::getAttachedShaders): - (ForbidSynchronousCallContext::getAttribLocation): - (ForbidSynchronousCallContext::getBooleanv): - (ForbidSynchronousCallContext::getBufferParameteriv): - (ForbidSynchronousCallContext::getContextAttributes): - (ForbidSynchronousCallContext::getError): - (ForbidSynchronousCallContext::getFloatv): - (ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv): - (ForbidSynchronousCallContext::getIntegerv): - (ForbidSynchronousCallContext::getProgramiv): - (ForbidSynchronousCallContext::getShaderiv): - (ForbidSynchronousCallContext::getString): - (ForbidSynchronousCallContext::getProgramInfoLog): - (ForbidSynchronousCallContext::getRenderbufferParameteriv): - (ForbidSynchronousCallContext::getShaderInfoLog): - (ForbidSynchronousCallContext::getShaderPrecisionFormat): - (ForbidSynchronousCallContext::getShaderSource): - (ForbidSynchronousCallContext::getTexParameterfv): - (ForbidSynchronousCallContext::getTexParameteriv): - (ForbidSynchronousCallContext::getUniformfv): - (ForbidSynchronousCallContext::getUniformiv): - (ForbidSynchronousCallContext::getUniformLocation): - (ForbidSynchronousCallContext::getVertexAttribfv): - (ForbidSynchronousCallContext::getVertexAttribiv): - (ForbidSynchronousCallContext::getVertexAttribOffset): - (TEST): - (LoseContextOnFirstGetContext): - (LoseContextOnFirstGetContext::LoseContextOnFirstGetContext): - (ContextThatDoesNotSupportMemoryManagmentExtensions): - (ContextThatDoesNotSupportMemoryManagmentExtensions::ContextThatDoesNotSupportMemoryManagmentExtensions): - (ContextThatDoesNotSupportMemoryManagmentExtensions::prepareTexture): - (ContextThatDoesNotSupportMemoryManagmentExtensions::setMemoryAllocationChangedCallbackCHROMIUM): - (ContextThatDoesNotSupportMemoryManagmentExtensions::getString): - (ClearCountingContext): - (ClearCountingContext::ClearCountingContext): - (ClearCountingContext::clear): - (ClearCountingContext::clearCount): - * tests/TiledLayerChromiumTest.cpp: - -2012-08-23 Stephen White <senorblanco@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-23 Wei Jia <wjia@chromium.org> - - create different WebKit::WebMediaPlayer based on URL - https://bugs.webkit.org/show_bug.cgi?id=91301 - - Reviewed by Adam Barth. - - Pass URL to WebFrameClient::createMediaPlayer(). This allows creation - of different WebMediaPlayer implementations based on the URL. - - * public/WebFrameClient.h: - (WebKit::WebFrameClient::createMediaPlayer): add URL as additional argument. - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::createWebMediaPlayer): add URL as additional argument. - (WebKit::WebMediaPlayerClientImpl::loadInternal): - -2012-08-23 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest - https://bugs.webkit.org/show_bug.cgi?id=94757 - - Reviewed by Tony Chang. - - Drop onSuccess(IDBDatabaseBackendImpl) overload from test, as it is no longer - implemented by IDBRequest. - - * tests/IDBRequestTest.cpp: - (WebCore::TEST): - -2012-08-23 Kenneth Russell <kbr@google.com> - - Convert ScrollableArea ASSERT_NOT_REACHED virtuals into pure virtuals - https://bugs.webkit.org/show_bug.cgi?id=93306 - - Unreviewed build fix. - - * src/ScrollbarGroup.h: - -2012-08-23 Adrienne Walker <enne@google.com> - - Convert ScrollableArea ASSERT_NOT_REACHED virtuals - https://bugs.webkit.org/show_bug.cgi?id=93306 - - Reviewed by Darin Adler. - - Add implementations where necessary to make derived classes concrete. - Add OVERRIDE for ScrollableArea functions. - - * src/ScrollbarGroup.h: - (ScrollbarGroup): - (WebKit::ScrollbarGroup::scrollCornerRect): - * tests/ScrollAnimatorNoneTest.cpp: - (MockScrollableArea): - -2012-08-23 David Reveman <reveman@chromium.org> - - [Chromium] Unnecessary delay when starting to update resources with an inactive vsync timer. - https://bugs.webkit.org/show_bug.cgi?id=94719 - - Reviewed by James Robinson. - - * tests/CCSchedulerTestCommon.h: - -2012-08-23 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-22 Alec Flett <alecflett@chromium.org> - - IndexedDB: tests for injection/extraction of idb keys - https://bugs.webkit.org/show_bug.cgi?id=94653 - - Reviewed by Tony Chang. - - Added unit tests for key injection/extraction using - SerializedScriptValue. These were moved from chromium, now - that all uses of the API are through WebKit. - - * tests/IDBKeyPathTest.cpp: - (WebCore): - (WebCore::TEST): - -2012-08-22 James Robinson <jamesr@chromium.org> - - [chromium] Change WebLayer from a concrete type to a pure virtual interface - https://bugs.webkit.org/show_bug.cgi?id=94174 - - Reviewed by Adrienne Walker. - - This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl / - NonCompositedContentHost / LinkHighlight. - - * WebKit.gypi: - * src/LinkHighlight.cpp: - (WebKit::LinkHighlight::LinkHighlight): - (WebKit::LinkHighlight::contentLayer): - (WebKit::LinkHighlight::clipLayer): - (WebKit::LinkHighlight::releaseResources): - (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): - (WebKit::LinkHighlight::startHighlightAnimation): - (WebKit::LinkHighlight::updateGeometry): - * src/LinkHighlight.h: - (LinkHighlight): - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - (WebKit::NonCompositedContentHost::setScrollLayer): - (WebKit::NonCompositedContentHost::setViewport): - (WebKit::NonCompositedContentHost::scrollLayer): - * src/NonCompositedContentHost.h: - * src/WebContentLayer.cpp: Removed. - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayer::create): - (WebKit::WebContentLayerImpl::WebContentLayerImpl): - (WebKit::WebContentLayerImpl::~WebContentLayerImpl): - (WebKit::WebContentLayerImpl::layer): - (WebKit): - (WebKit::WebContentLayerImpl::setDoubleSided): - (WebKit::WebContentLayerImpl::setContentsScale): - (WebKit::WebContentLayerImpl::setUseLCDText): - (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): - (WebKit::WebContentLayerImpl::paintContents): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp. - (WebKit): - (WebKit::WebExternalTextureLayer::create): - (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::layer): - (WebKit::WebExternalTextureLayerImpl::setTextureId): - (WebKit::WebExternalTextureLayerImpl::setFlipped): - (WebKit::WebExternalTextureLayerImpl::setUVRect): - (WebKit::WebExternalTextureLayerImpl::setOpaque): - (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha): - (WebKit::WebExternalTextureLayerImpl::willModifyTexture): - (WebKit::WebExternalTextureLayerImpl::setRateLimitContext): - (WebTextureUpdaterImpl): - (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): - (WebKit::WebExternalTextureLayerImpl::prepareTexture): - (WebKit::WebExternalTextureLayerImpl::context): - * src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h. - (WebKit): - (WebExternalTextureLayerImpl): - * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp. - (WebKit): - (WebKit::WebIOSurfaceLayer::create): - (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): - (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl): - (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties): - (WebKit::WebIOSurfaceLayerImpl::layer): - * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h. - (WebCore): - (WebKit): - (WebIOSurfaceLayerImpl): - * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp. - (WebKit): - (WebKit::WebImageLayer::create): - (WebKit::WebImageLayerImpl::WebImageLayerImpl): - (WebKit::WebImageLayerImpl::~WebImageLayerImpl): - (WebKit::WebImageLayerImpl::layer): - (WebKit::WebImageLayerImpl::setBitmap): - * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp. - (WebCore): - (WebKit): - (WebImageLayerImpl): - * src/WebLayer.cpp: Removed. - * src/WebLayerImpl.cpp: - (WebKit::WebLayer::create): - (WebKit::WebLayerImpl::WebLayerImpl): - (WebKit::WebLayerImpl::~WebLayerImpl): - (WebKit): - (WebKit::WebLayerImpl::id): - (WebKit::WebLayerImpl::invalidateRect): - (WebKit::WebLayerImpl::invalidate): - (WebKit::WebLayerImpl::addChild): - (WebKit::WebLayerImpl::insertChild): - (WebKit::WebLayerImpl::replaceChild): - (WebKit::WebLayerImpl::setChildren): - (WebKit::WebLayerImpl::removeFromParent): - (WebKit::WebLayerImpl::removeAllChildren): - (WebKit::WebLayerImpl::setAnchorPoint): - (WebKit::WebLayerImpl::anchorPoint): - (WebKit::WebLayerImpl::setAnchorPointZ): - (WebKit::WebLayerImpl::anchorPointZ): - (WebKit::WebLayerImpl::setBounds): - (WebKit::WebLayerImpl::bounds): - (WebKit::WebLayerImpl::setMasksToBounds): - (WebKit::WebLayerImpl::masksToBounds): - (WebKit::WebLayerImpl::setMaskLayer): - (WebKit::WebLayerImpl::setReplicaLayer): - (WebKit::WebLayerImpl::setOpacity): - (WebKit::WebLayerImpl::opacity): - (WebKit::WebLayerImpl::setOpaque): - (WebKit::WebLayerImpl::opaque): - (WebKit::WebLayerImpl::setPosition): - (WebKit::WebLayerImpl::position): - (WebKit::WebLayerImpl::setSublayerTransform): - (WebKit::WebLayerImpl::sublayerTransform): - (WebKit::WebLayerImpl::setTransform): - (WebKit::WebLayerImpl::transform): - (WebKit::WebLayerImpl::setDrawsContent): - (WebKit::WebLayerImpl::drawsContent): - (WebKit::WebLayerImpl::setPreserves3D): - (WebKit::WebLayerImpl::setUseParentBackfaceVisibility): - (WebKit::WebLayerImpl::setBackgroundColor): - (WebKit::WebLayerImpl::setFilters): - (WebKit::WebLayerImpl::setBackgroundFilters): - (WebKit::WebLayerImpl::setDebugBorderColor): - (WebKit::WebLayerImpl::setDebugBorderWidth): - (WebKit::WebLayerImpl::setDebugName): - (WebKit::WebLayerImpl::setAnimationDelegate): - (WebKit::WebLayerImpl::addAnimation): - (WebKit::WebLayerImpl::removeAnimation): - (WebKit::WebLayerImpl::pauseAnimation): - (WebKit::WebLayerImpl::suspendAnimations): - (WebKit::WebLayerImpl::resumeAnimations): - (WebKit::WebLayerImpl::hasActiveAnimation): - (WebKit::WebLayerImpl::transferAnimationsTo): - (WebKit::WebLayerImpl::setForceRenderSurface): - (WebKit::WebLayerImpl::setScrollPosition): - (WebKit::WebLayerImpl::setScrollable): - (WebKit::WebLayerImpl::setHaveWheelEventHandlers): - (WebKit::WebLayerImpl::setShouldScrollOnMainThread): - (WebKit::WebLayerImpl::setNonFastScrollableRegion): - (WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers): - (WebKit::WebLayerImpl::setFixedToContainerLayer): - (WebKit::WebLayerImpl::layer): - * src/WebLayerImpl.h: - (WebCore): - (WebLayerImpl): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setRootLayer): - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::create): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - (WebKit::WebMediaPlayerClientImpl::repaint): - (WebKit::WebMediaPlayerClientImpl::setOpaque): - (WebKit::WebMediaPlayerClientImpl::platformLayer): - (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - (WebKit::WebPluginContainerImpl::commitBackingTexture): - (WebKit::WebPluginContainerImpl::setOpaque): - (WebKit::WebPluginContainerImpl::platformLayer): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - * src/WebScrollableLayer.cpp: Removed. - * src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp. - (WebKit): - (WebKit::WebScrollbarLayer::create): - (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): - (WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl): - (WebKit::WebScrollbarLayerImpl::layer): - (WebKit::WebScrollbarLayerImpl::setScrollLayer): - * src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h. - (WebCore): - (WebKit): - (WebScrollbarLayerImpl): - * src/WebSolidColorLayerImpl.cpp: - (WebKit::WebSolidColorLayer::create): - (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): - (WebKit::WebSolidColorLayerImpl::layer): - (WebKit): - (WebKit::WebSolidColorLayerImpl::setBackgroundColor): - * src/WebSolidColorLayerImpl.h: - (WebCore): - (WebKit): - (WebSolidColorLayerImpl): - * src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp. - (WebKit): - (WebKit::WebVideoLayer::create): - (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): - (WebKit::WebVideoLayerImpl::~WebVideoLayerImpl): - (WebKit::WebVideoLayerImpl::layer): - (WebKit::WebVideoLayerImpl::active): - * src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp. - (WebCore): - (WebKit): - (WebVideoLayerImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setRootGraphicsLayer): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - * src/WebViewImpl.h: - * tests/ImageLayerChromiumTest.cpp: - (WebCore::TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-22 Alejandro Piñeiro <apinheiro@igalia.com> - - Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON - https://bugs.webkit.org/show_bug.cgi?id=73819 - - Reviewed by Chris Fleizach. - - Added a new role, Toggle Button, based on whether aria-pressed is present. - http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed - - * public/WebAccessibilityRole.h: added WebAccessibilityRoleToggleButton that - matchs with WebCore ToggleButtonRole - * src/AssertMatchingEnums.cpp: added the assert matching rule for - WebAccessibilityRoleToggleButton and ToggleButtonRole - -2012-08-17 Jeffrey Pfau <jpfau@apple.com> - - Allow blocking of Web SQL databases in third-party web workers - https://bugs.webkit.org/show_bug.cgi?id=94170 - - Reviewed by Adam Barth. - - Web workers did not previously know anything about the document that - spawned them. This is undefined for shared workers, but for dedicated - workers, we now pipe the information through. - - - * src/WebWorkerClientImpl.cpp: - (WebKit::WebWorkerClientImpl::startWorkerContext): Pass top document's origin - -2012-08-22 Kentaro Hara <haraken@chromium.org> - - [V8] Move context() from V8Proxy to ScriptController - https://bugs.webkit.org/show_bug.cgi?id=94593 - - Reviewed by Adam Barth. - - To kill V8Proxy, we can move context() from V8Proxy to ScriptController. - - No tests. No change in behavior. - - * src/InspectorFrontendClientImpl.cpp: - (WebKit::InspectorFrontendClientImpl::windowObjectCleared): - * src/WebDevToolsFrontendImpl.cpp: - (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): - -2012-08-22 Nikhil Bhargava <nbhargava@google.com> - - Reduce Font.h includes across project -- improves RenderObject.h compile time - https://bugs.webkit.org/show_bug.cgi?id=93629 - - Reviewed by Eric Seidel. - - Adds includes due to change in RenderStyle.h - - * src/WebFrameImpl.cpp: - * src/mac/WebSubstringUtil.mm: - -2012-08-22 Nikhil Bhargava <nbhargava@google.com> - - Speed up compilation of tests involving WebTransformationMatrix - https://bugs.webkit.org/show_bug.cgi?id=94639 - - Reviewed by James Robinson. - - EXPECT_TRANSFORMATION_MATRIX_EQ was changed to become mainly a function. - As a macro that expanded into 16 other macros, it caused an unneeded - slow down of close to 45s in the compile time of CCLayerTreeHostCommonTest - Bugs have been filed to clang and gcc noting the errant behavior: - http://llvm.org/bugs/show_bug.cgi?id=13651 and http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54337 - - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeTestCommon.h: - (WebKitTests): - (WebKitTests::ExpectTransformationMatrixEq): - * tests/WebTransformOperationsTest.cpp: - (TEST): - (checkProgress): - * tests/WebTransformationMatrixTest.cpp: - (WebKit::TEST): - -2012-08-22 Alexandre Elias <aelias@google.com> - - [chromium] Add software bitmap resources to CCResourceProvider - https://bugs.webkit.org/show_bug.cgi?id=93677 - - Reviewed by Adrienne Walker. - - Second commit after revert. - - This adds the ability to CCResourceProvider to use software bitmaps. - They are allocated as plain-old-memory, and exposed as Skia objects. - - We want the ResourceProvider to be able to handle different resource - types at the same time. In practice, a default resource type is - desired for most uses within a single compositor instance, which is - specified by the default resource type. Default resource types are - expected to be mostly 1-to-1 with CCRenderer types. - - New tests added by parametrizing existing CCResourceProvider tests. - - * tests/CCResourceProviderTest.cpp: - (WebKit::CCResourceProviderTest::getResourcePixels): - -2012-08-22 W. James MacLean <wjmaclean@chromium.org> - - [chromium] Add touch link highlight animation layers. - https://bugs.webkit.org/show_bug.cgi?id=84487 - - Reviewed by James Robinson. - - Adds support for creating composited touch link highlights in renderer thread. Clipping not yet - implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported. - Transform support currently limited to translation. - - Unit tests for LinkHighlight revised. - - * WebKit.gyp: - * src/LinkHighlight.cpp: Added. - (WebKit): - (WebKit::LinkHighlight::create): - (WebKit::LinkHighlight::LinkHighlight): - (WebKit::LinkHighlight::~LinkHighlight): - (WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight. - (WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight. - (WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers. - (WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to. - (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates. - (WebKit::LinkHighlight::paintContents): If highlight active, paints highlight. - (WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation. - (WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium. - (WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate. - (WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes. - (WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position. - Computations proceed only if preceded by call to invalidate(). - (WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid. - (WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout(). - (WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium. - * src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h. - (WebCore): - (WebKit): - (LinkHighlight): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - (WebKit): - (WebKit::highlightConditions): - (WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location. - (WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location. - (WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry(). - * src/WebViewImpl.h: - (WebKit): - (WebViewImpl): - (WebKit::WebViewImpl::linkHighlight): - * tests/LinkHighlightTest.cpp: - (WebCore): - (WebCore::TEST): - * tests/data/test_touch_link_highlight.html: Added. - -2012-08-22 Adam Barth <abarth@webkit.org> - - WebWidget should be able to paint into a zoomed canvas without aliasing - https://bugs.webkit.org/show_bug.cgi?id=92043 - - Reviewed by James Robinson. - - If accelerated compositing is enabled, WebWidget::paint reads back from - the compositor rather than re-painting the widget. That approach works - well if the canvas we're rendering into is at a similar resolution to - the pixels in the compositor, but if the canvas has been scaled (e.g., - to help the user disambiguate links), then reading back from the - compositor will cause aliasing artifacts. - - This patch adds an option to paint to let the embedder request a - software re-rendering of the widget to avoid these aliasing artifacts. - - * public/WebWidget.h: - (WebKit::WebWidget::paint): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::paint): - * src/WebPagePopupImpl.h: - (WebPagePopupImpl): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::paint): - * src/WebPopupMenuImpl.h: - * src/WebViewImpl.cpp: - (WebKit::canvasBackgroundForTransparencey): - (WebKit): - (WebKit::WebViewImpl::paint): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-22 Eric Penner <epenner@google.com> - - [chromium] Simplify updateContentRect, removing rect parameter, refactor unit tests. - https://bugs.webkit.org/show_bug.cgi?id=94165 - - Reviewed by Adrienne Walker. - - Refactored tests to remove lots of boilerplate code. - - * tests/CCTiledLayerTestCommon.cpp: - * tests/CCTiledLayerTestCommon.h: - (FakeTiledLayerChromium): - * tests/TiledLayerChromiumTest.cpp: - -2012-08-22 Iain Merrick <husky@chromium.org> - - [chromium] Remove WebFrame::setSelectionToRange - https://bugs.webkit.org/show_bug.cgi?id=94685 - - Reviewed by Adam Barth. - - It has basically the same functionality as WebFrame::selectRange. - The calling code was removed in Chromium patch 152608. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-08-22 Kenneth Russell <kbr@google.com> - - Unreviewed, rolling out r126319. - http://trac.webkit.org/changeset/126319 - https://bugs.webkit.org/show_bug.cgi?id=84487 - - Broke Chromium Mac build - - * WebKit.gyp: - * src/LinkHighlight.cpp: Removed. - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - (WebKit::WebViewImpl::computeScaleAndScrollForHitRect): - (WebKit::WebViewImpl::layout): - * src/WebViewImpl.h: - (WebKit): - (WebViewImpl): - * tests/LinkHighlightTest.cpp: - * tests/data/test_touch_link_highlight.html: Removed. - -2012-08-22 W. James MacLean <wjmaclean@chromium.org> - - [chromium] Add touch link highlight animation layers. - https://bugs.webkit.org/show_bug.cgi?id=84487 - - Reviewed by James Robinson. - - Adds support for creating composited touch link highlights in renderer thread. Clipping not yet - implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported. - Transform support currently limited to translation. - - Unit tests for LinkHighlight revised. - - * WebKit.gyp: - * src/LinkHighlight.cpp: Added. - (WebKit): - (WebKit::LinkHighlight::create): - (WebKit::LinkHighlight::LinkHighlight): - (WebKit::LinkHighlight::~LinkHighlight): - (WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight. - (WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight. - (WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers. - (WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to. - (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates. - (WebKit::LinkHighlight::paintContents): If highlight active, paints highlight. - (WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation. - (WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium. - (WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate. - (WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes. - (WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position. - Computations proceed only if preceded by call to invalidate(). - (WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid. - (WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout(). - (WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium. - * src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h. - (WebCore): - (WebKit): - (LinkHighlight): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - (WebKit): - (WebKit::highlightConditions): - (WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location. - (WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location. - (WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry(). - * src/WebViewImpl.h: - (WebKit): - (WebViewImpl): - (WebKit::WebViewImpl::linkHighlight): - * tests/LinkHighlightTest.cpp: - (WebCore): - (WebCore::TEST): - * tests/data/test_touch_link_highlight.html: Added. - -2012-08-22 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-21 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126202. - http://trac.webkit.org/changeset/126202 - https://bugs.webkit.org/show_bug.cgi?id=94657 - - Causes assertion failures on Chromium Linux dbg compositing - layout tests (Requested by dominicc on #webkit). - - * tests/CCResourceProviderTest.cpp: - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - (WebKit::CCResourceProviderTest::getResourcePixels): - (WebKit::TEST_F): - -2012-08-21 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Find-in-page coordinates should use containingBlock - https://bugs.webkit.org/show_bug.cgi?id=94343 - - Reviewed by Julien Chaffraix. - - The current implementation uses the container method to climb the render tree. - However, it would be more correct and convenient to use containingBlock instead. - Also, this patch introduces new tests for find-in-page coordinates in tables. - - * src/FindInPageCoordinates.cpp: - (WebKit::toNormalizedRect): use containingBlock and get rid of the output parameter as it's not required now. - (WebKit::findInPageRectFromAbsoluteRect): use containingBlock introduce some simplifications. - * tests/WebFrameTest.cpp: add new tests for tables. - * tests/data/find_in_page.html: - * tests/data/find_in_page_frame.html: new tests for tables. - -2012-08-21 Alexandre Elias <aelias@google.com> - - [chromium] Add software bitmap resources to CCResourceProvider - https://bugs.webkit.org/show_bug.cgi?id=93677 - - Reviewed by Adrienne Walker. - - This adds the ability to CCResourceProvider to use software bitmaps. - They are allocated as plain-old-memory, and exposed as Skia objects. - - We want the ResourceProvider to be able to handle different resource - types at the same time. In practice, a default resource type is - desired for most uses within a single compositor instance, which is - specified by the default resource type. Default resource types are - expected to be mostly 1-to-1 with CCRenderer types. - - New tests added by parametrizing existing CCResourceProvider tests. - - * tests/CCResourceProviderTest.cpp: - (WebKit::CCResourceProviderTest::getResourcePixels): - -2012-08-21 Oli Lan <olilan@chromium.org> - - [chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndDelete. - https://bugs.webkit.org/show_bug.cgi?id=93724 - - Reviewed by Ryosuke Niwa. - - This adds two new methods to WebViewImpl. - - 1) setCompositionFromExistingText creates a new composition from the existing text - in the currently focused input field. The new composition is between the two offsets - provided, relative to the rootEditableElement. The current selection is left unchanged. - - 2) extendSelectionAndDelete extends the selection by the specified number of characters - before and after, and then deletes the selection. If the selection is just a caret, the effect - is to delete the specified number of characters before and after the current editing point. - - These methods will be used e.g. by the Android port to implement IME functionality. - - New tests WebViewTest.ExtendSelectionAndDelete and WebViewTest.SetCompositionFromExistingText - test the two new methods. - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setComposingRegion): - (WebKit): - (WebKit::extendSelectionAndDelete): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/WebViewTest.cpp: - -2012-08-21 Alec Flett <alecflett@chromium.org> - - IndexedDB: remove old update/openCursor glue - https://bugs.webkit.org/show_bug.cgi?id=94378 - - Reviewed by Tony Chang. - - Remove Chromium/WebKit API for old methods that have now been - removed from chromium proper. - - * public/WebIDBObjectStore.h: - * src/IDBObjectStoreBackendProxy.cpp: - * src/IDBObjectStoreBackendProxy.h: - (IDBObjectStoreBackendProxy): - * src/WebIDBObjectStoreImpl.h: - (WebIDBObjectStoreImpl): - -2012-08-21 James Robinson <jamesr@chromium.org> - - [chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer - https://bugs.webkit.org/show_bug.cgi?id=94631 - - Reviewed by Adrienne Walker. - - Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash. - - * tests/LayerChromiumTest.cpp: - -2012-08-21 James Robinson <jamesr@chromium.org> - - Unreviewed, rolling out r126170. - http://trac.webkit.org/changeset/126170 - https://bugs.webkit.org/show_bug.cgi?id=94614 - - I spoke too soon - - * WebKit.gypi: - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - (WebKit::NonCompositedContentHost::setScrollLayer): - (WebKit::NonCompositedContentHost::setViewport): - (WebKit::NonCompositedContentHost::scrollLayer): - * src/NonCompositedContentHost.h: - * src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp. - (WebKit): - (WebKit::WebContentLayer::create): - (WebKit::WebContentLayer::clearClient): - (WebKit::WebContentLayer::setDoubleSided): - (WebKit::WebContentLayer::setContentsScale): - (WebKit::WebContentLayer::setUseLCDText): - (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles): - (WebKit::WebContentLayer::WebContentLayer): - (WebKit::WebContentLayer::operator=): - (WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>): - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::create): - (WebKit::WebContentLayerImpl::WebContentLayerImpl): - (WebKit::WebContentLayerImpl::~WebContentLayerImpl): - (WebKit::WebContentLayerImpl::paintContents): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp. - (WebKit): - (WebTextureUpdaterImpl): - (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): - (WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayer::create): - (WebKit::WebExternalTextureLayer::clearClient): - (WebKit::WebExternalTextureLayer::setTextureId): - (WebKit::WebExternalTextureLayer::setFlipped): - (WebKit::WebExternalTextureLayer::setUVRect): - (WebKit::WebExternalTextureLayer::setOpaque): - (WebKit::WebExternalTextureLayer::setPremultipliedAlpha): - (WebKit::WebExternalTextureLayer::willModifyTexture): - (WebKit::WebExternalTextureLayer::setRateLimitContext): - (WebKit::WebExternalTextureLayer::WebExternalTextureLayer): - * src/WebExternalTextureLayerImpl.h: Removed. - * src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp. - (WebKit): - (WebKit::WebIOSurfaceLayer::create): - (WebKit::WebIOSurfaceLayer::setIOSurfaceProperties): - (WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer): - * src/WebIOSurfaceLayerImpl.h: Removed. - * src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h. - (WebKit): - (WebKit::WebImageLayer::create): - (WebKit::WebImageLayer::WebImageLayer): - (WebKit::WebImageLayer::setBitmap): - * src/WebLayer.cpp: Added. - (WebKit): - (WebKit::WebLayer::create): - (WebKit::WebLayer::reset): - (WebKit::WebLayer::assign): - (WebKit::WebLayer::equals): - (WebKit::WebLayer::invalidateRect): - (WebKit::WebLayer::invalidate): - (WebKit::WebLayer::addChild): - (WebKit::WebLayer::insertChild): - (WebKit::WebLayer::replaceChild): - (WebKit::WebLayer::setChildren): - (WebKit::WebLayer::removeFromParent): - (WebKit::WebLayer::removeAllChildren): - (WebKit::WebLayer::setAnchorPoint): - (WebKit::WebLayer::anchorPoint): - (WebKit::WebLayer::setAnchorPointZ): - (WebKit::WebLayer::anchorPointZ): - (WebKit::WebLayer::setBounds): - (WebKit::WebLayer::bounds): - (WebKit::WebLayer::setMasksToBounds): - (WebKit::WebLayer::masksToBounds): - (WebKit::WebLayer::setMaskLayer): - (WebKit::WebLayer::setReplicaLayer): - (WebKit::WebLayer::setOpacity): - (WebKit::WebLayer::opacity): - (WebKit::WebLayer::setOpaque): - (WebKit::WebLayer::opaque): - (WebKit::WebLayer::setPosition): - (WebKit::WebLayer::position): - (WebKit::WebLayer::setSublayerTransform): - (WebKit::WebLayer::sublayerTransform): - (WebKit::WebLayer::setTransform): - (WebKit::WebLayer::transform): - (WebKit::WebLayer::setDrawsContent): - (WebKit::WebLayer::drawsContent): - (WebKit::WebLayer::setPreserves3D): - (WebKit::WebLayer::setUseParentBackfaceVisibility): - (WebKit::WebLayer::setBackgroundColor): - (WebKit::WebLayer::setFilters): - (WebKit::WebLayer::setBackgroundFilters): - (WebKit::WebLayer::setDebugBorderColor): - (WebKit::WebLayer::setDebugBorderWidth): - (WebKit::WebLayer::setDebugName): - (WebKit::WebLayer::setAnimationDelegate): - (WebKit::WebLayer::addAnimation): - (WebKit::WebLayer::removeAnimation): - (WebKit::WebLayer::pauseAnimation): - (WebKit::WebLayer::suspendAnimations): - (WebKit::WebLayer::resumeAnimations): - (WebKit::WebLayer::hasActiveAnimation): - (WebKit::WebLayer::transferAnimationsTo): - (WebKit::WebLayer::setForceRenderSurface): - (WebKit::WebLayer::clearRenderSurface): - (WebKit::WebLayer::WebLayer): - (WebKit::WebLayer::operator=): - (WebKit::WebLayer::operator PassRefPtr<LayerChromium>): - * src/WebLayerImpl.cpp: - (WebKit::WebLayerImpl::create): - (WebKit::WebLayerImpl::WebLayerImpl): - (WebKit::WebLayerImpl::~WebLayerImpl): - * src/WebLayerImpl.h: - (WebLayerImpl): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setRootLayer): - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::create): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - (WebKit::WebMediaPlayerClientImpl::repaint): - (WebKit::WebMediaPlayerClientImpl::setOpaque): - (WebKit::WebMediaPlayerClientImpl::platformLayer): - (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - (WebKit::WebPluginContainerImpl::commitBackingTexture): - (WebKit::WebPluginContainerImpl::setOpaque): - (WebKit::WebPluginContainerImpl::platformLayer): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - * src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp. - (WebKit): - (WebKit::WebScrollableLayer::setScrollPosition): - (WebKit::WebScrollableLayer::setScrollable): - (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): - (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): - (WebKit::WebScrollableLayer::setNonFastScrollableRegion): - (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): - (WebKit::WebScrollableLayer::setFixedToContainerLayer): - * src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp. - (WebKit): - (WebKit::WebScrollbarLayer::setScrollLayer): - (WebKit::WebScrollbarLayer::create): - (WebKit::WebScrollbarLayer::WebScrollbarLayer): - (WebKit::WebScrollbarLayer::operator=): - (WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>): - * src/WebScrollbarLayerImpl.h: Removed. - * src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h. - (WebKit): - (WebKit::WebSolidColorLayer::create): - (WebKit::WebSolidColorLayer::WebSolidColorLayer): - (WebKit::WebSolidColorLayer::setBackgroundColor): - * src/WebSolidColorLayerImpl.cpp: - (WebKit::WebSolidColorLayerImpl::create): - (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): - * src/WebSolidColorLayerImpl.h: - (WebSolidColorLayerImpl): - * src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h. - (WebKit): - (WebKit::WebVideoLayer::create): - (WebKit::WebVideoLayer::WebVideoLayer): - (WebKit::WebVideoLayer::active): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setRootGraphicsLayer): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - * src/WebViewImpl.h: - * tests/ImageLayerChromiumTest.cpp: - (WebCore::TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-21 James Robinson <jamesr@chromium.org> - - Unreviewed, rolling out r126169. - http://trac.webkit.org/changeset/126169 - https://bugs.webkit.org/show_bug.cgi?id=94614 - - Crashes already fixed downstream - - * WebKit.gypi: - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - (WebKit::NonCompositedContentHost::setScrollLayer): - (WebKit::NonCompositedContentHost::setViewport): - (WebKit::NonCompositedContentHost::scrollLayer): - * src/NonCompositedContentHost.h: - * src/WebContentLayer.cpp: Removed. - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayer::create): - (WebKit::WebContentLayerImpl::WebContentLayerImpl): - (WebKit::WebContentLayerImpl::~WebContentLayerImpl): - (WebKit::WebContentLayerImpl::layer): - (WebKit): - (WebKit::WebContentLayerImpl::setDoubleSided): - (WebKit::WebContentLayerImpl::setContentsScale): - (WebKit::WebContentLayerImpl::setUseLCDText): - (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): - (WebKit::WebContentLayerImpl::paintContents): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp. - (WebKit): - (WebKit::WebExternalTextureLayer::create): - (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::layer): - (WebKit::WebExternalTextureLayerImpl::setTextureId): - (WebKit::WebExternalTextureLayerImpl::setFlipped): - (WebKit::WebExternalTextureLayerImpl::setUVRect): - (WebKit::WebExternalTextureLayerImpl::setOpaque): - (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha): - (WebKit::WebExternalTextureLayerImpl::willModifyTexture): - (WebKit::WebExternalTextureLayerImpl::setRateLimitContext): - (WebTextureUpdaterImpl): - (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): - (WebKit::WebExternalTextureLayerImpl::prepareTexture): - (WebKit::WebExternalTextureLayerImpl::context): - * src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h. - (WebKit): - (WebExternalTextureLayerImpl): - * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp. - (WebKit): - (WebKit::WebIOSurfaceLayer::create): - (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): - (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl): - (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties): - (WebKit::WebIOSurfaceLayerImpl::layer): - * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h. - (WebCore): - (WebKit): - (WebIOSurfaceLayerImpl): - * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp. - (WebKit): - (WebKit::WebImageLayer::create): - (WebKit::WebImageLayerImpl::WebImageLayerImpl): - (WebKit::WebImageLayerImpl::~WebImageLayerImpl): - (WebKit::WebImageLayerImpl::layer): - (WebKit::WebImageLayerImpl::setBitmap): - * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp. - (WebCore): - (WebKit): - (WebImageLayerImpl): - * src/WebLayer.cpp: Removed. - * src/WebLayerImpl.cpp: - (WebKit::WebLayer::create): - (WebKit::WebLayerImpl::WebLayerImpl): - (WebKit::WebLayerImpl::~WebLayerImpl): - (WebKit): - (WebKit::WebLayerImpl::id): - (WebKit::WebLayerImpl::invalidateRect): - (WebKit::WebLayerImpl::invalidate): - (WebKit::WebLayerImpl::addChild): - (WebKit::WebLayerImpl::insertChild): - (WebKit::WebLayerImpl::replaceChild): - (WebKit::WebLayerImpl::setChildren): - (WebKit::WebLayerImpl::removeFromParent): - (WebKit::WebLayerImpl::removeAllChildren): - (WebKit::WebLayerImpl::setAnchorPoint): - (WebKit::WebLayerImpl::anchorPoint): - (WebKit::WebLayerImpl::setAnchorPointZ): - (WebKit::WebLayerImpl::anchorPointZ): - (WebKit::WebLayerImpl::setBounds): - (WebKit::WebLayerImpl::bounds): - (WebKit::WebLayerImpl::setMasksToBounds): - (WebKit::WebLayerImpl::masksToBounds): - (WebKit::WebLayerImpl::setMaskLayer): - (WebKit::WebLayerImpl::setReplicaLayer): - (WebKit::WebLayerImpl::setOpacity): - (WebKit::WebLayerImpl::opacity): - (WebKit::WebLayerImpl::setOpaque): - (WebKit::WebLayerImpl::opaque): - (WebKit::WebLayerImpl::setPosition): - (WebKit::WebLayerImpl::position): - (WebKit::WebLayerImpl::setSublayerTransform): - (WebKit::WebLayerImpl::sublayerTransform): - (WebKit::WebLayerImpl::setTransform): - (WebKit::WebLayerImpl::transform): - (WebKit::WebLayerImpl::setDrawsContent): - (WebKit::WebLayerImpl::drawsContent): - (WebKit::WebLayerImpl::setPreserves3D): - (WebKit::WebLayerImpl::setUseParentBackfaceVisibility): - (WebKit::WebLayerImpl::setBackgroundColor): - (WebKit::WebLayerImpl::setFilters): - (WebKit::WebLayerImpl::setBackgroundFilters): - (WebKit::WebLayerImpl::setDebugBorderColor): - (WebKit::WebLayerImpl::setDebugBorderWidth): - (WebKit::WebLayerImpl::setDebugName): - (WebKit::WebLayerImpl::setAnimationDelegate): - (WebKit::WebLayerImpl::addAnimation): - (WebKit::WebLayerImpl::removeAnimation): - (WebKit::WebLayerImpl::pauseAnimation): - (WebKit::WebLayerImpl::suspendAnimations): - (WebKit::WebLayerImpl::resumeAnimations): - (WebKit::WebLayerImpl::hasActiveAnimation): - (WebKit::WebLayerImpl::transferAnimationsTo): - (WebKit::WebLayerImpl::setForceRenderSurface): - (WebKit::WebLayerImpl::setScrollPosition): - (WebKit::WebLayerImpl::setScrollable): - (WebKit::WebLayerImpl::setHaveWheelEventHandlers): - (WebKit::WebLayerImpl::setShouldScrollOnMainThread): - (WebKit::WebLayerImpl::setNonFastScrollableRegion): - (WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers): - (WebKit::WebLayerImpl::setFixedToContainerLayer): - (WebKit::WebLayerImpl::layer): - * src/WebLayerImpl.h: - (WebCore): - (WebLayerImpl): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setRootLayer): - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::create): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - (WebKit::WebMediaPlayerClientImpl::repaint): - (WebKit::WebMediaPlayerClientImpl::setOpaque): - (WebKit::WebMediaPlayerClientImpl::platformLayer): - (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - (WebKit::WebPluginContainerImpl::commitBackingTexture): - (WebKit::WebPluginContainerImpl::setOpaque): - (WebKit::WebPluginContainerImpl::platformLayer): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - * src/WebScrollableLayer.cpp: Removed. - * src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp. - (WebKit): - (WebKit::WebScrollbarLayer::create): - (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): - (WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl): - (WebKit::WebScrollbarLayerImpl::layer): - (WebKit::WebScrollbarLayerImpl::setScrollLayer): - * src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h. - (WebCore): - (WebKit): - (WebScrollbarLayerImpl): - * src/WebSolidColorLayerImpl.cpp: - (WebKit::WebSolidColorLayer::create): - (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): - (WebKit::WebSolidColorLayerImpl::layer): - (WebKit): - (WebKit::WebSolidColorLayerImpl::setBackgroundColor): - * src/WebSolidColorLayerImpl.h: - (WebCore): - (WebKit): - (WebSolidColorLayerImpl): - * src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp. - (WebKit): - (WebKit::WebVideoLayer::create): - (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): - (WebKit::WebVideoLayerImpl::~WebVideoLayerImpl): - (WebKit::WebVideoLayerImpl::layer): - (WebKit::WebVideoLayerImpl::active): - * src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp. - (WebCore): - (WebKit): - (WebVideoLayerImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setRootGraphicsLayer): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - * src/WebViewImpl.h: - * tests/ImageLayerChromiumTest.cpp: - (WebCore::TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-21 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126076, r126099, and r126106. - http://trac.webkit.org/changeset/126076 - http://trac.webkit.org/changeset/126099 - http://trac.webkit.org/changeset/126106 - https://bugs.webkit.org/show_bug.cgi?id=94614 - - Caused crashes during compositor shutdown in Aura builds of - Chromium (Requested by kbr_google on #webkit). - - * WebKit.gypi: - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - (WebKit::NonCompositedContentHost::setScrollLayer): - (WebKit::NonCompositedContentHost::setViewport): - (WebKit::NonCompositedContentHost::scrollLayer): - * src/NonCompositedContentHost.h: - * src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp. - (WebKit): - (WebKit::WebContentLayer::create): - (WebKit::WebContentLayer::clearClient): - (WebKit::WebContentLayer::setDoubleSided): - (WebKit::WebContentLayer::setContentsScale): - (WebKit::WebContentLayer::setUseLCDText): - (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles): - (WebKit::WebContentLayer::WebContentLayer): - (WebKit::WebContentLayer::operator=): - (WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>): - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::create): - (WebKit::WebContentLayerImpl::WebContentLayerImpl): - (WebKit::WebContentLayerImpl::~WebContentLayerImpl): - (WebKit::WebContentLayerImpl::paintContents): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp. - (WebKit): - (WebTextureUpdaterImpl): - (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): - (WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayer::create): - (WebKit::WebExternalTextureLayer::clearClient): - (WebKit::WebExternalTextureLayer::setTextureId): - (WebKit::WebExternalTextureLayer::setFlipped): - (WebKit::WebExternalTextureLayer::setUVRect): - (WebKit::WebExternalTextureLayer::setOpaque): - (WebKit::WebExternalTextureLayer::setPremultipliedAlpha): - (WebKit::WebExternalTextureLayer::willModifyTexture): - (WebKit::WebExternalTextureLayer::setRateLimitContext): - (WebKit::WebExternalTextureLayer::WebExternalTextureLayer): - * src/WebExternalTextureLayerImpl.h: Removed. - * src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp. - (WebKit): - (WebKit::WebIOSurfaceLayer::create): - (WebKit::WebIOSurfaceLayer::setIOSurfaceProperties): - (WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer): - * src/WebIOSurfaceLayerImpl.h: Removed. - * src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h. - (WebKit): - (WebKit::WebImageLayer::create): - (WebKit::WebImageLayer::WebImageLayer): - (WebKit::WebImageLayer::setBitmap): - * src/WebLayer.cpp: Added. - (WebKit): - (WebKit::WebLayer::create): - (WebKit::WebLayer::reset): - (WebKit::WebLayer::assign): - (WebKit::WebLayer::equals): - (WebKit::WebLayer::invalidateRect): - (WebKit::WebLayer::invalidate): - (WebKit::WebLayer::addChild): - (WebKit::WebLayer::insertChild): - (WebKit::WebLayer::replaceChild): - (WebKit::WebLayer::setChildren): - (WebKit::WebLayer::removeFromParent): - (WebKit::WebLayer::removeAllChildren): - (WebKit::WebLayer::setAnchorPoint): - (WebKit::WebLayer::anchorPoint): - (WebKit::WebLayer::setAnchorPointZ): - (WebKit::WebLayer::anchorPointZ): - (WebKit::WebLayer::setBounds): - (WebKit::WebLayer::bounds): - (WebKit::WebLayer::setMasksToBounds): - (WebKit::WebLayer::masksToBounds): - (WebKit::WebLayer::setMaskLayer): - (WebKit::WebLayer::setReplicaLayer): - (WebKit::WebLayer::setOpacity): - (WebKit::WebLayer::opacity): - (WebKit::WebLayer::setOpaque): - (WebKit::WebLayer::opaque): - (WebKit::WebLayer::setPosition): - (WebKit::WebLayer::position): - (WebKit::WebLayer::setSublayerTransform): - (WebKit::WebLayer::sublayerTransform): - (WebKit::WebLayer::setTransform): - (WebKit::WebLayer::transform): - (WebKit::WebLayer::setDrawsContent): - (WebKit::WebLayer::drawsContent): - (WebKit::WebLayer::setPreserves3D): - (WebKit::WebLayer::setUseParentBackfaceVisibility): - (WebKit::WebLayer::setBackgroundColor): - (WebKit::WebLayer::setFilters): - (WebKit::WebLayer::setBackgroundFilters): - (WebKit::WebLayer::setDebugBorderColor): - (WebKit::WebLayer::setDebugBorderWidth): - (WebKit::WebLayer::setDebugName): - (WebKit::WebLayer::setAnimationDelegate): - (WebKit::WebLayer::addAnimation): - (WebKit::WebLayer::removeAnimation): - (WebKit::WebLayer::pauseAnimation): - (WebKit::WebLayer::suspendAnimations): - (WebKit::WebLayer::resumeAnimations): - (WebKit::WebLayer::hasActiveAnimation): - (WebKit::WebLayer::transferAnimationsTo): - (WebKit::WebLayer::setForceRenderSurface): - (WebKit::WebLayer::clearRenderSurface): - (WebKit::WebLayer::WebLayer): - (WebKit::WebLayer::operator=): - (WebKit::WebLayer::operator PassRefPtr<LayerChromium>): - * src/WebLayerImpl.cpp: - (WebKit::WebLayerImpl::create): - (WebKit::WebLayerImpl::WebLayerImpl): - (WebKit::WebLayerImpl::~WebLayerImpl): - * src/WebLayerImpl.h: - (WebLayerImpl): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setRootLayer): - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::create): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - (WebKit::WebMediaPlayerClientImpl::repaint): - (WebKit::WebMediaPlayerClientImpl::setOpaque): - (WebKit::WebMediaPlayerClientImpl::platformLayer): - (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - (WebKit::WebPluginContainerImpl::commitBackingTexture): - (WebKit::WebPluginContainerImpl::setOpaque): - (WebKit::WebPluginContainerImpl::platformLayer): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - * src/WebScrollableLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.cpp. - (WebKit): - (WebKit::WebScrollableLayer::setScrollPosition): - (WebKit::WebScrollableLayer::setScrollable): - (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): - (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): - (WebKit::WebScrollableLayer::setNonFastScrollableRegion): - (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): - (WebKit::WebScrollableLayer::setFixedToContainerLayer): - * src/WebScrollbarLayer.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayerImpl.cpp. - (WebKit): - (WebKit::WebScrollbarLayer::setScrollLayer): - (WebKit::WebScrollbarLayer::create): - (WebKit::WebScrollbarLayer::WebScrollbarLayer): - (WebKit::WebScrollbarLayer::operator=): - (WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>): - * src/WebScrollbarLayerImpl.h: Removed. - * src/WebSolidColorLayer.cpp: Copied from Source/Platform/chromium/public/WebSolidColorLayer.h. - (WebKit): - (WebKit::WebSolidColorLayer::create): - (WebKit::WebSolidColorLayer::WebSolidColorLayer): - (WebKit::WebSolidColorLayer::setBackgroundColor): - * src/WebSolidColorLayerImpl.cpp: - (WebKit::WebSolidColorLayerImpl::create): - (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): - * src/WebSolidColorLayerImpl.h: - (WebSolidColorLayerImpl): - * src/WebVideoLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.h. - (WebKit): - (WebKit::WebVideoLayer::create): - (WebKit::WebVideoLayer::WebVideoLayer): - (WebKit::WebVideoLayer::active): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setRootGraphicsLayer): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - * src/WebViewImpl.h: - * tests/ImageLayerChromiumTest.cpp: - (WebCore::TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-21 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: NMI: rename addMember for strings and KURL to addInstrumentedMember. - https://bugs.webkit.org/show_bug.cgi?id=94580 - - Reviewed by Yury Semikhatsky. - - Drive by fix: immutable ElementAttrybuteData uses the same trick with placement new as in StylePropertySet. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - (WebCore): - -2012-08-21 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-20 Kent Tamura <tkent@chromium.org> - - [Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date] - https://bugs.webkit.org/show_bug.cgi?id=94281 - - Reviewed by Hajime Morita. - - * tests/LocaleWinTest.cpp: - (TEST_F): Added formatting and parsing tests for Persian locale to check - native digit behavior. - -2012-08-20 Kent Tamura <tkent@chromium.org> - - [Chromium] Make the popup positioning code testable - https://bugs.webkit.org/show_bug.cgi?id=94086 - - Reviewed by Hajime Morita. - - * WebKit.gypi: Add PopupContainerTest.cpp. - * tests/PopupContainerTest.cpp: Added. - (MockPopupContent): - (calculatePosition): - (TEST): - -2012-08-20 Scott Graham <scottmg@chromium.org> - - [Chromium] Fix warnings on Windows builds - https://bugs.webkit.org/show_bug.cgi?id=94543 - - Reviewed by Adrienne Walker. - - * tests/CCMathUtilTest.cpp: - -2012-08-20 Adam Klein <adamk@chromium.org> - - Allow MutationEvents to be enabled/disabled per context - https://bugs.webkit.org/show_bug.cgi?id=94016 - - Reviewed by Ojan Vafai. - - Add Chromium/WebKit API for enabling/disabling MutationEvents via - WebPermissionClient. - - * public/WebPermissionClient.h: - (WebPermissionClient): - (WebKit::WebPermissionClient::allowMutationEvents): - * src/ContextFeaturesClientImpl.cpp: - (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): - -2012-08-20 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r126095. - http://trac.webkit.org/changeset/126095 - https://bugs.webkit.org/show_bug.cgi?id=94555 - - Breaks compilation of downstream WebWidget::paint - implementations (Requested by jamesr on #webkit). - - * public/WebWidget.h: - (WebKit::WebWidget::paint): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::paint): - * src/WebPagePopupImpl.h: - (WebPagePopupImpl): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::paint): - * src/WebPopupMenuImpl.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::paint): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-20 Kentaro Hara <haraken@chromium.org> - - [V8] Move instrumentedCallFunction() from V8Proxy to ScriptController - https://bugs.webkit.org/show_bug.cgi?id=94456 - - Reviewed by Adam Barth. - - To kill V8Proxy, this patch moves instrumentedCallFunction() from V8Proxy - to ScriptController. Also this patch renames instrumentedCallFunction() - to callFunctionWithInstrumentation(), for consistency with callFunction(). - - No tests. No change in behavior. - - * src/WebDevToolsFrontendImpl.cpp: - (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): - -2012-08-20 Kentaro Hara <haraken@chromium.org> - - [V8] Move retrieve{Window,Frame,PerContextData}() from V8Proxy to V8Binding - https://bugs.webkit.org/show_bug.cgi?id=94460 - - Reviewed by Adam Barth. - - To kill V8Proxy, we move retrieve{Window,Frame,PerContextData}() - from V8Proxy to V8Binding. Also, this patch renames these methods as follows: - - - retrieveWindow() -> toDOMWindow() - - retrieveFrame() -> toFrameIfNotDetached() - - retrievePerContextData() -> perContextDataForCurrentWorld() - - No tests. No change in behavior. - - * src/WebBindings.cpp: - (WebKit::makeIntArrayImpl): - (WebKit::makeStringArrayImpl): - * src/WebFrameImpl.cpp: - (WebKit::WebFrame::frameForContext): - -2012-08-20 James Robinson <jamesr@chromium.org> - - [chromium] REGRESSION(126076) Should not touch old GraphicsLayerChromium::m_contentsLayer when setting up a new contents layer - https://bugs.webkit.org/show_bug.cgi?id=94544 - - Reviewed by Adrienne Walker. - - * src/WebLayerImpl.cpp: - (WebKit::WebLayerImpl::id): - (WebKit): - * src/WebLayerImpl.h: - (WebLayerImpl): - -2012-08-20 Kentaro Hara <haraken@chromium.org> - - [V8] Move collectGarbage() from ScriptController to V8GCController - https://bugs.webkit.org/show_bug.cgi?id=94455 - - Reviewed by Adam Barth. - - - This patch moves collectGarbage() from ScriptController to V8GCController. - - This patch makes collectGarbage() a static method. - - This patch removes ScriptController::lowMemoryNotification() - since it is not used at all. - - No tests. No change in behavior. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::collectGarbage): - -2012-08-20 Adam Barth <abarth@webkit.org> - - WebWidget should be able to paint into a zoomed canvas without aliasing - https://bugs.webkit.org/show_bug.cgi?id=92043 - - Reviewed by James Robinson. - - If accelerated compositing is enabled, WebWidget::paint reads back from - the compositor rather than re-painting the widget. That approach works - well if the canvas we're rendering into is at a similar resolution to - the pixels in the compositor, but if the canvas has been scaled (e.g., - to help the user disambiguate links), then reading back from the - compositor will cause aliasing artifacts. - - This patch adds an option to paint to let the embedder request a - software re-rendering of the widget to avoid these aliasing artifacts. - - * public/WebWidget.h: - (WebKit::WebWidget::paint): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::paint): - * src/WebPagePopupImpl.h: - (WebPagePopupImpl): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::paint): - * src/WebPopupMenuImpl.h: - * src/WebViewImpl.cpp: - (WebKit::canvasBackgroundForTransparencey): - (WebKit): - (WebKit::WebViewImpl::paint): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-20 James Robinson <jamesr@chromium.org> - - Unreviewed. Roll WebKit chromium DEPS forward. - - * DEPS: - -2012-08-20 Kentaro Hara <haraken@chromium.org> - - [V8] Move clearForClose() and clearForNavigation() from V8Proxy to ScriptController - https://bugs.webkit.org/show_bug.cgi?id=94459 - - Reviewed by Adam Barth. - - To kill V8Proxy, we can move clearForClose() and - clearForNavigation() from V8Proxy to ScriptController. - - No tests. No change in behavior. - - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::detachedFromParent3): - -2012-08-20 Kentaro Hara <haraken@chromium.org> - - [V8] Move mainWorldContext() from V8Proxy to ScriptController - https://bugs.webkit.org/show_bug.cgi?id=94453 - - Reviewed by Adam Barth. - - This patch moves mainWorldContext() from V8Proxy to ScriptController. - In addition, this patch removes dependency on V8Proxy from WorldContextHandle. - - No tests. No change in behavior. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::mainWorldScriptContext): - -2012-08-20 Adam Klein <adamk@chromium.org> - - Remove redundant TOUCH_LISTENER event type - https://bugs.webkit.org/show_bug.cgi?id=94524 - - Reviewed by Ryosuke Niwa. - - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): Remove - bookkeeping for TOUCH_LISTENER. - -2012-08-16 James Robinson <jamesr@chromium.org> - - [chromium] Change WebLayer from a concrete type to a pure virtual interface - https://bugs.webkit.org/show_bug.cgi?id=94174 - - Reviewed by Adrienne Walker. - - This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl / - NonCompositedContentHost. - - * WebKit.gyp: - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - (WebKit::NonCompositedContentHost::setScrollLayer): - (WebKit::NonCompositedContentHost::setViewport): - (WebKit::NonCompositedContentHost::scrollLayer): - * src/NonCompositedContentHost.h: - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayer::create): - (WebKit::WebContentLayerImpl::WebContentLayerImpl): - (WebKit::WebContentLayerImpl::~WebContentLayerImpl): - (WebKit::WebContentLayerImpl::layer): - (WebKit): - (WebKit::WebContentLayerImpl::clearClient): - (WebKit::WebContentLayerImpl::setDoubleSided): - (WebKit::WebContentLayerImpl::setContentsScale): - (WebKit::WebContentLayerImpl::setUseLCDText): - (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles): - (WebKit::WebContentLayerImpl::paintContents): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebExternalTextureLayer.cpp: Removed. - * src/WebExternalTextureLayerImpl.cpp: Added. - (WebKit): - (WebKit::WebExternalTextureLayer::create): - (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::layer): - (WebKit::WebExternalTextureLayerImpl::clearClient): - (WebKit::WebExternalTextureLayerImpl::setTextureId): - (WebKit::WebExternalTextureLayerImpl::setFlipped): - (WebKit::WebExternalTextureLayerImpl::setUVRect): - (WebKit::WebExternalTextureLayerImpl::setOpaque): - (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha): - (WebKit::WebExternalTextureLayerImpl::willModifyTexture): - (WebKit::WebExternalTextureLayerImpl::setRateLimitContext): - (WebTextureUpdaterImpl): - (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): - (WebKit::WebExternalTextureLayerImpl::prepareTexture): - (WebKit::WebExternalTextureLayerImpl::context): - * src/WebExternalTextureLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebContentLayer.cpp. - (WebKit): - (WebExternalTextureLayerImpl): - * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp. - (WebKit): - (WebKit::WebIOSurfaceLayer::create): - (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl): - (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl): - (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties): - (WebKit::WebIOSurfaceLayerImpl::layer): - * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h. - (WebCore): - (WebKit): - (WebIOSurfaceLayerImpl): - * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp. - (WebKit): - (WebKit::WebImageLayer::create): - (WebKit::WebImageLayerImpl::WebImageLayerImpl): - (WebKit::WebImageLayerImpl::~WebImageLayerImpl): - (WebKit::WebImageLayerImpl::layer): - (WebKit::WebImageLayerImpl::setBitmap): - * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp. - (WebCore): - (WebKit): - (WebImageLayerImpl): - * src/WebLayer.cpp: Removed. - * src/WebLayerImpl.cpp: - (WebKit::WebLayer::create): - (WebKit::WebLayerImpl::WebLayerImpl): - (WebKit::WebLayerImpl::~WebLayerImpl): - (WebKit): - (WebKit::WebLayerImpl::invalidateRect): - (WebKit::WebLayerImpl::invalidate): - (WebKit::WebLayerImpl::addChild): - (WebKit::WebLayerImpl::insertChild): - (WebKit::WebLayerImpl::replaceChild): - (WebKit::WebLayerImpl::setChildren): - (WebKit::WebLayerImpl::removeFromParent): - (WebKit::WebLayerImpl::removeAllChildren): - (WebKit::WebLayerImpl::setAnchorPoint): - (WebKit::WebLayerImpl::anchorPoint): - (WebKit::WebLayerImpl::setAnchorPointZ): - (WebKit::WebLayerImpl::anchorPointZ): - (WebKit::WebLayerImpl::setBounds): - (WebKit::WebLayerImpl::bounds): - (WebKit::WebLayerImpl::setMasksToBounds): - (WebKit::WebLayerImpl::masksToBounds): - (WebKit::WebLayerImpl::setMaskLayer): - (WebKit::WebLayerImpl::setReplicaLayer): - (WebKit::WebLayerImpl::setOpacity): - (WebKit::WebLayerImpl::opacity): - (WebKit::WebLayerImpl::setOpaque): - (WebKit::WebLayerImpl::opaque): - (WebKit::WebLayerImpl::setPosition): - (WebKit::WebLayerImpl::position): - (WebKit::WebLayerImpl::setSublayerTransform): - (WebKit::WebLayerImpl::sublayerTransform): - (WebKit::WebLayerImpl::setTransform): - (WebKit::WebLayerImpl::transform): - (WebKit::WebLayerImpl::setDrawsContent): - (WebKit::WebLayerImpl::drawsContent): - (WebKit::WebLayerImpl::setPreserves3D): - (WebKit::WebLayerImpl::setUseParentBackfaceVisibility): - (WebKit::WebLayerImpl::setBackgroundColor): - (WebKit::WebLayerImpl::setFilters): - (WebKit::WebLayerImpl::setBackgroundFilters): - (WebKit::WebLayerImpl::setDebugBorderColor): - (WebKit::WebLayerImpl::setDebugBorderWidth): - (WebKit::WebLayerImpl::setDebugName): - (WebKit::WebLayerImpl::setAnimationDelegate): - (WebKit::WebLayerImpl::addAnimation): - (WebKit::WebLayerImpl::removeAnimation): - (WebKit::WebLayerImpl::pauseAnimation): - (WebKit::WebLayerImpl::suspendAnimations): - (WebKit::WebLayerImpl::resumeAnimations): - (WebKit::WebLayerImpl::hasActiveAnimation): - (WebKit::WebLayerImpl::transferAnimationsTo): - (WebKit::WebLayerImpl::setForceRenderSurface): - (WebKit::WebLayerImpl::clearRenderSurface): - (WebKit::WebLayerImpl::setScrollPosition): - (WebKit::WebLayerImpl::setScrollable): - (WebKit::WebLayerImpl::setHaveWheelEventHandlers): - (WebKit::WebLayerImpl::setShouldScrollOnMainThread): - (WebKit::WebLayerImpl::setNonFastScrollableRegion): - (WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers): - (WebKit::WebLayerImpl::setFixedToContainerLayer): - (WebKit::WebLayerImpl::layer): - * src/WebLayerImpl.h: - (WebCore): - (WebLayerImpl): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setRootLayer): - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::create): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::readyStateChanged): - (WebKit::WebMediaPlayerClientImpl::repaint): - (WebKit::WebMediaPlayerClientImpl::setOpaque): - (WebKit::WebMediaPlayerClientImpl::platformLayer): - (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setBackingTextureId): - (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): - (WebKit::WebPluginContainerImpl::commitBackingTexture): - (WebKit::WebPluginContainerImpl::setOpaque): - (WebKit::WebPluginContainerImpl::platformLayer): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - * src/WebScrollableLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollableLayer.cpp. - (WebKit): - (WebKit::WebScrollableLayer::setScrollPosition): - (WebKit::WebScrollableLayer::setScrollable): - (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): - (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): - (WebKit::WebScrollableLayer::setNonFastScrollableRegion): - (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): - (WebKit::WebScrollableLayer::setFixedToContainerLayer): - * src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp. - (WebKit): - (WebKit::WebScrollbarLayer::create): - (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl): - (WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl): - (WebKit::WebScrollbarLayerImpl::layer): - (WebKit::WebScrollbarLayerImpl::setScrollLayer): - * src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h. - (WebCore): - (WebKit): - (WebScrollbarLayerImpl): - * src/WebSolidColorLayerImpl.cpp: - (WebKit::WebSolidColorLayer::create): - (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl): - (WebKit::WebSolidColorLayerImpl::layer): - (WebKit): - (WebKit::WebSolidColorLayerImpl::setBackgroundColor): - * src/WebSolidColorLayerImpl.h: - (WebCore): - (WebKit): - (WebSolidColorLayerImpl): - * src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp. - (WebKit): - (WebKit::WebVideoLayer::create): - (WebKit::WebVideoLayerImpl::WebVideoLayerImpl): - (WebKit::WebVideoLayerImpl::~WebVideoLayerImpl): - (WebKit::WebVideoLayerImpl::layer): - (WebKit::WebVideoLayerImpl::active): - * src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp. - (WebCore): - (WebKit): - (WebVideoLayerImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setRootGraphicsLayer): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit): - * src/WebViewImpl.h: - * tests/ImageLayerChromiumTest.cpp: - (WebCore::TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-20 Shawn Singh <shawnsingh@chromium.org> - - [chromium] CCMathUtilTest.smallestAngleBetweenVectors unit test failing - https://bugs.webkit.org/show_bug.cgi?id=94502 - - Reviewed by Kenneth Russell. - - The test needed to use EXPECT_FLOAT_EQ instead of EXPECT_EQ. In - this patch, the test is also re-enabled. - - * tests/CCMathUtilTest.cpp: - -2012-08-20 Leandro Gracia Gil <leandrogracia@chromium.org> - - Move transformFriendlyBoundingBox out of Range - https://bugs.webkit.org/show_bug.cgi?id=94366 - - Reviewed by Ryosuke Niwa. - - Update the WebKit code that makes use of transformFriendlyBoundingBox. - - * src/FindInPageCoordinates.cpp: - (WebKit::findInPageRectFromRange): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::find): - (WebKit::WebFrameImpl::selectFindMatch): - -2012-08-20 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] detectContentIntentAround has a misleading name - https://bugs.webkit.org/show_bug.cgi?id=94349 - - Reviewed by Adam Barth. - - The current WebViewClient API exposes a method named detectContentIntentAround. - However, this is not designed to detect any "content intent", but to allow the embedder - to detect content around a position and fire Android intents if appropriate. - - This patch also disables content detection if the touched node listens to events - that consume the tap action like clicks, touch events or mouse events. - - * public/WebViewClient.h: - (WebViewClient): - (WebKit::WebViewClient::detectContentAround): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::detectContentOnTouch): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-20 Hans Wennborg <hans@chromium.org> - - Respect runtime flags for Device Orientation and Device Motion - https://bugs.webkit.org/show_bug.cgi?id=94479 - - Reviewed by Adam Barth. - - WebRuntimeFeatures::enableDeviceMotion should not be hard-coded to - false. - - * src/WebViewImpl.cpp: - (WebKit::WebView::create): - -2012-08-20 David Reveman <reveman@chromium.org> - - [Chromium] Schedule texture uploads based on hard-coded timer and vsync. - https://bugs.webkit.org/show_bug.cgi?id=84281 - - Reviewed by James Robinson. - - * tests/CCSchedulerTest.cpp: - (WebKitTests::TEST): - * tests/CCSchedulerTestCommon.h: - (WebKitTests::FakeCCTimeSource::FakeCCTimeSource): - (WebKitTests::FakeCCTimeSource::setNextTickTime): - (FakeCCTimeSource): - * tests/CCTextureUpdateControllerTest.cpp: - -2012-08-20 Kenneth Russell <kbr@google.com> - - Unreviewed Chromium rebaselining and test failure suppressions. - - https://bugs.webkit.org/show_bug.cgi?id=94502 - - * tests/CCMathUtilTest.cpp: - -2012-08-20 Ian Vollick <vollick@chromium.org> - - [chromium] Add tracing for active composited animations - https://bugs.webkit.org/show_bug.cgi?id=84210 - - Reviewed by James Robinson. - - This patch issues the trace events from the animations. Animations will - report when they start and finish on the main and impl threads (via - TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they - change state. - - * src/WebAnimationImpl.cpp: - (WebKit::WebAnimationImpl::cloneToCCAnimation): - * tests/CCAnimationTestCommon.h: - -2012-08-20 Sami Kyostila <skyostil@chromium.org> - - [chromium] Convert screen space scroll gestures to layer space - https://bugs.webkit.org/show_bug.cgi?id=92499 - - Reviewed by James Robinson. - - Added new tests for verifying transformed layer scrolling: - - CCLayerTreeHostImplTest.scrollAxisAlignedRotatedLayer - CCLayerTreeHostImplTest.scrollNonAxisAlignedRotatedLayer - CCLayerTreeHostImplTest.scrollScaledLayer - - Also some tests for the introduced math utilities: - - CCMathUtilTest.smallestAngleBetweenVectors - CCMathUtilTest.vectorProjection - - * src/WebCompositorInputHandlerImpl.cpp: - (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): - (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): - * tests/CCLayerTreeHostImplTest.cpp: Adjusted scroll delta in scrollChildBeyondLimit to avoid triggering the 45 degree rule. - * tests/CCLayerTreeHostTest.cpp: - * tests/CCMathUtilTest.cpp: - * tests/WebCompositorInputHandlerImplTest.cpp: - (MockCCInputHandlerClient): - (WebKit::TEST_F): - -2012-08-20 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: load scripts panel lazily - https://bugs.webkit.org/show_bug.cgi?id=94416 - - Reviewed by Vsevolod Vlasov. - - * WebKit.gyp: - -2012-08-19 Kentaro Hara <haraken@chromium.org> - - [V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController - https://bugs.webkit.org/show_bug.cgi?id=94446 - - Reviewed by Adam Barth. - - To kill V8Proxy, we can move contextDebugId() and setContextDebugId() - from V8Proxy to ScriptController. - - No tests. No change in behavior. - - * src/WebDevToolsAgentImpl.cpp: - (WebKit::WebDevToolsAgentImpl::didCreateScriptContext): - -2012-08-20 Kentaro Hara <haraken@chromium.org> - - [V8] Move V8Proxy::m_extensions to ScriptController - https://bugs.webkit.org/show_bug.cgi?id=94444 - - Reviewed by Adam Barth. - - To kill V8Proxy, this patch moves V8Proxy::m_extensions to ScriptController. - - No tests. No change in behavior. - - * src/WebScriptController.cpp: - (WebKit::WebScriptController::registerExtension): - -2012-08-19 James Robinson <jamesr@chromium.org> - - [chromium] Put webkit compositor binding files in separate conditionally included gyp section - https://bugs.webkit.org/show_bug.cgi?id=94392 - - Reviewed by Dirk Pranke. - - This allows the use_libcc_for_compositor gyp variable to control whether the webkit bindings are pulled from the - WebKit repository or an external target. - - * WebKit.gyp: - * WebKit.gypi: - -2012-08-19 Rick Byers <rbyers@chromium.org> - - [chromium] Add additional fields to WebGestureEvent - https://bugs.webkit.org/show_bug.cgi?id=94238 - - Reviewed by James Robinson. - - Add a union to WebGestureEvent with per-event-type data, as a first - step to eliminating the overloaded delta fields. - - * public/WebInputEvent.h: - (WebGestureEvent): - (WebKit::WebGestureEvent::WebGestureEvent): - * src/WebInputEvent.cpp: - (SameSizeAsWebGestureEvent): - -2012-08-19 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: load network panel lazily - https://bugs.webkit.org/show_bug.cgi?id=94414 - - Reviewed by Vsevolod Vlasov. - - * WebKit.gyp: - -2012-08-18 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: make profiles panel a lazily loaded module. - https://bugs.webkit.org/show_bug.cgi?id=94351 - - Reviewed by Yury Semikhatsky. - - * WebKit.gyp: - -2012-08-18 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: load panels code on demand - https://bugs.webkit.org/show_bug.cgi?id=94326 - - Reviewed by Vsevolod Vlasov. - - * WebKit.gyp: - * scripts/concatenate_js_files.py: - (OrderedJSFilesExtractor.handle_starttag): - * scripts/inline_js_imports.py: - (main): - -2012-08-17 Dirk Pranke <dpranke@chromium.org> - - Unreviewed, rolling out r125897. - http://trac.webkit.org/changeset/125897 - https://bugs.webkit.org/show_bug.cgi?id=94326 - - this patch seems to have broken the inspector on the apple mac bots. - - * WebKit.gyp: - * scripts/concatenate_js_files.py: - (OrderedJSFilesExtractor.handle_starttag): - * scripts/inline_js_imports.py: - (main): - -2012-08-17 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r125922. - http://trac.webkit.org/changeset/125922 - https://bugs.webkit.org/show_bug.cgi?id=94389 - - "Causing failing/crashing tests on Mac bots" (Requested by - bradee-oh on #webkit). - - * WebKit.gyp: - -2012-08-16 James Robinson <jamesr@chromium.org> - - [chromium] Add Source/WebCore/platform/graphics/chromium/cc/ to include path and remove cc/ prefix from includes - https://bugs.webkit.org/show_bug.cgi?id=94279 - - Reviewed by Adam Barth. - - * src/WebAnimationCurveCommon.cpp: - * src/WebAnimationImpl.cpp: - * src/WebCompositorInputHandlerImpl.cpp: - * src/WebCompositorInputHandlerImpl.h: - * src/WebExternalTextureLayer.cpp: - * src/WebFloatAnimationCurve.cpp: - * src/WebLayerTreeView.cpp: - * src/WebLayerTreeViewImpl.cpp: - * src/WebTransformAnimationCurve.cpp: - * tests/CCActiveAnimationTest.cpp: - * tests/CCAnimationTestCommon.cpp: - * tests/CCAnimationTestCommon.h: - * tests/CCDamageTrackerTest.cpp: - * tests/CCDelayBasedTimeSourceTest.cpp: - * tests/CCFrameRateControllerTest.cpp: - * tests/CCKeyframedAnimationCurveTest.cpp: - * tests/CCLayerAnimationControllerTest.cpp: - * tests/CCLayerImplTest.cpp: - * tests/CCLayerIteratorTest.cpp: - * tests/CCLayerQuadTest.cpp: - * tests/CCLayerSorterTest.cpp: - * tests/CCLayerTestCommon.cpp: - * tests/CCLayerTestCommon.h: - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCMathUtilTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - * tests/CCOcclusionTrackerTestCommon.h: - * tests/CCPrioritizedTextureTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/CCRenderSurfaceFiltersTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCResourceProviderTest.cpp: - * tests/CCSchedulerStateMachineTest.cpp: - * tests/CCSchedulerTest.cpp: - * tests/CCSchedulerTestCommon.h: - * tests/CCScopedTextureTest.cpp: - * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - * tests/CCTestCommon.h: - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCThreadTaskTest.cpp: - * tests/CCThreadedTest.cpp: - * tests/CCThreadedTest.h: - * tests/CCTiledLayerImplTest.cpp: - * tests/CCTiledLayerTestCommon.h: - * tests/CCTimerTest.cpp: - * tests/ContentLayerChromiumTest.cpp: - * tests/FakeCCGraphicsContext.h: - * tests/FakeCCLayerTreeHostClient.h: - * tests/FloatQuadTest.cpp: - * tests/GraphicsLayerChromiumTest.cpp: - * tests/LayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - * tests/MockCCQuadCuller.h: - * tests/PlatformGestureCurveTest.cpp: - * tests/ScrollbarLayerChromiumTest.cpp: - * tests/TextureLayerChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - * tests/TreeSynchronizerTest.cpp: - * tests/WebCompositorInputHandlerImplTest.cpp: - * tests/WebFloatAnimationCurveTest.cpp: - * tests/WebTransformAnimationCurveTest.cpp: - -2012-08-17 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: make profiles panel a lazily loaded module. - https://bugs.webkit.org/show_bug.cgi?id=94351 - - Reviewed by Yury Semikhatsky. - - * WebKit.gyp: - -2012-08-17 Keishi Hattori <keishi@webkit.org> - - [Chromium] Turn off ENABLE_DATALIST_ELEMENT for Android - https://bugs.webkit.org/show_bug.cgi?id=94337 - - Reviewed by Kent Tamura. - - We shouldn't have turned ENABLE_DATALIST_ELEMENT on for Android. - - * features.gypi: - -2012-08-17 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r125892. - http://trac.webkit.org/changeset/125892 - https://bugs.webkit.org/show_bug.cgi?id=94350 - - Broke windows build (Requested by vollick on #webkit). - - * src/WebAnimationImpl.cpp: - (WebKit::WebAnimationImpl::cloneToCCAnimation): - -2012-08-17 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-17 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: load panels code on demand - https://bugs.webkit.org/show_bug.cgi?id=94326 - - Reviewed by Vsevolod Vlasov. - - * WebKit.gyp: - * scripts/concatenate_js_files.py: - (OrderedJSFilesExtractor.handle_starttag): - * scripts/inline_js_imports.py: - (main): - -2012-08-17 Ian Vollick <vollick@chromium.org> - - [chromium] Add tracing for active composited animations - https://bugs.webkit.org/show_bug.cgi?id=84210 - - Reviewed by James Robinson. - - This patch issues the trace events from the animations. Animations will - report when they start and finish on the main and impl threads (via - TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they - change state. - - * src/WebAnimationImpl.cpp: - (WebKit::WebAnimationImpl::cloneToCCAnimation): - -2012-08-16 Antoine Labour <piman@chromium.org> - - [chromium] Add resource transfer functions to CCResourceProvider - https://bugs.webkit.org/show_bug.cgi?id=93524 - - Reviewed by James Robinson. - - This adds methods to CCResourceProvider to be able to transport - resources from a child to a parent. - - Added test to CCResourceProviderTest. - - * tests/CCResourceProviderTest.cpp: - (WebKit::textureSize): - (WebKit): - (WebKit::Texture::Texture): - (Texture): - (ContextSharedData): - (WebKit::ContextSharedData::create): - (WebKit::ContextSharedData::insertSyncPoint): - (WebKit::ContextSharedData::genMailbox): - (WebKit::ContextSharedData::produceTexture): - (WebKit::ContextSharedData::consumeTexture): - (WebKit::ContextSharedData::ContextSharedData): - (WebKit::ResourceProviderContext::create): - (ResourceProviderContext): - (WebKit::ResourceProviderContext::insertSyncPoint): - (WebKit::ResourceProviderContext::waitSyncPoint): - (WebKit::ResourceProviderContext::genMailboxCHROMIUM): - (WebKit::ResourceProviderContext::produceTextureCHROMIUM): - (WebKit::ResourceProviderContext::consumeTextureCHROMIUM): - (WebKit::ResourceProviderContext::ResourceProviderContext): - (PendingProduceTexture): - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - (CCResourceProviderTest): - (WebKit::TEST_F): - -2012-08-16 David Grogan <dgrogan@chromium.org> - - IndexedDB: Frontend and plumbing for integer versions - https://bugs.webkit.org/show_bug.cgi?id=92897 - - Reviewed by Tony Chang. - - * src/IDBCallbacksProxy.cpp: - (WebKit::IDBCallbacksProxy::onBlocked): - (WebKit): - (WebKit::IDBCallbacksProxy::onUpgradeNeeded): - * src/IDBCallbacksProxy.h: - (IDBCallbacksProxy): - * src/IDBDatabaseBackendProxy.cpp: - (WebKit::IDBDatabaseBackendProxy::setVersion): - * src/IDBDatabaseCallbacksProxy.cpp: - (WebKit::IDBDatabaseCallbacksProxy::onVersionChange): - (WebKit): - * src/IDBDatabaseCallbacksProxy.h: - (IDBDatabaseCallbacksProxy): - * src/IDBFactoryBackendProxy.cpp: - (WebKit::IDBFactoryBackendProxy::open): - * src/IDBFactoryBackendProxy.h: - (IDBFactoryBackendProxy): - * src/IDBTransactionCallbacksProxy.cpp: - (WebKit::IDBTransactionCallbacksProxy::onComplete): - * src/WebIDBCallbacksImpl.cpp: - (WebKit::WebIDBCallbacksImpl::WebIDBCallbacksImpl): - (WebKit::WebIDBCallbacksImpl::onSuccess): - We don't want to create IDBDatabaseBackendProxy again if we've already - created it during upgradeNeeded. This makes - IDBRequest::onSuccess(IDBDatabaseBackend) reuse its previous - IDBDatabaseBackendInterface if it has one. - - (WebKit::WebIDBCallbacksImpl::onBlocked): - (WebKit): - (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): - * src/WebIDBCallbacksImpl.h: - (WebIDBCallbacksImpl): - * src/WebIDBDatabaseCallbacksImpl.cpp: - (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange): - (WebKit): - * src/WebIDBDatabaseCallbacksImpl.h: - (WebIDBDatabaseCallbacksImpl): - * src/WebIDBDatabaseImpl.cpp: - (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): - (WebKit::WebIDBDatabaseImpl::close): - (WebKit::WebIDBDatabaseImpl::open): - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - * src/WebIDBFactoryImpl.cpp: - (WebKit::WebIDBFactoryImpl::open): - * src/WebIDBFactoryImpl.h: - (WebIDBFactoryImpl): - * src/WebIDBTransactionCallbacksImpl.cpp: - (WebKit::WebIDBTransactionCallbacksImpl::onComplete): - * tests/IDBAbortOnCorruptTest.cpp: - (WebCore::TEST): - * tests/IDBDatabaseBackendTest.cpp: - -2012-08-16 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r125838. - http://trac.webkit.org/changeset/125838 - https://bugs.webkit.org/show_bug.cgi?id=94283 - - Breaks Mac compile due to bug 74625 (Requested by enne on - #webkit). - - * tests/CCResourceProviderTest.cpp: - (WebKit::ResourceProviderContext::create): - (WebKit::ResourceProviderContext::textureSize): - (ResourceProviderContext): - (WebKit::ResourceProviderContext::ResourceProviderContext): - (WebKit::ResourceProviderContext::Texture::Texture): - (Texture): - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - (CCResourceProviderTest): - (WebKit::TEST_F): - -2012-08-16 Kenneth Russell <kbr@google.com> - - Unreviewed, rolling out r125800. - http://trac.webkit.org/changeset/125800 - https://bugs.webkit.org/show_bug.cgi?id=84281 - - Hypothesis that this change caused gpu_throughput_tests to - start timing out on all platforms on the Chromium GPU - canaries. - - * tests/CCSchedulerTest.cpp: - (WebKitTests::TEST): - * tests/CCSchedulerTestCommon.h: - (WebKitTests::FakeCCTimeSource::FakeCCTimeSource): - (FakeCCTimeSource): - * tests/CCTextureUpdateControllerTest.cpp: - -2012-08-16 Antoine Labour <piman@chromium.org> - - [chromium] Add resource transfer functions to CCResourceProvider - https://bugs.webkit.org/show_bug.cgi?id=93524 - - Reviewed by James Robinson. - - This adds methods to CCResourceProvider to be able to transport - resources from a child to a parent. - - Added test to CCResourceProviderTest. - - * tests/CCResourceProviderTest.cpp: - (WebKit::textureSize): - (WebKit): - (WebKit::Texture::Texture): - (Texture): - (ContextSharedData): - (WebKit::ContextSharedData::create): - (WebKit::ContextSharedData::insertSyncPoint): - (WebKit::ContextSharedData::genMailbox): - (WebKit::ContextSharedData::produceTexture): - (WebKit::ContextSharedData::consumeTexture): - (WebKit::ContextSharedData::ContextSharedData): - (WebKit::ResourceProviderContext::create): - (ResourceProviderContext): - (WebKit::ResourceProviderContext::insertSyncPoint): - (WebKit::ResourceProviderContext::waitSyncPoint): - (WebKit::ResourceProviderContext::genMailboxCHROMIUM): - (WebKit::ResourceProviderContext::produceTextureCHROMIUM): - (WebKit::ResourceProviderContext::consumeTextureCHROMIUM): - (WebKit::ResourceProviderContext::ResourceProviderContext): - (PendingProduceTexture): - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - (CCResourceProviderTest): - (WebKit::TEST_F): - -2012-08-16 Alexandre Elias <aelias@google.com> - - [chromium] Replace destRect with destOffset in texture upload - https://bugs.webkit.org/show_bug.cgi?id=94154 - - Reviewed by James Robinson. - - Previously, texture upload code implicitly assumed that sourceRect and - destRect have the same size. The behavior is undefined if they are - different, since they are used interchangeably and there's no support - for scaling from one rect to the other. This patch enforces that - constraint at the interface level by replacing all instances of - "IntRect destRect" by "IntSize destOffset". - - * tests/CCResourceProviderTest.cpp: - (WebKit::TEST_F): - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): - * tests/CCTiledLayerTestCommon.h: - (Texture): - (WebKitTests::FakeTextureUploader::uploadTexture): - -2012-08-16 James Robinson <jamesr@chromium.org> - - [chromium] Remove unnecessary tree hierarchy inspection APIs from WebLayer - https://bugs.webkit.org/show_bug.cgi?id=94229 - - Reviewed by Adrienne Walker. - - Remove dead WebLayer function implementations and tests of same. - - * src/WebLayer.cpp: - * tests/WebLayerTest.cpp: - -2012-08-16 David Reveman <reveman@chromium.org> - - [Chromium] Avoid aliasing global symbol monotonicallyIncreasingTime(). - https://bugs.webkit.org/show_bug.cgi?id=94233 - - Reviewed by James Robinson. - - * tests/CCDelayBasedTimeSourceTest.cpp: - (WebKitTests::TEST): - * tests/CCFrameRateControllerTest.cpp: - (WebKitTests::TEST): - * tests/CCSchedulerTestCommon.h: - (WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicTimeNow): - (WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource): - (FakeCCDelayBasedTimeSource): - -2012-08-16 David Reveman <reveman@chromium.org> - - [Chromium] Schedule texture uploads based on hard-coded timer and vsync. - https://bugs.webkit.org/show_bug.cgi?id=84281 - - Reviewed by James Robinson. - - * tests/CCSchedulerTest.cpp: - (WebKitTests::TEST): - * tests/CCSchedulerTestCommon.h: - (WebKitTests::FakeCCTimeSource::FakeCCTimeSource): - (WebKitTests::FakeCCTimeSource::setNextTickTime): - (FakeCCTimeSource): - * tests/CCTextureUpdateControllerTest.cpp: - -2012-08-16 Dana Jansens <danakj@chromium.org> - - [chromium] Impl scrolling crashes when the renderer's initialization failed - https://bugs.webkit.org/show_bug.cgi?id=94232 - - Reviewed by James Robinson. - - Also updated the finishAllRenderingAfterContextLost to properly fail - renderer initialization. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-16 Peter Beverloo <peter@chromium.org> - - [Chromium] Pass the --strip-binary argument to the apk test generator - https://bugs.webkit.org/show_bug.cgi?id=94224 - - Reviewed by Adam Barth. - - The native test generator currently relies on the $STRIP environment - variable to be available, which it shouldn't do. Instead, pass it as an - argument to the script. The $STRIP variable is being deprecated. - - * WebKitUnitTests.gyp: - -2012-08-16 James Robinson <jamesr@chromium.org> - - [chromium] Remove alwaysReserveTextures code - it doesn't do anything - https://bugs.webkit.org/show_bug.cgi?id=94183 - - Reviewed by Dimitri Glazkov. - - Stops attempting to find the scrollbar layers and call setAlwaysReserveTextures() on them since the call doesn't - do anything. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::setViewport): - * src/WebLayer.cpp: - -2012-08-16 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-16 Keishi Hattori <keishi@webkit.org> - - DOMWindowPagePopup needs to be installed before loading the html inside the page popup - https://bugs.webkit.org/show_bug.cgi?id=94193 - - Reviewed by Kent Tamura. - - We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html. - - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::initPage): - -2012-08-16 Marja Hölttä <marja@chromium.org> - - WebHistoryItem: Enable reading selected file names from document state - https://bugs.webkit.org/show_bug.cgi?id=91231 - - Reviewed by Jochen Eisinger. - - This change enables Chromium to set up file permissions properly when - the session restore feature restores a page with selected files. - - * public/WebHistoryItem.h: - (WebHistoryItem): Added getReferencedFilePaths. - * src/WebHistoryItem.cpp: - (WebKit::WebHistoryItem::getReferencedFilePaths): Extracts selected and posted file paths from a document state. - (WebKit): - -2012-08-15 Shawn Singh <shawnsingh@chromium.org> - - [chromium] set scissorRect per quad so that quads are correctly clipped - https://bugs.webkit.org/show_bug.cgi?id=94050 - - Reviewed by Adrienne Walker. - - Updated two unit tests to reflect that we need to always scissor, - until we refactor so that quads do not depend on scissoring. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-16 Hironori Bono <hbono@chromium.org> - - Prevent showing suggestions when right-clicking a selection range. - https://bugs.webkit.org/show_bug.cgi?id=94189 - - Reviewed by Hajime Morita. - - To emulate Safari, my r120810 changes selection when right-clicking a misspelled - word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange - and it changes the existing selection when right-clicking a selection which - includes a misspelled word. This change uses VisibleSelection::isCaret to - prevent showing suggestions when right-clicking a selection range. (Neither does - Safari show suggestions when there is a selection range.) - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): - -2012-08-15 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-15 Ryosuke Niwa <rniwa@webkit.org> - - Update manual tests and comments to refer to TestRunner instead of LayoutTestController - https://bugs.webkit.org/show_bug.cgi?id=94168 - - Reviewed by Kent Tamura. - - * public/WebDevToolsAgent.h: - (WebDevToolsAgent): - * public/WebView.h: - (WebView): - -2012-08-15 Alec Flett <alecflett@chromium.org> - - IndexedDB: generate index keys for existing data in createIndex in front end - https://bugs.webkit.org/show_bug.cgi?id=91125 - - Reviewed by Tony Chang. - - Add Chromium API methods to let the renderer process tell the - browser process about indexing progress. - - * public/WebIDBObjectStore.h: - (WebKit::WebIDBObjectStore::openCursor): - * src/IDBObjectStoreBackendProxy.cpp: - (WebKit::IDBObjectStoreBackendProxy::setIndexKeys): - (WebKit): - (WebKit::IDBObjectStoreBackendProxy::setIndexesReady): - (WebKit::IDBObjectStoreBackendProxy::openCursor): - * src/IDBObjectStoreBackendProxy.h: - (IDBObjectStoreBackendProxy): - * src/WebIDBObjectStoreImpl.cpp: - (WebKit::WebIDBObjectStoreImpl::setIndexKeys): - (WebKit): - (WebKit::WebIDBObjectStoreImpl::setIndexesReady): - (WebKit::WebIDBObjectStoreImpl::openCursor): - * src/WebIDBObjectStoreImpl.h: - (WebIDBObjectStoreImpl): - -2012-08-15 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> - - [css3-text] Add CSS3 Text decoration compile flag - https://bugs.webkit.org/show_bug.cgi?id=93863 - - Reviewed by Julien Chaffraix. - - This patch handles the compile flag implementation, which will come disabled by - default, thus not exposing the CSS3 text decoration features to the web, unless - when explicitly enabling it with "--css3-text-decoration" build parameter. - - * features.gypi: - -2012-08-15 Iain Merrick <husky@chromium.org> - - Refactoring: move EventHandler::targetNode into HitTestResult - https://bugs.webkit.org/show_bug.cgi?id=94107 - - Reviewed by Dimitri Glazkov. - - This static helper method in EventHandler was made public so that - WebFrameImpl can call it. That's untidy because EventHandler isn't - really involved. This patch turns it into an instance method of - HitTestResult (with a wrapper in MouseEventWithHitTestResult for - convenience). - - Pure refactoring, no behavior change, no new test needed. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::visiblePositionForWindowPoint): - -2012-08-15 David Grogan <dgrogan@chromium.org> - - IndexedDB: Add some ASSERTs - https://bugs.webkit.org/show_bug.cgi?id=94055 - - Reviewed by Ojan Vafai. - - * src/IDBDatabaseBackendProxy.cpp: - (WebKit::IDBDatabaseBackendProxy::setVersion): - -2012-08-15 Ian Vollick <vollick@chromium.org> - - [chromium] Must account for empty transformation lists when checking for big rotations. - https://bugs.webkit.org/show_bug.cgi?id=93975 - - Reviewed by James Robinson. - - Adds a test to check that creating an animation with a big (> 180 - degree) rotation, where the transform operations list in the 1st - keyframe is empty fails as expected. - - * tests/AnimationTranslationUtilTest.cpp: - (WebKit::TEST): - (WebKit): - -2012-08-15 Joshua Bell <jsbell@chromium.org> - - [chromium] IndexedDB: Delete unused WebKit API cursor accessors - https://bugs.webkit.org/show_bug.cgi?id=94134 - - Reviewed by Adam Barth. - - Last bit of refactor work from http://webkit.org/b/92278 that ships the - cursor key/primaryKey/value to the front end via success messages, eliminating - the need for these accessors and the old success messages. - - * public/WebIDBCallbacks.h: - * public/WebIDBCursor.h: - -2012-08-15 Anna Cavender <annacc@chromium.org> - - Add the timestampOffset attribute to SourceBuffer. - https://bugs.webkit.org/show_bug.cgi?id=93303 - - Reviewed by Dimitri Glazkov. - - On the 30 July 2012 version of the Media Source Extensions spec, a timestampOffset - attribute was added to the SourceBuffer object: - http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#dom-timestampoffset - - * public/WebMediaPlayer.h: - (WebKit::WebMediaPlayer::sourceSetTimestampOffset): Add the new method. - * src/WebMediaPlayerClientImpl.cpp: - (WebKit): - (WebKit::WebMediaPlayerClientImpl::sourceSetTimestampOffset): Forward the call. - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-08-15 Peter Beverloo <peter@chromium.org> - - [Chromium] Roll WebKit Chromium DEPS to r151672 - https://bugs.webkit.org/show_bug.cgi?id=94091 - - Unreviewed DEPS roll. - - This also adds the new dependency on third_party/skia/gyp/, as was - introduced in Chromium's revision 151463. - - * DEPS: - -2012-08-14 Keishi Hattori <keishi@webkit.org> - - Share common code between calendar picker and color suggestion picker - https://bugs.webkit.org/show_bug.cgi?id=93802 - - Reviewed by Kent Tamura. - - * src/ColorChooserUIController.cpp: - (WebKit::ColorChooserUIController::writeDocument): - -2012-08-14 Scott Graham <scottmg@chromium.org> - - [Chromium] Fix warnings on Windows build - https://bugs.webkit.org/show_bug.cgi?id=93997 - - Reviewed by Kentaro Hara. - - Fixes truncation from 'double' to 'float' warnings on Chromium Windows - build. - - * tests/CCRenderSurfaceFiltersTest.cpp: - (WebKit::TEST): - * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: - (WebCore::TEST_F): - -2012-08-14 Chris Rogers <crogers@google.com> - - Implement new synchronized audio I/O render method in chromium - https://bugs.webkit.org/show_bug.cgi?id=93510 - - Reviewed by Kenneth Russell. - - The chromium implementation of AudioDestination is being upgraded to - support synchronized audio I/O. Other changes on the chromium-side - can then be tested against something that works in WebKit. - - * src/AudioDestinationChromium.cpp: - (WebCore::AudioDestinationChromium::AudioDestinationChromium): - (WebCore::AudioDestinationChromium::render): - (WebCore): - (WebCore::AudioDestinationChromium::provideInput): - * src/AudioDestinationChromium.h: - (WebCore): - (AudioDestinationChromium): - -2012-08-14 Adam Barth <abarth@webkit.org> - - Delete Frame::domWindow() and Frame::existingDOMWindow() - https://bugs.webkit.org/show_bug.cgi?id=93990 - - Reviewed by Eric Seidel. - - * src/StorageAreaProxy.cpp: - (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): - (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): - * src/WebDOMMessageEvent.cpp: - (WebKit::WebDOMMessageEvent::initMessageEvent): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::performance): - (WebKit::WebFrameImpl::addMessageToConsole): - (WebKit::WebFrameImpl::unloadListenerCount): - (WebKit::WebFrameImpl::addEventListener): - (WebKit::WebFrameImpl::removeEventListener): - (WebKit::WebFrameImpl::dispatchEvent): - (WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck): - (WebKit::WebFrameImpl::deliverIntent): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::initPage): - -2012-08-14 Iain Merrick <husky@chromium.org> - - [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint. - https://bugs.webkit.org/show_bug.cgi?id=93108 - - Reviewed by Adam Barth. - - Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange, - and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is - used by selectRange. - - The test uses sample files that contain selected text on load. The test uses - WebViewImpl::selectionBounds to get the coordinates, deselects all, then - calls WebFrameImpl::selectRange to attempt to reselect the same text. - - Four cases are tested: - - the basic case - - the case where the selected text is offscreen due to a scroll - - the case where the selected text is in an iframe - - the case where the selected text is in an editable element - - * tests/WebFrameTest.cpp: - * tests/data/select_range_basic.html: Added. - * tests/data/select_range_editable.html: Added. - * tests/data/select_range_iframe.html: Added. - * tests/data/select_range_scroll.html: Added. - -2012-08-14 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Pass cursor continue results back in callback - https://bugs.webkit.org/show_bug.cgi?id=92278 - - Reviewed by Tony Chang. - - Supply the updated cursor key/primaryKey/value in the success callback, - rather than forcing the callee to make three calls into the back end to - fetch them. Callbacks onSuccess(cursor) and onSuccessWithContinuation() - are given the three new payload parameters (and the latter is renamed.) - - * public/WebIDBCallbacks.h: - (WebIDBCallbacks): - (WebKit::WebIDBCallbacks::onSuccess): Replace with no-op stub. - (WebKit::WebIDBCallbacks::onSuccessWithContinuation): Ditto. - * public/WebIDBCursor.h: - (WebIDBCursor): Methods can be removed once Chromium is cleaned up. - * src/IDBCallbacksProxy.cpp: Updated callbacks. - (WebKit::IDBCallbacksProxy::onSuccess): - (WebKit): - * src/IDBCallbacksProxy.h: Updated callbacks. - (IDBCallbacksProxy): - * src/IDBCursorBackendProxy.cpp: Remove back end accessors. - * src/IDBCursorBackendProxy.h: - (IDBCursorBackendProxy): - * src/WebIDBCallbacksImpl.cpp: Updated callbacks. - (WebKit::WebIDBCallbacksImpl::onSuccess): - * src/WebIDBCallbacksImpl.h: Updated callbacks. - (WebIDBCallbacksImpl): - * src/WebIDBCursorImpl.cpp: Remove back end accessors. - * src/WebIDBCursorImpl.h: Remove back end accessors. - (WebIDBCursorImpl): - * tests/IDBAbortOnCorruptTest.cpp: Update test stubs. - (WebCore::MockIDBCallbacks::onSuccess): - * tests/IDBDatabaseBackendTest.cpp: Ditto. - * tests/IDBRequestTest.cpp: Ditto. - -2012-08-14 Peter Beverloo <peter@chromium.org> - - [Chromium] Remove unneeded build logic for Android - https://bugs.webkit.org/show_bug.cgi?id=93962 - - Reviewed by Dimitri Glazkov. - - The Android SDK and NDK have been checked in to the Chromium tree, which - allows WebKit to leverage those as well. They will already be pulled in - through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT - environment variable, the envsetup.sh will set the project files up - appropriately for us. - - * DEPS: - -2012-08-14 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-14 Peter Beverloo <peter@chromium.org> - - [Chromium] Fix apk generation for the Android platform - https://bugs.webkit.org/show_bug.cgi?id=93841 - - Unreviewed build fix (step 2). - - The path from webkit_unit_tests isn't robust enough. Use the same - convention as the Chromium side, i.e. walk up from the ant_build_out path. - One-line Android-only gyp change. - - * WebKitUnitTests.gyp: - -2012-08-14 Peter Beverloo <peter@chromium.org> - - [Chromium] Fix apk generation for the Android platform - https://bugs.webkit.org/show_bug.cgi?id=93841 - - Unreviewed build fix. - - APK generation was broken as the configuration file assumed compilation - would only occur in the Chromium tree. Pass the path to Chromium's source - base directory as a property to ant. - - * WebKitUnitTests.gyp: - -2012-08-13 Tom Sepez <tsepez@chromium.org> - - [chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach. - https://bugs.webkit.org/show_bug.cgi?id=93283 - - Reviewed by Eric Seidel. - - Change the client redirectDataToPlugin method(s) to expect the possibility of - a NULL argument, NULLing Chromium's refptr that needs to be NULLed. - - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::redirectDataToPlugin): - -2012-08-13 Eric Penner <epenner@google.com> - - [chromium] Paint animated layers immediately to avoid animation hiccups. - https://bugs.webkit.org/show_bug.cgi?id=93028 - - Reviewed by Adrienne Walker. - - Replaced one test. Test painting full animated layer. - - * tests/TiledLayerChromiumTest.cpp: - -2012-08-12 Shawn Singh <shawnsingh@chromium.org> - - [chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds - https://bugs.webkit.org/show_bug.cgi?id=93795 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-08-13 James Robinson <jamesr@chromium.org> - - [chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols - https://bugs.webkit.org/show_bug.cgi?id=93907 - - Reviewed by Darin Fisher. - - Adds a WebAnimationImpl implementation of the WebAnimation interface. - - * WebKit.gyp: - * src/WebAnimationImpl.cpp: Renamed from Source/WebKit/chromium/src/WebAnimation.cpp. - (WebKit): - (WebKit::WebAnimation::create): - (WebKit::WebAnimationImpl::targetProperty): - (WebKit::WebAnimationImpl::iterations): - (WebKit::WebAnimationImpl::setIterations): - (WebKit::WebAnimationImpl::startTime): - (WebKit::WebAnimationImpl::setStartTime): - (WebKit::WebAnimationImpl::timeOffset): - (WebKit::WebAnimationImpl::setTimeOffset): - (WebKit::WebAnimationImpl::alternatesDirection): - (WebKit::WebAnimationImpl::setAlternatesDirection): - (WebKit::WebAnimationImpl::cloneToCCAnimation): - * src/WebAnimationImpl.h: Added. - (WebCore): - (WebKit): - (WebAnimationImpl): - (WebKit::WebAnimationImpl::WebAnimationImpl): - (WebKit::WebAnimationImpl::~WebAnimationImpl): - * src/WebLayer.cpp: - (WebKit::WebLayer::addAnimation): - * tests/WebAnimationTest.cpp: - (WebKit::TEST): - -2012-08-10 James Robinson <jamesr@chromium.org> - - [chromium] Clean up dependencies for Canvas2DLayerBridgeTest and GraphicsLayerChromiumTest unit tests - https://bugs.webkit.org/show_bug.cgi?id=93757 - - Reviewed by Adrienne Walker. - - Breaks up some unit tests and removes unused code to avoid unit tests depending on both non-compositor WebCore - logic and compositor internals. Canvas2DLayerBridgeTest had some vestigal includes and local variables that - weren't being used, those are removed. GraphicsLayerChromiumTest was reaching into CC types, but could mostly - use Platform API types for testing. - - GraphicsLayerChromiumTest had some tests that were verifying that we could correctly translate WebCore - animation lists into CCAnimation types - these have been moved into AnimationTranslationUtilTest.cpp, since the - logic under test is in AnimationTranslationUtil. Currently these only test that we accept / reject animations as - expected. They could be expanded to verify that the animation was translated faithfully, but that would require - expanding the information exposed on WebAnimation. - - * WebKit.gypi: - * src/WebLayer.cpp: - (WebKit::WebLayer::hasActiveAnimation): - (WebKit): - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - * tests/GraphicsLayerChromiumTest.cpp: - (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): - (GraphicsLayerChromiumTest): - (WebKit::TEST_F): - * tests/WebLayerTreeViewTest.cpp: - * tests/WebLayerTreeViewTestCommon.h: Added. - (WebKit): - (MockWebLayerTreeViewClient): - -2012-08-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r125422. - http://trac.webkit.org/changeset/125422 - https://bugs.webkit.org/show_bug.cgi?id=93902 - - Broke the Android canary build (Requested by fmalita on - #webkit). - - * WebKitUnitTests.gyp: - -2012-08-13 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Fix nits in the find-in-page match rects API - https://bugs.webkit.org/show_bug.cgi?id=93817 - - Reviewed by Adam Barth. - - This patch fixes a few pending nits from 93111. - - * src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument. - (WebKit::toNormalizedRect): - (WebKit::findInPageRectFromAbsoluteRect): - -2012-08-13 Peter Beverloo <peter@chromium.org> - - [Chromium] Fix apk generation for the Android platform - https://bugs.webkit.org/show_bug.cgi?id=93841 - - Reviewed by Dimitri Glazkov. - - APK generation was broken as the configuration file assumed compilation - would only occur in the Chromium tree. Pass the path to Chromium's source - base directory as a property to ant. - - * WebKitUnitTests.gyp: - -2012-08-13 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-13 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-10 Kinuko Yasuda <kinuko@chromium.org> - - Support creating File object from FileSystem URL for files in FileSystem API - https://bugs.webkit.org/show_bug.cgi?id=93706 - - Reviewed by Darin Fisher. - - * src/WebBlobData.cpp: - (WebKit::WebBlobData::itemAt): - -2012-08-12 Yuta Kitamura <yutak@google.com> - - Unreviewed. Fix Chromium's Android build. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::find): Needs parentheses for a function call. - -2012-08-12 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Implement the find-in-page match rects API - https://bugs.webkit.org/show_bug.cgi?id=93111 - - Reviewed by Adam Barth. - - Implement the funcionality of the find-in-page match rects API in WebFrame. - These methods keep a cache of the match rects in a special coordinate system - (find-in-page coordinates) and update them on size changes. They also allow - to recover the match closest to a given point, therefore enabling to move - to find matches when tapping on their corresponding tickmarks. - - * WebKit.gyp: add FindInPageCoordinates.h / cpp. - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl. - * src/FindInPageCoordinates.cpp: Added. - (WebKit): - (WebKit::toNormalizedRect): auxiliary internal function. - (WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function. - (WebKit::findInPageRectFromRange): convenience conversion function for Ranges. - * src/FindInPageCoordinates.h: Added. - (WebCore): - (WebKit): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor. - (WebKit): - (WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port. - (WebKit::WebFrameImpl::stopFinding): clear matches cache. - (WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache. - (WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version. - (WebKit::WebFrameImpl::resetMatchCount): update the matches cache version. - (WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version. - (WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache. - (WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree. - (WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required. - (WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates. - (WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates. - (WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames. - (WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates. - (WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame. - (WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache. - (WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables. - (WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes. - * src/WebFrameImpl.h: - (WebCore): - (WebFrameImpl): - (WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const. - (WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing. - (FindMatch): cache structure for find matches. - * tests/WebFrameTest.cpp: new test case for find-in-page match rects. - * tests/data/find_in_page.html: Added. Test case layout. - * tests/data/find_in_page_frame.html: Added. Test case layout. - -2012-08-09 James Robinson <jamesr@chromium.org> - - [chromium] Remove forwarding headers for compositor-related WebKit API and update includes - https://bugs.webkit.org/show_bug.cgi?id=93669 - - Reviewed by Adam Barth. - - This updates all includes for compositor-related headers to refer consistently to the Platform API location and - removes the now-unneeded forwarding headers in the client API location. I also updated and resorted other - platform API includes in modified header blocks. - - * WebKit.gyp: - * public/WebCompositor.h: Removed. - * public/platform/WebContentLayer.h: Removed. - * public/platform/WebContentLayerClient.h: Removed. - * public/platform/WebExternalTextureLayer.h: Removed. - * public/platform/WebLayer.h: Removed. - * public/platform/WebLayerTreeView.h: Removed. - * public/platform/WebLayerTreeViewClient.h: Removed. - * public/platform/WebSolidColorLayer.h: Removed. - * src/WebCompositorInputHandlerImpl.h: - * src/WebContentLayerImpl.cpp: - * src/WebLayer.cpp: - * src/WebLayerTreeView.cpp: - * src/WebLayerTreeViewImpl.cpp: - * src/WebLayerTreeViewImpl.h: - * src/WebSolidColorLayer.cpp: - * src/WebViewImpl.h: - * tests/Canvas2DLayerBridgeTest.cpp: - * tests/GraphicsLayerChromiumTest.cpp: - * tests/TextureLayerChromiumTest.cpp: - -2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-10 Iain Merrick <husky@google.com> - - [chromium] Upstream Android changes to WebFrameImpl::selectRange - https://bugs.webkit.org/show_bug.cgi?id=92513 - - Reviewed by Ryosuke Niwa. - - This change is driven by the Chromium port on the Android platform, - but it should be suitable for other touch-based platforms. We reuse - selectionExtentRespectingEditingBoundary (extracted from EventHandler - into VisibleSelection). - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::selectRange): - (WebKit::WebFrameImpl::visiblePositionForWindowPoint): - -2012-08-10 Dana Jansens <danakj@chromium.org> - - [chromium] Remove targetSurface pointer from CCRenderPass - https://bugs.webkit.org/show_bug.cgi?id=93734 - - Reviewed by Adrienne Walker. - - Use the RenderPass's damageRect instead of the surface's damageRect - directly to test the same things without requiring a pointer to - the surface that generated the RenderPass. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r125310. - http://trac.webkit.org/changeset/125310 - https://bugs.webkit.org/show_bug.cgi?id=93739 - - The DEPS roll broke Android. One does not simply break - Android. (Requested by fmalita_ on #webkit). - - * DEPS: - -2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-10 Dana Jansens <danakj@chromium.org> - - [chromium] Remove scissor from the namings in CCOcclusionTracker - https://bugs.webkit.org/show_bug.cgi?id=93630 - - Reviewed by Adrienne Walker. - - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::TestCCOcclusionTrackerWithClip::TestCCOcclusionTrackerWithClip): - (WebKitTests::TestCCOcclusionTrackerWithClip::setLayerClipRect): - (WebKitTests::TestCCOcclusionTrackerWithClip::useDefaultLayerClipRect): - (WebKitTests::TestCCOcclusionTrackerWithClip::layerClipRectInTarget): - (TestCCOcclusionTrackerWithClip): - (WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest): - (WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): - (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerClipRectOutsideChild::runMyTest): - (WebKitTests): - (WebKitTests::CCOcclusionTrackerTestViewportRectOutsideChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerClipRectOverChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestViewportRectOverChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerClipRectPartlyOverChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestViewportRectPartlyOverChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerClipRectOverNothing::runMyTest): - (WebKitTests::CCOcclusionTrackerTestViewportRectOverNothing::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerClipRectForLayerOffOrigin::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest): - (WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest): - (WebKitTests::CCOcclusionTrackerTestUnsorted3dLayers::runMyTest): - (WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest): - (WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToViewport::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest): - * tests/TiledLayerChromiumTest.cpp: - -2012-08-10 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r125230 and r125238. - http://trac.webkit.org/changeset/125230 - http://trac.webkit.org/changeset/125238 - https://bugs.webkit.org/show_bug.cgi?id=93698 - - Broke ChromiumOS browser tests. (Requested by yutak on - #webkit). - - * tests/TiledLayerChromiumTest.cpp: - -2012-08-09 Eric Penner <epenner@google.com> - - [chromium] Paint animated layers immediately to avoid animation hiccups. - https://bugs.webkit.org/show_bug.cgi?id=93028 - - Reviewed by Adrienne Walker. - - Replaced one test. Test painting full animated layer. - - * tests/TiledLayerChromiumTest.cpp: - -2012-08-09 Nat Duca <nduca@chromium.org> - - [chromium] Remove missing files from WebKit.gyp introduced by r125219 - https://bugs.webkit.org/show_bug.cgi?id=93671 - - Unreviewed. Fixing windows build. - - * WebKit.gyp: - -2012-08-09 Alec Flett <alecflett@chromium.org> - - IndexedDB: add AssertMatchingEnums for Direction and TaskType - https://bugs.webkit.org/show_bug.cgi?id=93618 - - Reviewed by Tony Chang. - - These chromium enums were introduced in a separate patch. - - * src/AssertMatchingEnums.cpp: - -2012-08-06 Nat Duca <nduca@chromium.org> - - [chromium] Expose CCGraphicsContext as WebCompositorOutputSurface - https://bugs.webkit.org/show_bug.cgi?id=92890 - - Reviewed by James Robinson. - - * WebKit.gyp: - * WebKit.gypi: - * public/WebSettings.h: - * public/WebViewClient.h: - (WebKit): - (WebViewClient): - (WebKit::WebViewClient::createOutputSurface): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): - * src/WebLayerTreeViewImpl.cpp: - (WebKit): - (WebGraphicsContextToOutputSurfaceAdapter): - (WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter): - (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::WebSettingsImpl): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit::WebViewImpl::createOutputSurface): - (WebKit): - (WebKit::WebViewImpl::didRebindGraphicsContext): - (WebKit::WebViewImpl::didRecreateOutputSurface): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF): - (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface): - (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface): - * tests/CCResourceProviderTest.cpp: - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCThreadedTest.cpp: - (WebKitTests::TestHooks::createOutputSurface): - * tests/CCThreadedTest.h: - (WebKitTests::TestHooks::didRecreateOutputSurface): - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - * tests/FakeCCGraphicsContext.h: - (WebKit::createFakeCCGraphicsContext): - * tests/FakeCCLayerTreeHostClient.h: - * tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h. - (WebKit): - (FakeWebCompositorOutputSurface): - (WebKit::FakeWebCompositorOutputSurface::create): - (WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface): - * tests/LayerRendererChromiumTest.cpp: - (LayerRendererChromiumTest::LayerRendererChromiumTest): - (TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-09 Nat Duca <nduca@chromium.org> - - Unreviewed, rolling out r125212. - http://trac.webkit.org/changeset/125212 - https://bugs.webkit.org/show_bug.cgi?id=92890 - - Compile failure on mac dbg builder - - * WebKit.gyp: - * WebKit.gypi: - * public/WebSettings.h: - * public/WebViewClient.h: - (WebKit): - (WebViewClient): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::WebSettingsImpl): - (WebKit::WebSettingsImpl::setForceSoftwareCompositing): - (WebKit): - * src/WebSettingsImpl.h: - (WebKit::WebSettingsImpl::forceSoftwareCompositing): - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit::WebViewImpl::createCompositorGraphicsContext3D): - (WebKit::WebViewImpl::createContext3D): - (WebKit::WebViewImpl::didRebindGraphicsContext): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF): - (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateContext): - (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateContext): - * tests/CCResourceProviderTest.cpp: - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCThreadedTest.cpp: - (WebKitTests::TestHooks::createContext): - * tests/CCThreadedTest.h: - (WebKitTests::TestHooks::didRecreateContext): - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - * tests/FakeCCGraphicsContext.h: - (WebKit::createFakeCCGraphicsContext): - * tests/FakeCCLayerTreeHostClient.h: - * tests/FakeWebCompositorOutputSurface.h: Removed. - * tests/LayerRendererChromiumTest.cpp: - (LayerRendererChromiumTest::LayerRendererChromiumTest): - (TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-09 Kentaro Hara <haraken@chromium.org> - - [V8] Rename V8BindingPerIsolateData to V8PerIsolateData - https://bugs.webkit.org/show_bug.cgi?id=93592 - - Reviewed by Adam Barth. - - For a better name. See discussion in bug 93333. - - No tests. No change in behavior. - - * src/WebKit.cpp: - (WebKit::initialize): - -2012-08-06 Nat Duca <nduca@chromium.org> - - [chromium] Expose CCGraphicsContext as WebCompositorOutputSurface - https://bugs.webkit.org/show_bug.cgi?id=92890 - - Reviewed by James Robinson. - - * WebKit.gyp: - * WebKit.gypi: - * public/WebSettings.h: - * public/WebViewClient.h: - (WebKit): - (WebViewClient): - (WebKit::WebViewClient::createOutputSurface): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): - * src/WebLayerTreeViewImpl.cpp: - (WebKit): - (WebGraphicsContextToOutputSurfaceAdapter): - (WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter): - (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::WebSettingsImpl): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit::WebViewImpl::createOutputSurface): - (WebKit): - (WebKit::WebViewImpl::didRebindGraphicsContext): - (WebKit::WebViewImpl::didRecreateOutputSurface): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF): - (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface): - (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface): - * tests/CCResourceProviderTest.cpp: - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCThreadedTest.cpp: - (WebKitTests::TestHooks::createOutputSurface): - * tests/CCThreadedTest.h: - (WebKitTests::TestHooks::didRecreateOutputSurface): - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - * tests/FakeCCGraphicsContext.h: - (WebKit::createFakeCCGraphicsContext): - * tests/FakeCCLayerTreeHostClient.h: - * tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h. - (WebKit): - (FakeWebCompositorOutputSurface): - (WebKit::FakeWebCompositorOutputSurface::create): - (WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface): - * tests/LayerRendererChromiumTest.cpp: - (LayerRendererChromiumTest::LayerRendererChromiumTest): - (TEST): - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-09 Alec Flett <alecflett@chromium.org> - - IndexedDB: additional chromium signature for openCursor - https://bugs.webkit.org/show_bug.cgi?id=93637 - - Reviewed by Adam Barth. - - Stub out the TaskType-based openCursor in the chromium API. - - * src/WebIDBObjectStoreImpl.cpp: - (WebKit::WebIDBObjectStoreImpl::openCursor): - * src/WebIDBObjectStoreImpl.h: - (WebKit::WebIDBObjectStoreImpl::openCursor): - (WebIDBObjectStoreImpl): - -2012-08-09 Dana Jansens <danakj@chromium.org> - - [chromium] Do partial-swap scissoring on quads during draw instead of on layers - https://bugs.webkit.org/show_bug.cgi?id=91800 - - Reviewed by Adrienne Walker. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::executeCalculateDrawTransformsAndVisibility): - * tests/CCLayerIteratorTest.cpp: - * tests/CCLayerTreeHostCommonTest.cpp: - Removed tests of the scissor rect here, as they are no longer - computed within CCLayerTreeHostCommon. Verify that the scissor - does not affect texture caching in CCLayerTreeHostImplTest now. - Previous scissor would affect the texture cache decisions, but - this was incorrect, as damaged areas are always inside the - scissor rect, and anything outside the scissor rect should - be considered as valid and complete (assuming no external - occlusion, which is computed outside the scissor rect now also). - - * tests/CCLayerTreeHostImplTest.cpp: - Removed didDrawNotCalledOnScissoredLayer test, as this no longer - applies. didDraw will be called on layers that are outside the - partial swap rect, regardless. - - Removed partialSwapNoUpdate test, and merged its functionality into - the partialSwap test while updating its expectations. - - Added textureCachingWithScissor, which is loosely based on the - CCLayerTreeHostCommonTest.scissorRectWithClip test. - - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): - (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): - * tests/CCQuadCullerTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::createLayer): - * tests/LayerRendererChromiumTest.cpp: - (LayerRendererChromiumTest::swapBuffers): - (TEST_F): - (TEST): - * tests/TiledLayerChromiumTest.cpp: - -2012-08-09 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Pass mask scale and offset to shaders for correct masking - https://bugs.webkit.org/show_bug.cgi?id=93558 - - Reviewed by Adrienne Walker. - - Updated one unit test that needed additional args in a - constructor, but no change in behavior of the test. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-09 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: add codemirror library as an experiment - https://bugs.webkit.org/show_bug.cgi?id=93620 - - Reviewed by Vsevolod Vlasov. - - * WebKit.gyp: - -2012-08-09 Peter Beverloo <peter@chromium.org> - - Unreviewed, rolling out r125171. - http://trac.webkit.org/changeset/125171 - - Broke the Chromium Android build. - - * DEPS: - -2012-08-09 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-09 Keishi Hattori <keishi@webkit.org> - - Page popups can show up at wrong locations - https://bugs.webkit.org/show_bug.cgi?id=93556 - - Reviewed by Kent Tamura. - - We were showing the popup at wrong positions. When there isn't enough - room below and above the element it adjusts the position but we weren't - resetting the adjustment when we resize the popup. This patch will make - the popup adjust the popup position each time we resize. - - * src/ColorChooserUIController.cpp: - (WebKit::ColorChooserUIController::contentSize): - * src/WebPagePopupImpl.cpp: - (WevKit::PagePopupChromeClient::setWindowRect): - (WebKit::WebPagePopupImpl::init): Use reposition(). - (WebKit::WebPagePopupImpl::reposition): Repositions the page popup based on the popup size. - (WebKit): - (WebKit::WebPagePopupImpl::resize): Use reposition(). - * src/WebPagePopupImpl.h: - (WebPagePopupImpl): - -2012-08-09 Peter Beverloo <peter@chromium.org> - - [Chromium] Pull in the android_tools directory for Android - https://bugs.webkit.org/show_bug.cgi?id=84843 - - Reviewed by Jochen Eisinger. - - Pull in the android_tools directory for Chromium Android checkouts. This - repository, living in Chromium's, contains checked in versions of the - Android NDK and SDK meant to make builds and updates easier. - - * DEPS: - -2012-08-08 Shane Stephens <shanestephens@google.com> - - Compile flag for CSS Hierarchies - https://bugs.webkit.org/show_bug.cgi?id=92433 - - Reviewed by Tony Chang. - - * features.gypi: - -2012-08-08 Kent Tamura <tkent@chromium.org> - - [Chromium-mac] Switch to LocalizedNumberMac from LocalizedNumberICU - https://bugs.webkit.org/show_bug.cgi?id=93432 - - Reviewed by Hajime Morita. - - * tests/LocaleMacTest.cpp: - Add some tests for number localization. They are similar to tests in - LocaleWinTest and LocalizedNumberICUTest.cpp - (LocaleMacTest): - (LocaleMacTest::decimalSeparator): - (TEST_F): - (testNumberIsReversible): - (testNumbers): - -2012-08-08 Adrienne Walker <enne@google.com> - - [chromium] Move scrollbar pointer into WebScrollbarThemePainter - https://bugs.webkit.org/show_bug.cgi?id=93541 - - Reviewed by James Robinson. - - Fix WebScrollbarThemePainter implementation to make direct calls on - the scrollbar rather than through the WebScrollbarThemeClientImpl - adapter. - - * src/WebScrollbarThemePainter.cpp: - (WebKit::WebScrollbarThemePainter::assign): - (WebKit::WebScrollbarThemePainter::paintScrollbarBackground): - (WebKit::WebScrollbarThemePainter::paintTrackBackground): - (WebKit::WebScrollbarThemePainter::paintBackTrackPart): - (WebKit::WebScrollbarThemePainter::paintForwardTrackPart): - (WebKit::WebScrollbarThemePainter::paintBackButtonStart): - (WebKit::WebScrollbarThemePainter::paintBackButtonEnd): - (WebKit::WebScrollbarThemePainter::paintForwardButtonStart): - (WebKit::WebScrollbarThemePainter::paintForwardButtonEnd): - (WebKit::WebScrollbarThemePainter::paintTickmarks): - (WebKit::WebScrollbarThemePainter::paintThumb): - (WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter): - * tests/ScrollbarLayerChromiumTest.cpp: - (WebCore::TEST): - -2012-08-08 Alexei Svitkine <asvitkine@chromium.org> - - [chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8 - https://bugs.webkit.org/show_bug.cgi?id=93535 - - Reviewed by Dimitri Glazkov. - - This enables putting two fingers on the track pad to show overlay scroll bars on 10.8+. - - * src/mac/WebInputEventFactory.mm: - (WebKit::phaseForNSEventPhase): - -2012-08-08 James Robinson <jamesr@chromium.org> - - [chromium] Fix up includes and types in chromium compositor unit tests - https://bugs.webkit.org/show_bug.cgi?id=93553 - - Reviewed by Adrienne Walker. - - This removes some unused GraphicsContext3DPrivate.h includes and adds some includes that were being implicitely - depending upon - mostly for wtf/PassOwnPtr.h. - - * tests/CCLayerTreeHostTest.cpp: - (::CCLayerTreeHostTestCommit::beginTest): - (::CCLayerTreeHostTestCommit::commitCompleteOnCCThread): - * tests/CCRenderSurfaceFiltersTest.cpp: - * tests/CompositorFakeWebGraphicsContext3D.h: - * tests/FakeGraphicsContext3DTest.cpp: - * tests/FakeWebScrollbarThemeGeometry.h: - * tests/TextureCopierTest.cpp: - * tests/ThrottledTextureUploaderTest.cpp: - -2012-08-08 Eric Penner <epenner@google.com> - - [chromium] Refactor tile flags. - https://bugs.webkit.org/show_bug.cgi?id=93059 - - Reviewed by Adrienne Walker. - - Minor fixes to existing tests. - - * tests/TiledLayerChromiumTest.cpp: - -2012-08-08 James Robinson <jamesr@chromium.org> - - [chromium] Clean up WebKit.h and WebKitPlatformSupport.h includes in chromium/src - https://bugs.webkit.org/show_bug.cgi?id=93539 - - Reviewed by Adam Barth. - - Most of these files don't need either WebKit.h or WebKitPlatformSupport.h. Some need <public/Platform.h>, and - some are relying on the forwarding headers. This updates includes to what is actually needed and points platform - includes at <public/Foo.h> instead of "platform/Foo.h" where possible. - - * src/ApplicationCacheHostInternal.h: - * src/AssociatedURLLoader.cpp: - * src/AsyncFileSystemChromium.cpp: - (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium): - * src/BlobRegistryProxy.cpp: - * src/ChromiumCurrentTime.cpp: - * src/ChromiumOSRandomSource.cpp: - * src/ChromiumThreading.cpp: - * src/EditorClientImpl.cpp: - * src/FrameLoaderClientImpl.cpp: - * src/IDBFactoryBackendProxy.cpp: - * src/LocalizedStrings.cpp: - * src/PlatformMessagePortChannel.cpp: - * src/WebCompositorInputHandlerImpl.cpp: - * src/WebMediaPlayerClientImpl.cpp: - * src/WebPluginContainerImpl.cpp: - * src/WebViewImpl.cpp: - * src/WebWorkerClientImpl.cpp: - * src/WorkerAsyncFileSystemChromium.cpp: - * src/WorkerFileWriterCallbacksBridge.cpp: - -2012-08-08 James Robinson <jamesr@chromium.org> - - [chromium] Clean up includes in compositor unit tests - https://bugs.webkit.org/show_bug.cgi?id=93531 - - Reviewed by Adrienne Walker. - - This removes unused includes and updates Platform API headers to use the <public/Web...> style paths. - - * tests/CCAnimationTestCommon.cpp: - * tests/CCKeyframedAnimationCurveTest.cpp: - * tests/CCLayerAnimationControllerTest.cpp: - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): - * tests/CCOcclusionTrackerTest.cpp: - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCThreadedTest.cpp: - * tests/FakeWebGraphicsContext3D.h: - * tests/LayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - * tests/WebCompositorInputHandlerImplTest.cpp: - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: - -2012-08-07 James Robinson <jamesr@chromium.org> - - [chromium] Only use public Platform API in NonCompositedContentHost - https://bugs.webkit.org/show_bug.cgi?id=93423 - - Reviewed by Adrienne Walker. - - Switches to using Web*Layer APIs in NonCompositedContentHost instead of reaching in to the LayerChromium and - updates unit tests for the nonCompositedContent->useLCDText flag rename. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - * src/WebContentLayer.cpp: - (WebKit::WebContentLayer::setUseLCDText): - (WebKit): - (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles): - * src/WebViewImpl.cpp: - * tests/CCLayerImplTest.cpp: - (WebCore::TEST): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/LayerChromiumTest.cpp: - -2012-08-08 Alec Flett <alecflett@chromium.org> - - IndexedDB: new enums and openCursor stub - https://bugs.webkit.org/show_bug.cgi?id=93410 - - Reviewed by Adam Barth. - - This stubs out the TaskType and Direction enums that will be - required to land the chromium side of - https://bugs.webkit.org/show_bug.cgi?id=91125. - - * public/WebIDBCursor.h: - * public/WebIDBObjectStore.h: - (WebKit::WebIDBObjectStore::setIndexKeys): - (WebKit::WebIDBObjectStore::setIndexesReady): - (WebIDBObjectStore): - (WebKit::WebIDBObjectStore::openCursor): - * public/WebIDBTransaction.h: - -2012-08-08 Dana Jansens <danakj@chromium.org> - - [chromium] Enable occlusion tracker in the occlusion tests for surface cacheing - https://bugs.webkit.org/show_bug.cgi?id=93500 - - Reviewed by Adrienne Walker. - - The occlusion tracker is not being used in these tests except to do - scissoring. We want to test occlusion with these occlusion tests, - and when scissoring is not part of occlusion tracker, these - tests would become useless otherwise. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-08 Adam Barth <abarth@webkit.org> - - Crash when reloading a Chromium "platform" app - https://bugs.webkit.org/show_bug.cgi?id=93497 - - Reviewed by Eric Seidel. - - Test that we don't crash when executing script during the - didCreateScriptContext callback. - - * tests/WebFrameTest.cpp: - * tests/data/hello_world.html: Added. - -2012-08-07 Joshua Bell <jsbell@chromium.org> - - Layout Test storage/indexeddb/intversion-omit-parameter.html is flaky - https://bugs.webkit.org/show_bug.cgi?id=92952 - - Reviewed by Tony Chang. - - Added test to exercise WebCore::IDBRequest event callbacks after - the script context has stopped and ensure no asserts are hit. - - * WebKit.gypi: - * tests/IDBRequestTest.cpp: Added. - (WebCore): - (WebCore::TEST): - -2012-08-07 Fady Samuel <fsamuel@chromium.org> - - Allow plugins to decide whether they are keyboard focusable - https://bugs.webkit.org/show_bug.cgi?id=88958 - - Reviewed by Anders Carlsson. - - * public/WebPlugin.h: - (WebKit::WebPlugin::supportsKeyboardFocus): - * src/WebInputEventConversion.cpp: - (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::supportsKeyboardFocus): - (WebKit): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - -2012-08-07 Kentaro Hara <haraken@chromium.org> - - [V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods - https://bugs.webkit.org/show_bug.cgi?id=93209 - - Reviewed by Adam Barth. - - By implementing V8Proxy::registerExtensionIfNeeded(), we can remove - registeredExtensionWithV8() and registerExtension(). - - No tests. No change in behavior. - - * src/WebScriptController.cpp: - (WebKit::WebScriptController::registerExtension): - -2012-08-07 James Robinson <jamesr@chromium.org> - - [chromium] Add new gclient-managed cc directory to Source/WebKit/chromium/.gitignore - https://bugs.webkit.org/show_bug.cgi?id=93403 - - Reviewed by Eric Seidel. - - * .gitignore: - -2012-08-07 Mihai Parparita <mihaip@chromium.org> - - [Chromium] Clean up WebScriptController.h comments - https://bugs.webkit.org/show_bug.cgi?id=93399 - - Reviewed by Adam Barth. - - Remove references to overloaded WebScriptController::registerExtension - variants. They were removed in r68666. - - * public/WebScriptController.h: - (WebScriptController): - -2012-08-07 Kentaro Hara <haraken@chromium.org> - - [V8] Remove #include Frame.h from V8Binding.h - https://bugs.webkit.org/show_bug.cgi?id=93326 - - Reviewed by Adam Barth. - - We want to remove unnecessary #include in V8Binding.h - to avoid circular include dependency. - - No tests. No change in behavior. - - * src/WebBindings.cpp: - -2012-08-07 James Robinson <jamesr@chromium.org> - - [chromium] Switch PlatformLayer typedef to Platform API type for PLATFORM(CHROMIUM) - https://bugs.webkit.org/show_bug.cgi?id=93335 - - Reviewed by Adrienne Walker. - - Update for new PlatformLayer typedef. This removes knowledge of WebCore::LayerChromium from all classes - except for NonCompositedContentHost, which still punches through for a few minor APIs that I'll address - in a separate patch. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - (WebKit::NonCompositedContentHost::setScrollLayer): - (WebKit::NonCompositedContentHost::scrollLayer): - (WebKit::NonCompositedContentHost::notifySyncRequired): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::platformLayer): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::platformLayer): - * src/WebPluginContainerImpl.h: - (WebCore): - (WebPluginContainerImpl): - * src/WebScrollableLayer.cpp: - (WebKit::WebScrollableLayer::setNonFastScrollableRegion): - (WebKit): - (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers): - (WebKit::WebScrollableLayer::setFixedToContainerLayer): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setRootGraphicsLayer): - * tests/Canvas2DLayerBridgeTest.cpp: - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - (WebKitTests::TEST_F): - -2012-08-07 James Robinson <jamesr@chromium.org> - - [chromium] Use WebCompositor interface in Platform API instead of CCProxy to query threaded compositor status - https://bugs.webkit.org/show_bug.cgi?id=93398 - - Reviewed by Adam Barth. - - Converts non-compositor code that cares about threaded compositing status over to query WebCompositor instead of - CCProxy. - - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::supportsType): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::composite): - (WebKit::WebViewImpl::scheduleAnimation): - (WebKit::WebViewImpl::scheduleComposite): - -2012-08-07 James Robinson <jamesr@chromium.org> - - [chromium] Move WebCompositor interface into Platform AP - https://bugs.webkit.org/show_bug.cgi?id=93391 - - Reviewed by Adam Barth. - - * WebKit.gyp: - * public/WebCompositor.h: - * src/WebLayerTreeViewImpl.cpp: - -2012-08-07 Joshua Bell <jsbell@chromium.org> - - REGRESSION(r124865): It broke the ARM Chromium build - https://bugs.webkit.org/show_bug.cgi?id=93364 - - Reviewed by Csaba Osztrogonác. - - Mark large constant with LL to satisfy a picky compiler. - - * tests/IDBLevelDBCodingTest.cpp: - (IDBLevelDBCoding::TEST): - -2012-08-07 Alexei Filippov <alexeif@chromium.org> - - Web Inspector: make the MemoryClassInfo class a not-template - https://bugs.webkit.org/show_bug.cgi?id=93265 - - Reviewed by Yury Semikhatsky. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::Instrumented::reportMemoryUsage): - (WebCore::InstrumentedRefPtr::reportMemoryUsage): - (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): - (WebCore::InstrumentedOther::reportMemoryUsage): - (WebCore::InstrumentedDOM::reportMemoryUsage): - (WebCore::NonVirtualInstrumented::reportMemoryUsage): - -2012-08-06 Yuta Kitamura <yutak@chromium.org> - - WebSocket.send() should accept ArrayBufferView - https://bugs.webkit.org/show_bug.cgi?id=90877 - - Reviewed by Kent Tamura. - - * src/WebSocketImpl.cpp: - (WebKit::WebSocketImpl::sendArrayBuffer): - Apply change in function signature of WebSocketChannel::send(). - -2012-08-06 James Robinson <jamesr@chromium.org> - - [chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp - https://bugs.webkit.org/show_bug.cgi?id=93319 - - Reviewed by Adrienne Walker. - - * src/WebLayer.cpp: - (WebKit::WebLayer::setChildren): - (WebKit): - (WebKit::WebLayer::setReplicaLayer): - (WebKit::WebLayer::setDebugName): - (WebKit::WebLayer::clearRenderSurface): - -2012-08-06 Adrienne Walker <enne@google.com> - - [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface - https://bugs.webkit.org/show_bug.cgi?id=93308 - - Reviewed by James Robinson. - - Now that WebScrollbarThemeGeometry can have different implementations, - create a FakeWebScrollbarThemeGeometry for testing purposes rather - than just overriding a geometry-related virtual. - - * WebKit.gyp: - * WebKit.gypi: - * src/WebScrollbarLayer.cpp: - (WebKit::WebScrollbarLayer::create): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/FakeWebScrollbarThemeGeometry.h: Added. - (WebKit): - (FakeWebScrollbarThemeGeometry): - (WebKit::FakeWebScrollbarThemeGeometry::create): - * tests/ScrollbarLayerChromiumTest.cpp: - (WebCore::TEST): - -2012-08-06 James Robinson <jamesr@chromium.org> - - [chromium] Update chromium DEPS r150037 -> r150169 - https://bugs.webkit.org/show_bug.cgi?id=93309 - - As the title says. Unreviewed. - - * DEPS: - -2012-08-06 David Reveman <reveman@chromium.org> - - [Chromium] Rename CCTextureUpdater to CCTextureUpdateQueue. - https://bugs.webkit.org/show_bug.cgi?id=93293 - - Reviewed by Adrienne Walker. - - * src/WebExternalTextureLayer.cpp: - (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): - (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): - (WTF::CCLayerTreeHostTestManySurfaces::beginTest): - * tests/CCTextureUpdateControllerTest.cpp: - * tests/CCThreadedTest.cpp: - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeTiledLayerChromium::update): - * tests/CCTiledLayerTestCommon.h: - (FakeTiledLayerChromium): - * tests/Canvas2DLayerBridgeTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-08-06 Bear Travis <betravis@adobe.com> - - [CSS Exclusions] Add a command-line flag to enable / disable exclusions - https://bugs.webkit.org/show_bug.cgi?id=91420 - - Reviewed by Dimitri Glazkov. - - Adding the interface code to expose the css exclusions runtime flag to - Chromium. - - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): Adding getters/setters for cssExclusions - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enableCSSExclusions): - (WebKit): - (WebKit::WebRuntimeFeatures::isCSSExclusionsEnabled): - -2012-08-06 Adam Barth <abarth@webkit.org> - - [Chromium] WebTouchCandidatesInfo should be part of the Client API - https://bugs.webkit.org/show_bug.cgi?id=93088 - - Reviewed by Eric Seidel. - - * WebKit.gyp: - * public/WebTouchCandidatesInfo.h: Copied from Source/Platform/chromium/public/WebTouchCandidatesInfo.h. - * src/WebViewImpl.cpp: - -2012-08-06 Adrienne Walker <enne@google.com> - - [chromium] REGRESSION(r124714): webkit_unit_tests asserts in Debug - https://bugs.webkit.org/show_bug.cgi?id=93297 - - Reviewed by James Robinson. - - This is a quick fix to get debug unit tests working again by - implementing a virtual function that has ASSERT_NOT_REACHED in the - base class version. - - * tests/ScrollAnimatorNoneTest.cpp: - (MockScrollableArea::scrollPosition): - -2012-08-06 Nasko Oskov <nasko@chromium.org> - - Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy. - https://bugs.webkit.org/show_bug.cgi?id=93127 - - Reviewed by Adam Barth. - - Add support in the API to monitor and create frame hierarchy to allow replicating it - across different instances of WebKit. - - * public/WebDocument.h: - (WebDocument): Added createElement. - * public/WebFrame.h: Added assignedName. - * public/WebFrameClient.h: - (WebFrameClient): - (WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created. - (WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter. - * public/WebNode.h: - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent): - * src/WebDocument.cpp: - (WebKit::WebDocument::createElement): Added to allow for creating frame elements. - (WebKit): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API. - (WebKit): - (WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed - to the unique name, generated by WebKit. - (WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame. - * src/WebFrameImpl.h: - (WebFrameImpl): - * src/WebNode.cpp: - (WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM. - (WebKit): - * tests/WebFrameTest.cpp: - -2012-08-06 David Reveman <reveman@chromium.org> - - [Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController. - https://bugs.webkit.org/show_bug.cgi?id=92596 - - Reviewed by Adrienne Walker. - - * WebKit.gypi: - * src/WebExternalTextureLayer.cpp: - * tests/CCTextureUpdateControllerTest.cpp: Renamed from Source/WebKit/chromium/tests/CCTextureUpdaterTest.cpp. - * tests/CCTiledLayerTestCommon.h: - (WebKitTests::FakeTextureCopier::copyTexture): - (WebKitTests::FakeTextureUploader::uploadTexture): - * tests/TextureCopierTest.cpp: - (TEST): - * tests/TiledLayerChromiumTest.cpp: - -2012-08-06 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Non-preserves-3d requires explicit flattening of screen-space transform. - https://bugs.webkit.org/show_bug.cgi?id=85808 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-08-06 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error - https://bugs.webkit.org/show_bug.cgi?id=92545 - - Reviewed by Pavel Feldman. - - Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers() - that tells if inspector front-end on the given platform can launch dedicated worker - front-end. - - * src/InspectorFrontendClientImpl.cpp: - (WebKit::InspectorFrontendClientImpl::canInspectWorkers): - (WebKit): - * src/InspectorFrontendClientImpl.h: - (InspectorFrontendClientImpl): - * src/js/DevTools.js: - -2012-08-06 Keishi Hattori <keishi@webkit.org> - - Remove minimum window size for PagePopup - https://bugs.webkit.org/show_bug.cgi?id=93100 - - Reviewed by Kent Tamura. - - * src/WebPagePopupImpl.cpp: Returns 0x0 so the page popup can be smaller than 100x100. - -2012-08-05 Kent Tamura <tkent@chromium.org> - - [Chromium-win] Use system locale for number representation - https://bugs.webkit.org/show_bug.cgi?id=93085 - - Reviewed by Hajime Morita. - - * WebKit.gypi: - Don't include Localized*ICUTest.cpp in Windows and OSX. They are unnecessary. - * tests/LocaleWinTest.cpp: - (LocaleWinTest): Add some LCID symbols. - (LocaleWinTest::decimalSeparator): - A helper for LocaleWinTest.decimalSeparator. - (TEST_F(LocaleWinTest, decimalSeparator)): - A test for LocaleWin::localizedDecimalSeparator(). This is a copy of the - corresponding test in LocalizedNumberICUTest.cpp. - (testNumberIsReversible): - A test helper LocaleWinTest.localizedNumberRoundTrip. This is a copy of - the corresponding test in LocalizedNumberICUTest.cpp. - (testNumbers): ditto. - (TEST_F(LocaleWinTest, localizedNumberRoundTrip)): - Tests for LocaleWin changes. This is a copy of the corresponding tests - in LocalizedNumberICUTest.cpp. - -2012-08-04 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-03 Nico Weber <thakis@chromium.org> - - [chromium] Add API to make it possible to request all variants of a WebImage - https://bugs.webkit.org/show_bug.cgi?id=92933 - - Reviewed by Adam Barth. - - Part of http://crbug.com/138550 - - * src/WebImageSkia.cpp: - (WebKit::WebImage::framesFromData): - (WebKit): - -2012-08-03 Yaron Friedman <yfriedman@chromium.org> - - [Chrome-Android] - Prepare apk tests for switch to checked in SDK. - https://bugs.webkit.org/show_bug.cgi?id=92931 - - Reviewed by Adam Barth. - - Pass Android-specific gyp variables to the native test generator - avoiding any dependencies on environment variables during build time. - - * WebKitUnitTests.gyp: - -2012-08-03 David Grogan <dgrogan@chromium.org> - - IndexedDB: Core upgradeneeded logic - https://bugs.webkit.org/show_bug.cgi?id=92558 - - Reviewed by Ojan Vafai. - - Update overridden methods to match new signatures. - - * tests/IDBAbortOnCorruptTest.cpp: - (WebCore::FailingBackingStore::createIDBDatabaseMetaData): - * tests/IDBFakeBackingStore.h: - -2012-08-03 Rick Byers <rbyers@chromium.org> - - Double tap gesture should send dblclick event - https://bugs.webkit.org/show_bug.cgi?id=92412 - - Reviewed by Adam Barth. - - Tweak comment to more completely describe the (lame) overloaded use - of deltaX in WebGestureEvent, and add a FIXME with the bug to track - cleaning it up. - * public/WebInputEvent.h: - (WebGestureEvent): - -2012-08-03 Dave Tu <dtu@chromium.org> - - [chromium] Remove assert when getting hardware renderingStats in software mode. - https://bugs.webkit.org/show_bug.cgi?id=92325 - - Reviewed by Adrienne Walker. - - If a page caused hardware mode to be turned on, then off, the hardware stats are still valid, so we don't need to assert that we're in hardware mode. Checking if the LayerTreeView is null should be sufficient. - - * public/WebWidget.h: - (WebWidget): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::renderingStats): - (WebKit::WebViewImpl::paint): - * src/WebViewImpl.h: - -2012-08-03 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-03 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r124632. - http://trac.webkit.org/changeset/124632 - https://bugs.webkit.org/show_bug.cgi?id=93154 - - Added new WebFrameTest.SelectRange which fails on bots - (Requested by dimich on #webkit). - - * tests/WebFrameTest.cpp: - * tests/data/select_range_basic.html: Removed. - * tests/data/select_range_iframe.html: Removed. - * tests/data/select_range_scroll.html: Removed. - -2012-08-03 Terry Anderson <tdanderson@chromium.org> - - Apply target fuzzing when sending a context menu event - https://bugs.webkit.org/show_bug.cgi?id=92914 - - Reviewed by Antonio Gomes. - - When constructing a PlatformEvent::GestureLongPress in WebInputEventConversion.cpp, - use |boundingBox| to specify |m_area|. - - * src/WebInputEventConversion.cpp: - (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): - -2012-08-03 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Add stubs for the find-in-page match rects API - https://bugs.webkit.org/show_bug.cgi?id=93110 - - Reviewed by Adam Barth. - - The Android port allows tapping on the find-in-page result tickmarks taking - the user to the corresponding matches. This patch introduces stubs for the - new required methods in order to achieve WebKit API compatibility for this - port as soon as possible. The implementation of these methods will be added - later in https://bugs.webkit.org/show_bug.cgi?id=93111. - - * public/WebFrame.h: - (WebKit): - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::findMatchMarkersVersion): - (WebKit): - (WebKit::WebFrameImpl::activeFindMatchRect): - (WebKit::WebFrameImpl::findMatchRects): - (WebKit::WebFrameImpl::selectNearestFindMatch): - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-08-03 Mike West <mkwst@chromium.org> - - Blocking a plugin via CSP should result in one (and only one) console message. - https://bugs.webkit.org/show_bug.cgi?id=92649 - - Reviewed by Adam Barth. - - * src/LocalizedStrings.cpp: - (WebCore::blockedPluginByContentSecurityPolicyText): - (WebCore): - Adding a stub for the newly added string. - -2012-08-03 Oli Lan <olilan@chromium.org> - - [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint. - https://bugs.webkit.org/show_bug.cgi?id=93108 - - Reviewed by Adam Barth. - - Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange, and also - serves to test WebFrameImpl::visiblePositionForWindowPoint as it is used by selectRange. - - The test uses sample files that contain selected text on load. The test uses - WebViewImpl::selectionBounds to retrieve the ends of the selection, then unselects - and calls WebFrameImpl::selectRange to attempt to reselect the same text. - - Three cases are tested: the normal case, the case where the selected text is offscreen - due to a scroll, and the case where the selected text is in an iframe. This allows the - problem cases and fix in https://bugs.webkit.org/show_bug.cgi?id=79117 to be tested. - - * tests/WebFrameTest.cpp: - * tests/data/select_range_basic.html: Added. - * tests/data/select_range_iframe.html: Added. - * tests/data/select_range_scroll.html: Added. - -2012-08-03 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: eliminate visitBaseClass method from NMI. It introduces unnecessary complexity. - https://bugs.webkit.org/show_bug.cgi?id=93129 - - Reviewed by Yury Semikhatsky. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): - -2012-08-03 Adam Barth <abarth@webkit.org> - - V8Proxy::retrieve(*) leads to really obfuscated code and should be removed - https://bugs.webkit.org/show_bug.cgi?id=93072 - - Reviewed by Eric Seidel. - - * src/WebDevToolsAgentImpl.cpp: - (WebKit::WebDevToolsAgentImpl::didCreateScriptContext): - -2012-08-02 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: extend test coverage for nmi code and fix 2 bugs. - https://bugs.webkit.org/show_bug.cgi?id=92994 - - Reviewed by Yury Semikhatsky. - - 1) owner object type propagation. - If a class with object-type DOM has an instrumented member with object-type Other then it has to be recorded as DOM. - Sample: We have SharedBuffer class and we don't know the object-type for it but we know that it is owned by an object with object-type CachedResourceImage. - - 2) the first member of an instrumented non virtual class was skipped even if it was reported properly. - it happened because the first member has the same address as it's owner - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::TEST): - (WebCore): - (InstrumentedOther): - (WebCore::InstrumentedOther::InstrumentedOther): - (WebCore::InstrumentedOther::reportMemoryUsage): - (InstrumentedDOM): - (WebCore::InstrumentedDOM::InstrumentedDOM): - (WebCore::InstrumentedDOM::reportMemoryUsage): - (NonVirtualInstrumented): - (WebCore::NonVirtualInstrumented::reportMemoryUsage): - -2012-08-02 Alec Flett <alecflett@chromium.org> - - IndexedDB: remove leftover chromium stubs from putIndexWithKeys - https://bugs.webkit.org/show_bug.cgi?id=93032 - - Reviewed by Darin Fisher. - - Remove old chromium APIs that are no longer called by chrome. - - * public/WebIDBCursor.h: - * public/WebIDBObjectStore.h: - * public/WebIDBTransaction.h: - -2012-08-02 Antoine Labour <piman@chromium.org> - - [chromium] add lost context test case for HW video decoder - https://bugs.webkit.org/show_bug.cgi?id=93057 - - Reviewed by Adrienne Walker. - - We check that we don't use resources after a lost context (assuming - proper WebVideoFrameProvider behavior). - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-02 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r124540. - http://trac.webkit.org/changeset/124540 - https://bugs.webkit.org/show_bug.cgi?id=93055 - - Broke compile on Chromium Win bot (Requested by dimich on - #webkit). - - * tests/IDBAbortOnCorruptTest.cpp: - (WebCore::FailingBackingStore::createIDBDatabaseMetaData): - * tests/IDBFakeBackingStore.h: - -2012-08-02 Alexandre Elias <aelias@google.com> - - [chromium] deviceViewportSize cleanup - https://bugs.webkit.org/show_bug.cgi?id=92794 - - Reviewed by Adrienne Walker. - - In the future, CSS layout size will become increasingly disassociated - from physical device size, and it will become impossible to infer one - from the other inside the compositor. Therefore, this patch allows - deviceViewportSize to be explicitly passed in by the outside client. - - I also renamed the existing viewportSize field to "layoutViewportSize" - for clarity, and converted its uses to deviceViewportSize since - that is more appropriate. - - I had to add some default-value scaffolding to WebLayerTreeView in - order to avoid breaking ui/compositor. We can delete it once that's - updated. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setViewportSize): - (WebKit::WebLayerTreeView::layoutViewportSize): - (WebKit): - (WebKit::WebLayerTreeView::deviceViewportSize): - (WebKit::WebLayerTreeView::setDeviceScaleFactor): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::paint): - (WebKit::WebViewImpl::updateLayerTreeViewport): - -2012-08-02 Adam Barth <abarth@webkit.org> - - V8Proxy::currentContext() doesn't do anything and should be removed - https://bugs.webkit.org/show_bug.cgi?id=93041 - - Reviewed by Eric Seidel. - - * src/WebBindings.cpp: - (WebKit::makeIntArrayImpl): - (WebKit::makeStringArrayImpl): - -2012-08-02 David Grogan <dgrogan@chromium.org> - - IndexedDB: Core upgradeneeded logic - https://bugs.webkit.org/show_bug.cgi?id=92558 - - Reviewed by Ojan Vafai. - - Update overridden methods to match new signatures. - - * tests/IDBAbortOnCorruptTest.cpp: - (WebCore::FailingBackingStore::createIDBDatabaseMetaData): - * tests/IDBFakeBackingStore.h: - -2012-08-02 Vincent Scheib <scheib@chromium.org> - - Remove old Pointer Lock API. - https://bugs.webkit.org/show_bug.cgi?id=88892 - - Reviewed by Adam Barth. - - * src/WebViewImpl.cpp: - Removed #include to old API header. - -2012-08-02 Tien-Ren Chen <trchen@chromium.org> - - [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation - https://bugs.webkit.org/show_bug.cgi?id=91688 - - Reviewed by Adrienne Walker. - - New unit test ScrollbarLayerChromiumTest.scrollOffsetSynchronization to verify - scroll offset is updated during tree synchronization and threaded scrolling. - Another new unit test CCScrollbarAnimationControllerLinearFadeTest to verify - opacity animates as intended. - - * tests/ScrollbarLayerChromiumTest.cpp: - -2012-08-02 Adrienne Walker <enne@google.com> - - [chromium] Make CCScrollbarLayerImpl handle lost contexts properly - https://bugs.webkit.org/show_bug.cgi?id=93021 - - Reviewed by James Robinson. - - Add CCScrollbarLayerImpl to the dontUseOldResourceAfterLostContext - test. Additionally, modify this test so that stale resource ids - properly point at invalid texture ids so that the test actually tests - what it is supposed to be testing. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-02 Adam Barth <abarth@webkit.org> - - The generic bindings shouldn't use templates - https://bugs.webkit.org/show_bug.cgi?id=93016 - - Reviewed by Eric Seidel. - - Update #include. - - * src/WebBindings.cpp: - -2012-08-02 Peter Beverloo <peter@chromium.org> - - [Chromium] Add a stub for WebView::getTouchHighlightQuads() - https://bugs.webkit.org/show_bug.cgi?id=92997 - - Reviewed by Adam Barth. - - Chrome on Android will be using this method for the link preview - implementation, discussion about which is available in Bug 79150. Since - that system is fairly big, will require refactoring, and the unavailable - APIs are blocking API compatibility, add a stub for now. - - Together with the WebView API, also add the "WebTouchCandidatesInfo" - structure which is being used by it. - - * public/WebView.h: - (WebKit): - (WebView): - * src/WebViewImpl.cpp: - (WebKit): - (WebKit::WebViewImpl::getTouchHighlightQuads): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-02 Hans Wennborg <hans@chromium.org> - - Speech JavaScript API: Fire speech start event at the same time as sound start event - https://bugs.webkit.org/show_bug.cgi?id=92971 - - Reviewed by Adam Barth. - - Chromium's speech recognizer doesn't differentiate between "sound - started" and "speech started". Just fire those events at the same - time, and don't provide functions for them in - WebSpeechRecognizerClient. - - * public/WebSpeechRecognizerClient.h: - * src/SpeechRecognitionClientProxy.cpp: - (WebKit::SpeechRecognitionClientProxy::didStartSound): - (WebKit::SpeechRecognitionClientProxy::didEndSound): - * src/SpeechRecognitionClientProxy.h: - (SpeechRecognitionClientProxy): - -2012-08-02 Adam Barth <abarth@webkit.org> - - [Chromium] WebViewImpl::showTouchHighlightQuads isn't needed for Android - https://bugs.webkit.org/show_bug.cgi?id=92921 - - Reviewed by Nate Chapin. - - We originally added a stub implementation of this function to make - merging detectContentOnTouch easier, but showTouchHighlightQuads is - being removed from the chromium-android branch in favor of the code in - https://bugs.webkit.org/show_bug.cgi?id=84487. This patch removes the - stub. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::detectContentIntentOnTouch): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-08-02 Peter Beverloo <peter@chromium.org> - - [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI - https://bugs.webkit.org/show_bug.cgi?id=92858 - - Reviewed by Adam Barth. - - Now that the sdk_build variable is available, we can remove these two differences - as well. This goes together with Adam's bug 90920. - - After this patch, the whole Tools/ directory will be unforked :-). - - * WebKitUnitTests.gyp: - -2012-08-02 Alexei Filippov <alexeif@chromium.org> - - Web Inspector: count RenderStyle objects in the native memory profiler - https://bugs.webkit.org/show_bug.cgi?id=91759 - - Reviewed by Yury Semikhatsky. - - Add a test for DataRef<T> wrapped member instrumentation. - - * tests/MemoryInstrumentationTest.cpp: - (WebCore::InstrumentedRefPtr::create): - (WebCore::TEST): - (WebCore): - -2012-08-02 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-08-01 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: test native memory instrumentation code with help of unittests - https://bugs.webkit.org/show_bug.cgi?id=92743 - - Reviewed by Yury Semikhatsky. - - Test a part of existing Native Memory Instrumentation code with help of unit tests. - 6 tests were added and two bugs were fixed. - a drive-by improvement: the method MemoryInstrumentation::addInstrumentedObject - was marked as private and addRootObject was introduced instead of it. - The new function also calls processDeferedPointers. - - * WebKit.gypi: - * tests/MemoryInstrumentationTest.cpp: Added. - (WebCore): - (NotInstrumented): - (Instrumented): - (WebCore::Instrumented::Instrumented): - (WebCore::Instrumented::~Instrumented): - (WebCore::Instrumented::reportMemoryUsage): - (WebCore::TEST): - (InstrumentedWithOwnPtr): - (WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr): - (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): - -2012-08-01 Xingnan Wang <xingnan.wang@intel.com> - - IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type - https://bugs.webkit.org/show_bug.cgi?id=92725 - - Reviewed by Kentaro Hara. - - Add two new tests in IDBLevelDBCodingTest.cpp. One for an added function decodeByte() and - another for verifying that encodeByte() and encodeVarInt() are indentical when the encoded - values are <= 127. - - * tests/IDBLevelDBCodingTest.cpp: - (IDBLevelDBCoding::TEST): - (IDBLevelDBCoding): - -2012-08-01 James Robinson <jamesr@chromium.org> - - [chromium] Use new-style tracing macros with explicit category - https://bugs.webkit.org/show_bug.cgi?id=92928 - - Reviewed by Adam Barth. - - Set the category explicitly in traces. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::updateAnimations): - (WebKit::WebViewImpl::layout): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - -2012-08-01 James Robinson <jamesr@chromium.org> - - [chromium] Move compositor HUD font atlas initialization code out of compositor core - https://bugs.webkit.org/show_bug.cgi?id=92924 - - Reviewed by Adrienne Walker. - - This initializes the compositor's font atlas when initialization the compositor if the "Show FPS counter" or - "Show layer tree" settings are true. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setFontAtlas): - (WebKit): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - -2012-08-01 Jian Li <jianli@chromium.org> - - [chromium] Make WebKit API support draggable region change update - https://bugs.webkit.org/show_bug.cgi?id=92813 - - Reviewed by Adam Barth. - - Introduce WebDraggableRegion and delegate the draggable region update - call to the new method draggableRegionsChanged in WebViewClient. - - * public/WebDocument.h: - (WebDocument): - * public/WebDraggableRegion.h: Added. - (WebKit): - (WebDraggableRegion): - * public/WebViewClient.h: - (WebViewClient): - (WebKit::WebViewClient::draggableRegionsChanged): - * src/ChromeClientImpl.cpp: - (WebKit): - (WebKit::ChromeClientImpl::dashboardRegionsChanged): - * src/ChromeClientImpl.h: - (ChromeClientImpl): - * src/WebDocument.cpp: - (WebKit::WebDocument::draggableRegions): - (WebKit): - -2012-08-01 Antoine Labour <piman@chromium.org> - - [chromium] factor out the optimization pass in CCRenderSurfaceFilters::apply - https://bugs.webkit.org/show_bug.cgi?id=92453 - - Reviewed by James Robinson. - - This separates the "optimization" pass in CCRenderSurfaceFilters::apply - to resolve a succession of color matrix filters into a single operation. - This allows testing of that code. - This introduces a new generic color matrix WebFilterOperation, which can - also be used on its own. - - * WebKit.gypi: - * tests/CCRenderSurfaceFiltersTest.cpp: Added. - (WebKit): - (WebKit::isCombined): - (WebKit::TEST): - -2012-08-01 Daniel Murphy <dmurph@chromium.org> - - Fix for drawing invalid layers in WebViewBenchmarkSupportImpl - https://bugs.webkit.org/show_bug.cgi?id=92920 - - Reviewed by Adrienne Walker. - - The GraphicsLayers without content needed to be skipped. - - * src/WebViewBenchmarkSupportImpl.cpp: - (WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped): - -2012-08-01 Jian Li <jianli@chromium.org> - - Add new CSS property "-webkit-widget-region" to expose dashboard region support for other port - https://bugs.webkit.org/show_bug.cgi?id=90298 - - Reviewed by Adam Barth. - - * features.gypi: Add ENABLE_WIDGET_REGION define. - -2012-08-01 Antoine Labour <piman@chromium.org> - - [chromium] Fix lost context handling on hud layer - https://bugs.webkit.org/show_bug.cgi?id=92915 - - Reviewed by Adrienne Walker. - - On lost context we need to release CCScopedTextures, otherwise later on - we will try to re-allocate it using a stale CCResourceProvider. - - Test CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext - extended. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-08-01 Nico Weber <thakis@chromium.org> - - [chromium/mac] Delete WebImageCG.cpp - https://bugs.webkit.org/show_bug.cgi?id=92910 - - Reviewed by James Robinson. - - It's been unused since the switch to skia. - Also remove now-unneeded *CG.cpp exclusion rule. - - * WebKit.gyp: - * src/WebImageCG.cpp: Removed. - -2012-08-01 Joshua Bell <jsbell@chromium.org> - - [Chromium] IndexedDB: API stubs to simplify WebIDBCursor API - https://bugs.webkit.org/show_bug.cgi?id=92414 - - Reviewed by Adam Barth. - - Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land. - Adds no-op methods which will later be implemented; during the landing sequence, - Chromium will call both the new methods and the old ones. The end goal is that - the success callbacks for cursors will include the new key/primaryKey/value rather - than requiring the callee to call back into the cursor backend to fetch them. - - * public/WebIDBCallbacks.h: - (WebIDBCallbacks): - (WebKit::WebIDBCallbacks::onSuccess): - -2012-08-01 Peter Beverloo <peter@chromium.org> - - [Text Autosizing] Provide an API for influencing the font scale factor - https://bugs.webkit.org/show_bug.cgi?id=92882 - - Reviewed by Adam Barth. - - Add an API to change Text Autosizing's font scale factor. - - The font scale factor applied to Text Autosizing influences the sizing - of text, and will influence the scaling of boosted blocks once the - implementation progresses. For Android, it will be set to the font size - chosen in the user's system-wide preferences. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setTextAutosizingFontScaleFactor): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-08-01 Dirk Pranke <dpranke@chromium.org> - - Roll chromium DEPS to 149416. - - Unreviewed. - - * DEPS: - -2012-08-01 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r124334. - http://trac.webkit.org/changeset/124334 - https://bugs.webkit.org/show_bug.cgi?id=92879 - - Broke MemoryInstrumentationTest.sizeOf from webkit_unit_tests - on Chromium canaries (Requested by apavlov1 on #webkit). - - * WebKit.gypi: - * tests/MemoryInstrumentationTest.cpp: Removed. - -2012-08-01 Ilya Tikhonovsky <loislo@chromium.org> - - Web Inspector: test native memory instrumentation code with help of unittests - https://bugs.webkit.org/show_bug.cgi?id=92743 - - Reviewed by Yury Semikhatsky. - - Test a part of existing Native Memory Instrumentation code with help of unit tests. - 6 tests were added and two bugs were fixed. - - * WebKit.gypi: - * tests/MemoryInstrumentationTest.cpp: Added. - (WebCore): - (MemoryInstrumentationImpl): - (WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl): - (WebCore::MemoryInstrumentationImpl::reportedSize): - (WebCore::MemoryInstrumentationImpl::countObjectSize): - (WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers): - (NotInstrumented): - (Instrumented): - (WebCore::Instrumented::Instrumented): - (WebCore::Instrumented::~Instrumented): - (WebCore::Instrumented::reportMemoryUsage): - (WebCore::TEST): - (InstrumentedWithOwnPtr): - (WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr): - (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage): - -2012-08-01 Alexei Filippov <alexeif@chromium.org> - - Web Inspector: count DOM storage cache memory for native snapshot - https://bugs.webkit.org/show_bug.cgi?id=91617 - - Reviewed by Yury Semikhatsky. - - Add memory size used for DOM storage cache reporting interface. - - * src/StorageAreaProxy.cpp: - (WebCore::StorageAreaProxy::memoryBytesUsedByCache): - (WebCore): - * src/StorageAreaProxy.h: - (StorageAreaProxy): - -2012-07-31 Yoshifumi Inoue <yosin@chromium.org> - - [Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS - https://bugs.webkit.org/show_bug.cgi?id=92822 - - Reviewed by Kent Tamura. - - This patch enables ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS for Chromium - port except for Android. - - * features.gypi: Add ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS=1 to "feature_defines" - block of OS != "android". - -2012-07-31 Yusuf Ozuysal <yusufo@google.com> - - [chromium]Upstream WebViewImpl:StartPageScaleAnimation changes for Chrome for Android - https://bugs.webkit.org/show_bug.cgi?id=92698 - - Reviewed by Adam Barth. - - Enforce the maximum and minimum scroll positions after the scale has changed. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::startPageScaleAnimation): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-31 Terry Anderson <tdanderson@chromium.org> - - [chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap - https://bugs.webkit.org/show_bug.cgi?id=92151 - - Reviewed by Darin Fisher. - - Now that gesture events store a bounding box, use |boundingBox| instead of - |deltaX| and |deltaY| when specifying |m_area|. - - * public/WebInputEvent.h: - (WebGestureEvent): - * src/WebInputEventConversion.cpp: - (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): - -2012-07-31 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-31 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Hit test points are being clipped by layers that should not clip - https://bugs.webkit.org/show_bug.cgi?id=92786 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostCommonTest.cpp: adds a test where the - hit-testable layer does not overlap its parent. The parent does - not clip, so the layer should still be hittable. - -2012-07-31 Chris Rogers <crogers@google.com> - - Allow AudioDestination to support local/live audio input - https://bugs.webkit.org/show_bug.cgi?id=90318 - - Reviewed by Kenneth Russell. - - * src/AudioDestinationChromium.cpp: - (WebCore::AudioDestination::create): - (WebCore::AudioDestinationChromium::AudioDestinationChromium): - (WebCore::AudioDestinationChromium::provideInput): - (WebCore): - * src/AudioDestinationChromium.h: - (AudioDestinationChromium): - -2012-07-31 Adam Barth <abarth@webkit.org> - - [Chromium-Android] We should hueristically detect content intents on touch - https://bugs.webkit.org/show_bug.cgi?id=92346 - - Reviewed by Nate Chapin. - - On Android, when the user touches a block of text, we run a bunch of - OS-provided hueristics to detect content intents, such as telephone - numbers and mailing addresses. - - This patch introduces the WebViewClient functions and the - detectContentIntentOnTouch function, but does not wire the code into - the event system. There are some decisions to make about how to wire it - into the event system, we'll tackle in the next patch. - - * public/WebViewClient.h: - (WebKit::WebViewClient::detectContentIntentAround): - (WebViewClient): - (WebKit::WebViewClient::scheduleContentIntent): - (WebKit::WebViewClient::cancelScheduledContentIntents): - * src/WebViewImpl.cpp: - (WebKit): - (WebKit::tapHighlightColorForNode): - (WebKit::WebViewImpl::showTouchHighlightQuads): - (WebKit::WebViewImpl::detectContentIntentOnTouch): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-31 Ian Vollick <vollick@chromium.org> - - [chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTranslationUtil - https://bugs.webkit.org/show_bug.cgi?id=90468 - - Reviewed by James Robinson. - - * src/WebAnimation.cpp: - (WebKit::WebAnimation::targetProperty): - (WebKit): - (WebKit::WebAnimation::initialize): - * src/WebLayer.cpp: - (WebKit::WebLayer::setAnimationDelegate): - (WebKit): - (WebKit::WebLayer::addAnimation): - (WebKit::WebLayer::removeAnimation): - (WebKit::WebLayer::pauseAnimation): - (WebKit::WebLayer::suspendAnimations): - (WebKit::WebLayer::resumeAnimations): - (WebKit::WebLayer::transferAnimationsTo): - * tests/CCThreadedTest.cpp: - * tests/CCThreadedTest.h: - (TestHooks): - * tests/WebAnimationTest.cpp: - (WebKit::TEST): - -2012-07-30 Adam Barth <abarth@webkit.org> - - Typo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp - https://bugs.webkit.org/show_bug.cgi?id=92135 - - Reviewed by Kentaro Hara. - - This patch fixes a typo. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::animateZoomAroundPoint): - -2012-07-31 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r124179. - http://trac.webkit.org/changeset/124179 - https://bugs.webkit.org/show_bug.cgi?id=92730 - - Breaks Chromium Linux 32 bots with "error: integer constant is - too large for 'long' type" in IDBLevelDBCodingTest.cpp - (Requested by apavlov on #webkit). - - * tests/IDBLevelDBCodingTest.cpp: - (IDBLevelDBCoding::TEST): - -2012-07-30 Keishi Hattori <keishi@webkit.org> - - Implement datalist UI for input type color for Chromium - https://bugs.webkit.org/show_bug.cgi?id=92075 - - Reviewed by Kent Tamura. - - Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController. - ColorChooserUIController can control whether to open the color suggestion picker - popup or the color chooser depending on the responses from ColorChooserClient. - - * WebKit.gyp: - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser. - (WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium. - * src/ChromeClientImpl.h: - (WebKit): - (ChromeClientImpl): - * src/ColorChooserProxy.cpp: Removed. - * src/ColorChooserProxy.h: Removed. - * src/ColorChooserUIController.cpp: Added. - (WebKit): - (WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient. - (WebKit::ColorChooserUIController::~ColorChooserUIController): - (WebKit::ColorChooserUIController::setSelectedColor): - (WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser. - (WebKit::ColorChooserUIController::didChooseColor): - (WebKit::ColorChooserUIController::didEndChooser): - (WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size. - (WebKit::ColorChooserUIController::writeDocument): - (WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue. - (WebKit::ColorChooserUIController::didClosePopup): - (WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup. - (WebKit::ColorChooserUIController::closePopup): - (WebKit::ColorChooserUIController::openColorChooser): Opens color chooser. - * src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h. - (WebCore): - (WebKit): - (ColorChooserUIController): - * src/WebColorChooserClientImpl.cpp: Removed. - -2012-07-30 Ryosuke Niwa <rniwa@webkit.org> - - Roll out the DEPS roll (r124164) for now since it broke Chromium Mac builds. - - * DEPS: - -2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-30 Adrienne Walker <enne@google.com> - - [chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer - https://bugs.webkit.org/show_bug.cgi?id=91032 - - Reviewed by James Robinson. - - Add implementation of WebScrollbarLayer to the client API. - - * WebKit.gyp: - * src/WebScrollbarLayer.cpp: Added. - (WebKit): - (WebKit::WebScrollbarLayer::setScrollLayer): - (WebKit::WebScrollbarLayer::create): - (WebKit::WebScrollbarLayer::WebScrollbarLayer): - (WebKit::WebScrollbarLayer::operator=): - (WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>): - -2012-07-30 Sadrul Habib Chowdhury <sadrul@chromium.org> - - Propagate gesture events to plugins. - https://bugs.webkit.org/show_bug.cgi?id=92281 - - Reviewed by Adam Barth. - - Propagate gesture events to plugins. - - * src/WebInputEventConversion.cpp: - (WebKit): - (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): - * src/WebInputEventConversion.h: - (WebCore): - (WebKit): - (WebGestureEventBuilder): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::handleEvent): - * src/WebPluginContainerImpl.h: - (WebCore): - (WebPluginContainerImpl): - -2012-07-30 John Bates <jbates@google.com> - - Plumb vsync-enabled flag up to compositor thread and support disable-vsync - https://bugs.webkit.org/show_bug.cgi?id=92323 - - Reviewed by James Robinson. - - * public/WebSettings.h: - * tests/CCFrameRateControllerTest.cpp: - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::WebSettingsImpl): - (WebKit::WebSettingsImpl::setRenderVSyncEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - (WebKit::WebSettingsImpl::renderVSyncEnabled): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - -2012-07-30 Adrienne Walker <enne@google.com> - - [chromium] Remove dependency on ScrollbarTheme from the compositor - https://bugs.webkit.org/show_bug.cgi?id=90528 - - Reviewed by James Robinson. - - Add implementations for WebScrollbarThemeGeometry and - WebScrollbarThemePainter. Fill out additional API calls for - WebPluginScrollbarImpl since it derives from WebScrollbar. - - Add WebScrollbarImpl to the client API to wrap and own an existing - WebCore Scrollbar object and provide the WebScrollbar interface. - - By keeping WebScrollbar separate from WebScrollbarThemeGeometry, the - compositor thread can create its own thread-safe data bag version of a - WebScrollbar (CCScrollbarLayerImpl::CCScrollbar), but this requires - WebScrollbarThemeClientImpl. - - WebScrollbarThemeClientImpl does the reverse of WebScrollbarImpl; it - wraps a WebScrollbar and provides the ScrollbarThemeClient interface. - This is so that a WebScrollbar can be passed to the geometry and - painter functions. Then, internally the WebScrollbarThemeClientImpl - can be used to adapt the WebScrollbar to the ScrollbarThemeClient - interface so the geometry and painter functions can call direct - functions on ScrollbarThemeComposite. - - * WebKit.gyp: - * src/AssertMatchingEnums.cpp: - * src/ExternalPopupMenu.h: - (WebKit): - * src/WebPluginScrollbarImpl.cpp: - (WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl): - (WebKit::WebPluginScrollbarImpl::location): - (WebKit): - (WebKit::WebPluginScrollbarImpl::size): - (WebKit::WebPluginScrollbarImpl::enabled): - (WebKit::WebPluginScrollbarImpl::maximum): - (WebKit::WebPluginScrollbarImpl::totalSize): - (WebKit::WebPluginScrollbarImpl::isScrollViewScrollbar): - (WebKit::WebPluginScrollbarImpl::isScrollableAreaActive): - (WebKit::WebPluginScrollbarImpl::getTickmarks): - (WebKit::WebPluginScrollbarImpl::controlSize): - (WebKit::WebPluginScrollbarImpl::pressedPart): - (WebKit::WebPluginScrollbarImpl::hoveredPart): - (WebKit::WebPluginScrollbarImpl::scrollbarOverlayStyle): - (WebKit::WebPluginScrollbarImpl::orientation): - (WebKit::WebPluginScrollbarImpl::isCustomScrollbar): - (WebKit::WebPluginScrollbarImpl::onMouseUp): - (WebKit::WebPluginScrollbarImpl::onMouseMove): - (WebKit::WebPluginScrollbarImpl::onMouseLeave): - * src/WebPluginScrollbarImpl.h: - (WebPluginScrollbarImpl): - * src/WebScrollbarImpl.cpp: Added. - (WebKit): - (WebKit::WebScrollbar::create): - (WebKit::WebScrollbarImpl::WebScrollbarImpl): - (WebKit::WebScrollbarImpl::isOverlay): - (WebKit::WebScrollbarImpl::value): - (WebKit::WebScrollbarImpl::location): - (WebKit::WebScrollbarImpl::size): - (WebKit::WebScrollbarImpl::enabled): - (WebKit::WebScrollbarImpl::maximum): - (WebKit::WebScrollbarImpl::totalSize): - (WebKit::WebScrollbarImpl::isScrollViewScrollbar): - (WebKit::WebScrollbarImpl::isScrollableAreaActive): - (WebKit::WebScrollbarImpl::getTickmarks): - (WebKit::WebScrollbarImpl::controlSize): - (WebKit::WebScrollbarImpl::pressedPart): - (WebKit::WebScrollbarImpl::hoveredPart): - (WebKit::WebScrollbarImpl::scrollbarOverlayStyle): - (WebKit::WebScrollbarImpl::orientation): - (WebKit::WebScrollbarImpl::isCustomScrollbar): - * src/WebScrollbarImpl.h: Copied from Source/Platform/chromium/public/WebScrollbar.h. - (WebCore): - (WebKit): - (WebScrollbarImpl): - * src/WebScrollbarThemeClientImpl.cpp: Added. - (WebKit): - (WebKit::WebScrollbarThemeClientImpl::WebScrollbarThemeClientImpl): - (WebKit::WebScrollbarThemeClientImpl::x): - (WebKit::WebScrollbarThemeClientImpl::y): - (WebKit::WebScrollbarThemeClientImpl::width): - (WebKit::WebScrollbarThemeClientImpl::height): - (WebKit::WebScrollbarThemeClientImpl::size): - (WebKit::WebScrollbarThemeClientImpl::location): - (WebKit::WebScrollbarThemeClientImpl::parent): - (WebKit::WebScrollbarThemeClientImpl::root): - (WebKit::WebScrollbarThemeClientImpl::setFrameRect): - (WebKit::WebScrollbarThemeClientImpl::frameRect): - (WebKit::WebScrollbarThemeClientImpl::invalidate): - (WebKit::WebScrollbarThemeClientImpl::invalidateRect): - (WebKit::WebScrollbarThemeClientImpl::scrollbarOverlayStyle): - (WebKit::WebScrollbarThemeClientImpl::getTickmarks): - (WebKit::WebScrollbarThemeClientImpl::isScrollableAreaActive): - (WebKit::WebScrollbarThemeClientImpl::isScrollViewScrollbar): - (WebKit::WebScrollbarThemeClientImpl::convertFromContainingWindow): - (WebKit::WebScrollbarThemeClientImpl::isCustomScrollbar): - (WebKit::WebScrollbarThemeClientImpl::orientation): - (WebKit::WebScrollbarThemeClientImpl::value): - (WebKit::WebScrollbarThemeClientImpl::currentPos): - (WebKit::WebScrollbarThemeClientImpl::visibleSize): - (WebKit::WebScrollbarThemeClientImpl::totalSize): - (WebKit::WebScrollbarThemeClientImpl::maximum): - (WebKit::WebScrollbarThemeClientImpl::controlSize): - (WebKit::WebScrollbarThemeClientImpl::lineStep): - (WebKit::WebScrollbarThemeClientImpl::pageStep): - (WebKit::WebScrollbarThemeClientImpl::pressedPart): - (WebKit::WebScrollbarThemeClientImpl::hoveredPart): - (WebKit::WebScrollbarThemeClientImpl::styleChanged): - (WebKit::WebScrollbarThemeClientImpl::enabled): - (WebKit::WebScrollbarThemeClientImpl::setEnabled): - (WebKit::WebScrollbarThemeClientImpl::isOverlayScrollbar): - * src/WebScrollbarThemeClientImpl.h: Added. - (WebCore): - (WebKit): - (WebScrollbarThemeClientImpl): - * src/WebScrollbarThemeGeometry.cpp: Added. - (WebKit): - (WebKit::WebScrollbarThemeGeometry::assign): - (WebKit::WebScrollbarThemeGeometry::thumbPosition): - (WebKit::WebScrollbarThemeGeometry::thumbLength): - (WebKit::WebScrollbarThemeGeometry::trackPosition): - (WebKit::WebScrollbarThemeGeometry::trackLength): - (WebKit::WebScrollbarThemeGeometry::hasButtons): - (WebKit::WebScrollbarThemeGeometry::hasThumb): - (WebKit::WebScrollbarThemeGeometry::trackRect): - (WebKit::WebScrollbarThemeGeometry::thumbRect): - (WebKit::WebScrollbarThemeGeometry::minimumThumbLength): - (WebKit::WebScrollbarThemeGeometry::scrollbarThickness): - (WebKit::WebScrollbarThemeGeometry::backButtonStartRect): - (WebKit::WebScrollbarThemeGeometry::backButtonEndRect): - (WebKit::WebScrollbarThemeGeometry::forwardButtonStartRect): - (WebKit::WebScrollbarThemeGeometry::forwardButtonEndRect): - (WebKit::WebScrollbarThemeGeometry::constrainTrackRectToTrackPieces): - (WebKit::WebScrollbarThemeGeometry::splitTrack): - (WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry): - * src/WebScrollbarThemePainter.cpp: Added. - (WebKit): - (WebKit::WebScrollbarThemePainter::assign): - (WebKit::WebScrollbarThemePainter::paintScrollbarBackground): - (WebKit::WebScrollbarThemePainter::paintTrackBackground): - (WebKit::WebScrollbarThemePainter::paintBackTrackPart): - (WebKit::WebScrollbarThemePainter::paintForwardTrackPart): - (WebKit::WebScrollbarThemePainter::paintBackButtonStart): - (WebKit::WebScrollbarThemePainter::paintBackButtonEnd): - (WebKit::WebScrollbarThemePainter::paintForwardButtonStart): - (WebKit::WebScrollbarThemePainter::paintForwardButtonEnd): - (WebKit::WebScrollbarThemePainter::paintTickmarks): - (WebKit::WebScrollbarThemePainter::paintThumb): - (WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter): - * tests/ScrollbarLayerChromiumTest.cpp: - (WebCore::MockScrollbar::convertFromContainingWindow): - (WebCore::MockScrollbar::isOverlayScrollbar): - (MockScrollbar): - (WebCore::TEST): - -2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r124025. - http://trac.webkit.org/changeset/124025 - https://bugs.webkit.org/show_bug.cgi?id=92658 - - Causes color-suggestion-picker-appearance layout test to time - out on all Chromium platforms (Requested by tomhudson_ on - #webkit). - - * WebKit.gyp: - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::createColorChooser): - * src/ChromeClientImpl.h: - (WebCore): - (ChromeClientImpl): - * src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebKit): - (WebKit::ColorChooserProxy::ColorChooserProxy): - (WebKit::ColorChooserProxy::~ColorChooserProxy): - (WebKit::ColorChooserProxy::setSelectedColor): - (WebKit::ColorChooserProxy::endChooser): - * src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebKit): - (ColorChooserProxy): - * src/ColorChooserUIController.cpp: Removed. - * src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebKit): - (WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl): - (WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl): - (WebKit::WebColorChooserClientImpl::didChooseColor): - (WebKit::WebColorChooserClientImpl::didEndChooser): - * src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebCore): - (WebKit): - (WebColorChooserClientImpl): - -2012-07-30 Keishi Hattori <keishi@webkit.org> - - Implement datalist UI for input type color for Chromium - https://bugs.webkit.org/show_bug.cgi?id=92075 - - Reviewed by Kent Tamura. - - Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController. - ColorChooserUIController can control whether to open the color suggestion picker - popup or the color chooser depending on the responses from ColorChooserClient. - - * WebKit.gyp: - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser. - (WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium. - * src/ChromeClientImpl.h: - (WebKit): - (ChromeClientImpl): - * src/ColorChooserProxy.cpp: Removed. - * src/ColorChooserProxy.h: Removed. - * src/ColorChooserUIController.cpp: Added. - (WebKit): - (WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient. - (WebKit::ColorChooserUIController::~ColorChooserUIController): - (WebKit::ColorChooserUIController::setSelectedColor): - (WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser. - (WebKit::ColorChooserUIController::didChooseColor): - (WebKit::ColorChooserUIController::didEndChooser): - (WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size. - (WebKit::ColorChooserUIController::writeDocument): - (WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue. - (WebKit::ColorChooserUIController::didClosePopup): - (WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup. - (WebKit::ColorChooserUIController::closePopup): - (WebKit::ColorChooserUIController::openColorChooser): Opens color chooser. - * src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h. - (WebCore): - (WebKit): - (ColorChooserUIController): - * src/WebColorChooserClientImpl.cpp: Removed. - -2012-07-30 Kaustubh Atrawalkar <kaustubh@motorola.com> - - [DRT] LTC:: pageNumberForElementById() could be moved to Internals - https://bugs.webkit.org/show_bug.cgi?id=92091 - - Reviewed by Hajime Morita. - - Move the pageNumberForElementById from LayoutTestCotroller to Internals and - remove the old platform specific implementations as it exclusively tests WebCore functionality. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit): - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-07-30 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r124004. - http://trac.webkit.org/changeset/124004 - https://bugs.webkit.org/show_bug.cgi?id=92622 - - Broke Android build (Requested by keishi on #webkit). - - * WebKit.gyp: - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::createColorChooser): - * src/ChromeClientImpl.h: - (WebCore): - (ChromeClientImpl): - * src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebKit): - (WebKit::ColorChooserProxy::ColorChooserProxy): - (WebKit::ColorChooserProxy::~ColorChooserProxy): - (WebKit::ColorChooserProxy::setSelectedColor): - (WebKit::ColorChooserProxy::endChooser): - * src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebKit): - (ColorChooserProxy): - * src/ColorChooserUIController.cpp: Removed. - * src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebKit): - (WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl): - (WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl): - (WebKit::WebColorChooserClientImpl::didChooseColor): - (WebKit::WebColorChooserClientImpl::didEndChooser): - * src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h. - (WebCore): - (WebKit): - (WebColorChooserClientImpl): - -2012-07-30 Keishi Hattori <keishi@webkit.org> - - Implement datalist UI for input type color for Chromium - https://bugs.webkit.org/show_bug.cgi?id=92075 - - Reviewed by Kent Tamura. - - Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController. - ColorChooserUIController can control whether to open the color suggestion picker - popup or the color chooser depending on the responses from ColorChooserClient. - - * WebKit.gyp: - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser. - (WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium. - * src/ChromeClientImpl.h: - (WebKit): - (ChromeClientImpl): - * src/ColorChooserProxy.cpp: Removed. - * src/ColorChooserProxy.h: Removed. - * src/ColorChooserUIController.cpp: Added. - (WebKit): - (WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient. - (WebKit::ColorChooserUIController::~ColorChooserUIController): - (WebKit::ColorChooserUIController::setSelectedColor): - (WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser. - (WebKit::ColorChooserUIController::didChooseColor): - (WebKit::ColorChooserUIController::didEndChooser): - (WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size. - (WebKit::ColorChooserUIController::writeDocument): - (WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue. - (WebKit::ColorChooserUIController::didClosePopup): - (WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup. - (WebKit::ColorChooserUIController::closePopup): - (WebKit::ColorChooserUIController::openColorChooser): Opens color chooser. - * src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h. - (WebCore): - (WebKit): - (ColorChooserUIController): - * src/WebColorChooserClientImpl.cpp: Removed. - -2012-07-29 Lu Guanqun <guanqun.lu@intel.com> - - [chromium] pass acceleratePainting info to settings - https://bugs.webkit.org/show_bug.cgi?id=92467 - - Reviewed by Eric Seidel. - - The acceleratePainting info is not passed into settings correctly so - that GPU composition would not use the code path of accelerated painting. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): - -2012-07-29 Rik Cabanier <cabanier@adobe.com> - - Add ENABLE_CSS_COMPOSITING flag - https://bugs.webkit.org/show_bug.cgi?id=92553 - - Reviewed by Dirk Schulze. - - Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html - - * features.gypi: - -2012-07-28 Peter Kasting <pkasting@google.com> - - Sigh. Just disable all the AutoResize tests after the first three. - https://bugs.webkit.org/show_bug.cgi?id=92318 - - Unreviewed, making bots happier. - - * tests/WebViewTest.cpp: - -2012-07-28 Peter Kasting <pkasting@google.com> - - Try disabling different test in hopes of tracking down the real problem. - https://bugs.webkit.org/show_bug.cgi?id=92318 - - Unreviewed, making bots happier. - - * tests/WebViewTest.cpp: - -2012-07-27 Peter Kasting <pkasting@google.com> - - Disable failing test. - https://bugs.webkit.org/show_bug.cgi?id=92318 - - Unreviewed, making bots happier. - - * tests/WebViewTest.cpp: - -2012-07-27 Scott Graham <scottmg@chromium.org> - - Change navigator.webkitGamepads[] to navigator.webkitGetGamepads() - https://bugs.webkit.org/show_bug.cgi?id=92533 - - Reviewed by Adam Barth. - - Renames for updated access point. - - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enableGamepad): - (WebKit::WebRuntimeFeatures::isGamepadEnabled): - -2012-07-27 Kevin Ellis <kevers@chromium.org> - - [chromium] Calendar for input type=date should be larger on devices that support touch input. - https://bugs.webkit.org/show_bug.cgi?id=92424 - - Reviewed by Kent Tamura. - - Plumbs the deviceSupportsTouch setting through to the popup page so - that the Calendar popup can be enlarged on screens that support touch - input. - - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::initPage): - -2012-07-27 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-27 Oli Lan <olilan@chromium.org> - - [chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes). - https://bugs.webkit.org/show_bug.cgi?id=79117 - - Fix two issues in WebFrameImpl::visiblePositionForWindowPoint. - - 1) If the point is off-screen, the visiblePosition is clipped to the screen. - - The fix is to add HitTestRequest::IgnoreClipping. - - 2) The result is incorrect if the point is within an iframe. - - This is because we are calling convertFromContainingWindow twice: once in windowToContents, - and then explicitly as well. - - This patch removes the explicit call to convertFromContainingWindow. - - Reviewed by Adam Barth. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::visiblePositionForWindowPoint): - -2012-07-27 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-27 Alec Flett <alecflett@chromium.org> - - IndexedDB: inject index keys on cursor/objectstore/index get success handlers - https://bugs.webkit.org/show_bug.cgi?id=91123 - - Reviewed by Tony Chang. - - Remove method no longer used. - - * tests/IDBFakeBackingStore.h: - -2012-07-26 Yoshifumi Inoue <yosin@chromium.org> - - [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week - https://bugs.webkit.org/show_bug.cgi?id=92339 - - Reviewed by Kent Tamura. - - To detect compilation errors and test failure earlier, I would like - build and run tests for input type datetime, datetime-local, month, - time and week with runtime feature flags to avoid behavior changes - on chromium browser. - - This patch adds query and change functions for runtime features of - input type datetime, datetime-local, month, time and week to WebRuntimeFeatures - class for exposing DRT and chromium browser expermental flags. - - * features.gypi: Turn on ENABLE_INPUT_TYPE_DATETIME, ENABLE_INPUT_TYPE_DATETIMELOCAL, - ENABLE_INPUT_TYPE_MONTH, ENABLE_INPUT_TYPE_TIME, and ENABLE_INPUT_TYPE_WEEK for all OS. - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enableInputTypeDateTime): Added. - (WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled): Added. - (WebKit::WebRuntimeFeatures::enableInputTypeDateTimeLocal): Added. - (WebKit::WebRuntimeFeatures::isInputTypeDateTimeLocalEnabled): Added. - (WebKit::WebRuntimeFeatures::enableInputTypeMonth): Added. - (WebKit::WebRuntimeFeatures::isInputTypeMonthEnabled): Added. - (WebKit::WebRuntimeFeatures::enableInputTypeTime): Added. - (WebKit::WebRuntimeFeatures::isInputTypeTimeEnabled): Added. - (WebKit::WebRuntimeFeatures::enableInputTypeWeek): Added. - (WebKit::WebRuntimeFeatures::isInputTypeWeekEnabled): Added. - -2012-07-26 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r123799. - http://trac.webkit.org/changeset/123799 - https://bugs.webkit.org/show_bug.cgi?id=92431 - - broke the Apple Mac build (Requested by bweinstein on - #webkit). - - * src/WebInputEventConversion.cpp: - (WebKit): - * src/WebInputEventConversion.h: - (WebKit): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::handleEvent): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - -2012-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org> - - Propagate gesture events to plugins. - https://bugs.webkit.org/show_bug.cgi?id=92281 - - Reviewed by Adam Barth. - - Propagate gesture events to plugins. - - * src/WebInputEventConversion.cpp: - (WebKit): - (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): - * src/WebInputEventConversion.h: - (WebCore): - (WebKit): - (WebGestureEventBuilder): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::handleEvent): - * src/WebPluginContainerImpl.h: - (WebCore): - (WebPluginContainerImpl): - -2012-07-26 Adrienne Walker <enne@google.com> - - [chromium] Remove redundant surface origin transforms - https://bugs.webkit.org/show_bug.cgi?id=91815 - - Reviewed by Stephen White. - - Clean up use of origin transforms in tests. Where possible, test - against the equivalent draw transform. - - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - -2012-07-25 David Grogan <dgrogan@chromium.org> - - IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events - https://bugs.webkit.org/show_bug.cgi?id=92203 - - Reviewed by Adam Barth. - - This is the beginning of our typical three-sided-patch process. - - * public/WebIDBCallbacks.h: - (WebKit::WebIDBCallbacks::onBlocked): - (WebKit::WebIDBCallbacks::onUpgradeNeeded): - * public/WebIDBDatabaseCallbacks.h: - (WebKit::WebIDBDatabaseCallbacks::onVersionChange): - * public/WebIDBFactory.h: - (WebIDBFactory): - (WebKit::WebIDBFactory::open): - * src/WebIDBFactoryImpl.cpp: - (WebKit::WebIDBFactoryImpl::open): - (WebKit): - * src/WebIDBFactoryImpl.h: - (WebIDBFactoryImpl): - -2012-07-19 Adrienne Walker <enne@google.com> - - [chromium] Make all compositor screen space transforms operate on content rects - https://bugs.webkit.org/show_bug.cgi?id=91807 - - Reviewed by Kenneth Russell. - - Update tests that deal with screen space transforms to reflect this change. - - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-07-25 Andrew Wilson <atwilson@chromium.org> - - Unreviewed chromium change to disable failing WebViewTest.AutoResizeInBetweenSizes. - https://bugs.webkit.org/show_bug.cgi?id=92318 - - * tests/WebViewTest.cpp: - -2012-07-25 Scott Graham <scottmg@chromium.org> - - [Chromium] fix double->float warnings in CCLayerTreeHostCommonTest.cpp - https://bugs.webkit.org/show_bug.cgi?id=92271 - - Reviewed by Adrienne Walker. - - Fix compile warnings on Windows. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-07-25 Dana Jansens <danakj@chromium.org> - - [chromium] Move WebFilterOperations from RenderPassDrawQuad to RenderPass - https://bugs.webkit.org/show_bug.cgi?id=91885 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - (FakeCCRendererClient::rootRenderPass): - (FakeCCRendererClient::renderPassesInDrawOrder): - (FakeCCRendererClient::renderPasses): - (FakeCCRendererClient): - (TEST_F): - (TEST): - -2012-07-24 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Refactor CCLayerTreeHostCommon: move root layer special case initialization into internal code. - https://bugs.webkit.org/show_bug.cgi?id=88953 - - Reviewed by Adrienne Walker. - - Unit tests updated to account for the new less-special root layer setup. - - most test cases just needed to remove root->renderSurface()->setContentBounds(), createRenderSurface(), and renderSurfaceLayerList.append(). - - some test cases originally relied on setting some awkward unconventional bounds of the rootLayer that were different than the rootLayer's renderSurface. these tests are updated. - - a few minor cleanups otherwise. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::executeCalculateDrawTransformsAndVisibility): - * tests/CCLayerIteratorTest.cpp: - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): - -2012-07-25 Taiju Tsuiki <tzik@chromium.org> - - FileSystem should provide a way to delete filesystem. - https://bugs.webkit.org/show_bug.cgi?id=91861 - - Reviewed by Adam Barth. - - * public/WebFrameClient.h: - (WebFrameClient): - (WebKit::WebFrameClient::deleteFileSystem): - * src/LocalFileSystemChromium.cpp: Add deleteFileSystem - (WebCore::deleteFileSystemNotAllowed): - (WebCore): - (WebCore::LocalFileSystem::deleteFileSystem): - -2012-07-25 Alok Priyadarshi <alokp@chromium.org> - - [chromium] WebViewBenchmarkSupport::paint API does not work with recording canvas - https://bugs.webkit.org/show_bug.cgi?id=92008 - - Reviewed by Darin Fisher. - - Moved the ownership of canvas to WebViewBenchmarkSupport::PaintClient. - - * public/WebViewBenchmarkSupport.h: - (PaintClient): - (WebKit::WebViewBenchmarkSupport::PaintClient::willPaint): - (WebKit::WebViewBenchmarkSupport::PaintClient::didPaint): - * src/WebViewBenchmarkSupportImpl.cpp: - (WebKit::WebViewBenchmarkSupportImpl::paintLayer): - (WebKit::WebViewBenchmarkSupportImpl::softwarePaint): - -2012-07-24 Dana Jansens <danakj@chromium.org> - - [chromium] Turn the debug HUD into a layer so that it can be drawn as a WebCompositorQuad - https://bugs.webkit.org/show_bug.cgi?id=92182 - - Reviewed by Adrienne Walker. - - * tests/LayerRendererChromiumTest.cpp: - (TEST): - -2012-07-25 Adrienne Walker <enne@google.com> - - [chromium] Unify compositor quadTransform/drawTransform/originTransform - https://bugs.webkit.org/show_bug.cgi?id=91417 - - Reviewed by Kenneth Russell. - - Clean up tests to refer to the new draw transform semantics. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::createTestTreeWithOneSurface): - (WebKitTests::createTestTreeWithTwoSurfaces): - (WebKitTests::TEST_F): - * tests/CCLayerSorterTest.cpp: - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread): - * tests/CCQuadCullerTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-07-25 Kevin Ellis <kevers@chromium.org> - - [chromium] Calendar picker popup displays at wrong scale when deviceScaleFactor != 1. - https://bugs.webkit.org/show_bug.cgi?id=92177 - - Manually tested at deviceScaleFactor = 1 and 2. - - Reviewed by Kent Tamura. - - The device scale factor was not being set for the calendar popup. - As a result, the popup was rendered too small on hidpi displays. - This patch sets the device scale factor for any page popup. - - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::initPage): - -2012-07-25 MORITA Hajime <morrita@google.com> - - Another unreviewed win build fix against r123569. - - * tests/IDBAbortOnCorruptTest.cpp: - -2012-07-25 MORITA Hajime <morrita@google.com> - - Unreviewed win build fix against r123569. - - * tests/IDBAbortOnCorruptTest.cpp: - * tests/IDBDatabaseBackendTest.cpp: - -2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-24 Dave Tu <dtu@chromium.org> - - [chromium] Move renderingStats from WebView to WebWidget. - https://bugs.webkit.org/show_bug.cgi?id=92184 - - Reviewed by Adam Barth. - - We are going to add some rendering stats that work in non-composited mode, so the renderingStats() method should be moved from WebView to WebWidget. - - * public/WebView.h: - (WebKit): - (WebView): - * public/WebWidget.h: - (WebKit): - (WebWidget): - (WebKit::WebWidget::renderingStats): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-24 Alec Flett <alecflett@chromium.org> - - IndexedDB: fix #include dependencies so IDBRequest isn't an include root - https://bugs.webkit.org/show_bug.cgi?id=92167 - - Reviewed by Tony Chang. - - Remove implicit dependencies due to using IDBRequest.h, and fix all - places that break as a result. - - * src/IDBCallbacksProxy.cpp: - * src/WebIDBDatabaseImpl.cpp: - * src/WebIDBTransactionImpl.cpp: - -2012-07-24 Adam Barth <abarth@webkit.org> - - [Chromium] Support scrolling and zooming to focused input elements - https://bugs.webkit.org/show_bug.cgi?id=91661 - - Reviewed by Darin Fisher. - - This patch introduces saveScrollAndScaleState and - restoreScrollAndScaleState, which can be used to save and restore the - scroll and scale state of the WebView, respectively. These functions - will be used by Chromium on Android to save the scale and scrolls state - before zoom into a text field so that we can "undo" the zoom if the - user didn't mean to zoom into the text field. - - I wanted to write unit tests for these functions, but it wasn't clear - to me how to write the test because startPageScaleAnimation appears to - complete asynchronously. - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::saveScrollAndScaleState): - (WebKit): - (WebKit::WebViewImpl::restoreScrollAndScaleState): - (WebKit::WebViewImpl::resetSavedScrollAndScaleState): - (WebKit::WebViewImpl::didCommitLoad): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-24 Dave Tu <dtu@chromium.org> - - [chromium] Add time spent painting to GPU benchmarking renderingStats() API. - https://bugs.webkit.org/show_bug.cgi?id=90019 - - Reviewed by Adrienne Walker. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::renderingStats): - * tests/CCLayerTreeHostTest.cpp: - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect): - (WebKitTests::FakeTiledLayerChromium::update): - * tests/CCTiledLayerTestCommon.h: - (Texture): - (FakeTiledLayerChromium): - * tests/Canvas2DLayerBridgeTest.cpp: - * tests/ContentLayerChromiumTest.cpp: - (WebKit::TEST): - * tests/TiledLayerChromiumTest.cpp: - -2012-07-24 Jian Li <jianli@chromium.org> - - Add per-context setting for html notifications - https://bugs.webkit.org/show_bug.cgi?id=91295 - - Reviewed by Adam Barth. - - Add new per-context feature for chromium port. - - * public/WebPermissionClient.h: - (WebPermissionClient): - (WebKit::WebPermissionClient::allowHTMLNotifications): - * src/ContextFeaturesClientImpl.cpp: - (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): - -2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r123499. - http://trac.webkit.org/changeset/123499 - https://bugs.webkit.org/show_bug.cgi?id=92161 - - Android fails to compile (Requested by zhenyao on #webkit). - - * src/AssertMatchingEnums.cpp: - -2012-07-24 Terry Anderson <tdanderson@chromium.org> - - [chromium] Add a bounding box member in WebGestureEvent - https://bugs.webkit.org/show_bug.cgi?id=92144 - - Reviewed by Adam Barth. - - The new |boundingBox| member will be used to store the touch region for a WebGestureEvent. - This will be useful for gesture target fuzzing across multiple different gesture types - (tap, long press, scroll, etc.) - - * public/WebInputEvent.h: - (WebGestureEvent): - * src/WebInputEvent.cpp: - (SameSizeAsWebGestureEvent): - -2012-07-24 Nico Weber <thakis@chromium.org> - - [chromium/mac] Add cursor resource pngs to the pak file. - https://bugs.webkit.org/show_bug.cgi?id=92148 - - Reviewed by Tony Chang. - - Once https://chromiumcodereview.appspot.com/10817031/ has landed, they can be - removed from WebCore.gyp's mac_bundle_resources. Part of http://crbug.com/137588 - - * WebKit.grd: - -2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r123472. - http://trac.webkit.org/changeset/123472 - https://bugs.webkit.org/show_bug.cgi?id=92134 - - Revert roll to v8 version that crashes sporadically (Requested - by atwilson on #webkit). - - * DEPS: - -2012-07-24 Keishi Hattori <keishi@webkit.org> - - [Chromium] Page popup should close on mouse down - https://bugs.webkit.org/show_bug.cgi?id=92092 - - Reviewed by Kent Tamura. - - Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that - we can hook to hide the page popup when the user clicks on the page. - - * src/WebPagePopupImpl.h: - (WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client. - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the - mouse down event opened the same popup we just closed. - -2012-07-24 Jochen Eisinger <jochen@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-24 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r123463. - http://trac.webkit.org/changeset/123463 - https://bugs.webkit.org/show_bug.cgi?id=92110 - - Broke Android build (Requested by keishi on #webkit). - - * src/WebPagePopupImpl.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleMouseDown): - -2012-07-24 Keishi Hattori <keishi@webkit.org> - - [Chromium] Page popup should close on mouse down - https://bugs.webkit.org/show_bug.cgi?id=92092 - - Reviewed by Kent Tamura. - - Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that - we can hook to hide the page popup when the user clicks on the page. - - * src/WebPagePopupImpl.h: - (WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client. - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the - mouse down event opened the same popup we just closed. - -2012-07-24 Anthony Scian <ascian@rim.com> - - Web Inspector [JSC]: Enable initiator column in network panel. - https://bugs.webkit.org/show_bug.cgi?id=65533 - - Reviewed by Vsevolod Vlasov. - - With 40118 fixed for webkit, Preferences.displayInitiator should be set to true. - Removed references to it since the optionality is no longer required. - - Test: http/tests/inspector/network/network-initiator.html - - * src/js/DevTools.js: - -2012-07-24 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-23 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move layoutTestMode to WebCore - https://bugs.webkit.org/show_bug.cgi?id=92010 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - * src/WebKit.cpp: - (WebKit::setLayoutTestMode): - (WebKit::layoutTestMode): - -2012-07-23 Dave Tu <dtu@chromium.org> - - [chromium] Add droppedFrameCount to renderingStats. - https://bugs.webkit.org/show_bug.cgi?id=91694 - - Reviewed by Adrienne Walker. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::renderingStats): - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread): - -2012-07-23 Brian Anderson <brianderson@chromium.org> - - [chromium] Use shallow flushes that don't glFlush - https://bugs.webkit.org/show_bug.cgi?id=90325 - - Reviewed by Kenneth Russell. - - Changed CCTextureUpdaterTest to recognize shallowFlushCHROMIUM(). - - * tests/CCTextureUpdaterTest.cpp: - -2012-07-23 Adrienne Walker <enne@google.com> - - [chromium] Add more compositor unit tests for high DPI transforms - https://bugs.webkit.org/show_bug.cgi?id=91917 - - Reviewed by Kenneth Russell. - - The current set of high DPI tests only deal with layers in a render - surface. Add some extra tests for non-surface layers. Also add a test - to make sure that an owning layer in a surface doesn't differ from a - non-owning layer in high DPI circumstances. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-07-23 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Fix unit tests in debug mode after r123375 - https://bugs.webkit.org/show_bug.cgi?id=92030 - - Reviewed by Adrienne Walker. - - Fixed two unit tests that were causing debug assertions because - they gave calcDrawTransforms an empty sized root layer. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-07-23 Simon Fraser <simon.fraser@apple.com> - - Part 2 of: Implement sticky positioning - https://bugs.webkit.org/show_bug.cgi?id=90046 - - Reviewed by Ojan Vafai. - - Turn on ENABLE_CSS_STICKY_POSITION. - - * features.gypi: - -2012-07-23 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect design - https://bugs.webkit.org/show_bug.cgi?id=80622 - - Reviewed by Adrienne Walker. - - Many tests needed to be updated because the semantics of the layer tree have changed: - - a few tests that were no longer applicable were removed. - - many tests needed to have fixed initialization, properly - setting surface contentRect and rootLayer bounds. - - because clipRect and usesLayerClipping no longer exists, those places in code had to be removed/changed - - the scissorRect tests needed to have updated expectations - because after this patch, the rootLayer Surface now clips - to its contentBounds. - - the clipRect tests were changed to test the layer's new semantics for the drawableContentRect instead. - - * tests/CCLayerImplTest.cpp: - (WebCore::TEST): - * tests/CCLayerIteratorTest.cpp: - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): - * tests/LayerChromiumTest.cpp: - -2012-07-23 Daniel Cheng <dcheng@chromium.org> - - [chromium] Fix build on Ubuntu Precise. - https://bugs.webkit.org/show_bug.cgi?id=92021 - - Reviewed by Adrienne Walker. - - Remove an array that's written but never read. - - * tests/CCResourceProviderTest.cpp: - (WebKit::TEST_F): - -2012-07-23 Nate Chapin <japhet@chromium.org> - - Add WebTextInputType enum values for text areas and - content-editable. - https://bugs.webkit.org/show_bug.cgi?id=91654 - - Reviewed by Adam Barth. - - No new tests, no behavior change without corresponding chromium.org changes. - - * public/WebTextInputType.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::textInputType): - -2012-07-23 Pierre Rossi <pierre.rossi@gmail.com> - - Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client - https://bugs.webkit.org/show_bug.cgi?id=91006 - - Reviewed by Ryosuke Niwa. - - Rename the functions to follow a more boolean logic. - - * public/WebViewClient.h: - (WebKit::WebViewClient::hasTouchEventHandlers): - * src/ChromeClientImpl.cpp: - (WebKit): - (WebKit::ChromeClientImpl::needTouchEvents): - * src/ChromeClientImpl.h: - (ChromeClientImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::hasTouchEventHandlers): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-23 Simon Fraser <simon.fraser@apple.com> - - Implement sticky positioning - https://bugs.webkit.org/show_bug.cgi?id=90046 - - Reviewed by Ojan Vafai. - - Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially. - - * features.gypi: - -2012-07-23 Peter Beverloo <peter@chromium.org> - - [Chromium] Buildfix for fixing gclient on the Chromium Windows bot - https://bugs.webkit.org/show_bug.cgi?id=91977 - - Unreviewed build fix. - - Add the tools/isolate directory to the Windows checkout as these files - currently are missing during gyp generation. maruel introduced the need - for these in this isolate refactoring, specifically this Chromium CL: - http://src.chromium.org/viewvc/chrome?view=rev&revision=147689 - - * DEPS: - -2012-07-22 Kent Tamura <tkent@chromium.org> - - [Chromium-Mac] Fix a build error. - - * DEPS: Add third_party/GTM. - -2012-07-23 Kent Tamura <tkent@chromium.org> - - Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively - https://bugs.webkit.org/show_bug.cgi?id=91941 - - Reviewed by Kentaro Hara. - - A flag name for an elmement should be ENABLE_*_ELEMENT. - - * features.gypi: - -2012-07-22 Kent Tamura <tkent@chromium.org> - - Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT - https://bugs.webkit.org/show_bug.cgi?id=91928 - - Reviewed by Kentaro Hara. - - A flag name for an elmement should be ENABLE_*_ELEMENT. - - * features.gypi: - -2012-07-21 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-20 Kent Tamura <tkent@chromium.org> - - Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT - https://bugs.webkit.org/show_bug.cgi?id=91846 - - Reviewed by Kentaro Hara. - - A flag name for an elmement should be ENABLE_*_ELEMENT. - - * features.gypi: - * src/WebInputElement.cpp: - (WebKit::WebInputElement::dataListOptions): - -2012-07-20 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Simplify backend interface classes - https://bugs.webkit.org/show_bug.cgi?id=91901 - - Reviewed by Tony Chang. - - Remove unnecessary method stubs from proxy class. - - * src/IDBTransactionBackendProxy.cpp: - * src/IDBTransactionBackendProxy.h: - (IDBTransactionBackendProxy): - -2012-07-20 Scott Graham <scottmg@chromium.org> - - Add windows native versions of bison, flex and gperf. - - Reviewed by Tony Chang. - - * DEPS: - -2012-07-20 David Grogan <dgrogan@chromium.org> - - IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types - https://bugs.webkit.org/show_bug.cgi?id=91414 - - Reviewed by Adam Barth. - - * src/AssertMatchingEnums.cpp: - * src/WebIDBMetadata.cpp: - (WebKit::WebIDBMetadata::WebIDBMetadata): - (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): - -2012-07-20 Robert Sesek <rsesek@chromium.org> - - [chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6 - https://bugs.webkit.org/show_bug.cgi?id=91752 - - Reviewed by Eric Seidel. - - Use 10.6 NSScreen/NSColorSpace APIs to determine if the screen is - monochrome rather than comparing against deprecated colorspace names. - - * src/mac/WebScreenInfoFactory.mm: - (WebKit::WebScreenInfoFactory::screenInfo): - -2012-07-20 Daniel Murphy <dmurph@chromium.org> - - Introduce WebViewBenchmarkSupport for performance experiments on a real WebView - https://bugs.webkit.org/show_bug.cgi?id=88271 - - Reviewed by Darin Fisher. - - * WebKit.gyp: - * public/WebView.h: - (WebKit): - (WebView): - (WebKit::WebView::benchmarkSupport): - * public/WebViewBenchmarkSupport.h: Added. - (WebKit): - (WebViewBenchmarkSupport): - (PaintClient): - (WebKit::WebViewBenchmarkSupport::PaintClient::willPaint): - (WebKit::WebViewBenchmarkSupport::PaintClient::didPaint): - (WebKit::WebViewBenchmarkSupport::PaintClient::~PaintClient): - (WebKit::WebViewBenchmarkSupport::~WebViewBenchmarkSupport): - * src/WebViewBenchmarkSupportImpl.cpp: Added. - (WebKit): - (WebKit::WebViewBenchmarkSupportImpl::paintLayer): - (WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped): - (WebKit::WebViewBenchmarkSupportImpl::softwarePaint): - (WebKit::WebViewBenchmarkSupportImpl::paint): - * src/WebViewBenchmarkSupportImpl.h: Added. - (WebCore): - (WebKit): - (WebViewBenchmarkSupportImpl): - (WebKit::WebViewBenchmarkSupportImpl::WebViewBenchmarkSupportImpl): - (WebKit::WebViewBenchmarkSupportImpl::~WebViewBenchmarkSupportImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::benchmarkSupport): - (WebKit): - (WebKit::WebViewImpl::rootGraphicsLayer): - * src/WebViewImpl.h: - (WebKit): - (WebViewImpl): - -2012-07-20 Han Shen <shenhan@google.com> - - [Chromium] Compilation fails under gcc 4.7 - https://bugs.webkit.org/show_bug.cgi?id=90227 - - Reviewed by Tony Chang. - - Disable warnings about c++0x compatibility in gcc newer than 4.6. - - * WebKit.gyp: - * WebKitUnitTests.gyp: - -2012-07-20 Adam Barth <abarth@webkit.org> - - [Chromium] Add WebView::zoomToFindInPageRect for Android - https://bugs.webkit.org/show_bug.cgi?id=91801 - - Reviewed by Tony Chang. - - On Android, when you find in page, we scale the viewport to reveal what - you've found (because the screen is small). This function instructs the - WebView to zoom to display a given rect. - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::animateZoomAroundPoint): - - This function is a bit more general than necessary for this patch - because it is also used in other cases for animating a zoom - around a given point (e.g., double-tap to zoom). These uses will - be upstreamed in later patches. - (WebKit::WebViewImpl::zoomToFindInPageRect): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-19 Luke Macpherson <macpherson@chromium.org> - - Enable CSS variables compile time flag in Chrome. - https://bugs.webkit.org/show_bug.cgi?id=91708 - - Reviewed by Dimitri Glazkov. - - Flips the ENABLE_CSS_VARIABLES compile flag on for Chrome. There is also a run-time flag that is off by default, - so this should not have a user visible effect other than making the variables runtime flag visible at chrome://flags/ - - * features.gypi: - -2012-07-19 Wei James <james.wei@intel.com> - - enable Web Audio for chromium android port - https://bugs.webkit.org/show_bug.cgi?id=89428 - - Reviewed by Kenneth Russell. - - * features.gypi: - -2012-07-19 Adam Barth <abarth@webkit.org> - - [Chromium] Support external autofill popups - https://bugs.webkit.org/show_bug.cgi?id=91651 - - Reviewed by Darin Fisher. - - This looks like the last piece needed to support external autofill - popups. This function just lets the embedder select an index - (presumably because the user picked an index from the external autofill - popup). - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::selectAutofillSuggestionAtIndex): - (WebKit): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-19 Zeev Lieber <zlieber@chromium.org> - - [Chromium] Textures drawn during occlusion are incorrectly re-used when unoccluded. - https://bugs.webkit.org/show_bug.cgi?id=91537 - - Reviewed by Adrienne Walker. - - Added unit tests to test texture caching with clipping and - occlusion. Removed some minor code duplication when initializing - layers for various scenarios. - - MockCCQuadCuller can now implement CCQuadSink. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/MockCCQuadCuller.h: - (WebCore::MockCCQuadCuller::MockCCQuadCuller): - -2012-07-19 Adam Barth <abarth@webkit.org> - - [Chromium] WebView is missing isSelectionEditable and backgroundColor which are used by chromium-android - https://bugs.webkit.org/show_bug.cgi?id=91671 - - Reviewed by Darin Fisher. - - I haven't studied what these APIs are used for downstream, but they - seem harmless enough. - - * public/WebView.h: - (WebView): - * public/WebWidget.h: - (WebWidget): - (WebKit::WebWidget::backgroundColor): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::isSelectionEditable): - (WebKit): - (WebKit::WebViewImpl::backgroundColor): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-19 Andrew Scherkus <scherkus@chromium.org> - - [chromium] Move WebAudioSourceProvider destructor from public to protected - https://bugs.webkit.org/show_bug.cgi?id=91669 - - Reviewed by Darin Fisher. - - The lifetime of a WebAudioSourceProvider is managed by the implementor - and should never be deallocted by WebKit. - - * public/WebAudioSourceProvider.h: - (WebAudioSourceProvider): - -2012-07-19 Tony Chang <tony@chromium.org> - - Unreviewed, rolling out r123036. - http://trac.webkit.org/changeset/123036 - https://bugs.webkit.org/show_bug.cgi?id=91555 - - Triggers some DCHECKs in Chromium browser_tests - - * public/WebTextInputType.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::textInputType): - -2012-07-19 Joshua Bell <jsbell@chromium.org> - - Roll out r121610 and r122487 which may have been causing flaky crashes - https://bugs.webkit.org/show_bug.cgi?id=91637 - - Reviewed by Kentaro Hara. - - Flaky crashes started in random tests following r121610. It's not clear - that r121610 is to blame, but we'd like to prove or disprove it. - If this doesn't resolve the crashes, this patch should be rolled out. - - * src/WebBindings.cpp: - (WebKit::getRangeImpl): - (WebKit::getElementImpl): - (WebKit::getArrayBufferImpl): - (WebKit::getArrayBufferViewImpl): - (WebKit::WebBindings::toV8Value): - -2012-07-19 Sami Kyostila <skyostil@chromium.org> - - [chromium] Remove duplicate mock CCLayerTreeHostClient - https://bugs.webkit.org/show_bug.cgi?id=89457 - - Reviewed by Adrienne Walker. - - This test can reuse the existing CCFakeLayerTreeHostClient. - - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::MockLayerTreeHost::create): - -2012-07-19 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-18 Ryosuke Niwa <rniwa@webkit.org> - - Chromium build fix attempt. Don't use anonymous namespace. - - * tests/TextureCopierTest.cpp: - -2012-07-18 Antoine Labour <piman@chromium.org> - - [chromium] Introduce CCResourceProvider, replacing TextureAllocator and hiding textures from clients to allow transport - https://bugs.webkit.org/show_bug.cgi?id=91044 - - Reviewed by Adrienne Walker. - - This does several things: - - Add a CCResourceProvider class, that hides textures and the 3D context - from layers (except those that need it). Instead layers manage - "resources". In the future, resources are expected to be transportable - to a "parent" CCResourceProvider to allow flattening of nested - compositors. - - Replace texture ids by resource ids in DrawQuads (allowing them to be - serializable). - - Replace TextureAllocator uses by the CCResourceProvider class. - - Upload of data is done through the CCResourceProvider instead of - explicit GL calls. - - External textures are wrapped into a resource at draw time (see - caveat/FIXME in CCTextureLayerImpl). - - Rendering with the resources is done through an explicit - beginRenderFrom/endRenderFrom that exposes the texture only between that - pair. - - Merge all the LayerTextureSubImage instances (one per layer), into a - single instance on the CCResourceProvider. - - Added CCResourceProviderTest, the refactoring is covered by existing tests. - - * WebKit.gypi: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCPrioritizedTextureTest.cpp: - (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): - (WTF::CCPrioritizedTextureTest::createManager): - (WTF::CCPrioritizedTextureTest::validateTexture): - (WTF::CCPrioritizedTextureTest::resourceProvider): - (CCPrioritizedTextureTest): - (WTF::TEST_F): - * tests/CCQuadCullerTest.cpp: - * tests/CCResourceProviderTest.cpp: Added. - (WebKit): - (ResourceProviderContext): - (WebKit::ResourceProviderContext::create): - (WebKit::ResourceProviderContext::bindTexture): - (WebKit::ResourceProviderContext::createTexture): - (WebKit::ResourceProviderContext::deleteTexture): - (WebKit::ResourceProviderContext::texStorage2DEXT): - (WebKit::ResourceProviderContext::texImage2D): - (WebKit::ResourceProviderContext::texSubImage2D): - (WebKit::ResourceProviderContext::getPixels): - (WebKit::ResourceProviderContext::textureCount): - (WebKit::ResourceProviderContext::textureSize): - (WebKit::ResourceProviderContext::ResourceProviderContext): - (WebKit::ResourceProviderContext::Texture::Texture): - (Texture): - (WebKit::ResourceProviderContext::allocateTexture): - (WebKit::ResourceProviderContext::setPixels): - (CCResourceProviderTest): - (WebKit::CCResourceProviderTest::CCResourceProviderTest): - (WebKit::CCResourceProviderTest::context): - (WebKit::CCResourceProviderTest::getResourcePixels): - (WebKit::TEST_F): - * tests/CCScopedTextureTest.cpp: - (WebKitTests::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::createLayer): - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): - * tests/CCTiledLayerTestCommon.h: - (Texture): - (WebKitTests::FakeTextureCopier::copyTexture): - (WebKitTests::FakeTextureCopier::flush): - (WebKitTests::FakeTextureUploader::uploadTexture): - * tests/ContentLayerChromiumTest.cpp: - (WebKit::TEST): - * tests/FakeCCGraphicsContext.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCTexture.h. - (WebKit): - (WebKit::createFakeCCGraphicsContext): - * tests/LayerRendererChromiumTest.cpp: - (FakeLayerRendererChromium::FakeLayerRendererChromium): - (LayerRendererChromiumTest::LayerRendererChromiumTest): - (LayerRendererChromiumTest::context): - (LayerRendererChromiumTest): - (TEST_F): - (TEST): - * tests/TextureCopierTest.cpp: - * tests/TextureManagerTest.cpp: - (WTF::TextureManagerTest::TextureManagerTest): - (WTF::TextureManagerTest::createTextureManager): - (WTF::TextureManagerTest::requestTexture): - (TextureManagerTest): - * tests/TiledLayerChromiumTest.cpp: - -2012-07-18 David Grogan <dgrogan@chromium.org> - - IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h - https://bugs.webkit.org/show_bug.cgi?id=91408 - - Reviewed by Adam Barth. - - This is in support of the new upgradeneeded versioning api. - intVersion will eventually replace the WebString version member. - - * public/WebIDBMetadata.h: - (WebKit::WebIDBMetadata::WebIDBMetadata): - The spec uses unsigned long long for version numbers but we use signed - long long so that we can use -1 as a sentinel. It indicates that a - database still uses a string version. - -2012-07-18 Adam Barth <abarth@webkit.org> - - Disable printing on chromium-android - https://bugs.webkit.org/show_bug.cgi?id=91550 - - Reviewed by Tony Chang. - - We don't implement printing on Android. - - * features.gypi: - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::printPage): - -2012-07-18 Alexandre Elias <aelias@google.com> - - [chromium] Ubercomp: add id to SharedQuadState - https://bugs.webkit.org/show_bug.cgi?id=91670 - - Reviewed by Adrienne Walker. - - This assigns an integer ID to SharedQuadState objects and a - corresponding ID to quads. This ID is unique only within a - RenderPass and currently is just set to the index in the shared quad - state list. This is redundant with the pointer and exists to - simplify serialization. - - I found out that pointer rewriting within a pickler is blocked by - pointers to memory being const there, so the reassignment will have to - be performed in the application layer anyway. In that case, it's - simplest to add some ID integers. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - (CCLayerTestCommon::getQuads): - -2012-07-18 Nate Chapin <japhet@chromium.org> - - Add WebTextInputType enum values for text areas and - content-editable. - https://bugs.webkit.org/show_bug.cgi?id=91654 - - Reviewed by Adam Barth. - - No new tests, no behavior change without corresponding chromium.org changes. - - * public/WebTextInputType.h: - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::textInputType): - -2012-07-18 Alexandre Elias <aelias@google.com> - - [chromium] Ubercomp: clean up CCRenderer interface - https://bugs.webkit.org/show_bug.cgi?id=91555 - - Reviewed by Adrienne Walker. - - I replaced the one-by-one RenderPass calls with a new drawFrame() - method that directly takes a CCRenderPassList, and moved a small - amount of code from CCLayerTreeHostImpl to implement it. In ubercomp - mode, we will produce a frame bundle rather than a command-stream, so - the full list is easier to work with. - - Also, give empty default implementations for the methods that don't - need to do anything in a non-GL context, and make private - setScissorToRect. - - * tests/LayerRendererChromiumTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - (FakeCCRendererClient::renderPasses): - (FakeCCRendererClient): - (TEST_F): - (TEST): - -2012-07-18 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Fix some coding style violations - https://bugs.webkit.org/show_bug.cgi?id=91565 - - Reviewed by Tony Chang. - - * tests/IDBLevelDBCodingTest.cpp: - (IDBLevelDBCoding::TEST): - -2012-07-18 Tony Chang <tony@chromium.org> - - [chromium] Unreviewed, fix some MSVC compile warnings. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-07-18 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Call SQLiteFileSystem-related functions directly - https://bugs.webkit.org/show_bug.cgi?id=91631 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * public/platform/WebKitPlatformSupport.h: - (WebKitPlatformSupport): - * src/PlatformSupport.cpp: - (WebCore): - -2012-07-18 Tony Chang <tony@chromium.org> - - [chromium] Unreviewed, more compile fixes on Chromium Win. - - * tests/WebTransformationMatrixTest.cpp: - (WebKit::TEST): - -2012-07-18 Tony Chang <tony@chromium.org> - - [chromium] Fix compile on Windows. - - 148>tests\LayerChromiumTest.cpp(510): warning C4305: 'argument' : truncation from 'double' to 'float' - - * tests/LayerChromiumTest.cpp: - -2012-07-18 Alec Flett <alecflett@chromium.org> - - Implement putIndexKeys in WebIDBObjectStoreImpl - https://bugs.webkit.org/show_bug.cgi?id=91546 - - Reviewed by Darin Fisher. - - Implement putIndexKeys in the chromium API, so it is callable - from chromium. - - * src/WebIDBObjectStoreImpl.cpp: - (WebKit::WebIDBObjectStoreImpl::putWithIndexKeys): - (WebKit): - * src/WebIDBObjectStoreImpl.h: - (WebIDBObjectStoreImpl): - -2012-07-18 Tony Chang <tony@chromium.org> - - [chromium] Unreviewed compile fix for Android. - - More sqrt fixes. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-07-18 Tony Chang <tony@chromium.org> - - [chromium] Unreviewed compile fix for Android. - - Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual void<unnamed>::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()': - Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - -2012-07-18 Varun Jain <varunjain@chromium.org> - - [chromium] Drag image for image elements should be scaled with device scale factor. - https://bugs.webkit.org/show_bug.cgi?id=89688 - - Reviewed by Adam Barth. - - * src/DragClientImpl.cpp: - (WebKit::DragClientImpl::startDrag): - * tests/DragImageTest.cpp: - (WebCore::TEST): - -2012-07-18 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Fix style for numeric literals in chromium unit test code - https://bugs.webkit.org/show_bug.cgi?id=91635 - - Reviewed by Adrienne Walker. - - Where possible, removed ".0" and "f" suffixes on numeric literals, - to be more consistent with WebKit style rules. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCLayerQuadTest.cpp: - (WebCore::TEST): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/LayerChromiumTest.cpp: - * tests/WebTransformationMatrixTest.cpp: - (WebKit::TEST): - -2012-07-17 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Remove awkward anchorPoint usage that implicity affects layer position - https://bugs.webkit.org/show_bug.cgi?id=91472 - - Reviewed by Adrienne Walker. - - Unit tests were updated to account for the fact that anchorPoint - and position are now separated. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-07-18 Yoshifumi Inoue <yosin@chromium.org> - - Decimal::toString should not round integer value. - https://bugs.webkit.org/show_bug.cgi?id=91481 - - Reviewed by Kent Tamura. - - This patch adds a new test cases for Decimal::toString() for failed - value and maximum coefficient value with various exponent. - - * tests/DecimalTest.cpp: - (TEST_F): DecimalTest.toString: Add test cases for big coefficient values. - -2012-07-18 Hans Wennborg <hans@chromium.org> - - Add copy constructor to WebSpeechGrammar.h - https://bugs.webkit.org/show_bug.cgi?id=91484 - - Reviewed by Adam Barth. - - Provide user-defined copy constructor (and assign function) for WebSpeechGrammar. - Without this, we were hitting the implicit copy constructor, which in - turn used the implicit copy constructor of WebPrivatePtr. This was bad, - because the implicit copy constructor wouldn't increace the reference - count on the wrapped object, causing us to crash. - - Also add one for WebSpeechRecognitionResult; haven't seen any problems - here, but I noticed it was missing. - - * public/WebSpeechGrammar.h: - (WebKit::WebSpeechGrammar::WebSpeechGrammar): - (WebSpeechGrammar): - * public/WebSpeechRecognitionResult.h: - (WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult): - (WebSpeechRecognitionResult): - * src/WebSpeechGrammar.cpp: - (WebKit::WebSpeechGrammar::assign): - (WebKit): - -2012-07-17 Yoshifumi Inoue <yosin@chromium.org> - - Decimal constructor with 99999999999999999 loses last digit - https://bugs.webkit.org/show_bug.cgi?id=91579 - - Reviewed by Kent Tamura. - - This patch adds test cases for Decimal::EncodedData constructors for - testing edge cases in addition to common cases which they aren't - covered by other test cases. - - * tests/DecimalTest.cpp: - (EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of - writing test cases for verifying components of Decimal::EncodedData. - (TEST_F): Added a new test entry DecimalTest.Constructor. - -2012-07-17 Yoshifumi Inoue <yosin@chromium.org> - - Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case - https://bugs.webkit.org/show_bug.cgi?id=91572 - - Reviewed by Kent Tamura. - - This patch introduces EXPECT_DECIMAL_STREQ macro to replace EXPECT_EQ - with String class for displaying text string rather than object dump - for ease of debugging test cases. - - * tests/DecimalTest.cpp: - (DecimalTest::stepDown): Changed to return Decimal instead of String - to use EXPECT_DECIMAL_STREQ. - (DecimalTest::stepUp): ditto. - (TEST_F): Replaced EXPECT_EQ + String class to EXPECT_DECIMAL_STREQ. - -2012-07-17 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Key generator state not maintained across connections - https://bugs.webkit.org/show_bug.cgi?id=91456 - - Reviewed by Tony Chang. - - Add stub method implementations to test class. - - * tests/IDBFakeBackingStore.h: - -2012-07-17 Tony Chang <tony@chromium.org> - - Unreviewed, rolling out r122884. - http://trac.webkit.org/changeset/122884 - https://bugs.webkit.org/show_bug.cgi?id=91408 - - Broke the chromium-win build. - - * public/WebIDBMetadata.h: - (WebIDBMetadata): - (WebKit::WebIDBMetadata::WebIDBMetadata): - -2012-07-17 David Grogan <dgrogan@chromium.org> - - IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h - https://bugs.webkit.org/show_bug.cgi?id=91408 - - Reviewed by Adam Barth. - - This is in support of the new upgradeneeded versioning api. - intVersion will eventually replace the WebString version member. - - * public/WebIDBMetadata.h: - (WebIDBMetadata): The spec uses unsigned long long for version - numbers but we use int64_t here so that we can use -1 as a sentinel. - It indicates that a database still uses a string version. - -2012-07-17 Tony Chang <tony@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-17 Vivek Galatage <vivekgalatage@gmail.com> - - Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel. - https://bugs.webkit.org/show_bug.cgi?id=91196 - - Reviewed by Pavel Feldman. - - Refactoring InspectorClients. InspectorClient::openInspectorFrontend - now returning the InspectorFrontendChannel. - - * src/InspectorClientImpl.cpp: - (WebKit::InspectorClientImpl::openInspectorFrontend): - * src/InspectorClientImpl.h: - (InspectorClientImpl): - * src/WebDevToolsAgentImpl.cpp: - (WebKit::WebDevToolsAgentImpl::reattach): - (WebKit::WebDevToolsAgentImpl::openInspectorFrontend): - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - -2012-07-16 Adam Barth <abarth@webkit.org> - - Unreviewed. Remove two empty directories. - - * public/linuxish: Removed. - * src/linuxish: Removed. - -2012-07-16 Gyuyoung Kim <gyuyoung.kim@samsung.com> - - Add RegisterProtocolHandlerClient to the Modules/protocolhandler - https://bugs.webkit.org/show_bug.cgi?id=90940 - - Reviewed by Hajime Morita. - - As a step to let protocol handler be moved to the modules, RegisterProtocolHandlerClient needs - to be added to the Modules/protocolhandler. Because ChromeClient has some virtual functions for - protocol handlers, virtual functions should be moved to RegisterProtocolHandlerClient. - - In order to support this, RegisterProtocolHandlerClientImpl class is added to ChromeClientImpl files. - - In addition, existing functions related to protocol handler in ChromeClientImpl class are moved to - RegisterProtocolHandlerClientImpl class. - - * WebKit.gyp: - * src/ChromeClientImpl.cpp: Implement RegisterProtocolHandlerClientImpl class. - (WebKit): - (WebKit::RegisterProtocolHandlerClientImpl::create): - (WebKit::RegisterProtocolHandlerClientImpl::RegisterProtocolHandlerClientImpl): - (WebKit::RegisterProtocolHandlerClientImpl::registerProtocolHandler): - * src/ChromeClientImpl.h: - (ChromeClientImpl): - (RegisterProtocolHandlerClientImpl): - (WebKit::RegisterProtocolHandlerClientImpl::~RegisterProtocolHandlerClientImpl): - (WebKit): - * src/WebViewImpl.cpp: Register RegisterProtocolHandlerClientImpl in order to support supplement. - (WebKit::WebViewImpl::WebViewImpl): - * src/WebViewImpl.h: - -2012-07-16 Yoshifumi Inoue <yosin@chromium.org> - - REGRESSION(r122552): DecimalTest tests (CeilingSmallExponent and FloorSmallExponent) started failing. - https://bugs.webkit.org/show_bug.cgi?id=91244 - - Reviewed by Kent Tamura. - - This patch enables and updates disabled test cases of DecimalTest - caused by fixes in r122552 of Decimal::ceiling() and Decimal::floor() - for small fraction numbers and added test cases. Fixes in r122552 - itself is correct however, it didn't update existing tests for very small - fraction numbers. - - * tests/DecimalTest.cpp: - (TEST_F): CeilingSmallExponent: Change expected value to 1 for ceiling(1e-1000), - ceiling rounds number toward positive infinity. - (TEST_F): FloorSmallExponent: Change expected value to -1 for floor(-1e-1000), - floor rounds number toward negative infinity. - -2012-07-16 Koji Ishii <kojiishi@gmail.com> - - Vertical alternate glyph (GSUB) support for OpenTypeVerticalData - https://bugs.webkit.org/show_bug.cgi?id=81389 - - Reviewed by Tony Chang. - - Tests for pointer validations for OpenType tables. - - * WebKit.gypi: - * tests/OpenTypeVerticalDataTest.cpp: Added. - (WebCore): - (TestTable): - (WebCore::TestTable::validateOffset): - (WebCore::TEST): - -2012-07-16 Alexandre Elias <aelias@google.com> - - [chromium] Fix WebFrameTest flakiness due to synthetic mouse events - https://bugs.webkit.org/show_bug.cgi?id=91428 - - Reviewed by Adam Barth. - - Synthetic mouse move events on scrolling can cause segfaults in - WebFrameTest due to delayed callbacks on the message loop after - state destruction. This is currently only affecting - the Android port, but has the potential to affect other platforms in the - future. - - We can avoid the issue by disabling the deviceSupportsMouse - setting, which shouldn't be needed by any WebFrameTest. - - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::createWebViewAndLoad): - -2012-07-16 Alec Flett <alecflett@chromium.org> - - IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer - https://bugs.webkit.org/show_bug.cgi?id=90923 - - Reviewed by Darin Fisher. - - Stub out implementations of putWithIndexKeys(), already implemented - on the chromium side. - - * public/WebIDBObjectStore.h: - (WebKit::WebIDBObjectStore::putWithIndexKeys): - * src/IDBObjectStoreBackendProxy.cpp: - (WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys): - (WebKit): - * src/IDBObjectStoreBackendProxy.h: - (IDBObjectStoreBackendProxy): - -2012-07-16 Adrienne Walker <enne@google.com> - - [chromium] Unify compositor quad transforms into content space - https://bugs.webkit.org/show_bug.cgi?id=91350 - - Reviewed by Kenneth Russell. - - Update tests to add bounds/contentBounds properties to layers. This - exposed a bug in the quad culler tests where the draw transform was - incorrectly being set to the origin transform rather than being a - transform that operates on centered layer rects. Fixed this bug. - - * tests/CCQuadCullerTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::createLayer): - -2012-07-16 Adrienne Walker <enne@google.com> - - [chromium] Unify compositor quad transforms into content space - https://bugs.webkit.org/show_bug.cgi?id=91350 - - Reviewed by Kenneth Russell. - - Update tests to add bounds/contentBounds properties to layers. This - exposed a bug in the quad culler tests where the draw transform was - incorrectly being set to the origin transform rather than being a - transform that operates on centered layer rects. Fixed this bug. - - * tests/CCQuadCullerTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::createLayer): - -2012-07-16 Dana Jansens <danakj@chromium.org> - - [chromium] Remove targetRenderSurface concept, give layers a renderTarget which is the layer whose coordinate space they draw into - https://bugs.webkit.org/show_bug.cgi?id=91288 - - Reviewed by Adrienne Walker. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCLayerImplTest.cpp: - (WebCore::TEST): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): - * tests/CCQuadCullerTest.cpp: - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeTiledLayerChromium::setTexturePriorities): - * tests/LayerChromiumTest.cpp: - -2012-07-16 Sami Kyostila <skyostil@chromium.org> - - [chromium] Only apply page scale delta to root scroll layer - https://bugs.webkit.org/show_bug.cgi?id=91374 - - Reviewed by Adrienne Walker. - - New unit test - CCLayerTreeHostImplTest.pageScaleDeltaAppliedToRootScrollLayerOnly to verify - the transformation of child layer while pinch zooming. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-07-16 Kihong Kwon <kihong.kwon@samsung.com> - - Remove setController from BatteryClient - https://bugs.webkit.org/show_bug.cgi?id=90944 - - Reviewed by Adam Barth. - - Remove virtual identifier from setController because setController is removed from WebCore::BatteryClient. - In addition, BatteryController is set to instance of BatteryClientImpl in the constructor of WebViewImpl. - - * src/BatteryClientImpl.h: - (BatteryClientImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - -2012-07-16 Dana Jansens <danakj@chromium.org> - - [chromium] Incorrect assertion: Replicas will cause a RenderPass to be removed twice - https://bugs.webkit.org/show_bug.cgi?id=91328 - - Reviewed by Adrienne Walker. - - Add replicas to the surfaces in the test. - - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest): - (CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): - -2012-07-13 Eric Penner <epenner@google.com> - - [chromium] Add 'self-managed' option to CCPrioritizedTexture to enable render-surface and canvas use cases. - https://bugs.webkit.org/show_bug.cgi?id=91177 - - Reviewed by Adrienne Walker. - - * tests/CCPrioritizedTextureTest.cpp: - (WTF::TEST_F): - * tests/TiledLayerChromiumTest.cpp: - -2012-07-13 Brian Anderson <brianderson@chromium.org> - - Add flushes to CCTextureUpdater::update - https://bugs.webkit.org/show_bug.cgi?id=89035 - - Reviewed by Adrienne Walker. - - CCTextureUpdaterTest added to verify texture upload/flushing patterns. - - * WebKit.gypi: - * tests/CCTextureUpdaterTest.cpp: Added. - -2012-07-13 David Grogan <dgrogan@chromium.org> - - IndexedDB: Re-enable indexeddb in test_shell - https://bugs.webkit.org/show_bug.cgi?id=91161 - - Reviewed by Tony Chang. - - IDB used to be allowed to run if webView->permissionClient() was NULL, - as is the case in test_shell. This was inadvertently changed in - http://wkb.ug/90310. - - We still don't have an automated test for this (http://crbug.com/113738) - Tested manually: - - * In test_shell: - 1) Open an IDB page - 2) Verify IDB has permission to open a DB - - * In chrome: - 1) Open an IDB page - 2) Verify IDB has permission to open a DB - 3) Revoke IDB permissions in chrome://chrome/settings/content - 4) Reload the IDB page - 5) Verify IDB doesn't have permission to open a DB - - * src/IDBFactoryBackendProxy.cpp: - (WebKit::IDBFactoryBackendProxy::allowIndexedDB): - -2012-07-13 Wei James <james.wei@intel.com> - - enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support - https://bugs.webkit.org/show_bug.cgi?id=91194 - - Reviewed by Adam Barth. - - * WebKitUnitTests.gyp: - -2012-07-13 Dana Jansens <danakj@chromium.org> - - webkit_unit_test CCLayerTreeHostImplTest.testRemoveRenderPasses started failing. - https://bugs.webkit.org/show_bug.cgi?id=91245 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-07-13 Vsevolod Vlasov <vsevik@chromium.org> - - Unreviewed gardening: skip failing webkit unit test. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-07-13 Vsevolod Vlasov <vsevik@chromium.org> - - Unreviewed gardening, skip failing webkit_unit_tests. - - * tests/DecimalTest.cpp: - (TEST_F): - -2012-07-13 Kent Tamura <tkent@chromium.org> - - Make calendar pickers testable - https://bugs.webkit.org/show_bug.cgi?id=84827 - - Reviewed by Hajime Morita. - - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::ChromeClientImpl): - Initialize m_pagePopupDriver with the WebViewImpl. - (WebKit::ChromeClientImpl::openPagePopup): - Just calls PagePoupDriver::openPagePopup(). - (WebKit::ChromeClientImpl::closePagePopup): - Just calls PagePoupDriver::closePagePopup(). - (WebKit::ChromeClientImpl::setPagePopupDriver): - * src/ChromeClientImpl.h: - (ChromeClientImpl): Add setPagePopupDriver - * src/WebViewImpl.h: - (WebViewImpl): - WebViewImpl implements PagePopupDriver. openPagePopup() and - closePagePopup() override members of PagePopupDriver. - -2012-07-13 Yoshifumi Inoue <yosin@chromium.org> - - REGRESSION(r119948): [Forms] Spin button Up/Down actions make value to zero for input type "number" when step mismatched - https://bugs.webkit.org/show_bug.cgi?id=91197 - - Reviewed by Kent Tamura. - - This patch adds test cases for Decimal::ceiling() and floor() of - positive/negative small fractional numbers. - - * tests/DecimalTest.cpp: - (TEST_F): - -2012-07-12 Adrienne Walker <enne@google.com> - - [chromium] Root invalidations for RTL pages need to be in the right space - https://bugs.webkit.org/show_bug.cgi?id=91155 - - Reviewed by Kenneth Russell. - - The root layer has a translation on it when placed in the tree, so any - invalidations on this layer likewise need to be adjusted. - - This adjustment is due to the fact that compositor layers all have the - origin in the upper left corner of the layer, but this is not always - the origin for graphics layers. Rather than making compositor layers - have to deal with a potential offset, we change the transform when - inserting the layer into the tree. Invalidations need to be similarly - transformed from document space into compositor layer space. - - The need for this offset is due to the definition of the initial - containing block. RTL pages (pages with dir=RTL on the body) start - scrolled all the way to the right, and the origin is in the upper left - hand corner of this initial viewport. Thus on RTL pages with - horizontal overflow, the left of the document is in negative CSS - space. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::invalidateRect): - -2012-07-12 Dana Jansens <danakj@chromium.org> - - [chromium] Remove the RenderPass pointer from RenderPassDrawQuad - https://bugs.webkit.org/show_bug.cgi?id=91023 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-07-12 Adam Barth <abarth@webkit.org> - - [Chromium] WebSettings should be sorted - https://bugs.webkit.org/show_bug.cgi?id=91157 - - Reviewed by Eric Seidel. - - This might be my OCD, but IMHO this file would be cleaner if we listed - the settings in alphabetic order. - - * public/WebSettings.h: - * src/WebSettingsImpl.h: - (WebSettingsImpl): - (WebKit::WebSettingsImpl::forceSoftwareCompositing): - (WebKit::WebSettingsImpl::viewportEnabled): - (WebKit::WebSettingsImpl::maxUntiledLayerSize): - -2012-07-12 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Enable IDBFactory.deleteDatabase() and webkitGetDatabaseNames() in Workers - https://bugs.webkit.org/show_bug.cgi?id=90310 - - Reviewed by Tony Chang. - - * src/IDBFactoryBackendProxy.cpp: - (WebKit::IDBFactoryBackendProxy::allowIndexedDB): Consolidates user-prompting logic. - (WebKit::getWebFrame): Helper to dig out frame from Document, or null for Worker. - (WebKit::IDBFactoryBackendProxy::getDatabaseNames): - (WebKit): - (WebKit::IDBFactoryBackendProxy::open): - (WebKit::IDBFactoryBackendProxy::deleteDatabase): - * src/IDBFactoryBackendProxy.h: Update method signatures to match interface. - (WebCore): - (IDBFactoryBackendProxy): - -2012-07-12 Dana Jansens <danakj@chromium.org> - - [chromium] The root layer should not try create a second RenderSurface for itself - https://bugs.webkit.org/show_bug.cgi?id=91124 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-07-12 Eric Penner <epenner@google.com> - - [chromium] Use CCTexture/TextureAllocator and remove TextureManager - https://bugs.webkit.org/show_bug.cgi?id=91001 - - Reviewed by Adrienne Walker. - - Deleting old texture manager tests. - - * WebKit.gypi: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCPrioritizedTextureTest.cpp: - (WTF::CCPrioritizedTextureTest::texturesMemorySize): - * tests/CCThreadedTest.cpp: - * tests/CCTiledLayerTestCommon.h: - * tests/Canvas2DLayerBridgeTest.cpp: - * tests/TextureManagerTest.cpp: Removed. - -2012-07-12 Robert Sesek <rsesek@chromium.org> - - [chromium][Mac] r122400 broke 10.6 build - https://bugs.webkit.org/show_bug.cgi?id=91103 - - Reviewed by Tony Chang. - - Use the right availability macros for forward-declaring methods and - defining constants. - - * src/mac/WebInputEventFactory.mm: - -2012-07-12 Tony Chang <tony@chromium.org> - - [chromium] Remove drag and drop API methods that are no longer used - https://bugs.webkit.org/show_bug.cgi?id=90996 - - Reviewed by Adam Barth. - - In r117327, we added a parameter for modifier keys to these methods. - Chromium has since switched to using the methods that require the - extra parameter so we can remove these methods. - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::dragTargetDragEnter): - (WebKit::WebViewImpl::dragTargetDragOver): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-12 Tony Chang <tony@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-12 Adam Barth <abarth@webkit.org> - - [Chromium] Delete last mention of Hixie76 in WebKit/chromium - https://bugs.webkit.org/show_bug.cgi?id=91099 - - Reviewed by Tony Chang. - - This deprecated API is no longer used anywhere. - - * public/WebSettings.h: - (WebKit::WebSettings::setDefaultDeviceScaleFactor): - -2012-07-12 Tony Chang <tony@chromium.org> - - Unreviewed, rolling out r122477. - http://trac.webkit.org/changeset/122477 - https://bugs.webkit.org/show_bug.cgi?id=91103 - - Broke Chromium Mac build - - * src/mac/WebInputEventFactory.mm: - -2012-07-12 Robert Sesek <rsesek@chromium.org> - - [chromium][Mac] r122400 broke 10.6 build - https://bugs.webkit.org/show_bug.cgi?id=91103 - - Reviewed by Tony Chang. - - Use the right availability macros for forward-declaring methods and - defining constants. - - * src/mac/WebInputEventFactory.mm: - -2012-07-12 Peter Beverloo <peter@chromium.org> - - [Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=90989 - - Reviewed by Adam Barth. - - Add dependencies on the webkit_unit_tests_apk and TestWebKitAPI_apk - targets for Android, making sure that we're generating the packages. - - * All.gyp: - -2012-07-12 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Remove unrequired API in WebSurroundingText. - https://bugs.webkit.org/show_bug.cgi?id=91067 - - Reviewed by Adam Barth. - - Remove the unused first initialize method from WebSurroundingText. - Now both Chromium and LayoutTestController use the second method. - - * public/WebSurroundingText.h: - (WebSurroundingText): - * src/WebSurroundingText.cpp: - -2012-07-11 Mark Rowe <mrowe@apple.com> - - <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros - - This removal was handled by a script that translates the relevant macros in to the equivalent checks - using the system availability macros. - - Reviewed by Filip Pizlo. - - * src/mac/WebInputEventFactory.mm: - -2012-07-11 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-11 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r122358. - http://trac.webkit.org/changeset/122358 - https://bugs.webkit.org/show_bug.cgi?id=91037 - - Build break on WebKit Win (Requested by hayato on #webkit). - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::dragTargetDragEnter): - (WebKit): - (WebKit::WebViewImpl::dragTargetDragOver): - (WebKit::WebViewImpl::dragTargetDrop): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-11 Alexandre Elias <aelias@google.com> - - [chromium] Move compositor quads to Platform/chromium/public - https://bugs.webkit.org/show_bug.cgi?id=90582 - - Reviewed by Adrienne Walker. - - This moves CCSharedQuadState, CCDrawQuad, and all but two CC*DrawQuad - classes to the WebKit namespace, as a first step to pushing them - across the process boundary for the ubercompositor. - - - The intent is to serialize the class hierarchy using the same - mechanism as WebInputEvent. In order to do this, there are three - requirements: pure POD data, a method returning size, and a packing - pragma. - - - Private data members are fine with this kind of serializer, and a - default constructor is not needed. Because of that, we can maintain - the same encapsulation and convenient APIs (behind - WEBKIT_IMPLEMENTATION) as the original classes. To ease the - transition, the original WebCore headers still exist and typedef to - the new classes. - - - However, SharedQuadState will be serialized using the normal - IPC_STRUCT_TRAITS macro, so I made its members public. A custom - serializer (on quad lists) will maintain the pointers from quads to - SharedQuadStates. - - - I converted the Material casting mechanism to materialCast() methods - living in the derived classes. That way, the WebCompositorQuad header - doesn't need to know about all its derived classes. - - - Quad classes not yet transitioned can still be used in - non-ubercompositor mode. CCRenderPassDrawQuad and CCYUVVideoDrawQuad - are currently non-POD and I left them in their original files. - - This approach is the best I've found so far, since it preserves all - WebCore-facing APIs and avoids unnecessary code duplication (new quad - types or members can be added by modifying only one place). There - also should not be an unreasonable amount of custom serializer code - required. - - * tests/CCLayerTestCommon.cpp: - (CCLayerTestCommon::verifyQuadsExactlyCoverRect): - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - -2012-07-11 Dana Jansens <danakj@chromium.org> - - [chromium] Rename layerRect to contentRect for rects that live in content space - https://bugs.webkit.org/show_bug.cgi?id=90843 - - Reviewed by Adrienne Walker. - - * tests/CCLayerImplTest.cpp: - (WebCore::TEST): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): - * tests/CCQuadCullerTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/CCTiledLayerImplTest.cpp: - (CCLayerTestCommon::createLayer): - (CCLayerTestCommon::TEST): - (CCLayerTestCommon::getQuads): - (CCLayerTestCommon::coverageVisibleRectIntersectsTiles): - (CCLayerTestCommon::coverageVisibleRectIntersectsBounds): - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::prepareToUpdate): - (WebKitTests::FakeTiledLayerChromium::update): - * tests/CCTiledLayerTestCommon.h: - (FakeTiledLayerChromium): - * tests/LayerChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-07-11 Dana Jansens <danakj@chromium.org> - - [chromium] Minimum size used for occlusion tracking should be a setting on CCLayerTreeHost - https://bugs.webkit.org/show_bug.cgi?id=90993 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-07-11 Adam Barth <abarth@webkit.org> - - [Chromium] Enable LEGACY_VIEWPORT_ADAPTION - https://bugs.webkit.org/show_bug.cgi?id=90991 - - Reviewed by Tony Chang. - - Chromium wishes to support LEGACY_VIEWPORT_ADAPTION. I actually thought - this was enabled before, but the enable bit got lost in the shuffle. - - * features.gypi: - -2012-07-11 Tony Chang <tony@chromium.org> - - [chromium] Remove drag and drop API methods that are no longer used - https://bugs.webkit.org/show_bug.cgi?id=90996 - - Reviewed by Adam Barth. - - In r117327, we added a parameter for modifier keys to these methods. - Chromium has since switched to using the methods that require the - extra parameter so we can remove these methods. - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::dragTargetDragEnter): - (WebKit::WebViewImpl::dragTargetDragOver): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-07-11 Shawn Singh <shawnsingh@chromium.org> - - Unreviewed build fix, forgot to add URLTestHelpers.* when landing r122344 - - * tests/URLTestHelpers.cpp: Added. - (URLTestHelpers): - (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): - (WebKit::URLTestHelpers::registerMockedURLLoad): - * tests/URLTestHelpers.h: Added. - (WebKit): - (URLTestHelpers): - (WebKit::URLTestHelpers::toKURL): - -2012-07-11 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=90094 - - Reviewed by Adrienne Walker. - - This patch adds the WEBKIT_IMPLEMENTATION = 1 define to - WebKitUnitTests.gyp. To get it to compile correctly, some string - and URL code was refactored and fixed, in particular GURL usage is - replaced with KURL usage. - - * WebKit.gyp: - added WEBKIT_IMPLEMENTATION == 1 for unit test code when in shared library - added URLTestHelpers to exclusion in shared library build, because it depends on webkit_support - - * WebKit.gypi: - added URLTestHelpers.h and .cpp to the build process - - * WebKitUnitTests.gyp: - added WEBKIT_IMPLEMENTATION == 1 for unit test code when not in shared library. - note that in shared library build, RunAllTests.cpp does not have WEBKIT_IMPLEMENTATION == 1. - - * public/WebDOMMessageEvent.h: - (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): - * tests/AssociatedURLLoaderTest.cpp: - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::loadFrame): - * tests/FrameTestHelpers.h: - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/PopupMenuTest.cpp: - * tests/RunAllTests.cpp: - * tests/URLTestHelpers.cpp: Added. - (URLTestHelpers): - (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): - (WebKit::URLTestHelpers::registerMockedURLLoad): - * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. - (WebKit): - (URLTestHelpers): - (WebKit::URLTestHelpers::toKURL): - * tests/WebFrameTest.cpp: - * tests/WebPageNewSerializerTest.cpp: - * tests/WebPageSerializerTest.cpp: - * tests/WebViewTest.cpp: - -2012-07-10 Pavel Feldman <pfeldman@chromium.org> - - Web Inspector: migrate from background images to CSS for statusbar rendering. - https://bugs.webkit.org/show_bug.cgi?id=90902 - - Reviewed by Vsevolod Vlasov. - - * WebKit.gypi: - * src/js/Images/statusbarBackgroundChromium.png: Removed. - * src/js/Images/statusbarBottomBackgroundChromium.png: Removed. - * src/js/Images/statusbarButtonsChromium.png: Removed. - * src/js/Images/statusbarMenuButtonChromium.png: Removed. - * src/js/Images/statusbarMenuButtonSelectedChromium.png: Removed. - * src/js/devTools.css: - (.status-bar-background): - -2012-07-11 Kenichi Ishibashi <bashi@chromium.org> - - [Chromium] Adding HarfBuzz-ng for Linux - https://bugs.webkit.org/show_bug.cgi?id=90362 - - Reviewed by Tony Chang. - - * features.gypi: Added use_harfbuzz_ng variable. If the value is set, USE(HARFBUZZ_NG) is defined. - -2012-07-10 Hayato Ito <hayato@chromium.org> - - Unreviewed gardening. - - Android builder started to fail after r122292. - My best guess is that '--ant-compile' does not take an argument. - - * WebKitUnitTests.gyp: - -2012-07-10 Yoshifumi Inoue <yosin@chromium.org> - - [Chromium-Windows] Implement functions for localized time format information - https://bugs.webkit.org/show_bug.cgi?id=90236 - - Reviewed by Kent Tamura. - - This patch introduces test cases for date and time format related - functions in LocaleWin. - - * tests/LocaleWinTest.cpp: - (LocaleWinTest): - (LocaleWinTest::dateComponents): Added. - (LocaleWinTest::msForDate): Moved inside class LocaleWinTest. - (LocaleWinTest::formatDate): Added. - (LocaleWinTest::parseDate): Added. - (LocaleWinTest::dateFormatText): Added. - (LocaleWinTest::firstDayOfWeek): Added. - (LocaleWinTest::monthLabel): Added. - (LocaleWinTest::weekDayShortLabel): Added. - (LocaleWinTest::timeFormatText): Added. - (LocaleWinTest::shortTimeFormatText): Added. - (LocaleWinTest::timeAMPMLabel): Added. - (TEST_F): - -2012-07-10 Adam Barth <abarth@webkit.org> - - [Chromium-Android] Add apk test targets for webkit_unit_tests and TestWebKitAPI - https://bugs.webkit.org/show_bug.cgi?id=90918 - - Reviewed by Tony Chang. - - The rules are similar to what we have added for DumpRenderTree apk. - All references to gtest_target_type can be removed once we enable APK - tests on the all bots. - - * WebKitUnitTests.gyp: - -2012-07-10 Kevin Ellis <kevers@chromium.org> - - Input elements with type=range do not have default touch handlers. - https://bugs.webkit.org/show_bug.cgi?id=88807 - - Reviewed by Antonio Gomes. - - Adds flag to enable native handling of touch events for input elements - with type=range. - - * features.gypi: - -2012-07-10 Adam Klein <adamk@chromium.org> - - [Chromium] REGRESSION(r121909): m_currentInputEvent never set - https://bugs.webkit.org/show_bug.cgi?id=90914 - - Reviewed by Abhishek Arya. - - The always-null m_currentInputEvent causes a regression when - middle-clicking on a link that calls window.open('...', '_blank'); - that new tab should open in the background, but instead opens in the - foreground (see code in ChromeClientImpl::getNavigationPolicy()). - - Fix usage of TemporaryChange to specify a local variable name so that - m_currentInputEvent is actually set for the duration of handleInputEvent. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleInputEvent): Name the TemporaryChange instance. - -2012-07-10 Adam Barth <abarth@webkit.org> - - WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed - https://bugs.webkit.org/show_bug.cgi?id=90910 - - Reviewed by Eric Seidel. - - * public/WebSettings.h: - (WebKit::WebSettings::setHixie76WebSocketProtocolEnabled): - * src/WebSettingsImpl.cpp: - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebSharedWorkerImpl.cpp: - (WebKit::WebSharedWorkerImpl::initializeLoader): - -2012-07-09 Dana Jansens <danakj@chromium.org> - - [chromium] Replace use of ManagedTexture with CCScopedTexture for impl thread and remove implTextureManager from LayerRendererChromium - https://bugs.webkit.org/show_bug.cgi?id=90841 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-07-10 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium-Android] Use default font rendering styles in FontPlatformData::querySystemForRenderStyle() - https://bugs.webkit.org/show_bug.cgi?id=90826 - - Reviewed by Adam Barth. - - * WebKit.gyp: - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::getRenderStyleForStrike): Call style.setDefault() on Android or when the font is not specified. - -2012-07-10 Dana Jansens <danakj@chromium.org> - - [chromium] Avoid allocating render pass textures that have no content - https://bugs.webkit.org/show_bug.cgi?id=90702 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking): - (CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::beginTest): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::didCommit): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread): - (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::afterTest): - (WTF): - -2012-07-10 Leandro Gracia Gil <leandrogracia@chromium.org> - - Unreviewed Chromium build fix for mac-release. - - Fixing clang build after https://bugs.webkit.org/show_bug.cgi?id=90807 - - * public/WebSurroundingText.h: - (WebKit): - -2012-07-10 Leandro Gracia Gil <leandrogracia@chromium.org> - - WebSurroundingText layout tests should use the same code path as the rest of the feature. - https://bugs.webkit.org/show_bug.cgi?id=90807 - - Reviewed by Adam Barth. - - Replace the offset-based initialize method used only by LayoutTestController - with a point-based version to follow the same code path. - - * public/WebSurroundingText.h: - (WebKit): - (WebSurroundingText): - * src/WebSurroundingText.cpp: - (WebKit::WebSurroundingText::initialize): - -2012-07-10 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r122207. - http://trac.webkit.org/changeset/122207 - https://bugs.webkit.org/show_bug.cgi?id=90874 - - Broke the cr-windows bot (Requested by beverloo on #webkit). - - * DEPS: - -2012-07-10 Jochen Eisinger <jochen@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-09 Matt Falkenhagen <falken@chromium.org> - - Add ENABLE_DIALOG_ELEMENT and skeleton files - https://bugs.webkit.org/show_bug.cgi?id=90521 - - Reviewed by Kent Tamura. - - * features.gypi: - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enableDialogElement): - (WebKit): - (WebKit::WebRuntimeFeatures::isDialogElementEnabled): - -2012-07-09 Yoshifumi Inoue <yosin@chromium.org> - - [Chromium-Mac] Implement functions for localized time format information - https://bugs.webkit.org/show_bug.cgi?id=90237 - - Reviewed by Kent Tamura. - - * tests/LocaleMacTest.cpp: - (LocaleMacTest): - (LocaleMacTest::timeFormatText): - (LocaleMacTest::shortTimeFormatText): - (LocaleMacTest::timeAMPMLabel): - (TEST_F): - -2012-07-09 Eric Penner <epenner@google.com> - - [chromium] Merge updates and idle updates into one pass - https://bugs.webkit.org/show_bug.cgi?id=90324 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostTest.cpp: - (WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount): - (WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking): - (ContentLayerChromiumWithUpdateTracking): - (WTF::CCLayerTreeHostTestOpacityChange::afterTest): - * tests/CCTiledLayerTestCommon.h: - (FakeTiledLayerChromium): - * tests/TiledLayerChromiumTest.cpp: - -2012-07-09 Yoshifumi Inoue <yosin@chromium.org> - - [Platform] Introduce LocaleMac class - https://bugs.webkit.org/show_bug.cgi?id=90248 - - Reviewed by Kent Tamura. - - This patch added tests for LocaleMac class. - - * WebKit.gypi: - * tests/LocaleMacTest.cpp: Added. - (LocaleMacTest): - (LocaleMacTest::dateComponents): - (LocaleMacTest::msForDate): - (LocaleMacTest::formatDate): - (LocaleMacTest::parseDate): - (LocaleMacTest::dateFormatText): - (LocaleMacTest::firstDayOfWeek): - (LocaleMacTest::monthLabel): - (LocaleMacTest::weekDayShortLabel): - (TEST_F): - -2012-07-09 Dana Jansens <danakj@chromium.org> - - [chromium] Create CCScopedTexture class for creating/freeing textures - https://bugs.webkit.org/show_bug.cgi?id=89485 - - Reviewed by Adrienne Walker. - - * WebKit.gypi: - * tests/CCScopedTextureTest.cpp: Added. - (WebKitTests): - (WebKitTests::TEST): - (TrackingTextureAllocator): - (WebKitTests::TrackingTextureAllocator::TrackingTextureAllocator): - (WebKitTests::TrackingTextureAllocator::numTextures): - -2012-07-09 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Remove obsolete accessor plumbing - https://bugs.webkit.org/show_bug.cgi?id=90812 - - Reviewed by Tony Chang. - - * public/WebIDBCursor.h: Remove direction. - * public/WebIDBDatabase.h: Remove name, version, objectStoreNames; - (WebKit::WebIDBDatabase::metadata): - * public/WebIDBIndex.h: Remove name, keyPath, unique, multiEntry; - * public/WebIDBObjectStore.h: Remove name, keyPath, indexNames, autoIncrement; - * src/IDBDatabaseBackendProxy.cpp: Remove plumbing. - * src/IDBDatabaseBackendProxy.h: Remove plumbing. - (IDBDatabaseBackendProxy): - * src/IDBIndexBackendProxy.cpp: Remove plumbing. - * src/IDBIndexBackendProxy.h: Remove plumbing. - (IDBIndexBackendProxy): - * src/IDBObjectStoreBackendProxy.cpp: Remove plumbing. - * src/IDBObjectStoreBackendProxy.h: Remove plumbing. - (IDBObjectStoreBackendProxy): - * src/IDBTransactionBackendProxy.cpp: Remove plumbing. - * src/IDBTransactionBackendProxy.h: Assert stub is not used - only needed - by real IDBTransactionBackendImpl - (WebKit::IDBTransactionBackendProxy::mode): - * src/WebIDBTransactionImpl.cpp: Remove plumbing. - * src/WebIDBTransactionImpl.h: Remove plumbing. - -2012-07-09 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r122161. - http://trac.webkit.org/changeset/122161 - https://bugs.webkit.org/show_bug.cgi?id=90837 - - failed to compile on chromium webkit linux bot (Requested by - shawnsingh on #webkit). - - * WebKit.gypi: - * WebKitUnitTests.gyp: - * public/WebDOMMessageEvent.h: - * tests/AssociatedURLLoaderTest.cpp: - (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): - (WebKit::AssociatedURLLoaderTest::SetUp): - (WebKit::AssociatedURLLoaderTest::CheckMethodFails): - (WebKit::AssociatedURLLoaderTest::CheckHeaderFails): - (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders): - (WebKit::TEST_F): - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::registerMockedURLLoad): - (FrameTestHelpers): - (WebKit::FrameTestHelpers::loadFrame): - * tests/FrameTestHelpers.h: - (FrameTestHelpers): - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/PopupMenuTest.cpp: - (WebKit::SelectPopupMenuTest::registerMockedURLLoad): - (WebKit::SelectPopupMenuTest::loadFrame): - (WebKit::TEST_F): - * tests/RunAllTests.cpp: - * tests/URLTestHelpers.cpp: Removed. - * tests/URLTestHelpers.h: Removed. - * tests/WebFrameTest.cpp: - (WebKit::WebFrameTest::registerMockedHttpURLLoad): - (WebKit::WebFrameTest::registerMockedChromeURLLoad): - (WebKit::TEST_F): - * tests/WebPageNewSerializerTest.cpp: - (WebKit::WebPageNewSerializeTest::registerMockedURLLoad): - (WebPageNewSerializeTest): - (WebKit::WebPageNewSerializeTest::setUpCSSTestPage): - (WebKit::WebPageNewSerializeTest::loadURLInTopFrame): - (WebKit::WebPageNewSerializeTest::resourceVectorContains): - (WebKit::TEST_F): - * tests/WebPageSerializerTest.cpp: - (WebKit::WebPageSerializerTest::registerMockedURLLoad): - (WebKit::WebPageSerializerTest::loadURLInTopFrame): - (WebKit::WebPageSerializerTest::webVectorContains): - (WebKit::TEST_F): - * tests/WebViewTest.cpp: - (WebKit::TEST_F): - (WebKit::WebViewTest::testAutoResize): - (WebKit::WebViewTest::testTextInputType): - -2012-07-09 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=90094 - - Reviewed by Adam Barth. - - This patch adds the WEBKIT_IMPLEMENTATION = 1 define to - WebKitUnitTests.gyp. To get it to compile correctly, some string - and URL code was refactored, and GURL types were replaced with KURL types. - - * WebKit.gypi: - * WebKitUnitTests.gyp: - * public/WebDOMMessageEvent.h: - (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): - * tests/AssociatedURLLoaderTest.cpp: - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::loadFrame): - * tests/FrameTestHelpers.h: - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/PopupMenuTest.cpp: - * tests/RunAllTests.cpp: - * tests/URLTestHelpers.cpp: Added. - (URLTestHelpers): - (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): - (WebKit::URLTestHelpers::registerMockedURLLoad): - * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. - (WebKit): - (URLTestHelpers): - (WebKit::URLTestHelpers::toKURL): - * tests/WebFrameTest.cpp: - * tests/WebPageNewSerializerTest.cpp: - * tests/WebPageSerializerTest.cpp: - * tests/WebViewTest.cpp: - -2012-07-09 Dana Jansens <danakj@chromium.org> - - [chromium] Decouple RenderPass drawing from CCRenderSurface - https://bugs.webkit.org/show_bug.cgi?id=90573 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - -2012-07-09 Adam Klein <adamk@chromium.org> - - Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver - https://bugs.webkit.org/show_bug.cgi?id=90810 - - Reviewed by Ojan Vafai. - - * src/WebKit.cpp: - -2012-07-09 Leandro Gracia Gil <leandrogracia@chromium.org> - - SurroundingText should not advance character iterators if they are at end. - https://bugs.webkit.org/show_bug.cgi?id=90560 - - Reviewed by Ryosuke Niwa. - - Moving the check for null visible positions to WebCore as it makes no - sense to be in a platform-specific code. - - * src/WebSurroundingText.cpp: - (WebKit::WebSurroundingText::initialize): - -2012-07-09 Dana Jansens <danakj@chromium.org> - - [chromium] Create render surfaces on main thread only for the current frame - https://bugs.webkit.org/show_bug.cgi?id=89793 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-07-02 Ryosuke Niwa <rniwa@webkit.org> - - Make HTMLCollection RefCounted - https://bugs.webkit.org/show_bug.cgi?id=90414 - - Reviewed by Sam Weinig. - - * src/WebPageSerializer.cpp: - (WebCore::retrieveResourcesForFrame): - * src/WebPageSerializerImpl.cpp: - (WebKit::WebPageSerializerImpl::collectTargetFrames): - -2012-07-09 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r122107. - http://trac.webkit.org/changeset/122107 - https://bugs.webkit.org/show_bug.cgi?id=90794 - - Build failure on Mac debug bots (Requested by falken_ on - #webkit). - - * features.gypi: - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): - * src/WebRuntimeFeatures.cpp: - -2012-07-09 Matt Falkenhagen <falken@chromium.org> - - Add ENABLE_DIALOG_ELEMENT and skeleton files - https://bugs.webkit.org/show_bug.cgi?id=90521 - - Reviewed by Kent Tamura. - - * features.gypi: - * public/WebRuntimeFeatures.h: - (WebRuntimeFeatures): - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enableDialogElement): - (WebKit): - (WebKit::WebRuntimeFeatures::isDialogElementEnabled): - -2012-07-09 MORITA Hajime <morrita@google.com> - - [Chromium] ContextFeaturesClient::isEnabled is slow - https://bugs.webkit.org/show_bug.cgi?id=90367 - - Reviewed by Kent Tamura. - - ContextFeaturesClientImpl::isEnabled touches a heavy part in chrome - where locks are acquired for each invocation. - - This change introduces a set of caches to avoid such slow calls. - The cache class ContextFeaturesCache is implemented as a - Supplement of ScriptExecutionContext because the flag bits - depend on the domain of each Document. - - * src/ContextFeaturesClientImpl.cpp: - (ContextFeaturesCache): Added. - (Entry): Added. - (WebKit::ContextFeaturesCache::Entry::Entry): - (WebKit::ContextFeaturesCache::Entry::isEnabled): - (WebKit::ContextFeaturesCache::Entry::set): - (WebKit::ContextFeaturesCache::Entry::needsRefresh): - (WebKit::ContextFeaturesCache::entryFor): - (WebKit): - (WebKit::ContextFeaturesCache::supplementName): - (WebKit::ContextFeaturesCache::from): - (WebKit::ContextFeaturesCache::refreshAgainst): - (WebKit::ContextFeaturesClientImpl::isEnabled): - (WebKit::ContextFeaturesClientImpl::urlDidChange): Added to invoke refrshAgainst. - (WebKit::ContextFeaturesClientImpl::askIfIsEnabled): - * src/ContextFeaturesClientImpl.h: - (ContextFeaturesClientImpl): - -2012-07-09 Vsevolod Vlasov <vsevik@chromium.org> - - Unreviewed chromium inspector test fix. - - * src/js/Tests.js: - (.TestSuite.prototype.nonAnonymousUISourceCodes_): - -2012-07-05 Yoshifumi Inoue <yosin@chromium.org> - - Unreviewed Chromium gardening. Roll Chromium DEPS - - * DEPS: 145501 => 145569 - -2012-07-05 Yoshifumi Inoue <yosin@chromium.org> - - Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows. - https://bugs.webkit.org/show_bug.cgi?id=90651 - - * tests/WebAnimationTest.cpp: - (WebKit): - (WebKit::TEST): - -2012-07-05 Ian Vollick <vollick@chromium.org> - - [chromium] Create a WebKit::Web* wrapper for the cc animation classes - https://bugs.webkit.org/show_bug.cgi?id=90303 - - Reviewed by James Robinson. - - * WebKit.gyp: - * WebKit.gypi: - * src/WebAnimation.cpp: Added. - (WebKit): - (WebKit::WebAnimation::iterations): - (WebKit::WebAnimation::setIterations): - (WebKit::WebAnimation::startTime): - (WebKit::WebAnimation::setStartTime): - (WebKit::WebAnimation::timeOffset): - (WebKit::WebAnimation::setTimeOffset): - (WebKit::WebAnimation::alternatesDirection): - (WebKit::WebAnimation::setAlternatesDirection): - (WebKit::WebAnimation::toCCActiveAnimation): - (WebKit::WebAnimation::initialize): - (WebKit::WebAnimation::destroy): - * src/WebAnimationCurveCommon.cpp: Added. - (WebKit): - (WebKit::createTimingFunction): - * src/WebAnimationCurveCommon.h: Added. - (WebCore): - (WebKit): - * src/WebFloatAnimationCurve.cpp: Added. - (WebKit): - (WebKit::WebFloatAnimationCurve::add): - (WebKit::WebFloatAnimationCurve::toCCAnimationCurve): - (WebKit::WebFloatAnimationCurve::initialize): - (WebKit::WebFloatAnimationCurve::destroy): - * src/WebTransformAnimationCurve.cpp: Added. - (WebKit): - (WebKit::WebTransformAnimationCurve::add): - (WebKit::WebTransformAnimationCurve::toCCAnimationCurve): - (WebKit::WebTransformAnimationCurve::initialize): - (WebKit::WebTransformAnimationCurve::destroy): - * tests/WebAnimationTest.cpp: Added. - * tests/WebFloatAnimationCurveTest.cpp: Added. - * tests/WebTransformAnimationCurveTest.cpp: Added. - -2012-07-05 Vincent Scheib <scheib@chromium.org> - - [Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent(). - https://bugs.webkit.org/show_bug.cgi?id=90391 - - WebViewImpl::handleInputEvent was keeping a pointer to an input event that would - later be accessed. When in pointer lock, that pointer was not being cleared. - Code modified to use TemporaryChange to automatically clear the pointer at all - method exit points. - - Reviewed by Abhishek Arya. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleInputEvent): - -2012-07-05 John Mellor <johnme@chromium.org> - - Text Autosizing: Add test framework and simple test. - https://bugs.webkit.org/show_bug.cgi?id=90561 - - ENABLE(TEXT_AUTOSIZING) is now on in Chromium (but disabled at runtime). - This allows it to be used in Layout Tests (and in future by Web - Inspector's mobile device emulation). - - Reviewed by Adam Barth. - - * features.gypi: - -2012-07-05 Oli Lan <olilan@chromium.org> - - [chromium] Add a method didChangeFormState to WebViewClient. - https://bugs.webkit.org/show_bug.cgi?id=90563 - - Reviewed by Adam Barth. - - This patch adds a new method didChangeFormState to WebViewClient, - and calls it from ChromeClientImpl::formStateDidChange with the changed node. - - This new method can be used for example by the Android port to update the browser's - IME when the state of the currently focused text node has changed. To facilitate this - usage, a focused() method has been added to WebNode. - - A new test has been added to WebViewTest. This test checks that didChangeFormState - is called when an input's value is changed, and also checks that WebNode::focused() returns - the correct value for the provided node, in both the focused and non-focused cases. - - * public/WebNode.h: - * public/WebViewClient.h: - (WebKit::WebViewClient::didChangeFormState): - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::formStateDidChange): - * src/WebNode.cpp: - (WebKit::WebNode::focused): - (WebKit): - * tests/WebViewTest.cpp: - (FormChangeWebViewClient): - (WebKit::FormChangeWebViewClient::didChangeFormState): - (WebKit::FormChangeWebViewClient::reset): - (WebKit::FormChangeWebViewClient::called): - (WebKit::FormChangeWebViewClient::focused): - (WebKit): - (WebKit::TEST_F): - * tests/data/input_field_set_value_while_focused.html: Added. - * tests/data/input_field_set_value_while_not_focused.html: Added. - -2012-07-04 Yoshifumi Inoue <yosin@chromium.org> - - Unreviewed, Chromium gardening. Roll Chromium DEPS. - - * DEPS: chromium_rev: 145322 => 145501 - -2012-07-04 Dana Jansens <danakj@chromium.org> - - [chromium] Respect memory needed for RenderSurfaces when reserving contents textures - https://bugs.webkit.org/show_bug.cgi?id=89901 - - Reviewed by Adrienne Walker. - - * tests/CCPrioritizedTextureTest.cpp: - (WTF::CCPrioritizedTextureTest::createManager): - (WTF::TEST_F): - (WTF): - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeTiledLayerChromium::setTexturePriorities): - (WebKitTests): - * tests/CCTiledLayerTestCommon.h: - (FakeTiledLayerChromium): - * tests/TiledLayerChromiumTest.cpp: - -2012-07-04 Dana Jansens <danakj@chromium.org> - - [chromium] Clear RenderSurfaces still when no idle paint will be done - https://bugs.webkit.org/show_bug.cgi?id=90553 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostTest.cpp: - (CCLayerTreeHostTestCompositeAndReadbackCleanup): - (WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::CCLayerTreeHostTestCompositeAndReadbackCleanup): - (WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::beginTest): - (WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::afterTest): - (WTF): - -2012-07-04 Dana Jansens <danakj@chromium.org> - - [chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests - https://bugs.webkit.org/show_bug.cgi?id=90556 - - Reviewed by Adrienne Walker. - - Currently many tests that run both single and threaded versions subclass - from CCLayerTreeHostTestThreadOnly just from copy/pasting. The class - only adds a runTestThreaded() which calls runTest(true). Many other - tests do run only in threaded mode call runTest(true) themselves, making - for an inconsistent mess. - - We remove CCLayerTreeHostTestThreadOnly class, so we don't have tests - inheriting it that are not thread-only. And now all tests that are - thread-only call runTest(true) consistently. - - * tests/CCLayerTreeHostTest.cpp: - (WTF::TEST_F): - -2012-07-04 John Mellor <johnme@chromium.org> - - Text Autosizing: Add compile flag and runtime setting - https://bugs.webkit.org/show_bug.cgi?id=87394 - - This patch renames Font Boosting to Text Autosizing and adds compile guards around the runtime setting. - - Reviewed by Adam Barth. - - * features.gypi: - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setTextAutosizingEnabled): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-07-04 Ian Vollick <vollick@chromium.org> - - [chromium] Correctly reject accelerated animations with certain rotations. - https://bugs.webkit.org/show_bug.cgi?id=89768 - - Reviewed by James Robinson. - - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::TEST_F): - (WebKitTests): - -2012-07-03 Alex Sakhartchouk <alexst@chromium.org> - - [chromium] Avoid calling getUniformLocation??() in the compositor startup - https://bugs.webkit.org/show_bug.cgi?id=90217 - - Reviewed by Adrienne Walker. - - Fixing the build error. - - * tests/TextureCopierTest.cpp: - -2012-07-03 Erik Arvidsson <arv@chromium.org> - - [V8] Remove enableFasterDOMStoreAccess which is never used - https://bugs.webkit.org/show_bug.cgi?id=90489 - - Reviewed by Adam Barth. - - * src/WebScriptController.cpp: - (WebKit::WebScriptController::enableV8SingleThreadMode): - -2012-07-03 Tony Chang <tony@chromium.org> - - [chromium] Unreviewed, update .gitignore to handle VS2010 files. - - * .gitignore: - -2012-07-03 Tony Chang <tony@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-03 Charles Wei <charles.wei@torchmobile.com.cn> - - IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath - https://bugs.webkit.org/show_bug.cgi?id=88338 - - Reviewed by David Levin. - - * src/WebSharedWorkerImpl.cpp: - (WebKit::WebSharedWorkerImpl::startWorkerContext): - * src/WebWorkerClientImpl.cpp: - (WebKit::WebWorkerClientImpl::startWorkerContext): - -2012-07-02 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-07-02 Leandro Gracia Gil <leandrogracia@chromium.org> - - [Chromium] Implement a Layout Test for editing/SurroundingText - https://bugs.webkit.org/show_bug.cgi?id=82461 - - Reviewed by Ryosuke Niwa. - - Allow passing nodes as arguments for layout test methods. - - * public/WebBindings.h: - (WebBindings): - * src/WebBindings.cpp: - (WebKit::getNodeImpl): - (WebKit): - (WebKit::WebBindings::getNode): - -2012-07-02 Benjamin Poulain <bpoulain@apple.com> - - Do not do any logging initialization when logging is disabled - https://bugs.webkit.org/show_bug.cgi?id=90228 - - Reviewed by Simon Fraser. - - * src/WebKit.cpp: - (WebKit::enableLogChannel): - -2012-07-01 Keishi Hattori <keishi@webkit.org> - - Unreviewed, rolling out r121650. - http://trac.webkit.org/changeset/121650 - https://bugs.webkit.org/show_bug.cgi?id=90303 - - runhooks is failing for chromium win bots and - WebAnimationTest.DefaultSettings is crashing - - * WebKit.gyp: - * WebKit.gypi: - * src/WebAnimation.cpp: Removed. - * src/WebAnimationCurveCommon.cpp: Removed. - * src/WebAnimationCurveCommon.h: Removed. - * src/WebFloatAnimationCurve.cpp: Removed. - * src/WebTransformAnimationCurve.cpp: Removed. - * tests/WebAnimationTest.cpp: Removed. - * tests/WebFloatAnimationCurveTest.cpp: Removed. - * tests/WebTransformAnimationCurveTest.cpp: Removed. - -2012-07-01 Ian Vollick <vollick@chromium.org> - - [chromium] Create a WebKit::Web* wrapper for the cc animation classes - https://bugs.webkit.org/show_bug.cgi?id=90303 - - Reviewed by James Robinson. - - * WebKit.gyp: - * WebKit.gypi: - * src/WebAnimation.cpp: Added. - (WebKit): - (WebKit::WebAnimation::iterations): - (WebKit::WebAnimation::setIterations): - (WebKit::WebAnimation::startTime): - (WebKit::WebAnimation::setStartTime): - (WebKit::WebAnimation::timeOffset): - (WebKit::WebAnimation::setTimeOffset): - (WebKit::WebAnimation::alternatesDirection): - (WebKit::WebAnimation::setAlternatesDirection): - (WebKit::WebAnimation::toCCActiveAnimation): - (WebKit::WebAnimation::initialize): - (WebKit::WebAnimation::destroy): - * src/WebAnimationCurveCommon.cpp: Added. - (WebKit): - (WebKit::createTimingFunction): - * src/WebAnimationCurveCommon.h: Added. - (WebCore): - (WebKit): - * src/WebFloatAnimationCurve.cpp: Added. - (WebKit): - (WebKit::WebFloatAnimationCurve::add): - (WebKit::WebFloatAnimationCurve::toCCAnimationCurve): - (WebKit::WebFloatAnimationCurve::initialize): - (WebKit::WebFloatAnimationCurve::destroy): - * src/WebTransformAnimationCurve.cpp: Added. - (WebKit): - (WebKit::WebTransformAnimationCurve::add): - (WebKit::WebTransformAnimationCurve::toCCAnimationCurve): - (WebKit::WebTransformAnimationCurve::initialize): - (WebKit::WebTransformAnimationCurve::destroy): - * tests/WebAnimationTest.cpp: Added. - * tests/WebFloatAnimationCurveTest.cpp: Added. - * tests/WebTransformAnimationCurveTest.cpp: Added. - -2012-06-30 Ian Vollick <vollick@chromium.org> - - [chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space. - https://bugs.webkit.org/show_bug.cgi?id=90092 - - The CanvasLayerTextureUpdater currently receives its opaque rects in - layer space, but is expected to return them in content space and does - not convert them. This patch adds this conversion. To avoid numerical - errors, this patch also switches to using float rects to store opaque - rects where appropriate. - - Reviewed by Adrienne Walker. - - * WebKit.gypi: - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::paintContents): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::TestOpacityChangeLayerDelegate::paintContents): - (WTF::MockContentLayerDelegate::paintContents): - * tests/ContentLayerChromiumTest.cpp: Added. - (WebKit): - (OpaqueRectDrawingGraphicsContextPainter): - (WebKit::OpaqueRectDrawingGraphicsContextPainter::OpaqueRectDrawingGraphicsContextPainter): - (WebKit::OpaqueRectDrawingGraphicsContextPainter::~OpaqueRectDrawingGraphicsContextPainter): - (MockContentLayerDelegate): - (WebKit::MockContentLayerDelegate::MockContentLayerDelegate): - (WebKit::TEST): - * tests/LayerChromiumTest.cpp: - * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: - (WebCore::TEST_F): - * tests/TiledLayerChromiumTest.cpp: - * tests/WebLayerTest.cpp: - -2012-06-29 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Keep direction on IDBCursor to avoid calls to back end - https://bugs.webkit.org/show_bug.cgi?id=90114 - - Stop plumbing IDBCursorBackendInterface::direction() through API. - - Reviewed by Tony Chang. - - * src/IDBCursorBackendProxy.cpp: - * src/IDBCursorBackendProxy.h: - (IDBCursorBackendProxy): - * src/WebIDBCursorImpl.cpp: - * src/WebIDBCursorImpl.h: - (WebIDBCursorImpl): - -2012-06-29 Adam Barth <abarth@webkit.org> - - [Chromium] WebFontRendering.cpp requires some OS(ANDROID) ifdefs to build downstream - https://bugs.webkit.org/show_bug.cgi?id=90292 - - Reviewed by Nate Chapin. - - These ifdefs are required to build this file downstream. There's some - sublte difference between how the OS flags are set upstream and - downstream. This is on our list of issues to resolve, but in the - meantime, this patch makes these files identical upstream and - downstream to reduce noise in the upstreaming queue. - - * src/linux/WebFontRendering.cpp: - (WebKit::WebFontRendering::setSubpixelPositioning): - -2012-06-29 Eric Penner <epenner@google.com> - - [chromium] Adding PrioritizedTexture and replacing ContentsTextureManager - https://bugs.webkit.org/show_bug.cgi?id=84308 - - Reviewed by Adrienne Walker. - - * WebKit.gypi: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread): - * tests/CCPrioritizedTextureTest.cpp: Added. - (WTF): - (CCPrioritizedTextureTest): - (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest): - (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest): - (WTF::CCPrioritizedTextureTest::texturesMemorySize): - (WTF::CCPrioritizedTextureTest::createManager): - (WTF::CCPrioritizedTextureTest::validateTexture): - (WTF::CCPrioritizedTextureTest::allocator): - (WTF::TEST_F): - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::Texture::Texture): - (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): - (WebKitTests::FakeLayerTextureUpdater::createTexture): - (WebKitTests::FakeTiledLayerChromium::FakeTiledLayerChromium): - (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds): - * tests/CCTiledLayerTestCommon.h: - (Texture): - (FakeLayerTextureUpdater): - (FakeTiledLayerChromium): - (FakeTiledLayerWithScaledBounds): - * tests/TiledLayerChromiumTest.cpp: - -2012-06-29 Ian Vollick <vollick@chromium.org> - - [chromium] Roll chromium rev to 144906 - https://bugs.webkit.org/show_bug.cgi?id=90278 - - Unreviewed. Deps roll. - - * DEPS: - -2012-06-29 Alexander Pavlov <apavlov@chromium.org> - - Web Inspector: [Device Metrics] "Fit window" option inhibits adjusting the page zoom factor - https://bugs.webkit.org/show_bug.cgi?id=90187 - - Reviewed by Vsevolod Vlasov. - - This change fixes the stale zoom factor, which does not get updated upon browser window resize in the "Fit window" mode. - The expected test results have little to do with actual dimensions of the test page in Chrome on a real mobile device, - since Chrome on the mobile uses a different zooming technique (pageScaleFactor-based viewport using layout width - rather than plain pageZoomFactor) and font boosting, which has not been upstreamed yet. - - * src/WebDevToolsAgentImpl.cpp: - (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): - (WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor): - -2012-06-29 Konrad Piascik <kpiascik@rim.com> - - Don't hardcode target dpi of 160 (it should be 96 on desktop) - https://bugs.webkit.org/show_bug.cgi?id=88114 - - Reviewed by Adam Barth. - - Updated the call to computeViewportAttributes. - - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): - -2012-06-29 Amy Ousterhout <aousterh@chromium.org> - - Deleting unused function in WebDeviceOrientation - https://bugs.webkit.org/show_bug.cgi?id=90185 - - Reviewed by Adam Barth. - - Deleting the unused copy assignment function in WebDeviceOrientation. - - * public/WebDeviceOrientation.h: - (WebDeviceOrientation): - * src/WebDeviceOrientation.cpp: - -2012-06-29 Yoshifumi Inoue <yosin@chromium.org> - - [Platform] Implement Date Time format parser - https://bugs.webkit.org/show_bug.cgi?id=89963 - - Reviewed by Kent Tamura. - - This patch adds an unit test for date time format parser if - ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) is true. - - * tests/DateTimeFormatTest.cpp: Added. - (DateTimeFormatTest): - (Token): - (DateTimeFormatTest::Token::Token): - (DateTimeFormatTest::Token::operator==): - (DateTimeFormatTest::Token::toString): - (Tokens): - (DateTimeFormatTest::Tokens::Tokens): - (DateTimeFormatTest::Tokens::operator==): - (DateTimeFormatTest::Tokens::toString): - (DateTimeFormatTest::parse): - (DateTimeFormatTest::single): - (TokenHandler): - (DateTimeFormatTest::TokenHandler::~TokenHandler): - (DateTimeFormatTest::TokenHandler::fieldType): - (DateTimeFormatTest::TokenHandler::tokens): - (DateTimeFormatTest::TokenHandler::visitField): - (DateTimeFormatTest::TokenHandler::visitLiteral): - (operator<<): - (TEST_F): - -2012-06-28 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Implement IDBTransaction internal active flag - https://bugs.webkit.org/show_bug.cgi?id=89379 - - Reviewed by Tony Chang. - - To match the IDB spec, transactions that have had no requests - filed against them should commit, not abort. This requires plumbing - through the commit() call from front-end to back-end. - - * src/IDBTransactionBackendProxy.cpp: - (WebKit::IDBTransactionBackendProxy::commit): - (WebKit): - * src/IDBTransactionBackendProxy.h: - (IDBTransactionBackendProxy): - * src/WebIDBTransactionImpl.cpp: - (WebKit::WebIDBTransactionImpl::commit): - (WebKit): - * src/WebIDBTransactionImpl.h: - -2012-06-28 Adrienne Walker <enne@google.com> - - [chromium] Split WebScrollbar into WebPluginScrollbar and WebScrollbar - https://bugs.webkit.org/show_bug.cgi?id=90117 - - Reviewed by James Robinson. - - Convert WebScrollbar/WebScrollbarClient/WebScrollbarImpl to be - WebPluginScrollbar, WebPluginScrollbarClient, and - WebPluginScrollbarImpl. Modify ScrollbarGroup - to use this instead. - - WebScrollbar is now the base interface for a pre-existing scrollbar - that is accessed in a const manner. It also provides all of the common - WebKit ScrollTypes.h enums. WebPluginScrollbar is now a scrollbar that - has been externally created and is externally modified in terms of its - position, invalidation, and painting. - - This is a pre-refactoring for adding Web versions of ScrollbarTheme - into the Platform directory which will operate on WebScrollbar, but - that don't need all of what WebPluginScrollbar provides. - - As WebScrollbar is moved to Platform, WebKit.gyp now must depend on - Platform as well. - - * WebKit.gyp: - * public/WebPluginScrollbar.h: - (WebKit): - (WebPluginScrollbar): - (WebKit::WebPluginScrollbar::~WebPluginScrollbar): - * public/WebPluginScrollbarClient.h: - (WebKit): - (WebPluginScrollbarClient): - * public/WebScrollbar.h: Removed. - * public/WebScrollbarClient.h: Removed. - * src/AssertMatchingEnums.cpp: - * src/ScrollbarGroup.cpp: - (WebKit::ScrollbarGroup::scrollbarCreated): - (WebKit::ScrollbarGroup::scrollbarDestroyed): - (WebKit::ScrollbarGroup::scrollSize): - (WebKit::ScrollbarGroup::scrollPosition): - (WebKit::ScrollbarGroup::contentsSize): - * src/ScrollbarGroup.h: - (WebKit): - (ScrollbarGroup): - * src/WebPluginScrollbarImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarImpl.cpp. - (WebKit): - (WebKit::WebPluginScrollbar::createForPlugin): - (WebKit::WebPluginScrollbar::defaultThickness): - (WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl): - (WebKit::WebPluginScrollbarImpl::~WebPluginScrollbarImpl): - (WebKit::WebPluginScrollbarImpl::setScrollOffset): - (WebKit::WebPluginScrollbarImpl::invalidateScrollbarRect): - (WebKit::WebPluginScrollbarImpl::getTickmarks): - (WebKit::WebPluginScrollbarImpl::convertFromContainingViewToScrollbar): - (WebKit::WebPluginScrollbarImpl::scrollbarStyleChanged): - (WebKit::WebPluginScrollbarImpl::isOverlay): - (WebKit::WebPluginScrollbarImpl::value): - (WebKit::WebPluginScrollbarImpl::setLocation): - (WebKit::WebPluginScrollbarImpl::setValue): - (WebKit::WebPluginScrollbarImpl::setDocumentSize): - (WebKit::WebPluginScrollbarImpl::scroll): - (WebKit::WebPluginScrollbarImpl::paint): - (WebKit::WebPluginScrollbarImpl::handleInputEvent): - (WebKit::WebPluginScrollbarImpl::onMouseDown): - (WebKit::WebPluginScrollbarImpl::onMouseUp): - (WebKit::WebPluginScrollbarImpl::onMouseMove): - (WebKit::WebPluginScrollbarImpl::onMouseLeave): - (WebKit::WebPluginScrollbarImpl::onMouseWheel): - (WebKit::WebPluginScrollbarImpl::onKeyDown): - * src/WebPluginScrollbarImpl.h: Added. - (WebCore): - (WebKit): - (WebPluginScrollbarImpl): - (WebKit::WebPluginScrollbarImpl::scrollOffset): - (WebKit::WebPluginScrollbarImpl::scrollbar): - * src/WebScrollbarImpl.h: Removed. - -2012-06-28 Adam Barth <abarth@webkit.org> - - [Chromium] On Android, we should be able to ask the embedder what intents exist in a region of the page - https://bugs.webkit.org/show_bug.cgi?id=90210 - - Reviewed by Dimitri Glazkov. - - This patch introduces a function that asks the embedder to analyze the - region around a hit test result for interesting content, like phone - numbers, email addresses, or physical addresses. The embedder then - responds with the "most interesting" content, together with an intent - URL for enacting the intent embodied by that content. - - This function will be used in a subsequent patch to detect content - after touch events. - - * WebKit.gyp: - * public/WebContentDetectionResult.h: Added. - (WebKit): - (WebContentDetectionResult): - (WebKit::WebContentDetectionResult::WebContentDetectionResult): - (WebKit::WebContentDetectionResult::isValid): - (WebKit::WebContentDetectionResult::range): - (WebKit::WebContentDetectionResult::string): - (WebKit::WebContentDetectionResult::intent): - * public/WebViewClient.h: - (WebViewClient): - (WebKit::WebViewClient::detechContentAround): - -2012-06-28 Alec Flett <alecflett@chromium.org> - - IndexedDB: Hook up render-side key ASSERTing for get() - https://bugs.webkit.org/show_bug.cgi?id=90001 - - Reviewed by Tony Chang. - - Hook up Chromium WebKit API to new onSuccess handler. - - * src/WebIDBCallbacksImpl.cpp: - (WebKit::WebIDBCallbacksImpl::onSuccess): - * tests/IDBAbortOnCorruptTest.cpp: - (WebCore::MockIDBCallbacks::onSuccess): - * tests/IDBDatabaseBackendTest.cpp: - -2012-06-28 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-28 Alpha Lam <hclam@chromium.org> - - Unreviewed, rolling out r121463. - http://trac.webkit.org/changeset/121463 - https://bugs.webkit.org/show_bug.cgi?id=90094 - - Broke Windows build. - - * WebKit.gypi: - * WebKitUnitTests.gyp: - * public/WebDOMMessageEvent.h: - * tests/AssociatedURLLoaderTest.cpp: - (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): - (WebKit::AssociatedURLLoaderTest::SetUp): - (WebKit::AssociatedURLLoaderTest::CheckMethodFails): - (WebKit::AssociatedURLLoaderTest::CheckHeaderFails): - (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders): - (WebKit::TEST_F): - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::registerMockedURLLoad): - (FrameTestHelpers): - (WebKit::FrameTestHelpers::loadFrame): - * tests/FrameTestHelpers.h: - (FrameTestHelpers): - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/PopupMenuTest.cpp: - (WebKit::SelectPopupMenuTest::registerMockedURLLoad): - (WebKit::SelectPopupMenuTest::loadFrame): - (WebKit::TEST_F): - * tests/RunAllTests.cpp: - * tests/URLTestHelpers.cpp: Removed. - * tests/URLTestHelpers.h: Removed. - * tests/WebFrameTest.cpp: - (WebKit::WebFrameTest::registerMockedHttpURLLoad): - (WebKit::WebFrameTest::registerMockedChromeURLLoad): - (WebKit::TEST_F): - * tests/WebPageNewSerializerTest.cpp: - (WebKit::WebPageNewSerializeTest::registerMockedURLLoad): - (WebPageNewSerializeTest): - (WebKit::WebPageNewSerializeTest::setUpCSSTestPage): - (WebKit::WebPageNewSerializeTest::loadURLInTopFrame): - (WebKit::WebPageNewSerializeTest::resourceVectorContains): - (WebKit::TEST_F): - * tests/WebPageSerializerTest.cpp: - (WebKit::WebPageSerializerTest::registerMockedURLLoad): - (WebKit::WebPageSerializerTest::loadURLInTopFrame): - (WebKit::WebPageSerializerTest::webVectorContains): - (WebKit::TEST_F): - * tests/WebViewTest.cpp: - (WebKit::TEST_F): - (WebKit::WebViewTest::testAutoResize): - (WebKit::WebViewTest::testTextInputType): - -2012-06-28 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=90094 - - Reviewed by Adam Barth. - - This patch adds the WEBKIT_IMPLEMENTATION = 1 define to - WebKitUnitTests.gyp. To get it to compile correctly, some string - and URL code was refactored and fixed. - - * WebKit.gypi: - * WebKitUnitTests.gyp: - * public/WebDOMMessageEvent.h: - (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): - * tests/AssociatedURLLoaderTest.cpp: - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::loadFrame): - * tests/FrameTestHelpers.h: - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/PopupMenuTest.cpp: - * tests/RunAllTests.cpp: - * tests/URLTestHelpers.cpp: Added. - (URLTestHelpers): - (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): - (WebKit::URLTestHelpers::registerMockedURLLoad): - * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. - (WebKit): - (URLTestHelpers): - (WebKit::URLTestHelpers::toKURL): - * tests/WebFrameTest.cpp: - * tests/WebPageNewSerializerTest.cpp: - * tests/WebPageSerializerTest.cpp: - * tests/WebViewTest.cpp: - -2012-06-28 Oli Lan <olilan@chromium.org> - - [chromium] Change WebViewImpl::textInputInfo to use root editable element. - https://bugs.webkit.org/show_bug.cgi?id=90179 - - Reviewed by Adam Barth. - - WebViewImpl::textInputInfo currently returns text value and offsets relative to the - focused node. For contenteditable nodes, this may not give the expected result. - - This patch changes the method to return value and offsets for the root editable element. - This also allows the implementation to be simplified somewhat. - - This also ensures that the offsets returned will use the same basis as the recently added - method Editor::setSelectionOffsets (and WebViewImpl::setEditableSelectionOffsets). - - Testing for textInputInfo has been added to WebViewTest. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::textInputInfo): - * tests/WebViewTest.cpp: - (WebKit::TEST_F): - -2012-06-28 James Robinson <jamesr@chromium.org> - - [chromium] Should schedule a commit when dropping contents textures - https://bugs.webkit.org/show_bug.cgi?id=90031 - - Reviewed by Adrienne Walker. - - Adds a somewhat vacuous test unit test for committing when releasing textures. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-27 Dana Jansens <danakj@chromium.org> - - [chromium] Do not multiply bounds by contentsScale in TiledLayerChromium and CanvasLayerTextureUpdater - https://bugs.webkit.org/show_bug.cgi?id=90103 - - Reviewed by Adrienne Walker. - - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::prepareToUpdate): - * tests/CCTiledLayerTestCommon.h: - (FakeTiledLayerChromium): - * tests/TiledLayerChromiumTest.cpp: - -2012-06-28 Dan Alcantara <dfalcantara@chromium.org> - - [chromium] Introduce way to reload a page using the original request URL - https://bugs.webkit.org/show_bug.cgi?id=89788 - - Reviewed by Adam Barth. - - Adds a new reload method for cases where we need to override the URL - when reloading a page. This is needed for situations where a server - redirects navigation based on information that may have changed since - the last time the page was loaded. - - User agents, for example, can cause a server to redirect to the mobile - version of a page. Changing to the desktop version by switching user agents - requires loading a URL from before the redirect occurred. - - Also adds a unit test to confirm that scroll position and page scale are - saved when the reload occurs. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::reloadWithGivenURL): - (WebKit): - * src/WebFrameImpl.h: - (WebFrameImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setClearPageScaleFactorOnLoad): - (WebKit): - (WebKit::WebViewImpl::didCommitLoad): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-06-28 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r121395. - http://trac.webkit.org/changeset/121395 - https://bugs.webkit.org/show_bug.cgi?id=90143 - - Patch causes crashes in fast/workers/worker-context-gc.html - (Requested by zdobersek on #webkit). - - * src/WebSharedWorkerImpl.cpp: - (WebKit::WebSharedWorkerImpl::startWorkerContext): - * src/WebWorkerClientImpl.cpp: - (WebKit::WebWorkerClientImpl::startWorkerContext): - -2012-06-28 Yoshifumi Inoue <yosin@chromium.org> - - [Platform] Implement functions for localized time format information - https://bugs.webkit.org/show_bug.cgi?id=89965 - - Reviewed by Kent Tamura. - - This patch adds new test LocalizedDateICUTest if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) - is true. - - * WebKit.gypi: - * tests/LocalizedDateICUTest.cpp: Added. - (LocalizedDateICUTest): - (Labels): - (LocalizedDateICUTest::Labels::Labels): - (LocalizedDateICUTest::Labels::operator==): - (LocalizedDateICUTest::Labels::toString): - (LocalizedDateICUTest::labels): - (LocalizedDateICUTest::localizedDateFormatText): - (LocalizedDateICUTest::localizedShortDateFormatText): - (LocalizedDateICUTest::timeAMPMLabels): - (operator<<): - (TEST_F): - -2012-06-27 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r121405. - http://trac.webkit.org/changeset/121405 - https://bugs.webkit.org/show_bug.cgi?id=90135 - - broke windows build (Requested by shawnsingh_ on #webkit). - - * WebKit.gypi: - * WebKitUnitTests.gyp: - * public/WebDOMMessageEvent.h: - * tests/AssociatedURLLoaderTest.cpp: - (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest): - (WebKit::AssociatedURLLoaderTest::SetUp): - (WebKit::AssociatedURLLoaderTest::CheckMethodFails): - (WebKit::AssociatedURLLoaderTest::CheckHeaderFails): - (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders): - (WebKit::TEST_F): - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::registerMockedURLLoad): - (FrameTestHelpers): - (WebKit::FrameTestHelpers::loadFrame): - * tests/FrameTestHelpers.h: - (FrameTestHelpers): - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/PopupMenuTest.cpp: - (WebKit::SelectPopupMenuTest::registerMockedURLLoad): - (WebKit::SelectPopupMenuTest::loadFrame): - * tests/RunAllTests.cpp: - * tests/URLTestHelpers.cpp: Removed. - * tests/URLTestHelpers.h: Removed. - * tests/WebFrameTest.cpp: - (WebKit::WebFrameTest::registerMockedHttpURLLoad): - (WebKit::WebFrameTest::registerMockedChromeURLLoad): - (WebKit::TEST_F): - * tests/WebPageNewSerializerTest.cpp: - (WebKit::WebPageNewSerializeTest::registerMockedURLLoad): - (WebPageNewSerializeTest): - (WebKit::WebPageNewSerializeTest::setUpCSSTestPage): - (WebKit::WebPageNewSerializeTest::loadURLInTopFrame): - (WebKit::WebPageNewSerializeTest::resourceVectorContains): - (WebKit::TEST_F): - * tests/WebPageSerializerTest.cpp: - (WebKit::WebPageSerializerTest::registerMockedURLLoad): - (WebKit::WebPageSerializerTest::loadURLInTopFrame): - (WebKit::WebPageSerializerTest::webVectorContains): - (WebKit::TEST_F): - * tests/WebViewTest.cpp: - (WebKit::TEST_F): - (WebKit::WebViewTest::testAutoResize): - (WebKit::WebViewTest::testTextInputType): - -2012-06-27 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=90094 - - Reviewed by James Robinson. - - This patch adds the WEBKIT_IMPLEMENTATION = 1 define to - WebKitUnitTests.gyp. To get it to compile correctly, some string - and URL code was refactored and fixed. - - * WebKit.gypi: - * WebKitUnitTests.gyp: - * public/WebDOMMessageEvent.h: - (WebKit::WebDOMMessageEvent::WebDOMMessageEvent): - * tests/AssociatedURLLoaderTest.cpp: - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::loadFrame): - * tests/FrameTestHelpers.h: - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/PopupMenuTest.cpp: - * tests/RunAllTests.cpp: - * tests/URLTestHelpers.cpp: Added. - (URLTestHelpers): - (WebKit::URLTestHelpers::registerMockedURLFromBaseURL): - (WebKit::URLTestHelpers::registerMockedURLLoad): - * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h. - (WebKit): - (URLTestHelpers): - (WebKit::URLTestHelpers::toKURL): - * tests/WebFrameTest.cpp: - * tests/WebPageNewSerializerTest.cpp: - * tests/WebPageSerializerTest.cpp: - * tests/WebViewTest.cpp: - -2012-06-27 Yoshifumi Inoue <yosin@chromium.org> - - [Platform] Implement localizedDecimalSeparator function - https://bugs.webkit.org/show_bug.cgi?id=90036 - - Reviewed by Kent Tamura. - - This patch adds test case for localizedDecimalSeparator(). - - * tests/LocalizedNumberICUTest.cpp: - (testDecimalSeparator): - (TEST): - -2012-06-27 Yusuke Sato <yusukes@chromium.org> - - [chromium] Improve keyboardEvent() so a web page could receive a DOM3 spec compliant keyboard event. - https://bugs.webkit.org/show_bug.cgi?id=89637 - - Reviewed by Tony Chang. - - This is a Gtk port of http://crrev.com/142209. - - Normalizes event->state to make it Windows/Mac compatible. Since the - way of setting modifier mask on X is very different than Windows/Mac - as shown in http://crbug.com/127142#c8, the normalization is necessary. - - * src/gtk/WebInputEventFactory.cpp: - (WebKit): - (WebKit::normalizeEventState): - (WebKit::WebInputEventFactory::keyboardEvent): - -2012-06-27 James Robinson <jamesr@chromium.org> - - [chromium] Use SkColor in compositor internals - https://bugs.webkit.org/show_bug.cgi?id=90108 - - Reviewed by Adrienne Walker. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::setBackgroundColor): - * tests/CCLayerImplTest.cpp: - (WebCore::TEST): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCSolidColorLayerImplTest.cpp: - (CCLayerTestCommon::TEST): - * tests/LayerChromiumTest.cpp: - -2012-06-27 Charles Wei <charles.wei@torchmobile.com.cn> - - IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath - https://bugs.webkit.org/show_bug.cgi?id=88338 - - Reviewed by David Levin. - - * src/WebSharedWorkerImpl.cpp: - (WebKit::WebSharedWorkerImpl::startWorkerContext): - * src/WebWorkerClientImpl.cpp: - (WebKit::WebWorkerClientImpl::startWorkerContext): - -2012-06-27 Joshua Bell <jsbell@chromium.org> - - [Chromium] IndexedDB: Expose WebIDBTransaction::commit() method in public API - https://bugs.webkit.org/show_bug.cgi?id=90089 - - Reviewed by James Robinson. - - Prep work for http://webkit.org/b/89379 which requires empty transactions to - trigger a commit from the front-end. - - * public/WebIDBTransaction.h: - (WebKit::WebIDBTransaction::commit): - -2012-06-27 Josh Horwich <jhorwich@chromium.org> - - [chromium] Expose device scale factor in WebPluginContainer - https://bugs.webkit.org/show_bug.cgi?id=87874 - - Reviewed by Adam Barth. - - * public/WebPluginContainer.h: - (WebPluginContainer): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::deviceScaleFactor): - (WebKit): - (WebKit::WebPluginContainerImpl::pageScaleFactor): - (WebKit::WebPluginContainerImpl::pageZoomFactor): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - -2012-06-27 Robert Kroeger <rjkroege@chromium.org> - - [chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor - https://bugs.webkit.org/show_bug.cgi?id=90006 - - The assert in WebViewImpl::setDeviceScaleFactor should test for non-scaling - after we have set both m_DeviceScaleInCompositor and page()->deviceScaleFactor() - instead of in between. - - Reviewed by James Robinson. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setDeviceScaleFactor): - -2012-06-26 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-26 James Robinson <jamesr@chromium.org> - - [chromium] Remove WebView::graphicsContext3D getter - https://bugs.webkit.org/show_bug.cgi?id=89916 - - Reviewed by Adrienne Walker. - - Removes WebView::graphicsContext3D getter. This getter was used to access the compositor's context, which is an - inherently dangerous operation since the compositor context may not be safe to use on the main thread and has - somewhat complicated creation / recreation semantics. A shared context is exposed - (WebView::sharedGraphicsContext3D) for callers who may want access to a context in a share group with the - compositor. - - * public/WebView.h: - (WebView): - * src/WebLayerTreeView.cpp: - * src/WebViewImpl.cpp: - * src/WebViewImpl.h: - (WebViewImpl): - -2012-06-26 Peter Beverloo <peter@chromium.org> - - [Chromium] Decrease the number of conditional blocks in features.gypi - https://bugs.webkit.org/show_bug.cgi?id=90013 - - Reviewed by Adam Barth. - - Consolidate two Android-specific and accelerated-compositing-specific - conditional blocks into other blocks which serve an identical purpose. - - * features.gypi: - -2012-06-26 Dave Tu <dtu@chromium.org> - - [chromium] Expose rendering statistics to WebWidget. - https://bugs.webkit.org/show_bug.cgi?id=88268 - - Reviewed by James Robinson. - - The WebKit side of a basic framework for exposing rendering statistics - to Chromium's --enable-benchmarking extension. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::renderingStatistics): - (WebKit): - -2012-06-25 James Robinson <jamesr@chromium.org> - - [chromium] Add WebLayer API for scrolling - https://bugs.webkit.org/show_bug.cgi?id=89913 - - Reviewed by Adrienne Walker. - - Use WebScrollableLayer type in NonCompositedContentHost. - - * WebKit.gyp: - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::setScrollLayer): - (WebKit::reserveScrollbarLayers): - (WebKit::NonCompositedContentHost::setViewport): - (WebKit::NonCompositedContentHost::haveScrollLayer): - (WebKit): - (WebKit::NonCompositedContentHost::scrollLayer): - * src/NonCompositedContentHost.h: - (WebCore): - * src/WebContentLayer.cpp: - (WebKit::WebContentLayer::WebContentLayer): - * src/WebLayer.cpp: - (WebKit::WebLayer::numberOfChildren): - (WebKit): - (WebKit::WebLayer::childAt): - (WebKit::WebLayer::setAlwaysReserveTextures): - * src/WebScrollableLayer.cpp: - (WebKit): - (WebKit::WebScrollableLayer::setScrollPosition): - (WebKit::WebScrollableLayer::setScrollable): - (WebKit::WebScrollableLayer::setHaveWheelEventHandlers): - (WebKit::WebScrollableLayer::setShouldScrollOnMainThread): - -2012-06-26 Ian Vollick <vollick@chromium.org> - - [chromium] The single thread proxy should not automatically tick new animations. - https://bugs.webkit.org/show_bug.cgi?id=89996 - - Reviewed by James Robinson. - - * WebKit.gypi: - * tests/CCSingleThreadProxyTest.cpp: Removed. - -2012-06-26 Ian Vollick <vollick@chromium.org> - - [chromium] Layer chromium should need a redraw after getting its first non-empty bounds. - https://bugs.webkit.org/show_bug.cgi?id=89784 - - Reviewed by James Robinson. - - Previously, we'd only set needs redraw if the old bounds were zero, - and the new bounds were non-zero, but we should actually have - checked that the old bounds were non-empty. - - * tests/LayerChromiumTest.cpp: - -2012-06-26 James Robinson <jamesr@chromium.org> - - [chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium - https://bugs.webkit.org/show_bug.cgi?id=89933 - - Reviewed by Kenneth Russell. - - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - -2012-06-26 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements - https://bugs.webkit.org/show_bug.cgi?id=89931 - - Reviewed by James Robinson. - - WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of - #ifdef or #if have different behavior. There are some places in - the code that use "#ifdef WEBKIT_IMLPEMENTATION", but they should - actually be "#if WEBKIT_IMPLEMENTATION". This patch fixes those - #ifdef statements. - - * public/WebTextRun.h: - (WebTextRun): - * public/linux/WebFontRenderStyle.h: - -2012-06-26 Jun Mukai <mukai@chromium.org> - - Allow using <input type="color"> UI in ChromeOS. - https://bugs.webkit.org/show_bug.cgi?id=89944 - - Reviewed by Kent Tamura. - - http://crrev.com/144111 adds the UI of <input type="color"> for - ChromeOS, so now we can set its flag too. - - * features.gypi: - -2012-06-25 Ryosuke Niwa <rniwa@webkit.org> - - Get rid of firstItem and nextItem from HTMLCollection - https://bugs.webkit.org/show_bug.cgi?id=89923 - - Reviewed by Andreas Kling. - - Re-implement WebNodeCollection::firstItem() and WebNodeCollection::nextItem() in WebKit code - because we got rid of it from WebCore implementation. - - This is an extremely poor API and we shouldn't be exposing it in the future. - - * public/WebNodeCollection.h: - (WebKit::WebNodeCollection::WebNodeCollection): - (WebNodeCollection): - * src/WebNodeCollection.cpp: - (WebKit::WebNodeCollection::nextItem): - (WebKit::WebNodeCollection::firstItem): - * src/WebPageSerializerImpl.cpp: - (WebKit::WebPageSerializerImpl::collectTargetFrames): - -2012-06-25 Luke Macpherson <macpherson@chromium.org> - - Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). - https://bugs.webkit.org/show_bug.cgi?id=89542 - - Reviewed by Dimitri Glazkov. - - * features.gypi: - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-06-25 Adrienne Walker <enne@google.com> - - [chromium] Add WebPluginScrollbar and WebPluginScrollbarClient stub implementations - https://bugs.webkit.org/show_bug.cgi?id=89928 - - Reviewed by Darin Fisher. - - These classes are just typedef'd to be the non-Plugin version. The - next step is to change Chromium to use the Plugin version, then move - most of WebPluginScrollbar to a WebScrollbar in Platform to separate - out the base functionality, while providing the same top level API. - - * WebKit.gyp: - * public/WebPluginScrollbar.h: Added. - (WebKit): - * public/WebPluginScrollbarClient.h: Added. - (WebKit): - -2012-06-25 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-25 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r121206. - http://trac.webkit.org/changeset/121206 - https://bugs.webkit.org/show_bug.cgi?id=89935 - - [chromium] webkit_unit_tests - WebViewTest.MHTMLWithMissingResourceFinishesLoading crash - (Requested by ukai on #webkit). - - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (WebKit::FrameTestHelpers::registerMockedURLLoad): - (WebKit::FrameTestHelpers::createWebViewAndLoad): - * tests/FrameTestHelpers.h: - (FrameTestHelpers): - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/WebFrameTest.cpp: - (WebKit::WebFrameTest::registerMockedHttpURLLoad): - (WebKit::WebFrameTest::registerMockedChromeURLLoad): - * tests/WebViewTest.cpp: - (WebKit::TEST_F): - (WebKit::WebViewTest::testAutoResize): - (WebKit::WebViewTest::testTextInputType): - -2012-06-25 Adam Barth <abarth@webkit.org> - - [Chromium] Let the embedder override the max page scale factor set by the page - https://bugs.webkit.org/show_bug.cgi?id=89406 - - Reviewed by James Robinson. - - Chrome on Android has an option to force the web site to allow page - scaling (for accessibility). This patch adds - WebView::setIgnoreViewportTagMaximumScale, which instructs the WebView - to ignore the maximum scale factor supplied by by the page in the - viewport meta tag. - - This patch is a bit different from how this is implemented on the - chromium-android branch, but I'll clean up the branch once this patch - lands. - - * public/WebView.h: - (WebView): - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setIgnoreViewportTagMaximumScale): - (WebKit): - * src/WebViewImpl.h: - (WebViewImpl): - (WebKit::WebViewImpl::ignoreViewportTagMaximumScale): - * tests/WebFrameTest.cpp: - (WebKit::TEST_F): - (WebKit): - -2012-06-25 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r121176. - http://trac.webkit.org/changeset/121176 - https://bugs.webkit.org/show_bug.cgi?id=89934 - - [chromium] browser_tests assert failed: - FATAL:native_theme_win.cc(1541)] Check failed: false. Invalid - part: 16 (Requested by ukai on #webkit). - - * src/PlatformSupport.cpp: - -2012-06-25 Jay Civelli <jcivelli@chromium.org> - - Fix progress load reporting for MHTML documents. - - MHTML documents containing references to resources they don't include - never finish loading. - https://bugs.webkit.org/show_bug.cgi?id=71859 - - Reviewed by Nate Chapin. - - * tests/EventListenerTest.cpp: - * tests/FrameTestHelpers.cpp: - (FrameTestHelpers): - (WebKit::FrameTestHelpers::registerMockedURLLoad): - (WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML): - (WebKit::FrameTestHelpers::createWebViewAndLoad): - * tests/FrameTestHelpers.h: - (FrameTestHelpers): - * tests/ListenerLeakTest.cpp: - (WebKit::ListenerLeakTest::RunTest): - * tests/WebFrameTest.cpp: - (WebKit::WebFrameTest::registerMockedHttpURLLoad): - (WebKit::WebFrameTest::registerMockedChromeURLLoad): - * tests/WebViewTest.cpp: - (WebKit::TEST_F): - (WebKit::WebViewTest::testAutoResize): - (WebKit::WebViewTest::testTextInputType): - (TestWebViewClient): - (WebKit::TestWebViewClient::TestWebViewClient): - (WebKit::TestWebViewClient::didStartLoading): - (WebKit::TestWebViewClient::didStopLoading): - (WebKit::TestWebViewClient::didChangeLoadProgress): - (WebKit::TestWebViewClient::loadingStarted): - (WebKit::TestWebViewClient::loadingStopped): - (WebKit::TestWebViewClient::loadProgress): - (WebKit): - -2012-06-25 James Robinson <jamesr@chromium.org> - - [chromium] Use WebGraphicsContext3D in compositor implementation - https://bugs.webkit.org/show_bug.cgi?id=89700 - - Reviewed by Adrienne Walker. - - Updates tests for refactor, mostly by removing unnecessary GraphicsContext3D wrapper around mock contexts. - - * WebKit.gypi: - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::context): - * src/WebLayerTreeViewImpl.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread): - (WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread): - (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread): - (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread): - * tests/CCSingleThreadProxyTest.cpp: - * tests/CCThreadedTest.cpp: - (WebKitTests::TestHooks::createContext): - * tests/CCThreadedTest.h: - (TestHooks): - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - * tests/CompositorFakeGraphicsContext3D.h: Removed. - * tests/DrawingBufferChromiumTest.cpp: Removed. - * tests/FakeCCLayerTreeHostClient.h: - * tests/FakeGraphicsContext3DTest.cpp: - (TEST): - * tests/GraphicsLayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (FakeLayerRendererChromium::FakeLayerRendererChromium): - (LayerRendererChromiumTest::LayerRendererChromiumTest): - (LayerRendererChromiumTest): - (TEST_F): - (TEST): - * tests/TextureCopierTest.cpp: - * tests/ThrottledTextureUploaderTest.cpp: - (WebKit::TEST): - * tests/TiledLayerChromiumTest.cpp: - -2012-06-25 Kausalya Madhusudhanan <kmadhusu@chromium.org> - - [Chromium] Add a chromium-webkit API to create a serializable file system. - https://bugs.webkit.org/show_bug.cgi?id=89776 - - In order to send a DOMFileSystem as part of WebIntent payload data it - should be serializable. Therefore, I added an API that allows us to - create serializable file system in chromium code. - - Reviewed by Adam Barth. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::createSerializableFileSystem): - (WebKit): - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-06-25 Alpha Lam <hclam@chromium.org> - - Unreviewed, rolling out r121178. - http://trac.webkit.org/changeset/121178 - https://bugs.webkit.org/show_bug.cgi?id=89784 - - New unit test added is failing on WebKit Linux (dbg) - - * tests/LayerChromiumTest.cpp: - -2012-06-25 Alpha Lam <hclam@chromium.org> - - Unreviewed, rolling out r121129. - http://trac.webkit.org/changeset/121129 - https://bugs.webkit.org/show_bug.cgi?id=89542 - - Chromium ASan failure: crbug.com/134402 - - * features.gypi: - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-06-25 Alpha Lam <hclam@chromium.org> - - Roll Chromium DEPS to r144020 - https://bugs.webkit.org/show_bug.cgi?id=89912 - - Build fixed now! Unreviewed. - - Rolled DEPS to fix chromium build. - Patch by Scott Graham <scottmg@chromium.org>. - - * DEPS: - -2012-06-25 Alec Flett <alecflett@chromium.org> - - IndexedDB: Stub out new onSuccess() handler for chromium - https://bugs.webkit.org/show_bug.cgi?id=89895 - - This is the chromium side of a refactor which will - introduce an onSuccess() method which includes the raw - SerializedScriptValue to the frontend, so the primaryKey - injection can happen in the front end, rather than - the V8 helper process. - - Reviewed by Darin Fisher. - - * public/WebIDBCallbacks.h: - (WebKit): - (WebKit::WebIDBCallbacks::onSuccess): - * src/IDBCallbacksProxy.cpp: - (WebKit::IDBCallbacksProxy::onSuccess): - * src/IDBCallbacksProxy.h: - (IDBCallbacksProxy): - * src/WebIDBCallbacksImpl.cpp: - (WebKit::WebIDBCallbacksImpl::onSuccess): - (WebKit): - * src/WebIDBCallbacksImpl.h: - (WebIDBCallbacksImpl): - -2012-06-25 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Remove unused backend property accessors - https://bugs.webkit.org/show_bug.cgi?id=89893 - - Reviewed by Darin Fisher. - - Following the "metadata" API addition in trac.webkit.org/changeset/121059 - per-property accessors can be removed from the Chromium WebKit API. - - * src/WebIDBDatabaseImpl.cpp: Removed name, version, objectStoreNames. - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - * src/WebIDBIndexImpl.cpp: Removed name, keyPath, unique, multiEntry. - * src/WebIDBIndexImpl.h: - (WebIDBIndexImpl): - * src/WebIDBObjectStoreImpl.cpp: Removed name, keyPath, autoIncrement, indexNames. - * src/WebIDBObjectStoreImpl.h: - (WebIDBObjectStoreImpl): - -2012-06-25 Ian Vollick <vollick@chromium.org> - - [chromium] Layer chromium should need a redraw after getting its first non-empty bounds. - https://bugs.webkit.org/show_bug.cgi?id=89784 - - Reviewed by James Robinson. - - Previously, we'd only set needs redraw if the old bounds were zero, - and the new bounds were non-zero, but we should actually have - checked that the old bounds were non-empty. - - * tests/LayerChromiumTest.cpp: - -2012-06-25 Scott Graham <scottmg@chromium.org> - - Plumb Scrollbar button dimensions down to WebThemeEngine - https://bugs.webkit.org/show_bug.cgi?id=89264 - - Reviewed by James Robinson. - - Rather than making the height of the scrollbar buttons the same as the - width of the scrollbar, delegate to the WebThemeEngine. This allows - matching the Aura theme rather than the standard Windows theme. - - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::getThemePartSize): - (WebCore): - -2012-06-25 Zeev Lieber <zlieber@chromium.org> - - [Chromium] RenderPass textures are evicted at the end of every frame - https://bugs.webkit.org/show_bug.cgi?id=89786 - - Reviewed by Adrienne Walker. - - Added unit tests to verify large textures are staying in memory - and available for render pass optimization. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-25 Kinuko Yasuda <kinuko@chromium.org> - - Heap-use-after-free in WebKit::MainThreadFileSystemCallbacks - https://bugs.webkit.org/show_bug.cgi?id=87019 - - Reviewed by David Levin. - - Should not access the CallbacksBridge's member field after it's freed. - - * src/WorkerFileSystemCallbacksBridge.cpp: - (WebKit::WorkerFileSystemCallbacksBridge::cleanUpAfterCallback): - -2012-06-24 Luke Macpherson <macpherson@chromium.org> - - Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). - https://bugs.webkit.org/show_bug.cgi?id=89542 - - Reviewed by Dimitri Glazkov. - - * features.gypi: - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-06-23 Kwang Yul Seo <skyul@company100.net> - - [chromium] Return has value, in function returning void - https://bugs.webkit.org/show_bug.cgi?id=89822 - - Reviewed by Adam Barth. - - A followup for r121091. - - * src/WebHistoryItem.cpp: - (WebKit::WebHistoryItem::setPageScaleFactor): - * src/WebImageLayer.cpp: - (WebKit::WebImageLayer::setBitmap): - * src/WebLayer.cpp: - (WebKit::WebLayer::setMaskLayer): - * src/WebOptionElement.cpp: - (WebKit::WebOptionElement::setValue): - (WebKit::WebOptionElement::setDefaultSelected): - -2012-06-23 Kwang Yul Seo <skyul@company100.net> - - [chromium] Return has value, in function returning void - https://bugs.webkit.org/show_bug.cgi?id=89805 - - Reviewed by Adam Barth. - - Make WebFrameImpl::replaceSelection not return a value because it is a function returning void. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::replaceSelection): - -2012-06-22 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-22 David Grogan <dgrogan@chromium.org> - - IndexedDB: Avoid infinite loop if we try to encode -1 for leveldb - https://bugs.webkit.org/show_bug.cgi?id=89625 - - Reviewed by Tony Chang. - - * tests/IDBLevelDBCodingTest.cpp: - (IDBLevelDBCoding::TEST): - -2012-06-22 Michael Nordman <michaeln@google.com> - - [chromium] WebKit API plumbing for applicationCache.abort() - https://bugs.webkit.org/show_bug.cgi?id=89792 - - Reviewed by Darin Fisher. - - * public/WebApplicationCacheHost.h: - (WebKit::WebApplicationCacheHost::abort): - * src/ApplicationCacheHost.cpp: - (WebCore::ApplicationCacheHost::abort): - -2012-06-22 James Robinson <jamesr@chromium.org> - - [chromium] LayerRendererChromium is not getting visibility messages in single threaded compositing mode. - https://bugs.webkit.org/show_bug.cgi?id=89045 - - Reviewed by Adrienne Walker. - - Based on patch by Michal Mocny <mmocny@google.com>. - - Update various test fixtures and tests to cover scheduling, visibility, and resource allocation changes. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (CCLayerTreeHostTestAbortFrameWhenInvisible): - (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::CCLayerTreeHostTestAbortFrameWhenInvisible): - (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::beginTest): - (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::afterTest): - (WTF): - (WTF::TEST_F): - (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): - (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): - (WTF::CCLayerTreeHostTestManySurfaces::beginTest): - * tests/CCSchedulerStateMachineTest.cpp: - (WebCore::TEST): - * tests/CCTiledLayerTestCommon.h: - * tests/FakeWebGraphicsContext3D.h: - (WebKit::FakeWebGraphicsContext3D::FakeWebGraphicsContext3D): - (FakeWebGraphicsContext3D): - (WebKit::FakeWebGraphicsContext3D::createTexture): - * tests/LayerRendererChromiumTest.cpp: - (TEST_F): - * tests/TiledLayerChromiumTest.cpp: - - -2012-06-22 Sadrul Habib Chowdhury <sadrul@chromium.org> - - [chromium] Notify the document if a plugin accepts touch input events - https://bugs.webkit.org/show_bug.cgi?id=89769 - - Reviewed by Adam Barth. - - The browser sends touch events to webkit only if webkit has any touch-event handlers. So it is - necessary to notify the document when a plugin starts accepting touch-events so that it can in - turn tell the browser to send it touch events. - - * public/WebPluginContainer.h: - (WebPluginContainer): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::setIsAcceptingTouchEvents): - (WebKit): - (WebKit::WebPluginContainerImpl::WebPluginContainerImpl): - (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl): - * src/WebPluginContainerImpl.h: - (WebPluginContainerImpl): - -2012-06-22 Kenneth Russell <kbr@google.com> - - Unreviewed, rolling out r121064. - http://trac.webkit.org/changeset/121064 - https://bugs.webkit.org/show_bug.cgi?id=88268 - - Broke Chromium Mac build. - - * public/WebView.h: - (WebKit): - (WebView): - * src/WebLayerTreeView.cpp: - * src/WebViewImpl.cpp: - * src/WebViewImpl.h: - (WebViewImpl): - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestScrollSimple::layout): - (WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit): - -2012-06-22 Dave Tu <dtu@chromium.org> - - [chromium] Expose rendering statistics to WebWidget. - https://bugs.webkit.org/show_bug.cgi?id=88268 - - Reviewed by James Robinson. - - The WebKit side of a basic framework for exposing rendering statistics - to Chromium's --enable-benchmarking extension. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::renderingStatistics): - (WebKit): - -2012-06-22 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Do not accumulate occlusion from 3d layers on the main thread - https://bugs.webkit.org/show_bug.cgi?id=89704 - - Reviewed by James Robinson. - - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): - (WebKitTests): - (CCOcclusionTrackerTestUnsorted3dLayers): - (WebKitTests::CCOcclusionTrackerTestUnsorted3dLayers::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): - -2012-06-22 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Snapshot metadata in front end to avoid IPC round-trips - https://bugs.webkit.org/show_bug.cgi?id=88467 - - Reviewed by Tony Chang. - - Add conversions to/from WebCore IDB metadata type and plumbing for routing the - IDBDatabaseBackendInterface::metadata() call through the public API.. - - * WebKit.gyp: New file added. - * public/WebIDBMetadata.h: Conversion functions. - (WebCore): - (WebIDBMetadata): - * src/IDBDatabaseBackendProxy.cpp: Plumbing. - (WebKit::IDBDatabaseBackendProxy::metadata): - (WebKit): - * src/IDBDatabaseBackendProxy.h: Plumbing. - (IDBDatabaseBackendProxy): - * src/WebIDBDatabaseImpl.cpp: Plumbing. - (WebKit::WebIDBDatabaseImpl::metadata): - (WebKit): - * src/WebIDBDatabaseImpl.h: Plumbing. - (WebKit): - (WebIDBDatabaseImpl): - * src/WebIDBMetadata.cpp: Added - conversion functions. - (WebKit): - (WebKit::WebIDBMetadata::WebIDBMetadata): - (WebKit::WebIDBMetadata::operator IDBDatabaseMetadata): - -2012-06-22 Fady Samuel <fsamuel@chromium.org> - - [Chromium] Browser Plugin: Expose advanceFocus to WebKit API so that guests can advance focus of theirs embedders - https://bugs.webkit.org/show_bug.cgi?id=88827 - - Reviewed by Darin Fisher. - - A browser plugin needs to be able to tells its embedder when the guest - is done tabbing through controls and wants its embedder to advance its - tab position. - - * public/WebView.h: - (WebView): - (WebKit::WebView::advanceFocus): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::advanceFocus): - (WebKit): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-06-22 Jeff Timanus <twiz@chromium.org> - - [Chromium] Change implementing a fast-path for copying GPU-accelerated Canvas2D instances to WebGL textures. - https://bugs.webkit.org/show_bug.cgi?id=86275 - - This change adds the necessary plumbing to the various rendering contexts to copy the backing store texture of - a Canvas2D instance to be copied to a WebGL texture. The GL_CHROMIUM_copy_texture extension is necessary - because the backing-store for a GPU-accelerated skia Canvas2D is normally in BGRA format, which is not supported - by glCopyTexImage. - - Reviewed by Kenneth Russell. - - * DEPS: Rolled chromium to 143630 to fix chromium-linux ews failures. - -2012-06-22 Kenneth Russell <kbr@google.com> - - Unreviewed, rolling out r121025. - http://trac.webkit.org/changeset/121025 - https://bugs.webkit.org/show_bug.cgi?id=89580 - - Caused crash in - EventHandler.shouldTurnVerticalTicksIntoHorizontal webkit unit - test on 10.7 - - * WebKit.gypi: - * tests/EventHandlerTest.cpp: Removed. - -2012-06-22 Peter Beverloo <peter@chromium.org> - - [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android - https://bugs.webkit.org/show_bug.cgi?id=88853 - - Reviewed by Steve Block. - - The Android exclusions were necessary to fix a gyp generation error, as - the gcc_version variable wasn't being defined for Android. Remove these - exceptions when Chromium is able to define the gcc_version variable. - - * WebKit.gyp: - * WebKitUnitTests.gyp: - -2012-06-22 Robert Kroeger <rjkroege@chromium.org> - - Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true - https://bugs.webkit.org/show_bug.cgi?id=89580 - - WebKit GTK and Chromium Linux force vertical wheel events to - scroll horizontally when over horizontal scroll bars. This is - undesirable for touchpad scrolling with hasPreciseScrollingDeltas() == true. - - Added unit tests to show that - EventHandler::shouldTurnVerticalTicksIntoHorizontal() is true - only for PlatformWheelEvents when !hasPreciseScrollingDeltas(). - - Reviewed by Adam Barth. - - * WebKit.gypi: - * tests/EventHandlerTest.cpp: Added. - (MockScrollbar): - (MockScrollbar::MockScrollbar): - (MockScrollbar::~MockScrollbar): - (MockHitTestResult): - (MockHitTestResult::MockHitTestResult): - (MockHitTestResult::scrollbar): - (MockPlatformWheelEvent): - (MockPlatformWheelEvent::MockPlatformWheelEvent): - (EventHandlerTest): - (EventHandlerTest::EventHandlerTest): - (EventHandlerTest::externalShouldTurnVerticalTicksIntoHorizontal): - (TEST): - -2012-06-22 Amy Ousterhout <aousterh@chromium.org> - - Renamed DeviceOrientation to DeviceOrientationData - https://bugs.webkit.org/show_bug.cgi?id=88663 - - Reviewed by Steve Block. - - Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation. - This change makes DeviceOrientationData consistent with DeviceMotionData. - - * public/WebDeviceOrientation.h: - (WebDeviceOrientation): - * src/DeviceOrientationClientProxy.cpp: - (WebKit::DeviceOrientationClientProxy::lastOrientation): - * src/DeviceOrientationClientProxy.h: - (DeviceOrientationClientProxy): - * src/WebDeviceOrientation.cpp: - (WebKit::WebDeviceOrientation::WebDeviceOrientation): - (WebKit::WebDeviceOrientation::operator=): - (WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientationData>): - * src/WebDeviceOrientationController.cpp: - (WebKit::WebDeviceOrientationController::didChangeDeviceOrientation): - -2012-06-22 Joseph Pecoraro <pecoraro@apple.com> - - Web Inspector: InspectorState::updateCookie should not do JSON serialization if unsupported - https://bugs.webkit.org/show_bug.cgi?id=89743 - - The Chromium port does want InspectorState updates. - - Reviewed by Yury Semikhatsky. - - * src/InspectorClientImpl.h: - (WebKit::InspectorClientImpl::supportsInspectorStateUpdates): - * src/WebDevToolsAgentImpl.h: - (WebKit::WebDevToolsAgentImpl::supportsInspectorStateUpdates): - -2012-06-21 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120982. - http://trac.webkit.org/changeset/120982 - https://bugs.webkit.org/show_bug.cgi?id=89740 - - [chromium] ASSERTION FAILED: - m_allocatedTextureIds.contains(textureId) (Requested by ukai - on #webkit). - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest): - (WTF): - (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): - (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): - (WTF::CCLayerTreeHostTestManySurfaces::beginTest): - * tests/CCSchedulerStateMachineTest.cpp: - (WebCore::TEST): - * tests/CCTiledLayerTestCommon.h: - (WebKitTests::FakeTextureAllocator::createTexture): - (WebKitTests::FakeTextureAllocator::deleteTexture): - * tests/FakeWebGraphicsContext3D.h: - (WebKit::FakeWebGraphicsContext3D::createTexture): - (FakeWebGraphicsContext3D): - * tests/LayerRendererChromiumTest.cpp: - (TEST_F): - * tests/TiledLayerChromiumTest.cpp: - -2012-06-21 James Robinson <jamesr@chromium.org> - - [chromium] Initialize compositor's visibility state upon initialization - https://bugs.webkit.org/show_bug.cgi?id=89712 - - Reviewed by Adrienne Walker. - - A given WebViewImpl's visibility state might change any number of times before compositing is enabled. If the - visibility state is not the default (visible) when the compositor is initialized, we need to let it know the - correct visibility state or it will start ticking uselessly in threaded mode. - - Tested manually, there's no way to create a new WebViewImpl in a non-visible state in a WebKit test that I know - of. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - -2012-06-21 Sadrul Habib Chowdhury <sadrul@chromium.org> - - [chromium] Add touch-event support for WebPluginContainerImpl - https://bugs.webkit.org/show_bug.cgi?id=89089 - - Reviewed by Adam Barth. - - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::handleEvent): - * src/WebPluginContainerImpl.h: - (WebCore): - (WebPluginContainerImpl): - -2012-06-21 Oli Lan <olilan@chromium.org> - - Add methods to select between offsets in an editable field. - https://bugs.webkit.org/show_bug.cgi?id=89098 - - Reviewed by Ryosuke Niwa. - - Reviewed by Ryosuke Niwa. - - This adds a new method WebViewImpl::setEditableSelectionOffsets, which - can be used to select between two character positions in the node - currently beign edited. - - The offsets are assumed to be relative to the rootEditableElement. - - This can be used for IME features that require the ability to manipulate - the selection, for example on Android where the method InputConnection#setSelection - is used. - - This method calls a new method Editor::setSelectionOffsets. - - The method works for inputs/textareas (i.e. text form controls) and - contenteditable nodes, and the new test in WebViewTest tests both these cases. - - * public/WebView.h: - (WebView): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setEditableSelectionOffsets): - (WebKit): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/WebViewTest.cpp: - (WebKit::TEST_F): - (WebKit): - * tests/data/content_editable_populated.html: Added. - * tests/data/input_field_populated.html: Added. - -2012-06-19 James Robinson <jamesr@chromium.org> - - [chromium] LayerRendererChromium is not getting visibility messages in single threaded compositing mode. - https://bugs.webkit.org/show_bug.cgi?id=89045 - - Reviewed by Adrienne Walker. - - Based on patch by Michal Mocny <mmocny@google.com>. - - Update various test fixtures and tests to cover scheduling, visibility, and resource allocation changes. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (CCLayerTreeHostTestAbortFrameWhenInvisible): - (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::CCLayerTreeHostTestAbortFrameWhenInvisible): - (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::beginTest): - (WTF::CCLayerTreeHostTestAbortFrameWhenInvisible::afterTest): - (WTF): - (WTF::TEST_F): - (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): - (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): - (WTF::CCLayerTreeHostTestManySurfaces::beginTest): - * tests/CCSchedulerStateMachineTest.cpp: - (WebCore::TEST): - * tests/CCTiledLayerTestCommon.h: - * tests/FakeWebGraphicsContext3D.h: - (WebKit::FakeWebGraphicsContext3D::FakeWebGraphicsContext3D): - (FakeWebGraphicsContext3D): - (WebKit::FakeWebGraphicsContext3D::createTexture): - * tests/LayerRendererChromiumTest.cpp: - (TEST_F): - * tests/TiledLayerChromiumTest.cpp: - - -2012-06-21 Mike West <mkwst@chromium.org> - - [Chromium] Enable CSP_NEXT on the Chromium port. - https://bugs.webkit.org/show_bug.cgi?id=89683 - - Reviewed by Adam Barth. - - Enable CSP 1.1 on the Chromium port. This has zero practical effect, - as no CSP 1.1 patches have landed yet. But it will. Oh it will. - - * features.gypi: ENABLE_CSP_NEXT=1 - -2012-06-21 Alec Flett <alecflett@chromium.org> - - IndexedDB: Implement spec behavior for multiEntry indexes with invalid/duplicate subkeys - https://bugs.webkit.org/show_bug.cgi?id=86123 - - Reviewed by Darin Fisher. - - Add matching isValid() to WebIDBKey to match the one in IDBKey. - - * public/WebIDBKey.h: - * src/WebIDBKey.cpp: - (WebKit::WebIDBKey::isValid): - (WebKit): - * src/WebIDBKeyRange.cpp: - (WebKit::WebIDBKeyRange::assign): - -2012-06-21 Ian Vollick <vollick@chromium.org> - - [chromium] Overlays when using the web inspector are blurry with device scale factor > 1 - https://bugs.webkit.org/show_bug.cgi?id=89676 - - Reviewed by James Robinson. - - Whenever we construct a GraphicsLayerChromium, make initialize the - device and page scale factors, if possible. - - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::TEST_F): - (WebKitTests): - -2012-06-21 Min Qin <qinmin@chromium.org> - - remove ENABLE_FULLSCREEN_MEDIA_CONTROL flag - https://bugs.webkit.org/show_bug.cgi?id=89614 - - Reviewed by Eric Carlson. - - Since desktop chrome now has fullscreen button, we don't need this flag anymore - - * features.gypi: - -2012-06-20 Zeev Lieber <zlieber@chromium.org> - - [Chromium] Damage tracker is not used without partial swap, causing valid render passes to be removed - https://bugs.webkit.org/show_bug.cgi?id=89589 - - Reviewed by Adrienne Walker. - - Added unit tests to check surface texture caching when partial - swap is not used. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-20 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120889. - http://trac.webkit.org/changeset/120889 - https://bugs.webkit.org/show_bug.cgi?id=89630 - - [Chromium] webkit_unit_tests didDrawNotCalledOnHiddenLayer - start failing (Requested by ukai on #webkit). - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-20 Zeev Lieber <zlieber@chromium.org> - - [Chromium] Damage tracker is not used without partial swap, causing valid render passes to be removed - https://bugs.webkit.org/show_bug.cgi?id=89589 - - Reviewed by Adrienne Walker. - - Added unit tests to check surface texture caching when partial - swap is not used. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-20 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Remove redundant IDBObjectStore.delete() overloads - https://bugs.webkit.org/show_bug.cgi?id=89587 - - Reviewed by Darin Fisher. - - * public/WebIDBObjectStore.h: Add note to remove overload when Chromium is updated. - (WebIDBObjectStore): - * src/IDBObjectStoreBackendProxy.cpp: Delete IDBKey overload. - * src/IDBObjectStoreBackendProxy.h: Delete IDBKey overload. - (IDBObjectStoreBackendProxy): - * src/WebIDBObjectStoreImpl.cpp: Delete IDBKey overload. - * src/WebIDBObjectStoreImpl.h: Delete IDBKey overload. - (WebIDBObjectStoreImpl): - -2012-06-20 Garret Kelly <gdk@chromium.org> - - Moving cookieEnabled/setCookieEnabled from Page to Settings, and - exposing through WebSettings. - https://bugs.webkit.org/show_bug.cgi?id=89545 - - Reviewed by Adam Barth. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setCookieEnabled): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-06-20 Raymes Khoury <raymes@chromium.org> - - Perform hit-test from correct frame in isRectTopmost() - https://bugs.webkit.org/show_bug.cgi?id=89492 - - Reviewed by Levi Weintraub. - - Hit-testing was being performed from the main frame, which gave the - incorrect result if the plugin was in a different frame. - - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::isRectTopmost): - -2012-06-20 Alexandre Elias <aelias@google.com> - - [chromium] Support mobile device rotation resizing - https://bugs.webkit.org/show_bug.cgi?id=86819 - - Reviewed by Adam Barth. - - Resizes on a mobile device are caused either by rotation or - on-screen-keyboard bringup, and need different treatment to remain - naturally laid out, scaled and scrolled without disorienting the user. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::resize): - -2012-06-19 James Robinson <jamesr@chromium.org> - - [chromium] Separate LayerRenderer initialization from updateLayers - https://bugs.webkit.org/show_bug.cgi?id=89525 - - Reviewed by Adrienne Walker. - - Update tests to call initializeLayerRendererIfNeeded() before calling updateLayers() to reflect what the proxies - do. - - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): - (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): - (WTF::CCLayerTreeHostTestManySurfaces::beginTest): - * tests/TiledLayerChromiumTest.cpp: - -2012-06-20 Christopher Cameron <ccameron@chromium.org> - - [chromium] webkit-backface-visibility doesn't work with video - https://bugs.webkit.org/show_bug.cgi?id=88908 - - When determining a contents layer's backface culling, use the parent - layer's transform and backface-visibility properties. Track which - layers need this special treatment with useParentBackfaceVisibility - and setUseParentBackfaceVisibility functions in WebCore::LayerChromium, - WebKit::WebLayer, and WebCore::CCLayerImpl. - - Reviewed by Adrienne Walker. - - * src/WebLayer.cpp: - (WebKit::WebLayer::setUseParentBackfaceVisibility): - Add an accessor to specify that a layer should use its parent's - backface culling behavior. - -2012-06-20 Ian Vollick <vollick@chromium.org> - - [chromium] Make sure that render surfaces are not pixel doubled with a device scale factor of 2 - https://bugs.webkit.org/show_bug.cgi?id=86882 - - Reviewed by Adrienne Walker. - - To ensure that render surfaces are not pixel doubled when device scale factor is - two, the render surface's owning layer's draw transform is scaled by the - contents scale (in the same way that the parent matrix is scaled by the device - scale factor). The transformedLayerRect's dimensions also need to be in pixel - space. The surface origin transform should not scale, but needs to offset the - correct number of pixels, and the replica transforms need to be modified to - account for the scaling. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-06-20 Joshua Bell <jsbell@chromium.org> - - Unreviewed build fix. - - * tests/IDBDatabaseBackendTest.cpp: - (WebCore::MockIDBCallbacks::~MockIDBCallbacks): - (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks): - -2012-06-20 Joshua Bell <jsbell@chromium.org> - - [Chromium] IndexedDB: Don't close database if pending connections are in flight - https://bugs.webkit.org/show_bug.cgi?id=89512 - - Reviewed by Tony Chang. - - * tests/IDBDatabaseBackendTest.cpp: - (MockIDBCallbacks): - (WebCore::MockIDBCallbacks::create): - (WebCore::MockIDBCallbacks::MockIDBCallbacks): - (WebCore): - (FakeIDBDatabaseCallbacks): - (WebCore::FakeIDBDatabaseCallbacks::create): - (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks): - (WebCore::TEST): - -2012-06-20 Zeev Lieber <zlieber@chromium.org> - - [Chromium] Remove redundant #includes in compositor - https://bugs.webkit.org/show_bug.cgi?id=89503 - - Reviewed by Adrienne Walker. - - Minor adjustments to #include statements to remove - dependencies. No new tests. - - * src/WebCompositorImpl.cpp: - * src/WebLayerTreeView.cpp: - * tests/CCLayerTestCommon.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/CCTiledLayerImplTest.cpp: - * tests/ImageLayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-06-20 Hans Wennborg <hans@chromium.org> - - Speech JavaScript API: add SpeechRecognition.maxAlternatives attribute - https://bugs.webkit.org/show_bug.cgi?id=89459 - - Reviewed by Eric Seidel. - - Plumbing for the maxAlternatives attribute. - - * public/WebSpeechRecognitionParams.h: - (WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams): - (WebKit::WebSpeechRecognitionParams::maxAlternatives): - (WebSpeechRecognitionParams): - * src/SpeechRecognitionClientProxy.cpp: - (WebKit::SpeechRecognitionClientProxy::start): - * src/SpeechRecognitionClientProxy.h: - (SpeechRecognitionClientProxy): - -2012-06-20 Hironori Bono <hbono@chromium.org> - - [chromium] Select the marker range when right-clicking on a marker. - https://bugs.webkit.org/show_bug.cgi?id=89331 - - Reviewed by Hajime Morita. - - Chromium always selects only one word when right-clicking on a spelling marker. - This prevents selecting whole region specified by a marker if the marker - consists of two or more words. This change retrieves a range coverted by a - marker and select the range. This emulates the behavior of Mac Chromium and it - does not need any workarounds for Mac. - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): - -2012-06-19 Kenneth Russell <kbr@google.com> - - Unreviewed, rolling out r120772. - http://trac.webkit.org/changeset/120772 - https://bugs.webkit.org/show_bug.cgi?id=89503 - - Broke build on Chromium Mac - - * src/WebCompositorImpl.cpp: - * src/WebLayerTreeView.cpp: - * tests/CCLayerTestCommon.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/CCTiledLayerImplTest.cpp: - * tests/ImageLayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-06-19 Zeev Lieber <zlieber@chromium.org> - - [Chromium] Remove redundant #includes in compositor - https://bugs.webkit.org/show_bug.cgi?id=89503 - - Reviewed by Adrienne Walker. - - Minor adjustments to #include statements to remove - dependencies. No new tests. - - * src/WebCompositorImpl.cpp: - * src/WebLayerTreeView.cpp: - * tests/CCLayerTestCommon.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - * tests/CCQuadCullerTest.cpp: - * tests/CCTiledLayerImplTest.cpp: - * tests/ImageLayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - -2012-06-19 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Add new type (and chromium webkit API) for metadata snapshot - https://bugs.webkit.org/show_bug.cgi?id=88678 - - Reviewed by Darin Fisher. - - * WebKit.gyp: - * public/WebIDBDatabase.h: - (WebKit::WebIDBDatabase::metadata): - * public/WebIDBKeyPath.h: - (WebIDBKeyPath): - (WebKit::WebIDBKeyPath::WebIDBKeyPath): - (WebKit::WebIDBKeyPath::~WebIDBKeyPath): - (WebKit::WebIDBKeyPath::operator=): Used by Chromium backend. - * public/WebIDBMetadata.h: Added new type. - (WebKit): - (WebIDBMetadata): - (WebKit::WebIDBMetadata::WebIDBMetadata): - (ObjectStore): - (WebKit::WebIDBMetadata::ObjectStore::ObjectStore): - (Index): - (WebKit::WebIDBMetadata::Index::Index): - * src/WebIDBKeyPath.cpp: Conform to normal WebXXX patern. - (WebKit::WebIDBKeyPath::assign): - (WebKit): - (WebKit::WebIDBKeyPath::reset): - -2012-06-19 Amy Ousterhout <aousterh@chromium.org> - - [Chromium] Style Fix in WebDeviceOrientationController - https://bugs.webkit.org/show_bug.cgi?id=89337 - - Reviewed by Steve Block. - - Changing a local variable from a PassRefPtr to a RefPtr in order to be consistent with the style guide. - - * src/WebDeviceOrientationController.cpp: - (WebKit::WebDeviceOrientationController::didChangeDeviceOrientation): - -2012-06-19 Peter Wang <peter.wang@torchmobile.com.cn> - - Remove the function ScriptDebugServer::supportsNativeBreakpoints() - https://bugs.webkit.org/show_bug.cgi?id=88759 - - Reviewed by Pavel Feldman. - - * src/js/DevTools.js: - -2012-06-19 Yury Semikhatsky <yurys@chromium.org> - - [Chromium] Web Inspector: remove unnecessary indirection from message loop instrumentation - https://bugs.webkit.org/show_bug.cgi?id=89443 - - Removed start/stopMainThreadMonitoring methods from WebDevToolsAgentClient - and WebDevToolsAgentImpl. The functionality is now implemented inside - InspectorClientImpl. - - Reviewed by Vsevolod Vlasov. - - * public/WebDevToolsAgentClient.h: - * src/InspectorClientImpl.cpp: - (WebKit::InspectorClientImpl::clearBrowserCookies): - (WebKit::InspectorClientImpl::startMainThreadMonitoring): - (WebKit::InspectorClientImpl::stopMainThreadMonitoring): - (WebKit::InspectorClientImpl::willProcessTask): - (WebKit): - (WebKit::InspectorClientImpl::didProcessTask): - * src/InspectorClientImpl.h: - (InspectorClientImpl): - * src/WebDevToolsAgentImpl.cpp: - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - -2012-06-19 Mike West <mkwst@chromium.org> - - Introduce ENABLE_CSP_NEXT configuration flag. - https://bugs.webkit.org/show_bug.cgi?id=89300 - - Reviewed by Adam Barth. - - The 1.0 draft of the Content Security Policy spec is just about to - move to Last Call. We'll hide work on the upcoming 1.1 spec behind - this ENABLE flag, disabled by default. - - Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html - - * features.gypi: - -2012-06-19 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120586. - http://trac.webkit.org/changeset/120586 - https://bugs.webkit.org/show_bug.cgi?id=89444 - - doesn't fix mac issue (Requested by morrita on #webkit). - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::replaceMisspelledRange): - -2012-06-19 Mike West <mkwst@chromium.org> - - Add a scheme registry for bypassing Content Security Policy. - https://bugs.webkit.org/show_bug.cgi?id=89373 - - Reviewed by Adam Barth. - - * public/WebSecurityPolicy.h: - (WebSecurityPolicy): - * src/WebSecurityPolicy.cpp: - (WebKit::WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy): - (WebKit): - -2012-06-18 Adam Barth <abarth@webkit.org> - - [Chromium] GesturePinchBegin and friends are gesture events - https://bugs.webkit.org/show_bug.cgi?id=89398 - - Reviewed by James Robinson. - - * public/WebInputEvent.h: - (WebKit::WebInputEvent::isGestureEventType): - -2012-06-18 Amy Ousterhout <aousterh@chromium.org> - - [Chromium] DeviceOrientation Cleanup - https://bugs.webkit.org/show_bug.cgi?id=89354 - - Reviewed by Kent Tamura. - - * public/WebDeviceOrientation.h: added const-qualifiers to getters, simplified an overly-complicated parameter to two functions - (WebKit::WebDeviceOrientation::isNull): - (WebKit::WebDeviceOrientation::canProvideAlpha): - (WebKit::WebDeviceOrientation::alpha): - (WebKit::WebDeviceOrientation::canProvideBeta): - (WebKit::WebDeviceOrientation::beta): - (WebKit::WebDeviceOrientation::canProvideGamma): - (WebKit::WebDeviceOrientation::gamma): - (WebKit::WebDeviceOrientation::canProvideAbsolute): - (WebKit::WebDeviceOrientation::absolute): - (WebDeviceOrientation): - * public/WebDeviceOrientationClient.h: added WEBKIT_ASSERT_NOT_REACHED to virtual functions - (WebKit::WebDeviceOrientationClient::setController): - (WebKit::WebDeviceOrientationClient::startUpdating): - (WebKit::WebDeviceOrientationClient::stopUpdating): - (WebKit::WebDeviceOrientationClient::lastOrientation): - * public/WebDeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions - (WebDeviceOrientationClientMock): - * src/DeviceOrientationClientProxy.h: designated functions as 'virtual' and added OVERRIDE specifier - (DeviceOrientationClientProxy): - * src/WebDeviceOrientation.cpp: simplified overly-complicated parameter to two functions - (WebKit::WebDeviceOrientation::WebDeviceOrientation): - (WebKit::WebDeviceOrientation::operator=): - -2012-06-18 Ami Fischman <fischman@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-14 James Robinson <jamesr@chromium.org> - - [chromium] Use WebImageLayer in GraphicsLayerChromium for image layers - https://bugs.webkit.org/show_bug.cgi?id=89150 - - Reviewed by Adrienne Walker. - - Implementation of WebImageLayer. Note: This could (should?) live in WebCore/platform/chromium/support/, but it's - here to be next to the other Web*Layer.cpp implementation files. - - * WebKit.gyp: - * src/WebImageLayer.cpp: Added. - (WebKit): - (WebKit::WebImageLayer::create): - (WebKit::WebImageLayer::WebImageLayer): - (WebKit::WebImageLayer::setBitmap): - -2012-06-14 James Robinson <jamesr@chromium.org> - - [chromium] GraphicsLayerChromium should use WebContentLayer directly - https://bugs.webkit.org/show_bug.cgi?id=89145 - - Reviewed by Adrienne Walker. - - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::paintContents): - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTestMainThreadTypes::createLayer): - * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: - (WebCore): - (WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest): - (WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect): - (WebCore::TEST_F): - * tests/WebLayerTest.cpp: - -2012-06-18 Ilya Sherman <isherman@chromium.org> - - [Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox() - Also update existing code to use updateLayoutIgnorePendingStylesheets() - https://bugs.webkit.org/show_bug.cgi?id=89258 - - Reviewed by James Robinson. - - * src/WebNode.cpp: - (WebKit::WebNode::isFocusable): Use updateLayoutIgnorePendingStylesheets() - (WebKit::WebNode::hasNonEmptyBoundingBox): Force layout before checking the bounding box - -2012-06-18 Ian Vollick <vollick@chromium.org> - - [chromium] Ensure that skipping frames during an accelerated animation doesn't cause starvation - https://bugs.webkit.org/show_bug.cgi?id=87766 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostTest.cpp: - (WTF): - (CCLayerTreeHostTestCheckerboardDoesNotStarveDraws): - (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws): - (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::beginTest): - (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::afterTest): - (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::animateLayers): - (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::drawLayersOnCCThread): - (WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::prepareToDrawOnCCThread): - (WTF::TEST_F): - * tests/CCSchedulerStateMachineTest.cpp: - (WebCore::TEST): - (WebCore): - * tests/CCThreadedTest.cpp: - (WebKitTests::MockLayerTreeHostImpl::prepareToDraw): - * tests/CCThreadedTest.h: - (WebKitTests::TestHooks::prepareToDrawOnCCThread): - -2012-06-18 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android - https://bugs.webkit.org/show_bug.cgi?id=89228 - - Reviewed by Tony Chang. - - * WebKit.gyp: - * public/linux/WebFontRendering.h: - (WebKit): - (WebFontRendering): - * public/linuxish/WebFontRendering.h: Removed. - * src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. - (WebKit): - (WebKit::WebFontRendering::setHinting): - (WebKit::WebFontRendering::setAutoHint): - (WebKit::WebFontRendering::setUseBitmaps): - (WebKit::WebFontRendering::setAntiAlias): - (WebKit::WebFontRendering::setSubpixelRendering): - (WebKit::WebFontRendering::setSubpixelPositioning): - (WebKit::WebFontRendering::setLCDOrder): - (WebKit::WebFontRendering::setLCDOrientation): - -2012-06-18 Hironori Bono <hbono@chromium.org> - - [chromium] Spellchecker should show suggestions only when right-clicking a misspelled word. - https://bugs.webkit.org/show_bug.cgi?id=89331 - - Reviewed by Hajime Morita. - - When a selection includes two or more misspelled words, it is not so easy to - select one word from them and to show its suggestions. To avoid this problem, - this change shows suggestions only when the selection is collapsed. For this - case, we can use Range::setStart and setEnd to convert a DocumentMarker to a - Range. - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a check that the selection is collapsed. - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::replaceMisspelledRange): Added a check that the selection is collapsed. Also, use Range::setStart() and Range::setEnd() to get the marker range to emulate the behavior of DocumentMarker::markersInRange(). - -2012-06-14 Kinuko Yasuda <kinuko@chromium.org> - - [chromium] Cleanup: remove PlatformSupport::createAsyncFileSystem as it's no longer used - https://bugs.webkit.org/show_bug.cgi?id=89083 - - Reviewed by Kentaro Hara. - - * src/PlatformSupport.cpp: - -2012-06-15 Kinuko Yasuda <kinuko@chromium.org> - - XHR_RESPONSE_BLOB is not enabled on some platforms - https://bugs.webkit.org/show_bug.cgi?id=88859 - - Reviewed by Adam Barth. - - Removing XHR_RESPONSE_BLOB since the current implementation has - no platform-specific part. - - * src/PlatformSupport.cpp: - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enableXHRResponseBlob): - (WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled): - -2012-06-17 MORITA Hajime <morrita@google.com> - - Unreviewed build fix. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-17 Zeev Lieber <zlieber@chromium.org> - - [Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged - https://bugs.webkit.org/show_bug.cgi?id=88482 - - Reviewed by Adrienne Walker. - - Added tests to verify quad removal algorithm. Added infrastructure - code to generate custom render passes out of a script encoded as C - string. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCLayerImplTest.cpp: - (WebCore): - (WebCore::TEST): - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-16 Robert Kroeger <rjkroege@chromium.org> - - [chromium] Make the deviceScaleFactor dynamically adjustable. - https://bugs.webkit.org/show_bug.cgi?id=88916 - - Reviewed by James Robinson. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCSettings): Removed unused - static deviceScaleFactor. - (WebKit::WebLayerTreeView::setDeviceScaleFactor): - (WebKit): - (WebKit::WebLayerTreeView::deviceScaleFactor): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setDeviceScaleFactor): Push the dynamic deviceScaleFactor - to the compositor as required. - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - * tests/CCLayerTreeHostTest.cpp: Tests use dynamic setDeviceScaleFactor. - (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers): - (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest): - (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread): - -2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120536. - http://trac.webkit.org/changeset/120536 - https://bugs.webkit.org/show_bug.cgi?id=89296 - - Does not compile on chromium-linux (Requested by abarth on - #webkit). - - * WebKit.gyp: - * public/linux/WebFontRendering.h: - * public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h. - (WebKit): - (WebFontRendering): - * src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp. - (WebKit): - (WebKit::WebFontRendering::setHinting): - (WebKit::WebFontRendering::setAutoHint): - (WebKit::WebFontRendering::setUseBitmaps): - (WebKit::WebFontRendering::setAntiAlias): - (WebKit::WebFontRendering::setSubpixelRendering): - (WebKit::WebFontRendering::setSubpixelPositioning): - (WebKit::WebFontRendering::setLCDOrder): - (WebKit::WebFontRendering::setLCDOrientation): - -2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120539. - http://trac.webkit.org/changeset/120539 - https://bugs.webkit.org/show_bug.cgi?id=89295 - - Does not compile on chromium-mac (Requested by abarth on - #webkit). - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCLayerImplTest.cpp: - (WebCore): - (WebCore::TEST): - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-16 Zeev Lieber <zlieber@chromium.org> - - [Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged - https://bugs.webkit.org/show_bug.cgi?id=88482 - - Reviewed by Adrienne Walker. - - Added tests to verify quad removal algorithm. Added infrastructure - code to generate custom render passes out of a script - encoded as C string. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - * tests/CCLayerImplTest.cpp: - (WebCore): - (WebCore::TEST): - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-16 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory - https://bugs.webkit.org/show_bug.cgi?id=89228 - - Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering - so that WebKit::WebFontRendering can be platform-independent. - - This also avoids the ambiguous name 'linuxish'. - - Reviewed by Tony Chang. - - * WebKit.gyp: - * public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION. - (WebFontRendering): - * public/linux/WebFontRendering.h: - * public/linuxish: Removed. - * public/linuxish/WebFontRendering.h: Removed. - * src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters. - (WebKit): - (WebKit::WebFontRendering::setHinting): - (WebKit::WebFontRendering::hinting): - (WebKit::WebFontRendering::setAutoHint): - (WebKit::WebFontRendering::autoHint): - (WebKit::WebFontRendering::setUseBitmaps): - (WebKit::WebFontRendering::useBitmaps): - (WebKit::WebFontRendering::setAntiAlias): - (WebKit::WebFontRendering::antiAlias): - (WebKit::WebFontRendering::setSubpixelRendering): - (WebKit::WebFontRendering::subpixelRendering): - (WebKit::WebFontRendering::setSubpixelPositioning): - (WebKit::WebFontRendering::subpixelPositioning): - * src/linuxish: Removed. - * src/linuxish/WebFontRendering.cpp: Removed. - -2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-16 Dan Alcantara <dfalcantara@chromium.org> - - [chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument - https://bugs.webkit.org/show_bug.cgi?id=89233 - - Reviewed by Darin Fisher. - - Adds a WebFrame* to the WebFrameClient::userAgentOverride() function. - - * public/WebFrameClient.h: - (WebKit::WebFrameClient::userAgentOverride): - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::userAgent): - * tests/FrameLoaderClientImplTest.cpp: - -2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120511. - http://trac.webkit.org/changeset/120511 - https://bugs.webkit.org/show_bug.cgi?id=89255 - - Breaks at least Android builder (Requested by wangxianzhu on - #webkit). - - * WebKit.gyp: - * public/linux/WebFontRendering.h: - * public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h. - (WebKit): - (WebFontRendering): - * src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp. - (WebKit): - (WebKit::WebFontRendering::setHinting): - (WebKit::WebFontRendering::setAutoHint): - (WebKit::WebFontRendering::setUseBitmaps): - (WebKit::WebFontRendering::setAntiAlias): - (WebKit::WebFontRendering::setSubpixelRendering): - (WebKit::WebFontRendering::setSubpixelPositioning): - (WebKit::WebFontRendering::setLCDOrder): - (WebKit::WebFontRendering::setLCDOrientation): - -2012-06-15 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory - https://bugs.webkit.org/show_bug.cgi?id=89228 - - Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering - so that WebKit::WebFontRendering can be platform-independent. - - This also avoids the ambiguous name 'linuxish'. - - Reviewed by Tony Chang. - - * WebKit.gyp: - * public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION. - (WebFontRendering): - * public/linux/WebFontRendering.h: - * public/linuxish: Removed. - * public/linuxish/WebFontRendering.h: Removed. - * src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters. - (WebKit): - (WebKit::WebFontRendering::setHinting): - (WebKit::WebFontRendering::hinting): - (WebKit::WebFontRendering::setAutoHint): - (WebKit::WebFontRendering::autoHint): - (WebKit::WebFontRendering::setUseBitmaps): - (WebKit::WebFontRendering::useBitmaps): - (WebKit::WebFontRendering::setAntiAlias): - (WebKit::WebFontRendering::antiAlias): - (WebKit::WebFontRendering::setSubpixelRendering): - (WebKit::WebFontRendering::subpixelRendering): - (WebKit::WebFontRendering::setSubpixelPositioning): - (WebKit::WebFontRendering::subpixelPositioning): - * src/linuxish: Removed. - * src/linuxish/WebFontRendering.cpp: Removed. - -2012-06-15 Tony Chang <tony@chromium.org> - - [chromium] Remove WebKit/chromium/public/gtk/WebFontInfo.h since it's no longer referenced. - https://bugs.webkit.org/show_bug.cgi?id=89251 - - Reviewed by Adam Barth. - - This was a forwarding header when we moved the file to public/linux. - - * public/gtk/WebFontInfo.h: Removed. - -2012-06-15 Bill Budge <bbudge@chromium.org> - - AssociatedURLLoader should allow trusted clients to read all headers, not just exposed ones. - https://bugs.webkit.org/show_bug.cgi?id=89185 - - Reviewed by Adam Barth. - - This change adds an option to turn off whitelist filtering of response headers for CORS loads, - and modifies AssociatedURLLoader check for that before filtering. - - * public/WebURLLoaderOptions.h: - (WebKit::WebURLLoaderOptions::WebURLLoaderOptions): - (WebURLLoaderOptions): - * src/AssociatedURLLoader.cpp: - (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): - * tests/AssociatedURLLoaderTest.cpp: - (WebKit): - (WebKit::TEST_F): - -2012-06-15 Sami Kyostila <skyostil@chromium.org> - - [chromium] Allow scrolling non-root layers in the compositor thread - https://bugs.webkit.org/show_bug.cgi?id=73350 - - Reviewed by James Robinson. - - New unit tests to verify layer scrolling behavior and the associated - utility functions. - - * src/WebCompositorInputHandlerImpl.cpp: - (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal): - (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::MockContentLayerDelegate::paintContents): - (CCLayerTreeHostTestScrollChildLayer): - (WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer): - (WTF::CCLayerTreeHostTestScrollChildLayer::beginTest): - (WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale): - (WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread): - (WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread): - (WTF::CCLayerTreeHostTestScrollChildLayer::afterTest): - (WTF): - (WTF::TEST_F): - * tests/WebCompositorInputHandlerImplTest.cpp: - (WebKit::TEST_F): - -2012-06-15 Hironori Bono <hbono@chromium.org> - - Allow platforms to choose whether to remove markers on editing - https://bugs.webkit.org/show_bug.cgi?id=88838 - - Reviewed by Hajime Morita. - - This change implements EditorClientImpl::checkGrammarOfString so - DumpRenderTree can run grammar tests. - - * src/EditorClientImpl.cpp: - (WebKit::EditorClientImpl::isGrammarCheckingEnabled): Return true also when unified text-checking is enabled. - (WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection): ditto. - (WebKit::EditorClientImpl::checkGrammarOfString): Implement this function with our unified text-checker. - -2012-06-14 Kent Tamura <tkent@chromium.org> - - Support file extensions in HTMLInputElement::accept - https://bugs.webkit.org/show_bug.cgi?id=88298 - - Reviewed by Hajime Morita. - - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::runOpenPanel): - Use FileChooserSettings::acceptTypes() to get both of MIME types and file extensions. - -2012-06-14 Kaustubh Atrawalkar <kaustubh@motorola.com> - - Remove support for counterValueForElementById from chromium port - https://bugs.webkit.org/show_bug.cgi?id=88851 - - Reviewed by Adam Barth. - - Moved the counterValueForElementById from LayoutTestCotroller to Internals so - remove the old platform specific implementations as it exclusively tests WebCore functionality. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit): - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-06-14 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium-Android] Initialize font rendering in DumpRenderTree - https://bugs.webkit.org/show_bug.cgi?id=89133 - - Reviewed by Adam Barth. - - * src/linuxish/WebFontRendering.cpp: - (WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites. - -2012-06-14 Tony Chang <tony@chromium.org> - - [chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=89132 - - Reviewed by Adam Barth. - - This test is currently in src/webkit/glue/iframe_redirect_unittest.cc - and uses test_shell's layoutTestController. Moving this will make - it easier to get rid of layoutTestController in test_shell. - - * tests/WebFrameTest.cpp: - (WebKit::TEST_F): - (WebKit): - * tests/data/iframe_redirect.html: Added. - -2012-06-14 David Reveman <reveman@chromium.org> - - [Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background. - https://bugs.webkit.org/show_bug.cgi?id=89033 - - Reviewed by James Robinson. - - Add canvas background argument to PageWidgetDelegate::paint and call - PlatformCanvasSkia::setDrawingToImageBuffer to ensure that sub-pixel - rendering is only used when WebView has opaque background. - - * src/PageWidgetDelegate.cpp: - (WebKit::PageWidgetDelegate::paint): - * src/PageWidgetDelegate.h: - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::paint): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::paint): - -2012-06-14 Shawn Singh <shawnsingh@chromium.org> - - [chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug - https://bugs.webkit.org/show_bug.cgi?id=89065 - - Reviewed by James Robinson. - - A debug assertion was being triggered in the hit-testing unit - tests because I accidentally forgot to set the - DebugScopedSetImplThread for the tests. - - This patch also re-enables the disabled broken test. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-06-14 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering - https://bugs.webkit.org/show_bug.cgi?id=89014 - - Reviewed by James Robinson. - - * public/linuxish/WebFontRendering.h: - (WebFontRendering): - * src/linuxish/WebFontRendering.cpp: - (WebKit): - (WebKit::WebFontRendering::setAutoHint): - (WebKit::WebFontRendering::setUseBitmaps): - (WebKit::WebFontRendering::setAntiAlias): - -2012-06-14 Daniel Erat <derat@chromium.org> - - [chromium/linux] Drop deprecated WebFontRenderStyle::useSubpixel - https://bugs.webkit.org/show_bug.cgi?id=88263 - - Reviewed by Adam Barth. - - This removes the useSubpixel member, which was replaced by - useSubpixelRendering. Chrome has been updated to set only the - useSubpixelRendering field. - - No test updates since the existing behavior shouldn't change. - - * public/linux/WebFontInfo.h: - (WebFontInfo): - * public/linux/WebFontRenderStyle.h: - * src/linux/WebFontInfo.cpp: - (WebKit::WebFontInfo::renderStyleForStrike): - * src/linux/WebFontRenderStyle.cpp: - (WebKit::WebFontRenderStyle::toFontRenderStyle): - (WebKit::WebFontRenderStyle::setDefaults): - -2012-06-14 Shawn Singh <shawnsingh@chromium.org> - - [chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it. - https://bugs.webkit.org/show_bug.cgi?id=89049 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-06-14 Ian Vollick <vollick@chromium.org> - - [chromium] Certain settings in CCSettings could be global - https://bugs.webkit.org/show_bug.cgi?id=88384 - - Reviewed by James Robinson. - - * WebKit.gypi: - * public/WebCompositor.h: - (WebCompositor): - * public/WebSettings.h: - * src/WebCompositorImpl.cpp: - (WebKit::WebCompositor::shutdown): - (WebKit): - (WebKit::WebCompositor::setPerTilePaintingEnabled): - (WebKit::WebCompositor::setPartialSwapEnabled): - (WebKit::WebCompositor::setAcceleratedAnimationEnabled): - * src/WebLayerTreeView.cpp: - (WebKit): - (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): - * src/WebSettingsImpl.cpp: - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF): - (CCLayerTreeHostTestShortlived1): - (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): - (WTF::CCLayerTreeHostTestShortlived1::beginTest): - (WTF::CCLayerTreeHostTestShortlived1::afterTest): - * tests/CCTestCommon.h: Added. - (WebKitTests): - (CCScopedSettings): - (WebKitTests::CCScopedSettings::CCScopedSettings): - (WebKitTests::CCScopedSettings::~CCScopedSettings): - * tests/CCThreadedTest.cpp: - (WebKitTests::MockLayerTreeHostImpl::create): - (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (WebKitTests::CCThreadedTest::runTest): - * tests/CCThreadedTest.h: - (CCThreadedTest): - (MockLayerTreeHostImpl): - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - * tests/LayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (LayerRendererChromiumTest): - (TEST_F): - (TEST): - * tests/TextureLayerChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - * tests/TreeSynchronizerTest.cpp: - (WebKitTests::TEST): - -2012-06-14 James Robinson <jamesr@chromium.org> - - [chromium] Move opaque rectangle tracking logic out of compositor core - https://bugs.webkit.org/show_bug.cgi?id=89031 - - Reviewed by Adrienne Walker. - - Moves the grayscale/subpixel AA text decision into NonCompositedContentHost and removes one layer of indirection - betwen NCCH and WVI that existed only for historical reasons. - - Ports the opaque rect tracking tests that were in LayerTextureUpdaterTest to - OpaquerectTrackingContentLayerDelegateTest to reflect the move in responsibilities. - - * WebKit.gypi: - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::NonCompositedContentHost): - (WebKit::NonCompositedContentHost::setOpaque): - (WebKit::NonCompositedContentHost::paintContents): - * src/NonCompositedContentHost.h: - (WebCore): - (WebKit): - (WebKit::NonCompositedContentHost::create): - (NonCompositedContentHost): - * src/WebContentLayerImpl.cpp: - (WebKit::WebContentLayerImpl::paintContents): - * src/WebContentLayerImpl.h: - (WebContentLayerImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::paintRootLayer): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/CCLayerTreeHostTest.cpp: - (WTF::TestOpacityChangeLayerDelegate::paintContents): - (WTF::MockContentLayerDelegate::paintContents): - * tests/LayerChromiumTest.cpp: - * tests/LayerTextureUpdaterTest.cpp: Removed. - * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: Added. - (WebCore): - (PaintCallback): - (TestLayerPainterChromium): - (WebCore::TestLayerPainterChromium::TestLayerPainterChromium): - (WebCore::PaintFillAlpha::operator()): - (WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque): - (PaintFillPartialOpaque): - (WebCore::PaintFillPartialOpaque::operator()): - (OpaqueRectTrackingContentLayerDelegateTest): - (WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest): - (WebCore::OpaqueRectTrackingContentLayerDelegateTest::skCanvas): - (WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect): - (WebCore::TEST_F): - -2012-06-14 Justin Novosad <junov@chromium.org> - - [Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw - https://bugs.webkit.org/show_bug.cgi?id=89018 - - Reviewed by Stephen White. - - Rolling chromium DEPS to 141884 - - * DEPS: - -2012-06-14 Alexander Pavlov <apavlov@chromium.org> - - [Chromium] Unreviewed, build fix for Mac 10.5 - - * src/WebDevToolsAgentImpl.cpp: - (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): - -2012-06-14 Eugene Klyuchnikov <eustas.bug@gmail.com> - - Web Inspector: Refactor message loop instrumentation. - https://bugs.webkit.org/show_bug.cgi?id=88978 - - Reviewed by Pavel Feldman. - - 1) Remove "messageLoop" term - 2) Reuse WebThread::TaskObserver interface - 3) Move implementation (from embedder) to platform code. - - * public/WebDevToolsAgent.h: - (WebDevToolsAgent): - * public/WebDevToolsAgentClient.h: - (WebDevToolsAgentClient): - (WebKit::WebDevToolsAgentClient::startMainThreadMonitoring): Renamed medthod. - (WebKit::WebDevToolsAgentClient::stopMainThreadMonitoring): Ditto. - * src/InspectorClientImpl.cpp: - (WebKit::InspectorClientImpl::startMainThreadMonitoring): Ditto. - (WebKit::InspectorClientImpl::stopMainThreadMonitoring): Ditto. - * src/InspectorClientImpl.h: - (InspectorClientImpl): - * src/WebDevToolsAgentImpl.cpp: - (WebKit::WebDevToolsAgentImpl::startMainThreadMonitoring): Use platform threading. - (WebKit::WebDevToolsAgentImpl::stopMainThreadMonitoring): Ditto. - (WebKit::WebDevToolsAgentImpl::willProcessTask): Renamed medthod. - (WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto. - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - * src/WebKit.cpp: - -2012-06-14 Alexander Pavlov <apavlov@chromium.org> - - Web Inspector: [Device Metrics] "Fit window" results in duplicate rescaling in WebDevToolsAgentImpl::autoZoomPageToFitWidth() - https://bugs.webkit.org/show_bug.cgi?id=89092 - - Reviewed by Pavel Feldman. - - Do not apply the sizeRatio after it has been applied in scaledEmulatedFrameSize(). - - * src/WebDevToolsAgentImpl.cpp: - (WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth): - (WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor): - -2012-06-14 Yoshifumi Inoue <yosin@chromium.org> - - [Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi - https://bugs.webkit.org/show_bug.cgi?id=89062 - - Reviewed by Kent Tamura. - - This patch removes ENABLE_INPUT_TYPE_*=0 from default entry of feature_defines to - allows us overriding by ~/.gyp/include.gypi - - * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME=0, ENABLE_INPUT_TYPE_DATETIMELOCAL=0, - and so on. - -2012-06-14 Min Qin <qinmin@google.com> - - Remove the const keyword from MediaPlayerPrivate::enterFullscreen() - https://bugs.webkit.org/show_bug.cgi?id=89044 - - Reviewed by Adam Barth. - - enterFullscreen() should be treated similarly as exitFullscreen() as it could alter the player state. - This reverts the change from r120213. - - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::enterFullscreen): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-06-14 Dan Alcantara <dfalcantara@chromium.org> - - [chromium] Rename WebFrameClient::userAgent() to better reflect what it does - https://bugs.webkit.org/show_bug.cgi?id=89028 - - Reviewed by Adam Barth. - - Renames WebFrameClient::userAgent() to userAgentOverride() and makes it return - the user agent override string directly. - - * public/WebFrameClient.h: - (WebFrameClient): - (WebKit::WebFrameClient::userAgentOverride): - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::userAgent): - * tests/FrameLoaderClientImplTest.cpp: - -2012-06-13 Jesse Greenwald <jgreenwald@google.com> - - [Chromium] Add WebDocument.images - https://bugs.webkit.org/show_bug.cgi?id=88837 - - Reviewed by Adam Barth. - - This method is needed on Android to support the existing - WebView.documentHasImages Java API. - - * public/WebDocument.h: - (WebDocument): - * src/WebDocument.cpp: - (WebKit::WebDocument::images): - (WebKit): - -2012-06-13 Dominic Cooney <dominicc@chromium.org> - - Unreviewed: Disable verifyHitTestingForSingleLayer. - https://bugs.webkit.org/show_bug.cgi?id=89065 - - It is failing on canary debug bots. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-06-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120268. - http://trac.webkit.org/changeset/120268 - https://bugs.webkit.org/show_bug.cgi?id=89060 - - WebCompositor::setPerTilePaintingEnabled hits an assertion in - DEBUG (Requested by dominicc|work on #webkit). - - * WebKit.gypi: - * public/WebCompositor.h: - (WebCompositor): - * public/WebSettings.h: - * src/WebCompositorImpl.cpp: - (WebKit::WebCompositor::shutdown): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCSettings): - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setPerTilePaintingEnabled): - (WebKit): - (WebKit::WebSettingsImpl::setPartialSwapEnabled): - (WebKit::WebSettingsImpl::setThreadedAnimationEnabled): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - * tests/CCTestCommon.h: Removed. - * tests/CCThreadedTest.cpp: - (WebKitTests::MockLayerTreeHostImpl::create): - (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (WebKitTests::CCThreadedTest::runTest): - * tests/CCThreadedTest.h: - (CCThreadedTest): - (MockLayerTreeHostImpl): - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - * tests/LayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (LayerRendererChromiumTest): - (TEST_F): - (TEST): - * tests/TextureLayerChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - * tests/TreeSynchronizerTest.cpp: - (WebKitTests::TEST): - -2012-06-13 Hironori Bono <hbono@chromium.org> - - [chromium] Add WebFrame::replaceMisspelledRange - https://bugs.webkit.org/show_bug.cgi?id=88618 - - Reviewed by Kent Tamura. - - This change adds WebFrame::replaceMisspelledRange, which replaces the range of a - misspelled marker with text so Chromium can use it for replacing misspelled - words with suggetions. - - * public/WebFrame.h: - (WebFrame): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::replaceMisspelledRange): - (WebKit): - * src/WebFrameImpl.h: - (WebFrameImpl): - -2012-06-13 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium] Let Android and Linux share WebFontRendering decl/impl. - https://bugs.webkit.org/show_bug.cgi?id=88802 - - Reviewed by Adam Barth. - - * WebKit.gyp: - * public/linux/WebFontRendering.h: Temporarily forwards to the new file under linuxish. - * public/linuxish: Added. - * public/linuxish/WebFontRendering.h: Copied from chromium/public/linux/WebFontRendering.h. - * src/linux/WebFontRendering.cpp: Removed. - * src/linuxish: Added. - * src/linuxish/WebFontRendering.cpp: Copied from chromium/src/linux/WebFontRendering.cpp. - -2012-06-13 Ian Vollick <vollick@chromium.org> - - [chromium] Certain settings in CCSettings could be global - https://bugs.webkit.org/show_bug.cgi?id=88384 - - Reviewed by James Robinson. - - * WebKit.gypi: - * public/WebCompositor.h: - (WebCompositor): - * public/WebSettings.h: - * src/WebCompositorImpl.cpp: - (WebKit::WebCompositor::shutdown): - (WebKit): - (WebKit::WebCompositor::setPerTilePaintingEnabled): - (WebKit::WebCompositor::setPartialSwapEnabled): - (WebKit::WebCompositor::setAcceleratedAnimationEnabled): - * src/WebLayerTreeView.cpp: - (WebKit): - (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): - * src/WebSettingsImpl.cpp: - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::WebViewImpl): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF): - (CCLayerTreeHostTestShortlived1): - (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1): - (WTF::CCLayerTreeHostTestShortlived1::beginTest): - (WTF::CCLayerTreeHostTestShortlived1::afterTest): - * tests/CCTestCommon.h: Added. - (WebKitTests): - (CCScopedSettings): - (WebKitTests::CCScopedSettings::CCScopedSettings): - (WebKitTests::CCScopedSettings::~CCScopedSettings): - * tests/CCThreadedTest.cpp: - (WebKitTests::MockLayerTreeHostImpl::create): - (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (WebKitTests::CCThreadedTest::runTest): - * tests/CCThreadedTest.h: - (CCThreadedTest): - (MockLayerTreeHostImpl): - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - * tests/LayerChromiumTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (LayerRendererChromiumTest): - (TEST_F): - (TEST): - * tests/TextureLayerChromiumTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - * tests/TreeSynchronizerTest.cpp: - (WebKitTests::TEST): - -2012-06-13 Dana Jansens <danakj@chromium.org> - - [chromium] Assert if iterating an invalid RenderSurfaceLayerList, where a layer in the list has no RenderSurface - https://bugs.webkit.org/show_bug.cgi?id=89004 - - Reviewed by Adrienne Walker. - - * tests/CCLayerIteratorTest.cpp: - -2012-06-13 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Implement hit-testing for impl-side input handling in accelerated compositor - https://bugs.webkit.org/show_bug.cgi?id=88972 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-06-13 David Reveman <reveman@chromium.org> - - [Chromium] Crash when WebViewImpl::setIsTransparent is called before the WebLayerTreeView has been initialized. - https://bugs.webkit.org/show_bug.cgi?id=89013 - - Reviewed by James Robinson. - - Add !m_layerTreeView.isNull() check to WebViewImpl::setIsTransparent. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsTransparent): - -2012-06-13 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120220. - http://trac.webkit.org/changeset/120220 - https://bugs.webkit.org/show_bug.cgi?id=89021 - - The patch broke build Chromium Win Release (Requested by - wangxianzhu on #webkit). - - * WebKit.gyp: - * public/linux/WebFontRendering.h: - (WebKit): - (WebFontRendering): - * public/linuxish/WebFontRendering.h: Removed. - * src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. - (WebKit): - (WebKit::WebFontRendering::setHinting): - (WebKit::WebFontRendering::setAntiAlias): - (WebKit::WebFontRendering::setSubpixelGlyphs): - (WebKit::WebFontRendering::setSubpixelRendering): - (WebKit::WebFontRendering::setSubpixelPositioning): - (WebKit::WebFontRendering::setLCDOrder): - (WebKit::WebFontRendering::setLCDOrientation): - -2012-06-13 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium] Let Android and Linux share WebFontRendering decl/impl. - https://bugs.webkit.org/show_bug.cgi?id=88802 - - Reviewed by Adam Barth. - - * WebKit.gyp: - * public/linux/WebFontRendering.h: Temporarily forwards to the new file under linuxish. - * public/linuxish: Added. - * public/linuxish/WebFontRendering.h: Copied from chromium/public/linux/WebFontRendering.h. - * src/linux/WebFontRendering.cpp: Removed. - * src/linuxish: Added. - * src/linuxish/WebFontRendering.cpp: Copied from chromium/src/linux/WebFontRendering.cpp. - -2012-06-13 Martin Kosiba <mkosiba@google.com> - - [Chromium] WebFrameImpl::find doesn't work for searching from a selection. - https://bugs.webkit.org/show_bug.cgi?id=88885 - - Reviewed by Adam Barth. - - Remember the active match not just until the seatchText changes but for the entire find session. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::find): - (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): - -2012-06-13 Peter Beverloo <peter@chromium.org> - - [Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1 - https://bugs.webkit.org/show_bug.cgi?id=88987 - - Reviewed by Simon Hausmann. - - The enterFullscreen method is declared as const by MediaPlayerPrivateInterface, - so this one should be declared as such as well. - - Patch by Evgeniy Stepanov <eugenis@google.com> - - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::enterFullscreen): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-06-13 MORITA Hajime <morrita@google.com> - - REGRESSION(r118098): <content> element does not render distributed children when cloned from another document - https://bugs.webkit.org/show_bug.cgi?id=88148 - - Reviewed by Dimitri Glazkov. - - - Added ContextFeaturesClientImpl which implements WebCore::ContextFeaturesClient. - - Replaced PagePopupFrameLoaderClient with PagePopupFeaturesClient. - - * WebKit.gyp: - * public/WebPermissionClient.h: - (WebKit): - (WebKit::WebPermissionClient::allowWebComponents): - * src/ContextFeaturesClientImpl.cpp: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.cpp. - (WebKit): - (WebKit::ContextFeaturesClientImpl::isEnabled): - * src/ContextFeaturesClientImpl.h: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.h. - (WebKit): - (ContextFeaturesClientImpl): - (WebKit::ContextFeaturesClientImpl::ContextFeaturesClientImpl): - (WebKit::ContextFeaturesClientImpl::setPermissionClient): - * src/FrameLoaderClientImpl.cpp: - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - * src/WebPagePopupImpl.cpp: - (PagePopupFeaturesClient): - (WebKit::PagePopupFeaturesClient::isEnabled): - (WebKit): - (WebKit::WebPagePopupImpl::initPage): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setPermissionClient): - (WebKit::WebViewImpl::WebViewImpl): - * src/WebViewImpl.h: - (WebKit): - -2012-06-12 Ian Vollick <vollick@chromium.org> - - [chromium] Roll chromium rev in DEPS - https://bugs.webkit.org/show_bug.cgi?id=88934 - - Reviewed by James Robinson. - - Rolling to 141410 - - * DEPS: - -2012-06-12 James Robinson <jamesr@chromium.org> - - [chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer - https://bugs.webkit.org/show_bug.cgi?id=88597 - - Reviewed by Adrienne Walker. - - Implementations for new WebExternalTextureLayer APIs, updates test. - - * src/WebExternalTextureLayer.cpp: - (WebKit::WebExternalTextureLayer::willModifyTexture): - (WebKit): - (WebKit::WebExternalTextureLayer::setRateLimitContext): - * tests/Canvas2DLayerBridgeTest.cpp: - (Canvas2DLayerBridgeTest::fullLifecycleTest): - -2012-06-12 Adrienne Walker <enne@google.com> - - [chromium] Paint scrollbars on WebKit thread and composite those textures - https://bugs.webkit.org/show_bug.cgi?id=88145 - - Reviewed by James Robinson. - - Remove scrollbarLayerLostContext test that no longer makes sense. The - compositor won't draw at all after a lost context if it has no - contents. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-12 Joshua Bell <jsbell@chromium.org> - - IndexedDB: ObjectStore/Index shouldn't hold reference to backing store - https://bugs.webkit.org/show_bug.cgi?id=83074 - - Reviewed by Tony Chang. - - * WebKit.gypi: - * tests/IDBDatabaseBackendTest.cpp: Added. - (WebCore): - (WebCore::TEST): - -2012-06-12 Dana Jansens <danakj@chromium.org> - - [chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests - https://bugs.webkit.org/show_bug.cgi?id=88903 - - Reviewed by Adrienne Walker. - - Without setting the contentBounds() on impl layers, the visibleLayerRect - will be wrong. This is not the case for main-thread layers, which most - of the tests in this file use. But this is a potential serious confusion - for future test implementors so I'd like to make it explicit now. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-06-12 Dana Jansens <danakj@chromium.org> - - [chromium] Return empty visibleLayerRect for layers with empty content bounds - https://bugs.webkit.org/show_bug.cgi?id=88901 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-12 Mark Mentovai <mark@chromium.org> - - [chromium mac] Don't #include things in subframeworks of - ApplicationServices.framework. - - #including the umbrella <ApplicatonServices/ApplicationServices.h> - exposed an ambiguous name, FontMetrics, that needs to be fully - qualified as WebCore::FontMetrics. - - https://bugs.webkit.org/show_bug.cgi?id=88569 - - Reviewed by Stephen White. - - * src/WebFontImpl.cpp: - (WebKit::WebFontImpl::estimateTextBounds): - -2012-06-12 James Robinson <jamesr@chromium.org> - - [chromium] REGRESSION(119769): Canvas2DLayerBridge may go away before its TextureLayerChromium - https://bugs.webkit.org/show_bug.cgi?id=88910 - - Reviewed by Adrienne Walker. - - New unit test to verify that we can still update a TextureLayerChromium after the bridge owning it has gone - away. - - * tests/Canvas2DLayerBridgeTest.cpp: - -2012-06-12 Adrienne Walker <enne@google.com> - - [chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages - https://bugs.webkit.org/show_bug.cgi?id=88887 - - Reviewed by James Robinson. - - The scroll position on layers needs to take into account the scroll - origin, since RTL pages start scrolled all the way to the right. - Otherwise, when scrolling left the scroll position incorrectly will go - negative, causing havok in scrollbar theme code that just assumes that - it's always scrolled all the way to the left. - - Also, now that the scroll origin is passed into NCCH, handle - scrollOrigin.y() for layer adjusting. This is always zero in practice, - but it seemed awkward to just drop it and that assumption could always - change in the future. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::setViewport): - (WebKit::NonCompositedContentHost::paintContents): - * src/NonCompositedContentHost.h: - (NonCompositedContentHost): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::updateLayerTreeViewport): - -2012-06-12 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Make damage tracking more robust to early exits - https://bugs.webkit.org/show_bug.cgi?id=84803 - - Reviewed by James Robinson. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::clearDamageForAllSurfaces): - (WebKitTests::TEST_F): - -2012-06-12 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r120051. - http://trac.webkit.org/changeset/120051 - https://bugs.webkit.org/show_bug.cgi?id=88852 - - some tests are crashing (Requested by morrita on #webkit). - - * WebKit.gyp: - * public/WebPermissionClient.h: - (WebKit::WebPermissionClient::allowWebComponents): - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::allowShadowDOM): - (WebKit): - (WebKit::FrameLoaderClientImpl::allowStyleScoped): - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::initPage): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setPermissionClient): - (WebKit::WebViewImpl::WebViewImpl): - * src/WebViewImpl.h: - (WebKit): - -2012-06-12 MORITA Hajime <morrita@google.com> - - REGRESSION(r118098): <content> element does not render distributed children when cloned from another document - https://bugs.webkit.org/show_bug.cgi?id=88148 - - Reviewed by Dimitri Glazkov. - - - Added ContextFeaturesClientImpl which implements WebCore::ContextFeaturesClient. - - Replaced PagePopupFrameLoaderClient with PagePopupFeaturesClient. - - * WebKit.gyp: - * public/WebPermissionClient.h: - (WebKit): - (WebKit::WebPermissionClient::allowWebComponents): - * src/ContextFeaturesClientImpl.cpp: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.cpp. - (WebKit): - (WebKit::ContextFeaturesClientImpl::isEnabled): - * src/ContextFeaturesClientImpl.h: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.h. - (WebKit): - (ContextFeaturesClientImpl): - (WebKit::ContextFeaturesClientImpl::ContextFeaturesClientImpl): - (WebKit::ContextFeaturesClientImpl::setPermissionClient): - * src/FrameLoaderClientImpl.cpp: - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - * src/WebPagePopupImpl.cpp: - (PagePopupFeaturesClient): - (WebKit::PagePopupFeaturesClient::isEnabled): - (WebKit): - (WebKit::WebPagePopupImpl::initPage): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setPermissionClient): - (WebKit::WebViewImpl::WebViewImpl): - * src/WebViewImpl.h: - (WebKit): - -2012-06-11 Nico Weber <thakis@chromium.org> - - Remove unused member variables found by clang's -Wunused-private-field - https://bugs.webkit.org/show_bug.cgi?id=88812 - - Reviewed by Anders Carlsson. - - * src/AudioDestinationChromium.cpp: - (WebCore::AudioDestinationChromium::AudioDestinationChromium): - * src/AudioDestinationChromium.h: - (AudioDestinationChromium): - * src/InspectorFrontendClientImpl.cpp: - (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): - * src/InspectorFrontendClientImpl.h: - (InspectorFrontendClientImpl): - * src/WebFrameImpl.cpp: - (ChromePluginPrintContext): - * src/WebInputEvent.cpp: - * src/WorkerAsyncFileSystemChromium.cpp: - (WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge): - * src/WorkerAsyncFileWriterChromium.cpp: - (WebCore::WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium): - * src/WorkerAsyncFileWriterChromium.h: - (WorkerAsyncFileWriterChromium): - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestSetVisible::CCLayerTreeHostTestSetVisible): - (CCLayerTreeHostTestSetVisible): - -2012-06-11 Vincent Scheib <scheib@chromium.org> - - Consolidate Pointer Lock runtime enabled flags to just one. - https://bugs.webkit.org/show_bug.cgi?id=88810 - - Reviewed by Dimitri Glazkov. - - * src/WebRuntimeFeatures.cpp: - (WebKit::WebRuntimeFeatures::enablePointerLock): - (WebKit::WebRuntimeFeatures::isPointerLockEnabled): - -2012-06-11 Alexis Menard <alexis.menard@openbossa.org> - - [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag. - https://bugs.webkit.org/show_bug.cgi?id=88804 - - Reviewed by Tony Chang. - - Protect box-decoration-break behind a feature flag enabled by default. - - * features.gypi: - -2012-05-11 James Robinson <jamesr@chromium.org> - - [chromium] Port DrawingBufferChromium from TextureLayerChromium over to WebExternalTextureLayer - https://bugs.webkit.org/show_bug.cgi?id=86273 - - Reviewed by Adrienne Walker. - - * src/WebExternalTextureLayer.cpp: - (WebTextureUpdaterImpl): - (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl): - (WebKit): - (WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl): - (WebKit::WebExternalTextureLayer::create): - (WebKit::WebExternalTextureLayer::clearClient): - (WebKit::WebExternalTextureLayer::setOpaque): - (WebKit::WebExternalTextureLayer::setPremultipliedAlpha): - -2012-06-11 Dana Jansens <danakj@chromium.org> - - [chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad - https://bugs.webkit.org/show_bug.cgi?id=88363 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCTiledLayerTestCommon.h: - (WebKitTests::FakeTextureCopier::copyToTexture): - * tests/Canvas2DLayerChromiumTest.cpp: - -2012-06-11 Joshua Bell <jsbell@chromium.org> - - IndexedDB: Object stores are not successfully deleted - https://bugs.webkit.org/show_bug.cgi?id=88788 - - Reviewed by Tony Chang. - - * tests/IDBLevelDBCodingTest.cpp: - (IDBLevelDBCoding::TEST): - -2012-06-11 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Implement position:fixed in compositor thread - https://bugs.webkit.org/show_bug.cgi?id=70103 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - -2012-06-11 Sam Weinig <sam@webkit.org> - - Remove support for disconnected/excluded from search frames, they are not used by Safari anymore - https://bugs.webkit.org/show_bug.cgi?id=88723 - - Reviewed by Dan Bernstein. - - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::scopeStringMatches): - -2012-06-11 Varun Jain <varunjain@chromium.org> - - [chromium] WebInputEvent::isGestureEventType should return true for GestureTwoFingerTap - https://bugs.webkit.org/show_bug.cgi?id=88789 - - Reviewed by Adam Barth. - - * public/WebInputEvent.h: - (WebKit::WebInputEvent::isGestureEventType): - -2012-06-11 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Call shared timer functions directly - https://bugs.webkit.org/show_bug.cgi?id=88781 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-06-11 Amy Ousterhout <aousterh@chromium.org> - - [Chromium] Removing long WebDeviceOrientation constructor - https://bugs.webkit.org/show_bug.cgi?id=88779 - - Reviewed by Adam Barth. - - Removing the WebDeviceOrientation constructor with nine parameters. - Chromium has been changed to use the default constructor and setter - functions instead (see https://chromiumcodereview.appspot.com/10542025/). - - * public/WebDeviceOrientation.h: - -2012-06-11 David Dorwin <ddorwin@chromium.org> - - [chromium] Provide access to the WebPlugin created by the helper plugin widget - https://bugs.webkit.org/show_bug.cgi?id=88028 - - Reviewed by Adam Barth. - - A WebPlugin is created when the document created by createHelperPlugin() is laid out. - Expose it so the embedder can interact with the plugin instance. - - * public/WebHelperPlugin.h: - (WebKit): - (WebHelperPlugin): - * public/WebMediaPlayerClient.h: - (WebKit): - * public/WebPlugin.h: - (WebKit::WebPlugin::isPlaceholder): - (WebPlugin): - * src/WebHelperPluginImpl.cpp: - (WebKit::WebHelperPluginImpl::WebHelperPluginImpl): - (WebKit): - (WebKit::WebHelperPluginImpl::getPlugin): - (WebKit::WebHelperPluginImpl::initPage): - (WebKit::WebHelperPluginImpl::close): - * src/WebHelperPluginImpl.h: - (WebKit): - (WebHelperPluginImpl): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::createHelperPlugin): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - * src/WebPagePopupImpl.cpp: - -2012-06-05 Dana Jansens <danakj@chromium.org> - - [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed - https://bugs.webkit.org/show_bug.cgi?id=88371 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-11 Kent Tamura <tkent@chromium.org> - - [Chromium] Should call frameDetached() in WebPagePopupImpl::close() - https://bugs.webkit.org/show_bug.cgi?id=88754 - - Reviewed by Adam Barth. - - * src/WebPagePopupImpl.cpp: - (WebKit::WebPagePopupImpl::close): Calls FrameLoader::frameDetached(). - -2012-06-11 Min Qin <qinmin@google.com> - - Adding a flag to show fullscreen media controls in chromium - https://bugs.webkit.org/show_bug.cgi?id=88266 - - Reviewed by Adam Barth. - - Adding a flag to the gyp file so that we can enable fullscreen media control - - * features.gypi: - -2012-06-09 Eugene Klyuchnikov <eustas.bug@gmail.com> - - Web Inspector: Add message loop instrumentation to public API and timeline agent - https://bugs.webkit.org/show_bug.cgi?id=88639 - - Reviewed by Vsevolod Vlasov. - - Message loop instrumentation will show when the render thread is busy. - That way developer can discover if a render thread business causes low fps, or not. - - * public/WebDevToolsAgent.h: - (WebDevToolsAgent): - * public/WebDevToolsAgentClient.h: - (WebDevToolsAgentClient): - (WebKit::WebDevToolsAgentClient::startMessageLoopMonitoring): - Request message loop notifications. - (WebKit::WebDevToolsAgentClient::stopMessageLoopMonitoring): - Cancel message loop notifications. - * src/InspectorClientImpl.cpp: - (WebKit::InspectorClientImpl::startMessageLoopMonitoring): - Request message loop notifications. - (WebKit): - (WebKit::InspectorClientImpl::stopMessageLoopMonitoring): - Cancel message loop notifications. - * src/InspectorClientImpl.h: - (InspectorClientImpl): - * src/WebDevToolsAgentImpl.cpp: - (WebKit::WebDevToolsAgentImpl::startMessageLoopMonitoring): - Request message loop notifications. - (WebKit): - (WebKit::WebDevToolsAgentImpl::stopMessageLoopMonitoring): - Cancel message loop notifications. - (WebKit::WebDevToolsAgentImpl::instrumentWillProcessTask): - Message loop notification. - (WebKit::WebDevToolsAgentImpl::instrumentDidProcessTask): - Ditto. - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - -2012-06-08 David Reveman <reveman@chromium.org> - - [Chromium] Compositor doesn't support translucent root layers. - https://bugs.webkit.org/show_bug.cgi?id=87821 - - Reviewed by James Robinson. - - * src/NonCompositedContentHost.cpp: - (WebKit::NonCompositedContentHost::setOpaque): - (WebKit): - * src/NonCompositedContentHost.h: - (NonCompositedContentHost): - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setHasTransparentBackground): - (WebKit): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsTransparent): - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - * tests/CCLayerTreeHostImplTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (ClearCountingContext): - (ClearCountingContext::ClearCountingContext): - (ClearCountingContext::clear): - (ClearCountingContext::clearCount): - (TEST): - -2012-06-08 Ian Vollick <vollick@chromium.org> - - [chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized - https://bugs.webkit.org/show_bug.cgi?id=88668 - - Reviewed by James Robinson. - - * WebKit.gypi: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest): - (WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread): - (WTF): - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation): - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::didAddAnimation): - (CCLayerTreeHostTestLayerAddedWithAnimation): - * tests/CCSingleThreadProxyTest.cpp: Added. - (FakeWebGraphicsContext3DMakeCurrentFails): - (FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent): - (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation): - (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation): - (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::beginTest): - (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers): - (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext): - (CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::afterTest): - (TEST_F): - (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer): - (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer): - (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::beginTest): - (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::animateLayers): - (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didRecreateContext): - (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didAddAnimation): - (CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::afterTest): - * tests/CCThreadedTest.cpp: Added. - (WebKitTests): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::create): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures): - (WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking): - (WebKitTests::TestHooks::createContext): - (WebKitTests::MockLayerTreeHostImpl::create): - (WebKitTests::MockLayerTreeHostImpl::beginCommit): - (WebKitTests::MockLayerTreeHostImpl::commitComplete): - (WebKitTests::MockLayerTreeHostImpl::prepareToDraw): - (WebKitTests::MockLayerTreeHostImpl::drawLayers): - (WebKitTests::MockLayerTreeHostImpl::animateLayers): - (WebKitTests::MockLayerTreeHostImpl::lowFrequencyAnimationInterval): - (WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl): - (MockLayerTreeHost): - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (MockLayerTreeHostClient): - (WebKitTests::MockLayerTreeHostClient::create): - (WebKitTests::MockLayerTreeHostClient::MockLayerTreeHostClient): - (TimeoutTask): - (WebKitTests::TimeoutTask::TimeoutTask): - (WebKitTests::TimeoutTask::clearTest): - (WebKitTests::TimeoutTask::~TimeoutTask): - (WebKitTests::TimeoutTask::run): - (BeginTask): - (WebKitTests::BeginTask::BeginTask): - (WebKitTests::BeginTask::~BeginTask): - (WebKitTests::BeginTask::run): - (EndTestTask): - (WebKitTests::EndTestTask::EndTestTask): - (WebKitTests::EndTestTask::~EndTestTask): - (WebKitTests::EndTestTask::clearTest): - (WebKitTests::EndTestTask::run): - (WebKitTests::CCThreadedTest::CCThreadedTest): - (WebKitTests::CCThreadedTest::endTest): - (WebKitTests::CCThreadedTest::endTestAfterDelay): - (WebKitTests::CCThreadedTest::postSetNeedsAnimateToMainThread): - (WebKitTests::CCThreadedTest::postAddAnimationToMainThread): - (WebKitTests::CCThreadedTest::postAddInstantAnimationToMainThread): - (WebKitTests::CCThreadedTest::postSetNeedsCommitToMainThread): - (WebKitTests::CCThreadedTest::postAcquireLayerTextures): - (WebKitTests::CCThreadedTest::postSetNeedsRedrawToMainThread): - (WebKitTests::CCThreadedTest::postSetNeedsAnimateAndCommitToMainThread): - (WebKitTests::CCThreadedTest::postSetVisibleToMainThread): - (WebKitTests::CCThreadedTest::postDidAddAnimationToMainThread): - (WebKitTests::CCThreadedTest::doBeginTest): - (WebKitTests::CCThreadedTest::timeout): - (WebKitTests::CCThreadedTest::scheduleComposite): - (WebKitTests::CCThreadedTest::onEndTest): - (WebKitTests::CCThreadedTest::dispatchSetNeedsAnimate): - (WebKitTests::CCThreadedTest::dispatchAddInstantAnimation): - (WebKitTests::CCThreadedTest::dispatchAddAnimation): - (WebKitTests::CCThreadedTest::dispatchSetNeedsAnimateAndCommit): - (WebKitTests::CCThreadedTest::dispatchSetNeedsCommit): - (WebKitTests::CCThreadedTest::dispatchAcquireLayerTextures): - (WebKitTests::CCThreadedTest::dispatchSetNeedsRedraw): - (WebKitTests::CCThreadedTest::dispatchSetVisible): - (WebKitTests::CCThreadedTest::dispatchSetInvisible): - (WebKitTests::CCThreadedTest::dispatchComposite): - (WebKitTests::CCThreadedTest::dispatchDidAddAnimation): - (WebKitTests::CCThreadedTest::runTest): - * tests/CCThreadedTest.h: Added. - (WebCore): - (WebKit): - (WebKitTests): - (TestHooks): - (WebKitTests::TestHooks::beginCommitOnCCThread): - (WebKitTests::TestHooks::commitCompleteOnCCThread): - (WebKitTests::TestHooks::prepareToDrawOnCCThread): - (WebKitTests::TestHooks::drawLayersOnCCThread): - (WebKitTests::TestHooks::animateLayers): - (WebKitTests::TestHooks::willAnimateLayers): - (WebKitTests::TestHooks::applyScrollAndScale): - (WebKitTests::TestHooks::updateAnimations): - (WebKitTests::TestHooks::layout): - (WebKitTests::TestHooks::didRecreateContext): - (WebKitTests::TestHooks::didAddAnimation): - (WebKitTests::TestHooks::didCommit): - (WebKitTests::TestHooks::didCommitAndDrawFrame): - (WebKitTests::TestHooks::scheduleComposite): - (WebKitTests::TestHooks::notifyAnimationStarted): - (WebKitTests::TestHooks::notifyAnimationFinished): - (CCThreadedTest): - (WebKitTests::CCThreadedTest::clearTimeout): - (WebKitTests::CCThreadedTest::clearEndTestTask): - (WebKitTests::CCThreadedTest::layerTreeHost): - (CCThreadedTestThreadOnly): - (WebKitTests::CCThreadedTestThreadOnly::runTestThreaded): - (MockLayerTreeHostImpl): - (CompositorFakeWebGraphicsContext3DWithTextureTracking): - -2012-06-08 David Grogan <dgrogan@chromium.org> - - IndexedDB: rename some instances of open to registerFrontendCallbacks - https://bugs.webkit.org/show_bug.cgi?id=88611 - - Reviewed by Tony Chang. - - * src/IDBDatabaseBackendProxy.cpp: - (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks): - * src/IDBDatabaseBackendProxy.h: - (IDBDatabaseBackendProxy): - * src/WebIDBDatabaseImpl.cpp: - (WebKit::WebIDBDatabaseImpl::open): - * src/WebIDBDatabaseImpl.h: - (WebIDBDatabaseImpl): - -2012-06-08 Dana Jansens <danakj@chromium.org> - - [chromium] Skip willDraw() and didDraw() on fully occluded layers - https://bugs.webkit.org/show_bug.cgi?id=88435 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-08 James Robinson <jamesr@chromium.org> - - [chromium] Clean up some unnecessary LayerChromium.h includes - https://bugs.webkit.org/show_bug.cgi?id=88599 - - Reviewed by Adam Barth. - - Removes unused include, update comment. - - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::platformLayer): - (WebKit::WebMediaPlayerClientImpl::paint): - -2012-06-08 Jochen Eisinger <jochen@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-08 Ian Vollick <vollick@chromium.org> - - [chromium] Accelerated animations should use WebTransformOperations - https://bugs.webkit.org/show_bug.cgi?id=87686 - - Reviewed by James Robinson. - - CCTransformKeyframe new owns a WebTransformOperations rather than a - TransformOperations. LayerChromium's API has been changed so that - LayerChromium::addAnimation should take only a CCActiveAnimation. - GraphicsLayerChromium is new responsible for translating to - WebTransformOperations and creating CCActiveAnimations. Tests that use - the public API (that is, they call addAnimation with KeyframeValueList - and Animation arguments) have been moved to GraphicsLayerChromiumTest. - - * tests/CCAnimationTestCommon.cpp: - (WebCore::addOpacityTransition): - (WebCore::addAnimatedTransform): - (WebKitTests::FakeTransformTransition::getValue): - * tests/CCAnimationTestCommon.h: - * tests/CCKeyframedAnimationCurveTest.cpp: - * tests/CCLayerAnimationControllerTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): - * tests/GraphicsLayerChromiumTest.cpp: - (MockLayerTreeHostClient): - (WebKitTests): - (MockLayerTreeHost): - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (GraphicsLayerChromiumTest): - (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - (WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): - (WebKitTests::GraphicsLayerChromiumTest::expectTranslateX): - (WebKitTests::TEST_F): - * tests/LayerChromiumTest.cpp: - -2012-06-08 Robert Kroeger <rjkroege@chromium.org> - - More than 8 fingers get ignored by touch - https://bugs.webkit.org/show_bug.cgi?id=88359 - - Reviewed by James Robinson. - - * public/WebInputEvent.h: Increase of TouchPoints per TouchEvent from 8 to 12. - -2012-06-08 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-08 Taiju Tsuiki <tzik@chromium.org> - - Add FileSystem item to storage tree. - https://bugs.webkit.org/show_bug.cgi?id=72691 - - Reviewed by Vsevolod Vlasov. - - * src/js/DevTools.js: - -2012-06-08 Peter Beverloo <peter@chromium.org> - - [Chromium] Re-enable SHARED_WORKERS for Android until a build fix has been resolved. - https://bugs.webkit.org/show_bug.cgi?id=88637 - - Unreviewed build fix. - - Linking content_shell on the Chromium side fails due to an unresolved - call to WebSharedWorker::create(). Since this blocks WebKit rolls, - temporarily re-enable the feature until this has been solved. - - * features.gypi: - -2012-06-07 Nico Weber <thakis@chromium.org> - - [chromium/mac] Improve deviceDPI, rect, and availableRect computation - https://bugs.webkit.org/show_bug.cgi?id=88596 - - Reviewed by Adam Barth. - - Set deviceDPI to 160 for normal displays and 320 for HiDPI displays. - (Why 160? That's what chromium's render_view.cc assumes as default - single-resolution resolution at the moment. The only other place - where this number gets used is fixed layout mode, which is currently - not enabled.) - - Also fix rect and availableRect computations: They get returned in - user space already. - - Needed for http://crbug.com/31960. - - * src/mac/WebScreenInfoFactory.mm: - (WebKit::toUserSpace): - (WebKit::deviceScaleFactor): - (WebKit): - (WebKit::WebScreenInfoFactory::screenInfo): - -2012-06-07 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move didStartWorkerRunLoop to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=88562 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-06-05 James Robinson <jamesr@chromium.org> - - [chromium] Move deferral-related logic out of Canvas2DLayerChromium - https://bugs.webkit.org/show_bug.cgi?id=86050 - - Reviewed by Stephen White. - - * WebKit.gypi: - * tests/Canvas2DLayerBridgeTest.cpp: Renamed from tests/Canvas2DLayerChromiumTest - (Canvas2DLayerBridgeTest): - (Canvas2DLayerBridgeTest::fullLifecycleTest): - -2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r119744. - http://trac.webkit.org/changeset/119744 - https://bugs.webkit.org/show_bug.cgi?id=88584 - - Fails assertions in debug builds (Requested by jamesr_ on - #webkit). - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-07 Adam Barth <abarth@webkit.org> - - Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor - https://bugs.webkit.org/show_bug.cgi?id=88375 - - Reviewed by James Robinson. - - * public/WebSettings.h: - (WebKit::WebSettings::setDefaultDeviceScaleFactor): - (WebSettings): - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): - * src/WebSettingsImpl.cpp: - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - * tests/WebFrameTest.cpp: - (WebKit::TEST_F): - -2012-06-07 Peter Beverloo <peter@chromium.org> - - [Chromium] features.gypi should have the correct definitions for Android - https://bugs.webkit.org/show_bug.cgi?id=88533 - - Reviewed by Adam Barth. - - Make all features which are enabled on Android but disabled on other platforms, - or are disabled on Android while enabled on other platforms, conditional. This - also means that the selection of code compiled for Android will slightly change. - - This change also removes the enable_viewport variable as the value of this is - no longer respected by WebKit - it's enabled by default for all of Chromium. - Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again. - - * features.gypi: - -2012-06-07 Dana Jansens <danakj@chromium.org> - - [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed - https://bugs.webkit.org/show_bug.cgi?id=88371 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-07 Ami Fischman <fischman@chromium.org> - - Plumb CORS attribute information from HTMLMediaElement to media players so it can be used - https://bugs.webkit.org/show_bug.cgi?id=88349 - - Reviewed by Adam Barth. - - * public/WebMediaPlayer.h: - (WebMediaPlayer): - * src/AssertMatchingEnums.cpp: - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::loadInternal): - (WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck): - (WebKit): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-06-07 Daniel Erat <derat@chromium.org> - - Add setting to enable subpixel-positioned text on Linux. - https://bugs.webkit.org/show_bug.cgi?id=88263 - - Reviewed by Tony Chang. - - Add subpixel positioning field to WebFontRenderStyle and rename - subpixel rendering field. Make similar changes in - WebFontRendering. - - Also add global WebFontInfo::setSubpixelPositioning() to turn - subpixel positioning on or off (there's not currently a - well-defined way to configure subpixel positioning via FontConfig). - - * public/linux/WebFontInfo.h: - (WebFontInfo): - * public/linux/WebFontRenderStyle.h: - * public/linux/WebFontRendering.h: - (WebFontRendering): - * src/linux/WebFontInfo.cpp: - (WebKit): - (WebKit::WebFontInfo::setSubpixelPositioning): - (WebKit::WebFontInfo::renderStyleForStrike): - * src/linux/WebFontRenderStyle.cpp: - (WebKit::WebFontRenderStyle::toFontRenderStyle): - (WebKit::WebFontRenderStyle::setDefaults): - * src/linux/WebFontRendering.cpp: - (WebKit::WebFontRendering::setSubpixelGlyphs): - (WebKit): - (WebKit::WebFontRendering::setSubpixelRendering): - (WebKit::WebFontRendering::setSubpixelPositioning): - -2012-06-06 Dana Jansens <danakj@chromium.org> - - [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called - https://bugs.webkit.org/show_bug.cgi?id=88469 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r119694. - http://trac.webkit.org/changeset/119694 - https://bugs.webkit.org/show_bug.cgi?id=88529 - - it broke PrerenderBrowserTest.PrerenderHTML5VideoNetwork - (Requested by loislo on #webkit). - - * public/WebMediaPlayer.h: - (WebMediaPlayer): - * src/AssertMatchingEnums.cpp: - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::loadInternal): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r119689. - http://trac.webkit.org/changeset/119689 - https://bugs.webkit.org/show_bug.cgi?id=88516 - - it broke didDrawNotCalledOnScissoredLayer webkit_unit_test - (Requested by loislo on #webkit). - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-07 Ami Fischman <fischman@chromium.org> - - Plumb CORS attribute information from HTMLMediaElement to media players so it can be used - https://bugs.webkit.org/show_bug.cgi?id=88349 - - Reviewed by Adam Barth. - - * public/WebMediaPlayer.h: - (WebMediaPlayer): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::loadInternal): - -2012-06-07 Yoshifumi Inoue <yosin@chromium.org> - - [Platform] Introduce conversion from/to Deciaml to/from double and helper functions - https://bugs.webkit.org/show_bug.cgi?id=88480 - - Reviewed by Kent Tamura. - - This patch added tests for Decimal::fromDouble, isInfinity, toDouble. - - * tests/DecimalTest.cpp: - (TEST_F): - -2012-06-07 Ami Fischman <fischman@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-06 Dana Jansens <danakj@chromium.org> - - [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called - https://bugs.webkit.org/show_bug.cgi?id=88469 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-06 Kent Tamura <tkent@chromium.org> - - Unreviewed, rolling out r60044. - http://trac.webkit.org/changeset/60044 - - It made a regression, crbug.com/114922. - - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll): Do not hide popups by scrolling. - (WebKit::ChromeClientImpl::scroll): ditto. - -2012-06-06 Noel Gordon <noel.gordon@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: Roll to chromium 140955. - -2012-06-06 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r119683. - http://trac.webkit.org/changeset/119683 - https://bugs.webkit.org/show_bug.cgi?id=88505 - - it broke webkit-unit-test - WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac - (Requested by loislo on #webkit). - - * tests/CCLayerTreeHostTest.cpp: - (WTF::MockLayerTreeHost::create): - * tests/Canvas2DLayerChromiumTest.cpp: - (Canvas2DLayerChromiumTest::fullLifecycleTest): - -2012-06-06 Robert Kroeger <rjkroege@chromium.org> - - [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows - https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for precise - scrolling deltas on all Chromium platforms. - - Reviewed by James Robinson. - - * src/WebInputEventConversion.cpp: - (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): Create PlatformWheelEvents - with m_hasPreciseScrollingDelta flag as required. - * tests/ScrollAnimatorNoneTest.cpp: Added new unit test condiiton for precise scrolling. - (TEST): - -2012-06-06 Michal Mocny <mmocny@google.com> - - [chromium] Stop dropping texture limits when the layer tree host becomes invisible, and initialize with 0 allocation. - https://bugs.webkit.org/show_bug.cgi?id=87747 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostTest.cpp: - (WTF::MockLayerTreeHost::create): - * tests/Canvas2DLayerChromiumTest.cpp: - (Canvas2DLayerChromiumTest::fullLifecycleTest): - -2012-06-06 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move createMessagePortChannel to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=85764 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * WebKit.gyp: - * public/WebFrame.h: - (WebFrame): - * public/WebMessagePortChannel.h: - * public/WebMessagePortChannelClient.h: - * public/WebSharedWorkerClient.h: - (WebSharedWorkerClient): - * public/platform/WebKitPlatformSupport.h: - (WebKit): - (WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue): - * src/PlatformMessagePortChannel.cpp: - (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): - * src/PlatformMessagePortChannel.h: - * src/SharedWorkerRepository.cpp: - * src/WebSharedWorkerImpl.cpp: - -2012-06-06 Amy Ousterhout <aousterh@chromium.org> - - [Chromium] DeviceOrientation cleanup - https://bugs.webkit.org/show_bug.cgi?id=88406 - - Reviewed by Kent Tamura. - - Made default constructor public and added a set function for each property. - This will allow us to remove the 8-parameter constructor. - - * public/WebDeviceOrientation.h: - (WebKit::WebDeviceOrientation::WebDeviceOrientation): - (WebKit::WebDeviceOrientation::setNull): - (WebKit::WebDeviceOrientation::setAlpha): - (WebKit::WebDeviceOrientation::setBeta): - (WebKit::WebDeviceOrientation::setGamma): - (WebKit::WebDeviceOrientation::setAbsolute): - (WebDeviceOrientation): - -2012-06-06 James Robinson <jamesr@chromium.org> - - [chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support - https://bugs.webkit.org/show_bug.cgi?id=86257 - - Reviewed by Kenneth Russell. - - * WebKit.gyp: - -2012-06-06 James Robinson <jamesr@chromium.org> - - [chromium] Unreviewed build fix, add an apparently used include of OwnArrayPtr.h back to GraphicsContext3DPrivate.h - https://bugs.webkit.org/show_bug.cgi?id=88468 - - * src/GraphicsContext3DPrivate.h: - -2012-06-06 James Robinson <jamesr@chromium.org> - - [chromium] Clean up GraphicsContext3D implementation - https://bugs.webkit.org/show_bug.cgi?id=88460 - - Reviewed by Kenneth Russell. - - Chromium's implementation of the GraphicsContext3D implementation has been somewhat messy for historical - reasons. The actual implementation of the majority of these functions is done by delegating to the Platform API - WebGraphicsContext3D. A few bits of functionality - extension mapping, some compositor functionality, a readback - utility - are implemented by code in WebKit. Previously, all GraphicsContext3D functions delegates to a clone of - the interface in GraphicsContext3DPrivate which in turn delegated to WebGraphicsContext3D. This required - duplicating the entire GraphicsContext3D interface and made updating the interface an epic pain in the rear. - - This patch provides the implementations of GraphicsContext3D functions in GraphicsContext3DChromium.cpp. Most of - these functions delegate directly to WebGraphicsContext3D. The ones that do not delegate to - GraphicsContext3DPrivate, which now has a dedicated header and cpp file. GraphicsContext3DPrivate.cpp implements - all GraphicsContext3DPrivate functions. I've also reordered the implementation files so that the function order - matches the associated header file and normalized the names of callback adapters. - - Refactor only, no change in functionality. Existing tests apply. - - * WebKit.gyp: - * src/Extensions3DChromium.cpp: - (WebCore::Extensions3DChromium::ensureEnabled): - (WebCore::Extensions3DChromium::getGraphicsResetStatusARB): - (WebCore::Extensions3DChromium::blitFramebuffer): - (WebCore::Extensions3DChromium::renderbufferStorageMultisample): - (WebCore::Extensions3DChromium::postSubBufferCHROMIUM): - (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM): - (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM): - (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM): - (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM): - (WebCore::Extensions3DChromium::setVisibilityCHROMIUM): - (WebCore::Extensions3DChromium::discardFramebufferEXT): - (WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM): - (WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE): - (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM): - (WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM): - (WebCore::Extensions3DChromium::texStorage2DEXT): - (WebCore::Extensions3DChromium::createQueryEXT): - (WebCore::Extensions3DChromium::deleteQueryEXT): - (WebCore::Extensions3DChromium::isQueryEXT): - (WebCore::Extensions3DChromium::beginQueryEXT): - (WebCore::Extensions3DChromium::endQueryEXT): - (WebCore::Extensions3DChromium::getQueryivEXT): - (WebCore::Extensions3DChromium::getQueryObjectuivEXT): - * src/GraphicsContext3DChromium.cpp: - (WebCore::GraphicsContext3D::GraphicsContext3D): - (WebCore::GraphicsContext3D::~GraphicsContext3D): - (WebCore::GraphicsContext3D::setContextLostCallback): - (WebCore::GraphicsContext3D::setErrorMessageCallback): - (WebCore::GraphicsContext3D::create): - (WebCore::GraphicsContext3D::platformGraphicsContext3D): - (WebCore::GraphicsContext3D::platformTexture): - (WebCore::GraphicsContext3D::grContext): - (WebCore::GraphicsContext3D::platformLayer): - (WebCore): - (WebCore::GraphicsContext3D::isGLES2Compliant): - (WebCore::GraphicsContext3D::isResourceSafe): - (WebCore::GraphicsContext3D::bindAttribLocation): - (WebCore::GraphicsContext3D::bufferData): - (WebCore::GraphicsContext3D::getActiveAttrib): - (WebCore::GraphicsContext3D::getActiveUniform): - (WebCore::GraphicsContext3D::getAttribLocation): - (WebCore::GraphicsContext3D::getContextAttributes): - (WebCore::GraphicsContext3D::getProgramInfoLog): - (WebCore::GraphicsContext3D::getShaderInfoLog): - (WebCore::GraphicsContext3D::getShaderSource): - (WebCore::GraphicsContext3D::getString): - (WebCore::GraphicsContext3D::getUniformLocation): - (WebCore::GraphicsContext3D::shaderSource): - (WebCore::GraphicsContext3D::texImage2D): - (WebCore::GraphicsContext3D::texSubImage2D): - (WebCore::GraphicsContext3D::reshape): - (WebCore::GraphicsContext3D::markContextChanged): - (WebCore::GraphicsContext3D::layerComposited): - (WebCore::GraphicsContext3D::markLayerComposited): - (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): - (WebCore::GraphicsContext3D::paintRenderingResultsToImageData): - (WebCore::GraphicsContext3D::paintCompositedResultsToCanvas): - (WebCore::GraphicsContext3D::getExtensions): - (WebCore::GraphicsContext3D::getInternalFramebufferSize): - * src/GraphicsContext3DPrivate.cpp: Added. - (WebCore): - (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate): - (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate): - (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext): - (WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D): - (GrMemoryAllocationChangedCallback): - (WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback): - (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged): - (WebCore::GraphicsContext3DPrivate::grContext): - (WebCore::GraphicsContext3DPrivate::markContextChanged): - (WebCore::GraphicsContext3DPrivate::layerComposited): - (WebCore::GraphicsContext3DPrivate::markLayerComposited): - (WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas): - (GraphicsContextLostCallbackAdapter): - (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter): - (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter): - (WebCore::GraphicsContextLostCallbackAdapter::onContextLost): - (WebCore::GraphicsContext3DPrivate::setContextLostCallback): - (GraphicsErrorMessageCallbackAdapter): - (WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter): - (WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter): - (WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage): - (WebCore::GraphicsContext3DPrivate::setErrorMessageCallback): - (WebCore::GraphicsContext3DPrivate::getExtensions): - (WebCore::GraphicsContext3DPrivate::initializeExtensions): - (WebCore::GraphicsContext3DPrivate::supportsExtension): - (WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled): - (WebCore::GraphicsContext3DPrivate::isExtensionEnabled): - (WebCore::GraphicsContext3DPrivate::isResourceSafe): - (GraphicsContext3DSwapBuffersCompleteCallbackAdapter): - (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter): - (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter): - (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete): - (WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM): - (GraphicsContext3DMemoryAllocationChangedCallbackAdapter): - (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter): - (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter): - (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged): - (WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM): - * src/GraphicsContext3DPrivate.h: - (GraphicsContext3DPrivate): - (WebCore::GraphicsContext3DPrivate::webContext): - (WebCore::GraphicsContext3DPrivate::preserveDrawingBuffer): - -2012-06-06 Sadrul Habib Chowdhury <sadrul@chromium.org> - - [chromium] Avoid limiting page-scale-factor when device-scale-factor is applied in the compositor. - https://bugs.webkit.org/show_bug.cgi?id=88417 - - Reviewed by James Robinson. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - -2012-06-06 Ami Fischman <fischman@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-06 Nico Weber <thakis@chromium.org> - - [chromium] Expose setPictographFontFamily through the chromium webkit api. - https://bugs.webkit.org/show_bug.cgi?id=88393 - - Reviewed by Adam Barth. - - This was added to WebCore in - https://bugs.webkit.org/show_bug.cgi?id=65197 - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setPictographFontFamily): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-06-06 Ryosuke Niwa <rniwa@webkit.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-06 Kinuko Yasuda <kinuko@chromium.org> - - Roll Chromium DEPS from r140700 to r140711. - - * DEPS: - -2012-06-06 Ami Fischman <fischman@chromium.org> - - [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349 - https://bugs.webkit.org/show_bug.cgi?id=88388 - - Reviewed by Darin Fisher. - - * public/WebMediaPlayer.h: - -2012-06-05 Ryosuke Niwa <rniwa@webkit.org> - - Roll Chromium DEPS from r140653 to r140700. - - * DEPS: - -2012-06-05 Kentaro Hara <haraken@chromium.org> - - Unreviewed, rolling out r119494. - http://trac.webkit.org/changeset/119494 - https://bugs.webkit.org/show_bug.cgi?id=87911 - - We found similar APIs are already implemented - - * public/WebWidget.h: - * src/WebViewImpl.cpp: - * src/WebViewImpl.h: - (WebViewImpl): - * tests/WebViewTest.cpp: - * tests/data/textarea.html: Removed. - -2012-06-05 Ryosuke Niwa <rniwa@webkit.org> - - Roll Chromium DEPS from r140528 to r140653. - - * DEPS: - -2012-06-05 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move createLocalStorageNamespace to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=85766 - - Reviewed by James Robinson. - - Part of a refactoring series. See tracking bug 82948. - - * WebKit.gyp: - * public/WebStorageArea.h: - * public/WebStorageNamespace.h: - * public/platform/WebKitPlatformSupport.h: - (WebKit): - (WebKitPlatformSupport): - -2012-06-05 Greg Billock <gbillock@google.com> - - New constructor for WebIntent to be used for delivery - https://bugs.webkit.org/show_bug.cgi?id=87143 - - Reviewed by Darin Fisher. - - When delivering an intent to webkit, the caller needs to be able to - provide the action, type, and data, and also extra data and ports. - - * public/WebIntent.h: - (WebIntent): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::deliverIntent): - * src/WebIntent.cpp: - (WebKit::WebIntent::WebIntent): - (WebKit): - (WebKit::WebIntent::reset): - (WebKit::WebIntent::messagePortChannelsRelease): - -2012-06-05 Ryosuke Niwa <rniwa@webkit.org> - - Roll Chromium DEPS from r140492 to r140528. - - * DEPS: - -2012-06-05 Seigo Nonaka <nona@chromium.org> - - [chromium] There is no way to retrieve composition character rectangle in WebKit/chromium - https://bugs.webkit.org/show_bug.cgi?id=87911 - - Reviewed by Ryosuke Niwa. - - Add an API for retreieving each character bounds in composition text. - This API is necessary for implementing IMR_QUERYCHARPOSITION message in Windows. - The message is used by Japanese IME for showing their window at the correct position. - - * public/WebWidget.h: - (WebWidget): - (WebKit::WebWidget::compositionCharacterBounds): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::compositionCharacterBounds): - (WebKit): - * src/WebViewImpl.h: - (WebViewImpl): - -2012-06-05 Dongwoo Im <dw.im@samsung.com> - - Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'. - https://bugs.webkit.org/show_bug.cgi?id=73176 - - Reviewed by Adam Barth. - - Two more APIs are added in Custom Scheme Handler specification. - http://dev.w3.org/html5/spec/Overview.html#custom-handlers - One is 'isProtocolHandlerRegistered' to query whether the specific URL - is registered or not. - The other is 'unregisterProtocolHandler' to remove the registered URL. - - * features.gypi: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'. - -2012-06-05 Kent Tamura <tkent@chromium.org> - - Move some function definitions in EmptyClients.h to EmptyClients.cpp - https://bugs.webkit.org/show_bug.cgi?id=88285 - - Reviewed by Ryosuke Niwa. - - * src/WebHelperPluginImpl.cpp: Remove unnecessary #includes, and add necessary #includes. - * src/WebPagePopupImpl.cpp: ditto. - -2012-06-05 Noel Gordon <noel.gordon@gmail.com> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-05 Adam Barth <abarth@webkit.org> - - EventHandler shouldn't dispatch fake mousemove events when scrolling on devices that don't have a mouse - https://bugs.webkit.org/show_bug.cgi?id=88270 - - Reviewed by James Robinson. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setDeviceSupportsMouse): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-06-04 Dana Jansens <danakj@chromium.org> - - [chromium] Remove redundant setNeedsCommit when prepareToDraw fails - https://bugs.webkit.org/show_bug.cgi?id=88246 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostImplTest.cpp: - -2012-06-04 Dana Jansens <danakj@chromium.org> - - [chromium] Allow CCLayerImpl to find its layer tree host, and use this for CCVideoLayerImpl instead of always-null pointer. - https://bugs.webkit.org/show_bug.cgi?id=88252 - - Reviewed by James Robinson. - - * tests/ScrollbarLayerChromiumTest.cpp: - (WebCore::TEST): - * tests/TreeSynchronizerTest.cpp: - (WebKitTests::expectTreesAreIdentical): - (WebKitTests::TEST): - -2012-06-04 Ryosuke Niwa <rniwa@webkit.org> - - yet another build fix attempt. - - * src/WebHelperPluginImpl.cpp: - -2012-06-04 Ryosuke Niwa <rniwa@webkit.org> - - Another Chromium Windows build fix attempt after r119411. - - * src/WebHelperPluginImpl.cpp: - -2012-06-04 Shawn Singh <shawnsingh@chromium.org> - - [chromium] CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer needs to be cleaner - https://bugs.webkit.org/show_bug.cgi?id=85245 - - Reviewed by James Robinson. - - Updated CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer - so that the test is clearer and cleaner. The original test was - covering what it needed, but in a confusing and not-so-practical - way. This patch adds comments and performs a tighter test so that - the intent is a bit more clear. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::TEST_F): - -2012-06-04 Ryosuke Niwa <rniwa@webkit.org> - - Fix attempt after r119411. - - * src/WebHelperPluginImpl.cpp: - -2012-06-04 Sadrul Habib Chowdhury <sadrul@chromium.org> - - [chromium] Fix software rendering for larger device-scale-factor - https://bugs.webkit.org/show_bug.cgi?id=88136 - - Reviewed by Darin Fisher. - - The fix is to apply the device-scale factor on the GraphicsContext. - (and add a WebWidgetClient::deviceScaleFactor method to facilitate that). - - * public/WebWidgetClient.h: - (WebWidgetClient): - (WebKit::WebWidgetClient::deviceScaleFactor): - * src/PageWidgetDelegate.cpp: - (WebKit::PageWidgetDelegate::paint): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::paint): - -2012-06-04 Sadrul Habib Chowdhury <sadrul@chromium.org> - - Combobox options and autofill options should not be scaled for device-scale factor. - https://bugs.webkit.org/show_bug.cgi?id=87921 - - Reviewed by Darin Fisher. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::applyAutofillSuggestions): - -2012-06-04 Dana Jansens <danakj@chromium.org> - - [chromium] Make LayerRendererChromium use RenderPasses instead of RenderSurfaces - https://bugs.webkit.org/show_bug.cgi?id=88132 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostImplTest.cpp: - * tests/LayerRendererChromiumTest.cpp: - (FakeCCRendererClient::FakeCCRendererClient): - (FakeCCRendererClient::rootRenderPass): - (FakeCCRendererClient): - (TEST_F): - -2012-06-04 David Dorwin <ddorwin@chromium.org> - - Enable Chromium media player to instantiate a plugin - https://bugs.webkit.org/show_bug.cgi?id=87399 - - Reviewed by Kent Tamura. - - Adds WebHelperPlugin, an off-screen widget that contains an <object> tag. - - * WebKit.gyp: - * public/WebHelperPlugin.h: Copied from Source/WebKit/chromium/public/WebPopupType.h. - (WebKit): - (WebHelperPlugin): - (WebKit::WebHelperPlugin::~WebHelperPlugin): - * public/WebMediaPlayerClient.h: - (WebKit): - * public/WebPopupType.h: - * public/WebView.h: - * public/WebViewClient.h: - (WebKit): - (WebViewClient): - (WebKit::WebViewClient::initializeHelperPluginWebFrame): - * src/WebFrameImpl.cpp: - (WebKit::WebFrameImpl::WebFrameImpl): - (WebKit::WebFrameImpl::initializeAsMainFrame): - * src/WebFrameImpl.h: - (WebFrameImpl): - * src/WebHelperPluginImpl.cpp: Added. - (WebKit): - (WebKit::addString): - (WebKit::writeDocument): - (HelperPluginChromeClient): - (WebKit::HelperPluginChromeClient::HelperPluginChromeClient): - (WebKit::WebHelperPluginImpl::WebHelperPluginImpl): - (WebKit::WebHelperPluginImpl::~WebHelperPluginImpl): - (WebKit::WebHelperPluginImpl::init): - (WebKit::WebHelperPluginImpl::initializeFrame): - (WebKit::WebHelperPluginImpl::initPage): - (WebKit::WebHelperPluginImpl::setCompositorSurfaceReady): - (WebKit::WebHelperPluginImpl::composite): - (WebKit::WebHelperPluginImpl::layout): - (WebKit::WebHelperPluginImpl::setFocus): - (WebKit::WebHelperPluginImpl::close): - (WebKit::WebHelperPluginImpl::closeHelperPlugin): - (WebKit::WebHelperPlugin::create): - * src/WebHelperPluginImpl.h: Copied from Source/WebKit/chromium/public/WebPopupType.h. - (WebCore): - (WebKit): - (WebHelperPluginImpl): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl): - (WebKit::WebMediaPlayerClientImpl::createHelperPlugin): - (WebKit): - (WebKit::WebMediaPlayerClientImpl::closeHelperPlugin): - * src/WebMediaPlayerClientImpl.h: - (WebKit): - (WebMediaPlayerClientImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::initializeMainFrame): - (WebKit::WebViewImpl::initializeHelperPluginFrame): - (WebKit): - (WebKit::WebViewImpl::createHelperPlugin): - * src/WebViewImpl.h: - (WebKit): - (WebViewImpl): - -2012-06-04 Raymes Khoury <raymes@chromium.org> - - Remove obsolete acceptMIMETypes member. - https://bugs.webkit.org/show_bug.cgi?id=88241 - - Reviewed by Darin Fisher. - - Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=87271 and http://codereview.chromium.org/10414085/. - - * public/WebFileChooserParams.h: - (WebFileChooserParams): - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::runOpenPanel): - -2012-06-04 Zeev Lieber <zlieber@chromium.org> - - [chromium] Cleanup scissor rect computation/use with damage - https://bugs.webkit.org/show_bug.cgi?id=87167 - - Reviewed by Adrienne Walker. - - Added unit tests to CCLayerTreeHostImpl using mock graphic context - to verify end-to-end quad drawing. - - Added more test cases to CCLayerTreeHostCommon to verify clip and - scissor rect computations. - - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::executeCalculateDrawTransformsAndVisibility): - * tests/CCLayerIteratorTest.cpp: - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostImplTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc): - * tests/CCRenderSurfaceTest.cpp: - -2012-06-03 Ryosuke Niwa <rniwa@webkit.org> - - Roll Chromium DEPS from r140222 to r140260. - - * DEPS: - -2012-06-03 Ryosuke Niwa <rniwa@webkit.org> - - Roll Chromium DEPS from r140000 to r140222. - - * DEPS: - -2012-06-03 Varun Jain <varunjain@google.com> - - [chromium] Add new gesture type (two finger tap) that triggers context menu. - https://bugs.webkit.org/show_bug.cgi?id=88173 - - Reviewed by Adam Barth. - - * public/WebInputEvent.h: - * src/PageWidgetDelegate.cpp: - (WebKit::PageWidgetDelegate::handleInputEvent): - * src/WebInputEventConversion.cpp: - (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): - * src/WebPopupMenuImpl.cpp: - (WebKit::WebPopupMenuImpl::handleInputEvent): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleGestureEvent): - -2012-06-03 Robert Kroeger <rjkroege@chromium.org> - - [chromium] replace isScrollGestureEventType with isGestureEventType - https://bugs.webkit.org/show_bug.cgi?id=88097 - - This change replaces the unused and incorrect isScrollGestureEventType - method with a correct and useful isGestureEventType method. - - Reviewed by Adam Barth. - - * public/WebInputEvent.h: - (WebInputEvent): - (WebKit::WebInputEvent::isGestureEventType): - -2012-06-01 Alexandre Elias <aelias@google.com> - - [chromium] Software compositor initialization and base classes - https://bugs.webkit.org/show_bug.cgi?id=87920 - - Reviewed by James Robinson. - - Add a new setting to force software compositing. In this mode, - no GraphicsContext3D should ever be created. - - * public/WebSettings.h: - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::Settings::operator CCSettings): - (WebKit::WebLayerTreeView::context): - * src/WebLayerTreeViewImpl.cpp: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::WebSettingsImpl): - (WebKit::WebSettingsImpl::setForceSoftwareCompositing): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - (WebKit::WebSettingsImpl::forceSoftwareCompositing): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): - (WebKit::WebViewImpl::createCompositorGraphicsContext3D): - (WebKit::WebViewImpl::createContext3D): - * tests/CCLayerTreeHostImplTest.cpp: - (WebKitTests::CCLayerTreeHostImplTest::createContext): - (WebKitTests::TEST_F): - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread): - (WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread): - (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread): - (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread): - * tests/CCTiledLayerTestCommon.cpp: - (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect): - * tests/CCTiledLayerTestCommon.h: - (Texture): - (WebKitTests::FakeTextureCopier::copyTexture): - (WebKitTests::FakeTextureUploader::uploadTexture): - * tests/Canvas2DLayerChromiumTest.cpp: - (Canvas2DLayerChromiumTest::fullLifecycleTest): - * tests/FakeCCLayerTreeHostClient.h: - * tests/LayerRendererChromiumTest.cpp: - (FakeLayerRendererChromium::FakeLayerRendererChromium): - (LayerRendererChromiumTest::LayerRendererChromiumTest): - (LayerRendererChromiumTest): - (TEST): - * tests/TextureCopierTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - (WTF::TEST): - -2012-06-01 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r119283, r119287, and r119291. - http://trac.webkit.org/changeset/119283 - http://trac.webkit.org/changeset/119287 - http://trac.webkit.org/changeset/119291 - https://bugs.webkit.org/show_bug.cgi?id=88159 - - Not only broke compilation in the initial commit but also - broke LayerChromiumTest.basicCreateAndDestroy (Requested by - rniwa on #webkit). - - * tests/CCAnimationTestCommon.cpp: - (WebCore::addOpacityTransition): - (WebCore::addAnimatedTransform): - (WebKitTests::FakeTransformTransition::getValue): - * tests/CCAnimationTestCommon.h: - * tests/CCKeyframedAnimationCurveTest.cpp: - * tests/CCLayerAnimationControllerTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted): - (WebKitTests::MockGraphicsLayerClient::notifySyncRequired): - (WebKitTests::MockGraphicsLayerClient::paintContents): - (WebKitTests::MockGraphicsLayerClient::showDebugBorders): - (WebKitTests::MockGraphicsLayerClient::showRepaintCounter): - (WebKitTests::TEST): - -2012-06-01 Ryosuke Niwa <rniwa@webkit.org> - - Use fully qualified name for Fixed to avoid the collision with "typedef SInt32 Fixed" in MacTypes.h - - * tests/GraphicsLayerChromiumTest.cpp: - (WebKitTests::TEST_F): - -2012-06-01 James Robinson <jamesr@chromium.org> - - [chromium] Unreviewed compile fix for r119283 - - For the record, Dana Jensens <danakj@chromium.org> wrote this slightly faster than I did. - - * tests/CCAnimationTestCommon.h: - -2012-06-01 Ian Vollick <vollick@chromium.org> - - [chromium] Accelerated animations should use WebTransformOperations - https://bugs.webkit.org/show_bug.cgi?id=87686 - - Reviewed by James Robinson. - - CCTransformKeyframe new owns a WebTransformOperations rather than a - TransformOperations. LayerChromium's API has been changed so that - LayerChromium::addAnimation should take only a CCActiveAnimation. - GraphicsLayerChromium is new responsible for translating to - WebTransformOperations and creating CCActiveAnimations. Tests that use - the public API (that is, they call addAnimation with KeyframeValueList - and Animation arguments) have been moved to GraphicsLayerChromiumTest. - - * tests/CCAnimationTestCommon.cpp: - (WebCore::addOpacityTransition): - (WebCore::addAnimatedTransform): - (WebKitTests::FakeTransformTransition::getValue): - * tests/CCAnimationTestCommon.h: - * tests/CCKeyframedAnimationCurveTest.cpp: - (WebCore::TEST): - * tests/CCLayerAnimationControllerTest.cpp: - (WebKitTests::TEST): - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): - * tests/GraphicsLayerChromiumTest.cpp: - (MockLayerTreeHostClient): - (WebKitTests): - (MockLayerTreeHost): - (WebKitTests::MockLayerTreeHost::create): - (WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl): - (WebKitTests::MockLayerTreeHost::MockLayerTreeHost): - (GraphicsLayerChromiumTest): - (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest): - (WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest): - (WebKitTests::GraphicsLayerChromiumTest::expectTranslateX): - (WebKitTests::TEST_F): - -2012-06-01 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Call clipboard methods directly - https://bugs.webkit.org/show_bug.cgi?id=88038 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/AssertMatchingEnums.cpp: - * src/PlatformSupport.cpp: - (WebCore::getCookieJar): - -2012-06-01 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-06-01 Yoshifumi Inoue <yosin@chromium.org> - - [Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order - https://bugs.webkit.org/show_bug.cgi?id=88044 - - Reviewed by Kent Tamura. - - * tests/DecimalTest.cpp: - (TEST_F): Add a new test for multiplication. - -2012-05-31 Hajime Morrita <morrita@chromium.org> - - REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac - https://bugs.webkit.org/show_bug.cgi?id=86859 - - Removed a port specific fix which was introduced at r117572. - - Reviewed by Ryosuke Niwa. - - * src/EditorClientImpl.cpp: - (WebKit::EditorClientImpl::frameWillDetachPage): - (WebKit::EditorClientImpl::requestCheckingOfString): - * src/EditorClientImpl.h: - (WebCore): - (EditorClientImpl): - * src/WebTextCheckingCompletionImpl.cpp: - (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText): - (WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText): - * src/WebTextCheckingCompletionImpl.h: - (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl): - (WebTextCheckingCompletionImpl): - -2012-05-31 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r119146. - http://trac.webkit.org/changeset/119146 - https://bugs.webkit.org/show_bug.cgi?id=88035 - - android breakage fixed in http://crrev.com/139945 (Requested - by fischman on #webkit). - - * public/WebMediaPlayer.h: - (WebMediaPlayer): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::didLoadingProgress): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-05-31 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Migrate to WebTransformationMatrix - https://bugs.webkit.org/show_bug.cgi?id=87788 - - Reviewed by James Robinson. - - * src/WebLayer.cpp: - (WebKit::WebLayer::setSublayerTransform): - (WebKit::WebLayer::setTransform): - * tests/CCAnimationTestCommon.cpp: - (WebKitTests::FakeTransformTransition::getValue): - * tests/CCAnimationTestCommon.h: - * tests/CCDamageTrackerTest.cpp: - (WebKitTests::executeCalculateDrawTransformsAndVisibility): - (WebKitTests::TEST_F): - * tests/CCKeyframedAnimationCurveTest.cpp: - * tests/CCLayerAnimationControllerTest.cpp: - * tests/CCLayerImplTest.cpp: - (WebCore::TEST): - * tests/CCLayerIteratorTest.cpp: - * tests/CCLayerSorterTest.cpp: - * tests/CCLayerTreeHostCommonTest.cpp: - * tests/CCLayerTreeHostTest.cpp: - (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread): - (WTF::setLayerPropertiesForTesting): - (WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest): - (WTF::setTestLayerPropertiesForTesting): - (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest): - (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest): - (WTF::CCLayerTreeHostTestManySurfaces::beginTest): - * tests/CCLayerTreeTestCommon.h: - (WebKitTests): - * tests/CCMathUtilTest.cpp: - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTest::createRoot): - (WebKitTests::CCOcclusionTrackerTest::createLayer): - (WebKitTests::CCOcclusionTrackerTest::createSurface): - (WebKitTests::CCOcclusionTrackerTest::createDrawingLayer): - (WebKitTests::CCOcclusionTrackerTest::createReplicaLayer): - (WebKitTests::CCOcclusionTrackerTest::createDrawingSurface): - (CCOcclusionTrackerTest): - (WebKitTests::CCOcclusionTrackerTest::setBaseProperties): - (WebKitTests::CCOcclusionTrackerTest::setProperties): - (WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): - (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): - (WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest): - (WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest): - (WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest): - * tests/CCQuadCullerTest.cpp: - * tests/CCRenderSurfaceTest.cpp: - * tests/FloatQuadTest.cpp: - * tests/LayerChromiumTest.cpp: - * tests/LinkHighlightTest.cpp: - * tests/TiledLayerChromiumTest.cpp: - * tests/WebTransformationMatrixTest.cpp: - (WebKit::TEST): - (WebKit): - -2012-05-31 Ian Vollick <vollick@chromium.org> - - [chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized - https://bugs.webkit.org/show_bug.cgi?id=87873 - - Reviewed by James Robinson. - - When the layer renderer fails to initialize, be sure to stop the animation timer. - - * tests/CCLayerTreeHostTest.cpp: - (CompositorFakeWebGraphicsContext3DWithTextureTracking): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures): - (WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking): - (WTF): - (WTF::TestHooks::didRecreateContext): - (TestHooks): - (WTF::TestHooks::createContext): - (CCLayerTreeHostTest): - (WTF::CCLayerTreeHostTest::clearEndTestTask): - (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): - (EndTestTask): - (WTF::CCLayerTreeHostTest::EndTestTask::EndTestTask): - (WTF::CCLayerTreeHostTest::EndTestTask::~EndTestTask): - (WTF::CCLayerTreeHostTest::EndTestTask::clearTest): - (WTF::CCLayerTreeHostTest::EndTestTask::run): - (WTF::CCLayerTreeHostTest::runTest): - (WTF::CCLayerTreeHostTest::endTestAfterDelay): - (FakeWebGraphicsContext3DMakeCurrentFails): - (WTF::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent): - (CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation): - (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation): - (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::beginTest): - (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers): - (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext): - (WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::afterTest): - (WTF::TEST_F): - -2012-05-15 Brett Wilson <brettw@chromium.org> - - Hook up GTK IsKeyPad flag for keyboard events, and preserve this flag - on all platforms when converting back to a WebKeyboardEvent. - - https://bugs.webkit.org/show_bug.cgi?id=86514 - - Reviewed by Dimitri Glazkov. - - * src/WebInputEventConversion.cpp: - (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder): - * src/gtk/WebInputEventFactory.cpp: - (WebKit::WebInputEventFactory::keyboardEvent): - * tests/WebInputEventFactoryTestGtk.cpp: - -2012-05-31 Alec Flett <alecflett@chromium.org> - - IndexedDB: Implement IDBTransaction.error and IDBRequest.error - https://bugs.webkit.org/show_bug.cgi?id=87865 - - Reviewed by Tony Chang. - - IDBDatabaseError now honors IDB-specific DOMException codes, - so make sure that's how they are passed to/from chromium. - - * src/WebIDBDatabaseError.cpp: - (WebKit::WebIDBDatabaseError::assign): - -2012-05-31 James Robinson <jamesr@chromium.org> - - [chromium] Assertion failures during compositor startup in lost context situations - https://bugs.webkit.org/show_bug.cgi?id=87912 - - Reviewed by Adrienne Walker. - - Adds a unit test verifying that even if we lose our context during or before initialization we get through the - rest of the path without failing ASSERT()s. - - * tests/LayerRendererChromiumTest.cpp: - (LoseContextOnFirstGetContext): - (LoseContextOnFirstGetContext::LoseContextOnFirstGetContext): - (TEST): - -2012-05-31 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r119125. - http://trac.webkit.org/changeset/119125 - https://bugs.webkit.org/show_bug.cgi?id=88007 - - Will break android build if rolled (Requested by rafaelw_ on - #webkit). - - * public/WebMediaPlayer.h: - (WebMediaPlayer): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::bytesLoaded): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-05-31 Dana Jansens <danakj@chromium.org> - - [chromium] Move drawing code for RenderSurfaces into LayerRendererChromium - https://bugs.webkit.org/show_bug.cgi?id=87877 - - Reviewed by James Robinson. - - * tests/CCRenderSurfaceTest.cpp: - (WebCore::TEST): - -2012-05-31 Ami Fischman <fischman@chromium.org> - - Replace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress() - https://bugs.webkit.org/show_bug.cgi?id=86113 - - Reviewed by Eric Carlson. - - * public/WebMediaPlayer.h: - (WebMediaPlayer): - * src/WebMediaPlayerClientImpl.cpp: - (WebKit::WebMediaPlayerClientImpl::didLoadingProgress): - * src/WebMediaPlayerClientImpl.h: - (WebMediaPlayerClientImpl): - -2012-05-31 Ian Vollick <vollick@chromium.org> - - [chromium] create WebTransformOperation interface for chromium platform - https://bugs.webkit.org/show_bug.cgi?id=87510 - - Reviewed by James Robinson. - - * WebKit.gypi: - * tests/WebTransformOperationsTest.cpp: Added. - (TEST): - (checkProgress): - -2012-05-31 Alexander Pavlov <apavlov@chromium.org> - - Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint - https://bugs.webkit.org/show_bug.cgi?id=87871 - - Reviewed by Yury Semikhatsky. - - When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report - these events as NOT handled by the WebKit, so that the browser can handle them appropriately - (on MacOS, switching between the application windows is done through the default key event handler, so if you run - event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`). - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::handleInputEvent): - -2012-05-31 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-05-30 Peter Beverloo <peter@chromium.org> - - [Chromium] Automatically install 64-bit linker for Android - https://bugs.webkit.org/show_bug.cgi?id=79780 - - Reviewed by Adam Barth. - - Change the Android-specific dependencies to inherit their revision from - Chromium's DEPS file, like many other dependencies do, solving the - versioning problem that we're running in to right now. These are listed - in Chromium's main DEPS file starting Chromium r139529. - - * DEPS: - -2012-05-31 Yoshifumi Inoue <yosin@chromium.org> - - Build fix for Chromium Linux (Tests) after r119073. - - * tests/DecimalTest.cpp: - (TEST_F): - -2012-05-31 Yoshifumi Inoue <yosin@chromium.org> - - [Platform] Introduce Decimal class for Number/Range input type. - https://bugs.webkit.org/show_bug.cgi?id=87360 - - Reviewed by Kent Tamura. - - This patch added unit test for Decimal class. - - * WebKit.gypi: - * tests/DecimalTest.cpp: Added. - (WebCore): - (WebCore::operator<<): Output Decimal for unit test debugging - (DecimalStepRange): - (DecimalStepRange::DecimalStepRange): - (DecimalStepRange::clampValue): - (DecimalTest): - (DecimalTest::encode): - (DecimalTest::fromString): - (DecimalTest::stepDown): - (DecimalTest::stepUp): - (TEST_F): - -2012-05-30 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: add MemoryUsageSupport::processMemorySizesInBytes - https://bugs.webkit.org/show_bug.cgi?id=87830 - - Reviewed by James Robinson. - - * public/platform/WebKitPlatformSupport.h: pulled getProcessMemorySize up - to the Source/Platform/chromium/public/Platform.h - * src/PlatformSupport.cpp: - -2012-05-31 Kent Tamura <tkent@chromium.org> - - Unreviewed, rolling out r119062 and r119064. - http://trac.webkit.org/changeset/119062 - http://trac.webkit.org/changeset/119064 - https://bugs.webkit.org/show_bug.cgi?id=87360 - - Broke build on Lion, SnowLoepard, Chromium Windows, and - Chromium Linux 32 - - * WebKit.gypi: - * tests/DecimalTest.cpp: Removed. - -2012-05-30 Yoshifumi Inoue <yosin@chromium.org> - - [Platform] Introduce Decimal class for Number/Range input type. - https://bugs.webkit.org/show_bug.cgi?id=87360 - - Reviewed by Kent Tamura. - - This patch added unit test for Decimal class. - - * WebKit.gypi: - * tests/DecimalTest.cpp: Added. - (WebCore): - (WebCore::operator<<): Output Decimal for unit test debugging - (DecimalStepRange): - (DecimalStepRange::DecimalStepRange): - (DecimalStepRange::clampValue): - (DecimalTest): - (DecimalTest::encode): - (DecimalTest::fromString): - (DecimalTest::stepDown): - (DecimalTest::stepUp): - (TEST_F): - -2012-05-30 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Fix min/max bounds error in CCMathUtil.cpp - https://bugs.webkit.org/show_bug.cgi?id=87915 - - Reviewed by James Robinson. - - * tests/CCMathUtilTest.cpp: - (WebCore::TEST): - (WebCore): - -2012-05-30 Ami Fischman <fischman@chromium.org> - - Roll chromium DEPS from r139300 to r139542. Unreviewed. - https://bugs.webkit.org/show_bug.cgi?id=87868 - - * DEPS: - -2012-05-30 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Call fileUtilities methods directly - https://bugs.webkit.org/show_bug.cgi?id=87852 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-05-30 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r118986. - http://trac.webkit.org/changeset/118986 - https://bugs.webkit.org/show_bug.cgi?id=87914 - - Caused several IndexedDB browser_test failures on Chromium - canary builders (Requested by rafaelw_ on #webkit). - - * src/WebIDBDatabaseError.cpp: - (WebKit::WebIDBDatabaseError::assign): - -2012-05-30 Dominic Mazzoni <dmazzoni@google.com> - - AX: Chromium WebAccessibilityObject should check if an AccessibilityObject is detached - https://bugs.webkit.org/show_bug.cgi?id=87778 - - Reviewed by Adam Barth. - - Pretty simple - all places that previously just checked for null - now also check if the wrapped AccessibilityObject is detached. - - * public/WebAccessibilityObject.h: - (WebAccessibilityObject): - * src/WebAccessibilityObject.cpp: - (WebKit::WebAccessibilityObject::isDetached): - (WebKit): - (WebKit::WebAccessibilityObject::axID): - (WebKit::WebAccessibilityObject::accessibilityDescription): - (WebKit::WebAccessibilityObject::actionVerb): - (WebKit::WebAccessibilityObject::canSetFocusAttribute): - (WebKit::WebAccessibilityObject::canSetValueAttribute): - (WebKit::WebAccessibilityObject::isValid): - (WebKit::WebAccessibilityObject::childCount): - (WebKit::WebAccessibilityObject::childAt): - (WebKit::WebAccessibilityObject::firstChild): - (WebKit::WebAccessibilityObject::focusedChild): - (WebKit::WebAccessibilityObject::lastChild): - (WebKit::WebAccessibilityObject::nextSibling): - (WebKit::WebAccessibilityObject::parentObject): - (WebKit::WebAccessibilityObject::previousSibling): - (WebKit::WebAccessibilityObject::canSetSelectedAttribute): - (WebKit::WebAccessibilityObject::isAnchor): - (WebKit::WebAccessibilityObject::isAriaReadOnly): - (WebKit::WebAccessibilityObject::isButtonStateMixed): - (WebKit::WebAccessibilityObject::isChecked): - (WebKit::WebAccessibilityObject::isCollapsed): - (WebKit::WebAccessibilityObject::isControl): - (WebKit::WebAccessibilityObject::isEnabled): - (WebKit::WebAccessibilityObject::isFocused): - (WebKit::WebAccessibilityObject::isHovered): - (WebKit::WebAccessibilityObject::isIndeterminate): - (WebKit::WebAccessibilityObject::isLinked): - (WebKit::WebAccessibilityObject::isLoaded): - (WebKit::WebAccessibilityObject::isMultiSelectable): - (WebKit::WebAccessibilityObject::isOffScreen): - (WebKit::WebAccessibilityObject::isPasswordField): - (WebKit::WebAccessibilityObject::isPressed): - (WebKit::WebAccessibilityObject::isReadOnly): - (WebKit::WebAccessibilityObject::isRequired): - (WebKit::WebAccessibilityObject::isSelected): - (WebKit::WebAccessibilityObject::isSelectedOptionActive): - (WebKit::WebAccessibilityObject::isVertical): - (WebKit::WebAccessibilityObject::isVisible): - (WebKit::WebAccessibilityObject::isVisited): - (WebKit::WebAccessibilityObject::accessKey): - (WebKit::WebAccessibilityObject::ariaHasPopup): - (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic): - (WebKit::WebAccessibilityObject::ariaLiveRegionBusy): - (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant): - (WebKit::WebAccessibilityObject::ariaLiveRegionStatus): - (WebKit::WebAccessibilityObject::boundingBox): - (WebKit::WebAccessibilityObject::estimatedLoadingProgress): - (WebKit::WebAccessibilityObject::helpText): - (WebKit::WebAccessibilityObject::headingLevel): - (WebKit::WebAccessibilityObject::hierarchicalLevel): - (WebKit::WebAccessibilityObject::hitTest): - (WebKit::WebAccessibilityObject::keyboardShortcut): - (WebKit::WebAccessibilityObject::performDefaultAction): - (WebKit::WebAccessibilityObject::roleValue): - (WebKit::WebAccessibilityObject::selectionEnd): - (WebKit::WebAccessibilityObject::selectionStart): - (WebKit::WebAccessibilityObject::setFocused): - (WebKit::WebAccessibilityObject::stringValue): - (WebKit::WebAccessibilityObject::title): - (WebKit::WebAccessibilityObject::titleUIElement): - (WebKit::WebAccessibilityObject::url): - (WebKit::WebAccessibilityObject::valueDescription): - (WebKit::WebAccessibilityObject::valueForRange): - (WebKit::WebAccessibilityObject::maxValueForRange): - (WebKit::WebAccessibilityObject::minValueForRange): - (WebKit::WebAccessibilityObject::node): - (WebKit::WebAccessibilityObject::document): - (WebKit::WebAccessibilityObject::hasComputedStyle): - (WebKit::WebAccessibilityObject::computedStyleDisplay): - (WebKit::WebAccessibilityObject::accessibilityIsIgnored): - (WebKit::WebAccessibilityObject::lineBreaks): - (WebKit::WebAccessibilityObject::columnCount): - (WebKit::WebAccessibilityObject::rowCount): - -2012-05-30 Shawn Singh <shawnsingh@chromium.org> - - Simplify TransformationMatrix rotation code to improve precision - https://bugs.webkit.org/show_bug.cgi?id=86666 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - (WebKitTests::TEST): - * tests/WebTransformationMatrixTest.cpp: - (WebKit::TEST): - (WebKit): - -2012-05-30 Alec Flett <alecflett@chromium.org> - - IndexedDB: Implement IDBTransaction.error and IDBRequest.error - https://bugs.webkit.org/show_bug.cgi?id=87865 - - Reviewed by Tony Chang. - - IDBDatabaseError now honors IDB-specific DOMException codes, - so make sure that's how they are passed to/from chromium. - - * src/WebIDBDatabaseError.cpp: - (WebKit::WebIDBDatabaseError::assign): - -2012-05-30 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Merge shared code in CCOcclusionTrackerTest - https://bugs.webkit.org/show_bug.cgi?id=87798 - - Reviewed by Adrienne Walker. - - This patch simple uses a different existing macro function so that - the same thing doesn't exist in multiple places, and so that the - naming is more consistent with gtest's conventions. - - * tests/CCOcclusionTrackerTest.cpp: - (WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest): - (WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest): - (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest): - (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest): - (WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest): - (WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest): - (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest): - (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest): - (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest): - (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest): - (WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest): - -2012-05-30 Tony Chang <tony@chromium.org> - - [chromium] port webframe_unittest.cc to webkit_unit_tests - https://bugs.webkit.org/show_bug.cgi?id=87796 - - Reviewed by James Robinson. - - Move WebFrameTest.GetContentAsPlainText and WebFrameTest.GetFullHtmlOfPage to webkit_unit_tests. - - * tests/WebFrameTest.cpp: - (WebKit::TEST_F): - (WebKit): Add tests. - -2012-05-30 Jochen Eisinger <jochen@chromium.org> - - Match Firefox restrictions to window.blur and window.focus - https://bugs.webkit.org/show_bug.cgi?id=86969 - - Reviewed by Adam Barth. - - Allow window.focus() during the dispatch of the click event on - notifications. - - * src/WebNotification.cpp: - (WebKit::WebNotification::dispatchClickEvent): - -2012-05-29 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move fileExists to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=87531 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * src/PlatformSupport.cpp: - (WebCore): - -2012-05-29 Alec Flett <alecflett@chromium.org> - - IndexedDB: Align codes and names for IDB-specific and DOM-specific errors/exceptions - https://bugs.webkit.org/show_bug.cgi?id=87276 - - Reviewed by Tony Chang. - - * public/WebIDBDatabaseException.h: - * src/AssertMatchingEnums.cpp: - -2012-05-29 Rafael Weinstein <rafaelw@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-05-29 Dana Jansens <danakj@chromium.org> - - [chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect - https://bugs.webkit.org/show_bug.cgi?id=87677 - - Reviewed by Adrienne Walker. - - * tests/CCOcclusionTrackerTest.cpp: - (CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor): - (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest): - (WebKitTests): - -2012-05-29 David Barr <davidbarr@chromium.org> - - Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag - https://bugs.webkit.org/show_bug.cgi?id=87685 - - Reviewed by Eric Seidel. - - Add a configuration option for CSS image-resolution support, disabling it by default. - - * features.gypi: - -2012-05-29 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-05-29 Hironori Bono <hbono@chromium.org> - - Use WebSpellCheckClient::spellcheck to retrieve suggestions. - https://bugs.webkit.org/show_bug.cgi?id=87690 - - Reviewed by Hajime Morita. - - This change uses WebSpellCheckClient::spellcheck as a fallback method to - retrieve suggestions when a marker does not have any suggestions. (It consumes - lots of CPU power to get suggestions for misspelled word, i.e. Chromium cannot - afford to attach suggestions to all spelling markers.) - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Retrieve suggestions if markers do not have any. - -2012-05-28 Takashi Toyoshima <toyoshim@chromium.org> - - [WebSocket] Receiving reserved close codes, 1005, 1006, and 1015 must appear as code=1006 and wasClean=false - https://bugs.webkit.org/show_bug.cgi?id=87084 - - Reviewed by Kent Tamura. - - Update close event codes corresponding to WebSocketChannel::CloseEventCode. - - * public/WebSocket.h: Update on newly defined close event codes - -2012-05-28 MORITA Hajime <morrita@google.com> - - Rename FrameLoaderClient::shadowDOMAllowed() to allowShadowDOM() - https://bugs.webkit.org/show_bug.cgi?id=87101 - - Reviewed by Kentaro Hara. - - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::allowShadowDOM): - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - -2012-05-28 Rob Flack <flackr@chromium.org> - - [chromium] Only increase size of Combo Box Options when displayed on touch screen - https://bugs.webkit.org/show_bug.cgi?id=85921 - - Reviewed by Adam Barth. - - Adds a flag to set whether the current device is a touch screen, independent of whether touch events are supported and use this for the combo box sizing. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::defaultDeviceScaleFactor): - (WebKit): - (WebKit::WebSettingsImpl::setDeviceSupportsTouch): - (WebKit::WebSettingsImpl::deviceSupportsTouch): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::applyAutofillSuggestions): - * tests/PopupMenuTest.cpp: - (WebKit::SelectPopupMenuTest::SetUp): - (WebKit::SelectPopupMenuTest::TearDown): - (SelectPopupMenuTest): - (WebKit::TEST_F): - -2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> - - WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled - https://bugs.webkit.org/show_bug.cgi?id=42328 - - Reviewed by Eric Seidel. - - Removed private APIs that were only being used by DRT. - - * public/WebDevToolsAgent.h: - (WebDevToolsAgent): - * src/WebDevToolsAgentImpl.cpp: - * src/WebDevToolsAgentImpl.h: - (WebDevToolsAgentImpl): - -2012-05-28 Peter Beverloo <peter@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-05-28 Peter Beverloo <peter@chromium.org> - - [Chromium] Build fix for the Android bot, set CXX_target at gyp generation-time - https://bugs.webkit.org/show_bug.cgi?id=87649 - - Unreviewed build fix. - - Chromium Android builds were broken because v8 tried to compile files - for target with the "-m32" flag. This was caused by a v8 check falling - back to using "which g++" to find the right compiler, whereas it should - have used the $CXX_target environment variable. This isn't being set - for Android builds. - - * gyp_webkit: Set the CXX_target environment variable. Annotate the fix - with a FIXME comment too. - -2012-05-28 Keishi Hattori <keishi@webkit.org> - - Expose value localization function of HTMLInputElement - https://bugs.webkit.org/show_bug.cgi?id=84356 - - Reviewed by Kent Tamura. - - * public/WebInputElement.h: - (WebInputElement): - * src/WebInputElement.cpp: - (WebKit::WebInputElement::localizeValue): - (WebKit): - -2012-05-28 MORITA Hajime <morrita@google.com> - - Unreviewed Mac Chromium build fix. - - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::allowStyleScoped): - -2012-05-28 MORITA Hajime <morrita@google.com> - - https://bugs.webkit.org/show_bug.cgi?id=87609 - [Chromium] FrameLoaderClient::allowStyleScoped() should be implemented interms of WebPermissionClient - - Reviewed by Kent Tamura. - - Added allowStyleScoped() implementation which is essentially same as shadowDOMAllowed(). - - * src/FrameLoaderClientImpl.cpp: - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - -2012-05-25 Ryosuke Niwa <rniwa@webkit.org> - - Roll chromium DEPS from r139156 to r139184. - - * DEPS: - -2012-05-25 Garrett Casto <gcasto@chromium.org> - - Allow WebTextFieldDecoratorClient to see applied decorations. - https://bugs.webkit.org/show_bug.cgi?id=86557 - - Reviewed by Kent Tamura. - - * WebKit.gyp: Added new files. - * public/WebInputElement.h: - (WebKit::WebInputElement::decorationElementFor): Returns the - WebElement attached to the WebInputElement by the given - WebTextFieldDecoratorClient, if one exists. - * src/TextFieldDecoratorImpl.cpp: - (WebKit): - * src/TextFieldDecoratorImpl.h: - (TextFieldDecoratorImpl::decoratorClient): Get the - WebTextFieldDecoratorClient owned by this object. - -2012-05-25 Mihai Parparita <mihaip@chromium.org> - - Allow synchronous XHRs to be disabled in documents - https://bugs.webkit.org/show_bug.cgi?id=87540 - - Reviewed by Eric Seidel. - - Synchronous XMLHttpRequests are a problematic API, since they result - in blocked UI threads. Some clients may wish to always disable them; - give them a setting to do so (see also r103629 for other cases where - synchronous XHRs are disabled). - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setSyncXHRInDocumentsEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-05-25 Kinuko Yasuda <kinuko@chromium.org> - - [chromium] Deprecate FileUtilities::getFileSize and getFileModifiedTime in favor of getFileMetadata - https://bugs.webkit.org/show_bug.cgi?id=87492 - - Reviewed by Adam Barth. - - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::getFileMetadata): - -2012-05-25 Ryosuke Niwa <rniwa@webkit.org> - - Roll Chromium DEPS from r139024 to r139156 in an attempt to fix Chromium Win builds. - - * DEPS: - -2012-05-25 Mark Pilgrim <pilgrim@chromium.org> - - [Chomium] Move sandboxSupport to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=87518 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * WebKit.gyp: - * public/platform/WebKitPlatformSupport.h: - (WebKit): - (WebKitPlatformSupport): - * public/platform/android/WebSandboxSupport.h: - * public/platform/linux/WebFontFamily.h: - * public/platform/linux/WebSandboxSupport.h: - * public/platform/mac/WebSandboxSupport.h: - * public/platform/win/WebSandboxSupport.h: - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::ensureFontLoaded): - (WebCore::PlatformSupport::loadFont): - (WebCore::PlatformSupport::getFontFamilyForCharacters): - (WebCore::PlatformSupport::getRenderStyleForStrike): - -2012-05-25 Dana Jansens <danakj@chromium.org> - - [chromium] WebLayerTreeViewImpl should not hide methods in CCLayerTreeHost with signatures that match the Client interface - https://bugs.webkit.org/show_bug.cgi?id=87301 - - Reviewed by James Robinson. - - Most methods in the CCLayerTreeHostClient interface have a matching - method signature on CCLayerTreeHost that simply calls the client, if - one exists at all. However, CCLayerTreeHost::updateAnimations() does - important work in addition to calling the client. - - Currently WebLayerTreeViewImpl itself implements the interface for - CCLayerTreeHostClient as well as CCLayerTreeHost, and simply forwards - any call to a method in the client interface to its own client. This - blocks WebViewImpl from calling CCLayerTreeHost::updateAnimations, since - the method is also in the client interface. - - We change WebLayerTreeViewImpl to own a CCLayerTreeHost and a - WebLayerTreeHostClientAdapter. This fixes the shadowing by making - the two interfaces separate, and resolves lifetime issues by - ensuring that the CCLayerTreeHost is destroyed before its client. - - * src/WebLayerTreeView.cpp: - (WebKit::WebLayerTreeView::setSurfaceReady): - (WebKit::WebLayerTreeView::setRootLayer): - (WebKit::WebLayerTreeView::compositorIdentifier): - (WebKit::WebLayerTreeView::setViewportSize): - (WebKit::WebLayerTreeView::viewportSize): - (WebKit::WebLayerTreeView::setBackgroundColor): - (WebKit::WebLayerTreeView::setVisible): - (WebKit::WebLayerTreeView::setPageScaleFactorAndLimits): - (WebKit::WebLayerTreeView::startPageScaleAnimation): - (WebKit::WebLayerTreeView::setNeedsAnimate): - (WebKit::WebLayerTreeView::setNeedsRedraw): - (WebKit::WebLayerTreeView::commitRequested): - (WebKit::WebLayerTreeView::composite): - (WebKit::WebLayerTreeView::updateAnimations): - (WebKit::WebLayerTreeView::compositeAndReadback): - (WebKit::WebLayerTreeView::finishAllRendering): - (WebKit::WebLayerTreeView::context): - (WebKit::WebLayerTreeView::loseCompositorContext): - * src/WebLayerTreeViewImpl.cpp: - (WebKit): - (WebLayerTreeViewClientAdapter): - (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter): - (WebKit::WebLayerTreeViewClientAdapter::~WebLayerTreeViewClientAdapter): - (WebKit::WebLayerTreeViewImpl::create): - (WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl): - (WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl): - * src/WebLayerTreeViewImpl.h: - (WebCore): - (WebKit): - (WebKit::WebLayerTreeViewImpl::layerTreeHost): - (WebLayerTreeViewImpl): - -2012-05-25 Kinuko Yasuda <kinuko@chromium.org> - - Unreviewed; rolling chromium deps. - - * DEPS: - -2012-05-25 W. James MacLean <wjmaclean@chromium.org> - - [chromium] LayerChromium should recognise existing layer active animations when the layer is added. - https://bugs.webkit.org/show_bug.cgi?id=87166 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostTest.cpp: - (WTF::MockLayerTreeHost::didAddAnimationWasCalled): - (MockLayerTreeHost): - (WTF::MockLayerTreeHost::MockLayerTreeHost): - (WTF): - (CCLayerTreeHostTestLayerAddedWithAnimation): - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation): - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest): - (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::afterTest): - -2012-05-17 Andrey Kosyakov <caseq@chromium.org> - - [chromium] add instrumentation for compositing - https://bugs.webkit.org/show_bug.cgi?id=83928 - - Reviewed by James Robinson. - - - plumb willCommit() and didComposite() to inspector instrumentation via WebViewImpl. - - * WebKit.gypi: Added WebLayerTreeViewTest - * src/WebLayerTreeViewImpl.cpp: - (WebKit::WebLayerTreeViewImpl::didBeginFrame): - (WebKit): - (WebKit::WebLayerTreeViewImpl::willCommit): - * src/WebLayerTreeViewImpl.h: - (WebLayerTreeViewImpl): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::didBeginFrame): - (WebKit): - (WebKit::WebViewImpl::willCommit): - * src/WebViewImpl.h: - (WebViewImpl): - * tests/CCLayerTreeHostTest.cpp: - * tests/FakeCCLayerTreeHostClient.h: - * tests/WebLayerTest.cpp: - * tests/WebLayerTreeViewTest.cpp: Added. - -2012-05-25 Peter Beverloo <peter@chromium.org> - - [Chromium] Pull in Android tools from Chromium's repo through the DEPS file - https://bugs.webkit.org/show_bug.cgi?id=87478 - - Reviewed by Kent Tamura. - - Chromium's r122048 added the forwarder tool, which forwards a TCP port - listening on the device to a port on the host. This now is a required - dependency of DumpRenderTree, so pull it in. - - Since it's likely that more tools will be required, pull in the entire - tools/android/ directory in case the Chromium port for Android is being - checked out or updated. - - * DEPS: Added Android-specific dependency on tools/android/ - -2012-05-25 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r118461. - http://trac.webkit.org/changeset/118461 - https://bugs.webkit.org/show_bug.cgi?id=87468 - - Breaks two chromium browser_tests. (Requested by vsevik on - #webkit). - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::resize): - -2012-05-24 Tim Horton <timothy_horton@apple.com> - - Add feature defines for web-facing parts of CSS Regions and Exclusions - https://bugs.webkit.org/show_bug.cgi?id=87442 - <rdar://problem/10887709> - - Reviewed by Dan Bernstein. - - * features.gypi: - -2012-05-24 Kent Tamura <tkent@chromium.org> - - PAGE_POPUP: window.setValueAndClosePopup should be moved to a - per-context property of DOMWindow. - https://bugs.webkit.org/show_bug.cgi?id=87086 - - Reviewed by Adam Barth. - - * src/WebPagePopupImpl.cpp: - (WebKit): Add PagePopupFrameLoaderClient, which allows window.pagePopupController. - (WebKit::WebPagePopupImpl::initPage): - - Use PagePopupFrameLoaderClient - - Remove the call of ScriptController::installFunctionsForPagePopup(). - - Call DOMWindowPagePopup::install() to inform m_popupClient to a - DOMWindowPagePopup object for the DOMWindow. - -2012-05-21 Kinuko Yasuda <kinuko@chromium.org> - - Cleanup: add a file system call which captures the file metadata at once. - https://bugs.webkit.org/show_bug.cgi?id=86995 - - Reviewed by David Levin. - - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::getFileMetadata): - (WebCore): - -2012-05-24 Hironori Bono <hbono@chromium.org> - - Enable grammar checking on Chromium when we paste text (Take 2) - https://bugs.webkit.org/show_bug.cgi?id=74393 - - Reviewed by Ryosuke Niwa. - - This change enables grammar checking on Chromium and implements a mock grammar - checker to fix a failing test. - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Show suggestions when we right-click grammatically-misspelled words. - * src/EditorClientImpl.cpp: - (WebKit::EditorClientImpl::isGrammarCheckingEnabled): Enable grammar checking when we enable asynchronous spellchecking. - (WebKit::EditorClientImpl::checkGrammarOfString): set badGrammarLocation to -1 to avoid an assertion error. - * src/WebTextCheckingResult.cpp: - (WebKit::WebTextCheckingResult::operator TextCheckingResult): Fill GrammarDetails for grammatical errors. - -2012-05-24 Alexandre Elias <aelias@google.com> - - [chromium] Support mobile device rotation resizing - https://bugs.webkit.org/show_bug.cgi?id=86819 - - Reviewed by Adam Barth. - - Resizes on a mobile device are caused either by rotation or - on-screen-keyboard bringup, and need different treatment to remain - naturally laid out, scaled and scrolled without disorienting the user. - - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::resize): - -2012-05-24 Antoine Labour <piman@chromium.org> - - [chromium] Add a setForceRenderSurface to WebLayer for test/bench purpose - https://bugs.webkit.org/show_bug.cgi?id=87436 - - Reviewed by James Robinson. - - * src/WebLayer.cpp: - (WebKit::WebLayer::setForceRenderSurface): - (WebKit): - (WebKit::WebLayer::forceRenderSurface): - * tests/CCLayerTreeHostCommonTest.cpp: - (WebKitTests::TEST): - (WebKitTests): - * tests/LayerChromiumTest.cpp: - -2012-05-24 Adam Barth <abarth@webkit.org> - - Fix the chromium-android build. - - * features.gypi: - -2012-05-24 John Mellor <johnme@chromium.org> - - Font Boosting: Add compile flag and runtime setting - https://bugs.webkit.org/show_bug.cgi?id=87394 - - Reviewed by Adam Barth. - - Expose fontBoostingEnabled runtime setting via WebSettings. - - * features.gypi: - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setFontBoostingEnabled): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-05-24 Kinuko Yasuda <kinuko@chromium.org> - - Cleanup: introduce toFile() to reduce static cast from Blob to File - https://bugs.webkit.org/show_bug.cgi?id=87234 - - Reviewed by Eric Seidel. - - * src/WebDragData.cpp: - (WebKit::WebDragData::items): - -2012-05-24 Lu Guanqun <guanqun.lu@intel.com> - - use built-in data type DashArray - https://bugs.webkit.org/show_bug.cgi?id=87344 - - Reviewed by Eric Seidel. - - * tests/PlatformContextSkiaTest.cpp: - (WebCore::TEST): - -2012-05-24 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move queryLocalizedString to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=85762 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * WebKit.gyp: - * public/platform/WebKitPlatformSupport.h: - (WebKit::WebKitPlatformSupport::getPluginList): - * public/platform/WebLocalizedString.h: - * src/LocalizedStrings.cpp: - (WebCore::query): - -2012-05-24 Dana Jansens <danakj@chromium.org> - - [chromium] Only display frames created with memory allocations meant to be displayed - https://bugs.webkit.org/show_bug.cgi?id=85108 - - Reviewed by Adrienne Walker. - - Removing code to protect visible textures when a tab becomes invisible, - as we want to reduce our memory limit for invisible tabs and these - textures should not be saved. - - * src/NonCompositedContentHost.cpp: - * src/NonCompositedContentHost.h: - (NonCompositedContentHost): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::setVisibilityState): - * tests/CCLayerTreeHostTest.cpp: - (WTF::TestHooks::didCommit): - (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest): - (WTF::CCLayerTreeHostTest::scheduleComposite): - (WTF::CCLayerTreeHostTest::dispatchComposite): - (CCLayerTreeHostTest): - (WTF::CCLayerTreeHostTest::doBeginTest): - (CCLayerTreeHostTestTickAnimationWhileBackgrounded): - (WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::willAnimateLayers): - (CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread): - (WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest): - (WTF): - -2012-05-24 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r118352. - http://trac.webkit.org/changeset/118352 - https://bugs.webkit.org/show_bug.cgi?id=87390 - - Caused 6 editing/spelling tests crash/fail on chromium in - debug. (Requested by vsevik on #webkit). - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): - * src/EditorClientImpl.cpp: - (WebKit::EditorClientImpl::isGrammarCheckingEnabled): - * src/WebTextCheckingResult.cpp: - (WebKit::WebTextCheckingResult::operator TextCheckingResult): - -2012-05-24 Ian Vollick <vollick@chromium.org> - - [chromium] Forcibly sync running animations in the waiting state when synchronized start times are needed. - https://bugs.webkit.org/show_bug.cgi?id=87153 - - Reviewed by James Robinson. - - * tests/CCLayerAnimationControllerTest.cpp: - (WebKitTests::TEST): - (WebKitTests): - -2012-05-23 Yury Semikhatsky <yurys@chromium.org> - - Web Inspector: add a command to InspectorMemoryAgent for getting process memory break down - https://bugs.webkit.org/show_bug.cgi?id=87263 - - Reviewed by Pavel Feldman. - - Added an API for retrieving render process private and shared memory in bytes. - - * public/platform/WebKitPlatformSupport.h: - (WebKitPlatformSupport): - (WebKit::WebKitPlatformSupport::getProcessMemorySize): - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::getProcessMemorySize): - (WebCore): - -2012-05-24 Hironori Bono <hbono@chromium.org> - - Enable grammar checking on Chromium when we paste text. - https://bugs.webkit.org/show_bug.cgi?id=74393 - - Reviewed by Hajime Morita. - - This change enables grammar checking on Chromium and implements a mock grammar - checker to fix a failing test. - - * src/ContextMenuClientImpl.cpp: - (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Show suggestions when we right-click grammatically-misspelled words. - * src/EditorClientImpl.cpp: - (WebKit::EditorClientImpl::isGrammarCheckingEnabled): Enable grammar checking when we enable asynchronous spellchecking. - * src/WebTextCheckingResult.cpp: - (WebKit::WebTextCheckingResult::operator TextCheckingResult): Fill GrammarDetails for grammatical errors. - -2012-05-24 Vivek Galatage <vivekgalatage@gmail.com> - - Web Inspector: localStorage items are not updated when the storage changes - https://bugs.webkit.org/show_bug.cgi?id=83012 - - Reviewed by Pavel Feldman. - - Instrumented the DOM Storage Events in order to update the frontend. - - * src/StorageAreaProxy.cpp: - (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): - (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): - -2012-05-23 Ojan Vafai <ojan@chromium.org> - - add back the ability to disable flexbox - https://bugs.webkit.org/show_bug.cgi?id=87147 - - Reviewed by Tony Chang. - - * features.gypi: - -2012-05-23 Dana Jansens <danakj@chromium.org> - - [chromium] Enable the CCLayerTreeHostTestCanDrawBlocksDrawing test in single-threaded mode - https://bugs.webkit.org/show_bug.cgi?id=87308 - - Reviewed by James Robinson. - - Chromium bug: http://crbug.com/127481 - - Unit test: CCLayerTreeHostTestCanDrawBlocksDrawing.runSingleThread - - * tests/CCLayerTreeHostTest.cpp: - (WTF::TestHooks::didCommit): - (WTF): - (WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommit): - -2012-05-23 James Robinson <jamesr@chromium.org> - - Add a Setting to make position:fixed form a new stacking context - https://bugs.webkit.org/show_bug.cgi?id=87186 - - Reviewed by Adam Barth. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setFixedPositionCreatesStackingContext): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-05-23 James Robinson <jamesr@chromium.org> - - [chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port - https://bugs.webkit.org/show_bug.cgi?id=87177 - - Reviewed by Eric Seidel. - - Removes ENABLE(OVERFLOW_SCROLLING) from the set of enables set by Chromium. This guards a new non-standard - CSS property, -webkit-overflow-scrolling, that was introduced by iOS5 intended for mobile browsers. This - property is very partially implemented in Chromium but the way it's implemented does cause new stacking contexts - to be created that otherwise would not be, breaking "desktop" pages. - - This turns the feature off until we can figure out how to deal with the compatibility issues. - - * features.gypi: - -2012-05-23 Jay Civelli <jcivelli@chromium.org> - - [chromium] Provides a way to cancel an external popup menu before it is shown. - https://bugs.webkit.org/show_bug.cgi?id=83474 - - Reviewed by Kent Tamura. - - * src/ExternalPopupMenu.cpp: - (WebKit::ExternalPopupMenu::show): - -2012-05-23 Michael Nordman <michaeln@google.com> - - [chromium] DomStorage events handling needs TLC (3) - https://bugs.webkit.org/show_bug.cgi?id=87031 - https://code.google.com/p/chromium/issues/detail?id=128482 - Only queue storage events for Documents which have allocated - a WebCore::Storage instance since pages that have attached onstorage - event handlers must have a non-null Storage instance. - - Reviewed by Adam Barth. - - * src/StorageAreaProxy.cpp: - (WebCore::StorageAreaProxy::dispatchLocalStorageEvent): - (WebCore::StorageAreaProxy::dispatchSessionStorageEvent): - (WebCore::StorageAreaProxy::isEventSource): - -2012-05-23 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r118218. - http://trac.webkit.org/changeset/118218 - https://bugs.webkit.org/show_bug.cgi?id=87299 - - breaks webkit win builder (Requested by pilgrim_google__ on - #webkit). - - * WebKit.gyp: - * public/platform/WebKitPlatformSupport.h: - (WebKitPlatformSupport): - (WebKit::WebKitPlatformSupport::queryLocalizedString): - * public/platform/WebLocalizedString.h: - (WebKit): - * src/LocalizedStrings.cpp: - (WebCore::query): - -2012-05-23 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move themeEngine to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=87268 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * WebKit.gyp: - * public/platform/WebKitPlatformSupport.h: - (WebKit): - (WebKit::WebKitPlatformSupport::sandboxSupport): - * public/platform/android/WebThemeEngine.h: - * public/platform/linux/WebThemeEngine.h: - * public/platform/mac/WebThemeEngine.h: - * public/platform/win/WebThemeEngine.h: - * src/AssertMatchingEnums.cpp: - * src/PlatformSupport.cpp: - (WebCore::PlatformSupport::paintButton): - (WebCore::PlatformSupport::paintMenuList): - (WebCore::PlatformSupport::paintScrollbarArrow): - (WebCore::PlatformSupport::paintScrollbarThumb): - (WebCore::PlatformSupport::paintScrollbarTrack): - (WebCore::PlatformSupport::paintSpinButton): - (WebCore::PlatformSupport::paintTextField): - (WebCore::PlatformSupport::paintTrackbar): - (WebCore::PlatformSupport::paintProgressBar): - (WebCore::PlatformSupport::getThemePartSize): - (WebCore::PlatformSupport::paintThemePart): - -2012-05-23 Raymes Khoury <raymes@chromium.org> - - Change acceptMIMETypes member to acceptTypes now that file extensions are legal accept types - https://bugs.webkit.org/show_bug.cgi?id=87271 - - Reviewed by Darin Fisher. - - * public/WebFileChooserParams.h: - (WebFileChooserParams): - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::runOpenPanel): - -2012-05-23 Dana Jansens <danakj@chromium.org> - - [chromium] Layers on main thread should get a RenderSurface for animating transform only if masksToBounds is true also - https://bugs.webkit.org/show_bug.cgi?id=87184 - - Reviewed by James Robinson. - - * tests/CCLayerTreeHostCommonTest.cpp: - (WebKitTests::TEST): - -2012-05-23 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move queryLocalizedString to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=85762 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * WebKit.gyp: - * public/platform/WebKitPlatformSupport.h: - (WebKit::WebKitPlatformSupport::getPluginList): - * public/platform/WebLocalizedString.h: - * src/LocalizedStrings.cpp: - (WebCore::query): - -2012-05-23 Antti Koivisto <antti@apple.com> - - Build fix. - - Not reviewed. - - * src/WebDocument.cpp: - (WebKit::WebDocument::insertUserStyleSheet): - -2012-05-22 Alexandre Elias <aelias@google.com> - - [chromium] Apply viewport tag initial-scale only once - https://bugs.webkit.org/show_bug.cgi?id=82949 - - Reviewed by Adam Barth. - - First, check that isPageScaleFactorSet return false before setting - initial-scale. We need to call dispatchViewportPropertiesDidChange() - when the viewport width changes, since that's an input to the viewport - tag calculation. When this happens, we shouldn't pop back to initial - scale. - - Second, check that isNewNavigation is true when deciding to clear - isPageScaleFactorIsSet in didCommitLoad. We only want to clear it on - the very first commit, otherwise we'll pop back to initial scale if - the user zooms in before the load is complete. - - New test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale. - - * src/ChromeClientImpl.cpp: - (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange): - * src/WebViewImpl.cpp: - (WebKit::WebViewImpl::didCommitLoad): - -2012-05-21 Shawn Singh <shawnsingh@chromium.org> - - Improve W3C conformance of backface-visibility - https://bugs.webkit.org/show_bug.cgi?id=84195 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - (WebKitTests::TEST): - (WebKitTests): - -2012-05-22 Sheriff Bot <webkit.review.bot@gmail.com> - - Unreviewed, rolling out r118095. - http://trac.webkit.org/changeset/118095 - https://bugs.webkit.org/show_bug.cgi?id=87201 - - "Causing crashes on Mac in - WebCore::StyleResolver::adjustRenderStyle (Requested by - sundiamonde on #webkit). - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-05-22 Xianzhu Wang <wangxianzhu@chromium.org> - - [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part) - https://bugs.webkit.org/show_bug.cgi?id=86922 - - Reviewed by Kent Tamura. - - * All.gyp: Added DumpRenderTree_apk into dependencies for Android. - -2012-05-22 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Call canAccelerate2dCanvas directly - https://bugs.webkit.org/show_bug.cgi?id=86893 - - Reviewed by James Robinson. - - Part of a refactoring series. See tracking bug 82948. - - * public/platform/WebKitPlatformSupport.h: - (WebKitPlatformSupport): - * src/PlatformSupport.cpp: - (WebCore): - -2012-05-22 Dana Jansens <danakj@chromium.org> - - [chromium] Don't drop children of a RenderSurface from the renderSurfaceLayerList when then position of the surface in its clipRect is not known - https://bugs.webkit.org/show_bug.cgi?id=87181 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - (WebKitTests::TEST): - (WebKitTests): - -2012-05-22 MORITA Hajime <morrita@google.com> - - [Chromium][API] Introduce WebPermissionClient::allowWebComponents() - https://bugs.webkit.org/show_bug.cgi?id=87097 - - Reviewed by Kent Tamura. - - - Added WebPermissionClient::allowWebComponents(), and - - Implemented FrameLoaderClientImpl::shadowDOMAllowed() using it. - - * public/WebPermissionClient.h: - (WebPermissionClient): - (WebKit::WebPermissionClient::allowWebComponents): - * src/FrameLoaderClientImpl.cpp: - (WebKit::FrameLoaderClientImpl::shadowDOMAllowed): - (WebKit): - * src/FrameLoaderClientImpl.h: - (FrameLoaderClientImpl): - -2012-05-22 James Robinson <jamesr@chromium.org> - - Add a Setting to make position:fixed form a new stacking context - https://bugs.webkit.org/show_bug.cgi?id=87186 - - Reviewed by Adam Barth. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setFixedPositionCreatesStackingContext): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-05-22 Dana Jansens <danakj@chromium.org> - - [chromium] Don't force the visibleLayerRect to be empty for animating layers whose front face is not visible - https://bugs.webkit.org/show_bug.cgi?id=86886 - - Reviewed by Adrienne Walker. - - * tests/CCLayerTreeHostCommonTest.cpp: - (WebKitTests::TEST): - -2012-05-22 Mark Pilgrim <pilgrim@chromium.org> - - [Chromium] Move cookieJar to Platform.h - https://bugs.webkit.org/show_bug.cgi?id=86755 - - Reviewed by Adam Barth. - - Part of a refactoring series. See tracking bug 82948. - - * WebKit.gyp: - * public/platform/WebCookie.h: - * public/platform/WebCookieJar.h: - * public/platform/WebKitPlatformSupport.h: - (WebKit): - (WebKit::WebKitPlatformSupport::themeEngine): - * src/PlatformSupport.cpp: - (WebCore::getCookieJar): - -2012-05-22 Jochen Eisinger <jochen@chromium.org> - - Unreviewed. Rolled DEPS. - - * DEPS: - -2012-05-22 Kausalya Madhusudhanan <kmadhusu@chromium.org> - - [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality. - https://bugs.webkit.org/show_bug.cgi?id=86684 - - Reviewed by Darin Fisher. - - * public/WebFrame.h: - (WebFrame): - * public/WebPlugin.h: - (WebPlugin): - * public/WebPrintParams.h: - (WebKit::WebPrintParams::WebPrintParams): - (WebPrintParams): - * src/WebFrameImpl.cpp: - (WebKit): - * src/WebFrameImpl.h: - (WebFrameImpl): - * src/WebPluginContainerImpl.cpp: - (WebKit::WebPluginContainerImpl::printBegin): - -2012-05-22 Adam Barth <abarth@webkit.org> - - [Chromium] Expose setMediaPlaybackRequiresUserGesture via WebSettings - https://bugs.webkit.org/show_bug.cgi?id=87164 - - Reviewed by Eric Seidel. - - This is used by the Chromium Android port. - - * public/WebSettings.h: - * src/WebSettingsImpl.cpp: - (WebKit::WebSettingsImpl::setMediaPlaybackRequiresUserGesture): - (WebKit): - * src/WebSettingsImpl.h: - (WebSettingsImpl): - -2012-05-21 Shawn Singh <shawnsingh@chromium.org> - - [chromium] Add unit testing for WebTransformationMatrix::blend() - https://bugs.webkit.org/show_bug.cgi?id=87066 - - Reviewed by Adrienne Walker. - - 8 more unit tests added: - WebTransformationMatrixTest.verifyBlendForTranslation - WebTransformationMatrixTest.verifyBlendForScale - WebTransformationMatrixTest.verifyBlendForSkewX - WebTransformationMatrixTest.verifyBlendForSkewY - WebTransformationMatrixTest.verifyBlendForRotationAboutX - WebTransformationMatrixTest.verifyBlendForRotationAboutY - WebTransformationMatrixTest.verifyBlendForRotationAboutZ - WebTransformationMatrixTest.verifyBlendForCompositeTransform - - * tests/WebTransformationMatrixTest.cpp: - (WebKit::TEST): - (WebKit): - (WebKit::printTransform): - -== Rolled over to ChangeLog-2012-05-22 == diff --git a/Source/WebKit/chromium/DEPS b/Source/WebKit/chromium/DEPS index 87e085819..bfedf4277 100644 --- a/Source/WebKit/chromium/DEPS +++ b/Source/WebKit/chromium/DEPS @@ -32,7 +32,7 @@ vars = { 'chromium_svn': 'http://src.chromium.org/svn/trunk/src', - 'chromium_rev': '161609' + 'chromium_rev': '158657' } deps = { @@ -161,6 +161,8 @@ deps_os = { From('chromium_deps', 'src/third_party/nss'), 'third_party/perl': From('chromium_deps', 'src/third_party/perl'), + 'tools/isolate': + Var('chromium_svn')+'/tools/isolate@'+Var('chromium_rev'), # Dependencies used by libjpeg-turbo 'third_party/yasm/binaries': From('chromium_deps', 'src/third_party/yasm/binaries'), diff --git a/Source/WebKit/chromium/WebKit.gyp b/Source/WebKit/chromium/WebKit.gyp index ef9997ea4..f4f4c9ece 100644 --- a/Source/WebKit/chromium/WebKit.gyp +++ b/Source/WebKit/chromium/WebKit.gyp @@ -917,7 +917,7 @@ '<@(webinspector_image_files)', '<@(devtools_image_files)', ], - }, + }, ], }, { @@ -972,75 +972,95 @@ 'concatenated_heap_snapshot_worker_js', 'concatenated_script_formatter_worker_js', 'concatenated_devtools_css'], - 'actions': [{ - 'action_name': 'generate_devtools_grd', - 'script_name': 'scripts/generate_devtools_grd.py', - 'input_pages': [ - '<(PRODUCT_DIR)/resources/inspector/devtools.html', - '<(PRODUCT_DIR)/resources/inspector/DevTools.js', - '<(PRODUCT_DIR)/resources/inspector/ElementsPanel.js', - '<(PRODUCT_DIR)/resources/inspector/ResourcesPanel.js', - '<(PRODUCT_DIR)/resources/inspector/NetworkPanel.js', - '<(PRODUCT_DIR)/resources/inspector/ScriptsPanel.js', - '<(PRODUCT_DIR)/resources/inspector/TimelinePanel.js', - '<(PRODUCT_DIR)/resources/inspector/ProfilesPanel.js', - '<(PRODUCT_DIR)/resources/inspector/AuditsPanel.js', - '<(PRODUCT_DIR)/resources/inspector/CodeMirrorTextEditor.js', - '<(PRODUCT_DIR)/resources/inspector/HeapSnapshotWorker.js', - '<(PRODUCT_DIR)/resources/inspector/ScriptFormatterWorker.js', - '<(PRODUCT_DIR)/resources/inspector/devTools.css', - '<(PRODUCT_DIR)/resources/inspector/devtools_extension_api.js', - '<@(webinspector_standalone_css_files)', - ], - 'images': [ - '<@(webinspector_image_files)', - '<@(devtools_image_files)', - ], - 'inputs': [ - '<@(_script_name)', - '<@(_input_pages)', - '<@(_images)', - ], - 'search_path': [ - '../../WebCore/inspector/front-end/Images', - 'src/js/Images', - ], - 'outputs': ['<(SHARED_INTERMEDIATE_DIR)/devtools/devtools_resources.grd'], - 'action': ['python', '<@(_script_name)', '<@(_input_pages)', '--images', '<@(_search_path)', '--output', '<@(_outputs)'], - }], - }, - { + },{ # If we're not concatenating devtools files, we want to # run after the original files have been copied to # <(PRODUCT_DIR)/resources/inspector. 'dependencies': ['inspector_resources'], - 'actions': [{ - 'action_name': 'generate_devtools_grd', - 'script_name': 'scripts/generate_devtools_grd.py', - 'input_pages': [ - '<@(webinspector_files)', - '<@(devtools_files)', - '<(SHARED_INTERMEDIATE_DIR)/webcore/InspectorBackendCommands.js', - '<(PRODUCT_DIR)/resources/inspector/devtools.html', - ], - 'images': [ - '<@(webinspector_image_files)', - '<@(devtools_image_files)', - ], - 'inputs': [ - '<@(_script_name)', - '<@(_input_pages)', - '<@(_images)', - ], - 'search_path': [ - '../../WebCore/inspector/front-end/Images', - 'src/js/Images', - ], - 'outputs': ['<(SHARED_INTERMEDIATE_DIR)/devtools/devtools_resources.grd'], - 'action': ['python', '<@(_script_name)', '<@(_input_pages)', '--images', '<@(_search_path)', '--output', '<@(_outputs)'], - }], }], ], + 'actions': [{ + 'action_name': 'generate_devtools_grd', + 'script_name': 'scripts/generate_devtools_grd.py', + 'input_pages': [ + '<(PRODUCT_DIR)/resources/inspector/devtools.html', + '<(PRODUCT_DIR)/resources/inspector/DevTools.js', + '<(PRODUCT_DIR)/resources/inspector/ElementsPanel.js', + '<(PRODUCT_DIR)/resources/inspector/ResourcesPanel.js', + '<(PRODUCT_DIR)/resources/inspector/NetworkPanel.js', + '<(PRODUCT_DIR)/resources/inspector/ScriptsPanel.js', + '<(PRODUCT_DIR)/resources/inspector/TimelinePanel.js', + '<(PRODUCT_DIR)/resources/inspector/ProfilesPanel.js', + '<(PRODUCT_DIR)/resources/inspector/AuditsPanel.js', + '<(PRODUCT_DIR)/resources/inspector/CodeMirrorTextEditor.js', + '<(PRODUCT_DIR)/resources/inspector/HeapSnapshotWorker.js', + '<(PRODUCT_DIR)/resources/inspector/ScriptFormatterWorker.js', + '<(PRODUCT_DIR)/resources/inspector/devTools.css', + '<(PRODUCT_DIR)/resources/inspector/devtools_extension_api.js', + '<@(webinspector_standalone_css_files)', + ], + 'images': [ + '<@(webinspector_image_files)', + '<@(devtools_image_files)', + ], + 'inputs': [ + '<@(_script_name)', + '<@(_input_pages)', + '<@(_images)', + ], + 'search_path': [ + '../../WebCore/inspector/front-end/Images', + 'src/js/Images', + ], + 'outputs': ['<(SHARED_INTERMEDIATE_DIR)/devtools/devtools_resources.grd'], + 'action': ['python', '<@(_script_name)', '<@(_input_pages)', '--images', '<@(_search_path)', '--output', '<@(_outputs)'], + }], + }, + { + 'target_name': 'generate_devtools_zip', + 'type': 'none', + 'dependencies': [ + '../../WebCore/WebCore.gyp/WebCore.gyp:inspector_protocol_sources', + ], + 'actions': [{ + 'action_name': 'generate_devtools_zip', + 'script_name': 'scripts/generate_devtools_zip.py', + 'inspector_html': '../../WebCore/inspector/front-end/inspector.html', + 'workers_files': [ + '../../WebCore/inspector/front-end/HeapSnapshotWorker.js', + '../../WebCore/inspector/front-end/JavaScriptFormatter.js', + '../../WebCore/inspector/front-end/ScriptFormatterWorker.js', + '<@(webinspector_uglifyjs_files)' + ], + 'inputs': [ + '<@(_script_name)', + 'scripts/generate_devtools_html.py', + 'scripts/generate_devtools_extension_api.py', + '<@(_inspector_html)', + '<@(devtools_files)', + '<@(webinspector_files)', + '<(SHARED_INTERMEDIATE_DIR)/webcore/InspectorBackendCommands.js', + '<@(_workers_files)', + '<@(webinspector_image_files)', + '<@(devtools_image_files)', + '<@(devtools_extension_api_files)', + ], + 'search_path': [ + '../../WebCore/inspector/front-end', + 'src/js', + ], + 'js_search_path': [ + '<(SHARED_INTERMEDIATE_DIR)/webcore', + ], + 'outputs': ['<(PRODUCT_DIR)/devtools_frontend.zip'], + 'action': ['python', '<@(_script_name)', '<@(_inspector_html)', + '--devtools-files', '<@(devtools_files)', + '--workers-files', '<@(_workers_files)', + '--extension-api-files', '<@(devtools_extension_api_files)', + '--search-path', '<@(_search_path)', + '--js-search-path', '<@(_js_search_path)', + '--output', '<@(_outputs)'], + }], }, ], # targets 'conditions': [ diff --git a/Source/WebKit/chromium/WebKit.gypi b/Source/WebKit/chromium/WebKit.gypi index 24cae298f..f428cb130 100644 --- a/Source/WebKit/chromium/WebKit.gypi +++ b/Source/WebKit/chromium/WebKit.gypi @@ -84,6 +84,7 @@ 'tests/LinkHighlightTest.cpp', 'tests/ListenerLeakTest.cpp', 'tests/MemoryInfo.cpp', + 'tests/MemoryInstrumentationTest.cpp', 'tests/OpaqueRectTrackingContentLayerDelegateTest.cpp', 'tests/OpenTypeVerticalDataTest.cpp', 'tests/PODArenaTest.cpp', @@ -107,7 +108,6 @@ 'tests/WebFrameTest.cpp', 'tests/WebImageTest.cpp', 'tests/WebInputEventConversionTest.cpp', - 'tests/WebInputEventFactoryTestMac.mm', 'tests/WebMediaPlayerClientImplTest.cpp', 'tests/WebPageNewSerializerTest.cpp', 'tests/WebPageSerializerTest.cpp', diff --git a/Source/WebKit/chromium/WebKitUnitTests.gyp b/Source/WebKit/chromium/WebKitUnitTests.gyp index 00631256a..12d0a957b 100644 --- a/Source/WebKit/chromium/WebKitUnitTests.gyp +++ b/Source/WebKit/chromium/WebKitUnitTests.gyp @@ -121,11 +121,6 @@ '<(chromium_src_dir)/testing/android/native_test.gyp:native_test_native_code', ], }], - ['OS=="mac"', { - 'include_dirs': [ - 'public/mac', - ], - }], ], } ], # targets diff --git a/Source/WebKit/chromium/features.gypi b/Source/WebKit/chromium/features.gypi index cb1e63799..8b4c40ec8 100644 --- a/Source/WebKit/chromium/features.gypi +++ b/Source/WebKit/chromium/features.gypi @@ -79,9 +79,9 @@ 'ENABLE_LEGACY_VIEWPORT_ADAPTION=1', 'ENABLE_LEGACY_VENDOR_PREFIXES=0', 'ENABLE_LEGACY_WEB_AUDIO=1', + 'ENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1', 'ENABLE_LINK_PREFETCH=1', 'ENABLE_LINK_PRERENDER=1', - 'ENABLE_MATHML=1', 'ENABLE_MEDIA_SOURCE=1', 'ENABLE_MEDIA_STATISTICS=1', 'ENABLE_METER_ELEMENT=1', @@ -120,6 +120,7 @@ 'ENABLE_WORKERS=1', 'ENABLE_XHR_RESPONSE_BLOB=1', 'ENABLE_XSLT=1', + 'SK_SUPPORT_HINTING_SCALE_FACTOR', 'WTF_USE_LEVELDB=1', 'WTF_USE_BUILTIN_UTF8_CODEC=1', # WTF_USE_DYNAMIC_ANNOTATIONS=1 may be defined in build/common.gypi @@ -140,6 +141,7 @@ 'enable_touch_events%': 1, 'enable_touch_icon_loading%' : 0, 'enable_mutation_observers%': 1, + 'use_harfbuzz_ng%': 0, }, 'use_accelerated_compositing%': '<(use_accelerated_compositing)', 'enable_skia_text%': '<(enable_skia_text)', @@ -175,7 +177,7 @@ 'ENABLE_DATALIST_ELEMENT=1', 'ENABLE_INPUT_SPEECH=1', 'ENABLE_INPUT_TYPE_COLOR=1', - 'ENABLE_INPUT_MULTIPLE_FIELDS_UI=1', + 'ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS=1', 'ENABLE_JAVASCRIPT_I18N_API=1', 'ENABLE_LEGACY_NOTIFICATIONS=1', 'ENABLE_MEDIA_CAPTURE=0', @@ -222,16 +224,11 @@ 'WTF_USE_SKIA_ON_MAC_CHROMIUM=1', ], }], - ['use_x11==1', { + ['use_harfbuzz_ng==1', { 'feature_defines': [ 'WTF_USE_HARFBUZZ_NG=1', ], }], - ['chromeos==1', { - 'feature_defines': [ - 'SK_SUPPORT_HINTING_SCALE_FACTOR', - ], - }], ], }, } diff --git a/Source/WebKit/chromium/public/WebDevToolsAgentClient.h b/Source/WebKit/chromium/public/WebDevToolsAgentClient.h index 7ac2c7c97..9c63b119d 100644 --- a/Source/WebKit/chromium/public/WebDevToolsAgentClient.h +++ b/Source/WebKit/chromium/public/WebDevToolsAgentClient.h @@ -61,14 +61,6 @@ public: virtual void clearBrowserCache() { } virtual void clearBrowserCookies() { } - class AllocatedObjectVisitor { - public: - virtual bool visitObject(const void* ptr) = 0; - protected: - virtual ~AllocatedObjectVisitor() { } - }; - virtual void visitAllocatedObjects(AllocatedObjectVisitor*) { } - protected: ~WebDevToolsAgentClient() { } }; diff --git a/Source/WebKit/chromium/public/WebDocument.h b/Source/WebKit/chromium/public/WebDocument.h index 7e885acc4..e0c444250 100644 --- a/Source/WebKit/chromium/public/WebDocument.h +++ b/Source/WebKit/chromium/public/WebDocument.h @@ -79,7 +79,6 @@ public: WEBKIT_EXPORT WebSecurityOrigin securityOrigin() const; WEBKIT_EXPORT WebString encoding() const; - WEBKIT_EXPORT WebString contentLanguage() const; // The url of the OpenSearch Desription Document (if any). WEBKIT_EXPORT WebURL openSearchDescriptionURL() const; diff --git a/Source/WebKit/chromium/public/WebDragStatus.h b/Source/WebKit/chromium/public/WebDragStatus.h deleted file mode 100644 index fb490d383..000000000 --- a/Source/WebKit/chromium/public/WebDragStatus.h +++ /dev/null @@ -1,46 +0,0 @@ -/* -* Copyright (C) 2012 Google Inc. All rights reserved. -* -* Redistribution and use in source and binary forms, with or without -* modification, are permitted provided that the following conditions are -* met: -* -* * Redistributions of source code must retain the above copyright -* notice, this list of conditions and the following disclaimer. -* * Redistributions in binary form must reproduce the above -* copyright notice, this list of conditions and the following disclaimer -* in the documentation and/or other materials provided with the -* distribution. -* * Neither the name of Google Inc. nor the names of its -* contributors may be used to endorse or promote products derived from -* this software without specific prior written permission. -* -* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -*/ - -#ifndef WebDragStatus_h -#define WebDragStatus_h - -namespace WebKit { - -enum WebDragStatus { - WebDragStatusUnknown = 0, - WebDragStatusEnter, - WebDragStatusOver, - WebDragStatusLeave, - WebDragStatusDrop -}; - -} // namespace WebKit - -#endif diff --git a/Source/WebKit/chromium/public/WebDraggableRegion.h b/Source/WebKit/chromium/public/WebDraggableRegion.h index 56006f6a5..0437f8973 100644 --- a/Source/WebKit/chromium/public/WebDraggableRegion.h +++ b/Source/WebKit/chromium/public/WebDraggableRegion.h @@ -38,10 +38,8 @@ namespace WebKit { struct WebDraggableRegion { - bool draggable; - WebRect bounds; - // FIXME: to be removed after chromium change is done. WebString label; + WebRect bounds; WebRect clip; }; diff --git a/Source/WebKit/chromium/public/WebElement.h b/Source/WebKit/chromium/public/WebElement.h index 75e3aff0f..84c43b251 100644 --- a/Source/WebKit/chromium/public/WebElement.h +++ b/Source/WebKit/chromium/public/WebElement.h @@ -51,15 +51,8 @@ struct WebRect; WEBKIT_EXPORT bool isFormControlElement() const; WEBKIT_EXPORT bool isTextFormControlElement() const; - // Returns the qualified name, which may contain a prefix and a colon. WEBKIT_EXPORT WebString tagName() const; - // Check if this element has the specified qualified name. This function - // doesn't makes much sense because we have no ways to check namespace - // URI. Do not use this. WEBKIT_EXPORT bool hasTagName(const WebString&) const; - // Check if this element has the specified local tag name, and the HTML - // namespace. Tag name matching is case-insensitive. - WEBKIT_EXPORT bool hasHTMLTagName(const WebString&) const; WEBKIT_EXPORT bool hasAttribute(const WebString&) const; WEBKIT_EXPORT WebString getAttribute(const WebString&) const; WEBKIT_EXPORT bool setAttribute(const WebString& name, const WebString& value); diff --git a/Source/WebKit/chromium/public/WebFrame.h b/Source/WebKit/chromium/public/WebFrame.h index d1ea38969..f38c73934 100644 --- a/Source/WebKit/chromium/public/WebFrame.h +++ b/Source/WebKit/chromium/public/WebFrame.h @@ -99,9 +99,23 @@ public: // Returns the number of live WebFrame objects, used for leak checking. WEBKIT_EXPORT static int instanceCount(); - // Returns the WebFrame associated with the current V8 context. This - // function can return 0 if the context is associated with a Document that - // is not currently being displayed in a Frame. + // The two functions below retrieve the WebFrame instances relating the + // currently executing JavaScript. Since JavaScript can make function + // calls across frames, though, we need to be more precise. + // + // For example, imagine that a JS function in frame A calls a function + // in frame B, which calls native code, which wants to know what the + // 'active' frame is. + // + // The 'entered context' is the context where execution first entered + // the script engine; the context that is at the bottom of the JS + // function stack. frameForEnteredContext() would return frame A in + // our example. + // + // The 'current context' is the context the JS engine is currently + // inside of; the context that is at the top of the JS function stack. + // frameForCurrentContext() would return frame B in our example. + WEBKIT_EXPORT static WebFrame* frameForEnteredContext(); WEBKIT_EXPORT static WebFrame* frameForCurrentContext(); #if WEBKIT_USING_V8 @@ -118,7 +132,14 @@ public: // Basic properties --------------------------------------------------- + // The name of this frame. + virtual WebString name() const = 0; + // The unique name of this frame. + // + // This is temporarily identical to the above name() function. Once this + // change makes it over to the Chromium tree, I will change all callers to + // use this function and will subsequently move assignedName() to name(). virtual WebString uniqueName() const = 0; // The name of this frame. If no name is given, empty string is returned. @@ -280,11 +301,8 @@ public: int argc, v8::Handle<v8::Value> argv[]) = 0; - // Returns the V8 context for associated with the main world and this - // frame. There can be many V8 contexts associated with this frame, one for - // each isolated world and one for the main world. If you don't know what - // the "main world" or an "isolated world" is, then you probably shouldn't - // be calling this API. + // Returns the V8 context for this frame, or an empty handle if there + // is none. virtual v8::Local<v8::Context> mainWorldScriptContext() const = 0; // Creates an instance of file system object. diff --git a/Source/WebKit/chromium/public/WebFrameClient.h b/Source/WebKit/chromium/public/WebFrameClient.h index 73980bf7f..b4fccebc2 100644 --- a/Source/WebKit/chromium/public/WebFrameClient.h +++ b/Source/WebKit/chromium/public/WebFrameClient.h @@ -62,7 +62,6 @@ class WebMediaPlayer; class WebMediaPlayerClient; class WebNode; class WebPlugin; -class WebRTCPeerConnectionHandler; class WebSharedWorker; class WebSharedWorkerClient; class WebSocketStreamHandle; @@ -399,25 +398,28 @@ public: // A WebSocket object is going to open new stream connection. virtual void willOpenSocketStream(WebSocketStreamHandle*) { } - // MediaStream ----------------------------------------------------- - - // A new WebRTCPeerConnectionHandler is created. - virtual void willStartUsingPeerConnectionHandler(WebFrame*, WebRTCPeerConnectionHandler*) { } - // Messages ------------------------------------------------------ // Notifies the embedder that a postMessage was issued on this frame, and // gives the embedder a chance to handle it instead of WebKit. Returns true // if the embedder handled it. virtual bool willCheckAndDispatchMessageEvent( + WebFrame* source, + WebSecurityOrigin target, + WebDOMMessageEvent) { return false; } + + virtual bool willCheckAndDispatchMessageEvent( WebFrame* sourceFrame, WebFrame* targetFrame, WebSecurityOrigin target, - WebDOMMessageEvent event) { return false; } + WebDOMMessageEvent event) + { + return willCheckAndDispatchMessageEvent(sourceFrame, target, event); + } // Asks the embedder if a specific user agent should be used for the given // URL. Non-empty strings indicate an override should be used. Otherwise, - // Platform::current()->userAgent() will be called to provide one. + // WebKitPlatformSupport::userAgent() will be called to provide one. virtual WebString userAgentOverride(WebFrame*, const WebURL& url) { return WebString(); } protected: diff --git a/Source/WebKit/chromium/public/WebIDBDatabase.h b/Source/WebKit/chromium/public/WebIDBDatabase.h index a4932ee28..83b9a425f 100644 --- a/Source/WebKit/chromium/public/WebIDBDatabase.h +++ b/Source/WebKit/chromium/public/WebIDBDatabase.h @@ -50,7 +50,7 @@ public: WEBKIT_ASSERT_NOT_REACHED(); return WebIDBMetadata(); } - virtual WebIDBObjectStore* createObjectStore(long long, const WebString&, const WebIDBKeyPath&, bool, const WebIDBTransaction&, WebExceptionCode&) + virtual WebIDBObjectStore* createObjectStore(const WebString&, const WebIDBKeyPath&, bool, const WebIDBTransaction&, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); return 0; diff --git a/Source/WebKit/chromium/public/WebIDBMetadata.h b/Source/WebKit/chromium/public/WebIDBMetadata.h index 957e082bb..1f2e9ead4 100644 --- a/Source/WebKit/chromium/public/WebIDBMetadata.h +++ b/Source/WebKit/chromium/public/WebIDBMetadata.h @@ -50,8 +50,6 @@ struct WebIDBMetadata { // setVersion, WebString version can be removed. WebString version; long long intVersion; - long long id; - long long maxObjectStoreId; WebVector<ObjectStore> objectStores; WebIDBMetadata() : intVersion(NoIntVersion) { } @@ -60,8 +58,6 @@ struct WebIDBMetadata { WebString name; WebIDBKeyPath keyPath; bool autoIncrement; - long long id; - long long maxIndexId; WebVector<Index> indexes; ObjectStore() : keyPath(WebIDBKeyPath::createNull()) @@ -73,7 +69,6 @@ struct WebIDBMetadata { WebIDBKeyPath keyPath; bool unique; bool multiEntry; - long long id; Index() : keyPath(WebIDBKeyPath::createNull()) , unique(false) diff --git a/Source/WebKit/chromium/public/WebIDBObjectStore.h b/Source/WebKit/chromium/public/WebIDBObjectStore.h index ca0103cda..a2b87da81 100644 --- a/Source/WebKit/chromium/public/WebIDBObjectStore.h +++ b/Source/WebKit/chromium/public/WebIDBObjectStore.h @@ -63,11 +63,6 @@ public: WEBKIT_ASSERT_NOT_REACHED(); return 0; } - virtual WebIDBIndex* createIndex(long long, const WebString&, const WebIDBKeyPath&, bool, bool, const WebIDBTransaction&, WebExceptionCode&) - { - WEBKIT_ASSERT_NOT_REACHED(); - return 0; - } virtual void setIndexKeys(const WebIDBKey&, const WebVector<WebString>&, const WebVector<WebIndexKeys>&, const WebIDBTransaction&) { WEBKIT_ASSERT_NOT_REACHED(); } virtual void setIndexesReady(const WebVector<WebString>&, const WebIDBTransaction&) { WEBKIT_ASSERT_NOT_REACHED(); }; // Transfers ownership of the WebIDBIndex to the caller. diff --git a/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h b/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h index 497d5e8db..5ea6cf45a 100644 --- a/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h +++ b/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h @@ -29,16 +29,11 @@ #include "platform/WebCommon.h" namespace WebKit { - -class WebIDBDatabaseError; - class WebIDBTransactionCallbacks { public: virtual ~WebIDBTransactionCallbacks() { } - // FIXME: Remove after callers are updated following WK99097. virtual void onAbort() { WEBKIT_ASSERT_NOT_REACHED(); } - virtual void onAbort(const WebIDBDatabaseError&) { WEBKIT_ASSERT_NOT_REACHED(); } virtual void onComplete() { WEBKIT_ASSERT_NOT_REACHED(); } }; diff --git a/Source/WebKit/chromium/public/WebNode.h b/Source/WebKit/chromium/public/WebNode.h index 5869aeec6..902b37669 100644 --- a/Source/WebKit/chromium/public/WebNode.h +++ b/Source/WebKit/chromium/public/WebNode.h @@ -113,7 +113,6 @@ public: WEBKIT_EXPORT WebNodeList getElementsByTagName(const WebString&) const; WEBKIT_EXPORT WebElement rootEditableElement() const; WEBKIT_EXPORT bool focused() const; - WEBKIT_EXPORT bool remove(); // Returns true if the node has a non-empty bounding box in layout. // This does not 100% guarantee the user can see it, but is pretty close. diff --git a/Source/WebKit/chromium/public/WebPlugin.h b/Source/WebKit/chromium/public/WebPlugin.h index c72fff325..8abaf3bfe 100644 --- a/Source/WebKit/chromium/public/WebPlugin.h +++ b/Source/WebKit/chromium/public/WebPlugin.h @@ -31,8 +31,6 @@ #ifndef WebPlugin_h #define WebPlugin_h -#include "WebDragOperation.h" -#include "WebDragStatus.h" #include "platform/WebCanvas.h" #include "platform/WebString.h" #include "platform/WebURL.h" @@ -42,7 +40,6 @@ struct NPObject; namespace WebKit { class WebDataSource; -class WebDragData; class WebFrame; class WebInputEvent; class WebPluginContainer; @@ -83,8 +80,6 @@ public: virtual bool acceptsInputEvents() = 0; virtual bool handleInputEvent(const WebInputEvent&, WebCursorInfo&) = 0; - virtual bool handleDragStatusUpdate(WebDragStatus, const WebDragData&, WebDragOperationsMask, const WebPoint& position, const WebPoint& screenPosition) { return false; } - virtual void didReceiveResponse(const WebURLResponse&) = 0; virtual void didReceiveData(const char* data, int dataLength) = 0; virtual void didFinishLoading() = 0; diff --git a/Source/WebKit/chromium/public/WebSecurityOrigin.h b/Source/WebKit/chromium/public/WebSecurityOrigin.h index 359dc730f..ffddf093a 100644 --- a/Source/WebKit/chromium/public/WebSecurityOrigin.h +++ b/Source/WebKit/chromium/public/WebSecurityOrigin.h @@ -96,9 +96,6 @@ public: // passwords stored in password manager. WEBKIT_EXPORT bool canAccessPasswordManager() const; - // Allows this WebSecurityOrigin access to local resources. - WEBKIT_EXPORT void grantLoadLocalResources() const; - #if WEBKIT_IMPLEMENTATION WebSecurityOrigin(const WTF::PassRefPtr<WebCore::SecurityOrigin>&); WebSecurityOrigin& operator=(const WTF::PassRefPtr<WebCore::SecurityOrigin>&); diff --git a/Source/WebKit/chromium/public/WebSettings.h b/Source/WebKit/chromium/public/WebSettings.h index abd84ed0e..5ff206b0a 100644 --- a/Source/WebKit/chromium/public/WebSettings.h +++ b/Source/WebKit/chromium/public/WebSettings.h @@ -72,9 +72,7 @@ public: virtual void setAllowScriptsToCloseWindows(bool) = 0; virtual void setAllowUniversalAccessFromFileURLs(bool) = 0; virtual void setApplyDefaultDeviceScaleFactorInCompositor(bool) = 0; - virtual void setApplyPageScaleFactorInCompositor(bool) = 0; virtual void setAsynchronousSpellCheckingEnabled(bool) = 0; - virtual void setAutoZoomFocusedNodeToLegibleScale(bool) = 0; virtual void setAuthorAndUserStylesEnabled(bool) = 0; virtual void setCaretBrowsingEnabled(bool) = 0; virtual void setCookieEnabled(bool) = 0; diff --git a/Source/WebKit/chromium/public/WebSpeechRecognitionParams.h b/Source/WebKit/chromium/public/WebSpeechRecognitionParams.h index 5f48fd293..96eecd994 100644 --- a/Source/WebKit/chromium/public/WebSpeechRecognitionParams.h +++ b/Source/WebKit/chromium/public/WebSpeechRecognitionParams.h @@ -37,11 +37,10 @@ class WebSpeechGrammar; class WebSpeechRecognitionParams { public: - WebSpeechRecognitionParams(const WebVector<WebSpeechGrammar>& grammars, const WebString& language, bool continuous, bool interimResults, unsigned long maxAlternatives, const WebSecurityOrigin& origin) + WebSpeechRecognitionParams(const WebVector<WebSpeechGrammar>& grammars, const WebString& language, bool continuous, unsigned long maxAlternatives, const WebSecurityOrigin& origin) : m_grammars(grammars) , m_language(language) , m_continuous(continuous) - , m_interimResults(interimResults) , m_maxAlternatives(maxAlternatives) , m_origin(origin) { @@ -50,7 +49,6 @@ public: const WebVector<WebSpeechGrammar>& grammars() const { return m_grammars; } const WebString& language() const { return m_language; } bool continuous() const { return m_continuous; } - bool interimResults() const { return m_interimResults; } unsigned long maxAlternatives() const { return m_maxAlternatives; } const WebSecurityOrigin& origin() const { return m_origin; } @@ -58,7 +56,6 @@ private: WebVector<WebSpeechGrammar> m_grammars; WebString m_language; bool m_continuous; - bool m_interimResults; unsigned long m_maxAlternatives; WebSecurityOrigin m_origin; }; diff --git a/Source/WebKit/chromium/public/WebSpeechRecognizerClient.h b/Source/WebKit/chromium/public/WebSpeechRecognizerClient.h index ebdc0c173..3fe1244a7 100644 --- a/Source/WebKit/chromium/public/WebSpeechRecognizerClient.h +++ b/Source/WebKit/chromium/public/WebSpeechRecognizerClient.h @@ -74,6 +74,10 @@ public: // recognizion hypothesis. virtual void didReceiveNoMatch(const WebSpeechRecognitionHandle&, const WebSpeechRecognitionResult&) = 0; + // To be called when the recognizer needs to delete one of the previously + // returned interim results. + virtual void didDeleteResult(const WebSpeechRecognitionHandle&, unsigned resultIndex, const WebVector<WebSpeechRecognitionResult>& resultHistory) = 0; + // To be called when a speech recognition error occurs. virtual void didReceiveError(const WebSpeechRecognitionHandle&, const WebString& message, ErrorCode) = 0; diff --git a/Source/WebKit/chromium/public/WebTextFieldDecoratorClient.h b/Source/WebKit/chromium/public/WebTextFieldDecoratorClient.h index 86f3ff6d4..772e1216b 100644 --- a/Source/WebKit/chromium/public/WebTextFieldDecoratorClient.h +++ b/Source/WebKit/chromium/public/WebTextFieldDecoratorClient.h @@ -58,13 +58,9 @@ public: // empty string, imageNameForNormalState() is used even for the disabled // state. virtual WebCString imageNameForDisabledState() = 0; - // Image resource name for the read only state. If this function returns an + // Image resource name for the disabled state. If this function returns an // empty string, the image same as imageNameForDisabledState() is used. virtual WebCString imageNameForReadOnlyState() = 0; - // Image resource name for when the imaged is being hovered over. If this - // function returns an empty string, imageNameForNormalState() is used - // instead. - virtual WebCString imageNameForHoverState() {return WebCString();} // This is called when the decoration icon is clicked. virtual void handleClick(WebInputElement&) = 0; diff --git a/Source/WebKit/chromium/public/WebUserMediaRequest.h b/Source/WebKit/chromium/public/WebUserMediaRequest.h index 3c8469648..660df5bc1 100644 --- a/Source/WebKit/chromium/public/WebUserMediaRequest.h +++ b/Source/WebKit/chromium/public/WebUserMediaRequest.h @@ -41,7 +41,6 @@ class UserMediaRequest; namespace WebKit { class WebDocument; -class WebMediaConstraints; class WebMediaStreamDescriptor; class WebMediaStreamSource; class WebString; @@ -66,8 +65,6 @@ public: WEBKIT_EXPORT bool audio() const; WEBKIT_EXPORT bool video() const; - WEBKIT_EXPORT WebMediaConstraints audioConstraints() const; - WEBKIT_EXPORT WebMediaConstraints videoConstraints() const; WEBKIT_EXPORT WebSecurityOrigin securityOrigin() const; WEBKIT_EXPORT WebDocument ownerDocument() const; diff --git a/Source/WebKit/chromium/scripts/generate_devtools_zip.py b/Source/WebKit/chromium/scripts/generate_devtools_zip.py new file mode 100644 index 000000000..9ca5238be --- /dev/null +++ b/Source/WebKit/chromium/scripts/generate_devtools_zip.py @@ -0,0 +1,140 @@ +#!/usr/bin/env python +# +# Copyright (C) 2011 Google Inc. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +# * Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +"""Creates a zip file containing the web inspector files for debugging. + +The zip file contains all the .html, .js, .css and image files used by the +web inspector. The js files and css files are not concatenated and are not +minified.""" + +from __future__ import with_statement + +import os +import StringIO +import sys +import zipfile + +import concatenate_js_files +import generate_devtools_html +import generate_devtools_extension_api + + +class ParsedArgs: + def __init__(self, inspector_html, devtools_files, workers_files, extension_api_files, + search_dirs, js_search_dirs, output_filename): + self.inspector_html = inspector_html + self.devtools_files = devtools_files + self.workers_files = workers_files + self.extension_api_files = extension_api_files + self.search_dirs = search_dirs + self.js_search_dirs = js_search_dirs + self.output_filename = output_filename + + +def parse_args(argv): + inspector_html = argv[0] + + devtools_files_position = argv.index('--devtools-files') + workers_files_position = argv.index('--workers-files') + extension_api_files_position = argv.index('--extension-api-files') + search_path_position = argv.index('--search-path') + js_search_path_position = argv.index('--js-search-path') + output_position = argv.index('--output') + + devtools_files = argv[devtools_files_position + 1:workers_files_position] + workers_files = argv[workers_files_position + 1:extension_api_files_position] + extension_api_files = argv[extension_api_files_position + 1:search_path_position] + search_dirs = argv[search_path_position + 1:js_search_path_position] + js_search_dirs = argv[js_search_path_position + 1:output_position] + + return ParsedArgs(inspector_html, devtools_files, workers_files, extension_api_files, + search_dirs, js_search_dirs, argv[output_position + 1]) + + +def main(argv): + parsed_args = parse_args(argv[1:]) + + devtools_html = StringIO.StringIO() + with open(parsed_args.inspector_html, 'r') as inspector_file: + generate_devtools_html.write_devtools_html( + inspector_file, devtools_html, True, parsed_args.devtools_files) + + zip = zipfile.ZipFile(parsed_args.output_filename, 'w', zipfile.ZIP_DEFLATED) + zip.writestr("devtools.html", devtools_html.getvalue()) + + devtools_extension_api = StringIO.StringIO() + generate_devtools_extension_api.write_devtools_extension_api( + devtools_extension_api, parsed_args.extension_api_files) + zip.writestr("devtools_extension_api.js", devtools_extension_api.getvalue()) + + js_extractor = concatenate_js_files.OrderedJSFilesExtractor( + devtools_html.getvalue()) + + js_dirs = parsed_args.search_dirs + parsed_args.js_search_dirs + expander = concatenate_js_files.PathExpander(js_dirs) + files = js_extractor.ordered_js_files + for input_file_name in set(files): + full_path = expander.expand(input_file_name) + if full_path is None: + raise Exception('File %s referenced in %s not found on any source paths, ' + 'check source tree for consistency' % + (input_file_name, 'devtools.html')) + zip.write(full_path, os.path.basename(full_path)) + + front_end_path = os.path.dirname(os.path.abspath(parsed_args.inspector_html)) + + for input_file_name in set(parsed_args.workers_files): + script_path = os.path.dirname(os.path.abspath(input_file_name)) + if script_path.startswith(front_end_path): + script_path = script_path.replace(front_end_path, "") + if len(script_path) > 0: + script_path += '/' + zip.write(input_file_name, + script_path + os.path.basename(input_file_name)) + else: + raise Exception('Worker script %s is not from Inspector front-end dir' % (input_file_name)) + + for dirname in parsed_args.search_dirs: + for filename in os.listdir(dirname): + if filename.endswith('.css'): + zip.write(os.path.join(dirname, filename), filename) + dirname = os.path.join(dirname, 'Images') + for filename in os.listdir(dirname): + if filename.endswith('.png') or filename.endswith('.gif'): + zip.write(os.path.join(dirname, filename), + os.path.join('Images', filename)) + + # It would be nice to use the with statement to scope closing the archive, + # but that wasn't added until python 2.7. + zip.close() + + +if '__main__' == __name__: + sys.exit(main(sys.argv)) diff --git a/Source/WebKit/chromium/src/ApplicationCacheHost.cpp b/Source/WebKit/chromium/src/ApplicationCacheHost.cpp index a8f398eb5..2b6a47707 100644 --- a/Source/WebKit/chromium/src/ApplicationCacheHost.cpp +++ b/Source/WebKit/chromium/src/ApplicationCacheHost.cpp @@ -44,10 +44,10 @@ #include "WebFrameImpl.h" #include "WrappedResourceRequest.h" #include "WrappedResourceResponse.h" -#include <public/WebURL.h> -#include <public/WebURLError.h> -#include <public/WebURLResponse.h> -#include <public/WebVector.h> +#include "platform/WebURL.h" +#include "platform/WebURLError.h" +#include "platform/WebURLResponse.h" +#include "platform/WebVector.h" using namespace WebKit; diff --git a/Source/WebKit/chromium/src/AssertMatchingEnums.cpp b/Source/WebKit/chromium/src/AssertMatchingEnums.cpp index d2461a9b4..c6bf971f1 100644 --- a/Source/WebKit/chromium/src/AssertMatchingEnums.cpp +++ b/Source/WebKit/chromium/src/AssertMatchingEnums.cpp @@ -124,6 +124,11 @@ #include <wtf/Assertions.h> #include <wtf/text/StringImpl.h> +#if OS(DARWIN) +#include "PlatformSupport.h" +#include <public/mac/WebThemeEngine.h> +#endif + #define COMPILE_ASSERT_MATCHING_ENUM(webkit_name, webcore_name) \ COMPILE_ASSERT(int(WebKit::webkit_name) == int(WebCore::webcore_name), mismatching_enums) @@ -543,6 +548,22 @@ COMPILE_ASSERT_MATCHING_ENUM(WebStorageQuotaErrorNotSupported, NOT_SUPPORTED_ERR COMPILE_ASSERT_MATCHING_ENUM(WebStorageQuotaErrorAbort, ABORT_ERR); #endif +#if OS(DARWIN) +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::StateDisabled, PlatformSupport::StateDisabled); +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::StateInactive, PlatformSupport::StateInactive); +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::StateActive, PlatformSupport::StateActive); +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::StatePressed, PlatformSupport::StatePressed); + +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::SizeRegular, PlatformSupport::SizeRegular); +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::SizeSmall, PlatformSupport::SizeSmall); + +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::ScrollbarOrientationHorizontal, PlatformSupport::ScrollbarOrientationHorizontal); +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::ScrollbarOrientationVertical, PlatformSupport::ScrollbarOrientationVertical); + +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::ScrollbarParentScrollView, PlatformSupport::ScrollbarParentScrollView); +COMPILE_ASSERT_MATCHING_ENUM(WebThemeEngine::ScrollbarParentRenderLayer, PlatformSupport::ScrollbarParentRenderLayer); +#endif + COMPILE_ASSERT_MATCHING_ENUM(WebPageVisibilityStateVisible, PageVisibilityStateVisible); COMPILE_ASSERT_MATCHING_ENUM(WebPageVisibilityStateHidden, PageVisibilityStateHidden); COMPILE_ASSERT_MATCHING_ENUM(WebPageVisibilityStatePrerender, PageVisibilityStatePrerender); diff --git a/Source/WebKit/chromium/src/AssociatedURLLoader.h b/Source/WebKit/chromium/src/AssociatedURLLoader.h index d202b1861..2851f3f82 100644 --- a/Source/WebKit/chromium/src/AssociatedURLLoader.h +++ b/Source/WebKit/chromium/src/AssociatedURLLoader.h @@ -32,7 +32,7 @@ #define AssociatedURLLoader_h #include "WebURLLoaderOptions.h" -#include <public/WebURLLoader.h> +#include "platform/WebURLLoader.h" #include <wtf/Noncopyable.h> #include <wtf/OwnPtr.h> #include <wtf/RefPtr.h> diff --git a/Source/WebKit/chromium/src/AsyncFileWriterChromium.cpp b/Source/WebKit/chromium/src/AsyncFileWriterChromium.cpp index f9e492b9a..6071a0ae6 100644 --- a/Source/WebKit/chromium/src/AsyncFileWriterChromium.cpp +++ b/Source/WebKit/chromium/src/AsyncFileWriterChromium.cpp @@ -36,7 +36,7 @@ #include "AsyncFileWriterClient.h" #include "Blob.h" #include "WebFileWriter.h" -#include <public/WebURL.h> +#include "platform/WebURL.h" namespace WebCore { diff --git a/Source/WebKit/chromium/src/AudioDestinationChromium.cpp b/Source/WebKit/chromium/src/AudioDestinationChromium.cpp index 12dbba742..380c74b85 100644 --- a/Source/WebKit/chromium/src/AudioDestinationChromium.cpp +++ b/Source/WebKit/chromium/src/AudioDestinationChromium.cpp @@ -29,9 +29,14 @@ #include "config.h" #if ENABLE(WEB_AUDIO) + #include "AudioDestinationChromium.h" + #include "AudioFIFO.h" #include "AudioPullFIFO.h" +#include "WebKit.h" +#include "platform/WebKitPlatformSupport.h" + #include <public/Platform.h> using namespace WebKit; diff --git a/Source/WebKit/chromium/src/AudioDestinationChromium.h b/Source/WebKit/chromium/src/AudioDestinationChromium.h index 7b148c464..7d261a7fa 100644 --- a/Source/WebKit/chromium/src/AudioDestinationChromium.h +++ b/Source/WebKit/chromium/src/AudioDestinationChromium.h @@ -33,8 +33,8 @@ #include "AudioDestination.h" #include "AudioIOCallback.h" #include "AudioSourceProvider.h" -#include <public/WebAudioDevice.h> -#include <public/WebVector.h> +#include "platform/WebAudioDevice.h" +#include "platform/WebVector.h" namespace WebKit { class WebAudioDevice; } diff --git a/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp b/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp index 66cb82bd5..4e643029a 100644 --- a/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp +++ b/Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp @@ -44,8 +44,8 @@ #include "WebNode.h" #include "WebViewClient.h" #include "WebViewImpl.h" -#include <public/WebString.h> -#include <public/WebVector.h> +#include "platform/WebString.h" +#include "platform/WebVector.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.cpp b/Source/WebKit/chromium/src/ChromeClientImpl.cpp index 65810b90c..985757783 100644 --- a/Source/WebKit/chromium/src/ChromeClientImpl.cpp +++ b/Source/WebKit/chromium/src/ChromeClientImpl.cpp @@ -63,6 +63,7 @@ #include "Page.h" #include "PagePopupDriver.h" #include "PlatformScreen.h" +#include "PlatformSupport.h" #include "PopupContainer.h" #include "PopupMenuChromium.h" #include "RenderWidget.h" @@ -89,16 +90,16 @@ #include "WebPopupMenuImpl.h" #include "WebPopupMenuInfo.h" #include "WebPopupType.h" +#include "platform/WebRect.h" #include "WebSettings.h" #include "WebTextDirection.h" +#include "platform/WebURLRequest.h" #include "WebViewClient.h" #include "WebViewImpl.h" #include "WebWindowFeatures.h" #include "WindowFeatures.h" #include "WrappedResourceRequest.h" #include <public/Platform.h> -#include <public/WebRect.h> -#include <public/WebURLRequest.h> #include <wtf/text/CString.h> #include <wtf/text/StringBuilder.h> #include <wtf/text/StringConcatenate.h> @@ -917,7 +918,7 @@ void ChromeClientImpl::attachRootGraphicsLayer(Frame* frame, GraphicsLayer* grap m_webView->setRootGraphicsLayer(graphicsLayer); } -void ChromeClientImpl::scheduleCompositingLayerFlush() +void ChromeClientImpl::scheduleCompositingLayerSync() { m_webView->scheduleCompositingLayerSync(); } @@ -1120,7 +1121,7 @@ bool ChromeClientImpl::isPointerLocked() #endif #if ENABLE(WIDGET_REGION) -void ChromeClientImpl::annotatedRegionsChanged() +void ChromeClientImpl::dashboardRegionsChanged() { WebViewClient* client = m_webView->client(); if (client) diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.h b/Source/WebKit/chromium/src/ChromeClientImpl.h index f996831f6..7d456fbf5 100644 --- a/Source/WebKit/chromium/src/ChromeClientImpl.h +++ b/Source/WebKit/chromium/src/ChromeClientImpl.h @@ -139,7 +139,7 @@ public: virtual void reachedMaxAppCacheSize(int64_t spaceNeeded); virtual void reachedApplicationCacheOriginQuota(WebCore::SecurityOrigin*, int64_t totalSpaceNeeded); #if ENABLE(WIDGET_REGION) - virtual void annotatedRegionsChanged(); + virtual void dashboardRegionsChanged(); #endif virtual bool paintCustomOverhangArea(WebCore::GraphicsContext*, const WebCore::IntRect&, const WebCore::IntRect&, const WebCore::IntRect&); #if ENABLE(INPUT_TYPE_COLOR) @@ -171,7 +171,7 @@ public: // Sets a flag to specify that the view needs to be updated, so we need // to do an eager layout before the drawing. - virtual void scheduleCompositingLayerFlush(); + virtual void scheduleCompositingLayerSync(); virtual CompositingTriggerFlags allowedCompositingTriggers() const; #endif diff --git a/Source/WebKit/chromium/src/ColorChooserUIController.cpp b/Source/WebKit/chromium/src/ColorChooserUIController.cpp index 330f59ce2..c77634cff 100644 --- a/Source/WebKit/chromium/src/ColorChooserUIController.cpp +++ b/Source/WebKit/chromium/src/ColorChooserUIController.cpp @@ -32,18 +32,14 @@ #include "Color.h" #include "ColorChooserClient.h" #include "ColorSuggestionPicker.h" -#include "FrameView.h" #include "IntRect.h" #include "LocalizedStrings.h" #include "PickerCommon.h" #include "WebColorChooser.h" -#include "WebViewImpl.h" -#include <public/Platform.h> -#include <public/WebColor.h> +#include "platform/WebColor.h" +#include "platform/WebKitPlatformSupport.h" #include <public/WebLocalizedString.h> -using namespace WebCore; - namespace WebKit { // Keep in sync with Actions in colorSuggestionPicker.js. @@ -53,11 +49,10 @@ enum ColorPickerPopupAction { ColorPickerPopupActionSetValue = 0 }; -ColorChooserUIController::ColorChooserUIController(ChromeClientImpl* chromeClient, ColorChooserClient* client) +ColorChooserUIController::ColorChooserUIController(ChromeClientImpl* chromeClient, WebCore::ColorChooserClient* client) : m_chromeClient(chromeClient) , m_client(client) , m_popup(0) - , m_localizer(Localizer::createDefault()) { if (m_client->shouldShowSuggestions()) openPopup(); @@ -69,7 +64,7 @@ ColorChooserUIController::~ColorChooserUIController() { } -void ColorChooserUIController::setSelectedColor(const Color& color) +void ColorChooserUIController::setSelectedColor(const WebCore::Color& color) { ASSERT(m_chooser); m_chooser->setSelectedColor(static_cast<WebColor>(color.rgb())); @@ -86,7 +81,7 @@ void ColorChooserUIController::endChooser() void ColorChooserUIController::didChooseColor(const WebColor& color) { ASSERT(m_client); - m_client->didChooseColor(Color(static_cast<RGBA32>(color))); + m_client->didChooseColor(WebCore::Color(static_cast<WebCore::RGBA32>(color))); } void ColorChooserUIController::didEndChooser() @@ -96,45 +91,29 @@ void ColorChooserUIController::didEndChooser() m_client->didEndChooser(); } -IntSize ColorChooserUIController::contentSize() +WebCore::IntSize ColorChooserUIController::contentSize() { - return IntSize(0, 0); + return WebCore::IntSize(0, 0); } -void ColorChooserUIController::writeDocument(DocumentWriter& writer) +void ColorChooserUIController::writeDocument(WebCore::DocumentWriter& writer) { - Vector<Color> suggestions = m_client->suggestions(); + Vector<WebCore::Color> suggestions = m_client->suggestions(); Vector<String> suggestionValues; for (unsigned i = 0; i < suggestions.size(); i++) suggestionValues.append(suggestions[i].serialized()); - IntRect anchorRectInScreen = m_chromeClient->rootViewToScreen(m_client->elementRectRelativeToRootView()); - FrameView* view = static_cast<WebViewImpl*>(m_chromeClient->webView())->page()->mainFrame()->view(); - IntRect rootViewVisibleContentRect = view->visibleContentRect(true /* include scrollbars */); - IntRect rootViewRectInScreen = m_chromeClient->rootViewToScreen(rootViewVisibleContentRect); - PagePopupClient::addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", writer); - writer.addData(pickerCommonCss, sizeof(pickerCommonCss)); - writer.addData(colorSuggestionPickerCss, sizeof(colorSuggestionPickerCss)); - PagePopupClient::addString("</style></head><body><div id=main>Loading...</div><script>\n" + WebCore::PagePopupClient::addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", writer); + writer.addData(WebCore::pickerCommonCss, sizeof(WebCore::pickerCommonCss)); + writer.addData(WebCore::colorSuggestionPickerCss, sizeof(WebCore::colorSuggestionPickerCss)); + WebCore::PagePopupClient::addString("</style></head><body><div id=main>Loading...</div><script>\n" "window.dialogArguments = {\n", writer); - PagePopupClient::addProperty("values", suggestionValues, writer); - PagePopupClient::addProperty("otherColorLabel", Platform::current()->queryLocalizedString(WebLocalizedString::OtherColorLabel), writer); - addProperty("anchorRectInScreen", anchorRectInScreen, writer); - addProperty("rootViewRectInScreen", rootViewRectInScreen, writer); -#if OS(MAC_OS_X) - addProperty("confineToRootView", true, writer); -#else - addProperty("confineToRootView", false, writer); -#endif - PagePopupClient::addString("};\n", writer); - writer.addData(pickerCommonJs, sizeof(pickerCommonJs)); - writer.addData(colorSuggestionPickerJs, sizeof(colorSuggestionPickerJs)); - PagePopupClient::addString("</script></body>\n", writer); -} - -Localizer& ColorChooserUIController::localizer() -{ - return *m_localizer; + WebCore::PagePopupClient::addProperty("values", suggestionValues, writer); + WebCore::PagePopupClient::addProperty("otherColorLabel", Platform::current()->queryLocalizedString(WebLocalizedString::OtherColorLabel), writer); + WebCore::PagePopupClient::addString("};\n", writer); + writer.addData(WebCore::pickerCommonJs, sizeof(WebCore::pickerCommonJs)); + writer.addData(WebCore::colorSuggestionPickerJs, sizeof(WebCore::colorSuggestionPickerJs)); + WebCore::PagePopupClient::addString("</script></body>\n", writer); } void ColorChooserUIController::setValueAndClosePopup(int numValue, const String& stringValue) @@ -142,7 +121,7 @@ void ColorChooserUIController::setValueAndClosePopup(int numValue, const String& ASSERT(m_popup); ASSERT(m_client); if (numValue == ColorPickerPopupActionSetValue) - m_client->didChooseColor(Color(stringValue)); + m_client->didChooseColor(WebCore::Color(stringValue)); if (numValue == ColorPickerPopupActionChooseOtherColor) openColorChooser(); closePopup(); diff --git a/Source/WebKit/chromium/src/ColorChooserUIController.h b/Source/WebKit/chromium/src/ColorChooserUIController.h index 40c878b8e..98adb6714 100644 --- a/Source/WebKit/chromium/src/ColorChooserUIController.h +++ b/Source/WebKit/chromium/src/ColorChooserUIController.h @@ -29,7 +29,6 @@ #if ENABLE(INPUT_TYPE_COLOR) #include "ColorChooser.h" -#include "Localizer.h" #include "PagePopupClient.h" #include "WebColorChooserClient.h" #include <wtf/OwnPtr.h> @@ -61,7 +60,6 @@ public: // PagePopupClient functions: virtual WebCore::IntSize contentSize() OVERRIDE; virtual void writeDocument(WebCore::DocumentWriter&) OVERRIDE; - virtual WebCore::Localizer& localizer() OVERRIDE; virtual void setValueAndClosePopup(int, const String&) OVERRIDE; virtual void didClosePopup() OVERRIDE; @@ -74,7 +72,6 @@ private: WebCore::ColorChooserClient* m_client; OwnPtr<WebColorChooser> m_chooser; WebCore::PagePopup* m_popup; - OwnPtr<WebCore::Localizer> m_localizer; }; } diff --git a/Source/WebKit/chromium/src/CompositionUnderlineBuilder.h b/Source/WebKit/chromium/src/CompositionUnderlineBuilder.h index 636e81076..73e07cb55 100644 --- a/Source/WebKit/chromium/src/CompositionUnderlineBuilder.h +++ b/Source/WebKit/chromium/src/CompositionUnderlineBuilder.h @@ -32,9 +32,9 @@ #define CompositionUnderlineBuilder_h #include "Editor.h" -#include "WebCompositionUnderline.h" -#include <public/WebVector.h> #include <wtf/Vector.h> +#include "WebCompositionUnderline.h" +#include "platform/WebVector.h" namespace WebKit { diff --git a/Source/WebKit/chromium/src/CompositionUnderlineVectorBuilder.h b/Source/WebKit/chromium/src/CompositionUnderlineVectorBuilder.h index 5d4f08289..b12b92cc6 100644 --- a/Source/WebKit/chromium/src/CompositionUnderlineVectorBuilder.h +++ b/Source/WebKit/chromium/src/CompositionUnderlineVectorBuilder.h @@ -32,9 +32,9 @@ #define CompositionUnderlineVectorBuilder_h #include "Editor.h" -#include "WebCompositionUnderline.h" -#include <public/WebVector.h> #include <wtf/Vector.h> +#include "WebCompositionUnderline.h" +#include "platform/WebVector.h" namespace WebKit { diff --git a/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp b/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp index ad116090c..641a585a0 100644 --- a/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp +++ b/Source/WebKit/chromium/src/ContextMenuClientImpl.cpp @@ -47,6 +47,7 @@ #include "HTMLMediaElement.h" #include "HTMLNames.h" #include "HTMLPlugInImageElement.h" + #include "HistoryItem.h" #include "HitTestResult.h" #include "KURL.h" @@ -56,6 +57,7 @@ #include "Settings.h" #include "TextBreakIterator.h" #include "Widget.h" + #include "WebContextMenuData.h" #include "WebDataSourceImpl.h" #include "WebFormElement.h" @@ -63,15 +65,15 @@ #include "WebMenuItemInfo.h" #include "WebPlugin.h" #include "WebPluginContainerImpl.h" +#include "platform/WebPoint.h" #include "WebSearchableFormData.h" #include "WebSpellCheckClient.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" +#include "platform/WebURLResponse.h" +#include "platform/WebVector.h" #include "WebViewClient.h" #include "WebViewImpl.h" -#include <public/WebPoint.h> -#include <public/WebString.h> -#include <public/WebURL.h> -#include <public/WebURLResponse.h> -#include <public/WebVector.h> #include <wtf/text/WTFString.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp b/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp index 20044add8..4e2c69e9f 100644 --- a/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp +++ b/Source/WebKit/chromium/src/DateTimeChooserImpl.cpp @@ -37,18 +37,16 @@ #include "ChromeClientImpl.h" #include "DateComponents.h" #include "DateTimeChooserClient.h" -#include "FrameView.h" #include "InputTypeNames.h" #include "Language.h" -#include "Localizer.h" +#include "LocalizedDate.h" #include "NotImplemented.h" #include "PickerCommon.h" #include "RenderTheme.h" -#include "WebViewImpl.h" -#include <public/Platform.h> +#include "platform/WebKitPlatformSupport.h" #include <public/WebLocalizedString.h> -using namespace WebCore; +using namespace WTF::Unicode; namespace WebKit { @@ -57,7 +55,6 @@ DateTimeChooserImpl::DateTimeChooserImpl(ChromeClientImpl* chromeClient, WebCore , m_client(client) , m_popup(0) , m_parameters(parameters) - , m_localizer(WebCore::Localizer::createDefault()) { ASSERT(m_chromeClient); ASSERT(m_client); @@ -88,11 +85,6 @@ void DateTimeChooserImpl::writeDocument(WebCore::DocumentWriter& writer) date.setMillisecondsSinceEpochForDate(m_parameters.maximum); String maxString = date.toString(); String stepString = String::number(m_parameters.step); - String stepBaseString = String::number(m_parameters.stepBase, 11, WTF::TruncateTrailingZeros); - IntRect anchorRectInScreen = m_chromeClient->rootViewToScreen(m_parameters.anchorRectInRootView); - FrameView* view = static_cast<WebViewImpl*>(m_chromeClient->webView())->page()->mainFrame()->view(); - IntRect rootViewVisibleContentRect = view->visibleContentRect(true /* include scrollbars */); - IntRect rootViewRectInScreen = m_chromeClient->rootViewToScreen(rootViewVisibleContentRect); addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", writer); writer.addData(WebCore::pickerCommonCss, sizeof(WebCore::pickerCommonCss)); @@ -103,27 +95,19 @@ void DateTimeChooserImpl::writeDocument(WebCore::DocumentWriter& writer) writer.addData(extraStyle.data(), extraStyle.length()); addString("</style></head><body><div id=main>Loading...</div><script>\n" "window.dialogArguments = {\n", writer); - addProperty("anchorRectInScreen", anchorRectInScreen, writer); - addProperty("rootViewRectInScreen", rootViewRectInScreen, writer); -#if OS(MAC_OS_X) - addProperty("confineToRootView", true, writer); -#else - addProperty("confineToRootView", false, writer); -#endif addProperty("min", minString, writer); addProperty("max", maxString, writer); addProperty("step", stepString, writer); - addProperty("stepBase", stepBaseString, writer); addProperty("required", m_parameters.required, writer); addProperty("currentValue", m_parameters.currentValue, writer); addProperty("locale", WebCore::defaultLanguage(), writer); addProperty("todayLabel", Platform::current()->queryLocalizedString(WebLocalizedString::CalendarToday), writer); addProperty("clearLabel", Platform::current()->queryLocalizedString(WebLocalizedString::CalendarClear), writer); - addProperty("weekStartDay", m_localizer->firstDayOfWeek(), writer); - addProperty("monthLabels", m_localizer->monthLabels(), writer); - addProperty("dayLabels", m_localizer->weekDayShortLabels(), writer); - addProperty("isCalendarRTL", m_localizer->isRTL(), writer); - addProperty("isRTL", m_parameters.isAnchorElementRTL, writer); + addProperty("weekStartDay", WebCore::firstDayOfWeek(), writer); + addProperty("monthLabels", WebCore::monthLabels(), writer); + addProperty("dayLabels", WebCore::weekDayShortLabels(), writer); + Direction dir = direction(WebCore::monthLabels()[0][0]); + addProperty("isRTL", dir == RightToLeft || dir == RightToLeftArabic, writer); if (m_parameters.suggestionValues.size()) { addProperty("inputWidth", static_cast<unsigned>(m_parameters.anchorRectInRootView.width()), writer); addProperty("suggestionValues", m_parameters.suggestionValues, writer); @@ -142,11 +126,6 @@ void DateTimeChooserImpl::writeDocument(WebCore::DocumentWriter& writer) addString("</script></body>\n", writer); } -WebCore::Localizer& DateTimeChooserImpl::localizer() -{ - return *m_localizer; -} - void DateTimeChooserImpl::setValueAndClosePopup(int numValue, const String& stringValue) { if (numValue >= 0) diff --git a/Source/WebKit/chromium/src/DateTimeChooserImpl.h b/Source/WebKit/chromium/src/DateTimeChooserImpl.h index 40195ce53..e504592bc 100644 --- a/Source/WebKit/chromium/src/DateTimeChooserImpl.h +++ b/Source/WebKit/chromium/src/DateTimeChooserImpl.h @@ -57,7 +57,6 @@ private: // PagePopupClient functions: virtual WebCore::IntSize contentSize() OVERRIDE; virtual void writeDocument(WebCore::DocumentWriter&) OVERRIDE; - virtual WebCore::Localizer& localizer() OVERRIDE; virtual void setValueAndClosePopup(int, const String&) OVERRIDE; virtual void didClosePopup() OVERRIDE; @@ -65,7 +64,6 @@ private: WebCore::DateTimeChooserClient* m_client; WebCore::PagePopup* m_popup; WebCore::DateTimeChooserParameters m_parameters; - OwnPtr<WebCore::Localizer> m_localizer; }; } diff --git a/Source/WebKit/chromium/src/DeliveredIntentClientImpl.h b/Source/WebKit/chromium/src/DeliveredIntentClientImpl.h index 5ece4eed1..a94d39b7c 100644 --- a/Source/WebKit/chromium/src/DeliveredIntentClientImpl.h +++ b/Source/WebKit/chromium/src/DeliveredIntentClientImpl.h @@ -33,7 +33,7 @@ #include "DeliveredIntent.h" #include "SerializedScriptValue.h" -#include <public/WebCommon.h> +#include "platform/WebCommon.h" #include <wtf/PassRefPtr.h> namespace WebKit { diff --git a/Source/WebKit/chromium/src/DragClientImpl.cpp b/Source/WebKit/chromium/src/DragClientImpl.cpp index 39f48c6b5..3974e7ad3 100644 --- a/Source/WebKit/chromium/src/DragClientImpl.cpp +++ b/Source/WebKit/chromium/src/DragClientImpl.cpp @@ -35,11 +35,12 @@ #include "ClipboardChromium.h" #include "Frame.h" #include "NativeImageSkia.h" +#include "platform/WebCommon.h" +#include "platform/WebImage.h" #include "WebViewClient.h" #include "WebViewImpl.h" -#include <public/WebCommon.h> + #include <public/WebDragData.h> -#include <public/WebImage.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/DragScrollTimer.h b/Source/WebKit/chromium/src/DragScrollTimer.h index e6aacd7ae..fe19013e2 100644 --- a/Source/WebKit/chromium/src/DragScrollTimer.h +++ b/Source/WebKit/chromium/src/DragScrollTimer.h @@ -33,7 +33,7 @@ #include "IntSize.h" #include "Timer.h" -#include <public/WebPoint.h> +#include "platform/WebPoint.h" namespace WebCore { class FrameView; } diff --git a/Source/WebKit/chromium/src/ExternalPopupMenu.cpp b/Source/WebKit/chromium/src/ExternalPopupMenu.cpp index 3166384c0..1855401c4 100644 --- a/Source/WebKit/chromium/src/ExternalPopupMenu.cpp +++ b/Source/WebKit/chromium/src/ExternalPopupMenu.cpp @@ -38,8 +38,8 @@ #include "WebExternalPopupMenu.h" #include "WebMenuItemInfo.h" #include "WebPopupMenuInfo.h" +#include "platform/WebVector.h" #include "WebViewClient.h" -#include <public/WebVector.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/FindInPageCoordinates.cpp b/Source/WebKit/chromium/src/FindInPageCoordinates.cpp index 5dbfacc23..643848868 100644 --- a/Source/WebKit/chromium/src/FindInPageCoordinates.cpp +++ b/Source/WebKit/chromium/src/FindInPageCoordinates.cpp @@ -67,7 +67,7 @@ static FloatRect toNormalizedRect(const FloatRect& absoluteRect, const RenderObj scrolledOrigin = -IntPoint(container->scrolledContentOffset()); FloatRect overflowRect(scrolledOrigin, container->maxLayoutOverflow()); - FloatRect containerRect = container->localToAbsoluteQuad(FloatQuad(overflowRect), SnapOffsetForTransforms).enclosingBoundingBox(); + FloatRect containerRect = container->localToAbsoluteQuad(FloatQuad(overflowRect), false).enclosingBoundingBox(); if (containerRect.isEmpty()) return FloatRect(); diff --git a/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp b/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp index 49e780baf..0ac5d932c 100644 --- a/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp +++ b/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp @@ -57,9 +57,6 @@ #include "ProgressTracker.h" #include "ResourceHandleInternal.h" #include "ResourceLoader.h" -#if ENABLE(MEDIA_STREAM) -#include "RTCPeerConnectionHandlerChromium.h" -#endif #include "Settings.h" #include "SocketStreamHandleInternal.h" #include "WebDOMEvent.h" @@ -78,17 +75,18 @@ #include "WebPluginLoadObserver.h" #include "WebPluginParams.h" #include "WebSecurityOrigin.h" +#include "platform/WebSocketStreamHandle.h" #include "WebViewClient.h" #include "WebViewImpl.h" #include "WindowFeatures.h" #include "WrappedResourceRequest.h" #include "WrappedResourceResponse.h" +#include "platform/WebURL.h" +#include "platform/WebURLError.h" +#include "platform/WebVector.h" #include <public/Platform.h> #include <public/WebMimeRegistry.h> -#include <public/WebSocketStreamHandle.h> -#include <public/WebURL.h> -#include <public/WebURLError.h> -#include <public/WebVector.h> + #include <wtf/StringExtras.h> #include <wtf/text/CString.h> #include <wtf/text/WTFString.h> @@ -128,7 +126,7 @@ void FrameLoaderClientImpl::frameLoaderDestroyed() // serves to keep us alive until the FrameLoader is done with us. The // FrameLoader calls this method when it's going away. Therefore, we balance // out that extra reference, which may cause 'this' to be deleted. - ASSERT(!m_webFrame->frame()); + m_webFrame->closing(); m_webFrame->deref(); } @@ -1641,12 +1639,4 @@ void FrameLoaderClientImpl::dispatchWillOpenSocketStream(SocketStreamHandle* han m_webFrame->client()->willOpenSocketStream(SocketStreamHandleInternal::toWebSocketStreamHandle(handle)); } -#if ENABLE(MEDIA_STREAM) -void FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler(RTCPeerConnectionHandler* handler) -{ - m_webFrame->client()->willStartUsingPeerConnectionHandler(webFrame(), RTCPeerConnectionHandlerChromium::toWebRTCPeerConnectionHandler(handler)); -} -#endif - - } // namespace WebKit diff --git a/Source/WebKit/chromium/src/FrameLoaderClientImpl.h b/Source/WebKit/chromium/src/FrameLoaderClientImpl.h index 12a76feee..4d33267ce 100644 --- a/Source/WebKit/chromium/src/FrameLoaderClientImpl.h +++ b/Source/WebKit/chromium/src/FrameLoaderClientImpl.h @@ -182,7 +182,6 @@ public: const WebCore::IntSize&, WebCore::HTMLPlugInElement*, const WebCore::KURL&, const Vector<WTF::String>&, const Vector<WTF::String>&, const WTF::String&, bool loadManually); - virtual void recreatePlugin(WebCore::Widget*) { } virtual void redirectDataToPlugin(WebCore::Widget* pluginWidget); virtual PassRefPtr<WebCore::Widget> createJavaAppletWidget( const WebCore::IntSize&, @@ -221,10 +220,6 @@ public: virtual void dispatchWillOpenSocketStream(WebCore::SocketStreamHandle*) OVERRIDE; -#if ENABLE(MEDIA_STREAM) - virtual void dispatchWillStartUsingPeerConnectionHandler(WebCore::RTCPeerConnectionHandler*) OVERRIDE; -#endif - private: void makeDocumentView(); diff --git a/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp b/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp index 29b8c4bf4..501ce61fb 100644 --- a/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp +++ b/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp @@ -66,12 +66,12 @@ IDBDatabaseMetadata IDBDatabaseBackendProxy::metadata() const return m_webIDBDatabase->metadata(); } -PassRefPtr<IDBObjectStoreBackendInterface> IDBDatabaseBackendProxy::createObjectStore(int64_t id, const String& name, const IDBKeyPath& keyPath, bool autoIncrement, IDBTransactionBackendInterface* transaction, ExceptionCode& ec) +PassRefPtr<IDBObjectStoreBackendInterface> IDBDatabaseBackendProxy::createObjectStore(const String& name, const IDBKeyPath& keyPath, bool autoIncrement, IDBTransactionBackendInterface* transaction, ExceptionCode& ec) { // The transaction pointer is guaranteed to be a pointer to a proxy object as, in the renderer, // all implementations of IDB interfaces are proxy objects. IDBTransactionBackendProxy* transactionProxy = static_cast<IDBTransactionBackendProxy*>(transaction); - OwnPtr<WebIDBObjectStore> objectStore = adoptPtr(m_webIDBDatabase->createObjectStore(id, name, keyPath, autoIncrement, *transactionProxy->getWebIDBTransaction(), ec)); + OwnPtr<WebIDBObjectStore> objectStore = adoptPtr(m_webIDBDatabase->createObjectStore(name, keyPath, autoIncrement, *transactionProxy->getWebIDBTransaction(), ec)); if (!objectStore) return 0; return IDBObjectStoreBackendProxy::create(objectStore.release()); diff --git a/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h b/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h index fc831e8de..795610aa6 100644 --- a/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h +++ b/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h @@ -44,7 +44,7 @@ public: virtual WebCore::IDBDatabaseMetadata metadata() const; - virtual PassRefPtr<WebCore::IDBObjectStoreBackendInterface> createObjectStore(int64_t, const String& name, const WebCore::IDBKeyPath&, bool autoIncrement, WebCore::IDBTransactionBackendInterface*, WebCore::ExceptionCode&); + virtual PassRefPtr<WebCore::IDBObjectStoreBackendInterface> createObjectStore(const String& name, const WebCore::IDBKeyPath&, bool autoIncrement, WebCore::IDBTransactionBackendInterface*, WebCore::ExceptionCode&); virtual void deleteObjectStore(const String& name, WebCore::IDBTransactionBackendInterface*, WebCore::ExceptionCode&); virtual void setVersion(const String& version, PassRefPtr<WebCore::IDBCallbacks>, PassRefPtr<WebCore::IDBDatabaseCallbacks>, WebCore::ExceptionCode&); virtual PassRefPtr<WebCore::IDBTransactionBackendInterface> transaction(WebCore::DOMStringList* storeNames, unsigned short mode, WebCore::ExceptionCode&); diff --git a/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp b/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp index 2b9b44a7a..b53eb2c3a 100755 --- a/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp +++ b/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp @@ -103,17 +103,6 @@ void IDBObjectStoreBackendProxy::clear(PassRefPtr<IDBCallbacks> callbacks, IDBTr m_webIDBObjectStore->clear(new WebIDBCallbacksImpl(callbacks), *transactionProxy->getWebIDBTransaction(), ec); } -PassRefPtr<IDBIndexBackendInterface> IDBObjectStoreBackendProxy::createIndex(int64_t id, const String& name, const IDBKeyPath& keyPath, bool unique, bool multiEntry, IDBTransactionBackendInterface* transaction, ExceptionCode& ec) -{ - // The transaction pointer is guaranteed to be a pointer to a proxy object as, in the renderer, - // all implementations of IDB interfaces are proxy objects. - IDBTransactionBackendProxy* transactionProxy = static_cast<IDBTransactionBackendProxy*>(transaction); - OwnPtr<WebIDBIndex> index = adoptPtr(m_webIDBObjectStore->createIndex(id, name, keyPath, unique, multiEntry, *transactionProxy->getWebIDBTransaction(), ec)); - if (!index) - return 0; - return IDBIndexBackendProxy::create(index.release()); -} - PassRefPtr<IDBIndexBackendInterface> IDBObjectStoreBackendProxy::createIndex(const String& name, const IDBKeyPath& keyPath, bool unique, bool multiEntry, IDBTransactionBackendInterface* transaction, ExceptionCode& ec) { // The transaction pointer is guaranteed to be a pointer to a proxy object as, in the renderer, diff --git a/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.h b/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.h index 8470c1ad9..74cb0bd57 100644 --- a/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.h +++ b/Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.h @@ -48,7 +48,6 @@ public: virtual void deleteFunction(PassRefPtr<WebCore::IDBKeyRange>, PassRefPtr<WebCore::IDBCallbacks>, WebCore::IDBTransactionBackendInterface*, WebCore::ExceptionCode&); virtual void clear(PassRefPtr<WebCore::IDBCallbacks>, WebCore::IDBTransactionBackendInterface*, WebCore::ExceptionCode&); - PassRefPtr<WebCore::IDBIndexBackendInterface> createIndex(int64_t id, const String& name, const WebCore::IDBKeyPath&, bool unique, bool multiEntry, WebCore::IDBTransactionBackendInterface*, WebCore::ExceptionCode&); PassRefPtr<WebCore::IDBIndexBackendInterface> createIndex(const String& name, const WebCore::IDBKeyPath&, bool unique, bool multiEntry, WebCore::IDBTransactionBackendInterface*, WebCore::ExceptionCode&); virtual void setIndexKeys(PassRefPtr<WebCore::IDBKey> prpPrimaryKey, const WTF::Vector<WTF::String>&, const WTF::Vector<IndexKeys>&, WebCore::IDBTransactionBackendInterface*); virtual void setIndexesReady(const Vector<String>&, WebCore::IDBTransactionBackendInterface*); diff --git a/Source/WebKit/chromium/src/InspectorClientImpl.cpp b/Source/WebKit/chromium/src/InspectorClientImpl.cpp index 402b8695c..6948982c8 100644 --- a/Source/WebKit/chromium/src/InspectorClientImpl.cpp +++ b/Source/WebKit/chromium/src/InspectorClientImpl.cpp @@ -37,12 +37,12 @@ #include "NotImplemented.h" #include "Page.h" #include "WebDevToolsAgentImpl.h" +#include "platform/WebRect.h" +#include "platform/WebURL.h" +#include "platform/WebURLRequest.h" #include "WebViewClient.h" #include "WebViewImpl.h" #include <public/Platform.h> -#include <public/WebRect.h> -#include <public/WebURL.h> -#include <public/WebURLRequest.h> #include <wtf/Vector.h> using namespace WebCore; @@ -163,12 +163,6 @@ bool InspectorClientImpl::supportsFrameInstrumentation() return true; } -void InspectorClientImpl::getAllocatedObjects(HashSet<const void*>& set) -{ - if (WebDevToolsAgentImpl* agent = devToolsAgent()) - agent->getAllocatedObjects(set); -} - void InspectorClientImpl::willProcessTask() { InspectorInstrumentation::willProcessTask(m_inspectedWebView->page()); diff --git a/Source/WebKit/chromium/src/InspectorClientImpl.h b/Source/WebKit/chromium/src/InspectorClientImpl.h index 9e1ea370e..7abbd3bf5 100644 --- a/Source/WebKit/chromium/src/InspectorClientImpl.h +++ b/Source/WebKit/chromium/src/InspectorClientImpl.h @@ -34,7 +34,7 @@ #include "InspectorClient.h" #include "InspectorController.h" #include "InspectorFrontendChannel.h" -#include <public/WebThread.h> +#include "platform/WebThread.h" #include <wtf/OwnPtr.h> namespace WebKit { @@ -78,8 +78,6 @@ public: virtual bool supportsFrameInstrumentation(); - virtual void getAllocatedObjects(HashSet<const void*>&); - private: // WebThread::TaskObserver virtual void willProcessTask(); diff --git a/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp b/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp index 763c85da8..f2657a7bd 100644 --- a/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp +++ b/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp @@ -39,8 +39,8 @@ #include "V8InspectorFrontendHost.h" #include "WebDevToolsFrontendClient.h" #include "WebDevToolsFrontendImpl.h" -#include <public/WebFloatPoint.h> -#include <public/WebString.h> +#include "platform/WebFloatPoint.h" +#include "platform/WebString.h" #include <wtf/text/WTFString.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/LinkHighlight.cpp b/Source/WebKit/chromium/src/LinkHighlight.cpp index 815a0c300..1e72900c4 100644 --- a/Source/WebKit/chromium/src/LinkHighlight.cpp +++ b/Source/WebKit/chromium/src/LinkHighlight.cpp @@ -65,7 +65,6 @@ LinkHighlight::LinkHighlight(Node* node, WebViewImpl* owningWebViewImpl) , m_owningWebViewImpl(owningWebViewImpl) , m_currentGraphicsLayer(0) , m_geometryNeedsUpdate(false) - , m_isAnimating(false) { ASSERT(m_node); ASSERT(owningWebViewImpl); @@ -74,11 +73,12 @@ LinkHighlight::LinkHighlight(Node* node, WebViewImpl* owningWebViewImpl) m_clipLayer = adoptPtr(compositorSupport->createLayer()); m_clipLayer->setAnchorPoint(WebFloatPoint()); m_clipLayer->addChild(m_contentLayer->layer()); + m_contentLayer->layer()->setDrawsContent(false); + + // We don't want to show the highlight until startAnimation is called, even though the highlight + // layer may be added to the tree immediately. + m_contentLayer->layer()->setOpacity(0); m_contentLayer->layer()->setAnimationDelegate(this); - m_contentLayer->layer()->setDrawsContent(true); - m_contentLayer->layer()->setOpacity(1); - m_geometryNeedsUpdate = true; - updateGeometry(); } LinkHighlight::~LinkHighlight() @@ -143,84 +143,40 @@ RenderLayer* LinkHighlight::computeEnclosingCompositingLayer() return renderLayer; } -static void convertTargetSpaceQuadToCompositedLayer(const FloatQuad& targetSpaceQuad, RenderObject* targetRenderer, RenderObject* compositedRenderer, FloatQuad& compositedSpaceQuad) -{ - ASSERT(targetRenderer); - ASSERT(compositedRenderer); - - for (unsigned i = 0; i < 4; ++i) { - IntPoint point; - switch (i) { - case 0: point = roundedIntPoint(targetSpaceQuad.p1()); break; - case 1: point = roundedIntPoint(targetSpaceQuad.p2()); break; - case 2: point = roundedIntPoint(targetSpaceQuad.p3()); break; - case 3: point = roundedIntPoint(targetSpaceQuad.p4()); break; - } - - point = targetRenderer->frame()->view()->contentsToWindow(point); - point = compositedRenderer->frame()->view()->windowToContents(point); - FloatPoint floatPoint = compositedRenderer->absoluteToLocal(point, UseTransforms | SnapOffsetForTransforms); - - switch (i) { - case 0: compositedSpaceQuad.setP1(floatPoint); break; - case 1: compositedSpaceQuad.setP2(floatPoint); break; - case 2: compositedSpaceQuad.setP3(floatPoint); break; - case 3: compositedSpaceQuad.setP4(floatPoint); break; - } - } -} - -static void addQuadToPath(const FloatQuad& quad, Path& path) -{ - // FIXME: Make this create rounded quad-paths, just like the axis-aligned case. - path.moveTo(quad.p1()); - path.addLineTo(quad.p2()); - path.addLineTo(quad.p3()); - path.addLineTo(quad.p4()); - path.closeSubpath(); -} - bool LinkHighlight::computeHighlightLayerPathAndPosition(RenderLayer* compositingLayer) { if (!m_node || !m_node->renderer()) return false; - ASSERT(compositingLayer); - - // Get quads for node in absolute coordinates. - Vector<FloatQuad> quads; - m_node->renderer()->absoluteQuads(quads); - ASSERT(quads.size()); - - Path newPath; - for (unsigned quadIndex = 0; quadIndex < quads.size(); ++quadIndex) { - - FloatQuad transformedQuad; - - // Transform node quads in target absolute coords to local coordinates in the compositor layer. - convertTargetSpaceQuadToCompositedLayer(quads[quadIndex], m_node->renderer(), compositingLayer->renderer(), transformedQuad); - - // FIXME: for now, we'll only use rounded paths if we have a single node quad. The reason for this is that - // we may sometimes get a chain of adjacent boxes (e.g. for text nodes) which end up looking like sausage - // links: these should ideally be merged into a single rect before creating the path, but that's - // another CL. - if (quads.size() == 1 && transformedQuad.isRectilinear()) { - FloatSize rectRoundingRadii(3, 3); - newPath.addRoundedRect(transformedQuad.boundingBox(), rectRoundingRadii); - } else - addQuadToPath(transformedQuad, newPath); + bool pathHasChanged = false; + FloatRect boundingRect = m_node->pixelSnappedBoundingBox(); + + // FIXME: If we ever use a more sophisticated highlight path, we'll need + // to devise a way of detecting when it changes. + if (boundingRect.size() != m_path.boundingRect().size()) { + FloatSize rectRoundingRadii(3, 3); + m_path.clear(); + m_path.addRoundedRect(boundingRect, rectRoundingRadii); + // Always treat the path as being at the origin of this layer. + m_path.translate(FloatPoint() - boundingRect.location()); + pathHasChanged = true; } - FloatRect boundingRect = newPath.boundingRect(); - newPath.translate(FloatPoint() - boundingRect.location()); + FloatRect nodeBounds = boundingRect; - bool pathHasChanged = !m_path.platformPath() || !(*newPath.platformPath() == *m_path.platformPath()); - if (pathHasChanged) { - m_path = newPath; - m_contentLayer->layer()->setBounds(enclosingIntRect(boundingRect).size()); - } + // This is a simplified, but basically correct, transformation of the target location, converted + // from its containing frame view to window coordinates and then back to the containing frame view + // of the composited layer. + // FIXME: We also need to transform the target's size in case of scaling. This can be done by also transforming + // the full rects in the xToY calls, and transforming both the upper-left and lower right corners + // to local coordinates at the end.. + ASSERT(compositingLayer); + IntPoint targetWindow = m_node->renderer()->frame()->view()->contentsToWindow(enclosingIntRect(nodeBounds).location()); + IntPoint targetCompositorAbsolute = compositingLayer->renderer()->frame()->view()->windowToContents(targetWindow); + FloatPoint targetCompositorLocal = compositingLayer->renderer()->absoluteToLocal(targetCompositorAbsolute, false, true); - m_contentLayer->layer()->setPosition(boundingRect.location()); + m_contentLayer->layer()->setBounds(WebSize(enclosingIntRect(nodeBounds).size())); + m_contentLayer->layer()->setPosition(WebFloatPoint(targetCompositorLocal)); return pathHasChanged; } @@ -238,12 +194,8 @@ void LinkHighlight::paintContents(WebCanvas* canvas, const WebRect& webClipRect, gc.fillPath(m_path); } -void LinkHighlight::startHighlightAnimationIfNeeded() +void LinkHighlight::startHighlightAnimation() { - if (m_isAnimating) - return; - - m_isAnimating = true; const float startOpacity = 1; // FIXME: Should duration be configurable? const float duration = 0.1f; diff --git a/Source/WebKit/chromium/src/LinkHighlight.h b/Source/WebKit/chromium/src/LinkHighlight.h index 3bac3c729..4eb6f5967 100644 --- a/Source/WebKit/chromium/src/LinkHighlight.h +++ b/Source/WebKit/chromium/src/LinkHighlight.h @@ -54,7 +54,7 @@ public: WebContentLayer* contentLayer(); WebLayer* clipLayer(); - void startHighlightAnimationIfNeeded(); + void startHighlightAnimation(); void updateGeometry(); // WebContentLayerClient implementation. @@ -90,7 +90,6 @@ private: WebCore::GraphicsLayerChromium* m_currentGraphicsLayer; bool m_geometryNeedsUpdate; - bool m_isAnimating; WebCore::FloatPoint m_graphicsLayerOffset; }; diff --git a/Source/WebKit/chromium/src/LocalizedStrings.cpp b/Source/WebKit/chromium/src/LocalizedStrings.cpp index 0cc8e00eb..40a009369 100644 --- a/Source/WebKit/chromium/src/LocalizedStrings.cpp +++ b/Source/WebKit/chromium/src/LocalizedStrings.cpp @@ -202,7 +202,7 @@ String AXMenuListActionVerb() return String(); } -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) String AXAMPMFieldText() { return query(WebLocalizedString::AXAMPMFieldText); @@ -252,32 +252,6 @@ String AXYearFieldText() { return query(WebLocalizedString::AXYearFieldText); } - -String placeholderForDayOfMonthField() -{ - return query(WebLocalizedString::PlaceholderForDayOfMonthField); -} - -String placeholderForMonthField() -{ - return query(WebLocalizedString::PlaceholderForMonthField); -} - -String placeholderForYearField() -{ - return query(WebLocalizedString::PlaceholderForYearField); -} - -String monthFormatInLDML() -{ - return query(WebLocalizedString::MonthFormatInLDML); -} - -String weekFormatInLDML() -{ - return query(WebLocalizedString::WeekFormatInLDML); -} - #endif String missingPluginText() diff --git a/Source/WebKit/chromium/src/NonCompositedContentHost.cpp b/Source/WebKit/chromium/src/NonCompositedContentHost.cpp index 21b9725b0..9729d05ec 100644 --- a/Source/WebKit/chromium/src/NonCompositedContentHost.cpp +++ b/Source/WebKit/chromium/src/NonCompositedContentHost.cpp @@ -32,7 +32,6 @@ #include "GraphicsLayer.h" #include "GraphicsLayerChromium.h" #include "PlatformContextSkia.h" -#include "Settings.h" #include "WebViewImpl.h" #include <public/WebContentLayer.h> #include <public/WebFloatPoint.h> @@ -44,12 +43,12 @@ NonCompositedContentHost::NonCompositedContentHost(WebViewImpl* webView) , m_opaque(true) , m_showDebugBorders(false) { - m_graphicsLayer = WebCore::GraphicsLayer::create(0, this); + m_graphicsLayer = WebCore::GraphicsLayer::create(this); #ifndef NDEBUG m_graphicsLayer->setName("non-composited content"); #endif m_graphicsLayer->setDrawsContent(true); - m_graphicsLayer->setAppliesPageScale(!m_webView->page()->settings()->applyPageScaleFactorInCompositor()); + m_graphicsLayer->setAppliesPageScale(true); WebContentLayer* layer = static_cast<WebCore::GraphicsLayerChromium*>(m_graphicsLayer.get())->contentLayer(); layer->setUseLCDText(true); layer->layer()->setOpaque(true); @@ -166,7 +165,7 @@ void NonCompositedContentHost::notifyAnimationStarted(const WebCore::GraphicsLay // Intentionally left empty since we don't support animations on the non-composited content. } -void NonCompositedContentHost::notifyFlushRequired(const WebCore::GraphicsLayer*) +void NonCompositedContentHost::notifySyncRequired(const WebCore::GraphicsLayer*) { m_webView->scheduleCompositingLayerSync(); } diff --git a/Source/WebKit/chromium/src/NonCompositedContentHost.h b/Source/WebKit/chromium/src/NonCompositedContentHost.h index 08e9c69b2..69776d90f 100644 --- a/Source/WebKit/chromium/src/NonCompositedContentHost.h +++ b/Source/WebKit/chromium/src/NonCompositedContentHost.h @@ -69,7 +69,7 @@ protected: private: // GraphicsLayerClient virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time); - virtual void notifyFlushRequired(const WebCore::GraphicsLayer*); + virtual void notifySyncRequired(const WebCore::GraphicsLayer*); virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& clipRect); virtual bool showDebugBorders(const WebCore::GraphicsLayer*) const; virtual bool showRepaintCounter(const WebCore::GraphicsLayer*) const; diff --git a/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp b/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp index d6df72efb..683e66faa 100644 --- a/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp +++ b/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp @@ -41,7 +41,7 @@ #include "WebNotification.h" #include "WebNotificationPermissionCallback.h" #include "WebNotificationPresenter.h" -#include <public/WebURL.h> +#include "platform/WebURL.h" #include <wtf/PassRefPtr.h> diff --git a/Source/WebKit/chromium/src/PageOverlay.cpp b/Source/WebKit/chromium/src/PageOverlay.cpp index a16a01077..b5d157a4b 100644 --- a/Source/WebKit/chromium/src/PageOverlay.cpp +++ b/Source/WebKit/chromium/src/PageOverlay.cpp @@ -75,7 +75,7 @@ public: virtual void notifyAnimationStarted(const GraphicsLayer*, double time) { } - virtual void notifyFlushRequired(const GraphicsLayer*) { } + virtual void notifySyncRequired(const GraphicsLayer*) { } virtual void paintContents(const GraphicsLayer*, GraphicsContext& gc, GraphicsLayerPaintingPhase, const IntRect& inClip) { diff --git a/Source/WebKit/chromium/src/PageWidgetDelegate.cpp b/Source/WebKit/chromium/src/PageWidgetDelegate.cpp index 071c22a3d..6ad25d953 100644 --- a/Source/WebKit/chromium/src/PageWidgetDelegate.cpp +++ b/Source/WebKit/chromium/src/PageWidgetDelegate.cpp @@ -59,7 +59,8 @@ void PageWidgetDelegate::animate(Page* page, double monotonicFrameBeginTime) FrameView* view = mainFrameView(page); if (!view) return; - view->serviceScriptedAnimations(monotonicFrameBeginTime); + double timeShift = currentTime() - monotonicallyIncreasingTime(); + view->serviceScriptedAnimations(convertSecondsToDOMTimeStamp(monotonicFrameBeginTime + timeShift)); #endif } @@ -89,7 +90,6 @@ void PageWidgetDelegate::paint(Page* page, PageOverlayList* overlays, WebCanvas* GraphicsContext& gc = builder.context(); gc.platformContext()->setDrawingToImageBuffer(background == Opaque ? false : true); gc.applyDeviceScaleFactor(page->deviceScaleFactor()); - gc.platformContext()->setDeviceScaleFactor(page->deviceScaleFactor()); IntRect dirtyRect(rect); gc.save(); FrameView* view = mainFrameView(page); diff --git a/Source/WebKit/chromium/src/PageWidgetDelegate.h b/Source/WebKit/chromium/src/PageWidgetDelegate.h index c9f76bb95..807e1987b 100644 --- a/Source/WebKit/chromium/src/PageWidgetDelegate.h +++ b/Source/WebKit/chromium/src/PageWidgetDelegate.h @@ -33,7 +33,7 @@ #include "Page.h" #include "WebWidget.h" -#include <public/WebCanvas.h> +#include "platform/WebCanvas.h" #include <wtf/OwnPtr.h> namespace WebCore { diff --git a/Source/WebKit/chromium/src/PlatformSupport.cpp b/Source/WebKit/chromium/src/PlatformSupport.cpp index 9eb8b68e1..7cd6453f6 100644 --- a/Source/WebKit/chromium/src/PlatformSupport.cpp +++ b/Source/WebKit/chromium/src/PlatformSupport.cpp @@ -55,6 +55,7 @@ #include "platform/WebSerializedScriptValue.h" #include "platform/WebString.h" #include "platform/WebURL.h" +#include "platform/WebVector.h" #if OS(WINDOWS) #include "platform/WebRect.h" @@ -92,7 +93,6 @@ #include <public/WebCookie.h> #include <public/WebCookieJar.h> #include <public/WebMimeRegistry.h> -#include <public/WebVector.h> #include <wtf/Assertions.h> // We are part of the WebKit implementation. @@ -324,6 +324,137 @@ void PlatformSupport::paintProgressBar( gc->platformContext()->canvas(), barRect, valueRect, determinate, animatedSeconds); } +#elif OS(DARWIN) + +void PlatformSupport::paintScrollbarThumb( + GraphicsContext* gc, ThemePaintState state, ThemePaintSize size, const IntRect& rect, const ThemePaintScrollbarInfo& scrollbarInfo) +{ + WebThemeEngine::ScrollbarInfo webThemeScrollbarInfo; + + webThemeScrollbarInfo.orientation = static_cast<WebThemeEngine::ScrollbarOrientation>(scrollbarInfo.orientation); + webThemeScrollbarInfo.parent = static_cast<WebThemeEngine::ScrollbarParent>(scrollbarInfo.parent); + webThemeScrollbarInfo.maxValue = scrollbarInfo.maxValue; + webThemeScrollbarInfo.currentValue = scrollbarInfo.currentValue; + webThemeScrollbarInfo.visibleSize = scrollbarInfo.visibleSize; + webThemeScrollbarInfo.totalSize = scrollbarInfo.totalSize; + + WebKit::WebCanvas* webCanvas = gc->platformContext()->canvas(); + WebKit::Platform::current()->themeEngine()->paintScrollbarThumb( + webCanvas, + static_cast<WebThemeEngine::State>(state), + static_cast<WebThemeEngine::Size>(size), + rect, + webThemeScrollbarInfo); +} + +#elif OS(UNIX) + +static WebThemeEngine::Part WebThemePart(PlatformSupport::ThemePart part) +{ + switch (part) { + case PlatformSupport::PartScrollbarDownArrow: return WebThemeEngine::PartScrollbarDownArrow; + case PlatformSupport::PartScrollbarLeftArrow: return WebThemeEngine::PartScrollbarLeftArrow; + case PlatformSupport::PartScrollbarRightArrow: return WebThemeEngine::PartScrollbarRightArrow; + case PlatformSupport::PartScrollbarUpArrow: return WebThemeEngine::PartScrollbarUpArrow; + case PlatformSupport::PartScrollbarHorizontalThumb: return WebThemeEngine::PartScrollbarHorizontalThumb; + case PlatformSupport::PartScrollbarVerticalThumb: return WebThemeEngine::PartScrollbarVerticalThumb; + case PlatformSupport::PartScrollbarHorizontalTrack: return WebThemeEngine::PartScrollbarHorizontalTrack; + case PlatformSupport::PartScrollbarVerticalTrack: return WebThemeEngine::PartScrollbarVerticalTrack; + case PlatformSupport::PartCheckbox: return WebThemeEngine::PartCheckbox; + case PlatformSupport::PartRadio: return WebThemeEngine::PartRadio; + case PlatformSupport::PartButton: return WebThemeEngine::PartButton; + case PlatformSupport::PartTextField: return WebThemeEngine::PartTextField; + case PlatformSupport::PartMenuList: return WebThemeEngine::PartMenuList; + case PlatformSupport::PartSliderTrack: return WebThemeEngine::PartSliderTrack; + case PlatformSupport::PartSliderThumb: return WebThemeEngine::PartSliderThumb; + case PlatformSupport::PartInnerSpinButton: return WebThemeEngine::PartInnerSpinButton; + case PlatformSupport::PartProgressBar: return WebThemeEngine::PartProgressBar; + } + ASSERT_NOT_REACHED(); + return WebThemeEngine::PartScrollbarDownArrow; +} + +static WebThemeEngine::State WebThemeState(PlatformSupport::ThemePaintState state) +{ + switch (state) { + case PlatformSupport::StateDisabled: return WebThemeEngine::StateDisabled; + case PlatformSupport::StateHover: return WebThemeEngine::StateHover; + case PlatformSupport::StateNormal: return WebThemeEngine::StateNormal; + case PlatformSupport::StatePressed: return WebThemeEngine::StatePressed; + } + ASSERT_NOT_REACHED(); + return WebThemeEngine::StateDisabled; +} + +static void GetWebThemeExtraParams(PlatformSupport::ThemePart part, PlatformSupport::ThemePaintState state, const PlatformSupport::ThemePaintExtraParams* extraParams, WebThemeEngine::ExtraParams* webThemeExtraParams) +{ + switch (part) { + case PlatformSupport::PartScrollbarHorizontalTrack: + case PlatformSupport::PartScrollbarVerticalTrack: + webThemeExtraParams->scrollbarTrack.trackX = extraParams->scrollbarTrack.trackX; + webThemeExtraParams->scrollbarTrack.trackY = extraParams->scrollbarTrack.trackY; + webThemeExtraParams->scrollbarTrack.trackWidth = extraParams->scrollbarTrack.trackWidth; + webThemeExtraParams->scrollbarTrack.trackHeight = extraParams->scrollbarTrack.trackHeight; + break; + case PlatformSupport::PartCheckbox: + webThemeExtraParams->button.checked = extraParams->button.checked; + webThemeExtraParams->button.indeterminate = extraParams->button.indeterminate; + break; + case PlatformSupport::PartRadio: + webThemeExtraParams->button.checked = extraParams->button.checked; + break; + case PlatformSupport::PartButton: + webThemeExtraParams->button.isDefault = extraParams->button.isDefault; + webThemeExtraParams->button.hasBorder = extraParams->button.hasBorder; + webThemeExtraParams->button.backgroundColor = extraParams->button.backgroundColor; + break; + case PlatformSupport::PartTextField: + webThemeExtraParams->textField.isTextArea = extraParams->textField.isTextArea; + webThemeExtraParams->textField.isListbox = extraParams->textField.isListbox; + webThemeExtraParams->textField.backgroundColor = extraParams->textField.backgroundColor; + break; + case PlatformSupport::PartMenuList: + webThemeExtraParams->menuList.hasBorder = extraParams->menuList.hasBorder; + webThemeExtraParams->menuList.hasBorderRadius = extraParams->menuList.hasBorderRadius; + webThemeExtraParams->menuList.arrowX = extraParams->menuList.arrowX; + webThemeExtraParams->menuList.arrowY = extraParams->menuList.arrowY; + webThemeExtraParams->menuList.backgroundColor = extraParams->menuList.backgroundColor; + break; + case PlatformSupport::PartSliderTrack: + case PlatformSupport::PartSliderThumb: + webThemeExtraParams->slider.vertical = extraParams->slider.vertical; + webThemeExtraParams->slider.inDrag = extraParams->slider.inDrag; + break; + case PlatformSupport::PartInnerSpinButton: + webThemeExtraParams->innerSpin.spinUp = extraParams->innerSpin.spinUp; + webThemeExtraParams->innerSpin.readOnly = extraParams->innerSpin.readOnly; + break; + case PlatformSupport::PartProgressBar: + webThemeExtraParams->progressBar.determinate = extraParams->progressBar.determinate; + webThemeExtraParams->progressBar.valueRectX = extraParams->progressBar.valueRectX; + webThemeExtraParams->progressBar.valueRectY = extraParams->progressBar.valueRectY; + webThemeExtraParams->progressBar.valueRectWidth = extraParams->progressBar.valueRectWidth; + webThemeExtraParams->progressBar.valueRectHeight = extraParams->progressBar.valueRectHeight; + break; + default: + break; // Parts that have no extra params get here. + } +} + +IntSize PlatformSupport::getThemePartSize(ThemePart part) +{ + return WebKit::Platform::current()->themeEngine()->getSize(WebThemePart(part)); +} + +void PlatformSupport::paintThemePart( + GraphicsContext* gc, ThemePart part, ThemePaintState state, const IntRect& rect, const ThemePaintExtraParams* extraParams) +{ + WebThemeEngine::ExtraParams webThemeExtraParams; + GetWebThemeExtraParams(part, state, extraParams, &webThemeExtraParams); + WebKit::Platform::current()->themeEngine()->paint( + gc->platformContext()->canvas(), WebThemePart(part), WebThemeState(state), rect, &webThemeExtraParams); +} + #endif // These are temporary methods that the WebKit layer can use to call to the diff --git a/Source/WebKit/chromium/src/SocketStreamHandle.cpp b/Source/WebKit/chromium/src/SocketStreamHandle.cpp index 3f98a77db..5eed90011 100644 --- a/Source/WebKit/chromium/src/SocketStreamHandle.cpp +++ b/Source/WebKit/chromium/src/SocketStreamHandle.cpp @@ -37,9 +37,10 @@ #include "Logging.h" #include "NotImplemented.h" #include "SocketStreamHandleClient.h" -#include <public/Platform.h> -#include <public/WebData.h> -#include <public/WebSocketStreamHandle.h> +#include "platform/WebData.h" +#include "WebKit.h" +#include "platform/WebKitPlatformSupport.h" +#include "platform/WebSocketStreamHandle.h" #include <wtf/PassOwnPtr.h> using namespace WebKit; @@ -72,13 +73,7 @@ void SocketStreamHandleInternal::connect(const KURL& url) int SocketStreamHandleInternal::send(const char* data, int len) { LOG(Network, "send len=%d", len); - // FIXME: |m_socket| should not be null here, but it seems that there is the - // case. We should figure out such a path and fix it rather than checking - // null here. - if (!m_socket) { - LOG(Network, "m_socket is null when sending. It should not be."); - return 0; - } + ASSERT(m_socket); if (m_pendingAmountSent + len >= m_maxPendingSendAllowed) len = m_maxPendingSendAllowed - m_pendingAmountSent - 1; diff --git a/Source/WebKit/chromium/src/SocketStreamHandleInternal.h b/Source/WebKit/chromium/src/SocketStreamHandleInternal.h index 04122d8f1..857b279e7 100644 --- a/Source/WebKit/chromium/src/SocketStreamHandleInternal.h +++ b/Source/WebKit/chromium/src/SocketStreamHandleInternal.h @@ -34,8 +34,8 @@ #if ENABLE(WEB_SOCKETS) #include "SocketStreamHandle.h" -#include <public/WebSocketStreamHandleClient.h> -#include <public/WebURL.h> +#include "platform/WebSocketStreamHandleClient.h" +#include "platform/WebURL.h" #include <wtf/PassOwnPtr.h> namespace WebKit { diff --git a/Source/WebKit/chromium/src/SpeechInputClientImpl.cpp b/Source/WebKit/chromium/src/SpeechInputClientImpl.cpp index 4f09f5f3b..09176ee98 100644 --- a/Source/WebKit/chromium/src/SpeechInputClientImpl.cpp +++ b/Source/WebKit/chromium/src/SpeechInputClientImpl.cpp @@ -35,8 +35,8 @@ #include "SpeechInputListener.h" #include "WebSecurityOrigin.h" #include "WebSpeechInputController.h" +#include "platform/WebString.h" #include "WebViewClient.h" -#include <public/WebString.h> #include <wtf/PassOwnPtr.h> #include <wtf/text/WTFString.h> diff --git a/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.cpp b/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.cpp index 082747cdb..aa9b189a7 100644 --- a/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.cpp +++ b/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.cpp @@ -55,13 +55,13 @@ PassOwnPtr<SpeechRecognitionClientProxy> SpeechRecognitionClientProxy::create(We return adoptPtr(new SpeechRecognitionClientProxy(recognizer)); } -void SpeechRecognitionClientProxy::start(SpeechRecognition* recognition, const SpeechGrammarList* grammarList, const String& lang, bool continuous, bool interimResults, unsigned long maxAlternatives) +void SpeechRecognitionClientProxy::start(SpeechRecognition* recognition, const SpeechGrammarList* grammarList, const String& lang, bool continuous, unsigned long maxAlternatives) { WebVector<WebSpeechGrammar> webSpeechGrammars(static_cast<size_t>(grammarList->length())); for (unsigned long i = 0; i < grammarList->length(); ++i) webSpeechGrammars[i] = grammarList->item(i); - WebSpeechRecognitionParams params(webSpeechGrammars, lang, continuous, interimResults, maxAlternatives, WebSecurityOrigin(recognition->scriptExecutionContext()->securityOrigin())); + WebSpeechRecognitionParams params(webSpeechGrammars, lang, continuous, maxAlternatives, WebSecurityOrigin(recognition->scriptExecutionContext()->securityOrigin())); m_recognizer->start(WebSpeechRecognitionHandle(recognition), params, this); } @@ -119,6 +119,17 @@ void SpeechRecognitionClientProxy::didReceiveNoMatch(const WebSpeechRecognitionH recognition->didReceiveNoMatch(result); } +void SpeechRecognitionClientProxy::didDeleteResult(const WebSpeechRecognitionHandle& handle, unsigned resultIndex, const WebVector<WebSpeechRecognitionResult>& resultHistory) +{ + RefPtr<SpeechRecognition> recognition = PassRefPtr<SpeechRecognition>(handle); + + Vector<RefPtr<SpeechRecognitionResult> > resultHistoryVector(resultHistory.size()); + for (size_t i = 0; i < resultHistory.size(); ++i) + resultHistoryVector[i] = static_cast<PassRefPtr<SpeechRecognitionResult> >(resultHistory[i]); + + recognition->didDeleteResult(resultIndex, SpeechRecognitionResultList::create(resultHistoryVector)); +} + void SpeechRecognitionClientProxy::didReceiveError(const WebSpeechRecognitionHandle& handle, const WebString& message, WebSpeechRecognizerClient::ErrorCode code) { RefPtr<SpeechRecognition> recognition = PassRefPtr<SpeechRecognition>(handle); diff --git a/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.h b/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.h index 6194f6600..312e88b13 100644 --- a/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.h +++ b/Source/WebKit/chromium/src/SpeechRecognitionClientProxy.h @@ -46,7 +46,7 @@ public: static PassOwnPtr<SpeechRecognitionClientProxy> create(WebSpeechRecognizer*); // WebCore::SpeechRecognitionClient: - virtual void start(WebCore::SpeechRecognition*, const WebCore::SpeechGrammarList*, const String& lang, bool continuous, bool interimResults, unsigned long maxAlternatives) OVERRIDE; + virtual void start(WebCore::SpeechRecognition*, const WebCore::SpeechGrammarList*, const String& lang, bool continuous, unsigned long maxAlternatives) OVERRIDE; virtual void stop(WebCore::SpeechRecognition*) OVERRIDE; virtual void abort(WebCore::SpeechRecognition*) OVERRIDE; @@ -57,6 +57,7 @@ public: virtual void didEndAudio(const WebSpeechRecognitionHandle&) OVERRIDE; virtual void didReceiveResult(const WebSpeechRecognitionHandle&, const WebSpeechRecognitionResult&, unsigned long resultIndex, const WebVector<WebSpeechRecognitionResult>& resultHistory) OVERRIDE; virtual void didReceiveNoMatch(const WebSpeechRecognitionHandle&, const WebSpeechRecognitionResult&) OVERRIDE; + virtual void didDeleteResult(const WebSpeechRecognitionHandle&, unsigned resultIndex, const WebVector<WebSpeechRecognitionResult>& resultHistory) OVERRIDE; virtual void didReceiveError(const WebSpeechRecognitionHandle&, const WebString& message, WebSpeechRecognizerClient::ErrorCode) OVERRIDE; virtual void didStart(const WebSpeechRecognitionHandle&) OVERRIDE; virtual void didEnd(const WebSpeechRecognitionHandle&) OVERRIDE; diff --git a/Source/WebKit/chromium/src/StorageAreaProxy.cpp b/Source/WebKit/chromium/src/StorageAreaProxy.cpp index 2e33d08fb..efa0c9098 100644 --- a/Source/WebKit/chromium/src/StorageAreaProxy.cpp +++ b/Source/WebKit/chromium/src/StorageAreaProxy.cpp @@ -43,9 +43,9 @@ #include "WebFrameImpl.h" #include "WebPermissionClient.h" #include "WebStorageArea.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" #include "WebViewImpl.h" -#include <public/WebString.h> -#include <public/WebURL.h> namespace WebCore { diff --git a/Source/WebKit/chromium/src/StorageNamespaceProxy.cpp b/Source/WebKit/chromium/src/StorageNamespaceProxy.cpp index 9594eb230..6c6845497 100644 --- a/Source/WebKit/chromium/src/StorageNamespaceProxy.cpp +++ b/Source/WebKit/chromium/src/StorageNamespaceProxy.cpp @@ -32,11 +32,11 @@ #include "SecurityOrigin.h" #include "StorageAreaProxy.h" #include "WebKit.h" +#include "platform/WebKitPlatformSupport.h" #include "WebStorageNamespace.h" +#include "platform/WebString.h" #include "WebViewClient.h" #include "WebViewImpl.h" -#include "platform/WebKitPlatformSupport.h" -#include <public/WebString.h> namespace WebCore { diff --git a/Source/WebKit/chromium/src/TextFieldDecoratorImpl.cpp b/Source/WebKit/chromium/src/TextFieldDecoratorImpl.cpp index 44bac4038..a74aa825a 100644 --- a/Source/WebKit/chromium/src/TextFieldDecoratorImpl.cpp +++ b/Source/WebKit/chromium/src/TextFieldDecoratorImpl.cpp @@ -103,7 +103,7 @@ CachedImage* TextFieldDecoratorImpl::imageForReadonlyState() if (!m_cachedImageForReadonlyState) { WebCString imageName = m_client->imageNameForReadOnlyState(); if (imageName.isEmpty()) - m_cachedImageForReadonlyState = imageForDisabledState(); + m_cachedImageForDisabledState = imageForDisabledState(); else { RefPtr<Image> image = Image::loadPlatformResource(imageName.data()); m_cachedImageForReadonlyState = new CachedImage(image.get()); @@ -112,20 +112,6 @@ CachedImage* TextFieldDecoratorImpl::imageForReadonlyState() return m_cachedImageForReadonlyState.get(); } -CachedImage* TextFieldDecoratorImpl::imageForHoverState() -{ - if (!m_cachedImageForHoverState) { - WebCString imageName = m_client->imageNameForHoverState(); - if (imageName.isEmpty()) - m_cachedImageForHoverState = imageForNormalState(); - else { - RefPtr<Image> image = Image::loadPlatformResource(imageName.data()); - m_cachedImageForHoverState = new CachedImage(image.get()); - } - } - return m_cachedImageForHoverState.get(); -} - void TextFieldDecoratorImpl::handleClick(HTMLInputElement* input) { ASSERT(input); diff --git a/Source/WebKit/chromium/src/TextFieldDecoratorImpl.h b/Source/WebKit/chromium/src/TextFieldDecoratorImpl.h index 92ab0dfb3..8f52069ba 100644 --- a/Source/WebKit/chromium/src/TextFieldDecoratorImpl.h +++ b/Source/WebKit/chromium/src/TextFieldDecoratorImpl.h @@ -51,7 +51,6 @@ private: virtual WebCore::CachedImage* imageForNormalState() OVERRIDE; virtual WebCore::CachedImage* imageForDisabledState() OVERRIDE; virtual WebCore::CachedImage* imageForReadonlyState() OVERRIDE; - virtual WebCore::CachedImage* imageForHoverState() OVERRIDE; virtual void handleClick(WebCore::HTMLInputElement*) OVERRIDE; virtual void willDetach(WebCore::HTMLInputElement*) OVERRIDE; @@ -61,7 +60,6 @@ private: WebCore::CachedResourceHandle<WebCore::CachedImage> m_cachedImageForNormalState; WebCore::CachedResourceHandle<WebCore::CachedImage> m_cachedImageForDisabledState; WebCore::CachedResourceHandle<WebCore::CachedImage> m_cachedImageForReadonlyState; - WebCore::CachedResourceHandle<WebCore::CachedImage> m_cachedImageForHoverState; }; } diff --git a/Source/WebKit/chromium/src/UserMediaClientImpl.cpp b/Source/WebKit/chromium/src/UserMediaClientImpl.cpp index cf4704cb8..ca8a98dcb 100644 --- a/Source/WebKit/chromium/src/UserMediaClientImpl.cpp +++ b/Source/WebKit/chromium/src/UserMediaClientImpl.cpp @@ -37,7 +37,7 @@ #include "WebUserMediaRequest.h" #include "WebViewClient.h" #include "WebViewImpl.h" -#include <public/WebMediaStreamSource.h> +#include "platform/WebMediaStreamSource.h" #include <wtf/RefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebAccessibilityObject.cpp b/Source/WebKit/chromium/src/WebAccessibilityObject.cpp index ebc1dbbbe..a3dd824cc 100644 --- a/Source/WebKit/chromium/src/WebAccessibilityObject.cpp +++ b/Source/WebKit/chromium/src/WebAccessibilityObject.cpp @@ -46,10 +46,10 @@ #include "UserGestureIndicator.h" #include "WebDocument.h" #include "WebNode.h" -#include <public/WebPoint.h> -#include <public/WebRect.h> -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebPoint.h" +#include "platform/WebRect.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" #include <wtf/text/StringBuilder.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebAnimationControllerImpl.cpp b/Source/WebKit/chromium/src/WebAnimationControllerImpl.cpp index 830d3beda..8af40102e 100644 --- a/Source/WebKit/chromium/src/WebAnimationControllerImpl.cpp +++ b/Source/WebKit/chromium/src/WebAnimationControllerImpl.cpp @@ -36,7 +36,7 @@ #include "WebElement.h" #include "WebFrameImpl.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebCommon.cpp b/Source/WebKit/chromium/src/WebCommon.cpp index 5e039594e..cd9795ae3 100644 --- a/Source/WebKit/chromium/src/WebCommon.cpp +++ b/Source/WebKit/chromium/src/WebCommon.cpp @@ -29,7 +29,7 @@ */ #include "config.h" -#include <public/WebCommon.h> +#include "platform/WebCommon.h" #include <wtf/Assertions.h> diff --git a/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h b/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h index 5cba416d2..8632ec4f2 100644 --- a/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h +++ b/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h @@ -31,7 +31,8 @@ #ifndef WebDOMEventListenerPrivate_h #define WebDOMEventListenerPrivate_h -#include <public/WebString.h> +#include "platform/WebString.h" + #include <wtf/Vector.h> namespace WebCore { diff --git a/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp b/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp index ad47a0ed1..383c7de21 100644 --- a/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp +++ b/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp @@ -40,7 +40,7 @@ #include "WebFrame.h" #include "WebFrameImpl.h" #include "platform/WebSerializedScriptValue.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebDOMStringList.cpp b/Source/WebKit/chromium/src/WebDOMStringList.cpp index 5f5a81556..dd106461e 100644 --- a/Source/WebKit/chromium/src/WebDOMStringList.cpp +++ b/Source/WebKit/chromium/src/WebDOMStringList.cpp @@ -32,7 +32,7 @@ #include "WebDOMStringList.h" #include "DOMStringList.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebDataSourceImpl.cpp b/Source/WebKit/chromium/src/WebDataSourceImpl.cpp index cc94b62ec..501fd447c 100644 --- a/Source/WebKit/chromium/src/WebDataSourceImpl.cpp +++ b/Source/WebKit/chromium/src/WebDataSourceImpl.cpp @@ -32,9 +32,9 @@ #include "WebDataSourceImpl.h" #include "ApplicationCacheHostInternal.h" -#include <public/WebURL.h> -#include <public/WebURLError.h> -#include <public/WebVector.h> +#include "platform/WebURL.h" +#include "platform/WebURLError.h" +#include "platform/WebVector.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebDatabase.cpp b/Source/WebKit/chromium/src/WebDatabase.cpp index 04d4a4079..d8eb64da4 100644 --- a/Source/WebKit/chromium/src/WebDatabase.cpp +++ b/Source/WebKit/chromium/src/WebDatabase.cpp @@ -36,7 +36,7 @@ #include "QuotaTracker.h" #include "SecurityOrigin.h" #include "WebDatabaseObserver.h" -#include <public/WebString.h> +#include "platform/WebString.h" #include <wtf/PassRefPtr.h> #include <wtf/RefPtr.h> diff --git a/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp b/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp index 7f362036b..a0a75b48c 100644 --- a/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp +++ b/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp @@ -54,14 +54,14 @@ #include "WebDataSource.h" #include "WebDevToolsAgentClient.h" #include "WebFrameImpl.h" +#include "platform/WebRect.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" +#include "platform/WebURLError.h" +#include "platform/WebURLRequest.h" +#include "platform/WebURLResponse.h" #include "WebViewClient.h" #include "WebViewImpl.h" -#include <public/WebRect.h> -#include <public/WebString.h> -#include <public/WebURL.h> -#include <public/WebURLError.h> -#include <public/WebURLRequest.h> -#include <public/WebURLResponse.h> #include <wtf/CurrentTime.h> #include <wtf/MathExtras.h> #include <wtf/Noncopyable.h> @@ -72,6 +72,8 @@ using namespace WebCore; using namespace std; namespace OverlayZOrders { +static const int viewportGutter = 97; + // Use 99 as a big z-order number so that highlight is above other overlays. static const int highlight = 99; } @@ -181,18 +183,20 @@ private: OwnPtr<WebDevToolsAgent::MessageDescriptor> m_descriptor; }; -class DeviceMetricsSupport { +class DeviceMetricsSupport : public WebPageOverlay { public: DeviceMetricsSupport(WebViewImpl* webView) : m_webView(webView) , m_fitWindow(false) , m_originalZoomFactor(0) { + m_webView->addPageOverlay(this, OverlayZOrders::viewportGutter); } ~DeviceMetricsSupport() { restore(); + m_webView->removePageOverlay(this); } void setDeviceMetrics(int width, int height, float textZoomFactor, bool fitWindow) @@ -281,7 +285,7 @@ private: view->setHorizontalScrollbarLock(false); view->setVerticalScrollbarLock(false); view->setScrollbarModes(ScrollbarAuto, ScrollbarAuto, false, false); - view->setFrameRect(IntRect(IntPoint(), IntSize(m_webView->size()))); + view->resize(IntSize(m_webView->size())); m_webView->sendResizeEventAndRepaint(); } @@ -337,6 +341,19 @@ private: doc->updateLayout(); } + virtual void paintPageOverlay(WebCanvas* canvas) + { + FrameView* frameView = this->frameView(); + if (!frameView) + return; + + GraphicsContextBuilder builder(canvas); + GraphicsContext& gc = builder.context(); + gc.clipOut(IntRect(IntPoint(), frameView->size())); + gc.setFillColor(Color::darkGray, ColorSpaceDeviceRGB); + gc.drawRect(IntRect(IntPoint(), m_webView->size())); + } + WebCore::FrameView* frameView() { return m_webView->mainFrameImpl() ? m_webView->mainFrameImpl()->frameView() : 0; @@ -372,7 +389,6 @@ void WebDevToolsAgentImpl::attach() ClientMessageLoopAdapter::ensureClientMessageLoopCreated(m_client); inspectorController()->connectFrontend(this); - inspectorController()->webViewResized(m_webViewImpl->size()); m_attached = true; } @@ -421,12 +437,10 @@ bool WebDevToolsAgentImpl::metricsOverridden() return !!m_metricsSupport; } -void WebDevToolsAgentImpl::webViewResized(const WebSize& size) +void WebDevToolsAgentImpl::webViewResized() { if (m_metricsSupport) m_metricsSupport->webViewResized(); - if (InspectorController* ic = inspectorController()) - ic->webViewResized(m_metricsSupport ? IntSize(size.width, size.height) : IntSize()); } void WebDevToolsAgentImpl::overrideDeviceMetrics(int width, int height, float fontScaleFactor, bool fitWindow) @@ -434,19 +448,12 @@ void WebDevToolsAgentImpl::overrideDeviceMetrics(int width, int height, float fo if (!width && !height) { if (m_metricsSupport) m_metricsSupport.clear(); - if (InspectorController* ic = inspectorController()) - ic->webViewResized(IntSize()); return; } if (!m_metricsSupport) m_metricsSupport = adoptPtr(new DeviceMetricsSupport(m_webViewImpl)); - m_metricsSupport->setDeviceMetrics(width, height, fontScaleFactor, fitWindow); - if (InspectorController* ic = inspectorController()) { - WebSize size = m_webViewImpl->size(); - ic->webViewResized(IntSize(size.width, size.height)); - } } void WebDevToolsAgentImpl::autoZoomPageToFitWidth() @@ -455,82 +462,6 @@ void WebDevToolsAgentImpl::autoZoomPageToFitWidth() m_metricsSupport->autoZoomPageToFitWidthOnNavigation(m_webViewImpl->mainFrameImpl()->frame()); } -void WebDevToolsAgentImpl::getAllocatedObjects(HashSet<const void*>& set) -{ - class CountingVisitor : public WebDevToolsAgentClient::AllocatedObjectVisitor { - public: - CountingVisitor() : m_totalObjectsCount(0) - { - } - virtual bool visitObject(const void* ptr) - { - ++m_totalObjectsCount; - return true; - } - size_t totalObjectsCount() - { - return m_totalObjectsCount; - } - - private: - size_t m_totalObjectsCount; - }; - - CountingVisitor counter; - m_client->visitAllocatedObjects(&counter); - - class PointerCollector : public WebDevToolsAgentClient::AllocatedObjectVisitor { - public: - explicit PointerCollector(size_t maxObjectsCount) - : m_maxObjectsCount(maxObjectsCount) - , m_index(0) - , m_success(true) - , m_pointers(new const void*[maxObjectsCount]) - { - } - ~PointerCollector() - { - delete[] m_pointers; - } - virtual bool visitObject(const void* ptr) - { - if (m_index == m_maxObjectsCount) { - m_success = false; - return false; - } - m_pointers[m_index++] = ptr; - return true; - } - - bool success() const { return m_success; } - - void copyTo(HashSet<const void*>& set) - { - for (size_t i = 0; i < m_index; i++) - set.add(m_pointers[i]); - } - - private: - const size_t m_maxObjectsCount; - size_t m_index; - bool m_success; - const void** m_pointers; - }; - - // Double size to allow room for all objects that may have been allocated - // since we counted them. - size_t estimatedMaxObjectsCount = counter.totalObjectsCount() * 2; - while (true) { - PointerCollector collector(estimatedMaxObjectsCount); - m_client->visitAllocatedObjects(&collector); - if (collector.success()) { - collector.copyTo(set); - break; - } - estimatedMaxObjectsCount *= 2; - } -} - void WebDevToolsAgentImpl::dispatchOnInspectorBackend(const WebString& message) { inspectorController()->dispatchMessageFromFrontend(message); diff --git a/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h b/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h index 6a9663127..f1af576cb 100644 --- a/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h +++ b/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h @@ -36,7 +36,8 @@ #include "WebDevToolsAgentPrivate.h" #include "WebPageOverlay.h" -#include <public/WebSize.h> +#include "platform/WebSize.h" + #include <wtf/Forward.h> #include <wtf/OwnPtr.h> @@ -75,7 +76,7 @@ public: virtual void didCreateScriptContext(WebFrameImpl*, int worldId); virtual void mainFrameViewCreated(WebFrameImpl*); virtual bool metricsOverridden(); - virtual void webViewResized(const WebSize&); + virtual void webViewResized(); // WebDevToolsAgent implementation. virtual void attach(); @@ -105,8 +106,6 @@ public: virtual void overrideDeviceMetrics(int width, int height, float fontScaleFactor, bool fitWindow); virtual void autoZoomPageToFitWidth(); - virtual void getAllocatedObjects(HashSet<const void*>&); - int hostId() { return m_hostId; } // WebPageOverlay diff --git a/Source/WebKit/chromium/src/WebDevToolsAgentPrivate.h b/Source/WebKit/chromium/src/WebDevToolsAgentPrivate.h index c1a1d93ae..06f5f1815 100644 --- a/Source/WebKit/chromium/src/WebDevToolsAgentPrivate.h +++ b/Source/WebKit/chromium/src/WebDevToolsAgentPrivate.h @@ -54,7 +54,7 @@ public: virtual bool metricsOverridden() = 0; // WebViewImpl has been resized. - virtual void webViewResized(const WebSize&) = 0; + virtual void webViewResized() = 0; }; } // namespace WebKit diff --git a/Source/WebKit/chromium/src/WebDocument.cpp b/Source/WebKit/chromium/src/WebDocument.cpp index 0593d1d20..3486613be 100644 --- a/Source/WebKit/chromium/src/WebDocument.cpp +++ b/Source/WebKit/chromium/src/WebDocument.cpp @@ -56,7 +56,8 @@ #include "WebFrameImpl.h" #include "WebNodeCollection.h" #include "WebNodeList.h" -#include <public/WebURL.h> +#include "platform/WebURL.h" + #include <wtf/PassRefPtr.h> using namespace WebCore; @@ -80,11 +81,6 @@ WebString WebDocument::encoding() const return constUnwrap<Document>()->encoding(); } -WebString WebDocument::contentLanguage() const -{ - return constUnwrap<Document>()->contentLanguage(); -} - WebURL WebDocument::openSearchDescriptionURL() const { return const_cast<Document*>(constUnwrap<Document>())->openSearchDescriptionURL(); @@ -262,13 +258,14 @@ WebVector<WebDraggableRegion> WebDocument::draggableRegions() const WebVector<WebDraggableRegion> draggableRegions; #if ENABLE(WIDGET_REGION) const Document* document = constUnwrap<Document>(); - if (document->hasAnnotatedRegions()) { - const Vector<AnnotatedRegionValue>& regions = document->annotatedRegions(); + if (document->hasDashboardRegions()) { + const Vector<DashboardRegionValue>& regions = document->dashboardRegions(); draggableRegions = WebVector<WebDraggableRegion>(regions.size()); for (size_t i = 0; i < regions.size(); i++) { - const AnnotatedRegionValue& value = regions[i]; - draggableRegions[i].draggable = value.draggable; + const DashboardRegionValue& value = regions[i]; + draggableRegions[i].label = value.label; draggableRegions[i].bounds = WebCore::IntRect(value.bounds); + draggableRegions[i].clip = WebCore::IntRect(value.clip); } } #endif diff --git a/Source/WebKit/chromium/src/WebDocumentType.cpp b/Source/WebKit/chromium/src/WebDocumentType.cpp index 4a4ed3642..32570233f 100644 --- a/Source/WebKit/chromium/src/WebDocumentType.cpp +++ b/Source/WebKit/chromium/src/WebDocumentType.cpp @@ -32,7 +32,8 @@ #include "WebDocumentType.h" #include "DocumentType.h" -#include <public/WebString.h> +#include "platform/WebString.h" + #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebDragData.cpp b/Source/WebKit/chromium/src/WebDragData.cpp index 33dd72e92..bcb0ad38a 100644 --- a/Source/WebKit/chromium/src/WebDragData.cpp +++ b/Source/WebKit/chromium/src/WebDragData.cpp @@ -34,11 +34,12 @@ #include "ClipboardMimeTypes.h" #include "DataTransferItem.h" #include "DraggedIsolatedFileSystem.h" -#include <public/WebData.h> +#include "platform/WebData.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" +#include "platform/WebVector.h" + #include <public/WebDragData.h> -#include <public/WebString.h> -#include <public/WebURL.h> -#include <public/WebVector.h> #include <wtf/HashMap.h> #include <wtf/PassRefPtr.h> diff --git a/Source/WebKit/chromium/src/WebElement.cpp b/Source/WebKit/chromium/src/WebElement.cpp index 49fff0a07..1cef30d60 100644 --- a/Source/WebKit/chromium/src/WebElement.cpp +++ b/Source/WebKit/chromium/src/WebElement.cpp @@ -29,13 +29,14 @@ */ #include "config.h" +#include "platform/WebRect.h" #include "WebElement.h" #include "WebDocument.h" + #include "Element.h" #include "NamedNodeMap.h" #include "RenderBoxModelObject.h" #include "RenderObject.h" -#include <public/WebRect.h> #include <wtf/PassRefPtr.h> @@ -64,12 +65,6 @@ bool WebElement::hasTagName(const WebString& tagName) const tagName.operator String()); } -bool WebElement::hasHTMLTagName(const WebString& tagName) const -{ - const Element* element = constUnwrap<Element>(); - return HTMLNames::xhtmlNamespaceURI == element->namespaceURI() && equalIgnoringCase(element->tagName(), String(tagName)); -} - bool WebElement::hasAttribute(const WebString& attrName) const { return constUnwrap<Element>()->hasAttribute(attrName); diff --git a/Source/WebKit/chromium/src/WebEntities.cpp b/Source/WebKit/chromium/src/WebEntities.cpp index 9208e5c6b..1175f1bb1 100644 --- a/Source/WebKit/chromium/src/WebEntities.cpp +++ b/Source/WebKit/chromium/src/WebEntities.cpp @@ -31,7 +31,8 @@ #include "config.h" #include "WebEntities.h" -#include <public/WebString.h> +#include "platform/WebString.h" + #include <string.h> #include <wtf/HashMap.h> #include <wtf/text/StringBuilder.h> diff --git a/Source/WebKit/chromium/src/WebFileChooserCompletionImpl.h b/Source/WebKit/chromium/src/WebFileChooserCompletionImpl.h index 2360c97f8..3ac63a5e8 100644 --- a/Source/WebKit/chromium/src/WebFileChooserCompletionImpl.h +++ b/Source/WebKit/chromium/src/WebFileChooserCompletionImpl.h @@ -31,10 +31,11 @@ #ifndef WebFileChooserCompletionImpl_h #define WebFileChooserCompletionImpl_h -#include "FileChooser.h" #include "WebFileChooserCompletion.h" -#include <public/WebString.h> -#include <public/WebVector.h> +#include "platform/WebString.h" +#include "platform/WebVector.h" + +#include "FileChooser.h" #include <wtf/PassRefPtr.h> using WebKit::WebFileChooserCompletion; diff --git a/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp b/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp index 25fc9b282..06809e54b 100644 --- a/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp +++ b/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp @@ -38,9 +38,9 @@ #include "ScriptExecutionContext.h" #include "WebFileInfo.h" #include "WebFileSystemEntry.h" +#include "platform/WebString.h" #include "WorkerAsyncFileSystemChromium.h" #include <public/WebFileSystem.h> -#include <public/WebString.h> #include <wtf/Vector.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.h b/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.h index 7ce8b2805..e5f04081f 100644 --- a/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.h +++ b/Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.h @@ -33,8 +33,8 @@ #include "FileSystemType.h" #include "WebFileSystemCallbacks.h" +#include "platform/WebVector.h" #include <public/WebFileSystem.h> -#include <public/WebVector.h> #include <wtf/OwnPtr.h> #include <wtf/PassOwnPtr.h> diff --git a/Source/WebKit/chromium/src/WebFontImpl.cpp b/Source/WebKit/chromium/src/WebFontImpl.cpp index c4f5ac1ab..cdb83c214 100644 --- a/Source/WebKit/chromium/src/WebFontImpl.cpp +++ b/Source/WebKit/chromium/src/WebFontImpl.cpp @@ -37,11 +37,12 @@ #include "GraphicsContext.h" #include "painting/GraphicsContextBuilder.h" #include "TextRun.h" +#include "platform/WebFloatPoint.h" +#include "platform/WebFloatRect.h" #include "WebFontDescription.h" +#include "platform/WebRect.h" #include "WebTextRun.h" -#include <public/WebFloatPoint.h> -#include <public/WebFloatRect.h> -#include <public/WebRect.h> + #include <skia/ext/platform_canvas.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebFormElement.cpp b/Source/WebKit/chromium/src/WebFormElement.cpp index cdae6620e..6400f4d96 100644 --- a/Source/WebKit/chromium/src/WebFormElement.cpp +++ b/Source/WebKit/chromium/src/WebFormElement.cpp @@ -38,8 +38,8 @@ #include "HTMLNames.h" #include "WebFormControlElement.h" #include "WebInputElement.h" -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebString.h" +#include "platform/WebURL.h" #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebFrameImpl.cpp b/Source/WebKit/chromium/src/WebFrameImpl.cpp index ec687147b..6d68a6f23 100644 --- a/Source/WebKit/chromium/src/WebFrameImpl.cpp +++ b/Source/WebKit/chromium/src/WebFrameImpl.cpp @@ -72,19 +72,15 @@ #include "WebFrameImpl.h" #include "AssociatedURLLoader.h" -#include "AsyncFileSystem.h" -#include "AsyncFileSystemChromium.h" #include "BackForwardController.h" #include "Chrome.h" #include "ClipboardUtilitiesChromium.h" #include "Console.h" -#include "DOMFileSystem.h" #include "DOMUtilitiesPrivate.h" #include "DOMWindow.h" #include "DOMWindowIntents.h" #include "DeliveredIntent.h" #include "DeliveredIntentClientImpl.h" -#include "DirectoryEntry.h" #include "Document.h" #include "DocumentLoader.h" #include "DocumentMarker.h" @@ -92,7 +88,6 @@ #include "Editor.h" #include "EventHandler.h" #include "EventListenerWrapper.h" -#include "FileEntry.h" #include "FileSystemType.h" #include "FindInPageCoordinates.h" #include "FocusController.h" @@ -121,6 +116,7 @@ #include "PageOverlay.h" #include "Performance.h" #include "PlatformMessagePortChannel.h" +#include "PlatformSupport.h" #include "PluginDocument.h" #include "PrintContext.h" #include "RenderBox.h" @@ -149,10 +145,6 @@ #include "TextAffinity.h" #include "TextIterator.h" #include "UserGestureIndicator.h" -#include "V8DOMFileSystem.h" -#include "V8DirectoryEntry.h" -#include "V8FileEntry.h" -#include "V8GCController.h" #include "WebAnimationControllerImpl.h" #include "WebConsoleMessage.h" #include "WebDOMEvent.h" @@ -181,20 +173,33 @@ #include "htmlediting.h" #include "markup.h" #include "painting/GraphicsContextBuilder.h" +#include "platform/WebFloatPoint.h" +#include "platform/WebFloatRect.h" +#include "platform/WebPoint.h" +#include "platform/WebRect.h" #include "platform/WebSerializedScriptValue.h" +#include "platform/WebSize.h" +#include "platform/WebURLError.h" +#include "platform/WebVector.h" + #include <algorithm> #include <public/Platform.h> -#include <public/WebFileSystem.h> -#include <public/WebFloatPoint.h> -#include <public/WebFloatRect.h> -#include <public/WebPoint.h> -#include <public/WebRect.h> -#include <public/WebSize.h> -#include <public/WebURLError.h> -#include <public/WebVector.h> #include <wtf/CurrentTime.h> #include <wtf/HashMap.h> +#if USE(V8) +#include "AsyncFileSystem.h" +#include "AsyncFileSystemChromium.h" +#include "DirectoryEntry.h" +#include "DOMFileSystem.h" +#include "FileEntry.h" +#include "V8DirectoryEntry.h" +#include "V8DOMFileSystem.h" +#include "V8FileEntry.h" +#include "V8GCController.h" +#include <public/WebFileSystem.h> +#endif + using namespace WebCore; namespace WebKit { @@ -209,12 +214,11 @@ static const char* const webFrameActiveCount = "WebFrameActiveCount"; // the text of each frame in turn to the |output| up to |maxChars| length. // // The |frame| must be non-null. -// -// FIXME: We should use StringBuilder rather than Vector<UChar>. -static void frameContentAsPlainText(size_t maxChars, Frame* frame, Vector<UChar>* output) +static void frameContentAsPlainText(size_t maxChars, Frame* frame, + Vector<UChar>* output) { - Document* document = frame->document(); - if (!document) + Document* doc = frame->document(); + if (!doc) return; if (!frame->view()) @@ -226,9 +230,9 @@ static void frameContentAsPlainText(size_t maxChars, Frame* frame, Vector<UChar> frame->view()->layout(); // Select the document body. - RefPtr<Range> range(document->createRange()); + RefPtr<Range> range(doc->createRange()); ExceptionCode exception = 0; - range->selectNodeContents(document->body(), exception); + range->selectNodeContents(doc->body(), exception); if (!exception) { // The text iterator will walk nodes giving us text. This is similar to @@ -360,33 +364,34 @@ public: return m_printedPageWidth / pageRect.width(); } - // Spools the printed page, a subrect of frame(). Skip the scale step. + // Spools the printed page, a subrect of m_frame. Skip the scale step. // NativeTheme doesn't play well with scaling. Scaling is done browser side // instead. Returns the scale to be applied. // On Linux, we don't have the problem with NativeTheme, hence we let WebKit // do the scaling and ignore the return value. - virtual float spoolPage(GraphicsContext& context, int pageNumber) + virtual float spoolPage(GraphicsContext& ctx, int pageNumber) { IntRect pageRect = m_pageRects[pageNumber]; float scale = m_printedPageWidth / pageRect.width(); - context.save(); + ctx.save(); #if OS(UNIX) && !OS(DARWIN) - context.scale(WebCore::FloatSize(scale, scale)); + ctx.scale(WebCore::FloatSize(scale, scale)); #endif - context.translate(static_cast<float>(-pageRect.x()), static_cast<float>(-pageRect.y())); - context.clip(pageRect); - frame()->view()->paintContents(&context, pageRect); - context.restore(); + ctx.translate(static_cast<float>(-pageRect.x()), + static_cast<float>(-pageRect.y())); + ctx.clip(pageRect); + m_frame->view()->paintContents(&ctx, pageRect); + ctx.restore(); return scale; } void spoolAllPagesWithBoundaries(GraphicsContext& graphicsContext, const FloatSize& pageSizeInPixels) { - if (!frame()->document() || !frame()->view() || !frame()->document()->renderer()) + if (!m_frame->document() || !m_frame->view() || !m_frame->document()->renderer()) return; - frame()->document()->updateLayout(); + m_frame->document()->updateLayout(); float pageHeight; computePageRects(FloatRect(FloatPoint(0, 0), pageSizeInPixels), 0, 0, 1, pageHeight); @@ -408,7 +413,8 @@ public: graphicsContext.save(); graphicsContext.setStrokeColor(Color(0, 0, 255), ColorSpaceDeviceRGB); graphicsContext.setFillColor(Color(0, 0, 255), ColorSpaceDeviceRGB); - graphicsContext.drawLine(IntPoint(0, currentHeight), IntPoint(pageWidth, currentHeight)); + graphicsContext.drawLine(IntPoint(0, currentHeight), + IntPoint(pageWidth, currentHeight)); graphicsContext.restore(); } @@ -488,12 +494,12 @@ public: return m_pageCount; } - // Spools the printed page, a subrect of frame(). Skip the scale step. + // Spools the printed page, a subrect of m_frame. Skip the scale step. // NativeTheme doesn't play well with scaling. Scaling is done browser side - // instead. Returns the scale to be applied. - virtual float spoolPage(GraphicsContext& context, int pageNumber) + // instead. Returns the scale to be applied. + virtual float spoolPage(GraphicsContext& ctx, int pageNumber) { - m_plugin->printPage(pageNumber, &context); + m_plugin->printPage(pageNumber, &ctx); return 1.0; } @@ -521,9 +527,15 @@ WebFrameImpl::FindMatch::FindMatch(PassRefPtr<Range> range, int ordinal) { } +// WebFrame ------------------------------------------------------------------- + class WebFrameImpl::DeferredScopeStringMatches { public: - DeferredScopeStringMatches(WebFrameImpl* webFrame, int identifier, const WebString& searchText, const WebFindOptions& options, bool reset) + DeferredScopeStringMatches(WebFrameImpl* webFrame, + int identifier, + const WebString& searchText, + const WebFindOptions& options, + bool reset) : m_timer(this, &DeferredScopeStringMatches::doTimeout) , m_webFrame(webFrame) , m_identifier(identifier) @@ -537,7 +549,8 @@ public: private: void doTimeout(Timer<DeferredScopeStringMatches>*) { - m_webFrame->callScopeStringMatches(this, m_identifier, m_searchText, m_options, m_reset); + m_webFrame->callScopeStringMatches( + this, m_identifier, m_searchText, m_options, m_reset); } Timer<DeferredScopeStringMatches> m_timer; @@ -548,6 +561,7 @@ private: bool m_reset; }; + // WebFrame ------------------------------------------------------------------- int WebFrame::instanceCount() @@ -555,6 +569,14 @@ int WebFrame::instanceCount() return frameCount; } +WebFrame* WebFrame::frameForEnteredContext() +{ + v8::Handle<v8::Context> context = v8::Context::GetEntered(); + if (context.IsEmpty()) + return 0; + return frameForContext(context); +} + WebFrame* WebFrame::frameForCurrentContext() { v8::Handle<v8::Context> context = v8::Context::GetCurrent(); @@ -572,22 +594,28 @@ WebFrame* WebFrame::frameForContext(v8::Handle<v8::Context> context) WebFrame* WebFrame::fromFrameOwnerElement(const WebElement& element) { - return WebFrameImpl::fromFrameOwnerElement(PassRefPtr<Element>(element).get()); + return WebFrameImpl::fromFrameOwnerElement( + PassRefPtr<Element>(element).get()); +} + +WebString WebFrameImpl::name() const +{ + return m_frame->tree()->uniqueName(); } WebString WebFrameImpl::uniqueName() const { - return frame()->tree()->uniqueName(); + return m_frame->tree()->uniqueName(); } WebString WebFrameImpl::assignedName() const { - return frame()->tree()->name(); + return m_frame->tree()->name(); } void WebFrameImpl::setName(const WebString& name) { - frame()->tree()->setName(name); + m_frame->tree()->setName(name); } long long WebFrameImpl::identifier() const @@ -597,35 +625,39 @@ long long WebFrameImpl::identifier() const WebVector<WebIconURL> WebFrameImpl::iconURLs(int iconTypes) const { + FrameLoader* frameLoader = m_frame->loader(); // The URL to the icon may be in the header. As such, only // ask the loader for the icon if it's finished loading. - if (frame()->loader()->state() == FrameStateComplete) - return frame()->loader()->icon()->urlsForTypes(iconTypes); + if (frameLoader->state() == FrameStateComplete) + return frameLoader->icon()->urlsForTypes(iconTypes); return WebVector<WebIconURL>(); } WebSize WebFrameImpl::scrollOffset() const { FrameView* view = frameView(); - if (!view) - return WebSize(); - return view->scrollOffset(); + if (view) + return view->scrollOffset(); + + return WebSize(); } WebSize WebFrameImpl::minimumScrollOffset() const { FrameView* view = frameView(); - if (!view) - return WebSize(); - return view->minimumScrollPosition() - IntPoint(); + if (view) + return view->minimumScrollPosition() - IntPoint(); + + return WebSize(); } WebSize WebFrameImpl::maximumScrollOffset() const { FrameView* view = frameView(); - if (!view) - return WebSize(); - return view->maximumScrollPosition() - IntPoint(); + if (view) + return view->maximumScrollPosition() - IntPoint(); + + return WebSize(); } void WebFrameImpl::setScrollOffset(const WebSize& offset) @@ -641,17 +673,18 @@ WebSize WebFrameImpl::contentsSize() const int WebFrameImpl::contentsPreferredWidth() const { - if (frame()->document() && frame()->document()->renderView()) { + if (m_frame->document() && m_frame->document()->renderView()) { FontCachePurgePreventer fontCachePurgePreventer; - return frame()->document()->renderView()->minPreferredLogicalWidth(); + + return m_frame->document()->renderView()->minPreferredLogicalWidth(); } return 0; } int WebFrameImpl::documentElementScrollHeight() const { - if (frame()->document() && frame()->document()->documentElement()) - return frame()->document()->documentElement()->scrollHeight(); + if (m_frame->document() && m_frame->document()->documentElement()) + return m_frame->document()->documentElement()->scrollHeight(); return 0; } @@ -662,12 +695,12 @@ bool WebFrameImpl::hasVisibleContent() const bool WebFrameImpl::hasHorizontalScrollbar() const { - return frame() && frame()->view() && frame()->view()->horizontalScrollbar(); + return m_frame && m_frame->view() && m_frame->view()->horizontalScrollbar(); } bool WebFrameImpl::hasVerticalScrollbar() const { - return frame() && frame()->view() && frame()->view()->verticalScrollbar(); + return m_frame && m_frame->view() && m_frame->view()->verticalScrollbar(); } WebView* WebFrameImpl::view() const @@ -677,76 +710,66 @@ WebView* WebFrameImpl::view() const WebFrame* WebFrameImpl::opener() const { - if (!frame()) - return 0; - return fromFrame(frame()->loader()->opener()); + Frame* opener = 0; + if (m_frame) + opener = m_frame->loader()->opener(); + return fromFrame(opener); } -void WebFrameImpl::setOpener(const WebFrame* webFrame) +void WebFrameImpl::setOpener(const WebFrame* frame) { - frame()->loader()->setOpener(webFrame ? static_cast<const WebFrameImpl*>(webFrame)->frame() : 0); + m_frame->loader()->setOpener(frame ? + static_cast<const WebFrameImpl*>(frame)->m_frame : 0); } WebFrame* WebFrameImpl::parent() const { - if (!frame()) - return 0; - return fromFrame(frame()->tree()->parent()); + Frame* parent = 0; + if (m_frame) + parent = m_frame->tree()->parent(); + return fromFrame(parent); } WebFrame* WebFrameImpl::top() const { - if (!frame()) - return 0; - return fromFrame(frame()->tree()->top()); + if (m_frame) + return fromFrame(m_frame->tree()->top()); + + return 0; } WebFrame* WebFrameImpl::firstChild() const { - if (!frame()) - return 0; return fromFrame(frame()->tree()->firstChild()); } WebFrame* WebFrameImpl::lastChild() const { - if (!frame()) - return 0; return fromFrame(frame()->tree()->lastChild()); } WebFrame* WebFrameImpl::nextSibling() const { - if (!frame()) - return 0; return fromFrame(frame()->tree()->nextSibling()); } WebFrame* WebFrameImpl::previousSibling() const { - if (!frame()) - return 0; return fromFrame(frame()->tree()->previousSibling()); } WebFrame* WebFrameImpl::traverseNext(bool wrap) const { - if (!frame()) - return 0; return fromFrame(frame()->tree()->traverseNextWithWrap(wrap)); } WebFrame* WebFrameImpl::traversePrevious(bool wrap) const { - if (!frame()) - return 0; return fromFrame(frame()->tree()->traversePreviousWithWrap(wrap)); } WebFrame* WebFrameImpl::findChildByName(const WebString& name) const { - if (!frame()) - return 0; return fromFrame(frame()->tree()->child(name)); } @@ -755,25 +778,33 @@ WebFrame* WebFrameImpl::findChildByExpression(const WebString& xpath) const if (xpath.isEmpty()) return 0; - Document* document = frame()->document(); + Document* document = m_frame->document(); ExceptionCode ec = 0; - RefPtr<XPathResult> xpathResult = document->evaluate(xpath, document, 0, XPathResult::ORDERED_NODE_ITERATOR_TYPE, 0, ec); + PassRefPtr<XPathResult> xpathResult = + document->evaluate(xpath, + document, + 0, // namespace + XPathResult::ORDERED_NODE_ITERATOR_TYPE, + 0, // XPathResult object + ec); if (!xpathResult) return 0; Node* node = xpathResult->iterateNext(ec); + if (!node || !node->isFrameOwnerElement()) return 0; - HTMLFrameOwnerElement* frameElement = static_cast<HTMLFrameOwnerElement*>(node); + HTMLFrameOwnerElement* frameElement = + static_cast<HTMLFrameOwnerElement*>(node); return fromFrame(frameElement->contentFrame()); } WebDocument WebFrameImpl::document() const { - if (!frame() || !frame()->document()) + if (!m_frame || !m_frame->document()) return WebDocument(); - return WebDocument(frame()->document()); + return WebDocument(m_frame->document()); } WebAnimationController* WebFrameImpl::animationController() @@ -783,49 +814,59 @@ WebAnimationController* WebFrameImpl::animationController() WebPerformance WebFrameImpl::performance() const { - if (!frame()) + if (!m_frame) return WebPerformance(); - return WebPerformance(frame()->document()->domWindow()->performance()); + + return WebPerformance(m_frame->document()->domWindow()->performance()); } NPObject* WebFrameImpl::windowObject() const { - if (!frame()) + if (!m_frame) return 0; - return frame()->script()->windowScriptNPObject(); + + return m_frame->script()->windowScriptNPObject(); } void WebFrameImpl::bindToWindowObject(const WebString& name, NPObject* object) { - if (!frame() || !frame()->script()->canExecuteScripts(NotAboutToExecuteScript)) + ASSERT(m_frame); + if (!m_frame || !m_frame->script()->canExecuteScripts(NotAboutToExecuteScript)) return; - frame()->script()->bindToWindowObject(frame(), String(name), object); + + String key = name; +#if USE(V8) + m_frame->script()->bindToWindowObject(m_frame, key, object); +#else + notImplemented(); +#endif } void WebFrameImpl::executeScript(const WebScriptSource& source) { - ASSERT(frame()); TextPosition position(OrdinalNumber::fromOneBasedInt(source.startLine), OrdinalNumber::first()); - frame()->script()->executeScript(ScriptSourceCode(source.code, source.url, position)); + m_frame->script()->executeScript( + ScriptSourceCode(source.code, source.url, position)); } -void WebFrameImpl::executeScriptInIsolatedWorld(int worldID, const WebScriptSource* sourcesIn, unsigned numSources, int extensionGroup) +void WebFrameImpl::executeScriptInIsolatedWorld( + int worldID, const WebScriptSource* sourcesIn, unsigned numSources, + int extensionGroup) { - ASSERT(frame()); - Vector<ScriptSourceCode> sources; + for (unsigned i = 0; i < numSources; ++i) { TextPosition position(OrdinalNumber::fromOneBasedInt(sourcesIn[i].startLine), OrdinalNumber::first()); - sources.append(ScriptSourceCode(sourcesIn[i].code, sourcesIn[i].url, position)); + sources.append(ScriptSourceCode( + sourcesIn[i].code, sourcesIn[i].url, position)); } - frame()->script()->evaluateInIsolatedWorld(worldID, sources, extensionGroup, 0); + m_frame->script()->evaluateInIsolatedWorld(worldID, sources, extensionGroup, 0); } void WebFrameImpl::setIsolatedWorldSecurityOrigin(int worldID, const WebSecurityOrigin& securityOrigin) { - ASSERT(frame()); - frame()->script()->setIsolatedWorldSecurityOrigin(worldID, securityOrigin.get()); + m_frame->script()->setIsolatedWorldSecurityOrigin(worldID, securityOrigin.get()); } void WebFrameImpl::addMessageToConsole(const WebConsoleMessage& message) @@ -856,23 +897,27 @@ void WebFrameImpl::addMessageToConsole(const WebConsoleMessage& message) void WebFrameImpl::collectGarbage() { - if (!frame()) + if (!m_frame) return; - if (!frame()->settings()->isScriptEnabled()) + if (!m_frame->settings()->isScriptEnabled()) return; + // FIXME: Move this to the ScriptController and make it JS neutral. +#if USE(V8) V8GCController::collectGarbage(); +#else + notImplemented(); +#endif } bool WebFrameImpl::checkIfRunInsecureContent(const WebURL& url) const { - ASSERT(frame()); - return frame()->loader()->checkIfRunInsecureContent(frame()->document()->securityOrigin(), url); + FrameLoader* frameLoader = m_frame->loader(); + return frameLoader->checkIfRunInsecureContent(m_frame->document()->securityOrigin(), url); } +#if USE(V8) v8::Handle<v8::Value> WebFrameImpl::executeScriptAndReturnValue(const WebScriptSource& source) { - ASSERT(frame()); - // FIXME: This fake user gesture is required to make a bunch of pyauto // tests pass. If this isn't needed in non-test situations, we should // consider removing this code and changing the tests. @@ -880,13 +925,13 @@ v8::Handle<v8::Value> WebFrameImpl::executeScriptAndReturnValue(const WebScriptS UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture); TextPosition position(OrdinalNumber::fromOneBasedInt(source.startLine), OrdinalNumber::first()); - return frame()->script()->executeScript(ScriptSourceCode(source.code, source.url, position)).v8Value(); + return m_frame->script()->executeScript(ScriptSourceCode(source.code, source.url, position)).v8Value(); } -void WebFrameImpl::executeScriptInIsolatedWorld(int worldID, const WebScriptSource* sourcesIn, unsigned numSources, int extensionGroup, WebVector<v8::Local<v8::Value> >* results) +void WebFrameImpl::executeScriptInIsolatedWorld( + int worldID, const WebScriptSource* sourcesIn, unsigned numSources, + int extensionGroup, WebVector<v8::Local<v8::Value> >* results) { - ASSERT(frame()); - Vector<ScriptSourceCode> sources; for (unsigned i = 0; i < numSources; ++i) { @@ -896,69 +941,76 @@ void WebFrameImpl::executeScriptInIsolatedWorld(int worldID, const WebScriptSour if (results) { Vector<ScriptValue> scriptResults; - frame()->script()->evaluateInIsolatedWorld(worldID, sources, extensionGroup, &scriptResults); + m_frame->script()->evaluateInIsolatedWorld(worldID, sources, extensionGroup, &scriptResults); WebVector<v8::Local<v8::Value> > v8Results(scriptResults.size()); for (unsigned i = 0; i < scriptResults.size(); i++) v8Results[i] = v8::Local<v8::Value>::New(scriptResults[i].v8Value()); results->swap(v8Results); } else - frame()->script()->evaluateInIsolatedWorld(worldID, sources, extensionGroup, 0); + m_frame->script()->evaluateInIsolatedWorld(worldID, sources, extensionGroup, 0); } -v8::Handle<v8::Value> WebFrameImpl::callFunctionEvenIfScriptDisabled(v8::Handle<v8::Function> function, v8::Handle<v8::Object> receiver, int argc, v8::Handle<v8::Value> argv[]) +// Call the function with the given receiver and arguments, bypassing canExecuteScripts. +v8::Handle<v8::Value> WebFrameImpl::callFunctionEvenIfScriptDisabled(v8::Handle<v8::Function> function, + v8::Handle<v8::Object> receiver, + int argc, + v8::Handle<v8::Value> argv[]) { - ASSERT(frame()); - return frame()->script()->callFunctionEvenIfScriptDisabled(function, receiver, argc, argv).v8Value(); + return m_frame->script()->callFunctionEvenIfScriptDisabled(function, receiver, argc, argv).v8Value(); } +// Returns the V8 context for this frame, or an empty handle if there is none. v8::Local<v8::Context> WebFrameImpl::mainWorldScriptContext() const { - if (!frame()) + if (!m_frame) return v8::Local<v8::Context>(); - return ScriptController::mainWorldContext(frame()); + + return ScriptController::mainWorldContext(m_frame); } -v8::Handle<v8::Value> WebFrameImpl::createFileSystem(WebFileSystem::Type type, const WebString& name, const WebString& path) +v8::Handle<v8::Value> WebFrameImpl::createFileSystem(WebFileSystem::Type type, + const WebString& name, + const WebString& path) { - ASSERT(frame()); return toV8(DOMFileSystem::create(frame()->document(), name, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, path.utf8().data()), AsyncFileSystemChromium::create())); } -v8::Handle<v8::Value> WebFrameImpl::createSerializableFileSystem(WebFileSystem::Type type, const WebString& name, const WebString& path) +v8::Handle<v8::Value> WebFrameImpl::createSerializableFileSystem(WebFileSystem::Type type, + const WebString& name, + const WebString& path) { - ASSERT(frame()); - RefPtr<DOMFileSystem> fileSystem = DOMFileSystem::create(frame()->document(), name, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, path.utf8().data()), AsyncFileSystemChromium::create()); - fileSystem->makeClonable(); - return toV8(fileSystem.release()); + RefPtr<DOMFileSystem> fs = DOMFileSystem::create(frame()->document(), name, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, path.utf8().data()), AsyncFileSystemChromium::create()); + fs->makeClonable(); + return toV8(fs.release()); } -v8::Handle<v8::Value> WebFrameImpl::createFileEntry(WebFileSystem::Type type, const WebString& fileSystemName, const WebString& fileSystemPath, const WebString& filePath, bool isDirectory) +v8::Handle<v8::Value> WebFrameImpl::createFileEntry(WebFileSystem::Type type, + const WebString& fileSystemName, + const WebString& fileSystemPath, + const WebString& filePath, + bool isDirectory) { - ASSERT(frame()); - RefPtr<DOMFileSystemBase> fileSystem = DOMFileSystem::create(frame()->document(), fileSystemName, static_cast<WebCore::FileSystemType>(type), KURL(ParsedURLString, fileSystemPath.utf8().data()), AsyncFileSystemChromium::create()); if (isDirectory) return toV8(DirectoryEntry::create(fileSystem, filePath)); return toV8(FileEntry::create(fileSystem, filePath)); } +#endif void WebFrameImpl::reload(bool ignoreCache) { - ASSERT(frame()); - frame()->loader()->history()->saveDocumentAndScrollState(); - frame()->loader()->reload(ignoreCache); + m_frame->loader()->history()->saveDocumentAndScrollState(); + m_frame->loader()->reload(ignoreCache); } void WebFrameImpl::reloadWithOverrideURL(const WebURL& overrideUrl, bool ignoreCache) { - ASSERT(frame()); - frame()->loader()->history()->saveDocumentAndScrollState(); - frame()->loader()->reloadWithOverrideURL(overrideUrl, ignoreCache); + m_frame->loader()->history()->saveDocumentAndScrollState(); + m_frame->loader()->reloadWithOverrideURL(overrideUrl, ignoreCache); } void WebFrameImpl::loadRequest(const WebURLRequest& request) { - ASSERT(frame()); ASSERT(!request.isNull()); const ResourceRequest& resourceRequest = request.toResourceRequest(); @@ -967,25 +1019,29 @@ void WebFrameImpl::loadRequest(const WebURLRequest& request) return; } - frame()->loader()->load(resourceRequest, false); + m_frame->loader()->load(resourceRequest, false); } void WebFrameImpl::loadHistoryItem(const WebHistoryItem& item) { - ASSERT(frame()); RefPtr<HistoryItem> historyItem = PassRefPtr<HistoryItem>(item); ASSERT(historyItem); - frame()->loader()->prepareForHistoryNavigation(); - RefPtr<HistoryItem> currentItem = frame()->loader()->history()->currentItem(); + m_frame->loader()->prepareForHistoryNavigation(); + RefPtr<HistoryItem> currentItem = m_frame->loader()->history()->currentItem(); m_inSameDocumentHistoryLoad = currentItem && currentItem->shouldDoSameDocumentNavigationTo(historyItem.get()); - frame()->page()->goToItem(historyItem.get(), FrameLoadTypeIndexedBackForward); + m_frame->page()->goToItem(historyItem.get(), + FrameLoadTypeIndexedBackForward); m_inSameDocumentHistoryLoad = false; } -void WebFrameImpl::loadData(const WebData& data, const WebString& mimeType, const WebString& textEncoding, const WebURL& baseURL, const WebURL& unreachableURL, bool replace) +void WebFrameImpl::loadData(const WebData& data, + const WebString& mimeType, + const WebString& textEncoding, + const WebURL& baseURL, + const WebURL& unreachableURL, + bool replace) { - ASSERT(frame()); SubstituteData substData(data, mimeType, textEncoding, unreachableURL); ASSERT(substData.isValid()); @@ -997,74 +1053,78 @@ void WebFrameImpl::loadData(const WebData& data, const WebString& mimeType, cons // instead of the currently loaded URL. ResourceRequest request; if (replace && !unreachableURL.isEmpty()) - request = frame()->loader()->originalRequest(); + request = m_frame->loader()->originalRequest(); request.setURL(baseURL); - frame()->loader()->load(request, substData, false); + m_frame->loader()->load(request, substData, false); if (replace) { // Do this to force WebKit to treat the load as replacing the currently // loaded page. - frame()->loader()->setReplacing(); + m_frame->loader()->setReplacing(); } } -void WebFrameImpl::loadHTMLString(const WebData& data, const WebURL& baseURL, const WebURL& unreachableURL, bool replace) +void WebFrameImpl::loadHTMLString(const WebData& data, + const WebURL& baseURL, + const WebURL& unreachableURL, + bool replace) { - ASSERT(frame()); - loadData(data, WebString::fromUTF8("text/html"), WebString::fromUTF8("UTF-8"), baseURL, unreachableURL, replace); + loadData(data, + WebString::fromUTF8("text/html"), + WebString::fromUTF8("UTF-8"), + baseURL, + unreachableURL, + replace); } bool WebFrameImpl::isLoading() const { - if (!frame()) + if (!m_frame) return false; - return frame()->loader()->isLoading(); + return m_frame->loader()->isLoading(); } void WebFrameImpl::stopLoading() { - if (!frame()) - return; + if (!m_frame) + return; + // FIXME: Figure out what we should really do here. It seems like a bug // that FrameLoader::stopLoading doesn't call stopAllLoaders. - frame()->loader()->stopAllLoaders(); - frame()->loader()->stopLoading(UnloadEventPolicyNone); + m_frame->loader()->stopAllLoaders(); + m_frame->loader()->stopLoading(UnloadEventPolicyNone); } WebDataSource* WebFrameImpl::provisionalDataSource() const { - ASSERT(frame()); + FrameLoader* frameLoader = m_frame->loader(); // We regard the policy document loader as still provisional. - DocumentLoader* documentLoader = frame()->loader()->provisionalDocumentLoader(); - if (!documentLoader) - documentLoader = frame()->loader()->policyDocumentLoader(); + DocumentLoader* docLoader = frameLoader->provisionalDocumentLoader(); + if (!docLoader) + docLoader = frameLoader->policyDocumentLoader(); - return DataSourceForDocLoader(documentLoader); + return DataSourceForDocLoader(docLoader); } WebDataSource* WebFrameImpl::dataSource() const { - ASSERT(frame()); - return DataSourceForDocLoader(frame()->loader()->documentLoader()); + return DataSourceForDocLoader(m_frame->loader()->documentLoader()); } WebHistoryItem WebFrameImpl::previousHistoryItem() const { - ASSERT(frame()); // We use the previous item here because documentState (filled-out forms) // only get saved to history when it becomes the previous item. The caller // is expected to query the history item after a navigation occurs, after // the desired history item has become the previous entry. - return WebHistoryItem(frame()->loader()->history()->previousItem()); + return WebHistoryItem(m_frame->loader()->history()->previousItem()); } WebHistoryItem WebFrameImpl::currentHistoryItem() const { - ASSERT(frame()); - // We're shutting down. - if (!frame()->loader()->activeDocumentLoader()) + if (!m_frame->loader()->activeDocumentLoader()) return WebHistoryItem(); // If we are still loading, then we don't want to clobber the current @@ -1072,30 +1132,35 @@ WebHistoryItem WebFrameImpl::currentHistoryItem() const // document state. However, it is OK for new navigations. // FIXME: Can we make this a plain old getter, instead of worrying about // clobbering here? - if (!m_inSameDocumentHistoryLoad && (frame()->loader()->loadType() == FrameLoadTypeStandard - || !frame()->loader()->activeDocumentLoader()->isLoadingInAPISense())) - frame()->loader()->history()->saveDocumentAndScrollState(); + if (!m_inSameDocumentHistoryLoad && (m_frame->loader()->loadType() == FrameLoadTypeStandard + || !m_frame->loader()->activeDocumentLoader()->isLoadingInAPISense())) + m_frame->loader()->history()->saveDocumentAndScrollState(); - return WebHistoryItem(frame()->page()->backForward()->currentItem()); + return WebHistoryItem(m_frame->page()->backForward()->currentItem()); } void WebFrameImpl::enableViewSourceMode(bool enable) { - if (frame()) - frame()->setInViewSourceMode(enable); + if (m_frame) + m_frame->setInViewSourceMode(enable); } bool WebFrameImpl::isViewSourceModeEnabled() const { - if (!frame()) - return false; - return frame()->inViewSourceMode(); + if (m_frame) + return m_frame->inViewSourceMode(); + + return false; } void WebFrameImpl::setReferrerForRequest(WebURLRequest& request, const WebURL& referrerURL) { - String referrer = referrerURL.isEmpty() ? frame()->loader()->outgoingReferrer() : String(referrerURL.spec().utf16()); - referrer = SecurityPolicy::generateReferrerHeader(frame()->document()->referrerPolicy(), request.url(), referrer); + String referrer; + if (referrerURL.isEmpty()) + referrer = m_frame->loader()->outgoingReferrer(); + else + referrer = referrerURL.spec().utf16(); + referrer = SecurityPolicy::generateReferrerHeader(m_frame->document()->referrerPolicy(), request.url(), referrer); if (referrer.isEmpty()) return; request.setHTTPHeaderField(WebString::fromUTF8("Referer"), referrer); @@ -1104,7 +1169,8 @@ void WebFrameImpl::setReferrerForRequest(WebURLRequest& request, const WebURL& r void WebFrameImpl::dispatchWillSendRequest(WebURLRequest& request) { ResourceResponse response; - frame()->loader()->client()->dispatchWillSendRequest(0, 0, request.toMutableResourceRequest(), response); + m_frame->loader()->client()->dispatchWillSendRequest( + 0, 0, request.toMutableResourceRequest(), response); } WebURLLoader* WebFrameImpl::createAssociatedURLLoader(const WebURLLoaderOptions& options) @@ -1114,7 +1180,7 @@ WebURLLoader* WebFrameImpl::createAssociatedURLLoader(const WebURLLoaderOptions& void WebFrameImpl::commitDocumentData(const char* data, size_t length) { - frame()->loader()->documentLoader()->commitData(data, length); + m_frame->loader()->documentLoader()->commitData(data, length); } unsigned WebFrameImpl::unloadListenerCount() const @@ -1146,16 +1212,21 @@ void WebFrameImpl::replaceSelection(const WebString& text) void WebFrameImpl::insertText(const WebString& text) { - if (frame()->editor()->hasComposition()) - frame()->editor()->confirmComposition(text); + Editor* editor = frame()->editor(); + + if (editor->hasComposition()) + editor->confirmComposition(text); else - frame()->editor()->insertText(text, 0); + editor->insertText(text, 0); } -void WebFrameImpl::setMarkedText(const WebString& text, unsigned location, unsigned length) +void WebFrameImpl::setMarkedText( + const WebString& text, unsigned location, unsigned length) { + Editor* editor = frame()->editor(); + Vector<CompositionUnderline> decorations; - frame()->editor()->setComposition(text, decorations, location, length); + editor->setComposition(text, decorations, location, length); } void WebFrameImpl::unmarkText() @@ -1184,6 +1255,7 @@ bool WebFrameImpl::firstRectForCharacterRange(unsigned location, unsigned length IntRect intRect = frame()->editor()->firstRectForRange(range.get()); rect = WebRect(intRect); rect = frame()->view()->contentsToWindow(rect); + return true; } @@ -1231,29 +1303,38 @@ bool WebFrameImpl::executeCommand(const WebString& name, const WebNode& node) } } - bool result = true; + bool rv = true; // Specially handling commands that Editor::execCommand does not directly // support. if (command == "DeleteToEndOfParagraph") { - if (!frame()->editor()->deleteWithDirection(DirectionForward, ParagraphBoundary, true, false)) - frame()->editor()->deleteWithDirection(DirectionForward, CharacterGranularity, true, false); + Editor* editor = frame()->editor(); + if (!editor->deleteWithDirection(DirectionForward, + ParagraphBoundary, + true, + false)) { + editor->deleteWithDirection(DirectionForward, + CharacterGranularity, + true, + false); + } } else if (command == "Indent") frame()->editor()->indent(); else if (command == "Outdent") frame()->editor()->outdent(); else if (command == "DeleteBackward") - result = frame()->editor()->command(AtomicString("BackwardDelete")).execute(); + rv = frame()->editor()->command(AtomicString("BackwardDelete")).execute(); else if (command == "DeleteForward") - result = frame()->editor()->command(AtomicString("ForwardDelete")).execute(); + rv = frame()->editor()->command(AtomicString("ForwardDelete")).execute(); else if (command == "AdvanceToNextMisspelling") { - // Wee need to pass false here or else the currently selected word will never be skipped. + // False must be passed here, or the currently selected word will never be + // skipped. frame()->editor()->advanceToNextMisspelling(false); } else if (command == "ToggleSpellPanel") frame()->editor()->showSpellingGuessPanel(); else - result = frame()->editor()->command(command).execute(); - return result; + rv = frame()->editor()->command(command).execute(); + return rv; } bool WebFrameImpl::executeCommand(const WebString& name, const WebString& value) @@ -1261,7 +1342,8 @@ bool WebFrameImpl::executeCommand(const WebString& name, const WebString& value) ASSERT(frame()); String webName = name; - // moveToBeginningOfDocument and moveToEndfDocument are only handled by WebKit for editable nodes. + // moveToBeginningOfDocument and moveToEndfDocument are only handled by WebKit + // for editable nodes. if (!frame()->editor()->canEdit() && webName == "moveToBeginningOfDocument") return viewImpl()->propagateScroll(ScrollUp, ScrollByDocument); @@ -1289,11 +1371,13 @@ bool WebFrameImpl::isContinuousSpellCheckingEnabled() const return frame()->editor()->isContinuousSpellCheckingEnabled(); } -void WebFrameImpl::requestTextChecking(const WebElement& webElement) +void WebFrameImpl::requestTextChecking(const WebElement& webElem) { - if (webElement.isNull()) + if (webElem.isNull()) return; - RefPtr<Range> rangeToCheck = rangeOfContents(const_cast<Element*>(webElement.constUnwrap<Element>())); + + RefPtr<Range> rangeToCheck = rangeOfContents(const_cast<Element*>(webElem.constUnwrap<Element>())); + frame()->editor()->spellChecker()->requestCheckingFor(SpellCheckRequest::create(TextCheckingTypeSpelling | TextCheckingTypeGrammar, TextCheckingProcessBatch, rangeToCheck, rangeToCheck)); } @@ -1361,9 +1445,9 @@ WebString WebFrameImpl::selectionAsMarkup() const return createMarkup(range.get(), 0, AnnotateForInterchange, false, ResolveNonLocalURLs); } -void WebFrameImpl::selectWordAroundPosition(Frame* frame, VisiblePosition position) +void WebFrameImpl::selectWordAroundPosition(Frame* frame, VisiblePosition pos) { - VisibleSelection selection(position); + VisibleSelection selection(pos); selection.expandUsingGranularity(WordGranularity); if (frame->selection()->shouldChangeSelection(selection)) { @@ -1384,33 +1468,42 @@ bool WebFrameImpl::selectWordAroundCaret() void WebFrameImpl::selectRange(const WebPoint& base, const WebPoint& extent) { - VisiblePosition basePosition = visiblePositionForWindowPoint(base); - VisiblePosition extentPosition = visiblePositionForWindowPoint(extent); - VisibleSelection newSelection = VisibleSelection(basePosition, extentPosition); + VisiblePosition basePos = visiblePositionForWindowPoint(base); + VisiblePosition extentPos = visiblePositionForWindowPoint(extent); + VisibleSelection newSelection = VisibleSelection(basePos, extentPos); if (frame()->selection()->shouldChangeSelection(newSelection)) frame()->selection()->setSelection(newSelection, CharacterGranularity); } void WebFrameImpl::selectRange(const WebRange& webRange) { - if (RefPtr<Range> range = static_cast<PassRefPtr<Range> >(webRange)) + RefPtr<Range> range = static_cast<PassRefPtr<Range> >(webRange); + if (range) frame()->selection()->setSelectedRange(range.get(), WebCore::VP_DEFAULT_AFFINITY, false); } VisiblePosition WebFrameImpl::visiblePositionForWindowPoint(const WebPoint& point) { - HitTestRequest request = HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::IgnoreClipping; - HitTestResult result(frame()->view()->windowToContents(IntPoint(point))); + HitTestRequest::HitTestRequestType hitType = HitTestRequest::Move; + hitType |= HitTestRequest::ReadOnly; + hitType |= HitTestRequest::Active; + hitType |= HitTestRequest::IgnoreClipping; + HitTestRequest request(hitType); + FrameView* view = frame()->view(); + HitTestResult result(view->windowToContents(IntPoint(point.x, point.y))); frame()->document()->renderView()->layer()->hitTest(request, result); Node* node = result.targetNode(); if (!node) return VisiblePosition(); + return node->renderer()->positionForPoint(result.localPoint()); } -int WebFrameImpl::printBegin(const WebPrintParams& printParams, const WebNode& constrainToNode, bool* useBrowserOverlays) +int WebFrameImpl::printBegin(const WebPrintParams& printParams, + const WebNode& constrainToNode, + bool* useBrowserOverlays) { ASSERT(!frame()->document()->isFrameSet()); WebPluginContainerImpl* pluginContainer = 0; @@ -1428,7 +1521,8 @@ int WebFrameImpl::printBegin(const WebPrintParams& printParams, const WebNode& c else m_printContext = adoptPtr(new ChromePrintContext(frame())); - FloatRect rect(0, 0, static_cast<float>(printParams.printContentArea.width), static_cast<float>(printParams.printContentArea.height)); + FloatRect rect(0, 0, static_cast<float>(printParams.printContentArea.width), + static_cast<float>(printParams.printContentArea.height)); m_printContext->begin(rect.width(), rect.height()); float pageHeight; // We ignore the overlays calculation for now since they are generated in the @@ -1442,19 +1536,29 @@ int WebFrameImpl::printBegin(const WebPrintParams& printParams, const WebNode& c float WebFrameImpl::getPrintPageShrink(int page) { - ASSERT(m_printContext && page >= 0); + // Ensure correct state. + if (!m_printContext || page < 0) { + ASSERT_NOT_REACHED(); + return 0; + } + return m_printContext->getPageShrink(page); } float WebFrameImpl::printPage(int page, WebCanvas* canvas) { #if ENABLE(PRINTING) - ASSERT(m_printContext && page >= 0 && frame() && frame()->document()); + // Ensure correct state. + if (!m_printContext || page < 0 || !frame() || !frame()->document()) { + ASSERT_NOT_REACHED(); + return 0; + } GraphicsContextBuilder builder(canvas); - GraphicsContext& graphicsContext = builder.context(); - graphicsContext.platformContext()->setPrinting(true); - return m_printContext->spoolPage(graphicsContext, page); + GraphicsContext& gc = builder.context(); + gc.platformContext()->setPrinting(true); + + return m_printContext->spoolPage(gc, page); #else return 0; #endif @@ -1463,13 +1567,18 @@ float WebFrameImpl::printPage(int page, WebCanvas* canvas) void WebFrameImpl::printEnd() { ASSERT(m_printContext); - m_printContext->end(); + if (m_printContext) + m_printContext->end(); m_printContext.clear(); } bool WebFrameImpl::isPrintScalingDisabledForPlugin(const WebNode& node) { - WebPluginContainerImpl* pluginContainer = node.isNull() ? pluginContainerFromFrame(frame()) : pluginContainerFromNode(node); + WebPluginContainerImpl* pluginContainer = 0; + if (node.isNull()) + pluginContainer = pluginContainerFromFrame(frame()); + else + pluginContainer = pluginContainerFromNode(node); if (!pluginContainer || !pluginContainer->supportsPaginatedPrint()) return false; @@ -1487,24 +1596,35 @@ bool WebFrameImpl::isPageBoxVisible(int pageIndex) return frame()->document()->isPageBoxVisible(pageIndex); } -void WebFrameImpl::pageSizeAndMarginsInPixels(int pageIndex, WebSize& pageSize, int& marginTop, int& marginRight, int& marginBottom, int& marginLeft) -{ - IntSize size = pageSize; - frame()->document()->pageSizeAndMarginsInPixels(pageIndex, size, marginTop, marginRight, marginBottom, marginLeft); +void WebFrameImpl::pageSizeAndMarginsInPixels(int pageIndex, + WebSize& pageSize, + int& marginTop, + int& marginRight, + int& marginBottom, + int& marginLeft) +{ + IntSize size(pageSize.width, pageSize.height); + frame()->document()->pageSizeAndMarginsInPixels(pageIndex, + size, + marginTop, + marginRight, + marginBottom, + marginLeft); pageSize = size; } WebString WebFrameImpl::pageProperty(const WebString& propertyName, int pageIndex) { ASSERT(m_printContext); - return m_printContext->pageProperty(frame(), propertyName.utf8().data(), pageIndex); + return m_printContext->pageProperty(m_frame, propertyName.utf8().data(), pageIndex); } -bool WebFrameImpl::find(int identifier, const WebString& searchText, const WebFindOptions& options, bool wrapWithinFrame, WebRect* selectionRect) +bool WebFrameImpl::find(int identifier, + const WebString& searchText, + const WebFindOptions& options, + bool wrapWithinFrame, + WebRect* selectionRect) { - if (!frame() || !frame()->page()) - return false; - WebFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl(); if (!options.findNext) @@ -1598,19 +1718,20 @@ void WebFrameImpl::stopFinding(bool clearSelection) invalidateArea(InvalidateAll); } -void WebFrameImpl::scopeStringMatches(int identifier, const WebString& searchText, const WebFindOptions& options, bool reset) +void WebFrameImpl::scopeStringMatches(int identifier, + const WebString& searchText, + const WebFindOptions& options, + bool reset) { + WebFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl(); + if (reset) { // This is a brand new search, so we need to reset everything. // Scoping is just about to begin. - m_scopingInProgress = true; - - // Need to keep the current identifier locally in order to finish the - // request in case the frame is detached during the process. - m_findRequestIdentifier = identifier; + m_scopingComplete = false; // Clear highlighting for this frame. - if (frame() && frame()->page() && frame()->editor()->markedTextMatchesAreHighlighted()) + if (frame() && frame()->editor()->markedTextMatchesAreHighlighted()) frame()->page()->unmarkAllTextMatches(); // Clear the tickmarks and results cache. @@ -1622,12 +1743,14 @@ void WebFrameImpl::scopeStringMatches(int identifier, const WebString& searchTex m_resumeScopingFromRange = 0; - // The view might be null on detached frames. - if (frame() && frame()->page()) - viewImpl()->mainFrameImpl()->m_framesScopingCount++; + mainFrameImpl->m_framesScopingCount++; // Now, defer scoping until later to allow find operation to finish quickly. - scopeStringMatchesSoon(identifier, searchText, options, false); // false means just reset, so don't do it again. + scopeStringMatchesSoon( + identifier, + searchText, + options, + false); // false=we just reset, so don't do it again. return; } @@ -1639,7 +1762,6 @@ void WebFrameImpl::scopeStringMatches(int identifier, const WebString& searchTex return; } - WebFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl(); RefPtr<Range> searchRange(rangeOfContents(frame()->document())); Node* originalEndContainer = searchRange->endContainer(); @@ -1769,29 +1891,20 @@ void WebFrameImpl::scopeStringMatches(int identifier, const WebString& searchTex finishCurrentScopingEffort(identifier); } -void WebFrameImpl::flushCurrentScopingEffort(int identifier) +void WebFrameImpl::finishCurrentScopingEffort(int identifier) { - if (!frame() || !frame()->page()) - return; - WebFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl(); // This frame has no further scoping left, so it is done. Other frames might, // of course, continue to scope matches. + m_scopingComplete = true; mainFrameImpl->m_framesScopingCount--; + m_lastFindRequestCompletedWithNoMatches = !m_lastMatchCount; // If this is the last frame to finish scoping we need to trigger the final // update to be sent. if (!mainFrameImpl->m_framesScopingCount) mainFrameImpl->increaseMatchCount(0, identifier); -} - -void WebFrameImpl::finishCurrentScopingEffort(int identifier) -{ - flushCurrentScopingEffort(identifier); - - m_scopingInProgress = false; - m_lastFindRequestCompletedWithNoMatches = !m_lastMatchCount; // This frame is done, so show any scrollbar tickmarks we haven't drawn yet. invalidateArea(InvalidateScrollbar); @@ -1804,11 +1917,8 @@ void WebFrameImpl::cancelPendingScopingEffort() m_activeMatchIndexInCurrentFrame = -1; - // Last request didn't complete. - if (m_scopingInProgress) + if (!m_scopingComplete) m_lastFindRequestCompletedWithNoMatches = false; - - m_scopingInProgress = false; } void WebFrameImpl::increaseMatchCount(int count, int identifier) @@ -1826,7 +1936,9 @@ void WebFrameImpl::increaseMatchCount(int count, int identifier) client()->reportFindInPageMatchCount(identifier, m_totalMatchCount, !m_framesScopingCount); } -void WebFrameImpl::reportFindInPageSelection(const WebRect& selectionRect, int activeMatchOrdinal, int identifier) +void WebFrameImpl::reportFindInPageSelection(const WebRect& selectionRect, + int activeMatchOrdinal, + int identifier) { // Update the UI with the latest selection rect. if (client()) @@ -1845,21 +1957,21 @@ void WebFrameImpl::resetMatchCount() void WebFrameImpl::sendOrientationChangeEvent(int orientation) { #if ENABLE(ORIENTATION_EVENTS) - if (frame()) - frame()->sendOrientationChangeEvent(orientation); + if (m_frame) + m_frame->sendOrientationChangeEvent(orientation); #endif } void WebFrameImpl::addEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture) { - DOMWindow* window = frame()->document()->domWindow(); + DOMWindow* window = m_frame->document()->domWindow(); EventListenerWrapper* listenerWrapper = listener->createEventListenerWrapper(eventType, useCapture, window); window->addEventListener(eventType, adoptRef(listenerWrapper), useCapture); } void WebFrameImpl::removeEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture) { - DOMWindow* window = frame()->document()->domWindow(); + DOMWindow* window = m_frame->document()->domWindow(); EventListenerWrapper* listenerWrapper = listener->getEventListenerWrapper(eventType, useCapture, window); window->removeEventListener(eventType, listenerWrapper, useCapture); } @@ -1867,13 +1979,14 @@ void WebFrameImpl::removeEventListener(const WebString& eventType, WebDOMEventLi bool WebFrameImpl::dispatchEvent(const WebDOMEvent& event) { ASSERT(!event.isNull()); - return frame()->document()->domWindow()->dispatchEvent(event); + return m_frame->document()->domWindow()->dispatchEvent(event); } void WebFrameImpl::dispatchMessageEventWithOriginCheck(const WebSecurityOrigin& intendedTargetOrigin, const WebDOMEvent& event) { ASSERT(!event.isNull()); - frame()->document()->domWindow()->dispatchMessageEventWithOriginCheck(intendedTargetOrigin.get(), event, 0); + // Pass an empty call stack, since we don't have the one from the other process. + m_frame->document()->domWindow()->dispatchMessageEventWithOriginCheck(intendedTargetOrigin.get(), event, 0); } int WebFrameImpl::findMatchMarkersVersion() const @@ -1895,7 +2008,8 @@ bool WebFrameImpl::isActiveMatchFrameValid() const { WebFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl(); WebFrameImpl* activeMatchFrame = mainFrameImpl->activeMatchFrame(); - return activeMatchFrame && activeMatchFrame->m_activeMatch && activeMatchFrame->frame()->tree()->isDescendantOf(mainFrameImpl->frame()); + return activeMatchFrame && activeMatchFrame->m_activeMatch + && activeMatchFrame->frame()->tree()->isDescendantOf(mainFrameImpl->frame()); } void WebFrameImpl::updateFindMatchRects() @@ -2079,41 +2193,44 @@ void WebFrameImpl::deliverIntent(const WebIntent& intent, WebMessagePortChannelA (*channels)[i] = MessagePortChannel::create(platformChannel); } } - OwnPtr<MessagePortArray> portArray = WebCore::MessagePort::entanglePorts(*(frame()->document()), channels.release()); + OwnPtr<MessagePortArray> portArray = WebCore::MessagePort::entanglePorts(*(m_frame->document()), channels.release()); - RefPtr<DeliveredIntent> deliveredIntent = DeliveredIntent::create(frame(), client.release(), intent.action(), intent.type(), intentData, portArray.release(), webcoreIntent->extras()); + RefPtr<DeliveredIntent> deliveredIntent = DeliveredIntent::create(m_frame, client.release(), intent.action(), intent.type(), intentData, portArray.release(), webcoreIntent->extras()); - DOMWindowIntents::from(frame()->document()->domWindow())->deliver(deliveredIntent.release()); + DOMWindowIntents::from(m_frame->document()->domWindow())->deliver(deliveredIntent.release()); #endif } WebString WebFrameImpl::contentAsText(size_t maxChars) const { - if (!frame()) + if (!m_frame) return WebString(); + Vector<UChar> text; - frameContentAsPlainText(maxChars, frame(), &text); + frameContentAsPlainText(maxChars, m_frame, &text); return String::adopt(text); } WebString WebFrameImpl::contentAsMarkup() const { - if (!frame()) - return WebString(); - return createFullMarkup(frame()->document()); + return createFullMarkup(m_frame->document()); } WebString WebFrameImpl::renderTreeAsText(RenderAsTextControls toShow) const { RenderAsTextBehavior behavior = RenderAsTextBehaviorNormal; - if (toShow & RenderAsTextDebug) - behavior |= RenderAsTextShowCompositedLayers | RenderAsTextShowAddresses | RenderAsTextShowIDAndClass | RenderAsTextShowLayerNesting; + if (toShow & RenderAsTextDebug) { + behavior |= RenderAsTextShowCompositedLayers + | RenderAsTextShowAddresses + | RenderAsTextShowIDAndClass + | RenderAsTextShowLayerNesting; + } if (toShow & RenderAsTextPrinting) behavior |= RenderAsTextPrintingMode; - return externalRepresentation(frame(), behavior); + return externalRepresentation(m_frame, behavior); } WebString WebFrameImpl::markerTextForListItem(const WebElement& webElement) const @@ -2123,34 +2240,36 @@ WebString WebFrameImpl::markerTextForListItem(const WebElement& webElement) cons void WebFrameImpl::printPagesWithBoundaries(WebCanvas* canvas, const WebSize& pageSizeInPixels) { - ASSERT(m_printContext); + ASSERT(m_printContext.get()); GraphicsContextBuilder builder(canvas); GraphicsContext& graphicsContext = builder.context(); graphicsContext.platformContext()->setPrinting(true); - m_printContext->spoolAllPagesWithBoundaries(graphicsContext, FloatSize(pageSizeInPixels.width, pageSizeInPixels.height)); + m_printContext->spoolAllPagesWithBoundaries(graphicsContext, + FloatSize(pageSizeInPixels.width, pageSizeInPixels.height)); } WebRect WebFrameImpl::selectionBoundsRect() const { - return hasSelection() ? WebRect(IntRect(frame()->selection()->bounds(false))) : WebRect(); + if (hasSelection()) + return IntRect(frame()->selection()->bounds(false)); + + return WebRect(); } bool WebFrameImpl::selectionStartHasSpellingMarkerFor(int from, int length) const { - if (!frame()) + if (!m_frame) return false; - return frame()->editor()->selectionStartHasMarkerFor(DocumentMarker::Spelling, from, length); + return m_frame->editor()->selectionStartHasMarkerFor(DocumentMarker::Spelling, from, length); } WebString WebFrameImpl::layerTreeAsText(bool showDebugInfo) const { - if (!frame()) + if (!m_frame) return WebString(); - - LayerTreeFlags flags = showDebugInfo ? LayerTreeFlagsIncludeDebugInfo : 0; - return WebString(frame()->layerTreeAsText(flags)); + return WebString(m_frame->layerTreeAsText(showDebugInfo)); } // WebFrameImpl public --------------------------------------------------------- @@ -2161,9 +2280,9 @@ PassRefPtr<WebFrameImpl> WebFrameImpl::create(WebFrameClient* client) } WebFrameImpl::WebFrameImpl(WebFrameClient* client) - : FrameDestructionObserver(0) - , m_frameLoaderClient(this) + : m_frameLoaderClient(this) , m_client(client) + , m_frame(0) , m_currentActiveMatchFrame(0) , m_activeMatchIndexInCurrentFrame(-1) , m_locatingActiveRect(false) @@ -2171,8 +2290,7 @@ WebFrameImpl::WebFrameImpl(WebFrameClient* client) , m_lastMatchCount(-1) , m_totalMatchCount(-1) , m_framesScopingCount(-1) - , m_findRequestIdentifier(-1) - , m_scopingInProgress(false) + , m_scopingComplete(false) , m_lastFindRequestCompletedWithNoMatches(false) , m_nextInvalidateAfter(0) , m_findMatchMarkersVersion(0) @@ -2193,16 +2311,10 @@ WebFrameImpl::~WebFrameImpl() cancelPendingScopingEffort(); } -void WebFrameImpl::setWebCoreFrame(WebCore::Frame* frame) -{ - ASSERT(frame); - observeFrame(frame); -} - void WebFrameImpl::initializeAsMainFrame(WebCore::Page* page) { - RefPtr<Frame> mainFrame = Frame::create(page, 0, &m_frameLoaderClient); - setWebCoreFrame(mainFrame.get()); + RefPtr<Frame> frame = Frame::create(page, 0, &m_frameLoaderClient); + m_frame = frame.get(); // Add reference on behalf of FrameLoader. See comments in // WebFrameLoaderClient::frameLoaderDestroyed for more info. @@ -2210,10 +2322,11 @@ void WebFrameImpl::initializeAsMainFrame(WebCore::Page* page) // We must call init() after m_frame is assigned because it is referenced // during init(). - frame()->init(); + m_frame->init(); } -PassRefPtr<Frame> WebFrameImpl::createChildFrame(const FrameLoadRequest& request, HTMLFrameOwnerElement* ownerElement) +PassRefPtr<Frame> WebFrameImpl::createChildFrame( + const FrameLoadRequest& request, HTMLFrameOwnerElement* ownerElement) { RefPtr<WebFrameImpl> webframe(adoptRef(new WebFrameImpl(m_client))); @@ -2222,12 +2335,13 @@ PassRefPtr<Frame> WebFrameImpl::createChildFrame(const FrameLoadRequest& request // of this file for more info. webframe->ref(); - RefPtr<Frame> childFrame = Frame::create(frame()->page(), ownerElement, &webframe->m_frameLoaderClient); - webframe->setWebCoreFrame(childFrame.get()); + RefPtr<Frame> childFrame = Frame::create( + m_frame->page(), ownerElement, &webframe->m_frameLoaderClient); + webframe->m_frame = childFrame.get(); childFrame->tree()->setName(request.frameName()); - frame()->tree()->appendChild(childFrame); + m_frame->tree()->appendChild(childFrame); // Frame::init() can trigger onload event in the parent frame, // which may detach this frame and trigger a null-pointer access @@ -2242,7 +2356,10 @@ PassRefPtr<Frame> WebFrameImpl::createChildFrame(const FrameLoadRequest& request if (!childFrame->tree()->parent()) return 0; - frame()->loader()->loadURLIntoChildFrame(request.resourceRequest().url(), request.resourceRequest().httpReferrer(), childFrame.get()); + m_frame->loader()->loadURLIntoChildFrame( + request.resourceRequest().url(), + request.resourceRequest().httpReferrer(), + childFrame.get()); // A synchronous navigation (about:blank) would have already processed // onload, so it is possible for the frame to have already been destroyed by @@ -2267,13 +2384,13 @@ void WebFrameImpl::didChangeContentsSize(const IntSize& size) void WebFrameImpl::createFrameView() { - ASSERT(frame()); // If frame() doesn't exist, we probably didn't init properly. + ASSERT(m_frame); // If m_frame doesn't exist, we probably didn't init properly. WebViewImpl* webView = viewImpl(); - bool isMainFrame = webView->mainFrameImpl()->frame() == frame(); - frame()->createView(webView->size(), Color::white, webView->isTransparent(), webView->fixedLayoutSize(), isMainFrame ? webView->isFixedLayoutModeEnabled() : 0); + bool isMainFrame = webView->mainFrameImpl()->frame() == m_frame; + m_frame->createView(webView->size(), Color::white, webView->isTransparent(), webView->fixedLayoutSize(), isMainFrame ? webView->isFixedLayoutModeEnabled() : 0); if (webView->shouldAutoResize() && isMainFrame) - frame()->view()->enableAutoSizeMode(true, webView->minAutoSize(), webView->maxAutoSize()); + m_frame->view()->enableAutoSizeMode(true, webView->minAutoSize(), webView->maxAutoSize()); if (isMainFrame && webView->devToolsAgentPrivate()) webView->devToolsAgentPrivate()->mainFrameViewCreated(this); @@ -2283,23 +2400,29 @@ WebFrameImpl* WebFrameImpl::fromFrame(Frame* frame) { if (!frame) return 0; + return static_cast<FrameLoaderClientImpl*>(frame->loader()->client())->webFrame(); } WebFrameImpl* WebFrameImpl::fromFrameOwnerElement(Element* element) { - // FIXME: Why do we check specifically for <iframe> and <frame> here? Why can't we get the WebFrameImpl from an <object> element, for example. - if (!element || !element->isFrameOwnerElement() || (!element->hasTagName(HTMLNames::iframeTag) && !element->hasTagName(HTMLNames::frameTag))) + if (!element + || !element->isFrameOwnerElement() + || (!element->hasTagName(HTMLNames::iframeTag) + && !element->hasTagName(HTMLNames::frameTag))) return 0; - HTMLFrameOwnerElement* frameElement = static_cast<HTMLFrameOwnerElement*>(element); + + HTMLFrameOwnerElement* frameElement = + static_cast<HTMLFrameOwnerElement*>(element); return fromFrame(frameElement->contentFrame()); } WebViewImpl* WebFrameImpl::viewImpl() const { - if (!frame()) + if (!m_frame) return 0; - return WebViewImpl::fromPage(frame()->page()); + + return WebViewImpl::fromPage(m_frame->page()); } WebDataSourceImpl* WebFrameImpl::dataSourceImpl() const @@ -2385,7 +2508,14 @@ void WebFrameImpl::didFail(const ResourceError& error, bool wasProvisional) void WebFrameImpl::setCanHaveScrollbars(bool canHaveScrollbars) { - frame()->view()->setCanHaveScrollbars(canHaveScrollbars); + m_frame->view()->setCanHaveScrollbars(canHaveScrollbars); +} + +// WebFrameImpl private -------------------------------------------------------- + +void WebFrameImpl::closing() +{ + m_frame = 0; } void WebFrameImpl::invalidateArea(AreaToInvalidate area) @@ -2423,6 +2553,7 @@ void WebFrameImpl::setMarkerActive(Range* range, bool active) WebCore::ExceptionCode ec; if (!range || range->collapsed(ec)) return; + frame()->document()->markers()->setMarkersActive(range, active); } @@ -2432,7 +2563,9 @@ int WebFrameImpl::ordinalOfFirstMatchForFrame(WebFrameImpl* frame) const WebFrameImpl* mainFrameImpl = viewImpl()->mainFrameImpl(); // Iterate from the main frame up to (but not including) |frame| and // add up the number of matches found so far. - for (WebFrameImpl* it = mainFrameImpl; it != frame; it = static_cast<WebFrameImpl*>(it->traverseNext(true))) { + for (WebFrameImpl* it = mainFrameImpl; + it != frame; + it = static_cast<WebFrameImpl*>(it->traverseNext(true))) { if (it->m_lastMatchCount > 0) ordinal += it->m_lastMatchCount; } @@ -2443,8 +2576,7 @@ bool WebFrameImpl::shouldScopeMatches(const String& searchText) { // Don't scope if we can't find a frame or a view. // The user may have closed the tab/application, so abort. - // Also ignore detached frames, as many find operations report to the main frame. - if (!frame() || !frame()->view() || !frame()->page()) + if (!frame() || !frame()->view()) return false; ASSERT(frame()->document() && frame()->view()); @@ -2464,14 +2596,19 @@ bool WebFrameImpl::shouldScopeMatches(const String& searchText) return true; } -void WebFrameImpl::scopeStringMatchesSoon(int identifier, const WebString& searchText, const WebFindOptions& options, bool reset) +void WebFrameImpl::scopeStringMatchesSoon(int identifier, const WebString& searchText, + const WebFindOptions& options, bool reset) { - m_deferredScopingWork.append(new DeferredScopeStringMatches(this, identifier, searchText, options, reset)); + m_deferredScopingWork.append(new DeferredScopeStringMatches( + this, identifier, searchText, options, reset)); } -void WebFrameImpl::callScopeStringMatches(DeferredScopeStringMatches* caller, int identifier, const WebString& searchText, const WebFindOptions& options, bool reset) +void WebFrameImpl::callScopeStringMatches(DeferredScopeStringMatches* caller, + int identifier, const WebString& searchText, + const WebFindOptions& options, bool reset) { m_deferredScopingWork.remove(m_deferredScopingWork.find(caller)); + scopeStringMatches(identifier, searchText, options, reset); // This needs to happen last since searchText is passed by reference. @@ -2480,22 +2617,21 @@ void WebFrameImpl::callScopeStringMatches(DeferredScopeStringMatches* caller, in void WebFrameImpl::invalidateIfNecessary() { - if (m_lastMatchCount <= m_nextInvalidateAfter) - return; - - // FIXME: (http://b/1088165) Optimize the drawing of the tickmarks and - // remove this. This calculation sets a milestone for when next to - // invalidate the scrollbar and the content area. We do this so that we - // don't spend too much time drawing the scrollbar over and over again. - // Basically, up until the first 500 matches there is no throttle. - // After the first 500 matches, we set set the milestone further and - // further out (750, 1125, 1688, 2K, 3K). - static const int startSlowingDownAfter = 500; - static const int slowdown = 750; - - int i = m_lastMatchCount / startSlowingDownAfter; - m_nextInvalidateAfter += i * slowdown; - invalidateArea(InvalidateScrollbar); + if (m_lastMatchCount > m_nextInvalidateAfter) { + // FIXME: (http://b/1088165) Optimize the drawing of the tickmarks and + // remove this. This calculation sets a milestone for when next to + // invalidate the scrollbar and the content area. We do this so that we + // don't spend too much time drawing the scrollbar over and over again. + // Basically, up until the first 500 matches there is no throttle. + // After the first 500 matches, we set set the milestone further and + // further out (750, 1125, 1688, 2K, 3K). + static const int startSlowingDownAfter = 500; + static const int slowdown = 750; + int i = (m_lastMatchCount / startSlowingDownAfter); + m_nextInvalidateAfter += i * slowdown; + + invalidateArea(InvalidateScrollbar); + } } void WebFrameImpl::loadJavaScriptURL(const KURL& url) @@ -2508,41 +2644,24 @@ void WebFrameImpl::loadJavaScriptURL(const KURL& url) // location change. We also allow a JS URL to be loaded even if scripts on // the page are otherwise disabled. - if (!frame()->document() || !frame()->page()) + if (!m_frame->document() || !m_frame->page()) return; - RefPtr<Document> ownerDocument(frame()->document()); + RefPtr<Document> ownerDocument(m_frame->document()); // Protect privileged pages against bookmarklets and other javascript manipulations. - if (SchemeRegistry::shouldTreatURLSchemeAsNotAllowingJavascriptURLs(frame()->document()->url().protocol())) + if (SchemeRegistry::shouldTreatURLSchemeAsNotAllowingJavascriptURLs(m_frame->document()->url().protocol())) return; String script = decodeURLEscapeSequences(url.string().substring(strlen("javascript:"))); - ScriptValue result = frame()->script()->executeScript(script, true); + ScriptValue result = m_frame->script()->executeScript(script, true); String scriptResult; if (!result.getString(scriptResult)) return; - if (!frame()->navigationScheduler()->locationChangePending()) - frame()->document()->loader()->writer()->replaceDocument(scriptResult, ownerDocument.get()); -} - -void WebFrameImpl::willDetachPage() -{ - if (!frame() || !frame()->page()) - return; - - // Do not expect string scoping results from any frames that got detached - // in the middle of the operation. - if (m_scopingInProgress) { - - // There is a possibility that the frame being detached was the only - // pending one. We need to make sure final replies can be sent. - flushCurrentScopingEffort(m_findRequestIdentifier); - - cancelPendingScopingEffort(); - } + if (!m_frame->navigationScheduler()->locationChangePending()) + m_frame->document()->loader()->writer()->replaceDocument(scriptResult, ownerDocument.get()); } } // namespace WebKit diff --git a/Source/WebKit/chromium/src/WebFrameImpl.h b/Source/WebKit/chromium/src/WebFrameImpl.h index 2686aad1d..a2fe797e3 100644 --- a/Source/WebKit/chromium/src/WebFrameImpl.h +++ b/Source/WebKit/chromium/src/WebFrameImpl.h @@ -35,7 +35,6 @@ #include "WebFrame.h" #include "Frame.h" -#include "FrameDestructionObserver.h" #include "FrameLoaderClientImpl.h" #include <wtf/Compiler.h> #include <wtf/OwnPtr.h> @@ -70,12 +69,10 @@ struct WebPrintParams; template <typename T> class WebVector; // Implementation of WebFrame, note that this is a reference counted object. -class WebFrameImpl - : public WebFrame - , public RefCounted<WebFrameImpl> - , public WebCore::FrameDestructionObserver { +class WebFrameImpl : public WebFrame, public RefCounted<WebFrameImpl> { public: // WebFrame methods: + virtual WebString name() const; virtual WebString uniqueName() const; virtual WebString assignedName() const; virtual void setName(const WebString&); @@ -243,9 +240,6 @@ public: virtual bool selectionStartHasSpellingMarkerFor(int from, int length) const; virtual WebString layerTreeAsText(bool showDebugInfo = false) const; - // WebCore::FrameDestructionObserver methods. - virtual void willDetachPage(); - static PassRefPtr<WebFrameImpl> create(WebFrameClient* client); virtual ~WebFrameImpl(); @@ -268,7 +262,8 @@ public: WebViewImpl* viewImpl() const; - WebCore::FrameView* frameView() const { return frame() ? frame()->view() : 0; } + WebCore::Frame* frame() const { return m_frame; } + WebCore::FrameView* frameView() const { return m_frame ? m_frame->view() : 0; } // Getters for the impls corresponding to Get(Provisional)DataSource. They // may return 0 if there is no corresponding data source. @@ -330,10 +325,11 @@ private: InvalidateAll // Both content area and the scrollbar. }; - explicit WebFrameImpl(WebFrameClient*); + WebFrameImpl(WebFrameClient*); - // Sets the local WebCore frame and registers destruction observers. - void setWebCoreFrame(WebCore::Frame*); + // Informs the WebFrame that the Frame is being closed, called by the + // WebFrameLoaderClient + void closing(); // Notifies the delegate about a new selection rect. void reportFindInPageSelection( @@ -386,11 +382,6 @@ private: // was searched. bool shouldScopeMatches(const WTF::String& searchText); - // Removes the current frame from the global scoping effort and triggers any - // updates if appropriate. This method does not mark the scoping operation - // as finished. - void flushCurrentScopingEffort(int identifier); - // Finishes the current scoping effort and triggers any updates if appropriate. void finishCurrentScopingEffort(int identifier); @@ -416,6 +407,10 @@ private: WebFrameClient* m_client; + // This is a weak pointer to our corresponding WebCore frame. A reference to + // ourselves is held while frame_ is valid. See our Closing method. + WebCore::Frame* m_frame; + // A way for the main frame to keep track of which frame has an active // match. Should be 0 for all other frames. WebFrameImpl* m_currentActiveMatchFrame; @@ -443,7 +438,8 @@ private: // Keeps track of how many matches this frame has found so far, so that we // don't loose count between scoping efforts, and is also used (in conjunction - // with m_lastSearchString) to figure out if we need to search the frame again. + // with m_lastSearchString and m_scopingComplete) to figure out if we need to + // search the frame again. int m_lastMatchCount; // This variable keeps a cumulative total of matches found so far for ALL the @@ -456,12 +452,9 @@ private: // It should be -1 for all other frames. int m_framesScopingCount; - // Identifier of the latest find-in-page request. Required to be stored in - // the frame in order to reply if required in case the frame is detached. - int m_findRequestIdentifier; - - // Keeps track of whether there is an scoping effort ongoing in the frame. - bool m_scopingInProgress; + // Keeps track of whether the scoping effort was completed (the user may + // interrupt it before it completes by submitting a new search). + bool m_scopingComplete; // Keeps track of whether the last find request completed its scoping effort // without finding any matches in this frame. diff --git a/Source/WebKit/chromium/src/WebGeolocationClientMock.cpp b/Source/WebKit/chromium/src/WebGeolocationClientMock.cpp index 21021ed37..a7948a78e 100644 --- a/Source/WebKit/chromium/src/WebGeolocationClientMock.cpp +++ b/Source/WebKit/chromium/src/WebGeolocationClientMock.cpp @@ -41,7 +41,7 @@ #include "WebGeolocationError.h" #include "WebGeolocationPermissionRequest.h" #include "WebGeolocationPosition.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebGeolocationError.cpp b/Source/WebKit/chromium/src/WebGeolocationError.cpp index aa6e0d7fc..3869468c8 100644 --- a/Source/WebKit/chromium/src/WebGeolocationError.cpp +++ b/Source/WebKit/chromium/src/WebGeolocationError.cpp @@ -27,7 +27,7 @@ #include "WebGeolocationError.h" #include "GeolocationError.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebGeolocationPermissionRequest.cpp b/Source/WebKit/chromium/src/WebGeolocationPermissionRequest.cpp index 533f6bc11..6d7ec631a 100644 --- a/Source/WebKit/chromium/src/WebGeolocationPermissionRequest.cpp +++ b/Source/WebKit/chromium/src/WebGeolocationPermissionRequest.cpp @@ -31,7 +31,7 @@ #include "Geolocation.h" #include "SecurityOrigin.h" #include "WebSecurityOrigin.h" -#include <public/WebURL.h> +#include "platform/WebURL.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebGeolocationPermissionRequestManager.cpp b/Source/WebKit/chromium/src/WebGeolocationPermissionRequestManager.cpp index 1eeac667b..4c0ed9cd7 100644 --- a/Source/WebKit/chromium/src/WebGeolocationPermissionRequestManager.cpp +++ b/Source/WebKit/chromium/src/WebGeolocationPermissionRequestManager.cpp @@ -64,7 +64,7 @@ bool WebGeolocationPermissionRequestManager::remove(const WebKit::WebGeolocation GeolocationIdMap::iterator it = m_private->m_geolocationIdMap.find(geolocation); if (it == m_private->m_geolocationIdMap.end()) return false; - id = it->value; + id = it->second; m_private->m_geolocationIdMap.remove(it); m_private->m_idGeolocationMap.remove(id); return true; @@ -75,7 +75,7 @@ bool WebGeolocationPermissionRequestManager::remove(int id, WebKit::WebGeolocati IdGeolocationMap::iterator it = m_private->m_idGeolocationMap.find(id); if (it == m_private->m_idGeolocationMap.end()) return false; - Geolocation* geolocation = it->value; + Geolocation* geolocation = it->second; permissionRequest = WebGeolocationPermissionRequest(geolocation); m_private->m_idGeolocationMap.remove(it); m_private->m_geolocationIdMap.remove(geolocation); diff --git a/Source/WebKit/chromium/src/WebHistoryItem.cpp b/Source/WebKit/chromium/src/WebHistoryItem.cpp index 976594c9c..31d2bd564 100644 --- a/Source/WebKit/chromium/src/WebHistoryItem.cpp +++ b/Source/WebKit/chromium/src/WebHistoryItem.cpp @@ -36,11 +36,12 @@ #include "HistoryItem.h" #include "KURL.h" #include "SerializedScriptValue.h" + +#include "platform/WebHTTPBody.h" +#include "platform/WebPoint.h" #include "platform/WebSerializedScriptValue.h" -#include <public/WebHTTPBody.h> -#include <public/WebPoint.h> -#include <public/WebString.h> -#include <public/WebVector.h> +#include "platform/WebString.h" +#include "platform/WebVector.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebHitTestResult.cpp b/Source/WebKit/chromium/src/WebHitTestResult.cpp index a839fb63e..5f806b80c 100644 --- a/Source/WebKit/chromium/src/WebHitTestResult.cpp +++ b/Source/WebKit/chromium/src/WebHitTestResult.cpp @@ -33,7 +33,8 @@ #include "RenderObject.h" #include "VisiblePosition.h" #include "WebNode.h" -#include <public/WebPoint.h> + +#include "platform/WebPoint.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp b/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp index e71029deb..b58cd5111 100644 --- a/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp +++ b/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp @@ -60,9 +60,9 @@ WebIDBMetadata WebIDBDatabaseImpl::metadata() const return m_databaseBackend->metadata(); } -WebIDBObjectStore* WebIDBDatabaseImpl::createObjectStore(long long id, const WebString& name, const WebIDBKeyPath& keyPath, bool autoIncrement, const WebIDBTransaction& transaction, WebExceptionCode& ec) +WebIDBObjectStore* WebIDBDatabaseImpl::createObjectStore(const WebString& name, const WebIDBKeyPath& keyPath, bool autoIncrement, const WebIDBTransaction& transaction, WebExceptionCode& ec) { - RefPtr<IDBObjectStoreBackendInterface> objectStore = m_databaseBackend->createObjectStore(id, name, keyPath, autoIncrement, transaction.getIDBTransactionBackendInterface(), ec); + RefPtr<IDBObjectStoreBackendInterface> objectStore = m_databaseBackend->createObjectStore(name, keyPath, autoIncrement, transaction.getIDBTransactionBackendInterface(), ec); if (!objectStore) { ASSERT(ec); return 0; diff --git a/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h b/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h index 769bdf5d0..518ffcdb9 100644 --- a/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h +++ b/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h @@ -52,7 +52,7 @@ public: virtual WebIDBMetadata metadata() const; - virtual WebIDBObjectStore* createObjectStore(long long, const WebString& name, const WebIDBKeyPath&, bool autoIncrement, const WebIDBTransaction&, WebExceptionCode&); + virtual WebIDBObjectStore* createObjectStore(const WebString& name, const WebIDBKeyPath&, bool autoIncrement, const WebIDBTransaction&, WebExceptionCode&); virtual void deleteObjectStore(const WebString& name, const WebIDBTransaction&, WebExceptionCode&); virtual void setVersion(const WebString& version, WebIDBCallbacks*, WebExceptionCode&); virtual WebIDBTransaction* transaction(const WebDOMStringList& names, unsigned short mode, WebExceptionCode&); diff --git a/Source/WebKit/chromium/src/WebIDBKeyPath.cpp b/Source/WebKit/chromium/src/WebIDBKeyPath.cpp index c78b3d98e..b094e77bd 100644 --- a/Source/WebKit/chromium/src/WebIDBKeyPath.cpp +++ b/Source/WebKit/chromium/src/WebIDBKeyPath.cpp @@ -30,7 +30,7 @@ #include "IDBKeyPath.h" #include "platform/WebString.h" -#include <public/WebVector.h> +#include "platform/WebVector.h" #include <wtf/Vector.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebIDBMetadata.cpp b/Source/WebKit/chromium/src/WebIDBMetadata.cpp index dd1c2c8e5..01d878a0a 100644 --- a/Source/WebKit/chromium/src/WebIDBMetadata.cpp +++ b/Source/WebKit/chromium/src/WebIDBMetadata.cpp @@ -31,7 +31,7 @@ #include "IDBMetadata.h" #include "WebIDBKeyPath.h" #include "platform/WebString.h" -#include <public/WebVector.h> +#include "platform/WebVector.h" using namespace WebCore; @@ -43,21 +43,19 @@ WebIDBMetadata::WebIDBMetadata(const WebCore::IDBDatabaseMetadata& metadata) version = metadata.version; intVersion = metadata.intVersion; objectStores = WebVector<ObjectStore>(static_cast<size_t>(metadata.objectStores.size())); - maxObjectStoreId = metadata.maxObjectStoreId; size_t i = 0; for (IDBDatabaseMetadata::ObjectStoreMap::const_iterator storeIterator = metadata.objectStores.begin(); storeIterator != metadata.objectStores.end(); ++storeIterator) { - const IDBObjectStoreMetadata& objectStore = storeIterator->value; + const IDBObjectStoreMetadata& objectStore = storeIterator->second; ObjectStore webObjectStore; webObjectStore.name = objectStore.name; webObjectStore.keyPath = objectStore.keyPath; webObjectStore.autoIncrement = objectStore.autoIncrement; webObjectStore.indexes = WebVector<Index>(static_cast<size_t>(objectStore.indexes.size())); - webObjectStore.maxIndexId = objectStore.maxIndexId; size_t j = 0; for (IDBObjectStoreMetadata::IndexMap::const_iterator indexIterator = objectStore.indexes.begin(); indexIterator != objectStore.indexes.end(); ++indexIterator) { - const IDBIndexMetadata& index = indexIterator->value; + const IDBIndexMetadata& index = indexIterator->second; Index webIndex; webIndex.name = index.name; webIndex.keyPath = index.keyPath; @@ -71,14 +69,14 @@ WebIDBMetadata::WebIDBMetadata(const WebCore::IDBDatabaseMetadata& metadata) WebIDBMetadata::operator IDBDatabaseMetadata() const { - IDBDatabaseMetadata db(name, id, version, intVersion, maxObjectStoreId); + IDBDatabaseMetadata db(name, version, intVersion); for (size_t i = 0; i < objectStores.size(); ++i) { const ObjectStore webObjectStore = objectStores[i]; - IDBObjectStoreMetadata objectStore(webObjectStore.name, webObjectStore.id, webObjectStore.keyPath, webObjectStore.autoIncrement, webObjectStore.maxIndexId); + IDBObjectStoreMetadata objectStore(webObjectStore.name, webObjectStore.keyPath, webObjectStore.autoIncrement); for (size_t j = 0; j < webObjectStore.indexes.size(); ++j) { const Index webIndex = webObjectStore.indexes[j]; - IDBIndexMetadata index(webIndex.name, webIndex.id, webIndex.keyPath, webIndex.unique, webIndex.multiEntry); + IDBIndexMetadata index(webIndex.name, webIndex.keyPath, webIndex.unique, webIndex.multiEntry); objectStore.indexes.set(index.name, index); } db.objectStores.set(objectStore.name, objectStore); diff --git a/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp b/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp index d814093f0..f5dd913c9 100755 --- a/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp +++ b/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp @@ -109,9 +109,9 @@ void WebIDBObjectStoreImpl::clear(WebIDBCallbacks* callbacks, const WebIDBTransa m_objectStore->clear(IDBCallbacksProxy::create(adoptPtr(callbacks)), transaction.getIDBTransactionBackendInterface(), ec); } -WebIDBIndex* WebIDBObjectStoreImpl::createIndex(long long id, const WebString& name, const WebIDBKeyPath& keyPath, bool unique, bool multiEntry, const WebIDBTransaction& transaction, WebExceptionCode& ec) +WebIDBIndex* WebIDBObjectStoreImpl::createIndex(const WebString& name, const WebIDBKeyPath& keyPath, bool unique, bool multiEntry, const WebIDBTransaction& transaction, WebExceptionCode& ec) { - RefPtr<IDBIndexBackendInterface> index = m_objectStore->createIndex(id, name, keyPath, unique, multiEntry, transaction.getIDBTransactionBackendInterface(), ec); + RefPtr<IDBIndexBackendInterface> index = m_objectStore->createIndex(name, keyPath, unique, multiEntry, transaction.getIDBTransactionBackendInterface(), ec); if (!index) return 0; return new WebIDBIndexImpl(index); diff --git a/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h b/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h index 7e9ed2573..04020e558 100644 --- a/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h +++ b/Source/WebKit/chromium/src/WebIDBObjectStoreImpl.h @@ -52,7 +52,7 @@ public: void deleteFunction(const WebIDBKeyRange&, WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&); void clear(WebIDBCallbacks*, const WebIDBTransaction&, WebExceptionCode&); - WebIDBIndex* createIndex(long long, const WebString& name, const WebIDBKeyPath&, bool unique, bool multiEntry, const WebIDBTransaction&, WebExceptionCode&); + WebIDBIndex* createIndex(const WebString& name, const WebIDBKeyPath&, bool unique, bool multiEntry, const WebIDBTransaction&, WebExceptionCode&); WebIDBIndex* index(const WebString& name, WebExceptionCode&); void deleteIndex(const WebString& name, const WebIDBTransaction&, WebExceptionCode&); diff --git a/Source/WebKit/chromium/src/WebIDBTransactionImpl.h b/Source/WebKit/chromium/src/WebIDBTransactionImpl.h index 66e315300..323e2be59 100644 --- a/Source/WebKit/chromium/src/WebIDBTransactionImpl.h +++ b/Source/WebKit/chromium/src/WebIDBTransactionImpl.h @@ -28,8 +28,8 @@ #if ENABLE(INDEXED_DATABASE) +#include "platform/WebCommon.h" #include "WebIDBTransaction.h" -#include <public/WebCommon.h> #include <wtf/PassRefPtr.h> #include <wtf/RefPtr.h> diff --git a/Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h b/Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h index 305db8f3c..d6d66db56 100644 --- a/Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h +++ b/Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h @@ -32,8 +32,8 @@ #define WebIconLoadingCompletionImpl_h #include "FileIconLoader.h" +#include "platform/WebData.h" #include "WebIconLoadingCompletion.h" -#include <public/WebData.h> #include <wtf/PassRefPtr.h> #include <wtf/RefPtr.h> diff --git a/Source/WebKit/chromium/src/WebImageDecoder.cpp b/Source/WebKit/chromium/src/WebImageDecoder.cpp index 104ab13fb..ad0a67e51 100644 --- a/Source/WebKit/chromium/src/WebImageDecoder.cpp +++ b/Source/WebKit/chromium/src/WebImageDecoder.cpp @@ -34,11 +34,14 @@ #include "BMPImageDecoder.h" #include "ICOImageDecoder.h" #include "SharedBuffer.h" -#include <public/WebData.h> +#include "platform/WebData.h" +#include "platform/WebSize.h" + #include <public/WebImage.h> -#include <public/WebSize.h> + #include <wtf/OwnPtr.h> #include <wtf/PassOwnPtr.h> + #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebImageSkia.cpp b/Source/WebKit/chromium/src/WebImageSkia.cpp index 9e92f3189..0198a6806 100644 --- a/Source/WebKit/chromium/src/WebImageSkia.cpp +++ b/Source/WebKit/chromium/src/WebImageSkia.cpp @@ -34,10 +34,12 @@ #include "ImageDecoder.h" #include "NativeImageSkia.h" #include "SharedBuffer.h" + +#include "platform/WebData.h" +#include "platform/WebSize.h" + #include <algorithm> -#include <public/WebData.h> #include <public/WebImage.h> -#include <public/WebSize.h> #include <wtf/OwnPtr.h> #include <wtf/PassOwnPtr.h> #include <wtf/PassRefPtr.h> @@ -123,7 +125,7 @@ WebVector<WebImage> WebImage::framesFromData(const WebData& data) continue; OwnPtr<NativeImageSkia> image = adoptPtr(frame->asNewNativeImage()); - if (image.get() && image->isDataComplete()) + if (image.get()) frames.append(WebImage(image->bitmap())); } diff --git a/Source/WebKit/chromium/src/WebInputElement.cpp b/Source/WebKit/chromium/src/WebInputElement.cpp index bdc9f5db2..791b2ebff 100644 --- a/Source/WebKit/chromium/src/WebInputElement.cpp +++ b/Source/WebKit/chromium/src/WebInputElement.cpp @@ -41,7 +41,7 @@ #include "TextFieldDecoratorImpl.h" #include "WebNodeCollection.h" #include "WebTextFieldDecoratorClient.h" -#include <public/WebString.h> +#include "platform/WebString.h" #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebInputEventConversion.cpp b/Source/WebKit/chromium/src/WebInputEventConversion.cpp index 0f4f6d5a8..0cc1e0c24 100644 --- a/Source/WebKit/chromium/src/WebInputEventConversion.cpp +++ b/Source/WebKit/chromium/src/WebInputEventConversion.cpp @@ -39,7 +39,6 @@ #include "PlatformKeyboardEvent.h" #include "PlatformMouseEvent.h" #include "PlatformWheelEvent.h" -#include "RenderObject.h" #include "ScrollView.h" #include "Touch.h" #include "TouchEvent.h" @@ -208,7 +207,7 @@ PlatformGestureEventBuilder::PlatformGestureEventBuilder(Widget* widget, const W // MakePlatformKeyboardEvent -------------------------------------------------- -inline PlatformEvent::Type toPlatformKeyboardEventType(WebInputEvent::Type type) +static inline PlatformEvent::Type toPlatformKeyboardEventType(WebInputEvent::Type type) { switch (type) { case WebInputEvent::KeyUp: @@ -301,7 +300,7 @@ bool PlatformKeyboardEventBuilder::isCharacterKey() const } #if ENABLE(TOUCH_EVENTS) -inline PlatformEvent::Type toPlatformTouchEventType(const WebInputEvent::Type type) +static inline PlatformEvent::Type toPlatformTouchEventType(const WebInputEvent::Type type) { switch (type) { case WebInputEvent::TouchStart: @@ -318,7 +317,7 @@ inline PlatformEvent::Type toPlatformTouchEventType(const WebInputEvent::Type ty return PlatformEvent::TouchStart; } -inline PlatformTouchPoint::State toPlatformTouchPointState(const WebTouchPoint::State state) +static inline PlatformTouchPoint::State toPlatformTouchPointState(const WebTouchPoint::State state) { switch (state) { case WebTouchPoint::StateReleased: @@ -337,19 +336,6 @@ inline PlatformTouchPoint::State toPlatformTouchPointState(const WebTouchPoint:: return PlatformTouchPoint::TouchReleased; } -inline WebTouchPoint::State toWebTouchPointState(const AtomicString& type) -{ - if (type == eventNames().touchendEvent) - return WebTouchPoint::StateReleased; - if (type == eventNames().touchcancelEvent) - return WebTouchPoint::StateCancelled; - if (type == eventNames().touchstartEvent) - return WebTouchPoint::StatePressed; - if (type == eventNames().touchmoveEvent) - return WebTouchPoint::StateMoved; - return WebTouchPoint::StateUndefined; -} - PlatformTouchPointBuilder::PlatformTouchPointBuilder(Widget* widget, const WebTouchPoint& point) { m_id = point.id; @@ -397,28 +383,7 @@ static int getWebInputModifiers(const UIEventWithKeyState& event) return modifiers; } -static IntPoint convertLocationForRenderObject(const LayoutPoint& location, const WebCore::RenderObject& renderObject) -{ - return roundedIntPoint(renderObject.absoluteToLocal(location, UseTransforms | SnapOffsetForTransforms)); -} - -static void updateWebMouseEventFromWebCoreMouseEvent(const MouseEvent& event, const Widget& widget, const WebCore::RenderObject& renderObject, WebMouseEvent& webEvent) -{ - webEvent.timeStampSeconds = event.timeStamp() / millisPerSecond; - webEvent.modifiers = getWebInputModifiers(event); - - ScrollView* view = widget.parent(); - IntPoint windowPoint = view->contentsToWindow(IntPoint(event.absoluteLocation().x(), event.absoluteLocation().y())); - webEvent.globalX = event.screenX(); - webEvent.globalY = event.screenY(); - webEvent.windowX = windowPoint.x(); - webEvent.windowY = windowPoint.y(); - IntPoint localPoint = convertLocationForRenderObject(event.absoluteLocation(), renderObject); - webEvent.x = localPoint.x(); - webEvent.y = localPoint.y(); -} - -WebMouseEventBuilder::WebMouseEventBuilder(const Widget* widget, const WebCore::RenderObject* renderObject, const MouseEvent& event) +WebMouseEventBuilder::WebMouseEventBuilder(const Widget* widget, const MouseEvent& event) { if (event.type() == eventNames().mousemoveEvent) type = WebInputEvent::MouseMove; @@ -434,9 +399,7 @@ WebMouseEventBuilder::WebMouseEventBuilder(const Widget* widget, const WebCore:: type = WebInputEvent::ContextMenu; else return; // Skip all other mouse events. - - updateWebMouseEventFromWebCoreMouseEvent(event, *widget, *renderObject, *this); - + timeStampSeconds = event.timeStamp() / millisPerSecond; switch (event.button()) { case LeftButton: button = WebMouseEvent::ButtonLeft; @@ -448,6 +411,7 @@ WebMouseEventBuilder::WebMouseEventBuilder(const Widget* widget, const WebCore:: button = WebMouseEvent::ButtonRight; break; } + modifiers = getWebInputModifiers(event); if (event.buttonDown()) { switch (event.button()) { case LeftButton: @@ -461,6 +425,15 @@ WebMouseEventBuilder::WebMouseEventBuilder(const Widget* widget, const WebCore:: break; } } + ScrollView* view = widget->parent(); + IntPoint p = view->contentsToWindow( + IntPoint(event.absoluteLocation().x(), event.absoluteLocation().y())); + globalX = event.screenX(); + globalY = event.screenY(); + windowX = p.x(); + windowY = p.y(); + x = event.absoluteLocation().x() - widget->location().x(); + y = event.absoluteLocation().y() - widget->location().y(); #if ENABLE(POINTER_LOCK) movementX = event.webkitMovementX(); movementY = event.webkitMovementY(); @@ -468,12 +441,22 @@ WebMouseEventBuilder::WebMouseEventBuilder(const Widget* widget, const WebCore:: clickCount = event.detail(); } -WebMouseWheelEventBuilder::WebMouseWheelEventBuilder(const Widget* widget, const WebCore::RenderObject* renderObject, const WheelEvent& event) +WebMouseWheelEventBuilder::WebMouseWheelEventBuilder(const Widget* widget, const WheelEvent& event) { if (event.type() != eventNames().mousewheelEvent) return; type = WebInputEvent::MouseWheel; - updateWebMouseEventFromWebCoreMouseEvent(event, *widget, *renderObject, *this); + timeStampSeconds = event.timeStamp() / millisPerSecond; + modifiers = getWebInputModifiers(event); + ScrollView* view = widget->parent(); + IntPoint p = view->contentsToWindow( + IntPoint(event.absoluteLocation().x(), event.absoluteLocation().y())); + globalX = event.screenX(); + globalY = event.screenY(); + windowX = p.x(); + windowY = p.y(); + x = event.absoluteLocation().x() - widget->location().x(); + y = event.absoluteLocation().y() - widget->location().y(); deltaX = static_cast<float>(event.rawDeltaX()); deltaY = static_cast<float>(event.rawDeltaY()); // The 120 is from WheelEvent::initWheelEvent(). @@ -519,7 +502,7 @@ WebKeyboardEventBuilder::WebKeyboardEventBuilder(const KeyboardEvent& event) #if ENABLE(TOUCH_EVENTS) -static void addTouchPoints(const AtomicString& touchType, TouchList* touches, WebTouchPoint* touchPoints, unsigned* touchPointsLength, const WebCore::RenderObject* renderObject) +static void addTouchPoints(TouchList* touches, const IntPoint& offset, WebTouchPoint* touchPoints, unsigned* touchPointsLength) { unsigned numberOfTouches = std::min(touches->length(), static_cast<unsigned>(WebTouchEvent::touchesLengthCap)); for (unsigned i = 0; i < numberOfTouches; ++i) { @@ -528,19 +511,18 @@ static void addTouchPoints(const AtomicString& touchType, TouchList* touches, We WebTouchPoint point; point.id = touch->identifier(); point.screenPosition = WebPoint(touch->screenX(), touch->screenY()); - point.position = convertLocationForRenderObject(LayoutPoint(IntPoint(touch->pageX(), touch->pageY())), *renderObject); + point.position = WebPoint(touch->pageX() - offset.x(), touch->pageY() - offset.y()); point.radiusX = touch->webkitRadiusX(); point.radiusY = touch->webkitRadiusY(); point.rotationAngle = touch->webkitRotationAngle(); point.force = touch->webkitForce(); - point.state = toWebTouchPointState(touchType); touchPoints[i] = point; } *touchPointsLength = numberOfTouches; } -WebTouchEventBuilder::WebTouchEventBuilder(const Widget* widget, const WebCore::RenderObject* renderObject, const TouchEvent& event) +WebTouchEventBuilder::WebTouchEventBuilder(const Widget* widget, const TouchEvent& event) { if (event.type() == eventNames().touchstartEvent) type = TouchStart; @@ -559,15 +541,15 @@ WebTouchEventBuilder::WebTouchEventBuilder(const Widget* widget, const WebCore:: modifiers = getWebInputModifiers(event); timeStampSeconds = event.timeStamp() / millisPerSecond; - addTouchPoints(event.type(), event.touches(), touches, &touchesLength, renderObject); - addTouchPoints(event.type(), event.changedTouches(), changedTouches, &changedTouchesLength, renderObject); - addTouchPoints(event.type(), event.targetTouches(), targetTouches, &targetTouchesLength, renderObject); + addTouchPoints(event.touches(), widget->location(), touches, &touchesLength); + addTouchPoints(event.changedTouches(), widget->location(), changedTouches, &changedTouchesLength); + addTouchPoints(event.targetTouches(), widget->location(), targetTouches, &targetTouchesLength); } #endif // ENABLE(TOUCH_EVENTS) #if ENABLE(GESTURE_EVENTS) -WebGestureEventBuilder::WebGestureEventBuilder(const Widget* widget, const WebCore::RenderObject* renderObject, const GestureEvent& event) +WebGestureEventBuilder::WebGestureEventBuilder(const Widget* widget, const GestureEvent& event) { if (event.type() == eventNames().gesturetapEvent) type = GestureTap; @@ -588,9 +570,8 @@ WebGestureEventBuilder::WebGestureEventBuilder(const Widget* widget, const WebCo globalX = event.screenX(); globalY = event.screenY(); - IntPoint localPoint = convertLocationForRenderObject(event.absoluteLocation(), *renderObject); - x = localPoint.x(); - y = localPoint.y(); + x = event.absoluteLocation().x() - widget->location().x(); + y = event.absoluteLocation().y() - widget->location().y(); } #endif // ENABLE(GESTURE_EVENTS) diff --git a/Source/WebKit/chromium/src/WebInputEventConversion.h b/Source/WebKit/chromium/src/WebInputEventConversion.h index 3512646eb..48975a404 100644 --- a/Source/WebKit/chromium/src/WebInputEventConversion.h +++ b/Source/WebKit/chromium/src/WebInputEventConversion.h @@ -42,10 +42,9 @@ namespace WebCore { class GestureEvent; class KeyboardEvent; class MouseEvent; -class RenderObject; class ScrollView; -class TouchEvent; class WheelEvent; +class TouchEvent; class Widget; } @@ -98,20 +97,21 @@ public: }; #endif -// Converts a WebCore::MouseEvent to a corresponding WebMouseEvent. +// Converts a WebCore::MouseEvent to a corresponding WebMouseEvent. view is +// the ScrollView corresponding to the event. // NOTE: This is only implemented for mousemove, mouseover, mouseout, // mousedown and mouseup. If the event mapping fails, the event type will // be set to Undefined. class WebMouseEventBuilder : public WebMouseEvent { public: - WebMouseEventBuilder(const WebCore::Widget*, const WebCore::RenderObject*, const WebCore::MouseEvent&); + WebMouseEventBuilder(const WebCore::Widget*, const WebCore::MouseEvent&); }; // Converts a WebCore::WheelEvent to a corresponding WebMouseWheelEvent. // If the event mapping fails, the event type will be set to Undefined. class WebMouseWheelEventBuilder : public WebMouseWheelEvent { public: - WebMouseWheelEventBuilder(const WebCore::Widget*, const WebCore::RenderObject*, const WebCore::WheelEvent&); + WebMouseWheelEventBuilder(const WebCore::Widget*, const WebCore::WheelEvent&); }; // Converts a WebCore::KeyboardEvent to a corresponding WebKeyboardEvent. @@ -128,7 +128,7 @@ public: // exceeding that cap will be dropped. class WebTouchEventBuilder : public WebTouchEvent { public: - WebTouchEventBuilder(const WebCore::Widget*, const WebCore::RenderObject*, const WebCore::TouchEvent&); + WebTouchEventBuilder(const WebCore::Widget*, const WebCore::TouchEvent&); }; #endif // ENABLE(TOUCH_EVENTS) @@ -137,7 +137,7 @@ public: // NOTE: If event mapping fails, the type will be set to Undefined. class WebGestureEventBuilder : public WebGestureEvent { public: - WebGestureEventBuilder(const WebCore::Widget*, const WebCore::RenderObject*, const WebCore::GestureEvent&); + WebGestureEventBuilder(const WebCore::Widget*, const WebCore::GestureEvent&); }; #endif // ENABLE(GESTURE_EVENTS) diff --git a/Source/WebKit/chromium/src/WebIntent.cpp b/Source/WebKit/chromium/src/WebIntent.cpp index 041c7f2e9..55775ecfc 100644 --- a/Source/WebKit/chromium/src/WebIntent.cpp +++ b/Source/WebKit/chromium/src/WebIntent.cpp @@ -188,7 +188,7 @@ WebString WebIntent::extrasValue(const WebString& name) const WTF::HashMap<String, String>::const_iterator val = m_private->extras().find(name); if (val == m_private->extras().end()) return WebString(); - return val->value; + return val->second; #else return WebString(); #endif diff --git a/Source/WebKit/chromium/src/WebKit.cpp b/Source/WebKit/chromium/src/WebKit.cpp index e357f28e4..9331d053a 100644 --- a/Source/WebKit/chromium/src/WebKit.cpp +++ b/Source/WebKit/chromium/src/WebKit.cpp @@ -44,10 +44,10 @@ #include "WebSocket.h" #include "WorkerContextExecutionProxy.h" #include "platform/WebKitPlatformSupport.h" +#include "platform/WebThread.h" #include "v8.h" #include <public/Platform.h> #include <public/WebPrerenderingSupport.h> -#include <public/WebThread.h> #include <wtf/Assertions.h> #include <wtf/MainThread.h> #include <wtf/Threading.h> diff --git a/Source/WebKit/chromium/src/WebLabelElement.cpp b/Source/WebKit/chromium/src/WebLabelElement.cpp index 4480ae89d..15ef3bbe3 100644 --- a/Source/WebKit/chromium/src/WebLabelElement.cpp +++ b/Source/WebKit/chromium/src/WebLabelElement.cpp @@ -33,7 +33,7 @@ #include "HTMLLabelElement.h" #include "HTMLNames.h" -#include <public/WebString.h> +#include "platform/WebString.h" #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp b/Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp index d1ad60620..7ec559d24 100644 --- a/Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp +++ b/Source/WebKit/chromium/src/WebMediaStreamRegistry.cpp @@ -37,9 +37,9 @@ #include "KURL.h" #include "MediaStreamDescriptor.h" #include "MediaStreamRegistry.h" -#include <public/WebMediaStreamDescriptor.h> -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebMediaStreamDescriptor.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebNode.cpp b/Source/WebKit/chromium/src/WebNode.cpp index 27d57cfbc..c5e836d4a 100644 --- a/Source/WebKit/chromium/src/WebNode.cpp +++ b/Source/WebKit/chromium/src/WebNode.cpp @@ -37,6 +37,7 @@ #include "FrameLoaderClientImpl.h" #include "Node.h" #include "NodeList.h" + #include "EventListenerWrapper.h" #include "WebDOMEvent.h" #include "WebDOMEventListener.h" @@ -44,9 +45,10 @@ #include "WebElement.h" #include "WebFrameImpl.h" #include "WebNodeList.h" +#include "platform/WebString.h" +#include "platform/WebVector.h" + #include "markup.h" -#include <public/WebString.h> -#include <public/WebVector.h> using namespace WebCore; @@ -223,13 +225,6 @@ bool WebNode::focused() const return m_private->focused(); } -bool WebNode::remove() -{ - ExceptionCode exceptionCode = 0; - m_private->remove(exceptionCode); - return !exceptionCode; -} - bool WebNode::hasNonEmptyBoundingBox() const { m_private->document()->updateLayoutIgnorePendingStylesheets(); diff --git a/Source/WebKit/chromium/src/WebNotification.cpp b/Source/WebKit/chromium/src/WebNotification.cpp index c8fe815c4..54209fd97 100644 --- a/Source/WebKit/chromium/src/WebNotification.cpp +++ b/Source/WebKit/chromium/src/WebNotification.cpp @@ -37,9 +37,11 @@ #include "Notification.h" #include "UserGestureIndicator.h" #include "WindowFocusAllowedIndicator.h" + +#include "platform/WebString.h" #include "WebTextDirection.h" -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebURL.h" + #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebOptionElement.cpp b/Source/WebKit/chromium/src/WebOptionElement.cpp index b511697b4..1d50a053e 100644 --- a/Source/WebKit/chromium/src/WebOptionElement.cpp +++ b/Source/WebKit/chromium/src/WebOptionElement.cpp @@ -34,7 +34,7 @@ #include "HTMLNames.h" #include "HTMLOptionElement.h" #include "HTMLSelectElement.h" -#include <public/WebString.h> +#include "platform/WebString.h" #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebPagePopupImpl.cpp b/Source/WebKit/chromium/src/WebPagePopupImpl.cpp index e4808fd70..1e0fcebb5 100644 --- a/Source/WebKit/chromium/src/WebPagePopupImpl.cpp +++ b/Source/WebKit/chromium/src/WebPagePopupImpl.cpp @@ -151,14 +151,15 @@ WebPagePopupImpl::~WebPagePopupImpl() ASSERT(!m_page); } -bool WebPagePopupImpl::init(WebViewImpl* webView, PagePopupClient* popupClient, const IntRect&) +bool WebPagePopupImpl::init(WebViewImpl* webView, PagePopupClient* popupClient, const IntRect& originBoundsInRootView) { ASSERT(webView); ASSERT(popupClient); m_webView = webView; m_popupClient = popupClient; + m_originBoundsInRootView = originBoundsInRootView; - resize(m_popupClient->contentSize()); + reposition(m_popupClient->contentSize()); if (!initPage()) return false; @@ -232,10 +233,22 @@ void WebPagePopupImpl::paint(WebCanvas* canvas, const WebRect& rect, PaintOption PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect, PageWidgetDelegate::Opaque); } +void WebPagePopupImpl::reposition(const WebSize& popupSize) +{ + WebSize rootViewSize = m_webView->size(); + IntRect popupBoundsInRootView(IntPoint(max(0, m_originBoundsInRootView.x()), max(0, m_originBoundsInRootView.maxY())), popupSize); + if (popupBoundsInRootView.maxY() > rootViewSize.height) + popupBoundsInRootView.setY(max(0, m_originBoundsInRootView.y() - popupSize.height)); + if (popupBoundsInRootView.maxX() > rootViewSize.width) + popupBoundsInRootView.setX(max(0, rootViewSize.width - popupSize.width)); + IntRect boundsInScreen = m_webView->page()->chrome()->rootViewToScreen(popupBoundsInRootView); + m_widgetClient->setWindowRect(boundsInScreen); + m_windowRectInScreen = boundsInScreen; +} + void WebPagePopupImpl::resize(const WebSize& newSize) { - m_windowRectInScreen = WebRect(m_windowRectInScreen.x, m_windowRectInScreen.y, newSize.width, newSize.height); - m_widgetClient->setWindowRect(m_windowRectInScreen); + reposition(newSize); if (m_page) m_page->mainFrame()->view()->resize(newSize); diff --git a/Source/WebKit/chromium/src/WebPagePopupImpl.h b/Source/WebKit/chromium/src/WebPagePopupImpl.h index cf2bbba78..e6844bfd0 100644 --- a/Source/WebKit/chromium/src/WebPagePopupImpl.h +++ b/Source/WebKit/chromium/src/WebPagePopupImpl.h @@ -87,9 +87,11 @@ private: explicit WebPagePopupImpl(WebWidgetClient*); bool initPage(); + void reposition(const WebSize&); WebWidgetClient* m_widgetClient; WebRect m_windowRectInScreen; + WebCore::IntRect m_originBoundsInRootView; WebViewImpl* m_webView; OwnPtr<WebCore::Page> m_page; OwnPtr<PagePopupChromeClient> m_chromeClient; diff --git a/Source/WebKit/chromium/src/WebPageSerializer.cpp b/Source/WebKit/chromium/src/WebPageSerializer.cpp index 6b4a4cbd3..1d771fb00 100644 --- a/Source/WebKit/chromium/src/WebPageSerializer.cpp +++ b/Source/WebKit/chromium/src/WebPageSerializer.cpp @@ -41,16 +41,17 @@ #include "KURL.h" #include "MHTMLArchive.h" #include "PageSerializer.h" +#include "platform/WebCString.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" +#include "platform/WebVector.h" #include "WebFrame.h" #include "WebFrameImpl.h" #include "WebPageSerializerClient.h" #include "WebPageSerializerImpl.h" #include "WebView.h" #include "WebViewImpl.h" -#include <public/WebCString.h> -#include <public/WebString.h> -#include <public/WebURL.h> -#include <public/WebVector.h> + #include <wtf/Vector.h> #include <wtf/text/StringConcatenate.h> diff --git a/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp b/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp index b03fbfc67..02a665a11 100644 --- a/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp +++ b/Source/WebKit/chromium/src/WebPageSerializerImpl.cpp @@ -91,10 +91,11 @@ #include "KURL.h" #include "TextEncoding.h" #include "markup.h" + #include "DOMUtilitiesPrivate.h" #include "WebFrameImpl.h" -#include <public/WebURL.h> -#include <public/WebVector.h> +#include "platform/WebURL.h" +#include "platform/WebVector.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebPageSerializerImpl.h b/Source/WebKit/chromium/src/WebPageSerializerImpl.h index e6cb9d735..acc5b8102 100644 --- a/Source/WebKit/chromium/src/WebPageSerializerImpl.h +++ b/Source/WebKit/chromium/src/WebPageSerializerImpl.h @@ -41,8 +41,8 @@ #include "WebEntities.h" #include "WebPageSerializer.h" #include "WebPageSerializerClient.h" -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebString.h" +#include "platform/WebURL.h" namespace WebCore { class Document; diff --git a/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp b/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp index 689154058..5c164319e 100644 --- a/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp +++ b/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp @@ -33,7 +33,6 @@ #include "Chrome.h" #include "ChromeClientImpl.h" -#include "ClipboardChromium.h" #include "ScrollbarGroup.h" #include "WebCursorInfo.h" #include "WebDataSourceImpl.h" @@ -74,7 +73,6 @@ #include <public/Platform.h> #include <public/WebClipboard.h> #include <public/WebCompositorSupport.h> -#include <public/WebDragData.h> #include <public/WebExternalTextureLayer.h> #include <public/WebRect.h> #include <public/WebString.h> @@ -117,13 +115,8 @@ void WebPluginContainerImpl::paint(GraphicsContext* gc, const IntRect& damageRec if (!parent()) return; - FloatRect scaledDamageRect = damageRect; - float frameScaleFactor = m_element->document()->page()->mainFrame()->frameScaleFactor(); - scaledDamageRect.scale(frameScaleFactor); - scaledDamageRect.move(-frameRect().x() * (frameScaleFactor - 1), -frameRect().y() * (frameScaleFactor - 1)); - // Don't paint anything if the plugin doesn't intersect the damage rect. - if (!frameRect().intersects(enclosingIntRect(scaledDamageRect))) + if (!frameRect().intersects(damageRect)) return; gc->save(); @@ -139,7 +132,7 @@ void WebPluginContainerImpl::paint(GraphicsContext* gc, const IntRect& damageRec WebCanvas* canvas = gc->platformContext()->canvas(); IntRect windowRect = - IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect))); + IntRect(view->contentsToWindow(damageRect.location()), damageRect.size()); m_webPlugin->paint(canvas, windowRect); gc->restore(); @@ -660,16 +653,11 @@ void WebPluginContainerImpl::handleMouseEvent(MouseEvent* event) { ASSERT(parent()->isFrameView()); - if (event->isDragEvent()) { - handleDragEvent(event); - return; - } - // We cache the parent FrameView here as the plugin widget could be deleted // in the call to HandleEvent. See http://b/issue?id=1362948 FrameView* parentView = static_cast<FrameView*>(parent()); - WebMouseEventBuilder webEvent(this, m_element->renderer(), *event); + WebMouseEventBuilder webEvent(this, *event); if (webEvent.type == WebInputEvent::Undefined) return; @@ -708,35 +696,9 @@ void WebPluginContainerImpl::handleMouseEvent(MouseEvent* event) chromeClient->setCursorForPlugin(cursorInfo); } -void WebPluginContainerImpl::handleDragEvent(MouseEvent* event) -{ - ASSERT(event->isDragEvent()); - - WebDragStatus dragStatus = WebDragStatusUnknown; - if (event->type() == eventNames().dragenterEvent) - dragStatus = WebDragStatusEnter; - else if (event->type() == eventNames().dragleaveEvent) - dragStatus = WebDragStatusLeave; - else if (event->type() == eventNames().dragoverEvent) - dragStatus = WebDragStatusOver; - else if (event->type() == eventNames().dropEvent) - dragStatus = WebDragStatusDrop; - - if (dragStatus == WebDragStatusUnknown) - return; - - ClipboardChromium* clipboard = static_cast<ClipboardChromium*>(event->dataTransfer()); - WebDragData dragData = clipboard->dataObject(); - WebDragOperationsMask dragOperationMask = static_cast<WebDragOperationsMask>(clipboard->sourceOperation()); - WebPoint dragScreenLocation(event->screenX(), event->screenY()); - WebPoint dragLocation(event->absoluteLocation().x() - location().x(), event->absoluteLocation().y() - location().y()); - - m_webPlugin->handleDragStatusUpdate(dragStatus, dragData, dragOperationMask, dragLocation, dragScreenLocation); -} - void WebPluginContainerImpl::handleWheelEvent(WheelEvent* event) { - WebMouseWheelEventBuilder webEvent(this, m_element->renderer(), *event); + WebMouseWheelEventBuilder webEvent(this, *event); if (webEvent.type == WebInputEvent::Undefined) return; @@ -785,9 +747,7 @@ void WebPluginContainerImpl::handleKeyboardEvent(KeyboardEvent* event) void WebPluginContainerImpl::handleTouchEvent(TouchEvent* event) { - if (!m_isAcceptingTouchEvents) - return; - WebTouchEventBuilder webEvent(this, m_element->renderer(), *event); + WebTouchEventBuilder webEvent(this, *event); if (webEvent.type == WebInputEvent::Undefined) return; WebCursorInfo cursorInfo; @@ -798,7 +758,7 @@ void WebPluginContainerImpl::handleTouchEvent(TouchEvent* event) void WebPluginContainerImpl::handleGestureEvent(GestureEvent* event) { - WebGestureEventBuilder webEvent(this, m_element->renderer(), *event); + WebGestureEventBuilder webEvent(this, *event); if (webEvent.type == WebInputEvent::Undefined) return; WebCursorInfo cursorInfo; diff --git a/Source/WebKit/chromium/src/WebPluginContainerImpl.h b/Source/WebKit/chromium/src/WebPluginContainerImpl.h index e89af0987..e203a7370 100644 --- a/Source/WebKit/chromium/src/WebPluginContainerImpl.h +++ b/Source/WebKit/chromium/src/WebPluginContainerImpl.h @@ -165,7 +165,6 @@ private: ~WebPluginContainerImpl(); void handleMouseEvent(WebCore::MouseEvent*); - void handleDragEvent(WebCore::MouseEvent*); void handleWheelEvent(WebCore::WheelEvent*); void handleKeyboardEvent(WebCore::KeyboardEvent*); void handleTouchEvent(WebCore::TouchEvent*); diff --git a/Source/WebKit/chromium/src/WebPluginListBuilderImpl.cpp b/Source/WebKit/chromium/src/WebPluginListBuilderImpl.cpp index acfb882a4..5c6b6fced 100644 --- a/Source/WebKit/chromium/src/WebPluginListBuilderImpl.cpp +++ b/Source/WebKit/chromium/src/WebPluginListBuilderImpl.cpp @@ -32,7 +32,7 @@ #include "WebPluginListBuilderImpl.h" #include "PluginData.h" -#include <public/WebString.h> +#include "platform/WebString.h" #include <wtf/Vector.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebPluginLoadObserver.h b/Source/WebKit/chromium/src/WebPluginLoadObserver.h index 364f40260..d7648e136 100644 --- a/Source/WebKit/chromium/src/WebPluginLoadObserver.h +++ b/Source/WebKit/chromium/src/WebPluginLoadObserver.h @@ -31,7 +31,7 @@ #ifndef WebPluginLoadObserver_h #define WebPluginLoadObserver_h -#include <public/WebURL.h> +#include "platform/WebURL.h" namespace WebKit { diff --git a/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp b/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp index 0d2aeac45..51114020b 100644 --- a/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp +++ b/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp @@ -48,7 +48,7 @@ #include "WebViewClient.h" #include "WebWidgetClient.h" #include "painting/GraphicsContextBuilder.h" -#include <public/WebRect.h> +#include "platform/WebRect.h" #include <skia/ext/platform_canvas.h> #if ENABLE(GESTURE_EVENTS) diff --git a/Source/WebKit/chromium/src/WebPopupMenuImpl.h b/Source/WebKit/chromium/src/WebPopupMenuImpl.h index 3c038acad..7f13e4385 100644 --- a/Source/WebKit/chromium/src/WebPopupMenuImpl.h +++ b/Source/WebKit/chromium/src/WebPopupMenuImpl.h @@ -33,8 +33,8 @@ #include "FramelessScrollViewClient.h" #include "WebPopupMenu.h" -#include <public/WebPoint.h> -#include <public/WebSize.h> +#include "platform/WebPoint.h" +#include "platform/WebSize.h" #include <wtf/OwnPtr.h> #include <wtf/RefCounted.h> diff --git a/Source/WebKit/chromium/src/WebRange.cpp b/Source/WebKit/chromium/src/WebRange.cpp index bc2930572..85df0a3ba 100644 --- a/Source/WebKit/chromium/src/WebRange.cpp +++ b/Source/WebKit/chromium/src/WebRange.cpp @@ -40,8 +40,8 @@ #include "TextIterator.h" #include "WebFrameImpl.h" #include "WebNode.h" -#include <public/WebFloatQuad.h> -#include <public/WebString.h> +#include "platform/WebFloatQuad.h" +#include "platform/WebString.h" #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebRegularExpression.cpp b/Source/WebKit/chromium/src/WebRegularExpression.cpp index 0f9074f67..4d0bd53be 100644 --- a/Source/WebKit/chromium/src/WebRegularExpression.cpp +++ b/Source/WebKit/chromium/src/WebRegularExpression.cpp @@ -32,7 +32,7 @@ #include "WebRegularExpression.h" #include "RegularExpression.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebScriptController.cpp b/Source/WebKit/chromium/src/WebScriptController.cpp index cdff75ab1..fbf73f689 100644 --- a/Source/WebKit/chromium/src/WebScriptController.cpp +++ b/Source/WebKit/chromium/src/WebScriptController.cpp @@ -34,7 +34,8 @@ #include "ScriptController.h" #include "V8Binding.h" #include "V8DOMMap.h" -#include <public/WebString.h> + +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebSecurityOrigin.cpp b/Source/WebKit/chromium/src/WebSecurityOrigin.cpp index eee5b6186..afe204d55 100644 --- a/Source/WebKit/chromium/src/WebSecurityOrigin.cpp +++ b/Source/WebKit/chromium/src/WebSecurityOrigin.cpp @@ -33,8 +33,8 @@ #include "KURL.h" #include "SecurityOrigin.h" -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebString.h" +#include "platform/WebURL.h" #include <wtf/PassRefPtr.h> using namespace WebCore; @@ -156,9 +156,4 @@ void WebSecurityOrigin::assign(WebSecurityOriginPrivate* p) m_private = p; } -void WebSecurityOrigin::grantLoadLocalResources() const -{ - get()->grantLoadLocalResources(); -} - } // namespace WebKit diff --git a/Source/WebKit/chromium/src/WebSecurityPolicy.cpp b/Source/WebKit/chromium/src/WebSecurityPolicy.cpp index c1d0d8866..e80061889 100644 --- a/Source/WebKit/chromium/src/WebSecurityPolicy.cpp +++ b/Source/WebKit/chromium/src/WebSecurityPolicy.cpp @@ -35,8 +35,9 @@ #include "SchemeRegistry.h" #include "SecurityOrigin.h" #include "SecurityPolicy.h" -#include <public/WebString.h> -#include <public/WebURL.h> + +#include "platform/WebString.h" +#include "platform/WebURL.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebSelectElement.cpp b/Source/WebKit/chromium/src/WebSelectElement.cpp index 28d56e146..3a8238640 100644 --- a/Source/WebKit/chromium/src/WebSelectElement.cpp +++ b/Source/WebKit/chromium/src/WebSelectElement.cpp @@ -34,7 +34,7 @@ #include "HTMLNames.h" #include "HTMLOptionElement.h" #include "HTMLSelectElement.h" -#include <public/WebString.h> +#include "platform/WebString.h" #include <wtf/PassRefPtr.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp b/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp index 34fa4bb25..fc7af6f3f 100644 --- a/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp +++ b/Source/WebKit/chromium/src/WebSerializedScriptValue.cpp @@ -32,7 +32,7 @@ #include "platform/WebSerializedScriptValue.h" #include "SerializedScriptValue.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebSessionDescriptionDescriptor.cpp b/Source/WebKit/chromium/src/WebSessionDescriptionDescriptor.cpp index 05cfce36d..e8f96e568 100644 --- a/Source/WebKit/chromium/src/WebSessionDescriptionDescriptor.cpp +++ b/Source/WebKit/chromium/src/WebSessionDescriptionDescriptor.cpp @@ -32,11 +32,11 @@ #if ENABLE(MEDIA_STREAM) -#include <public/WebSessionDescriptionDescriptor.h> +#include "platform/WebSessionDescriptionDescriptor.h" #include "SessionDescriptionDescriptor.h" -#include <public/WebICECandidateDescriptor.h> -#include <public/WebString.h> +#include "platform/WebICECandidateDescriptor.h" +#include "platform/WebString.h" #include <wtf/Vector.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebSettingsImpl.cpp b/Source/WebKit/chromium/src/WebSettingsImpl.cpp index 988c5e66b..4cc3ef727 100644 --- a/Source/WebKit/chromium/src/WebSettingsImpl.cpp +++ b/Source/WebKit/chromium/src/WebSettingsImpl.cpp @@ -33,8 +33,8 @@ #include "FontRenderingMode.h" #include "Settings.h" -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebString.h" +#include "platform/WebURL.h" #include <wtf/UnusedParam.h> #if defined(OS_WIN) @@ -54,7 +54,6 @@ WebSettingsImpl::WebSettingsImpl(Settings* settings) , m_viewportEnabled(false) , m_applyDefaultDeviceScaleFactorInCompositor(false) , m_gestureTapHighlightEnabled(true) - , m_autoZoomFocusedNodeToLegibleScale(false) , m_defaultTileSize(WebSize(256, 256)) , m_maxUntiledLayerSize(WebSize(512, 512)) { @@ -141,16 +140,6 @@ void WebSettingsImpl::setApplyDefaultDeviceScaleFactorInCompositor(bool applyDef m_applyDefaultDeviceScaleFactorInCompositor = applyDefaultDeviceScaleFactorInCompositor; } -void WebSettingsImpl::setApplyPageScaleFactorInCompositor(bool applyPageScaleFactorInCompositor) -{ - m_settings->setApplyPageScaleFactorInCompositor(applyPageScaleFactorInCompositor); -} - -void WebSettingsImpl::setAutoZoomFocusedNodeToLegibleScale(bool autoZoomFocusedNodeToLegibleScale) -{ - m_autoZoomFocusedNodeToLegibleScale = autoZoomFocusedNodeToLegibleScale; -} - void WebSettingsImpl::setTextAutosizingEnabled(bool enabled) { #if ENABLE(TEXT_AUTOSIZING) @@ -664,9 +653,4 @@ void WebSettingsImpl::setGestureTapHighlightEnabled(bool enableHighlight) m_gestureTapHighlightEnabled = enableHighlight; } -bool WebSettingsImpl::applyPageScaleFactorInCompositor() const -{ - return m_settings->applyPageScaleFactorInCompositor(); -} - } // namespace WebKit diff --git a/Source/WebKit/chromium/src/WebSettingsImpl.h b/Source/WebKit/chromium/src/WebSettingsImpl.h index 1169c31cf..e9e01bfcd 100644 --- a/Source/WebKit/chromium/src/WebSettingsImpl.h +++ b/Source/WebKit/chromium/src/WebSettingsImpl.h @@ -64,10 +64,8 @@ public: virtual void setAllowScriptsToCloseWindows(bool); virtual void setAllowUniversalAccessFromFileURLs(bool); virtual void setApplyDefaultDeviceScaleFactorInCompositor(bool); - virtual void setApplyPageScaleFactorInCompositor(bool); virtual void setAsynchronousSpellCheckingEnabled(bool); virtual void setAuthorAndUserStylesEnabled(bool); - virtual void setAutoZoomFocusedNodeToLegibleScale(bool); virtual void setCaretBrowsingEnabled(bool); virtual void setCookieEnabled(bool); virtual void setCursiveFontFamily(const WebString&, UScriptCode = USCRIPT_COMMON); @@ -162,8 +160,6 @@ public: bool showPaintRects() const { return m_showPaintRects; } bool renderVSyncEnabled() const { return m_renderVSyncEnabled; } bool applyDefaultDeviceScaleFactorInCompositor() const { return m_applyDefaultDeviceScaleFactorInCompositor; } - bool applyPageScaleFactorInCompositor() const; - bool autoZoomFocusedNodeToLegibleScale() const { return m_autoZoomFocusedNodeToLegibleScale; } bool gestureTapHighlightEnabled() { return m_gestureTapHighlightEnabled; } WebSize defaultTileSize() const { return m_defaultTileSize; } WebSize maxUntiledLayerSize() const { return m_maxUntiledLayerSize; } @@ -177,7 +173,6 @@ private: bool m_viewportEnabled; bool m_applyDefaultDeviceScaleFactorInCompositor; bool m_gestureTapHighlightEnabled; - bool m_autoZoomFocusedNodeToLegibleScale; WebSize m_defaultTileSize; WebSize m_maxUntiledLayerSize; }; diff --git a/Source/WebKit/chromium/src/WebSocketImpl.cpp b/Source/WebKit/chromium/src/WebSocketImpl.cpp index a0849efca..7548c6315 100644 --- a/Source/WebKit/chromium/src/WebSocketImpl.cpp +++ b/Source/WebKit/chromium/src/WebSocketImpl.cpp @@ -47,8 +47,8 @@ class WebSocketChannel { #include "WebArrayBuffer.h" #include "WebDocument.h" #include "WebSocketClient.h" -#include <public/WebString.h> -#include <public/WebURL.h> +#include "platform/WebString.h" +#include "platform/WebURL.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebSocketImpl.h b/Source/WebKit/chromium/src/WebSocketImpl.h index ebf4e775a..ef14b18c7 100644 --- a/Source/WebKit/chromium/src/WebSocketImpl.h +++ b/Source/WebKit/chromium/src/WebSocketImpl.h @@ -31,10 +31,10 @@ #ifndef WebSocketImpl_h #define WebSocketImpl_h +#include "platform/WebCommon.h" #include "WebSocket.h" #include "WebSocketChannelClient.h" #include "WebSocketClient.h" -#include <public/WebCommon.h> #include <wtf/OwnPtr.h> #include <wtf/RefPtr.h> diff --git a/Source/WebKit/chromium/src/WebStorageEventDispatcherImpl.cpp b/Source/WebKit/chromium/src/WebStorageEventDispatcherImpl.cpp index 9f31debc8..95d3bcf88 100644 --- a/Source/WebKit/chromium/src/WebStorageEventDispatcherImpl.cpp +++ b/Source/WebKit/chromium/src/WebStorageEventDispatcherImpl.cpp @@ -35,7 +35,8 @@ #include "SecurityOrigin.h" #include "StorageAreaProxy.h" #include "WebViewImpl.h" -#include <public/WebURL.h> + +#include "platform/WebURL.h" #include <wtf/PassOwnPtr.h> namespace WebKit { diff --git a/Source/WebKit/chromium/src/WebSurroundingText.cpp b/Source/WebKit/chromium/src/WebSurroundingText.cpp index 3caadca2e..45db3d1bd 100644 --- a/Source/WebKit/chromium/src/WebSurroundingText.cpp +++ b/Source/WebKit/chromium/src/WebSurroundingText.cpp @@ -33,7 +33,8 @@ #include "Text.h" #include "VisiblePosition.h" #include "WebHitTestResult.h" -#include <public/WebPoint.h> + +#include "platform/WebPoint.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp b/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp index 46fbf2371..b81ea578b 100644 --- a/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp +++ b/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp @@ -35,7 +35,7 @@ #include "SpellChecker.h" #include "TextCheckerClient.h" #include "WebTextCheckingResult.h" -#include <public/WebVector.h> +#include "platform/WebVector.h" #include <wtf/Assertions.h> using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebURLLoadTiming.cpp b/Source/WebKit/chromium/src/WebURLLoadTiming.cpp index 2a2777157..0949c9b2e 100644 --- a/Source/WebKit/chromium/src/WebURLLoadTiming.cpp +++ b/Source/WebKit/chromium/src/WebURLLoadTiming.cpp @@ -29,10 +29,10 @@ */ #include "config.h" -#include <public/WebURLLoadTiming.h> +#include "platform/WebURLLoadTiming.h" #include "ResourceLoadTiming.h" -#include <public/WebString.h> +#include "platform/WebString.h" using namespace WebCore; diff --git a/Source/WebKit/chromium/src/WebUserMediaRequest.cpp b/Source/WebKit/chromium/src/WebUserMediaRequest.cpp index ffecb0aed..26f17c35b 100644 --- a/Source/WebKit/chromium/src/WebUserMediaRequest.cpp +++ b/Source/WebKit/chromium/src/WebUserMediaRequest.cpp @@ -35,18 +35,16 @@ #include "WebUserMediaRequest.h" #include "Document.h" -#include "MediaConstraints.h" #include "MediaStreamDescriptor.h" #include "MediaStreamSource.h" #include "SecurityOrigin.h" #include "UserMediaRequest.h" #include "WebDocument.h" #include "WebSecurityOrigin.h" -#include <public/WebMediaConstraints.h> -#include <public/WebMediaStreamDescriptor.h> -#include <public/WebMediaStreamSource.h> -#include <public/WebString.h> -#include <public/WebVector.h> +#include "platform/WebMediaStreamDescriptor.h" +#include "platform/WebMediaStreamSource.h" +#include "platform/WebString.h" +#include "platform/WebVector.h" #include <wtf/Vector.h> using namespace WebCore; @@ -75,18 +73,6 @@ bool WebUserMediaRequest::video() const return m_private->video(); } -WebMediaConstraints WebUserMediaRequest::audioConstraints() const -{ - ASSERT(!isNull()); - return m_private->audioConstraints(); -} - -WebMediaConstraints WebUserMediaRequest::videoConstraints() const -{ - ASSERT(!isNull()); - return m_private->videoConstraints(); -} - WebSecurityOrigin WebUserMediaRequest::securityOrigin() const { ASSERT(!isNull() && m_private->scriptExecutionContext()); diff --git a/Source/WebKit/chromium/src/WebViewImpl.cpp b/Source/WebKit/chromium/src/WebViewImpl.cpp index d6bf94b96..261f7c357 100644 --- a/Source/WebKit/chromium/src/WebViewImpl.cpp +++ b/Source/WebKit/chromium/src/WebViewImpl.cpp @@ -92,6 +92,7 @@ #include "PageGroupLoadDeferrer.h" #include "PagePopupClient.h" #include "PageWidgetDelegate.h" +#include "Pasteboard.h" #include "PlatformContextSkia.h" #include "PlatformKeyboardEvent.h" #include "PlatformMouseEvent.h" @@ -191,19 +192,13 @@ using namespace std; // (such as due to a double tap gesture or find in page etc.). These are // experimentally determined. static const int touchPointPadding = 32; -static const int nonUserInitiatedPointPadding = 11; static const float minScaleDifference = 0.01f; static const float doubleTapZoomContentDefaultMargin = 5; static const float doubleTapZoomContentMinimumMargin = 2; static const double doubleTapZoomAnimationDurationInSeconds = 0.25; -static const float doubleTapZoomAlreadyLegibleRatio = 1.2f; // Constants for zooming in on a focused text field. static const double scrollAndScaleAnimationDurationInSeconds = 0.2; -static const int minReadableCaretHeight = 18; -static const float minScaleChangeToTriggerZoom = 1.05f; -static const float leftBoxRatio = 0.3f; -static const int caretPadding = 10; namespace WebKit { @@ -214,8 +209,8 @@ namespace WebKit { const double WebView::textSizeMultiplierRatio = 1.2; const double WebView::minTextSizeMultiplier = 0.5; const double WebView::maxTextSizeMultiplier = 3.0; -const float WebView::minPageScaleFactor = 0.25f; -const float WebView::maxPageScaleFactor = 4.0f; +const float WebView::minPageScaleFactor = 0.25; +const float WebView::maxPageScaleFactor = 4.0; // The group name identifies a namespace of pages. Page group is used on PLATFORM(MAC) @@ -397,8 +392,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client) , m_ignoreViewportTagMaximumScale(false) , m_pageScaleFactorIsSet(false) , m_savedPageScaleFactor(0) - , m_doubleTapZoomInEffect(false) - , m_shouldUseDoubleTapTimeZero(false) , m_contextMenuAllowed(false) , m_doingDragAndDrop(false) , m_ignoreInputEvents(false) @@ -629,6 +622,39 @@ void WebViewImpl::mouseContextMenu(const WebMouseEvent& event) void WebViewImpl::handleMouseUp(Frame& mainFrame, const WebMouseEvent& event) { +#if OS(UNIX) && !OS(DARWIN) + // If the event was a middle click, attempt to copy text into the focused + // frame. We execute this before we let the page have a go at the event + // because the page may change what is focused during in its event handler. + // + // This code is in the mouse up handler. There is some debate about putting + // this here, as opposed to the mouse down handler. + // xterm: pastes on up. + // GTK: pastes on down. + // Firefox: pastes on up. + // Midori: couldn't paste at all with 0.1.2 + // + // There is something of a webcompat angle to this well, as highlighted by + // crbug.com/14608. Pages can clear text boxes 'onclick' and, if we paste on + // down then the text is pasted just before the onclick handler runs and + // clears the text box. So it's important this happens after the + // handleMouseReleaseEvent() earlier in this function + if (event.button == WebMouseEvent::ButtonMiddle) { + Frame* focused = focusedWebCoreFrame(); + FrameView* view = m_page->mainFrame()->view(); + IntPoint clickPoint(m_lastMouseDownPoint.x, m_lastMouseDownPoint.y); + IntPoint contentPoint = view->windowToContents(clickPoint); + HitTestResult hitTestResult = focused->eventHandler()->hitTestResultAtPoint(contentPoint, false, false, ShouldHitTestScrollbars); + // We don't want to send a paste when middle clicking a scroll bar or a + // link (which will navigate later in the code). The main scrollbars + // have to be handled separately. + if (!hitTestResult.scrollbar() && !hitTestResult.isLiveLink() && focused && !view->scrollbarAtPoint(clickPoint)) { + Editor* editor = focused->editor(); + editor->command(AtomicString("PasteGlobalSelection")).execute(); + } + } +#endif + PageWidgetEventHandler::handleMouseUp(mainFrame, event); #if OS(WINDOWS) @@ -663,29 +689,6 @@ void WebViewImpl::scrollBy(const WebCore::IntPoint& delta) bool WebViewImpl::handleGestureEvent(const WebGestureEvent& event) { bool eventSwallowed = false; - - // Handle link highlighting outside the main switch to avoid getting lost in the - // complicated set of cases handled below. - switch (event.type) { - case WebInputEvent::GestureTapDown: - // Queue a highlight animation, then hand off to regular handler. -#if OS(LINUX) - if (settingsImpl()->gestureTapHighlightEnabled()) - enableTouchHighlight(IntPoint(event.x, event.y)); -#endif - break; - case WebInputEvent::GestureTapCancel: - if (m_linkHighlight) - m_linkHighlight->startHighlightAnimationIfNeeded(); - break; - case WebInputEvent::GestureTap: - // If a link highlight is active, kill it. - m_linkHighlight.clear(); - break; - default: - break; - } - switch (event.type) { case WebInputEvent::GestureFlingStart: { m_client->cancelScheduledContentIntents(); @@ -707,7 +710,7 @@ bool WebViewImpl::handleGestureEvent(const WebGestureEvent& event) break; case WebInputEvent::GestureTap: { m_client->cancelScheduledContentIntents(); - if (detectContentOnTouch(WebPoint(event.x, event.y))) { + if (detectContentOnTouch(WebPoint(event.x, event.y), event.type)) { eventSwallowed = true; break; } @@ -742,42 +745,37 @@ bool WebViewImpl::handleGestureEvent(const WebGestureEvent& event) break; } - case WebInputEvent::GestureTwoFingerTap: { - if (!mainFrameImpl() || !mainFrameImpl()->frameView()) - break; - - m_page->contextMenuController()->clearContextMenu(); - m_contextMenuAllowed = true; - PlatformGestureEventBuilder platformEvent(mainFrameImpl()->frameView(), event); - eventSwallowed = mainFrameImpl()->frame()->eventHandler()->sendContextMenuEventForGesture(platformEvent); - m_contextMenuAllowed = false; - - break; - } + case WebInputEvent::GestureTwoFingerTap: case WebInputEvent::GestureLongPress: { if (!mainFrameImpl() || !mainFrameImpl()->frameView()) break; m_client->cancelScheduledContentIntents(); + if (detectContentOnTouch(WebPoint(event.x, event.y), event.type)) { + eventSwallowed = true; + break; + } + m_page->contextMenuController()->clearContextMenu(); m_contextMenuAllowed = true; PlatformGestureEventBuilder platformEvent(mainFrameImpl()->frameView(), event); - eventSwallowed = mainFrameImpl()->frame()->eventHandler()->handleGestureEvent(platformEvent); + eventSwallowed = mainFrameImpl()->frame()->eventHandler()->sendContextMenuEventForGesture(platformEvent); m_contextMenuAllowed = false; break; } case WebInputEvent::GestureTapDown: { m_client->cancelScheduledContentIntents(); + // Queue a highlight animation, then hand off to regular handler. +#if OS(LINUX) + if (settingsImpl()->gestureTapHighlightEnabled()) + enableTouchHighlight(IntPoint(event.x, event.y)); +#endif PlatformGestureEventBuilder platformEvent(mainFrameImpl()->frameView(), event); eventSwallowed = mainFrameImpl()->frame()->eventHandler()->handleGestureEvent(platformEvent); break; } case WebInputEvent::GestureDoubleTap: - m_client->cancelScheduledContentIntents(); - animateZoomAroundPoint(WebPoint(event.x, event.y), DoubleTap); - eventSwallowed = true; - break; case WebInputEvent::GestureScrollBegin: case WebInputEvent::GesturePinchBegin: m_client->cancelScheduledContentIntents(); @@ -817,15 +815,17 @@ void WebViewImpl::renderingStats(WebRenderingStats& stats) const void WebViewImpl::startPageScaleAnimation(const IntPoint& targetPosition, bool useAnchor, float newScale, double durationInSeconds) { - WebPoint clampedPoint = targetPosition; + if (!m_layerTreeView) + return; + + IntPoint clampedPoint = targetPosition; if (!useAnchor) clampedPoint = clampOffsetAtScale(targetPosition, newScale); - if ((!durationInSeconds && !useAnchor) || m_shouldUseDoubleTapTimeZero) { + + if (!durationInSeconds && !useAnchor) { setPageScaleFactor(newScale, clampedPoint); return; } - if (!m_layerTreeView) - return; m_layerTreeView->startPageScaleAnimation(targetPosition, useAnchor, newScale, durationInSeconds); } @@ -1075,37 +1075,24 @@ WebRect WebViewImpl::widenRectWithinPageBounds(const WebRect& source, int target return WebRect(newX, source.y, newWidth, source.height); } -void WebViewImpl::shouldUseAnimateDoubleTapTimeZeroForTesting(bool setToZero) -{ - m_shouldUseDoubleTapTimeZero = setToZero; -} - -void WebViewImpl::computeScaleAndScrollForHitRect(const WebRect& hitRect, AutoZoomType zoomType, float& scale, WebPoint& scroll, bool& isAnchor) +void WebViewImpl::computeScaleAndScrollForHitRect(const WebRect& hitRect, AutoZoomType zoomType, float& scale, WebPoint& scroll) { scale = pageScaleFactor(); scroll.x = scroll.y = 0; WebRect targetRect = hitRect; - // Padding only depends on page scale when triggered by manually tapping - int padding = (zoomType == DoubleTap) ? touchPointPadding : nonUserInitiatedPointPadding; if (targetRect.isEmpty()) - targetRect.width = targetRect.height = padding; + targetRect.width = targetRect.height = touchPointPadding; + WebRect rect = computeBlockBounds(targetRect, zoomType); - if (zoomType == FindInPage && rect.isEmpty()) { - // Keep current scale (no need to scroll as x,y will normally already - // be visible). FIXME: Revisit this if it isn't always true. - return; - } + const float overviewScale = m_minimumPageScaleFactor; bool scaleUnchanged = true; if (!rect.isEmpty()) { // Pages should be as legible as on desktop when at dpi scale, so no // need to zoom in further when automatically determining zoom level // (after double tap, find in page, etc), though the user should still // be allowed to manually pinch zoom in further if they desire. - const float defaultScaleWhenAlreadyLegible = m_minimumPageScaleFactor * doubleTapZoomAlreadyLegibleRatio; - float legibleScale = deviceScaleFactor(); - if (legibleScale < defaultScaleWhenAlreadyLegible) - legibleScale = (scale == m_minimumPageScaleFactor) ? defaultScaleWhenAlreadyLegible : m_minimumPageScaleFactor; + const float maxScale = deviceScaleFactor(); const float defaultMargin = doubleTapZoomContentDefaultMargin * deviceScaleFactor(); const float minimumMargin = doubleTapZoomContentMinimumMargin * deviceScaleFactor(); @@ -1118,61 +1105,55 @@ void WebViewImpl::computeScaleAndScrollForHitRect(const WebRect& hitRect, AutoZo rect = widenRectWithinPageBounds(rect, static_cast<int>(defaultMargin * rect.width / m_size.width), static_cast<int>(minimumMargin * rect.width / m_size.width)); + // Fit block to screen, respecting limits. scale *= static_cast<float>(m_size.width) / rect.width; - scale = min(scale, legibleScale); + scale = min(scale, maxScale); scale = clampPageScaleFactorToLimits(scale); scaleUnchanged = fabs(pageScaleFactor() - scale) < minScaleDifference; } - if (zoomType == DoubleTap && (rect.isEmpty() || scaleUnchanged || m_doubleTapZoomInEffect)) { - // Zoom out to minimum scale. - scale = m_minimumPageScaleFactor; - scroll = WebPoint(hitRect.x, hitRect.y); - isAnchor = true; - m_doubleTapZoomInEffect = false; - } else { - if (zoomType == DoubleTap && scale != m_minimumPageScaleFactor) - m_doubleTapZoomInEffect = true; - else - m_doubleTapZoomInEffect = false; - // FIXME: If this is being called for auto zoom during find in page, - // then if the user manually zooms in it'd be nice to preserve the - // relative increase in zoom they caused (if they zoom out then it's ok - // to zoom them back in again). This isn't compatible with our current - // double-tap zoom strategy (fitting the containing block to the screen) - // though. - - float screenHeight = m_size.height / scale * pageScaleFactor(); - float screenWidth = m_size.width / scale * pageScaleFactor(); - - // Scroll to vertically align the block. - if (rect.height < screenHeight) { - // Vertically center short blocks. - rect.y -= 0.5 * (screenHeight - rect.height); - } else { - // Ensure position we're zooming to (+ padding) isn't off the bottom of - // the screen. - rect.y = max<float>(rect.y, hitRect.y + padding - screenHeight); - } // Otherwise top align the block. - - // Do the same thing for horizontal alignment. - if (rect.width < screenWidth) - rect.x -= 0.5 * (screenWidth - rect.width); - else - rect.x = max<float>(rect.x, hitRect.x + padding - screenWidth); - scroll.x = rect.x; - scroll.y = rect.y; - isAnchor = false; + if (zoomType == DoubleTap) { + if (rect.isEmpty() || scaleUnchanged) { + // Zoom out to overview mode. + if (overviewScale) + scale = overviewScale; + return; + } + } else if (rect.isEmpty()) { + // Keep current scale (no need to scroll as x,y will normally already + // be visible). FIXME: Revisit this if it isn't always true. + return; } - scale = clampPageScaleFactorToLimits(scale); - scroll = mainFrameImpl()->frameView()->windowToContents(scroll); - float scaleDelta = scale / pageScaleFactor(); - scroll = WebPoint(scroll.x * scaleDelta, scroll.y * scaleDelta); - if (!isAnchor) - scroll = clampOffsetAtScale(scroll, scale); + // FIXME: If this is being called for auto zoom during find in page, + // then if the user manually zooms in it'd be nice to preserve the relative + // increase in zoom they caused (if they zoom out then it's ok to zoom + // them back in again). This isn't compatible with our current double-tap + // zoom strategy (fitting the containing block to the screen) though. + + float screenHeight = m_size.height / scale * pageScaleFactor(); + float screenWidth = m_size.width / scale * pageScaleFactor(); + + // Scroll to vertically align the block. + if (rect.height < screenHeight) { + // Vertically center short blocks. + rect.y -= 0.5 * (screenHeight - rect.height); + } else { + // Ensure position we're zooming to (+ padding) isn't off the bottom of + // the screen. + rect.y = max<float>(rect.y, hitRect.y + touchPointPadding - screenHeight); + } // Otherwise top align the block. + + // Do the same thing for horizontal alignment. + if (rect.width < screenWidth) + rect.x -= 0.5 * (screenWidth - rect.width); + else + rect.x = max<float>(rect.x, hitRect.x + touchPointPadding - screenWidth); + + scroll.x = rect.x; + scroll.y = rect.y; } static bool highlightConditions(Node* node) @@ -1198,10 +1179,10 @@ Node* WebViewImpl::bestTouchLinkNode(IntPoint touchEventLocation) while (bestTouchNode && !highlightConditions(bestTouchNode)) bestTouchNode = bestTouchNode->parentNode(); - // If the document/body have click handlers installed, we don't want to default to applying the highlight to the entire RenderView, or the - // entire body. + // If the document has click handlers installed, we don't want to default to applying the highlight to the entire RenderView, or the + // entire body. Also, if the node has non-auto Z-index, we cannot be sure of it's ordering with respect to other possible target nodes. RenderObject* touchNodeRenderer = bestTouchNode ? bestTouchNode->renderer() : 0; - if (bestTouchNode && (!touchNodeRenderer || touchNodeRenderer->isRenderView() || touchNodeRenderer->isBody())) + if (bestTouchNode && (!touchNodeRenderer || touchNodeRenderer->isRenderView() || touchNodeRenderer->isBody() || !touchNodeRenderer->style()->hasAutoZIndex())) return 0; return bestTouchNode; @@ -1225,6 +1206,7 @@ void WebViewImpl::enableTouchHighlight(IntPoint touchEventLocation) return; m_linkHighlight = LinkHighlight::create(touchNode, this); + m_linkHighlight->startHighlightAnimation(); } #endif @@ -1237,13 +1219,11 @@ void WebViewImpl::animateZoomAroundPoint(const IntPoint& point, AutoZoomType zoo float scale; WebPoint scroll; - bool isAnchor; - WebPoint webPoint = point; - computeScaleAndScrollForHitRect(WebRect(webPoint.x, webPoint.y, 0, 0), zoomType, scale, scroll, isAnchor); + computeScaleAndScrollForHitRect(WebRect(point.x(), point.y(), 0, 0), zoomType, scale, scroll); bool isDoubleTap = (zoomType == DoubleTap); - double durationInSeconds = (isDoubleTap && !m_shouldUseDoubleTapTimeZero) ? doubleTapZoomAnimationDurationInSeconds : 0; - startPageScaleAnimation(scroll, isAnchor, scale, durationInSeconds); + double durationInSeconds = isDoubleTap ? doubleTapZoomAnimationDurationInSeconds : 0; + startPageScaleAnimation(scroll, isDoubleTap, scale, durationInSeconds); #endif } @@ -1575,9 +1555,9 @@ void WebViewImpl::resize(const WebSize& newSize) #endif WebDevToolsAgentPrivate* agentPrivate = devToolsAgentPrivate(); - if (agentPrivate) - agentPrivate->webViewResized(newSize); - if (!agentPrivate || !agentPrivate->metricsOverridden()) { + if (agentPrivate && agentPrivate->metricsOverridden()) + agentPrivate->webViewResized(); + else { WebFrameImpl* webFrame = mainFrameImpl(); if (webFrame->frameView()) webFrame->frameView()->resize(newSize.width, newSize.height); @@ -1743,6 +1723,13 @@ void WebViewImpl::updateAnimations(double monotonicFrameBeginTime) #if ENABLE(REQUEST_ANIMATION_FRAME) TRACE_EVENT0("webkit", "WebViewImpl::updateAnimations"); + WebFrameImpl* webframe = mainFrameImpl(); + if (!webframe) + return; + FrameView* view = webframe->frameView(); + if (!view) + return; + // Create synthetic wheel events as necessary for fling. if (m_gestureAnimation) { if (m_gestureAnimation->animate(monotonicFrameBeginTime)) @@ -1751,9 +1738,6 @@ void WebViewImpl::updateAnimations(double monotonicFrameBeginTime) m_gestureAnimation.clear(); } - if (!m_page) - return; - PageWidgetDelegate::animate(m_page.get(), monotonicFrameBeginTime); #endif } @@ -2644,78 +2628,8 @@ void WebViewImpl::scrollFocusedNodeIntoRect(const WebRect& rect) Node* focusedNode = focusedWebCoreNode(); if (!frame || !frame->view() || !focusedNode || !focusedNode->isElementNode()) return; - - if (!m_webSettings->autoZoomFocusedNodeToLegibleScale()) { - Element* elementNode = static_cast<Element*>(focusedNode); - frame->view()->scrollElementToRect(elementNode, IntRect(rect.x, rect.y, rect.width, rect.height)); - return; - } - -#if ENABLE(GESTURE_EVENTS) - focusedNode->document()->updateLayoutIgnorePendingStylesheets(); - - // 'caret' is rect encompassing the blinking cursor. - IntRect textboxRect = focusedNode->document()->view()->contentsToWindow(pixelSnappedIntRect(focusedNode->Node::boundingBox())); - WebRect caret, end; - selectionBounds(caret, end); - - // Pick a scale which is reasonably readable. This is the scale at which - // the caret height will become minReadableCaretHeight (adjusted for dpi - // and font scale factor). - float targetScale = deviceScaleFactor(); -#if ENABLE(TEXT_AUTOSIZING) - if (page() && page()->settings()) - targetScale *= page()->settings()->textAutosizingFontScaleFactor(); -#endif - const float newScale = clampPageScaleFactorToLimits(pageScaleFactor() * minReadableCaretHeight * targetScale / caret.height); - const float deltaScale = newScale / pageScaleFactor(); - - // Convert the rects to absolute space in the new scale. - IntRect textboxRectInDocumentCoordinates = textboxRect; - textboxRectInDocumentCoordinates.move(mainFrame()->scrollOffset()); - textboxRectInDocumentCoordinates.scale(deltaScale); - IntRect caretInDocumentCoordinates = caret; - caretInDocumentCoordinates.move(mainFrame()->scrollOffset()); - caretInDocumentCoordinates.scale(deltaScale); - - IntPoint newOffset; - if (textboxRectInDocumentCoordinates.width() <= m_size.width) { - // Field is narrower than screen. Try to leave padding on left so field's - // label is visible, but it's more important to ensure entire field is - // onscreen. - int idealLeftPadding = m_size.width * leftBoxRatio; - int maxLeftPaddingKeepingBoxOnscreen = m_size.width - textboxRectInDocumentCoordinates.width(); - newOffset.setX(textboxRectInDocumentCoordinates.x() - min<int>(idealLeftPadding, maxLeftPaddingKeepingBoxOnscreen)); - } else { - // Field is wider than screen. Try to left-align field, unless caret would - // be offscreen, in which case right-align the caret. - newOffset.setX(max<int>(textboxRectInDocumentCoordinates.x(), caretInDocumentCoordinates.x() + caretInDocumentCoordinates.width() + caretPadding - m_size.width)); - } - if (textboxRectInDocumentCoordinates.height() <= m_size.height) { - // Field is shorter than screen. Vertically center it. - newOffset.setY(textboxRectInDocumentCoordinates.y() - (m_size.height - textboxRectInDocumentCoordinates.height()) / 2); - } else { - // Field is taller than screen. Try to top align field, unless caret would - // be offscreen, in which case bottom-align the caret. - newOffset.setY(max<int>(textboxRectInDocumentCoordinates.y(), caretInDocumentCoordinates.y() + caretInDocumentCoordinates.height() + caretPadding - m_size.height)); - } - - bool needAnimation = false; - // If we are at less than the target zoom level, zoom in. - if (deltaScale > minScaleChangeToTriggerZoom) - needAnimation = true; - // If the caret is offscreen, then animate. - IntRect sizeRect(0, 0, m_size.width, m_size.height); - if (!sizeRect.contains(caret)) - needAnimation = true; - // If the box is partially offscreen and it's possible to bring it fully - // onscreen, then animate. - if (sizeRect.contains(textboxRectInDocumentCoordinates.width(), textboxRectInDocumentCoordinates.height()) && !sizeRect.contains(textboxRect)) - needAnimation = true; - - if (needAnimation) - startPageScaleAnimation(newOffset, false, newScale, scrollAndScaleAnimationDurationInSeconds); -#endif + Element* elementNode = static_cast<Element*>(focusedNode); + frame->view()->scrollElementToRect(elementNode, IntRect(rect.x, rect.y, rect.width, rect.height)); } void WebViewImpl::advanceFocus(bool reverse) @@ -2842,20 +2756,8 @@ void WebViewImpl::setPageScaleFactor(float scaleFactor, const WebPoint& origin) } scaleFactor = clampPageScaleFactorToLimits(scaleFactor); - WebPoint scrollOffset; - if (!m_page->settings()->applyPageScaleFactorInCompositor()) { - // If page scale is not applied in the compositor, then the scroll offsets should - // be modified by the scale factor. - scrollOffset = clampOffsetAtScale(origin, scaleFactor); - } else { - IntPoint offset = origin; - WebSize contentSize = mainFrame()->contentsSize(); - offset.shrunkTo(IntPoint(contentSize.width - m_size.width, contentSize.height - m_size.height)); - offset.clampNegativeToZero(); - scrollOffset = offset; - } - - page()->setPageScaleFactor(scaleFactor, scrollOffset); + WebPoint clampedOrigin = clampOffsetAtScale(origin, scaleFactor); + page()->setPageScaleFactor(scaleFactor, clampedOrigin); m_pageScaleFactorIsSet = true; } @@ -3293,8 +3195,6 @@ void WebViewImpl::sendResizeEventAndRepaint() m_client->didInvalidateRect(damagedRect); } } - if (m_pageOverlays) - m_pageOverlays->update(); } void WebViewImpl::configureAutoResizeMode() @@ -3512,13 +3412,13 @@ void WebView::addUserScript(const WebString& sourceCode, WebView::UserScriptInjectAt injectAt, WebView::UserContentInjectIn injectIn) { - Vector<String> patterns; + OwnPtr<Vector<String> > patterns = adoptPtr(new Vector<String>); for (size_t i = 0; i < patternsIn.size(); ++i) - patterns.append(patternsIn[i]); + patterns->append(patternsIn[i]); PageGroup* pageGroup = PageGroup::pageGroup(pageGroupName); RefPtr<DOMWrapperWorld> world(DOMWrapperWorld::createUninitializedWorld()); - pageGroup->addUserScriptToWorld(world.get(), sourceCode, WebURL(), patterns, Vector<String>(), + pageGroup->addUserScriptToWorld(world.get(), sourceCode, WebURL(), patterns.release(), nullptr, static_cast<UserScriptInjectionTime>(injectAt), static_cast<UserContentInjectedFrames>(injectIn)); } @@ -3528,9 +3428,9 @@ void WebView::addUserStyleSheet(const WebString& sourceCode, WebView::UserContentInjectIn injectIn, WebView::UserStyleInjectionTime injectionTime) { - Vector<String> patterns; + OwnPtr<Vector<String> > patterns = adoptPtr(new Vector<String>); for (size_t i = 0; i < patternsIn.size(); ++i) - patterns.append(patternsIn[i]); + patterns->append(patternsIn[i]); PageGroup* pageGroup = PageGroup::pageGroup(pageGroupName); RefPtr<DOMWrapperWorld> world(DOMWrapperWorld::createUninitializedWorld()); @@ -3539,7 +3439,7 @@ void WebView::addUserStyleSheet(const WebString& sourceCode, // callers specify this though, since in other cases the caller will probably want "user" level. // // FIXME: It would be nice to populate the URL correctly, instead of passing an empty URL. - pageGroup->addUserStyleSheetToWorld(world.get(), sourceCode, WebURL(), patterns, Vector<String>(), + pageGroup->addUserStyleSheetToWorld(world.get(), sourceCode, WebURL(), patterns.release(), nullptr, static_cast<UserContentInjectedFrames>(injectIn), UserStyleAuthorLevel, static_cast<WebCore::UserStyleInjectionTime>(injectionTime)); @@ -3562,10 +3462,8 @@ void WebViewImpl::didCommitLoad(bool* isNewNavigation, bool isNavigationWithinPa m_newNavigationLoader = 0; #endif m_observedNewNavigation = false; - if (*isNewNavigation && !isNavigationWithinPage) { + if (*isNewNavigation && !isNavigationWithinPage) m_pageScaleFactorIsSet = false; - m_doubleTapZoomInEffect = false; - } // Make sure link highlight from previous page is cleared. m_linkHighlight.clear(); @@ -3859,8 +3757,6 @@ void WebViewImpl::paintRootLayer(GraphicsContext& context, const IntRect& conten if (!page()) return; FrameView* view = page()->mainFrame()->view(); - if (context.platformContext()) - context.platformContext()->setDeviceScaleFactor(page()->deviceScaleFactor()); view->paintContents(&context, contentRect); double paintEnd = currentTime(); double pixelsPerSec = (contentRect.width() * contentRect.height()) / (paintEnd - paintStart); @@ -3880,9 +3776,8 @@ void WebViewImpl::setIsAcceleratedCompositingActive(bool active) if (!active) { m_isAcceleratedCompositingActive = false; // We need to finish all GL rendering before sending didDeactivateCompositor() to prevent - // flickering when compositing turns off. This is only necessary if we're not in - // force-compositing-mode. - if (m_layerTreeView && !page()->settings()->forceCompositingMode()) + // flickering when compositing turns off. + if (m_layerTreeView) m_layerTreeView->finishAllRendering(); m_client->didDeactivateCompositor(); } else if (m_layerTreeView) { @@ -4026,22 +3921,15 @@ void WebViewImpl::applyScrollAndScale(const WebSize& scrollDelta, float pageScal mainFrameImpl()->frameView()->scrollBy(scrollDelta); } else { // The page scale changed, so apply a scale and scroll in a single - // operation. + // operation. The old scroll offset (and passed-in delta) are + // in the old coordinate space, so we first need to multiply them + // by the page scale delta. WebSize scrollOffset = mainFrame()->scrollOffset(); scrollOffset.width += scrollDelta.width; scrollOffset.height += scrollDelta.height; - - WebPoint scrollPoint(scrollOffset.width, scrollOffset.height); - if (!m_page->settings()->applyPageScaleFactorInCompositor()) { - // The old scroll offset (and passed-in delta) are in the old - // coordinate space, so we first need to multiply them by the page - // scale delta. - scrollPoint.x = scrollPoint.x * pageScaleDelta; - scrollPoint.y = scrollPoint.y * pageScaleDelta; - } - - setPageScaleFactor(pageScaleFactor() * pageScaleDelta, scrollPoint); - m_doubleTapZoomInEffect = false; + WebPoint scaledScrollOffset(scrollOffset.width * pageScaleDelta, + scrollOffset.height * pageScaleDelta); + setPageScaleFactor(pageScaleFactor() * pageScaleDelta, scaledScrollOffset); } } @@ -4132,8 +4020,12 @@ void WebViewImpl::selectAutofillSuggestionAtIndex(unsigned listIndex) m_autofillPopupClient->valueChanged(listIndex); } -bool WebViewImpl::detectContentOnTouch(const WebPoint& position) +bool WebViewImpl::detectContentOnTouch(const WebPoint& position, WebInputEvent::Type touchType) { + ASSERT(touchType == WebInputEvent::GestureTap + || touchType == WebInputEvent::GestureTwoFingerTap + || touchType == WebInputEvent::GestureLongPress); + HitTestResult touchHit = hitTestResultForWindowPos(position); if (touchHit.isContentEditable()) @@ -4146,14 +4038,22 @@ bool WebViewImpl::detectContentOnTouch(const WebPoint& position) // Ignore when tapping on links or nodes listening to click events, unless the click event is on the // body element, in which case it's unlikely that the original node itself was intended to be clickable. for (; node && !node->hasTagName(HTMLNames::bodyTag); node = node->parentNode()) { - if (node->isLink() || node->willRespondToTouchEvents() || node->willRespondToMouseClickEvents()) + if (node->isLink() || (touchType == WebInputEvent::GestureTap + && (node->willRespondToTouchEvents() || node->willRespondToMouseClickEvents()))) { return false; + } } WebContentDetectionResult content = m_client->detectContentAround(touchHit); if (!content.isValid()) return false; + if (touchType != WebInputEvent::GestureTap) { + // Select the detected content as a block. + focusedFrame()->selectRange(content.range()); + return true; + } + m_client->scheduleContentIntent(content.intent()); return true; } diff --git a/Source/WebKit/chromium/src/WebViewImpl.h b/Source/WebKit/chromium/src/WebViewImpl.h index 47907f124..4c1a974a0 100644 --- a/Source/WebKit/chromium/src/WebViewImpl.h +++ b/Source/WebKit/chromium/src/WebViewImpl.h @@ -392,7 +392,7 @@ public: void mouseContextMenu(const WebMouseEvent&); void mouseDoubleClick(const WebMouseEvent&); - bool detectContentOnTouch(const WebPoint&); + bool detectContentOnTouch(const WebPoint&, WebInputEvent::Type); void startPageScaleAnimation(const WebCore::IntPoint& targetPosition, bool useAnchor, float newScale, double durationInSeconds); void numberOfWheelEventHandlersChanged(unsigned); @@ -561,14 +561,12 @@ public: void fullFramePluginZoomLevelChanged(double zoomLevel); #if ENABLE(GESTURE_EVENTS) - void computeScaleAndScrollForHitRect(const WebRect& hitRect, AutoZoomType, float& scale, WebPoint& scroll, bool& isAnchor); + void computeScaleAndScrollForHitRect(const WebRect& hitRect, AutoZoomType, float& scale, WebPoint& scroll); WebCore::Node* bestTouchLinkNode(WebCore::IntPoint touchEventLocation); void enableTouchHighlight(WebCore::IntPoint touchEventLocation); #endif void animateZoomAroundPoint(const WebCore::IntPoint&, AutoZoomType); - void shouldUseAnimateDoubleTapTimeZeroForTesting(bool); - void loseCompositorContext(int numTimes); void enterFullScreenForElement(WebCore::Element*); @@ -742,12 +740,6 @@ private: float m_savedPageScaleFactor; // 0 means that no page scale factor is saved. WebCore::IntSize m_savedScrollOffset; - // Whether the current scale was achieved by zooming in with double tap. - bool m_doubleTapZoomInEffect; - - // Used for testing purposes. - bool m_shouldUseDoubleTapTimeZero; - bool m_contextMenuAllowed; bool m_doingDragAndDrop; diff --git a/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp b/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp index d287b0905..e127cfc6d 100644 --- a/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp +++ b/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp @@ -37,13 +37,13 @@ #include "Blob.h" #include "ScriptExecutionContext.h" #include "WebFileWriter.h" +#include "platform/WebURL.h" #include "WebWorkerBase.h" #include "WorkerContext.h" #include "WorkerFileWriterCallbacksBridge.h" #include "WorkerLoaderProxy.h" #include "WorkerThread.h" #include <public/WebFileSystem.h> -#include <public/WebURL.h> #include <wtf/Assertions.h> using namespace WebKit; diff --git a/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp b/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp index 755802380..bd9b1761a 100644 --- a/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp +++ b/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp @@ -39,13 +39,13 @@ #include "WebFileInfo.h" #include "WebFileSystemCallbacks.h" #include "WebFileSystemEntry.h" +#include "platform/WebString.h" +#include "platform/WebURL.h" #include "WebWorkerBase.h" #include "WorkerContext.h" #include "WorkerLoaderProxy.h" #include "WorkerScriptController.h" #include "WorkerThread.h" -#include <public/WebString.h> -#include <public/WebURL.h> #include <wtf/MainThread.h> #include <wtf/Threading.h> #include <wtf/UnusedParam.h> diff --git a/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h b/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h index 10168f53a..5c0a59084 100644 --- a/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h +++ b/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.h @@ -35,8 +35,8 @@ #include "ScriptExecutionContext.h" #include "WebFileError.h" +#include "platform/WebVector.h" #include <public/WebFileSystem.h> -#include <public/WebVector.h> #include <wtf/PassOwnPtr.h> #include <wtf/PassRefPtr.h> #include <wtf/Threading.h> diff --git a/Source/WebKit/chromium/src/js/DevTools.js b/Source/WebKit/chromium/src/js/DevTools.js index bbdbd9805..f555419e9 100644 --- a/Source/WebKit/chromium/src/js/DevTools.js +++ b/Source/WebKit/chromium/src/js/DevTools.js @@ -41,7 +41,6 @@ Preferences.exposeDisableCache = true; Preferences.showDockToRight = true; Preferences.exposeFileSystemInspection = true; - Preferences.experimentsEnabled = false; })();} function buildPlatformExtensionAPI(extensionInfo) diff --git a/Source/WebKit/chromium/src/js/Tests.js b/Source/WebKit/chromium/src/js/Tests.js index 424e41a26..68c6742cc 100644 --- a/Source/WebKit/chromium/src/js/Tests.js +++ b/Source/WebKit/chromium/src/js/Tests.js @@ -555,90 +555,6 @@ TestSuite.prototype.testPauseInSharedWorkerInitialization = function() }; -// Regression test for http://webk.it/97466 -TestSuite.prototype.testPageOverlayUpdate = function() -{ - var test = this; - var records = []; - var dispatchOnRecordType = {} - - function addRecord(event) - { - innerAddRecord(event.data); - } - - function innerAddRecord(record) - { - records.push(record); - if (typeof dispatchOnRecordType[record.type] === "function") - dispatchOnRecordType[record.type](record); - - if (record.children) - record.children.forEach(innerAddRecord); - } - - function populatePage() - { - var div1 = document.createElement("div"); - div1.id = "div1"; - // Force accelerated compositing. - div1.style.webkitTransform = "translateZ(0)"; - document.body.appendChild(div1); - var div2 = document.createElement("div"); - div2.id = "div2"; - document.body.appendChild(div2); - } - - function step1() - { - WebInspector.timelineManager.addEventListener(WebInspector.TimelineManager.EventTypes.TimelineEventRecorded, addRecord); - WebInspector.timelineManager.start(); - - test.evaluateInConsole_(populatePage.toString() + "; populatePage();" + - "inspect(document.getElementById('div1'))", function() {}); - WebInspector.notifications.addEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, step2); - } - - function step2() - { - WebInspector.notifications.removeEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, step2); - setTimeout(step3, 500); - } - - function step3() - { - test.evaluateInConsole_("inspect(document.getElementById('div2'))", function() {}); - WebInspector.notifications.addEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, step4); - } - - function step4() - { - WebInspector.notifications.removeEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, step4); - dispatchOnRecordType.TimeStamp = step5; - test.evaluateInConsole_("console.timeStamp('ready')", function() {}); - } - - function step5() - { - var types = {}; - WebInspector.timelineManager.stop(); - WebInspector.timelineManager.removeEventListener(WebInspector.TimelineManager.EventTypes.TimelineEventRecorded, addRecord); - for (var i = 0; i < records.length; ++i) - types[records[i].type] = (types[records[i].type] || 0) + 1; - - var frameCount = types["BeginFrame"]; - // There should be at least two updates caused by selection of nodes. - test.assertTrue(frameCount >= 2, "Not enough DevTools overlay updates"); - // We normally expect up to 3 frames, but allow for a bit more in case - // of some unexpected invalidations. - test.assertTrue(frameCount < 6, "Too many updates caused by DevTools overlay"); - test.releaseControl(); - } - - step1(); - this.takeControl(); -} - TestSuite.prototype.waitForTestResultsInConsole = function() { var messages = WebInspector.console.messages; diff --git a/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm b/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm index 4854ae218..b3a22fee1 100644 --- a/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm +++ b/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm @@ -135,6 +135,9 @@ static bool isKeypadEvent(NSEvent* event) return false; } + if ([event modifierFlags] & NSNumericPadKeyMask) + return true; + switch ([event keyCode]) { case 71: // Clear case 81: // = diff --git a/Source/WebKit/chromium/src/painting/PaintAggregator.cpp b/Source/WebKit/chromium/src/painting/PaintAggregator.cpp index 89f28d33d..a373342ca 100644 --- a/Source/WebKit/chromium/src/painting/PaintAggregator.cpp +++ b/Source/WebKit/chromium/src/painting/PaintAggregator.cpp @@ -30,7 +30,10 @@ #include "config.h" #include "PaintAggregator.h" -#include <public/Platform.h> + +#include "WebKit.h" +#include "platform/WebKitPlatformSupport.h" + using namespace WebCore; namespace WebKit { diff --git a/Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp b/Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp index 79e57039a..f9a136c35 100644 --- a/Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp +++ b/Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp @@ -30,8 +30,6 @@ #include "GraphicsContext3DPrivate.h" #include <gmock/gmock.h> #include <gtest/gtest.h> -#include <public/Platform.h> -#include <public/WebThread.h> using namespace WebCore; using testing::InSequence; @@ -49,15 +47,6 @@ public: { } - virtual size_t storageAllocatedForRecording() OVERRIDE - { - // Because the fake layer has no canvas to query, just - // return status quo. Allocation changes that would normally be - // initiated by the canvas can be faked by invoking - // storageAllocatedForRecordingChanged directly from the test code. - return m_bytesAllocated; - } - void fakeFreeableBytes(size_t size) { m_freeableBytes = size; @@ -76,7 +65,6 @@ public: virtual void flush() OVERRIDE { - flushedDrawCommands(); m_flushCount++; } @@ -145,83 +133,6 @@ protected: EXPECT_EQ((size_t)11, layer.bytesAllocated()); // flush drops the layer from manager's tracking list EXPECT_FALSE(manager.isInList(&layer)); } - - void doDeferredFrameTestTask(FakeCanvas2DLayerBridge* layer, bool skipCommands) - { - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - layer->contextAcquired(); - layer->storageAllocatedForRecordingChanged(1); - EXPECT_TRUE(Canvas2DLayerManager::get().m_taskObserverActive); - if (skipCommands) { - layer->contextAcquired(); - layer->storageAllocatedForRecordingChanged(0); - layer->skippedPendingDrawCommands(); - } - WebKit::Platform::current()->currentThread()->exitRunLoop(); - } - - class DeferredFrameTestTask : public WebKit::WebThread::Task { - public: - DeferredFrameTestTask(Canvas2DLayerManagerTest* test, FakeCanvas2DLayerBridge* layer, bool skipCommands) - { - m_test = test; - m_layer = layer; - m_skipCommands = skipCommands; - } - - virtual void run() OVERRIDE - { - m_test->doDeferredFrameTestTask(m_layer, m_skipCommands); - } - private: - Canvas2DLayerManagerTest* m_test; - FakeCanvas2DLayerBridge* m_layer; - bool m_skipCommands; - }; - - void deferredFrameTest() - { - Canvas2DLayerManager::get().init(10, 10); - FakeCanvas2DLayerBridge fakeLayer; - WebKit::Platform::current()->currentThread()->postTask(new DeferredFrameTestTask(this, &fakeLayer, true)); - WebKit::Platform::current()->currentThread()->enterRunLoop(); - // Verify that didProcessTask was called upon completion - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - // Verify that no flush was performed because frame is fresh - EXPECT_EQ(0, fakeLayer.m_flushCount); - - // Verify that no flushes are triggered as long as frame are fresh - WebKit::Platform::current()->currentThread()->postTask(new DeferredFrameTestTask(this, &fakeLayer, true)); - WebKit::Platform::current()->currentThread()->enterRunLoop(); - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - EXPECT_EQ(0, fakeLayer.m_flushCount); - - WebKit::Platform::current()->currentThread()->postTask(new DeferredFrameTestTask(this, &fakeLayer, true)); - WebKit::Platform::current()->currentThread()->enterRunLoop(); - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - EXPECT_EQ(0, fakeLayer.m_flushCount); - - // Verify that a flush is triggered every two frames when they are stale. - WebKit::Platform::current()->currentThread()->postTask(new DeferredFrameTestTask(this, &fakeLayer, false)); - WebKit::Platform::current()->currentThread()->enterRunLoop(); - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - EXPECT_EQ(1, fakeLayer.m_flushCount); - - WebKit::Platform::current()->currentThread()->postTask(new DeferredFrameTestTask(this, &fakeLayer, false)); - WebKit::Platform::current()->currentThread()->enterRunLoop(); - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - EXPECT_EQ(1, fakeLayer.m_flushCount); - - WebKit::Platform::current()->currentThread()->postTask(new DeferredFrameTestTask(this, &fakeLayer, false)); - WebKit::Platform::current()->currentThread()->enterRunLoop(); - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - EXPECT_EQ(2, fakeLayer.m_flushCount); - - WebKit::Platform::current()->currentThread()->postTask(new DeferredFrameTestTask(this, &fakeLayer, false)); - WebKit::Platform::current()->currentThread()->enterRunLoop(); - EXPECT_FALSE(Canvas2DLayerManager::get().m_taskObserverActive); - EXPECT_EQ(2, fakeLayer.m_flushCount); - } }; namespace { @@ -241,10 +152,5 @@ TEST_F(Canvas2DLayerManagerTest, testFlushEviction) flushEvictionTest(); } -TEST_F(Canvas2DLayerManagerTest, testDeferredFrame) -{ - deferredFrameTest(); -} - } // namespace diff --git a/Source/WebKit/chromium/tests/DateTimeFormatTest.cpp b/Source/WebKit/chromium/tests/DateTimeFormatTest.cpp index a2c5e9f0a..1c006abaf 100644 --- a/Source/WebKit/chromium/tests/DateTimeFormatTest.cpp +++ b/Source/WebKit/chromium/tests/DateTimeFormatTest.cpp @@ -26,7 +26,7 @@ #include "config.h" #include "DateTimeFormat.h" -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) #include <gtest/gtest.h> #include <wtf/text/CString.h> #include <wtf/text/StringBuilder.h> @@ -280,7 +280,7 @@ TEST_F(DateTimeFormatTest, SingleLowerCaseCharacter) EXPECT_EQ(DateTimeFormat::FieldTypeSecond, single('s')); EXPECT_EQ(DateTimeFormat::FieldTypeExtendedYear, single('u')); EXPECT_EQ(DateTimeFormat::FieldTypeNonLocationZone, single('v')); - EXPECT_EQ(DateTimeFormat::FieldTypeWeekOfMonth, single('W')); + EXPECT_EQ(DateTimeFormat::FieldTypeWeekOfMonth, single('w')); EXPECT_EQ(DateTimeFormat::FieldTypeYear, single('y')); EXPECT_EQ(DateTimeFormat::FieldTypeZone, single('z')); } @@ -313,7 +313,7 @@ TEST_F(DateTimeFormatTest, SingleUpperCaseCharacter) EXPECT_EQ(DateTimeFormat::FieldTypeMonth, single('M')); EXPECT_EQ(DateTimeFormat::FieldTypeQuater, single('Q')); EXPECT_EQ(DateTimeFormat::FieldTypeFractionalSecond, single('S')); - EXPECT_EQ(DateTimeFormat::FieldTypeWeekOfYear, single('w')); + EXPECT_EQ(DateTimeFormat::FieldTypeWeekOfYear, single('W')); EXPECT_EQ(DateTimeFormat::FieldTypeYearOfWeekOfYear, single('Y')); EXPECT_EQ(DateTimeFormat::FieldTypeRFC822Zone, single('Z')); } diff --git a/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp b/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp index 0ce84257b..812246e57 100644 --- a/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp +++ b/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp @@ -50,7 +50,7 @@ namespace { class MockGraphicsLayerClient : public GraphicsLayerClient { public: virtual void notifyAnimationStarted(const GraphicsLayer*, double time) OVERRIDE { } - virtual void notifyFlushRequired(const GraphicsLayer*) OVERRIDE { } + virtual void notifySyncRequired(const GraphicsLayer*) OVERRIDE { } virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect& inClip) OVERRIDE { } virtual bool showDebugBorders(const GraphicsLayer*) const OVERRIDE { return false; } virtual bool showRepaintCounter(const GraphicsLayer*) const OVERRIDE { return false; } diff --git a/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp b/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp index 2cf2a1f88..b6b36671d 100644 --- a/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp +++ b/Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp @@ -57,12 +57,12 @@ TEST(IDBDatabaseBackendTest, BackingStoreRetention) EXPECT_GT(backingStore->refCount(), 1); const bool autoIncrement = false; - RefPtr<IDBObjectStoreBackendImpl> store = IDBObjectStoreBackendImpl::create(db.get(), 1, "store", IDBKeyPath("keyPath"), autoIncrement, 0); + RefPtr<IDBObjectStoreBackendImpl> store = IDBObjectStoreBackendImpl::create(db.get(), "store", IDBKeyPath("keyPath"), autoIncrement); EXPECT_GT(backingStore->refCount(), 1); const bool unique = false; const bool multiEntry = false; - RefPtr<IDBIndexBackendImpl> index = IDBIndexBackendImpl::create(db.get(), store.get(), -1, "index", IDBKeyPath("keyPath"), unique, multiEntry); + RefPtr<IDBIndexBackendImpl> index = IDBIndexBackendImpl::create(db.get(), store.get(), "index", IDBKeyPath("keyPath"), unique, multiEntry); EXPECT_GT(backingStore->refCount(), 1); db.clear(); @@ -148,7 +148,7 @@ public: } virtual IDBDatabaseMetadata metadata() const { return IDBDatabaseMetadata(); } - virtual PassRefPtr<IDBObjectStoreBackendInterface> createObjectStore(int64_t, const String& name, const IDBKeyPath&, bool autoIncrement, IDBTransactionBackendInterface*, ExceptionCode&) { return 0; } + virtual PassRefPtr<IDBObjectStoreBackendInterface> createObjectStore(const String& name, const IDBKeyPath&, bool autoIncrement, IDBTransactionBackendInterface*, ExceptionCode&) { return 0; } virtual void deleteObjectStore(const String& name, IDBTransactionBackendInterface*, ExceptionCode&) { } virtual void setVersion(const String& version, PassRefPtr<IDBCallbacks>, PassRefPtr<IDBDatabaseCallbacks>, ExceptionCode&) { } virtual PassRefPtr<IDBTransactionBackendInterface> transaction(DOMStringList* storeNames, unsigned short mode, ExceptionCode&) { return 0; } diff --git a/Source/WebKit/chromium/tests/IDBFakeBackingStore.h b/Source/WebKit/chromium/tests/IDBFakeBackingStore.h index c59dce675..457ae3745 100644 --- a/Source/WebKit/chromium/tests/IDBFakeBackingStore.h +++ b/Source/WebKit/chromium/tests/IDBFakeBackingStore.h @@ -33,14 +33,14 @@ namespace WebCore { class IDBFakeBackingStore : public IDBBackingStore { public: virtual void getDatabaseNames(Vector<String>& foundNames) OVERRIDE { } - virtual bool getIDBDatabaseMetaData(const String& name, String& foundStringVersion, int64_t& foundIntVersion, int64_t& foundId, int64_t& maxObjectStoreId) OVERRIDE { return false; } + virtual bool getIDBDatabaseMetaData(const String& name, String& foundVersion, int64_t& foundIntVersion, int64_t& foundId) OVERRIDE { return false; } virtual bool createIDBDatabaseMetaData(const String& name, const String& version, int64_t intVersion, int64_t& rowId) OVERRIDE { return true; } virtual bool updateIDBDatabaseMetaData(Transaction*, int64_t rowId, const String& version) OVERRIDE { return false; } virtual bool updateIDBDatabaseIntVersion(Transaction*, int64_t rowId, int64_t version) OVERRIDE { return false; } virtual bool deleteDatabase(const String& name) OVERRIDE { return false; } - virtual void getObjectStores(int64_t databaseId, Vector<int64_t>& foundIds, Vector<String>& foundNames, Vector<IDBKeyPath>& foundKeyPaths, Vector<bool>& foundAutoIncrementFlags, Vector<int64_t>& foundMaxIndexIds) OVERRIDE { } - virtual bool createObjectStore(Transaction*, int64_t databaseId, int64_t objectStoreId, const String& name, const IDBKeyPath&, bool autoIncrement) OVERRIDE { return false; }; + virtual void getObjectStores(int64_t databaseId, Vector<int64_t>& foundIds, Vector<String>& foundNames, Vector<IDBKeyPath>& foundKeyPaths, Vector<bool>& foundAutoIncrementFlags) OVERRIDE { } + virtual bool createObjectStore(Transaction*, int64_t databaseId, const String& name, const IDBKeyPath& keyPath, bool autoIncrement, int64_t& assignedObjectStoreId) OVERRIDE { return false; } virtual void deleteObjectStore(Transaction*, int64_t databaseId, int64_t objectStoreId) OVERRIDE { } virtual PassRefPtr<ObjectStoreRecordIdentifier> createInvalidRecordIdentifier() OVERRIDE { return PassRefPtr<ObjectStoreRecordIdentifier>(); } @@ -56,7 +56,7 @@ public: virtual bool forEachObjectStoreRecord(Transaction*, int64_t databaseId, int64_t objectStoreId, ObjectStoreRecordCallback&) OVERRIDE { return false; } virtual void getIndexes(int64_t databaseId, int64_t objectStoreId, Vector<int64_t>& foundIds, Vector<String>& foundNames, Vector<IDBKeyPath>& foundKeyPaths, Vector<bool>& foundUniqueFlags, Vector<bool>& foundMultiEntryFlags) OVERRIDE { } - virtual bool createIndex(Transaction*, int64_t databaseId, int64_t objectStoreId, int64_t indexId, const String& name, const IDBKeyPath&, bool isUnique, bool isMultiEntry) OVERRIDE { return false; }; + virtual bool createIndex(Transaction*, int64_t databaseId, int64_t objectStoreId, const String& name, const IDBKeyPath& keyPath, bool isUnique, bool isMultiEntry, int64_t& indexId) OVERRIDE { return false; } virtual void deleteIndex(Transaction*, int64_t databaseId, int64_t objectStoreId, int64_t indexId) OVERRIDE { } virtual bool putIndexDataForRecord(Transaction*, int64_t databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey&, const ObjectStoreRecordIdentifier*) OVERRIDE { return false; } virtual bool deleteIndexDataForRecord(Transaction*, int64_t databaseId, int64_t objectStoreId, int64_t indexId, const ObjectStoreRecordIdentifier*) OVERRIDE { return false; } diff --git a/Source/WebKit/chromium/tests/IDBRequestTest.cpp b/Source/WebKit/chromium/tests/IDBRequestTest.cpp index 52a038d5b..9e2459d39 100644 --- a/Source/WebKit/chromium/tests/IDBRequestTest.cpp +++ b/Source/WebKit/chromium/tests/IDBRequestTest.cpp @@ -58,21 +58,6 @@ TEST(IDBRequestTest, EventsAfterStopping) request->onSuccess(IDBKey::createInvalid(), IDBKey::createInvalid(), SerializedScriptValue::nullValue()); } -TEST(IDBRequestTest, AbortErrorAfterAbort) -{ - ScriptExecutionContext* context = 0; - IDBTransaction* transaction = 0; - RefPtr<IDBRequest> request = IDBRequest::create(context, IDBAny::createInvalid(), transaction); - EXPECT_EQ(request->readyState(), "pending"); - - // Simulate the IDBTransaction having received onAbort from back end and aborting the request: - request->abort(); - - // Now simulate the back end having fired an abort error at the request to clear up any intermediaries. - // Ensure an assertion is not raised. - request->onError(IDBDatabaseError::create(IDBDatabaseException::IDB_ABORT_ERR, "Description goes here.")); -} - } // namespace #endif // ENABLE(INDEXED_DATABASE) diff --git a/Source/WebKit/chromium/tests/ImageLayerChromiumTest.cpp b/Source/WebKit/chromium/tests/ImageLayerChromiumTest.cpp index bfb03ed30..55212e5e8 100644 --- a/Source/WebKit/chromium/tests/ImageLayerChromiumTest.cpp +++ b/Source/WebKit/chromium/tests/ImageLayerChromiumTest.cpp @@ -38,7 +38,7 @@ namespace { class MockGraphicsLayerClient : public GraphicsLayerClient { public: virtual void notifyAnimationStarted(const GraphicsLayer*, double time) { } - virtual void notifyFlushRequired(const GraphicsLayer*) { } + virtual void notifySyncRequired(const GraphicsLayer*) { } virtual void paintContents(const GraphicsLayer*, GraphicsContext&, GraphicsLayerPaintingPhase, const IntRect& inClip) { } virtual bool showDebugBorders(const GraphicsLayer*) const { return false; } virtual bool showRepaintCounter(const GraphicsLayer*) const { return false; } diff --git a/Source/WebKit/chromium/tests/LocaleMacTest.cpp b/Source/WebKit/chromium/tests/LocaleMacTest.cpp index 8b1c2f576..afcd0b889 100644 --- a/Source/WebKit/chromium/tests/LocaleMacTest.cpp +++ b/Source/WebKit/chromium/tests/LocaleMacTest.cpp @@ -57,13 +57,6 @@ protected: return date; } - DateComponents timeComponents(int hour, int minute, int second, int millisecond) - { - DateComponents date; - date.setMillisecondsSinceMidnight(hour * msPerHour + minute * msPerMinute + second * msPerSecond + millisecond); - return date; - } - double msForDate(int year, int month, int day) { return dateToDaysFrom1970(year, month, day) * msPerDay; @@ -72,19 +65,13 @@ protected: String formatDate(const String& localeString, int year, int month, int day) { OwnPtr<LocaleMac> locale = LocaleMac::create(localeString); - return locale->formatDateTime(dateComponents(year, month, day)); - } - - String formatTime(const String& localeString, int hour, int minute, int second, int millisecond, bool useShortFormat) - { - OwnPtr<LocaleMac> locale = LocaleMac::create(localeString); - return locale->formatDateTime(timeComponents(hour, minute, second, millisecond), (useShortFormat ? Localizer::FormatTypeShort : Localizer::FormatTypeMedium)); + return locale->formatDate(dateComponents(year, month, day)); } double parseDate(const String& localeString, const String& dateString) { OwnPtr<LocaleMac> locale = LocaleMac::create(localeString); - return locale->parseDateTime(dateString, DateComponents::Date); + return locale->parseDate(dateString); } #if ENABLE(CALENDAR_PICKER) @@ -111,15 +98,9 @@ protected: OwnPtr<LocaleMac> locale = LocaleMac::create(localeString); return locale->weekDayShortLabels()[index]; } - - bool isRTL(const String& localeString) - { - OwnPtr<LocaleMac> locale = LocaleMac::create(localeString); - return locale->isRTL(); - } #endif -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) String timeFormat(const String& localeString) { OwnPtr<LocaleMac> locale = LocaleMac::create(localeString); @@ -153,27 +134,6 @@ TEST_F(LocaleMacTest, formatDate) EXPECT_STREQ("05/04/27", formatDate("ja_JP", 2005, April, 27).utf8().data()); } -TEST_F(LocaleMacTest, formatTime) -{ - EXPECT_STREQ("1:23 PM", formatTime("en_US", 13, 23, 00, 000, true).utf8().data()); - EXPECT_STREQ("13:23", formatTime("fr_FR", 13, 23, 00, 000, true).utf8().data()); - EXPECT_STREQ("13:23", formatTime("ja_JP", 13, 23, 00, 000, true).utf8().data()); - EXPECT_STREQ("\xD9\xA1:\xD9\xA2\xD9\xA3 \xD9\x85", formatTime("ar", 13, 23, 00, 000, true).utf8().data()); - EXPECT_STREQ("\xDB\xB1\xDB\xB3:\xDB\xB2\xDB\xB3", formatTime("fa", 13, 23, 00, 000, true).utf8().data()); - - EXPECT_STREQ("12:00 AM", formatTime("en_US", 00, 00, 00, 000, true).utf8().data()); - EXPECT_STREQ("00:00", formatTime("fr_FR", 00, 00, 00, 000, true).utf8().data()); - EXPECT_STREQ("0:00", formatTime("ja_JP", 00, 00, 00, 000, true).utf8().data()); - EXPECT_STREQ("\xD9\xA1\xD9\xA2:\xD9\xA0\xD9\xA0 \xD8\xB5", formatTime("ar", 00, 00, 00, 000, true).utf8().data()); - EXPECT_STREQ("\xDB\xB0:\xDB\xB0\xDB\xB0", formatTime("fa", 00, 00, 00, 000, true).utf8().data()); - - EXPECT_STREQ("7:07:07.007 AM", formatTime("en_US", 07, 07, 07, 007, false).utf8().data()); - EXPECT_STREQ("07:07:07,007", formatTime("fr_FR", 07, 07, 07, 007, false).utf8().data()); - EXPECT_STREQ("7:07:07.007", formatTime("ja_JP", 07, 07, 07, 007, false).utf8().data()); - EXPECT_STREQ("\xD9\xA7:\xD9\xA0\xD9\xA7:\xD9\xA0\xD9\xA7\xD9\xAB\xD9\xA0\xD9\xA0\xD9\xA7 \xD8\xB5", formatTime("ar", 07, 07, 07, 007, false).utf8().data()); - EXPECT_STREQ("\xDB\xB7:\xDB\xB0\xDB\xB7:\xDB\xB0\xDB\xB7\xD9\xAB\xDB\xB0\xDB\xB0\xDB\xB7", formatTime("fa", 07, 07, 07, 007, false).utf8().data()); -} - TEST_F(LocaleMacTest, parseDate) { EXPECT_EQ(msForDate(2005, April, 27), parseDate("en_US", "April 27, 2005")); @@ -225,17 +185,9 @@ TEST_F(LocaleMacTest, weekDayShortLabels) EXPECT_STREQ("\xE6\xB0\xB4", weekDayShortLabel("ja_JP", Wednesday).utf8().data()); EXPECT_STREQ("\xE5\x9C\x9F", weekDayShortLabel("ja_JP", Saturday).utf8().data()); } - -TEST_F(LocaleMacTest, isRTL) -{ - EXPECT_TRUE(isRTL("ar-eg")); - EXPECT_FALSE(isRTL("en-us")); - EXPECT_FALSE(isRTL("ja-jp")); - EXPECT_FALSE(isRTL("**invalid**")); -} #endif -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) TEST_F(LocaleMacTest, timeFormat) { EXPECT_STREQ("h:mm:ss a", timeFormat("en_US").utf8().data()); diff --git a/Source/WebKit/chromium/tests/LocaleWinTest.cpp b/Source/WebKit/chromium/tests/LocaleWinTest.cpp index 25cf704b6..a3719f0d3 100644 --- a/Source/WebKit/chromium/tests/LocaleWinTest.cpp +++ b/Source/WebKit/chromium/tests/LocaleWinTest.cpp @@ -87,13 +87,13 @@ protected: String formatDate(LCID lcid, int year, int month, int day) { OwnPtr<LocaleWin> locale = LocaleWin::create(lcid); - return locale->formatDateTime(dateComponents(year, month, day)); + return locale->formatDate(dateComponents(year, month, day)); } double parseDate(LCID lcid, const String& dateString) { OwnPtr<LocaleWin> locale = LocaleWin::create(lcid); - return locale->parseDateTime(dateString, DateComponents::Date); + return locale->parseDate(dateString); } #if ENABLE(CALENDAR_PICKER) @@ -120,15 +120,9 @@ protected: OwnPtr<LocaleWin> locale = LocaleWin::create(lcid); return locale->weekDayShortLabels()[index]; } - - bool isRTL(LCID lcid) - { - OwnPtr<LocaleWin> locale = LocaleWin::create(lcid); - return locale->isRTL(); - } #endif -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) String timeFormat(LCID lcid) { OwnPtr<LocaleWin> locale = LocaleWin::create(lcid); @@ -328,24 +322,9 @@ TEST_F(LocaleWinTest, weekDayShortLabels) EXPECT_STREQ("\xE6\xB0\xB4", weekDayShortLabel(JapaneseJP, Wednesday).utf8().data()); EXPECT_STREQ("\xE5\x9C\x9F", weekDayShortLabel(JapaneseJP, Saturday).utf8().data()); } - -TEST_F(LocaleWinTest, isRTL) -{ - EXPECT_TRUE(isRTL(ArabicEG)); - EXPECT_FALSE(isRTL(EnglishUS)); -} - #endif -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) -TEST_F(LocaleWinTest, dateFormat) -{ - EXPECT_STREQ("y'-'M'-'d", LocaleWin::dateFormat("y-M-d").utf8().data()); - EXPECT_STREQ("''yy'-'''MM'''-'dd", LocaleWin::dateFormat("''yy-''MM''-dd").utf8().data()); - EXPECT_STREQ("yyyy'-''''-'MMM'''''-'dd", LocaleWin::dateFormat("yyyy-''''-MMM''''-dd").utf8().data()); - EXPECT_STREQ("yyyy'-'''''MMMM'-'dd", LocaleWin::dateFormat("yyyy-''''MMMM-dd").utf8().data()); -} - +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) TEST_F(LocaleWinTest, timeFormat) { EXPECT_STREQ("h:mm:ss a", timeFormat(EnglishUS).utf8().data()); diff --git a/Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp b/Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp index 771a3cbc0..749f91038 100644 --- a/Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp +++ b/Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp @@ -30,7 +30,7 @@ #include "config.h" -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) #include "LocaleICU.h" #include <gtest/gtest.h> @@ -105,12 +105,6 @@ protected: OwnPtr<LocaleICU> locale = LocaleICU::create(localeString); return Labels(locale->timeAMPMLabels()); } - - bool isRTL(const char* localeString) - { - OwnPtr<LocaleICU> locale = LocaleICU::create(localeString); - return locale->isRTL(); - } }; std::ostream& operator<<(std::ostream& os, const LocalizedDateICUTest::Labels& labels) @@ -118,14 +112,6 @@ std::ostream& operator<<(std::ostream& os, const LocalizedDateICUTest::Labels& l return os << labels.toString().utf8().data(); } -TEST_F(LocalizedDateICUTest, isRTL) -{ - EXPECT_TRUE(isRTL("ar-EG")); - EXPECT_FALSE(isRTL("en-us")); - EXPECT_FALSE(isRTL("ja-jp")); - EXPECT_FALSE(isRTL("**invalid**")); -} - TEST_F(LocalizedDateICUTest, localizedDateFormatText) { // Note: EXPECT_EQ(String, String) doesn't print result as string. diff --git a/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp b/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp index 6facdc1a1..ec7de4e9e 100644 --- a/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp +++ b/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp @@ -80,7 +80,7 @@ TEST(LocalizedNumberICUTest, Reversible) testNumbers("zh_TW"); } -#if ENABLE(INPUT_MULTIPLE_FIELDS_UI) +#if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) static String testDecimalSeparator(const AtomicString& locale) { diff --git a/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp b/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp new file mode 100644 index 000000000..21ce96316 --- /dev/null +++ b/Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp @@ -0,0 +1,443 @@ +/* + * Copyright (C) 2012 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are + * met: + * + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following disclaimer + * in the documentation and/or other materials provided with the + * distribution. + * * Neither the name of Google Inc. nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include "config.h" + +#include "DataRef.h" +#include "MemoryInstrumentationImpl.h" +#include "WebCoreMemoryInstrumentation.h" + +#include <gtest/gtest.h> + +#include <wtf/HashSet.h> +#include <wtf/MemoryInstrumentationVector.h> +#include <wtf/RefCounted.h> +#include <wtf/Vector.h> +#include <wtf/text/AtomicString.h> +#include <wtf/text/CString.h> +#include <wtf/text/StringImpl.h> +#include <wtf/text/WTFString.h> + +using namespace WebCore; + +namespace { + +class NotInstrumented { +public: + NotInstrumented(const char* = 0) { } + char m_data[42]; +}; + +class Instrumented { +public: + Instrumented() : m_notInstrumented(new NotInstrumented) { } + virtual ~Instrumented() { delete m_notInstrumented; } + + virtual void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_notInstrumented); + } + NotInstrumented* m_notInstrumented; +}; + +TEST(MemoryInstrumentationTest, sizeOf) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + Instrumented instrumented; + impl.addRootObject(instrumented); + EXPECT_EQ(sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, nullCheck) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + Instrumented* instrumented = 0; + impl.addRootObject(instrumented); + EXPECT_EQ(0u, impl.reportedSizeForAllTypes()); + EXPECT_EQ(0, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, ptrVsRef) +{ + { + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + Instrumented instrumented; + impl.addRootObject(&instrumented); + EXPECT_EQ(sizeof(Instrumented) + sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); + } + { + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + Instrumented instrumented; + impl.addRootObject(instrumented); + EXPECT_EQ(sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); + } +} + +TEST(MemoryInstrumentationTest, ownPtr) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + OwnPtr<Instrumented> instrumented(adoptPtr(new Instrumented)); + impl.addRootObject(instrumented); + EXPECT_EQ(sizeof(Instrumented) + sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); +} + +class InstrumentedRefPtr : public RefCounted<InstrumentedRefPtr> { +public: + InstrumentedRefPtr() : m_notInstrumented(new NotInstrumented) { } + virtual ~InstrumentedRefPtr() { delete m_notInstrumented; } + static PassRefPtr<InstrumentedRefPtr> create() { return adoptRef(new InstrumentedRefPtr()); } + + virtual void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_notInstrumented); + } + NotInstrumented* m_notInstrumented; +}; + +TEST(MemoryInstrumentationTest, dataRef) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + DataRef<InstrumentedRefPtr> instrumentedRefPtr; + instrumentedRefPtr.init(); + impl.addRootObject(instrumentedRefPtr); + EXPECT_EQ(sizeof(InstrumentedRefPtr) + sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, refPtr) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + RefPtr<InstrumentedRefPtr> instrumentedRefPtr(adoptRef(new InstrumentedRefPtr)); + impl.addRootObject(instrumentedRefPtr); + EXPECT_EQ(sizeof(InstrumentedRefPtr) + sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); +} + +class InstrumentedWithOwnPtr : public Instrumented { +public: + InstrumentedWithOwnPtr() : m_notInstrumentedOwnPtr(adoptPtr(new NotInstrumented)) { } + + virtual void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::CSS); + Instrumented::reportMemoryUsage(memoryObjectInfo); + info.addMember(m_notInstrumentedOwnPtr); + } + OwnPtr<NotInstrumented> m_notInstrumentedOwnPtr; +}; + +TEST(MemoryInstrumentationTest, ownPtrNotInstrumented) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedWithOwnPtr instrumentedWithOwnPtr; + impl.addRootObject(instrumentedWithOwnPtr); + EXPECT_EQ(2 * sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); +} + +class InstrumentedUndefined { +public: + InstrumentedUndefined() : m_data(0) { } + + void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this); + } + int m_data; +}; + +class InstrumentedDOM { +public: + InstrumentedDOM() : m_instrumentedUndefined(adoptPtr(new InstrumentedUndefined)) { } + + void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_instrumentedUndefined); + } + OwnPtr<InstrumentedUndefined> m_instrumentedUndefined; +}; + +TEST(MemoryInstrumentationTest, ownerTypePropagation) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + OwnPtr<InstrumentedDOM> instrumentedDOM(adoptPtr(new InstrumentedDOM)); + impl.addRootObject(instrumentedDOM); + EXPECT_EQ(sizeof(InstrumentedDOM) + sizeof(InstrumentedUndefined), impl.reportedSizeForAllTypes()); + EXPECT_EQ(sizeof(InstrumentedDOM) + sizeof(InstrumentedUndefined), impl.totalSize(WebCoreMemoryTypes::DOM)); + EXPECT_EQ(2, visitedObjects.size()); +} + +class NonVirtualInstrumented { +public: + void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_instrumented); + } + + Instrumented m_instrumented; +}; + +TEST(MemoryInstrumentationTest, visitFirstMemberInNonVirtualClass) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + NonVirtualInstrumented nonVirtualInstrumented; + impl.addRootObject(&nonVirtualInstrumented); + EXPECT_EQ(sizeof(NonVirtualInstrumented) + sizeof(NotInstrumented), impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); +} + +template<typename T> +class InstrumentedOwner { +public: + template<typename V> + InstrumentedOwner(const V& value) : m_value(value) { } + InstrumentedOwner() { } + void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_value); + } + + T m_value; +}; + +TEST(MemoryInstrumentationTest, visitStrings) +{ + { + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<String> stringInstrumentedOwner("String"); + stringInstrumentedOwner.m_value.characters(); // Force 16bit shadow creation. + impl.addRootObject(stringInstrumentedOwner); + EXPECT_EQ(sizeof(StringImpl) + stringInstrumentedOwner.m_value.length() * 2, impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); + } + + { + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<AtomicString> atomicStringInstrumentedOwner("AtomicString"); + atomicStringInstrumentedOwner.m_value.string().characters(); // Force 16bit shadow creation. + impl.addRootObject(atomicStringInstrumentedOwner); + EXPECT_EQ(sizeof(StringImpl) + atomicStringInstrumentedOwner.m_value.length() * 2, impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); + } + + { + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<CString> cStringInstrumentedOwner("CString"); + impl.addRootObject(cStringInstrumentedOwner); + EXPECT_EQ(sizeof(WTF::CStringBuffer) + cStringInstrumentedOwner.m_value.length(), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); + } +} + +class TwoPointersToRefPtr { +public: + TwoPointersToRefPtr(const RefPtr<StringImpl>& value) : m_ptr1(&value), m_ptr2(&value) { } + void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_ptr1); + info.addMember(m_ptr2); + } + + const RefPtr<StringImpl>* m_ptr1; + const RefPtr<StringImpl>* m_ptr2; +}; + +TEST(MemoryInstrumentationTest, refPtrPtr) +{ + RefPtr<StringImpl> refPtr; + TwoPointersToRefPtr root(refPtr); + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + impl.addRootObject(root); + EXPECT_EQ(sizeof(RefPtr<StringImpl>), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); +} + +class TwoPointersToOwnPtr { +public: + TwoPointersToOwnPtr(const OwnPtr<NotInstrumented>& value) : m_ptr1(&value), m_ptr2(&value) { } + void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_ptr1); + info.addMember(m_ptr2); + } + + const OwnPtr<NotInstrumented>* m_ptr1; + const OwnPtr<NotInstrumented>* m_ptr2; +}; + +TEST(MemoryInstrumentationTest, ownPtrPtr) +{ + OwnPtr<NotInstrumented> ownPtr; + TwoPointersToOwnPtr root(ownPtr); + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + impl.addRootObject(root); + EXPECT_EQ(sizeof(OwnPtr<NotInstrumented>), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); +} + +template<typename T> +class InstrumentedTemplate { +public: + template<typename V> + InstrumentedTemplate(const V& value) : m_value(value) { } + + template<typename MemoryObjectInfo> + void reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const + { + typename MemoryObjectInfo::ClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); + info.addMember(m_value); + } + + T m_value; +}; + +TEST(MemoryInstrumentationTest, detectReportMemoryUsageMethod) +{ + { + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + + OwnPtr<InstrumentedTemplate<String> > value = adoptPtr(new InstrumentedTemplate<String>("")); + InstrumentedOwner<InstrumentedTemplate<String>* > root(value.get()); + impl.addRootObject(root); + EXPECT_EQ(sizeof(InstrumentedTemplate<String>) + sizeof(StringImpl), impl.reportedSizeForAllTypes()); + // FIXME: it is failing on Chromium Canary bots but works fine locally. + // EXPECT_EQ(2, visitedObjects.size()); + } + { + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + + OwnPtr<InstrumentedTemplate<NotInstrumented> > value = adoptPtr(new InstrumentedTemplate<NotInstrumented>("")); + InstrumentedOwner<InstrumentedTemplate<NotInstrumented>* > root(value.get()); + impl.addRootObject(root); + EXPECT_EQ(sizeof(InstrumentedTemplate<NotInstrumented>), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); + } +} + +TEST(MemoryInstrumentationTest, vectorZeroInlineCapacity) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<Vector<int> > vectorOwner(16); + impl.addRootObject(vectorOwner); + EXPECT_EQ(16 * sizeof(int), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, vectorFieldWithInlineCapacity) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<Vector<int, 4> > vectorOwner; + impl.addRootObject(vectorOwner); + EXPECT_EQ(static_cast<size_t>(0), impl.reportedSizeForAllTypes()); + EXPECT_EQ(0, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, vectorFieldWithInlineCapacityResized) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<Vector<int, 4> > vectorOwner; + vectorOwner.m_value.reserveCapacity(8); + impl.addRootObject(vectorOwner); + EXPECT_EQ(8 * sizeof(int), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, heapAllocatedVectorWithInlineCapacity) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<OwnPtr<Vector<int, 4> > > vectorOwner; + vectorOwner.m_value = adoptPtr(new Vector<int, 4>()); + impl.addRootObject(vectorOwner); + EXPECT_EQ(sizeof(Vector<int, 4>), impl.reportedSizeForAllTypes()); + EXPECT_EQ(1, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, heapAllocatedVectorWithInlineCapacityResized) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + InstrumentedOwner<OwnPtr<Vector<int, 4> > > vectorOwner; + vectorOwner.m_value = adoptPtr(new Vector<int, 4>()); + vectorOwner.m_value->reserveCapacity(8); + impl.addRootObject(vectorOwner); + EXPECT_EQ(8 * sizeof(int) + sizeof(Vector<int, 4>), impl.reportedSizeForAllTypes()); + EXPECT_EQ(2, visitedObjects.size()); +} + +TEST(MemoryInstrumentationTest, vectorWithInstrumentedType) +{ + VisitedObjects visitedObjects; + MemoryInstrumentationImpl impl(visitedObjects); + + typedef Vector<String> StringVector; + OwnPtr<StringVector> value = adoptPtr(new StringVector()); + size_t count = 10; + for (size_t i = 0; i < count; ++i) + value->append("string"); + InstrumentedOwner<StringVector* > root(value.get()); + impl.addRootObject(root); + EXPECT_EQ(sizeof(StringVector) + sizeof(String) * value->capacity() + sizeof(StringImpl) * value->size(), impl.reportedSizeForAllTypes()); + EXPECT_EQ(count + 2, (size_t)visitedObjects.size()); +} + +} // namespace + diff --git a/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp b/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp index d70570114..b4fa4a1db 100644 --- a/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp +++ b/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp @@ -183,15 +183,6 @@ TEST_F(ScrollingCoordinatorChromiumTest, wheelEventHandler) ASSERT_TRUE(rootScrollLayer->haveWheelEventHandlers()); } -TEST_F(ScrollingCoordinatorChromiumTest, clippedBodyTest) -{ - registerMockedHttpURLLoad("clipped-body.html"); - navigateTo(m_baseURL + "clipped-body.html"); - - WebLayer* rootScrollLayer = getRootScrollLayer(); - ASSERT_EQ(0u, rootScrollLayer->nonFastScrollableRegion().size()); -} - #if ENABLE(ACCELERATED_OVERFLOW_SCROLLING) TEST_F(ScrollingCoordinatorChromiumTest, touchOverflowScrolling) { diff --git a/Source/WebKit/chromium/tests/WebFrameTest.cpp b/Source/WebKit/chromium/tests/WebFrameTest.cpp index d4bc4819e..a0049b67e 100644 --- a/Source/WebKit/chromium/tests/WebFrameTest.cpp +++ b/Source/WebKit/chromium/tests/WebFrameTest.cpp @@ -316,256 +316,76 @@ TEST_F(WebFrameTest, CanOverrideMaximumScaleFactor) } #if ENABLE(GESTURE_EVENTS) -class DivAutoZoomTestWebViewClient : public WebViewClient { - public: - virtual WebRect windowRect() OVERRIDE { return m_windowRect; } - - WebRect m_windowRect; -}; - -void setScaleAndScrollAndLayout(WebKit::WebView* webView, WebPoint scroll, float scale) -{ - webView->setPageScaleFactor(scale, WebPoint(scroll.x, scroll.y)); - webView->layout(); -} - TEST_F(WebFrameTest, DivAutoZoomParamsTest) { registerMockedHttpURLLoad("get_scale_for_auto_zoom_into_div_test.html"); - DivAutoZoomTestWebViewClient client; - int viewportWidth = 640; - int viewportHeight = 480; - client.m_windowRect = WebRect(0, 0, viewportWidth, viewportHeight); - WebKit::WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "get_scale_for_auto_zoom_into_div_test.html", true, 0, &client); - webView->enableFixedLayoutMode(true); - webView->setDeviceScaleFactor(2.0f); - webView->resize(WebSize(viewportWidth, viewportHeight)); - webView->setPageScaleFactorLimits(0.01f, 4); - webView->layout(); - - WebRect wideDiv(200, 100, 400, 150); - WebRect tallDiv(200, 300, 400, 800); - WebRect doubleTapPointWide((wideDiv.x + 50) * webView->pageScaleFactor(), - (wideDiv.y + 50) * webView->pageScaleFactor(), 0, 0); - WebRect doubleTapPointTall((tallDiv.x + 50) * webView->pageScaleFactor(), - (tallDiv.y + 50) * webView->pageScaleFactor(), 0, 0); + WebViewImpl* webViewImpl = static_cast<WebViewImpl*>(FrameTestHelpers::createWebViewAndLoad(m_baseURL + "get_scale_for_auto_zoom_into_div_test.html", true)); + int pageWidth = 640; + int pageHeight = 480; + int divPosX = 200; + int divPosY = 200; + int divWidth = 200; + int divHeight = 150; + WebRect doubleTapPoint(250, 250, 0, 0); + webViewImpl->resize(WebSize(pageWidth, pageHeight)); float scale; WebPoint scroll; - bool isAnchor; - - WebViewImpl* webViewImpl = static_cast<WebViewImpl*>(webView); - // Test double-tap zooming into wide div. - webViewImpl->computeScaleAndScrollForHitRect(doubleTapPointWide, WebViewImpl::DoubleTap, scale, scroll, isAnchor); - // The div should horizontally fill the screen (modulo margins), and - // vertically centered (modulo integer rounding). - EXPECT_NEAR(viewportWidth / (float) wideDiv.width, scale, 0.1); - EXPECT_NEAR(wideDiv.x * scale, scroll.x, 20); - int vScroll = (wideDiv.y + wideDiv.height / 2) * scale - (viewportHeight / 2); - EXPECT_NEAR(vScroll, scroll.y, 1); - EXPECT_FALSE(isAnchor); - - setScaleAndScrollAndLayout(webViewImpl, scroll, scale); - - // Test zoom out back to minimum scale. - webViewImpl->computeScaleAndScrollForHitRect(doubleTapPointWide, WebViewImpl::DoubleTap, scale, scroll, isAnchor); - EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); - EXPECT_TRUE(isAnchor); - - setScaleAndScrollAndLayout(webViewImpl, WebPoint(0, 0), scale); - - // Test double-tap zooming into tall div. - webViewImpl->computeScaleAndScrollForHitRect(doubleTapPointTall, WebViewImpl::DoubleTap, scale, scroll, isAnchor); - // The div should start at the top left of the viewport. - EXPECT_NEAR(viewportWidth / (float) tallDiv.width, scale, 0.1); - EXPECT_NEAR(tallDiv.x * scale, scroll.x, 20); - EXPECT_NEAR(tallDiv.y * scale, scroll.y, 20); - EXPECT_FALSE(isAnchor); - - // Test for Non-doubletap scaling - // Test zooming into div. - webViewImpl->computeScaleAndScrollForHitRect(WebRect(250, 250, 10, 10), WebViewImpl::FindInPage, scale, scroll, isAnchor); - EXPECT_NEAR(viewportWidth / (float) wideDiv.width, scale, 0.1); -} - -void simulateDoubleTap(WebViewImpl* webViewImpl, WebPoint& point, float& scale) -{ - WebPoint scaledPoint(static_cast<int>(point.x * webViewImpl->pageScaleFactor()), - static_cast<int>(point.y * webViewImpl->pageScaleFactor())); - webViewImpl->animateZoomAroundPoint(scaledPoint, WebViewImpl::DoubleTap); - webViewImpl->mainFrameImpl()->frameView()->layout(); - scale = webViewImpl->pageScaleFactor(); -} - -TEST_F(WebFrameTest, DivAutoZoomMultipleDivsTest) -{ - registerMockedHttpURLLoad("get_multiple_divs_for_auto_zoom_test.html"); - - DivAutoZoomTestWebViewClient client; - int viewportWidth = 640; - int viewportHeight = 480; - float doubleTapZoomAlreadyLegibleRatio = 1.2f; - client.m_windowRect = WebRect(0, 0, viewportWidth, viewportHeight); - WebKit::WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "get_multiple_divs_for_auto_zoom_test.html", true, 0, &client); - webView->enableFixedLayoutMode(true); - webView->resize(WebSize(viewportWidth, viewportHeight)); - webView->setPageScaleFactorLimits(1, 4); - webView->layout(); - webView->setDeviceScaleFactor(1.5f); - WebViewImpl* webViewImpl = static_cast<WebViewImpl*>(webView); - webViewImpl->shouldUseAnimateDoubleTapTimeZeroForTesting(true); + // Test for Doubletap scaling - WebRect topDiv(200, 100, 200, 150); - WebRect bottomDiv(200, 300, 200, 150); - WebPoint topPoint(topDiv.x + 50, topDiv.y + 50); - WebPoint bottomPoint(bottomDiv.x + 50, bottomDiv.y + 50); - float scale; - setScaleAndScrollAndLayout(webViewImpl, WebPoint(0, 0), (webViewImpl->minimumPageScaleFactor()) * (1 + doubleTapZoomAlreadyLegibleRatio) / 2); - - // Test double tap on two different divs - // After first zoom, we should go back to minimum page scale with a second double tap. - simulateDoubleTap(webViewImpl, topPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->deviceScaleFactor(), scale); - simulateDoubleTap(webViewImpl, bottomPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); - - // If the user pinch zooms after double tap, a second double tap should zoom back to the div. - simulateDoubleTap(webViewImpl, topPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->deviceScaleFactor(), scale); - webViewImpl->applyScrollAndScale(WebSize(), 0.6f); - simulateDoubleTap(webViewImpl, bottomPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->deviceScaleFactor(), scale); -} + // Tests for zooming in and out without clamping. + // Set device scale and scale limits so we dont get clamped. + webViewImpl->setDeviceScaleFactor(4); + webViewImpl->setPageScaleFactorLimits(0, 4 / webViewImpl->deviceScaleFactor()); -TEST_F(WebFrameTest, DivAutoZoomScaleBoundsTest) -{ - registerMockedHttpURLLoad("get_scale_bounds_check_for_auto_zoom_test.html"); - - DivAutoZoomTestWebViewClient client; - int viewportWidth = 640; - int viewportHeight = 480; - float doubleTapZoomAlreadyLegibleRatio = 1.2f; - client.m_windowRect = WebRect(0, 0, viewportWidth, viewportHeight); - WebKit::WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "get_scale_bounds_check_for_auto_zoom_test.html", true, 0, &client); - webView->enableFixedLayoutMode(true); - webView->resize(WebSize(viewportWidth, viewportHeight)); - webView->setPageScaleFactorLimits(1, 4); - webView->layout(); - webView->setDeviceScaleFactor(1.5f); - - WebViewImpl* webViewImpl = static_cast<WebViewImpl*>(webView); - webViewImpl->shouldUseAnimateDoubleTapTimeZeroForTesting(true); - float doubleTapZoomAlreadyLegibleScale = webViewImpl->minimumPageScaleFactor() * doubleTapZoomAlreadyLegibleRatio; - - WebRect div(200, 100, 200, 150); - WebPoint doubleTapPoint(div.x + 50, div.y + 50); - float scale; - - // Test double tap scale bounds. - // minimumPageScale < doubleTapZoomAlreadyLegibleScale < deviceDpiScale - setScaleAndScrollAndLayout(webViewImpl, WebPoint(0, 0), (webViewImpl->minimumPageScaleFactor()) * (1 + doubleTapZoomAlreadyLegibleRatio) / 2); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->deviceScaleFactor(), scale); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->deviceScaleFactor(), scale); - - // Zoom in to reset double_tap_zoom_in_effect flag. - webViewImpl->applyScrollAndScale(WebSize(), 1.1f); - // deviceDpiScale < minimumPageScale < doubleTapZoomAlreadyLegibleScale - webViewImpl->setDeviceScaleFactor(0.5f); - setScaleAndScrollAndLayout(webViewImpl, WebPoint(0, 0), (webViewImpl->minimumPageScaleFactor()) * (1 + doubleTapZoomAlreadyLegibleRatio) / 2); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(doubleTapZoomAlreadyLegibleScale, scale); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); - - // Zoom in to reset double_tap_zoom_in_effect flag. - webViewImpl->applyScrollAndScale(WebSize(), 1.1f); - // minimumPageScale < doubleTapZoomAlreadyLegibleScale < deviceDpiScale - webViewImpl->setDeviceScaleFactor(1.1f); - setScaleAndScrollAndLayout(webViewImpl, WebPoint(0, 0), (webViewImpl->minimumPageScaleFactor()) * (1 + doubleTapZoomAlreadyLegibleRatio) / 2); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(doubleTapZoomAlreadyLegibleScale, scale); - simulateDoubleTap(webViewImpl, doubleTapPoint, scale); - EXPECT_FLOAT_EQ(webViewImpl->minimumPageScaleFactor(), scale); -} + // Test zooming into div. + webViewImpl->computeScaleAndScrollForHitRect(doubleTapPoint, WebViewImpl::DoubleTap, scale, scroll); + float scaledDivWidth = divWidth * scale; + float scaledDivHeight = divHeight * scale; + int hScroll = ((divPosX * scale) - ((pageWidth - scaledDivWidth) / 2)) / scale; + int vScroll = ((divPosY * scale) - ((pageHeight - scaledDivHeight) / 2)) / scale; + EXPECT_NEAR(pageWidth / divWidth, scale, 0.1); + EXPECT_EQ(hScroll, scroll.x); + EXPECT_EQ(vScroll, scroll.y); + + // Test zoom out to overview scale. + webViewImpl->applyScrollAndScale(WebSize(scroll.x, scroll.y), scale / webViewImpl->pageScaleFactor()); + webViewImpl->computeScaleAndScrollForHitRect(doubleTapPoint, WebViewImpl::DoubleTap, scale, scroll); + EXPECT_FLOAT_EQ(1, scale); + EXPECT_EQ(WebPoint(0, 0), scroll); + + // Tests for clamped scaling. + // Test clamp to device scale: + webViewImpl->applyScrollAndScale(WebSize(scroll.x, scroll.y), scale / webViewImpl->pageScaleFactor()); + webViewImpl->setDeviceScaleFactor(2.5); + webViewImpl->computeScaleAndScrollForHitRect(doubleTapPoint, WebViewImpl::DoubleTap, scale, scroll); + EXPECT_FLOAT_EQ(2.5, scale); + + // Test clamp to minimum scale: + webViewImpl->applyScrollAndScale(WebSize(scroll.x, scroll.y), scale / webViewImpl->pageScaleFactor()); + webViewImpl->setPageScaleFactorLimits(1.5 / webViewImpl->deviceScaleFactor(), 4 / webViewImpl->deviceScaleFactor()); + webViewImpl->computeScaleAndScrollForHitRect(doubleTapPoint, WebViewImpl::DoubleTap, scale, scroll); + EXPECT_FLOAT_EQ(1.5, scale); + EXPECT_EQ(WebPoint(0, 0), scroll); + + // Test clamp to maximum scale: + webViewImpl->applyScrollAndScale(WebSize(scroll.x, scroll.y), scale / webViewImpl->pageScaleFactor()); + webViewImpl->setDeviceScaleFactor(4); + webViewImpl->setPageScaleFactorLimits(0, 3 / webViewImpl->deviceScaleFactor()); + webViewImpl->computeScaleAndScrollForHitRect(doubleTapPoint, WebViewImpl::DoubleTap, scale, scroll); + EXPECT_FLOAT_EQ(3, scale); -// This test depends on code that is compiled conditionally. We likely need to -// add the proper ifdef when re-enabling it. See -// https://bugs.webkit.org/show_bug.cgi?id=98558 -TEST_F(WebFrameTest, DISABLED_DivScrollIntoEditableTest) -{ - registerMockedHttpURLLoad("get_scale_for_zoom_into_editable_test.html"); + // Test for Non-doubletap scaling + webViewImpl->setPageScaleFactor(1, WebPoint(0, 0)); + webViewImpl->setDeviceScaleFactor(4); + webViewImpl->setPageScaleFactorLimits(0, 4 / webViewImpl->deviceScaleFactor()); + // Test zooming into div. + webViewImpl->computeScaleAndScrollForHitRect(WebRect(250, 250, 10, 10), WebViewImpl::FindInPage, scale, scroll); + EXPECT_NEAR(pageWidth / divWidth, scale, 0.1); - DivAutoZoomTestWebViewClient client; - int viewportWidth = 640; - int viewportHeight = 480; - float leftBoxRatio = 0.3f; - int caretPadding = 10; - int minReadableCaretHeight = 18; - client.m_windowRect = WebRect(0, 0, viewportWidth, viewportHeight); - WebKit::WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "get_scale_for_zoom_into_editable_test.html", true, 0, &client); - webView->enableFixedLayoutMode(true); - webView->resize(WebSize(viewportWidth, viewportHeight)); - webView->setPageScaleFactorLimits(1, 10); - webView->layout(); - webView->setDeviceScaleFactor(1.5f); - webView->settings()->setAutoZoomFocusedNodeToLegibleScale(true); - - WebViewImpl* webViewImpl = static_cast<WebViewImpl*>(webView); - webViewImpl->shouldUseAnimateDoubleTapTimeZeroForTesting(true); - - WebRect editBoxWithText(200, 200, 250, 20); - WebRect editBoxWithNoText(200, 250, 250, 20); - - // Test scrolling the focused node - // The edit box is shorter and narrower than the viewport when legible. - setScaleAndScrollAndLayout(webView, WebPoint(0, 0), 1); - WebRect rect, caret; - webViewImpl->selectionBounds(caret, rect); - webView->scrollFocusedNodeIntoRect(rect); - // The edit box should be left aligned with a margin for possible label. - int hScroll = editBoxWithText.x * webView->pageScaleFactor() - leftBoxRatio * viewportWidth; - EXPECT_EQ(hScroll, webView->mainFrame()->scrollOffset().width); - int vScroll = editBoxWithText.y * webView->pageScaleFactor() - (viewportHeight - editBoxWithText.height * webView->pageScaleFactor()) / 2; - EXPECT_EQ(vScroll, webView->mainFrame()->scrollOffset().height); - EXPECT_FLOAT_EQ(webView->deviceScaleFactor() * minReadableCaretHeight / caret.height, webView->pageScaleFactor()); - - // The edit box is wider than the viewport when legible. - webView->setDeviceScaleFactor(4); - setScaleAndScrollAndLayout(webView, WebPoint(0, 0), 1); - webViewImpl->selectionBounds(caret, rect); - webView->scrollFocusedNodeIntoRect(rect); - // The caret should be right aligned since the caret would be offscreen when the edit box is left aligned. - hScroll = (caret.x + caret.width) * webView->pageScaleFactor() + caretPadding - viewportWidth; - EXPECT_EQ(hScroll, webView->mainFrame()->scrollOffset().width); - EXPECT_FLOAT_EQ(webView->deviceScaleFactor() * minReadableCaretHeight / caret.height, webView->pageScaleFactor()); - - setScaleAndScrollAndLayout(webView, WebPoint(0, 0), 1); - // Move focus to edit box with text. - webView->advanceFocus(false); - webViewImpl->selectionBounds(caret, rect); - webView->scrollFocusedNodeIntoRect(rect); - // The edit box should be left aligned. - hScroll = editBoxWithNoText.x * webView->pageScaleFactor(); - EXPECT_EQ(hScroll, webView->mainFrame()->scrollOffset().width); - vScroll = editBoxWithNoText.y * webView->pageScaleFactor() - (viewportHeight - editBoxWithNoText.height * webView->pageScaleFactor()) / 2; - EXPECT_EQ(vScroll, webView->mainFrame()->scrollOffset().height); - EXPECT_FLOAT_EQ(webView->deviceScaleFactor() * minReadableCaretHeight / caret.height, webView->pageScaleFactor()); - - // Move focus back to the first edit box. - webView->advanceFocus(true); - webViewImpl->selectionBounds(caret, rect); - // The position should have stayed the same since this box was already on screen with the right scale. - EXPECT_EQ(vScroll, webView->mainFrame()->scrollOffset().height); - EXPECT_EQ(hScroll, webView->mainFrame()->scrollOffset().width); + // Drop any pending fake mouse events from zooming before leaving the test. + webViewImpl->page()->mainFrame()->eventHandler()->clear(); } #endif @@ -1080,8 +900,6 @@ TEST_F(WebFrameTest, FindInPageMatchRects) WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(webView->mainFrame()); EXPECT_TRUE(mainFrame->find(kFindIdentifier, searchText, options, false, 0)); - mainFrame->resetMatchCount(); - for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false)) frame->scopeStringMatches(kFindIdentifier, searchText, options, true); @@ -1172,129 +990,6 @@ TEST_F(WebFrameTest, FindInPageMatchRects) webView->close(); } -TEST_F(WebFrameTest, FindOnDetachedFrame) -{ - registerMockedHttpURLLoad("find_in_page.html"); - registerMockedHttpURLLoad("find_in_page_frame.html"); - - FindUpdateWebFrameClient client; - WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "find_in_page.html", true, &client); - webView->resize(WebSize(640, 480)); - webView->layout(); - webkit_support::RunAllPendingMessages(); - - static const char* kFindString = "result"; - static const int kFindIdentifier = 12345; - - WebFindOptions options; - WebString searchText = WebString::fromUTF8(kFindString); - WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(webView->mainFrame()); - WebFrameImpl* secondFrame = static_cast<WebFrameImpl*>(mainFrame->traverseNext(false)); - RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame(); - - // Detach the frame before finding. - EXPECT_TRUE(mainFrame->document().getElementById("frame").remove()); - - EXPECT_TRUE(mainFrame->find(kFindIdentifier, searchText, options, false, 0)); - EXPECT_FALSE(secondFrame->find(kFindIdentifier, searchText, options, false, 0)); - - webkit_support::RunAllPendingMessages(); - EXPECT_FALSE(client.findResultsAreReady()); - - mainFrame->resetMatchCount(); - - for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false)) - frame->scopeStringMatches(kFindIdentifier, searchText, options, true); - - webkit_support::RunAllPendingMessages(); - EXPECT_TRUE(client.findResultsAreReady()); - - holdSecondFrame.release(); - webView->close(); -} - -TEST_F(WebFrameTest, FindDetachFrameBeforeScopeStrings) -{ - registerMockedHttpURLLoad("find_in_page.html"); - registerMockedHttpURLLoad("find_in_page_frame.html"); - - FindUpdateWebFrameClient client; - WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "find_in_page.html", true, &client); - webView->resize(WebSize(640, 480)); - webView->layout(); - webkit_support::RunAllPendingMessages(); - - static const char* kFindString = "result"; - static const int kFindIdentifier = 12345; - - WebFindOptions options; - WebString searchText = WebString::fromUTF8(kFindString); - WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(webView->mainFrame()); - WebFrameImpl* secondFrame = static_cast<WebFrameImpl*>(mainFrame->traverseNext(false)); - RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame(); - - for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false)) - EXPECT_TRUE(frame->find(kFindIdentifier, searchText, options, false, 0)); - - webkit_support::RunAllPendingMessages(); - EXPECT_FALSE(client.findResultsAreReady()); - - // Detach the frame between finding and scoping. - EXPECT_TRUE(mainFrame->document().getElementById("frame").remove()); - - mainFrame->resetMatchCount(); - - for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false)) - frame->scopeStringMatches(kFindIdentifier, searchText, options, true); - - webkit_support::RunAllPendingMessages(); - EXPECT_TRUE(client.findResultsAreReady()); - - holdSecondFrame.release(); - webView->close(); -} - -TEST_F(WebFrameTest, FindDetachFrameWhileScopingStrings) -{ - registerMockedHttpURLLoad("find_in_page.html"); - registerMockedHttpURLLoad("find_in_page_frame.html"); - - FindUpdateWebFrameClient client; - WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "find_in_page.html", true, &client); - webView->resize(WebSize(640, 480)); - webView->layout(); - webkit_support::RunAllPendingMessages(); - - static const char* kFindString = "result"; - static const int kFindIdentifier = 12345; - - WebFindOptions options; - WebString searchText = WebString::fromUTF8(kFindString); - WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(webView->mainFrame()); - WebFrameImpl* secondFrame = static_cast<WebFrameImpl*>(mainFrame->traverseNext(false)); - RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame(); - - for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false)) - EXPECT_TRUE(frame->find(kFindIdentifier, searchText, options, false, 0)); - - webkit_support::RunAllPendingMessages(); - EXPECT_FALSE(client.findResultsAreReady()); - - mainFrame->resetMatchCount(); - - for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false)) - frame->scopeStringMatches(kFindIdentifier, searchText, options, true); - - // The first scopeStringMatches will have reset the state. Detach before it actually scopes. - EXPECT_TRUE(mainFrame->document().getElementById("frame").remove()); - - webkit_support::RunAllPendingMessages(); - EXPECT_TRUE(client.findResultsAreReady()); - - holdSecondFrame.release(); - webView->close(); -} - static WebView* createWebViewForTextSelection(const std::string& url) { WebView* webView = FrameTestHelpers::createWebViewAndLoad(url, true); diff --git a/Source/WebKit/chromium/tests/WebImageTest.cpp b/Source/WebKit/chromium/tests/WebImageTest.cpp index 2f44e34b3..f968176cf 100644 --- a/Source/WebKit/chromium/tests/WebImageTest.cpp +++ b/Source/WebKit/chromium/tests/WebImageTest.cpp @@ -88,15 +88,6 @@ TEST(WebImageTest, ICOImage) EXPECT_EQ(SkColorSetARGB(255, 0, 0, 0), images[1].getSkBitmap().getColor(0, 0)); } -TEST(WebImageTest, ICOValidHeaderMissingBitmap) -{ - RefPtr<SharedBuffer> data = readFile("valid_header_missing_bitmap.ico"); - ASSERT_TRUE(data.get()); - - WebVector<WebImage> images = WebImage::framesFromData(WebData(data)); - ASSERT_TRUE(images.isEmpty()); -} - TEST(WebImageTest, BadImage) { const char badImage[] = "hello world"; diff --git a/Source/WebKit/chromium/tests/WebInputEventFactoryTestMac.mm b/Source/WebKit/chromium/tests/WebInputEventFactoryTestMac.mm deleted file mode 100644 index 73a29bcd1..000000000 --- a/Source/WebKit/chromium/tests/WebInputEventFactoryTestMac.mm +++ /dev/null @@ -1,84 +0,0 @@ -/* - * Copyright (C) 2012 Google Inc. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following disclaimer - * in the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Google Inc. nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -#include "config.h" - -#import <Cocoa/Cocoa.h> -#include <gtest/gtest.h> - -#include "KeyboardEvent.h" -#include "WebInputEvent.h" -#include "WebInputEventFactory.h" - -using WebKit::WebInputEventFactory; -using WebKit::WebKeyboardEvent; - -namespace { - -NSEvent* BuildFakeKeyEvent(NSUInteger keyCode, unichar character, NSUInteger modifierFlags) -{ - NSString* string = [NSString stringWithCharacters:&character length:1]; - return [NSEvent keyEventWithType:NSKeyDown - location:NSZeroPoint - modifierFlags:modifierFlags - timestamp:0.0 - windowNumber:0 - context:nil - characters:string - charactersIgnoringModifiers:string - isARepeat:NO - keyCode:keyCode]; -} - -} // namespace - -// Test that arrow keys don't have numpad modifier set. -TEST(WebInputEventFactoryTestMac, ArrowKeyNumPad) -{ - // Left - NSEvent* macEvent = BuildFakeKeyEvent(0x7B, NSLeftArrowFunctionKey, NSNumericPadKeyMask); - WebKeyboardEvent webEvent = WebInputEventFactory::keyboardEvent(macEvent); - EXPECT_EQ(0, webEvent.modifiers); - - // Right - macEvent = BuildFakeKeyEvent(0x7C, NSRightArrowFunctionKey, NSNumericPadKeyMask); - webEvent = WebInputEventFactory::keyboardEvent(macEvent); - EXPECT_EQ(0, webEvent.modifiers); - - // Down - macEvent = BuildFakeKeyEvent(0x7D, NSDownArrowFunctionKey, NSNumericPadKeyMask); - webEvent = WebInputEventFactory::keyboardEvent(macEvent); - EXPECT_EQ(0, webEvent.modifiers); - - // Up - macEvent = BuildFakeKeyEvent(0x7E, NSUpArrowFunctionKey, NSNumericPadKeyMask); - webEvent = WebInputEventFactory::keyboardEvent(macEvent); - EXPECT_EQ(0, webEvent.modifiers); -} diff --git a/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp b/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp index 9d4b60acd..3ea4fcf9e 100644 --- a/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp +++ b/Source/WebKit/chromium/tests/WebPageNewSerializerTest.cpp @@ -88,7 +88,6 @@ public: , m_xhtmlMimeType(WebString::fromUTF8("application/xhtml+xml")) , m_cssMimeType(WebString::fromUTF8("text/css")) , m_pngMimeType(WebString::fromUTF8("image/png")) - , m_svgMimeType(WebString::fromUTF8("image/svg+xml")) { } @@ -149,7 +148,6 @@ protected: const WebString& xhtmlMimeType() const { return m_xhtmlMimeType; } const WebString& cssMimeType() const { return m_cssMimeType; } const WebString& pngMimeType() const { return m_pngMimeType; } - const WebString& svgMimeType() const { return m_svgMimeType; } static bool resourceVectorContains(const WebVector<WebPageSerializer::Resource>& resources, const char* url, const char* mimeType) { @@ -169,7 +167,6 @@ private: WebString m_xhtmlMimeType; WebString m_cssMimeType; WebString m_pngMimeType; - WebString m_svgMimeType; TestWebFrameClient m_webFrameClient; }; @@ -332,20 +329,4 @@ TEST_F(WebPageNewSerializeTest, FAILS_TestMHTMLEncoding) EXPECT_EQ(12, sectionCheckedCount); } -// Test that we don't regress https://bugs.webkit.org/show_bug.cgi?id=99105 -TEST_F(WebPageNewSerializeTest, SVGImageDontCrash) -{ - WebURL pageUrl = toKURL("http://www.test.com"); - WebURL imageUrl = toKURL("http://www.test.com/green_rectangle.svg"); - - registerMockedURLLoad(pageUrl, WebString::fromUTF8("page_with_svg_image.html"), WebString::fromUTF8("pageserializer/"), htmlMimeType()); - registerMockedURLLoad(imageUrl, WebString::fromUTF8("green_rectangle.svg"), WebString::fromUTF8("pageserializer/"), svgMimeType()); - - loadURLInTopFrame(pageUrl); - - WebCString mhtml = WebPageSerializer::serializeToMHTML(m_webView); - // We expect some data to be generated. - EXPECT_GT(mhtml.length(), 50U); -} - } diff --git a/Source/WebKit/chromium/tests/WebSocketExtensionDispatcherTest.cpp b/Source/WebKit/chromium/tests/WebSocketExtensionDispatcherTest.cpp index 52905bab1..358983b83 100644 --- a/Source/WebKit/chromium/tests/WebSocketExtensionDispatcherTest.cpp +++ b/Source/WebKit/chromium/tests/WebSocketExtensionDispatcherTest.cpp @@ -27,11 +27,9 @@ #include "WebSocketExtensionDispatcher.h" -#include "WebSocketExtensionParser.h" #include "WebSocketExtensionProcessor.h" #include <gtest/gtest.h> -#include <wtf/text/CString.h> #include <wtf/text/StringHash.h> using namespace WebCore; @@ -105,10 +103,10 @@ TEST_F(WebSocketExtensionDispatcherTest, TestParameters) EXPECT_EQ(2, m_parsedParameters[0].size()); HashMap<String, String>::iterator parameter = m_parsedParameters[0].find("max-channels"); EXPECT_TRUE(parameter != m_parsedParameters[0].end()); - EXPECT_EQ("4", parameter->value); + EXPECT_EQ("4", parameter->second); parameter = m_parsedParameters[0].find("flow-control"); EXPECT_TRUE(parameter != m_parsedParameters[0].end()); - EXPECT_TRUE(parameter->value.isNull()); + EXPECT_TRUE(parameter->second.isNull()); } TEST_F(WebSocketExtensionDispatcherTest, TestMultiple) @@ -133,12 +131,12 @@ TEST_F(WebSocketExtensionDispatcherTest, TestMultiple) const HashMap<String, String>& parsedParameters = m_parsedParameters[i]; EXPECT_EQ(expected[i].parameters.size(), m_parsedParameters[i].size()); for (HashMap<String, String>::const_iterator iterator = expectedParameters.begin(); iterator != expectedParameters.end(); ++iterator) { - HashMap<String, String>::const_iterator parsed = parsedParameters.find(iterator->key); + HashMap<String, String>::const_iterator parsed = parsedParameters.find(iterator->first); EXPECT_TRUE(parsed != parsedParameters.end()); - if (iterator->value.isNull()) - EXPECT_TRUE(parsed->value.isNull()); + if (iterator->second.isNull()) + EXPECT_TRUE(parsed->second.isNull()); else - EXPECT_EQ(iterator->value, parsed->value); + EXPECT_EQ(iterator->second, parsed->second); } } } @@ -178,34 +176,4 @@ TEST_F(WebSocketExtensionDispatcherTest, TestInvalid) } } -// Tests for the most complex example at http://tools.ietf.org/html/draft-ietf-hybi-permessage-compression-01#section-3.1 -TEST_F(WebSocketExtensionDispatcherTest, TestPerMessageCompressExample) -{ - addMockProcessor("permessage-compress"); - addMockProcessor("bar"); - EXPECT_TRUE(m_extensions.processHeaderValue("permessage-compress; method=\"foo; x=\\\"Hello World\\\", bar\"")); - EXPECT_EQ(1U, m_parsedExtensionTokens.size()); - EXPECT_EQ("permessage-compress", m_parsedExtensionTokens[0]); - String methodParameter = m_parsedParameters[0].find("method")->value; - EXPECT_EQ("foo; x=\"Hello World\", bar", methodParameter); - - CString methodValue = methodParameter.ascii(); - WebSocketExtensionParser parser(methodValue.data(), methodValue.data() + methodValue.length()); - - String token1; - HashMap<String, String> parameters1; - EXPECT_TRUE(parser.parseExtension(token1, parameters1)); - EXPECT_EQ("foo", token1); - EXPECT_EQ(1, parameters1.size()); - HashMap<String, String>::iterator xparameter = parameters1.find("x"); - EXPECT_EQ("x", xparameter->key); - EXPECT_EQ("Hello World", xparameter->value); - - String token2; - HashMap<String, String> parameters2; - EXPECT_TRUE(parser.parseExtension(token2, parameters2)); - EXPECT_EQ("bar", token2); - EXPECT_EQ(0, parameters2.size()); -} - } diff --git a/Source/WebKit/chromium/tests/WebViewTest.cpp b/Source/WebKit/chromium/tests/WebViewTest.cpp index 1929c1ba6..d478aad92 100644 --- a/Source/WebKit/chromium/tests/WebViewTest.cpp +++ b/Source/WebKit/chromium/tests/WebViewTest.cpp @@ -585,6 +585,24 @@ TEST_F(WebViewTest, DetectContentAroundPosition) EXPECT_FALSE(client.contentDetectionRequested()); client.reset(); + // Content detection should still work on click, mouse and touch event listeners for long taps + // as long as we're not tapping on links. + EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, clickListener)); + EXPECT_TRUE(client.contentDetectionRequested()); + client.reset(); + + EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, touchstartListener)); + EXPECT_TRUE(client.contentDetectionRequested()); + client.reset(); + + EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, mousedownListener)); + EXPECT_TRUE(client.contentDetectionRequested()); + client.reset(); + + EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, link)); + EXPECT_FALSE(client.contentDetectionRequested()); + client.reset(); + // Content detection should work normally without these event listeners. // The click listener in the body should be ignored as a special case. EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureTap, noListener)); @@ -629,26 +647,4 @@ TEST_F(WebViewTest, ClientTapHandling) webView->close(); } -#if OS(ANDROID) -TEST_F(WebViewTest, LongPressSelection) -{ - URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("longpress_selection.html")); - - WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "longpress_selection.html", true); - webView->resize(WebSize(500, 300)); - webView->layout(); - webkit_support::RunAllPendingMessages(); - - WebString target = WebString::fromUTF8("target"); - WebString onselectstartfalse = WebString::fromUTF8("onselectstartfalse"); - WebFrameImpl* frame = static_cast<WebFrameImpl*>(webView->mainFrame()); - - EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, onselectstartfalse)); - EXPECT_EQ("", std::string(frame->selectionAsText().utf8().data())); - EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, target)); - EXPECT_EQ("testword", std::string(frame->selectionAsText().utf8().data())); - webView->close(); -} -#endif - } diff --git a/Source/WebKit/chromium/tests/data/clipped-body.html b/Source/WebKit/chromium/tests/data/clipped-body.html deleted file mode 100644 index 4ebf169ad..000000000 --- a/Source/WebKit/chromium/tests/data/clipped-body.html +++ /dev/null @@ -1,21 +0,0 @@ -<!DOCTYPE html> -<html> - -<head> - <style> - html, body { - overflow-x: hidden; - } - #content { - background: silver; - width: 1000px; - height: 1000px; - } - </style> -<head> - -<body> - <div id="content"></div> -</body> - -</html> diff --git a/Source/WebKit/chromium/tests/data/find_in_page.html b/Source/WebKit/chromium/tests/data/find_in_page.html index f5d28a644..643073a16 100644 --- a/Source/WebKit/chromium/tests/data/find_in_page.html +++ b/Source/WebKit/chromium/tests/data/find_in_page.html @@ -6,7 +6,7 @@ <body> This a find-in-page match rect test.</br> result 00</br> -<iframe src="find_in_page_frame.html" id="frame" height="300" scrolling="yes"></iframe> +<iframe src="find_in_page_frame.html" height="300" scrolling="yes"></iframe> </br> result 01 </body> diff --git a/Source/WebKit/chromium/tests/data/get_multiple_divs_for_auto_zoom_test.html b/Source/WebKit/chromium/tests/data/get_multiple_divs_for_auto_zoom_test.html deleted file mode 100644 index 5f2e6442f..000000000 --- a/Source/WebKit/chromium/tests/data/get_multiple_divs_for_auto_zoom_test.html +++ /dev/null @@ -1,10 +0,0 @@ -<html> - <body> - <div style="background-color: green; position: absolute; left: 200px; top: 100px; width: 200px; height: 150px"> - <p id="Div">Top Div</p> - </div> - <div style="background-color: green; position: absolute; left: 200px; top: 300px; width: 200px; height: 150px"> - <p id="Div">Bottom Div</p> - </div> - </body> -</html> diff --git a/Source/WebKit/chromium/tests/data/get_scale_bounds_check_for_auto_zoom_test.html b/Source/WebKit/chromium/tests/data/get_scale_bounds_check_for_auto_zoom_test.html deleted file mode 100644 index 9cc8e9c16..000000000 --- a/Source/WebKit/chromium/tests/data/get_scale_bounds_check_for_auto_zoom_test.html +++ /dev/null @@ -1,7 +0,0 @@ -<html> - <body> - <div style="background-color: green; position: absolute; left: 200px; top: 100px; width: 200px; height: 400px"> - <p id="Div">Div</p> - </div> - </body> -</html> diff --git a/Source/WebKit/chromium/tests/data/get_scale_for_auto_zoom_into_div_test.html b/Source/WebKit/chromium/tests/data/get_scale_for_auto_zoom_into_div_test.html index 95e7b3787..1817dc47d 100644 --- a/Source/WebKit/chromium/tests/data/get_scale_for_auto_zoom_into_div_test.html +++ b/Source/WebKit/chromium/tests/data/get_scale_for_auto_zoom_into_div_test.html @@ -1,10 +1,13 @@ <html> <body> - <div style="background-color: green; position: absolute; left: 200px; top: 100px; width: 400px; height: 150px"> - <p id="wideDiv">Wide div</p> - </div> - <div style="background-color: green; position: absolute; left: 200px; top: 300px; width: 400px; height: 800"> - <p id="tallDiv">Tall div</p> + <div style="background-color: green; position: absolute; left: 0px; top: 0px; width: 640px; height: 480px"> + <p>Top Div</p> + <div style="background-color: white; position: absolute; left: 200px; top: 200px; width: 200px; height: 150px"> + <p id="innerDiv">Div to zoom to</p> + <div style="background-color: red; position: fixed; left: 220px; top: 350px; width: 160px; height: 40px"> + <p id="innerInnerDiv">Div NOT to zoom to</p> + </div> + </div> </div> </body> </html> diff --git a/Source/WebKit/chromium/tests/data/get_scale_for_zoom_into_editable_test.html b/Source/WebKit/chromium/tests/data/get_scale_for_zoom_into_editable_test.html deleted file mode 100644 index 91c748e30..000000000 --- a/Source/WebKit/chromium/tests/data/get_scale_for_zoom_into_editable_test.html +++ /dev/null @@ -1,16 +0,0 @@ -<html> -<head> -<script> -function getfocus() -{ -var textfield = document.getElementById('EditBoxWithText'); -textfield.focus(); -textfield.setSelectionRange(textfield.value.length,textfield.value.length); -} -</script> -</head> - <body onload="getfocus()"> - <input id="EditBoxWithText" style=" position: absolute; left: 200px; top: 200px; width: 250; height:20" value = "Long text to fill the edit box" type="text"> - <input id="EditBoxWithNoText" style=" position: absolute; left: 200px; top: 250px; width: 250; height:20" type="text"> - </body> -</html> diff --git a/Source/WebKit/chromium/tests/data/longpress_selection.html b/Source/WebKit/chromium/tests/data/longpress_selection.html deleted file mode 100644 index 866994f9b..000000000 --- a/Source/WebKit/chromium/tests/data/longpress_selection.html +++ /dev/null @@ -1,23 +0,0 @@ -<!DOCTYPE html> -<html> -<head> -<style> -span { - font-size: 300%; -} -</style> -</head> -<body> -Hello this is some text for testing. Here is a -<span id="target"> -testword -</span> -that we should be able to select by longpressing. - -To test onselectstart, here is -<span id="onselectstartfalse" onselectstart="return false;"> -anotherbitoftext -</span> -that we should not be able to select. -</body> -</html> diff --git a/Source/WebKit/chromium/tests/data/pageserializer/green_rectangle.svg b/Source/WebKit/chromium/tests/data/pageserializer/green_rectangle.svg deleted file mode 100644 index 75307187a..000000000 --- a/Source/WebKit/chromium/tests/data/pageserializer/green_rectangle.svg +++ /dev/null @@ -1,11 +0,0 @@ -<?xml version="1.0"?> -<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" - "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> - -<svg xmlns="http://www.w3.org/2000/svg" version="1.1" - width="120" height="120" viewBox="0 0 236 120"> - <rect x="14" y="23" width="250" height="50" fill="green" - stroke="black" stroke-width="1" /> - <rect x="14" y="23" width="250" height="50" fill="green" - stroke="black" stroke-width="1" /> -</svg> diff --git a/Source/WebKit/chromium/tests/data/pageserializer/page_with_svg_image.html b/Source/WebKit/chromium/tests/data/pageserializer/page_with_svg_image.html deleted file mode 100644 index a3eb7b88d..000000000 --- a/Source/WebKit/chromium/tests/data/pageserializer/page_with_svg_image.html +++ /dev/null @@ -1,6 +0,0 @@ -<html> -<body> -SVG to the max!<br> -<img src="green_rectangle.svg"/> -</body> -</html> diff --git a/Source/WebKit/chromium/tests/data/valid_header_missing_bitmap.ico b/Source/WebKit/chromium/tests/data/valid_header_missing_bitmap.ico Binary files differdeleted file mode 100755 index 5e4cfcec5..000000000 --- a/Source/WebKit/chromium/tests/data/valid_header_missing_bitmap.ico +++ /dev/null |
