| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an asian IME is used to compose a new word, and a modifier key is
pressed (shift, alt, etc), WebEngine would notify Chromium to cancel
the composition, thus clearing the text. But the actual IME window
would still be present, and if another "letter" key was pressed, the
composition would continue with the previous pre-edit text, which leads
to unusual text flickering.
The previous behavior was introduced in 31efe25d14 to fix a Windows
double character input bug.
The current change makes sure to clear the IME composition only in case
the last received QInputMethodEvent pre-edit and commit strings were
empty, which is not the case when pressing a modifier key for instance.
Change-Id: Ic968404c90e1e0eb703fe1c2849990467bedd5e1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls in the PDB location fix, an updated libjpeg_turbo and the backport
of a crash fix.
Task-number: QTBUG-52938
Task-number: QTBUG-53800
Task-number: QTBUG-54023
Change-Id: Ic773b082d26825758e8986e8d77f8f5bc7b80f83
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppose QWebEnginePage is destroyed while there's still a combobox popup
open. We would crash with the following stack trace:
1 QtWebEngineCore::RenderWidgetHostViewQt::dpiScale
2 QtWebEngineCore::RenderWidgetHostViewQt::GetViewBounds
3 content::RenderWidgetHostImpl::SendScreenRects
4 content::RenderWidgetHostImpl::OnRenderViewReady
...
16 base::MessageLoop::DoWork
17 WebEngineContext::destroy
18 `anonymous namespace'::destroyContext
19 qt_call_post_routines
20 QApplication::~QApplication
RenderWidgetHostViewQt still holds a pointer to WebContentsAdapterClient.
To fix this, expose the QObject owning the adapter client, and
hide RenderWidgetHostViewQt when it is destroyed so it won't try to render.
Change-Id: Ide5543197b35038a3e1c7491ceda3f5ad10f6f07
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use Chromium's Aura cursors when we don't have Qt equivalents.
These cursors were also supported in QtWebKit. Note this
depends on Aura being used, which means OS X still doesn't
have the new cursors.
Task-number: QTBUG-53593
Change-Id: I9fbbf102dd313da5a6836069b4d7ece057d8c946
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
It has changed from how it was done in Qt WebKit.
The following sentence needs to be changed, because "this" no
longer refers to the correct thing.
Task-number: QTBUG-53849
Change-Id: I11be382c92a4ab729585d334a4f3c0abe46bb3e4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
We shouldn't ignore defined hotspots for cursors we adapt from pixmaps.
Change-Id: Ia9c1e29e6374116d4564b306d0e199baaf5d494f
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink can not handle more than the three main mouse-buttons, and we were
translating a press of an extra mouse-button as a mouse-down of the
button ButtonNone.
Instead ignore mouse-button events blink does not currently support.
Task-number: QTBUG-53799
Change-Id: If1d3ba6bd331ec8ad0ff45bcd674e67763ee9097
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
New security fixes are added for new Qt 5.6.x versions.
Change-Id: Ibf67bde7003b99d729fe8ac23b86c8ff46182ee6
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were reporting any mouse button event where the left mouse button was
held as a left mouse button event. We should instead separate the button
changed and the ones held.
Also adds test of the translation.
Change-Id: I1139d6615d54a036dfe843fdb1d1c90b23b467b5
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before the change, chromium would process an onclick handler twice,
once due to a touch event, and another time due to the OS synthesized
mouse event.
Patch makes sure only the touch events are forwarded to Chromium. This
is consistent with mainline Chrome behavior.
Task-number: QTBUG-53201
Change-Id: I16f46b94890c2f6fa9a9089f7c721ec79e0bc96b
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
Fixes warnings when building with clang.
Task-number: QTBUG-51295
Change-Id: I4ede7e4ea5c1c3924b3bba852834b8066b539825
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Current qml menu implementation uses always WebEngineView
as the parent of the menu. However menu can
be triggered several times during WebEngineView
lifetime, each time creating new menu component.
Use onDone menu signal instead to delete menu.
Change-Id: I1a6064451e95453268a2cd46899e297e769dc1f1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I951c78e53ff0e05918daf34076fffc44b813a8d2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Fixes clipboard access from flash and fixes an assert when using the
copy button on codereview.qt-project.org.
Change-Id: Ia66ada8a1195a51a26d2b3fd689ddc867bc8d422
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
| |
...which loads images from cache.
Change-Id: Icb445bb2224ec30df6257fb3fd6c59c54791b570
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Loading qt_module.prf automagically fills PRECOMPILED_HEADER.
Clear this, because core_module is a link-only module.
Change-Id: I4edf75faf7c251719c1d9412ca42870dd06ddb95
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
refs/staging/5.6
|
| |\
| | |
| | |
| | | |
Change-Id: Ic2fad2311550860c5a2f83b6f228a7a648131ece
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Pulls in cherry-picked security fixes from Chromium 51.
Change-Id: I4c16b2c8633c53e6c2ae3a6fcdd446bcc404335b
Task-number: QTBUG-53643
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Examples in binary packages now directly match the install path.
Change-Id: I701bb08e189ae4e3ebb6cb10118900ce72791e3b
Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Building qtwebengine failed with Yocto2.1/GCC5.3 with an IMX.6 ARM
target. Adding the include fixed the issue.
compiling .moc/moc_qquickwebengineview_p.cpp
.moc/moc_qquickwebengineview_p.cpp: In static member function 'static void QQuickWebEngineView::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)':
.moc/moc_qquickwebengineview_p.cpp:866:72: error: invalid use of incomplete type 'class QColor'
case 15: *reinterpret_cast< QColor*>(_v) = _t->backgroundColor(); break;
^
In file included from /data/projects/fsl-community-bsp/build/tmp/sysroots/wandboard/usr/include/qt5/QtCore/qobject.h:48:0,
from /data/projects/fsl-community-bsp/build/tmp/sysroots/wandboard/usr/include/qt5/QtCore/QObject:1,
from .moc/../api/qquickwebenginescript_p.h:52,
from .moc/../api/qquickwebengineview_p.h:52,
from .moc/moc_qquickwebengineview_p.cpp:9:
/data/projects/fsl-community-bsp/build/tmp/sysroots/wandboard/usr/include/qt5/QtCore/qmetatype.h:1886:1: note: forward declaration of 'class QColor'
Change-Id: If58315d4c0b5087705687ae582ffe86702063937
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
An error or update could potentially arrive after shutdown causing
segmentation faults due to using unretained pointers in Chromium
callbacks.
This patch switches to using Chromium WeakPtrs and Qt invokable, to
ensure dead objects are not invoked.
Change-Id: Icf1a22c2ee081048dcc579e74b1b5da572eaf256
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Touch events have causesScrollingIfUncanceled flag that is used by
TouchEventQueue::TouchMoveSlopSuppressor for determining whether they
can be suppressed or not. Previously it was always false what caused
the events be suppressed. Then, it was set to true what caused the
events cannot be suppressed event if they can. Now the flag can be
dinamically changed depending on the result of
ui::FilteredGestureProvider::OnTouchEvent.
Change-Id: I625a5c5d9b7597e25406e55c461efb7187e7c482
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
And also uses the system provided libc++ library.
Task-number: QTBUG-53685
Change-Id: Ibc6a773cf65ca057770baecedcff6ab27ffabf66
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch is a port of commit 4b0cac9dfeebb73f21a11e10e6a2bc7bddbe889b in
Chromium for Qt WebEngine.
The based commit says:
> http://www.khronos.org/registry/egl/extensions/KHR/EGL_KHR_surfaceless_context.txt
>
> This patch adds support in GLSurfaceEGL to be able to use
> surfaceless context when supported by the drivers. This avoids
> the creation of a dummy offscreen surface. This would also enable
> support for offscreen rendering on platforms (i.e Ozone-Wayland) which
> donot support pbuffer surfaces.
Some platforms supported by QPA, such as Mesa 3D DRI2 with drm and wayland
backend also don't support pbuffer surfaces.
Change-Id: I8378957931d79b691392b6fbe13082b8610b8fe6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
In case arm_version == 7, arm_thumb used by default.
This change allows to override the configuration.
Change-Id: Ifa924d3d6b6c39da513523fdc40757d277fb7f26
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I98cb984548d833121d7e3102b9d89ccc7c8a11b6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I5e22ceaf5a8450fb5254278dbcbe6e02ecf51a45
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add "Module" to the overview section titles, to stop links
from other modules from leading to the "Qt WebEngine" section
in the "Overview" instead of to the Qt WebEngine module front
page.
Change-Id: I1c571c4edad0bcf9dd05e4dad703f95f39eb579c
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-53685
Change-Id: I4bd08196929953a24e96d82eb583014785e6bbf8
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Qt Quick Controls 1 always creates "native" windows
for popups, however it does not check if the platform
can support creating "native" windows. As a workaround
disable context menu until Qt Quick Controls 2 are
in place.
Task-number: QTBUG-53467
Change-Id: Iea32e19f256f3d7e81a61e23f7da64dfc7ec660d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
page.runJavascript > page.runJavaScript
Change-Id: I82b608746487906160cb60da038c4e2718e1fb61
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a QQuickWebEngineView does not have focus, and activeFocusOnPress is
set to false, a user can still partially interact with the view. For
instance hovering the mouse over a link would change the cursor, a link
can be clicked to go to a different page.
Clicking on a text input field would focus the text field, but entering
characters will not be possible, because the view does not have QtQuick
keyboard focus, and clicking does not give the focus (because
activeFocusOnPress is set to false) and this leads to confusing
behavior.
Thus the fix is to make sure no mouse / keyboard events are forwarded
to Chromium if the view has no focus, and activeFocusOnPress is set
to false, in order to maintain a more user-friendly behavior.
Manually forcing the focus via some user-provided method that calls
forceActiveFocus() would allow further proper interaction.
Change-Id: I72c3ff69438972b9a93ee2d415fa1d4b44b86cd9
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently if a QWebEngineView or a QQuickWebEngineView is disabled
using setEnabled(false), after loading a web page, the views are
automatically focused, and a user might see a blinking caret in an html
input for example, even though the user can't interact with it.
Fix consists in not calling the Focus() method whenever a view is
disabled.
Change-Id: I1014fb5898a5ddf01a4e9b14c3eaf5d4006e5131
Task-number: QTBUG-53159
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a QWebEngineView is disabled, input events are still forwarded to
Chromium, thus allowing the user to interact with a web page.
Fix consists in stopping the forwarding of input events in the generic
event handler, just like QWidget::event() does.
Change-Id: Ie822d1f3d640840569a282223d76749686cf3419
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Qt Location and Qt Positioning were missing, even though
they are linked to in the Qt WebEngine Features topic.
Change-Id: I5b5d0deae11735c3097b99e33fa9d75fd9411bdc
Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ifb141ae83330cd320896b75090b8bb8e51b853a5
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The meta type for QClipboard::Mode must be registered, because we're
passing it from the application thread to the IO thread.
Without this registration, one can trigger Qt metaobject warnings by
alternating between copying text and copying images to the clipboard.
Change-Id: I0f7f69a3e80c6b2326be0a0c562c867063449fa5
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Chromium fails silently - except for a log entry - when the size of
the content is larger than 2 MB. This was causing trouble because the
user was not informed about the failed load at all.
Task-number: QTBUG-53414
Change-Id: I80f3f36b5eac72f3809538c19ff314068b75b61d
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Move some features from the platform notes to the new
topic.
Change-Id: I23bb0593a0e142a18ad4216a03bfe1935965fc10
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-53332
Change-Id: Ia3e89287caae50ea043065cb97441ad9796c1dcc
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|\ \
| | |
| | |
| | | |
refs/staging/5.6
|
| |\ \
| | |/
| | |
| | | |
Change-Id: I3d5e806345abd81fe91919bb4deecdac725c341f
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Includes the new fix for allowing qrc access to local files.
Task-number: QTBUG-52085
Change-Id: Ifae5af52580a41f7d66429324714428694a6b65a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It was causing a regression that broke applications that embedded
JavaScript in qrc files and accessed them from other embedded
JavaScript files. This is e.g. a typical pattern for applications
that used QtWebChannel.
This partially reverts 29f9a2fb68568208a70ba9efef0e455b50a4d3e3
Task-number: QTBUG-53108
Change-Id: I8b26395d84258b6d9aca8e0c5f07d4435617f44d
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-53314
Change-Id: I575a740cf0cd6e788c7533f4ec87fc910f1d03fa
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This appears to have been added to headerclean and is now preventing us
from integrating.
Change-Id: I7c25a85c0d62c945d4f4a68f559000fab8c880cc
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
WebKit expects pasted images to have the MIME type image/png (see code
and comment in DataObjectItem::getAsFile()).
Task-number: QTBUG-53409
Change-Id: I2b0c1244d309687ad190db26c5b00718ed0c4258
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes highlighting of visited links and now Acid3 test
completely works (100 of 100).
The reason is that VisitedLinkMaster must be initialized before a new
RenderView will be created. Otherwise, it will not handle
content::NOTIFICATION_RENDERER_PROCESS_CREATED event and therefore
VisitedLinkSlave will be left uninitialized (salt_ is zero). Because of
this reason CSS :visited selector was broken and didn't work.
Change-Id: I769cd5dbae2ffb95fd128df634a54e562b9cc91d
Reviewed-by: Ilia Kirianovskii <ilia.kirianovskii@lgepartner.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-52733
Change-Id: Id0806db78fd7a87cc78c6b284c2249a7ad203b7b
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|