1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
|
# Copyright 2018 The Dawn Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import os
import platform
import subprocess
def _DoClangFormat(input_api, output_api):
# Our binary clang-format is a linux binary compiled for x64
if platform.system() != 'Linux' or platform.architecture()[0] != '64bit':
return [output_api.PresubmitNotifyResult('Skipping clang-format')]
# We need to know which commit to diff against. It doesn't seem to be exposed anywhere
# except in that private member of presubmit_support.Change. This is likely to break
# but hopefully we have an updated clang-format in CPID/GS before it does.
upstream_commit = input_api.change._upstream
if upstream_commit == None:
return []
lint_cmd = [
'scripts/lint_clang_format.sh',
'third_party/clang-format/clang-format',
upstream_commit
]
# Make clang-format use our linux x64 sysroot because it is compiled with a version of
# stdlibc++ that's incompatible with the old libraries present on the bots.
env = {
'LD_LIBRARY_PATH': os.path.join(
os.getcwd(),
'build',
'linux',
'debian_sid_amd64-sysroot',
'usr',
'lib',
'x86_64-linux-gnu'
)
}
# Call the linting script and forward the output as a notification or as an error
try:
output = subprocess.check_output(lint_cmd, env=env);
return [output_api.PresubmitNotifyResult(output)]
except subprocess.CalledProcessError as e:
return [output_api.PresubmitError(e.output)]
def _DoCommonChecks(input_api, output_api):
results = []
results.extend(input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api))
results.extend(input_api.canned_checks.CheckGNFormatted(input_api, output_api))
results.extend(_DoClangFormat(input_api, output_api))
return results
def CheckChangeOnUpload(input_api, output_api):
return _DoCommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return _DoCommonChecks(input_api, output_api)
|
