blob: e053782b759baf60e5e5841a653db3ae20556a33 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
|
# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for changes affecting Source/platform.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools.
"""
import difflib
import os
import re
RUNTIMEENABLED_NAME = re.compile(r'\s*name\s*:\s*"([^"]*)"')
def RuntimeEnabledFeatureNames(filename):
"""Reads the 'name' of each feature in runtime_enabled_features.json5."""
# Note: We don't have a JSON5 parser available, so just use a regex.
with open(filename) as f:
for line in f:
match = RUNTIMEENABLED_NAME.match(line)
if match:
yield match.group(1)
def _CheckRuntimeEnabledFeaturesSorted(input_api, output_api):
"""Check: runtime_enabled_features.json5 feature list sorted alphabetically.
"""
# Read runtime_enabled_features.json5 using the JSON5 parser.
filename = os.path.join(input_api.PresubmitLocalPath(),
'runtime_enabled_features.json5')
features = list(RuntimeEnabledFeatureNames(filename))
# Sort the 'data' section by name.
features_sorted = sorted(features, key=lambda s: s.lower())
if features == features_sorted:
return []
# Diff the sorted/unsorted versions.
differ = difflib.Differ()
diff = differ.compare(features, features_sorted)
return [output_api.PresubmitError(
'runtime_enabled_features.json5 features must be sorted alphabetically. '
'Diff of feature order follows:', long_text='\n'.join(diff))]
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
results.extend(_CheckRuntimeEnabledFeaturesSorted(input_api, output_api))
return results
def CheckChangeOnUpload(input_api, output_api):
return _CommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return _CommonChecks(input_api, output_api)
|
