1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
|
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "third_party/blink/renderer/core/editing/commands/insert_list_command.h"
#include "third_party/blink/renderer/core/dom/parent_node.h"
#include "third_party/blink/renderer/core/dom/text.h"
#include "third_party/blink/renderer/core/editing/frame_selection.h"
#include "third_party/blink/renderer/core/editing/selection_template.h"
#include "third_party/blink/renderer/core/editing/testing/editing_test_base.h"
namespace blink {
class InsertListCommandTest : public EditingTestBase {};
TEST_F(InsertListCommandTest, ShouldCleanlyRemoveSpuriousTextNode) {
GetDocument().SetCompatibilityMode(Document::kQuirksMode);
// Needs to be editable to use InsertListCommand.
GetDocument().setDesignMode("on");
// Set up the condition:
// * Selection is a range, to go down into
// InsertListCommand::listifyParagraph.
// * The selection needs to have a sibling list to go down into
// InsertListCommand::mergeWithNeighboringLists.
// * Should be the same type (ordered list) to go into
// CompositeEditCommand::mergeIdenticalElements.
// * Should have no actual children to fail the listChildNode check
// in InsertListCommand::doApplyForSingleParagraph.
// * There needs to be an extra text node to trigger its removal in
// CompositeEditCommand::mergeIdenticalElements.
// The removeNode is what updates document lifecycle to VisualUpdatePending
// and makes FrameView::needsLayout return true.
SetBodyContent("\nd\n<ol>");
Text* empty_text = GetDocument().createTextNode("");
GetDocument().body()->InsertBefore(empty_text,
GetDocument().body()->firstChild());
UpdateAllLifecyclePhases();
GetDocument().GetFrame()->Selection().SetSelection(
SelectionInDOMTree::Builder()
.Collapse(Position(GetDocument().body(), 0))
.Extend(Position(GetDocument().body(), 2))
.Build(),
SetSelectionOptions());
InsertListCommand* command =
InsertListCommand::Create(GetDocument(), InsertListCommand::kOrderedList);
// This should not DCHECK.
EXPECT_TRUE(command->Apply())
<< "The insert ordered list command should have succeeded";
EXPECT_EQ("<ol><li>d</li></ol>", GetDocument().body()->InnerHTMLAsString());
}
// Refer https://crbug.com/794356
TEST_F(InsertListCommandTest, UnlistifyParagraphCrashOnVisuallyEmptyParagraph) {
GetDocument().setDesignMode("on");
Selection().SetSelection(
SetSelectionTextToBody("^<dl>"
"<textarea style='float:left;'></textarea>"
"</dl>|"),
SetSelectionOptions());
InsertListCommand* command = InsertListCommand::Create(
GetDocument(), InsertListCommand::kUnorderedList);
// Crash happens here.
EXPECT_FALSE(command->Apply());
EXPECT_EQ(
"<dl><ul>"
"|<textarea style=\"float:left;\"></textarea>"
"</ul></dl>",
GetSelectionTextFromBody());
}
// Refer https://crbug.com/798176
TEST_F(InsertListCommandTest, CleanupNodeSameAsDestinationNode) {
GetDocument().setDesignMode("on");
InsertStyleElement(
"* { -webkit-appearance:checkbox; }"
"br { visibility:hidden; }"
"colgroup { -webkit-column-count:2; }");
Selection().SetSelection(SetSelectionTextToBody("^<table><col></table>"
"<button></button>|"),
SetSelectionOptions());
InsertListCommand* command = InsertListCommand::Create(
GetDocument(), InsertListCommand::kUnorderedList);
// Crash happens here.
EXPECT_FALSE(command->Apply());
EXPECT_EQ(
"<ul><li><br></li></ul>"
"<br>"
"<table>|<colgroup><col>"
"<ul><li><br></li></ul>"
"</col></colgroup></table>"
"<button></button>",
GetSelectionTextFromBody());
}
TEST_F(InsertListCommandTest, InsertListOnEmptyHiddenElements) {
GetDocument().setDesignMode("on");
InsertStyleElement("br { visibility:hidden; }");
Selection().SetSelection(SetSelectionTextToBody("^<button></button>|"),
SetSelectionOptions());
InsertListCommand* command = InsertListCommand::Create(
GetDocument(), InsertListCommand::kUnorderedList);
// Crash happens here.
EXPECT_FALSE(command->Apply());
EXPECT_EQ(
"<button>"
"|<ul><li><br></li></ul>"
"</button>",
GetSelectionTextFromBody());
}
// Refer https://crbug.com/797520
TEST_F(InsertListCommandTest, InsertListWithCollapsedVisibility) {
GetDocument().setDesignMode("on");
InsertStyleElement(
"ul { visibility:collapse; }"
"dl { visibility:visible; }");
Selection().SetSelection(SetSelectionTextToBody("^<dl>a</dl>|"),
SetSelectionOptions());
InsertListCommand* command =
InsertListCommand::Create(GetDocument(), InsertListCommand::kOrderedList);
// Crash happens here.
EXPECT_FALSE(command->Apply());
EXPECT_EQ(
"<dl>"
"<ol></ol><ul>^a|</ul>"
"</dl>",
GetSelectionTextFromBody());
}
}
|
