1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
|
// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "quic/core/quic_write_blocked_list.h"
#include "quic/platform/api/quic_test.h"
#include "quic/test_tools/quic_test_utils.h"
using spdy::kHttp2DefaultStreamWeight;
using spdy::kV3HighestPriority;
using spdy::kV3LowestPriority;
namespace quic {
namespace test {
namespace {
class QuicWriteBlockedListTest : public QuicTestWithParam<bool> {
public:
QuicWriteBlockedListTest()
: write_blocked_list_(AllSupportedVersions()[0].transport_version) {}
protected:
QuicWriteBlockedList write_blocked_list_;
};
TEST_F(QuicWriteBlockedListTest, PriorityOrder) {
/*
0
|
23
|
17
|
40
*/
// Mark streams blocked in roughly reverse priority order, and
// verify that streams are sorted.
write_blocked_list_.RegisterStream(
40, false, spdy::SpdyStreamPrecedence(kV3LowestPriority));
write_blocked_list_.RegisterStream(
23, false, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.RegisterStream(
17, false, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.RegisterStream(
1, true, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.RegisterStream(
3, true, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.AddStream(40);
EXPECT_TRUE(write_blocked_list_.IsStreamBlocked(40));
write_blocked_list_.AddStream(23);
EXPECT_TRUE(write_blocked_list_.IsStreamBlocked(23));
write_blocked_list_.AddStream(17);
EXPECT_TRUE(write_blocked_list_.IsStreamBlocked(17));
write_blocked_list_.AddStream(3);
EXPECT_TRUE(write_blocked_list_.IsStreamBlocked(3));
write_blocked_list_.AddStream(1);
EXPECT_TRUE(write_blocked_list_.IsStreamBlocked(1));
EXPECT_EQ(5u, write_blocked_list_.NumBlockedStreams());
EXPECT_TRUE(write_blocked_list_.HasWriteBlockedSpecialStream());
EXPECT_EQ(2u, write_blocked_list_.NumBlockedSpecialStreams());
EXPECT_TRUE(write_blocked_list_.HasWriteBlockedDataStreams());
// The Crypto stream is highest priority.
EXPECT_EQ(1u, write_blocked_list_.PopFront());
EXPECT_EQ(1u, write_blocked_list_.NumBlockedSpecialStreams());
EXPECT_FALSE(write_blocked_list_.IsStreamBlocked(1));
// Followed by the Headers stream.
EXPECT_EQ(3u, write_blocked_list_.PopFront());
EXPECT_EQ(0u, write_blocked_list_.NumBlockedSpecialStreams());
EXPECT_FALSE(write_blocked_list_.IsStreamBlocked(3));
// Streams with same priority are popped in the order they were inserted.
EXPECT_EQ(23u, write_blocked_list_.PopFront());
EXPECT_FALSE(write_blocked_list_.IsStreamBlocked(23));
EXPECT_EQ(17u, write_blocked_list_.PopFront());
EXPECT_FALSE(write_blocked_list_.IsStreamBlocked(17));
// Low priority stream appears last.
EXPECT_EQ(40u, write_blocked_list_.PopFront());
EXPECT_FALSE(write_blocked_list_.IsStreamBlocked(40));
EXPECT_EQ(0u, write_blocked_list_.NumBlockedStreams());
EXPECT_FALSE(write_blocked_list_.HasWriteBlockedSpecialStream());
EXPECT_FALSE(write_blocked_list_.HasWriteBlockedDataStreams());
}
TEST_F(QuicWriteBlockedListTest, CryptoStream) {
write_blocked_list_.RegisterStream(
1, true, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.AddStream(1);
EXPECT_EQ(1u, write_blocked_list_.NumBlockedStreams());
EXPECT_TRUE(write_blocked_list_.HasWriteBlockedSpecialStream());
EXPECT_EQ(1u, write_blocked_list_.PopFront());
EXPECT_EQ(0u, write_blocked_list_.NumBlockedStreams());
EXPECT_FALSE(write_blocked_list_.HasWriteBlockedSpecialStream());
}
TEST_F(QuicWriteBlockedListTest, HeadersStream) {
write_blocked_list_.RegisterStream(
3, true, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.AddStream(3);
EXPECT_EQ(1u, write_blocked_list_.NumBlockedStreams());
EXPECT_TRUE(write_blocked_list_.HasWriteBlockedSpecialStream());
EXPECT_EQ(3u, write_blocked_list_.PopFront());
EXPECT_EQ(0u, write_blocked_list_.NumBlockedStreams());
EXPECT_FALSE(write_blocked_list_.HasWriteBlockedSpecialStream());
}
TEST_F(QuicWriteBlockedListTest, VerifyHeadersStream) {
write_blocked_list_.RegisterStream(
5, false, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.RegisterStream(
3, true, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.AddStream(5);
write_blocked_list_.AddStream(3);
EXPECT_EQ(2u, write_blocked_list_.NumBlockedStreams());
EXPECT_TRUE(write_blocked_list_.HasWriteBlockedSpecialStream());
EXPECT_TRUE(write_blocked_list_.HasWriteBlockedDataStreams());
// In newer QUIC versions, there is a headers stream which is
// higher priority than data streams.
EXPECT_EQ(3u, write_blocked_list_.PopFront());
EXPECT_EQ(5u, write_blocked_list_.PopFront());
EXPECT_EQ(0u, write_blocked_list_.NumBlockedStreams());
EXPECT_FALSE(write_blocked_list_.HasWriteBlockedSpecialStream());
EXPECT_FALSE(write_blocked_list_.HasWriteBlockedDataStreams());
}
TEST_F(QuicWriteBlockedListTest, NoDuplicateEntries) {
// Test that QuicWriteBlockedList doesn't allow duplicate entries.
// Try to add a stream to the write blocked list multiple times at the same
// priority.
const QuicStreamId kBlockedId = 3 + 2;
write_blocked_list_.RegisterStream(
kBlockedId, false, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.AddStream(kBlockedId);
write_blocked_list_.AddStream(kBlockedId);
write_blocked_list_.AddStream(kBlockedId);
// This should only result in one blocked stream being added.
EXPECT_EQ(1u, write_blocked_list_.NumBlockedStreams());
EXPECT_TRUE(write_blocked_list_.HasWriteBlockedDataStreams());
// There should only be one stream to pop off the front.
EXPECT_EQ(kBlockedId, write_blocked_list_.PopFront());
EXPECT_EQ(0u, write_blocked_list_.NumBlockedStreams());
EXPECT_FALSE(write_blocked_list_.HasWriteBlockedDataStreams());
}
TEST_F(QuicWriteBlockedListTest, BatchingWrites) {
const QuicStreamId id1 = 3 + 2;
const QuicStreamId id2 = id1 + 2;
const QuicStreamId id3 = id2 + 2;
write_blocked_list_.RegisterStream(
id1, false, spdy::SpdyStreamPrecedence(kV3LowestPriority));
write_blocked_list_.RegisterStream(
id2, false, spdy::SpdyStreamPrecedence(kV3LowestPriority));
write_blocked_list_.RegisterStream(
id3, false, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.AddStream(id1);
write_blocked_list_.AddStream(id2);
EXPECT_EQ(2u, write_blocked_list_.NumBlockedStreams());
// The first stream we push back should stay at the front until 16k is
// written.
EXPECT_EQ(id1, write_blocked_list_.PopFront());
write_blocked_list_.UpdateBytesForStream(id1, 15999);
write_blocked_list_.AddStream(id1);
EXPECT_EQ(2u, write_blocked_list_.NumBlockedStreams());
EXPECT_EQ(id1, write_blocked_list_.PopFront());
// Once 16k is written the first stream will yield to the next.
write_blocked_list_.UpdateBytesForStream(id1, 1);
write_blocked_list_.AddStream(id1);
EXPECT_EQ(2u, write_blocked_list_.NumBlockedStreams());
EXPECT_EQ(id2, write_blocked_list_.PopFront());
// Set the new stream to have written all but one byte.
write_blocked_list_.UpdateBytesForStream(id2, 15999);
write_blocked_list_.AddStream(id2);
EXPECT_EQ(2u, write_blocked_list_.NumBlockedStreams());
// Ensure higher priority streams are popped first.
write_blocked_list_.AddStream(id3);
EXPECT_EQ(id3, write_blocked_list_.PopFront());
// Higher priority streams will always be popped first, even if using their
// byte quota
write_blocked_list_.UpdateBytesForStream(id3, 20000);
write_blocked_list_.AddStream(id3);
EXPECT_EQ(id3, write_blocked_list_.PopFront());
// Once the higher priority stream is out of the way, id2 will resume its 16k
// write, with only 1 byte remaining of its guaranteed write allocation.
EXPECT_EQ(id2, write_blocked_list_.PopFront());
write_blocked_list_.UpdateBytesForStream(id2, 1);
write_blocked_list_.AddStream(id2);
EXPECT_EQ(2u, write_blocked_list_.NumBlockedStreams());
EXPECT_EQ(id1, write_blocked_list_.PopFront());
}
TEST_F(QuicWriteBlockedListTest, Ceding) {
/*
0
|
15
|
16
|
5
|
4
|
7
*/
write_blocked_list_.RegisterStream(
15, false, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.RegisterStream(
16, false, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.RegisterStream(5, false, spdy::SpdyStreamPrecedence(5));
write_blocked_list_.RegisterStream(4, false, spdy::SpdyStreamPrecedence(5));
write_blocked_list_.RegisterStream(7, false, spdy::SpdyStreamPrecedence(7));
write_blocked_list_.RegisterStream(
1, true, spdy::SpdyStreamPrecedence(kV3HighestPriority));
write_blocked_list_.RegisterStream(
3, true, spdy::SpdyStreamPrecedence(kV3HighestPriority));
// When nothing is on the list, nothing yields.
EXPECT_FALSE(write_blocked_list_.ShouldYield(5));
write_blocked_list_.AddStream(5);
// 5 should not yield to itself.
EXPECT_FALSE(write_blocked_list_.ShouldYield(5));
// 4 and 7 are equal or lower priority and should yield to 5.
EXPECT_TRUE(write_blocked_list_.ShouldYield(4));
EXPECT_TRUE(write_blocked_list_.ShouldYield(7));
// 15, headers and crypto should preempt 5.
EXPECT_FALSE(write_blocked_list_.ShouldYield(15));
EXPECT_FALSE(write_blocked_list_.ShouldYield(3));
EXPECT_FALSE(write_blocked_list_.ShouldYield(1));
// Block a high priority stream.
write_blocked_list_.AddStream(15);
// 16 should yield (same priority) but headers and crypto will still not.
EXPECT_TRUE(write_blocked_list_.ShouldYield(16));
EXPECT_FALSE(write_blocked_list_.ShouldYield(3));
EXPECT_FALSE(write_blocked_list_.ShouldYield(1));
// Block the headers stream. All streams but crypto and headers should yield.
write_blocked_list_.AddStream(3);
EXPECT_TRUE(write_blocked_list_.ShouldYield(16));
EXPECT_TRUE(write_blocked_list_.ShouldYield(15));
EXPECT_FALSE(write_blocked_list_.ShouldYield(3));
EXPECT_FALSE(write_blocked_list_.ShouldYield(1));
// Block the crypto stream. All streams but crypto should yield.
write_blocked_list_.AddStream(1);
EXPECT_TRUE(write_blocked_list_.ShouldYield(16));
EXPECT_TRUE(write_blocked_list_.ShouldYield(15));
EXPECT_TRUE(write_blocked_list_.ShouldYield(3));
EXPECT_FALSE(write_blocked_list_.ShouldYield(1));
}
} // namespace
} // namespace test
} // namespace quic
|
