summaryrefslogtreecommitdiff
path: root/chromium/net/http/transport_security_persister_unittest.cc
blob: a1f2ec3edfbdf989113f6f5876f1b084afd3452a (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "net/http/transport_security_persister.h"

#include <map>
#include <memory>
#include <string>
#include <vector>

#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/json/json_writer.h"
#include "base/run_loop.h"
#include "base/strings/string_util.h"
#include "base/task/current_thread.h"
#include "base/task/thread_pool.h"
#include "base/test/scoped_feature_list.h"
#include "base/threading/thread_task_runner_handle.h"
#include "net/base/features.h"
#include "net/base/network_isolation_key.h"
#include "net/base/schemeful_site.h"
#include "net/http/transport_security_state.h"
#include "net/test/test_with_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"

namespace net {

namespace {

const char kReportUri[] = "http://www.example.test/report";

// The bool indicates whether kPartitionExpectCTStateByNetworkIsolationKey
// should be enabled.
class TransportSecurityPersisterTest : public ::testing::TestWithParam<bool>,
                                       public WithTaskEnvironment {
 public:
  TransportSecurityPersisterTest()
      : WithTaskEnvironment(
            base::test::TaskEnvironment::TimeSource::MOCK_TIME) {
    // Mock out time so that entries with hard-coded json data can be
    // successfully loaded. Use a large enough value that dynamically created
    // entries have at least somewhat interesting expiration times.
    FastForwardBy(base::TimeDelta::FromDays(3660));
  }

  ~TransportSecurityPersisterTest() override {
    EXPECT_TRUE(base::CurrentIOThread::IsSet());
    base::RunLoop().RunUntilIdle();
  }

  void SetUp() override {
    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
    transport_security_file_path_ =
        temp_dir_.GetPath().AppendASCII("TransportSecurity");
    ASSERT_TRUE(base::CurrentIOThread::IsSet());
    scoped_refptr<base::SequencedTaskRunner> background_runner(
        base::ThreadPool::CreateSequencedTaskRunner(
            {base::MayBlock(), base::TaskPriority::BEST_EFFORT,
             base::TaskShutdownBehavior::BLOCK_SHUTDOWN}));
    // This feature is used in initializing |state_|.
    if (partition_expect_ct_state()) {
      feature_list_.InitAndEnableFeature(
          features::kPartitionExpectCTStateByNetworkIsolationKey);
    } else {
      feature_list_.InitAndDisableFeature(
          features::kPartitionExpectCTStateByNetworkIsolationKey);
    }
    state_ = std::make_unique<TransportSecurityState>();
    persister_ = std::make_unique<TransportSecurityPersister>(
        state_.get(), std::move(background_runner),
        transport_security_file_path_);
  }

  bool partition_expect_ct_state() const { return GetParam(); }

 protected:
  base::FilePath transport_security_file_path_;
  base::ScopedTempDir temp_dir_;
  base::test::ScopedFeatureList feature_list_;
  std::unique_ptr<TransportSecurityState> state_;
  std::unique_ptr<TransportSecurityPersister> persister_;
};

INSTANTIATE_TEST_SUITE_P(All, TransportSecurityPersisterTest, testing::Bool());

// Tests that LoadEntries() clears existing non-static entries.
TEST_P(TransportSecurityPersisterTest, LoadEntriesClearsExistingState) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitAndEnableFeature(
      TransportSecurityState::kDynamicExpectCTFeature);

  TransportSecurityState::STSState sts_state;
  TransportSecurityState::ExpectCTState expect_ct_state;
  const base::Time current_time(base::Time::Now());
  const base::Time expiry = current_time + base::TimeDelta::FromSeconds(1000);
  static const char kYahooDomain[] = "yahoo.com";

  EXPECT_FALSE(state_->GetDynamicSTSState(kYahooDomain, &sts_state));

  state_->AddHSTS(kYahooDomain, expiry, false /* include subdomains */);
  state_->AddExpectCT(kYahooDomain, expiry, true /* enforce */, GURL(),
                      NetworkIsolationKey());

  EXPECT_TRUE(state_->GetDynamicSTSState(kYahooDomain, &sts_state));
  EXPECT_TRUE(state_->GetDynamicExpectCTState(
      kYahooDomain, NetworkIsolationKey(), &expect_ct_state));

  persister_->LoadEntries("{\"version\":2}");

  EXPECT_FALSE(state_->GetDynamicSTSState(kYahooDomain, &sts_state));
  EXPECT_FALSE(state_->GetDynamicExpectCTState(
      kYahooDomain, NetworkIsolationKey(), &expect_ct_state));
}

// Tests that serializing -> deserializing -> reserializing results in the same
// output.
TEST_P(TransportSecurityPersisterTest, SerializeData1) {
  std::string output;

  EXPECT_TRUE(persister_->SerializeData(&output));
  persister_->LoadEntries(output);

  std::string output2;
  EXPECT_TRUE(persister_->SerializeData(&output2));
  EXPECT_EQ(output, output2);
}

TEST_P(TransportSecurityPersisterTest, SerializeData2) {
  TransportSecurityState::STSState sts_state;
  const base::Time current_time(base::Time::Now());
  const base::Time expiry = current_time + base::TimeDelta::FromSeconds(1000);
  static const char kYahooDomain[] = "yahoo.com";

  EXPECT_FALSE(state_->GetDynamicSTSState(kYahooDomain, &sts_state));

  bool include_subdomains = true;
  state_->AddHSTS(kYahooDomain, expiry, include_subdomains);

  std::string output;
  EXPECT_TRUE(persister_->SerializeData(&output));
  persister_->LoadEntries(output);

  EXPECT_TRUE(state_->GetDynamicSTSState(kYahooDomain, &sts_state));
  EXPECT_EQ(sts_state.upgrade_mode,
            TransportSecurityState::STSState::MODE_FORCE_HTTPS);
  EXPECT_TRUE(state_->GetDynamicSTSState("foo.yahoo.com", &sts_state));
  EXPECT_EQ(sts_state.upgrade_mode,
            TransportSecurityState::STSState::MODE_FORCE_HTTPS);
  EXPECT_TRUE(state_->GetDynamicSTSState("foo.bar.yahoo.com", &sts_state));
  EXPECT_EQ(sts_state.upgrade_mode,
            TransportSecurityState::STSState::MODE_FORCE_HTTPS);
  EXPECT_TRUE(state_->GetDynamicSTSState("foo.bar.baz.yahoo.com", &sts_state));
  EXPECT_EQ(sts_state.upgrade_mode,
            TransportSecurityState::STSState::MODE_FORCE_HTTPS);
}

TEST_P(TransportSecurityPersisterTest, SerializeData3) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitAndEnableFeature(
      TransportSecurityState::kDynamicExpectCTFeature);
  const GURL report_uri(kReportUri);
  // Add an entry.
  base::Time expiry =
      base::Time::Now() + base::TimeDelta::FromSeconds(1000);
  bool include_subdomains = false;
  state_->AddHSTS("www.example.com", expiry, include_subdomains);
  state_->AddExpectCT("www.example.com", expiry, true /* enforce */, GURL(),
                      NetworkIsolationKey());

  // Add another entry.
  expiry =
      base::Time::Now() + base::TimeDelta::FromSeconds(3000);
  state_->AddHSTS("www.example.net", expiry, include_subdomains);
  state_->AddExpectCT("www.example.net", expiry, false /* enforce */,
                      report_uri, NetworkIsolationKey());

  // Save a copy of everything.
  std::set<std::string> sts_saved;
  TransportSecurityState::STSStateIterator sts_iter(*state_);
  while (sts_iter.HasNext()) {
    sts_saved.insert(sts_iter.hostname());
    sts_iter.Advance();
  }

  std::set<std::string> expect_ct_saved;
  TransportSecurityState::ExpectCTStateIterator expect_ct_iter(*state_);
  while (expect_ct_iter.HasNext()) {
    expect_ct_saved.insert(expect_ct_iter.hostname());
    expect_ct_iter.Advance();
  }

  std::string serialized;
  EXPECT_TRUE(persister_->SerializeData(&serialized));

  // Persist the data to the file.
  base::RunLoop run_loop;
  persister_->WriteNow(state_.get(), run_loop.QuitClosure());
  run_loop.Run();

  // Read the data back.
  std::string persisted;
  EXPECT_TRUE(
      base::ReadFileToString(transport_security_file_path_, &persisted));
  EXPECT_EQ(persisted, serialized);
  persister_->LoadEntries(persisted);

  // Check that states are the same as saved.
  size_t count = 0;
  TransportSecurityState::STSStateIterator sts_iter2(*state_);
  while (sts_iter2.HasNext()) {
    count++;
    sts_iter2.Advance();
  }
  EXPECT_EQ(count, sts_saved.size());

  count = 0;
  TransportSecurityState::ExpectCTStateIterator expect_ct_iter2(*state_);
  while (expect_ct_iter2.HasNext()) {
    count++;
    expect_ct_iter2.Advance();
  }
  EXPECT_EQ(count, expect_ct_saved.size());
}

// Tests that deserializing bad data shouldn't result in any ExpectCT or STS
// entries being added to the transport security state.
TEST_P(TransportSecurityPersisterTest, DeserializeBadData) {
  persister_->LoadEntries("");
  EXPECT_EQ(0u, state_->num_expect_ct_entries_for_testing());
  EXPECT_EQ(0u, state_->num_sts_entries());

  persister_->LoadEntries("Foopy");
  EXPECT_EQ(0u, state_->num_expect_ct_entries_for_testing());
  EXPECT_EQ(0u, state_->num_sts_entries());

  persister_->LoadEntries("15");
  EXPECT_EQ(0u, state_->num_expect_ct_entries_for_testing());
  EXPECT_EQ(0u, state_->num_sts_entries());

  persister_->LoadEntries("[15]");
  EXPECT_EQ(0u, state_->num_expect_ct_entries_for_testing());
  EXPECT_EQ(0u, state_->num_sts_entries());

  persister_->LoadEntries("{\"version\":1}");
  EXPECT_EQ(0u, state_->num_expect_ct_entries_for_testing());
  EXPECT_EQ(0u, state_->num_sts_entries());
}

TEST_P(TransportSecurityPersisterTest, DeserializeDataOldWithoutCreationDate) {
  // This is an old-style piece of transport state JSON, which has no creation
  // date.
  const std::string kInput =
      "{ "
      "\"G0EywIek2XnIhLrUjaK4TrHBT1+2TcixDVRXwM3/CCo=\": {"
      "\"expiry\": 1266815027.983453, "
      "\"include_subdomains\": false, "
      "\"mode\": \"strict\" "
      "}"
      "}";
  persister_->LoadEntries(kInput);
  EXPECT_EQ(0u, state_->num_expect_ct_entries_for_testing());
  EXPECT_EQ(0u, state_->num_sts_entries());
}

TEST_P(TransportSecurityPersisterTest, DeserializeDataOldMergedDictionary) {
  // This is an old-style piece of transport state JSON, which uses a single
  // unversioned host-keyed dictionary of merged ExpectCT and HSTS data.
  const std::string kInput =
      "{"
      "   \"CxLbri+JPdi5pZ8/a/2rjyzq+IYs07WJJ1yxjB4Lpw0=\": {"
      "      \"expect_ct\": {"
      "         \"expect_ct_enforce\": true,"
      "         \"expect_ct_expiry\": 1590512843.283966,"
      "         \"expect_ct_observed\": 1590511843.284064,"
      "         \"expect_ct_report_uri\": \"https://expect_ct.test/report_uri\""
      "      },"
      "      \"expiry\": 0.0,"
      "      \"mode\": \"default\","
      "      \"sts_include_subdomains\": false,"
      "      \"sts_observed\": 0.0"
      "   },"
      "   \"DkgjGShIBmYtgJcJf5lfX3rTr2S6dqyF+O8IAgjuleE=\": {"
      "      \"expiry\": 1590512843.283966,"
      "      \"mode\": \"force-https\","
      "      \"sts_include_subdomains\": false,"
      "      \"sts_observed\": 1590511843.284025"
      "   },"
      "   \"M5lkNV3JBeoPMlKrTOKRYT+mrUsZCS5eoQWsc9/r1MU=\": {"
      "      \"expect_ct\": {"
      "         \"expect_ct_enforce\": true,"
      "         \"expect_ct_expiry\": 1590512843.283966,"
      "         \"expect_ct_observed\": 1590511843.284098,"
      "         \"expect_ct_report_uri\": \"\""
      "      },"
      "      \"expiry\": 1590512843.283966,"
      "      \"mode\": \"force-https\","
      "      \"sts_include_subdomains\": true,"
      "      \"sts_observed\": 1590511843.284091"
      "   }"
      "}";

  persister_->LoadEntries(kInput);
  EXPECT_EQ(0u, state_->num_expect_ct_entries_for_testing());
  EXPECT_EQ(0u, state_->num_sts_entries());
}

// Tests that dynamic Expect-CT state is serialized and deserialized correctly.
TEST_P(TransportSecurityPersisterTest, ExpectCT) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitAndEnableFeature(
      TransportSecurityState::kDynamicExpectCTFeature);
  const GURL report_uri(kReportUri);
  TransportSecurityState::ExpectCTState expect_ct_state;
  static const char kTestDomain[] = "example.test";

  EXPECT_FALSE(state_->GetDynamicExpectCTState(
      kTestDomain, NetworkIsolationKey(), &expect_ct_state));

  const base::Time current_time(base::Time::Now());
  const base::Time expiry = current_time + base::TimeDelta::FromSeconds(1000);
  state_->AddExpectCT(kTestDomain, expiry, true /* enforce */, GURL(),
                      NetworkIsolationKey());
  std::string serialized;
  EXPECT_TRUE(persister_->SerializeData(&serialized));
  // LoadEntries() clears existing dynamic data before loading entries from
  // |serialized|.
  persister_->LoadEntries(serialized);

  TransportSecurityState::ExpectCTState new_expect_ct_state;
  EXPECT_TRUE(state_->GetDynamicExpectCTState(
      kTestDomain, NetworkIsolationKey(), &new_expect_ct_state));
  EXPECT_TRUE(new_expect_ct_state.enforce);
  EXPECT_TRUE(new_expect_ct_state.report_uri.is_empty());
  EXPECT_EQ(expiry, new_expect_ct_state.expiry);

  // Update the state for the domain and check that it is
  // serialized/deserialized correctly.
  state_->AddExpectCT(kTestDomain, expiry, false /* enforce */, report_uri,
                      NetworkIsolationKey());
  EXPECT_TRUE(persister_->SerializeData(&serialized));
  persister_->LoadEntries(serialized);
  EXPECT_TRUE(state_->GetDynamicExpectCTState(
      kTestDomain, NetworkIsolationKey(), &new_expect_ct_state));
  EXPECT_FALSE(new_expect_ct_state.enforce);
  EXPECT_EQ(report_uri, new_expect_ct_state.report_uri);
  EXPECT_EQ(expiry, new_expect_ct_state.expiry);
}

// Tests that dynamic Expect-CT state is serialized and deserialized correctly
// when there is also STS data present.
TEST_P(TransportSecurityPersisterTest, ExpectCTWithSTSDataPresent) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitAndEnableFeature(
      TransportSecurityState::kDynamicExpectCTFeature);
  const GURL report_uri(kReportUri);
  TransportSecurityState::ExpectCTState expect_ct_state;
  static const char kTestDomain[] = "example.test";

  EXPECT_FALSE(state_->GetDynamicExpectCTState(
      kTestDomain, NetworkIsolationKey(), &expect_ct_state));

  const base::Time current_time(base::Time::Now());
  const base::Time expiry = current_time + base::TimeDelta::FromSeconds(1000);
  state_->AddHSTS(kTestDomain, expiry, false /* include subdomains */);
  state_->AddExpectCT(kTestDomain, expiry, true /* enforce */, GURL(),
                      NetworkIsolationKey());

  std::string serialized;
  EXPECT_TRUE(persister_->SerializeData(&serialized));
  // LoadEntries() clears existing dynamic data before loading entries from
  // |serialized|.
  persister_->LoadEntries(serialized);

  TransportSecurityState::ExpectCTState new_expect_ct_state;
  EXPECT_TRUE(state_->GetDynamicExpectCTState(
      kTestDomain, NetworkIsolationKey(), &new_expect_ct_state));
  EXPECT_TRUE(new_expect_ct_state.enforce);
  EXPECT_TRUE(new_expect_ct_state.report_uri.is_empty());
  EXPECT_EQ(expiry, new_expect_ct_state.expiry);
  // Check that STS state is loaded properly as well.
  TransportSecurityState::STSState sts_state;
  EXPECT_TRUE(state_->GetDynamicSTSState(kTestDomain, &sts_state));
  EXPECT_EQ(sts_state.upgrade_mode,
            TransportSecurityState::STSState::MODE_FORCE_HTTPS);
}

// Tests that Expect-CT state is not serialized and persisted when the feature
// is disabled.
TEST_P(TransportSecurityPersisterTest, ExpectCTDisabled) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitAndDisableFeature(
      TransportSecurityState::kDynamicExpectCTFeature);
  const GURL report_uri(kReportUri);
  TransportSecurityState::ExpectCTState expect_ct_state;
  static const char kTestDomain[] = "example.test";

  EXPECT_FALSE(state_->GetDynamicExpectCTState(
      kTestDomain, NetworkIsolationKey(), &expect_ct_state));

  const base::Time current_time(base::Time::Now());
  const base::Time expiry = current_time + base::TimeDelta::FromSeconds(1000);
  state_->AddExpectCT(kTestDomain, expiry, true /* enforce */, GURL(),
                      NetworkIsolationKey());
  std::string serialized;
  EXPECT_TRUE(persister_->SerializeData(&serialized));
  persister_->LoadEntries(serialized);

  TransportSecurityState::ExpectCTState new_expect_ct_state;
  EXPECT_FALSE(state_->GetDynamicExpectCTState(
      kTestDomain, NetworkIsolationKey(), &new_expect_ct_state));
}

// Save data with several NetworkIsolationKeys with
// kPartitionExpectCTStateByNetworkIsolationKey enabled, and then load it with
// the feature enabled or disabled, based on partition_expect_ct_state().
TEST_P(TransportSecurityPersisterTest, ExpectCTWithNetworkIsolationKey) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitAndEnableFeature(
      TransportSecurityState::kDynamicExpectCTFeature);

  const GURL report_uri(kReportUri);
  static const char kTestDomain[] = "example.test";
  const SchemefulSite kSite(GURL("https://somewhere.else.test"));
  const NetworkIsolationKey empty_network_isolation_key;
  const NetworkIsolationKey network_isolation_key(kSite /* top_frame_site */,
                                                  kSite /* frame_site */);
  const NetworkIsolationKey transient_network_isolation_key =
      NetworkIsolationKey::CreateTransient();

  const base::Time current_time(base::Time::Now());
  const base::Time expiry1 = current_time + base::TimeDelta::FromSeconds(1000);
  const base::Time expiry2 = current_time + base::TimeDelta::FromSeconds(2000);
  const base::Time expiry3 = current_time + base::TimeDelta::FromSeconds(3000);

  // Serialize data with kPartitionExpectCTStateByNetworkIsolationKey enabled,
  // and then revert the feature to its previous value.
  std::string serialized;
  {
    base::test::ScopedFeatureList feature_list2;
    feature_list2.InitAndEnableFeature(
        features::kPartitionExpectCTStateByNetworkIsolationKey);
    TransportSecurityState state2;
    TransportSecurityPersister persister2(
        &state2,
        std::move(base::ThreadPool::CreateSequencedTaskRunner(
            {base::MayBlock(), base::TaskPriority::BEST_EFFORT,
             base::TaskShutdownBehavior::BLOCK_SHUTDOWN})),
        transport_security_file_path_);
    TransportSecurityState::ExpectCTState expect_ct_state;
    state2.AddExpectCT(kTestDomain, expiry1, true /* enforce */, GURL(),
                       empty_network_isolation_key);
    state2.AddExpectCT(kTestDomain, expiry2, true /* enforce */, GURL(),
                       network_isolation_key);
    state2.AddExpectCT(kTestDomain, expiry3, true /* enforce */, GURL(),
                       transient_network_isolation_key);
    EXPECT_TRUE(persister2.SerializeData(&serialized));

    EXPECT_TRUE(state2.GetDynamicExpectCTState(
        kTestDomain, empty_network_isolation_key, &expect_ct_state));
    EXPECT_TRUE(state2.GetDynamicExpectCTState(
        kTestDomain, network_isolation_key, &expect_ct_state));
    EXPECT_TRUE(state2.GetDynamicExpectCTState(
        kTestDomain, transient_network_isolation_key, &expect_ct_state));
  }

  // Load entries into the other persister.
  persister_->LoadEntries(serialized);

  if (partition_expect_ct_state()) {
    TransportSecurityState::ExpectCTState new_expect_ct_state;
    EXPECT_TRUE(state_->GetDynamicExpectCTState(
        kTestDomain, empty_network_isolation_key, &new_expect_ct_state));
    EXPECT_TRUE(new_expect_ct_state.enforce);
    EXPECT_TRUE(new_expect_ct_state.report_uri.is_empty());
    EXPECT_EQ(expiry1, new_expect_ct_state.expiry);

    EXPECT_TRUE(state_->GetDynamicExpectCTState(
        kTestDomain, network_isolation_key, &new_expect_ct_state));
    EXPECT_TRUE(new_expect_ct_state.enforce);
    EXPECT_TRUE(new_expect_ct_state.report_uri.is_empty());
    EXPECT_EQ(expiry2, new_expect_ct_state.expiry);

    // The data associated with the transient NetworkIsolationKey should not
    // have been saved.
    EXPECT_FALSE(state_->GetDynamicExpectCTState(
        kTestDomain, transient_network_isolation_key, &new_expect_ct_state));
  } else {
    std::set<std::string> expect_ct_saved;
    TransportSecurityState::ExpectCTStateIterator expect_ct_iter(*state_);
    ASSERT_TRUE(expect_ct_iter.HasNext());
    EXPECT_EQ(empty_network_isolation_key,
              expect_ct_iter.network_isolation_key());
    EXPECT_TRUE(expect_ct_iter.domain_state().enforce);
    EXPECT_TRUE(expect_ct_iter.domain_state().report_uri.is_empty());
    expect_ct_iter.Advance();
    EXPECT_FALSE(expect_ct_iter.HasNext());
  }
}

// Test the case when deserializing a NetworkIsolationKey fails.
TEST_P(TransportSecurityPersisterTest,
       ExpectCTNetworkIsolationKeyDeserializationFails) {
  base::test::ScopedFeatureList feature_list;
  feature_list.InitWithFeatures(
      // enabled_features
      {TransportSecurityState::kDynamicExpectCTFeature,
       features::kPartitionExpectCTStateByNetworkIsolationKey},
      // disabled_features
      {});

  const GURL report_uri(kReportUri);
  static const char kTestDomain[] = "example.test";
  const SchemefulSite kSite(GURL("https://somewhere.else.test"));
  const NetworkIsolationKey empty_network_isolation_key;
  const NetworkIsolationKey network_isolation_key(kSite /* top_frame_site */,
                                                  kSite /* frame_site */);
  const base::Time current_time(base::Time::Now());
  const base::Time expiry1 = current_time + base::TimeDelta::FromSeconds(1000);
  const base::Time expiry2 = current_time + base::TimeDelta::FromSeconds(2000);

  // Serialize data.
  std::string serialized;
  TransportSecurityState state2;
  TransportSecurityPersister persister2(
      &state2,
      std::move(base::ThreadPool::CreateSequencedTaskRunner(
          {base::MayBlock(), base::TaskPriority::BEST_EFFORT,
           base::TaskShutdownBehavior::BLOCK_SHUTDOWN})),
      transport_security_file_path_);
  TransportSecurityState::ExpectCTState expect_ct_state;
  state2.AddExpectCT(kTestDomain, expiry1, true /* enforce */, GURL(),
                     empty_network_isolation_key);
  state2.AddExpectCT(kTestDomain, expiry2, true /* enforce */, GURL(),
                     network_isolation_key);
  EXPECT_TRUE(persister2.SerializeData(&serialized));

  EXPECT_TRUE(state2.GetDynamicExpectCTState(
      kTestDomain, empty_network_isolation_key, &expect_ct_state));
  EXPECT_TRUE(state2.GetDynamicExpectCTState(kTestDomain, network_isolation_key,
                                             &expect_ct_state));

  // Replace reference to |network_isolation_key|'s value with an invalid NIK
  // value.
  base::Value nik_value;
  ASSERT_TRUE(network_isolation_key.ToValue(&nik_value));
  std::string nik_string;
  ASSERT_TRUE(base::JSONWriter::Write(nik_value, &nik_string));
  base::ReplaceFirstSubstringAfterOffset(&serialized, 0, nik_string,
                                         "\"Not a valid NIK\"");

  // Load entries into the other persister.
  persister_->LoadEntries(serialized);

  // The entry with the non-empty NetworkIsolationKey should be dropped, since
  // its NIK is now invalid. The other entry should be preserved.
  std::set<std::string> expect_ct_saved;
  TransportSecurityState::ExpectCTStateIterator expect_ct_iter(*state_);
  ASSERT_TRUE(expect_ct_iter.HasNext());
  EXPECT_EQ(empty_network_isolation_key,
            expect_ct_iter.network_isolation_key());
  EXPECT_TRUE(expect_ct_iter.domain_state().enforce);
  EXPECT_TRUE(expect_ct_iter.domain_state().report_uri.is_empty());
  expect_ct_iter.Advance();
  EXPECT_FALSE(expect_ct_iter.HasNext());
}

}  // namespace

}  // namespace net