1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/cert/nss_profile_filter_chromeos.h"
#include <cert.h>
#include <pk11pub.h>
#include <secmod.h>
#include <algorithm>
#include <utility>
#include "crypto/nss_util_internal.h"
#include "crypto/scoped_nss_types.h"
#include "crypto/scoped_test_nss_chromeos_user.h"
#include "crypto/scoped_test_nss_db.h"
#include "net/base/hash_value.h"
#include "net/cert/x509_util_nss.h"
#include "net/test/cert_test_util.h"
#include "net/test/test_data_directory.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
namespace {
crypto::ScopedPK11Slot GetRootCertsSlot() {
crypto::AutoSECMODListReadLock auto_lock;
SECMODModuleList* head = SECMOD_GetDefaultModuleList();
for (SECMODModuleList* item = head; item != nullptr; item = item->next) {
int slot_count = item->module->loaded ? item->module->slotCount : 0;
for (int i = 0; i < slot_count; i++) {
PK11SlotInfo* slot = item->module->slots[i];
if (!PK11_IsPresent(slot))
continue;
if (PK11_HasRootCerts(slot))
return crypto::ScopedPK11Slot(PK11_ReferenceSlot(slot));
}
}
return crypto::ScopedPK11Slot();
}
ScopedCERTCertificateList ListCertsInSlot(PK11SlotInfo* slot) {
ScopedCERTCertificateList result;
CERTCertList* cert_list = PK11_ListCertsInSlot(slot);
if (!cert_list)
return result;
for (CERTCertListNode* node = CERT_LIST_HEAD(cert_list);
!CERT_LIST_END(node, cert_list);
node = CERT_LIST_NEXT(node)) {
result.push_back(x509_util::DupCERTCertificate(node->cert));
}
CERT_DestroyCertList(cert_list);
// Sort the result so that test comparisons can be deterministic.
std::sort(
result.begin(), result.end(),
[](const ScopedCERTCertificate& lhs, const ScopedCERTCertificate& rhs) {
return x509_util::CalculateFingerprint256(lhs.get()) <
x509_util::CalculateFingerprint256(rhs.get());
});
return result;
}
} // anonymous namespace
class NSSProfileFilterChromeOSTest : public testing::Test {
public:
NSSProfileFilterChromeOSTest() : user_1_("user1"), user_2_("user2") {}
void SetUp() override {
ASSERT_TRUE(system_slot_user_.is_open());
ASSERT_TRUE(user_1_.constructed_successfully());
ASSERT_TRUE(user_2_.constructed_successfully());
user_1_.FinishInit();
user_2_.FinishInit();
// TODO(mattm): more accurately test public/private slot filtering somehow.
// (The slots used to initialize a profile filter should be separate slots
// in separate modules, while ScopedTestNSSChromeOSUser uses the same slot
// for both.)
crypto::ScopedPK11Slot private_slot_1(crypto::GetPrivateSlotForChromeOSUser(
user_1_.username_hash(),
base::OnceCallback<void(crypto::ScopedPK11Slot)>()));
ASSERT_TRUE(private_slot_1.get());
profile_filter_1_.Init(
crypto::GetPublicSlotForChromeOSUser(user_1_.username_hash()),
std::move(private_slot_1), get_system_slot());
profile_filter_1_copy_ = profile_filter_1_;
crypto::ScopedPK11Slot private_slot_2(crypto::GetPrivateSlotForChromeOSUser(
user_2_.username_hash(),
base::OnceCallback<void(crypto::ScopedPK11Slot)>()));
ASSERT_TRUE(private_slot_2.get());
profile_filter_2_.Init(
crypto::GetPublicSlotForChromeOSUser(user_2_.username_hash()),
std::move(private_slot_2),
crypto::ScopedPK11Slot() /* no system slot */);
certs_ = CreateCERTCertificateListFromFile(GetTestCertsDirectory(),
"root_ca_cert.pem",
X509Certificate::FORMAT_AUTO);
ASSERT_EQ(1U, certs_.size());
}
crypto::ScopedPK11Slot get_system_slot() {
return crypto::ScopedPK11Slot(PK11_ReferenceSlot(system_slot_user_.slot()));
}
protected:
ScopedCERTCertificateList certs_;
crypto::ScopedTestNSSDB system_slot_user_;
crypto::ScopedTestNSSChromeOSUser user_1_;
crypto::ScopedTestNSSChromeOSUser user_2_;
NSSProfileFilterChromeOS no_slots_profile_filter_;
NSSProfileFilterChromeOS profile_filter_1_;
NSSProfileFilterChromeOS profile_filter_2_;
NSSProfileFilterChromeOS profile_filter_1_copy_;
};
TEST_F(NSSProfileFilterChromeOSTest, TempCertNotAllowed) {
EXPECT_EQ(nullptr, certs_[0]->slot);
EXPECT_FALSE(no_slots_profile_filter_.IsCertAllowed(certs_[0].get()));
EXPECT_FALSE(profile_filter_1_.IsCertAllowed(certs_[0].get()));
EXPECT_FALSE(profile_filter_1_copy_.IsCertAllowed(certs_[0].get()));
EXPECT_FALSE(profile_filter_2_.IsCertAllowed(certs_[0].get()));
}
TEST_F(NSSProfileFilterChromeOSTest, InternalSlotAllowed) {
crypto::ScopedPK11Slot internal_slot(PK11_GetInternalSlot());
ASSERT_TRUE(internal_slot.get());
EXPECT_TRUE(no_slots_profile_filter_.IsModuleAllowed(internal_slot.get()));
EXPECT_TRUE(profile_filter_1_.IsModuleAllowed(internal_slot.get()));
EXPECT_TRUE(profile_filter_1_copy_.IsModuleAllowed(internal_slot.get()));
EXPECT_TRUE(profile_filter_2_.IsModuleAllowed(internal_slot.get()));
crypto::ScopedPK11Slot internal_key_slot(PK11_GetInternalKeySlot());
ASSERT_TRUE(internal_key_slot.get());
EXPECT_TRUE(
no_slots_profile_filter_.IsModuleAllowed(internal_key_slot.get()));
EXPECT_TRUE(profile_filter_1_.IsModuleAllowed(internal_key_slot.get()));
EXPECT_TRUE(profile_filter_1_copy_.IsModuleAllowed(internal_key_slot.get()));
EXPECT_TRUE(profile_filter_2_.IsModuleAllowed(internal_key_slot.get()));
}
TEST_F(NSSProfileFilterChromeOSTest, RootCertsAllowed) {
crypto::ScopedPK11Slot root_certs_slot(GetRootCertsSlot());
ASSERT_TRUE(root_certs_slot.get());
EXPECT_TRUE(no_slots_profile_filter_.IsModuleAllowed(root_certs_slot.get()));
EXPECT_TRUE(profile_filter_1_.IsModuleAllowed(root_certs_slot.get()));
EXPECT_TRUE(profile_filter_1_copy_.IsModuleAllowed(root_certs_slot.get()));
EXPECT_TRUE(profile_filter_2_.IsModuleAllowed(root_certs_slot.get()));
ScopedCERTCertificateList root_certs(ListCertsInSlot(root_certs_slot.get()));
ASSERT_FALSE(root_certs.empty());
EXPECT_TRUE(no_slots_profile_filter_.IsCertAllowed(root_certs[0].get()));
EXPECT_TRUE(profile_filter_1_.IsCertAllowed(root_certs[0].get()));
EXPECT_TRUE(profile_filter_1_copy_.IsCertAllowed(root_certs[0].get()));
EXPECT_TRUE(profile_filter_2_.IsCertAllowed(root_certs[0].get()));
}
TEST_F(NSSProfileFilterChromeOSTest, SoftwareSlots) {
crypto::ScopedPK11Slot system_slot(get_system_slot());
crypto::ScopedPK11Slot slot_1(
crypto::GetPublicSlotForChromeOSUser(user_1_.username_hash()));
ASSERT_TRUE(slot_1);
crypto::ScopedPK11Slot slot_2(
crypto::GetPublicSlotForChromeOSUser(user_2_.username_hash()));
ASSERT_TRUE(slot_2);
CERTCertificate* cert_1 = certs_[0].get();
ScopedCERTCertificateList certs_2 = CreateCERTCertificateListFromFile(
GetTestCertsDirectory(), "ok_cert.pem", X509Certificate::FORMAT_AUTO);
ASSERT_EQ(1U, certs_2.size());
CERTCertificate* cert_2 = certs_2[0].get();
ScopedCERTCertificateList system_certs = CreateCERTCertificateListFromFile(
GetTestCertsDirectory(), "mit.davidben.der",
X509Certificate::FORMAT_AUTO);
ASSERT_EQ(1U, system_certs.size());
CERTCertificate* system_cert = system_certs[0].get();
ASSERT_EQ(SECSuccess,
PK11_ImportCert(slot_1.get(), cert_1, CK_INVALID_HANDLE, "cert1",
PR_FALSE /* includeTrust (unused) */));
ASSERT_EQ(SECSuccess,
PK11_ImportCert(slot_2.get(), cert_2, CK_INVALID_HANDLE, "cert2",
PR_FALSE /* includeTrust (unused) */));
ASSERT_EQ(SECSuccess, PK11_ImportCert(system_slot.get(), system_cert,
CK_INVALID_HANDLE, "systemcert",
PR_FALSE /* includeTrust (unused) */));
EXPECT_FALSE(no_slots_profile_filter_.IsCertAllowed(cert_1));
EXPECT_FALSE(no_slots_profile_filter_.IsCertAllowed(cert_2));
EXPECT_FALSE(no_slots_profile_filter_.IsCertAllowed(system_cert));
EXPECT_TRUE(profile_filter_1_.IsCertAllowed(cert_1));
EXPECT_TRUE(profile_filter_1_copy_.IsCertAllowed(cert_1));
EXPECT_FALSE(profile_filter_1_.IsCertAllowed(cert_2));
EXPECT_FALSE(profile_filter_1_copy_.IsCertAllowed(cert_2));
EXPECT_TRUE(profile_filter_1_.IsCertAllowed(system_cert));
EXPECT_TRUE(profile_filter_1_copy_.IsCertAllowed(system_cert));
EXPECT_FALSE(profile_filter_2_.IsCertAllowed(cert_1));
EXPECT_TRUE(profile_filter_2_.IsCertAllowed(cert_2));
EXPECT_FALSE(profile_filter_2_.IsCertAllowed(system_cert));
}
} // namespace net
|
