1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
|
// Copyright 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "media/capture/video/mac/pixel_buffer_pool_mac.h"
#include "base/bind.h"
#include "base/mac/scoped_nsobject.h"
#import "media/capture/video/mac/test/video_capture_test_utils_mac.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace media {
namespace {
// NV12, also known as 420v, also known as media::PIXEL_FORMAT_NV12.
constexpr OSType kPixelFormatNv12 =
kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange;
// A common 4:3 resolution.
constexpr int kVgaWidth = 640;
constexpr int kVgaHeight = 480;
} // namespace
TEST(PixelBufferPoolTest, CannotCreatePoolWithNonsenseArguments) {
EXPECT_FALSE(PixelBufferPool::Create(0, -1, -1, 1));
}
TEST(PixelBufferPoolTest, CreatedBufferHasSpecifiedAttributes) {
std::unique_ptr<PixelBufferPool> pool =
PixelBufferPool::Create(kPixelFormatNv12, kVgaWidth, kVgaHeight, 1);
base::ScopedCFTypeRef<CVPixelBufferRef> buffer = pool->CreateBuffer();
EXPECT_TRUE(CVPixelBufferGetPixelFormatType(buffer) == kPixelFormatNv12);
EXPECT_EQ(CVPixelBufferGetWidth(buffer), static_cast<size_t>(kVgaWidth));
EXPECT_EQ(CVPixelBufferGetHeight(buffer), static_cast<size_t>(kVgaHeight));
}
TEST(PixelBufferPoolTest, CreatedBufferHasIOSurface) {
std::unique_ptr<PixelBufferPool> pool =
PixelBufferPool::Create(kPixelFormatNv12, kVgaWidth, kVgaHeight, 1);
base::ScopedCFTypeRef<CVPixelBufferRef> buffer = pool->CreateBuffer();
EXPECT_TRUE(CVPixelBufferGetIOSurface(buffer));
}
TEST(PixelBufferPoolTest, CannotExceedMaxBuffersWhenHoldingOnToPixelBuffer) {
constexpr size_t kPoolMaxBuffers = 2;
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, kPoolMaxBuffers);
base::ScopedCFTypeRef<CVPixelBufferRef> first_buffer = pool->CreateBuffer();
EXPECT_TRUE(first_buffer);
base::ScopedCFTypeRef<CVPixelBufferRef> second_buffer = pool->CreateBuffer();
EXPECT_TRUE(second_buffer);
base::ScopedCFTypeRef<CVPixelBufferRef> third_buffer = pool->CreateBuffer();
EXPECT_FALSE(third_buffer);
}
TEST(PixelBufferPoolTest, CannotExceedMaxBuffersWhenIOSurfaceIsInUse) {
constexpr size_t kPoolMaxBuffers = 1;
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, kPoolMaxBuffers);
base::ScopedCFTypeRef<CVPixelBufferRef> first_buffer = pool->CreateBuffer();
EXPECT_TRUE(first_buffer);
IOSurfaceRef io_surface = CVPixelBufferGetIOSurface(first_buffer);
EXPECT_TRUE(io_surface);
// Incremet use count of raw ptr IOSurface reference while releasing the pixel
// buffer's only reference.
IOSurfaceIncrementUseCount(io_surface);
first_buffer.reset();
// The pixel buffer has not been returned to the pool.
base::ScopedCFTypeRef<CVPixelBufferRef> second_buffer = pool->CreateBuffer();
EXPECT_FALSE(second_buffer);
// Cleanup.
IOSurfaceDecrementUseCount(io_surface);
}
TEST(PixelBufferPoolTest, CanCreateBuffersIfMaxIsNull) {
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, base::nullopt);
base::ScopedCFTypeRef<CVPixelBufferRef> first_buffer = pool->CreateBuffer();
EXPECT_TRUE(first_buffer);
base::ScopedCFTypeRef<CVPixelBufferRef> second_buffer = pool->CreateBuffer();
EXPECT_TRUE(second_buffer);
base::ScopedCFTypeRef<CVPixelBufferRef> third_buffer = pool->CreateBuffer();
EXPECT_TRUE(third_buffer);
}
TEST(PixelBufferPoolTest, CanCreateBufferAfterPreviousBufferIsReleased) {
constexpr size_t kPoolMaxBuffers = 1;
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, kPoolMaxBuffers);
base::ScopedCFTypeRef<CVPixelBufferRef> buffer = pool->CreateBuffer();
buffer.reset();
buffer = pool->CreateBuffer();
EXPECT_TRUE(buffer);
}
TEST(PixelBufferPoolTest, CanCreateBufferAfterPreviousIOSurfaceIsNoLongerUsed) {
constexpr size_t kPoolMaxBuffers = 1;
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, kPoolMaxBuffers);
base::ScopedCFTypeRef<CVPixelBufferRef> first_buffer = pool->CreateBuffer();
EXPECT_TRUE(first_buffer);
IOSurfaceRef io_surface = CVPixelBufferGetIOSurface(first_buffer);
EXPECT_TRUE(io_surface);
IOSurfaceIncrementUseCount(io_surface);
first_buffer.reset();
// Decrementing the use count when there are no pixel buffer references
// returns it to the pool.
IOSurfaceDecrementUseCount(io_surface);
base::ScopedCFTypeRef<CVPixelBufferRef> second_buffer = pool->CreateBuffer();
EXPECT_TRUE(second_buffer);
}
TEST(PixelBufferPoolTest,
SimplyReferencingAnIOSurfaceDoesNotPreventItReturningToThePool) {
constexpr size_t kPoolMaxBuffers = 1;
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, kPoolMaxBuffers);
base::ScopedCFTypeRef<CVPixelBufferRef> first_buffer = pool->CreateBuffer();
EXPECT_TRUE(first_buffer);
base::ScopedCFTypeRef<IOSurfaceRef> first_buffer_io_surface(
CVPixelBufferGetIOSurface(first_buffer), base::scoped_policy::RETAIN);
EXPECT_TRUE(first_buffer_io_surface);
// Releasing the first buffer returns it to the pool, despite the IOSurface
// still being referenced by |first_buffer_io_surface|.
first_buffer.reset();
base::ScopedCFTypeRef<CVPixelBufferRef> second_buffer = pool->CreateBuffer();
EXPECT_TRUE(second_buffer);
base::ScopedCFTypeRef<IOSurfaceRef> second_buffer_io_surface(
CVPixelBufferGetIOSurface(second_buffer), base::scoped_policy::RETAIN);
EXPECT_TRUE(second_buffer_io_surface);
// Because this is a recycled pixel buffer, the IOSurface is also recycled.
EXPECT_EQ(IOSurfaceGetID(first_buffer_io_surface),
IOSurfaceGetID(second_buffer_io_surface));
}
TEST(PixelBufferPoolTest, RecreatePoolAndObserveRecycledIOSurfaceID) {
constexpr size_t kPoolMaxBuffers = 1;
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, kPoolMaxBuffers);
base::ScopedCFTypeRef<CVPixelBufferRef> first_buffer = pool->CreateBuffer();
EXPECT_TRUE(first_buffer);
IOSurfaceID first_buffer_id =
IOSurfaceGetID(CVPixelBufferGetIOSurface(first_buffer));
// Free references and recreate the pool. There is nothing preventing the
// IOSurfaceID from being recycled, even by a different CVPixelBufferPool with
// a different resolution!
first_buffer.reset();
pool = PixelBufferPool::Create(kPixelFormatNv12, kVgaWidth / 2,
kVgaHeight / 2, kPoolMaxBuffers);
base::ScopedCFTypeRef<CVPixelBufferRef> second_buffer = pool->CreateBuffer();
EXPECT_TRUE(second_buffer);
IOSurfaceID second_buffer_id =
IOSurfaceGetID(CVPixelBufferGetIOSurface(second_buffer));
// The new pool is allowed to recycle the old IOSurface ID.
//
// This test documents "foot gun" behavior that is not documented by Apple
// anywhere. If the test starts failing, it may be because this behavior is
// specific to version or hardware. In such cases, feel free to disable the
// test.
EXPECT_EQ(first_buffer_id, second_buffer_id);
}
TEST(PixelBufferPoolTest, BuffersCanOutliveThePool) {
std::unique_ptr<PixelBufferPool> pool =
PixelBufferPool::Create(kPixelFormatNv12, kVgaWidth, kVgaHeight, 1);
base::ScopedCFTypeRef<CVPixelBufferRef> buffer = pool->CreateBuffer();
pool.reset();
EXPECT_TRUE(CVPixelBufferGetPixelFormatType(buffer) == kPixelFormatNv12);
EXPECT_EQ(CVPixelBufferGetWidth(buffer), static_cast<size_t>(kVgaWidth));
EXPECT_EQ(CVPixelBufferGetHeight(buffer), static_cast<size_t>(kVgaHeight));
EXPECT_TRUE(CVPixelBufferGetIOSurface(buffer));
}
TEST(PixelBufferPoolTest, CanFlushWhileBufferIsInUse) {
std::unique_ptr<PixelBufferPool> pool = PixelBufferPool::Create(
kPixelFormatNv12, kVgaWidth, kVgaHeight, base::nullopt);
base::ScopedCFTypeRef<CVPixelBufferRef> retained_buffer =
pool->CreateBuffer();
base::ScopedCFTypeRef<CVPixelBufferRef> released_buffer =
pool->CreateBuffer();
released_buffer.reset();
// We expect the memory of |released_buffer| to be freed now, but there is no
// way to assert this in a unittest.
pool->Flush();
// We expect |retained_buffer| is still usable. Inspecting its properties.
EXPECT_TRUE(CVPixelBufferGetPixelFormatType(retained_buffer) ==
kPixelFormatNv12);
EXPECT_EQ(CVPixelBufferGetWidth(retained_buffer),
static_cast<size_t>(kVgaWidth));
EXPECT_EQ(CVPixelBufferGetHeight(retained_buffer),
static_cast<size_t>(kVgaHeight));
EXPECT_TRUE(CVPixelBufferGetIOSurface(retained_buffer));
}
} // namespace media
|
