1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
|
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/password_manager/core/browser/http_data_cleaner.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "components/password_manager/core/browser/mock_password_store.h"
#include "components/password_manager/core/browser/password_manager_test_utils.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using autofill::PasswordForm;
using testing::Invoke;
using testing::Message;
using testing::Mock;
using testing::NiceMock;
using testing::_;
namespace password_manager {
constexpr char kTestHttpURL[] = "http://example.org/";
constexpr char kTestHttpsURL[] = "https://example.org/";
PasswordForm CreateTestHTTPForm() {
PasswordForm form;
form.origin = GURL(kTestHttpURL);
form.signon_realm = form.origin.spec();
form.action = form.origin;
form.username_value = base::ASCIIToUTF16("user");
form.password_value = base::ASCIIToUTF16("password");
return form;
}
PasswordForm CreateTestHTTPSForm() {
PasswordForm form;
form.origin = GURL(kTestHttpsURL);
form.signon_realm = form.origin.spec();
form.action = form.origin;
form.username_value = base::ASCIIToUTF16("user");
form.password_value = base::ASCIIToUTF16("password");
return form;
}
InteractionsStats CreateTestHTTPStats() {
InteractionsStats stats;
stats.origin_domain = GURL(kTestHttpURL);
stats.username_value = base::ASCIIToUTF16("user");
return stats;
}
InteractionsStats CreateTestHTTPSStats() {
InteractionsStats stats;
stats.origin_domain = GURL(kTestHttpsURL);
stats.username_value = base::ASCIIToUTF16("user");
return stats;
}
class HTTPDataCleanerTest : public testing::Test {
public:
HTTPDataCleanerTest()
: store_(new NiceMock<MockPasswordStore>),
prefs_(base::MakeUnique<TestingPrefServiceSimple>()),
request_context_(new net::TestURLRequestContextGetter(
base::ThreadTaskRunnerHandle::Get())) {
prefs()->registry()->RegisterBooleanPref(prefs::kWasObsoleteHttpDataCleaned,
false);
}
~HTTPDataCleanerTest() override { store_->ShutdownOnUIThread(); }
MockPasswordStore* store() { return store_.get(); }
TestingPrefServiceSimple* prefs() { return prefs_.get(); }
const scoped_refptr<net::TestURLRequestContextGetter>& request_context() {
return request_context_;
}
private:
base::MessageLoop message_loop_; // Used by store_ and request_context_.
scoped_refptr<MockPasswordStore> store_;
std::unique_ptr<TestingPrefServiceSimple> prefs_;
scoped_refptr<net::TestURLRequestContextGetter> request_context_;
DISALLOW_COPY_AND_ASSIGN(HTTPDataCleanerTest);
};
TEST_F(HTTPDataCleanerTest, TestBlacklistDeletion) {
for (bool is_http : {false, true}) {
for (bool is_hsts : {false, true}) {
SCOPED_TRACE(Message() << std::boolalpha << "(is_http, is_hsts): ("
<< is_http << ", " << is_hsts << ")");
prefs()->SetBoolean(prefs::kWasObsoleteHttpDataCleaned, false);
const bool should_be_deleted = is_http && is_hsts;
PasswordForm form =
is_http ? CreateTestHTTPForm() : CreateTestHTTPSForm();
form.blacklisted_by_user = true;
form.username_value.clear();
form.password_value.clear();
HSTSStateManager manager(
request_context()->GetURLRequestContext()->transport_security_state(),
is_hsts, form.origin.host());
EXPECT_CALL(*store(), FillBlacklistLogins(_))
.WillOnce(Invoke(
[&form](
std::vector<std::unique_ptr<autofill::PasswordForm>>* forms) {
*forms = WrapForms({form});
return true;
}));
EXPECT_CALL(*store(), RemoveLogin(form)).Times(should_be_deleted);
// Initiate clean up and make sure all aync tasks are run until
// completion.
CleanObsoleteHttpDataForPasswordStoreAndPrefsForTesting(
store(), prefs(), request_context());
base::RunLoop().RunUntilIdle();
// Verify and clear all expectations as well as the preference.
Mock::VerifyAndClearExpectations(store());
EXPECT_TRUE(prefs()->GetBoolean(prefs::kWasObsoleteHttpDataCleaned));
}
}
}
TEST_F(HTTPDataCleanerTest, TestAutofillableDeletion) {
for (bool is_hsts : {false, true}) {
for (bool same_host : {false, true}) {
for (bool same_user : {false, true}) {
for (bool same_pass : {false, true}) {
SCOPED_TRACE(Message()
<< std::boolalpha
<< "(is_hsts, same_host, same_user, same_pass): ("
<< is_hsts << ", " << same_host << ", " << same_user
<< ", " << same_pass);
prefs()->SetBoolean(prefs::kWasObsoleteHttpDataCleaned, false);
const bool should_be_deleted =
is_hsts && same_host && same_user && same_pass;
PasswordForm http_form = CreateTestHTTPForm();
PasswordForm https_form = CreateTestHTTPSForm();
if (!same_host) {
GURL::Replacements rep;
rep.SetHostStr("a-totally-different-host");
http_form.origin = http_form.origin.ReplaceComponents(rep);
}
if (!same_user)
http_form.username_value = base::ASCIIToUTF16("different-user");
if (!same_pass)
http_form.password_value = base::ASCIIToUTF16("different-pass");
HSTSStateManager manager(request_context()
->GetURLRequestContext()
->transport_security_state(),
is_hsts, https_form.origin.host());
EXPECT_CALL(*store(), FillAutofillableLogins(_))
.WillOnce(Invoke(
[&http_form, &https_form](
std::vector<std::unique_ptr<autofill::PasswordForm>>*
forms) {
*forms = WrapForms({http_form, https_form});
return true;
}));
EXPECT_CALL(*store(), RemoveLogin(http_form))
.Times(should_be_deleted);
// Initiate clean up and make sure all aync tasks are run until
// completion.
CleanObsoleteHttpDataForPasswordStoreAndPrefsForTesting(
store(), prefs(), request_context());
base::RunLoop().RunUntilIdle();
// Verify and clear all expectations as well as the preference.
Mock::VerifyAndClearExpectations(store());
EXPECT_TRUE(prefs()->GetBoolean(prefs::kWasObsoleteHttpDataCleaned));
}
}
}
}
}
TEST_F(HTTPDataCleanerTest, TestSiteStatsDeletion) {
for (bool is_http : {false, true}) {
for (bool is_hsts : {false, true}) {
SCOPED_TRACE(Message() << std::boolalpha << "(is_http, is_hsts): ("
<< is_http << ", " << is_hsts);
prefs()->SetBoolean(prefs::kWasObsoleteHttpDataCleaned, false);
const bool should_be_deleted = is_http && is_hsts;
InteractionsStats stats =
is_http ? CreateTestHTTPStats() : CreateTestHTTPSStats();
HSTSStateManager manager(
request_context()->GetURLRequestContext()->transport_security_state(),
is_hsts, stats.origin_domain.host());
EXPECT_CALL(*store(), GetAllSiteStatsImpl()).WillOnce(Invoke([&stats]() {
return std::vector<InteractionsStats>({stats});
}));
EXPECT_CALL(*store(), RemoveSiteStatsImpl(stats.origin_domain))
.Times(should_be_deleted);
// Initiate clean up and make sure all async tasks are run until
// completion.
CleanObsoleteHttpDataForPasswordStoreAndPrefsForTesting(
store(), prefs(), request_context());
base::RunLoop().RunUntilIdle();
// Verify and clear all expectations as well as the preference.
Mock::VerifyAndClearExpectations(store());
EXPECT_TRUE(prefs()->GetBoolean(prefs::kWasObsoleteHttpDataCleaned));
}
}
}
} // namespace password_manager
|
