1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
|
// Copyright 2021 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/history_clusters/core/noisy_cluster_finalizer.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "components/history_clusters/core/clustering_test_utils.h"
#include "components/history_clusters/core/on_device_clustering_features.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace history_clusters {
namespace {
using ::testing::ElementsAre;
class NoisyClusterFinalizerTest : public ::testing::Test {
public:
void SetUp() override {
cluster_finalizer_ = std::make_unique<NoisyClusterFinalizer>();
scoped_feature_list_.InitAndEnableFeatureWithParameters(
features::kOnDeviceClustering,
{{"num_interesting_visits_filter_threshold", "2"}});
}
void TearDown() override { cluster_finalizer_.reset(); }
void FinalizeCluster(history::Cluster& cluster) {
cluster_finalizer_->FinalizeCluster(cluster);
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
std::unique_ptr<NoisyClusterFinalizer> cluster_finalizer_;
base::test::TaskEnvironment task_environment_;
};
TEST_F(NoisyClusterFinalizerTest, FilterHighEngagementClusters) {
history::ClusterVisit visit = testing::CreateClusterVisit(
testing::CreateDefaultAnnotatedVisit(1, GURL("https://bar.com/")));
visit.engagement_score = 25.0;
history::ClusterVisit visit2 = testing::CreateClusterVisit(
testing::CreateDefaultAnnotatedVisit(2, GURL("https://bar.com/")));
visit2.duplicate_visits.push_back(visit);
visit2.engagement_score = 25.0;
history::Cluster cluster;
cluster.visits = {visit2};
FinalizeCluster(cluster);
EXPECT_FALSE(cluster.should_show_on_prominent_ui_surfaces);
}
TEST_F(NoisyClusterFinalizerTest, HideClusterWithOnlyOneInterestingVisit) {
base::HistogramTester histogram_tester;
history::ClusterVisit visit = testing::CreateClusterVisit(
testing::CreateDefaultAnnotatedVisit(1, GURL("https://bar.com/")));
visit.engagement_score = 5.0;
history::ClusterVisit visit2 = testing::CreateClusterVisit(
testing::CreateDefaultAnnotatedVisit(2, GURL("https://bar.com/")));
visit2.duplicate_visits.push_back(visit);
visit2.engagement_score = 25.0;
history::Cluster cluster;
cluster.visits = {visit2};
FinalizeCluster(cluster);
EXPECT_FALSE(cluster.should_show_on_prominent_ui_surfaces);
histogram_tester.ExpectUniqueSample(
"History.Clusters.Backend.WasClusterFiltered.NoisyCluster", true, 1);
}
TEST_F(NoisyClusterFinalizerTest, KeepClusterWithAtLeastTwoInterestingVisits) {
base::HistogramTester histogram_tester;
history::ClusterVisit visit = testing::CreateClusterVisit(
testing::CreateDefaultAnnotatedVisit(1, GURL("https://bar.com/")));
visit.engagement_score = 5.0;
history::ClusterVisit visit2 = testing::CreateClusterVisit(
testing::CreateDefaultAnnotatedVisit(2, GURL("https://bar.com/")));
visit2.engagement_score = 25.0;
history::ClusterVisit visit3 = testing::CreateClusterVisit(
testing::CreateDefaultAnnotatedVisit(3, GURL("https://foo.com/")));
visit3.duplicate_visits.push_back(visit);
visit3.engagement_score = 5.0;
history::Cluster cluster;
cluster.visits = {visit2, visit3};
FinalizeCluster(cluster);
EXPECT_TRUE(cluster.should_show_on_prominent_ui_surfaces);
histogram_tester.ExpectUniqueSample(
"History.Clusters.Backend.WasClusterFiltered.NoisyCluster", false, 1);
}
} // namespace
} // namespace history_clusters
|
