summaryrefslogtreecommitdiff
path: root/chromium/build/android/lint/suppressions.xml
blob: 49d8aa0892fc48fc69aa11214985b8bd99128ea4 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
<?xml version="1.0" encoding="utf-8"?>
<lint>
  <!--
STOP! It looks like you want to suppress some lint errors:
- Have you tried identifing the offending patch?
  Ask the author for a fix and/or revert the patch.
- It is preferred to add suppressions in the code instead of
  sweeping it under the rug here. See:

    http://developer.android.com/tools/debugging/improving-w-lint.html

Still reading?
- You can edit this file manually to suppress an issue
  globally if it is not applicable to the project.
- You can also automatically add issues found so for in the
  build process by running:

    build/android/lint/suppress.py

  which will generate this file (Comments are not preserved).
  Note: PRODUCT_DIR will be substituted at run-time with actual
  directory path (e.g. out/Debug)
-->
  <!-- AllowBackup defaults to true, and causes a lint warning if not explicitly set. -->
  <issue id="AllowBackup">
    <ignore path="AndroidManifest.xml"/>
  </issue>
  <!-- TODO(crbug.com/799070): File bugs to fix this -->
  <issue id="AppCompatResource" severity="ignore"/>
  <!-- We use asserts in Chromium. See https://chromium.googlesource.com/chromium/src/+/master/styleguide/java/java.md#Asserts -->
  <issue id="Assert" severity="ignore"/>
  <issue id="AuthLeak" severity="Error">
    <ignore regexp="chrome/android/javatests"/>
  </issue>
  <issue id="BadHostnameVerifier" severity="Error">
    <!-- Safe, used in test only. -->
    <ignore regexp="net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java"/>
  </issue>
  <issue id="ButtonOrder" severity="Error">
    <ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/>
  </issue>
  <issue id="ButtonStyle" severity="Error">
    <ignore regexp="remoting/android/host/res/layout/main.xml"/>
  </issue>
  <!-- Found in generated android_chrome_strings.xml. -->
  <issue id="ByteOrderMark" severity="Error">
    <ignore regexp="values-pt-rBR/android_chrome_strings.xml"/>
  </issue>
  <issue id="ClickableViewAccessibility" severity="ignore"/>
  <issue id="CommitPrefEdits">
    <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/ticl/android2/channel/AndroidChannelPreferences.java"/>
  </issue>
  <issue id="ContentDescription" severity="Error">
    <ignore regexp="chromecast/internal"/>
  </issue>
  <issue id="DefaultLocale">
    <ignore regexp="clank"/>
    <ignore regexp="com/android/tv"/>
    <ignore regexp="org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.class"/>
    <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbChooserPreferences"/>
    <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbDevicePreferences"/>
    <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/external/client/contrib/AndroidListenerState.java"/>
  </issue>
  <!-- TODO(crbug.com/635567): Fix this properly. -->
  <issue id="Deprecated" severity="Error">
    <ignore regexp="android:singleLine"/>
    <ignore regexp="AndroidManifest.xml"/>
    <ignore regexp="/test/"/>
  </issue>
  <issue id="DrawAllocation">
    <ignore regexp="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java"/>
    <ignore regexp="content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java"/>
  </issue>
  <!-- TODO(crbug.com/799070): File bugs to fix this -->
  <issue id="EllipsizeMaxLines" severity="ignore"/>
  <issue id="ExifInterface">
    <!-- TODO(crbug.com/799070): Update android.support.media.ExifInterface and use it instead -->
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/photo_picker/BitmapUtils.java"/>
  </issue>
  <issue id="ExportedContentProvider">
    <ignore path="AndroidManifest.xml"/>
  </issue>
  <issue id="ExportedService" severity="Error">
    <ignore regexp="AndroidManifest.xml"/>
  </issue>
  <!-- TODO(crbug.com/635567): Fix this properly. -->
  <issue id="GoogleAppIndexingUrlError" severity="Error">
    <ignore regexp="AndroidManifest.xml"/>
  </issue>
  <!-- TODO(crbug.com/635567): Fix this properly. -->
  <issue id="GoogleAppIndexingWarning" severity="Error">
    <ignore regexp="AndroidManifest.xml"/>
  </issue>
  <!-- TODO(crbug.com/799070): Fix for remoting -->
  <issue id="AppLinkUrlError">
    <ignore regexp="AndroidManifest.xml"/>
  </issue>
  <issue id="HandlerLeak">
    <ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java" />
    <ignore regexp="chromecast/internal" />
    <ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java" />
  </issue>
  <issue id="HardcodedDebugMode" severity="Fatal">
    <ignore path="AndroidManifest.xml"/>
  </issue>
  <issue id="HardcodedText" severity="Error">
    <ignore regexp="chromecast/internal"/>
    <ignore regexp="remoting/android/host/res/layout/main.xml"/>
  </issue>
  <issue id="IconColors" severity="Error">
    <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/notification_icon.png"/>
    <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/notification_icon.png"/>
    <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/notification_icon.png"/>
    <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/notification_icon.png"/>
    <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/notification_icon.png"/>
  </issue>
  <issue id="IconDensities">
    <!-- The large assets below only include a few densities to reduce APK size. -->
    <ignore regexp="data_reduction_illustration.png"/>
    <!-- This is intentional to save on WebAPKs' size. -->
    <ignore regexp="chrome/android/webapk/shell_apk/res/drawable-*"/>
    <!-- crbug.com/457918 is tracking missing assets -->
    <ignore regexp="chrome/android/java/res/drawable-xxhdpi"/>
    <ignore regexp="chrome/android/java/res/drawable-xxxhdpi"/>
    <ignore regexp="chromecast/internal"/>
    <ignore regexp="content/public/android/java/res/drawable-xxhdpi"/>
    <ignore regexp="content/public/android/java/res/drawable-xxxhdpi"/>
    <ignore regexp="ui/android/java/res/drawable-xxhdpi"/>
    <ignore regexp="ui/android/java/res/drawable-xxxhdpi"/>
  </issue>
  <issue id="IconDipSize">
    <ignore regexp="chromecast/internal"/>
    <!-- TODO(crbug.com/799070): File bugs to fix these icons -->
    <ignore regexp="chrome/android/java/res/.*tab_strip_fade"/>
  </issue>
  <issue id="IconDuplicates" severity="Error">
    <ignore regexp="chromecast/internal"/>
  </issue>
  <issue id="IconDuplicatesConfig" severity="Error">
    <ignore regexp="chromecast/internal"/>
  </issue>
  <issue id="IconLauncherFormat" severity="ignore">
    <!-- TODO(crbug.com/739746): Remove after lint version has been updated. -->
    <ignore regexp="remoting/android/java/res/mipmap-anydpi-v26/ic_launcher.xml"/>
  </issue>
  <issue id="IconLauncherShape" severity="Error">
    <ignore regexp="chromecast/internal"/>
    <ignore regexp="chrome/android/webapk/shell_apk/res/mipmap-mdpi/ic_launcher_background.png"/>
  </issue>
  <issue id="IconLocation">
    <ignore regexp="chromecast/internal"/>
    <!-- It is OK for content_shell_apk to have missing assets. -->
    <ignore regexp="content/shell/android/java/res/"/>
    <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/drawable/icon.png -->
    <ignore regexp="res/drawable/icon.png"/>
  </issue>
  <issue id="IconMissingDensityFolder">
    <!-- see crbug.com/542435 -->
    <ignore regexp="android_webview/apk/java/res"/>
    <ignore regexp="android_webview/tools/system_webview_shell/apk/res"/>
    <ignore regexp="chrome/android/webapk/shell_apk/res"/>
    <ignore regexp="chromecast/internal"/>
    <ignore regexp="tools/android/push_apps_to_background/res"/>
    <ignore regexp="ui/android/java/res"/>
    <!-- crbug.com/457918 is tracking missing assets -->
    <ignore regexp="components/web_contents_delegate_android/java/res"/>
  </issue>
  <issue id="ImpliedQuantity" severity="Error">
    <ignore regexp="chrome/android/chrome_strings_grd"/>
  </issue>
  <issue id="InconsistentArrays" severity="Error">
    <ignore regexp="android_webview/locale_paks.resources.zip/values/locale-paks.xml"/>
    <ignore regexp="chrome/android/chrome_locale_paks.resources.zip/values/locale-paks.xml"/>
  </issue>
  <issue id="InconsistentLayout" severity="ignore"/>
  <issue id="InefficientWeight" severity="Error">
    <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml"/>
  </issue>
  <issue id="InflateParams" severity="ignore"/>
  <issue id="InlinedApi" severity="ignore"/>
  <issue id="InvalidPackage" severity="Error">
    <ignore regexp="espresso/espresso_core_java.interface.jar"/>
  </issue>
  <issue id="InvalidVectorPath" severity="ignore"/>
  <issue id="LabelFor" severity="Error">
    <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml"/>
  </issue>
  <!-- TODO(crbug.com/799070): File bugs to fix this. -->
  <issue id="KeyboardInaccessibleWidget" severity="ignore"/>
  <issue id="LintError" severity="Error"/>
  <issue id="LogConditional" severity="ignore"/>
  <issue id="LongLogTag" severity="ignore"/>
  <issue id="MissingApplicationIcon" severity="ignore"/>
  <issue id="MissingPermission" severity="ignore"/>
  <!-- TODO(yolandyan) remove this once all tests are converted to junit4 -->
  <issue id="MissingPrefix" severity="ignore"/>
  <!--
    TODO(estevenson) remove this once translations are added for
    IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE (http://crbug.com/635677)
  -->
  <issue id="MissingQuantity">
    <ignore regexp="android_chrome_strings.xml"/>
  </issue>
  <issue id="MissingRegistered" severity="ignore"/>
  <issue id="MissingSuperCall" severity="Error">
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectionToolbar.java"/>
  </issue>
  <issue id="MissingTranslation">
    <!-- http://crbug.com/450548 -->
    <ignore regexp="chromecast/internal"/>
    <ignore regexp="restriction_values.xml.*"/>
  </issue>
  <issue id="MissingVersion">
    <ignore path="AndroidManifest.xml"/>
  </issue>
  <issue id="NewApi">
    <!-- This is rewritten by desugar after lint runs. -->
    <ignore regexp="Call requires API level 19.*`java.util.Objects#requireNonNull`"/>
    <!-- AutoCloseable has been available since API 15, just hidden. -->
    <ignore regexp="Class requires API level 19.*java.lang.AutoCloseable"/>
    <ignore regexp="Call requires API level 19.*java.lang.AutoCloseable#close"/>
    <!-- We support try-with-resources via desugar. -->
    <ignore regexp="Try-with-resources requires API level 19"/>
    <ignore regexp="Call requires API level 19.*`java.lang.Throwable#addSuppressed`"/>
    <!-- We support default methods via desugar. -->
    <ignore regexp="Default method requires API level 24"/>
    <!-- TODO(crbug.com/799070): Fix these after lint upgrade. -->
    <ignore regexp="Static interface  method requires API level 24"/>
    <ignore regexp="(current min is 1)"/>
    <!-- Suppressions below this line need rationale :( -->
    <ignore regexp="Attribute `paddingStart` referenced here can result in a crash on some specific devices older than API 17"/>
    <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/>
    <ignore regexp="chromecast/internal"/>
    <ignore regexp="com/android/tv"/>
    <ignore regexp="com/android/webview/chromium/ServiceWorkerControllerAdapter.class"/>
    <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.class"/>
    <ignore regexp="com/android/webview/chromium/WebViewChromium.class"/>
    <ignore regexp="com/android/webview/chromium/WebViewChromiumFactoryProvider.class"/>
    <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class"/>
    <ignore regexp="com/google/android/apps/cast"/>
    <ignore regexp="com/google/android/apps/mediashell"/>
    <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.class"/>
    <ignore regexp="org/chromium/base/JavaHandlerThread.class"/>
    <ignore regexp="org/chromium/base/SysUtils.class"/>
    <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class"/>
    <ignore regexp="org/chromium/chrome/browser/ntp/IncognitoNewTabPage.class"/>
    <ignore regexp="org/chromium/chrome/browser/ntp/NewTabPage.class"/>
    <ignore regexp="org/chromium/chromecast/base/CastSettingsManager.class"/>
    <ignore regexp="org/chromium/memconsumer/MemConsumer.*.class"/>
    <ignore regexp="org/chromium/memconsumer/ResidentService.class"/>
    <ignore regexp="org/chromium/mojo/bindings/ValidationTest.class"/>
    <!-- TODO(crbug.com/635567): Fix this properly. -->
    <ignore regexp="sdk/extras/chromium/support/src/org/chromium/android/support/PackageManagerWrapper.java"/>
  </issue>
  <!-- TODO(crbug.com/799070): Re-enable this -->
  <issue id="ObsoleteSdkInt" severity="ignore"/>
  <issue id="OldTargetApi">
    <ignore path="AndroidManifest.xml"/>
  </issue>
  <issue id="Overdraw" severity="ignore"/>
  <issue id="Override">
    <!-- TODO(crbug.com/635567): Fix this properly. -->
    <ignore regexp="org/chromium/content/browser/input/ThreadedInputConnection.class"/>
    <!-- TODO(crbug.com/635567): Fix this properly. -->
    <ignore regexp="com/android/webview/chromium/ContentSettingsAdapter.class"/>
    <!-- TODO(crbug.com/635567): Fix this properly. -->
    <ignore regexp="com/android/webview/chromium/ServiceWorkerControllerAdapter.class"/>
    <!-- TODO(crbug.com/635567): Fix this properly. -->
    <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.class"/>
    <!-- TODO(crbug.com/635567): Fix this properly. -->
    <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/>
    <!-- TODO(crbug.com/635567): Fix this properly. -->
    <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/>
  </issue>
  <issue id="PackageManagerGetSignatures">
    <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java"/>
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java"/>
  </issue>
  <issue id="PluralsCandidate" severity="Error">
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
  </issue>
  <issue id="PrivateApi" severity="ignore"/>
  <issue id="Recycle" severity="ignore"/>
  <issue id="Registered" severity="ignore"/>
  <issue id="ResourceAsColor" severity="ignore"/>
  <issue id="ResourceType" severity="Error">
    <ignore regexp="/javatests/"/>
  </issue>
  <issue id="RtlCompat" severity="ignore"/>
  <issue id="RtlEnabled" severity="ignore"/>
  <issue id="RtlSymmetry" severity="ignore"/>
  <issue id="SdCardPath">
    <ignore regexp="content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java"/>
  </issue>
  <issue id="SetJavaScriptEnabled" severity="ignore"/>
  <issue id="SignatureOrSystemPermissions" severity="ignore"/>
  <issue id="SpUsage" severity="Error">
    <ignore regexp="chromecast/internal"/>
  </issue>
  <issue id="StaticFieldLeak">
    <!-- TODO(crbug.com/799070): Fix after upgrading lint. -->
    <ignore regexp="This AsyncTask class should be static or leaks might occur"/>
  </issue>
  <issue id="StringFormatCount" severity="Error">
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
  </issue>
  <issue id="StringFormatInvalid" severity="Error">
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-da/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-pt-rBR/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sv/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-tl/android_chrome_strings.xml"/>
  </issue>
  <!-- We have many C++ enums that we don't care about in java -->
  <issue id="SwitchIntDef" severity="ignore"/>
  <issue id="TextFields" severity="Error">
    <ignore regexp="chromecast/internal"/>
  </issue>
  <issue id="TypographyDashes" severity="Error">
    <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml"/>
  </issue>
  <!-- Typos check disabled due to lint bug: http://crbug.com/671170 -->
  <issue id="Typos" severity="ignore" />
  <issue id="UnusedAttribute" severity="ignore"/>
  <issue id="UnusedIds" severity="ignore"/>
  <issue id="UnusedQuantity" severity="Error">
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-in/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ja/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-ko/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-lt/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-sk/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-th/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-vi/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-zh-rTW/android_chrome_strings.xml"/>
  </issue>
  <!-- Our generated enums are allowed to have the same values. -->
  <issue id="UniqueConstants" severity="ignore"/>
  <!-- Do not add new suppressions without very good rationale. -->
  <issue id="UnusedResources">
    <!-- 3 raw resources are accessed by URL in various places -->
    <ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits.html"/>
    <ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits_css.css"/>
    <ignore regexp="PRODUCT_DIR/gen/remoting/android/.*/res/raw/credits_js.js"/>
    <!-- 2 dimens override support library's res, will be changing soon -->
    <ignore regexp="R.dimen.design_bottom_navigation_text_size"/>
    <ignore regexp="R.dimen.design_bottom_navigation_active_text_size"/>
    <!-- 1 string test only, used in CronetSmokeTestCase dynamically -->
    <ignore regexp="R.string.TestSupportImplClass"/>
    <!-- 1 string used by Android's policies system, pulled from app directly -->
    <ignore regexp="restriction_values.xml"/>
    <!-- 3 resources test only, used in webview tests dynamically -->
    <ignore regexp="android_webview/tools/automated_ui_tests/java/res/layout/"/>
    <ignore regexp="android_webview/test/shell/res/raw/resource_file.html"/>
    <ignore regexp="android_webview/test/shell/res/raw/resource_icon.png"/>
    <!-- 2 resources used by android webview glue layer, could be refactored -->
    <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outline_black_48dp.png"/>
    <ignore regexp="R.string.private_browsing_warning"/>
    <!-- 9 OMR1 SDK roll mystery. TODO(jbudorick): Remove this after rolling lint. -->
    <ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml"/>
    <ignore regexp="chrome/android/java/res/layout/location_bar.xml"/>
    <ignore regexp="chrome/android/java/res/values/colors.xml"/>
    <ignore regexp="chrome/android/java/res/values/dimens.xml"/>
    <ignore regexp="chrome/android/java/res/drawable-hdpi/ic_omnibox_magnifier.png"/>
    <ignore regexp="chrome/android/java/res/drawable-hdpi/omnibox_https_invalid.png"/>
    <ignore regexp="chrome/android/java/res/drawable-hdpi/omnibox_info.png"/>
    <ignore regexp="clank/java/clank_strings_grd.resources.zip/values/android_internal_strings.xml"/>
    <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/notification_icon.png"/>
    <!-- # TODO(crbug.com/799070): Fix these. -->
    <ignore regexp="ui/android/java/res/values/colors.xml"/>
    <ignore regexp="ui/android/java/res/values/dimens.xml"/>
    <ignore regexp="ui/android/java/res/values-v17/styles.xml"/>
    <ignore regexp="chrome/android/java/res/anim/fullscreen_notification_in.xml"/>
    <ignore regexp="chrome/android/java/res/values-v17/styles.xml"/>
    <ignore regexp="chrome/android/java/res/values-v21/styles.xml"/>
    <!-- Endnote: Please specify number of resources when adding more suppressions -->
  </issue>
  <issue id="UseCompoundDrawables">
    <!-- Upscaling 24dp to 48dp doesn't work as expected with a TextView compound drawable. -->
    <ignore regexp="chrome/android/java/res/layout/photo_picker_bitmap_view.xml"/>
  </issue>
  <issue id="UselessParent">
    <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml"/>
    <ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/>
    <ignore regexp="chromecast/internal"/>
    <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activity_account_authenticator.xml"/>
  </issue>
  <issue id="UsesMinSdkAttributes" severity="Error">
    <ignore regexp="AndroidManifest.xml"/>
  </issue>
  <issue id="UseSparseArrays" severity="ignore"/>
  <issue id="ValidFragment" severity="Error">
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/BaseMediaRouteDialogManager.java"/>
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java"/>
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteControllerDialogManager.java"/>
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java"/>
    <ignore regexp="media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java"/>
  </issue>
  <issue id="VectorPath" severity="ignore"/>
  <issue id="ViewConstructor" severity="ignore"/>
  <issue id="VisibleForTests" severity="Error">
    <ignore regexp="/javatests/"/>
    <ignore regexp="/test/"/>
    <!-- TODO(crbug.com/757124): Remove all these specific Feedback files after underlying issue is resolved -->
    <!-- Underlying issue is that Android FeedbackOptions.Builder using @VisibleForTesting without 'otherwise='. -->
    <ignore regexp="clank/java/src/com/google/android/apps/chrome/feedback/FeedbackUtil.java"/>
    <ignore regexp="clank/java/src/com/google/android/apps/chrome/feedback/PlayServicesFeedbackReporter.java"/>
    <ignore regexp="clank/java/src/com/google/android/apps/chrome/help/FeedbackCategoryChooserActivity.java"/>
    <ignore regexp="clank/java/src/com/google/android/apps/chrome/help/HelpAndFeedbackInternal.java"/>
  </issue>
  <issue id="WrongCall" severity="ignore"/>
  <issue id="WrongConstant">
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java"/>
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java"/>
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java"/>
    <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDialog.java"/>
    <ignore regexp="third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java"/>
  </issue>
</lint>