summaryrefslogtreecommitdiff
path: root/chromium/content/common
Commit message (Collapse)AuthorAgeFilesLines
* [Backport] CVE-2022-1497: Inappropriate implementation in InputGarrett Tanzer2022-05-201-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Manual cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/3481666: Reland "Fix noopener case for user activation consumption" This is a reland of e9828a82b5c182dc9a7fb0ae7226c35ba1726e7d The MSAN error is from checking status before err in content/renderer/render_view_impl.cc . https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/b8821495655905086193/overview The fix is to split the check for err and kIgnore into two checks, and put the err check before kBlocked. It is probably possible for the browser to consume user activation but then eventually mojo returns an error and the renderer doesn't consume activation, but that seems pretty marginal. Original change's description: > Fix noopener case for user activation consumption > > > The flow for user activation consumption in window.open was as follows: > > Renderer: ask the browser to create a new window > Browser: consume transient user activation (in the browser, and via RPC > to remote frames only) > Browser: return success for opener, return ignore for noopener > Renderer: consume transient user activation upon success > > So in the noopener case, the renderer with the local frame where the > window.open originated didn't have its transient user activation > consumed. > > > The new behavior is to consume user activation in the calling renderer > whenever it is consumed in the browser. We accomplish this by returning > a distinct value kBlocked to represent failure before the browser > consumes user activation. > > Bug: 1264543, 1291210 > Change-Id: Iffb6e3fd772bef625d3d28e600e6fb73d70ab29f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3468171 > Reviewed-by: Dominic Farolino <dom@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Charles Reis <creis@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Garrett Tanzer <gtanzer@chromium.org> > Cr-Commit-Position: refs/heads/main@{#973876} Bug: 1264543, 1291210 Change-Id: Ie27c4d68db34dfd98adee7cc5c743953dad59834 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Garrett Tanzer <gtanzer@chromium.org> Cr-Commit-Position: refs/heads/main@{#976745} Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* [Backport] CVE-2022-1138: Inappropriate implementation in Web Cursor.Mike Wasserman2022-05-032-5/+7
| | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/3413912: Make web cursor size limits match on browser and renderer Use NSCursor arrowCursor on Mac for ui::mojom::CursorType::kNull. (i.e. when WebCursor is constructed with an overly large custom cursor) Bug: 1246188 Test: Automated unit tests and WPTs Change-Id: I89627fa13cba96b755b8f80adbc91cfc865b6b1b Reviewed-by: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Mike Wasserman <msw@chromium.org> Auto-Submit: Mike Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/main@{#964378} Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* [Backport] CVE-2022-0111 and CVE-2022-0117 (2/2)Ben Kelly2022-01-132-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Manual backport of patch for "CVE-2022-0111: Inappropriate implementation in Navigation." and "CVE-2022-0117: Policy bypass in Service Workers", originally reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/3213310 Fetch: Plumb navigation redirect chain through service workers Navigation redirection works differently than normal redirection. Navigation requests are made using "manual" redirect mode which means the redirect is not immediately followed. Instead the redirect location is handed back up to the NavigationURLLoaderImpl which then manually follows the redirect. This results in a new request being sent for each step in the redirect chain. This CL plumbs the redirect chain information from NavigationURLLoaderImpl down through each request so it can be included with requests proxied by a passthrough service worker. For more detailed information about these changes please see the internal design doc at: https://docs.google.com/document/d/1KZscujuV7bCFEnzJW-0DaCPU-I40RJimQKoCcI0umTQ/edit?usp=sharing We have rough consensus to make this change in this spec issue: https://github.com/whatwg/fetch/issues/1335 Note, this CL includes some expected test failures. These are due to the "lax-allowing-unsafe" intervention that is currently enabled. See: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations;l=4635;drc=e8133cbf2469adb99c6610483ab78bcfb8cc4c76 Bug: 1115847,1241188 Change-Id: I2a2a17639e0bec3222684e0d444d6d98a21402ed Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/main@{#939851} Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* [Backport] CVE-2022-0111 and CVE-2022-0117 (1/2)Ben Kelly2022-01-132-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Manual backprort of patch for "CVE-2022-0111: Inappropriate implementation in Navigation." and "CVE-2022-0117: Policy bypass in Service Workers", originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/3251368: Reland "Fetch: Plumb request initiator through passthrough service workers." This is a reland of da0a6501cf321579bd46a27ff9fba1bb8ea910bb This CL also includes a change to mark the two WPT tests as requiring long timeout durations. On my fast build machine with an opt build they take ~5 seconds each to complete and the default timeout is 10 seconds. On slower bots with debug builds its highly likely that these tests would be marked as timing out. This change gives them a 60 second timeout instead. Original change's description: > Fetch: Plumb request initiator through passthrough service workers. > > This CL contains essentially two changes: > > 1. The request initiator origin is plumbed through service workers > that do `fetch(evt.request)`. In addition to plumbing, this > requires changes to how we validate navigation requests in the > CorsURLLoaderFactory. > 2. Tracks the original destination of a request passed through a > service worker. This is then used in the network service to force > SameSite=Lax cookies to treat the request as a main frame navigation > where appropriate. > > For more detailed information about these changes please see the > internal design doc at: > > https://docs.google.com/document/d/1KZscujuV7bCFEnzJW-0DaCPU-I40RJimQKoCcI0umTQ/edit?usp=sharing > > In addition, there is some discussion of these features in the following > spec issues: > > https://github.com/whatwg/fetch/issues/1321 > https://github.com/whatwg/fetch/issues/1327 > > The test includes WPT tests that verify navigation headers and SameSite > cookies. Note, chrome has a couple expected failures in the SameSite > cookie tests because of the "lax-allowing-unsafe" intervention that is > currently enabled. See: > > https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/TestExpectations;l=4635;drc=e8133cbf2469adb99c6610483ab78bcfb8cc4c76 > > Bug: 1115847,1241188 > Change-Id: I7e236fa20aeabb705aef40fcf8d5c36da6d2798c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3115917 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/main@{#936029} Bug: 1115847,1241188 Change-Id: Ia26acbdd0d7ce6583d9a44f83ed086708657b8bd Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Ben Kelly <wanderview@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/main@{#936560} Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fixes for jumbo buildAllan Sandfeld Jensen2021-07-051-1/+7
| | | | | | | | Fixes necessary to make jumbo build work Change-Id: I1551ddeaa15fdc4e9db72e86ea49191193cb4964 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix 32bit sandboxing on WindowsAllan Sandfeld Jensen2021-06-251-1/+1
| | | | | | | | Static linking would lose essential symbols, we need it to be a source_set, but can make the places that uses it static_libraries instead. Change-Id: I77454a217c937117d497330b023da6fa45c95d0f Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Pass virtual url of data url request back to the UIAllan Sandfeld Jensen2021-06-211-0/+2
| | | | | | | | | | | Otherwise we lose information about interpage navigation. This fixes a regression after Chromium switched to browser-side navigation Task-number: QTBUG-67701 Change-Id: I10659699f1acc033948e297e3f7319ee44d6423f Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix initialize of cdm for sandbox from widevine-pathMichal Klocek2021-06-211-0/+1
| | | | | | | | | Pass widevine-path when doing zygote on Linux, so cdm library can be preloaded before entering sandbox. Fixes: QTBUG-78709 Change-Id: I8bbdba1a94e843a96bfea85db5699289c226c08c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Pass through a new application name argument to utility processesAllan Sandfeld Jensen2021-06-211-0/+3
| | | | | | | | | Audio is now played by a utility process, but we need to tell PulseAudio which application is playing back. Task-number: QTBUG-85363 Change-Id: I3c9b364527b669d8cd2f2421034bc6b2f7b2b28e Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Bring enable_webrtc backAllan Sandfeld Jensen2021-06-211-0/+10
| | | | | | | | | | | | Returns the GN args and BUILDFLAG to disable WebRTC code shrinking the Chromium binary by a 15%. Reverting https://chromium-review.googlesource.com/1044220, https://chromium-review.googlesource.com/1059408 and fixes later bitrot. Change-Id: Ic46c2832dbfacaeffa6a00a12a8a144cf0adf7f0 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix zygote path usedAllan Sandfeld Jensen2021-06-211-2/+3
| | | | | | | | It was using FILE_EXE which is the application executable not the subprocess one. Only worked because we returned the subprocess executable for FILE_EXE. Change-Id: I0a3c4c9c621ea23df086c13197ff76477097cfb7
* WIP: Extend url library for WebEngine custom schemesJüri Valdmann2021-06-211-1/+38
| | | | | | | | | | | | | Adds (another) parallel scheme registry in url/url_util_qt, which is then used in Chromium and Blink to specialize URL handling for WebEngine custom schemes. The registry is transmitted from the main process to subprocesses in a new command line flag (--webengine-schemes), since the scheme lists in url/url_util are locked before IPC is initialized. Task-number: QTBUG-62536 Change-Id: Id26811a18d4c740cc4d281d2da5720304a235a41 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Qt GN integrationMichal Klocek2021-06-212-2/+5
| | | | | | | | | | - Exclude source files we override in the qt webengine sources. - Add TOOLKIT_QT define for use_qt - Add is_shared GN argument Change-Id: I79925220265602bd0c39e5e03162cf1dca15befe Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 90.0.4430.221Allan Sandfeld Jensen2021-06-0780-3422/+2908
| | | | | Change-Id: Iff4d9d18d2fcf1a576f3b1f453010f744a232920 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 88.0.4324.208Allan Sandfeld Jensen2021-03-1657-3031/+323
| | | | | Change-Id: I3ae87d23e4eff4b4a469685658740a213600c667 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 87.0.4280.67Allan Sandfeld Jensen2020-11-1873-2941/+1287
| | | | | Change-Id: Ib157360be8c2ffb2c73125751a89f60e049c1d54 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 86.0.4240.124Allan Sandfeld Jensen2020-11-0285-1356/+690
| | | | | Change-Id: Ide0ff151e94cd665ae6521a446995d34a9d1d644 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 85.0.4183.14085-basedAllan Sandfeld Jensen2020-10-13108-3359/+2157
| | | | | Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 84.0.4147.141Allan Sandfeld Jensen2020-10-1385-1224/+848
| | | | | Change-Id: Ib85eb4cfa1cbe2b2b81e5022c8cad5c493969535 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 83.0.4103.122Allan Sandfeld Jensen2020-07-17153-5290/+2634
| | | | | Change-Id: Ie3a82f5bb0076eec2a7c6a6162326b4301ee291e Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 80.0.3987.136Allan Sandfeld Jensen2020-03-1873-5197/+479
| | | | | Change-Id: I98e1649aafae85ba3a83e67af00bb27ef301db7b Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* BASELINE: Update Chromium to 79.0.3945.139Allan Sandfeld Jensen2020-01-2361-1535/+529
| | | | | Change-Id: I336b7182fab9bca80b709682489c07db112eaca5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 78.0.3904.130Allan Sandfeld Jensen2020-01-22102-1980/+2068
| | | | | Change-Id: If185e0c0061b3437531c97c9c8c78f239352a68b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 77.0.3865.59Allan Sandfeld Jensen2019-08-3091-1546/+900
| | | | | Change-Id: I1e89a5f3b009a9519a6705102ad65c92fe736f21 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 76.0.3809.94Allan Sandfeld Jensen2019-08-3074-1078/+1443
| | | | | Change-Id: I321c3f5f929c105aec0f98c5091ef6108822e647 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 75.0.3770.116Allan Sandfeld Jensen2019-07-036-4/+57
| | | | | Change-Id: Ifcd5227841577e8ce81a1b7a54c56caba4d85e02 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* BASELINE: Update Chromium to 75.0.3770.56Allan Sandfeld Jensen2019-05-2478-1443/+1383
| | | | | Change-Id: I86d2007fd27a45d5797eee06f4c9369b8b50ac4f Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 74.0.3729.159Allan Sandfeld Jensen2019-05-2071-1540/+810
| | | | | Change-Id: I8d2497da544c275415aedd94dd25328d555de811 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 73.0.3683.83Allan Sandfeld Jensen2019-03-185-3/+30
| | | | | Change-Id: Ie2948cebb1e9204f293fdf63c36d6215a5f5b507 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 73.0.3683.64Allan Sandfeld Jensen2019-03-062-1/+38
| | | | | Change-Id: I76517dc277ba4e16bfd7e098fda3d079656b3b9f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 73.0.3683.37Allan Sandfeld Jensen2019-02-14119-3873/+571
| | | | | Change-Id: I08c9af2948b645f671e5d933aca1f7a90ea372f2 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 72.0.3626.110 and Ninja to 1.9.0Allan Sandfeld Jensen2019-02-14101-1895/+1942
| | | | | Change-Id: Ic57220b00ecc929a893c91f5cc552f5d3e99e922 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 71.0.3578.93Allan Sandfeld Jensen2018-12-10107-2000/+1932
| | | | | Change-Id: I6a32086c33670e1b033f8b10e6bf1fd4da1d105d Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 70.0.3538.78Allan Sandfeld Jensen2018-10-30134-3725/+2296
| | | | | Change-Id: Ie634710bf039e26c1957f4ae45e101bd4c434ae7 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 69.0.3497.70Allan Sandfeld Jensen2018-08-28110-1868/+1444
| | | | | Change-Id: I2b7b56e4e7a8b26656930def0d4575dc32b900a0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 68.0.3440.125Allan Sandfeld Jensen2018-08-28133-2772/+1886
| | | | | Change-Id: I23f19369e01f688e496f5bf179abb521ad73874f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 67.0.3396.76Allan Sandfeld Jensen2018-06-181-0/+2
| | | | | Change-Id: I9a14af4efb092ab203e9364f0779fca781909a38 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* BASELINE: Update Chromium to 67.0.3396.47Allan Sandfeld Jensen2018-05-15185-1779/+1645
| | | | | Change-Id: Idcb1341782e417561a2473eeecc82642dafda5b7 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* BASELINE: Update Chromium to 66.0.3359.156Allan Sandfeld Jensen2018-05-15170-2857/+2209
| | | | | Change-Id: I0c9831ad39911a086b6377b16f995ad75a51e441 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* BASELINE: Update Chromium to 65.0.3325.151Allan Sandfeld Jensen2018-03-085-70/+12
| | | | | Change-Id: I3c71dd500483eb29491ac3eee4123714dda52da9 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* BASELINE: Update Chromium to 65.0.3325.75Allan Sandfeld Jensen2018-02-153-5/+12
| | | | | Change-Id: I5485bc5c111539356276457516584fa5737f07d8 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* BASELINE: Update Chromium to 65.0.3525.40Allan Sandfeld Jensen2018-02-06145-3928/+2763
| | | | | | | Also imports missing submodules Change-Id: I36901b7c6a325cda3d2c10cedb2186c25af3b79b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 64.0.3282.139Allan Sandfeld Jensen2018-02-01232-9379/+3277
| | | | | Change-Id: I1cae68fe9c94ff7608b26b8382fc19862cdb293a Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 63.0.3239.117Allan Sandfeld Jensen2017-12-193-3/+58
| | | | | | | And add two chrome files we need. Change-Id: Ie4b6cefa8ea274623132c3ce59f951de8ea4ec6c Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 63.0.3239.87Allan Sandfeld Jensen2017-12-083-10/+105
| | | | | Change-Id: Iac27464730121b4fac76869d87d622504642e016 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* BASELINE: Update Chromium to 63.0.3239.58Allan Sandfeld Jensen2017-11-22204-4737/+4586
| | | | | Change-Id: Ia93b322a00ba4dd4004f3bcf1254063ba90e1605 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 62.0.3202.101Allan Sandfeld Jensen2017-11-22154-2108/+2663
| | | | | Change-Id: I2d5eca8117600df6d331f6166ab24d943d9814ac Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 61.0.3163.99Allan Sandfeld Jensen2017-10-04151-2687/+4446
| | | | | Change-Id: I8452f34574d88ca2b27af9bd56fc9ff3f16b1367 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* BASELINE: Update Chromium to 60.0.3112.78Alexandru Croitor2017-08-011-2/+0
| | | | | Change-Id: I58f9d14bddb9104a666b6ef869944111ee7eadb8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* BASELINE: Update Chromium to 60.0.3112.70Allan Sandfeld Jensen2017-07-1996-1423/+1654
| | | | | Change-Id: I9911c2280a014d4632f254857876a395d4baed2d Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
View Lorry Controller Status