| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Reverts four patches disabling and removing jumbo builds.
It makes too big of a difference for us to drop.
Change-Id: Ib7dd65996f9e985480f49fab2d1781a5d08bf6fd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: I62f1048995935995a4f9c84bf636624c6d5ec14c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://crrev.com/c/2801873.
Glibc has started rewriting fstat(fd, stat_buf) to
fstatat(fd, "", stat_buf, AT_EMPTY_PATH). This works because when
AT_EMPTY_PATH is specified, and the second argument is an empty string,
then fstatat just performs an fstat on fd like normal.
Unfortunately, fstatat() also allows stat-ing arbitrary pathnames like
with fstatat(AT_FDCWD, "/i/am/a/file", stat_buf, 0);
The baseline policy needs to prevent this usage of fstatat() since it
doesn't allow access to arbitrary pathnames.
Sadly, if the second argument is not an empty string, AT_EMPTY_PATH is
simply ignored by current kernels.
This means fstatat() is completely unsandboxable with seccomp, since
we *need* to verify that the second argument is the empty string, but
we can't dereference pointers in seccomp (due to limitations of BPF,
and the difficulty of addressing these limitations due to TOCTOU
issues).
So, this CL Traps (raises a SIGSYS via seccomp) on any fstatat syscall.
The signal handler, which runs in the sandboxed process, checks for
AT_EMPTY_PATH and the empty string, and then rewrites any applicable
fstatat() back into the old-style fstat().
Bug: 1164975
Change-Id: I3df6c04c0d781eb1f181d707ccaaead779337291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3042179
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#903873}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
kernel_stat""
This reverts commit ff277a52ece0b216617d770f201ed66955fe70b9.
Reason for revert: reland
The fix included in the reland is that fstatat64() needs to be
allowed in the broker process's seccomp policy.
This CL also includes some extra tests that the kernel_stat structures
match the layout the kernel expects.
Bug: 1164975, 1199431
Test: trogdor Chromebook successfully boots and allows login.
Original change's description:
> Revert "Reland "Linux sandbox syscall broker: use struct kernel_stat""
>
> This reverts commit cffbc4432af79f720ae3c75dff380b853701bd64.
>
> Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1199431
>
> Original change's description:
> > Reland "Linux sandbox syscall broker: use struct kernel_stat"
> >
> > This reverts commit 23030dc650cdfa22631f25bef937905f27f06a2c.
> >
> > Original change's description:
> > > Revert "Linux sandbox syscall broker: use struct kernel_stat"
> > >
> > > This reverts commit 784b0fcd8a3ca6bcd3acb9cfd624ec9cbbac2789.
> > >
> > > Reason for revert: Causing failure in
> > > Step "sandbox_linux_unittests" failing on builder "Linux ChromiumOS MSan Tests"
> > > See crbug.com/1198480
> > >
> > > Original change's description:
> > > > Linux sandbox syscall broker: use struct kernel_stat
> > > >
> > > > The struct stat used in libc is different (in size and field ordering)
> > > > from the structure assumed by the Linux kernel. So, when emulating
> > > > system calls, we need to use the struct definition the kernel expects.
> > > >
> > > > This CL adds linux_stat.h that includes definitions of the different
> > > > kernel structs.
> > > >
> > > > Change-Id: I53cad35c2251dff0f6b7ea77528cfa58ef3cab4a
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780876
> > > > Commit-Queue: Matthew Denton <mpdenton@chromium.org>
> > > > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#871767}
> > >
> > > Change-Id: Icbec38f2103c8424dec79ab1870b97c3e83f9361
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2821812
> > > Auto-Submit: Victor Vianna <victorvianna@google.com>
> > > Owners-Override: Victor Vianna <victorvianna@google.com>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Cr-Commit-Position: refs/heads/master@{#871882}
> >
> > Change-Id: I1f39bb5242961474def594ff7dbea52009f2cee4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824115
> > Auto-Submit: Matthew Denton <mpdenton@chromium.org>
> > Commit-Queue: Matthew Denton <mpdenton@chromium.org>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#872812}
>
> Fixed: 1199431
> Change-Id: Iebfc0c48201bf22ff9c54d8d5c8a43d26a880098
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830459
> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Owners-Override: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#873173}
Change-Id: Ibe6a485070f33489aaa157b51b908c2d23d174d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2848936
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#902981}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL cleans up some unused code in RenderFrameImpl, specifically the
traversal up to the nearest local root that is not used in
RenderFrameImpl::Initialize.
Bug: N/A
Change-Id: Idaeb92b3f34398e1d447ea0c2c188ce7c74d94c9
Review-Url: https://chromium-review.googlesource.com/c/chromium/src/+/2845830
Cr-Commit-Position: refs/heads/master@{#891517}
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Manual edit of an original change in order to allow build with latest
freetype release 2.11.0 without separate roll commit. Subsequent change
removes support to build with non-latest freetype completely, so save it
Bug: chromium:1223001
Change-Id: I969d86e5678961c3daad7995e1fe8dd9b976f077
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
| |
Bug: none
Change-Id: I3d68e5d8fe09ee19bf0b77c526f811d909e753ca
Review-Url: https://chromium-review.googlesource.com/c/chromium/src/+/3053701
Cr-Commit-Position: refs/heads/master@{#905871}
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Rsp writer is able to dump link data in form of
set of response files which have objects, archives,
defines, linker flags or libs.
Task-number: QTBUG-95590
Change-Id: Id153effb43fb7b70e38d9eca881e12018cbed729
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: If5ac705f3a4292da915d1f36526ef1fbed3868e6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
CMake uses a compiler for a linker step, which we also
pass as a linker to gn build, fix the build template to use
cl as a linker.
Task-number: QTBUG-91760
Change-Id: I9bc7472dfc709887f0a348ff6573b7580a6737bf
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This dumb code has already been defanged in Chromium as it broke their
own builds, but it is still causing trouble for us as it still
fundamentally wrong.
We can only reinstate if we stop tracking ico dependencies or fix rc.py
to work on anything other than Google's setup.
Change-Id: I089ed9997b6eafb1b927eb99854f0f38b87798c0
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update to Xcode 11.4 introduces new weak symbol
which breaks gn linking with:
Undefined symbols for architecture x86_64:
"___darwin_check_fd_set_overflow"
This symbol is declared by FD_SET macros referenced in exec_process.c
and mark for weak linking, resulting object file has undefined
weak symbol:
(undefined) weak external ___darwin_check_fd_set_overflow
Unfortunately during linking this is not handled properly without
'isysroot' parameter passed to linker. Fix it in gn build script.
Change-Id: Ibb4c38aad098da1e119253cd89eba0216a921164
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
(cherry picked from commit d5c4b6230b7f915f6e044e230c0c575249938400)
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses the isysroot passed in, which will be set to $$QMAKE_MAC_SDK_PATH
by the WebEngine build scripts.
Leaving this out when specifying a tool chain leads to problems on macOS
10.14 when the command line tools are also installed, as some symlinks
point to the wrong clang executable.
We also add the isysroot for the rest of Qt and Chromium detects it as
well, so this adds to consistency as well.
Cherry-pick from 71-based.
Change-Id: I267c0428f0a472a026451aefaf558e5d6c129303
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: I122070cdf1dc9a54f7dfdf39c86bd8aadbd8a14c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: Ibbd0d7a88ce84fe5eb8902d301f5fc1252fee432
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merge of patches:
Add x86 target support for gn
Fix creation of 'x86' toolchain in gn
Fix x86-32 builds with GCC 8
Fix building gn on arm
Task-number: QTBUG-70728
Fixes: QTBUG-72391
Fixes: QTBUG-72393
Change-Id: I7316edb5acb9832736eee368a02fbc39650d0136
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: I92658998836c1e2a1c877433d587d98ce5bb1c32
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-64759
Change-Id: Ifd366e496ce08365f63216943f93864fc285b8b0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Rhel machines on ci do not have it.
Change-Id: I4cbb6d9d0826a23f8065a9eebba7ba27856e44d4
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
In case of arm , mcpu can be specified instead
of 'march' and 'mtune'.
Change-Id: I8318f6dfaf02beb2dad40dec59fc73a263e7d04f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Implement a very limited version of chrome.tabs.update() JavaScript API
with only one functionality: navigating the current WebContents when an
URL update was requested.
Task-number: QTBUG-95282
Change-Id: I9628262ed73aefb2ef53934e724444dd3378a9ad
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Eliminates Visual C++ run-time library asserts with
MSVC debug build.
Change-Id: Ie9d84b9b4aa3c405b5eb21b212b21e01989e0ec8
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
|
|
|
|
|
|
|
|
|
| |
We now enable it by default,but allow users to disable it with
--disable-features=ChromeStaticPinning
Fixes: QTBUG-88036
Change-Id: I0fac896c16a8a060232419d9d03978cd0e2803d0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Three missing symbols and a load of warnings.
Change-Id: Ib8b5ea0aec3f2f39ea8625627eb0cd249defbc54
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
| |
Allow same page navigations since they aren't real navigations anyway.
Change-Id: I9809f6fb8534d00a2725231a8f108591e88b81ad
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
Fix coversion errors:
invalid ‘static_cast’ from type ‘uint32x4_t’ to type ‘float32x4_t’
Change-Id: I444e05b199b8a9ec05a919f6f0adc835507769c3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Too aggresive inclusions
Change-Id: Ifd9457ae59a8c7fe15cc3c3967e3332db2798679
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
| |
Tries to use the new bezier curves to approximate our old smooth
scrolling behavior.
Change-Id: I3b319025fb0339ec95c0a29525f2dde0631866ed
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|
|
|
|
|
|
| |
We don't currently use it so avoid adding it as a dependency
Change-Id: Id363ddfc4d6d95af8325dc73fb7e240a8d80c95e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: I11e714254cd56b001515441784187d887f724b6c
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
| |
Qt WebEngine is still using it.
Change-Id: I8f9aed97c06c8e38032b8c89161e1800f2169cde
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: I9bc2bd517ee3ee1ea1a8798f636f12b4f48639b0
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
It used from content_switches.h
Task-number: QTBUG-94572
Change-Id: I26cf7050f607a6941841a78354ead0ec3598a9a2
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
| |
Since a0cbfced7 we dropped dependecies in extensions/api
this leads to build races.
Change-Id: Ibbd036b071581448ab2c43452f322b8bbcdcffb1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I0cc4822112032d1fed7529d39c7f51684104840d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
The header is in /usr/include/libxkbcommon/xkbcommon/ so
we need the includepath from pkgconfig.
Change-Id: I1140cac4687f2c29888051afc6ce56280482a073
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
When building for arm64 on an x86_64 macOS, the header files for the
arm platform will be included, but ARCH_CPU_AR_64 is not defined.
This lead to checking non-constexpr vm_page_size in a static_assert even
though a DCHECK should be used for arm64.
Use the DCHECK unconditionally on macOS builds to fix this.
Change-Id: Iffa7e2de76358d3bb26473226e1c2a1ef6e0c356
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
The cast that we use to compile on aarch64 without fp16 caused a compilation
error for macOS arm64. Re-establish the upstream version for this case.
Change-Id: Ic4c4c20f9502bf5ae716956efaa87a15026f8a29
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
They have no function at the moment, but may be enabled as it becomes
possible.
Change-Id: Ic173ad41f4557b83f94b8998eca488d15c405cef
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove component/sync dependency of component/history
- Add FaviconHandler::Type() to support toggle touch icons at runtime
- Add FaviconHandler::Delegate::OnHandlerCompleted() to notify when icon
downloading is done
- Make FaviconHandler and FaviconService working when HistoryService is
not set due to off-the-record profile
Task-number: QTBUG-51184
Change-Id: Ic596f216b270ac4b76f0f37feb6d523d50592aae
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Comparing std::string with base::BasicStringPiece<std::string> doesn't
seem to work properly in std::binary_search().
Task-number: QTBUG-91467
Change-Id: I535faa358e3ce20ddb87a0830aa97fa1953d5994
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
(cherry picked from commit 5b2293cf1f238916da5cb40c4746dd987c071abd)
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
From time to time with extensions build on we get:
chromium/qtwebengine/browser/pdf/pdf_extension_util.cc:49:10:
fatal error: 'chrome/grit/generated_resources.h' file not found
Add missing dependency.
Change-Id: Idf73253da7a1cda3b358d4e5fac7c593085695dc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change brings back the behavior when the site for cookies was
stored as an URL before Chromium 81. QtWebEngine implementation relies
on that becuase it uses SiteForCookies to provide first party url in
some cases.
The site for cookies url was replaced by net::SiteForCookies in change
https://chromium-review.googlesource.com/c/chromium/src/+/1925189
Task-number: QTBUG-90231
Change-Id: Ie1e4be21535a646699b031c3a2ebdb0a19617fc7
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the build is compiled with no webrtc, the platform
abstraction will return no VideoCaptureImplManager and this
is not handled well within LocalVideoCapturerSource.
After a short call stack analysis, it seems the most suitable
place to bailout is in the user media processor, report no
hardware as in unit tests.
Change-Id: I75c92e4fe8869d6f3fb6831e8bf24c982d0b347c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Is needed for linux-clang spec build to not depend on atomic lib
Task-number: QTBUG-93294
Change-Id: I9fcb275b9dd7973653c7897c1e19ddb9f6daeb58
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
(cherry picked from commit 1d3b13e963467a19ebdd515431464771f513f6ef)
|
|
|
|
|
|
|
|
|
| |
It is used for Keyboard.getLayoutMap() on Linux.
Task-number: QTBUG-92971
Change-Id: I86ff88edd4de3f4b6c7f7e2deaf6c9c522cc0fcd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit f6730fe81a09266e29d7e5ea43f1d436d14dc610)
|
|
|
|
|
|
|
|
|
|
| |
We get undefined reference to kNoCropRect in
CropRect(const SkIRect* optionalCrop), so instead use
CropRect(const SkIRect& crop), since the pointer isn't nullable
anyway.
Change-Id: Id02deec1c57abd8d34fda70673c5973626000e96
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
| |
With following change we no longer can compile with no extensions:
https://chromium-review.googlesource.com/c/chromium/src/+/2272030
Remove gn assertion in favor of the condition.
Change-Id: I008e38a06db8397cd6632e559062fcf8aea614aa
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: Ia2bf55a221161e4b404f47b4c9f4e9a5111ddd56
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
| |
We don't have a WebRtcEventLogManager.
Fixes: QTBUG-91857
Change-Id: I70e1ab23c9bc0672856321d78ef66e2cb6b9d88e
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|