summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | [Backport] CVE-2023-0474: Use after free in GuestViewKevin McNee2023-02-022-10/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4140170: M108: Ensure a GuestView's owner WebContents' destruction is observed for delayed init Ensure a GuestView's owner WebContents' destruction is observed for delayed init We currently don't start observing a guest's owner's destruction until after the creation of the guest WebContents. An AppView's guest WebContents is created asynchronously after the embedding request completes. If the owner is destroyed while the embedding request is pending, we go on to access a stale pointer to the owner when the request completes. We now start observing the owner immediately, so we clear the owner pointer when it is destroyed. We also check that the owner still exists before proceesing with an accepted embedding request. (cherry picked from commit f29c9094a6153eb6f473b09fc9fb31b5eb744488) Bug: 1400841 Change-Id: I52ed4c98df25d5aea908d746900582c0465f01c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4140170 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by: James Maclean <wjmaclean@chromium.org> Commit-Queue: James Maclean <wjmaclean@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1090972} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4178470 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5359@{#1349} Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456885 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0473: Type Confusion in ServiceWorker APIYoshisato Yanagisawa2023-02-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originallt reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4159531: Ensure v8::Value type is v8::Function in FetchHandlerType(). In the previous code, we did not confirm the returned v8::Value is v8::Function or not in ServiceWorkerGlobalScope::FetchHandlerType(). If non function type is set as an fetch event listener, it causes misbehavior. (cherry picked from commit f68e9991d68d7ee36eb679cf5ffec06ab89569ac) Bug: 1404639 Change-Id: I7bc32f91108b2ffd3c5e8dc0464f2fa4adc41e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4137870 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1089635} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4159531 Reviewed-by: Minoru Chikamune <chikamune@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#1328} Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456884 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0472: Use after free in WebRTCHarald Alvestrand2023-02-022-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4176412: Delete PeerConnectionHandler in PeerConnection finalizer Also guard against removal of PC during PeerConnectionHandler call that may cause garbage collection. (cherry picked from commit 5066dd66309d884762e5fb9be04b59582893d09a) Bug: chromium:1405256 Change-Id: I9adf7b219e2026e07ccc0868c1a85f3b35cd9d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4154578 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1091801} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4176412 Auto-Submit: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#1347} Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456883 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0471: Use after free in WebTransportVictor Vasiliev2023-02-022-2/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4139783: Ensure clean destruction of network::WebTransport Once the destruction of the object begins, we should not process any callbacks, nor should we attempt to reset the streams on a connection that is already being closed. (cherry picked from commit 57c54ae221d60e9f9394d7ee69634d66c9cd26f3) Bug: 1376354 Change-Id: Ib49e0ce0b177062cccd0e52368782e291cf8166c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117501 Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1085965} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4139783 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#1326} Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456882 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] Security bug 1406115Vasiliy Telezhnikov2023-02-021-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4178714 Remove NUM_COMMAND_BUFFER_NAMESPACES from SyncToken.mojom Mojo validates input for allowed values, NUM_COMMAND_BUFFER_NAMESPACES is not valid value to send over ipc and is used only to know maximum value in code. (cherry picked from commit d652130c4bc2842d5df5488c69ef4f3168634a54) Bug: 1406115 Change-Id: I8e5c3b6b2a9a9206fbeb377b27ceb1242a4f54e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4167409 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1093100} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4178714 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5359@{#1352} Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456881 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] Security bug 1404811Carlos IL2023-02-023-26/+284
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4167220: Fix include_subdomains handling with PKI Metadata pins list Previously include_subdomains was ignored once the pinning list was loaded from a component (due to the find() call for the map using the full domain). This fixes this by calling it again with the url substring starting at the next . if the full domain is not found. (cherry picked from commit ca9cbe0aad4e4070b1e3c1ca530ede8a8a52cc4f) Bug: 1404811 Change-Id: I2d487401711a8a44e9cedb4b91c84ae5553c6932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4137286 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1091464} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4167220 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#1333} Cr-Branched-From: 27d3765d341b09369006d030f83f582a29eb57ae-refs/heads/main@{#1058933} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456880 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Adapt DevToolsUIBindings for WebEngineMartin Negyokru2023-02-012-0/+85
| | | | | | | | | | | | Change-Id: I34a5ded45466e2bac461a4cdb2c093618a70f85d Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/446181 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Fixes for jumbo buildMartin Negyokru2023-01-271-2/+2
| | | | | | | | | | | | | | Fixes: QTBUG-110711 Change-Id: I4a60dcee8cda3731cbf279f4629c469f8e398f8b Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456760 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Do not override getaddrinfo in libc_interceptorMartin Negyokru2023-01-271-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | This code should live in an executable, but never in a library as it causes erratic behavior depending on the linking order. It is safe to guard it since it was only used for logging. Chromium change: https://chromium-review.googlesource.com/c/chromium/src/+/3936307 Fixes: QTBUG-110287 Change-Id: I511b24be3b3a89fa28d95f90293bdca9f38f70af Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/456327 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Drop dependency on content/public/browser in content gpuMichal Klocek2023-01-254-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We include header from content/public/browser which includes generated headers, however we do not have that dependency on content gpu. This creates build race condition as generated headers might to be in place. Unfortunately adding that dependency causes some gn asserts, as this dependency should not be allowed. Therefore, move GetInProcessGpuShareGroup from browser content to gpu content, where it make more sense. Change-Id: I9dfc37ddf7466ca7b431a31b379e811583790467 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/455058 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 406715225b17b2cf4204f17b9b651bef5d397392) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/455128 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | FIXUP: Avoid using libdrmAllan Sandfeld Jensen2023-01-171-1/+1
| | | | | | | | | | | | | | | | | | use_qt changed name. Change-Id: Iad0c5c968fec9faf62b6e4f035de9e661dfd5249 Fixes: QTBUG-110272 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454525 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0138: Heap buffer overflow in libphonenumberRobert Ogden2023-01-169-710/+777
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originallt reviwed on https://chromium-review.googlesource.com/c/chromium/src/+/3961634: Remove TFLite Support's whitespace tokenizer whitespace tokenizer uses an unsafe function, chartorune, which cannot be easily fixed upstream. In the mean time we'll just remove it so nobody accidentally uses it. Bug: 1346675 Change-Id: I7fb3ba52e0f9cdf55ace15c3828550853535cfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961634 Reviewed-by: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/main@{#1061197} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454215 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0141: Insufficient policy enforcement in CORS (2/2)Takashi Toyoshima2023-01-163-0/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/3967950: Net: Update net::HttpUtil::IsSafeHeader to follow the latest spec This patch adds new forbidden cases from the fetch standard. The code is implemented behind a feature flag, but enabled by default. This is for the case if this change breaks something big in the real world. Bug: 1362331 Change-Id: I6d2f4203f89978bd7bd79527f1640a69b4db4c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3967950 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062673} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454214 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0141: Insufficient policy enforcement in CORS (1/2)Takashi Toyoshima2023-01-1611-30/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/3963942: Net: API change to take a value to evaluate safe headers This patch changes the net::HttpUtil::IsSafeHeader() API to take a header value in addition to the name. This API change is needed in a coming change, and this CL is a preparation to avoid mixing the core change with mechanical changes spread around the code base. This also affects blink::cors::IsForbiddenHeaderName(). Bug: 1362331 Change-Id: I517799b96c3a045c336d2a509691bb8cc1f173e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963942 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062009} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454213 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0131: Inappropriate implementation in iframe SandboxArthur Sonzogni2023-01-165-4/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Manual cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4085032: [M109] Fix NavigationDownloadPolicy from the browser process The NavigationDownloadPolicy is currently computed by the renderer process. The problem: not every navigation is initiated from the renderer. This is a problem. Most fields from the bitfield can also be computed from the browser process. This patch computes the one related to the 'allow-download' sandbox flags from the navigation request. In the future, I believe we want to do something similar for the other properties. (cherry picked from commit 258bee7ca64b1a2193d65f29c8209b2a0898043d) Bug: 1357366 Change-Id: I0f18d2ff302271745d030494004007aecef1d738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4061566 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1079858} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4085032 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/branch-heads/5414@{#718} Cr-Branched-From: 4417ee59d7bf6df7a9c9ea28f7722d2ee6203413-refs/heads/main@{#1070088} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454212 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0132: Inappropriate implementation in Permission promptsThomas Nguyen2023-01-1610-11/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4030554: Bind dialog input protector to it's anchor widget changed event. Bug: 1371215 (cherry picked from commit 0040cb967d7469250444603bdf1aa6e4d2ae822e) Change-Id: I39b9ea632447e1e7d4ba1b1d57f67a293c751b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016874 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Nguyen <tungnh@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1070921} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030554 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Thomas Nguyen <tungnh@google.com> Cr-Commit-Position: refs/branch-heads/5414@{#158} Cr-Branched-From: 4417ee59d7bf6df7a9c9ea28f7722d2ee6203413-refs/heads/main@{#1070088} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454211 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] CVE-2023-0129: Heap buffer overflow in Network ServiceMaks Orlovich2023-01-163-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/4048289: Align NetworkContext::SetNetworkConditions better with devtools emulateNetworkConditions The former used values of 0 to disable particular throttles, while the later documents -1, and looks to be pretty much a direct client, and the only one. So make NetworkService handle everything <= 0 as a disable, clamping at intake of config. Bug: 1382033 (cherry picked from commit ce463c2c939818a12bbcec5e2c91c35f2a0a1f0e) Change-Id: I2fd3f075d5071cb0cf647838782115b5c00405bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035891 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1073566} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4048289 Cr-Commit-Position: refs/branch-heads/5414@{#188} Cr-Branched-From: 4417ee59d7bf6df7a9c9ea28f7722d2ee6203413-refs/heads/main@{#1070088} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454210 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Remove VkDevice parameter from SurfaceFactoryOzone::CreateNativePixmap()Peter Varga2023-01-131-3/+1
| | | | | | | | | | | | Change-Id: Ib72617b91172dc3e1962f31b164aec50357e37d0 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/454028 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Jumbo buildsAllan Sandfeld Jensen2023-01-122-11/+11
| | | | | | | | | | | | Change-Id: I14c80e03e674dc8fef0945c274176d7c84ec4897 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/453306 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Merge remote-tracking branch 'origin/upstream-master' into 108-basedAllan Sandfeld Jensen2023-01-12303-4951/+3764
|\ \ | |/ | | | | Change-Id: I44852f40ee2bd63801975311335df50f7a3bf451
| * BASELINE: Update Chromium to 108.0.5359.181Allan Sandfeld Jensen2023-01-11303-4951/+3764
| | | | | | | | | | | | Change-Id: Iae2b9d190e7789ad5556dbf4c59498e05ce6e5d2 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/453305 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | [Backport] Fix up guarding SharedImage factories using VulkanPeter Varga2023-01-124-27/+44
| | | | | | | | | | | | | | | | | | Bug: none Change-Id: Ifafe188054714b1166e15680a61ec16923dc4b21 Review-URL: https://chromium-review.googlesource.com/c/chromium/src/+/4004619 Cr-Commit-Position: refs/heads/main@{#1070301} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/453117 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | [Backport] Remove VkDevice parameter from ↵Peter Varga2023-01-1217-52/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | SurfaceFactoryOzone::CreateNativePixmap() It doesn't build without Vulkan. Replace it with gpu::VulkanDeviceQueue* instead. Bug: none Change-Id: I8ba31d8bcc961847349c3829199139c274316881 Review-URL: https://chromium-review.googlesource.com/c/chromium/src/+/4013439 Cr-Commit-Position: refs/heads/main@{#1069780} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/453116 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | [Backport] viz: Do IWYU in skia_output_surface_impl_on_gpu.cc and .hPeter Varga2023-01-123-20/+9
| | | | | | | | | | | | | | | | | | Bug: none Change-Id: Ibcb286a311be61862a5e384b28a093b4d97295df Review-URL: https://chromium-review.googlesource.com/c/chromium/src/+/4003069 Cr-Commit-Position: refs/heads/main@{#1067166} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/453115 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Fixes for building with MSVCPeter Varga2023-01-091-0/+5
| | | | | | | | | | | | Change-Id: Ic9827f728e25654d98a15aa78cacfec5024ecb32 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/452684 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Fix gn build windows issuePeter Varga2023-01-092-1/+4
| | | | | | | | | | | | | | | | | | | | Omit /link flag if linking with lld-link. Change-Id: I924e954225f713ba11844478f8a5b55401e13117 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 2c4b80c2a640797a4ffd1c2265c0209f2d8d10e1) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/448108 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Update project's url for lighthouseMichal Klocek2023-01-063-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Fix the url of the project lighthouse as qdoc has an issue to create a proper link for chromium_attributions.qdoc Change-Id: I82cc89836fd1b4ff01115f3b5446f75d55db2297 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/451416 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit fdc28ee72672dc3c6bf53e68d193eacfedb52f3a) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/452245
* | Fix initalization for FCMMichal Klocek2023-01-062-0/+9
| | | | | | | | | | | | | | | | | | | | | | We should not use account fetcher as it initalizes more stuff and expects image fetcher for GAIA accounts. Change-Id: I39cb08b118ea6cadc2d369049cf852515ebd7a0d Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/434519 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 481d91afcf30a6491cdf27868025b2d2c242ef69) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/452244
* | Remove custom push servcie endpoint supportMichal Klocek2023-01-063-25/+0
| | | | | | | | | | | | | | | | | | | | Task-number: QTBUG-107442 Change-Id: Iaba5a6620fcc71f04f87da47e72261e7c477ea19 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449005 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 1051027a3098efb3ab5c718dd30ee6f482a2ab6d) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/452243 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | FIXUP: Fix ios build for pdfiumMichal Klocek2023-01-051-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | New mojo crypto tokens pulls a lot of dependencies here and there and chromium has ios asserts, therefore simply skip most stuff from root BUILD.gn, which is anyway just test dependencies. We could simply replace BUILD.gn with pdfium/BUILD.gn and make our configuration nice and simple however this would brake source directory structure as root BUILD.gn assumes fixed location of base dependencies. Change-Id: I990f19a0a930fc7e389e370b50c337e8f410c8b0 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/451990 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | FIXUP: Fix QtWebEngine build on all platformsAllan Sandfeld Jensen2023-01-041-1/+1
| | | | | | | | | | | | Change-Id: I22cb0091aaa28e746712e5ae5d6b3ed3d3396e74 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/448453 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | FIXUP: Fixes for building with MSVCAllan Jensen2023-01-0414-36/+134
| | | | | | | | | | | | Change-Id: I76c11ec75064ac16aa3e2ed0da62a4f5c0ec9a04 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/448454 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | FIXUP: Fix browser DCHECKAllan Sandfeld Jensen2023-01-041-1/+1
| | | | | | | | | | | | | | | | Switch moved Change-Id: I375620479caa708a35c09adb968cb58bd38b34f6 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/451985 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | FIXUP: Fix crashes and assertsAllan Sandfeld Jensen2023-01-041-1/+1
| | | | | | | | | | | | Change-Id: I9dd4f4de60b0d396eb6c63951a4f0474caf30c27 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/451710 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | FIXUP: Jumbo buildAllan Sandfeld Jensen2023-01-044-2/+7
| | | | | | | | | | | | | | Task-number: QTBUG-109639 Change-Id: I309c4430f4638a00ec3ab7453d66eb2adb2ed94f Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/451316 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Stop using C++20 initializationAllan Sandfeld Jensen2023-01-03160-1066/+1093
| | | | | | | | | | | | | | | | | | | | Named initialization is proposed for C++20 and we are supposed to be using only C++17. Change-Id: Iefd936eeadf5ba3ee53b446bbb4ab7c6891aadaa Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/448689 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | FIXUP: Fix misuse of {} initializationAllan Sandfeld Jensen2023-01-021-3/+3
| | | | | | | | | | | | Change-Id: I7f37dd26a2ba2b1ef8ba7c5365e9383496a1e418 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/451313 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | FIXUP: Legalize the bloody codeAllan Sandfeld Jensen2023-01-021-3/+3
| | | | | | | | | | | | Change-Id: Ifb68352979f8399db7303c679cbb0707d1bf800d Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/451314 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Remove directives from function-like macro parametersPeter Varga2023-01-0231-98/+89
| | | | | | | | | | | | | | | | | | | | | | | | It is not supported by MSVC: https://developercommunity.visualstudio.com/t/-va-args-expansion-fails-with-nested-directives/799854 Majority of the changes are replacement of BASE_FEATURE function-like macro. It was introduced by https://crrev.com/c/3906639 Change-Id: I787b5114e9948359c9e24114fe7adbca32d57307 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449903 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | [Backport] Correct initializer that is not C++11 compliantPeter Varga2023-01-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://en.cppreference.com/w/cpp/language/aggregate_initialization#Notes “Until C++11, narrowing conversions were permitted in aggregate initialization, but they are no longer allowed.” Bug: 819294 Change-Id: I95ce7cd4920ae6f7485b11c20873948f309feb42 Review-URL: https://chromium-review.googlesource.com/c/chromium/src/+/3968638 Cr-Commit-Position: refs/heads/main@{#1061771} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/443635 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 4390a3595e2e87fa13c70307c4a7f5f0be470e5e) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449678
* | Remove dependency on libgbmAllan Sandfeld Jensen2023-01-025-10/+13
| | | | | | | | | | | | | | | | We don't currently use it so avoid adding it as a dependency Change-Id: Id363ddfc4d6d95af8325dc73fb7e240a8d80c95e Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/448612
* | FIXUP: Fix navigation when clicking on links in a PDFAllan Sandfeld Jensen2022-12-201-1/+1
| | | | | | | | | | | | | | Change-Id: Ie39e49e96cf536cbe7bd6b9081d21789bab3f1cf Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449322 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Adapt permissions component for WebEnginePeter Varga2022-12-202-0/+7
| | | | | | | | | | | | Change-Id: I84c3f2b2827e4640bb838fea53122cdfd9d5a22a Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449815 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Trim down some dependencies of push messagingPeter Varga2022-12-201-0/+2
| | | | | | | | | | | | Change-Id: Id96e402e8f315af70918609c6a61dff0bc9bda1b Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449814 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | [Backport] Detile vld for gcc build fixPeter Varga2022-12-201-6/+6
| | | | | | | | | | | | | | | | | | | | - add {} around loaded register Bug: libyuv:944 Review-URL: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/3957634 Change-Id: I744df3ac1f41d47105ff58cafe137af908405315 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449813 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Remove ash_features.h header includesPeter Varga2022-12-202-2/+0
| | | | | | | | | | | | | | | | | | | | It is ChromeOS specific and we don't have it. This patch is temporary because ash_features.h will be replaced by ui_base_features.h in the next update: https://crrev.com/c/4082468 Change-Id: Icfe797897562dea6068197c5b92cc855327a2b1c Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449812 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Bring enable_webrtc backPeter Varga2022-12-201-18/+16
| | | | | | | | | | | | Change-Id: Ic54f57087aade01589eee54e9a2f3da62b65b879 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449811 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: [Revert] base: Provide a way to customize fallback allocator for ↵Peter Varga2022-12-201-2/+2
| | | | | | | | | | | | | | | | StackVector Change-Id: Ieeda9a8c182156518748424cbff979439015623e Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449810 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | [Backport] GCC: declare DocumentLoader::DecodedBodyData as publicPeter Varga2022-12-201-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix build with GCC as DocumentLoader::DecodedBodyData was not declaring SameSizeAsDocumentLoader. This works in Clang because declaring it as friend of DocumentLoader implicitly declares it as friend of its class members. But GCC does not accept that. Bug: 819294 Review-URL: https://chromium-review.googlesource.com/c/chromium/src/+/3963839 Cr-Commit-Position: refs/heads/main@{#1061645} Change-Id: I1b38321b34e9ff3daa80b3b9a9e7780b257c9d0c Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/449809 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | FIXUP: Fixes for jumbo buildPeter Varga2022-12-196-22/+23
| | | | | | | | | | | | | | Change-Id: I77c3986bab58aa047469bf7c4796af4221b069dd Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/448608 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
View Lorry Controller Status