diff options
Diffstat (limited to 'chromium/v8/src/builtins/accessors.cc')
| -rw-r--r-- | chromium/v8/src/builtins/accessors.cc | 34 |
1 files changed, 15 insertions, 19 deletions
diff --git a/chromium/v8/src/builtins/accessors.cc b/chromium/v8/src/builtins/accessors.cc index c255184caeb..0285b33e1f6 100644 --- a/chromium/v8/src/builtins/accessors.cc +++ b/chromium/v8/src/builtins/accessors.cc @@ -113,8 +113,7 @@ void Accessors::ReconfigureToDataProperty( v8::Local<v8::Name> key, v8::Local<v8::Value> val, const v8::PropertyCallbackInfo<v8::Boolean>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope stats_scope( - isolate, RuntimeCallCounterId::kReconfigureToDataProperty); + RCS_SCOPE(isolate, RuntimeCallCounterId::kReconfigureToDataProperty); HandleScope scope(isolate); Handle<Object> receiver = Utils::OpenHandle(*info.This()); Handle<JSObject> holder = @@ -155,8 +154,7 @@ Handle<AccessorInfo> Accessors::MakeArgumentsIteratorInfo(Isolate* isolate) { void Accessors::ArrayLengthGetter( v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kArrayLengthGetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kArrayLengthGetter); DisallowGarbageCollection no_gc; HandleScope scope(isolate); JSArray holder = JSArray::cast(*Utils::OpenHandle(*info.Holder())); @@ -168,8 +166,7 @@ void Accessors::ArrayLengthSetter( v8::Local<v8::Name> name, v8::Local<v8::Value> val, const v8::PropertyCallbackInfo<v8::Boolean>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kArrayLengthSetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kArrayLengthSetter); HandleScope scope(isolate); DCHECK(Utils::OpenHandle(*name)->SameValue( @@ -206,7 +203,12 @@ void Accessors::ArrayLengthSetter( return; } - JSArray::SetLength(array, length); + if (JSArray::SetLength(array, length).IsNothing()) { + // TODO(victorgomes): AccessorNameBooleanSetterCallback does not handle + // exceptions. + FATAL("Fatal JavaScript invalid array length %u", length); + UNREACHABLE(); + } uint32_t actual_new_len = 0; CHECK(array->length().ToArrayLength(&actual_new_len)); @@ -282,8 +284,7 @@ Handle<AccessorInfo> Accessors::MakeModuleNamespaceEntryInfo( void Accessors::StringLengthGetter( v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kStringLengthGetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kStringLengthGetter); DisallowGarbageCollection no_gc; HandleScope scope(isolate); @@ -330,8 +331,7 @@ static Handle<Object> GetFunctionPrototype(Isolate* isolate, void Accessors::FunctionPrototypeGetter( v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kFunctionPrototypeGetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kFunctionPrototypeGetter); HandleScope scope(isolate); Handle<JSFunction> function = Handle<JSFunction>::cast(Utils::OpenHandle(*info.Holder())); @@ -344,8 +344,7 @@ void Accessors::FunctionPrototypeSetter( v8::Local<v8::Name> name, v8::Local<v8::Value> val, const v8::PropertyCallbackInfo<v8::Boolean>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kFunctionPrototypeSetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kFunctionPrototypeSetter); HandleScope scope(isolate); Handle<Object> value = Utils::OpenHandle(*val); Handle<JSFunction> object = @@ -367,8 +366,7 @@ Handle<AccessorInfo> Accessors::MakeFunctionPrototypeInfo(Isolate* isolate) { void Accessors::FunctionLengthGetter( v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kFunctionLengthGetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kFunctionLengthGetter); HandleScope scope(isolate); Handle<JSFunction> function = Handle<JSFunction>::cast(Utils::OpenHandle(*info.Holder())); @@ -722,8 +720,7 @@ Handle<AccessorInfo> Accessors::MakeFunctionCallerInfo(Isolate* isolate) { void Accessors::BoundFunctionLengthGetter( v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kBoundFunctionLengthGetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kBoundFunctionLengthGetter); HandleScope scope(isolate); Handle<JSBoundFunction> function = Handle<JSBoundFunction>::cast(Utils::OpenHandle(*info.Holder())); @@ -749,8 +746,7 @@ Handle<AccessorInfo> Accessors::MakeBoundFunctionLengthInfo(Isolate* isolate) { void Accessors::BoundFunctionNameGetter( v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info) { i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate()); - RuntimeCallTimerScope timer(isolate, - RuntimeCallCounterId::kBoundFunctionNameGetter); + RCS_SCOPE(isolate, RuntimeCallCounterId::kBoundFunctionNameGetter); HandleScope scope(isolate); Handle<JSBoundFunction> function = Handle<JSBoundFunction>::cast(Utils::OpenHandle(*info.Holder())); |