summaryrefslogtreecommitdiff
path: root/chromium/net/cookies/cookie_util_unittest.cc
diff options
context:
space:
mode:
Diffstat (limited to 'chromium/net/cookies/cookie_util_unittest.cc')
-rw-r--r--chromium/net/cookies/cookie_util_unittest.cc37
1 files changed, 17 insertions, 20 deletions
diff --git a/chromium/net/cookies/cookie_util_unittest.cc b/chromium/net/cookies/cookie_util_unittest.cc
index bd028aa709f..801a9b6ee77 100644
--- a/chromium/net/cookies/cookie_util_unittest.cc
+++ b/chromium/net/cookies/cookie_util_unittest.cc
@@ -1,8 +1,7 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include <algorithm>
#include <memory>
#include <string>
#include <tuple>
@@ -20,7 +19,7 @@
#include "net/cookies/cookie_constants.h"
#include "net/cookies/cookie_options.h"
#include "net/cookies/cookie_util.h"
-#include "net/cookies/same_party_context.h"
+#include "net/first_party_sets/same_party_context.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/abseil-cpp/absl/types/optional.h"
@@ -505,11 +504,8 @@ class CookieUtilComputeSameSiteContextTest
std::vector<SiteForCookies> cross_site_sfc;
std::vector<SiteForCookies> same_site_sfc = GetSameSiteSitesForCookies();
for (const SiteForCookies& sfc : GetAllSitesForCookies()) {
- if (std::none_of(same_site_sfc.begin(), same_site_sfc.end(),
- [&sfc](const SiteForCookies& s) {
- return sfc.RepresentativeUrl() ==
- s.RepresentativeUrl();
- })) {
+ if (!base::Contains(same_site_sfc, sfc.RepresentativeUrl(),
+ &SiteForCookies::RepresentativeUrl)) {
cross_site_sfc.push_back(sfc);
}
}
@@ -1518,7 +1514,7 @@ TEST(CookieUtilTest, AdaptCookieAccessResultToBool) {
}
TEST(CookieUtilTest, GetSamePartyStatus_NotInSet) {
- const bool first_party_sets_enabled = true;
+ const bool same_party_attribute_enabled = true;
CookieOptions options;
options.set_is_in_nontrivial_first_party_set(false);
@@ -1546,7 +1542,7 @@ TEST(CookieUtilTest, GetSamePartyStatus_NotInSet) {
SamePartyContext(party_context_type));
EXPECT_EQ(CookieSamePartyStatus::kNoSamePartyEnforcement,
cookie_util::GetSamePartyStatus(
- *cookie, options, first_party_sets_enabled));
+ *cookie, options, same_party_attribute_enabled));
}
}
}
@@ -1555,7 +1551,7 @@ TEST(CookieUtilTest, GetSamePartyStatus_NotInSet) {
}
TEST(CookieUtilTest, GetSamePartyStatus_FeatureDisabled) {
- const bool first_party_sets_enabled = false;
+ const bool same_party_attribute_enabled = false;
CookieOptions options;
options.set_is_in_nontrivial_first_party_set(true);
@@ -1583,7 +1579,7 @@ TEST(CookieUtilTest, GetSamePartyStatus_FeatureDisabled) {
SamePartyContext(party_context_type));
EXPECT_EQ(CookieSamePartyStatus::kNoSamePartyEnforcement,
cookie_util::GetSamePartyStatus(
- *cookie, options, first_party_sets_enabled));
+ *cookie, options, same_party_attribute_enabled));
}
}
}
@@ -1592,7 +1588,6 @@ TEST(CookieUtilTest, GetSamePartyStatus_FeatureDisabled) {
}
TEST(CookieUtilTest, GetSamePartyStatus_NotSameParty) {
- const bool first_party_sets_enabled = true;
CookieOptions options;
options.set_is_in_nontrivial_first_party_set(true);
@@ -1618,8 +1613,9 @@ TEST(CookieUtilTest, GetSamePartyStatus_NotSameParty) {
options.set_same_party_context(SamePartyContext(party_context_type));
EXPECT_EQ(CookieSamePartyStatus::kNoSamePartyEnforcement,
- cookie_util::GetSamePartyStatus(*cookie, options,
- first_party_sets_enabled));
+ cookie_util::GetSamePartyStatus(
+ *cookie, options,
+ /*same_party_attribute_enabled=*/true));
}
}
}
@@ -1627,7 +1623,6 @@ TEST(CookieUtilTest, GetSamePartyStatus_NotSameParty) {
}
TEST(CookieUtilTest, GetSamePartyStatus_SamePartySemantics) {
- const bool first_party_sets_enabled = true;
CookieOptions options;
options.set_is_in_nontrivial_first_party_set(true);
@@ -1676,14 +1671,16 @@ TEST(CookieUtilTest, GetSamePartyStatus_SamePartySemantics) {
options.set_same_party_context(
SamePartyContext(SamePartyContext::Type::kCrossParty));
EXPECT_EQ(CookieSamePartyStatus::kEnforceSamePartyExclude,
- cookie_util::GetSamePartyStatus(*cookie, options,
- first_party_sets_enabled));
+ cookie_util::GetSamePartyStatus(
+ *cookie, options,
+ /*same_party_attribute_enabled=*/true));
options.set_same_party_context(
SamePartyContext(SamePartyContext::Type::kSameParty));
EXPECT_EQ(CookieSamePartyStatus::kEnforceSamePartyInclude,
- cookie_util::GetSamePartyStatus(*cookie, options,
- first_party_sets_enabled));
+ cookie_util::GetSamePartyStatus(
+ *cookie, options,
+ /*same_party_attribute_enabled=*/true));
}
}
}