summaryrefslogtreecommitdiff
path: root/chromium/components/offline_pages/core/background/request_queue_store_sql.cc
diff options
context:
space:
mode:
Diffstat (limited to 'chromium/components/offline_pages/core/background/request_queue_store_sql.cc')
-rw-r--r--chromium/components/offline_pages/core/background/request_queue_store_sql.cc16
1 files changed, 5 insertions, 11 deletions
diff --git a/chromium/components/offline_pages/core/background/request_queue_store_sql.cc b/chromium/components/offline_pages/core/background/request_queue_store_sql.cc
index 099f774180f..16a13e49c6b 100644
--- a/chromium/components/offline_pages/core/background/request_queue_store_sql.cc
+++ b/chromium/components/offline_pages/core/background/request_queue_store_sql.cc
@@ -97,7 +97,7 @@ bool CreateSchema(sql::Connection* db) {
return false;
}
- // TODO(fgorski): Add indices here.
+ // This would be a great place to add indices when we need them.
return transaction.Commit();
}
@@ -109,8 +109,6 @@ std::unique_ptr<SavePageRequest> MakeSavePageRequest(
const int64_t id = statement.ColumnInt64(0);
const base::Time creation_time =
base::Time::FromInternalValue(statement.ColumnInt64(1));
- const base::Time activation_time =
- base::Time::FromInternalValue(statement.ColumnInt64(2));
const base::Time last_attempt_time =
base::Time::FromInternalValue(statement.ColumnInt64(3));
const int64_t started_attempt_count = statement.ColumnInt64(4);
@@ -127,8 +125,8 @@ std::unique_ptr<SavePageRequest> MakeSavePageRequest(
<< " creation time " << creation_time << " user requested "
<< kUserRequested << " original_url " << original_url;
- std::unique_ptr<SavePageRequest> request(new SavePageRequest(
- id, url, client_id, creation_time, activation_time, kUserRequested));
+ std::unique_ptr<SavePageRequest> request(
+ new SavePageRequest(id, url, client_id, creation_time, kUserRequested));
request->set_last_attempt_time(last_attempt_time);
request->set_started_attempt_count(started_attempt_count);
request->set_completed_attempt_count(completed_attempt_count);
@@ -178,7 +176,7 @@ ItemActionStatus Insert(sql::Connection* db, const SavePageRequest& request) {
sql::Statement statement(db->GetCachedStatement(SQL_FROM_HERE, kSql));
statement.BindInt64(0, request.request_id());
statement.BindInt64(1, request.creation_time().ToInternalValue());
- statement.BindInt64(2, request.activation_time().ToInternalValue());
+ statement.BindInt64(2, 0);
statement.BindInt64(3, request.last_attempt_time().ToInternalValue());
statement.BindInt64(4, request.started_attempt_count());
statement.BindInt64(5, request.completed_attempt_count());
@@ -205,7 +203,7 @@ ItemActionStatus Update(sql::Connection* db, const SavePageRequest& request) {
sql::Statement statement(db->GetCachedStatement(SQL_FROM_HERE, kSql));
statement.BindInt64(0, request.creation_time().ToInternalValue());
- statement.BindInt64(1, request.activation_time().ToInternalValue());
+ statement.BindInt64(1, 0);
statement.BindInt64(2, request.last_attempt_time().ToInternalValue());
statement.BindInt64(3, request.started_attempt_count());
statement.BindInt64(4, request.completed_attempt_count());
@@ -294,7 +292,6 @@ void GetRequestsByIdsSync(sql::Connection* db,
scoped_refptr<base::SingleThreadTaskRunner> runner,
const std::vector<int64_t>& request_ids,
const RequestQueueStore::UpdateCallback& callback) {
- // TODO(fgorski): Perhaps add metrics here.
std::unique_ptr<UpdateRequestsResult> result(
new UpdateRequestsResult(StoreState::LOADED));
@@ -332,7 +329,6 @@ void AddRequestSync(sql::Connection* db,
scoped_refptr<base::SingleThreadTaskRunner> runner,
const SavePageRequest& request,
const RequestQueueStore::AddCallback& callback) {
- // TODO(fgorski): add UMA metrics here.
ItemActionStatus status = Insert(db, request);
runner->PostTask(FROM_HERE, base::Bind(callback, status));
}
@@ -341,7 +337,6 @@ void UpdateRequestsSync(sql::Connection* db,
scoped_refptr<base::SingleThreadTaskRunner> runner,
const std::vector<SavePageRequest>& requests,
const RequestQueueStore::UpdateCallback& callback) {
- // TODO(fgorski): add UMA metrics here.
std::unique_ptr<UpdateRequestsResult> result(
new UpdateRequestsResult(StoreState::LOADED));
@@ -371,7 +366,6 @@ void RemoveRequestsSync(sql::Connection* db,
scoped_refptr<base::SingleThreadTaskRunner> runner,
const std::vector<int64_t>& request_ids,
const RequestQueueStore::UpdateCallback& callback) {
- // TODO(fgorski): Perhaps add metrics here.
std::unique_ptr<UpdateRequestsResult> result(
new UpdateRequestsResult(StoreState::LOADED));