diff options
Diffstat (limited to 'chromium/chrome/browser/extensions/api/management/management_browsertest.cc')
-rw-r--r-- | chromium/chrome/browser/extensions/api/management/management_browsertest.cc | 30 |
1 files changed, 14 insertions, 16 deletions
diff --git a/chromium/chrome/browser/extensions/api/management/management_browsertest.cc b/chromium/chrome/browser/extensions/api/management/management_browsertest.cc index 60ced21750e..adba1640c02 100644 --- a/chromium/chrome/browser/extensions/api/management/management_browsertest.cc +++ b/chromium/chrome/browser/extensions/api/management/management_browsertest.cc @@ -59,7 +59,7 @@ std::string BuildForceInstallPolicyValue(const char* extension_id, } // namespace -class ExtensionManagementTest : public ExtensionBrowserTest { +class ExtensionManagementTest : public extensions::ExtensionBrowserTest { public: void SetUpInProcessBrowserTestFixture() override { EXPECT_CALL(policy_provider_, IsInitializationComplete(_)) @@ -369,16 +369,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, MAYBE_AutoUpdate) { ASSERT_EQ("ogjcoiohnmldgjemafoockdghcjciccf", extension->id()); ASSERT_EQ("1.0", extension->VersionString()); - extensions::ExtensionUpdater::CheckParams params; - params.callback = - base::Bind(&NotificationListener::OnFinished, - base::Unretained(¬ification_listener)); - // Run autoupdate and make sure version 2 of the extension was installed. ExtensionTestMessageListener listener2("v2 installed", false); extensions::TestExtensionRegistryObserver install_observer(registry); - service->updater()->CheckNow(params); + extensions::ExtensionUpdater::CheckParams params1; + params1.callback = base::BindOnce(&NotificationListener::OnFinished, + base::Unretained(¬ification_listener)); + service->updater()->CheckNow(std::move(params1)); install_observer.WaitForExtensionWillBeInstalled(); EXPECT_TRUE(listener2.WaitUntilSatisfied()); ASSERT_EQ(size_before + 1, registry->enabled_extensions().size()); @@ -400,7 +398,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, MAYBE_AutoUpdate) { interceptor.SetResponseIgnoreQuery(GURL("http://localhost/autoupdate/v3.crx"), basedir.AppendASCII("v3.crx")); - service->updater()->CheckNow(params); + extensions::ExtensionUpdater::CheckParams params2; + params2.callback = base::BindOnce(&NotificationListener::OnFinished, + base::Unretained(¬ification_listener)); + service->updater()->CheckNow(std::move(params2)); ASSERT_TRUE(WaitForExtensionInstallError()); ASSERT_TRUE(notification_listener.started()); ASSERT_TRUE(notification_listener.finished()); @@ -473,16 +474,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ASSERT_EQ("ogjcoiohnmldgjemafoockdghcjciccf", extension->id()); ASSERT_EQ("1.0", extension->VersionString()); - extensions::ExtensionUpdater::CheckParams params; - params.callback = - base::Bind(&NotificationListener::OnFinished, - base::Unretained(¬ification_listener)); - ExtensionTestMessageListener listener2("v2 installed", false); extensions::TestExtensionRegistryObserver install_observer(registry); // Run autoupdate and make sure version 2 of the extension was installed but // is still disabled. - service->updater()->CheckNow(params); + extensions::ExtensionUpdater::CheckParams params; + params.callback = base::BindOnce(&NotificationListener::OnFinished, + base::Unretained(¬ification_listener)); + service->updater()->CheckNow(std::move(params)); install_observer.WaitForExtensionWillBeInstalled(); ASSERT_EQ(disabled_size_before + 1, registry->disabled_extensions().size()); ASSERT_EQ(enabled_size_before, registry->enabled_extensions().size()); @@ -509,7 +508,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) { ExtensionService* service = extensions::ExtensionSystem::Get( browser()->profile())->extension_service(); const char kExtensionId[] = "ogjcoiohnmldgjemafoockdghcjciccf"; - extensions::ExtensionUpdater::CheckParams params; base::ScopedAllowBlockingForTesting allow_blocking; base::ScopedTempDir temp_dir; @@ -556,7 +554,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) { extensions::TestExtensionRegistryObserver install_observer(registry); // Run autoupdate and make sure version 2 of the extension was installed. - service->updater()->CheckNow(params); + service->updater()->CheckNow(extensions::ExtensionUpdater::CheckParams()); install_observer.WaitForExtensionWillBeInstalled(); ASSERT_EQ(size_before + 1, registry->enabled_extensions().size()); const Extension* extension = service->GetExtensionById(kExtensionId, false); |