diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-12-08 13:24:59 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-12-08 13:24:59 +0100 |
| commit | cd7832ee326b0c424d4ad1538efd074c86a68f9b (patch) | |
| tree | 158872ea92d5df96b1290b578cbe574aaa2acfd5 /chromium/v8/src/compiler/escape-analysis.h | |
| parent | 93cdb9906305e23304d9ff55350b7557fc1850cb (diff) | |
| parent | 69b8f9169ffd66fdeca1ac60a4bc06b91d106186 (diff) | |
| download | qtwebengine-chromium-cd7832ee326b0c424d4ad1538efd074c86a68f9b.tar.gz | |
Merge remote-tracking branch 'origin/upstream-master' into 63-based
Change-Id: I4d88054034fccbb7409fa65c37d4498b74ec0578
Diffstat (limited to 'chromium/v8/src/compiler/escape-analysis.h')
| -rw-r--r-- | chromium/v8/src/compiler/escape-analysis.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chromium/v8/src/compiler/escape-analysis.h b/chromium/v8/src/compiler/escape-analysis.h index e0d65cfacc1..504729bc811 100644 --- a/chromium/v8/src/compiler/escape-analysis.h +++ b/chromium/v8/src/compiler/escape-analysis.h @@ -130,7 +130,10 @@ class VirtualObject : public Dependable { } CHECK(!HasEscaped()); if (offset >= size()) { - // This can only happen in unreachable code. + // TODO(tebbi): Reading out-of-bounds can only happen in unreachable + // code. In this case, we have to mark the object as escaping to avoid + // dead nodes in the graph. This is a workaround that should be removed + // once we can handle dead nodes everywhere. return Nothing<Variable>(); } return Just(fields_.at(offset / kPointerSize)); |