diff options
| author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-02-02 12:21:57 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-02-12 08:13:00 +0000 |
| commit | 606d85f2a5386472314d39923da28c70c60dc8e7 (patch) | |
| tree | a8f4d7bf997f349f45605e6058259fba0630e4d7 /chromium/tools | |
| parent | 5786336dda477d04fb98483dca1a5426eebde2d7 (diff) | |
| download | qtwebengine-chromium-606d85f2a5386472314d39923da28c70c60dc8e7.tar.gz | |
BASELINE: Update Chromium to 96.0.4664.181
Change-Id: I762cd1da89d73aa6313b4a753fe126c34833f046
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/tools')
430 files changed, 26889 insertions, 14105 deletions
diff --git a/chromium/tools/OWNERS b/chromium/tools/OWNERS index 22bff4b17f1..baffc4e083f 100644 --- a/chromium/tools/OWNERS +++ b/chromium/tools/OWNERS @@ -41,4 +41,3 @@ per-file roll_webrtc.py=mbonadei@chromium.org per-file download_optimization_profile.py=gbiv@chromium.org per-file update_pgo_profiles.py=liaoyuke@chromium.org -per-file update_pgo_profiles.py=sebmarchand@chromium.org diff --git a/chromium/tools/accessibility/DIR_METADATA b/chromium/tools/accessibility/DIR_METADATA index 8dd4f6f73ca..da0b9fc5222 100644 --- a/chromium/tools/accessibility/DIR_METADATA +++ b/chromium/tools/accessibility/DIR_METADATA @@ -6,7 +6,4 @@ # For the schema of this file, see Metadata message: # https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/tools/dirmd/proto/dir_metadata.proto -monorail { - component: "Internals>Accessibility" -} -team_email: "chromium-accessibility@chromium.org"
\ No newline at end of file +mixins: "//ui/accessibility/COMMON_METADATA" diff --git a/chromium/tools/accessibility/inspect/ax_dump_events.cc b/chromium/tools/accessibility/inspect/ax_dump_events.cc index d3b51dc9744..4abe747d5aa 100644 --- a/chromium/tools/accessibility/inspect/ax_dump_events.cc +++ b/chromium/tools/accessibility/inspect/ax_dump_events.cc @@ -13,6 +13,7 @@ #include "base/run_loop.h" #include "base/strings/string_number_conversions.h" #include "base/task/single_thread_task_executor.h" +#include "build/build_config.h" #include "tools/accessibility/inspect/ax_event_server.h" #include "tools/accessibility/inspect/ax_utils.h" @@ -20,19 +21,8 @@ using ui::AXTreeSelector; namespace { -constexpr char kPidSwitch[] = "pid"; constexpr char kHelpSwitch[] = "help"; -// Convert from string to int, whether in 0x hex format or decimal format. -bool StringToInt(std::string str, int* result) { - if (str.empty()) - return false; - bool is_hex = - str.size() > 2 && str[0] == '0' && (str[1] == 'x' || str[1] == 'X'); - return is_hex ? base::HexStringToInt(str, result) - : base::StringToInt(str, result); -} - bool AXDumpEventsLogMessageHandler(int severity, const char* file, int line, @@ -48,8 +38,6 @@ void PrintHelp() { "of running applications.\n"); printf("\nusage: ax_dump_events <options>\n"); printf("options:\n"); - printf( - " --pid\t\tprocess id of an application to dump accessible tree for\n"); tools::PrintHelpForTreeSelectors(); } @@ -67,28 +55,27 @@ int main(int argc, char** argv) { return 0; } - const std::string pid_str = - base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kPidSwitch); - const AXTreeSelector selector = - tools::TreeSelectorFromCommandLine(command_line); + absl::optional<AXTreeSelector> selector = + tools::TreeSelectorFromCommandLine(*command_line); - if (pid_str.empty() && selector.empty()) { + if (!selector || selector->empty()) { LOG(ERROR) << "* Error: no application was identified to dump events for. " "Run with --help for help."; return 1; } - - int pid = 0; - if (!pid_str.empty()) { - if (!StringToInt(pid_str, &pid)) { - LOG(ERROR) << "* Error: Could not convert process id to integer."; - return 1; - } - } - base::AtExitManager exit_manager; base::SingleThreadTaskExecutor main_task_executor(base::MessagePumpType::UI); - const auto server = std::make_unique<tools::AXEventServer>(pid, selector); + + // The following code is temporary. The `pid` is set to ZERO for windows + // because `selector->widget` is a HWND for windows, otherwise, it is a PID. + // The window's code uses `selector->widget` to find the application later on. + // A future patch will update mac and linux to use selector->widget and remove + // the `pid` argument. + unsigned int pid = 0; +#if defined(USE_OZONE) || defined(USE_X11) || defined(OS_MAC) + pid = selector->widget; +#endif + const auto server = std::make_unique<tools::AXEventServer>(pid, *selector); base::RunLoop().Run(); return 0; } diff --git a/chromium/tools/accessibility/inspect/ax_dump_tree.cc b/chromium/tools/accessibility/inspect/ax_dump_tree.cc index ba9a2d9aa63..dffff9a5dbd 100644 --- a/chromium/tools/accessibility/inspect/ax_dump_tree.cc +++ b/chromium/tools/accessibility/inspect/ax_dump_tree.cc @@ -9,32 +9,15 @@ #include "base/command_line.h" #include "base/files/file_path.h" #include "base/logging.h" -#include "base/strings/string_number_conversions.h" #include "build/build_config.h" #include "tools/accessibility/inspect/ax_tree_server.h" #include "tools/accessibility/inspect/ax_utils.h" using ui::AXTreeSelector; -char kIdSwitch[] = -#if defined(WINDOWS) - "window"; -#else - "pid"; -#endif char kFiltersSwitch[] = "filters"; char kHelpSwitch[] = "help"; -// Convert from string to int, whether in 0x hex format or decimal format. -bool StringToInt(std::string str, unsigned* result) { - if (str.empty()) - return false; - bool is_hex = - str.size() > 2 && str[0] == '0' && (str[1] == 'x' || str[1] == 'X'); - return is_hex ? base::HexStringToUInt(str, result) - : base::StringToUint(str, result); -} - bool AXDumpTreeLogMessageHandler(int severity, const char* file, int line, @@ -44,26 +27,12 @@ bool AXDumpTreeLogMessageHandler(int severity, return true; } -gfx::AcceleratedWidget CastToAcceleratedWidget(unsigned window_id) { -#if defined(USE_OZONE) || defined(USE_X11) || defined(OS_MAC) - return static_cast<gfx::AcceleratedWidget>(window_id); -#else - return reinterpret_cast<gfx::AcceleratedWidget>(window_id); -#endif -} - void PrintHelp() { printf( "ax_dump_tree is a tool designed to dump platform accessible trees " "of running applications.\n"); printf("\nusage: ax_dump_tree <options>\n"); printf("options:\n"); -#if defined(WINDOWS) - printf(" --window\tHWND of a window to dump accessible tree for\n"); -#else - printf( - " --pid\t\tprocess id of an application to dump accessible tree for\n"); -#endif tools::PrintHelpForTreeSelectors(); printf( " --filters\tfile containing property filters used to filter out\n" @@ -87,24 +56,12 @@ int main(int argc, char** argv) { base::FilePath filters_path = command_line->GetSwitchValuePath(kFiltersSwitch); - std::string id_str = command_line->GetSwitchValueASCII(kIdSwitch); - if (!id_str.empty()) { - unsigned hwnd_or_pid; - if (!StringToInt(id_str, &hwnd_or_pid)) { - LOG(ERROR) << "* Error: Could not convert window id string to integer."; - return 1; - } - gfx::AcceleratedWidget widget(CastToAcceleratedWidget(hwnd_or_pid)); - - std::unique_ptr<content::AXTreeServer> server( - new content::AXTreeServer(widget, filters_path)); - return 0; - } + absl::optional<AXTreeSelector> selector = + tools::TreeSelectorFromCommandLine(*command_line); - AXTreeSelector selector = tools::TreeSelectorFromCommandLine(command_line); - if (!selector.empty()) { - std::unique_ptr<content::AXTreeServer> server( - new content::AXTreeServer(selector, filters_path)); + if (selector && !selector->empty()) { + auto server = + absl::make_unique<content::AXTreeServer>(*selector, filters_path); return 0; } diff --git a/chromium/tools/accessibility/inspect/ax_event_server.h b/chromium/tools/accessibility/inspect/ax_event_server.h index 996a3ae0dd1..8c7b02e3c60 100644 --- a/chromium/tools/accessibility/inspect/ax_event_server.h +++ b/chromium/tools/accessibility/inspect/ax_event_server.h @@ -22,6 +22,10 @@ class AXEventServer final { // or tree selector. explicit AXEventServer(base::ProcessId pid, const ui::AXTreeSelector& selector); + + AXEventServer(const AXEventServer&) = delete; + AXEventServer& operator=(const AXEventServer&) = delete; + ~AXEventServer(); private: @@ -32,8 +36,6 @@ class AXEventServer final { base::win::ScopedCOMInitializer com_initializer_; #endif std::unique_ptr<ui::AXEventRecorder> recorder_; - - DISALLOW_COPY_AND_ASSIGN(AXEventServer); }; } // namespace tools diff --git a/chromium/tools/accessibility/inspect/ax_tree_server.cc b/chromium/tools/accessibility/inspect/ax_tree_server.cc index a019f38efbc..185d7f3b831 100644 --- a/chromium/tools/accessibility/inspect/ax_tree_server.cc +++ b/chromium/tools/accessibility/inspect/ax_tree_server.cc @@ -30,28 +30,8 @@ constexpr char kAllowOptEmptyStr[] = "@ALLOW-EMPTY:"; constexpr char kAllowOptStr[] = "@ALLOW:"; constexpr char kDenyOptStr[] = "@DENY:"; -base::Value BuildTreeForSelector(const AXTreeSelector& selector, - const AXTreeFormatter* formatter) { - return formatter->BuildTreeForSelector(selector); -} - -base::Value BuildTreeForWindow(gfx::AcceleratedWidget widget, - const AXTreeFormatter* formatter) { - return formatter->BuildTreeForWindow(widget); -} - AXTreeServer::AXTreeServer(const AXTreeSelector& selector, const base::FilePath& filters_path) { - Run(base::BindOnce(&BuildTreeForSelector, selector), filters_path); -} - -AXTreeServer::AXTreeServer(gfx::AcceleratedWidget widget, - const base::FilePath& filters_path) { - Run(base::BindOnce(&BuildTreeForWindow, widget), filters_path); -} - -void AXTreeServer::Run(BuildTree build_tree, - const base::FilePath& filters_path) { std::unique_ptr<AXTreeFormatter> formatter( AXInspectFactory::CreatePlatformFormatter()); @@ -66,7 +46,7 @@ void AXTreeServer::Run(BuildTree build_tree, ui::AXTreeFormatter::kFiltersDefaultSet); // Get accessibility tree as a nested dictionary. - base::Value dict = std::move(build_tree).Run(formatter.get()); + base::Value dict = formatter->BuildTreeForSelector(selector); if (dict.DictEmpty()) { LOG(ERROR) << "Failed to get accessibility tree"; return; diff --git a/chromium/tools/accessibility/inspect/ax_tree_server.h b/chromium/tools/accessibility/inspect/ax_tree_server.h index d9937d69583..e39742a3ad0 100644 --- a/chromium/tools/accessibility/inspect/ax_tree_server.h +++ b/chromium/tools/accessibility/inspect/ax_tree_server.h @@ -21,17 +21,10 @@ namespace content { class AXTreeServer final { public: - AXTreeServer(gfx::AcceleratedWidget widget, - const base::FilePath& filters_path); AXTreeServer(const ui::AXTreeSelector& selector, const base::FilePath& filters_path); private: - using BuildTree = base::OnceCallback<base::Value(const ui::AXTreeFormatter*)>; - - // Builds and formats the accessible tree. - void Run(BuildTree build_tree, const base::FilePath& filters_path); - // Generates property filters. absl::optional<std::vector<ui::AXPropertyFilter>> GetPropertyFilters( const base::FilePath& filters_path); diff --git a/chromium/tools/accessibility/inspect/ax_utils.cc b/chromium/tools/accessibility/inspect/ax_utils.cc index 7c1d841694e..6ec7315eaae 100644 --- a/chromium/tools/accessibility/inspect/ax_utils.cc +++ b/chromium/tools/accessibility/inspect/ax_utils.cc @@ -5,6 +5,9 @@ #include "tools/accessibility/inspect/ax_utils.h" #include "base/command_line.h" +#include "base/logging.h" +#include "base/strings/string_number_conversions.h" +#include "build/build_config.h" char kActiveTabSwitch[] = "active-tab"; char kChromeSwitch[] = "chrome"; @@ -14,44 +17,84 @@ char kEdgeSwitch[] = "edge"; char kPatternSwitch[] = "pattern"; char kSafariSwitch[] = "safari"; +#if defined(USE_OZONE) || defined(USE_X11) || defined(OS_MAC) +char kIdSwitch[] = "pid"; +#else +char kIdSwitch[] = "window"; +#endif // defined(WINDOWS) + using ui::AXTreeSelector; +gfx::AcceleratedWidget CastToAcceleratedWidget(unsigned int window_id) { +#if defined(USE_OZONE) || defined(USE_X11) || defined(OS_MAC) + return static_cast<gfx::AcceleratedWidget>(window_id); +#else + return reinterpret_cast<gfx::AcceleratedWidget>(window_id); +#endif +} + +// Convert from string to int, whether in 0x hex format or decimal format. +bool StringToInt(std::string str, unsigned* result) { + if (str.empty()) + return false; + bool is_hex = + str.size() > 2 && str[0] == '0' && (str[1] == 'x' || str[1] == 'X'); + return is_hex ? base::HexStringToUInt(str, result) + : base::StringToUint(str, result); +} + namespace tools { void PrintHelpForTreeSelectors() { - printf(" --pattern\ttitle of an application to dump accessible tree for\n"); - printf(" pre-defined application selectors to dump accessible tree for:\n"); + printf(" --pattern\ttitle of an application\n"); +#if defined(WINDOWS) + printf(" --window\tHWND of a window\n"); +#else + printf(" --pid\t\tprocess id of an application\n"); +#endif + printf(" pre-defined application selectors:\n"); printf(" --chrome\tChrome browser\n"); printf(" --chromium\tChromium browser\n"); #if defined(WINDOWS) printf(" --edge\tEdge browser\n"); #endif printf(" --firefox\tFirefox browser\n"); -#if defined(MACOS) +#if defined(OS_MAC) printf(" --safari\tSafari browser\n"); #endif - printf(" --active-tab\tActive tab of a choosen browser\n"); + printf( + " --active-tab\tActive tab of browser, if application is a browser\n"); } -AXTreeSelector TreeSelectorFromCommandLine( - const base::CommandLine* command_line) { +absl::optional<AXTreeSelector> TreeSelectorFromCommandLine( + const base::CommandLine& command_line) { int selectors = AXTreeSelector::None; - if (command_line->HasSwitch(kChromeSwitch)) { + if (command_line.HasSwitch(kChromeSwitch)) { selectors = AXTreeSelector::Chrome; - } else if (command_line->HasSwitch(kChromiumSwitch)) { + } else if (command_line.HasSwitch(kChromiumSwitch)) { selectors = AXTreeSelector::Chromium; - } else if (command_line->HasSwitch(kEdgeSwitch)) { + } else if (command_line.HasSwitch(kEdgeSwitch)) { selectors = AXTreeSelector::Edge; - } else if (command_line->HasSwitch(kFirefoxSwitch)) { + } else if (command_line.HasSwitch(kFirefoxSwitch)) { selectors = AXTreeSelector::Firefox; - } else if (command_line->HasSwitch(kSafariSwitch)) { + } else if (command_line.HasSwitch(kSafariSwitch)) { selectors = AXTreeSelector::Safari; } - if (command_line->HasSwitch(kActiveTabSwitch)) { + if (command_line.HasSwitch(kActiveTabSwitch)) { selectors |= AXTreeSelector::ActiveTab; } + std::string pattern_str = command_line.GetSwitchValueASCII(kPatternSwitch); + std::string id_str = command_line.GetSwitchValueASCII(kIdSwitch); - std::string pattern_str = command_line->GetSwitchValueASCII(kPatternSwitch); + if (!id_str.empty()) { + unsigned hwnd_or_pid = 0; + if (!StringToInt(id_str, &hwnd_or_pid)) { + LOG(ERROR) << "* Error: Could not convert window id string to integer."; + return absl::nullopt; + } + return AXTreeSelector(selectors, pattern_str, + CastToAcceleratedWidget(hwnd_or_pid)); + } return AXTreeSelector(selectors, pattern_str); } diff --git a/chromium/tools/accessibility/inspect/ax_utils.h b/chromium/tools/accessibility/inspect/ax_utils.h index da6621cf703..30860a61c40 100644 --- a/chromium/tools/accessibility/inspect/ax_utils.h +++ b/chromium/tools/accessibility/inspect/ax_utils.h @@ -6,6 +6,7 @@ #define TOOLS_ACCESSIBILITY_INSPECT_AX_UTILS_H_ #include "base/command_line.h" +#include "third_party/abseil-cpp/absl/types/optional.h" #include "ui/accessibility/platform/inspect/ax_inspect.h" namespace tools { @@ -14,7 +15,8 @@ namespace tools { void PrintHelpForTreeSelectors(); // Returns tree selector from command line arguments. -ui::AXTreeSelector TreeSelectorFromCommandLine(const base::CommandLine*); +absl::optional<ui::AXTreeSelector> TreeSelectorFromCommandLine( + const base::CommandLine& command_line); } // namespace tools diff --git a/chromium/tools/add_header.py b/chromium/tools/add_header.py new file mode 100755 index 00000000000..5e2f6fbe9ae --- /dev/null +++ b/chromium/tools/add_header.py @@ -0,0 +1,417 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""Helper for adding an include to a source file in the "right" place. + +clang-format already provides header sorting functionality; however, the +functionality is limited to sorting headers within a block of headers surrounded +by blank lines (these are a heuristic to avoid clang breaking ordering for +headers sensitive to inclusion order, e.g. <windows.h>). + +As a result, inserting a new header is a bit more complex than simply inserting +the new header at the top and running clang-format. + +This script implements additional logic to: +- classify different blocks of headers by type (C system, C++ system, user) +- find the appropriate insertion point for the new header +- creating a new header block if necessary + +As a bonus, it does *also* sort the includes, though any sorting disagreements +with clang-format should be resolved in favor of clang-format. + +Usage: +tools/add_header.py --header '<utility>' foo/bar.cc foo/baz.cc foo/baz.h +""" + +import argparse +import difflib +import os.path +import re +import sys + +# The specific values of these constants are also used as a sort key for +# ordering different header types in the correct relative order. +_HEADER_TYPE_C_SYSTEM = 0 +_HEADER_TYPE_CXX_SYSTEM = 1 +_HEADER_TYPE_USER = 2 +_HEADER_TYPE_INVALID = -1 + + +def ClassifyHeader(decorated_name): + if IsCSystemHeader(decorated_name): + return _HEADER_TYPE_C_SYSTEM + elif IsCXXSystemHeader(decorated_name): + return _HEADER_TYPE_CXX_SYSTEM + elif IsUserHeader(decorated_name): + return _HEADER_TYPE_USER + else: + return _HEADER_TYPE_INVALID + + +def UndecoratedName(decorated_name): + """Returns the undecorated version of decorated_name by removing "" or <>.""" + assert IsSystemHeader(decorated_name) or IsUserHeader(decorated_name) + return decorated_name[1:-1] + + +def IsSystemHeader(decorated_name): + """Returns true if decorated_name looks like a system header.""" + return decorated_name[0] == '<' and decorated_name[-1] == '>' + + +def IsCSystemHeader(decorated_name): + """Returns true if decoraed_name looks like a C system header.""" + return IsSystemHeader(decorated_name) and UndecoratedName( + decorated_name).endswith('.h') + + +def IsCXXSystemHeader(decorated_name): + """Returns true if decoraed_name looks like a C++ system header.""" + return IsSystemHeader( + decorated_name) and not UndecoratedName(decorated_name).endswith('.h') + + +def IsUserHeader(decorated_name): + """Returns true if decoraed_name looks like a user header.""" + return decorated_name[0] == '"' and decorated_name[-1] == '"' + + +_EMPTY_LINE_RE = re.compile(r'\s*$') +_COMMENT_RE = re.compile(r'\s*//(.*)$') +_INCLUDE_RE = re.compile( + r'\s*#(import|include)\s+([<"].+?[">])\s*?(?://(.*))?$') + + +def FindIncludes(lines): + """Finds the block of #includes, assuming Google+Chrome C++ style source. + + Note that this doesn't simply return a slice of the input lines, because + having the actual indices simplifies things when generatingn the updated + source text. + + Args: + lines: The source text split into lines. + + Returns: + A tuple of begin, end indices that can be used to slice the input lines to + contain the includes to process. Returns -1, -1 if no such block of + input lines could be found. + """ + begin = end = -1 + for idx, line in enumerate(lines): + # Skip over any initial comments (e.g. the copyright boilerplate) or empty + # lines. + # TODO(dcheng): This means that any preamble comment associated with the + # first header will be dropped. So far, this hasn't broken anything, but + # maybe this needs to be more clever. + # TODO(dcheng): #define and #undef should probably also be allowed. + if _EMPTY_LINE_RE.match(line) or _COMMENT_RE.match(line): + continue + m = _INCLUDE_RE.match(line) + if not m: + if begin < 0: + # No match, but no #includes have been seen yet. Keep scanning for the + # first #include. + continue + # Give up, it's something weird that probably requires manual + # intervention. + break + + if begin < 0: + begin = idx + end = idx + 1 + return begin, end + + +class Include(object): + """Represents an #include/#import and any interesting metadata for it. + + Attributes: + decorated_name: The name of the header file, decorated with <> for system + headers or "" for user headers. + + directive: 'include' or 'import' + TODO(dcheng): In the future, this may need to support C++ modules. + + preamble: Any comment lines that precede this include line, e.g.: + + // This is a preamble comment + // for a header file. + #include <windows.h> + + would have a preamble of + + ['// This is a preamble comment', '// for a header file.']. + + inline_comment: Any comment that comes after the #include on the same line, + e.g. + + #include <windows.h> // For CreateWindowExW() + + would be parsed with an inline comment of ' For CreateWindowExW'. + + header_type: The header type corresponding to decorated_name as determined + by ClassifyHeader(). + + is_primary_header: True if this is the primary related header of a C++ + implementation file. Any primary header will be sorted to the top in its + own separate block. + """ + + def __init__(self, decorated_name, directive, preamble, inline_comment): + self.decorated_name = decorated_name + assert directive == 'include' or directive == 'import' + self.directive = directive + self.preamble = preamble + self.inline_comment = inline_comment + self.header_type = ClassifyHeader(decorated_name) + assert self.header_type != _HEADER_TYPE_INVALID + self.is_primary_header = False + + def __repr__(self): + return str((self.decorated_name, self.directive, self.preamble, + self.inline_comment, self.header_type, self.is_primary_header)) + + def ShouldInsertNewline(self, previous_include): + # Per the Google C++ style guide, different blocks of headers should be + # separated by an empty line. + return (self.is_primary_header != previous_include.is_primary_header + or self.header_type != previous_include.header_type) + + def ToSource(self): + """Generates a C++ source representation of this include.""" + source = [] + source.extend(self.preamble) + include_line = '#%s %s' % (self.directive, self.decorated_name) + if self.inline_comment: + include_line = include_line + ' //' + self.inline_comment + source.append(include_line) + return [line.rstrip() for line in source] + + +def ParseIncludes(lines): + """Parses lines into a list of Include objects. Returns None on failure. + + Args: + lines: A list of strings representing C++ source text. + + Returns: + A list of Include objects representing the parsed input lines, or None if + the input lines could not be parsed. + """ + includes = [] + preamble = [] + for line in lines: + if _EMPTY_LINE_RE.match(line): + if preamble: + # preamble contents are flushed when an #include directive is matched. + # If preamble is non-empty, that means there is a preamble separated + # from its #include directive by at least one newline. Just give up, + # since the sorter has no idea how to preserve structure in this case. + return None + continue + m = _INCLUDE_RE.match(line) + if not m: + preamble.append(line) + continue + includes.append(Include(m.group(2), m.group(1), preamble, m.group(3))) + preamble = [] + # In theory, the caller should never pass a list of lines with a dangling + # preamble. But there's a test case that exercises this, and just in case it + # actually happens, fail a bit more gracefully. + if preamble: + return None + return includes + + +def _DecomposePath(filename): + """Decomposes a filename into a list of directories and the basename. + + Args: + filename: A filename! + + Returns: + A tuple of a list of directories and a string basename. + """ + dirs = [] + dirname, basename = os.path.split(filename) + while dirname: + dirname, last = os.path.split(dirname) + dirs.append(last) + dirs.reverse() + # Remove the extension from the basename. + basename = os.path.splitext(basename)[0] + return dirs, basename + + +_PLATFORM_SUFFIX = ( + r'(?:_(?:android|aura|chromeos|ios|linux|mac|ozone|posix|win|x11))?') +_TEST_SUFFIX = r'(?:_(?:browser|interactive_ui|ui|unit)?test)?' + + +def MarkPrimaryInclude(includes, filename): + """Finds the primary header in includes and marks it as such. + + Per the style guide, if moo.cc's main purpose is to implement or test the + functionality in moo.h, moo.h should be ordered first in the includes. + + Args: + includes: A list of Include objects. + filename: The filename to use as the basis for finding the primary header. + """ + # Header files never have a primary include. + if filename.endswith('.h'): + return + + basis = _DecomposePath(filename) + + # The list of includes is searched in reverse order of length. Even though + # matching is fuzzy, moo_posix.h should take precedence over moo.h when + # considering moo_posix.cc. + includes.sort(key=lambda i: -len(i.decorated_name)) + for include in includes: + if include.header_type != _HEADER_TYPE_USER: + continue + to_test = _DecomposePath(UndecoratedName(include.decorated_name)) + + # If the basename to test is longer than the basis, just skip it and + # continue. moo.c should never match against moo_posix.h. + if len(to_test[1]) > len(basis[1]): + continue + + # The basename in the two paths being compared need to fuzzily match. + # This allows for situations where moo_posix.cc implements the interfaces + # defined in moo.h. + escaped_basename = re.escape(to_test[1]) + if not (re.match(escaped_basename + _PLATFORM_SUFFIX + _TEST_SUFFIX + '$', + basis[1]) or + re.match(escaped_basename + _TEST_SUFFIX + _PLATFORM_SUFFIX + '$', + basis[1])): + continue + + # The topmost directory name must match, and the rest of the directory path + # should be 'substantially similar'. + s = difflib.SequenceMatcher(None, to_test[0], basis[0]) + first_matched = False + total_matched = 0 + for match in s.get_matching_blocks(): + if total_matched == 0 and match.a == 0 and match.b == 0: + first_matched = True + total_matched += match.size + + if not first_matched: + continue + + # 'Substantially similar' is defined to be: + # - no more than two differences + # - at least one match besides the topmost directory + total_differences = abs(total_matched - + len(to_test[0])) + abs(total_matched - + len(basis[0])) + # Note: total_differences != 0 is mainly intended to allow more succinct + # tests (otherwise tests with just a basename would always trip the + # total_matched < 2 check). + if total_differences != 0 and (total_differences > 2 or total_matched < 2): + continue + + include.is_primary_header = True + return + + +def SerializeIncludes(includes): + """Turns includes back into the corresponding C++ source text. + + This function assumes that the list of input Include objects is already sorted + according to Google style. + + Args: + includes: a list of Include objects. + + Returns: + A list of strings representing C++ source text. + """ + source = [] + + # Assume there's always at least one include. + previous_include = None + for include in includes: + if previous_include and include.ShouldInsertNewline(previous_include): + source.append('') + source.extend(include.ToSource()) + previous_include = include + return source + + +def InsertHeaderIntoSource(filename, source, decorated_name): + """Inserts the specified header into some source text, if needed. + + Args: + filename: The name of the source file. + source: A string containing the contents of the source file. + decorated_name: The decorated name of the header to insert. + + Returns: + None on failure or the modified source text on success. + """ + lines = source.splitlines() + begin, end = FindIncludes(lines) + + # No #includes in this file. Just give up. + # TODO(dcheng): Be more clever and insert it after the file-level comment or + # include guard as appropriate. + if begin < 0: + print(f'Skipping {filename}: unable to find includes!') + return None + + includes = ParseIncludes(lines[begin:end]) + if not includes: + print(f'Skipping {filename}: unable to parse includes!') + return None + if decorated_name in [i.decorated_name for i in includes]: + # Nothing to do. + print(f'Skipping {filename}: no changes required!') + return source + MarkPrimaryInclude(includes, filename) + includes.append(Include(decorated_name, 'include', [], None)) + + # TODO(dcheng): It may be worth considering adding special sorting heuristics + # for windows.h, et cetera. + def SortKey(include): + return (not include.is_primary_header, include.header_type, + include.decorated_name) + + includes.sort(key=SortKey) + lines[begin:end] = SerializeIncludes(includes) + lines.append('') # To avoid eating the newline at the end of the file. + return '\n'.join(lines) + + +def main(): + parser = argparse.ArgumentParser( + description='Mass insert a new header into a bunch of files.') + parser.add_argument( + '--header', + help='The decorated filename of the header to insert (e.g. "a" or <a>)', + required=True) + parser.add_argument('files', nargs='+') + args = parser.parse_args() + if ClassifyHeader(args.header) == _HEADER_TYPE_INVALID: + print('--header argument must be a decorated filename, e.g.') + print(' --header "<utility>"') + print('or') + print(' --header \'"moo.h"\'') + return 1 + print(f'Inserting #include {args.header}...') + for filename in args.files: + with open(filename, 'r') as f: + new_source = InsertHeaderIntoSource(os.path.normpath(filename), f.read(), + args.header) + if not new_source: + continue + with open(filename, 'w') as f: + f.write(new_source) + + +if __name__ == '__main__': + sys.exit(main()) diff --git a/chromium/tools/add_header_test.py b/chromium/tools/add_header_test.py new file mode 100755 index 00000000000..0020518635b --- /dev/null +++ b/chromium/tools/add_header_test.py @@ -0,0 +1,417 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import unittest + +import add_header + + +class DecoratedFilenameTest(unittest.TestCase): + def testCHeaderClassification(self): + self.assertTrue(add_header.IsCSystemHeader('<stdlib.h>')) + self.assertFalse(add_header.IsCSystemHeader('<type_traits>')) + self.assertFalse(add_header.IsCSystemHeader('"moo.h"')) + + def testCXXHeaderClassification(self): + self.assertFalse(add_header.IsCXXSystemHeader('<stdlib.h>')) + self.assertTrue(add_header.IsCXXSystemHeader('<type_traits>')) + self.assertFalse(add_header.IsCXXSystemHeader('"moo.h"')) + + def testUserHeaderClassification(self): + self.assertFalse(add_header.IsUserHeader('<stdlib.h>')) + self.assertFalse(add_header.IsUserHeader('<type_traits>')) + self.assertTrue(add_header.IsUserHeader('"moo.h"')) + + def testClassifyHeader(self): + self.assertEqual(add_header.ClassifyHeader('<stdlib.h>'), + add_header._HEADER_TYPE_C_SYSTEM) + self.assertEqual(add_header.ClassifyHeader('<type_traits>'), + add_header._HEADER_TYPE_CXX_SYSTEM) + self.assertEqual(add_header.ClassifyHeader('"moo.h"'), + add_header._HEADER_TYPE_USER) + self.assertEqual(add_header.ClassifyHeader('invalid'), + add_header._HEADER_TYPE_INVALID) + + +class FindIncludesTest(unittest.TestCase): + def testEmpty(self): + begin, end = add_header.FindIncludes([]) + self.assertEqual(begin, -1) + self.assertEqual(end, -1) + + def testNoIncludes(self): + begin, end = add_header.FindIncludes(['a']) + self.assertEqual(begin, -1) + self.assertEqual(end, -1) + + def testOneInclude(self): + begin, end = add_header.FindIncludes(['#include <algorithm>']) + self.assertEqual(begin, 0) + self.assertEqual(end, 1) + + def testIncludeWithInlineComment(self): + begin, end = add_header.FindIncludes( + ['#include "moo.h" // TODO: Add more sounds.']) + self.assertEqual(begin, 0) + self.assertEqual(end, 1) + + def testNewlinesBetweenIncludes(self): + begin, end = add_header.FindIncludes( + ['#include <utility>', '', '#include "moo.h"']) + self.assertEqual(begin, 0) + self.assertEqual(end, 3) + + def testCommentsBetweenIncludes(self): + begin, end = add_header.FindIncludes([ + '#include <utility>', '// TODO: Add goat support.', '#include "moo.h"' + ]) + self.assertEqual(begin, 0) + self.assertEqual(end, 3) + + def testEmptyLinesNotIncluded(self): + begin, end = add_header.FindIncludes( + ['', '#include <utility>', '', '#include "moo.h"', '']) + self.assertEqual(begin, 1) + self.assertEqual(end, 4) + + def testCommentsNotIncluded(self): + begin, end = add_header.FindIncludes([ + '// Cow module.', '#include <utility>', '// For cow speech synthesis.', + '#include "moo.h"', '// TODO: Add Linux audio support.' + ]) + self.assertEqual(begin, 1) + self.assertEqual(end, 4) + + def testNonIncludesLinesBeforeIncludesIgnored(self): + begin, end = add_header.FindIncludes( + ['#ifndef COW_H_', '#define COW_H_', '#include "moo.h"']) + self.assertEqual(begin, 2) + self.assertEqual(end, 3) + + def testNonIncludesLinesAfterIncludesTerminates(self): + begin, end = add_header.FindIncludes([ + '#include "moo.h"', '#ifndef COW_MESSAGES_H_', '#define COW_MESSAGE_H_' + ]) + self.assertEqual(begin, 0) + self.assertEqual(end, 1) + + +class IncludeTest(unittest.TestCase): + def testToSource(self): + self.assertEqual( + add_header.Include('<moo.h>', 'include', [], None).ToSource(), + ['#include <moo.h>']) + + def testIncludeWithPreambleToSource(self): + self.assertEqual( + add_header.Include('"moo.h"', 'include', ['// preamble'], + None).ToSource(), + ['// preamble', '#include "moo.h"']) + + def testIncludeWithInlineCommentToSource(self): + self.assertEqual( + add_header.Include('"moo.h"', 'include', [], + ' inline comment').ToSource(), + ['#include "moo.h" // inline comment']) + + def testIncludeWithPreambleAndInlineCommentToSource(self): + # Make sure whitespace is vaguely normalized too. + self.assertEqual( + add_header.Include('"moo.h"', 'include', [ + '// preamble with trailing space ', + ], ' inline comment with trailing space ').ToSource(), [ + '// preamble with trailing space', + '#include "moo.h" // inline comment with trailing space' + ]) + + def testImportToSource(self): + self.assertEqual( + add_header.Include('"moo.h"', 'import', [], None).ToSource(), + ['#import "moo.h"']) + + +class ParseIncludesTest(unittest.TestCase): + def testInvalid(self): + self.assertIsNone(add_header.ParseIncludes(['invalid'])) + + def testInclude(self): + includes = add_header.ParseIncludes(['#include "moo.h"']) + self.assertEqual(len(includes), 1) + self.assertEqual(includes[0].decorated_name, '"moo.h"') + self.assertEqual(includes[0].directive, 'include') + self.assertEqual(includes[0].preamble, []) + self.assertIsNone(includes[0].inline_comment) + self.assertEqual(includes[0].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[0].is_primary_header) + + def testIncludeSurroundedByWhitespace(self): + includes = add_header.ParseIncludes([' #include "moo.h" ']) + self.assertEqual(len(includes), 1) + self.assertEqual(includes[0].decorated_name, '"moo.h"') + self.assertEqual(includes[0].directive, 'include') + self.assertEqual(includes[0].preamble, []) + self.assertIsNone(includes[0].inline_comment) + self.assertEqual(includes[0].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[0].is_primary_header) + + def testImport(self): + includes = add_header.ParseIncludes(['#import "moo.h"']) + self.assertEqual(len(includes), 1) + self.assertEqual(includes[0].decorated_name, '"moo.h"') + self.assertEqual(includes[0].directive, 'import') + self.assertEqual(includes[0].preamble, []) + self.assertIsNone(includes[0].inline_comment) + self.assertEqual(includes[0].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[0].is_primary_header) + + def testIncludeWithPreamble(self): + includes = add_header.ParseIncludes( + ['// preamble comment ', '#include "moo.h"']) + self.assertEqual(len(includes), 1) + self.assertEqual(includes[0].decorated_name, '"moo.h"') + self.assertEqual(includes[0].directive, 'include') + self.assertEqual(includes[0].preamble, ['// preamble comment ']) + self.assertIsNone(includes[0].inline_comment) + self.assertEqual(includes[0].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[0].is_primary_header) + + def testIncludeWithInvalidPreamble(self): + self.assertIsNone( + add_header.ParseIncludes(['// orphan comment', '', '#include "moo.h"'])) + + def testIncludeWIthInlineComment(self): + includes = add_header.ParseIncludes(['#include "moo.h"// For SFX ']) + self.assertEqual(len(includes), 1) + self.assertEqual(includes[0].decorated_name, '"moo.h"') + self.assertEqual(includes[0].directive, 'include') + self.assertEqual(includes[0].preamble, []) + self.assertEqual(includes[0].inline_comment, ' For SFX ') + self.assertEqual(includes[0].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[0].is_primary_header) + + def testIncludeWithInlineCommentAndPreamble(self): + includes = add_header.ParseIncludes( + ['// preamble comment ', '#include "moo.h" // For SFX ']) + self.assertEqual(len(includes), 1) + self.assertEqual(includes[0].decorated_name, '"moo.h"') + self.assertEqual(includes[0].directive, 'include') + self.assertEqual(includes[0].preamble, ['// preamble comment ']) + self.assertEqual(includes[0].inline_comment, ' For SFX ') + self.assertEqual(includes[0].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[0].is_primary_header) + + def testMultipleIncludes(self): + includes = add_header.ParseIncludes([ + '#include <time.h>', '', '#include "moo.h" // For SFX ', + '// TODO: Implement death ray.', '#import "goat.h"' + ]) + self.assertEqual(len(includes), 3) + self.assertEqual(includes[0].decorated_name, '<time.h>') + self.assertEqual(includes[0].directive, 'include') + self.assertEqual(includes[0].preamble, []) + self.assertIsNone(includes[0].inline_comment) + self.assertEqual(includes[0].header_type, add_header._HEADER_TYPE_C_SYSTEM) + self.assertFalse(includes[0].is_primary_header) + self.assertEqual(includes[1].decorated_name, '"moo.h"') + self.assertEqual(includes[1].directive, 'include') + self.assertEqual(includes[1].preamble, []) + self.assertEqual(includes[1].inline_comment, ' For SFX ') + self.assertEqual(includes[1].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[1].is_primary_header) + self.assertEqual(includes[2].decorated_name, '"goat.h"') + self.assertEqual(includes[2].directive, 'import') + self.assertEqual(includes[2].preamble, ['// TODO: Implement death ray.']) + self.assertIsNone(includes[2].inline_comment) + self.assertEqual(includes[2].header_type, add_header._HEADER_TYPE_USER) + self.assertFalse(includes[2].is_primary_header) + + +class MarkPrimaryIncludeTest(unittest.TestCase): + def _extract_primary_name(self, includes): + for include in includes: + if include.is_primary_header: + return include.decorated_name + + def testNoOpOnHeader(self): + includes = [add_header.Include('"cow.h"', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'cow.h') + self.assertIsNone(self._extract_primary_name(includes)) + + def testSystemHeaderNotMatched(self): + includes = [add_header.Include('<cow.h>', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'cow.cc') + self.assertIsNone(self._extract_primary_name(includes)) + + def testExactMatch(self): + includes = [ + add_header.Include('"cow.h"', 'include', [], None), + add_header.Include('"cow_posix.h"', 'include', [], None), + ] + add_header.MarkPrimaryInclude(includes, 'cow.cc') + self.assertEqual(self._extract_primary_name(includes), '"cow.h"') + + def testFuzzyMatch(self): + includes = [add_header.Include('"cow.h"', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'cow_linux_unittest.cc') + self.assertEqual(self._extract_primary_name(includes), '"cow.h"') + + def testFuzzymatchInReverse(self): + includes = [add_header.Include('"cow.h"', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'cow_uitest_aura.cc') + self.assertEqual(self._extract_primary_name(includes), '"cow.h"') + + def testFuzzyMatchDoesntMatchDifferentSuffixes(self): + includes = [add_header.Include('"cow_posix.h"', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'cow_windows.cc') + self.assertIsNone(self._extract_primary_name(includes)) + + def testMarksMostSpecific(self): + includes = [ + add_header.Include('"cow.h"', 'include', [], None), + add_header.Include('"cow_posix.h"', 'include', [], None), + ] + add_header.MarkPrimaryInclude(includes, 'cow_posix.cc') + self.assertEqual(self._extract_primary_name(includes), '"cow_posix.h"') + + def testFullPathMatch(self): + includes = [add_header.Include('"zfs/impl/cow.h"', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'zfs/impl/cow.cc') + self.assertEqual(self._extract_primary_name(includes), '"zfs/impl/cow.h"') + + def testTopmostDirectoryDoesNotMatch(self): + includes = [add_header.Include('"animal/impl/cow.h"', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'zfs/impl/cow.cc') + self.assertIsNone(self._extract_primary_name(includes)) + + def testSubstantiallySimilarPaths(self): + includes = [ + add_header.Include('"farm/public/animal/cow.h"', 'include', [], None) + ] + add_header.MarkPrimaryInclude(includes, 'farm/animal/cow.cc') + self.assertEqual(self._extract_primary_name(includes), + '"farm/public/animal/cow.h"') + + def testNoMatchingSubdirectories(self): + includes = [add_header.Include('"base/zfs/cow.h"', 'include', [], None)] + add_header.MarkPrimaryInclude(includes, 'base/animal/cow.cc') + self.assertIsNone(self._extract_primary_name(includes)) + + +class SerializeIncludesTest(unittest.TestCase): + def testSystemHeaders(self): + source = add_header.SerializeIncludes([ + add_header.Include('<stdlib.h>', 'include', [], None), + add_header.Include('<map>', 'include', [], None), + ]) + self.assertEqual(source, ['#include <stdlib.h>', '', '#include <map>']) + + def testUserHeaders(self): + source = add_header.SerializeIncludes([ + add_header.Include('"goat.h"', 'include', [], None), + add_header.Include('"moo.h"', 'include', [], None), + ]) + self.assertEqual(source, ['#include "goat.h"', '#include "moo.h"']) + + def testSystemAndUserHeaders(self): + source = add_header.SerializeIncludes([ + add_header.Include('<stdlib.h>', 'include', [], None), + add_header.Include('<map>', 'include', [], None), + add_header.Include('"moo.h"', 'include', [], None), + ]) + self.assertEqual( + source, + ['#include <stdlib.h>', '', '#include <map>', '', '#include "moo.h"']) + + def testPrimaryAndSystemHeaders(self): + primary_header = add_header.Include('"cow.h"', 'include', [], None) + primary_header.is_primary_header = True + source = add_header.SerializeIncludes([ + primary_header, + add_header.Include('<stdlib.h>', 'include', [], None), + add_header.Include('<map>', 'include', [], None), + ]) + self.assertEqual( + source, + ['#include "cow.h"', '', '#include <stdlib.h>', '', '#include <map>']) + + def testPrimaryAndUserHeaders(self): + primary_header = add_header.Include('"cow.h"', 'include', [], None) + primary_header.is_primary_header = True + source = add_header.SerializeIncludes([ + primary_header, + add_header.Include('"moo.h"', 'include', [], None), + ]) + self.assertEqual(source, ['#include "cow.h"', '', '#include "moo.h"']) + + def testPrimarySystemAndUserHeaders(self): + primary_header = add_header.Include('"cow.h"', 'include', [], None) + primary_header.is_primary_header = True + source = add_header.SerializeIncludes([ + primary_header, + add_header.Include('<stdlib.h>', 'include', [], None), + add_header.Include('<map>', 'include', [], None), + add_header.Include('"moo.h"', 'include', [], None), + ]) + self.assertEqual(source, [ + '#include "cow.h"', '', '#include <stdlib.h>', '', '#include <map>', '', + '#include "moo.h"' + ]) + + +class InsertHeaderIntoSourceTest(unittest.TestCase): + def testAddInclude(self): + source = add_header.InsertHeaderIntoSource( + 'cow.cc', '\n'.join([ + '// Copyright info here.', '', '#include <utility>', + '// For cow speech synthesis.', + '#include "moo.h" // TODO: Add Linux audio support.', + '#include <time.h>', '#include "cow.h"', 'namespace bovine {', '', + '// TODO: Implement.', '} // namespace bovine' + ]), '<memory>') + self.assertEqual( + source, '\n'.join([ + '// Copyright info here.', '', '#include "cow.h"', '', + '#include <time.h>', '', '#include <memory>', '#include <utility>', + '', '// For cow speech synthesis.', + '#include "moo.h" // TODO: Add Linux audio support.', + 'namespace bovine {', '', '// TODO: Implement.', + '} // namespace bovine', '' + ])) + + def testAlreadyIncluded(self): + # To make sure the original source is returned unmodified, the input source + # intentionally scrambles the #include order. + source = '\n'.join([ + '// Copyright info here.', '', '#include "moo.h"', '#include <utility>', + '#include <memory>', '#include "cow.h"', 'namespace bovine {', '', + '// TODO: Implement.', '} // namespace bovine' + ]) + self.assertEqual( + add_header.InsertHeaderIntoSource('cow.cc', source, '<memory>'), source) + + def testConditionalIncludesLeftALone(self): + # TODO(dcheng): Conditional header handling could probably be more clever. + # But for the moment, this is probably Good Enough. + source = add_header.InsertHeaderIntoSource( + 'cow.cc', '\n'.join([ + '// Copyright info here.', '', '#include "cow.h"', + '#include <utility>', '// For cow speech synthesis.', + '#include "moo.h" // TODO: Add Linux audio support.', + '#if defined(USE_AURA)', '#include <memory>', + '#endif // defined(USE_AURA)' + ]), '<memory>') + self.assertEqual( + source, '\n'.join([ + '// Copyright info here.', '', '#include "cow.h"', '', + '#include <memory>', '#include <utility>', '', + '// For cow speech synthesis.', + '#include "moo.h" // TODO: Add Linux audio support.', + '#if defined(USE_AURA)', '#include <memory>', + '#endif // defined(USE_AURA)', '' + ])) + + +if __name__ == '__main__': + unittest.main() diff --git a/chromium/tools/aggregation_service/BUILD.gn b/chromium/tools/aggregation_service/BUILD.gn index 7343739b808..9f122bed75d 100644 --- a/chromium/tools/aggregation_service/BUILD.gn +++ b/chromium/tools/aggregation_service/BUILD.gn @@ -5,11 +5,23 @@ executable("aggregation_service_tool") { testonly = true - sources = [ "aggregation_service_tool_main.cc" ] + sources = [ + "aggregation_service_tool.cc", + "aggregation_service_tool.h", + "aggregation_service_tool_main.cc", + "aggregation_service_tool_network_initializer.cc", + "aggregation_service_tool_network_initializer.h", + ] deps = [ "//base", "//content/test:test_support", + "//mojo/core/embedder:embedder", + "//net", + "//services/cert_verifier:lib", + "//services/network:network_service", + "//services/network/public/cpp", + "//services/network/public/mojom", "//url", ] } diff --git a/chromium/tools/aggregation_service/DEPS b/chromium/tools/aggregation_service/DEPS index b9445512748..9ac832d4da5 100644 --- a/chromium/tools/aggregation_service/DEPS +++ b/chromium/tools/aggregation_service/DEPS @@ -1,3 +1,8 @@ include_rules = [ - "+content/public/test" + "+content/public/browser", + "+content/public/test", + "+mojo/core/embedder", + "+mojo/public/cpp", + "+services/cert_verifier/public/mojom", + "+services/network", ] diff --git a/chromium/tools/aggregation_service/DIR_METADATA b/chromium/tools/aggregation_service/DIR_METADATA index 4f8aa58578e..e5ef722f969 100644 --- a/chromium/tools/aggregation_service/DIR_METADATA +++ b/chromium/tools/aggregation_service/DIR_METADATA @@ -1,4 +1 @@ -monorail { - component: "Internals>ConversionMeasurement" -} -team_email: "privacy-sandbox-dev@chromium.org" +mixins: "//content/browser/aggregation_service/COMMON_METADATA" diff --git a/chromium/tools/aggregation_service/README.md b/chromium/tools/aggregation_service/README.md new file mode 100644 index 00000000000..cd9aa6e1a79 --- /dev/null +++ b/chromium/tools/aggregation_service/README.md @@ -0,0 +1,5 @@ +This directory contains a command-line tool that generates aggregatable reports for testing. + +**TODO**: Expand this README. + +Please see //content/browser/aggregation_service's [README](../../content/browser/aggregation_service/README.md) for more detail on the reports and service. diff --git a/chromium/tools/aggregation_service/aggregation_service_tool.cc b/chromium/tools/aggregation_service/aggregation_service_tool.cc new file mode 100644 index 00000000000..8a452b57dcc --- /dev/null +++ b/chromium/tools/aggregation_service/aggregation_service_tool.cc @@ -0,0 +1,118 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/aggregation_service/aggregation_service_tool.h" + +#include <functional> +#include <string> +#include <utility> + +#include "base/bind.h" +#include "base/callback_forward.h" +#include "base/check.h" +#include "base/files/file_path.h" +#include "base/files/file_util.h" +#include "base/json/json_string_value_serializer.h" +#include "base/logging.h" +#include "base/run_loop.h" +#include "base/strings/utf_string_conversions.h" +#include "base/time/default_clock.h" +#include "base/values.h" +#include "build/build_config.h" +#include "content/public/test/test_aggregation_service.h" +#include "tools/aggregation_service/aggregation_service_tool_network_initializer.h" +#include "url/gurl.h" +#include "url/origin.h" + +namespace aggregation_service { + +AggregationServiceTool::AggregationServiceTool() + : agg_service_(content::TestAggregationService::Create( + base::DefaultClock::GetInstance())) {} + +AggregationServiceTool::~AggregationServiceTool() = default; + +bool AggregationServiceTool::SetPublicKeys(const base::StringPairs& kv_pairs) { + // Send each origin's specified public keys to the tool's storage. + for (const auto& kv : kv_pairs) { + url::Origin origin = url::Origin::Create(GURL("https://" + kv.first)); + if (!SetPublicKeysFromFile(origin, kv.second)) + return false; + } + + return true; +} + +bool AggregationServiceTool::SetPublicKeysFromFile( + const url::Origin& origin, + const std::string& json_file_path) { +#if defined(OS_WIN) + base::FilePath json_file(base::UTF8ToWide(json_file_path)); +#else + base::FilePath json_file(json_file_path); +#endif + + if (!base::PathExists(json_file)) { + LOG(ERROR) << "aggregation_service_tool failed to open file: " + << json_file.value() << "."; + return false; + } + + std::string json_string; + if (!base::ReadFileToString(json_file, &json_string)) { + LOG(ERROR) << "aggregation_service_tool failed to read file: " + << json_file.value() << "."; + return false; + } + + bool succeeded = false; + + base::RunLoop run_loop; + agg_service_->SetPublicKeys( + origin, json_string, + base::BindOnce( + [](base::OnceClosure quit, bool& succeeded_out, bool succeeded_in) { + succeeded_out = succeeded_in; + std::move(quit).Run(); + }, + run_loop.QuitClosure(), std::ref(succeeded))); + run_loop.Run(); + + return succeeded; +} + +bool AggregationServiceTool::SendReport(const base::Value& contents, + const GURL& url) { + DCHECK(url.is_valid()); + + ToolNetworkInitializer network_initializer(agg_service_.get()); + + bool succeeded = false; + + base::RunLoop run_loop; + agg_service_->SendReport( + url, contents, + base::BindOnce( + [](base::OnceClosure quit, bool& succeeded_out, bool succeeded_in) { + succeeded_out = succeeded_in; + std::move(quit).Run(); + }, + run_loop.QuitClosure(), std::ref(succeeded))); + run_loop.Run(); + + return succeeded; +} + +bool AggregationServiceTool::WriteReportToFile(const base::Value& contents, + const base::FilePath& filename) { + DCHECK(!filename.empty()); + + std::string contents_json; + JSONStringValueSerializer serializer(&contents_json); + DCHECK(serializer.Serialize(contents)); + + return base::WriteFile(filename, contents_json); +} + +} // namespace aggregation_service
\ No newline at end of file diff --git a/chromium/tools/aggregation_service/aggregation_service_tool.h b/chromium/tools/aggregation_service/aggregation_service_tool.h new file mode 100644 index 00000000000..f3d68ca7091 --- /dev/null +++ b/chromium/tools/aggregation_service/aggregation_service_tool.h @@ -0,0 +1,58 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef TOOLS_AGGREGATION_SERVICE_AGGREGATION_SERVICE_TOOL_H_ +#define TOOLS_AGGREGATION_SERVICE_AGGREGATION_SERVICE_TOOL_H_ + +#include <memory> +#include <string> + +#include "base/strings/string_split.h" + +class GURL; + +namespace base { +class FilePath; +class Value; +} // namespace base + +namespace content { +class TestAggregationService; +} // namespace content + +namespace url { +class Origin; +} // namespace url + +namespace aggregation_service { + +// This class is a wrapper for aggregation service tool. +class AggregationServiceTool { + public: + AggregationServiceTool(); + ~AggregationServiceTool(); + + // Sets public keys to storage from the origin-filename pairs and returns + // whether it's successful. + bool SetPublicKeys(const base::StringPairs& kv_pairs); + + // Sends the contents of the aggregatable report to the specified reporting + // url `url` and returns whether it's successful. + bool SendReport(const base::Value& contents, const GURL& url); + + // Writes the contents of the aggregatable report to the specified file + // `filename` and returns whether it's successful. + bool WriteReportToFile(const base::Value& contents, + const base::FilePath& filename); + + private: + bool SetPublicKeysFromFile(const url::Origin& origin, + const std::string& json_file_path); + + std::unique_ptr<content::TestAggregationService> agg_service_; +}; + +} // namespace aggregation_service + +#endif // TOOLS_AGGREGATION_SERVICE_AGGREGATION_SERVICE_TOOL_H_
\ No newline at end of file diff --git a/chromium/tools/aggregation_service/aggregation_service_tool_main.cc b/chromium/tools/aggregation_service/aggregation_service_tool_main.cc index 1e8db95d6fb..2eea584c7a1 100644 --- a/chromium/tools/aggregation_service/aggregation_service_tool_main.cc +++ b/chromium/tools/aggregation_service/aggregation_service_tool_main.cc @@ -2,25 +2,17 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include <functional> -#include <memory> #include <string> -#include "base/bind.h" -#include "base/callback.h" #include "base/command_line.h" #include "base/files/file_path.h" -#include "base/files/file_util.h" #include "base/logging.h" -#include "base/run_loop.h" #include "base/strings/string_split.h" -#include "base/strings/utf_string_conversions.h" #include "base/task/single_thread_task_executor.h" #include "base/task/thread_pool/thread_pool_instance.h" -#include "build/build_config.h" -#include "content/public/test/test_aggregation_service.h" +#include "base/values.h" +#include "tools/aggregation_service/aggregation_service_tool.h" #include "url/gurl.h" -#include "url/origin.h" namespace { @@ -28,57 +20,35 @@ namespace { const char kSwitchContents[] = "contents"; const char kSwitchHelperKeys[] = "helper-keys"; const char kSwitchOutput[] = "output"; +const char kSwitchReportingUrl[] = "reporting-url"; const char kHelpMsg[] = R"( aggregation_service_tool --contents=<report_contents> - --helper-keys=<helper_server_keys> --output=<output_file_path> + --helper-keys=<helper_server_keys> [--output=<output_file_path>] + [--reporting-url=<reporting_url>] Example: aggregation_service_tool --contents="count-value,1234,5" --helper-keys="a.com:keys1.json,b.com:keys2.json" --output="output.json" + or + aggregation_service_tool --contents="count-value,1234,5" + --helper-keys="a.com:keys1.json,b.com:keys2.json" + --reporting-url="https://c.com" aggregation_service_tool is a command-line tool that accepts report contents `contents` and mapping of origins to public key json files - `helper_server_keys` as input and output an encrypted report in - `output_file_path`. + `helper_server_keys` as input and either output an aggregatable report to + `output_file_path` or send the aggregatable report to `reporting_url`. )"; void PrintHelp() { LOG(INFO) << kHelpMsg; } -void SetPublicKeysFromFile(const url::Origin& origin, - const std::string& json_file_path, - content::TestAggregationService* agg_service, - base::OnceCallback<void(bool)> callback) { -#if defined(OS_WIN) - base::FilePath json_file(base::UTF8ToWide(json_file_path)); -#else - base::FilePath json_file(json_file_path); -#endif - - if (!base::PathExists(json_file)) { - LOG(ERROR) << "aggregation_service_tool failed to open file: " - << json_file.value() << "."; - std::move(callback).Run(false); - return; - } - - std::string json_string; - if (!base::ReadFileToString(json_file, &json_string)) { - LOG(ERROR) << "aggregation_service_tool failed to read file: " - << json_file.value() << "."; - std::move(callback).Run(false); - return; - } - - agg_service->SetPublicKeys(origin, json_string, std::move(callback)); -} - } // namespace int main(int argc, char* argv[]) { - base::SingleThreadTaskExecutor executor; + base::SingleThreadTaskExecutor executor(base::MessagePumpType::IO); base::ThreadPoolInstance::CreateAndStartWithDefaultParams( "aggregation_service_tool"); @@ -94,54 +64,71 @@ int main(int argc, char* argv[]) { return 1; } - if (!command_line.HasSwitch(kSwitchContents) || - !command_line.HasSwitch(kSwitchHelperKeys) || - !command_line.HasSwitch(kSwitchOutput)) { - LOG(ERROR) << "aggregation_service_tool expects contents, helper keys and " - "output to be specified."; + if (!command_line.HasSwitch(kSwitchContents)) { + LOG(ERROR) << "aggregation_service_tool expects " << kSwitchContents + << " to be specified."; PrintHelp(); return 1; } - std::string contents = command_line.GetSwitchValueASCII(kSwitchContents); - std::string helper_keys = command_line.GetSwitchValueASCII(kSwitchHelperKeys); - base::FilePath output = command_line.GetSwitchValuePath(kSwitchOutput); + if (!command_line.HasSwitch(kSwitchHelperKeys)) { + LOG(ERROR) << "aggregation_service_tool expects " << kSwitchHelperKeys + << " to be specified."; + PrintHelp(); + return 1; + } + + // Either output or reporting url should be specified, but not both. + if (!(command_line.HasSwitch(kSwitchOutput) ^ + command_line.HasSwitch(kSwitchReportingUrl))) { + LOG(ERROR) << "aggregation_service_tool expects either " << kSwitchOutput + << " or " << kSwitchReportingUrl + << " to be specified, but not both."; + PrintHelp(); + return 1; + } + + aggregation_service::AggregationServiceTool tool; - std::unique_ptr<content::TestAggregationService> agg_service = - content::TestAggregationService::Create(); + std::string helper_keys = command_line.GetSwitchValueASCII(kSwitchHelperKeys); // `helper_keys` is formatted like "a.com:keys1.json,b.com:keys2.json". base::StringPairs kv_pairs; base::SplitStringIntoKeyValuePairs(helper_keys, /*key_value_delimiter=*/':', /*key_value_pair_delimiter=*/',', &kv_pairs); - - // Send each origin's specified public keys to the tool's storage. - for (const auto& kv : kv_pairs) { - url::Origin origin = url::Origin::Create(GURL("https://" + kv.first)); - bool succeeded = false; - base::RunLoop run_loop; - SetPublicKeysFromFile( - origin, kv.second, agg_service.get(), - base::BindOnce( - [](base::OnceClosure quit, bool& succeeded_out, bool succeeded_in) { - succeeded_out = succeeded_in; - std::move(quit).Run(); - }, - run_loop.QuitClosure(), std::ref(succeeded))); - run_loop.Run(); - if (!succeeded) { - LOG(ERROR) - << "aggregation_service_tool failed to set public keys for origin: " - << origin << "."; - return 1; - } + if (!tool.SetPublicKeys(kv_pairs)) { + LOG(ERROR) << "aggregation_service_tool failed to set public keys."; + return 1; } // TODO(crbug.com/1217824): Interact with the assembler to create an encrypted // report. - // TODO(crbug.com/1218124): Returning that report (e.g. by saving to disk). + base::Value report_contents; + + bool succeeded = false; + if (command_line.HasSwitch(kSwitchOutput)) { + base::FilePath output = command_line.GetSwitchValuePath(kSwitchOutput); + succeeded = tool.WriteReportToFile(report_contents, output); + + if (!succeeded) { + LOG(ERROR) << "aggregation_service_tool failed to write to " << output + << "."; + } + } else { + std::string reporting_url = + command_line.GetSwitchValueASCII(kSwitchReportingUrl); + succeeded = tool.SendReport(report_contents, GURL(reporting_url)); + + if (!succeeded) { + LOG(ERROR) << "aggregation_service_tool failed to send the report to " + << reporting_url << "."; + } + } + + if (!succeeded) + return 1; return 0; -} +}
\ No newline at end of file diff --git a/chromium/tools/aggregation_service/aggregation_service_tool_network_initializer.cc b/chromium/tools/aggregation_service/aggregation_service_tool_network_initializer.cc new file mode 100644 index 00000000000..af5c8841935 --- /dev/null +++ b/chromium/tools/aggregation_service/aggregation_service_tool_network_initializer.cc @@ -0,0 +1,55 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/aggregation_service/aggregation_service_tool_network_initializer.h" + +#include "base/check.h" +#include "content/public/browser/network_service_instance.h" +#include "mojo/core/embedder/embedder.h" +#include "mojo/public/cpp/bindings/remote.h" +#include "services/cert_verifier/public/mojom/cert_verifier_service_factory.mojom.h" +#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h" +#include "services/network/public/mojom/network_context.mojom.h" +#include "services/network/public/mojom/network_service.mojom.h" + +namespace aggregation_service { + +ToolNetworkInitializer::ToolNetworkInitializer( + content::TestAggregationService* agg_service) { + // Initialize the network state as this tool runs independently from the + // command line. + mojo::core::Init(); + + mojo::Remote<network::mojom::NetworkService> network_service_remote; + network_service_ = network::NetworkService::Create( + network_service_remote.BindNewPipeAndPassReceiver()); + + auto network_context_params = network::mojom::NetworkContextParams::New(); + network_context_params->cert_verifier_params = content::GetCertVerifierParams( + cert_verifier::mojom::CertVerifierCreationParams::New()); + + mojo::Remote<network::mojom::NetworkContext> network_context_remote; + network_context_ = std::make_unique<network::NetworkContext>( + network_service_.get(), + network_context_remote.BindNewPipeAndPassReceiver(), + std::move(network_context_params)); + + auto url_loader_factory_params = + network::mojom::URLLoaderFactoryParams::New(); + url_loader_factory_params->process_id = network::mojom::kBrowserProcessId; + url_loader_factory_params->is_corb_enabled = false; + network_context_->CreateURLLoaderFactory( + url_loader_factory_.BindNewPipeAndPassReceiver(), + std::move(url_loader_factory_params)); + shared_url_loader_factory_ = + base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>( + url_loader_factory_.get()); + + DCHECK(agg_service); + agg_service->SetURLLoaderFactory(shared_url_loader_factory_); +} + +ToolNetworkInitializer::~ToolNetworkInitializer() = default; + +} // namespace aggregation_service
\ No newline at end of file diff --git a/chromium/tools/aggregation_service/aggregation_service_tool_network_initializer.h b/chromium/tools/aggregation_service/aggregation_service_tool_network_initializer.h new file mode 100644 index 00000000000..ca620b03647 --- /dev/null +++ b/chromium/tools/aggregation_service/aggregation_service_tool_network_initializer.h @@ -0,0 +1,40 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef TOOLS_AGGREGATION_SERVICE_AGGREGATION_SERVICE_TOOL_NETWORK_INITIALIZER_H_ +#define TOOLS_AGGREGATION_SERVICE_AGGREGATION_SERVICE_TOOL_NETWORK_INITIALIZER_H_ + +#include <memory> + +#include "base/memory/scoped_refptr.h" +#include "content/public/test/test_aggregation_service.h" +#include "mojo/public/cpp/bindings/remote.h" +#include "services/network/network_context.h" +#include "services/network/network_service.h" +#include "services/network/public/cpp/shared_url_loader_factory.h" +#include "services/network/public/mojom/url_loader_factory.mojom.h" + +namespace aggregation_service { + +// This class is responsible for initializing network states. The object should +// be kept alive for the duration of network usage. +class ToolNetworkInitializer { + public: + // `agg_service` must be a non-null pointer to a TestAggregationService. + explicit ToolNetworkInitializer(content::TestAggregationService* agg_service); + ToolNetworkInitializer(const ToolNetworkInitializer& other) = delete; + ToolNetworkInitializer& operator=(const ToolNetworkInitializer& other) = + delete; + ~ToolNetworkInitializer(); + + private: + std::unique_ptr<network::NetworkService> network_service_; + std::unique_ptr<network::NetworkContext> network_context_; + mojo::Remote<network::mojom::URLLoaderFactory> url_loader_factory_; + scoped_refptr<network::SharedURLLoaderFactory> shared_url_loader_factory_; +}; + +} // namespace aggregation_service + +#endif // TOOLS_AGGREGATION_SERVICE_AGGREGATION_SERVICE_TOOL_NETWORK_INITIALIZER_H_
\ No newline at end of file diff --git a/chromium/tools/binary_size/BUILD.gn b/chromium/tools/binary_size/BUILD.gn index 383ab115e57..df429e23385 100644 --- a/chromium/tools/binary_size/BUILD.gn +++ b/chromium/tools/binary_size/BUILD.gn @@ -18,7 +18,10 @@ python_library("binary_size_trybot_py") { python_library("sizes_py") { testonly = true pydeps_file = "sizes.pydeps" - data_deps = [ "//third_party/catapult/tracing:convert_chart_json" ] + data_deps = [ + "//build/util:test_results", + "//third_party/catapult/tracing:convert_chart_json", + ] } if (is_linux) { diff --git a/chromium/tools/binary_size/PRESUBMIT.py b/chromium/tools/binary_size/PRESUBMIT.py index d8901f8140f..25f8e7b949e 100644 --- a/chromium/tools/binary_size/PRESUBMIT.py +++ b/chromium/tools/binary_size/PRESUBMIT.py @@ -13,7 +13,8 @@ USE_PYTHON3 = True def CommonChecks(input_api, output_api): output = [] - output.extend(input_api.canned_checks.RunPylint(input_api, output_api)) + output.extend( + input_api.canned_checks.RunPylint(input_api, output_api, version='2.6')) py_tests = input_api.canned_checks.GetUnitTestsRecursively( input_api, output_api, @@ -21,7 +22,8 @@ def CommonChecks(input_api, output_api): files_to_check=[r'.+_test\.py$'], files_to_skip=[], run_on_python2=False, - run_on_python3=True) + run_on_python3=True, + skip_shebang_check=True) output.extend(input_api.RunTests(py_tests, False)) diff --git a/chromium/tools/binary_size/diagnose_bloat.py b/chromium/tools/binary_size/diagnose_bloat.py index 4e6a244ddc4..c47633c6a4c 100755 --- a/chromium/tools/binary_size/diagnose_bloat.py +++ b/chromium/tools/binary_size/diagnose_bloat.py @@ -44,7 +44,7 @@ _GN_PATH = os.path.join(_SRC_ROOT, 'third_party', 'depot_tools', 'gn') _DiffResult = collections.namedtuple('DiffResult', ['name', 'value', 'units']) -class BaseDiff(object): +class BaseDiff: """Base class capturing binary size diffs.""" def __init__(self, name): self.name = name @@ -96,7 +96,7 @@ class NativeDiff(BaseDiff): self._size_name = size_name self._supersize_path = supersize_path self._diff = [] - super(NativeDiff, self).__init__('Native Diff') + super().__init__('Native Diff') @property def summary_stat(self): @@ -131,7 +131,7 @@ class ResourceSizesDiff(BaseDiff): self._diff = None # Set by |ProduceDiff()| self._filename = filename self._include_sections = include_sections - super(ResourceSizesDiff, self).__init__('Resource Sizes Diff') + super().__init__('Resource Sizes Diff') @property def summary_stat(self): @@ -230,7 +230,7 @@ class ResourceSizesDiff(BaseDiff): return ret -class _BuildHelper(object): +class _BuildHelper: """Helper class for generating and building targets.""" def __init__(self, args): self.clean = args.clean @@ -401,7 +401,7 @@ class _BuildHelper(object): return self.target_os == 'linux' -class _BuildArchive(object): +class _BuildArchive: """Class for managing a directory with build results and build metadata.""" def __init__(self, rev, base_archive_dir, build, subrepo, save_unstripped): @@ -478,7 +478,7 @@ class _BuildArchive(object): _RunCmd(supersize_cmd) -class _DiffArchiveManager(object): +class _DiffArchiveManager: """Class for maintaining BuildArchives and their related diff artifacts.""" def __init__(self, revs, archive_dir, diffs, build, subrepo, save_unstripped): @@ -622,7 +622,7 @@ class _DiffArchiveManager(object): return diff_path -class _Metadata(object): +class _Metadata: def __init__(self, archives, build, path, subrepo): self.data = { @@ -982,6 +982,8 @@ def main(): 0, i, is_internal=args.enable_chrome_android_internal) diff_mngr.Summarize() + return 0 + if __name__ == '__main__': sys.exit(main()) diff --git a/chromium/tools/binary_size/generate_milestone_reports.py b/chromium/tools/binary_size/generate_milestone_reports.py index 2fbba0dc484..d209a3fe2a9 100755 --- a/chromium/tools/binary_size/generate_milestone_reports.py +++ b/chromium/tools/binary_size/generate_milestone_reports.py @@ -84,7 +84,9 @@ _DESIRED_VERSIONS = [ '89.0.4389.105', '90.0.4430.82', '91.0.4472.120', - '92.0.4515.70', # Beta + '92.0.4515.70', + '93.0.4577.37', + '94.0.4606.6', ] diff --git a/chromium/tools/binary_size/libsupersize/apkanalyzer.py b/chromium/tools/binary_size/libsupersize/apkanalyzer.py index e40f6822893..226fd348e36 100644 --- a/chromium/tools/binary_size/libsupersize/apkanalyzer.py +++ b/chromium/tools/binary_size/libsupersize/apkanalyzer.py @@ -226,6 +226,7 @@ class LambdaNormalizer: 'No valid match for new lambda name format: ' + class_path + '\n' 'Please update https://crbug.com/1208385 with this error so we can ' 'update the lambda normalization code.') + return None # Visible for testing. diff --git a/chromium/tools/binary_size/libsupersize/archive.py b/chromium/tools/binary_size/libsupersize/archive.py index db62c31a7ce..22c4fd27973 100644 --- a/chromium/tools/binary_size/libsupersize/archive.py +++ b/chromium/tools/binary_size/libsupersize/archive.py @@ -31,6 +31,7 @@ import ar import data_quality import demangle import describe +import dwarfdump import file_format import function_signature import linker_map_parser @@ -55,6 +56,14 @@ _OWNERS_FILENAME = 'OWNERS' _OWNERS_COMPONENT_REGEX = re.compile(r'^\s*#\s*COMPONENT:\s*(\S+)', re.MULTILINE) _OWNERS_FILE_PATH_REGEX = re.compile(r'^\s*file://(\S+)', re.MULTILINE) +# Paths that are missing metadata, and where it's hard to add (e.g. code in +# other repositories. +_COMPONENT_DEFAULTS = { + os.path.join('third_party', 'webrtc'): 'Blink>WebRTC', + os.path.join('logging', 'rtc_event_log'): 'Blink>WebRTC', + os.path.join('modules', 'audio_codec'): 'Blink>WebRTC', + os.path.join('modules', 'audio_processing'): 'Blink>WebRTC', +} _UNCOMPRESSED_COMPRESSION_RATIO_THRESHOLD = 0.9 @@ -76,7 +85,7 @@ _SECTION_SIZE_BLOCKLIST = ['.symtab', '.shstrtab', '.strtab'] # Tunable constant "knobs" for CreateContainerAndSymbols(). -class SectionSizeKnobs(object): +class SectionSizeKnobs: def __init__(self): # A limit on the number of symbols an address can have, before these symbols # are compacted into shared symbols. Increasing this value causes more data @@ -283,38 +292,51 @@ def _NormalizeSourcePath(path): return True, path -def _ExtractSourcePathsAndNormalizeObjectPaths(raw_symbols, source_mapper): +def _ExtractSourcePathsAndNormalizeObjectPaths(raw_symbols, + object_source_mapper, + address_source_mapper): """Fills in the |source_path| attribute and normalizes |object_path|.""" - logging.info('Normalizing dex symbol paths') - dex_and_other = models.DEX_SECTIONS + (models.SECTION_OTHER, ) - for symbol in raw_symbols: - if symbol.source_path and symbol.section_name in dex_and_other: - symbol.generated_source, symbol.source_path = _NormalizeSourcePath( - symbol.source_path) - - if source_mapper: + if object_source_mapper: logging.info('Looking up source paths from ninja files') for symbol in raw_symbols: if symbol.IsDex() or symbol.IsOther(): continue # Native symbols and pak symbols use object paths. object_path = symbol.object_path - if object_path: - # We don't have source info for prebuilt .a files. - if not os.path.isabs(object_path) and not object_path.startswith('..'): - source_path = source_mapper.FindSourceForPath(object_path) - if source_path: - symbol.generated_source, symbol.source_path = ( - _NormalizeSourcePath(source_path)) - symbol.object_path = _NormalizeObjectPath(object_path) - assert source_mapper.unmatched_paths_count == 0, ( + if not object_path: + continue + + # We don't have source info for prebuilt .a files. + if not os.path.isabs(object_path) and not object_path.startswith('..'): + symbol.source_path = object_source_mapper.FindSourceForPath(object_path) + assert object_source_mapper.unmatched_paths_count == 0, ( 'One or more source file paths could not be found. Likely caused by ' '.ninja files being generated at a different time than the .map file.') - else: - logging.info('Normalizing object paths') + if address_source_mapper: + logging.info('Looking up source paths from dwarfdump') for symbol in raw_symbols: - if symbol.object_path: - symbol.object_path = _NormalizeObjectPath(symbol.object_path) + + if symbol.section_name != models.SECTION_TEXT: + continue + source_path = address_source_mapper.FindSourceForTextAddress( + symbol.address) + if source_path and not os.path.isabs(source_path): + symbol.source_path = source_path + # Majority of unmatched queries are for assembly source files (ex libav1d) + # and v8 builtins. + assert address_source_mapper.unmatched_queries_ratio < 0.03, ( + 'Percentage of failing |address_source_mapper| queries ' + + '({}%) >= 3% '.format( + address_source_mapper.unmatched_queries_ratio * 100) + + 'FindSourceForTextAddress() likely has a bug.') + + logging.info('Normalizing source and object paths') + for symbol in raw_symbols: + if symbol.object_path: + symbol.object_path = _NormalizeObjectPath(symbol.object_path) + if symbol.source_path: + symbol.generated_source, symbol.source_path = _NormalizeSourcePath( + symbol.source_path) def _ComputeAncestorPath(path_list, symbol_count): @@ -647,7 +669,7 @@ def _PopulateComponents(raw_symbols, source_directory): raw_symbols: list of Symbol objects. source_directory: Directory to use as the root. """ - seen_paths = {} + seen_paths = _COMPONENT_DEFAULTS.copy() for symbol in raw_symbols: if symbol.source_path: folder_path = os.path.dirname(symbol.source_path) @@ -961,7 +983,7 @@ def _ParseElfInfo(map_path, elf_path, tool_prefix, track_string_literals, # single path for these symbols. # Rather than record all paths for each symbol, set the paths to be the # common ancestor of all paths. - if outdir_context: + if outdir_context and map_path: bulk_analyzer = obj_analyzer.BulkObjectFileAnalyzer( tool_prefix, outdir_context.output_directory, track_string_literals=track_string_literals) @@ -980,7 +1002,7 @@ def _ParseElfInfo(map_path, elf_path, tool_prefix, track_string_literals, raw_symbols = nm.CreateUniqueSymbols(elf_path, tool_prefix, elf_section_ranges) - if map_path and elf_path: + if elf_path and map_path: logging.debug('Validating section sizes') differing_elf_section_sizes = {} differing_map_section_sizes = {} @@ -997,14 +1019,14 @@ def _ParseElfInfo(map_path, elf_path, tool_prefix, track_string_literals, logging.error('.map file: %r', differing_map_section_sizes) sys.exit(1) - if elf_path and outdir_context: + if elf_path and map_path and outdir_context: missed_object_paths = _DiscoverMissedObjectPaths( raw_symbols, outdir_context.known_inputs) missed_object_paths = ar.ExpandThinArchives( missed_object_paths, outdir_context.output_directory)[0] bulk_analyzer.AnalyzePaths(missed_object_paths) bulk_analyzer.SortPaths() - if track_string_literals and map_path: + if track_string_literals: merge_string_syms = [s for s in raw_symbols if s.full_name == '** merge strings' or s.full_name == '** lld merge strings'] @@ -1028,7 +1050,7 @@ def _ParseElfInfo(map_path, elf_path, tool_prefix, track_string_literals, raw_symbols = _AddNmAliases(raw_symbols, names_by_address) - if outdir_context: + if map_path and outdir_context: object_paths_by_name = bulk_analyzer.GetSymbolNames() logging.debug( 'Fetched path information for %d symbols from %d files', @@ -1128,7 +1150,7 @@ def _IsPakContentUncompressed(content): return compression_ratio < _UNCOMPRESSED_COMPRESSION_RATIO_THRESHOLD -class _ResourceSourceMapper(object): +class _ResourceSourceMapper: def __init__(self, size_info_prefix, knobs): self._knobs = knobs self._res_info = self._LoadResInfo(size_info_prefix) @@ -1245,7 +1267,7 @@ def _ParseApkElfSectionRanges(section_ranges, metadata, apk_elf_result): return apk_section_ranges, elf_overhead_size -class _ResourcePathDeobfuscator(object): +class _ResourcePathDeobfuscator: def __init__(self, pathmap_path): self._pathmap = self._LoadResourcesPathmap(pathmap_path) @@ -1588,13 +1610,20 @@ def CreateContainerAndSymbols(knobs=None, apk_elf_result = None outdir_context = None - source_mapper = None + object_source_mapper = None + address_source_mapper = None section_ranges = {} raw_symbols = [] if opts.analyze_native and output_directory: - # Finds all objects passed to the linker and creates a map of .o -> .cc. - source_mapper, ninja_elf_object_paths = _ParseNinjaFiles( - output_directory, elf_path) + if map_path: + # Finds all objects passed to the linker and creates a map of .o -> .cc. + object_source_mapper, ninja_elf_object_paths = _ParseNinjaFiles( + output_directory, elf_path) + else: + ninja_elf_object_paths = None + logging.info('Parsing source path info via dwarfdump') + address_source_mapper = dwarfdump.CreateAddressSourceMapper( + elf_path, tool_prefix) # Start by finding elf_object_paths so that nm can run on them while the # linker .map is being parsed. @@ -1604,12 +1633,12 @@ def CreateContainerAndSymbols(knobs=None, known_inputs = set(elf_object_paths) known_inputs.update(ninja_elf_object_paths) else: - elf_object_paths = None + elf_object_paths = [] known_inputs = None # When we don't know which elf file is used, just search all paths. - if opts.analyze_native: + if opts.analyze_native and object_source_mapper: thin_archives = set( - p for p in source_mapper.IterAllPaths() if p.endswith('.a') + p for p in object_source_mapper.IterAllPaths() if p.endswith('.a') and ar.IsThinArchive(os.path.join(output_directory, p))) else: thin_archives = None @@ -1715,7 +1744,8 @@ def CreateContainerAndSymbols(knobs=None, '**'), s.address, s.full_name)) raw_symbols.extend(other_symbols) - _ExtractSourcePathsAndNormalizeObjectPaths(raw_symbols, source_mapper) + _ExtractSourcePathsAndNormalizeObjectPaths(raw_symbols, object_source_mapper, + address_source_mapper) _PopulateComponents(raw_symbols, source_directory) logging.info('Converting excessive aliases into shared-path symbols') _CompactLargeAliasesIntoSharedSymbols(raw_symbols, knobs) @@ -1999,7 +2029,7 @@ def ParseSsargs(lines): def _DeduceNativeInfo(tentative_output_dir, apk_path, elf_path, map_path, - ignore_linker_map, on_config_error): + ignore_linker_map, tool_prefix, on_config_error): apk_so_path = None if apk_path: with zipfile.ZipFile(apk_path) as z: @@ -2030,7 +2060,7 @@ def _DeduceNativeInfo(tentative_output_dir, apk_path, elf_path, map_path, on_config_error('Found unexpected _partition.so: ' + elf_path) if not ignore_linker_map: - if _ElfIsMainPartition(elf_path, ''): + if _ElfIsMainPartition(elf_path, tool_prefix): map_path = elf_path.replace('.so', '__combined.so') + '.map' else: map_path = elf_path + '.map' @@ -2114,12 +2144,17 @@ def _ProcessContainerArgs(top_args, sub_args, container_name, on_config_error): if not is_base_module: opts.analyze_native = False else: + tool_prefix_finder = path_util.ToolPrefixFinder( + value=sub_args.tool_prefix, + output_directory=top_args.output_directory, + linker_name='lld') sub_args.elf_file, sub_args.map_file, apk_so_path = _DeduceNativeInfo( tentative_output_dir=top_args.output_directory, apk_path=sub_args.apk_file, elf_path=sub_args.elf_file or sub_args.aux_elf_file, map_path=sub_args.map_file, ignore_linker_map=sub_args.ignore_linker_map, + tool_prefix=tool_prefix_finder.Finalized(), on_config_error=on_config_error) if sub_args.ignore_linker_map: @@ -2155,7 +2190,7 @@ def _ProcessContainerArgs(top_args, sub_args, container_name, on_config_error): if not sub_args.elf_file and not sub_args.map_file: opts.analyze_native = False - container_args = {k: v for k, v in sub_args.__dict__.items()} + container_args = sub_args.__dict__.copy() container_args.update(opts.__dict__) logging.info('Container Params: %r', container_args) return (sub_args, opts, container_name, apk_so_path, resources_pathmap_path, diff --git a/chromium/tools/binary_size/libsupersize/bcanalyzer.py b/chromium/tools/binary_size/libsupersize/bcanalyzer.py index 50bed857756..8473059884c 100755 --- a/chromium/tools/binary_size/libsupersize/bcanalyzer.py +++ b/chromium/tools/binary_size/libsupersize/bcanalyzer.py @@ -140,7 +140,7 @@ def _UnpackUint32ListToBytes(items): yield (item >> 24) & 0xFF -class _BcIntArrayType(object): +class _BcIntArrayType: """The specs of an integer array type.""" # Lookup table to map from width to an unpacker that splits ints into bytes. @@ -177,7 +177,7 @@ class _BcIntArrayType(object): return s -class _BcTypeInfo(object): +class _BcTypeInfo: """Stateful parser of <TYPE_BLOCK_ID>, specialized for integer arrays.""" # <TYPE_BLOCK_ID NumWords=103 BlockCodeSize=4> @@ -310,8 +310,11 @@ def _ParseBcAnalyzer(lines): if _IsClosingTag(tag_type) and tag == 'CONSTANTS_BLOCK': # Skip remaining data, including subsequent <CONSTANTS_BLOCK>s. break - elif tag == 'SETTYPE': - consts_cur_type_id = next(_ParseOpItems(line, attrib_pos)) # op0. + if tag == 'SETTYPE': + try: + consts_cur_type_id = next(_ParseOpItems(line, attrib_pos)) # op0. + except StopIteration: + return consts_cur_type = type_info.GetArrayType(consts_cur_type_id) elif consts_cur_type and consts_cur_type.width <= _CHAR_WIDTH_LIMIT: if tag in ['CSTRING', 'STRING', 'DATA']: @@ -322,7 +325,7 @@ def _ParseBcAnalyzer(lines): yield (consts_cur_type, s) -class _BcAnalyzerRunner(object): +class _BcAnalyzerRunner: """Helper to run bcanalyzer and extract output lines. """ def __init__(self, tool_prefix, output_directory): self._args = [path_util.GetBcAnalyzerPath(tool_prefix), '--dump', diff --git a/chromium/tools/binary_size/libsupersize/canned_queries.py b/chromium/tools/binary_size/libsupersize/canned_queries.py index 4e847604880..459aa68f5c9 100644 --- a/chromium/tools/binary_size/libsupersize/canned_queries.py +++ b/chromium/tools/binary_size/libsupersize/canned_queries.py @@ -10,13 +10,13 @@ import re import models -class _Grouper(object): +class _Grouper: def __init__(self): self.groups = [] def Add(self, name, group): logging.debug('Computed %s (%d syms)', name, len(group)) - if len(group): + if group: sorted_group = group.Sorted() sorted_group.SetName(name) self.groups.append(sorted_group) @@ -158,7 +158,7 @@ def _CategorizeGenerated(symbols): return g.Finalize(symbols) -class CannedQueries(object): +class CannedQueries: """A set of pre-written queries.""" def __init__(self, size_infos): diff --git a/chromium/tools/binary_size/libsupersize/console.py b/chromium/tools/binary_size/libsupersize/console.py index 52ebcac723b..4001f70db50 100644 --- a/chromium/tools/binary_size/libsupersize/console.py +++ b/chromium/tools/binary_size/libsupersize/console.py @@ -81,7 +81,7 @@ def _ReadlineSession(): readline.write_history_file(history_file) -class _Session(object): +class _Session: def __init__(self, size_infos, output_directory_finder, tool_prefix_finder): self._printed_variables = [] @@ -309,9 +309,9 @@ class _Session(object): paths_to_try = [p for p in paths_to_try if os.path.exists(p)] - for i, elf_path in enumerate(paths_to_try): - if build_id_matches(elf_path): - return elf_path + for i, path in enumerate(paths_to_try): + if build_id_matches(path): + return path # Show an error only once all paths are tried. if i + 1 == len(paths_to_try): @@ -322,12 +322,14 @@ class _Session(object): '--output-directory is set. If output directory is unavailable, ' 'ensure {} is located beside {}, or pass its path explicitly using ' 'elf_path=').format(os.path.basename(filename), size_info.size_path) + return None def _SizeInfoForSymbol(self, symbol): for size_info in self._size_infos: if symbol in size_info.raw_symbols: return size_info assert False, 'Symbol does not belong to a size_info.' + return None def _DisassembleFunc(self, symbol, elf_path=None, use_pager=None, to_file=None): @@ -491,7 +493,7 @@ class _Session(object): if isinstance(value, types.ModuleType): continue if key.startswith('size_info'): - lines.append(' {}: Loaded from {}'.format(key, value.size_path)) + lines.append(' {}: Loaded from {}'.format(key, value.size_path)) # pylint: disable=no-member lines.append('*' * 80) return '\n'.join(lines) diff --git a/chromium/tools/binary_size/libsupersize/data_quality.py b/chromium/tools/binary_size/libsupersize/data_quality.py index 4bed5925e86..85ab58e274d 100644 --- a/chromium/tools/binary_size/libsupersize/data_quality.py +++ b/chromium/tools/binary_size/libsupersize/data_quality.py @@ -10,8 +10,7 @@ import os class QualityCheckError(Exception): def __init__(self, msg): - super(QualityCheckError, - self).__init__('--check-data-quality assertion failed: ' + msg) + super().__init__('--check-data-quality assertion failed: ' + msg) def CheckDataQuality(size_info, track_string_literals): @@ -169,7 +168,7 @@ def _DescribeSizeInfoContainerCoverage(raw_symbols, container): yield '* {} have a component assigned. {}'.format(len(syms), size_msg(syms)) syms = in_section.WhereNameMatches(r'^\*') - if len(syms): + if syms: yield '* {} placeholders exist (symbols that start with **). {}'.format( len(syms), size_msg(syms)) @@ -184,7 +183,7 @@ def _DescribeSizeInfoContainerCoverage(raw_symbols, container): len(syms), size_msg(syms, show_padding=True)) syms = in_section.Filter(lambda s: s.aliases) - if len(syms): + if syms: uniques = sum(1 for s in syms.IterUniqueSymbols()) saved = sum(s.size_without_padding * (s.num_aliases - 1) for s in syms.IterUniqueSymbols()) @@ -192,7 +191,7 @@ def _DescribeSizeInfoContainerCoverage(raw_symbols, container): '({} bytes saved)').format(len(syms), uniques, saved) syms = in_section.WhereObjectPathMatches('{shared}') - if len(syms): + if syms: yield '* {} symbols have shared ownership. {}'.format( len(syms), size_msg(syms)) else: @@ -205,7 +204,7 @@ def _DescribeSizeInfoContainerCoverage(raw_symbols, container): (models.FLAG_GENERATED_SOURCE, 'from generated sources')): syms = in_section.WhereHasFlag(flag) - if len(syms): + if syms: yield '* {} symbols are {}. {}'.format(len(syms), desc, size_msg(syms)) spam_counter = 0 diff --git a/chromium/tools/binary_size/libsupersize/demangle.py b/chromium/tools/binary_size/libsupersize/demangle.py index 6247408cc8e..7476da1bef8 100644 --- a/chromium/tools/binary_size/libsupersize/demangle.py +++ b/chromium/tools/binary_size/libsupersize/demangle.py @@ -118,6 +118,8 @@ def DemangleSetsInDictsInPlace(key_to_names, tool_prefix): key_to_names[key] = set(next(it) if _CanDemangle(n) else n for n in names) assert(next(it, None) is None) + return None + def DemangleKeysAndMergeLists(name_to_list, tool_prefix): """Demangles keys of a dict of lists, and returns the result. diff --git a/chromium/tools/binary_size/libsupersize/describe.py b/chromium/tools/binary_size/libsupersize/describe.py index b4ddb675e3d..de87d684e77 100644 --- a/chromium/tools/binary_size/libsupersize/describe.py +++ b/chromium/tools/binary_size/libsupersize/describe.py @@ -24,9 +24,9 @@ def _PrettySize(size): size /= 1024.0 if abs(size) < 10: return '%.2fkb' % size - elif abs(size) < 100: + if abs(size) < 100: return '%.1fkb' % size - elif abs(size) < 1024: + if abs(size) < 1024: return '%dkb' % size size /= 1024.0 if abs(size) < 10: @@ -74,7 +74,7 @@ def _GetSectionSizeInfo(unsummed_sections, summed_sections, section_sizes): return (total_bytes, section_names) -class Histogram(object): +class Histogram: BUCKET_NAMES_FOR_SMALL_VALUES = {-1: '(-1,0)', 0: '{0}', 1: '(0,1)'} def __init__(self): @@ -127,7 +127,7 @@ class Histogram(object): yield line.rstrip() -class Describer(object): +class Describer: def __init__(self): pass @@ -173,7 +173,7 @@ class Describer(object): class DescriberText(Describer): def __init__(self, verbose=False, recursive=False, summarize=True): - super(DescriberText, self).__init__() + super().__init__() self.verbose = verbose self.recursive = recursive self.summarize = summarize @@ -446,15 +446,15 @@ class DescriberText(Describer): yield '{} paths added, {} removed, {} changed'.format( len(added), len(removed), len(changed)) - if self.verbose and len(added): + if self.verbose and added: yield 'Added files:' for p in sorted(added): yield ' ' + p - if self.verbose and len(removed): + if self.verbose and removed: yield 'Removed files:' for p in sorted(removed): yield ' ' + p - if self.verbose and len(changed): + if self.verbose and changed: yield 'Changed files:' for p in sorted(changed): yield ' ' + p @@ -599,7 +599,7 @@ class DescriberText(Describer): class DescriberCsv(Describer): def __init__(self, verbose=False): - super(DescriberCsv, self).__init__() + super().__init__() self.verbose = verbose self.stringio = io.StringIO() self.csv_writer = csv.writer(self.stringio) diff --git a/chromium/tools/binary_size/libsupersize/dwarfdump.py b/chromium/tools/binary_size/libsupersize/dwarfdump.py new file mode 100755 index 00000000000..de6cf0743d5 --- /dev/null +++ b/chromium/tools/binary_size/libsupersize/dwarfdump.py @@ -0,0 +1,195 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""Runs dwarfdump on passed-in .so.""" + +import bisect +import dataclasses +import subprocess +import typing + +import path_util + + +@dataclasses.dataclass(order=True) +class _AddressRange: + start: int + stop: int + + +class _SourceMapper: + def __init__(self, range_info_list): + self._range_info_list = range_info_list + self._largest_address = 0 + self._unmatched_queries_count = 0 + self._total_queries_count = 0 + + if self._range_info_list: + self._largest_address = self._range_info_list[-1][0].stop + + def FindSourceForTextAddress(self, address): + """Returns source file path matching passed-in symbol address. + + Only symbols in the .text section of the elf file are supported. + """ + self._total_queries_count += 1 + # Bisect against stop = self._largest_address + 1 to avoid bisecting against + # the "source path" tuple component. + bisect_index = bisect.bisect_right( + self._range_info_list, + (_AddressRange(address, self._largest_address + 1), '')) - 1 + if bisect_index >= 0: + info = self._range_info_list[bisect_index] + if info[0].start <= address < info[0].stop: + return info[1] + + self._unmatched_queries_count += 1 + return None + + @property + def unmatched_queries_ratio(self): + return self._unmatched_queries_count / self._total_queries_count + + +def CreateAddressSourceMapper(elf_path, tool_prefix): + """Runs dwarfdump. Returns object for querying source path given address.""" + return _SourceMapper(_Parse(elf_path, tool_prefix)) + + +def CreateAddressSourceMapperForTest(lines): + return _SourceMapper(_ParseDumpOutput(lines)) + + +def ParseDumpOutputForTest(lines): + return _ParseDumpOutput(lines) + + +def _Parse(elf_path, tool_prefix): + cmd = [ + path_util.GetDwarfdumpPath(tool_prefix), + elf_path, + '--debug-info', + '--summarize-types', + '--recurse-depth=0', + ] + stdout = subprocess.check_output(cmd, + stderr=subprocess.DEVNULL, + encoding='utf-8') + return _ParseDumpOutput(stdout.splitlines()) + + +def _ParseDumpOutput(lines): + """Parses passed-in dwarfdump stdout.""" + + # List of (_AddressRange, source path) tuples. + range_info_list = [] + + line_it = iter(lines) + line = next(line_it, None) + while line is not None: + if 'DW_TAG_compile_unit' not in line: + line = next(line_it, None) + continue + + line, address_ranges, source_path = _ParseCompileUnit(line_it) + if source_path and address_ranges: + for address_range in address_ranges: + range_info_list.append((address_range, source_path)) + + return sorted(range_info_list) + + +def _ParseCompileUnit(line_it): + """Parses DW_AT_compile_unit block. + + Example: + 0x000026: DW_AT_compile_unit + DW_AT_low_pc (0x02f) + DW_AT_high_pc (0x03f) + DW_AT_name (foo.cc) + """ + source_path = None + single_range = _AddressRange(0, 0) + range_addresses = [] + + while True: + line = next(line_it, None) + + dw_index = 0 if line is None else line.find('DW_') + if dw_index < 0: + continue + + if line is None or line.startswith('DW_TAG', dw_index): + if range_addresses: + # If compile unit specifies both DW_AT_ranges and DW_AT_low_pc, + # DW_AT_low_pc is base offset. Base offset is currently unsupported. + assert single_range.start == 0 + elif single_range.start > 0: + range_addresses.append(single_range) + return (line, range_addresses, source_path) + + if line.startswith('DW_AT_low_pc', dw_index): + single_range.start = int(_ExtractDwValue(line), 16) + if single_range.stop == 0: + single_range.stop = single_range.start + 1 + continue + if line.startswith('DW_AT_high_pc', dw_index): + single_range.stop = int(_ExtractDwValue(line), 16) + continue + if line.startswith('DW_AT_name', dw_index): + source_path = _ExtractDwValue(line) + continue + + if line.startswith('DW_AT_ranges', dw_index): + range_addresses = _ParseRanges(line_it) + + +def _ParseRanges(line_it): + """Parses DW_AT_ranges from dwarfdump stdout. + + Example: + [0x1, 0x2) + [0x5, 0x10)) + """ + range_addresses = [] + + line = next(line_it, None) + while line is not None: + num_opening_brackets = line.count('(') + line.count('[') + num_closing_brackets = line.count(')') + line.count(']') + + tokens = line.strip('([]) \t').split(',') + if len(tokens) == 2: + start_address = int(tokens[0], 16) + end_address = int(tokens[1], 16) + # Dwarf spec does not assign special meaning to empty ranges. + if start_address != end_address: + range_addresses.append(_AddressRange(start_address, end_address)) + + if num_closing_brackets > num_opening_brackets: + break + line = next(line_it, None) + + return range_addresses + + +def _ExtractDwValue(line): + """Extract DW_AT_ value from dwarfdump stdout. + + Examples: + DW_AT_name ("foo.cc") + DW_AT_decl_line (177) + DW_AT_low_pc (0x2) + """ + lparen_index = line.rfind('(') + if lparen_index < 0: + return None + rparen_index = line.find(')', lparen_index + 1) + if rparen_index < 0: + return None + if (lparen_index < rparen_index - 2 and line[lparen_index + 1] == '"' + and line[rparen_index - 1] == '"'): + lparen_index += 1 + rparen_index -= 1 + return line[lparen_index + 1:rparen_index] diff --git a/chromium/tools/binary_size/libsupersize/dwarfdump_test.py b/chromium/tools/binary_size/libsupersize/dwarfdump_test.py new file mode 100755 index 00000000000..b2f8aa2a08f --- /dev/null +++ b/chromium/tools/binary_size/libsupersize/dwarfdump_test.py @@ -0,0 +1,182 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import unittest + +import dwarfdump + + +class DwarfDumpTest(unittest.TestCase): + def _MakeRangeInfoList(self, flat_list): + out = [] + for item in flat_list: + assert len(item) == 3 + out.append((dwarfdump._AddressRange(item[0], item[1]), item[2])) + return out + + def testParseNonContiguousAddressRange(self): + """Test parsing DW_TAG_compile_unit with non-contiguous address range.""" + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("solution.cc")', + 'DW_AT_low_pc (0x0)', + 'DW_AT_ranges (0x1', + '[0x10, 0x21)', + '[0x31, 0x41))', + ] + expected_info_list = [(0x10, 0x21, 'solution.cc'), + (0x31, 0x41, 'solution.cc')] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testParseNonContiguousAddressRangeOtherBrackets(self): + """Test parsing DW_AT_ranges when non-standard brackets are used.""" + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("solution.cc")', + 'DW_AT_low_pc (0x0)', + 'DW_AT_ranges [0x1', + '(0x10, 0x21)', + '[0x31, 0x41]]', + ] + expected_info_list = [(0x10, 0x21, 'solution.cc'), + (0x31, 0x41, 'solution.cc')] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testParseNonContiguousIgnoreEmptyRanges(self): + """Test that empty ranges are ignored when parsing DW_AT_ranges.""" + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("solution.cc")', + 'DW_AT_ranges (0x1', + '[0x1, 0x1)', + '[0x10, 0x21)', + '[0x22, 0x22)', + '[0x31, 0x41)', + '[0x42, 0x42))', + ] + expected_info_list = [(0x10, 0x21, 'solution.cc'), + (0x31, 0x41, 'solution.cc')] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testParseContiguousAddressRange(self): + """Test parsing DW_TAG_compile_unit with contiguous address range.""" + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("solution.cc")', + 'DW_AT_low_pc (0x1)', + 'DW_AT_high_pc (0x10)', + ] + expected_info_list = [ + (0x1, 0x10, 'solution.cc'), + ] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testParseSingleAddress(self): + """Test parsing DW_TAG_compile_unit with single address.""" + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("solution.cc")', + 'DW_AT_low_pc (0x10)', + ] + expected_info_list = [ + (0x10, 0x11, 'solution.cc'), + ] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testParseEmptyCompileUnit(self): + """Test parsing empty DW_TAG_compile_unit.""" + lines = ['DW_TAG_compile_unit'] + self.assertEqual([], dwarfdump.ParseDumpOutputForTest(lines)) + + def testConsecutiveCompileUnits(self): + """Test parsing consecutive DW_TAG_compile_units.""" + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("foo.cc")', + 'DW_AT_low_pc (0x1)', + 'DW_AT_high_pc (0x10)', + 'DW_TAG_compile_unit', + 'DW_AT_name ("bar.cc")', + 'DW_AT_low_pc (0x12)', + 'DW_AT_high_pc (0x20)', + ] + expected_info_list = [(0x1, 0x10, 'foo.cc'), (0x12, 0x20, 'bar.cc')] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testTagTerminatedCompileUnit(self): + """Test parsing DW_TAG_compile_unit where compile unit is followed by a + non-DW_TAG_compile_unit entry. + """ + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("foo.cc")', + 'DW_AT_low_pc (0x1)', + 'DW_AT_high_pc (0x10)', + 'DW_TAG_subprogram', + 'DW_AT_name ("bar.cc")', + 'DW_AT_low_pc (0x12)', + 'DW_AT_high_pc (0x20)', + ] + expected_info_list = [ + (0x1, 0x10, 'foo.cc'), + ] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testHandlePrefixes(self): + """Test parsing DW_TAG_compile_unit where 'DW_' does not start line in + DW_TAG_compile_unit entry. + """ + lines = [ + '0x1 DW_TAG_compile_unit', + ' DW_AT_language (DW_LANG_C_plus_plus_14)', + ' DW_AT_name ("solution.cc")', + ' DW_AT_stmt_list (0x5)', + ' DW_AT_low_pc (0x1)', + ' DW_AT_high_pc (0x10)', + ] + expected_info_list = [ + (0x1, 0x10, 'solution.cc'), + ] + self.assertEqual(self._MakeRangeInfoList(expected_info_list), + dwarfdump.ParseDumpOutputForTest(lines)) + + def testFindAddress(self): + """Tests for _SourceMapper.FindSourceForTextAddress()""" + lines = [ + 'DW_TAG_compile_unit', + 'DW_AT_name ("foo.cc")', + 'DW_AT_low_pc (0x1)', + 'DW_AT_high_pc (0x10)', + 'DW_TAG_compile_unit', + 'DW_AT_name ("bar.cc")', + 'DW_AT_low_pc (0x21)', + 'DW_AT_high_pc (0x30)', + 'DW_TAG_compile_unit', + 'DW_AT_name ("baz.cc")', + 'DW_AT_low_pc (0x41)', + 'DW_AT_high_pc (0x50)', + ] + source_mapper = dwarfdump.CreateAddressSourceMapperForTest(lines) + # Address is before first range. + self.assertIsNone(source_mapper.FindSourceForTextAddress(0x0)) + # Address matches start of first range. + self.assertEqual('foo.cc', source_mapper.FindSourceForTextAddress(0x1)) + # Address is in the middle of middle range. + self.assertEqual('bar.cc', source_mapper.FindSourceForTextAddress(0x2a)) + # Address matches end of last range. + self.assertEqual('baz.cc', source_mapper.FindSourceForTextAddress(0x4f)) + # Address is after lange range. + self.assertIsNone(source_mapper.FindSourceForTextAddress(0x50)) + + +if __name__ == '__main__': + unittest.main() diff --git a/chromium/tools/binary_size/libsupersize/file_format.py b/chromium/tools/binary_size/libsupersize/file_format.py index 02e5d8ad708..5da6fca7f9a 100644 --- a/chromium/tools/binary_size/libsupersize/file_format.py +++ b/chromium/tools/binary_size/libsupersize/file_format.py @@ -774,6 +774,8 @@ def SaveDeltaSizeInfo(delta_size_info, path, file_obj=None): after_promise.get() w.WriteBytes(after_size_file.getvalue()) + return None + def LoadDeltaSizeInfo(path, file_obj=None): """Returns a tuple of size infos (before, after). diff --git a/chromium/tools/binary_size/libsupersize/function_signature.py b/chromium/tools/binary_size/libsupersize/function_signature.py index a328511f30b..d5d3ff643c4 100644 --- a/chromium/tools/binary_size/libsupersize/function_signature.py +++ b/chromium/tools/binary_size/libsupersize/function_signature.py @@ -213,7 +213,7 @@ def Parse(name): # there was a return value. name = _NormalizeTopLevelGccLambda(name, left_paren_idx) return Parse(name) - elif name_no_params.endswith('::__invoke') and '$' in name_no_params: + if name_no_params.endswith('::__invoke') and '$' in name_no_params: assert '$_' in name_no_params, 'Surprising lambda: ' + name name = _NormalizeTopLevelClangLambda(name, left_paren_idx) return Parse(name) diff --git a/chromium/tools/binary_size/libsupersize/html_report.py b/chromium/tools/binary_size/libsupersize/html_report.py index 2bd9c777e22..47d55369a27 100644 --- a/chromium/tools/binary_size/libsupersize/html_report.py +++ b/chromium/tools/binary_size/libsupersize/html_report.py @@ -52,7 +52,7 @@ def _GetOrAddFileNode(path, component, file_nodes, components): return file_node -class IndexedSet(object): +class IndexedSet: """Set-like object where values are unique and indexed. Values must be immutable. diff --git a/chromium/tools/binary_size/libsupersize/integration_test.py b/chromium/tools/binary_size/libsupersize/integration_test.py index 6fab8e8d9eb..3870655fb6e 100755 --- a/chromium/tools/binary_size/libsupersize/integration_test.py +++ b/chromium/tools/binary_size/libsupersize/integration_test.py @@ -328,10 +328,11 @@ class IntegrationTest(unittest.TestCase): archive_path, '--source-directory', _TEST_SOURCE_DIR, + '--tool-prefix', + _TEST_TOOL_PREFIX, ] if ignore_linker_map: args += ['--no-map-file'] - args += ['--tool-prefix', _TEST_TOOL_PREFIX] elif not use_ssargs: # --map-file ignored for use_ssargs. args += ['--map-file', _TEST_MAP_PATH] diff --git a/chromium/tools/binary_size/libsupersize/linker_map_parser.py b/chromium/tools/binary_size/libsupersize/linker_map_parser.py index 9f18ac372f6..6278ede0aeb 100755 --- a/chromium/tools/binary_size/libsupersize/linker_map_parser.py +++ b/chromium/tools/binary_size/libsupersize/linker_map_parser.py @@ -77,7 +77,7 @@ def _NormalizeName(name): return name -class MapFileParserGold(object): +class MapFileParserGold: """Parses a linker map file from gold linker.""" # Map file writer for gold linker: # https://github.com/gittup/binutils/blob/HEAD/gold/mapfile.cc @@ -107,7 +107,7 @@ class MapFileParserGold(object): self._common_symbols = self._ParseCommonSymbols() logging.debug('.bss common entries: %d', len(self._common_symbols)) continue - elif line.startswith('Memory map'): + if line.startswith('Memory map'): self._ParseSections() break return self._section_ranges, self._symbols, {} @@ -116,6 +116,7 @@ class MapFileParserGold(object): for l in self._lines: if l.startswith(prefix) or (prefix2 and l.startswith(prefix2)): return l + return None def _ParsePossiblyWrappedParts(self, line, count): parts = line.split(None, count - 1) @@ -254,9 +255,9 @@ class MapFileParserGold(object): # using addresses. We do this because fill lines are not # present when compiling with gcc (only for clang). continue - elif line.startswith(' **'): + if line.startswith(' **'): break - elif name is None: + if name is None: address_str2, name = self._ParsePossiblyWrappedParts(line, 2) if address_str == '0xffffffffffffffff': @@ -327,7 +328,7 @@ class MapFileParserGold(object): raise -class MapFileParserLld(object): +class MapFileParserLld: """Parses a linker map file from LLD.""" # Map file writer for LLD linker (for ELF): # https://github.com/llvm-mirror/lld/blob/HEAD/ELF/MapFile.cpp @@ -718,7 +719,7 @@ def DetectLinkerNameFromMapFile(lines): raise Exception('Invalid map file: ' + first_line) -class MapFileParser(object): +class MapFileParser: """Parses a linker map file generated from a specified linker.""" def Parse(self, linker_name, lines): """Parses a linker map file. diff --git a/chromium/tools/binary_size/libsupersize/main.py b/chromium/tools/binary_size/libsupersize/main.py index 3bbdd5e194d..1d4ca415fd2 100755 --- a/chromium/tools/binary_size/libsupersize/main.py +++ b/chromium/tools/binary_size/libsupersize/main.py @@ -35,7 +35,7 @@ def _AddCommonArguments(parser): help='Verbose level (multiple times for more)') -class _DiffAction(object): +class _DiffAction: @staticmethod def AddArguments(parser): parser.add_argument('before', help='Before-patch .size file.') @@ -62,7 +62,7 @@ class _DiffAction(object): console.Run(args, on_config_error) -class _SaveDiffAction(object): +class _SaveDiffAction: @staticmethod def AddArguments(parser): diff --git a/chromium/tools/binary_size/libsupersize/models.py b/chromium/tools/binary_size/libsupersize/models.py index db5a3c20dd0..6e7730b63c4 100644 --- a/chromium/tools/binary_size/libsupersize/models.py +++ b/chromium/tools/binary_size/libsupersize/models.py @@ -207,7 +207,7 @@ def ClassifySections(section_names): return frozenset(unsummed_sections), frozenset(summed_sections) -class BaseContainer(object): +class BaseContainer: """Base class for BaseContainer and DeltaContainer. Fields: @@ -239,6 +239,10 @@ class BaseContainer(object): for i, c in enumerate(containers): c.short_name = str(i) if c.name else '' + @property + def section_sizes(self): + pass + class Container(BaseContainer): """Info for a single SuperSize input file (e.g., APK file). @@ -253,7 +257,7 @@ class Container(BaseContainer): ) def __init__(self, name, metadata, section_sizes): - super(Container, self).__init__(name) + super().__init__(name) self.metadata = metadata or {} self.section_sizes = section_sizes # E.g. {SECTION_TEXT: 0} @@ -276,7 +280,7 @@ class DeltaContainer(BaseContainer): ) def __init__(self, name, before, after): - super(DeltaContainer, self).__init__(name) + super().__init__(name) self.before = before self.after = after @@ -287,7 +291,7 @@ class DeltaContainer(BaseContainer): return dict(ret) -class BaseSizeInfo(object): +class BaseSizeInfo: """Base class for SizeInfo and DeltaSizeInfo. Fields: @@ -373,10 +377,7 @@ class SizeInfo(BaseSizeInfo): raw_symbols, symbols=None, size_path=None): - super(SizeInfo, self).__init__(build_config, - containers, - raw_symbols, - symbols=symbols) + super().__init__(build_config, containers, raw_symbols, symbols=symbols) self.size_path = size_path @property @@ -406,12 +407,12 @@ class DeltaSizeInfo(BaseSizeInfo): ) def __init__(self, before, after, containers, raw_symbols): - super(DeltaSizeInfo, self).__init__(None, containers, raw_symbols) + super().__init__(None, containers, raw_symbols) self.before = before self.after = after -class BaseSymbol(object): +class BaseSymbol: """Base class for Symbol and SymbolGroup. Refer to module docs for field descriptions. @@ -419,6 +420,42 @@ class BaseSymbol(object): __slots__ = () @property + def container(self): + pass + + @property + def section_name(self): + pass + + @property + def size(self): + pass + + @property + def padding(self): + pass + + @property + def address(self): + pass + + @property + def flags(self): + pass + + @property + def aliases(self): + pass + + @property + def full_name(self): + pass + + @property + def name(self): + pass + + @property def container_name(self): return self.container.name if self.container else '' diff --git a/chromium/tools/binary_size/libsupersize/ninja_parser.py b/chromium/tools/binary_size/libsupersize/ninja_parser.py index baf595faee0..cbb20e42122 100755 --- a/chromium/tools/binary_size/libsupersize/ninja_parser.py +++ b/chromium/tools/binary_size/libsupersize/ninja_parser.py @@ -19,7 +19,7 @@ import sys _REGEX = re.compile(r'build ([^:]+): \w+ (.*?)(?: *\||\n|$)') -class _SourceMapper(object): +class _SourceMapper: def __init__(self, dep_map, parsed_file_count): self._dep_map = dep_map self.parsed_file_count = parsed_file_count @@ -35,7 +35,16 @@ class _SourceMapper(object): obj_name = path[start_idx + 1:-1] by_basename = self._dep_map.get(lib_name) if not by_basename: + if lib_name.endswith('rlib') and 'std/' in lib_name: + # Currently we use binary prebuilt static libraries of the Rust + # stdlib so we can't get source paths. That may change in future. + return '(Rust stdlib)/%s' % lib_name return None + if lib_name.endswith('.rlib'): + # Rust doesn't really have the concept of an object file because + # the compilation unit is the whole 'crate'. Return whichever + # filename was the crate root. + return next(iter(by_basename.values())) obj_path = by_basename.get(obj_name) if not obj_path: # Found the library, but it doesn't list the .o file. @@ -68,6 +77,11 @@ def _ParseNinjaPathList(path_list): return [s.replace('\b', ' ') for s in ret.split()] +def _OutputsAreObject(outputs): + return (outputs.endswith('.a') or outputs.endswith('.o') + or outputs.endswith('.rlib')) + + def _ParseOneFile(lines, dep_map, elf_path): sub_ninjas = [] elf_inputs = None @@ -78,7 +92,7 @@ def _ParseOneFile(lines, dep_map, elf_path): m = _REGEX.match(line) if m: outputs, srcs = m.groups() - if len(outputs) > 2 and outputs[-2] == '.' and outputs[-1] in 'ao': + if _OutputsAreObject(outputs): output = outputs.replace('\\ ', ' ') assert output not in dep_map, 'Duplicate output: ' + output if output[-1] == 'o': diff --git a/chromium/tools/binary_size/libsupersize/obj_analyzer.py b/chromium/tools/binary_size/libsupersize/obj_analyzer.py index bf589a3f4fd..a9cd1d61b86 100755 --- a/chromium/tools/binary_size/libsupersize/obj_analyzer.py +++ b/chromium/tools/binary_size/libsupersize/obj_analyzer.py @@ -79,14 +79,14 @@ def _MakeToolPrefixAbsolute(tool_prefix): return tool_prefix -class _PathsByType(object): +class _PathsByType: def __init__(self, arch, obj, bc): self.arch = arch self.obj = obj self.bc = bc -class _BulkObjectFileAnalyzerWorker(object): +class _BulkObjectFileAnalyzerWorker: def __init__(self, tool_prefix, output_directory, track_string_literals=True): self._tool_prefix = _MakeToolPrefixAbsolute(tool_prefix) self._output_directory = output_directory @@ -106,7 +106,7 @@ class _BulkObjectFileAnalyzerWorker(object): obj_paths = [] bc_paths = [] for path in paths: - if path.endswith('.a'): + if path.endswith('.a') or path.endswith('.rlib'): # .a files are typically system libraries containing .o files that are # ELF files (and never BC files). arch_paths.append(path) @@ -262,7 +262,7 @@ def _TerminateSubprocesses(): _active_pids = [] -class _BulkObjectFileAnalyzerHost(object): +class _BulkObjectFileAnalyzerHost: """Runs BulkObjectFileAnalyzer in a subprocess.""" def __init__(self, tool_prefix, output_directory, track_string_literals=True): self._tool_prefix = tool_prefix @@ -329,7 +329,7 @@ class _BulkObjectFileAnalyzerHost(object): # _active_pids to be killed just in case. -class _BulkObjectFileAnalyzerDelegate(object): +class _BulkObjectFileAnalyzerDelegate: """The subprocess entry point.""" def __init__(self, worker_analyzer, pipe): self._worker_analyzer = worker_analyzer diff --git a/chromium/tools/binary_size/libsupersize/parallel.py b/chromium/tools/binary_size/libsupersize/parallel.py index 5732f86132a..fede7a7a1cd 100644 --- a/chromium/tools/binary_size/libsupersize/parallel.py +++ b/chromium/tools/binary_size/libsupersize/parallel.py @@ -13,6 +13,8 @@ import sys import threading import traceback +from multiprocessing import process + DISABLE_ASYNC = os.environ.get('SUPERSIZE_DISABLE_ASYNC') == '1' if DISABLE_ASYNC: logging.debug('Running in synchronous mode.') @@ -27,7 +29,6 @@ _fork_kwargs = None # Avoid printing backtrace for every worker for Ctrl-C. def _PatchMultiprocessing(): - from multiprocessing import process old_run = process.BaseProcess.run def new_run(self): @@ -42,7 +43,7 @@ def _PatchMultiprocessing(): _PatchMultiprocessing() -class _ImmediateResult(object): +class _ImmediateResult: def __init__(self, value): self._value = value @@ -59,7 +60,7 @@ class _ImmediateResult(object): return True -class _ExceptionWrapper(object): +class _ExceptionWrapper: """Used to marshal exception messages back to main process.""" def __init__(self, msg, exception_type=None): @@ -72,7 +73,7 @@ class _ExceptionWrapper(object): self.exception_type)('Originally caused by: ' + self.msg) -class _FuncWrapper(object): +class _FuncWrapper: """Runs on the fork()'ed side to catch exceptions and spread *args.""" def __init__(self, func): @@ -82,7 +83,7 @@ class _FuncWrapper(object): def __call__(self, index, _=None): try: - return self._func(*_fork_params[index], **_fork_kwargs) + return self._func(*_fork_params[index], **dict(_fork_kwargs)) except BaseException as e: # Only keep the exception type for builtin exception types or else risk # further marshalling exceptions. @@ -94,7 +95,7 @@ class _FuncWrapper(object): return _ExceptionWrapper(traceback.format_exc(), exception_type) -class _WrappedResult(object): +class _WrappedResult: """Allows for host-side logic to be run after child process has terminated. * Raises exception caught by _FuncWrapper. diff --git a/chromium/tools/binary_size/libsupersize/parallel_test.py b/chromium/tools/binary_size/libsupersize/parallel_test.py index 3eca36bd4f8..f4a3ca11bd1 100755 --- a/chromium/tools/binary_size/libsupersize/parallel_test.py +++ b/chromium/tools/binary_size/libsupersize/parallel_test.py @@ -16,7 +16,7 @@ def _ForkTestHelper(arg1, arg2, pickle_me_not, test_instance, parent_pid): return arg1 + arg2 -class Unpicklable(object): +class Unpicklable: """Ensures that pickle() is not called on parameters.""" def __getstate__(self): diff --git a/chromium/tools/binary_size/libsupersize/path_util.py b/chromium/tools/binary_size/libsupersize/path_util.py index da33b465196..7dad64c1385 100644 --- a/chromium/tools/binary_size/libsupersize/path_util.py +++ b/chromium/tools/binary_size/libsupersize/path_util.py @@ -29,7 +29,7 @@ ANDROID_ARM_NDK_TOOL_PREFIX = os.path.join(TOOLS_SRC_ROOT, 'third_party', 'arm-linux-androideabi-') -class _PathFinder(object): +class _PathFinder: def __init__(self, name, value): self._status = _STATUS_DETECTED if value is not None else 0 self._name = name @@ -61,8 +61,7 @@ class _PathFinder(object): class OutputDirectoryFinder(_PathFinder): def __init__(self, value=None, any_path_within_output_directory=None): - super(OutputDirectoryFinder, self).__init__( - name='output-directory', value=value) + super().__init__(name='output-directory', value=value) self._any_path_within_output_directory = any_path_within_output_directory def Detect(self): @@ -91,8 +90,7 @@ class OutputDirectoryFinder(_PathFinder): class ToolPrefixFinder(_PathFinder): def __init__(self, value=None, output_directory=None, linker_name=None): - super(ToolPrefixFinder, self).__init__( - name='tool-prefix', value=value) + super().__init__(name='tool-prefix', value=value) self._output_directory = output_directory self._linker_name = linker_name; @@ -119,12 +117,11 @@ class ToolPrefixFinder(_PathFinder): # Check for output directories that have a stale build_vars.json if os.path.isfile(ret + _SAMPLE_TOOL_SUFFIX): return ret - else: - err_lines = ['tool-prefix not found: %s' % ret] - if ret.endswith('llvm-'): - err_lines.append('Probably need to run: ' - 'tools/clang/scripts/update.py --package=objdump') - raise Exception('\n'.join(err_lines)) + err_lines = ['tool-prefix not found: %s' % ret] + if ret.endswith('llvm-'): + err_lines.append('Probably need to run: ' + 'tools/clang/scripts/update.py --package=objdump') + raise Exception('\n'.join(err_lines)) from_path = distutils.spawn.find_executable(_SAMPLE_TOOL_SUFFIX) if from_path: return from_path[:-7] @@ -196,6 +193,10 @@ def GetCppFiltPath(tool_prefix): return tool_prefix + 'c++filt' +def GetDwarfdumpPath(tool_prefix): + return tool_prefix + 'dwarfdump' + + def GetStripPath(tool_prefix): # Chromium's toolchain uses //buildtools/third_party/eu-strip, but first # look for the test-only "fakestrip" for the sake of tests. diff --git a/chromium/tools/binary_size/libsupersize/readelf.py b/chromium/tools/binary_size/libsupersize/readelf.py index 15fd02cd0e2..ec1edf36e0d 100644 --- a/chromium/tools/binary_size/libsupersize/readelf.py +++ b/chromium/tools/binary_size/libsupersize/readelf.py @@ -27,9 +27,9 @@ def ArchFromElf(elf_path, tool_prefix): return 'x86' if machine == 'Advanced Micro Devices X86-64': return 'x64' - elif machine == 'ARM': + if machine == 'ARM': return 'arm' - elif machine == 'AArch64': + if machine == 'AArch64': return 'arm64' return machine diff --git a/chromium/tools/binary_size/libsupersize/test_util.py b/chromium/tools/binary_size/libsupersize/test_util.py index 26fb7de6a91..b02c97879e9 100644 --- a/chromium/tools/binary_size/libsupersize/test_util.py +++ b/chromium/tools/binary_size/libsupersize/test_util.py @@ -8,7 +8,7 @@ import logging import describe -class Golden(object): +class Golden: """Utility to use or manage "Golden" test files.""" # Global state on whether to update Golden files in CheckOrUpdate(). diff --git a/chromium/tools/binary_size/libsupersize/zip_util_test.py b/chromium/tools/binary_size/libsupersize/zip_util_test.py index b7d18533baf..0167a078741 100755 --- a/chromium/tools/binary_size/libsupersize/zip_util_test.py +++ b/chromium/tools/binary_size/libsupersize/zip_util_test.py @@ -41,6 +41,9 @@ class ZipUtilTest(unittest.TestCase): zip_util.ReadZipInfoExtraFieldLength(z, i) for i in z.infolist() ] + # Some versions of zipalign add 4 bytes when none are needed :/. + # https://android-review.googlesource.com/c/platform/build/+/1467998/9#message-e05d1da10ab2189ddd662fcb14a8006114f8a206 + alignments = [x % 4 for x in alignments] self.assertEqual([1, 0, 3], alignments) def testMeasureApkSignatureBlock(self): diff --git a/chromium/tools/binary_size/milestone_apk_sizes.py b/chromium/tools/binary_size/milestone_apk_sizes.py index 94156afefda..09e6cccaa09 100755 --- a/chromium/tools/binary_size/milestone_apk_sizes.py +++ b/chromium/tools/binary_size/milestone_apk_sizes.py @@ -37,7 +37,7 @@ _KEYSTORE_PASSWORD = 'chromium' _KEYSTORE_ALIAS = 'chromiumdebugkey' -class _Artifact(object): +class _Artifact: def __init__(self, prefix, name, staging_dir): self.name = name self._gs_url = posixpath.join(prefix, name) diff --git a/chromium/tools/binary_size/sizes.py b/chromium/tools/binary_size/sizes.py index 7e9b4a4e777..4cf0aff3982 100755 --- a/chromium/tools/binary_size/sizes.py +++ b/chromium/tools/binary_size/sizes.py @@ -32,8 +32,12 @@ SRC_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), '..', '..')) sys.path.append(os.path.join(SRC_DIR, 'third_party', 'catapult', 'tracing')) from tracing.value import convert_chart_json +sys.path.insert(0, os.path.join(SRC_DIR, 'build', 'util')) +from lib.results import result_sink +from lib.results import result_types -class ResultsCollector(object): + +class ResultsCollector: def __init__(self): self.results = {} @@ -279,7 +283,7 @@ def main_linux(output_directory, results_collector, size_path): # TODO(mcgrathr): This should all be refactored so the mac and win flavors # also deliver data structures rather than printing, and the logic for # the printing and the summing totals is shared across all three flavors. - for (identifier, units), value in sorted(totals.iteritems()): + for (identifier, units), value in sorted(totals.items()): results_collector.add_result('totals-%s' % identifier, identifier, value, units) @@ -470,6 +474,7 @@ def main(): os.makedirs(results_directory) results_collector = ResultsCollector() + result_sink_client = result_sink.TryInitClient() try: rc = real_main(args.output_directory, results_collector, args.size_path) isolated_script_output = { @@ -498,6 +503,13 @@ def main(): else: with open(histogram_path, 'w') as f: f.write(histogram_result.stdout) + if result_sink_client: + status = result_types.PASS + if not isolated_script_output['valid']: + status = result_types.UNKNOWN + elif isolated_script_output['failures']: + status = result_types.FAIL + result_sink_client.Post(test_name, status, None, None, None) return rc diff --git a/chromium/tools/binary_size/sizes.pydeps b/chromium/tools/binary_size/sizes.pydeps index 3e8559a48e0..5996e25e2ba 100644 --- a/chromium/tools/binary_size/sizes.pydeps +++ b/chromium/tools/binary_size/sizes.pydeps @@ -1,5 +1,9 @@ # Generated by running: # build/print_python_deps.py --root tools/binary_size --output tools/binary_size/sizes.pydeps tools/binary_size/sizes.py +../../build/util/lib/__init__.py +../../build/util/lib/results/__init__.py +../../build/util/lib/results/result_sink.py +../../build/util/lib/results/result_types.py ../../third_party/catapult/third_party/six/six.py ../../third_party/catapult/third_party/vinn/vinn/__init__.py ../../third_party/catapult/third_party/vinn/vinn/_vinn.py diff --git a/chromium/tools/binary_size/trybot_commit_size_checker.py b/chromium/tools/binary_size/trybot_commit_size_checker.py index 783cd8a2d9b..4fdf77ed311 100755 --- a/chromium/tools/binary_size/trybot_commit_size_checker.py +++ b/chromium/tools/binary_size/trybot_commit_size_checker.py @@ -237,7 +237,7 @@ def _GenerateBinarySizePluginDetails(metrics): binary_size_listings.insert(0, listing) continue # The main 'binary size' delta is always shown even if unchanged. - elif delta.actual == 0: + if delta.actual == 0: continue binary_size_listings.append(listing) diff --git a/chromium/tools/bisect/OWNERS b/chromium/tools/bisect/OWNERS new file mode 100644 index 00000000000..0e5f33c6ecd --- /dev/null +++ b/chromium/tools/bisect/OWNERS @@ -0,0 +1,2 @@ +svenzheng@chromium.org + diff --git a/chromium/tools/bisect/bisect.py b/chromium/tools/bisect/bisect.py new file mode 100755 index 00000000000..b49a55a915a --- /dev/null +++ b/chromium/tools/bisect/bisect.py @@ -0,0 +1,125 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +# +# This is a script helping developer bisect test failures. +# +# Currently this only supports bisecting gtest based test failures. +# Say you're assigned a BrowserTest.TestCase1 failure. You would generally do +# 1 Find a good commit and bad commit. +# 2 `git bisect start` +# 3 `git bisect good <good commit id>` +# 4 `git bisect bad <bad commit id>` +# 5 `gclient sync` +# 6 `autoninja -C out/Default browser_tests` +# 7 `out/Default/browser_tests --gtest_filter=BrowserTest.TestCase1` +# 8 if the test pass, `git bisect good`, otherwise `git bisect bad`. +# 9 repeat 5 - 8 until finding the culprit. +# This script will help you on 2 - 9. You first do 1, then run +# `python3 tools/bisect/bisect.py -g <good commit id> -b <bad commit id> +# --build_command 'autoninja -C out/Default browser_tests' +# --test_command 'out/Default/browser_tests +# --gtest_filter=BrowserTest.TestCase1'` +# The script will run until it finds the culprit cl breaking the test. +# +# Note1: We only support non-flaky -> failure, or non-flaky -> flaky. +# Flaky -> failure can't get correct result. For non-flaky -> flaky, +# you can use `--gtest_repeat`. +# Note2: For tests using python launching script, this is supported. e.g. +# `--test_command 'build/lacros/test_runner.py test +# out/lacrosdesktop/lacros_chrome_browsertests +# --ash-chrome-path=out/lacrosdesktop/ash_clang_x64/test_ash_chrome +# --gtest_filter=BrowserTest.TestCase1'` + +import argparse +import subprocess +import sys + +# This is the message from `git bisect` when it +# finds the culprit cl. +GIT_BAD_COMMENT_MSG = 'is the first bad commit' +GIT_BISECT_IN_PROCESS_MSG = 'left to test after this' + + +def Run(command, print_stdout_on_error=True): + print(command) + c = subprocess.run(command, shell=True) + if print_stdout_on_error and c.returncode != 0: + print(c.stdout) + return c.returncode == 0 + + +def StartBisect(good_rev, bad_rev, build_command, test_command): + assert (Run('git bisect start')) + assert (Run('git bisect bad %s' % bad_rev)) + assert (Run('git bisect good %s' % good_rev)) + + while True: + assert (Run('gclient sync')) + assert (Run(build_command)) + test_ret = None + # If the test result is different running twice, then + # try again. + for _ in range(5): + c1 = Run(test_command, print_stdout_on_error=False) + c2 = Run(test_command, print_stdout_on_error=False) + if c1 == c2: + test_ret = c2 + break + + gitcp = None + if test_ret: + print('git bisect good') + gitcp = subprocess.run('git bisect good', + shell=True, + capture_output=True, + text=True) + else: + print('git bisect bad') + gitcp = subprocess.run('git bisect bad', + shell=True, + capture_output=True, + text=True) + # git should always print 'left to test after this'. No stdout + # means something is wrong. + if not gitcp.stdout: + print('Something is wrong! Exit bisect.') + if gitcp.stderr: + print(gitcp.stderr) + break + + print(gitcp.stdout) + first_line = gitcp.stdout[:gitcp.stdout.find('\n')] + # Found the culprit! + if GIT_BAD_COMMENT_MSG in first_line: + print('Found the culprit change!') + return 0 + if GIT_BISECT_IN_PROCESS_MSG not in first_line: + print('Something is wrong! Exit bisect.') + if gitcp.stderr: + print(gitcp.stderr) + break + return 1 + + +def main(): + parser = argparse.ArgumentParser() + parser.add_argument('-b', + '--bad', + type=str, + help='A bad revision to start bisection.') + parser.add_argument('-g', + '--good', + type=str, + help='A good revision to start bisection.') + parser.add_argument('--build_command', + type=str, + help='Command to build test target.') + parser.add_argument('--test_command', type=str, help='Command to run test.') + args = parser.parse_args() + return StartBisect(args.good, args.bad, args.build_command, args.test_command) + + +if __name__ == '__main__': + sys.exit(main()) diff --git a/chromium/tools/boilerplate.py b/chromium/tools/boilerplate.py index b88ae84eda0..62923232cc5 100755 --- a/chromium/tools/boilerplate.py +++ b/chromium/tools/boilerplate.py @@ -8,9 +8,10 @@ Usage: tools/boilerplate.py path/to/file.{h,cc} """ -from __future__ import print_function +from __future__ import print_function, unicode_literals from datetime import date +import io import os import os.path import sys @@ -135,9 +136,8 @@ def _CreateFile(filename): elif filename.endswith('.mm'): contents += _ObjCppImplementation(filename) - fd = open(filename, 'wb') - fd.write(contents) - fd.close() + with io.open(filename, mode='w', newline='\n') as fd: + fd.write(contents) def Main(): diff --git a/chromium/tools/captured_sites/OWNERS b/chromium/tools/captured_sites/OWNERS new file mode 100644 index 00000000000..c111965eccc --- /dev/null +++ b/chromium/tools/captured_sites/OWNERS @@ -0,0 +1,2 @@ +ianstruiksma@google.com +file://components/autofill/OWNERS diff --git a/chromium/tools/captured_sites/control.py b/chromium/tools/captured_sites/control.py new file mode 100755 index 00000000000..7dd4e253a1e --- /dev/null +++ b/chromium/tools/captured_sites/control.py @@ -0,0 +1,403 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""Runs captured sites framework recording and tests. + + $ tools/captured_sites/control.py [command] [arguments] +Commands: + chrome Starts a Chrome instance with autofill hooks + wpr Starts a WPR server instance to record or replay + run Starts a test for a single site or "*" for all sites +Use "captured_sites [command] -h" for more information about each command.', + +This script attempts to simplify the various configuration and override options +that are available in creating and executing the Captured Sites Framework for +Autofill and Password Manager. + +This script assumes execution location is the src folder of the chromium +checkout. Commands should be run from chromium/src directory. + +Also assumes that built targets are in : + out/Default for is_debug = true + out/Release for is_debug = false + +Some environment variables should be set in order to use this script to its +full potential. + + CAPTURED_SITES_USER_DATA_DIR - a location to store local information about the + chromium profile. This allows the tester to pull back the address and credit + card profile information without restarting it each time. + CAPTURED_SITES_LOG_DATA_DIR - a location to store log data for easier parsing + after a test run has been completed. + +Common tasks: +Recording a new test for site 'youtube' (requires two terminal windows): + Window 1$: tools/captured_sites/control.py wpr record youtube + Window 2$: tools/captured_sites/control.py chrome -w -r + +Checking a recorded test for site 'youtube' (requires two terminal windows): + Window 1$ tools/captured_sites/control.py wpr replay youtube + Window 2$ tools/captured_sites/control.py chrome -w -r -u youtube + +Running all 'sign_in_pass' tests and saving the logs: + $ tools/captured_sites/control.py run -s sign_in_pass * + +Running disabled autofill test 'rei': + $ tools/captured_sites/control.py run -d rei + +Running autofill test 'rei' with ability to pause at each step: + $ tools/captured_sites/control.py run -q path/to/pipe rei + +""" + +from __future__ import print_function + +import argparse +import json +import os +import signal +import subprocess +import sys +import time + +# Checking for environment variables. +_HOME_DIR = os.environ['HOME'] +_DEFAULT_USER_DATA_DIR = os.path.join(_HOME_DIR, 'data/userdir') +_DEFAULT_LOG_DATA_DIR = os.path.join(_HOME_DIR, 'data/local_test_results') +if 'CAPTURED_SITES_USER_DATA_DIR' in os.environ: + _USER_DATA_DIR_PATH = os.environ['CAPTURED_SITES_USER_DATA_DIR'] +else: + _USER_DATA_DIR_PATH = _DEFAULT_USER_DATA_DIR +if 'CAPTURED_SITES_LOG_DATA_DIR' in os.environ: + _LOG_DATA_DIR_PATH = os.environ['CAPTURED_SITES_LOG_DATA_DIR'] +else: + _LOG_DATA_DIR_PATH = _DEFAULT_LOG_DATA_DIR + +# Long text chunks that will be used in command constructions. +_EXTRA_BROWSER_AUTOFILL = ('autofill_download_manager=1,form_cache=1,' + 'autofill_agent=1,autofill_handler=1,' + 'form_structure=1,cache_replayer=2') +_WPR_INJECT_SCRIPTS = ('--inject_scripts=third_party/catapult/web_page_replay_g' + 'o/deterministic.js,chrome/test/data/web_page_replay_go_' + 'helper_scripts/automation_helper.js') +_NORMAL_BROWSER_AUTOFILL = 'cache_replayer=1' +_RUN_BACKGROUND = 'testing/xvfb.py' +_RUN_DISABLED_TESTS = '--gtest_also_run_disabled_tests' + +_AUTOFILL_TEST = '*/AutofillCapturedSitesInteractiveTest' +_PASSWORD_MANAGER_TEST = '*/CapturedSitesPasswordManagerBrowserTest' +_VMODULE_AUTOFILL_FILE = 'autofill_captured_sites_interactive_uitest' +_VMODULE_PASSWORD_FILE = 'password_manager_captured_sites_interactive_uitest' + +_STABLE_GOOGLE_CHROME = '/usr/bin/google-chrome' +_RELEASE_BUILD_CHROME = 'out/Release/chrome' + +_HOOK_CHROME_TO_WPR = ('--host-resolver-rules="MAP *:80 127.0.0.1:8080,' + 'MAP *:443 127.0.0.1:8081,EXCLUDE localhost"') + +_AUTOFILL_CACHE_TYPE_LOOKUP = { + 'SavedCache': 'SavedCache', + 'ProductionServer': 'ProductionServer', + 'OnlyLocalHeuristics': 'OnlyLocalHeuristics', + 'c': 'SavedCache', + 'p': 'ProductionServer', + 'n': 'OnlyLocalHeuristics' +} + + +class Command(): + def __init__(self, description, arg_builders, launch_method): + self.description = description + self.arg_builders = arg_builders + self.launch_method = launch_method + + def build_and_execute(self, args): + parser = argparse.ArgumentParser(description=self.description) + for arg_builder in self.arg_builders: + arg_builder(parser) + found_args = parser.parse_known_args(args) + self.launch_method(found_args[0], found_args[1]) + + +def _add_chrome_args(parser): + parser.add_argument('-r', + '--release', + dest='build_target', + default=_STABLE_GOOGLE_CHROME, + const=_RELEASE_BUILD_CHROME, + help='Start Release build of chrome.', + action='store_const') + parser.add_argument('-w', + '--wpr', + dest='wpr_selection', + action='store_true', + help='Point chrome instance at wpr service.') + parser.add_argument('-u', + '--url', + dest='start_url', + action='store', + help='Grab starting URL from test recipe.') + + +def _add_wpr_args(parser): + parser.add_argument('subhead', + choices=['record', 'replay'], + help=('Whether to record new traffic to an archive, ' + 'or replay from an existing archive.')) + + +def _add_run_args(parser): + parser.add_argument('-r', + '--release', + dest='target', + action='store_const', + default='Default', + const='Release', + help='Run tests on Release build of chrome.') + parser.add_argument('-s', + '--store-log', + dest='store_log', + action='store_true', + help='Store the log and output in _LOG_DATA_DIR_PATH.') + parser.add_argument('-b', + '--background', + dest='background', + action='store_true', + help='Run the test in background with xvfb.py.') + parser.add_argument('-d', + '--disabled', + dest='add_disabled', + action='store_true', + help='Also run disabled tests that match the filter.') + parser.add_argument('-v', + '--verbose', + dest='verbose_logging', + action='store_const', + default=_NORMAL_BROWSER_AUTOFILL, + const=_EXTRA_BROWSER_AUTOFILL, + help='Log verbose Autofill Server information.') + parser.add_argument('-t', + '--test-retry', + dest='retry_count', + action='store', + default=0, + type=int, + help='How many times to retry failed tests.') + parser.add_argument('-a', + '--autofill-cache-type', + dest='autofill_cache_type', + choices=_AUTOFILL_CACHE_TYPE_LOOKUP.keys(), + action='store', + help='Control the autofill cache behavior.') + parser.add_argument('-q', + '--command_file', + dest='command_file', + action='store', + default='', + type=str, + help='Location of "pipe: file') + + +def _add_shared_args(parser): + parser.add_argument('-p', + '--print-only', + dest='print_only', + action='store_true', + help='Build the command and print it but do not execute.') + + +def _add_scenario_site_args(parser): + parser.add_argument('scenario_dir', + nargs='?', + default='', + choices=[ + 'sign_in_pass', 'sign_up_pass', 'sign_up_fill', + 'capture_update_pass', '*', '' + ], + help=('Only for password tests to designate the specific ' + 'test scenario. Use * to indicate all password test' + ' scenarios.')) + parser.add_argument('site_name', + help=('The site name which should have a match in ' + 'testcases.json. Use * to indicate all enumerated ' + 'sites in that file.')) + + +def _parse_command_args(command_names): + parser = argparse.ArgumentParser( + formatter_class=argparse.RawTextHelpFormatter) + parser.usage = __doc__ + parser.add_argument('name', choices=command_names) + parser.add_argument('args', nargs=argparse.REMAINDER) + return parser.parse_args() + + +def _make_process_call(command_args, print_only): + command_text = ' '.join(command_args) + print(command_text) + if print_only: + return + + if not os.path.exists(command_args[0]): + raise EnvironmentError('Cannot locate binary to execute. ' + 'Ensure that working directory is chromium/src') + subprocess.call(command_text, shell=True) + + +def _print_starting_url(url): + password_path = 'chrome/test/data/password/captured_sites/%s.test' + autofill_path = 'chrome/test/data/autofill/captured_sites/%s.test' + if '-' in url: + path = password_path % url.replace('-', '/') + else: + path = autofill_path % url + if not os.path.exists(path): + print('No file found for "%s"' % url, file=sys.stderr) + return + with open(path, 'r') as read_file: + data = json.load(read_file) + if not 'startingURL' in data: + print('No startingURL found in file for "%s"' % url, file=sys.stderr) + return + print('%s test starts at:' % url, file=sys.stderr) + print(data['startingURL']) + print('') + + +def _launch_chrome(options, forward_args): + if options.start_url: + _print_starting_url(options.start_url) + + if not os.path.isdir(_USER_DATA_DIR_PATH): + print('Required CAPTURED_SITES_USER_DATA_DIR "%s" cannot be found' % + _USER_DATA_DIR_PATH) + raise ValueError('Must set environment variable $CAPTURED_SITES_USER_DATA_D' + 'IR or ensure default _USER_DATA_DIR_PATH exists') + + command_args = [ + options.build_target, '--ignore-certificate-errors-spki-list=' + 'PoNnQAwghMiLUPg1YNFtvTfGreNT8r9oeLEyzgNCJWc=', + '--user-data-dir="%s"' % _USER_DATA_DIR_PATH, + '--disable-application-cache', '--show-autofill-signatures', + '--enable-features=AutofillShowTypePredictions', + '--disable-features=AutofillCacheQueryResponses' + ] + if options.wpr_selection: + command_args.append(_HOOK_CHROME_TO_WPR) + _make_process_call(command_args + forward_args, options.print_only) + + +def _launch_wpr(options, forward_args): + command_args = [ + 'third_party/catapult/telemetry/telemetry/bin/linux/x86_64/wpr', + options.subhead, '--https_cert_file=components/test/data/autofill/' + 'web_page_replay_support_files/wpr_cert.pem', + '--https_key_file=components/test/data/autofill/' + 'web_page_replay_support_files/wpr_key.pem', '--http_port=8080', + '--https_port=8081', _WPR_INJECT_SCRIPTS + ] + + if options.subhead == 'replay': + command_args.append('--serve_response_in_chronological_sequence') + + if options.scenario_dir == '': + command_args.append('chrome/test/data/autofill/captured_sites/%s.wpr' % + options.site_name) + else: + command_args.append('chrome/test/data/password/captured_sites/%s/%s.wpr' % + (options.scenario_dir, options.site_name)) + + _make_process_call(command_args + forward_args, options.print_only) + + +def _launch_run(options, forward_args): + gtest_filter = _AUTOFILL_TEST + gtest_parameter = options.site_name + vmodule_name = _VMODULE_AUTOFILL_FILE + if options.scenario_dir != '': + gtest_filter = _PASSWORD_MANAGER_TEST + gtest_parameter = '%s_%s' % (options.scenario_dir, options.site_name) + vmodule_name = _VMODULE_PASSWORD_FILE + + command_args = [ + 'out/%s/captured_sites_interactive_tests' % options.target, + '--gtest_filter="%s.Recipe/%s"' % (gtest_filter, gtest_parameter), + '--test-launcher-interactive', '--enable-pixel-output-in-tests', + '--vmodule=captured_sites_test_utils=2,%s,%s=1' % + (options.verbose_logging, vmodule_name) + ] + + if options.background: + command_args.insert(0, _RUN_BACKGROUND) + + if options.add_disabled: + command_args.append(_RUN_DISABLED_TESTS) + + if options.retry_count > 0: + command_args.append('--test-launcher-retry-limit=%d' % options.retry_count) + + if options.autofill_cache_type: + full_cache_type = _AUTOFILL_CACHE_TYPE_LOOKUP[options.autofill_cache_type] + command_args.append('--autofill-server-type=%s ' % full_cache_type) + + if options.command_file: + command_args.append('--command_file=%s' % options.command_file) + + if options.store_log: + if not os.path.isdir(_LOG_DATA_DIR_PATH): + print('Required LOG_DATA_DIR "%s" cannot be found' % _LOG_DATA_DIR_PATH) + raise ValueError('Must set environment variable $LOG_DATA_DIR or ' + 'ensure default _LOG_DATA_DIR_PATH exists') + logging_scenario_site_param = gtest_parameter.replace('*', 'all') + command_args.append( + '--test-launcher-summary-output={}/{}_output.json'.format( + _LOG_DATA_DIR_PATH, logging_scenario_site_param)) + command_args.extend(forward_args) + command_args.append('2>&1 | tee {}/{}_capture.log'.format( + _LOG_DATA_DIR_PATH, logging_scenario_site_param)) + + _make_process_call(command_args, options.print_only) + + +def _handle_signal(sig, _): + """Handles received signals to make sure spawned test process are killed. + + sig (int): An integer representing the received signal, for example SIGTERM. + """ + + # Don't do any cleanup here, instead, leave it to the finally blocks. + # Assumption is based on https://docs.python.org/3/library/sys.html#sys.exit: + # cleanup actions specified by finally clauses of try statements are honored. + + # https://tldp.org/LDP/abs/html/exitcodes.html: + # Exit code 128+n -> Fatal error signal "n". + print('Signal to quit received, waiting for potential WPR write to complete') + time.sleep(1) + sys.exit(128 + sig) + + +def main(): + for sig in (signal.SIGTERM, signal.SIGINT): + signal.signal(sig, _handle_signal) + + all_commands = { + 'chrome': + Command('Start a Chrome instance with autofill hooks.', + [_add_chrome_args, _add_shared_args], _launch_chrome), + 'wpr': + Command('Start WPR to replay or record.', + [_add_wpr_args, _add_shared_args, _add_scenario_site_args], + _launch_wpr), + 'run': + Command('Start an autofill or password test run.', + [_add_run_args, _add_shared_args, _add_scenario_site_args], + _launch_run) + } + options = _parse_command_args(all_commands.keys()) + command = all_commands[options.name] + command.build_and_execute(options.args) + + +if __name__ == '__main__': + sys.exit(main()) diff --git a/chromium/tools/cast3p/OWNERS b/chromium/tools/cast3p/OWNERS new file mode 100644 index 00000000000..b8864346fed --- /dev/null +++ b/chromium/tools/cast3p/OWNERS @@ -0,0 +1,4 @@ +chonggu@google.com +mfoltz@google.com +riazantsevv@google.com +rwkeane@google.com
\ No newline at end of file diff --git a/chromium/tools/cast3p/README.md b/chromium/tools/cast3p/README.md new file mode 100644 index 00000000000..0b273d58f97 --- /dev/null +++ b/chromium/tools/cast3p/README.md @@ -0,0 +1,5 @@ +This directory contains Python code used for interacting with the binaries +related to OEM integration for Cast running on third-party hardware. +These binaries can be fetched by setting checkout_cast3p=True in .gclient. +go/upstreaming-the-cast-web-runtime details the effort to upstream the +Cast Web Runtime. diff --git a/chromium/tools/cast3p/runtime.version b/chromium/tools/cast3p/runtime.version new file mode 100644 index 00000000000..3f82e1709a0 --- /dev/null +++ b/chromium/tools/cast3p/runtime.version @@ -0,0 +1 @@ +273826
\ No newline at end of file diff --git a/chromium/tools/cast3p/update_runtime.py b/chromium/tools/cast3p/update_runtime.py new file mode 100755 index 00000000000..1624be1f7e8 --- /dev/null +++ b/chromium/tools/cast3p/update_runtime.py @@ -0,0 +1,69 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import logging +import os +import subprocess +import shutil +import sys +import tempfile + +from zipfile import ZipFile + +DIR_SOURCE_ROOT = os.path.abspath( + os.path.join(os.path.dirname(__file__), os.pardir, os.pardir)) + +sys.path.append(os.path.join(DIR_SOURCE_ROOT, 'build')) +import find_depot_tools + +RUNTIME_SIGNATURE_FILE = '.version' +WEB_RUNTIME_ROOT = os.path.abspath( + os.path.join(DIR_SOURCE_ROOT, 'third_party', 'cast_web_runtime')) +ZIP_PATH_TEMPLATE = ( + 'gs://gtv-eureka/internal/master/core_runtime-eng/{version}' \ + '/core_runtime_package.zip') + + +# Fetches a .zip file from GCS and uncompresses it to |output_dir|. +def DownloadAndUnpackFromCloudStorage(url, output_dir): + with tempfile.TemporaryDirectory() as tmpdir: + temp_zip_file = os.path.join(tmpdir, 'web_runtime.zip') + cmd = [ + os.path.join(find_depot_tools.DEPOT_TOOLS_PATH, 'gsutil.py'), 'cp', url, + temp_zip_file + ] + task = subprocess.check_call(cmd, + stdout=subprocess.DEVNULL, + stderr=subprocess.DEVNULL) + with ZipFile(temp_zip_file, 'r') as zip_ref: + zip_ref.extractall(output_dir) + + +def MakeCleanDirectory(directory_name): + if os.path.exists(directory_name): + shutil.rmtree(directory_name) + os.mkdir(directory_name) + + +def main(): + runtime_version = open( + os.path.join(os.path.dirname(__file__), + 'runtime.version')).read().strip() + signature_file_path = os.path.join(WEB_RUNTIME_ROOT, RUNTIME_SIGNATURE_FILE) + current_signature = (open(signature_file_path, 'r').read().strip() + if os.path.exists(signature_file_path) else '') + if current_signature != runtime_version: + logging.info( + 'Downloading Cast Web Runtime version {}...'.format(runtime_version)) + MakeCleanDirectory(WEB_RUNTIME_ROOT) + DownloadAndUnpackFromCloudStorage( + ZIP_PATH_TEMPLATE.format(version=runtime_version), WEB_RUNTIME_ROOT) + with open(signature_file_path, 'w') as f: + f.write(runtime_version) + return 0 + + +if __name__ == '__main__': + sys.exit(main()) diff --git a/chromium/tools/checklicenses/checklicenses.py b/chromium/tools/checklicenses/checklicenses.py index 69820bcced6..bef0318a3dd 100755 --- a/chromium/tools/checklicenses/checklicenses.py +++ b/chromium/tools/checklicenses/checklicenses.py @@ -484,34 +484,6 @@ PATH_SPECIFIC_ALLOWLISTED_LICENSES = { 'UNKNOWN', ], - # New BSD license. http://crbug.com/98455 - 'tools/swarming_client/third_party/google': [ - 'UNKNOWN', - ], - - # https://github.com/google/google-api-python-client/issues/216 - # Apache v2.0. - 'tools/swarming_client/third_party/googleapiclient': [ - 'UNKNOWN', - ], - - # http://crbug.com/334668 - # https://github.com/jcgregorio/httplib2/issues/307 - # MIT license. - 'tools/swarming_client/third_party/httplib2': [ - 'UNKNOWN', - ], - - # http://crbug.com/471372 - # BSD - 'tools/swarming_client/third_party/pyasn1': [ - 'UNKNOWN', - ], - - # https://github.com/kennethreitz/requests/issues/1610 - 'tools/swarming_client/third_party/requests': [ - 'UNKNOWN', - ], 'third_party/minizip': [ 'UNKNOWN', ], @@ -673,6 +645,7 @@ def check_licenses(options, args): errors = [] for line in stdout.splitlines(): + line = line.decode('utf-8') filename, license = line.split(':', 1) filename = os.path.relpath(filename.strip(), options.base_directory) diff --git a/chromium/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp b/chromium/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp index 40b1473b71a..723458c6e52 100644 --- a/chromium/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp +++ b/chromium/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp @@ -57,7 +57,7 @@ void CheckFieldsVisitor::AtIterator(Iterator* edge) { if (!managed_host_) return; - if (edge->IsUnsafe()) + if (!stack_allocated_host_ && edge->on_heap()) invalid_fields_.push_back(std::make_pair(current_, kIteratorToGCManaged)); } diff --git a/chromium/tools/clang/blink_gc_plugin/Config.h b/chromium/tools/clang/blink_gc_plugin/Config.h index 5729d33eb37..1f9ce59f99b 100644 --- a/chromium/tools/clang/blink_gc_plugin/Config.h +++ b/chromium/tools/clang/blink_gc_plugin/Config.h @@ -134,7 +134,6 @@ class Config { return name == "Vector" || name == "Deque" || name == "HashSet" || - name == "ListHashSet" || name == "LinkedHashSet" || name == "HashCountedSet" || name == "HashMap"; @@ -142,25 +141,12 @@ class Config { static bool IsGCCollection(llvm::StringRef name) { return name == "HeapVector" || name == "HeapDeque" || - name == "HeapHashSet" || name == "HeapListHashSet" || - name == "HeapLinkedHashSet" || name == "HeapHashCountedSet" || - name == "HeapHashMap"; - } - - static bool IsGCCollectionWithUnsafeIterator(llvm::StringRef name) { - if (!IsGCCollection(name)) - return false; - // The list hash set iterators refer to the set, not the - // backing store and are consequently safe. - if (name == "HeapListHashSet" || name == "PersistentHeapListHashSet") - return false; - return true; + name == "HeapHashSet" || name == "HeapLinkedHashSet" || + name == "HeapHashCountedSet" || name == "HeapHashMap"; } static bool IsHashMap(llvm::StringRef name) { - return name == "HashMap" || - name == "HeapHashMap" || - name == "PersistentHeapHashMap"; + return name == "HashMap" || name == "HeapHashMap"; } // Assumes name is a valid collection name. diff --git a/chromium/tools/clang/blink_gc_plugin/DIR_METADATA b/chromium/tools/clang/blink_gc_plugin/DIR_METADATA index 5b0987557d6..b8ee9be3a2a 100644 --- a/chromium/tools/clang/blink_gc_plugin/DIR_METADATA +++ b/chromium/tools/clang/blink_gc_plugin/DIR_METADATA @@ -7,6 +7,6 @@ # https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/tools/dirmd/proto/dir_metadata.proto monorail { - component: "Blink>MemoryAllocator>GarbageCollection" + component: "Blink>GarbageCollection" } team_email: "oilpan-reviews@chromium.org"
\ No newline at end of file diff --git a/chromium/tools/clang/blink_gc_plugin/Edge.h b/chromium/tools/clang/blink_gc_plugin/Edge.h index 2b0b0e66c93..671c640270d 100644 --- a/chromium/tools/clang/blink_gc_plugin/Edge.h +++ b/chromium/tools/clang/blink_gc_plugin/Edge.h @@ -289,8 +289,7 @@ class Collection : public Edge { // An iterator edge is a direct edge to some iterator type. class Iterator : public Edge { public: - Iterator(RecordInfo* info, bool on_heap, bool is_unsafe) - : info_(info), on_heap_(on_heap), is_unsafe_(is_unsafe) {} + Iterator(RecordInfo* info, bool on_heap) : info_(info), on_heap_(on_heap) {} ~Iterator() {} void Accept(EdgeVisitor* visitor) override { visitor->VisitIterator(this); } @@ -298,18 +297,17 @@ class Iterator : public Edge { bool NeedsFinalization() override { return false; } TracingStatus NeedsTracing(NeedsTracingOption) override { if (on_heap_) - return TracingStatus::Needed(); + return TracingStatus::Illegal(); return TracingStatus::Unneeded(); } RecordInfo* info() const { return info_; } - bool IsUnsafe() const { return is_unsafe_; } + bool on_heap() const { return on_heap_; } private: RecordInfo* info_; bool on_heap_; - bool is_unsafe_; }; #endif // TOOLS_BLINK_GC_PLUGIN_EDGE_H_ diff --git a/chromium/tools/clang/blink_gc_plugin/RecordInfo.cpp b/chromium/tools/clang/blink_gc_plugin/RecordInfo.cpp index 23c70665edc..e5d75003428 100644 --- a/chromium/tools/clang/blink_gc_plugin/RecordInfo.cpp +++ b/chromium/tools/clang/blink_gc_plugin/RecordInfo.cpp @@ -84,7 +84,7 @@ bool RecordInfo::HasOptionalFinalizer() { return false; // Heap collections may have a finalizer but it is optional (i.e. may be // delayed until FinalizeGarbageCollectedObject() gets called), unless there - // is an inline buffer. Vector, Deque, and ListHashSet can have an inline + // is an inline buffer. Vector and Deque can have an inline // buffer. if (name_ != "Vector" && name_ != "Deque" && name_ != "HeapVector" && name_ != "HeapDeque") @@ -665,15 +665,12 @@ Edge* RecordInfo::CreateEdgeFromOriginalType(const Type* type) { cache_->Lookup(elaboratedType->getQualifier()->getAsType()); bool on_heap = false; - bool is_unsafe = false; // Silently handle unknown types; the on-heap collection types will // have to be in scope for the declaration to compile, though. if (info) { - is_unsafe = Config::IsGCCollectionWithUnsafeIterator(info->name()); - // Don't mark iterator as being on the heap if it is not supported. - on_heap = !is_unsafe && Config::IsGCCollection(info->name()); + on_heap = Config::IsGCCollection(info->name()); } - return new Iterator(info, on_heap, is_unsafe); + return new Iterator(info, on_heap); } Edge* RecordInfo::CreateEdge(const Type* type) { diff --git a/chromium/tools/clang/rewrite_raw_ptr_fields/RewriteRawPtrFields.cpp b/chromium/tools/clang/rewrite_raw_ptr_fields/RewriteRawPtrFields.cpp index ae40c4d4b94..d49ff34d153 100644 --- a/chromium/tools/clang/rewrite_raw_ptr_fields/RewriteRawPtrFields.cpp +++ b/chromium/tools/clang/rewrite_raw_ptr_fields/RewriteRawPtrFields.cpp @@ -1255,37 +1255,6 @@ int main(int argc, const char* argv[]) { FilteredExprWriter global_destructor_writer(&output_helper, "global-scope"); match_finder.addMatcher(global_destructor_matcher, &global_destructor_writer); - // Matches CXXRecordDecls with a deleted operator new - e.g. - // StructWithNoOperatorNew below: - // struct StructWithNoOperatorNew { - // void* operator new(size_t) = delete; - // }; - auto record_with_deleted_allocation_operator_type_matcher = cxxRecordDecl( - hasMethod(allOf(hasOverloadedOperatorName("new"), isDeleted()))); - // Matches rewritable fields inside structs with no operator new. See the - // testcase in tests/gen-deleted-operator-new-test.cc - auto field_in_record_with_deleted_operator_new_matcher = fieldDecl( - allOf(field_decl_matcher, - hasParent(record_with_deleted_allocation_operator_type_matcher))); - FilteredExprWriter field_in_record_with_deleted_operator_new_writer( - &output_helper, "embedder-has-no-operator-new"); - match_finder.addMatcher(field_in_record_with_deleted_operator_new_matcher, - &field_in_record_with_deleted_operator_new_writer); - // Matches rewritable fields that contain a pointer, pointing to a pointee - // with no operator new. See the testcase in - // tests/gen-deleted-operator-new-test.cc - auto field_pointing_to_record_with_deleted_operator_new_matcher = - fieldDecl(allOf( - field_decl_matcher, - hasType(pointerType( - pointee(hasUnqualifiedDesugaredType(recordType(hasDeclaration( - record_with_deleted_allocation_operator_type_matcher)))))))); - FilteredExprWriter field_pointing_to_record_with_deleted_operator_new_writer( - &output_helper, "pointee-has-no-operator-new"); - match_finder.addMatcher( - field_pointing_to_record_with_deleted_operator_new_matcher, - &field_pointing_to_record_with_deleted_operator_new_writer); - // Matches fields in unions (both directly rewritable fields as well as union // fields that embed a struct that contains a rewritable field). See also the // testcases in tests/gen-unions-test.cc. diff --git a/chromium/tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt b/chromium/tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt index 7b018c45182..7b9f8d8705f 100644 --- a/chromium/tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt +++ b/chromium/tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt @@ -195,8 +195,6 @@ blink::PrerendererClient::client_ blink::weakness_marking_test::EphemeronCallbacksCounter::count_holder_ sql::recover::InnerPageDecoder::db_reader_ sql::recover::LeafPageDecoder::db_reader_ -WTF::ListHashSet::head_ -WTF::ListHashSet::tail_ # Populated manually - flexible array with non-trivial destruction blink::ShapeResultView::(anonymous struct)::alignment diff --git a/chromium/tools/clang/rewrite_raw_ptr_fields/manual-paths-to-ignore.txt b/chromium/tools/clang/rewrite_raw_ptr_fields/manual-paths-to-ignore.txt index 62c9a69beec..5c22e8d7f9d 100644 --- a/chromium/tools/clang/rewrite_raw_ptr_fields/manual-paths-to-ignore.txt +++ b/chromium/tools/clang/rewrite_raw_ptr_fields/manual-paths-to-ignore.txt @@ -64,11 +64,26 @@ base/observer_list.h base/containers/linked_list.h base/containers/circular_deque.h -# Performance related exclusion based on speedometer2 benchmark -third_party/blink/renderer/core/ -third_party/blink/renderer/platform/bindings/ -third_party/blink/renderer/platform/heap/ -third_party/blink/renderer/platform/wtf/ +# Exclude code that only runs inside a renderer process - renderer +# processes are excluded for now from the MiraclePtr project scope, +# because they are sensitive to performance regressions (to a much higher +# degree than, say, the Browser process). +# +# Note that some renderer-only directories are already excluded +# elsewhere - for example "v8/" is excluded in another part of this +# file. +# +# The common/ directories must be included in the rewrite as they contain code +# that is also used from the browser process. +# +# Also, note that isInThirdPartyLocation AST matcher in +# RewriteRawPtrFields.cpp explicitly includes third_party/blink +# (because it is in the same git repository as the rest of Chromium), +# but we go ahead and exclude it below. +/renderer/ # (e.g. //content/renderer/ or //components/visitedlink/renderer/). +third_party/blink/ +!third_party/blink/public/common/ +!third_party/blink/common/ # Exclude paths in separate repositories - i.e. in directories that # 1. Contain a ".git" subdirectory @@ -139,7 +154,6 @@ remoting/webapp/app_remoting/internal/ skia/tools/clusterfuzz-data/ tools/page_cycler/acid3/ tools/perf/data/ -tools/swarming_client/ ui/file_manager/internal/ v8/ webkit/data/bmp_decoder/ diff --git a/chromium/tools/clang/scripts/build.py b/chromium/tools/clang/scripts/build.py index f421cbc5c2d..3878ce4e211 100755 --- a/chromium/tools/clang/scripts/build.py +++ b/chromium/tools/clang/scripts/build.py @@ -38,7 +38,6 @@ LLVM_BOOTSTRAP_INSTALL_DIR = os.path.join(THIRD_PARTY_DIR, 'llvm-bootstrap-install') LLVM_INSTRUMENTED_DIR = os.path.join(THIRD_PARTY_DIR, 'llvm-instrumented') LLVM_PROFDATA_FILE = os.path.join(LLVM_INSTRUMENTED_DIR, 'profdata.prof') -CHROME_TOOLS_SHIM_DIR = os.path.join(LLVM_DIR, 'llvm', 'tools', 'chrometools') LLVM_BUILD_TOOLS_DIR = os.path.abspath( os.path.join(LLVM_DIR, '..', 'llvm-build-tools')) ANDROID_NDK_DIR = os.path.join( @@ -184,35 +183,13 @@ def GetCommitDescription(commit): def DeleteChromeToolsShim(): + # TODO: These dirs are no longer used. Remove this code after a while. OLD_SHIM_DIR = os.path.join(LLVM_DIR, 'tools', 'zzz-chrometools') shutil.rmtree(OLD_SHIM_DIR, ignore_errors=True) + CHROME_TOOLS_SHIM_DIR = os.path.join(LLVM_DIR, 'llvm', 'tools', 'chrometools') shutil.rmtree(CHROME_TOOLS_SHIM_DIR, ignore_errors=True) -def CreateChromeToolsShim(): - """Hooks the Chrome tools into the LLVM build. - - Several Chrome tools have dependencies on LLVM/Clang libraries. The LLVM build - detects implicit tools in the tools subdirectory, so this helper install a - shim CMakeLists.txt that forwards to the real directory for the Chrome tools. - - Note that the shim directory name intentionally has no - or _. The implicit - tool detection logic munges them in a weird way.""" - assert not any(i in os.path.basename(CHROME_TOOLS_SHIM_DIR) for i in '-_') - os.mkdir(CHROME_TOOLS_SHIM_DIR) - with open(os.path.join(CHROME_TOOLS_SHIM_DIR, 'CMakeLists.txt'), 'w') as f: - f.write('# Automatically generated by tools/clang/scripts/update.py. ' + - 'Do not edit.\n') - f.write('# Since tools/clang is located in another directory, use the \n') - f.write('# two arg version to specify where build artifacts go. CMake\n') - f.write('# disallows reuse of the same binary dir for multiple source\n') - f.write('# dirs, so the build artifacts need to go into a subdirectory.\n') - f.write('if (CHROMIUM_TOOLS_SRC)\n') - f.write(' add_subdirectory(${CHROMIUM_TOOLS_SRC} ' + - '${CMAKE_CURRENT_BINARY_DIR}/a)\n') - f.write('endif (CHROMIUM_TOOLS_SRC)\n') - - def AddCMakeToPath(args): """Download CMake and add it to PATH.""" if args.use_system_cmake: @@ -566,7 +543,7 @@ def main(): targets = 'AArch64;ARM;Mips;PowerPC;SystemZ;WebAssembly;X86' - projects = 'clang;compiler-rt;lld;chrometools;clang-tools-extra' + projects = 'clang;compiler-rt;lld;clang-tools-extra' if sys.platform == 'darwin': # clang needs libc++, else -stdlib=libc++ won't find includes @@ -595,6 +572,8 @@ def main(): '-DLLVM_ENABLE_DIA_SDK=OFF', # See crbug.com/1205046: don't build scudo (and others we don't need). '-DCOMPILER_RT_SANITIZERS_TO_BUILD=asan;dfsan;msan;hwasan;tsan;cfi', + # The default value differs per platform, force it off everywhere. + '-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF', ] if args.gcc_toolchain: @@ -892,7 +871,9 @@ def main(): '-DCMAKE_SHARED_LINKER_FLAGS=' + ' '.join(ldflags), '-DCMAKE_MODULE_LINKER_FLAGS=' + ' '.join(ldflags), '-DCMAKE_INSTALL_PREFIX=' + LLVM_BUILD_DIR, - '-DCHROMIUM_TOOLS_SRC=%s' % os.path.join(CHROMIUM_DIR, 'tools', 'clang'), + '-DLLVM_EXTERNAL_PROJECTS=chrometools', + '-DLLVM_EXTERNAL_CHROMETOOLS_SOURCE_DIR=' + + os.path.join(CHROMIUM_DIR, 'tools', 'clang'), '-DCHROMIUM_TOOLS=%s' % ';'.join(chrome_tools)] if args.pgo: cmake_args.append('-DLLVM_PROFDATA_FILE=' + LLVM_PROFDATA_FILE) @@ -922,9 +903,6 @@ def main(): elif sys.platform == 'win32': cmake_args.append('-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-pc-windows-msvc') - # TODO(crbug.com/962988): Use -DLLVM_EXTERNAL_PROJECTS instead. - CreateChromeToolsShim() - if os.path.exists(LLVM_BUILD_DIR): RmTree(LLVM_BUILD_DIR) EnsureDirExists(LLVM_BUILD_DIR) @@ -994,7 +972,7 @@ def main(): # TODO(thakis): Now that the NDK uses clang, try to build all archs in # one LLVM build instead of building 3 times. toolchain_dir = ANDROID_NDK_DIR + '/toolchains/llvm/prebuilt/linux-x86_64' - for target_arch in ['aarch64', 'arm', 'i686']: + for target_arch in ['aarch64', 'arm', 'i686', 'x86_64']: # Build compiler-rt runtimes needed for Android in a separate build tree. build_dir = os.path.join(LLVM_BUILD_DIR, 'android-' + target_arch) if not os.path.exists(build_dir): @@ -1003,7 +981,9 @@ def main(): target_triple = target_arch if target_arch == 'arm': target_triple = 'armv7' - api_level = '21' if target_arch == 'aarch64' else '19' + api_level = '19' + if target_arch == 'aarch64' or target_arch == 'x86_64': + api_level = '21' target_triple += '-linux-android' + api_level cflags = [ '--target=' + target_triple, @@ -1013,10 +993,11 @@ def main(): # depends on a newer version of libxml2.so than what's available on # the bots. To make things work, use our just-built lld as linker. '-fuse-ld=lld', - # Clang defaults to compiler-rt when targeting android after - # a478b0a199f4. Stick with libgcc for now. (crbug.com/1184398). + # The compiler we're building with (just-built clang) doesn't have the + # compiler-rt builtins; use libgcc to get past the CMake checks. '--rtlib=libgcc', ] + android_args = base_cmake_args + [ '-DCMAKE_C_COMPILER=' + os.path.join(LLVM_BUILD_DIR, 'bin/clang'), '-DCMAKE_CXX_COMPILER=' + os.path.join(LLVM_BUILD_DIR, 'bin/clang++'), @@ -1024,7 +1005,7 @@ def main(): '-DCMAKE_C_FLAGS=' + ' '.join(cflags), '-DCMAKE_CXX_FLAGS=' + ' '.join(cflags), '-DCMAKE_ASM_FLAGS=' + ' '.join(cflags), - '-DCOMPILER_RT_BUILD_BUILTINS=OFF', + '-DCOMPILER_RT_BUILD_BUILTINS=ON', '-DCOMPILER_RT_BUILD_CRT=OFF', '-DCOMPILER_RT_BUILD_LIBFUZZER=OFF', '-DCOMPILER_RT_BUILD_MEMPROF=OFF', @@ -1037,13 +1018,13 @@ def main(): '-DANDROID=1'] RunCommand(['cmake'] + android_args + [COMPILER_RT_DIR]) - # We use ASan, UBSan, coverage, and PGO on the various Android targets. - # Only build HWASan for AArch64. libs_want = [ 'lib/linux/libclang_rt.asan-{0}-android.so', + 'lib/linux/libclang_rt.builtins-{0}-android.a', 'lib/linux/libclang_rt.ubsan_standalone-{0}-android.so', 'lib/linux/libclang_rt.profile-{0}-android.a', ] + # Only build HWASan for AArch64. if target_arch == 'aarch64': libs_want += ['lib/linux/libclang_rt.hwasan-{0}-android.so'] libs_want = [lib.format(target_arch) for lib in libs_want] diff --git a/chromium/tools/clang/scripts/package.py b/chromium/tools/clang/scripts/package.py index 635634df335..b413b1384a4 100755 --- a/chromium/tools/clang/scripts/package.py +++ b/chromium/tools/clang/scripts/package.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright (c) 2015 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -53,7 +53,7 @@ def TeeCmd(cmd, logfile, fail_hard=True): stdin=open(os.devnull), stdout=subprocess.PIPE, stderr=subprocess.STDOUT) for line in iter(proc.stdout.readline,''): - Tee(line, logfile) + Tee(str(line.decode()), logfile) if proc.poll() is not None: break exit_code = proc.wait() @@ -70,7 +70,7 @@ def PrintTarProgress(tarinfo): def GetExpectedStamp(): rev_cmd = [sys.executable, os.path.join(THIS_DIR, 'update.py'), '--print-revision'] - return subprocess.check_output(rev_cmd).rstrip() + return str(subprocess.check_output(rev_cmd).decode()).rstrip() def GetGsutilPath(): @@ -93,6 +93,20 @@ def RunGsutil(args): return subprocess.call([sys.executable, GetGsutilPath()] + args) +def PackageInArchive(directory_path, archive_path): + bin_dir_path = os.path.join(directory_path, 'bin') + if sys.platform != 'win32' and os.path.exists(bin_dir_path): + for f in os.listdir(bin_dir_path): + file_path = os.path.join(bin_dir_path, f) + if not os.path.islink(file_path): + subprocess.call(['strip', file_path]) + + with tarfile.open(archive_path, 'w:gz') as tar: + for f in os.listdir(directory_path): + tar.add(os.path.join(directory_path, f), + arcname=f, filter=PrintTarProgress) + + def MaybeUpload(do_upload, filename, gcs_platform, extra_gsutil_args=[]): gsutil_args = ['cp'] + extra_gsutil_args + [ '-a', 'public-read', filename, @@ -256,7 +270,8 @@ def main(): if not args.build_mac_arm: # TODO(thakis): Figure out why this doesn't build in --build-mac-arm # builds. - want.append('lib/clang/$V/lib/x86_64-unknown-fuchsia/libclang_rt.profile.a') + want.append( + 'lib/clang/$V/lib/x86_64-unknown-fuchsia/libclang_rt.profile.a') if sys.platform != 'darwin': # The Fuchsia asan runtime is only built on non-Mac platforms. want.append('lib/clang/$V/lib/x86_64-unknown-fuchsia/libclang_rt.asan.so') @@ -306,6 +321,12 @@ def main(): 'lib/clang/$V/lib/linux/libclang_rt.asan-arm-android.so', 'lib/clang/$V/lib/linux/libclang_rt.asan-i686-android.so', + # Builtins for Android. + 'lib/clang/$V/lib/linux/libclang_rt.builtins-aarch64-android.a', + 'lib/clang/$V/lib/linux/libclang_rt.builtins-arm-android.a', + 'lib/clang/$V/lib/linux/libclang_rt.builtins-i686-android.a', + 'lib/clang/$V/lib/linux/libclang_rt.builtins-x86_64-android.a', + # HWASAN Android runtime. 'lib/clang/$V/lib/linux/libclang_rt.hwasan-aarch64-android.so', @@ -319,6 +340,7 @@ def main(): # Profile runtime (used by profiler and code coverage). 'lib/clang/$V/lib/linux/libclang_rt.profile-i386.a', + 'lib/clang/$V/lib/linux/libclang_rt.profile-i686-android.a', 'lib/clang/$V/lib/linux/libclang_rt.profile-x86_64.a', 'lib/clang/$V/lib/linux/libclang_rt.profile-aarch64-android.a', 'lib/clang/$V/lib/linux/libclang_rt.profile-arm-android.a', @@ -342,7 +364,9 @@ def main(): 'lib/clang/$V/lib/linux/libclang_rt.ubsan_standalone_cxx-x86_64.a.syms', # UndefinedBehaviorSanitizer Android runtime, needed for CFI. + # pylint: disable=line-too-long 'lib/clang/$V/lib/linux/libclang_rt.ubsan_standalone-aarch64-android.so', + # pylint: enable=line-too-long 'lib/clang/$V/lib/linux/libclang_rt.ubsan_standalone-arm-android.so', # Ignorelist for MemorySanitizer (used on Linux only). @@ -407,26 +431,6 @@ def main(): os.path.splitext(f)[1] in ['.so', '.a']): subprocess.call([EU_STRIP, '-g', dest]) - stripped_binaries = ['clang', - 'clang-tidy', - 'lld', - 'llvm-ar', - 'llvm-bcanalyzer', - 'llvm-cov', - 'llvm-cxxfilt', - 'llvm-nm', - 'llvm-objcopy', - 'llvm-objdump', - 'llvm-pdbutil', - 'llvm-profdata', - 'llvm-readobj', - 'llvm-symbolizer', - 'llvm-undname', - ] - for f in stripped_binaries: - if sys.platform != 'win32': - subprocess.call(['strip', os.path.join(pdir, 'bin', f)]) - # Set up symlinks. if sys.platform != 'win32': os.symlink('clang', os.path.join(pdir, 'bin', 'clang++')) @@ -445,12 +449,7 @@ def main(): os.path.join(pdir, 'include', 'c++')) # Create main archive. - tar_entries = ['bin', 'lib' ] - if sys.platform == 'darwin': - tar_entries += ['include'] - with tarfile.open(pdir + '.tgz', 'w:gz') as tar: - for entry in tar_entries: - tar.add(os.path.join(pdir, entry), arcname=entry, filter=PrintTarProgress) + PackageInArchive(pdir, pdir + '.tgz') MaybeUpload(args.upload, pdir + '.tgz', gcs_platform) # Upload build log next to it. @@ -468,17 +467,17 @@ def main(): for filename in ['llvm-cov', 'llvm-profdata']: shutil.copy(os.path.join(LLVM_RELEASE_DIR, 'bin', filename + exe_ext), os.path.join(code_coverage_dir, 'bin')) - with tarfile.open(code_coverage_dir + '.tgz', 'w:gz') as tar: - tar.add(os.path.join(code_coverage_dir, 'bin'), arcname='bin', - filter=PrintTarProgress) + PackageInArchive(code_coverage_dir, code_coverage_dir + '.tgz') MaybeUpload(args.upload, code_coverage_dir + '.tgz', gcs_platform) # Zip up llvm-objdump and related tools for sanitizer coverage and Supersize. objdumpdir = 'llvmobjdump-' + stamp shutil.rmtree(objdumpdir, ignore_errors=True) os.makedirs(os.path.join(objdumpdir, 'bin')) - for filename in ['llvm-bcanalyzer', 'llvm-cxxfilt', 'llvm-nm', 'llvm-objdump', - 'llvm-readobj']: + for filename in [ + 'llvm-bcanalyzer', 'llvm-cxxfilt', 'llvm-dwarfdump', 'llvm-nm', + 'llvm-objdump', 'llvm-readobj' + ]: shutil.copy(os.path.join(LLVM_RELEASE_DIR, 'bin', filename + exe_ext), os.path.join(objdumpdir, 'bin')) llvmobjdump_stamp_file_base = 'llvmobjdump_build_revision' @@ -489,11 +488,7 @@ def main(): if sys.platform != 'win32': os.symlink('llvm-objdump', os.path.join(objdumpdir, 'bin', 'llvm-otool')) os.symlink('llvm-readobj', os.path.join(objdumpdir, 'bin', 'llvm-readelf')) - with tarfile.open(objdumpdir + '.tgz', 'w:gz') as tar: - tar.add(os.path.join(objdumpdir, 'bin'), arcname='bin', - filter=PrintTarProgress) - tar.add(llvmobjdump_stamp_file, arcname=llvmobjdump_stamp_file_base, - filter=PrintTarProgress) + PackageInArchive(objdumpdir, objdumpdir + '.tgz') MaybeUpload(args.upload, objdumpdir + '.tgz', gcs_platform) # Zip up clang-tidy for users who opt into it, and Tricium. @@ -502,9 +497,7 @@ def main(): os.makedirs(os.path.join(clang_tidy_dir, 'bin')) shutil.copy(os.path.join(LLVM_RELEASE_DIR, 'bin', 'clang-tidy' + exe_ext), os.path.join(clang_tidy_dir, 'bin')) - with tarfile.open(clang_tidy_dir + '.tgz', 'w:gz') as tar: - tar.add(os.path.join(clang_tidy_dir, 'bin'), arcname='bin', - filter=PrintTarProgress) + PackageInArchive(clang_tidy_dir, clang_tidy_dir + '.tgz') MaybeUpload(args.upload, clang_tidy_dir + '.tgz', gcs_platform) if sys.platform == 'darwin': @@ -516,9 +509,7 @@ def main(): os.makedirs(os.path.join(dsymdir, 'bin')) shutil.copy(os.path.join(LLVM_RELEASE_DIR, 'bin', 'dsymutil'), os.path.join(dsymdir, 'bin')) - with tarfile.open(dsymdir + '.tgz', 'w:gz') as tar: - tar.add(os.path.join(dsymdir, 'bin'), arcname='bin', - filter=PrintTarProgress) + PackageInArchive(dsymdir, dsymdir + '.tgz') MaybeUpload(args.upload, dsymdir + '.tgz', gcs_platform) # Zip up the translation_unit tool. @@ -528,9 +519,7 @@ def main(): shutil.copy(os.path.join(LLVM_RELEASE_DIR, 'bin', 'translation_unit' + exe_ext), os.path.join(translation_unit_dir, 'bin')) - with tarfile.open(translation_unit_dir + '.tgz', 'w:gz') as tar: - tar.add(os.path.join(translation_unit_dir, 'bin'), arcname='bin', - filter=PrintTarProgress) + PackageInArchive(translation_unit_dir, translation_unit_dir + '.tgz') MaybeUpload(args.upload, translation_unit_dir + '.tgz', gcs_platform) # Zip up the libclang binaries. @@ -545,11 +534,7 @@ def main(): shutil.copy(os.path.join(LLVM_DIR, 'clang', 'bindings', 'python', 'clang', filename), os.path.join(libclang_dir, 'bindings', 'python', 'clang')) - tar_entries = ['bin', 'bindings' ] - with tarfile.open(libclang_dir + '.tgz', 'w:gz') as tar: - for entry in tar_entries: - tar.add(os.path.join(libclang_dir, entry), arcname=entry, - filter=PrintTarProgress) + PackageInArchive(libclang_dir, libclang_dir + '.tgz') MaybeUpload(args.upload, libclang_dir + '.tgz', gcs_platform) if sys.platform == 'win32' and args.upload: diff --git a/chromium/tools/clang/scripts/update.py b/chromium/tools/clang/scripts/update.py index 8e9d4231b10..b5f9205707b 100755 --- a/chromium/tools/clang/scripts/update.py +++ b/chromium/tools/clang/scripts/update.py @@ -39,7 +39,7 @@ import zipfile # https://chromium.googlesource.com/chromium/src/+/main/docs/updating_clang.md # Reverting problematic clang rolls is safe, though. # This is the output of `git describe` and is usable as a commit-ish. -CLANG_REVISION = 'llvmorg-14-init-1002-gb5e470aa' +CLANG_REVISION = 'llvmorg-14-init-5759-g02895eed' CLANG_SUB_REVISION = 1 PACKAGE_VERSION = '%s-%s' % (CLANG_REVISION, CLANG_SUB_REVISION) diff --git a/chromium/tools/code_coverage/coverage.py b/chromium/tools/code_coverage/coverage.py index dda605f16f0..8f57960b7d0 100755 --- a/chromium/tools/code_coverage/coverage.py +++ b/chromium/tools/code_coverage/coverage.py @@ -124,6 +124,9 @@ PROFDATA_FILE_NAME = os.extsep.join(['coverage', 'profdata']) # Name of the file with summary information generated by llvm-cov export. SUMMARY_FILE_NAME = os.extsep.join(['summary', 'json']) +# Name of the coverage file in lcov format generated by llvm-cov export. +LCOV_FILE_NAME = os.extsep.join(['coverage', 'lcov']) + # Build arg required for generating code coverage data. CLANG_COVERAGE_BUILD_ARG = 'use_clang_coverage' @@ -160,7 +163,8 @@ def _ConfigureLLVMCoverageTools(args): LLVM_PROFDATA_PATH = os.path.join(llvm_bin_dir, 'llvm-profdata') else: subprocess.check_call([ - 'python', 'tools/clang/scripts/update.py', '--package', 'coverage_tools' + sys.executable, 'tools/clang/scripts/update.py', '--package', + 'coverage_tools' ]) if coverage_utils.GetHostPlatform() == 'win': @@ -248,6 +252,40 @@ def _GeneratePerFileLineByLineCoverageInFormat(binary_paths, profdata_file_path, logging.debug('Finished running "llvm-cov show" command.') +def _GeneratePerFileLineByLineCoverageInLcov(binary_paths, profdata_file_path, filters, + ignore_filename_regex): + """Generates per file line-by-line coverage using "llvm-cov export". + + Args: + binary_paths: A list of paths to the instrumented binaries. + profdata_file_path: A path to the profdata file. + filters: A list of directories and files to get coverage for. + ignore_filename_regex: A regular expression for skipping source code files + with certain file paths. + """ + logging.debug('Generating per file line by line coverage reports using ' + '"llvm-cov export" command.') + for path in binary_paths: + if not os.path.exists(path): + logging.error("Binary %s does not exist", path) + subprocess_cmd = [ + LLVM_COV_PATH, 'export', '-format=lcov', + '-instr-profile=' + profdata_file_path, binary_paths[0] + ] + subprocess_cmd.extend( + ['-object=' + binary_path for binary_path in binary_paths[1:]]) + _AddArchArgumentForIOSIfNeeded(subprocess_cmd, len(binary_paths)) + subprocess_cmd.extend(filters) + if ignore_filename_regex: + subprocess_cmd.append('-ignore-filename-regex=%s' % ignore_filename_regex) + + # Write output on the disk to be used by code coverage bot. + with open(_GetLcovFilePath(), 'w') as f: + subprocess.check_call(subprocess_cmd, stdout=f) + + logging.debug('Finished running "llvm-cov export" command.') + + def _GetLogsDirectoryPath(): """Path to the logs directory.""" return os.path.join( @@ -268,6 +306,13 @@ def _GetSummaryFilePath(): SUMMARY_FILE_NAME) +def _GetLcovFilePath(): + """The LCOV file that contains coverage data written by llvm-cov export.""" + return os.path.join( + coverage_utils.GetCoverageReportRootDirPath(OUTPUT_DIR), + LCOV_FILE_NAME) + + def _CreateCoverageProfileDataForTargets(targets, commands, jobs_count=None): """Builds and runs target to generate the coverage profile data. @@ -973,8 +1018,8 @@ def _ParseCommandArguments(): '--format', type=str, default='html', - help='Output format of the "llvm-cov show" command. The supported ' - 'formats are "text" and "html".') + help='Output format of the "llvm-cov show/export" command. The ' + 'supported formats are "text", "html" and "lcov".') arg_parser.add_argument( '-v', @@ -1006,7 +1051,8 @@ def Main(): # is used by coverage bot for initial setup. if len(sys.argv) == 1: subprocess.check_call([ - 'python', 'tools/clang/scripts/update.py', '--package', 'coverage_tools' + sys.executable, 'tools/clang/scripts/update.py', '--package', + 'coverage_tools' ]) print(__doc__) return @@ -1083,14 +1129,21 @@ def Main(): binary_paths.extend( coverage_utils.GetSharedLibraries(binary_paths, BUILD_DIR, otool_path)) - assert args.format == 'html' or args.format == 'text', ( - '%s is not a valid output format for "llvm-cov show". Only "text" and ' - '"html" formats are supported.' % (args.format)) + assert args.format in ['html', 'lcov', 'text'], ( + '%s is not a valid output format for "llvm-cov show/export". Only ' + '"text", "html" and "lcov" formats are supported.' % (args.format)) logging.info('Generating code coverage report in %s (this can take a while ' 'depending on size of target!).' % (args.format)) per_file_summary_data = _GeneratePerFileCoverageSummary( binary_paths, profdata_file_path, absolute_filter_paths, args.ignore_filename_regex) + + if args.format == 'lcov': + _GeneratePerFileLineByLineCoverageInLcov( + binary_paths, profdata_file_path, absolute_filter_paths, + args.ignore_filename_regex) + return + _GeneratePerFileLineByLineCoverageInFormat( binary_paths, profdata_file_path, absolute_filter_paths, args.ignore_filename_regex, args.format) diff --git a/chromium/tools/code_coverage/coverage_test.py b/chromium/tools/code_coverage/coverage_test.py index b92850e5fb2..cb2b4ddd2bc 100755 --- a/chromium/tools/code_coverage/coverage_test.py +++ b/chromium/tools/code_coverage/coverage_test.py @@ -55,6 +55,7 @@ class CoverageTest(unittest.TestCase): 'report1_no_components') self.REPORT_DIR_2 = os.path.join(self.BUILD_DIR, 'report2') self.REPORT_DIR_3 = os.path.join(self.BUILD_DIR, 'report3') + self.REPORT_DIR_4 = os.path.join(self.BUILD_DIR, 'report4') self.LLVM_COV = os.path.join(self.CHROMIUM_SRC_DIR, 'third_party', 'llvm-build', 'Release+Asserts', 'bin', @@ -126,6 +127,15 @@ class CoverageTest(unittest.TestCase): self.assertGreater(data.count('crypto'), 100) self.assertGreater(data.count('libpng'), 10) + def verify_lcov_file(self, filepath): + """Asserts that a given lcov file looks correct.""" + with open(filepath) as f: + data = f.read() + + self.assertGreater(data.count('SF:'), 100) + self.assertGreater(data.count('crypto'), 100) + self.assertGreater(data.count('libpng'), 10) + def test_different_workflows_and_cross_check_the_results(self): """Test a few different workflows and assert that the results are the same @@ -266,7 +276,7 @@ class CoverageTest(unittest.TestCase): summary_output = self.run_cmd(cmd) summary_path = os.path.join(self.REPORT_DIR_3, 'summary.json') - with open(summary_path, 'w') as f: + with open(summary_path, 'wb') as f: f.write(summary_output) cmd = [ @@ -296,6 +306,28 @@ class CoverageTest(unittest.TestCase): self.assertEqual(report_1_file_view_data_no_component, report_3_file_view_data) + # Testcase 4. Export coverage data in lcov format using coverage.py script. + cmd = [ + self.COVERAGE_SCRIPT, + 'crypto_unittests', + 'libpng_read_fuzzer', + '--format', + 'lcov', + '-v', + '-b', + self.BUILD_DIR, + '-o', + self.REPORT_DIR_4, + '-c' + '%s/crypto_unittests' % self.BUILD_DIR, + '-c', + '%s/libpng_read_fuzzer -runs=0 third_party/libpng/' % self.BUILD_DIR, + ] + self.run_cmd(cmd) + + output_dir = os.path.join(self.REPORT_DIR_4, self.PLATFORM) + self.verify_lcov_file(os.path.join(output_dir, 'coverage.lcov')) + if __name__ == '__main__': unittest.main() diff --git a/chromium/tools/cr/cr/base/context.py b/chromium/tools/cr/cr/base/context.py index 850832867b5..1becf073c0f 100644 --- a/chromium/tools/cr/cr/base/context.py +++ b/chromium/tools/cr/cr/base/context.py @@ -169,15 +169,16 @@ class Context(cr.config.Config): Overrides CR_DRY_RUN """ ) - parser.add_argument( - '-v', '--verbose', dest='CR_VERBOSE', - action='count', default=None, - help=""" + parser.add_argument('-v', + '--verbose', + dest='CR_VERBOSE', + action='count', + default=0, + help=""" Print information about commands being performed. Repeating multiple times increases the verbosity level. Overrides CR_VERBOSE - """ - ) + """) @property def args(self): @@ -209,8 +210,8 @@ class Context(cr.config.Config): @property def verbose(self): if self.autocompleting: - return False - return self.Find('CR_VERBOSE') or self.dry_run + return 0 + return self.Find('CR_VERBOSE') or (self.dry_run and 1 or 0) @property def dry_run(self): diff --git a/chromium/tools/cr/cr/base/host.py b/chromium/tools/cr/cr/base/host.py index 35e03deca41..4e68488d7f4 100644 --- a/chromium/tools/cr/cr/base/host.py +++ b/chromium/tools/cr/cr/base/host.py @@ -117,6 +117,8 @@ class Host(cr.Plugin, cr.Plugin.Type): if p.returncode != 0: print('Error {0} executing command {1}'.format(p.returncode, command)) exit(p.returncode) + if output is not None: + output = output.decode('utf-8') return output or '' return '' diff --git a/chromium/tools/cygprofile/cluster.py b/chromium/tools/cygprofile/cluster.py index 37f8de30b77..6bc0394cc91 100644 --- a/chromium/tools/cygprofile/cluster.py +++ b/chromium/tools/cygprofile/cluster.py @@ -173,7 +173,7 @@ class Clustering(object): neighbors = [] for sym_list in sym_lists: for i, s in enumerate(sym_list): - for j in xrange(i + 1, min(i + self.NEIGHBOR_DISTANCE, len(sym_list))): + for j in range(i + 1, min(i + self.NEIGHBOR_DISTANCE, len(sym_list))): if s == sym_list[j]: # Free functions that are static inline seem to be the only # source of these duplicates. @@ -265,7 +265,7 @@ def _GetOffsetSymbolName(processor, dump_offset): dump_offset_to_symbol_info = \ processor.GetDumpOffsetToSymboInfolIncludingWhitelist() offset_to_primary = processor.OffsetToPrimaryMap() - idx = dump_offset / 2 + idx = dump_offset // 2 assert dump_offset >= 0 and idx < len(dump_offset_to_symbol_info), ( 'Dump offset out of binary range') symbol_info = dump_offset_to_symbol_info[idx] @@ -294,17 +294,17 @@ def _GetSymbolsCallGraph(profiles, processor): # |process_type| can be : browser, renderer, gpu-process, etc. for process_type in offsets_graph: for process in offsets_graph[process_type]: - process = sorted(process, key=lambda k: long(k['index'])) + process = sorted(process, key=lambda k: int(k['index'])) graph_list = [] for el in process: - index = long(el['index']) + index = int(el['index']) callee_symbol = _GetOffsetSymbolName(processor, - long(el['callee_offset'])) + int(el['callee_offset'])) misses = 0 caller_and_count = [] for bucket in el['caller_and_count']: - caller_offset = long(bucket['caller_offset']) - count = long(bucket['count']) + caller_offset = int(bucket['caller_offset']) + count = int(bucket['count']) if caller_offset == 0: misses += count continue diff --git a/chromium/tools/cygprofile/cyglog_to_orderfile_unittest.py b/chromium/tools/cygprofile/cyglog_to_orderfile_unittest.py index 6e5a246e7e6..0575cd7275a 100755 --- a/chromium/tools/cygprofile/cyglog_to_orderfile_unittest.py +++ b/chromium/tools/cygprofile/cyglog_to_orderfile_unittest.py @@ -63,7 +63,7 @@ class TestCyglogToOrderfile(unittest.TestCase): else: try: self.assertListEqual(sorted(expected[i]), sorted(observed[i])) - except self.failureException, e: + except self.failureException as e: raise self.failureException('For key {}: {}'.format(i, e)) for i in observed: # All i that are in expected have already been tested. diff --git a/chromium/tools/cygprofile/orderfile_generator_backend.py b/chromium/tools/cygprofile/orderfile_generator_backend.py index b9f0200f52a..8a030e608a9 100755 --- a/chromium/tools/cygprofile/orderfile_generator_backend.py +++ b/chromium/tools/cygprofile/orderfile_generator_backend.py @@ -54,9 +54,9 @@ constants.SetBuildType('Release') # Architecture specific GN args. Trying to build an orderfile for an # architecture not listed here will eventually throw. _ARCH_GN_ARGS = { - 'arm': [ 'target_cpu = "arm"' ], - 'arm64': [ 'target_cpu = "arm64"', - 'android_64bit_browser = true'], + 'arm': ['target_cpu = "arm"'], + 'arm64': ['target_cpu = "arm64"', 'android_64bit_browser = true'], + 'x86': ['target_cpu = "x86"'], } class CommandError(Exception): @@ -484,7 +484,11 @@ class OrderfileGenerator(object): def _GetPathToOrderfile(self): """Gets the path to the architecture-specific orderfile.""" - return self._path_to_orderfile % self._options.arch + # Build GN files use the ".arm" orderfile irrespective of the actual + # architecture. Fake it, otherwise the orderfile we generate here is not + # going to be picked up by builds. + orderfile_fake_arch = 'arm' + return self._path_to_orderfile % orderfile_fake_arch def _GetUnpatchedOrderfileFilename(self): """Gets the path to the architecture-specific unpatched orderfile.""" @@ -894,6 +898,7 @@ class OrderfileGenerator(object): Returns: benchmark_results: (dict) Results extracted from benchmarks. """ + benchmark_results = {} try: _UnstashOutputDirectory(out_directory) self._compiler = ClankCompiler(out_directory, self._step_recorder, @@ -913,7 +918,6 @@ class OrderfileGenerator(object): self._compiler.CompileChromeApk(instrumented=False, use_call_graph=False, force_relink=True) - benchmark_results = dict() benchmark_results['Speedometer2.0'] = self._PerformanceBenchmark( self._compiler.chrome_apk) benchmark_results['orderfile.memory_mobile'] = ( @@ -1051,9 +1055,11 @@ def CreateArgumentParser(): parser.add_argument( '--verify', action='store_true', help='If true, the script only verifies the current orderfile') - parser.add_argument('--target-arch', action='store', dest='arch', + parser.add_argument('--target-arch', + action='store', + dest='arch', default='arm', - choices=['arm', 'arm64'], + choices=list(_ARCH_GN_ARGS.keys()), help='The target architecture for which to build.') parser.add_argument('--output-json', action='store', dest='json_file', help='Location to save stats in json format') @@ -1135,6 +1141,14 @@ def CreateOrderfile(options, orderfile_updater_class=None): logging.basicConfig(level=logging.INFO) devil_chromium.Initialize(adb_path=options.adb_path) + # Since we generate a ".arm" orderfile irrespective of the architecture (see + # comment in _GetPathToOrderfile()), make sure that we don't commit it. + if options.arch != 'arm': + assert not options.buildbot, ( + 'ARM is the only supported architecture on bots') + assert not options.upload_ready_orderfiles, ( + 'ARM is the only supported architecture on bots') + generator = OrderfileGenerator(options, orderfile_updater_class) try: if options.verify: diff --git a/chromium/tools/cygprofile/patch_orderfile.py b/chromium/tools/cygprofile/patch_orderfile.py index 63cefd96c8c..7f3495162d9 100755 --- a/chromium/tools/cygprofile/patch_orderfile.py +++ b/chromium/tools/cygprofile/patch_orderfile.py @@ -174,7 +174,7 @@ def _PatchedSymbols(symbol_to_matching, profiled_symbols, max_outlined_index): # guarantee ordering after code changes before the next orderfile is # generated. So we double the number of outlined functions as a measure of # security. - for idx in xrange(2 * max_outlined_index + 1): + for idx in range(2 * max_outlined_index + 1): yield _OUTLINED_FUNCTION_FORMAT.format(idx) @@ -189,7 +189,7 @@ def ReadOrderfile(orderfile): Symbol names, cleaned and unique. """ with open(orderfile) as f: - for line in f.xreadlines(): + for line in f: line = line.strip() if line: yield line diff --git a/chromium/tools/cygprofile/patch_orderfile_unittest.py b/chromium/tools/cygprofile/patch_orderfile_unittest.py index 45644fa31ca..699a1e8619d 100755 --- a/chromium/tools/cygprofile/patch_orderfile_unittest.py +++ b/chromium/tools/cygprofile/patch_orderfile_unittest.py @@ -51,14 +51,15 @@ class TestPatchOrderFile(unittest.TestCase): def testPatchedSymbolsWithOutlining(self): # As above, but add outlined functions at the end. The aliased outlined # function should be ignored. - self.assertEquals(list('abd') + - ['OUTLINED_FUNCTION_{}'.format(i) - for i in xrange(5)], - list(patch_orderfile._PatchedSymbols( - {'a': 'a', - 'b': ['b', 'OUTLINED_FUNCTION_4'], - 'd': 'd'}, - ['a', 'b', 'OUTLINED_FUNCTION_2', 'c', 'd'], 2))) + self.assertEquals( + list('abd') + ['OUTLINED_FUNCTION_{}'.format(i) for i in range(5)], + list( + patch_orderfile._PatchedSymbols( + { + 'a': 'a', + 'b': ['b', 'OUTLINED_FUNCTION_4'], + 'd': 'd' + }, ['a', 'b', 'OUTLINED_FUNCTION_2', 'c', 'd'], 2))) if __name__ == '__main__': diff --git a/chromium/tools/cygprofile/process_profiles.py b/chromium/tools/cygprofile/process_profiles.py index 7fcdd06c502..18650b85725 100755 --- a/chromium/tools/cygprofile/process_profiles.py +++ b/chromium/tools/cygprofile/process_profiles.py @@ -25,10 +25,10 @@ def _Median(items): return None sorted_items = sorted(items) if len(sorted_items) & 1: - return sorted_items[len(sorted_items)/2] + return sorted_items[len(sorted_items) // 2] else: - return (sorted_items[len(sorted_items)/2 - 1] + - sorted_items[len(sorted_items)/2]) / 2 + return (sorted_items[len(sorted_items) // 2 - 1] + + sorted_items[len(sorted_items) // 2]) // 2 class SymbolOffsetProcessor(object): @@ -204,7 +204,7 @@ class SymbolOffsetProcessor(object): """ our_symbol_names = set(s.name for s in self.SymbolInfos()) matched_names = our_symbol_names.intersection(set(symbol_names)) - return [self.NameToSymbolMap()[n] for n in matched_names] + return sorted([self.NameToSymbolMap()[n] for n in matched_names]) def TranslateAnnotatedSymbolOffsets(self, annotated_offsets): """Merges offsets across run groups and translates to symbol offsets. @@ -237,7 +237,7 @@ class SymbolOffsetProcessor(object): dump_offset_to_symbol_info = self.GetDumpOffsetToSymbolInfo() for i in items: dump_offset = get(i) - idx = dump_offset / 2 + idx = dump_offset // 2 assert dump_offset >= 0 and idx < len(dump_offset_to_symbol_info), ( 'Dump offset out of binary range') symbol_info = dump_offset_to_symbol_info[idx] @@ -275,7 +275,7 @@ class SymbolOffsetProcessor(object): if sym.size != 0 or sym.offset == start_of_text: continue self._whitelist.add(sym.name) - idx = (sym.offset - start_of_text)/ 2 + idx = (sym.offset - start_of_text) // 2 assert self._offset_to_symbol_info[idx] == sym, ( 'Unexpected unset offset') idx += 1 @@ -297,7 +297,7 @@ class SymbolOffsetProcessor(object): assert len(start_syms) == 1, 'Can\'t find unique start of text symbol' start_of_text = start_syms[0].offset max_offset = max(s.offset + s.size for s in self.SymbolInfos()) - text_length_halfwords = (max_offset - start_of_text) / 2 + text_length_halfwords = (max_offset - start_of_text) // 2 self._offset_to_symbol_info = [None] * text_length_halfwords for sym in self.SymbolInfos(): offset = sym.offset - start_of_text @@ -306,7 +306,7 @@ class SymbolOffsetProcessor(object): # The low bit of offset may be set to indicate a thumb instruction. The # actual offset is still halfword aligned and so the low bit may be # safely ignored in the division by two below. - for i in range(offset / 2, (offset + sym.size) / 2): + for i in range(offset // 2, (offset + sym.size) // 2): assert i < text_length_halfwords other_symbol = self._offset_to_symbol_info[i] # There may be overlapping symbols, for example fancy @@ -316,7 +316,7 @@ class SymbolOffsetProcessor(object): self._offset_to_symbol_info[i] = sym if sym.name != symbol_extractor.START_OF_TEXT_SYMBOL and sym.size == 0: - idx = offset / 2 + idx = offset // 2 assert (self._offset_to_symbol_info[idx] is None or self._offset_to_symbol_info[idx].size == 0), ( 'Unexpected symbols overlapping') @@ -390,10 +390,10 @@ class ProfileManager(object): return self._count.get((phase, process), 0) def Processes(self): - return set(k[1] for k in self._count.iterkeys()) + return set(k[1] for k in self._count.keys()) def Phases(self): - return set(k[0] for k in self._count.iterkeys()) + return set(k[0] for k in self._count.keys()) def Offset(self): return self._offset @@ -478,12 +478,12 @@ class ProfileManager(object): return offsets_by_process def _SanityCheckAllCallsCapturedByTheInstrumentation(self, process_info): - total_calls_count = long(process_info['total_calls_count']) + total_calls_count = int(process_info['total_calls_count']) call_graph = process_info['call_graph'] count = 0 for el in call_graph: for bucket in el['caller_and_count']: - count += long(bucket['count']) + count += int(bucket['count']) # This is a sanity check to ensure the number of race-related # inconsistencies is small. @@ -580,8 +580,8 @@ class ProfileManager(object): assert self._run_groups if len(self._run_groups) < 5: return # Small runs have too much variance for testing. - sizes = map(lambda g: len(g.Filenames()), self._run_groups) - avg_size = sum(sizes) / len(self._run_groups) + sizes = list(map(lambda g: len(g.Filenames()), self._run_groups)) + avg_size = sum(sizes) // len(self._run_groups) num_outliers = len([s for s in sizes if s > 1.5 * avg_size or s < 0.75 * avg_size]) expected_outliers = 0.1 * len(self._run_groups) diff --git a/chromium/tools/cygprofile/process_profiles_unittest.py b/chromium/tools/cygprofile/process_profiles_unittest.py index fa3a209efc2..5c07797d508 100755 --- a/chromium/tools/cygprofile/process_profiles_unittest.py +++ b/chromium/tools/cygprofile/process_profiles_unittest.py @@ -104,7 +104,7 @@ class ProcessProfilesTestCase(unittest.TestCase): SimpleTestSymbol('Y', 60, 5), SimpleTestSymbol('X', 100, 10)] processor = TestSymbolOffsetProcessor(symbols) - self.assertListEqual(symbols[1:3], + self.assertListEqual(sorted(symbols[1:3]), processor.MatchSymbolNames(['Y', 'X'])) def testSymbolsSize(self): @@ -143,7 +143,7 @@ class ProcessProfilesTestCase(unittest.TestCase): def testRunGroupSanity(self): files = [] # Generate 20 sets of files in groups separated by 60s. - for ts_base in xrange(0, 20): + for ts_base in range(0, 20): ts = ts_base * 60 files.extend([ProfileFile(ts, 0, 'browser'), ProfileFile(ts + 1, 0, 'renderer'), @@ -154,11 +154,11 @@ class ProcessProfilesTestCase(unittest.TestCase): # The following call should not assert. process_profiles.ProfileManager(files)._ComputeRunGroups() - files.extend([ProfileFile(20 * 60, 0, 'browser'), - ProfileFile(20 * 60 + 2, 1, 'renderer'), - ProfileFile(21 * 60, 0, 'browser')] + - [ProfileFile(22 * 60, 0, 'renderer') - for _ in xrange(0, 10)]) + files.extend([ + ProfileFile(20 * 60, 0, 'browser'), + ProfileFile(20 * 60 + 2, 1, 'renderer'), + ProfileFile(21 * 60, 0, 'browser') + ] + [ProfileFile(22 * 60, 0, 'renderer') for _ in range(0, 10)]) self.assertRaises(AssertionError, process_profiles.ProfileManager(files)._ComputeRunGroups) @@ -219,7 +219,7 @@ class ProcessProfilesTestCase(unittest.TestCase): ProfileFile(51, 1, 'gpu-process'): [6, 7], ProfileFile(70, 0, ''): [2, 8, 9], ProfileFile(70, 1, ''): [9]}) - offsets = mgr.GetAnnotatedOffsets() + offsets = list(mgr.GetAnnotatedOffsets()) self.assertListEqual([ self.MakeAnnotatedOffset(1, {(0, 'browser'): 1}), self.MakeAnnotatedOffset(2, {(0, 'browser'): 2, diff --git a/chromium/tools/cygprofile/symbol_extractor.py b/chromium/tools/cygprofile/symbol_extractor.py index 96710854dae..d8e734c288c 100644 --- a/chromium/tools/cygprofile/symbol_extractor.py +++ b/chromium/tools/cygprofile/symbol_extractor.py @@ -162,7 +162,7 @@ def _SymbolInfosFromStream(objdump_lines): name_to_offsets = collections.defaultdict(list) symbol_infos = [] for line in objdump_lines: - symbol_info = _FromObjdumpLine(line.rstrip('\n')) + symbol_info = _FromObjdumpLine(line.decode('utf-8').rstrip('\n')) if symbol_info is not None: # On ARM the LLD linker inserts pseudo-functions (thunks) that allow # jumping distances farther than 16 MiB. Such thunks are known to often @@ -174,9 +174,10 @@ def _SymbolInfosFromStream(objdump_lines): # Outlined functions are known to be repeated often, so ignore them in the # repeated symbol count. - repeated_symbols = filter(lambda s: len(name_to_offsets[s]) > 1, - (k for k in name_to_offsets.keys() - if not k.startswith('OUTLINED_FUNCTION_'))) + repeated_symbols = list( + filter(lambda s: len(name_to_offsets[s]) > 1, + (k for k in name_to_offsets.keys() + if not k.startswith('OUTLINED_FUNCTION_')))) if repeated_symbols: # Log the first 5 repeated offsets of the first 10 repeated symbols. logging.warning('%d symbols repeated with multiple offsets:\n %s', @@ -224,6 +225,7 @@ def _SymbolInfosFromLlvmNm(lines): """ symbol_names = [] for line in lines: + line = line.decode('utf-8') m = _LLVM_NM_LINE_RE.match(line) assert m is not None, line if m.group('symbol_type') not in ['t', 'T', 'w', 'W']: @@ -251,7 +253,7 @@ def SymbolNamesFromLlvmBitcodeFile(filename): Returns: [str] A list of symbol names, can be empty. """ - command = (_NM_PATH, '-defined-only', filename) + command = (_NM_PATH, '--defined-only', filename) p = subprocess.Popen(command, shell=False, stdout=subprocess.PIPE, stderr=subprocess.PIPE) try: @@ -316,7 +318,7 @@ def CreateNameToSymbolInfo(symbol_infos): # check_orderfile. symbol_infos_by_name = {} warnings = cygprofile_utils.WarningCollector(_MAX_WARNINGS_TO_PRINT) - for infos in GroupSymbolInfosByName(symbol_infos).itervalues(): + for infos in GroupSymbolInfosByName(symbol_infos).values(): first_symbol_info = min(infos, key=lambda x: x.offset) symbol_infos_by_name[first_symbol_info.name] = first_symbol_info if len(infos) > 1: @@ -332,5 +334,6 @@ def DemangleSymbol(mangled_symbol): """Return the demangled form of mangled_symbol.""" cmd = [host_paths.ToolPath('c++filt', _arch)] process = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE) - demangled_symbol, _ = process.communicate(mangled_symbol + '\n') + demangled_symbol, _ = process.communicate( + (mangled_symbol + '\n').encode('utf-8')) return demangled_symbol diff --git a/chromium/tools/determinism/OWNERS b/chromium/tools/determinism/OWNERS index a0b7be428c3..4ec83adf33b 100644 --- a/chromium/tools/determinism/OWNERS +++ b/chromium/tools/determinism/OWNERS @@ -3,7 +3,6 @@ dpranke@google.com erikchen@chromium.org -sebmarchand@chromium.org thakis@chromium.org tikuta@chromium.org yyanagisawa@chromium.org diff --git a/chromium/tools/flags/list_flags.py b/chromium/tools/flags/list_flags.py index e43cdf86556..f77278bf956 100755 --- a/chromium/tools/flags/list_flags.py +++ b/chromium/tools/flags/list_flags.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -27,7 +27,7 @@ import owners def load_metadata(): flags_path = os.path.join(ROOT_PATH, 'chrome', 'browser', 'flag-metadata.json') - return json5.load(open(flags_path, encoding='utf-8')) + return json5.load(open(flags_path)) def keep_expired_by(flags, mstone): @@ -89,7 +89,7 @@ def find_unused(flags): 'chrome/browser/about_flags.cc', 'ios/chrome/browser/flags/about_flags.mm', ] - flag_files_data = [open(f, 'rb', encoding='utf-8').read() for f in FLAG_FILES] + flag_files_data = [open(f, 'r', encoding='utf-8').read() for f in FLAG_FILES] unused_flags = [] for flag in flags: # Search for the name in quotes. diff --git a/chromium/tools/fuchsia/DIR_METADATA b/chromium/tools/fuchsia/DIR_METADATA index 11f5ec90ebb..5b3985ecc8b 100644 --- a/chromium/tools/fuchsia/DIR_METADATA +++ b/chromium/tools/fuchsia/DIR_METADATA @@ -6,8 +6,5 @@ # For the schema of this file, see Metadata message: # https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/tools/dirmd/proto/dir_metadata.proto -monorail { - component: "Fuchsia" -} -team_email: "cr-fuchsia@chromium.org" +mixins: "//build/fuchsia/COMMON_METADATA" os: FUCHSIA
\ No newline at end of file diff --git a/chromium/tools/fuchsia/local-sdk.py b/chromium/tools/fuchsia/local-sdk.py index 2162657e60a..e0185d3cafd 100755 --- a/chromium/tools/fuchsia/local-sdk.py +++ b/chromium/tools/fuchsia/local-sdk.py @@ -34,16 +34,9 @@ def EnsureEmptyDir(path): def BuildForArch(arch): - Run( - 'scripts/fx', - '--dir', - 'out/release-{}'.format(arch), - 'set', - 'terminal.qemu-{}'.format(arch), - '--args=is_debug=false', - '--args=build_sdk_archives=true', - # Increase the size of the image to allow multiple test runs. - '--args=fvm_image_size={}'.format(512 * 1024 * 1024)) + Run('scripts/fx', '--dir', 'out/release-{}'.format(arch), 'set', + 'terminal.qemu-{}'.format(arch), '--args=is_debug=false', + '--args=build_sdk_archives=true') Run('scripts/fx', 'build', 'sdk', 'build/images') diff --git a/chromium/tools/git/mass-rename.py b/chromium/tools/git/mass-rename.py index 3f05bbb57d1..54c482fc6c8 100755 --- a/chromium/tools/git/mass-rename.py +++ b/chromium/tools/git/mass-rename.py @@ -27,6 +27,7 @@ def main(): popen = subprocess.Popen('git diff --cached --raw -M', shell=True, stdout=subprocess.PIPE) out, _ = popen.communicate() + out = out.decode('utf-8') if popen.returncode != 0: return 1 lines = out.splitlines() diff --git a/chromium/tools/git/mffr.py b/chromium/tools/git/mffr.py index 563eb40a896..fc38d25b1dd 100755 --- a/chromium/tools/git/mffr.py +++ b/chromium/tools/git/mffr.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright (c) 2013 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -37,8 +37,11 @@ import sys # quotes for CreateProcess(), rather than |, <, >, etc. through multiple layers # of cmd. if sys.platform == 'win32': - _git = os.path.normpath(os.path.join(subprocess.check_output( - 'git bash -c "cd / && pwd -W"', shell=True).strip(), 'bin\\git.exe')) + _git = os.path.normpath( + os.path.join( + subprocess.check_output('git bash -c "cd / && pwd -W"', + shell=True).decode('utf-8').strip(), + 'bin\\git.exe')) else: _git = 'git' @@ -74,13 +77,13 @@ def MultiFileFindReplace(original, replacement, file_globs): referees = out.splitlines() for referee in referees: - with open(referee) as f: + with open(referee, encoding='utf-8') as f: original_contents = f.read() contents = re.sub(original, replacement, original_contents) if contents == original_contents: raise Exception('No change in file %s although matched in grep' % referee) - with open(referee, 'wb') as f: + with open(referee, mode='w', encoding='utf-8') as f: f.write(contents) return referees diff --git a/chromium/tools/git/move_source_file.bat b/chromium/tools/git/move_source_file.bat index eb988350150..4f61fc424d9 100755 --- a/chromium/tools/git/move_source_file.bat +++ b/chromium/tools/git/move_source_file.bat @@ -3,4 +3,4 @@ setlocal :: This is required with cygwin only. PATH=%~dp0;%PATH% set PYTHONDONTWRITEBYTECODE=1 -call python "%~dp0move_source_file.py" %* +call python3 "%~dp0move_source_file.py" %* diff --git a/chromium/tools/git/move_source_file.py b/chromium/tools/git/move_source_file.py index f7a2a20f6db..9c03343c3cf 100755 --- a/chromium/tools/git/move_source_file.py +++ b/chromium/tools/git/move_source_file.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -27,10 +27,9 @@ import sys import mffr if __name__ == '__main__': - # Need to add the directory containing sort-headers.py to the Python + # Need to add the directory containing sort_sources.py to the Python # classpath. sys.path.append(os.path.abspath(os.path.join(sys.path[0], '..'))) -sort_headers = __import__('sort-headers') import sort_sources @@ -65,21 +64,6 @@ def MakeDestinationPath(from_path, to_path): return to_path -def UpdateIncludePathForBlink(path): - """Updates |path| as it would be when used in an include statement in Blink. - - As Blink has its 'public' and 'Source' folders in the include search path, - these prefixes of file paths are not included in include statements. For - example, if |path| is 'public/foo/bar.h', the matching include statement - is '#include "foo/bar.h"'. - """ - for prefix in ('public/', 'Source/'): - if path.startswith(prefix): - return path[len(prefix):] - - return path - - def MoveFile(from_path, to_path): """Performs a git mv command to move a file from |from_path| to |to_path|. """ @@ -87,36 +71,20 @@ def MoveFile(from_path, to_path): raise Exception('Fatal: Failed to run git mv command.') -def UpdateIncludes(from_path, to_path, in_blink): +def UpdateIncludes(from_path, to_path): """Updates any includes of |from_path| to |to_path|. Paths supplied to this function have been mapped to forward slashes. """ - from_include_path = from_path - to_include_path = to_path - if in_blink: - from_include_path = UpdateIncludePathForBlink(from_include_path) - to_include_path = UpdateIncludePathForBlink(to_include_path) - # This handles three types of include/imports: # . C++ includes. # . Object-C imports # . Imports in mojom files. files_with_changed_includes = mffr.MultiFileFindReplace( - r'(#?(include|import)\s*["<])%s([>"]);?' % re.escape(from_include_path), - r'\1%s\3' % to_include_path, - ['*.cc', '*.h', '*.m', '*.mm', '*.cpp', '*.mojom']) - - # Reorder headers in files that changed. - for changed_file in files_with_changed_includes: - - def AlwaysConfirm(a, b): - return True - - sort_headers.FixFileWithConfirmFunction(changed_file, AlwaysConfirm, True, - in_blink) + r'(#?(include|import)\s*["<])%s([>"]);?' % re.escape(from_path), + r'\1%s\3' % to_path, ['*.cc', '*.h', '*.m', '*.mm', '*.cpp', '*.mojom']) -def UpdatePostMove(from_path, to_path, in_blink): +def UpdatePostMove(from_path, to_path): """Given a file that has moved from |from_path| to |to_path|, updates the moved file's include guard to match the new path and updates all references to the file in other source files. Also tries @@ -128,13 +96,13 @@ def UpdatePostMove(from_path, to_path, in_blink): extension = os.path.splitext(from_path)[1] if extension in ['.h', '.hh', '.mojom']: - UpdateIncludes(from_path, to_path, in_blink) + UpdateIncludes(from_path, to_path) if extension == '.mojom': # For mojom files, update includes of generated headers. - UpdateIncludes(from_path + '.h', to_path + '.h', in_blink) - UpdateIncludes(from_path + '-blink.h', to_path + '-blink.h', in_blink) - UpdateIncludes(from_path + '-shared.h', to_path + '-shared.h', in_blink) - UpdateIncludes(from_path + '-forward.h', to_path + '-forward.h', in_blink) + UpdateIncludes(from_path + '.h', to_path + '.h') + UpdateIncludes(from_path + '-blink.h', to_path + '-blink.h') + UpdateIncludes(from_path + '-shared.h', to_path + '-shared.h') + UpdateIncludes(from_path + '-forward.h', to_path + '-forward.h') else: UpdateIncludeGuard(from_path, to_path) @@ -243,8 +211,6 @@ def main(): cwd = os.getcwd() parent = os.path.dirname(cwd) - in_blink = (os.path.basename(parent) == 'third_party' and - os.path.basename(cwd) == 'WebKit') parser = optparse.OptionParser(usage='%prog FROM_PATH... TO_PATH') parser.add_option('--already_moved', action='store_true', @@ -278,7 +244,7 @@ def main(): to_path = MakeDestinationPath(from_path, orig_to_path) if not opts.already_moved: MoveFile(from_path, to_path) - UpdatePostMove(from_path, to_path, in_blink) + UpdatePostMove(from_path, to_path) return 0 diff --git a/chromium/tools/grit/grit/format/data_pack.py b/chromium/tools/grit/grit/format/data_pack.py index b180bf6d5cc..37f29d49b65 100755 --- a/chromium/tools/grit/grit/format/data_pack.py +++ b/chromium/tools/grit/grit/format/data_pack.py @@ -284,9 +284,9 @@ def RePackFromDataPackStrings(inputs, duplicate_keys = set(input_resources.keys()) & set(resources.keys()) if duplicate_keys: raise KeyError( - 'Duplicate resource IDs: ' + str(list(duplicate_keys)) + '. ' - 'This is likely because the reserved ID ranges defined in' + - 'tools/gritsettings/resource_ids.spec have been exhausted.') + 'Duplicate resource IDs: ' + str(list(duplicate_keys)) + '. ' + 'This is likely because the reserved ID ranges defined in ' + + 'tools/gritsettings/resource_ids.spec have been exhausted.') # Make sure encoding is consistent. if encoding in (None, BINARY): diff --git a/chromium/tools/grit/grit/node/base.py b/chromium/tools/grit/grit/node/base.py index 7f373b4cab4..a0a77c6aeab 100644 --- a/chromium/tools/grit/grit/node/base.py +++ b/chromium/tools/grit/grit/node/base.py @@ -496,6 +496,8 @@ class Node(object): value = target_platform == 'android' elif name == 'is_ios': value = target_platform == 'ios' + elif name == 'is_fuchsia': + value = target_platform == 'fuchsia' elif name == 'is_bsd': value = 'bsd' in target_platform elif name == 'is_posix': diff --git a/chromium/tools/grit/grit_defines.gni b/chromium/tools/grit/grit_defines.gni index 0039f04a75e..6bf3b8b3e42 100644 --- a/chromium/tools/grit/grit_defines.gni +++ b/chromium/tools/grit/grit_defines.gni @@ -5,15 +5,23 @@ import("//build/config/chrome_build.gni") import("//build/config/chromeos/ui_mode.gni") import("//build/config/crypto.gni") +import("//build/config/devtools.gni") import("//build/config/ui.gni") +shared_intermediate_dir = rebase_path(root_gen_dir, root_build_dir) +devtools_grd_path = "$shared_intermediate_dir/$devtools_grd_location" +devtools_grd_path_no_ext = get_path_info(devtools_grd_path, "dir") + "/" + + get_path_info(devtools_grd_path, "name") + grit_defines = [ "-E", "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir), "-E", "root_src_dir=" + rebase_path("//", root_build_dir), "-D", - "SHARED_INTERMEDIATE_DIR=" + rebase_path(root_gen_dir, root_build_dir), + "SHARED_INTERMEDIATE_DIR=" + shared_intermediate_dir, + "-D", + "DEVTOOLS_GRD_PATH=" + devtools_grd_path_no_ext, ] if (is_mac || is_win || is_linux || is_chromeos || is_ios) { @@ -69,13 +77,6 @@ if (is_linux || is_chromeos_lacros) { ] } -if (is_fuchsia) { - grit_defines += [ - "-D", - "is_fuchsia", - ] -} - if (toolkit_views) { grit_defines += [ "-D", @@ -143,4 +144,10 @@ if (current_toolchain != host_toolchain) { "win32", ] } + if (is_fuchsia) { + grit_defines += [ + "-t", + "fuchsia", + ] + } } diff --git a/chromium/tools/grit/minify_with_uglify.py b/chromium/tools/grit/minify_with_uglify.py index 5cfb04e0a9d..640e855dcd5 100755 --- a/chromium/tools/grit/minify_with_uglify.py +++ b/chromium/tools/grit/minify_with_uglify.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. diff --git a/chromium/tools/gritsettings/resource_ids.spec b/chromium/tools/gritsettings/resource_ids.spec index 628fa47e4f2..4e80d8de308 100644 --- a/chromium/tools/gritsettings/resource_ids.spec +++ b/chromium/tools/gritsettings/resource_ids.spec @@ -30,6 +30,10 @@ # "META": {"join": <duplicate count>}, # for the item following duplicates. Be sure to look for duplicates that # may appear earlier than those that immediately precede the item. +# * Periodically we might need to refresh this file to make more space for +# numbers. The command lines to do this (from current directory) are: +# $ python ../grit/grit.py update_resource_ids --fake resource_ids.spec > temp +# $ mv temp resource_ids.spec { # The first entry in the file, SRCDIR, is special: It is a relative path from # this file to the base of your checkout. @@ -107,262 +111,270 @@ "structures": [1240], }, "chrome/browser/resources/feedback_webui/feedback_resources.grd": { - "includes": [1250], + "includes": [1260], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/app_service_internals/resources.grd": { "META": {"sizes": {"includes": [5],}}, - "includes": [1251], + "includes": [1280], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/bookmarks/bookmarks_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [1260], + "includes": [1300], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/browser_switch/resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [1355], + "includes": [1320], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/enterprise_casting/resources.grd": { "META": {"sizes": {"includes": [50]}}, - "includes": [1364], + "includes": [1340], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/emoji_picker/resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [1365], + "includes": [1360], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/launcher_internals/resources.grd": { "META": {"sizes": {"includes": [50]}}, - "includes": [1366], + "includes": [1380], }, - "chrome/browser/resources/chromeos/login/oobe_resources.grd": { + "chrome/browser/resources/chromeos/login/oobe_conditional_resources.grd": { "META": {"sizes": {"includes": [150], "structures": [300]}}, - "includes": [1367], - "structures": [1368], + "includes": [1400], + "structures": [1420], }, - "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/login/oobe_modulized_resources.grd": { + "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/login/oobe_unconditional_resources.grd": { "META": {"sizes": {"includes": [150]}}, - "includes": [1369], + "includes": [1440], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/multidevice_internals/resources.grd": { "META": {"sizes": {"includes": [35]}}, - "includes": [1370], + "includes": [1460], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [1380], + "includes": [1480], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/commander/commander_resources.grd": { "META": {"sizes": {"includes": [15]}}, - "includes": [1405], + "includes": [1500], }, "chrome/browser/resources/component_extension_resources.grd": { - "includes": [1420], - "structures": [1440], + "includes": [1520], + "structures": [1540], + }, + "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/connectors_internals/resources.grd": { + "META": {"sizes": {"includes": [15]}}, + "includes": [1560], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/downloads/downloads_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [1480], + "includes": [1580], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/extensions/extensions_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [1540], + "includes": [1600], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/history/history_resources.grd": { "META": {"sizes": {"includes": [40]}}, - "includes": [1580], + "includes": [1620], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/internals/resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [1590], + "includes": [1640], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/management/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [1610], + "includes": [1660], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/new_tab_page_instant/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [1620], + "includes": [1680], }, "chrome/browser/resources/webid/webid_resources.grd": { - "includes": [1622], - "structures": [1626], + "includes": [1700], + "structures": [1720], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/nearby_internals/nearby_internals_resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [1630], + "includes": [1740], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/nearby_share/nearby_share_dialog_resources.grd": { "META": {"sizes": {"includes": [100]}}, - "includes": [1640], + "includes": [1760], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/media_router/media_router_feedback_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [1650], + "includes": [1780], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/new_tab_page/resources.grd": { "META": {"sizes": {"includes": [200]}}, - "includes": [1670], + "includes": [1800], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/new_tab_page_third_party/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [1695], + "includes": [1820], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/ntp4/apps_resources.grd": { "META": {"sizes": {"includes": [40]}}, - "includes": [1705], + "includes": [1840], }, "chrome/browser/resources/preinstalled_web_apps/resources.grd": { - "includes": [1710], + "includes": [1860], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/pdf/resources.grd": { "META": {"sizes": {"includes": [200]}}, - "includes": [1715], + "includes": [1880], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/print_preview/print_preview_resources.grd": { "META": {"sizes": {"includes": [500],}}, - "includes": [1720], + "includes": [1900], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/read_later/read_later_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [1760], + "includes": [1920], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/settings/chromeos/os_settings_resources.grd": { "META": {"sizes": {"includes": [1000],}}, - "includes": [1770], + "includes": [1940], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/settings/settings_resources.grd": { "META": {"sizes": {"includes": [500],}}, - "includes": [1830], + "includes": [1960], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/signin/profile_picker/profile_picker_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [1850], + "includes": [1980], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/signin/resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [1860], + "includes": [2000], + }, + "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/support_tool/resources.grd": { + "META": {"sizes": {"includes": [10]}}, + "includes": [2010], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/tab_search/tab_search_resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [1880], + "includes": [2020], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/tab_strip/tab_strip_resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [1920], + "includes": [2040], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/welcome/welcome_resources.grd": { "META": {"sizes": {"includes": [30]}}, - "includes": [1940], + "includes": [2060], }, "chrome/browser/supervised_user/supervised_user_unscaled_resources.grd": { - "includes": [1970], + "includes": [2080], }, "chrome/browser/test_dummy/internal/android/resources/resources.grd": { - "includes": [1980], + "includes": [2100], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/download_shelf/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [1990], + "includes": [2120], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/whats_new/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [2000], + "includes": [2140], }, # END chrome/browser section. # START chrome/ WebUI resources section "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/federated_learning/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [2010], + "includes": [2160], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/bluetooth_internals/resources.grd": { "META": {"sizes": {"includes": [30],}}, - "includes": [2020], + "includes": [2180], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/audio/resources.grd": { "META": {"sizes": {"includes": [30]}}, - "includes": [2025], + "includes": [2200], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2030], + "includes": [2220], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/chromebox_for_meetings/resources.grd": { "META": {"sizes": {"includes": [5]}}, - "includes": [2035], + "includes": [2240], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2040], + "includes": [2260], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2050], + "includes": [2280], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/chromeos/network_ui/network_ui_resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [2065], + "includes": [2300], }, "<(SHARED_INTERMEDIATE_DIR)/components/download/resources/download_internals/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [2070], + "includes": [2320], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/gaia_auth_host/resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2080], + "includes": [2340], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/invalidations/resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2090], + "includes": [2360], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/media/webrtc_logs_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2100], + "includes": [2380], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/net_internals/resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [2120], + "includes": [2400], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/omnibox/resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [2140], + "includes": [2420], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/quota_internals/quota_internals_resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [2160], + "includes": [2440], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/sync_file_system_internals/resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [2180], + "includes": [2460], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/usb_internals/resources.grd": { "META": {"sizes": {"includes": [20]}}, - "includes": [2200], + "includes": [2480], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/webapks/resources.grd": { "META": {"sizes": {"includes": [10]}}, - "includes": [2220], + "includes": [2500], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/browser/resources/webui_js_error/webui_js_error_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2230], + "includes": [2520], }, "<(SHARED_INTERMEDIATE_DIR)/components/sync/driver/resources/resources.grd": { "META": {"sizes": {"includes": [30],}}, - "includes": [2240], + "includes": [2540], }, "components/resources/dev_ui_components_resources.grd": { - "includes": [2260], + "includes": [2560], }, "<(SHARED_INTERMEDIATE_DIR)/content/browser/resources/media/resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2270], + "includes": [2580], }, "<(SHARED_INTERMEDIATE_DIR)/content/browser/webrtc/resources/resources.grd": { "META": {"sizes": {"includes": [20],}}, - "includes": [2280], + "includes": [2600], }, "content/dev_ui_content_resources.grd": { - "includes": [2300], + "includes": [2620], }, # END chrome/ WebUI resources section @@ -370,25 +382,25 @@ "chrome/common/common_resources.grd": { # Big alignment at start of section. "META": {"align": 100}, - "includes": [2320], + "includes": [2700], }, "<(SHARED_INTERMEDIATE_DIR)/chrome/common/chromeos/extensions/chromeos_system_extensions_resources.grd": { "META": {"sizes": {"includes": [10],}}, - "includes": [2330], + "includes": [2720], }, "chrome/credential_provider/gaiacp/gaia_resources.grd": { - "includes": [2340], - "messages": [2360], + "includes": [2740], + "messages": [2760], }, "chrome/renderer/resources/renderer_resources.grd": { - "includes": [2380], - "structures": [2400], + "includes": [2780], + "structures": [2800], }, "chrome/test/data/webui_test_resources.grd": { - "includes": [2420], + "includes": [2820], }, "chrome/test/data/chrome_test_resources.grd": { - "messages": [2440], + "messages": [2840], }, # END chrome/ miscellaneous section. @@ -396,165 +408,182 @@ "chromeos/chromeos_strings.grd": { # Big alignment at start of section. "META": {"align": 100}, - "messages": [2500], + "messages": [2900], }, "<(SHARED_INTERMEDIATE_DIR)/chromeos/components/camera_app_ui/chromeos_camera_app_resources.grd": { "META": {"sizes": {"includes": [300],}}, - "includes": [2505], + "includes": [2920], }, "chromeos/components/camera_app_ui/resources/strings/camera_strings.grd": { - "messages": [2515], + "messages": [2940], }, "<(SHARED_INTERMEDIATE_DIR)/chromeos/components/connectivity_diagnostics/resources/connectivity_diagnostics_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2516], + "includes": [2960], }, "ash/webui/diagnostics_ui/resources/diagnostics_app_resources.grd": { - "includes": [2517], + "includes": [2980], }, "<(SHARED_INTERMEDIATE_DIR)/ash/webui/file_manager/resources/file_manager_swa_resources.grd": { "META": {"sizes": {"includes": [100]}}, - "includes": [2519], + "includes": [3000], }, - "chromeos/components/help_app_ui/resources/help_app_resources.grd": { - "includes": [2520], + "<(SHARED_INTERMEDIATE_DIR)/ash/webui/file_manager/resources/file_manager_untrusted_resources.grd": { + "META": {"sizes": {"includes": [10]}}, + "includes": [3020], + }, + "ash/webui/help_app_ui/resources/help_app_resources.grd": { + "includes": [3040], }, # Both help_app_kids_magazine_bundle_resources.grd and # help_app_kids_magazine_bundle_mock_resources.grd start with the same id # because only one of them is built depending on if src_internal is available. # Lower bound for number of resource ids is the number of files, which is 3 in # in this case (HTML, JS and CSS file). - "chromeos/components/help_app_ui/resources/prod/help_app_kids_magazine_bundle_resources.grd": { + "ash/webui/help_app_ui/resources/prod/help_app_kids_magazine_bundle_resources.grd": { "META": {"sizes": {"includes": [5],}}, - "includes": [2530], + "includes": [3060], }, - "chromeos/components/help_app_ui/resources/mock/help_app_kids_magazine_bundle_mock_resources.grd": { - "includes": [2530], + "ash/webui/help_app_ui/resources/mock/help_app_kids_magazine_bundle_mock_resources.grd": { + "includes": [3060], }, # Both help_app_bundle_resources.grd and help_app_bundle_mock_resources.grd # start with the same id because only one of them is built depending on if # src_internal is available. Lower bound is that we bundle ~100 images for # offline articles with the app, as well as strings in every language (74), # and bundled content in the top 25 languages (25 x 2). - "chromeos/components/help_app_ui/resources/prod/help_app_bundle_resources.grd": { + "ash/webui/help_app_ui/resources/prod/help_app_bundle_resources.grd": { "META": {"sizes": {"includes": [300],}}, # Relies on src-internal. - "includes": [2540], + "includes": [3080], }, - "chromeos/components/help_app_ui/resources/mock/help_app_bundle_mock_resources.grd": { - "includes": [2540], + "ash/webui/help_app_ui/resources/mock/help_app_bundle_mock_resources.grd": { + "includes": [3080], }, - "chromeos/components/media_app_ui/resources/media_app_resources.grd": { + "ash/webui/media_app_ui/resources/media_app_resources.grd": { "META": {"join": 2}, - "includes": [2560], + "includes": [3100], }, # Both media_app_bundle_resources.grd and media_app_bundle_mock_resources.grd # start with the same id because only one of them is built depending on if # src_internal is available. Lower bound for number of resource ids is number # of languages (74). - "chromeos/components/media_app_ui/resources/prod/media_app_bundle_resources.grd": { + "ash/webui/media_app_ui/resources/prod/media_app_bundle_resources.grd": { "META": {"sizes": {"includes": [120],}}, # Relies on src-internal. - "includes": [2580], + "includes": [3120], }, - "chromeos/components/media_app_ui/resources/mock/media_app_bundle_mock_resources.grd": { - "includes": [2580], + "ash/webui/media_app_ui/resources/mock/media_app_bundle_mock_resources.grd": { + "includes": [3120], }, - "chromeos/components/print_management/resources/print_management_resources.grd": { + "ash/webui/print_management/resources/print_management_resources.grd": { "META": {"join": 2}, - "includes": [2600], - "structures": [2620], + "includes": [3140], + "structures": [3160], }, "<(SHARED_INTERMEDIATE_DIR)/ash/webui/sample_system_web_app_ui/ash_sample_system_web_app_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2640], + "includes": [3180], }, "<(SHARED_INTERMEDIATE_DIR)/ash/webui/sample_system_web_app_ui/ash_sample_system_web_app_untrusted_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2645], + "includes": [3200], }, "ash/webui/scanning/resources/scanning_app_resources.grd": { - "includes": [2650], - "structures": [2655], + "includes": [3220], + "structures": [3240], }, - "chromeos/components/telemetry_extension_ui/resources/telemetry_extension_resources.grd": { - "includes": [2660], + "ash/webui/telemetry_extension_ui/resources/telemetry_extension_resources.grd": { + "includes": [3260], }, "chromeos/resources/chromeos_resources.grd": { - "includes": [2670], + "includes": [3280], }, "<(SHARED_INTERMEDIATE_DIR)/chromeos/components/eche_app_ui/chromeos_eche_app_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2680], + "includes": [3300], }, # Both eche_bundle_resources.grd and eche_bundle_mock_resources.grd # start with the same id because only one of them is built depending on if # src_internal is available. "chromeos/components/eche_app_ui/resources/prod/eche_bundle_resources.grd": { - "META": {"sizes": {"includes": [50],}}, - "includes": [2690], + "META": {"sizes": {"includes": [120],}}, + "includes": [3320], }, "chromeos/components/eche_app_ui/resources/mock/eche_bundle_mock_resources.grd": { - "META": {"sizes": {"includes": [50],}}, - "includes": [2690], + "META": {"sizes": {"includes": [120],}}, + "includes": [3320], }, "<(SHARED_INTERMEDIATE_DIR)/chromeos/components/personalization_app/resources/chromeos_personalization_app_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2695], + "includes": [3340], }, - "<(SHARED_INTERMEDIATE_DIR)/chromeos/components/demo_mode_app_ui/chromeos_demo_mode_app_resources.grd": { + "<(SHARED_INTERMEDIATE_DIR)/ash/webui/demo_mode_app_ui/ash_demo_mode_app_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2700], + "includes": [3360], }, "<(SHARED_INTERMEDIATE_DIR)/chromeos/components/projector_app/resources/chromeos_projector_app_untrusted_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2705], + "includes": [3380], }, "<(SHARED_INTERMEDIATE_DIR)/chromeos/components/projector_app/resources/chromeos_projector_app_trusted_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [2710], + "includes": [3400], + }, + # Both projector_app_bundle_resources.grd and projector_app_bundle_mock_resources.grd + # start with the same id because only one of them is built depending on if + # src_internal is available. Lower bound for number of resource ids is number + # of languages (79). + "chromeos/components/projector_app/resources/prod/projector_app_bundle_resources.grd": { + "META": {"sizes": {"includes": [120],}}, # Relies on src-internal. + "includes": [3420], + }, + "chromeos/components/projector_app/resources/mock/projector_app_bundle_mock_resources.grd": { + "includes": [3420], }, # END chromeos/ section. # START components/ section. + "components/arc/input_overlay/resources/input_overlay_resources.grd": { + # Big alignment at start of section. + "META": {"align": 1000}, + "includes": [3500], + }, # Chromium strings and Google Chrome strings must start at the same id. # We only use one file depending on whether we're building Chromium or # Google Chrome. "components/components_chromium_strings.grd": { - # Big alignment at start of section. - "META": {"align": 100}, - "messages": [2700], + "messages": [3520], }, "components/components_google_chrome_strings.grd": { - "messages": [2700], + "messages": [3520], }, - "components/components_locale_settings.grd": { "META": {"join": 2}, - "includes": [2720], - "messages": [2740], + "includes": [3540], + "messages": [3560], }, "components/components_strings.grd": { - "messages": [2760], + "messages": [3580], }, "components/omnibox/resources/omnibox_pedal_synonyms.grd": { - "messages": [2770], + "messages": [3600], }, "components/omnibox/resources/omnibox_resources.grd": { - "includes": [2780], + "includes": [3620], }, "components/policy/resources/policy_templates.grd": { - "structures": [2800], + "structures": [3640], }, "components/resources/components_resources.grd": { - "includes": [2820], + "includes": [3660], }, "components/resources/components_scaled_resources.grd": { - "structures": [2840], + "structures": [3680], }, "components/embedder_support/android/java/strings/web_contents_delegate_android_strings.grd": { - "messages": [2860], + "messages": [3700], }, "components/autofill/core/browser/autofill_address_rewriter_resources.grd":{ - "includes": [2880] + "includes": [3720] }, # END components/ section. @@ -612,11 +641,26 @@ "META": {"join": 2}, "messages": [800], }, + # END ios/ section. + + # START ios_internal/ section. "ios/chrome/widget_kit_extension/strings/ios_widget_kit_extension_strings.grd": { "messages": [820], }, - - # END ios/ section. + "ios_internal/chrome/app/ios_internal_strings.grd": { + "messages": [840], + }, + "ios_internal/chrome/app/theme/mobile_theme_resources.grd": { + "structures": [860], + }, + "ios_internal/chrome/app/ios_internal_chromium_strings.grd": { + "META": {"join": 2}, + "messages": [3740], + }, + "ios_internal/chrome/app/ios_internal_google_chrome_strings.grd": { + "messages": [3740], + }, + # END ios_internal/ section. # START content/ section. # content/ and ios/web/ must start at the same id. @@ -624,22 +668,22 @@ "content/app/resources/content_resources.grd": { # Big alignment at start of section. "META": {"join": 2, "align": 100}, - "structures": [2900], + "structures": [3800], }, "content/content_resources.grd": { - "includes": [2920], + "includes": [3820], }, "content/shell/shell_resources.grd": { - "includes": [2940], + "includes": [3840], }, "content/test/web_ui_mojo_test_resources.grd": { - "includes": [2950], + "includes": [3860], }, # This file is generated during the build. "<(SHARED_INTERMEDIATE_DIR)/content/browser/tracing/tracing_resources.grd": { "META": {"sizes": {"includes": [20],}}, - "includes": [2960], + "includes": [3880], }, # END content/ section. @@ -649,10 +693,10 @@ "ios/web/ios_web_resources.grd": { # Big alignment at start of section. "META": {"align": 100}, - "includes": [2900], + "includes": [3800], }, "ios/web/test/test_resources.grd": { - "includes": [2920], + "includes": [3820], }, # END ios/web/ section. @@ -661,176 +705,183 @@ "android_webview/ui/aw_resources.grd": { # Big alignment at start of section. "META": {"join": 2, "align": 100}, - "includes": [3000], + "includes": [3900], }, "android_webview/ui/aw_strings.grd": { - "messages": [3020], + "messages": [3920], }, "ash/app_list/resources/app_list_resources.grd": { - "structures": [3040], + "structures": [3940], }, "ash/ash_strings.grd": { - "messages": [3060], + "messages": [3960], }, "<(SHARED_INTERMEDIATE_DIR)/ash/webui/os_feedback_ui/resources/ash_os_feedback_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [3064], + "includes": [3980], }, "<(SHARED_INTERMEDIATE_DIR)/ash/webui/shortcut_customization_ui/resources/ash_shortcut_customization_app_resources.grd": { "META": {"sizes": {"includes": [200],}}, - "includes": [3070], + "includes": [4000], }, "ash/shortcut_viewer/shortcut_viewer_strings.grd": { - "messages": [3080], + "messages": [4020], }, "<(SHARED_INTERMEDIATE_DIR)/ash/webui/shimless_rma/resources/ash_shimless_rma_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [3090], + "includes": [4040], }, "ash/keyboard/ui/keyboard_resources.grd": { - "includes": [3100], + "includes": [4060], }, "ash/login/resources/login_resources.grd": { - "structures": [3120], + "structures": [4080], }, "ash/public/cpp/resources/ash_public_unscaled_resources.grd": { - "includes": [3140], + "includes": [4100], }, "base/tracing/protos/resources.grd": { - "includes": [3150], + "includes": [4120], + }, + "chromecast/app/resources/chromecast_settings.grd": { + "messages": [4140], + }, + "chromecast/app/resources/shell_resources.grd": { + "includes": [4160], }, "chromecast/renderer/resources/extensions_renderer_resources.grd": { - "includes": [3160], + "includes": [4180], }, "cloud_print/virtual_driver/win/install/virtual_driver_setup_resources.grd": { - "includes": [3180], - "messages": [3200], + "includes": [4200], + "messages": [4220], }, "device/bluetooth/bluetooth_strings.grd": { - "messages": [3220], + "messages": [4240], }, "device/fido/fido_strings.grd": { - "messages": [3240], + "messages": [4260], }, "extensions/browser/resources/extensions_browser_resources.grd": { - "structures": [3260], + "structures": [4280], }, "extensions/extensions_resources.grd": { - "includes": [3280], + "includes": [4300], }, "extensions/renderer/resources/extensions_renderer_resources.grd": { - "includes": [3300], - "structures": [3320], + "includes": [4320], + "structures": [4340], }, "extensions/shell/app_shell_resources.grd": { - "includes": [3340], + "includes": [4360], }, "extensions/strings/extensions_strings.grd": { - "messages": [3360], + "messages": [4380], }, "headless/lib/resources/headless_lib_resources.grd": { - "includes": [3380], + "includes": [4400], }, "mojo/public/js/mojo_bindings_resources.grd": { - "includes": [3400], + "includes": [4420], }, "net/base/net_resources.grd": { - "includes": [3420], + "includes": [4440], }, "remoting/resources/remoting_strings.grd": { - "messages": [3440], + "messages": [4460], }, "services/services_strings.grd": { - "messages": [3460], + "messages": [4480], }, "skia/skia_resources.grd": { - "includes": [3470], + "includes": [4500], }, "third_party/blink/public/blink_image_resources.grd": { - "structures": [3480], + "structures": [4520], }, "third_party/blink/public/blink_resources.grd": { - "includes": [3500], + "includes": [4540], }, "third_party/blink/renderer/modules/media_controls/resources/media_controls_resources.grd": { - "includes": [3520], - "structures": [3540], + "includes": [4560], + "structures": [4580], }, "third_party/blink/public/strings/blink_strings.grd": { - "messages": [3560], + "messages": [4600], }, "third_party/libaddressinput/chromium/address_input_strings.grd": { - "messages": [3600], + "messages": [4620], }, "ui/base/test/ui_base_test_resources.grd": { - "messages": [3620], + "messages": [4640], }, "ui/chromeos/resources/ui_chromeos_resources.grd": { - "structures": [3640], + "structures": [4660], }, "ui/chromeos/ui_chromeos_strings.grd": { - "messages": [3660], + "messages": [4680], }, "<(SHARED_INTERMEDIATE_DIR)/ui/file_manager/file_manager_gen_resources.grd": { "META": {"sizes": {"includes": [2000]}}, - "includes": [3670], + "includes": [4700], }, "ui/file_manager/file_manager_resources.grd": { - "includes": [3680], + "includes": [4720], }, "ui/resources/ui_resources.grd": { - "structures": [3700], + "structures": [4740], }, "ui/resources/ui_unscaled_resources.grd": { - "includes": [3720], + "includes": [4760], }, "ui/strings/app_locale_settings.grd": { - "messages": [3740], + "messages": [4780], }, "ui/strings/ui_strings.grd": { - "messages": [3760], + "messages": [4800], }, "ui/views/examples/views_examples_resources.grd": { - "messages": [3770], + "messages": [4820], }, "ui/views/resources/views_resources.grd": { - "structures": [3780], + "structures": [4840], }, "ui/webui/resources/webui_resources.grd": { - "includes": [3800], - "structures": [3820], + "includes": [4860], + "structures": [4880], }, "<(SHARED_INTERMEDIATE_DIR)/ui/webui/resources/webui_generated_resources.grd": { "META": {"sizes": {"includes": [800]}}, - "includes": [3830], + "includes": [4900], }, "weblayer/weblayer_resources.grd": { - "includes": [3840], + "includes": [4920], }, # This file is generated during the build. - "<(SHARED_INTERMEDIATE_DIR)/third_party/devtools-frontend/src/front_end/devtools_resources.grd": { + # .grd extension is required because it's checked before var interpolation. + "<(DEVTOOLS_GRD_PATH).grd": { # In debug build, devtools frontend sources are not bundled and therefore # includes a lot of individual resources "META": {"sizes": {"includes": [2000],}}, - "includes": [3860], + "includes": [4940], }, # This file is generated during the build. "<(SHARED_INTERMEDIATE_DIR)/resources/inspector_overlay/inspector_overlay_resources.grd": { "META": {"sizes": {"includes": [50],}}, - "includes": [3880], + "includes": [4960], }, # END "everything else" section. @@ -838,6 +889,4 @@ # Thinking about appending to the end? # Please read the header and find the right section above instead. - - # Resource ids starting at 31000 are reserved for projects built on Chromium. } diff --git a/chromium/tools/gritsettings/translation_expectations.pyl b/chromium/tools/gritsettings/translation_expectations.pyl index 1ac625b66b2..098a6cf9ab7 100644 --- a/chromium/tools/gritsettings/translation_expectations.pyl +++ b/chromium/tools/gritsettings/translation_expectations.pyl @@ -96,7 +96,11 @@ # before changing this list or another phase of TC pipeline breaks. "omnibox_pedal_synonyms_grd": { "languages": [ - "ar", "de", "es-419", "fr", "ja", "zh-CN", "zh-TW", + "am", "ar", "bg", "bn", "ca", "cs", "da", "de", "el", "en", "en-GB", "es", + "es-419", "et", "fa", "fi", "fil", "fr", "gu", "he", "hi", "hr", "hu", + "id", "it", "ja", "kn", "ko", "lt", "lv", "ml", "mr", "ms", "nl", "pl", + "pt-BR", "pt-PT", "ro", "ru", "sk", "sl", "sr", "sv", "sw", "ta", "te", + "th", "tr", "uk", "vi", "zh-CN", "zh-TW", ], "files": [ "components/omnibox/resources/omnibox_pedal_synonyms.grd", diff --git a/chromium/tools/infra/PRESUBMIT.py b/chromium/tools/infra/PRESUBMIT.py index 8aa73ac6a79..d0d342d30bf 100644 --- a/chromium/tools/infra/PRESUBMIT.py +++ b/chromium/tools/infra/PRESUBMIT.py @@ -13,7 +13,8 @@ USE_PYTHON3 = True def _CommonChecks(input_api, output_api): results = [] - results.extend(input_api.canned_checks.RunPylint(input_api, output_api)) + results.extend( + input_api.canned_checks.RunPylint(input_api, output_api, version='2.6')) commands = [] commands.extend( @@ -22,7 +23,10 @@ def _CommonChecks(input_api, output_api): output_api, input_api.os_path.join(input_api.PresubmitLocalPath()), files_to_check=[r'.+_unittest\.py$'], - files_to_skip=[])) + files_to_skip=[], + run_on_python2=False, + run_on_python3=True, + skip_shebang_check=True)) results.extend(input_api.RunTests(commands)) return results diff --git a/chromium/tools/infra/clobber_cache_utils.py b/chromium/tools/infra/clobber_cache_utils.py index ccd289306c7..612aad5d434 100644 --- a/chromium/tools/infra/clobber_cache_utils.py +++ b/chromium/tools/infra/clobber_cache_utils.py @@ -121,7 +121,7 @@ def clobber_caches(swarming_server, for bot in bots: print(' %s' % bot) print() - val = raw_input('Proceed? [Y/n] ') + val = input('Proceed? [Y/n] ') if val and not val[0] in ('Y', 'y'): print('Cancelled.') return 1 @@ -129,3 +129,4 @@ def clobber_caches(swarming_server, for bot in bots: _trigger_clobber(swarming_server, pool, realm, cache, bot, mount_rel_path, dry_run) + return 0 diff --git a/chromium/tools/infra/find_bad_builds.py b/chromium/tools/infra/find_bad_builds.py index f1b16f31e39..1a051692eff 100755 --- a/chromium/tools/infra/find_bad_builds.py +++ b/chromium/tools/infra/find_bad_builds.py @@ -1,4 +1,4 @@ -#!/usr/bin/env vpython +#!/usr/bin/env vpython3 # Copyright 2020 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -17,8 +17,6 @@ This script uses your chromium/src checkout, so you must keep it updated if you want this to be able to cancel recent builds. """ -from __future__ import print_function - import argparse import datetime import functools @@ -28,7 +26,7 @@ import multiprocessing import subprocess import sys -# Provided by root level .vpython file +# Provided by root level .vpython3 file import pytz from dateutil.tz import tzlocal diff --git a/chromium/tools/infra/find_bad_builds_unittest.py b/chromium/tools/infra/find_bad_builds_unittest.py index f03255caf52..7c981b0b9f2 100755 --- a/chromium/tools/infra/find_bad_builds_unittest.py +++ b/chromium/tools/infra/find_bad_builds_unittest.py @@ -1,4 +1,4 @@ -#!/usr/bin/env vpython +#!/usr/bin/env vpython3 # Copyright 2021 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -21,7 +21,7 @@ import find_bad_builds import mock -class Pool(object): +class Pool: """Simple object used to mock out multiprocessing.Pool.""" def map(self, fn, lst): @@ -112,6 +112,7 @@ class FindBadBuildsIntegrationTest(unittest.TestCase): if b['id'] == bid: return b['revision'] self.fail('build %s is missing a revision' % bid) + return None fetch_rev.side_effect = find_rev with mock.patch('find_bad_builds._get_build_running_time') as b_runtime: diff --git a/chromium/tools/infra/named-cache-clobber.py b/chromium/tools/infra/named-cache-clobber.py index 784781c29f2..6dc893d26f5 100755 --- a/chromium/tools/infra/named-cache-clobber.py +++ b/chromium/tools/infra/named-cache-clobber.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. diff --git a/chromium/tools/infra/reproduce.py b/chromium/tools/infra/reproduce.py index 9953ce3676b..82cf3677022 100755 --- a/chromium/tools/infra/reproduce.py +++ b/chromium/tools/infra/reproduce.py @@ -1,4 +1,4 @@ -#!/usr/bin/env vpython +#!/usr/bin/env vpython3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -19,8 +19,6 @@ Bugs and feature requests should be given as bugs filed via https://bit.ly/cci-generic-bug. """ -from __future__ import print_function - import argparse import base64 import collections @@ -31,7 +29,7 @@ import sys import subprocess import tempfile import traceback -import urllib +from urllib import parse # From vpython @@ -114,7 +112,7 @@ def guess_host_dimensions(): } -class Build(object): +class Build: """All relevant information for an already executed build. The constructor does several HTTP requests to get needed information from @@ -122,7 +120,7 @@ class Build(object): """ def __init__(self, build_address): # Build address of the build. - self.build_address = urllib.unquote_plus(build_address) + self.build_address = parse.unquote_plus(build_address) assert len(self.build_address.split('/')) == 3, ( 'Expected build address to look like <bucket>/<builder>/<buildnumber>, ' 'but got %s' % self.build_address @@ -239,13 +237,14 @@ class Build(object): def _fetch_test_results(self, failed_suites): results = [] for suite in failed_suites: - test_results_url = TEST_RESULTS_BASE + 'testfile?%s' % urllib.urlencode({ - 'builder': self.builder, - 'name': 'full_results.json', - 'master': self.mastername, - 'testtype': '%s (with patch)' % suite, - 'buildnumber': self.buildnumber, - }) + test_results_url = TEST_RESULTS_BASE + 'testfile?%s' % parse.urlencode( + { + 'builder': self.builder, + 'name': 'full_results.json', + 'master': self.mastername, + 'testtype': '%s (with patch)' % suite, + 'buildnumber': self.buildnumber, + }) data = requests.get(test_results_url).json() results.append(data) @@ -354,7 +353,7 @@ class Build(object): ' values of %r. Do you wish to proceed with running the test? ' '(y/N)' % ( dimension, swarming_value, host_values)) - response = raw_input('>> ').lower() + response = input('>> ').lower() if response != 'y': print('Not running test suite %s...' % suite_name) return 1 @@ -389,6 +388,8 @@ class Build(object): if suite.is_isolated: os.unlink(temp_filename) + return 0 + def checkout_commands(self): cmd = [ 'gclient', @@ -494,7 +495,7 @@ def main(): print() print('Would you like this script to run these commands? (Y/n)') - response = raw_input('>> ').lower().strip() + response = input('>> ').lower().strip() if response in ('y', ''): build.ensure_checkout() else: @@ -515,7 +516,7 @@ def main(): print(' ' + cmd) print('What would you like to do?') - response = raw_input('>> ').lower() + response = input('>> ').lower() try: num = int(response) @@ -549,4 +550,3 @@ if __name__ == '__main__': print('If this exception is unexpected, please file a bug via ' 'https://bit.ly/cci-generic-bug.') sys.exit(1) - diff --git a/chromium/tools/infra/reproduce_unittest.py b/chromium/tools/infra/reproduce_unittest.py index d5c07d7be0b..202f72adfc4 100755 --- a/chromium/tools/infra/reproduce_unittest.py +++ b/chromium/tools/infra/reproduce_unittest.py @@ -1,4 +1,4 @@ -#!/usr/bin/env vpython +#!/usr/bin/env vpython3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -84,9 +84,9 @@ class ReproduceTest(unittest.TestCase): }]), ['gl_unittests']) - @mock.patch('__builtin__.print') + @mock.patch('builtins.print') @mock.patch('reproduce.guess_host_dimensions') - @mock.patch('__builtin__.raw_input') + @mock.patch('builtins.input') @mock.patch('reproduce.run_command') def test_run_suite_gtest(self, run_mock, input_mock, guess_mock, print_mock): # Just want to mock this so if something weird happens with the test it @@ -121,9 +121,9 @@ class ReproduceTest(unittest.TestCase): 'gl_unittests', '--', '--gtest_filter=test.1:test.2' ]) - @mock.patch('__builtin__.print') + @mock.patch('builtins.print') @mock.patch('reproduce.guess_host_dimensions') - @mock.patch('__builtin__.raw_input') + @mock.patch('builtins.input') @mock.patch('reproduce.run_command') def test_run_suite_isolated_script(self, run_mock, input_mock, guess_mock, print_mock): @@ -157,8 +157,8 @@ class ReproduceTest(unittest.TestCase): # The script tries to close the file handler to the temp file when # it creates it. Mock that out. with mock.patch('reproduce.os.close'): - temp_mock.side_effect = [(5, fake_tempfile_name)] - b.run_suite('blink_web_tests', '//out/Default') + temp_mock.side_effect = [(5, fake_tempfile_name)] + b.run_suite('blink_web_tests', '//out/Default') unlink_mock.assert_called_with(fake_tempfile_name) run_mock.assert_called_with([ @@ -169,9 +169,9 @@ class ReproduceTest(unittest.TestCase): '--isolated-script-test-output', fake_tempfile_name, ]) - @mock.patch('__builtin__.print') + @mock.patch('builtins.print') @mock.patch('reproduce.guess_host_dimensions') - @mock.patch('__builtin__.raw_input') + @mock.patch('builtins.input') @mock.patch('reproduce.run_command') def test_run_suite_dimension_prompt(self, run_mock, input_mock, guess_mock, print_mock): @@ -199,9 +199,9 @@ class ReproduceTest(unittest.TestCase): self.assertEqual(print_mock.call_count, 2) run_mock.assert_not_called() - @mock.patch('__builtin__.print') + @mock.patch('builtins.print') @mock.patch('reproduce.guess_host_dimensions') - @mock.patch('__builtin__.raw_input') + @mock.patch('builtins.input') @mock.patch('reproduce.run_command') def test_run_suite_already_prompted(self, run_mock, input_mock, guess_mock, print_mock): diff --git a/chromium/tools/ipc_fuzzer/BUILD.gn b/chromium/tools/ipc_fuzzer/BUILD.gn index 8abe2472325..7f177dd4062 100644 --- a/chromium/tools/ipc_fuzzer/BUILD.gn +++ b/chromium/tools/ipc_fuzzer/BUILD.gn @@ -29,7 +29,11 @@ if (enable_ipc_fuzzer) { testonly = true deps = [ "//tools/ipc_fuzzer/fuzzer:ipc_fuzzer", - "//tools/ipc_fuzzer/message_dump:ipc_message_dump", + + # Disable this until build is fixed. + # TODO(1241274): Fix the build issue and reenable this. + # "//tools/ipc_fuzzer/message_dump:ipc_message_dump", + "//tools/ipc_fuzzer/message_replay:ipc_fuzzer_replay", "//tools/ipc_fuzzer/message_tools:ipc_message_list", "//tools/ipc_fuzzer/message_tools:ipc_message_util", diff --git a/chromium/tools/ipc_fuzzer/message_lib/message_file_writer.cc b/chromium/tools/ipc_fuzzer/message_lib/message_file_writer.cc index 2c1f23d6865..b2343a37b4d 100644 --- a/chromium/tools/ipc_fuzzer/message_lib/message_file_writer.cc +++ b/chromium/tools/ipc_fuzzer/message_lib/message_file_writer.cc @@ -22,6 +22,10 @@ namespace { class Writer { public: Writer(const base::FilePath& path); + + Writer(const Writer&) = delete; + Writer& operator=(const Writer&) = delete; + ~Writer() {} bool Write(const MessageVector& messages); @@ -49,8 +53,6 @@ class Writer { base::File file_; const MessageVector* messages_; TypesSet types_; - - DISALLOW_COPY_AND_ASSIGN(Writer); }; Writer::Writer(const base::FilePath& path) : path_(path), messages_(NULL) { diff --git a/chromium/tools/ipc_fuzzer/message_lib/message_names.h b/chromium/tools/ipc_fuzzer/message_lib/message_names.h index 094118fc3a4..5f76bebd1c8 100644 --- a/chromium/tools/ipc_fuzzer/message_lib/message_names.h +++ b/chromium/tools/ipc_fuzzer/message_lib/message_names.h @@ -17,6 +17,10 @@ namespace ipc_fuzzer { class MessageNames { public: MessageNames(); + + MessageNames(const MessageNames&) = delete; + MessageNames& operator=(const MessageNames&) = delete; + ~MessageNames(); static MessageNames* GetInstance(); @@ -52,8 +56,6 @@ class MessageNames { NameToTypeMap type_map_; static MessageNames* all_names_; - - DISALLOW_COPY_AND_ASSIGN(MessageNames); }; } // namespace ipc_fuzzer diff --git a/chromium/tools/ipc_fuzzer/message_replay/replay_process.cc b/chromium/tools/ipc_fuzzer/message_replay/replay_process.cc index a985a255944..13697fc389e 100644 --- a/chromium/tools/ipc_fuzzer/message_replay/replay_process.cc +++ b/chromium/tools/ipc_fuzzer/message_replay/replay_process.cc @@ -178,7 +178,7 @@ void ReplayProcess::SendNextMessage() { void ReplayProcess::Run() { base::RepeatingTimer timer; - timer.Start(FROM_HERE, base::TimeDelta::FromMilliseconds(1), + timer.Start(FROM_HERE, base::Milliseconds(1), base::BindRepeating(&ReplayProcess::SendNextMessage, base::Unretained(this))); base::RunLoop().Run(); diff --git a/chromium/tools/ipc_fuzzer/message_replay/replay_process.h b/chromium/tools/ipc_fuzzer/message_replay/replay_process.h index 7f855ccc9dc..b48ad7a4411 100644 --- a/chromium/tools/ipc_fuzzer/message_replay/replay_process.h +++ b/chromium/tools/ipc_fuzzer/message_replay/replay_process.h @@ -31,6 +31,10 @@ namespace ipc_fuzzer { class ReplayProcess : public IPC::Listener { public: ReplayProcess(); + + ReplayProcess(const ReplayProcess&) = delete; + ReplayProcess& operator=(const ReplayProcess&) = delete; + ~ReplayProcess() override; // Set up command line, logging, IO thread. Returns true on success, false @@ -62,8 +66,6 @@ class ReplayProcess : public IPC::Listener { base::WaitableEvent shutdown_event_; MessageVector messages_; size_t message_index_; - - DISALLOW_COPY_AND_ASSIGN(ReplayProcess); }; } // namespace ipc_fuzzer diff --git a/chromium/tools/json_schema_compiler/OWNERS b/chromium/tools/json_schema_compiler/OWNERS index aad0b9203df..0b2db88c32b 100644 --- a/chromium/tools/json_schema_compiler/OWNERS +++ b/chromium/tools/json_schema_compiler/OWNERS @@ -1 +1,2 @@ rdevlin.cronin@chromium.org +karandeepb@chromium.org diff --git a/chromium/tools/json_schema_compiler/cc_generator.py b/chromium/tools/json_schema_compiler/cc_generator.py index 4e09b628d3d..42184ca5837 100644 --- a/chromium/tools/json_schema_compiler/cc_generator.py +++ b/chromium/tools/json_schema_compiler/cc_generator.py @@ -240,7 +240,7 @@ class _Generator(object): choice)) .Concat(self._GeneratePopulateVariableFromValue( choice, - '(&value)', + 'value', 'out->as_%s' % choice.unix_name, 'false', is_ptr=True)) @@ -283,7 +283,7 @@ class _Generator(object): .Append('%s tmp;' % cpp_type) .Concat(self._GeneratePopulateVariableFromValue( type_.additional_properties, - '(&it.value())', + 'it.value()', 'tmp', 'false')) .Append('out->additional_properties[it.key()] = tmp;') @@ -315,7 +315,7 @@ class _Generator(object): (c.Sblock( 'if (%(value_var)s) {') .Concat(self._GeneratePopulatePropertyFromValue( - prop, value_var, dst, 'false'))) + prop, '(*%s)' % value_var, dst, 'false'))) underlying_type = self._type_helper.FollowRef(prop.type_) if underlying_type.property_type == PropertyType.ENUM: namespace_prefix = ('%s::' % underlying_type.namespace.unix_name @@ -333,7 +333,7 @@ class _Generator(object): .Append('return false;') .Eblock('}') .Concat(self._GeneratePopulatePropertyFromValue( - prop, value_var, dst, 'false')) + prop, '(*%s)' % value_var, dst, 'false')) ) c.Append() c.Substitute({ @@ -834,15 +834,15 @@ class _Generator(object): if not param.optional: num_required += 1 if num_required == len(function.params): - c.Sblock('if (%(var)s.GetSize() != %(total)d) {') + c.Sblock('if (%(var)s.size() != %(total)d) {') elif not num_required: - c.Sblock('if (%(var)s.GetSize() > %(total)d) {') + c.Sblock('if (%(var)s.size() > %(total)d) {') else: - c.Sblock('if (%(var)s.GetSize() < %(required)d' - ' || %(var)s.GetSize() > %(total)d) {') + c.Sblock('if (%(var)s.size() < %(required)d' + ' || %(var)s.size() > %(total)d) {') (c.Concat(self._AppendError16( 'u"expected %%(total)d arguments, got " ' - '+ base::NumberToString16(%%(var)s.GetSize())')) + '+ base::NumberToString16(%%(var)s.size())')) .Append('return nullptr;') .Eblock('}') .Substitute({ @@ -854,14 +854,16 @@ class _Generator(object): def _GenerateFunctionParamsCreate(self, function): """Generate function to create an instance of Params. The generated - function takes a base::ListValue of arguments. + function takes a base::Value::ConstListView of arguments. E.g for function "Bar", generate Bar::Params::Create() """ c = Code() + (c.Append('// static') .Sblock('std::unique_ptr<Params> Params::Create(%s) {' % - self._GenerateParams(['const base::ListValue& args'])) + self._GenerateParams([ + 'const base::Value::ConstListView& args'])) ) if self._generate_error_messages: c.Append('DCHECK(error);') @@ -880,9 +882,9 @@ class _Generator(object): failure_value = 'std::unique_ptr<Params>()' c.Append() value_var = param.unix_name + '_value' - (c.Append('const base::Value* %(value_var)s = nullptr;') - .Append('if (args.Get(%(i)s, &%(value_var)s) &&') - .Sblock(' !%(value_var)s->is_none()) {') + (c.Append('if (%(i)s < args.size() &&') + .Sblock(' !args[%(i)s].is_none()) {') + .Append('const base::Value& %(value_var)s = args[%(i)s];') .Concat(self._GeneratePopulatePropertyFromValue( param, value_var, 'params', failure_value)) .Eblock('}') @@ -907,7 +909,7 @@ class _Generator(object): dst_class_var, failure_value): """Generates code to populate property |prop| of |dst_class_var| (a - pointer) from a Value*. See |_GeneratePopulateVariableFromValue| for + pointer) from a Value. See |_GeneratePopulateVariableFromValue| for semantics. """ return self._GeneratePopulateVariableFromValue(prop.type_, @@ -924,9 +926,8 @@ class _Generator(object): failure_value, is_ptr=False): """Generates code to populate a variable |dst_var| of type |type_| from a - Value* at |src_var|. The Value* is assumed to be non-null. In the generated - code, if |dst_var| fails to be populated then Populate will return - |failure_value|. + Value |src_var|. In the generated code, if |dst_var| fails to be populated + then Populate will return |failure_value|. """ c = Code() @@ -947,15 +948,13 @@ class _Generator(object): .Concat(self._AppendError16( 'u"\'%%(key)s\': expected ' + '%s, got " + %s' % ( type_.name, - self._util_cc_helper.GetValueTypeString( - '%%(src_var)s', True))))) + self._util_cc_helper.GetValueTypeString('%%(src_var)s'))))) else: (c.Sblock('if (!temp.has_value()) {') .Concat(self._AppendError16( 'u"\'%%(key)s\': expected ' + '%s, got " + %s' % ( type_.name, - self._util_cc_helper.GetValueTypeString( - '%%(src_var)s', True))))) + self._util_cc_helper.GetValueTypeString('%%(src_var)s'))))) if is_ptr: c.Append('%(dst_var)s.reset();') c.Append('return %(failure_value)s;') @@ -974,10 +973,10 @@ class _Generator(object): elif underlying_type.property_type == PropertyType.OBJECT: if is_ptr: (c.Append('const base::DictionaryValue* dictionary = nullptr;') - .Sblock('if (!%(src_var)s->GetAsDictionary(&dictionary)) {') + .Sblock('if (!%(src_var)s.GetAsDictionary(&dictionary)) {') .Concat(self._AppendError16( 'u"\'%%(key)s\': expected dictionary, got " + ' + - self._util_cc_helper.GetValueTypeString('%%(src_var)s', True))) + self._util_cc_helper.GetValueTypeString('%%(src_var)s'))) .Append('return %(failure_value)s;') ) (c.Eblock('}') @@ -994,10 +993,10 @@ class _Generator(object): ) else: (c.Append('const base::DictionaryValue* dictionary = nullptr;') - .Sblock('if (!%(src_var)s->GetAsDictionary(&dictionary)) {') + .Sblock('if (!%(src_var)s.GetAsDictionary(&dictionary)) {') .Concat(self._AppendError16( 'u"\'%%(key)s\': expected dictionary, got " + ' + - self._util_cc_helper.GetValueTypeString('%%(src_var)s', True))) + self._util_cc_helper.GetValueTypeString('%%(src_var)s'))) .Append('return %(failure_value)s;') .Eblock('}') .Append('if (!%%(cpp_type)s::Populate(%s)) {' % self._GenerateArgs( @@ -1011,14 +1010,13 @@ class _Generator(object): if is_ptr: # Non-serializable functions are just represented as dicts. c.Append('%(dst_var)s = std::make_unique<base::DictionaryValue>();') elif underlying_type.property_type == PropertyType.ANY: - c.Append('%(dst_var)s = %(src_var)s->CreateDeepCopy();') + c.Append('%(dst_var)s = %(src_var)s.CreateDeepCopy();') elif underlying_type.property_type == PropertyType.ARRAY: # util_cc_helper deals with optional and required arrays - (c.Append('const base::ListValue* list = nullptr;') - .Sblock('if (!%(src_var)s->GetAsList(&list)) {') + (c.Sblock('if (!%(src_var)s.is_list()) {') .Concat(self._AppendError16( 'u"\'%%(key)s\': expected list, got " + ' + - self._util_cc_helper.GetValueTypeString('%%(src_var)s', True))) + self._util_cc_helper.GetValueTypeString('%%(src_var)s'))) .Append('return %(failure_value)s;') ) c.Eblock('}') @@ -1027,12 +1025,12 @@ class _Generator(object): if item_type.property_type == PropertyType.ENUM: c.Concat(self._GenerateListValueToEnumArrayConversion( item_type, - 'list', + src_var, dst_var, failure_value, is_ptr=is_ptr)) else: - args = ['*list', '&%(dst_var)s'] + args = ['%(src_var)s.GetList()', '&%(dst_var)s'] if self._generate_error_messages: c.Append('std::u16string array_parse_error;') args.append('&array_parse_error') @@ -1054,13 +1052,13 @@ class _Generator(object): if is_ptr: (c.Append('auto temp = std::make_unique<%(cpp_type)s>();') .Append('if (!%%(cpp_type)s::Populate(%s))' % self._GenerateArgs( - ('*%(src_var)s', 'temp.get()'))) + ('%(src_var)s', 'temp.get()'))) .Append(' return %(failure_value)s;') .Append('%(dst_var)s = std::move(temp);') ) else: (c.Append('if (!%%(cpp_type)s::Populate(%s))' % self._GenerateArgs( - ('*%(src_var)s', '&%(dst_var)s'))) + ('%(src_var)s', '&%(dst_var)s'))) .Append(' return %(failure_value)s;')) elif underlying_type.property_type == PropertyType.ENUM: c.Concat(self._GenerateStringToEnumConversion(underlying_type, @@ -1068,10 +1066,10 @@ class _Generator(object): dst_var, failure_value)) elif underlying_type.property_type == PropertyType.BINARY: - (c.Sblock('if (!%(src_var)s->is_blob()) {') + (c.Sblock('if (!%(src_var)s.is_blob()) {') .Concat(self._AppendError16( 'u"\'%%(key)s\': expected binary, got " + ' + - self._util_cc_helper.GetValueTypeString('%%(src_var)s', True))) + self._util_cc_helper.GetValueTypeString('%%(src_var)s'))) .Append('return %(failure_value)s;') ) (c.Eblock('}') @@ -1079,9 +1077,9 @@ class _Generator(object): ) if is_ptr: c.Append('%(dst_var)s = std::make_unique<std::vector<uint8_t>>(' - '%(src_var)s->GetBlob());') + '%(src_var)s.GetBlob());') else: - c.Append('%(dst_var)s = %(src_var)s->GetBlob();') + c.Append('%(dst_var)s = %(src_var)s.GetBlob();') c.Eblock('}') else: raise NotImplementedError(type_) @@ -1102,7 +1100,7 @@ class _Generator(object): dst_var, failure_value, is_ptr=False): - """Returns Code that converts a ListValue of string constants from + """Returns Code that converts a list Value of string constants from |src_var| into an array of enums of |type_| in |dst_var|. On failure, returns |failure_value|. """ @@ -1113,13 +1111,12 @@ class _Generator(object): cpp_type = self._type_helper.GetCppType(item_type, is_in_container=True) c.Append('%s = std::make_unique<std::vector<%s>>();' % (dst_var, cpp_type)) - (c.Sblock('for (const auto& it : (%s)->GetList()) {' % src_var) + (c.Sblock('for (const auto& it : (%s).GetList()) {' % src_var) .Append('%s tmp;' % self._type_helper.GetCppType(item_type)) .Concat(self._GenerateStringToEnumConversion(item_type, '(it)', 'tmp', - failure_value, - is_ptr=False)) + failure_value)) .Append('%s%spush_back(tmp);' % (dst_var, accessor)) .Eblock('}') ) @@ -1129,8 +1126,7 @@ class _Generator(object): type_, src_var, dst_var, - failure_value, - is_ptr=True): + failure_value): """Returns Code that converts a string type in |src_var| to an enum with type |type_| in |dst_var|. In the generated code, if |src_var| is not a valid enum name then the function will return |failure_value|. @@ -1142,14 +1138,11 @@ class _Generator(object): cpp_type_namespace = '' if type_.namespace != self._namespace: cpp_type_namespace = '%s::' % type_.namespace.unix_name - accessor = '->' if is_ptr else '.' (c.Append('std::string %s;' % enum_as_string) - .Sblock('if (!%s%sGetAsString(&%s)) {' % (src_var, - accessor, - enum_as_string)) + .Sblock('if (!%s.GetAsString(&%s)) {' % (src_var, enum_as_string)) .Concat(self._AppendError16( 'u"\'%%(key)s\': expected string, got " + ' + - self._util_cc_helper.GetValueTypeString('%%(src_var)s', is_ptr))) + self._util_cc_helper.GetValueTypeString('%%(src_var)s'))) .Append('return %s;' % failure_value) .Eblock('}') .Append('%s = %sParse%s(%s);' % (dst_var, diff --git a/chromium/tools/json_schema_compiler/cpp_util.py b/chromium/tools/json_schema_compiler/cpp_util.py index a6b741aafd1..1af4525e293 100644 --- a/chromium/tools/json_schema_compiler/cpp_util.py +++ b/chromium/tools/json_schema_compiler/cpp_util.py @@ -60,18 +60,18 @@ def GetAsFundamentalValue(type_, src): """Returns the C++ code for retrieving a fundamental type from a Value into a variable. - src: Value* + src: Value """ if type_.property_type == PropertyType.BOOLEAN: - s = '%s->GetIfBool()' + s = '%s.GetIfBool()' elif type_.property_type == PropertyType.DOUBLE: - s = '%s->GetIfDouble()' + s = '%s.GetIfDouble()' elif type_.property_type == PropertyType.INTEGER: - s = '%s->GetIfInt()' + s = '%s.GetIfInt()' elif (type_.property_type == PropertyType.STRING or (type_.property_type == PropertyType.FUNCTION and type_.is_serializable_function)): - s = '%s->GetIfString()' + s = '%s.GetIfString()' else: raise ValueError('Type %s is not a fundamental value' % type_.name) diff --git a/chromium/tools/json_schema_compiler/feature_compiler.py b/chromium/tools/json_schema_compiler/feature_compiler.py index 6a94be1f109..b23dca56890 100644 --- a/chromium/tools/json_schema_compiler/feature_compiler.py +++ b/chromium/tools/json_schema_compiler/feature_compiler.py @@ -263,6 +263,7 @@ FEATURE_GRAMMAR = ({ 'linux': 'Feature::LINUX_PLATFORM', 'mac': 'Feature::MACOSX_PLATFORM', 'win': 'Feature::WIN_PLATFORM', + 'fuchsia': 'Feature::FUCHSIA_PLATFORM', } } }, diff --git a/chromium/tools/json_schema_compiler/h_generator.py b/chromium/tools/json_schema_compiler/h_generator.py index 4c22baa4071..97edbfe352e 100644 --- a/chromium/tools/json_schema_compiler/h_generator.py +++ b/chromium/tools/json_schema_compiler/h_generator.py @@ -342,7 +342,8 @@ class _Generator(object): c = Code() (c.Sblock('struct Params {') .Append('static std::unique_ptr<Params> Create(%s);' % - self._GenerateParams(('const base::ListValue& args',))) + self._GenerateParams( + ('const base::Value::ConstListView& args',))) .Append('Params(const Params&) = delete;') .Append('Params& operator=(const Params&) = delete;') .Append('~Params();') diff --git a/chromium/tools/json_schema_compiler/manifest_parse_util.h b/chromium/tools/json_schema_compiler/manifest_parse_util.h index 427739a77f4..a4bbcfbc9ff 100644 --- a/chromium/tools/json_schema_compiler/manifest_parse_util.h +++ b/chromium/tools/json_schema_compiler/manifest_parse_util.h @@ -105,7 +105,7 @@ bool ParseFromDictionary(const base::DictionaryValue& dict, return false; bool result = json_schema_compiler::util::PopulateArrayFromList( - value->AsListValue(*value), out_ptr, error); + value->GetList(), out_ptr, error); if (!result) { DCHECK(error_path_reversed); DCHECK(error_path_reversed->empty()); diff --git a/chromium/tools/json_schema_compiler/model.py b/chromium/tools/json_schema_compiler/model.py index 31486859874..d0c969f7b4a 100644 --- a/chromium/tools/json_schema_compiler/model.py +++ b/chromium/tools/json_schema_compiler/model.py @@ -376,9 +376,15 @@ class Function(object): returns_async = json.get('returns_async', None) if returns_async: - if len(returns_async.get('parameters')) > 1: + returns_async_params = returns_async.get('parameters') + if (returns_async_params is None): + raise ValueError( + 'parameters key not specified on returns_async: %s.%s in %s' % + (namespace.name, name, namespace.source_file)) + if len(returns_async_params) > 1: raise ValueError('Only a single parameter can be specific on ' - 'returns_async: %s.%s' % (namespace.name, name)) + 'returns_async: %s.%s in %s' % + (namespace.name, name, namespace.source_file)) self.returns_async = ReturnsAsync(self, returns_async, namespace, Origin(from_client=True), True) # TODO(https://crbug.com/1143032): Returning a synchronous value is diff --git a/chromium/tools/json_schema_compiler/model_test.py b/chromium/tools/json_schema_compiler/model_test.py index 9fbcafbecc9..e111aa6505b 100755 --- a/chromium/tools/json_schema_compiler/model_test.py +++ b/chromium/tools/json_schema_compiler/model_test.py @@ -132,6 +132,17 @@ class ModelTest(unittest.TestCase): test_json[0], 'path/to/redundant_default_attribute.json') + def testReturnsAsyncMissingParametersKey(self): + test_json = CachedLoad('test/returns_async_missing_parameters_key.json') + self.assertRaisesRegexp( + ValueError, + 'parameters key not specified on returns_async: ' + 'returnsAsyncMissingParametersKey.asyncNoParametersKey in ' + 'path/to/returns_async_missing_parameters_key.json', + self.model.AddNamespace, + test_json[0], + 'path/to/returns_async_missing_parameters_key.json') + def testDescription(self): self.assertFalse( self.permissions.functions['contains'].params[0].description) diff --git a/chromium/tools/json_schema_compiler/util.h b/chromium/tools/json_schema_compiler/util.h index 9a8394dab33..d3875b1430c 100644 --- a/chromium/tools/json_schema_compiler/util.h +++ b/chromium/tools/json_schema_compiler/util.h @@ -69,10 +69,11 @@ bool PopulateItem(const base::Value& from, T* out, std::u16string* error) { // Populates |out| with |list|. Returns false if there is no list at the // specified key or if the list has anything other than |T|. template <class T> -bool PopulateArrayFromList(const base::ListValue& list, std::vector<T>* out) { +bool PopulateArrayFromList(const base::Value::ConstListView& list, + std::vector<T>* out) { out->clear(); T item; - for (const auto& value : list.GetList()) { + for (const auto& value : list) { if (!PopulateItem(value, &item)) return false; // T might not be movable, but in that case it should be copyable, and this @@ -86,13 +87,12 @@ bool PopulateArrayFromList(const base::ListValue& list, std::vector<T>* out) { // Populates |out| with |list|. Returns false and sets |error| if there is no // list at the specified key or if the list has anything other than |T|. template <class T> -bool PopulateArrayFromList(const base::ListValue& list_value, +bool PopulateArrayFromList(const base::Value::ConstListView& list, std::vector<T>* out, std::u16string* error) { out->clear(); T item; std::u16string item_error; - const auto& list = list_value.GetList(); for (size_t i = 0; i < list.size(); ++i) { if (!PopulateItem(list[i], &item, &item_error)) { DCHECK(error->empty()); @@ -111,7 +111,7 @@ bool PopulateArrayFromList(const base::ListValue& list_value, // true on success or if there is nothing at the specified key. Returns false // if anything other than a list of |T| is at the specified key. template <class T> -bool PopulateOptionalArrayFromList(const base::ListValue& list, +bool PopulateOptionalArrayFromList(const base::Value::ConstListView& list, std::unique_ptr<std::vector<T>>* out) { out->reset(new std::vector<T>()); if (!PopulateArrayFromList(list, out->get())) { @@ -122,7 +122,7 @@ bool PopulateOptionalArrayFromList(const base::ListValue& list, } template <class T> -bool PopulateOptionalArrayFromList(const base::ListValue& list, +bool PopulateOptionalArrayFromList(const base::Value::ConstListView& list, std::unique_ptr<std::vector<T>>* out, std::u16string* error) { out->reset(new std::vector<T>()); diff --git a/chromium/tools/json_schema_compiler/util_cc_helper.py b/chromium/tools/json_schema_compiler/util_cc_helper.py index 40fb30ed026..f1670d3e2e5 100644 --- a/chromium/tools/json_schema_compiler/util_cc_helper.py +++ b/chromium/tools/json_schema_compiler/util_cc_helper.py @@ -29,8 +29,5 @@ class UtilCCHelper(object): def GetIncludePath(self): return '#include "tools/json_schema_compiler/util.h"' - def GetValueTypeString(self, value, is_ptr=False): - call = '.type()' - if is_ptr: - call = '->type()' - return 'UTF8ToUTF16(base::Value::GetTypeName(%s%s))' % (value, call) + def GetValueTypeString(self, value): + return 'UTF8ToUTF16(base::Value::GetTypeName(%s.type()))' % value diff --git a/chromium/tools/licenses.py b/chromium/tools/licenses.py index d6787f6455e..f251273b895 100755 --- a/chromium/tools/licenses.py +++ b/chromium/tools/licenses.py @@ -40,42 +40,39 @@ from util import build_utils # Paths from the root of the tree to directories to skip. PRUNE_PATHS = set([ # Placeholder directory only, not third-party code. - os.path.join('third_party','adobe'), + os.path.join('third_party', 'adobe'), # Will remove it once converted private sdk using cipd. - os.path.join('third_party','android_tools_internal'), + os.path.join('third_party', 'android_tools_internal'), # Build files only, not third-party code. - os.path.join('third_party','widevine'), + os.path.join('third_party', 'widevine'), # Only binaries, used during development. - os.path.join('third_party','valgrind'), + os.path.join('third_party', 'valgrind'), # Used for development and test, not in the shipping product. - os.path.join('build','secondary'), - os.path.join('third_party','bison'), - os.path.join('third_party','blanketjs'), - os.path.join('third_party','chromite'), - os.path.join('third_party','cygwin'), - os.path.join('third_party','gles2_conform'), - os.path.join('third_party','gnu_binutils'), - os.path.join('third_party','gold'), - os.path.join('third_party','gperf'), - os.path.join('third_party','lighttpd'), - os.path.join('third_party','llvm'), - os.path.join('third_party','llvm-build'), - os.path.join('third_party','mingw-w64'), - os.path.join('third_party','nacl_sdk_binaries'), - os.path.join('third_party','pefile'), - os.path.join('third_party','perl'), - os.path.join('third_party','psyco_win32'), - os.path.join('third_party','pyelftools'), - os.path.join('third_party','pylib'), - os.path.join('third_party','pywebsocket'), - os.path.join('third_party','syzygy'), - - # Chromium code. - os.path.join('tools', 'swarming_client'), + os.path.join('build', 'secondary'), + os.path.join('third_party', 'bison'), + os.path.join('third_party', 'blanketjs'), + os.path.join('third_party', 'chromite'), + os.path.join('third_party', 'cygwin'), + os.path.join('third_party', 'gles2_conform'), + os.path.join('third_party', 'gnu_binutils'), + os.path.join('third_party', 'gold'), + os.path.join('third_party', 'gperf'), + os.path.join('third_party', 'lighttpd'), + os.path.join('third_party', 'llvm'), + os.path.join('third_party', 'llvm-build'), + os.path.join('third_party', 'mingw-w64'), + os.path.join('third_party', 'nacl_sdk_binaries'), + os.path.join('third_party', 'pefile'), + os.path.join('third_party', 'perl'), + os.path.join('third_party', 'psyco_win32'), + os.path.join('third_party', 'pyelftools'), + os.path.join('third_party', 'pylib'), + os.path.join('third_party', 'pywebsocket'), + os.path.join('third_party', 'syzygy'), # Stuff pulled in from chrome-internal for official builds/tools. os.path.join('third_party', 'clear_cache'), @@ -89,8 +86,11 @@ PRUNE_PATHS = set([ # Chrome for Android proprietary code. os.path.join('clank'), + # Proprietary DevTools code. + os.path.join('third_party', 'devtools-frontend-internal'), + # Redistribution does not require attribution in documentation. - os.path.join('third_party','directxsdk'), + os.path.join('third_party', 'directxsdk'), # For testing only, presents on some bots. os.path.join('isolate_deps_dir'), diff --git a/chromium/tools/linux/dump-static-initializers.py b/chromium/tools/linux/dump-static-initializers.py index 61ef9836ed5..306cd189587 100755 --- a/chromium/tools/linux/dump-static-initializers.py +++ b/chromium/tools/linux/dump-static-initializers.py @@ -27,6 +27,7 @@ they reference. from __future__ import print_function import optparse +import os import re import subprocess import sys @@ -46,7 +47,15 @@ class Demangler(object): """A wrapper around c++filt to provide a function to demangle symbols.""" def __init__(self, toolchain): - self.cppfilt = subprocess.Popen([toolchain + 'c++filt'], + # llvm toolchain uses cxx rather than c++. + path = toolchain + 'cxxfilt' + if not os.path.exists(path): + path = toolchain + 'c++filt' + if not os.path.exists(path): + # Android currently has an issue where the llvm toolchain in the ndk does + # not contain c++filt. Hopefully fixed in next NDK update... + path = 'c++filt' + self.cppfilt = subprocess.Popen([path], stdin=subprocess.PIPE, stdout=subprocess.PIPE, universal_newlines=True) diff --git a/chromium/tools/mac/power/BUILD.gn b/chromium/tools/mac/power/BUILD.gn new file mode 100644 index 00000000000..52321bcadda --- /dev/null +++ b/chromium/tools/mac/power/BUILD.gn @@ -0,0 +1,70 @@ +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +# This is the root build file for mac power-related tooling. To build the +# targets here you can do something like +# +# ninja -C out/Default tools/mac/power:all + +import("//build/config/mac/mac_sdk.gni") +import("//testing/test.gni") + +# This file should only be included for macOS. +assert(is_mac) + +group("all") { + testonly = true + + deps = [ + ":power_sampler", + ":power_sampler_unittests", + ] +} + +static_library("power_sampler_lib") { + sources = [ + "power_sampler/backlight_level_sampler.cc", + "power_sampler/backlight_level_sampler.h", + "power_sampler/monitor.cc", + "power_sampler/monitor.h", + "power_sampler/sampler.cc", + "power_sampler/sampler.h", + "power_sampler/sampling_controller.cc", + "power_sampler/sampling_controller.h", + "power_sampler/user_idle_level_sampler.cc", + "power_sampler/user_idle_level_sampler.h", + ] + deps = [ "//base" ] + frameworks = [ + # Used by the backlight sampler. + "DisplayServices.framework", + ] + framework_dirs = [ "$mac_sdk_path/System/Library/PrivateFrameworks" ] +} + +executable("power_sampler") { + sources = [ "power_sampler/power_sampler_main.cc" ] + deps = [ + ":power_sampler_lib", + "//base", + ] +} + +test("power_sampler_unittests") { + testonly = true + sources = [ + "power_sampler/backlight_level_sampler_unittest.cc", + "power_sampler/sampling_controller_unittest.cc", + "power_sampler/user_idle_level_sampler_unittest.cc", + ] + + deps = [ + ":power_sampler_lib", + "//base", + "//base/test:run_all_unittests", + "//base/test:test_support", + "//testing/gmock", + "//testing/gtest", + ] +} diff --git a/chromium/tools/mac/power/README.md b/chromium/tools/mac/power/README.md index 95498243d28..83bce6ee005 100644 --- a/chromium/tools/mac/power/README.md +++ b/chromium/tools/mac/power/README.md @@ -1,11 +1,102 @@ -# Usage scenario scripts +# Mac power measurement + +This directory contains the tools necessary to run different browsers and usage scenarios and measuring their +performance impact. For Chromium it's also possible to generate profiles of CPU use. See `benchmark.py` for +running the full suite. See `collapse_profile.py` for generating profiles. + + +## Setting Up + +### Python Virtual Environment +These scripts use python [Virtual Environments](https://docs.python.org/3/tutorial/venv.html). + +Create the venv. Only needs to be done once. +``` +python3 -m venv ./env +``` +Activate the venv. +``` +source ./env/bin/activate +``` +Once the venv is activated, `python` refers to python3. +Upgrade pip and install all python dependencies. +``` +python -m pip install -U pip +python -m pip install -r requirements.txt +``` + +To deactivate venv. +``` +deactivate +``` + +### Chromium build + +If measuring of profiling Chromium it needs to be built with the following args.gn and copied to the "Applications" folder. + + use_goma = true + is_debug = false + is_component_build = false + symbol_level = 0 + blink_symbol_level = 0 + is_official_build = true + +## Getting around sudo password + +To disable asking password for sudo commands (required by powermetrics). +Run `sudo visudo` and add the last line to User specification (replacing `<user>`): +``` +# root and users in group wheel can run anything on any machine as any user +root ALL = (ALL) ALL +%admin ALL = (ALL) ALL +<user> ALL = (ALL) NOPASSWD:ALL +``` + +## DTrace + +Running benchmark.py in profile mode uses `dtrace` to analyse the chromium processes. By default `dtrace` does not work well with [SIP](https://support.apple.com/en-us/HT204899). Disabling SIP as a whole is not recommended and instead should be done only for dtrace using these steps: + +* Reboot in recovery mode +* Start a shell +* Execute `csrutil enable --without dtrace --without debug` +* Reboot + +## benchmark.py + +A tool that allow you to run different browsers under specific usage scenarios and: + +* Measure their impact of system resource use. +* Profile the code that runs and/or is causing wake-ups. (chromium only) + +``` +./benchmark.py ./results --measure +./benchmark.py ./profile --profile_mode cpu_time +``` + +## collapse_profile.py + +A tool that converts the DTrace results created by benchmark.py into a format suitable for +FlameGraph generation and analysis. It also applies some Chromium specific filtering and enhancements. + +``` +./collapse_profile.py ./profile --profile_mode cpu_time +``` + +This command will produce a file at `./samples/samples.collapsed.cpu_time`. + +This file can be used with tools such as: + +* [FlameGraph](https://github.com/brendangregg/FlameGraph) +* [SpeedScope](https://www.speedscope.app/) + +## Usage scenario scripts This directory contains the necessary files to make Chromium based browsers and Safari execute usage scenarios that represent real world usage. The scripts differ slightly from similar tools like telemetry tests in that they work for Safari. -## Scenarios +### Scenarios Scenarios are a set of operations to be applied on a set of URLs. For example: @@ -16,7 +107,7 @@ For example: It's interesting to gather power metrics, profiles and traces for specific scenarios to understand their performance characteristics. -# Usage +### Usage First `generate_scripts.py` needs to be used to convert the templates in `driver_script_templates/` into working AppleScript. The templating allows for the generation of scripts that work with many different @@ -28,7 +119,7 @@ Once generated the driver scripts are found in `driver_scripts/` and can be invo osascript ./driver_scripts/chrome_navigation.scpt ``` -Once the scenario has run it's course the script will exit. If the desired the +Once the scenario has run its course the script will exit. If the desired the browser can be opened by hand before running the scenario to modify the starting state. @@ -39,3 +130,7 @@ jinja2 templates that need to be rendered into usable Applescript. Files in `driver_script_templates/` that end in .scpt are already working Applescript and will be copied as is to `driver_script/`. + +# Tests + +Unit tests can be run using `run_tests.py`. diff --git a/chromium/tools/mac/power/benchmark.py b/chromium/tools/mac/power/benchmark.py new file mode 100755 index 00000000000..16b76a357ea --- /dev/null +++ b/chromium/tools/mac/power/benchmark.py @@ -0,0 +1,111 @@ +#!/usr/bin/env python3 + +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import argparse +import logging +import os +import psutil +import signal +import subprocess +import sys +import time + +import utils +from driver import Driver +import generate_scripts + + +def SignalHandler(sig, frame, driver): + """Handle the run being aborted. + """ + driver.Teardown() + sys.exit(0) + + +def main(): + parser = argparse.ArgumentParser(description='Runs browser power benchmarks') + parser.add_argument("output_dir", help="Output dir") + parser.add_argument('--no-checks', + dest='no_checks', + action='store_true', + help="Invalid environment doesn't throw") + parser.add_argument( + '--measure', + dest='run_measure', + action='store_true', + help="Run measurements of the cpu use of the application.") + + # Profile related arguments + parser.add_argument( + '--profile_mode', + dest='profile_mode', + action='store', + choices=["wakeups", "cpu_time"], + help="Profile the application in one of two modes: wakeups, cpu_time.") + parser.add_argument('--meet-meeting-id', + dest='meet_meeting_id', + action='store', + help='The meeting ID to use for the Meet benchmarks') + parser.add_argument( + '--chrome-user-dir', + dest='chrome_user_dir', + action='store', + help='The user data dir to pass to Chrome via --user-data-dir') + + parser.add_argument('--verbose', + action='store_true', + default=False, + help='Print verbose output.') + + args = parser.parse_args() + + if args.verbose: + log_level = logging.INFO + else: + log_level = logging.WARNING + logging.basicConfig(format='%(levelname)s: %(message)s', level=log_level) + + if args.profile_mode and args.run_measure: + logging.error("Cannot measure and profile at the same time, choose one.") + sys.exit(-1) + + # Generate the runner scripts + extra_args = {} + if args.meet_meeting_id: + extra_args["meeting_id"] = args.meet_meeting_id + generate_scripts.generate_all(extra_args) + + driver = Driver(args.output_dir) + driver.CheckEnv(not args.no_checks) + + signal.signal( + signal.SIGINT, lambda sig, frame: SignalHandler(sig, frame, driver)) + + if args.chrome_user_dir: + chrome_extra_arg = "--user-data-dir=%s" % args.chrome_user_dir + else: + chrome_extra_arg = "--guest" + + # Measure or Profile all defined scenarios. To add/remove some change their + # "skip" attribute in utils.SCENARIOS. + for scenario in utils.SCENARIOS: + + if scenario["browser"] != "Safari": + scenario["extra_args"].append(chrome_extra_arg) + + # TODO(crbug.com/1224994): Allow scenario filtering like gtest_filter. + if not scenario["skip"]: + if args.run_measure: + logging.info(f'Recording scenario {scenario["name"]} ...') + driver.Record(scenario) + + if args.profile_mode: + logging.info(f'Profiling scenario {scenario["name"]} ...') + driver.Profile(scenario, profile_mode=args.profile_mode) + + +if __name__ == "__main__": + main() diff --git a/chromium/tools/mac/power/check_env.sh b/chromium/tools/mac/power/check_env.sh new file mode 100755 index 00000000000..ba9e8452617 --- /dev/null +++ b/chromium/tools/mac/power/check_env.sh @@ -0,0 +1,85 @@ +#!/bin/zsh + +# Copyright (c) 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +set -eu + +function SystemProfilerProperty() +{ + local result=$2 + local local_result=$(system_profiler $3| grep -i $1 |\ + cut -d ":" -f 2 | awk '{$1=$1};1') + eval $result="'$local_result'" +} + +function GetPowerProperty() +{ + SystemProfilerProperty $1 $2 "SPPowerDataType" +} + +function GetDisplayProperty() +{ + SystemProfilerProperty $1 $2 "SPDisplaysDataType" +} + +function CompareValue() +{ + if [ "$1" != "$2" ]; then + echo $3 + exit 127 + fi +} + +CheckPowerValue() +{ + # Query value, remove newlines. + GetPowerProperty $1 VALUE + VALUE=$(echo $VALUE|tr -d '\n') + + CompareValue $VALUE $2 $3 +} + +CheckDisplayValue() +{ + # Query value, remove newlines. + GetDisplayProperty $1 VALUE + VALUE=$(echo $VALUE|tr -d '\n') + + CompareValue $VALUE $2 $3 +} + +function CheckProgramNotRunning(){ + if pgrep -x "$1" > /dev/null; then + echo "$2" + exit 127 + fi +} + +function CheckEnv() +{ + # Validate power setup. + CheckPowerValue "charging" "NoNo" "Laptop cannot be charging during test." + CheckPowerValue "connected" "No" "Charger cannot be connected during test." + + # Validate display setup. + CheckDisplayValue "Automatically adjust brightness" "No"\ + "Disable automatic brightness adjustments and unplug external monitors" + + # Use Amphetamine.app to avoid sleeping during the tests. + if ! pgrep -x "Amphetamine" > /dev/null; then + echo "Use Amphetamine to prevent sleep." + exit 127 + fi + CompareValue $(defaults read com.if.Amphetamine "Default Duration") "0"\ + "Default session length in Amphetamine should be unlimited"; + + # Verify that no terminals are running. + # They introduce too much overhead. (As measured with powermetrics) + CheckProgramNotRunning "Terminal" "Do not have a terminal opened. Use SSH."; + CheckProgramNotRunning "iTerm2" "Do not have a terminal opened. Use SSH."; + +} + +CheckEnv diff --git a/chromium/tools/mac/power/collapse_profile.py b/chromium/tools/mac/power/collapse_profile.py new file mode 100755 index 00000000000..10dc88483ef --- /dev/null +++ b/chromium/tools/mac/power/collapse_profile.py @@ -0,0 +1,291 @@ +#!/usr/bin/env python3 + +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +from collections import defaultdict +import argparse +import csv +import logging +import os +import sys +"""This module contains the utilities necessary to read Dtrace result files and +convert them in the collapse stack format used by FlameGraph tools. +""" + + +class StackCollapser: + """Massages and collapses chromium Dtrace profiles. + + Collapsing means taking samples in the DTrace format from multiple files and + converting them to the "collapsed stack" format that is used in tools like + flamegraphs. The format is called "collapsed" because it puts the whole stack + on a single line. + + The massaging part consists in cutting out and adding stack frames to make + the profile easier to use for the purpose of analyzing Chromium performance. + + Typical usage example: + + collapser = StackCollapser('./samples/samples.collapsed') + collapser.read_dtrace_logs('./profile/') + collapser.post_process_samples() + collapse.write_results() + """ + + def __init__(self, output_filename): + """ + Args: + output_filename: The path of the file in which results are written. + """ + self.output_filename = output_filename + self.samples = [] + self.post_processing_applied = False + + def set_samples_for_testing(self, samples): + """ + Args: + samples: Values extracted from profiles. Type is: + {"frames": list of str, "weight": int} + """ + self.samples = samples + + def read_dtrace_logs(self, stack_dir): + """ + Args: + stack_dir: The directory where Dtrace profile results can be found. + + Returns: + A list of string arrays that contain stack frames and a count. + + Raises: + SystemExit: When no results are found in stack_dir. + """ + # The DTrace format is defined as such: + # First there are lines, each containing + # the name of a function with an optional offset. + # Finally there is a line with the weight associated + # with the full stack. The block is broken up by an + # empty line and a new stack starts. + # + # base::foo+0x21 + # content::bar + # biz::baz + # 17 + # + # ... + + weights = defaultdict(int) + for root, dirs, files in os.walk(stack_dir): + for stack_file in files: + with open(os.path.join(stack_dir, stack_file), + newline='', + encoding="ISO-8859-1") as stack_file: + lines = stack_file.readlines() + + # Read each such blocks in all DTrace results + # and store in the return format. + block = [] + for line in lines: + if not line.strip(): + # If an empty line is encountered. + if block: + # If that empty line was terminating a block. + + # Keep the count. + weight = block.pop() + + # Reorder the frames since they were reversed while reading. + block.reverse() + + # Build the full stack line. + stack_trace_string = ";".join(block) + + # Increment the sum of weights for this specific full stack. + weights[stack_trace_string] += int(weight) + + # Start a new block. + block = [] + else: + # Read the line to build on the current block. + stack_frame = line.strip() + + # Remove offset + plus_index = stack_frame.find('+') + if plus_index != -1: + stack_frame = stack_frame[:plus_index] + + block.append(stack_frame) + + for stack, weight in weights.items(): + sample = {} + sample["frames"] = stack.split(';') + sample["weight"] = weight + self.samples.append(sample) + + if not self.samples: + logging.error("No results found, check directory contents") + sys.exit(-1) + + def shorten_stack(self, stack): + """Drop some frames that don't offer any valuable information. The part + above/before the frame is trimmed. This means that the base of the stack + can be dropped but no frame can "skipped". + + Example (dropping biz): + + foo;bar;biz;boo --> boo + foo;biz;bar;boo --> bar;boo + + Args: + stack: An array of strings that represent each frame of a stack trace. + + Returns: The input array with zero or more elements removed. + """ + + message_pump_roots = [ + "base::MessagePumpNSRunLoop::DoRun", "base::MessagePumpDefault::Run", + "base::MessagePumpKqueue::Run", "base::MessagePumpCFRunLoopBase::Run", + "base::MessagePumpNSApplication::DoRun", "base::mac::CallWithEHFrame" + ] + + first_ignored_index = -1 + for i, frame in enumerate(stack): + if any( + frame.startswith(message_pump_root) + for message_pump_root in message_pump_roots): + # If any of the markers is present in the function it means everything + # under the frame should be dropped from the stack. + first_ignored_index = max( + i - 1, + 0) # Cutoff point is included but can't be smaller than zero. + break + + if first_ignored_index != -1: + return stack[first_ignored_index + 1:] + else: + return stack + + def add_category_from_any_frame(self, stack): + """Adds synthetic frame according to some generic categories to help + analyze the results. + + Args: + stack: An array of strings that represent each frame of a stack trace. + + Returns: The input array with zero or one element added. + """ + + # Categories ordered by importance. Each element of the list is an + # array of synonyms. + special_markers = [['viz'], ['net::', 'network::'], ['blink::'], ['mojo::'], + ['gpu::'], ['v8::'], ['sql::'], ['CoreText'], ['AppKit'], + ['Security'], ['CoreFoundation']] + + # Look for the presence of any of the special markers in the stack and + # compound them to create the synthetic frame. + compound_marker = [] + for synonyms in special_markers: + for variation in synonyms: + for frame in stack: + if variation in frame and variation not in compound_marker: + compound_marker.append(synonyms[0]) + + # Add some namespace separators for markers that didn't have them. + for i, marker in enumerate(compound_marker): + if marker.find("::") == -1: + compound_marker[i] = marker + "::" + + if compound_marker: + compound_marker.sort() + stack = ["".join(compound_marker)] + stack + + return stack + + def remove_tokens(self, stack): + """Removes some substrings from frames in the stack. + + Args: + stack: An array of strings that represent each frame of a stack trace. + + Returns: The input array with zero or more frames modified. + """ + + # Drop parts of the function names that just add noise. + tokens_to_remove = [ + "Chromium Framework`", "libsystem_kernel.dylib`", "Security`" + ] + + for i, frame in enumerate(stack): + for token in tokens_to_remove: + # If removing the token would result in an empty string don't + # remove it. + if stack[i] != token: + stack[i] = stack[i].replace(token, "") + + return stack + + def write_down_samples(self): + """Writes down self.samples to a file. In contrast to the Dtrace format full + stacks are writtent on a single line. At first the different are separated + by semi-colons and a space separates the weight associated with the + function. + + Example: + + base::foo;content::bar;biz::baz 17 + base::biz;content::boo;biz::bim 23 + ... + + """ + + if not os.path.exists(os.path.dirname(self.output_filename)): + os.makedirs(os.path.dirname(self.output_filename)) + + with open(self.output_filename, 'w') as f: + for row in self.samples: + line = ';'.join(row["frames"]) + weight = row["weight"] + # Reform the line in stacked format and write it out. + f.write(f"{line} {weight}\n") + + def post_process_samples(self): + """Applies filtering and enhancing to self.samples(). This function can + only be called once. + + Raises: + SystemExit: If this function is called twice on the same object. + """ + + if self.post_processing_applied: + logging.error("Post processing cannot be applied twice") + sys.exit(-1) + self.post_processing_applied = True + + processed_samples = [] + for row in self.samples: + # Filter out the frames we don't care about and all those under it. + row["frames"] = self.shorten_stack(row["frames"]) + row["frames"] = self.add_category_from_any_frame(row["frames"]) + row["frames"] = self.remove_tokens(row["frames"]) + + +def main(stack_dir, output_filename): + collapser = StackCollapser(output_filename) + collapser.read_dtrace_logs(stack_dir) + collapser.post_process_samples() + collapser.write_down_samples() + + +if __name__ == "__main__": + parser = argparse.ArgumentParser( + description='Flip stack order of a collapsed stack file.') + parser.add_argument("--stack_dir", + help="Collapsed stack file.", + required=True) + parser.add_argument("--output_filename", + help="The file to write the collapsed stacks into.", + required=True) + args = parser.parse_args() + main(args.stack_dir, args.output_filename) diff --git a/chromium/tools/mac/power/collapse_profile_test.py b/chromium/tools/mac/power/collapse_profile_test.py new file mode 100644 index 00000000000..4e538b41889 --- /dev/null +++ b/chromium/tools/mac/power/collapse_profile_test.py @@ -0,0 +1,199 @@ +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import unittest +from collapse_profile import StackCollapser + + +class DTraceReadTest(unittest.TestCase): + def testEmpty(self): + """Tests that a directory with no valid stacks triggers a failure.""" + + with self.assertRaises(SystemExit): + collapser = StackCollapser('./samples.collapsed') + collapser.read_dtrace_logs('./test_data/empty/') + + def testValidBlock(self): + """Tests basic parsing of the DTrace format.""" + + collapser = StackCollapser('./samples.collapsed') + collapser.read_dtrace_logs('./test_data/valid/') + self.assertEquals(collapser.samples, [{ + 'frames': ['foo', 'bar', 'baz'], + 'weight': 12 + }]) + + def testRepeatedFunction(self): + """Tests accumulation of samples of the same function over many files.""" + + collapser = StackCollapser('./samples.collapsed') + collapser.read_dtrace_logs('./test_data/repeated/') + self.assertEquals(collapser.samples, [{ + 'frames': ['foo', 'bar', 'baz'], + 'weight': 24 + }]) + + def testTrimFunctionOffset(self): + """Tests removal of the function offset markers in the DTrace format.""" + + collapser = StackCollapser('./samples.collapsed') + collapser.read_dtrace_logs('./test_data/with_offset/') + self.assertEquals(collapser.samples, [{ + 'frames': ['foo', 'bar', 'baz'], + 'weight': 12 + }]) + + +class StackCollapseTest(unittest.TestCase): + def testDoublePostProcessFails(self): + """Tests that calling post_process_samples() twice triggers a failure.""" + + samples = [{'frames': ['foo', 'bar', 'baz'], 'weight': 24}] + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + + with self.assertRaises(SystemExit): + stack_collapser.post_process_samples() + stack_collapser.post_process_samples() + + def testNoStackShortening(self): + """Tests that sampes with no uninteresting frames don't get modified.""" + + samples = [{'frames': ['foo', 'bar', 'baz'], 'weight': 24}] + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(samples, stack_collapser.samples) + + def testTokenClean(self): + """Tests that tokens that need to be removed are cleaned and others + are left untouched.""" + + samples = [{ + 'frames': ['Chromium Framework`foo', 'bar', 'baz'], + 'weight': 24 + }] + cleaned_samples = [{'frames': ['foo', 'bar', 'baz'], 'weight': 24}] + + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(cleaned_samples, stack_collapser.samples) + + def testNoStackShortening(self): + """Tests that sampes with no uninteresting frames don't get modified.""" + + samples = [{'frames': ['foo', 'bar', 'baz'], 'weight': 24}] + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(samples, stack_collapser.samples) + + def testCutoffPointPreserved(self): + """Tests that shortening a stack is inclusive of the cutoff point.""" + + samples = [{ + 'frames': + ['foo', 'bar', 'baz', 'base::MessagePumpNSRunLoop::DoRun', "biz"], + 'weight': + 24 + }] + shortened_stack = [{ + 'frames': ['base::MessagePumpNSRunLoop::DoRun', "biz"], + 'weight': 24 + }] + + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(shortened_stack, stack_collapser.samples) + + def testNoStackDisappearance(self): + """Tests that a stack that finishes with an ignored frame isn't culled from + the report. It represents overhead and should be kept""" + + samples = [{ + 'frames': ['foo', 'bar', 'baz', 'base::MessagePumpNSRunLoop::DoRun'], + 'weight': + 24 + }] + shortened_stack = [{ + 'frames': ['base::MessagePumpNSRunLoop::DoRun'], + 'weight': 24 + }] + + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(shortened_stack, stack_collapser.samples) + + def testStackShortening(self): + """Tests that stacks get shortened to drop frames of low interest.""" + + samples = [{ + 'frames': ['foo', 'bar', 'baz'], + 'weight': 24 + }, { + 'frames': ['foo', 'bar', 'baz', 'base::MessagePumpNSRunLoop::DoRun'], + 'weight': + 24 + }] + + # Stack will be shortened to remove anything before the uninteresting frame. + shortened_samples = samples.copy() + shortened_samples[1]["frames"] = shortened_samples[1]["frames"][2:] + + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(shortened_samples, stack_collapser.samples) + + def testSingleSyntheticMarker(self): + """Tests that when a single frame of interest is found the appropriate + synthetic frame is added to the bottom of the stack.""" + + samples = [{'frames': ['foo', 'bar', 'baz'], 'weight': 24}] + + # Stack will be augmented with mojo marker + augmented_stack = samples.copy() + augmented_stack[0]["frames"] = ['viz::'] + augmented_stack[0]["frames"] + + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(augmented_stack, stack_collapser.samples) + + def testSynonymMarkers(self): + """Tests that two markers that are synonyms trigger the addition of the same + synthetic frame.""" + + samples = [{'frames': ['foo', 'bar', '::network'], 'weight': 24}] + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + + samples_2 = [{'frames': ['foo', 'bar', '::net'], 'weight': 24}] + stack_collapser_2 = StackCollapser('./samples.collapsed') + stack_collapser_2.set_samples_for_testing(samples_2) + stack_collapser_2.post_process_samples() + + # Same synthetic stack frame is added. + self.assertEquals(stack_collapser.samples[0]["frames"][0], + stack_collapser_2.samples[0]["frames"][0]) + + def testCompoundSyntheticMarker(self): + """Tests that when more than one frame of interest is found the correct + compound synthetic frame is added to the bottom of the stack.""" + + samples = [{'frames': ['foo', 'bar', 'viz', '::network'], 'weight': 24}] + + # Stack will be augmented with mojo marker + augmented_stack = samples.copy() + augmented_stack[0]["frames"] = ['mojo::viz::' + ] + augmented_stack[0]["frames"] + + stack_collapser = StackCollapser('./samples.collapsed') + stack_collapser.set_samples_for_testing(samples) + stack_collapser.post_process_samples() + self.assertEquals(augmented_stack, stack_collapser.samples) diff --git a/chromium/tools/mac/power/driver.py b/chromium/tools/mac/power/driver.py new file mode 100644 index 00000000000..487ca643691 --- /dev/null +++ b/chromium/tools/mac/power/driver.py @@ -0,0 +1,311 @@ +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import logging +import os +import psutil +import subprocess +import sys +import time + +import utils + +class Driver: + """Class in charge of running the measurements and keeping track + of the global state needed to do so. + """ + + def __init__(self, output_dir): + """ + Args: + output_dir: A string path of Where the results should be stored. + """ + + self._started_processeds = [] + self.__output_dir = output_dir + + # Make sure there is somewhere to put results. + os.makedirs(f"{self.__output_dir}", exist_ok=True) + + def CheckEnv(self, throw_on_bad_env): + """Verifies that the environment is conducive to proper profiling or + measurements. + + Args: + throw_on_bad_env: False if executions continues no matter what and + only warnings are printed. + + Raises: + SystemExit: When the environment is invalid and throw_on_bad_env is + True. + """ + + if throw_on_bad_env: + logging_function = logging.error + else: + logging_function = logging.warning + + logging.warning("Trying sudo access. Possibly enter password:") + sudo_check = subprocess.Popen(["sudo", "ls"], + stdout=subprocess.DEVNULL, + stderr=subprocess.STDOUT) + sudo_check.wait() + + try: + check_env = subprocess.run(['zsh', '-c', './check_env.sh'], + check=throw_on_bad_env, + capture_output=True) + logging_function(check_env.stdout.decode('ascii')) + except subprocess.CalledProcessError as e: + logging_function(e.stdout.decode('ascii')) + sys.exit(-1) + + # Make sure that no browsers are running which would affect the + # tests. + for browser in utils.get_browser_process_names(): + if self.FindBrowserProcess(browser): + logging_function(f"{browser} already running. \ + Make sure to close it before running again.") + + if throw_on_bad_env: + sys.exit(-1) + + def Teardown(self): + """Cleans up global state after all calls to Record()/Profile(). + + Makes sure that all processes started for measurement/profiling are exited + and that the execution can move on to the next one. + """ + + # Cleanup can't be achieved with a simple call to psutil.waitprocs() because + # some executables are started with sudo and will end up as a zombie + # processes. + for process in self._started_processeds: + logging.info(f"Terminating PID:{process.pid}") + + try: + process.terminate() + process.wait(0.5) + except psutil.NoSuchProcess: + continue + except (psutil.TimeoutExpired, psutil.AccessDenied) as e: + logging.info(f"Terminate failed, moving on to kill.") + + try: + process.kill() + process.wait(0.5) + except psutil.NoSuchProcess: + continue + except (psutil.TimeoutExpired, psutil.AccessDenied) as e: + logging.info(f"Kill failed, trying sudo kill.") + + try: + os.system(f"sudo kill {process.pid}") + process.wait(0.5) + except psutil.NoSuchProcess: + continue + except psutil.TimeoutExpired: + logging.error(f"Could not clean up PID:{process.pid}. Aborting") + sys.exit(-1) + + # Start over for next round. + self._started_processeds.clear() + + def FindBrowserProcess(self, browser): + """Looks for the process associated with |browser|. + + Args: + browser: A string of the browser name + + Returns: + A psutil.process representation of the browser process. + + Raises: + SystemExit: When no process is found for the browser. + """ + + process_name = utils.get_browser_property(browser, 'process_name') + processes = filter(lambda p: p.name() == process_name, + psutil.process_iter()) + browser_process = None + + for process in processes: + if not browser_process: + browser_process = process + else: + logging.error("Too many copies of the browser running, this is wrong") + sys.exit(-1) + + return browser_process + + def RunScenario(self, scenario_config): + """Start the browser and initiate the scenario + + Args: + scenario_config: A dictionary describing the scenario. + + Returns: A psutil.process representation the driver script process. + """ + + scenario_browser = scenario_config["browser"] + + if scenario_browser is not None: + browser_executable = utils.get_browser_property(scenario_browser, + 'executable') + if scenario_browser in ["Chromium", "Chrome", "Canary", "Edge"]: + subprocess.call(["open", "-a", browser_executable, "--args"] + + ["--enable-benchmarking", "--disable-stack-profiler"] + + scenario_config["extra_args"]) + elif scenario_browser == "Safari": + subprocess.call(["open", "-a", browser_executable]) + # Call prep_safari.scpt to make sure the run starts clean. See file + # comment for details. + subprocess.call(["osascript", './driver_scripts/prep_safari.scpt']) + subprocess.call(["open", "-a", browser_executable, "--args"] + + scenario_config["extra_args"]) + + # Wait for the browser to be started and ready for AppleScript commands. + if scenario_browser: + browser_process_name = utils.get_browser_property(scenario_browser, + 'process_name') + browser_process = None + while not browser_process: + browser_process = self.FindBrowserProcess(scenario_config["browser"]) + time.sleep(0.100) + logging.info(f"Waiting for {browser_process_name} to start") + + self._started_processeds.append(browser_process) + + driver_script_args = [ + "osascript", f'./driver_scripts/{scenario_config["driver_script"]}.scpt' + ] + process = subprocess.Popen(driver_script_args) + + return process + + def Record(self, scenario_config): + """Cover the running of the scenario with powermetrics and save + the results + + Args: + scenario_config: A dictionary describing the scenario. + """ + + output_file = \ + f'./{self.__output_dir}/{scenario_config["name"]}_powermetrics.plist' + + with open(output_file, "w") as powermetrics_output: + + # TODO(crbug.com/1224994): Narrow down samplers to only those of interest. + powermetrics_args = [ + "sudo", "powermetrics", "-f", "plist", "--samplers", "all", + "--show-responsible-pid", "--show-process-gpu", + "--show-process-energy", "-i", "60000" + ] + + powermetrics_process = subprocess.Popen(powermetrics_args, + stdout=powermetrics_output, + stdin=subprocess.PIPE) + + self._started_processeds.append(psutil.Process(powermetrics_process.pid)) + + + # No need to add |scenario_process| to |self._started_processeds| as it's + # explicitly waited on. + scenario_process = self.RunScenario(scenario_config) + scenario_process.wait() + + self.Teardown() + + + def GetAllPids(self, browser_process): + """Get the pids for the browser and all children. w + + Args: + browser_process: A psutil.Process object associated with the + browser process. + + Returns: + A list of pids as integers. + """ + + pids = [browser_process.pid] + try: + children = browser_process.children(recursive=True) + except psutil.NoSuchProcess: + return [] + + for child in children: + pids.append(child.pid) + + return pids + + def Profile(self, scenario_config, profile_mode): + """Cover the running of the scenario with DTrace and save the + results. + + Args: + profile_mode: A string describing the Profile mode between "wakeups" + and "cpu_time". + + Raises: + TimeoutExpired: When a DTrace process takes more than 30 seconds to + terminate after the end of the scenario. + """ + + if scenario_config["browser"] != "Chromium": + logging.error("Only Chromium can be profiled! Skipping.") + return + + script_process = self.RunScenario(scenario_config) + browser_process = self.FindBrowserProcess(scenario_config["browser"]) + + # Set up the environment for correct dtrace execution. + dtrace_env = os.environ.copy() + dtrace_env["DYLD_SHARED_REGION"] = "avoid" + + pid_to_subprocess = {} + + with open('./dtrace_log.txt', "w") as dtrace_log: + # Keep looking for child processes as long as the scenario is running. + while script_process.poll() is None: + + # Let some time pass to limit the overhead of this script. + time.sleep(0.100) + logging.info("Looking for child processes") + + # Watch for new processes and follow those too. + for pid in self.GetAllPids(browser_process): + if profile_mode == "wakeups": + probe_def = \ + f"mach_kernel::wakeup/pid == {pid}/ {{ @[ustack()] = count(); }}" + else: + probe_def = \ + f"profile-1001/pid == {pid}/ {{ @[ustack()] = count(); }}" + + dtrace_args = [ + 'sudo', 'dtrace', '-p', f"{pid}", "-o", + f"{self.__output_dir}/{pid}.txt", '-n', probe_def + ] + + if pid not in pid_to_subprocess: + logging.info(f"Found new child!:{pid}") + # No need to add |process| to |self._started_processeds| as it's + # explicitly waited on later. + process = subprocess.Popen(dtrace_args, + env=dtrace_env, + stdout=dtrace_log, + stderr=dtrace_log) + pid_to_subprocess[pid] = process + + script_process.wait() + + # Cleanup executed before waiting for the DTrace processes so that they + # see that the browse is gone. + self.Teardown() + + for pid, dtrace_process in pid_to_subprocess.items(): + logging.info(f"Waiting for dtrace hooked on {pid} to exit") + dtrace_process.wait(30) + diff --git a/chromium/tools/mac/power/driver_scripts_templates/idle.scpt b/chromium/tools/mac/power/driver_scripts_templates/idle.scpt index 2db3e905412..c0d2d15d1de 100755 --- a/chromium/tools/mac/power/driver_scripts_templates/idle.scpt +++ b/chromium/tools/mac/power/driver_scripts_templates/idle.scpt @@ -4,6 +4,6 @@ -- Use of this source code is governed by a BSD-style license that can be -- found in the LICENSE file. --- This script simply waits for |delay| seconds before quiting. +-- This script simply waits for 3600 seconds before quiting. -delay {{ delay }} +delay 3600 diff --git a/chromium/tools/mac/power/driver_scripts_templates/navigation b/chromium/tools/mac/power/driver_scripts_templates/navigation index e8b1de754da..5eb93951916 100644 --- a/chromium/tools/mac/power/driver_scripts_templates/navigation +++ b/chromium/tools/mac/power/driver_scripts_templates/navigation @@ -31,13 +31,12 @@ tell application "{{ browser }}" -- Each cycles takes about 2 mins. Aim for a test that takes an hour. repeat with i from 1 to {{ navigation_cycles }} - set sites to {"https://amazon.com", "https://www.youtube.com"} & ¬ - {"https://www.google.com", "https://github.com/chromium/chromium"} + set sites to {"https://amazon.com", "https://www.google.com"} repeat with site in sites open location site - delay {{ per_navigation_delay }} + delay {{ 10 }} tell active tab of w close diff --git a/chromium/tools/mac/power/generate_scripts.py b/chromium/tools/mac/power/generate_scripts.py index ec4fa978f48..61c54db5b6d 100755 --- a/chromium/tools/mac/power/generate_scripts.py +++ b/chromium/tools/mac/power/generate_scripts.py @@ -102,7 +102,6 @@ def render_runner_scripts(extra_args): for template_file in files: if not template_file.endswith(".scpt") and not template_file.endswith( ".swp"): - print(template_file) if template_file.startswith("safari"): # Generate for Safari render("", template_file, "", extra_args) @@ -118,11 +117,14 @@ def generate_all(extra_args): modified by hand. """ + args = {"hash_bang": "#!/usr/bin/osascript"} + args = {**args, **extra_args} + shutil.rmtree("driver_scripts/", ignore_errors=True) os.makedirs("driver_scripts", exist_ok=True) # Generate scripts for all scenarios. - render_runner_scripts(extra_args) + render_runner_scripts(args) # Copy the files that don't need any substitutions. for _, _, files in os.walk("./driver_scripts_templates"): @@ -140,7 +142,7 @@ if __name__ == "__main__": required=False) args = parser.parse_args() - extra_args = {"hash_bang": "#!/usr/bin/osascript"} + extra_args = {} if args.meet_meeting_id: extra_args["meeting_id"] = args.meet_meeting_id diff --git a/chromium/tools/mac/power/power_sampler/backlight_level_sampler.cc b/chromium/tools/mac/power/power_sampler/backlight_level_sampler.cc new file mode 100644 index 00000000000..fd614740c27 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/backlight_level_sampler.cc @@ -0,0 +1,91 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/backlight_level_sampler.h" + +#include "base/memory/ptr_util.h" +#include "third_party/abseil-cpp/absl/types/optional.h" + +extern "C" { + +// This sampler imitates the open-source "brightness" tool at +// https://github.com/nriley/brightness. +// Since this sampler doesn't care about older MacOSen, multiple displays +// or other complications that tool has to consider, retrieving the brightness +// level boils down to calling this function for the main display. +extern int DisplayServicesGetBrightness(CGDirectDisplayID id, + float* brightness); +} + +namespace power_sampler { + +namespace { +constexpr char kSamplerName[] = "BacklightLevel"; + +absl::optional<float> GetBrightnessForDisplay( + int(brightness_fn)(CGDirectDisplayID id, float* brightness), + CGDirectDisplayID display) { + float result = 0.0; + + int err = brightness_fn(display, &result); + if (err != 0) + return absl::nullopt; + + return result; +} + +} // namespace + +BacklightLevelSampler::~BacklightLevelSampler() = default; + +// static +std::unique_ptr<BacklightLevelSampler> BacklightLevelSampler::Create() { + return CreateImpl(CGMainDisplayID(), &DisplayServicesGetBrightness); +} + +std::string BacklightLevelSampler::GetName() { + return kSamplerName; +} + +Sampler::DatumNameUnits BacklightLevelSampler::GetDatumNameUnits() { + DatumNameUnits ret; + // Display brightness is in units of 0-100% of max brightness. + ret.insert(std::make_pair("display_brightness", "%")); + return ret; +} + +Sampler::Sample BacklightLevelSampler::GetSample(base::TimeTicks sample_time) { + Sampler::Sample sample; + auto brightness = GetBrightnessForDisplay(brightness_fn_, main_display_); + if (brightness.has_value()) + sample.emplace("display_brightness", brightness.value() * 100.0); + + return sample; +} + +// static +std::unique_ptr<BacklightLevelSampler> BacklightLevelSampler::CreateForTesting( + CGDirectDisplayID main_display, + DisplayServicesGetBrightnessFn brightness_fn) { + return CreateImpl(main_display, brightness_fn); +} + +// static +std::unique_ptr<BacklightLevelSampler> BacklightLevelSampler::CreateImpl( + CGDirectDisplayID main_display, + DisplayServicesGetBrightnessFn brightness_fn) { + auto brightness = GetBrightnessForDisplay(brightness_fn, main_display); + if (!brightness.has_value()) + return nullptr; + + return base::WrapUnique( + new BacklightLevelSampler(main_display, brightness_fn)); +} + +BacklightLevelSampler::BacklightLevelSampler( + CGDirectDisplayID main_display, + DisplayServicesGetBrightnessFn brightness_fn) + : main_display_(main_display), brightness_fn_(brightness_fn) {} + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/power_sampler/backlight_level_sampler.h b/chromium/tools/mac/power/power_sampler/backlight_level_sampler.h new file mode 100644 index 00000000000..97008f8c218 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/backlight_level_sampler.h @@ -0,0 +1,57 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef TOOLS_MAC_POWER_POWER_SAMPLER_BACKLIGHT_LEVEL_SAMPLER_H_ +#define TOOLS_MAC_POWER_POWER_SAMPLER_BACKLIGHT_LEVEL_SAMPLER_H_ + +#include <memory> + +#include <CoreGraphics/CoreGraphics.h> + +#include "tools/mac/power/power_sampler/sampler.h" + +namespace power_sampler { + +// Samples the backlight level of the main display, if possible. +// Note that this pretty much assumes that the computer under test has a +// single, built-in backlit display. +// Note also that this samples the set level of the backlight, which doesn't +// necessarily mean the display is lit at all. If the display sleeps, the set +// level doesn't change, so it's assumed that this is running under a power +// assertion that prevents display sleep. +class BacklightLevelSampler : public Sampler { + public: + ~BacklightLevelSampler() override; + + // Creates and initializes a new sampler, if possible. + // Returns nullptr on failure. + static std::unique_ptr<BacklightLevelSampler> Create(); + + // Sampler implementation. + std::string GetName() override; + DatumNameUnits GetDatumNameUnits() override; + Sample GetSample(base::TimeTicks sample_time) override; + + using DisplayServicesGetBrightnessFn = int (*)(CGDirectDisplayID, float*); + static std::unique_ptr<BacklightLevelSampler> CreateForTesting( + CGDirectDisplayID main_display, + DisplayServicesGetBrightnessFn brightness_fn); + + private: + static std::unique_ptr<BacklightLevelSampler> CreateImpl( + CGDirectDisplayID main_display, + DisplayServicesGetBrightnessFn brightness_fn); + + BacklightLevelSampler(CGDirectDisplayID main_display, + DisplayServicesGetBrightnessFn brightness_fn); + + CGDirectDisplayID main_display_; + + // Test seam. + const DisplayServicesGetBrightnessFn brightness_fn_; +}; + +} // namespace power_sampler + +#endif // TOOLS_MAC_POWER_POWER_SAMPLER_BACKLIGHT_LEVEL_SAMPLER_H_ diff --git a/chromium/tools/mac/power/power_sampler/backlight_level_sampler_unittest.cc b/chromium/tools/mac/power/power_sampler/backlight_level_sampler_unittest.cc new file mode 100644 index 00000000000..88fc0c75deb --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/backlight_level_sampler_unittest.cc @@ -0,0 +1,62 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/backlight_level_sampler.h" + +#include <memory> + +#include "base/time/time.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace power_sampler { +namespace { + +// Simulates a display with no brightness control. +int NoBrightness(CGDirectDisplayID id, float* brightness) { + return -1; +} + +// Simulates a display with brightness control. +int PointFiveBrightness(CGDirectDisplayID id, float* brightness) { + *brightness = 0.5; + return 0; +} + +constexpr CGDirectDisplayID kDummyDisplay = 0xFABBEE; + +} // namespace + +TEST(BacklightLevelSamplerTest, CreateFailsWhenNoBrightness) { + EXPECT_EQ(nullptr, BacklightLevelSampler::CreateForTesting(kDummyDisplay, + NoBrightness)); +} + +TEST(BacklightLevelSamplerTest, NameAndGetDatumNameUnits) { + std::unique_ptr<BacklightLevelSampler> sampler( + BacklightLevelSampler::CreateForTesting(kDummyDisplay, + PointFiveBrightness)); + ASSERT_NE(nullptr, sampler.get()); + + EXPECT_EQ("BacklightLevel", sampler->GetName()); + + auto datum_name_units = sampler->GetDatumNameUnits(); + ASSERT_EQ(1u, datum_name_units.size()); + EXPECT_EQ("%", datum_name_units["display_brightness"]); +} + +TEST(BacklightLevelSamplerTest, ReturnsASample) { + std::unique_ptr<BacklightLevelSampler> sampler( + BacklightLevelSampler::CreateForTesting(kDummyDisplay, + PointFiveBrightness)); + ASSERT_NE(nullptr, sampler.get()); + Sampler::Sample datums = sampler->GetSample(base::TimeTicks::Now()); + + EXPECT_EQ(1u, datums.size()); + auto it = datums.find("display_brightness"); + ASSERT_TRUE(it != datums.end()); + // The level should be in the range of 0.0-100.0. + EXPECT_EQ(50, it->second); +} + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/power_sampler/monitor.cc b/chromium/tools/mac/power/power_sampler/monitor.cc new file mode 100644 index 00000000000..192eaeac3f5 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/monitor.cc @@ -0,0 +1,11 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/monitor.h" + +namespace power_sampler { + +Monitor::~Monitor() = default; + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/power_sampler/monitor.h b/chromium/tools/mac/power/power_sampler/monitor.h new file mode 100644 index 00000000000..a48e467a9b4 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/monitor.h @@ -0,0 +1,65 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef TOOLS_MAC_POWER_POWER_SAMPLER_MONITOR_H_ +#define TOOLS_MAC_POWER_POWER_SAMPLER_MONITOR_H_ + +#include <memory> +#include <vector> + +#include "base/containers/flat_map.h" +#include "base/time/time.h" + +namespace power_sampler { + +// A DataColumnKey uniquely identifies data columns given to Monitor. +struct DataColumnKey { + std::string sampler_name; + std::string column_name; + + bool operator==(const DataColumnKey& other) const { + return std::make_pair(sampler_name, column_name) == + std::make_pair(other.sampler_name, other.column_name); + } + bool operator<(const DataColumnKey& other) const { + return std::make_pair(sampler_name, column_name) < + std::make_pair(other.sampler_name, other.column_name); + } +}; + +using DataRow = base::flat_map<DataColumnKey, double>; + +// Concrete monitor classes override this interface. +class Monitor { + public: + Monitor() = default; + virtual ~Monitor() = 0; + + // TODO(siggi): Add more callouts. + // - Add a callout for pre-session notification with all samplers. + // - Add a callot for post-session. + // - This will allow monitors to do the output, whether it's done as you + // go for e.g. CSV, or all-in-one for e.g. JSON. + + // Called once before any OnSample calls are made. + // Can be used to e.g. open a file, output a file header or other + // one-time setup. + virtual void OnStartSession( + const base::flat_map<DataColumnKey, std::string>& data_columns_units) = 0; + + // Called each time a new set of |samples| has been acquired. The + // |sample_time| is the time when the acquisition of |samples| started. + // |data_row| is a potentially sparse collection of named datums provided in + // OnStartSession(). Returns true if the sampling session should be ended. + virtual bool OnSample(base::TimeTicks sample_time, + const DataRow& data_row) = 0; + + // Called once after all OnSample calls have been made. + // Can be used to e.g. close files, flush output or other one-time teardown. + virtual void OnEndSession() = 0; +}; + +} // namespace power_sampler + +#endif // TOOLS_MAC_POWER_POWER_SAMPLER_MONITOR_H_ diff --git a/chromium/tools/mac/power/power_sampler/power_sampler_main.cc b/chromium/tools/mac/power/power_sampler/power_sampler_main.cc new file mode 100644 index 00000000000..80440760d20 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/power_sampler_main.cc @@ -0,0 +1,16 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/sampler.h" +#include "tools/mac/power/power_sampler/sampling_controller.h" + +int main(int argc, char** argv) { + power_sampler::SamplingController controller; + + // TODO(siggi): Parse command line, add samplers and monitors to controller. + // Fire up a message loop and use it to drive events at the controller + // until the session is complete, then exit. + + return 0; +} diff --git a/chromium/tools/mac/power/power_sampler/sampler.cc b/chromium/tools/mac/power/power_sampler/sampler.cc new file mode 100644 index 00000000000..61f21a3944d --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/sampler.cc @@ -0,0 +1,11 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/sampler.h" + +namespace power_sampler { + +Sampler::~Sampler() = default; + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/power_sampler/sampler.h b/chromium/tools/mac/power/power_sampler/sampler.h new file mode 100644 index 00000000000..50fb5fd9bb1 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/sampler.h @@ -0,0 +1,40 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef TOOLS_MAC_POWER_POWER_SAMPLER_SAMPLER_H_ +#define TOOLS_MAC_POWER_POWER_SAMPLER_SAMPLER_H_ + +#include <functional> +#include <map> +#include <string> + +#include "base/containers/flat_map.h" +#include "base/time/time.h" + +namespace power_sampler { + +// Concrete sampler classes override this interface. +class Sampler { + public: + using DatumNameUnits = base::flat_map<std::string, std::string>; + using Sample = base::flat_map<std::string, double>; + + Sampler() = default; + virtual ~Sampler() = 0; + + // Returns the name of the sampler. + virtual std::string GetName() = 0; + + // Returns the names and units of the datums provided by this sampler. + virtual DatumNameUnits GetDatumNameUnits() = 0; + + // Subclasses override to return their sample, |sample_time| is the time + // when the controller started the acquisition of this sample. + // Returns the new sample. + virtual Sample GetSample(base::TimeTicks sample_time) = 0; +}; + +} // namespace power_sampler + +#endif // TOOLS_MAC_POWER_POWER_SAMPLER_SAMPLER_H_ diff --git a/chromium/tools/mac/power/power_sampler/sampling_controller.cc b/chromium/tools/mac/power/power_sampler/sampling_controller.cc new file mode 100644 index 00000000000..0b073f41d3c --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/sampling_controller.cc @@ -0,0 +1,96 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/sampling_controller.h" + +#include <map> +#include <memory> +#include <set> +#include <string> +#include <vector> + +#include "base/check.h" +#include "base/containers/contains.h" +#include "base/strings/string_piece.h" +#include "base/time/time.h" +#include "tools/mac/power/power_sampler/monitor.h" +#include "tools/mac/power/power_sampler/sampler.h" + +namespace power_sampler { + +SamplingController::SamplingController() = default; +SamplingController::~SamplingController() { + // Stop the session before destruction for best results. + DCHECK(!started_); +} + +bool SamplingController::AddSampler(std::unique_ptr<Sampler> new_sampler) { + DCHECK(!started_); + + for (const auto& sampler : samplers_) { + if (sampler->GetName() == new_sampler->GetName()) + return false; + } + + for (const auto& name_and_unit : new_sampler->GetDatumNameUnits()) { + bool inserted = + data_columns_units_ + .emplace(DataColumnKey{new_sampler->GetName(), name_and_unit.first}, + name_and_unit.second) + .second; + DCHECK(inserted); + } + + samplers_.push_back(std::move(new_sampler)); + return true; +} + +void SamplingController::AddMonitor(std::unique_ptr<Monitor> monitor) { + DCHECK(!started_); + monitors_.push_back(std::move(monitor)); +} + +void SamplingController::StartSession() { + DCHECK(!started_); + + for (auto& monitor : monitors_) + monitor->OnStartSession(data_columns_units_); + + started_ = true; +} + +bool SamplingController::OnSamplingEvent() { + DCHECK(started_); + + DataRow data_row; + const base::TimeTicks sample_time = base::TimeTicks::Now(); + for (auto& sampler : samplers_) { + Sampler::Sample sample = sampler->GetSample(sample_time); + for (const auto& value : sample) { + DataColumnKey column_key{sampler->GetName(), value.first}; + DCHECK(base::Contains(data_columns_units_, column_key)); + data_row.emplace(column_key, value.second); + } + } + + // Notify all monitors of the new sample, and make sure we stop sampling + // after this round if any of them want out. + bool should_end_session = false; + for (auto& monitor : monitors_) + if (monitor->OnSample(sample_time, data_row)) + should_end_session = true; + + return should_end_session; +} + +void SamplingController::EndSession() { + DCHECK(started_); + + for (auto& monitor : monitors_) + monitor->OnEndSession(); + + started_ = false; +} + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/power_sampler/sampling_controller.h b/chromium/tools/mac/power/power_sampler/sampling_controller.h new file mode 100644 index 00000000000..48c57d98051 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/sampling_controller.h @@ -0,0 +1,70 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef TOOLS_MAC_POWER_POWER_SAMPLER_SAMPLING_CONTROLLER_H_ +#define TOOLS_MAC_POWER_POWER_SAMPLER_SAMPLING_CONTROLLER_H_ + +#include <functional> +#include <map> +#include <memory> +#include <string> +#include <vector> + +#include "base/containers/flat_map.h" + +namespace power_sampler { + +class Sampler; +class Monitor; +struct DataColumnKey; + +// The sampling controller takes care of colleting datums from all samplers +// on a sampling event. +class SamplingController { + public: + SamplingController(); + ~SamplingController(); + + // Adds |sampler| to this controller if it has a unique name. + // Returns true if |sampler| was added to the controller. + bool AddSampler(std::unique_ptr<Sampler> sampler); + + // Adds |monitor| to this controller. + // Each monitor is called after a sample is acquired to evaluate whether the + // sampling session should end. + void AddMonitor(std::unique_ptr<Monitor> monitor); + + // Call once after all samplers and monitors have been added. + // Will notify monitors that a session is starting. + void StartSession(); + + // Returns true iff this controller has all the samples it wants. + bool OnSamplingEvent(); + + // Call once after the last call to OnSamplingEvent. + // Will notify monitors that a session has ended. + void EndSession(); + + // TODO(siggi): We want to at least have a sampling event provider that + // ticks on IOPMPowerSource change notification, plus a simple timed + // source. + // TODO(siggi): We want to output samples in CSV at least, maybe other + // formats? Outputting samples as they're collected seems the best + // strategy? + + private: + using Samplers = std::vector<std::unique_ptr<Sampler>>; + using Monitors = std::vector<std::unique_ptr<Monitor>>; + + Samplers samplers_; + Monitors monitors_; + + base::flat_map<DataColumnKey, std::string> data_columns_units_; + + bool started_ = false; +}; + +} // namespace power_sampler + +#endif // TOOLS_MAC_POWER_POWER_SAMPLER_SAMPLING_CONTROLLER_H_ diff --git a/chromium/tools/mac/power/power_sampler/sampling_controller_unittest.cc b/chromium/tools/mac/power/power_sampler/sampling_controller_unittest.cc new file mode 100644 index 00000000000..9bb2ccc29fd --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/sampling_controller_unittest.cc @@ -0,0 +1,120 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/sampling_controller.h" + +#include "base/test/task_environment.h" +#include "base/time/time.h" +#include "testing/gmock/include/gmock/gmock.h" +#include "testing/gtest/include/gtest/gtest.h" +#include "tools/mac/power/power_sampler/monitor.h" +#include "tools/mac/power/power_sampler/sampler.h" + +namespace power_sampler { + +namespace { + +using testing::_; +using testing::DoAll; +using testing::ElementsAre; +using testing::Return; +using testing::SaveArg; +using testing::StrictMock; + +class TestSampler : public Sampler { + public: + explicit TestSampler(const char* name, double sample = 0.0) + : name_(name), sample_(sample) {} + + std::string GetName() override { return name_; } + + DatumNameUnits GetDatumNameUnits() override { + DatumNameUnits datum_name_units; + datum_name_units.insert(std::make_pair(name_, name_)); + return datum_name_units; + } + + Sample GetSample(base::TimeTicks sample_time) override { + Sample sample; + sample.emplace(name_, sample_); + return sample; + } + + private: + const std::string name_; + const double sample_; +}; + +class LenientMockMonitor : public Monitor { + public: + LenientMockMonitor() = default; + ~LenientMockMonitor() = default; + + MOCK_METHOD(void, + OnStartSession, + ((const base::flat_map<DataColumnKey, std::string>&))); + MOCK_METHOD(bool, + OnSample, + (base::TimeTicks sample_time, const DataRow& data_row)); + MOCK_METHOD(void, OnEndSession, ()); +}; +using MockMonitor = StrictMock<LenientMockMonitor>; + +} // namespace + +TEST(SamplingControllerTest, AddSampler) { + SamplingController controller; + EXPECT_TRUE(controller.AddSampler(std::make_unique<TestSampler>("foo"))); + EXPECT_TRUE(controller.AddSampler(std::make_unique<TestSampler>("bar"))); + EXPECT_FALSE(controller.AddSampler(std::make_unique<TestSampler>("bar"))); +} + +TEST(SamplingControllerTest, CallsSamplersAndMonitors) { + base::test::SingleThreadTaskEnvironment task_environment{ + base::test::TaskEnvironment::TimeSource::MOCK_TIME}; + + SamplingController controller; + EXPECT_TRUE(controller.AddSampler(std::make_unique<TestSampler>("foo", 1.0))); + EXPECT_TRUE(controller.AddSampler(std::make_unique<TestSampler>("bar", 2.0))); + + controller.StartSession(); + // No monitors to end the session. + EXPECT_FALSE(controller.OnSamplingEvent()); + controller.EndSession(); + + auto mock_monitor = std::make_unique<MockMonitor>(); + MockMonitor* monitor = mock_monitor.get(); + controller.AddMonitor(std::move(mock_monitor)); + + EXPECT_CALL(*monitor, OnStartSession(_)); + controller.StartSession(); + + base::TimeTicks first_now = base::TimeTicks::Now(); + DataRow last_seen_data_row; + EXPECT_CALL(*monitor, OnSample(first_now, _)) + .WillOnce(DoAll(SaveArg<1>(&last_seen_data_row), Return(false))); + EXPECT_FALSE(controller.OnSamplingEvent()); + + EXPECT_THAT(last_seen_data_row, + ElementsAre(std::make_pair(DataColumnKey{"bar", "bar"}, 2.0), + std::make_pair(DataColumnKey{"foo", "foo"}, 1.0))); + + last_seen_data_row.clear(); + + task_environment.FastForwardBy(base::Milliseconds(1500)); + base::TimeTicks second_now = base::TimeTicks::Now(); + // Terminate the sampling session on the next sample. + EXPECT_CALL(*monitor, OnSample(second_now, _)) + .WillOnce(DoAll(SaveArg<1>(&last_seen_data_row), Return(true))); + EXPECT_TRUE(controller.OnSamplingEvent()); + // We still expect the same samples. + EXPECT_THAT(last_seen_data_row, + ElementsAre(std::make_pair(DataColumnKey{"bar", "bar"}, 2.0), + std::make_pair(DataColumnKey{"foo", "foo"}, 1.0))); + + EXPECT_CALL(*monitor, OnEndSession()); + controller.EndSession(); +} + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/power_sampler/user_idle_level_sampler.cc b/chromium/tools/mac/power/power_sampler/user_idle_level_sampler.cc new file mode 100644 index 00000000000..8c8e4962146 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/user_idle_level_sampler.cc @@ -0,0 +1,86 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/user_idle_level_sampler.h" + +#include <sys/sysctl.h> +#include <sys/types.h> + +#include "base/logging.h" +#include "base/memory/ptr_util.h" +#include "third_party/abseil-cpp/absl/types/optional.h" + +namespace power_sampler { + +namespace { +constexpr char kSamplerName[] = "UserIdleLevel"; + +absl::optional<int> GetIntSysCtl(const std::vector<int>& mib_name) { + int value = 0; + size_t size = sizeof(value); + int ret = sysctl(const_cast<int*>(mib_name.data()), mib_name.size(), &value, + &size, nullptr, 0); + if (ret != 0) { + PLOG(ERROR) << "Error in sysctl"; + } else if (size != sizeof(value)) { + LOG(ERROR) + << "sysctl returns an unexpected size for machdep.user_idle_level"; + } else { + return value; + } + + return absl::nullopt; +} + +} // namespace + +UserIdleLevelSampler::~UserIdleLevelSampler() = default; + +// static +std::unique_ptr<UserIdleLevelSampler> UserIdleLevelSampler::Create() { + std::vector<int> mib_name(10); + + size_t size = mib_name.size(); + int ret = sysctlnametomib("machdep.user_idle_level", mib_name.data(), &size); + if (ret != 0) { + PLOG(ERROR) << "Error in sysctlnametomib"; + return nullptr; + } + + DCHECK_NE(0u, size); + mib_name.resize(size); + + if (!GetIntSysCtl(mib_name).has_value()) + return nullptr; + + return base::WrapUnique(new UserIdleLevelSampler(std::move(mib_name))); +} + +std::string UserIdleLevelSampler::GetName() { + return kSamplerName; +} + +Sampler::DatumNameUnits UserIdleLevelSampler::GetDatumNameUnits() { + DatumNameUnits ret; + ret.insert(std::make_pair("user_idle_level", "int")); + return ret; +} + +Sampler::Sample UserIdleLevelSampler::GetSample(base::TimeTicks sample_time) { + DCHECK(!mib_name_.empty()); + + Sample sample; + auto value = GetIntSysCtl(mib_name_); + if (value.has_value()) + sample.emplace("user_idle_level", value.value()); + + return sample; +} + +UserIdleLevelSampler::UserIdleLevelSampler(std::vector<int> mib_name) + : mib_name_(std::move(mib_name)) { + DCHECK(!mib_name_.empty()); +} + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/power_sampler/user_idle_level_sampler.h b/chromium/tools/mac/power/power_sampler/user_idle_level_sampler.h new file mode 100644 index 00000000000..edd9e5a3e01 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/user_idle_level_sampler.h @@ -0,0 +1,38 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef TOOLS_MAC_POWER_POWER_SAMPLER_USER_IDLE_LEVEL_SAMPLER_H_ +#define TOOLS_MAC_POWER_POWER_SAMPLER_USER_IDLE_LEVEL_SAMPLER_H_ + +#include "tools/mac/power/power_sampler/sampler.h" + +#include <memory> +#include <vector> + +namespace power_sampler { + +// Samples the machdep.user_idle_level sysctl value if it exists. +class UserIdleLevelSampler : public Sampler { + public: + ~UserIdleLevelSampler() override; + + // Creates and initializes a new sampler, if possible. + // Returns nullptr on failure. + static std::unique_ptr<UserIdleLevelSampler> Create(); + + // Sampler implementation. + std::string GetName() override; + DatumNameUnits GetDatumNameUnits() override; + Sample GetSample(base::TimeTicks sample_time) override; + + private: + explicit UserIdleLevelSampler(std::vector<int> mib_name); + + // The mib name of the machdep.user_idle_level sysctl value. + const std::vector<int> mib_name_; +}; + +} // namespace power_sampler + +#endif // TOOLS_MAC_POWER_POWER_SAMPLER_USER_IDLE_LEVEL_SAMPLER_H_ diff --git a/chromium/tools/mac/power/power_sampler/user_idle_level_sampler_unittest.cc b/chromium/tools/mac/power/power_sampler/user_idle_level_sampler_unittest.cc new file mode 100644 index 00000000000..06b94b0e1f9 --- /dev/null +++ b/chromium/tools/mac/power/power_sampler/user_idle_level_sampler_unittest.cc @@ -0,0 +1,38 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "tools/mac/power/power_sampler/user_idle_level_sampler.h" + +#include <memory> + +#include "base/time/time.h" +#include "testing/gtest/include/gtest/gtest.h" + +namespace power_sampler { + +TEST(UserIdleLevelSamplerTest, NameAndGetDatumNameUnits) { + std::unique_ptr<UserIdleLevelSampler> sampler(UserIdleLevelSampler::Create()); + EXPECT_NE(nullptr, sampler.get()); + + EXPECT_EQ("UserIdleLevel", sampler->GetName()); + + auto datum_name_units = sampler->GetDatumNameUnits(); + ASSERT_EQ(1u, datum_name_units.size()); + EXPECT_EQ("int", datum_name_units["user_idle_level"]); +} + +TEST(UserIdleLevelSamplerTest, ReturnsASample) { + std::unique_ptr<UserIdleLevelSampler> sampler(UserIdleLevelSampler::Create()); + ASSERT_NE(nullptr, sampler.get()); + + Sampler::Sample sample = sampler->GetSample(base::TimeTicks::Now()); + + EXPECT_EQ(1u, sample.size()); + auto it = sample.find("user_idle_level"); + ASSERT_TRUE(it != sample.end()); + // These are the values seen so far. + EXPECT_TRUE(it->second == 0.0 || it->second == 128.0); +} + +} // namespace power_sampler diff --git a/chromium/tools/mac/power/run_tests.py b/chromium/tools/mac/power/run_tests.py new file mode 100755 index 00000000000..8ff8505a3fb --- /dev/null +++ b/chromium/tools/mac/power/run_tests.py @@ -0,0 +1,24 @@ +#!/usr/bin/env python3 + +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import logging +import os +import sys +import unittest + +if __name__ == '__main__': + logging.basicConfig(format='%(levelname)s: %(message)s', + level=logging.WARNING) + + suite = unittest.TestSuite() + loader = unittest.TestLoader() + suite.addTests( + loader.discover(start_dir=os.path.dirname(__file__), pattern='*_test.py')) + res = unittest.TextTestRunner(verbosity=2).run(suite) + if res.wasSuccessful(): + sys.exit(0) + else: + sys.exit(1) diff --git a/chromium/tools/mac/power/test_data/empty/empty.txt b/chromium/tools/mac/power/test_data/empty/empty.txt new file mode 100644 index 00000000000..e69de29bb2d --- /dev/null +++ b/chromium/tools/mac/power/test_data/empty/empty.txt diff --git a/chromium/tools/mac/power/test_data/repeated/valid.txt b/chromium/tools/mac/power/test_data/repeated/valid.txt new file mode 100644 index 00000000000..4e7e03ebfac --- /dev/null +++ b/chromium/tools/mac/power/test_data/repeated/valid.txt @@ -0,0 +1,10 @@ + + + + + +baz +bar +foo + 12 + diff --git a/chromium/tools/mac/power/test_data/repeated/valid2.txt b/chromium/tools/mac/power/test_data/repeated/valid2.txt new file mode 100644 index 00000000000..4e7e03ebfac --- /dev/null +++ b/chromium/tools/mac/power/test_data/repeated/valid2.txt @@ -0,0 +1,10 @@ + + + + + +baz +bar +foo + 12 + diff --git a/chromium/tools/mac/power/test_data/valid/valid.txt b/chromium/tools/mac/power/test_data/valid/valid.txt new file mode 100644 index 00000000000..4e7e03ebfac --- /dev/null +++ b/chromium/tools/mac/power/test_data/valid/valid.txt @@ -0,0 +1,10 @@ + + + + + +baz +bar +foo + 12 + diff --git a/chromium/tools/mac/power/test_data/with_offset/with_offset.txt b/chromium/tools/mac/power/test_data/with_offset/with_offset.txt new file mode 100644 index 00000000000..0d4ebefc106 --- /dev/null +++ b/chromium/tools/mac/power/test_data/with_offset/with_offset.txt @@ -0,0 +1,10 @@ + + + + + +baz+0x21 +bar+0x85 +foo+0x37 + 12 + diff --git a/chromium/tools/mac/power/utils.py b/chromium/tools/mac/power/utils.py index 0033fa3d901..66109013add 100644 --- a/chromium/tools/mac/power/utils.py +++ b/chromium/tools/mac/power/utils.py @@ -3,52 +3,119 @@ # found in the LICENSE file. SCENARIOS = [{ - "name": "idle" + "name": "chromium_navigation", + "driver_script": "chromium_navigation", + "browser": "Chromium", + "extra_args": [], + "skip": False +}, { + "name": "idle", + "driver_script": "idle", + "browser": None, + "extra_args": [], + "skip": True }, { "name": "canary_idle_on_youtube_slack", - "browser": "Canary" + "driver_script": "canary_idle_on_youtube", + "browser": "Canary", + "extra_args": ["--enable-features=LudicrousTimerSlack"], + "skip": True }, { "name": "canary_idle_on_youtube_noslack", - "browser": "Canary" + "driver_script": "canary_idle_on_youtube", + "browser": "Canary", + "extra_args": [], + "skip": True }, { "name": "safari_idle_on_youtube", - "browser": "Safari" + "driver_script": "safari_idle_on_youtube", + "browser": "Safari", + "extra_args": [], + "skip": True }, { "name": "canary_idle_on_wiki_slack", - "browser": "Canary" + "driver_script": "canary_idle_on_wiki", + "browser": "Canary", + "extra_args": ["--enable-features=LudicrousTimerSlack"], + "skip": True }, { "name": "canary_idle_on_wiki_noslack", - "browser": "Canary" + "driver_script": "canary_idle_on_wiki", + "browser": "Canary", + "extra_args": [], + "skip": True }, { "name": "chrome_navigation", - "browser": "Chrome" + "driver_script": "chrome_navigation", + "browser": "Chrome", + "extra_args": [], + "skip": True }, { "name": "safari_navigation", - "browser": "Safari" + "driver_script": "safari_navigation", + "browser": "Safari", + "extra_args": [], + "skip": True }, { "name": "chrome_idle_on_wiki", - "browser": "Chrome" + "driver_script": "chrome_idle_on_wiki", + "browser": "Chrome", + "extra_args": [], + "skip": True }, { "name": "safari_idle_on_wiki", - "browser": "Safari" + "driver_script": "safari_idle_on_wiki", + "browser": "Safari", + "extra_args": [], + "skip": True }, { "name": "chrome_idle_on_wiki_hidden", - "browser": "Chrome" + "driver_script": "chrome_idle_on_wiki_hidden", + "browser": "Chrome", + "extra_args": [], + "skip": True }, { "name": "safari_idle_on_wiki_hidden", - "browser": "Safari" + "driver_script": "safari_idle_on_wiki_hidden", + "browser": "Safari", + "extra_args": [], + "skip": True }, { "name": "chrome_idle_on_youtube", - "browser": "Chrome" + "driver_script": "chrome_idle_on_youtube", + "browser": "Chrome", + "extra_args": [], + "skip": True }, { "name": "safari_idle_on_youtube", - "browser": "Safari" + "driver_script": "safari_idle_on_youtube", + "browser": "Safari", + "extra_args": [], + "skip": True }, { "name": "chrome_zero_window", - "browser": "Chrome" + "driver_script": "chrome_zero_window", + "browser": "Chrome", + "extra_args": [], + "skip": True }, { "name": "safari_zero_window", - "browser": "Safari" + "driver_script": "safari_zero_window", + "browser": "Safari", + "extra_args": [], + "skip": True +}, { + "name": "chrome_meet", + "driver_script": "chrome_meet", + "browser": "Chrome", + "extra_args": [], + "skip": True +}, { + "name": "safari_meet", + "driver_script": "safari_meet", + "browser": "Safari", + "extra_args": [], + "skip": True }] BROWSERS_DEFINITION = { @@ -78,3 +145,11 @@ BROWSERS_DEFINITION = { "identifier": "com.apple.Safari" } } + + +def get_browser_property(browser, property_name): + return BROWSERS_DEFINITION[browser][property_name] + + +def get_browser_process_names(): + return BROWSERS_DEFINITION.keys() diff --git a/chromium/tools/mb/PRESUBMIT.py b/chromium/tools/mb/PRESUBMIT.py index aa560e72c5a..c85684867fb 100644 --- a/chromium/tools/mb/PRESUBMIT.py +++ b/chromium/tools/mb/PRESUBMIT.py @@ -5,11 +5,55 @@ USE_PYTHON3 = True +_IGNORE_FREEZE_FOOTER = 'Ignore-Freeze' + +# The time module's handling of timezones is abysmal, so the boundaries are +# precomputed in UNIX time +_FREEZE_START = 1639641600 # 2021/12/16 00:00 -0800 +_FREEZE_END = 1641196800 # 2022/01/03 00:00 -0800 + + +def CheckFreeze(input_api, output_api): + if _FREEZE_START <= input_api.time.time() < _FREEZE_END: + footers = input_api.change.GitFootersFromDescription() + if _IGNORE_FREEZE_FOOTER not in footers: + + def convert(t): + ts = input_api.time.localtime(t) + return input_api.time.strftime('%Y/%m/%d %H:%M %z', ts) + + return [ + output_api.PresubmitError( + 'There is a prod freeze in effect from {} until {},' + ' files in //tools/mb cannot be modified'.format( + convert(_FREEZE_START), convert(_FREEZE_END))) + ] + + return [] + + +def CheckTests(input_api, output_api): + glob = input_api.os_path.join(input_api.PresubmitLocalPath(), '*_test.py') + tests = input_api.canned_checks.GetUnitTests(input_api, + output_api, + input_api.glob(glob), + run_on_python2=False, + run_on_python3=True, + skip_shebang_check=True) + return input_api.RunTests(tests) + + def _CommonChecks(input_api, output_api): results = [] # Run Pylint over the files in the directory. - pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api) + pylint_checks = input_api.canned_checks.GetPylint( + input_api, + output_api, + # pylint complains about Checkfreeze not being defined, its probably + # finding a different PRESUBMIT.py + files_to_skip=['PRESUBMIT_test.py'], + ) results.extend(input_api.RunTests(pylint_checks)) # Run the MB unittests. @@ -24,6 +68,9 @@ def _CommonChecks(input_api, output_api): cmd=cmd, kwargs=kwargs, message=output_api.PresubmitError)])) + results.extend(CheckFreeze(input_api, output_api)) + results.extend(CheckTests(input_api, output_api)) + return results diff --git a/chromium/tools/mb/PRESUBMIT_test.py b/chromium/tools/mb/PRESUBMIT_test.py new file mode 100755 index 00000000000..0ef25a45d10 --- /dev/null +++ b/chromium/tools/mb/PRESUBMIT_test.py @@ -0,0 +1,105 @@ +#!/usr/bin/env python3 +# Copyright (c) 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import time +import unittest + +import PRESUBMIT + + +class PresubmitError: + def __init__(self, message): + self.message = message + + def __eq__(self, other): + return isinstance(other, PresubmitError) and self.message == other.message + + def __repr__(self): + return 'PresubmitError({!r})'.format(self.message) + + +class TestCheckFreeze(unittest.TestCase): + def get_input_api(self, current_time, footers=None): + """Get an input API to use for tests. + + Args: + current_time - Current time expressed as seconds since the epoch. + """ + + class FakeTime: + + localtime = time.localtime + strftime = time.strftime + + def time(self): + return float(current_time) + + class FakeChange: + def GitFootersFromDescription(self): + return footers or [] + + class FakeInputApi: + + time = FakeTime() + change = FakeChange() + + return FakeInputApi() + + def get_output_api(self): + class FakeOutputApi: + + PresubmitError = PresubmitError + + return FakeOutputApi + + def test_before_freeze(self): + input_api = self.get_input_api(1639641599) # 2021/12/15 23:59:59 -0800 + output_api = self.get_output_api() + + errors = PRESUBMIT.CheckFreeze(input_api, output_api) + + self.assertEqual(errors, []) + + def test_start_of_freeze(self): + input_api = self.get_input_api(1639641600) # 2021/12/16 00:00:00 -0800 + output_api = self.get_output_api() + + errors = PRESUBMIT.CheckFreeze(input_api, output_api) + + self.assertEqual(len(errors), 1) + self.assertTrue( + errors[0].message.startswith('There is a prod freeze in effect')) + + def test_end_of_freeze(self): + input_api = self.get_input_api(1641196799) # 2022/01/02 23:59:59 -0800 + output_api = self.get_output_api() + + errors = PRESUBMIT.CheckFreeze(input_api, output_api) + + self.assertEqual(len(errors), 1) + self.assertTrue( + errors[0].message.startswith('There is a prod freeze in effect')) + + def test_after_freeze(self): + input_api = self.get_input_api(1641196800) # 2022/01/03 00:00:00 -0800') + output_api = self.get_output_api() + + errors = PRESUBMIT.CheckFreeze(input_api, output_api) + + self.assertEqual(errors, []) + + def test_ignore_freeze(self): + input_api = self.get_input_api( + 1639641600, # 2021/12/16 00:00:00 -0800 + footers={'Ignore-Freeze': 'testing'}) + output_api = self.get_output_api() + + errors = PRESUBMIT.CheckFreeze(input_api, output_api) + + self.assertEqual(errors, []) + + +if __name__ == '__main__': + unittest.main() diff --git a/chromium/tools/mb/mb.py b/chromium/tools/mb/mb.py index c5231b8927d..81b367d9163 100755 --- a/chromium/tools/mb/mb.py +++ b/chromium/tools/mb/mb.py @@ -1532,8 +1532,6 @@ class MetaBuildWrapper(object): self.WriteJSON( { 'args': [ - '--isolated', - self.ToSrcRelPath('%s/%s.isolated' % (build_dir, target)), '--isolate', self.ToSrcRelPath('%s/%s.isolate' % (build_dir, target)), ], @@ -1711,7 +1709,7 @@ class MetaBuildWrapper(object): cmdline += [ os.path.join('bin', 'run_%s' % target), '--test-launcher-bot-mode', - '--system-log-file', '${ISOLATED_OUTDIR}/system_log' + '--logs-dir=${ISOLATED_OUTDIR}', ] elif is_cros_device and test_type != 'script': cmdline += [ diff --git a/chromium/tools/mb/mb_config.pyl b/chromium/tools/mb/mb_config.pyl index 7036641a849..cfea261abab 100644 --- a/chromium/tools/mb/mb_config.pyl +++ b/chromium/tools/mb/mb_config.pyl @@ -15,11 +15,14 @@ 'builder_groups': { 'chrome': { 'chromeos-arm-generic-cfi-thin-lto-chrome': 'chromeos_arm-generic_cfi_thin_lto_official', + 'chromeos-betty-arc-r-chrome': 'chromeos_betty-arc-r_include_unwind_tables_official_use_fake_dbus_clients', 'chromeos-betty-pi-arc-cfi-thin-lto-chrome': 'chromeos_betty-pi-arc_cfi_thin_lto_official', 'chromeos-betty-pi-arc-chrome': 'chromeos_betty-pi-arc_include_unwind_tables_official_use_fake_dbus_clients', + 'chromeos-eve-arc-r-chrome': 'chromeos_eve-arc-r_include_unwind_tables_official', 'chromeos-eve-chrome': 'chromeos_eve_include_unwind_tables_official', 'chromeos-kevin-chrome': 'chromeos_kevin_include_unwind_tables_official', 'lacros-amd64-generic-chrome': 'chromeos_amd64-generic_lacros_official', + 'lacros-amd64-generic-chrome-skylab': 'chromeos_amd64-generic_lacros_official_skylab', 'lacros-arm-generic-chrome': 'chromeos_arm-generic_lacros_official', # Don't include unwind tables for linux-/mac-/win-/win64-chrome builders. # They monitor binary size growth, which may be affected by the tables. @@ -48,17 +51,22 @@ 'fuchsia-official': 'fuchsia_official_optimize_goma', 'linux-archive-rel': 'release_bot', 'linux-archive-dbg': 'debug_bot', + 'linux-archive-tagged': 'official_optimize_goma', 'linux-official': 'official_optimize_goma', 'mac-archive-rel': 'release_bot_mac_strip_minimal_symbols', 'mac-archive-dbg': 'debug_bot', + 'mac-archive-tagged': 'official_optimize_goma', 'mac-arm64-archive-rel': 'release_bot_mac_strip_minimal_symbols_arm64', 'mac-arm64-archive-dbg': 'debug_bot_arm64', + 'mac-arm64-archive-tagged': 'arm64_official_optimize_goma', 'mac-official': 'official_optimize_goma', 'win32-official': 'x86_official_optimize_goma', 'win32-archive-rel': 'release_bot_x86_minimal_symbols_enable_archive_compression', 'win32-archive-dbg': 'debug_bot_x86', + 'win32-archive-tagged': 'x86_official_optimize_goma', 'win-archive-rel': 'release_bot_minimal_symbols_enable_archive_compression', 'win-archive-dbg': 'debug_bot', + 'win-archive-tagged': 'official_optimize_goma', 'win-official': 'official_optimize_goma', }, @@ -84,7 +92,6 @@ 'android-cronet-x86-dbg': 'android_cronet_debug_static_bot_x86', 'android-cronet-x86-rel': 'android_cronet_release_bot_minimal_symbols_x86', 'android-incremental-dbg': 'android_incremental_debug_bot', - 'android-lollipop-arm-rel': 'android_release_bot_minimal_symbols_webview_google', # This bot must use the gpu_tests mixin to match 'Android FYI Release (Nexus 5X)' # on the chromium.gpu waterfall, which it mirrors via trybots.pyl. @@ -115,21 +122,21 @@ 'android-weblayer-pie-x86-wpt-smoketest': 'android_release_bot_minimal_symbols_x86_fastbuild_webview_google', 'android-webview-pie-x86-wpt-fyi-rel': 'android_release_bot_minimal_symbols_x86_fastbuild_webview_chrome_webview_shell', 'android-weblayer-with-aosp-webview-x86-fyi-rel': 'android_release_bot_minimal_symbols_x86_fastbuild_resource_allowlisting_disable_proguard_chrome_google', + 'android-x86-fyi-rel': 'android_release_bot_minimal_symbols_x86_fastbuild_webview_chrome_webview_shell', }, 'chromium.angle': { - 'android-angle-arm64-builder': 'angle_specific_no_trace_android_release_trybot_arm64', - 'android-angle-chromium-arm64-builder': 'gpu_tests_android_release_trybot_arm64_fastbuild', - 'fuchsia-angle-builder': 'angle_specific_release_trybot_fuchsia', - 'ios-angle-builder': 'angle_specific_release_trybot_ios', - 'linux-angle-builder': 'angle_specific_release_trybot', - 'linux-angle-chromium-builder': 'gpu_tests_release_trybot', - 'mac-angle-builder': 'angle_specific_release_trybot', - 'mac-angle-chromium-builder': 'gpu_tests_release_trybot', - 'win-angle-chromium-x64-builder': 'gpu_tests_release_trybot', - 'win-angle-chromium-x86-builder': 'gpu_tests_release_trybot_x86', - 'win-angle-x64-builder': 'angle_specific_release_trybot', - 'win-angle-x86-builder': 'angle_specific_release_trybot_x86', + 'android-angle-arm64-builder': 'angle_specific_no_trace_android_release_trybot_dcheck_always_on_arm64', + 'android-angle-chromium-arm64-builder': 'gpu_tests_android_release_bot_dcheck_always_on_arm64_fastbuild', + 'fuchsia-angle-builder': 'angle_specific_release_bot_dcheck_always_on_fuchsia', + 'ios-angle-builder': 'angle_specific_release_bot_dcheck_always_on_ios', + 'linux-angle-builder': 'angle_specific_release_bot_dcheck_always_on', + 'linux-angle-chromium-builder': 'gpu_tests_release_trybot_minimal_symbols', + 'mac-angle-chromium-builder': 'gpu_tests_release_trybot_minimal_symbols', + 'win-angle-chromium-x64-builder': 'gpu_tests_release_trybot_minimal_symbols', + 'win-angle-chromium-x86-builder': 'gpu_tests_release_bot_dcheck_always_on_x86', + 'win-angle-x64-builder': 'angle_specific_release_bot_dcheck_always_on', + 'win-angle-x86-builder': 'angle_specific_release_bot_dcheck_always_on_x86', }, 'chromium.chromiumos': { @@ -139,7 +146,7 @@ 'chromeos-amd64-generic-cfi-thin-lto-rel': 'chromeos_amd64-generic_cfi_thin_lto', 'chromeos-amd64-generic-dbg': 'chromeos_amd64-generic_dbg', 'chromeos-amd64-generic-lacros-dbg': 'chromeos_amd64-generic_lacros_dbg', - 'chromeos-amd64-generic-rel': 'chromeos_amd64-generic_use_fake_dbus_clients', + 'chromeos-amd64-generic-rel': 'chromeos_amd64-generic_use_fake_dbus_clients_vm_optimized', 'chromeos-arm-generic-dbg': 'chromeos_arm-generic_dbg', 'chromeos-arm-generic-rel': 'chromeos_arm-generic', 'chromeos-kevin-rel': 'chromeos_kevin', @@ -147,7 +154,7 @@ 'lacros-amd64-generic-rel': 'chromeos_amd64-generic_lacros_rel', 'lacros-arm-generic-rel': 'chromeos_arm-generic_lacros_rel', 'linux-ash-chromium-generator-rel': 'chromeos_with_codecs_release_bot', - 'linux-chromeos-rel': 'chromeos_with_codecs_release_bot', + 'linux-chromeos-rel': 'chromeos_with_codecs_with_lacros_release_bot', 'linux-chromeos-dbg': 'chromeos_with_codecs_debug_bot', 'linux-lacros-builder-rel': 'lacros_on_linux_release_bot', 'linux-lacros-dbg': 'lacros_on_linux_debug_bot', @@ -209,15 +216,15 @@ 'Dawn Linux x64 Builder': 'dawn_tests_with_desktop_gl_release_trybot', 'Dawn Linux x64 DEPS Builder': 'dawn_tests_with_desktop_gl_release_trybot', - 'Dawn Mac x64 Builder': 'dawn_tests_release_trybot', - 'Dawn Mac x64 DEPS Builder': 'dawn_tests_release_trybot', + 'Dawn Mac x64 Builder': 'dawn_tests_release_bot_dcheck_always_on', + 'Dawn Mac x64 DEPS Builder': 'dawn_tests_release_bot_dcheck_always_on', - 'Dawn Win10 x86 Builder': 'dawn_tests_release_trybot_x86', - 'Dawn Win10 x64 Builder': 'dawn_tests_release_trybot', - 'Dawn Win10 x86 DEPS Builder': 'dawn_tests_release_trybot_x86', - 'Dawn Win10 x64 DEPS Builder': 'dawn_tests_release_trybot', + 'Dawn Win10 x86 Builder': 'dawn_tests_release_bot_dcheck_always_on_x86', + 'Dawn Win10 x64 Builder': 'dawn_tests_release_bot_dcheck_always_on', + 'Dawn Win10 x86 DEPS Builder': 'dawn_tests_release_bot_dcheck_always_on_x86', + 'Dawn Win10 x64 DEPS Builder': 'dawn_tests_release_bot_dcheck_always_on', - 'Dawn Win10 x64 ASAN Release': 'dawn_tests_asan_release_trybot', + 'Dawn Win10 x64 ASAN Release': 'dawn_tests_asan_release_bot_dcheck_always_on', }, 'chromium.devtools-frontend': { @@ -261,6 +268,8 @@ 'chromium.fyi': { 'Afl Upload Linux ASan': 'afl_asan_shared_release_bot', 'ASAN Debug (reclient)': 'asan_lsan_debug_bot_reclient', + 'ASAN Release Media (reclient_shadow)': 'asan_lsan_fuzzer_v8_heap_chromeos_codecs_release_bot_reclient', + 'ASAN Release (reclient shadow)': 'asan_lsan_fuzzer_v8_heap_release_bot_reclient', 'Comparison Linux': { 'goma': 'gpu_tests_release_bot', 'reclient': 'gpu_tests_release_bot_reclient', @@ -273,47 +282,42 @@ 'Libfuzzer Upload Linux UBSan': 'libfuzzer_ubsan_release_bot', 'Libfuzzer Upload Mac ASan': 'libfuzzer_mac_asan_shared_release_bot', 'Libfuzzer Upload Windows ASan': 'libfuzzer_windows_asan_release_bot', - 'Linux Builder (core-32) (goma)': 'gpu_tests_release_bot', - 'Linux Builder (core-32) (reclient)': 'gpu_tests_release_bot_reclient', - 'Linux Builder (core-32) (runsc) (reclient)': 'gpu_tests_release_bot_reclient', 'Linux Builder (deps-cache) (reclient)': 'gpu_tests_release_bot_reclient', 'Linux Builder (j-500) (g-ip) (reclient)': 'gpu_tests_release_bot_reclient', 'Linux Builder (j-500) (reclient)': 'gpu_tests_release_bot_reclient', 'Linux Builder (j-500) (n2) (reclient)': 'gpu_tests_release_bot_reclient', 'Linux TSan Builder (goma cache silo)': 'tsan_disable_nacl_release_bot', 'Linux TSan Builder (reclient)': 'tsan_disable_nacl_release_bot_reclient', - 'Linux Viz': 'release_trybot', + 'Linux Viz': 'release_trybot_minimal_symbols', 'lacros-amd64-generic-rel-fyi': 'chromeos_amd64-generic_lacros_rel', 'linux-ash-chromium-builder-fyi-rel': 'chromeos_with_codecs_release_bot', 'linux-lacros-builder-fyi-rel': 'lacros_on_linux_release_bot', 'linux-lacros-dbg-fyi': 'lacros_on_linux_debug_bot', 'linux-lacros-dbg-tests-fyi': 'lacros_on_linux_debug_bot', 'linux-lacros-tester-fyi-rel': 'lacros_on_linux_release_bot', + # TODO(crbug.com/1244441): remove this after the migration. + 'Mac Builder (reclient)': 'gpu_tests_release_bot_minimal_symbols_reclient', 'Mac Builder Next': 'gpu_tests_release_bot_minimal_symbols', 'Mac deterministic': 'release_bot_mac_strip_minimal_symbols', 'Mac deterministic (dbg)': 'debug_bot', - + 'MSAN Release (chained origins) (reclient shadow)': 'msan_release_bot_reclient', + 'MSAN Release (no origins) (reclient shadow)': 'msan_no_origins_release_bot_reclient', 'Site Isolation Android': 'android_release_bot_minimal_symbols_arm64', 'TSAN Debug (reclient)': 'tsan_disable_nacl_debug_bot_reclient', - 'TSAN Release (core-32) (goma)': 'tsan_disable_nacl_release_bot', - 'TSAN Release (core-32) (reclient)': 'tsan_disable_nacl_release_bot_reclient', 'TSAN Release (deps-cache) (reclient)': 'tsan_disable_nacl_release_bot_reclient', 'TSAN Release (j-250) (reclient)': 'tsan_disable_nacl_release_bot_reclient', 'TSAN Release (g-ip) (reclient)': 'tsan_disable_nacl_release_bot_reclient', 'TSAN Release (reclient)': 'tsan_disable_nacl_release_bot_reclient', - 'TSAN Release (runsc-exp) (reclient)': 'tsan_disable_nacl_release_bot_reclient', 'UBSan Release (reclient)': 'ubsan_release_bot_reclient', 'VR Linux': 'vr_release_bot', 'VR Linux (reclient)': 'vr_release_bot_reclient', - 'Win 10 Fast Ring': 'release_trybot', + 'Win 10 Fast Ring': 'release_trybot_minimal_symbols', 'Win x64 Builder (reclient)': 'gpu_tests_release_bot_minimal_symbols_reclient', 'Win x64 Builder (reclient)(cross)': 'gpu_tests_release_bot_minimal_symbols_reclient_win_cross', 'android-code-coverage': 'gpu_tests_android_release_bot_minimal_symbols_arm64_fastbuild_java_coverage', 'android-code-coverage-native': 'gpu_tests_android_release_bot_no_symbols_arm64_fastbuild_native_coverage', 'android-backuprefptr-arm-fyi-rel': 'release_trybot_backuprefptr_arm', 'android-backuprefptr-arm64-fyi-rel': 'release_trybot_backuprefptr_arm64', - 'arm-upload-perfetto': 'release_bot_arm_chromeos', - 'arm64-upload-perfetto': 'release_bot_arm64_chromeos', 'chromeos-amd64-generic-rel-dchecks': 'chromeos_amd64-generic_use_fake_dbus_clients_dchecks', 'chromeos-amd64-generic-rel (reclient)': 'chromeos_amd64-generic_use_fake_dbus_clients_reclient', # TODO(crbug.com/1235218): remove after the migration. @@ -326,11 +330,12 @@ 'fuchsia-fyi-x64-dbg': 'debug_bot_fuchsia', 'fuchsia-fyi-x64-rel': 'release_bot_fuchsia', 'ios14-beta-simulator': 'ios_simulator_debug_static_bot_xctest', - 'ios14-sdk-simulator': 'ios_simulator_debug_static_bot_xctest', + 'ios14-sdk-simulator': 'ios_simulator_debug_static_bot_xctest_arm64', 'ios15-beta-simulator': 'ios_simulator_debug_static_bot_xctest', 'ios15-sdk-device': 'ios_device_release_static_bot_xctest', 'ios15-sdk-simulator': 'ios_simulator_debug_static_bot_xctest', 'ios-asan': 'ios_simulator_release_static_asan_bot_xctest', + 'ios-reclient': 'ios_simulator_debug_static_bot_xctest_reclient', 'ios-simulator-code-coverage': 'clang_code_coverage_ios_xctest', 'ios-simulator-cr-recipe': 'ios_simulator_debug_static_bot_xctest', 'ios-simulator-cronet': 'ios_cronet_xctest', @@ -340,7 +345,7 @@ 'lacros-amd64-generic-rel (reclient)': 'chromeos_amd64-generic_lacros_rel_reclient', 'linux-annotator-rel': 'release_bot', 'linux-blink-animation-use-time-delta': 'debug_bot_enable_blink_animation_use_time_delta', - 'linux-blink-heap-concurrent-marking-tsan-rel': 'release_trybot_tsan', + 'linux-blink-heap-concurrent-marking-tsan-rel': 'release_trybot_minimal_symbols_tsan', 'linux-blink-heap-verification': 'release_bot_enable_blink_heap_verification_dcheck_always_on', 'linux-blink-v8-oilpan': 'release_bot_enable_v8_oilpan_dcheck_always_on', 'linux-chromeos-code-coverage': 'chromeos_with_codecs_release_bot_coverage', @@ -350,6 +355,7 @@ 'linux-exp-code-coverage': 'clang_code_coverage', 'linux-example-builder': 'release_bot', 'linux-fieldtrial-rel': 'release_bot_minimal_symbols', + 'linux-headless-shell-rel': 'headless_shell_release_bot', 'linux-backuprefptr-x64-fyi-rel': 'release_trybot_backuprefptr_x64', 'linux-lacros-builder-rel (goma cache silo)': 'lacros_on_linux_release_bot', 'linux-lacros-builder-rel (reclient)': 'lacros_on_linux_release_bot_reclient', @@ -361,6 +367,8 @@ 'linux-wpt-identity-fyi-rel': 'release_bot_minimal_symbols', 'linux-wpt-input-fyi-rel': 'release_bot_minimal_symbols', 'mac-arm64-on-arm64-rel': 'mac_arm64_release_bot', + # TODO(crbug.com/1252626): remove this after the migration. + 'mac-arm64-on-arm64-rel-reclient': 'mac_arm64_release_bot_reclient', 'mac-code-coverage': 'clang_code_coverage', 'mac-hermetic-upgrade-rel': 'release_bot', 'mac-paeverywhere-x64-fyi-dbg': 'debug_bot_paeverywhere_x64', @@ -446,14 +454,14 @@ 'chromium.gpu': { # These all use the 'trybot' mixins to ensure that dcheck is on. - 'GPU Mac Builder': 'gpu_tests_release_trybot', + 'GPU Mac Builder': 'gpu_tests_release_trybot_minimal_symbols', 'GPU Mac Builder (dbg)': 'gpu_tests_debug_bot', - 'GPU Linux Builder': 'gpu_tests_release_trybot', + 'GPU Linux Builder': 'gpu_tests_release_trybot_minimal_symbols', 'GPU Linux Builder (dbg)': 'gpu_tests_debug_bot', - 'GPU Win x64 Builder': 'gpu_tests_release_trybot_resource_allowlisting', + 'GPU Win x64 Builder': 'gpu_tests_release_bot_dcheck_always_on_resource_allowlisting', 'GPU Win x64 Builder Code Coverage': 'gpu_tests_release_trybot_resource_allowlisting_code_coverage', 'GPU Win x64 Builder (dbg)': 'gpu_tests_debug_bot', - 'Android Release (Nexus 5X)': 'gpu_tests_android_release_trybot_arm64_fastbuild', + 'Android Release (Nexus 5X)': 'gpu_tests_android_release_bot_dcheck_always_on_arm64_fastbuild', }, 'chromium.gpu.fyi': { @@ -476,7 +484,9 @@ 'GPU FYI Linux Builder (dbg)': 'gpu_fyi_tests_debug_trybot', 'GPU FYI Linux dEQP Builder': 'angle_deqp_release_trybot', 'GPU FYI Mac Builder': 'gpu_fyi_tests_release_trybot', + 'GPU FYI Mac Builder (asan)': 'gpu_fyi_tests_release_trybot_asan', 'GPU FYI Mac Builder (dbg)': 'gpu_fyi_tests_debug_trybot', + 'GPU FYI Mac arm64 Builder': 'gpu_fyi_tests_release_trybot_arm64', 'GPU FYI Win Builder': 'gpu_fyi_tests_release_trybot_x86', 'GPU FYI Win x64 Builder': 'gpu_fyi_tests_release_trybot', 'GPU FYI Win x64 Builder (dbg)': 'gpu_fyi_tests_debug_trybot', @@ -485,8 +495,6 @@ 'GPU FYI XR Win x64 Builder': 'gpu_fyi_tests_release_trybot', 'Linux FYI GPU TSAN Release': 'gpu_fyi_tests_release_trybot_tsan', 'Linux FYI SkiaRenderer Dawn Release (Intel HD 630)': 'gpu_tests_sk_dawn_release_trybot', - 'Mac FYI arm64 Release (Apple DTK)': 'gpu_fyi_tests_release_trybot_arm64', - 'Mac FYI GPU ASAN Release': 'gpu_fyi_tests_release_trybot_asan', 'Optional Android Release (Nexus 5X)': 'gpu_tests_android_release_trybot_arm64', 'Optional Android Release (Pixel 4)': 'gpu_tests_android_release_trybot', 'Win10 FYI x64 SkiaRenderer Dawn Release (NVIDIA)': 'gpu_tests_sk_dawn_release_trybot', @@ -505,6 +513,7 @@ 'Cast Audio Linux': 'cast_audio_release_bot', 'Cast Linux': 'cast_release_bot', 'Cast Linux Debug': 'cast_debug_bot', + 'Cast Linux ARM64': 'cast_arm64_release_bot', 'Deterministic Fuchsia (dbg)': 'debug_bot_fuchsia', 'Deterministic Linux (dbg)': { 'local': 'debug_bot_local_build', @@ -517,6 +526,7 @@ 'Linux Builder (dbg)': 'gpu_tests_debug_bot', 'Linux Builder (dbg)(32)': 'gpu_tests_debug_bot_x86', 'Linux Builder': 'gpu_tests_release_bot', + 'Linux Builder (Wayland)': 'gpu_tests_wayland_release_bot', 'Network Service Linux': 'release_bot', 'fuchsia-arm64-cast': 'release_bot_fuchsia_arm64_cast', 'fuchsia-x64-cast': 'release_bot_fuchsia_cast', @@ -543,7 +553,7 @@ 'chromium.memory': { 'Linux ASan LSan Builder': 'asan_lsan_release_trybot', 'Linux CFI': 'cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on_goma', - 'Linux Chromium OS ASan LSan Builder': 'asan_lsan_chromeos_release_trybot', + 'Linux Chromium OS ASan LSan Builder': 'asan_lsan_chromeos_release_bot_dcheck_always_on', 'Linux ChromiumOS MSan Builder': 'chromeos_msan_release_bot', 'Linux MSan Builder': 'msan_release_bot', 'Linux TSan Builder': 'tsan_disable_nacl_release_bot', @@ -559,9 +569,9 @@ 'chromium.mojo': { 'Mojo Android': 'android_release_bot_minimal_symbols_arm64', 'Mojo ChromiumOS': 'chromeos_with_codecs_release_trybot', - 'Mojo Linux': 'release_trybot', + 'Mojo Linux': 'release_trybot_minimal_symbols', 'Mojo Windows': 'release_bot_x86_minimal_symbols', - 'mac-mojo-rel': 'release_trybot', + 'mac-mojo-rel': 'release_trybot_minimal_symbols', }, 'chromium.perf': { @@ -580,8 +590,8 @@ }, 'chromium.perf.calibration': { - 'linux-perf-calibration': 'official_goma_linux_perf', - 'android-pixel2-perf-calibration': 'official_goma_minimal_symbols_android_arm64', + 'linux-perf-calibration': 'official_goma_linux_perf_py3', + 'android-pixel2-perf-calibration': 'official_goma_minimal_symbols_android_arm64_py3', }, 'chromium.perf.fyi': { @@ -592,23 +602,28 @@ }, 'chromium.reclient.fyi': { - 'Linux Builder Re-Client Staging': 'gpu_tests_release_bot_reclient', - 'Linux Builder Re-Client Test': 'gpu_tests_release_bot_reclient', + 'Linux Builder reclient staging': 'gpu_tests_release_bot_reclient', + 'Linux Builder reclient test': 'gpu_tests_release_bot_reclient', + }, + + 'chromium.rust': { + 'linux-rust-x64-rel': 'release_rust_linux_x64', + 'android-rust-arm-rel': 'release_rust_android_arm', }, 'chromium.swangle': { - 'linux-swangle-chromium-x64': 'gpu_tests_release_trybot', + 'linux-swangle-chromium-x64': 'gpu_tests_release_trybot_minimal_symbols', 'linux-swangle-tot-angle-x64': 'angle_deqp_release_trybot', 'linux-swangle-tot-swiftshader-x64': 'angle_deqp_release_trybot', 'linux-swangle-x64': 'angle_deqp_release_trybot', - 'mac-swangle-chromium-x64': 'gpu_tests_release_trybot', - 'win-swangle-chromium-x86': 'gpu_tests_release_trybot_x86_resource_allowlisting', + 'mac-swangle-chromium-x64': 'gpu_tests_release_trybot_minimal_symbols', + 'win-swangle-chromium-x86': 'gpu_tests_release_trybot_minimal_symbol_x86_resource_allowlisting', 'win-swangle-tot-angle-x64': 'angle_deqp_release_trybot', - 'win-swangle-tot-angle-x86': 'angle_deqp_release_trybot_x86', + 'win-swangle-tot-angle-x86': 'angle_deqp_release_bot_dcheck_always_on_x86', 'win-swangle-tot-swiftshader-x64': 'angle_deqp_release_trybot', - 'win-swangle-tot-swiftshader-x86': 'angle_deqp_release_trybot_x86', + 'win-swangle-tot-swiftshader-x86': 'angle_deqp_release_bot_dcheck_always_on_x86', 'win-swangle-x64': 'angle_deqp_release_trybot', - 'win-swangle-x86': 'angle_deqp_release_trybot_x86', + 'win-swangle-x86': 'angle_deqp_release_bot_dcheck_always_on_x86', }, 'chromium.dev': { @@ -660,9 +675,9 @@ 'Android V8 FYI Release (Nexus 5X)': 'gpu_tests_android_release_trybot_arm64', 'Linux ASAN Builder': 'asan_lsan_release_trybot', 'Linux Debug Builder': 'debug_bot_blink', - 'Linux V8 FYI Release (NVIDIA)': 'gpu_tests_release_trybot', + 'Linux V8 FYI Release (NVIDIA)': 'gpu_tests_release_trybot_minimal_symbols', 'Linux V8 FYI Release - pointer compression (NVIDIA)': 'gpu_tests_release_trybot_ptr_comp', - 'Mac V8 FYI Release (Intel)': 'gpu_tests_release_trybot', + 'Mac V8 FYI Release (Intel)': 'gpu_tests_release_trybot_minimal_symbols', 'V8 Android GN (dbg)': 'android_debug_bot', 'V8 Blink Linux': 'release_bot_blink', 'V8 Blink Linux Debug': 'release_bot_blink_v8_debug', @@ -670,7 +685,7 @@ 'V8 Blink Mac': 'release_bot_blink', 'V8 Blink Win': 'release_bot_blink', 'V8 Linux GN': 'release_bot', - 'Win V8 FYI Release (NVIDIA)': 'gpu_tests_release_trybot_x86_resource_allowlisting', + 'Win V8 FYI Release (NVIDIA)': 'gpu_tests_release_trybot_minimal_symbol_x86_resource_allowlisting', }, 'chromium.updater': { @@ -722,29 +737,23 @@ 'infra': { 'linux-bootstrap': 'release_bot', - 'linux-control-rel': 'release_bot', - 'linux-component-rel': 'shared_release_bot', - 'linux-local-ssd-nvme-rel': 'release_bot', - 'linux-local-ssd-scsi-rel': 'release_bot', - 'linux-pd-ssd-rel': 'release_bot', + 'win-bootstrap': 'release_bot', }, 'internal.chrome.fyi': { 'chromeos-amd64-generic-lacros-internal-rel': 'chromeos_amd64-generic_lacros_rel', 'linux-autofill-captured-sites-rel': 'release_bot', - 'linux-chrome-finch-fyi': 'official_goma', 'linux-password-manager-captured-sites-rel': 'release_bot', 'lorenz-graph-dbg': 'android_debug_static_external_bot', 'mac-autofill-captured-sites-rel': 'release_bot', 'win-autofill-captured-sites-rel': 'release_bot', 'win-celab-rel': 'official_celab_release_bot', + 'win-chrome-finch-fyi': 'official_goma', 'win-password-manager-captured-sites-rel': 'release_bot', }, 'internal.chromeos.fyi': { - 'chromeos-betty-arc-r-chrome': 'chromeos_betty-arc-r_include_unwind_tables_official_use_fake_dbus_clients', 'chromeos-betty-pi-arc-chrome-dchecks': 'chromeos_betty-pi-arc_dchecks', - 'chromeos-eve-arc-r-chrome': 'chromeos_eve-arc-r_include_unwind_tables_official', 'lacros-amd64-generic-chrome-fyi': 'chromeos_amd64-generic_lacros_official_skylab', 'lacros-arm-generic-chrome-fyi': 'chromeos_arm-generic_lacros_official_skylab', }, @@ -778,8 +787,8 @@ 'mac10.14-blink-rel': 'release_bot_blink_minimal_symbols', 'mac10.15-blink-rel': 'release_bot_blink_minimal_symbols_no_nacl', 'mac11.0-blink-rel': 'release_bot_blink_minimal_symbols', + 'mac11.0.arm64-blink-rel': 'release_bot_blink_arm64_minimal_symbols', 'win7-blink-rel': 'release_bot_blink_x86_minimal_symbols', - 'win10-blink-rel': 'release_bot_blink_x86_minimal_symbols', 'win10.20h2-blink-rel': 'release_bot_blink_x86_minimal_symbols', }, @@ -801,9 +810,10 @@ 'android-cronet-arm-dbg': 'android_cronet_debug_static_bot_arm_no_neon', 'android-cronet-marshmallow-arm64-rel': 'android_cronet_release_trybot_arm64', 'android-inverse-fieldtrials-pie-x86-fyi-rel': 'android_release_trybot_x86_fastbuild_webview_google_invert_fieldtrials', - 'android-lollipop-arm-rel': 'android_release_trybot_webview_google', 'android-marshmallow-arm64-rel': 'gpu_tests_android_release_trybot_arm64_resource_allowlisting_fastbuild_java_coverage', - 'android-marshmallow-x86-rel': 'android_release_trybot_x86_fastbuild_resource_allowlisting_webview_google', + 'android-marshmallow-arm64-rel-rts': 'gpu_tests_android_release_trybot_arm64_resource_allowlisting_fastbuild_java_coverage', + 'android-marshmallow-x86-rel': 'android_release_trybot_x86_fastbuild_resource_allowlisting_webview_google_coverage', + 'android-marshmallow-x86-rel-orchestrator': 'android_release_trybot_x86_fastbuild_resource_allowlisting_webview_google_coverage', 'android-marshmallow-x86-rel-non-cq': 'android_release_trybot_x86_fastbuild_resource_allowlisting_webview_google', 'android-marshmallow-x86-rel-rts': 'android_release_trybot_x86_fastbuild_resource_allowlisting_webview_google', 'android-nougat-arm64-rel': 'android_release_trybot_arm64_fastbuild_webview_google', @@ -813,6 +823,7 @@ 'android-pie-arm64-coverage-rel': 'android_release_trybot_arm64_webview_google_native_coverage', 'android-pie-arm64-coverage-experimental-rel': 'android_release_trybot_arm64_webview_google_expectations_native_coverage', 'android-pie-arm64-rel': 'android_release_trybot_arm64_webview_google_expectations_fastbuild', + 'android-pie-arm64-rel-rts': 'android_release_trybot_arm64_webview_google_expectations_fastbuild', 'android-pie-arm64-wpt-rel-non-cq': 'android_release_trybot_arm64_webview_google', 'android-pie-x86-rel': 'android_release_trybot_x86_fastbuild_webview_google', 'android-web-platform-pie-x86-fyi-rel': 'android_release_trybot_x86_fastbuild_webview_google', @@ -872,7 +883,6 @@ 'android-angle-try': 'angle_specific_no_trace_android_release_trybot_arm64', 'android_angle_rel_ng': 'gpu_tests_android_release_trybot_arm64', 'android_angle_deqp_rel_ng': 'angle_deqp_android_release_trybot_arm64', - 'angle-try-mac-amd-exp': 'angle_specific_release_trybot', 'fuchsia-angle-rel': 'gpu_fyi_tests_release_trybot_fuchsia', 'fuchsia-angle-try': 'angle_specific_release_trybot_fuchsia', 'ios-angle-try-intel': 'angle_specific_release_trybot_ios', @@ -881,7 +891,6 @@ 'linux_angle_deqp_rel_ng': 'angle_deqp_release_trybot', 'linux-angle-try': 'angle_specific_release_trybot', 'mac-angle-chromium-try': 'gpu_tests_release_trybot', - 'mac-angle-try': 'angle_specific_release_trybot', 'win-angle-chromium-x64-try': 'gpu_tests_release_trybot', 'win-angle-chromium-x86-try': 'gpu_tests_release_trybot_x86', 'win-angle-x64-try': 'angle_specific_release_trybot', @@ -900,10 +909,10 @@ 'chromeos-kevin-chrome': 'chromeos_kevin_include_unwind_tables_official', 'chromeos-kevin-compile-chrome': 'chromeos_kevin_include_unwind_tables_official', 'lacros-amd64-generic-chrome': 'chromeos_amd64-generic_lacros_official', + 'lacros-amd64-generic-chrome-skylab': 'chromeos_amd64-generic_lacros_official_skylab', 'lacros-arm-generic-chrome': 'chromeos_arm-generic_lacros_official', 'linux-chrome': 'official_goma', 'linux-chrome-beta': 'official_goma', - 'linux-chrome-finch-fyi': 'official_goma', 'linux-chrome-stable': 'official_goma', 'linux-chromeos-chrome': 'official_goma_chromeos_include_unwind_tables', 'mac-chrome': 'official_goma_mac', @@ -912,6 +921,7 @@ 'win-celab-try-rel': 'official_celab_release_bot', 'win-chrome': 'official_goma_x86', 'win-chrome-beta': 'official_goma_x86', + 'win-chrome-finch-fyi': 'official_goma', 'win-chrome-stable': 'official_goma_x86', 'win64-chrome': 'official_goma_x64', 'win64-chrome-beta': 'official_goma_x64', @@ -932,7 +942,7 @@ # and two kevin bots when the PFQ has it enabled. 'chromeos-amd64-generic-cfi-thin-lto-rel': 'chromeos_amd64-generic_cfi_thin_lto', 'chromeos-amd64-generic-dbg': 'chromeos_amd64-generic_dbg', - 'chromeos-amd64-generic-rel': 'chromeos_amd64-generic_use_fake_dbus_clients', + 'chromeos-amd64-generic-rel': 'chromeos_amd64-generic_use_fake_dbus_clients_vm_optimized', 'chromeos-amd64-generic-rel-dchecks': 'chromeos_amd64-generic_use_fake_dbus_clients_dchecks', 'chromeos-amd64-generic-rel-rts': 'chromeos_amd64-generic_use_fake_dbus_clients', 'chromeos-arm-generic-dbg': 'chromeos_arm-generic_dbg', @@ -949,6 +959,7 @@ 'linux-chromeos-compile-dbg': 'chromeos_with_codecs_debug_bot', 'linux-chromeos-dbg': 'chromeos_with_codecs_debug_bot', 'linux-lacros-rel': 'lacros_on_linux_release_trybot', + 'linux-lacros-rel-rts': 'lacros_on_linux_release_trybot', 'linux-cfm-rel': 'linux_cfm_release_trybot', }, @@ -965,6 +976,7 @@ 'dawn-linux-x64-deps-rel': 'dawn_tests_with_desktop_gl_release_trybot', 'dawn-mac-x64-deps-rel': 'dawn_tests_release_trybot', 'dawn-try-mac-amd-exp': 'dawn_tests_release_trybot', + 'dawn-try-mac-intel-exp': 'dawn_tests_release_trybot', 'dawn-win10-x86-deps-rel': 'dawn_tests_release_trybot_x86', 'dawn-win10-x64-deps-rel': 'dawn_tests_release_trybot', 'linux-dawn-rel': 'dawn_tests_with_desktop_gl_release_trybot', @@ -978,6 +990,7 @@ 'cast_shell_audio_linux': 'cast_audio_release_trybot', 'cast_shell_linux': 'cast_release_trybot', 'cast_shell_linux_dbg': 'cast_debug_bot', + 'cast_shell_linux_arm64': 'cast_arm64_release_bot', 'cast-binary-size': 'cast_binary_size', 'chromium_presubmit': 'presubmit', 'fuchsia_arm64': 'release_trybot_fuchsia_arm64', @@ -1031,9 +1044,10 @@ 'linux-mbi-mode-per-render-process-host-rel': 'gpu_tests_release_trybot_mbi_mode_per_render_process_host', 'linux-mbi-mode-per-site-instance-rel': 'gpu_tests_release_trybot_mbi_mode_per_site_instance', 'linux-ozone-rel': 'ozone_linux_release_trybot_no_symbols', + 'linux-wayland-rel': 'gpu_tests_wayland_release_trybot_no_symbols_use_dummy_lastchange_code_coverage', 'linux-perfetto-rel': 'perfetto_release_trybot', 'linux-rel': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_code_coverage', - 'linux-rel-orchestrator': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange', + 'linux-rel-orchestrator': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_code_coverage', 'linux-rel-reclient': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_code_coverage_reclient', 'linux-rel-rts': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_code_coverage', 'linux-trusty-rel': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange', @@ -1045,6 +1059,7 @@ 'linux-xenial-rel': 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange', 'linux_chromium_archive_rel_ng': 'release_bot', 'linux_chromium_asan_rel_ng': 'asan_lsan_release_trybot', + 'linux_chromium_asan_rel_ng_rts': 'asan_lsan_release_trybot', 'linux_chromium_cfi_rel_ng': 'cfi_full_cfi_icall_cfi_diag_thin_lto_release_static_dcheck_always_on_goma', 'linux_chromium_chromeos_asan_rel_ng': 'asan_lsan_chromeos_release_trybot', 'linux_chromium_chromeos_msan_rel_ng': 'chromeos_msan_release_bot', @@ -1061,6 +1076,7 @@ 'linux_chromium_msan_rel_ng': 'msan_release_bot', 'linux_chromium_tsan_rel_ng': 'tsan_disable_nacl_release_trybot', + 'linux_chromium_tsan_rel_ng_rts': 'tsan_disable_nacl_release_trybot', # This is intentionally a release_bot and not a release_trybot to match # the CI configuration, where no debug builder exists. @@ -1080,11 +1096,12 @@ 'tryserver.chromium.mac': { 'gpu-fyi-try-mac-amd-pro-rel': 'gpu_fyi_tests_release_trybot', + 'gpu-fyi-try-mac-amd-retina-asan': 'gpu_fyi_tests_release_trybot_asan', 'gpu-fyi-try-mac-amd-retina-dbg': 'gpu_fyi_tests_debug_trybot', 'gpu-fyi-try-mac-amd-retina-exp': 'gpu_fyi_tests_release_trybot', 'gpu-fyi-try-mac-amd-retina-rel': 'gpu_fyi_tests_release_trybot', - 'gpu-fyi-try-mac-arm64-apple-dtk-rel': 'gpu_fyi_tests_release_trybot_arm64', - 'gpu-fyi-try-mac-asan': 'gpu_fyi_tests_release_trybot_asan', + 'gpu-fyi-try-mac-arm64-apple-m1-rel': 'gpu_fyi_tests_release_trybot_arm64', + 'gpu-fyi-try-mac-intel-asan': 'gpu_fyi_tests_release_trybot_asan', 'gpu-fyi-try-mac-intel-dbg': 'gpu_fyi_tests_debug_trybot', 'gpu-fyi-try-mac-intel-exp': 'gpu_fyi_tests_release_trybot', 'gpu-fyi-try-mac-intel-rel': 'gpu_fyi_tests_release_trybot', @@ -1096,7 +1113,7 @@ 'gpu-try-mac-intel-dbg': 'gpu_tests_debug_bot', 'ios-device': 'ios_device_release_compile_only', 'ios14-beta-simulator': 'ios_simulator_debug_static_bot_xctest', - 'ios14-sdk-simulator': 'ios_simulator_debug_static_bot_xctest', + 'ios14-sdk-simulator': 'ios_simulator_debug_static_bot_xctest_arm64', 'ios15-beta-simulator': 'ios_simulator_debug_static_bot_xctest', 'ios15-sdk-simulator': 'ios_simulator_debug_static_bot_xctest', 'ios-simulator': 'ios_simulator_code_coverage_partial_instrumentation_xctest', @@ -1123,7 +1140,7 @@ 'mac_upload_clang': 'release_bot', 'mac_upload_clang_arm': 'release_bot', 'mac-inverse-fieldtrials-fyi-rel': 'gpu_tests_release_trybot_invert_fieldtrials', - 'mac-rel': 'gpu_tests_release_trybot_no_symbols', + 'mac-rel': 'gpu_tests_release_trybot_no_symbols_mac_code_coverage', 'mac-rel-rts': 'gpu_tests_release_trybot_no_symbols', 'mac11-arm64-rel': 'mac_arm64_release_trybot', }, @@ -1140,6 +1157,11 @@ 'Win x64 Builder Perf': 'official_goma_perf', }, + 'tryserver.chromium.rust': { + 'linux-rust-x64-rel': 'release_rust_linux_x64', + 'android-rust-arm-rel': 'release_rust_android_arm', + }, + 'tryserver.chromium.swangle': { 'linux-swangle-chromium-try-x64': 'gpu_tests_release_trybot', 'linux-swangle-try-tot-angle-x64': 'angle_deqp_release_trybot', @@ -1182,7 +1204,7 @@ 'win10_chromium_x64_rel_ng_exp': 'release_trybot', 'win10_chromium_x64_rel_ng_rts': 'gpu_tests_release_trybot_resource_allowlisting_code_coverage', 'win10_chromium_x64_20h2_fyi_rel_ng': 'gpu_tests_release_trybot_resource_allowlisting_code_coverage', - 'win10-rel-orchestrator': 'gpu_tests_release_trybot_no_resource_allowlisting_no_symbols', + 'win10-rel-orchestrator': 'gpu_tests_release_trybot_resource_allowlisting_code_coverage', 'win-annotator-rel': 'release_trybot', 'win-asan': 'asan_clang_fuzzer_static_v8_heap_minimal_symbols_release', 'win-celab-try-rel': 'release_bot_minimal_symbols', @@ -1207,6 +1229,7 @@ 'tryserver.infra': { 'linux-bootstrap': 'release_trybot', + 'win-bootstrap': 'release_trybot', }, 'tryserver.v8': { @@ -1518,11 +1541,6 @@ 'use_clang_coverage', 'partial_code_coverage_instrumentation', ], - 'android_release_trybot_webview_google': [ - 'android', 'release_trybot', 'strip_debug_info', 'android_no_proguard', - 'webview_google', - ], - 'android_release_trybot_minimal_symbols_x86_fastbuild_webview_google': [ 'android', 'release_trybot', 'minimal_symbols', 'x86', 'strip_debug_info', 'android_fastbuild', 'webview_google', @@ -1537,6 +1555,7 @@ 'android_release_trybot_x64_fastbuild_webview_google': [ 'android', 'release_trybot', 'strip_debug_info', 'x64', 'android_fastbuild', 'webview_google', + 'no_secondary_abi', ], 'android_release_trybot_x86_fastbuild_resource_allowlisting_webview_google': [ @@ -1544,6 +1563,12 @@ 'resource_allowlisting', 'webview_google', ], + 'android_release_trybot_x86_fastbuild_resource_allowlisting_webview_google_coverage': [ + 'android', 'release_trybot_minimal_symbols', 'x86', 'android_fastbuild', + 'resource_allowlisting', 'webview_google', 'use_java_coverage', + 'partial_code_coverage_instrumentation', + ], + 'android_release_trybot_x86_fastbuild_webview_google': [ 'android', 'release_trybot', 'strip_debug_info', 'x86', 'android_fastbuild', 'webview_google', @@ -1579,11 +1604,19 @@ ], 'angle_deqp_android_release_trybot_arm64': [ - 'angle_deqp_tests', 'android', 'shared_release_trybot', 'arm64', + 'angle_deqp_tests', 'android', 'shared_release_bot_dcheck_always_on', 'arm64', ], 'angle_deqp_release_trybot': [ - 'angle_deqp_tests', 'shared_release_trybot', + 'angle_deqp_tests', 'shared_release_bot_dcheck_always_on', + ], + + 'angle_deqp_release_bot_dcheck_always_on_x86': [ + 'angle_deqp_tests', 'shared_release_bot_dcheck_always_on', 'x86', + ], + + 'angle_deqp_release_trybot': [ + 'angle_deqp_tests', 'shared_release_bot_dcheck_always_on', ], 'angle_deqp_release_trybot_x86': [ @@ -1595,6 +1628,27 @@ 'shared_release_trybot', 'arm64', ], + 'angle_specific_no_trace_android_release_trybot_dcheck_always_on_arm64': [ + 'angle_specific_no_trace_tests', 'android_without_codecs', + 'shared_release_bot_dcheck_always_on', 'arm64', + ], + + 'angle_specific_release_bot_dcheck_always_on': [ + 'angle_specific_tests', 'shared_release_bot_dcheck_always_on', + ], + + 'angle_specific_release_bot_dcheck_always_on_fuchsia': [ + 'angle_specific_tests', 'shared_release_bot_dcheck_always_on', 'fuchsia', + ], + + 'angle_specific_release_bot_dcheck_always_on_ios': [ + 'angle_specific_tests', 'release_trybot_minimal_symbols', 'ios', 'ios_simulator', 'ios_cpu_x64', 'xctest', 'ios_disable_xcode_project_generation', + ], + + 'angle_specific_release_bot_dcheck_always_on_x86': [ + 'angle_specific_tests', 'shared_release_bot_dcheck_always_on', 'x86', + ], + 'angle_specific_release_trybot': [ 'angle_specific_tests', 'shared_release_trybot', ], @@ -1615,6 +1669,10 @@ 'asan', 'clang_tot', 'shared', 'v8_heap', 'minimal_symbols', 'release', ], + 'arm64_official_optimize_goma': [ + 'arm64', 'official_optimize_goma', + ], + 'asan_clang_fuzzer_static_v8_heap_minimal_symbols_release': [ 'asan', 'fuzzer', 'static', 'v8_heap', 'minimal_symbols', 'release_bot', ], @@ -1663,6 +1721,10 @@ 'clang', 'asan', 'fuzzer', 'v8_heap', 'release_bot', ], + 'asan_lsan_chromeos_release_bot_dcheck_always_on': [ + 'asan', 'lsan', 'chromeos', 'release_trybot_minimal_symbols', + ], + 'asan_lsan_chromeos_release_trybot': [ 'asan', 'lsan', 'chromeos', 'release_trybot', ], @@ -1679,10 +1741,18 @@ 'asan', 'lsan', 'v8_heap', 'chromeos_codecs', 'release_bot', ], + 'asan_lsan_fuzzer_v8_heap_chromeos_codecs_release_bot_reclient': [ + 'asan', 'lsan', 'v8_heap', 'chromeos_codecs', 'release_bot_reclient', + ], + 'asan_lsan_fuzzer_v8_heap_release_bot': [ 'asan', 'lsan', 'fuzzer', 'v8_heap', 'release_bot', ], + 'asan_lsan_fuzzer_v8_heap_release_bot_reclient': [ + 'asan', 'lsan', 'fuzzer', 'v8_heap', 'release_bot_reclient', + ], + 'asan_lsan_release_bot': [ 'asan', 'lsan', 'release_bot', ], @@ -1692,7 +1762,7 @@ ], 'asan_lsan_release_trybot': [ - 'asan', 'lsan', 'release_trybot', + 'asan', 'lsan', 'release_trybot_minimal_symbols', ], 'autofill_assistant_release_trybot': [ @@ -1713,6 +1783,10 @@ 'cast', 'debug_bot', ], + 'cast_arm64_release_bot': [ + 'cast', 'release_bot', 'arm64', 'minimal_symbols', + ], + 'cast_binary_size': [ 'cast', 'minimal_symbols', 'release_bot', ], @@ -1771,10 +1845,14 @@ 'chromeos_amd64-generic', 'debug', ], - 'chromeos_amd64-generic_use_fake_dbus_clients': [ + 'chromeos_amd64-generic_use_fake_dbus_clients':[ 'chromeos_amd64-generic', 'use_fake_dbus_clients', ], + 'chromeos_amd64-generic_use_fake_dbus_clients_vm_optimized': [ + 'chromeos_amd64-generic-vm', 'use_fake_dbus_clients', + ], + 'chromeos_amd64-generic_use_fake_dbus_clients_dchecks': [ 'chromeos_amd64-generic', 'use_fake_dbus_clients', 'dcheck_always_on', ], @@ -1860,6 +1938,10 @@ 'chromeos_with_codecs', 'release_bot', ], + 'chromeos_with_codecs_with_lacros_release_bot': [ + 'chromeos_with_codecs', 'release_bot', 'also_build_lacros_chrome' + ], + 'chromeos_with_codecs_release_bot_coverage': [ 'chromeos_with_codecs', 'release_bot', 'use_clang_coverage', ], @@ -1874,7 +1956,7 @@ # Keep in sync with chromeos_with_codecs_release_trybot. 'chromeos_with_codecs_release_trybot_code_coverage': [ - 'chromeos_with_codecs', 'release_trybot', 'no_symbols', + 'chromeos_with_codecs', 'release_trybot', 'no_symbols', 'also_build_lacros_chrome', 'use_clang_coverage', 'partial_code_coverage_instrumentation', ], @@ -2010,10 +2092,22 @@ 'codesearch', ], + 'dawn_tests_asan_release_bot_dcheck_always_on': [ + 'dawn_tests', 'asan', 'release_trybot_minimal_symbols', + ], + 'dawn_tests_asan_release_trybot': [ 'dawn_tests', 'asan', 'release_trybot', ], + 'dawn_tests_release_bot_dcheck_always_on': [ + 'dawn_tests', 'release_trybot_minimal_symbols', + ], + + 'dawn_tests_release_bot_dcheck_always_on_x86': [ + 'dawn_tests', 'release_trybot_minimal_symbols', 'x86', + ], + 'dawn_tests_release_trybot': [ 'dawn_tests', 'release_trybot', ], @@ -2023,7 +2117,7 @@ ], 'dawn_tests_with_desktop_gl_release_trybot': [ - 'dawn_tests', 'dawn_enable_desktop_gl', 'release_trybot', + 'dawn_tests', 'dawn_enable_desktop_gl', 'release_trybot_minimal_symbols', ], 'debug_bot': [ @@ -2100,31 +2194,31 @@ ], 'gpu_fyi_tests_dx12vk_release_trybot': [ - 'gpu_fyi_tests', 'dx12vk', 'release_trybot', 'disable_nacl', + 'gpu_fyi_tests', 'dx12vk', 'release_trybot_minimal_symbols', 'disable_nacl', ], 'gpu_fyi_tests_release_trybot': [ - 'gpu_fyi_tests', 'release_trybot', 'disable_nacl', + 'gpu_fyi_tests', 'release_trybot_minimal_symbols', 'disable_nacl', ], 'gpu_fyi_tests_release_trybot_arm64': [ - 'gpu_fyi_tests', 'release_trybot', 'arm64', 'disable_nacl', + 'gpu_fyi_tests', 'release_trybot_minimal_symbols', 'arm64', 'disable_nacl', ], 'gpu_fyi_tests_release_trybot_asan': [ - 'gpu_fyi_tests', 'release_trybot', 'asan', 'disable_nacl', + 'gpu_fyi_tests', 'release_trybot_minimal_symbols', 'asan', 'disable_nacl', ], 'gpu_fyi_tests_release_trybot_fuchsia': [ - 'gpu_fyi_tests', 'release_trybot', 'fuchsia', 'disable_nacl', + 'gpu_fyi_tests', 'release_trybot_minimal_symbols', 'fuchsia', 'disable_nacl', ], 'gpu_fyi_tests_release_trybot_tsan': [ - 'gpu_fyi_tests', 'release_trybot', 'tsan', 'disable_nacl', + 'gpu_fyi_tests', 'release_trybot_minimal_symbols', 'tsan', 'disable_nacl', ], 'gpu_fyi_tests_release_trybot_x86': [ - 'gpu_fyi_tests', 'release_trybot', 'x86', 'disable_nacl', + 'gpu_fyi_tests', 'release_trybot_minimal_symbols', 'x86', 'disable_nacl', ], 'gpu_tests_android_release_bot_minimal_symbols_arm64_fastbuild': [ @@ -2148,11 +2242,16 @@ ], 'gpu_tests_android_release_trybot': [ - 'gpu_tests', 'android', 'release_trybot', 'static_angle', + 'gpu_tests', 'android', 'release_trybot_minimal_symbols', 'static_angle', ], 'gpu_tests_android_release_trybot_arm64': [ - 'gpu_tests', 'android', 'release_trybot', 'arm64', 'static_angle', + 'gpu_tests', 'android', 'release_trybot_minimal_symbols', 'arm64', 'static_angle', + ], + + 'gpu_tests_android_release_bot_dcheck_always_on_arm64_fastbuild': [ + 'gpu_tests', 'android', 'release_trybot_minimal_symbols', 'arm64', 'static_angle', + 'android_fastbuild', ], 'gpu_tests_android_release_trybot_arm64_fastbuild': [ @@ -2162,7 +2261,7 @@ 'gpu_tests_android_release_trybot_arm64_resource_allowlisting_fastbuild_java_coverage': [ 'gpu_tests', 'android', 'release_trybot', 'arm64', 'static_angle', - 'resource_allowlisting', 'android_fastbuild', 'webview_google', + 'strip_debug_info', 'android_fastbuild', 'webview_google', 'use_java_coverage', 'partial_code_coverage_instrumentation', ], @@ -2195,6 +2294,10 @@ 'gpu_tests', 'release_bot', ], + 'gpu_tests_wayland_release_bot': [ + 'gpu_tests', 'release_bot', 'linux_wayland', + ], + 'gpu_tests_release_bot_minimal_symbols': [ 'gpu_tests', 'release_bot', 'minimal_symbols', ], @@ -2244,6 +2347,10 @@ 'gpu_tests', 'release_trybot', 'mbi_mode_per_site_instance' ], + 'gpu_tests_release_bot_dcheck_always_on_resource_allowlisting': [ + 'gpu_tests', 'release_trybot_minimal_symbols', 'resource_allowlisting', + ], + 'gpu_tests_release_trybot_resource_allowlisting': [ 'gpu_tests', 'release_trybot', 'resource_allowlisting', ], @@ -2254,27 +2361,37 @@ 'gpu_tests_release_trybot_resource_allowlisting_code_coverage': [ 'gpu_tests', 'release_trybot', 'no_resource_allowlisting', 'use_clang_coverage', 'partial_code_coverage_instrumentation', - # TODO(svenzheng): Move this to 'release_trybot' if there are no objections. - 'no_symbols', - ], - - 'gpu_tests_release_trybot_no_resource_allowlisting_no_symbols': [ - 'gpu_tests', 'release_trybot', 'no_resource_allowlisting', - 'no_symbols', ], 'gpu_tests_release_trybot_resource_allowlisting_invert_fieldtrials': [ 'gpu_tests', 'release_trybot', 'resource_allowlisting', 'invert_fieldtrials', ], + 'gpu_tests_release_bot_dcheck_always_on_x86': [ + 'gpu_tests', 'release_trybot_minimal_symbols', 'x86', + ], + 'gpu_tests_release_trybot_x86': [ 'gpu_tests', 'release_trybot', 'x86', ], + 'gpu_tests_release_trybot_minimal_symbols': [ + 'gpu_tests', 'release_trybot_minimal_symbols', + ], + + 'gpu_tests_release_trybot_minimal_symbol_x86_resource_allowlisting': [ + 'gpu_tests', 'release_trybot_minimal_symbols', 'x86', 'resource_allowlisting', + ], + 'gpu_tests_release_trybot_no_symbols': [ 'gpu_tests', 'release_trybot', 'no_symbols', ], + 'gpu_tests_release_trybot_no_symbols_mac_code_coverage': [ + 'gpu_tests', 'release_trybot', 'no_symbols', + 'use_clang_coverage', 'partial_code_coverage_instrumentation' + ], + 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange': [ 'gpu_tests', 'release_trybot', 'no_symbols', 'use_dummy_lastchange', ], @@ -2286,6 +2403,11 @@ 'use_clang_coverage', 'partial_code_coverage_instrumentation', ], + 'gpu_tests_wayland_release_trybot_no_symbols_use_dummy_lastchange_code_coverage': [ + 'gpu_tests', 'release_trybot', 'no_symbols', 'use_dummy_lastchange', + 'linux_wayland', + ], + 'gpu_tests_release_trybot_no_symbols_use_dummy_lastchange_code_coverage_reclient': [ 'gpu_tests', 'release_trybot_reclient', 'no_symbols', 'use_dummy_lastchange', 'use_clang_coverage', 'partial_code_coverage_instrumentation', @@ -2297,7 +2419,7 @@ ], 'gpu_tests_release_trybot_ptr_comp': [ - 'gpu_tests', 'release_trybot', 'v8_pointer_compression', + 'gpu_tests', 'release_trybot_minimal_symbols', 'v8_pointer_compression', ], 'gpu_tests_release_trybot_x86_resource_allowlisting': [ @@ -2305,13 +2427,17 @@ ], 'gpu_tests_sk_dawn_release_trybot': [ - 'gpu_tests', 'sk_dawn', 'release_trybot', + 'gpu_tests', 'sk_dawn', 'release_trybot_minimal_symbols', ], 'gn_linux_upload': [ 'gn_linux_upload', 'official', 'goma', ], + 'headless_shell_release_bot': [ + 'headless_shell', 'release', 'static', 'goma', + ], + 'ios_clang_tot_xctest': [ 'clang_tot', 'ios', 'ios_simulator', 'ios_cpu_x64', 'ios_disable_code_signing', 'release', 'static', 'xctest', 'ios_disable_xcode_project_generation', ], @@ -2337,6 +2463,14 @@ 'debug_static_bot', 'ios', 'ios_simulator', 'ios_cpu_x64', 'xctest', 'ios_disable_xcode_project_generation', ], + 'ios_simulator_debug_static_bot_xctest_arm64': [ + 'debug_static_bot', 'ios', 'ios_simulator', 'ios_cpu_arm64', 'xctest', 'ios_disable_xcode_project_generation', + ], + + 'ios_simulator_debug_static_bot_xctest_reclient': [ + 'debug_static_bot_reclient', 'ios', 'ios_simulator', 'ios_cpu_x64', 'xctest', 'ios_disable_xcode_project_generation', + ], + 'ios_simulator_debug_static_bot_invert_fieldtrials_xctest': [ 'debug_static_bot', 'ios', 'ios_simulator', 'ios_cpu_x64', 'invert_fieldtrials', 'xctest', 'ios_disable_xcode_project_generation', ], @@ -2414,7 +2548,7 @@ ], 'libfuzzer_asan_clang_tot_release': [ - 'libfuzzer', 'asan', 'clang_tot', 'release', 'chromeos_codecs', 'pdf_xfa', 'disable_nacl', + 'libfuzzer', 'asan', 'clang_tot', 'release', 'shared', 'chromeos_codecs', 'pdf_xfa', 'disable_nacl', 'optimize_for_fuzzing', 'mojo_fuzzer', ], 'libfuzzer_msan_release_bot': [ @@ -2456,6 +2590,10 @@ 'release_bot', 'arm64', ], + 'mac_arm64_release_bot_reclient': [ + 'release_bot_reclient', 'arm64', + ], + 'mac_arm64_release_trybot': [ 'release_trybot', 'arm64', ], @@ -2468,10 +2606,18 @@ 'msan_no_origins', 'release_bot', ], + 'msan_no_origins_release_bot_reclient': [ + 'msan_no_origins', 'release_bot_reclient', + ], + 'msan_release_bot': [ 'msan', 'release_bot', ], + 'msan_release_bot_reclient': [ + 'msan', 'release_bot_reclient', + ], + 'msan_release_bot_blink': [ 'msan', 'release_bot_blink', ], @@ -2524,6 +2670,10 @@ 'official', 'goma', 'no_gnome_keyring', 'minimal_symbols', 'pgo_phase_0', ], + 'official_goma_linux_perf_py3': [ + 'official', 'goma', 'no_gnome_keyring', 'minimal_symbols', 'pgo_phase_0', 'use_py3_for_perf' + ], + 'official_goma_fuchsia_arm64_perf': [ 'official', 'goma', 'minimal_symbols', 'fuchsia', 'fuchsia_include_astro_images', 'arm64', 'ffmpeg_branding_chrome', 'proprietary_codecs', 'test_isolate_no_emulator' ], @@ -2544,6 +2694,10 @@ 'official', 'goma', 'minimal_symbols', 'android', 'arm64', 'pgo_phase_0', 'no_default_afdo' ], + 'official_goma_minimal_symbols_android_arm64_py3': [ + 'official', 'goma', 'minimal_symbols', 'android', 'arm64', 'pgo_phase_0', 'no_default_afdo', 'use_py3_for_perf' + ], + 'official_goma_minimal_symbols_android_thin_lto_opt': [ 'official', 'goma', 'minimal_symbols', 'android', 'thin_lto_opt', 'no_default_afdo' ], @@ -2601,7 +2755,7 @@ ], 'gpu_tests_ozone_linux_non_x11_release_trybot': [ - 'gpu_tests', 'ozone_linux', 'ozone_linux_non_x11', 'release_trybot', + 'gpu_tests', 'ozone_linux', 'ozone_linux_non_x11', 'release_trybot_minimal_symbols', ], 'ozone_linux_release_bot': [ @@ -2629,14 +2783,6 @@ 'release_bot', ], - 'release_bot_arm_chromeos': [ - 'release_bot', 'chromeos', 'arm', - ], - - 'release_bot_arm64_chromeos': [ - 'release_bot', 'chromeos', 'arm64', - ], - 'release_bot_blink': [ 'release_bot_blink', ], @@ -2651,6 +2797,9 @@ 'disable_nacl', ], + 'release_bot_blink_arm64_minimal_symbols': [ + 'release_bot_blink', 'arm64', 'minimal_symbols', + ], 'release_bot_blink_x86_minimal_symbols': [ 'release_bot_blink', 'x86', 'minimal_symbols', @@ -2767,23 +2916,39 @@ ], 'release_trybot_backuprefptr_x86': [ - 'release_trybot', 'backuprefptr', 'x86', + 'release_trybot_minimal_symbols', 'backuprefptr', 'x86', ], 'release_trybot_backuprefptr_x64': [ - 'release_trybot', 'backuprefptr', 'x64', + 'release_trybot_minimal_symbols', 'backuprefptr', 'x64', ], 'release_trybot_backuprefptr_arm': [ - 'release_trybot', 'backuprefptr', 'android', 'arm', + 'release_trybot_minimal_symbols', 'backuprefptr', 'android', 'arm', ], 'release_trybot_backuprefptr_arm64': [ - 'release_trybot', 'backuprefptr', 'android', 'arm64', + 'release_trybot_minimal_symbols', 'backuprefptr', 'backuprefptr', 'android', 'arm64', ], 'release_trybot_paeverywhere_x64': [ - 'release_trybot', 'paeverywhere', 'x64', + 'release_trybot_minimal_symbols', 'paeverywhere', 'x64', + ], + + 'release_rust_android_arm': [ + 'release_trybot_minimal_symbols', 'enable_rust', 'android', 'arm', + ], + + 'release_rust_linux_x64': [ + 'release_trybot_minimal_symbols', 'enable_rust', 'x64', + ], + + 'release_trybot_minimal_symbols': [ + 'release_trybot_minimal_symbols', + ], + + 'release_trybot_minimal_symbols_tsan': [ + 'release_trybot_minimal_symbols', 'tsan' ], 'release_trybot_tsan': [ @@ -2799,10 +2964,6 @@ 'no_goma', ], - 'shared_release_bot': [ - 'shared_release_bot', - ], - 'tsan_disable_nacl_debug_bot': [ 'tsan', 'disable_nacl', 'debug_bot', ], @@ -2820,7 +2981,7 @@ ], 'tsan_disable_nacl_release_trybot': [ - 'tsan', 'disable_nacl', 'release_trybot', + 'tsan', 'disable_nacl', 'release_trybot_minimal_symbols', ], 'ubsan_release_bot': [ @@ -2881,6 +3042,10 @@ 'args_file': '//build/args/chromeos/amd64-generic.gni', }, + 'amd64-generic-vm': { + 'args_file': '//build/args/chromeos/amd64-generic-vm.gni', + }, + 'amd64-generic-crostoolchain': { 'args_file': '//build/args/chromeos/amd64-generic-crostoolchain.gni', }, @@ -2928,17 +3093,12 @@ 'gn_args': 'build_angle_deqp_tests=true', }, - 'angle_gles1_conform_tests': { - 'gn_args': 'build_angle_gles1_conform_tests=true', - }, - 'angle_specific_tests': { - 'mixins': ['angle_gles1_conform_tests', 'angle_deqp_tests', - 'angle_trace_perf_tests', 'disable_nacl'], + 'mixins': ['angle_deqp_tests', 'angle_trace_perf_tests', 'disable_nacl'], }, 'angle_specific_no_trace_tests': { - 'mixins': ['angle_gles1_conform_tests', 'angle_deqp_tests'], + 'mixins': ['angle_deqp_tests'], }, 'angle_trace_perf_tests': { @@ -3049,6 +3209,10 @@ 'mixins': ['chromeos_device', 'amd64-generic',] }, + 'chromeos_amd64-generic-vm': { + 'mixins': ['chromeos_device', 'amd64-generic-vm',] + }, + 'chromeos_amd64-generic-crostoolchain': { 'mixins': ['chromeos_device', 'amd64-generic-crostoolchain',] }, @@ -3202,6 +3366,10 @@ 'gn_args': 'skip_archive_compression=false', }, + 'enable_rust': { + 'gn_args': 'enable_rust=true', + }, + 'enable_v8_oilpan': { 'gn_args': 'enable_blink_heap_use_v8_oilpan=true', }, @@ -3283,6 +3451,7 @@ }, 'gpu_fyi_tests': { + 'gn_args': 'is_gpu_fyi_bot=true', 'mixins': ['angle_trace_perf_tests', 'gpu_tests', 'internal_gles_conform_tests'], }, @@ -3290,6 +3459,14 @@ 'mixins': ['chrome_with_codecs'], }, + 'headless': { + 'args_file': '//build/args/headless.gn', + }, + + 'headless_shell': { + 'mixins': ['headless', 'no_codecs'], + }, + 'hybrid': { 'gn_args': 'v8_target_cpu="arm" target_cpu="x86"', 'mixins': ['disable_nacl'], @@ -3304,7 +3481,7 @@ }, 'internal_gles_conform_tests': { - 'gn_args': 'internal_gles2_conform_tests=true build_angle_gles1_conform_tests=true', + 'gn_args': 'internal_gles2_conform_tests=true', }, 'invert_fieldtrials': { @@ -3385,6 +3562,10 @@ 'gn_args': 'also_build_ash_chrome=true', }, + 'also_build_lacros_chrome': { + 'gn_args': 'also_build_lacros_chrome=true', + }, + 'libfuzzer': { 'gn_args': 'use_libfuzzer=true' }, 'lsan': { @@ -3415,6 +3596,13 @@ 'gn_args': 'is_clang=false', }, + 'no_codecs': { + 'gn_args': ('media_use_libvpx=false ' + 'media_use_ffmpeg=false ' + 'proprietary_codecs=false ' + 'enable_ffmpeg_video_decoders=false'), + }, + 'no_com_init_hooks': { 'gn_args': 'com_init_check_hook_disabled=true', }, @@ -3465,7 +3653,7 @@ }, 'updater_on_win_mac': { - 'gn_args': 'is_google_branded=true', + 'gn_args': 'enable_chromium_updater=true', }, 'optimize_for_fuzzing': { @@ -3476,6 +3664,10 @@ 'gn_args': 'use_ozone=true', }, + 'linux_wayland': { + 'gn_args': 'ozone_auto_platforms=false ozone_platform_wayland=true ozone_platform="wayland" use_bundled_weston=true', + }, + 'ozone_linux': { 'gn_args': 'use_ozone=true ozone_platform="headless" use_bundled_weston=true', }, @@ -3485,7 +3677,7 @@ # that exercises angle + ozone (though, it is ozone/drm in reality. We don't support # angle on Linux Ozone/X11/Wayland yet). 'ozone_linux_non_x11': { - 'gn_args': 'use_x11=false' + 'gn_args': 'use_x11=false ozone_platform_x11=false' }, 'paeverywhere': { @@ -3493,7 +3685,7 @@ }, 'backuprefptr': { - 'gn_args': 'use_allocator="partition" use_backup_ref_ptr=true enable_runtime_backup_ref_ptr_control=true never_remove_from_brp_pool_blocklist=true enable_backup_ref_ptr_slow_checks=true', + 'gn_args': 'use_allocator="partition" use_backup_ref_ptr=false', }, # Used to pass the list of files to instrument for coverage to the compile @@ -3532,12 +3724,12 @@ }, 'reclient': { - 'gn_args': 'use_rbe=true', + 'gn_args': 'use_rbe=true use_remoteexec=true', }, # experiment windows cross. crbug.com/1213717 'reclient_win_cross': { - 'gn_args': 'use_rbe=true rbe_cfg_dir="../../buildtools/reclient_cfgs/win-cross-experiments"', + 'gn_args': 'use_rbe=true use_remoteexec=true rbe_cfg_dir="../../buildtools/reclient_cfgs/win-cross-experiments"', }, # Historically, a 'release' bot had DCHECKs turned off. DCHECKs are now @@ -3571,7 +3763,7 @@ }, 'release_trybot': { - 'mixins': ['release_bot', 'minimal_symbols', 'dcheck_always_on', + 'mixins': ['release_bot', 'no_symbols', 'dcheck_always_on', 'blink_disable_generated_code_formatting'], }, @@ -3584,6 +3776,11 @@ 'blink_disable_generated_code_formatting'], }, + 'release_trybot_minimal_symbols': { + 'mixins': ['release_bot', 'minimal_symbols', 'dcheck_always_on', + 'blink_disable_generated_code_formatting'], + }, + 'release_trybot_reclient': { 'mixins': ['release_bot_reclient', 'minimal_symbols', 'dcheck_always_on', 'blink_disable_generated_code_formatting'], @@ -3601,12 +3798,16 @@ 'mixins': ['shared', 'release', 'goma'], }, + 'shared_release_bot_dcheck_always_on': { + 'mixins': ['shared_release_bot', 'minimal_symbols', 'dcheck_always_on'], + }, + 'shared_release_bot_reclient': { 'mixins': ['shared', 'release', 'reclient'] }, 'shared_release_trybot': { - 'mixins': ['shared_release_bot', 'minimal_symbols', 'dcheck_always_on'], + 'mixins': ['shared_release_bot', 'no_symbols', 'dcheck_always_on'], }, 'sk_dawn': { @@ -3700,6 +3901,10 @@ 'gn_args': 'use_javascript_coverage=true', }, + 'use_py3_for_perf': { + 'gn_args': 'use_py3_for_perf=true', + }, + 'v8_simulate_arm': { 'gn_args': 'target_cpu="x86" v8_target_cpu="arm"', }, diff --git a/chromium/tools/mb/mb_config_expectations/chrome.json b/chromium/tools/mb/mb_config_expectations/chrome.json index 0c72e9a970f..57e8bbe08a0 100644 --- a/chromium/tools/mb/mb_config_expectations/chrome.json +++ b/chromium/tools/mb/mb_config_expectations/chrome.json @@ -14,6 +14,19 @@ "use_thin_lto": true } }, + "chromeos-betty-arc-r-chrome": { + "args_file": "//build/args/chromeos/betty-arc-r.gni", + "gn_args": { + "dcheck_always_on": false, + "exclude_unwind_tables": false, + "is_chrome_branded": true, + "is_chromeos_device": true, + "is_official_build": true, + "ozone_platform_headless": true, + "use_goma": true, + "use_real_dbus_clients": false + } + }, "chromeos-betty-pi-arc-cfi-thin-lto-chrome": { "args_file": "//build/args/chromeos/betty-pi-arc.gni", "gn_args": { @@ -42,6 +55,18 @@ "use_real_dbus_clients": false } }, + "chromeos-eve-arc-r-chrome": { + "args_file": "//build/args/chromeos/eve-arc-r.gni", + "gn_args": { + "dcheck_always_on": false, + "exclude_unwind_tables": false, + "is_chrome_branded": true, + "is_chromeos_device": true, + "is_official_build": true, + "ozone_platform_headless": true, + "use_goma": true + } + }, "chromeos-eve-chrome": { "args_file": "//build/args/chromeos/eve.gni", "gn_args": { @@ -84,6 +109,25 @@ "use_thin_lto": true } }, + "lacros-amd64-generic-chrome-skylab": { + "args_file": "//build/args/chromeos/amd64-generic-crostoolchain.gni", + "gn_args": { + "chromeos_is_browser_only": true, + "cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot", + "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot", + "dcheck_always_on": false, + "is_cfi": true, + "is_chrome_branded": true, + "is_chromeos_device": true, + "is_official_build": true, + "is_skylab": true, + "ozone_platform_headless": true, + "symbol_level": 1, + "target_os": "chromeos", + "use_goma": true, + "use_thin_lto": true + } + }, "lacros-arm-generic-chrome": { "args_file": "//build/args/chromeos/arm-generic-crostoolchain.gni", "gn_args": { diff --git a/chromium/tools/mb/mb_config_expectations/chromium.android.fyi.json b/chromium/tools/mb/mb_config_expectations/chromium.android.fyi.json index 6c06eae5d8e..2fc428d6f51 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.android.fyi.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.android.fyi.json @@ -10,7 +10,8 @@ "strip_debug_info": true, "symbol_level": 1, "target_os": "android", - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "Android WebView P FYI (rel)": { @@ -38,7 +39,8 @@ "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "android-12-x64-fyi-rel": { @@ -159,5 +161,23 @@ "use_errorprone_java_compiler": false, "use_goma": true } + }, + "android-x86-fyi-rel": { + "gn_args": { + "dcheck_always_on": false, + "disable_android_lint": true, + "ffmpeg_branding": "Chrome", + "is_component_build": false, + "is_debug": false, + "proprietary_codecs": true, + "strip_debug_info": true, + "symbol_level": 1, + "system_webview_package_name": "com.google.android.apps.chrome", + "system_webview_shell_package_name": "com.google.android.webview_shell", + "target_cpu": "x86", + "target_os": "android", + "use_errorprone_java_compiler": false, + "use_goma": true + } } }
\ No newline at end of file diff --git a/chromium/tools/mb/mb_config_expectations/chromium.android.json b/chromium/tools/mb/mb_config_expectations/chromium.android.json index 59931af0434..87db17d27af 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.android.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.android.json @@ -418,20 +418,6 @@ "use_goma": true } }, - "android-lollipop-arm-rel": { - "gn_args": { - "dcheck_always_on": false, - "ffmpeg_branding": "Chrome", - "is_component_build": false, - "is_debug": false, - "proprietary_codecs": true, - "strip_debug_info": true, - "symbol_level": 1, - "system_webview_package_name": "com.google.android.webview", - "target_os": "android", - "use_goma": true - } - }, "android-marshmallow-arm64-rel": { "gn_args": { "dcheck_always_on": false, diff --git a/chromium/tools/mb/mb_config_expectations/chromium.angle.json b/chromium/tools/mb/mb_config_expectations/chromium.angle.json index 4f690e7d914..caebdac0cee 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.angle.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.angle.json @@ -2,7 +2,6 @@ "android-angle-arm64-builder": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "dcheck_always_on": true, "is_component_build": true, "is_debug": false, @@ -32,7 +31,6 @@ "fuchsia-angle-builder": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -47,7 +45,6 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -65,7 +62,6 @@ "linux-angle-builder": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -87,19 +83,6 @@ "use_goma": true } }, - "mac-angle-builder": { - "gn_args": { - "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, - "build_angle_trace_perf_tests": true, - "dcheck_always_on": true, - "enable_nacl": false, - "is_component_build": true, - "is_debug": false, - "symbol_level": 1, - "use_goma": true - } - }, "mac-angle-chromium-builder": { "gn_args": { "blink_enable_generated_code_formatting": false, @@ -140,7 +123,6 @@ "win-angle-x64-builder": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -153,7 +135,6 @@ "win-angle-x86-builder": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, diff --git a/chromium/tools/mb/mb_config_expectations/chromium.chromiumos.json b/chromium/tools/mb/mb_config_expectations/chromium.chromiumos.json index 5b082b2a6e7..7bee521759a 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.chromiumos.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.chromiumos.json @@ -57,7 +57,7 @@ } }, "chromeos-amd64-generic-rel": { - "args_file": "//build/args/chromeos/amd64-generic.gni", + "args_file": "//build/args/chromeos/amd64-generic-vm.gni", "gn_args": { "dcheck_always_on": false, "is_chromeos_device": true, @@ -170,6 +170,7 @@ }, "linux-chromeos-rel": { "gn_args": { + "also_build_lacros_chrome": true, "dcheck_always_on": false, "ffmpeg_branding": "ChromeOS", "is_component_build": false, diff --git a/chromium/tools/mb/mb_config_expectations/chromium.clang.json b/chromium/tools/mb/mb_config_expectations/chromium.clang.json index 9d90798402f..f7df49e8a94 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.clang.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.clang.json @@ -198,12 +198,15 @@ "ToTLinuxASanLibfuzzer": { "gn_args": { "dcheck_always_on": false, + "enable_mojom_fuzzer": true, "enable_nacl": false, "ffmpeg_branding": "ChromeOS", "is_asan": true, "is_clang": true, + "is_component_build": true, "is_debug": false, "llvm_force_head_revision": true, + "optimize_for_fuzzing": true, "pdf_enable_xfa": true, "proprietary_codecs": true, "use_libfuzzer": true diff --git a/chromium/tools/mb/mb_config_expectations/chromium.fyi.json b/chromium/tools/mb/mb_config_expectations/chromium.fyi.json index 00015f27b57..bf2e984798f 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.fyi.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.fyi.json @@ -6,7 +6,35 @@ "is_debug": true, "is_lsan": true, "symbol_level": 1, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true + } + }, + "ASAN Release (reclient shadow)": { + "gn_args": { + "dcheck_always_on": false, + "enable_ipc_fuzzer": true, + "is_asan": true, + "is_component_build": false, + "is_debug": false, + "is_lsan": true, + "use_rbe": true, + "use_remoteexec": true, + "v8_enable_verify_heap": true + } + }, + "ASAN Release Media (reclient_shadow)": { + "gn_args": { + "dcheck_always_on": false, + "ffmpeg_branding": "ChromeOS", + "is_asan": true, + "is_component_build": false, + "is_debug": false, + "is_lsan": true, + "proprietary_codecs": true, + "use_rbe": true, + "use_remoteexec": true, + "v8_enable_verify_heap": true } }, "Afl Upload Linux ASan": { @@ -40,7 +68,8 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "Libfuzzer Upload Chrome OS ASan": { @@ -89,7 +118,8 @@ "pdf_enable_xfa": true, "proprietary_codecs": true, "use_libfuzzer": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "Libfuzzer Upload Linux ASan Debug": { @@ -172,104 +202,113 @@ "use_libfuzzer": true } }, - "Linux Builder (core-32) (goma)": { + "Linux Builder (deps-cache) (reclient)": { "gn_args": { "dcheck_always_on": false, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "use_goma": true + "use_rbe": true, + "use_remoteexec": true } }, - "Linux Builder (core-32) (reclient)": { + "Linux Builder (j-500) (g-ip) (reclient)": { "gn_args": { "dcheck_always_on": false, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, - "Linux Builder (core-32) (runsc) (reclient)": { + "Linux Builder (j-500) (n2) (reclient)": { "gn_args": { "dcheck_always_on": false, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, - "Linux Builder (deps-cache) (reclient)": { + "Linux Builder (j-500) (reclient)": { "gn_args": { "dcheck_always_on": false, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, - "Linux Builder (j-500) (g-ip) (reclient)": { + "Linux TSan Builder (goma cache silo)": { "gn_args": { "dcheck_always_on": false, - "ffmpeg_branding": "Chrome", + "enable_nacl": false, "is_component_build": false, "is_debug": false, - "proprietary_codecs": true, - "use_rbe": true + "is_tsan": true, + "use_goma": true } }, - "Linux Builder (j-500) (n2) (reclient)": { + "Linux TSan Builder (reclient)": { "gn_args": { "dcheck_always_on": false, - "ffmpeg_branding": "Chrome", + "enable_nacl": false, "is_component_build": false, "is_debug": false, - "proprietary_codecs": true, - "use_rbe": true + "is_tsan": true, + "use_rbe": true, + "use_remoteexec": true } }, - "Linux Builder (j-500) (reclient)": { + "Linux Viz": { "gn_args": { - "dcheck_always_on": false, - "ffmpeg_branding": "Chrome", + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "proprietary_codecs": true, - "use_rbe": true + "symbol_level": 1, + "use_goma": true } }, - "Linux TSan Builder (goma cache silo)": { + "MSAN Release (chained origins) (reclient shadow)": { "gn_args": { "dcheck_always_on": false, - "enable_nacl": false, "is_component_build": false, "is_debug": false, - "is_tsan": true, - "use_goma": true + "is_msan": true, + "msan_track_origins": 2, + "use_rbe": true, + "use_remoteexec": true } }, - "Linux TSan Builder (reclient)": { + "MSAN Release (no origins) (reclient shadow)": { "gn_args": { "dcheck_always_on": false, - "enable_nacl": false, "is_component_build": false, "is_debug": false, - "is_tsan": true, - "use_rbe": true + "is_msan": true, + "msan_track_origins": 0, + "use_rbe": true, + "use_remoteexec": true } }, - "Linux Viz": { + "Mac Builder (reclient)": { "gn_args": { - "blink_enable_generated_code_formatting": false, - "dcheck_always_on": true, + "dcheck_always_on": false, + "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, + "proprietary_codecs": true, "symbol_level": 1, - "use_goma": true + "use_rbe": true, + "use_remoteexec": true } }, "Mac Builder Next": { @@ -322,27 +361,8 @@ "is_debug": true, "is_tsan": true, "symbol_level": 1, - "use_rbe": true - } - }, - "TSAN Release (core-32) (goma)": { - "gn_args": { - "dcheck_always_on": false, - "enable_nacl": false, - "is_component_build": false, - "is_debug": false, - "is_tsan": true, - "use_goma": true - } - }, - "TSAN Release (core-32) (reclient)": { - "gn_args": { - "dcheck_always_on": false, - "enable_nacl": false, - "is_component_build": false, - "is_debug": false, - "is_tsan": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "TSAN Release (deps-cache) (reclient)": { @@ -352,7 +372,8 @@ "is_component_build": false, "is_debug": false, "is_tsan": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "TSAN Release (g-ip) (reclient)": { @@ -362,7 +383,8 @@ "is_component_build": false, "is_debug": false, "is_tsan": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "TSAN Release (j-250) (reclient)": { @@ -372,7 +394,8 @@ "is_component_build": false, "is_debug": false, "is_tsan": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "TSAN Release (reclient)": { @@ -382,17 +405,8 @@ "is_component_build": false, "is_debug": false, "is_tsan": true, - "use_rbe": true - } - }, - "TSAN Release (runsc-exp) (reclient)": { - "gn_args": { - "dcheck_always_on": false, - "enable_nacl": false, - "is_component_build": false, - "is_debug": false, - "is_tsan": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "UBSan Release (reclient)": { @@ -401,7 +415,8 @@ "is_component_build": false, "is_debug": false, "is_ubsan": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "VR Linux": { @@ -421,7 +436,8 @@ "is_component_build": false, "is_debug": false, "use_ozone": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "Win 10 Fast Ring": { @@ -442,7 +458,8 @@ "is_debug": false, "proprietary_codecs": true, "symbol_level": 1, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "Win x64 Builder (reclient)(cross)": { @@ -454,25 +471,23 @@ "proprietary_codecs": true, "rbe_cfg_dir": "../../buildtools/reclient_cfgs/win-cross-experiments", "symbol_level": 1, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "android-backuprefptr-arm-fyi-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, "dcheck_always_on": true, - "enable_backup_ref_ptr_slow_checks": true, - "enable_runtime_backup_ref_ptr_control": true, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, - "never_remove_from_brp_pool_blocklist": true, "proprietary_codecs": true, "symbol_level": 1, "target_cpu": "arm", "target_os": "android", "use_allocator": "partition", - "use_backup_ref_ptr": true, + "use_backup_ref_ptr": false, "use_goma": true } }, @@ -480,18 +495,15 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "dcheck_always_on": true, - "enable_backup_ref_ptr_slow_checks": true, - "enable_runtime_backup_ref_ptr_control": true, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, - "never_remove_from_brp_pool_blocklist": true, "proprietary_codecs": true, "symbol_level": 1, "target_cpu": "arm64", "target_os": "android", "use_allocator": "partition", - "use_backup_ref_ptr": true, + "use_backup_ref_ptr": false, "use_goma": true } }, @@ -534,26 +546,6 @@ "use_static_angle": true } }, - "arm-upload-perfetto": { - "gn_args": { - "dcheck_always_on": false, - "is_component_build": false, - "is_debug": false, - "target_cpu": "arm", - "target_os": "chromeos", - "use_goma": true - } - }, - "arm64-upload-perfetto": { - "gn_args": { - "dcheck_always_on": false, - "is_component_build": false, - "is_debug": false, - "target_cpu": "arm64", - "target_os": "chromeos", - "use_goma": true - } - }, "chromeos-amd64-generic-rel (goma cache silo)": { "args_file": "//build/args/chromeos/amd64-generic.gni", "gn_args": { @@ -570,7 +562,8 @@ "is_chromeos_device": true, "ozone_platform_headless": true, "use_rbe": true, - "use_real_dbus_clients": false + "use_real_dbus_clients": false, + "use_remoteexec": true } }, "chromeos-amd64-generic-rel (reclient)": { @@ -579,7 +572,8 @@ "is_chromeos_device": true, "ozone_platform_headless": true, "use_rbe": true, - "use_real_dbus_clients": false + "use_real_dbus_clients": false, + "use_remoteexec": true } }, "chromeos-amd64-generic-rel-dchecks": { @@ -667,6 +661,20 @@ "use_goma": true } }, + "ios-reclient": { + "gn_args": { + "enable_run_ios_unittests_with_xctest": true, + "ios_set_attributes_for_xcode_project_generation": false, + "is_component_build": false, + "is_debug": true, + "symbol_level": 1, + "target_cpu": "x64", + "target_environment": "simulator", + "target_os": "ios", + "use_rbe": true, + "use_remoteexec": true + } + }, "ios-simulator-code-coverage": { "gn_args": { "enable_run_ios_unittests_with_xctest": true, @@ -767,7 +775,7 @@ "is_component_build": false, "is_debug": true, "symbol_level": 1, - "target_cpu": "x64", + "target_cpu": "arm64", "target_environment": "simulator", "target_os": "ios", "use_goma": true @@ -836,7 +844,8 @@ "is_chromeos_device": true, "ozone_platform_headless": true, "target_os": "chromeos", - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "lacros-amd64-generic-rel-fyi": { @@ -876,15 +885,12 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "dcheck_always_on": true, - "enable_backup_ref_ptr_slow_checks": true, - "enable_runtime_backup_ref_ptr_control": true, "is_component_build": false, "is_debug": false, - "never_remove_from_brp_pool_blocklist": true, "symbol_level": 1, "target_cpu": "x64", "use_allocator": "partition", - "use_backup_ref_ptr": true, + "use_backup_ref_ptr": false, "use_goma": true } }, @@ -1003,6 +1009,19 @@ "use_goma": true } }, + "linux-headless-shell-rel": { + "args_file": "//build/args/headless.gn", + "gn_args": { + "dcheck_always_on": false, + "enable_ffmpeg_video_decoders": false, + "is_component_build": false, + "is_debug": false, + "media_use_ffmpeg": false, + "media_use_libvpx": false, + "proprietary_codecs": false, + "use_goma": true + } + }, "linux-lacros-builder-fyi-rel": { "gn_args": { "also_build_ash_chrome": true, @@ -1033,7 +1052,8 @@ "is_component_build": false, "is_debug": false, "target_os": "chromeos", - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "linux-lacros-code-coverage": { @@ -1146,6 +1166,16 @@ "use_goma": true } }, + "mac-arm64-on-arm64-rel-reclient": { + "gn_args": { + "dcheck_always_on": false, + "is_component_build": false, + "is_debug": false, + "target_cpu": "arm64", + "use_rbe": true, + "use_remoteexec": true + } + }, "mac-code-coverage": { "gn_args": { "dcheck_always_on": false, @@ -1207,15 +1237,12 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "dcheck_always_on": true, - "enable_backup_ref_ptr_slow_checks": true, - "enable_runtime_backup_ref_ptr_control": true, "is_component_build": false, "is_debug": false, - "never_remove_from_brp_pool_blocklist": true, "symbol_level": 1, "target_cpu": "x64", "use_allocator": "partition", - "use_backup_ref_ptr": true, + "use_backup_ref_ptr": false, "use_goma": true } }, @@ -1223,15 +1250,12 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "dcheck_always_on": true, - "enable_backup_ref_ptr_slow_checks": true, - "enable_runtime_backup_ref_ptr_control": true, "is_component_build": false, "is_debug": false, - "never_remove_from_brp_pool_blocklist": true, "symbol_level": 1, "target_cpu": "x86", "use_allocator": "partition", - "use_backup_ref_ptr": true, + "use_backup_ref_ptr": false, "use_goma": true } }, diff --git a/chromium/tools/mb/mb_config_expectations/chromium.gpu.fyi.json b/chromium/tools/mb/mb_config_expectations/chromium.gpu.fyi.json index 140ce4fe9e6..0fbfa6842a8 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.gpu.fyi.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.gpu.fyi.json @@ -196,6 +196,7 @@ "is_component_build": false, "is_debug": false, "ozone_platform": "headless", + "ozone_platform_x11": false, "proprietary_codecs": true, "symbol_level": 1, "use_bundled_weston": true, @@ -207,7 +208,6 @@ "GPU FYI Linux Builder": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -215,6 +215,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -222,13 +223,13 @@ }, "GPU FYI Linux Builder (dbg)": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -247,7 +248,6 @@ "GPU FYI Mac Builder": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -255,6 +255,24 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, + "proprietary_codecs": true, + "symbol_level": 1, + "use_goma": true + } + }, + "GPU FYI Mac Builder (asan)": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "build_angle_trace_perf_tests": true, + "dcheck_always_on": true, + "enable_nacl": false, + "ffmpeg_branding": "Chrome", + "internal_gles2_conform_tests": true, + "is_asan": true, + "is_component_build": false, + "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -262,22 +280,38 @@ }, "GPU FYI Mac Builder (dbg)": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true } }, + "GPU FYI Mac arm64 Builder": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "build_angle_trace_perf_tests": true, + "dcheck_always_on": true, + "enable_nacl": false, + "ffmpeg_branding": "Chrome", + "internal_gles2_conform_tests": true, + "is_component_build": false, + "is_debug": false, + "is_gpu_fyi_bot": true, + "proprietary_codecs": true, + "symbol_level": 1, + "target_cpu": "arm64", + "use_goma": true + } + }, "GPU FYI Win Builder": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -285,6 +319,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "target_cpu": "x86", @@ -294,7 +329,6 @@ "GPU FYI Win x64 Builder": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -302,6 +336,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -309,13 +344,13 @@ }, "GPU FYI Win x64 Builder (dbg)": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -324,7 +359,6 @@ "GPU FYI Win x64 DX12 Vulkan Builder": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -333,6 +367,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -340,7 +375,6 @@ }, "GPU FYI Win x64 DX12 Vulkan Builder (dbg)": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "enable_vulkan": true, @@ -348,6 +382,7 @@ "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -356,7 +391,6 @@ "GPU FYI XR Win x64 Builder": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -364,6 +398,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -372,7 +407,6 @@ "Linux FYI GPU TSAN Release": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -380,6 +414,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "is_tsan": true, "proprietary_codecs": true, "symbol_level": 1, @@ -400,40 +435,6 @@ "use_goma": true } }, - "Mac FYI GPU ASAN Release": { - "gn_args": { - "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, - "build_angle_trace_perf_tests": true, - "dcheck_always_on": true, - "enable_nacl": false, - "ffmpeg_branding": "Chrome", - "internal_gles2_conform_tests": true, - "is_asan": true, - "is_component_build": false, - "is_debug": false, - "proprietary_codecs": true, - "symbol_level": 1, - "use_goma": true - } - }, - "Mac FYI arm64 Release (Apple DTK)": { - "gn_args": { - "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, - "build_angle_trace_perf_tests": true, - "dcheck_always_on": true, - "enable_nacl": false, - "ffmpeg_branding": "Chrome", - "internal_gles2_conform_tests": true, - "is_component_build": false, - "is_debug": false, - "proprietary_codecs": true, - "symbol_level": 1, - "target_cpu": "arm64", - "use_goma": true - } - }, "Optional Android Release (Nexus 5X)": { "gn_args": { "blink_enable_generated_code_formatting": false, diff --git a/chromium/tools/mb/mb_config_expectations/chromium.json b/chromium/tools/mb/mb_config_expectations/chromium.json index 3497b9ed447..a9d8c6abed4 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.json @@ -49,6 +49,12 @@ "use_goma": true } }, + "linux-archive-tagged": { + "gn_args": { + "is_official_build": true, + "use_goma": true + } + }, "linux-official": { "gn_args": { "is_official_build": true, @@ -73,6 +79,12 @@ "use_goma": true } }, + "mac-archive-tagged": { + "gn_args": { + "is_official_build": true, + "use_goma": true + } + }, "mac-arm64-archive-dbg": { "gn_args": { "is_component_build": true, @@ -93,6 +105,13 @@ "use_goma": true } }, + "mac-arm64-archive-tagged": { + "gn_args": { + "is_official_build": true, + "target_cpu": "arm64", + "use_goma": true + } + }, "mac-official": { "gn_args": { "is_official_build": true, @@ -117,6 +136,12 @@ "use_goma": true } }, + "win-archive-tagged": { + "gn_args": { + "is_official_build": true, + "use_goma": true + } + }, "win-official": { "gn_args": { "is_official_build": true, @@ -143,6 +168,13 @@ "use_goma": true } }, + "win32-archive-tagged": { + "gn_args": { + "is_official_build": true, + "target_cpu": "x86", + "use_goma": true + } + }, "win32-official": { "gn_args": { "is_official_build": true, diff --git a/chromium/tools/mb/mb_config_expectations/chromium.linux.json b/chromium/tools/mb/mb_config_expectations/chromium.linux.json index f8d2e9e4f77..1ace04cda15 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.linux.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.linux.json @@ -20,6 +20,17 @@ "use_goma": true } }, + "Cast Linux ARM64": { + "gn_args": { + "dcheck_always_on": false, + "is_chromecast": true, + "is_component_build": false, + "is_debug": false, + "symbol_level": 1, + "target_cpu": "arm64", + "use_goma": true + } + }, "Cast Linux Debug": { "gn_args": { "is_chromecast": true, @@ -97,6 +108,20 @@ "use_goma": true } }, + "Linux Builder (Wayland)": { + "gn_args": { + "dcheck_always_on": false, + "ffmpeg_branding": "Chrome", + "is_component_build": false, + "is_debug": false, + "ozone_auto_platforms": false, + "ozone_platform": "wayland", + "ozone_platform_wayland": true, + "proprietary_codecs": true, + "use_bundled_weston": true, + "use_goma": true + } + }, "Linux Builder (dbg)": { "gn_args": { "ffmpeg_branding": "Chrome", diff --git a/chromium/tools/mb/mb_config_expectations/chromium.perf.calibration.json b/chromium/tools/mb/mb_config_expectations/chromium.perf.calibration.json index be07a918e42..eb302f1e867 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.perf.calibration.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.perf.calibration.json @@ -11,7 +11,8 @@ "symbol_level": 1, "target_cpu": "arm64", "target_os": "android", - "use_goma": true + "use_goma": true, + "use_py3_for_perf": true } }, "linux-perf-calibration": { @@ -22,7 +23,8 @@ "strip_absolute_paths_from_debug_symbols": true, "symbol_level": 1, "use_gnome_keyring": false, - "use_goma": true + "use_goma": true, + "use_py3_for_perf": true } } }
\ No newline at end of file diff --git a/chromium/tools/mb/mb_config_expectations/chromium.reclient.fyi.json b/chromium/tools/mb/mb_config_expectations/chromium.reclient.fyi.json index bc145d71202..400c0404743 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.reclient.fyi.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.reclient.fyi.json @@ -1,22 +1,24 @@ { - "Linux Builder Re-Client Staging": { + "Linux Builder reclient staging": { "gn_args": { "dcheck_always_on": false, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, - "Linux Builder Re-Client Test": { + "Linux Builder reclient test": { "gn_args": { "dcheck_always_on": false, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } } }
\ No newline at end of file diff --git a/chromium/tools/mb/mb_config_expectations/chromium.rust.json b/chromium/tools/mb/mb_config_expectations/chromium.rust.json new file mode 100644 index 00000000000..03820518972 --- /dev/null +++ b/chromium/tools/mb/mb_config_expectations/chromium.rust.json @@ -0,0 +1,29 @@ +{ + "android-rust-arm-rel": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "enable_rust": true, + "ffmpeg_branding": "Chrome", + "is_component_build": false, + "is_debug": false, + "proprietary_codecs": true, + "symbol_level": 1, + "target_cpu": "arm", + "target_os": "android", + "use_goma": true + } + }, + "linux-rust-x64-rel": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "enable_rust": true, + "is_component_build": false, + "is_debug": false, + "symbol_level": 1, + "target_cpu": "x64", + "use_goma": true + } + } +}
\ No newline at end of file diff --git a/chromium/tools/mb/mb_config_expectations/chromium.updater.json b/chromium/tools/mb/mb_config_expectations/chromium.updater.json index b91ccfb7464..8b9437307e3 100644 --- a/chromium/tools/mb/mb_config_expectations/chromium.updater.json +++ b/chromium/tools/mb/mb_config_expectations/chromium.updater.json @@ -1,9 +1,9 @@ { "mac-updater-builder-dbg": { "gn_args": { + "enable_chromium_updater": true, "is_component_build": true, "is_debug": true, - "is_google_branded": true, "symbol_level": 1, "use_goma": true } @@ -11,17 +11,17 @@ "mac-updater-builder-rel": { "gn_args": { "dcheck_always_on": false, + "enable_chromium_updater": true, "is_component_build": false, "is_debug": false, - "is_google_branded": true, "use_goma": true } }, "win-updater-builder-dbg": { "gn_args": { + "enable_chromium_updater": true, "is_component_build": true, "is_debug": true, - "is_google_branded": true, "symbol_level": 1, "use_goma": true } @@ -29,17 +29,17 @@ "win-updater-builder-rel": { "gn_args": { "dcheck_always_on": false, + "enable_chromium_updater": true, "is_component_build": false, "is_debug": false, - "is_google_branded": true, "use_goma": true } }, "win32-updater-builder-dbg": { "gn_args": { + "enable_chromium_updater": true, "is_component_build": true, "is_debug": true, - "is_google_branded": true, "symbol_level": 1, "target_cpu": "x86", "use_goma": true @@ -48,9 +48,9 @@ "win32-updater-builder-rel": { "gn_args": { "dcheck_always_on": false, + "enable_chromium_updater": true, "is_component_build": false, "is_debug": false, - "is_google_branded": true, "target_cpu": "x86", "use_goma": true } diff --git a/chromium/tools/mb/mb_config_expectations/infra.json b/chromium/tools/mb/mb_config_expectations/infra.json index 6196738d370..70eb3c27102 100644 --- a/chromium/tools/mb/mb_config_expectations/infra.json +++ b/chromium/tools/mb/mb_config_expectations/infra.json @@ -7,39 +7,7 @@ "use_goma": true } }, - "linux-component-rel": { - "gn_args": { - "dcheck_always_on": false, - "is_component_build": true, - "is_debug": false, - "use_goma": true - } - }, - "linux-control-rel": { - "gn_args": { - "dcheck_always_on": false, - "is_component_build": false, - "is_debug": false, - "use_goma": true - } - }, - "linux-local-ssd-nvme-rel": { - "gn_args": { - "dcheck_always_on": false, - "is_component_build": false, - "is_debug": false, - "use_goma": true - } - }, - "linux-local-ssd-scsi-rel": { - "gn_args": { - "dcheck_always_on": false, - "is_component_build": false, - "is_debug": false, - "use_goma": true - } - }, - "linux-pd-ssd-rel": { + "win-bootstrap": { "gn_args": { "dcheck_always_on": false, "is_component_build": false, diff --git a/chromium/tools/mb/mb_config_expectations/internal.chrome.fyi.json b/chromium/tools/mb/mb_config_expectations/internal.chrome.fyi.json index 847079eb68b..22a952029e0 100644 --- a/chromium/tools/mb/mb_config_expectations/internal.chrome.fyi.json +++ b/chromium/tools/mb/mb_config_expectations/internal.chrome.fyi.json @@ -21,13 +21,6 @@ "use_goma": true } }, - "linux-chrome-finch-fyi": { - "gn_args": { - "is_chrome_branded": true, - "is_official_build": true, - "use_goma": true - } - }, "linux-password-manager-captured-sites-rel": { "gn_args": { "dcheck_always_on": false, @@ -75,6 +68,13 @@ "use_goma": true } }, + "win-chrome-finch-fyi": { + "gn_args": { + "is_chrome_branded": true, + "is_official_build": true, + "use_goma": true + } + }, "win-password-manager-captured-sites-rel": { "gn_args": { "dcheck_always_on": false, diff --git a/chromium/tools/mb/mb_config_expectations/internal.chromeos.fyi.json b/chromium/tools/mb/mb_config_expectations/internal.chromeos.fyi.json index 875dc7d3650..9d5e742f8e1 100644 --- a/chromium/tools/mb/mb_config_expectations/internal.chromeos.fyi.json +++ b/chromium/tools/mb/mb_config_expectations/internal.chromeos.fyi.json @@ -1,17 +1,4 @@ { - "chromeos-betty-arc-r-chrome": { - "args_file": "//build/args/chromeos/betty-arc-r.gni", - "gn_args": { - "dcheck_always_on": false, - "exclude_unwind_tables": false, - "is_chrome_branded": true, - "is_chromeos_device": true, - "is_official_build": true, - "ozone_platform_headless": true, - "use_goma": true, - "use_real_dbus_clients": false - } - }, "chromeos-betty-pi-arc-chrome-dchecks": { "args_file": "//build/args/chromeos/betty-pi-arc.gni", "gn_args": { @@ -25,18 +12,6 @@ "use_real_dbus_clients": false } }, - "chromeos-eve-arc-r-chrome": { - "args_file": "//build/args/chromeos/eve-arc-r.gni", - "gn_args": { - "dcheck_always_on": false, - "exclude_unwind_tables": false, - "is_chrome_branded": true, - "is_chromeos_device": true, - "is_official_build": true, - "ozone_platform_headless": true, - "use_goma": true - } - }, "lacros-amd64-generic-chrome-fyi": { "args_file": "//build/args/chromeos/amd64-generic-crostoolchain.gni", "gn_args": { diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.blink.json b/chromium/tools/mb/mb_config_expectations/tryserver.blink.json index e8951982516..5d0f36d9410 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.blink.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.blink.json @@ -77,7 +77,7 @@ "use_goma": true } }, - "win10-blink-rel": { + "mac11.0.arm64-blink-rel": { "gn_args": { "dcheck_always_on": false, "ffmpeg_branding": "Chrome", @@ -85,7 +85,7 @@ "is_debug": false, "proprietary_codecs": true, "symbol_level": 1, - "target_cpu": "x86", + "target_cpu": "arm64", "use_goma": true } }, diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chrome.json b/chromium/tools/mb/mb_config_expectations/tryserver.chrome.json index 382514cd16f..2c34bb0f392 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chrome.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chrome.json @@ -146,17 +146,18 @@ "use_thin_lto": true } }, - "lacros-arm-generic-chrome": { - "args_file": "//build/args/chromeos/arm-generic-crostoolchain.gni", + "lacros-amd64-generic-chrome-skylab": { + "args_file": "//build/args/chromeos/amd64-generic-crostoolchain.gni", "gn_args": { "chromeos_is_browser_only": true, "cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot", - "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_i386-sysroot", + "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_amd64-sysroot", "dcheck_always_on": false, "is_cfi": true, "is_chrome_branded": true, "is_chromeos_device": true, "is_official_build": true, + "is_skylab": true, "ozone_platform_headless": true, "symbol_level": 1, "target_os": "chromeos", @@ -164,21 +165,32 @@ "use_thin_lto": true } }, - "linux-chrome": { + "lacros-arm-generic-chrome": { + "args_file": "//build/args/chromeos/arm-generic-crostoolchain.gni", "gn_args": { + "chromeos_is_browser_only": true, + "cros_host_sysroot": "//build/linux/debian_sid_amd64-sysroot", + "cros_v8_snapshot_sysroot": "//build/linux/debian_sid_i386-sysroot", + "dcheck_always_on": false, + "is_cfi": true, "is_chrome_branded": true, + "is_chromeos_device": true, "is_official_build": true, - "use_goma": true + "ozone_platform_headless": true, + "symbol_level": 1, + "target_os": "chromeos", + "use_goma": true, + "use_thin_lto": true } }, - "linux-chrome-beta": { + "linux-chrome": { "gn_args": { "is_chrome_branded": true, "is_official_build": true, "use_goma": true } }, - "linux-chrome-finch-fyi": { + "linux-chrome-beta": { "gn_args": { "is_chrome_branded": true, "is_official_build": true, @@ -252,6 +264,13 @@ "use_goma": true } }, + "win-chrome-finch-fyi": { + "gn_args": { + "is_chrome_branded": true, + "is_official_build": true, + "use_goma": true + } + }, "win-chrome-stable": { "gn_args": { "is_chrome_branded": true, diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.android.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.android.json index b7256500609..7cdef5f3019 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.android.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.android.json @@ -9,7 +9,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -27,7 +27,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -44,8 +44,9 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, + "skip_secondary_abi_for_cq": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x64", "target_os": "android", @@ -78,7 +79,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_os": "android", "use_goma": true } @@ -143,7 +144,7 @@ "media_use_ffmpeg": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "android", "use_crash_key_stubs": true, @@ -172,7 +173,7 @@ "is_component_build": false, "is_debug": false, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_os": "android", "use_goma": true } @@ -188,7 +189,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -196,34 +197,39 @@ "use_goma": true } }, - "android-lollipop-arm-rel": { + "android-marshmallow-arm64-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, + "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, + "disable_android_lint": true, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, - "is_java_debug": true, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", + "target_cpu": "arm64", "target_os": "android", - "use_goma": true + "use_errorprone_java_compiler": false, + "use_goma": true, + "use_jacoco_coverage": true, + "use_static_angle": true } }, - "android-marshmallow-arm64-rel": { + "android-marshmallow-arm64-rel-rts": { "gn_args": { "blink_enable_generated_code_formatting": false, "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, "disable_android_lint": true, - "enable_resource_allowlist_generation": true, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "strip_debug_info": true, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -236,6 +242,7 @@ "android-marshmallow-x86-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, + "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, "disable_android_lint": true, "enable_resource_allowlist_generation": true, @@ -248,7 +255,8 @@ "target_cpu": "x86", "target_os": "android", "use_errorprone_java_compiler": false, - "use_goma": true + "use_goma": true, + "use_jacoco_coverage": true } }, "android-marshmallow-x86-rel-non-cq": { @@ -261,7 +269,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -269,9 +277,10 @@ "use_goma": true } }, - "android-marshmallow-x86-rel-rts": { + "android-marshmallow-x86-rel-orchestrator": { "gn_args": { "blink_enable_generated_code_formatting": false, + "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, "disable_android_lint": true, "enable_resource_allowlist_generation": true, @@ -284,6 +293,25 @@ "target_cpu": "x86", "target_os": "android", "use_errorprone_java_compiler": false, + "use_goma": true, + "use_jacoco_coverage": true + } + }, + "android-marshmallow-x86-rel-rts": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "disable_android_lint": true, + "enable_resource_allowlist_generation": true, + "ffmpeg_branding": "Chrome", + "is_component_build": false, + "is_debug": false, + "proprietary_codecs": true, + "symbol_level": 0, + "system_webview_package_name": "com.google.android.webview", + "target_cpu": "x86", + "target_os": "android", + "use_errorprone_java_compiler": false, "use_goma": true } }, @@ -297,7 +325,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -314,7 +342,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_os": "android", "use_goma": true } @@ -354,7 +382,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -372,7 +400,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -404,7 +432,27 @@ "proprietary_codecs": true, "skip_secondary_abi_for_cq": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, + "system_webview_package_name": "com.google.android.webview", + "target_cpu": "arm64", + "target_os": "android", + "use_errorprone_java_compiler": false, + "use_goma": true + } + }, + "android-pie-arm64-rel-rts": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "disable_android_lint": true, + "fail_on_android_expectations": true, + "ffmpeg_branding": "Chrome", + "is_component_build": false, + "is_debug": false, + "proprietary_codecs": true, + "skip_secondary_abi_for_cq": true, + "strip_debug_info": true, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -421,7 +469,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -438,7 +486,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -456,7 +504,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -512,7 +560,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -548,7 +596,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -566,7 +614,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "x86", "target_os": "android", @@ -583,7 +631,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -599,7 +647,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -615,7 +663,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -631,7 +679,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -647,7 +695,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "system_webview_package_name": "com.google.android.webview", "target_cpu": "arm64", "target_os": "android", @@ -681,7 +729,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_os": "android", "use_goma": true } @@ -709,7 +757,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_os": "android", "use_goma": true } @@ -811,7 +859,7 @@ "is_debug": false, "media_use_ffmpeg": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm", "target_os": "android", "use_crash_key_stubs": true, @@ -831,7 +879,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "android", "use_goma": true diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.angle.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.angle.json index f545c7a90d4..823705b6508 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.angle.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.angle.json @@ -8,7 +8,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "android", "use_errorprone_java_compiler": false, @@ -19,11 +19,10 @@ "android-angle-try": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "dcheck_always_on": true, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "android", "use_goma": true @@ -58,23 +57,9 @@ "use_static_angle": true } }, - "angle-try-mac-amd-exp": { - "gn_args": { - "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, - "build_angle_trace_perf_tests": true, - "dcheck_always_on": true, - "enable_nacl": false, - "is_component_build": true, - "is_debug": false, - "symbol_level": 1, - "use_goma": true - } - }, "fuchsia-angle-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -82,6 +67,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "target_os": "fuchsia", @@ -91,13 +77,12 @@ "fuchsia-angle-try": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_os": "fuchsia", "use_goma": true } @@ -106,7 +91,6 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -114,7 +98,7 @@ "ios_set_attributes_for_xcode_project_generation": false, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x64", "target_environment": "simulator", "target_os": "ios", @@ -129,14 +113,13 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, "linux-angle-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -144,6 +127,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -152,13 +136,12 @@ "linux-angle-try": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -180,20 +163,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, - "use_goma": true - } - }, - "mac-angle-try": { - "gn_args": { - "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, - "build_angle_trace_perf_tests": true, - "dcheck_always_on": true, - "enable_nacl": false, - "is_component_build": true, - "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -205,7 +175,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -217,7 +187,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -225,26 +195,24 @@ "win-angle-x64-try": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, "win-angle-x86-try": { "gn_args": { "build_angle_deqp_tests": true, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.chromiumos.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.chromiumos.json index f7c6d2f8788..13849471f2d 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.chromiumos.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.chromiumos.json @@ -22,7 +22,7 @@ } }, "chromeos-amd64-generic-rel": { - "args_file": "//build/args/chromeos/amd64-generic.gni", + "args_file": "//build/args/chromeos/amd64-generic-vm.gni", "gn_args": { "dcheck_always_on": false, "is_chromeos_device": true, @@ -153,7 +153,7 @@ "is_cfm": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_os": "chromeos", "use_goma": true } @@ -213,6 +213,7 @@ }, "linux-chromeos-rel": { "gn_args": { + "also_build_lacros_chrome": true, "blink_enable_generated_code_formatting": false, "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, @@ -238,5 +239,18 @@ "target_os": "chromeos", "use_goma": true } + }, + "linux-lacros-rel-rts": { + "gn_args": { + "also_build_ash_chrome": true, + "blink_enable_generated_code_formatting": false, + "chromeos_is_browser_only": true, + "dcheck_always_on": true, + "is_component_build": false, + "is_debug": false, + "symbol_level": 0, + "target_os": "chromeos", + "use_goma": true + } } }
\ No newline at end of file diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.dawn.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.dawn.json index 95b3f5de64c..6c541d53117 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.dawn.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.dawn.json @@ -19,7 +19,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_dawn": true, "use_goma": true } @@ -31,7 +31,19 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, + "use_dawn": true, + "use_goma": true + } + }, + "dawn-try-mac-intel-exp": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dawn_enable_opengles": true, + "dcheck_always_on": true, + "is_component_build": false, + "is_debug": false, + "symbol_level": 0, "use_dawn": true, "use_goma": true } @@ -44,7 +56,7 @@ "is_asan": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_dawn": true, "use_goma": true } @@ -56,7 +68,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_dawn": true, "use_goma": true @@ -69,7 +81,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_dawn": true, "use_goma": true } @@ -81,7 +93,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_dawn": true, "use_goma": true @@ -107,7 +119,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_dawn": true, "use_goma": true } @@ -119,7 +131,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_dawn": true, "use_goma": true } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.linux.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.linux.json index 8a73926d2ce..cb296b24d81 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.linux.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.linux.json @@ -17,7 +17,7 @@ "is_chromecast": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -28,7 +28,18 @@ "is_chromecast": true, "is_component_build": false, "is_debug": false, + "symbol_level": 0, + "use_goma": true + } + }, + "cast_shell_linux_arm64": { + "gn_args": { + "dcheck_always_on": false, + "is_chromecast": true, + "is_component_build": false, + "is_debug": false, "symbol_level": 1, + "target_cpu": "arm64", "use_goma": true } }, @@ -48,7 +59,7 @@ "is_chromecast": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "fuchsia", "use_goma": true @@ -88,7 +99,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "fuchsia", "use_goma": true @@ -100,7 +111,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "fuchsia", "use_goma": true @@ -121,7 +132,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_os": "fuchsia", "use_goma": true } @@ -133,7 +144,7 @@ "is_chromecast": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_os": "fuchsia", "use_goma": true } @@ -144,7 +155,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "target_os": "fuchsia", "use_goma": true @@ -156,7 +167,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_os": "fuchsia", "use_goma": true } @@ -167,7 +178,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_os": "fuchsia", "use_goma": true } @@ -180,6 +191,7 @@ "is_component_build": false, "is_debug": false, "ozone_platform": "headless", + "ozone_platform_x11": false, "proprietary_codecs": true, "symbol_level": 1, "use_bundled_weston": true, @@ -196,6 +208,7 @@ "is_component_build": false, "is_debug": false, "ozone_platform": "headless", + "ozone_platform_x11": false, "proprietary_codecs": true, "symbol_level": 1, "use_bundled_weston": true, @@ -207,7 +220,6 @@ "gpu-fyi-try-linux-amd-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -215,6 +227,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -233,7 +246,6 @@ "gpu-fyi-try-linux-intel-exp": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -241,6 +253,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -249,7 +262,6 @@ "gpu-fyi-try-linux-intel-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -257,6 +269,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -279,7 +292,6 @@ "gpu-fyi-try-linux-intel-skv": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -287,6 +299,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -294,13 +307,13 @@ }, "gpu-fyi-try-linux-nvidia-dbg": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -319,7 +332,6 @@ "gpu-fyi-try-linux-nvidia-exp": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -327,6 +339,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -335,7 +348,6 @@ "gpu-fyi-try-linux-nvidia-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -343,6 +355,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -351,7 +364,6 @@ "gpu-fyi-try-linux-nvidia-skv": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -359,6 +371,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -367,7 +380,6 @@ "gpu-fyi-try-linux-nvidia-tsn": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -375,6 +387,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "is_tsan": true, "proprietary_codecs": true, "symbol_level": 1, @@ -399,7 +412,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -409,7 +422,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -419,7 +432,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -429,7 +442,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -439,7 +452,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -450,7 +463,7 @@ "enable_autofill_assistant_api": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -484,7 +497,7 @@ "is_component_build": false, "is_debug": false, "is_tsan": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -518,7 +531,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -536,7 +549,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -546,7 +559,7 @@ "dcheck_always_on": false, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -556,7 +569,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -567,7 +580,7 @@ "extended_tracing_enabled": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -626,7 +639,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -643,7 +656,7 @@ "optimize_for_fuzzing": true, "pdf_enable_xfa": true, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true, "use_libfuzzer": true } @@ -657,7 +670,7 @@ "is_debug": false, "mbi_mode": "per_render_process_host", "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -670,7 +683,7 @@ "is_debug": false, "mbi_mode": "per_site_instance", "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -693,7 +706,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true, "use_perfetto_client_library": true } @@ -716,12 +729,14 @@ "linux-rel-orchestrator": { "gn_args": { "blink_enable_generated_code_formatting": false, + "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, "symbol_level": 0, + "use_clang_coverage": true, "use_dummy_lastchange": true, "use_goma": true } @@ -738,7 +753,8 @@ "symbol_level": 0, "use_clang_coverage": true, "use_dummy_lastchange": true, - "use_rbe": true + "use_rbe": true, + "use_remoteexec": true } }, "linux-rel-rts": { @@ -775,7 +791,24 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, + "use_goma": true + } + }, + "linux-wayland-rel": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "ffmpeg_branding": "Chrome", + "is_component_build": false, + "is_debug": false, + "ozone_auto_platforms": false, + "ozone_platform": "wayland", + "ozone_platform_wayland": true, + "proprietary_codecs": true, + "symbol_level": 0, + "use_bundled_weston": true, + "use_dummy_lastchange": true, "use_goma": true } }, @@ -795,7 +828,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -805,7 +838,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -815,7 +848,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -852,6 +885,18 @@ "use_goma": true } }, + "linux_chromium_asan_rel_ng_rts": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "is_asan": true, + "is_component_build": false, + "is_debug": false, + "is_lsan": true, + "symbol_level": 1, + "use_goma": true + } + }, "linux_chromium_cfi_rel_ng": { "gn_args": { "dcheck_always_on": true, @@ -873,7 +918,7 @@ "is_component_build": false, "is_debug": false, "is_lsan": true, - "symbol_level": 1, + "symbol_level": 0, "target_os": "chromeos", "use_goma": true } @@ -895,7 +940,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -905,7 +950,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -932,7 +977,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -968,6 +1013,18 @@ "use_goma": true } }, + "linux_chromium_tsan_rel_ng_rts": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "enable_nacl": false, + "is_component_build": false, + "is_debug": false, + "is_tsan": true, + "symbol_level": 1, + "use_goma": true + } + }, "linux_chromium_ubsan_rel_ng": { "gn_args": { "dcheck_always_on": false, @@ -986,7 +1043,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -996,7 +1053,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -1006,7 +1063,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -1026,7 +1083,6 @@ "linux_optional_gpu_tests_rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -1034,6 +1090,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -1054,7 +1111,7 @@ "enable_vr": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true, "use_ozone": true } @@ -1065,7 +1122,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.mac.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.mac.json index d48b048802d..4feb019c40b 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.mac.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.mac.json @@ -2,7 +2,6 @@ "gpu-fyi-try-mac-amd-pro-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -10,6 +9,24 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, + "proprietary_codecs": true, + "symbol_level": 1, + "use_goma": true + } + }, + "gpu-fyi-try-mac-amd-retina-asan": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "build_angle_trace_perf_tests": true, + "dcheck_always_on": true, + "enable_nacl": false, + "ffmpeg_branding": "Chrome", + "internal_gles2_conform_tests": true, + "is_asan": true, + "is_component_build": false, + "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -17,13 +34,13 @@ }, "gpu-fyi-try-mac-amd-retina-dbg": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -32,7 +49,6 @@ "gpu-fyi-try-mac-amd-retina-exp": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -40,6 +56,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -48,7 +65,6 @@ "gpu-fyi-try-mac-amd-retina-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -56,15 +72,15 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true } }, - "gpu-fyi-try-mac-arm64-apple-dtk-rel": { + "gpu-fyi-try-mac-arm64-apple-m1-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -72,16 +88,16 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "target_cpu": "arm64", "use_goma": true } }, - "gpu-fyi-try-mac-asan": { + "gpu-fyi-try-mac-intel-asan": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -90,6 +106,7 @@ "is_asan": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -97,13 +114,13 @@ }, "gpu-fyi-try-mac-intel-dbg": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -112,7 +129,6 @@ "gpu-fyi-try-mac-intel-exp": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -120,6 +136,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -128,7 +145,6 @@ "gpu-fyi-try-mac-intel-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -136,6 +152,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -144,7 +161,6 @@ "gpu-fyi-try-mac-intel-uhd-630-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -152,6 +168,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -159,13 +176,13 @@ }, "gpu-fyi-try-mac-nvidia-retina-dbg": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -174,7 +191,6 @@ "gpu-fyi-try-mac-nvidia-retina-exp": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -182,6 +198,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -190,7 +207,6 @@ "gpu-fyi-try-mac-nvidia-retina-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -198,6 +214,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -384,7 +401,7 @@ "is_component_build": false, "is_debug": true, "symbol_level": 1, - "target_cpu": "x64", + "target_cpu": "arm64", "target_environment": "simulator", "target_os": "ios", "use_goma": true @@ -425,7 +442,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -437,19 +454,21 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, "mac-rel": { "gn_args": { "blink_enable_generated_code_formatting": false, + "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, "ffmpeg_branding": "Chrome", "is_component_build": false, "is_debug": false, "proprietary_codecs": true, "symbol_level": 0, + "use_clang_coverage": true, "use_goma": true } }, @@ -471,7 +490,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "arm64", "use_goma": true } @@ -484,7 +503,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -496,7 +515,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -506,7 +525,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -516,7 +535,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -527,7 +546,7 @@ "enable_nacl": false, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -537,7 +556,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -579,7 +598,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -596,7 +615,6 @@ "mac_optional_gpu_tests_rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -604,6 +622,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.rust.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.rust.json new file mode 100644 index 00000000000..03820518972 --- /dev/null +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.rust.json @@ -0,0 +1,29 @@ +{ + "android-rust-arm-rel": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "enable_rust": true, + "ffmpeg_branding": "Chrome", + "is_component_build": false, + "is_debug": false, + "proprietary_codecs": true, + "symbol_level": 1, + "target_cpu": "arm", + "target_os": "android", + "use_goma": true + } + }, + "linux-rust-x64-rel": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "enable_rust": true, + "is_component_build": false, + "is_debug": false, + "symbol_level": 1, + "target_cpu": "x64", + "use_goma": true + } + } +}
\ No newline at end of file diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.swangle.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.swangle.json index 9d316cbd380..1a94a338f51 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.swangle.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.swangle.json @@ -7,7 +7,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -49,7 +49,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -62,7 +62,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -83,7 +83,7 @@ "dcheck_always_on": true, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -104,7 +104,7 @@ "dcheck_always_on": true, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -125,7 +125,7 @@ "dcheck_always_on": true, "is_component_build": true, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.updater.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.updater.json index 1d29508bb49..f31a411d66b 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.updater.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.updater.json @@ -1,9 +1,9 @@ { "mac-updater-try-builder-dbg": { "gn_args": { + "enable_chromium_updater": true, "is_component_build": true, "is_debug": true, - "is_google_branded": true, "symbol_level": 1, "use_goma": true } @@ -12,18 +12,18 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "dcheck_always_on": true, + "enable_chromium_updater": true, "is_component_build": false, "is_debug": false, - "is_google_branded": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, "win-updater-try-builder-dbg": { "gn_args": { + "enable_chromium_updater": true, "is_component_build": true, "is_debug": true, - "is_google_branded": true, "symbol_level": 1, "use_goma": true } @@ -32,10 +32,10 @@ "gn_args": { "blink_enable_generated_code_formatting": false, "dcheck_always_on": true, + "enable_chromium_updater": true, "is_component_build": false, "is_debug": false, - "is_google_branded": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.win.json b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.win.json index 87829e8690e..cfaa268bd49 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.chromium.win.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.chromium.win.json @@ -2,7 +2,6 @@ "gpu-fyi-try-win10-amd-rel-64": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -10,6 +9,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -18,7 +18,6 @@ "gpu-fyi-try-win10-intel-exp-64": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -26,6 +25,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -34,7 +34,6 @@ "gpu-fyi-try-win10-intel-rel-64": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -42,6 +41,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -49,13 +49,13 @@ }, "gpu-fyi-try-win10-nvidia-dbg-64": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "ffmpeg_branding": "Chrome", "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -63,7 +63,6 @@ }, "gpu-fyi-try-win10-nvidia-dx12vk-dbg-64": { "gn_args": { - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "enable_nacl": false, "enable_vulkan": true, @@ -71,6 +70,7 @@ "internal_gles2_conform_tests": true, "is_component_build": true, "is_debug": true, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -79,7 +79,6 @@ "gpu-fyi-try-win10-nvidia-dx12vk-rel-64": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -88,6 +87,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -96,7 +96,6 @@ "gpu-fyi-try-win10-nvidia-exp-64": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -104,6 +103,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -112,7 +112,6 @@ "gpu-fyi-try-win10-nvidia-rel-32": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -120,6 +119,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "target_cpu": "x86", @@ -129,7 +129,6 @@ "gpu-fyi-try-win10-nvidia-rel-64": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -137,6 +136,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -159,7 +159,6 @@ "gpu-fyi-try-win7-amd-rel-32": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -167,6 +166,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "target_cpu": "x86", @@ -176,7 +176,6 @@ "gpu-fyi-try-win7-nvidia-rel-32": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -184,6 +183,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "target_cpu": "x86", @@ -193,7 +193,6 @@ "gpu-fyi-try-win7-nvidia-rel-64": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -201,6 +200,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -212,7 +212,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -258,6 +258,7 @@ "win10-rel-orchestrator": { "gn_args": { "blink_enable_generated_code_formatting": false, + "coverage_instrumentation_input_file": "//.code-coverage/files_to_instrument.txt", "dcheck_always_on": true, "enable_resource_allowlist_generation": false, "ffmpeg_branding": "Chrome", @@ -265,6 +266,7 @@ "is_debug": false, "proprietary_codecs": true, "symbol_level": 0, + "use_clang_coverage": true, "use_goma": true } }, @@ -278,7 +280,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -328,7 +330,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -356,7 +358,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -367,7 +369,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -392,7 +394,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -416,7 +418,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -426,7 +428,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "target_cpu": "x86", "use_goma": true } @@ -434,7 +436,6 @@ "win_optional_gpu_tests_rel": { "gn_args": { "blink_enable_generated_code_formatting": false, - "build_angle_gles1_conform_tests": true, "build_angle_trace_perf_tests": true, "dcheck_always_on": true, "enable_nacl": false, @@ -442,6 +443,7 @@ "internal_gles2_conform_tests": true, "is_component_build": false, "is_debug": false, + "is_gpu_fyi_bot": true, "proprietary_codecs": true, "symbol_level": 1, "use_goma": true @@ -461,7 +463,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.infra.json b/chromium/tools/mb/mb_config_expectations/tryserver.infra.json index 193bf3c11a9..ab3155bbfbd 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.infra.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.infra.json @@ -5,7 +5,17 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, + "use_goma": true + } + }, + "win-bootstrap": { + "gn_args": { + "blink_enable_generated_code_formatting": false, + "dcheck_always_on": true, + "is_component_build": false, + "is_debug": false, + "symbol_level": 0, "use_goma": true } } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.v8.json b/chromium/tools/mb/mb_config_expectations/tryserver.v8.json index 9022ba48a0d..c6dd40f370f 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.v8.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.v8.json @@ -16,7 +16,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } } diff --git a/chromium/tools/mb/mb_config_expectations/tryserver.webrtc.json b/chromium/tools/mb/mb_config_expectations/tryserver.webrtc.json index 124be0e6f8e..4649a1050ac 100644 --- a/chromium/tools/mb/mb_config_expectations/tryserver.webrtc.json +++ b/chromium/tools/mb/mb_config_expectations/tryserver.webrtc.json @@ -8,7 +8,7 @@ "is_debug": false, "proprietary_codecs": true, "strip_debug_info": true, - "symbol_level": 1, + "symbol_level": 0, "target_os": "android", "use_goma": true } @@ -19,7 +19,7 @@ "dcheck_always_on": true, "is_component_build": false, "is_debug": false, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -39,7 +39,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, @@ -52,7 +52,7 @@ "is_component_build": false, "is_debug": false, "proprietary_codecs": true, - "symbol_level": 1, + "symbol_level": 0, "use_goma": true } }, diff --git a/chromium/tools/memory/partition_allocator/BUILD.gn b/chromium/tools/memory/partition_allocator/BUILD.gn new file mode 100644 index 00000000000..d054cac6f0d --- /dev/null +++ b/chromium/tools/memory/partition_allocator/BUILD.gn @@ -0,0 +1,18 @@ +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +_tcache_tool_supported = target_cpu == "x64" && target_os == "linux" + +if (_tcache_tool_supported) { + executable("pa_tcache_inspect") { + sources = [ "pa_tcache_inspect.cc" ] + deps = [ "//base" ] + } +} + +group("all") { + if (_tcache_tool_supported) { + deps = [ ":pa_tcache_inspect" ] + } +} diff --git a/chromium/tools/memory/partition_allocator/README.md b/chromium/tools/memory/partition_allocator/README.md new file mode 100644 index 00000000000..11b005815a6 --- /dev/null +++ b/chromium/tools/memory/partition_allocator/README.md @@ -0,0 +1,23 @@ +# PartitionAlloc tools + +This directory contains tools useful to inspect, debug and optimize +PartitionAlloc. In particular, `pa_tcache_inspect` is used to inspect a running +Chrome instance, and report statistics on its thread caches. + +## `pa_tcache_inspect` + +This tool displays data about any running Chrome process. The main constraint is +that both the tool and the running instance have to be built at revisions where +the allocator's layout is identical. For best results, it should be the same +revision whenever possible. + +It works by first identifying the address of the thread cache registry, then use +it to find out all other data structures. They are then read from the remote +process, and displayed live. + +The tool must be able to read the remote process memory, which on some Debian +configurations requires running: + +``` +sudo sh -c 'echo 0 > /proc/sys/kernel/yama/ptrace_scope +``` diff --git a/chromium/tools/memory/partition_allocator/compute_external_fragmentation.py b/chromium/tools/memory/partition_allocator/compute_external_fragmentation.py new file mode 100755 index 00000000000..1fea8478b8c --- /dev/null +++ b/chromium/tools/memory/partition_allocator/compute_external_fragmentation.py @@ -0,0 +1,127 @@ +#!/usr/bin/python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""Parses allocation profiles from a trace and computes the external +fragmentation from PartitionAlloc + +We compute this as the difference between the memory allocated and the total +amount of memory used by the allocator. (For example, a bucket may have empty +slot spans, in which case PartitionAlloc is using more memory it has +allocated.) + +The output of this script is two sets of graphs. The first shows external +fragmentation (as a percentage) for each bucket. The second shows the actual +amount of memory wasted due to external fragmentation for each bucket. + +See: trace_utils.py for details on collecting a trace. +""" + +import argparse +import logging +import os +import re + +from matplotlib import pylab as plt +import numpy as np + +import trace_utils + + +def _SummarizeStatsForAllocators(result_for_pid: dict, allocators: dict): + """We compute the wasted memory here by taking the difference of + 'allocated_objects_size' and 'size'. See + MemoryDumpPartitionStatsDumper::PartitionDumpTotals in chrome for details on + where these are collected. + """ + size_counts = [] + # We are only interested in the main malloc partition, reported in + # |ReportPartitionAllocStats|. + pattern = re.compile("malloc/partitions/allocator/buckets/bucket_\d+") + for entry in allocators: + # |entry| can represent a subset of the allocations for a given allocator. + if (not pattern.match(entry)): + continue + attrs = allocators[entry]['attrs'] + + allocated_objects_size = trace_utils.GetAllocatorAttr( + attrs, 'allocated_objects_size') + slot_size = trace_utils.GetAllocatorAttr(attrs, 'slot_size') + try: + # 'size' is only available in the dump if 'allocated_objects_size' is + # non-zero. + size = trace_utils.GetAllocatorAttr(attrs, 'size') + fragmentation = 1 - allocated_objects_size / size + except KeyError: + assert allocated_objects_size == 0 + size = 0 + fragmentation = 0 + assert allocated_objects_size <= size + + size_counts.append( + (slot_size, 100 * fragmentation, size - allocated_objects_size)) + size_counts.sort() + result_for_pid['data'] = np.array(size_counts, + dtype=[('size', np.int), + ('fragmentation', np.int), + ('unused', np.int)]) + + +def _PlotProcess(all_data: dict, pid: int, output_prefix: str): + """Represents the allocation size distribution. + + Args: + all_data: As returned by _ParseTrace(). + pid: PID to plot the data for. + output_prefix: Prefix of the output file. + """ + data = all_data[pid] + logging.info('Plotting data for PID %d' % pid) + + fragmentation_title = ('External Fragmentation (%%) vs Size - %s - %s' % + (data['name'], data['labels'])) + fragmentation_output = ('%s_%s_fragmentation.png' % (output_prefix, pid)) + trace_utils.PlotProcessFragmentation(fragmentation_title, data, + fragmentation_output) + + unused_title = ('External Unused Memory vs Size - %s - %s' % + (data['name'], data['labels'])) + unused_output = ('%s_%d_unused.png' % (output_prefix, pid)) + trace_utils.PlotProcessWaste(unused_title, data, unused_output) + + +def _CreateArgumentParser(): + parser = argparse.ArgumentParser() + parser.add_argument( + '--trace', + type=str, + required=True, + help='Path to a trace.json[.gz] with memory-infra enabled.') + parser.add_argument('--output-dir', + type=str, + required=True, + help='Output directory for graphs.') + return parser + + +def main(): + logging.basicConfig(level=logging.INFO) + parser = _CreateArgumentParser() + args = parser.parse_args() + + logging.info('Loading the trace') + trace = trace_utils.LoadTrace(args.trace) + + logging.info('Parsing the trace') + stats_per_process = trace_utils.ParseTrace(trace, + _SummarizeStatsForAllocators) + + logging.info('Plotting the results') + for pid in stats_per_process: + if 'data' in stats_per_process[pid]: + _PlotProcess(stats_per_process, pid, + os.path.join(args.output_dir, 'external')) + + +if __name__ == '__main__': + main() diff --git a/chromium/tools/memory/partition_allocator/compute_internal_fragmentation.py b/chromium/tools/memory/partition_allocator/compute_internal_fragmentation.py new file mode 100755 index 00000000000..8ca3dd74168 --- /dev/null +++ b/chromium/tools/memory/partition_allocator/compute_internal_fragmentation.py @@ -0,0 +1,207 @@ +#!/usr/bin/python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""Parses allocation profiles from a trace and computes the internal +fragmentation from PartitionAlloc, given a list of buckets. + +We compute this as the difference in memory usage between the given trace, and +that same trace if we were to only allocate memory into one of the given +buckets. This provides a rough estimate of the increased memory usage given +a specific bucket mapping. We probably underestimate the increase here, as this +script only considers surviving allocations. + +NOTE: Buckets (given with --buckets flag) should be a subset of the buckets in +Chrome when the trace was recorded. To see why, say we have a request size of +999B, and the next bucket in Chrome is 1024B. The 999B allocation will be +recorded in the trace as 1024B (since we don't record the requested size in +most cases, just the allocated size). Say our buckets (from --buckets flag) +have a 1000B bucket. Our 999B allocation would have gone there, if we were +actually using that bucket mapping in Chrome, which would have reduced +fragmentation. However, this script would round this upwards, based on the +1024B size, and tell us we increased fragmentation instead. + +This script outputs two sets of graphs. The first shows the increase in memory +usage that would occur for each bucket, using the given bucket mapping, in +percent. The second shows the increase in memory (in bytes) that would occur +from using the given bucket mapping compared with the one from the trace. + +See: trace_utils.py for details on collecting a trace. +""" + +import argparse +import logging +import os +import re + +from matplotlib import pylab as plt +import numpy as np + +import trace_utils + + +def _LoadBuckets(filename: str) -> list[int]: + """Loads a list of bucket sizes from a file. The file should contain + integers, in Newline Separated Value format. + + Args: + filename: Filename. + + Returns: + A sorted list of bucket sizes to use. + """ + try: + f = open(filename, 'r') + buckets = [int(line) for line in f.readlines()] + finally: + if f is not None: + f.close() + + buckets.sort() + return buckets + + +def _RoundUpToNearestBucket(buckets: list[int], size: int) -> int: + """Rounds a size up to the nearest bucket. + + Args: + buckets: Sorted list of bucket sizes. + size: The size to round upwards. + + Returns: + The closest bucket size to |size|, rounding upwards. + """ + curr = None + for bucket_size in buckets: + curr = bucket_size + if size <= bucket_size: + break + assert curr is not None + return curr + + +def _SummarizeStatsForAllocators(result_for_pid: dict, allocators: dict, + buckets: list[int]): + """We compute the wasted memory here by taking the 'allocated_objects_size' + and rounding it up to nearest bucket (in |buckets|), and comparing the two. + """ + size_counts = [] + total_allocated_size = 0 + rounded_allocated_size = 0 + # We are only interested in the main malloc partition, reported in + # |ReportPartitionAllocStats|. + pattern = re.compile("malloc/partitions/allocator/buckets/bucket_\d+") + for entry in allocators: + # |entry| can represent a subset of the allocations for a given allocator. + if (not pattern.match(entry)): + continue + attrs = allocators[entry]['attrs'] + + allocated_objects_size = trace_utils.GetAllocatorAttr( + attrs, 'allocated_objects_size') + slot_size = trace_utils.GetAllocatorAttr(attrs, 'slot_size') + if allocated_objects_size != 0: + # See: |CanStoreRawSize| in + # base/allocator/partition_allocator/partition_bucket.h + # The single slot span size below assumes we have 4 KiB pages. + if slot_size >= 0xE0000: # Direct Mapped, so not affected by bucket size + rounded_allocated_objects_size = allocated_objects_size + elif slot_size >= 4 << 14: # Single slot span + # We care about the increase in all memory here, not just the increase + # in allocated size. To deal with this, we round up the + # allocated_objects_size. + allocated_objects_size = slot_size + rounded_allocated_objects_size = _RoundUpToNearestBucket( + buckets, slot_size) + else: + bucket_size = _RoundUpToNearestBucket(buckets, slot_size) + rounded_allocated_objects_size = (allocated_objects_size / + slot_size) * bucket_size + assert bucket_size in buckets + assert slot_size <= bucket_size + fragmentation = (1 - + allocated_objects_size / rounded_allocated_objects_size) + total_allocated_size += allocated_objects_size + rounded_allocated_size += rounded_allocated_objects_size + else: + bucket_size = 0 + rounded_allocated_objects_size = 0 + fragmentation = 0 + + size_counts.append( + (slot_size, fragmentation * 100, + rounded_allocated_objects_size - allocated_objects_size)) + size_counts.sort() + result_for_pid['regression'] = (rounded_allocated_size - total_allocated_size + ) * 100 / total_allocated_size + result_for_pid['data'] = np.array(size_counts, + dtype=[('size', np.int), + ('fragmentation', np.int), + ('unused', np.int)]) + + +def _PlotProcess(all_data: dict, pid: int, output_prefix: str): + """Represents the allocation size distribution. + + Args: + all_data: As returned by _ParseTrace(). + pid: PID to plot the data for. + output_prefix: Prefix of the output file. + """ + data = all_data[pid] + logging.info('Plotting data for PID %d' % pid) + + fragmentation_title = ('Internal Fragmentation (%%) vs Size - %s - %s' % + (data['name'], data['labels'])) + fragmentation_output = ('%s_%s_fragmentation.png' % (output_prefix, pid)) + trace_utils.PlotProcessFragmentation(fragmentation_title, data, + fragmentation_output) + + unused_title = ( + 'Internal Unused Memory vs Size - %s - %s (%.2f%% Regression)' % + (data['name'], data['labels'], data['regression'])) + unused_output = ('%s_%d_unused.png' % (output_prefix, pid)) + trace_utils.PlotProcessWaste(unused_title, data, unused_output) + + +def _CreateArgumentParser(): + parser = argparse.ArgumentParser() + parser.add_argument( + '--trace', + type=str, + required=True, + help='Path to a trace.json[.gz] with memory-infra enabled.') + parser.add_argument('--output-dir', + type=str, + required=True, + help='Output directory for graphs.') + parser.add_argument('--buckets', + type=str, + required=True, + help='Path to file containing bucket sizes.') + return parser + + +def main(): + logging.basicConfig(level=logging.INFO) + parser = _CreateArgumentParser() + args = parser.parse_args() + + logging.info('Loading the trace') + trace = trace_utils.LoadTrace(args.trace) + buckets = _LoadBuckets(args.buckets) + + logging.info('Parsing the trace') + stats_per_process = trace_utils.ParseTrace( + trace, (lambda result_for_pid, allocators: _SummarizeStatsForAllocators( + result_for_pid, allocators, buckets))) + + logging.info('Plotting the results') + for pid in stats_per_process: + if 'data' in stats_per_process[pid]: + _PlotProcess(stats_per_process, pid, + os.path.join(args.output_dir, 'internal')) + + +if __name__ == '__main__': + main() diff --git a/chromium/tools/memory/partition_allocator/pa_tcache_inspect.cc b/chromium/tools/memory/partition_allocator/pa_tcache_inspect.cc new file mode 100644 index 00000000000..de978643fe2 --- /dev/null +++ b/chromium/tools/memory/partition_allocator/pa_tcache_inspect.cc @@ -0,0 +1,582 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// Connects to a running Chrome process, and outputs statistics about its thread +// caches. + +#include <fcntl.h> +#include <signal.h> +#include <sys/stat.h> +#include <sys/types.h> +#include <unistd.h> +#include <algorithm> +#include <cstring> +#include <ios> +#include <iostream> +#include <map> +#include <string> +#include <vector> + +#include "base/allocator/partition_allocator/partition_root.h" +#include "base/allocator/partition_allocator/thread_cache.h" +#include "base/check_op.h" +#include "base/debug/proc_maps_linux.h" +#include "base/files/file.h" +#include "base/files/file_enumerator.h" +#include "base/files/scoped_file.h" +#include "base/logging.h" +#include "base/posix/eintr_wrapper.h" +#include "base/strings/string_number_conversions.h" +#include "base/strings/stringprintf.h" +#include "base/thread_annotations.h" +#include "base/time/time.h" +#include "build/build_config.h" +#include "third_party/abseil-cpp/absl/types/optional.h" + +namespace { + +// SIGSTOPs a process. +class ScopedSigStopper { + public: + explicit ScopedSigStopper(pid_t pid) : pid_(pid) { kill(pid_, SIGSTOP); } + ~ScopedSigStopper() { kill(pid_, SIGCONT); } + + private: + const pid_t pid_; +}; + +base::ScopedFD OpenProcMem(pid_t pid) { + std::string path = base::StringPrintf("/proc/%d/mem", pid); + int fd = open(path.c_str(), O_RDONLY); + CHECK_NE(fd, -1) + << "Do you have 0 set in /proc/sys/kernel/yama/ptrace_scope?"; + + return base::ScopedFD(fd); +} + +// Reads a remote process memory. +bool ReadMemory(int fd, unsigned long address, size_t size, char* buffer) { + if (HANDLE_EINTR(pread(fd, buffer, size, address)) == + static_cast<ssize_t>(size)) { + return true; + } + + return false; +} + +// Scans the process memory to look for the thread cache registry address. This +// does not need symbols. +uintptr_t FindThreadCacheRegistry(pid_t pid, int mem_fd) { + std::vector<base::debug::MappedMemoryRegion> regions; + + { + // Ensures that the mappings are not going to change. + ScopedSigStopper stop{pid}; + + // There are subtleties when trying to read this file, which we blissfully + // ignore here. See //base/debug/proc_maps_linux.h for details. We don't use + // it, since we don't read the maps for ourselves, and everything is already + // extremely racy. At worst we have to retry. + LOG(INFO) << "Opening /proc/PID/maps"; + std::string path = base::StringPrintf("/proc/%d/maps", pid); + auto file = base::File(base::FilePath(path), + base::File::FLAG_OPEN | base::File::FLAG_READ); + CHECK(file.IsValid()); + std::vector<char> data(1e7); + int bytes_read = + file.ReadAtCurrentPos(&data[0], static_cast<int>(data.size()) - 1); + CHECK_GT(bytes_read, 0) << "Cannot read " << path; + data[bytes_read] = '\0'; + std::string proc_maps(&data[0]); + + LOG(INFO) << "Parsing the maps"; + CHECK(base::debug::ParseProcMaps(proc_maps, ®ions)); + LOG(INFO) << "Found " << regions.size() << " regions"; + } + + for (auto& region : regions) { + using base::debug::MappedMemoryRegion; + + // The array is in .data, meaning that it's mapped from the executable, and + // has rw-p permissions. For Chrome, .data is quite small, hence the size + // limit. + uint8_t expected_permissions = MappedMemoryRegion::Permission::READ | + MappedMemoryRegion::Permission::WRITE | + MappedMemoryRegion::Permission::PRIVATE; + size_t region_size = region.end - region.start; + if (region.permissions != expected_permissions || region_size > 1e7 || + region.path.empty()) { + continue; + } + + LOG(INFO) << "Found a candidate region between " << std::hex << region.start + << " and " << region.end << std::dec + << " (size = " << region.end - region.start + << ") path = " << region.path; + // Scan the region, looking for the needles. + uintptr_t needle_array_candidate[3]; + for (uintptr_t address = region.start; + address < region.end - sizeof(needle_array_candidate); + address += sizeof(uintptr_t)) { + bool ok = ReadMemory(mem_fd, reinterpret_cast<unsigned long>(address), + sizeof(needle_array_candidate), + reinterpret_cast<char*>(needle_array_candidate)); + if (!ok) { + LOG(WARNING) << "Failed to read"; + continue; + } + + if (needle_array_candidate[0] == base::internal::tools::kNeedle1 && + needle_array_candidate[2] == base::internal::tools::kNeedle2) { + LOG(INFO) << "Got it! Address = 0x" << std::hex + << needle_array_candidate[1]; + return needle_array_candidate[1]; + } + } + } + + LOG(ERROR) << "Failed to find the address"; + return 0; +} + +// Allows to access an object copied from remote memory "as if" it were +// local. Of course, dereferencing any pointer from within it will at best +// fault. +template <typename T> +class RawBuffer { + public: + RawBuffer() = default; + const T* get() const { return reinterpret_cast<const T*>(buffer_); } + char* get_buffer() { return buffer_; } + + static absl::optional<RawBuffer<T>> ReadFromMemFd(int mem_fd, + uintptr_t address) { + RawBuffer<T> buf; + bool ok = ReadMemory(mem_fd, reinterpret_cast<unsigned long>(address), + sizeof(T), buf.get_buffer()); + if (!ok) + return absl::nullopt; + + return {buf}; + } + + private: + alignas(T) char buffer_[sizeof(T)]; +}; + +// List all thread names for a given PID. +std::map<base::PlatformThreadId, std::string> ThreadNames(pid_t pid) { + std::map<base::PlatformThreadId, std::string> result; + + base::FilePath root_path = + base::FilePath(base::StringPrintf("/proc/%d/task", pid)); + base::FileEnumerator enumerator{root_path, false, + base::FileEnumerator::DIRECTORIES}; + + for (base::FilePath path = enumerator.Next(); !path.empty(); + path = enumerator.Next()) { + auto stat_path = path.Append("stat"); + base::File stat_file{stat_path, + base::File::FLAG_OPEN | base::File::FLAG_READ}; + if (!stat_file.IsValid()) { + LOG(WARNING) << "Invalid file: " << stat_path.value(); + continue; + } + + char buffer[4096 + 1]; + int bytes_read = stat_file.ReadAtCurrentPos(buffer, 4096); + if (bytes_read <= 0) + continue; + buffer[bytes_read] = '\0'; + + int pid, ppid, pgrp; + char name[256]; + char state; + sscanf(buffer, "%d %s %c %d %d", &pid, name, &state, &ppid, &pgrp); + result[base::PlatformThreadId(pid)] = std::string(name); + } + + return result; +} + +} // namespace + +namespace base { +namespace internal { +namespace tools { + +class ThreadCacheInspector { + public: + // Distinct from ThreadCache::Bucket because |count| is uint8_t. + struct BucketStats { + int count = 0; + int per_thread_limit = 0; + size_t size = 0; + }; + + ThreadCacheInspector(uintptr_t registry_addr, int mem_fd, pid_t pid); + bool GetAllThreadCaches(); + size_t CachedMemory() const; + uintptr_t GetRootAddress(); + + const std::vector<RawBuffer<ThreadCache>>& thread_caches() const { + return thread_caches_; + } + + static bool should_purge(const RawBuffer<ThreadCache>& tcache) { + return tcache.get()->should_purge_; + } + + std::vector<BucketStats> AccumulateThreadCacheBuckets(); + std::uint8_t largest_active_bucket_index() { + return registry_.get()->largest_active_bucket_index_; + } + + private: + uintptr_t registry_addr_; + int mem_fd_; + pid_t pid_; + RawBuffer<ThreadCacheRegistry> registry_; + std::vector<RawBuffer<ThreadCache>> thread_caches_; +}; + +class PartitionRootInspector { + public: + struct BucketStats { + size_t slot_size = 0; + size_t allocated_slots = 0; + size_t freelist_size = 0; + size_t active_slot_spans = 0; + }; + + PartitionRootInspector(uintptr_t root_addr, int mem_fd, pid_t pid) + : root_addr_(root_addr), mem_fd_(mem_fd), pid_(pid) {} + // Returns true for success. + bool GatherStatistics(); + const std::vector<BucketStats>& bucket_stats() const { return bucket_stats_; } + const PartitionRoot<ThreadSafe>* root() { return root_.get(); } + + private: + void Update(); + + uintptr_t root_addr_; + int mem_fd_; + pid_t pid_; + RawBuffer<PartitionRoot<ThreadSafe>> root_; + std::vector<BucketStats> bucket_stats_; +}; + +ThreadCacheInspector::ThreadCacheInspector(uintptr_t registry_addr, + int mem_fd, + pid_t pid) + : registry_addr_(registry_addr), mem_fd_(mem_fd), pid_(pid) {} + +// NO_THREAD_SAFETY_ANALYSIS: Well, reading a running process' memory is not +// really thread-safe. +bool ThreadCacheInspector::GetAllThreadCaches() NO_THREAD_SAFETY_ANALYSIS { + thread_caches_.clear(); + + // This is going to take a while, make sure that the metadata don't change. + ScopedSigStopper stopper{pid_}; + + auto registry = + RawBuffer<ThreadCacheRegistry>::ReadFromMemFd(mem_fd_, registry_addr_); + if (!registry.has_value()) + return false; + + registry_ = *registry; + ThreadCache* head = registry_.get()->list_head_; + while (head) { + auto tcache = RawBuffer<ThreadCache>::ReadFromMemFd( + mem_fd_, reinterpret_cast<uintptr_t>(head)); + if (!tcache.has_value()) { + LOG(WARNING) << "Failed to read a ThreadCache"; + return false; + } + thread_caches_.push_back(tcache.value()); + head = tcache->get()->next_; + } + return true; +} + +size_t ThreadCacheInspector::CachedMemory() const { + size_t total_memory = 0; + + for (auto& tcache : thread_caches_) { + size_t cached_memory = tcache.get()->CachedMemory(); + total_memory += cached_memory; + } + + return total_memory; +} + +uintptr_t ThreadCacheInspector::GetRootAddress() { + CHECK(!thread_caches_.empty()); + return reinterpret_cast<uintptr_t>(thread_caches_[0].get()->root_); +} + +std::vector<ThreadCacheInspector::BucketStats> +ThreadCacheInspector::AccumulateThreadCacheBuckets() { + std::vector<BucketStats> result(ThreadCache::kBucketCount); + for (auto& tcache : thread_caches_) { + for (int i = 0; i < ThreadCache::kBucketCount; i++) { + result[i].count += tcache.get()->buckets_[i].count; + result[i].per_thread_limit = tcache.get()->buckets_[i].limit; + } + } + + BucketIndexLookup lookup{}; + for (int i = 0; i < ThreadCache::kBucketCount; i++) { + result[i].size = lookup.bucket_sizes()[i]; + } + return result; +} + +void PartitionRootInspector::Update() { + auto root = + RawBuffer<PartitionRoot<ThreadSafe>>::ReadFromMemFd(mem_fd_, root_addr_); + if (root.has_value()) + root_ = *root; +} + +bool PartitionRootInspector::GatherStatistics() { + // This is going to take a while, make sure that the metadata don't change. + ScopedSigStopper stopper{pid_}; + + Update(); + bucket_stats_.clear(); + + for (auto& bucket : root_.get()->buckets) { + BucketStats stats; + stats.slot_size = bucket.slot_size; + + // Only look at the small buckets. + if (bucket.slot_size > 1024) + return true; + + absl::optional<RawBuffer<SlotSpanMetadata<ThreadSafe>>> metadata; + for (auto* active_slot_span = bucket.active_slot_spans_head; + active_slot_span; active_slot_span = metadata->get()->next_slot_span) { + metadata = RawBuffer<SlotSpanMetadata<ThreadSafe>>::ReadFromMemFd( + mem_fd_, reinterpret_cast<uintptr_t>(active_slot_span)); + if (!metadata.has_value()) + return false; + + int16_t allocated_slots = metadata->get()->num_allocated_slots; + // Negative number for a full slot span. + if (allocated_slots < 0) + allocated_slots = -allocated_slots; + + stats.allocated_slots += allocated_slots; + size_t allocated_unprovisioned = metadata->get()->num_allocated_slots + + metadata->get()->num_unprovisioned_slots; + // Inconsistent data. This can happen since we stopped the process at an + // arbitrary point. + if (allocated_unprovisioned > bucket.get_slots_per_span()) + return false; + + size_t freelist_size = + bucket.get_slots_per_span() - allocated_unprovisioned; + + stats.freelist_size += freelist_size; + stats.active_slot_spans++; + } + bucket_stats_.push_back(stats); + } + + // We should have found at least one bucket too large, and returned earlier. + return false; +} + +void DisplayBucket(const ThreadCacheInspector::BucketStats& bucket, + bool is_limit) { + size_t bucket_memory = bucket.size * bucket.count; + + std::string line = base::StringPrintf( + "% 4d\t% 4d\t% 4d\t% 4dkiB", static_cast<int>(bucket.size), + static_cast<int>(bucket.per_thread_limit), static_cast<int>(bucket.count), + static_cast<int>(bucket_memory / 1024)); + + std::cout << (is_limit ? "*" : " ") << line; +} + +void DisplayPerThreadData( + ThreadCacheInspector& inspector, + std::map<base::PlatformThreadId, std::string>& tid_to_name) { + std::cout << "Found " << inspector.thread_caches().size() + << " caches, total cached memory = " + << inspector.CachedMemory() / 1024 << "kiB" + << "\n"; + + std::cout << "Per thread:\n" + << "Thread Name Size\tPurge\n" + << std::string(80, '-') << "\n"; + base::ThreadCacheStats all_threads_stats = {0}; + for (const auto& tcache : inspector.thread_caches()) { + base::ThreadCacheStats stats = {0}; + // No alloc stats, they reach into tcache->root_, which is not valid. + tcache.get()->AccumulateStats(&stats); + tcache.get()->AccumulateStats(&all_threads_stats); + uint64_t count = stats.alloc_count; + uint64_t hit_rate = (100 * stats.alloc_hits) / count; + uint64_t too_large = (100 * stats.alloc_miss_too_large) / count; + uint64_t empty = (100 * stats.alloc_miss_empty) / count; + + std::string thread_name = tid_to_name[tcache.get()->thread_id()]; + std::string padding(20 - thread_name.size(), ' '); + std::cout << thread_name << padding << tcache.get()->CachedMemory() / 1024 + << "kiB\t" << (inspector.should_purge(tcache) ? 'X' : ' ') + << "\tHit Rate = " << hit_rate << "%" + << "\tToo Large = " << too_large << "%" + << "\tEmpty = " << empty << "%" + << "\t Count = " << count / 1000 << "k" + << "\n"; + } + + uint64_t count = all_threads_stats.alloc_count; + uint64_t hit_rate = (100 * all_threads_stats.alloc_hits) / count; + uint64_t too_large = (100 * all_threads_stats.alloc_miss_too_large) / count; + uint64_t empty = (100 * all_threads_stats.alloc_miss_empty) / count; + std::cout << "\nALL THREADS: " + << all_threads_stats.bucket_total_memory / 1024 << "kiB" + << "\t\tHit Rate = " << hit_rate << "%" + << "\tToo Large = " << too_large << "%" + << "\tEmpty = " << empty << "%" + << "\t Count = " << count / 1000 << "k" + << "\n"; +} + +void DisplayPerBucketData(ThreadCacheInspector& inspector) { + std::cout << "Per-bucket stats (All Threads):" + << "\nSize\tLimit\tCount\tMemory\t| Size\t\tLimit\tCount\tMemory\n" + << std::string(80, '-') << "\n"; + + size_t total_memory = 0; + auto bucket_stats = inspector.AccumulateThreadCacheBuckets(); + for (size_t index = 0; index < bucket_stats.size() / 2; index++) { + size_t bucket_index = index; + auto& bucket = bucket_stats[bucket_index]; + total_memory += bucket.size * bucket.count; + DisplayBucket(bucket, + inspector.largest_active_bucket_index() == bucket_index); + + std::cout << "\t| "; + + bucket_index = bucket_stats.size() / 2 + index; + bucket = bucket_stats[bucket_index]; + total_memory += bucket.size * bucket.count; + DisplayBucket(bucket_stats[bucket_index], + inspector.largest_active_bucket_index() == bucket_index); + + std::cout << "\n"; + } + std::cout << "\nALL THREADS TOTAL: " << total_memory / 1024 << "kiB\n"; +} + +void DisplayRootData(PartitionRootInspector& root_inspector) { + std::cout << "Per-bucket size / allocated slots / free slots / slot span " + "count:\n"; + for (size_t i = 0; i < root_inspector.bucket_stats().size(); i++) { + const auto& bucket_stats = root_inspector.bucket_stats()[i]; + + std::string line = base::StringPrintf( + "|% 5d % 6d % 6d % 4d|", static_cast<int>(bucket_stats.slot_size), + static_cast<int>(bucket_stats.allocated_slots), + static_cast<int>(bucket_stats.freelist_size), + static_cast<int>(bucket_stats.active_slot_spans)); + + std::cout << line; + if (i % 4 == 3) + std::cout << "\n"; + else + std::cout << "\t"; + } + + auto* root = root_inspector.root(); + uint64_t syscall_count = root->syscall_count.load(std::memory_order_relaxed); + uint64_t total_duration_ms = + root->syscall_total_time_ns.load(std::memory_order_relaxed) / 1e6; + + std::cout << "\n\nSyscall count = " << syscall_count + << "\tTotal duration = " << total_duration_ms << "ms\n" + << "Max committed size = " + << root->max_size_of_committed_pages.load( + std::memory_order_relaxed) / + 1024 + << "kiB"; + std::cout << "\nEmpty Slot Spans Dirty Size = " + << TS_UNCHECKED_READ(root->empty_slot_spans_dirty_bytes) / 1024 + << "kiB"; +} + +} // namespace tools +} // namespace internal +} // namespace base + +int main(int argc, char** argv) { + if (argc < 2) { + LOG(ERROR) << "Usage:" << argv[0] << " <PID> " + << "[address. 0 to scan the process memory]"; + return 1; + } + + int pid = atoi(argv[1]); + uintptr_t registry_address = 0; + + auto mem_fd = OpenProcMem(pid); + + if (argc == 3) { + uint64_t address; + CHECK(base::StringToUint64(argv[2], &address)); + registry_address = static_cast<uintptr_t>(address); + } else { + // Scan the memory. + registry_address = FindThreadCacheRegistry(pid, mem_fd.get()); + } + + CHECK(registry_address); + + LOG(INFO) << "Getting the thread cache registry"; + base::internal::tools::ThreadCacheInspector thread_cache_inspector{ + registry_address, mem_fd.get(), pid}; + std::map<base::PlatformThreadId, std::string> tid_to_name; + + while (true) { + base::TimeTicks tick = base::TimeTicks::Now(); + bool ok = thread_cache_inspector.GetAllThreadCaches(); + if (!ok) + continue; + + base::internal::tools::PartitionRootInspector root_inspector{ + thread_cache_inspector.GetRootAddress(), mem_fd.get(), pid}; + bool has_bucket_stats = root_inspector.GatherStatistics(); + + for (const auto& tcache : thread_cache_inspector.thread_caches()) { + // Note: this is not robust when TIDs are reused, but here this is fine, + // as at worst we would display wrong data, and TID reuse is very unlikely + // in normal scenarios. + if (tid_to_name.find(tcache.get()->thread_id()) == tid_to_name.end()) { + tid_to_name = ThreadNames(pid); + break; + } + } + int64_t gather_time_ms = (base::TimeTicks::Now() - tick).InMilliseconds(); + + constexpr const char* kClearScreen = "\033[2J\033[1;1H"; + std::cout << kClearScreen << "Time to gather data = " << gather_time_ms + << "ms\n"; + DisplayPerThreadData(thread_cache_inspector, tid_to_name); + + std::cout << "\n\n"; + DisplayPerBucketData(thread_cache_inspector); + + if (has_bucket_stats) { + std::cout << "\n\n"; + DisplayRootData(root_inspector); + } + + std::cout << std::endl; + usleep(200000); + } +} diff --git a/chromium/tools/memory/partition_allocator/profile_allocations.py b/chromium/tools/memory/partition_allocator/profile_allocations.py index 9ce52bc710d..9b58691f177 100755 --- a/chromium/tools/memory/partition_allocator/profile_allocations.py +++ b/chromium/tools/memory/partition_allocator/profile_allocations.py @@ -17,75 +17,27 @@ To collect a profile: """ import argparse -import gzip -import json import logging import os from matplotlib import pylab as plt import numpy as np - -def _LoadTrace(filename: str) -> dict: - """Loads a JSON trace, gzipped or not. - - Args: - filename: Filename, gzipped or not. - - Returns: - A dictionary with the trace content. - """ - try: - f = None - if filename.endswith('.gz'): - f = gzip.open(filename, 'r') - else: - f = open(filename, 'r') - return json.load(f) - finally: - if f is not None: - f.close() +from parse_trace import LoadTrace, GetAllocatorDumps, ProcessNamesAndLabels def _ParseTrace(trace: dict) -> dict: """Parses a trace, and returns thread cache stats. Args: - trace: As returned by _LoadTrace() + trace: As returned by LoadTrace() Returns: {pid -> {'name': str, 'labels': str, 'data': np.array}. Where the data array contains 'size' and 'count' columns. """ - events = trace['traceEvents'] - memory_infra_events = [ - e for e in events if e['cat'] == 'disabled-by-default-memory-infra' - ] - dumps = [ - e for e in memory_infra_events - if e['name'] == 'periodic_interval' and e['args']['dumps'] - ['level_of_detail'] == 'detailed' and 'allocators' in e['args']['dumps'] - ] - - # Process names and labels. - pid_to_name = {} - pid_to_labels = {} - - metadata_events = [ - e for e in trace['traceEvents'] if e['cat'] == '__metadata' - ] - - process_name_events = [ - e for e in metadata_events if e['name'] == 'process_name' - ] - for e in process_name_events: - pid_to_name[e['pid']] = e['args']['name'] - - process_labels_events = [ - e for e in metadata_events if e['name'] == 'process_labels' - ] - for e in process_labels_events: - pid_to_labels[e['pid']] = e['args']['labels'] + dumps = GetAllocatorDumps(trace) + pid_to_name, pid_to_labels = ProcessNamesAndLabels(trace) result = {} for dump in dumps: @@ -131,9 +83,9 @@ def _PlotProcess(all_data: dict, pid: int, output_prefix: str): plt.figure(figsize=(16, 8)) plt.title('Allocation count vs Size - %s - %s' % (data['name'], data['labels'])) - plt.stem(data['data']['size'], data['data']['count']) plt.xscale('log', base=2) plt.yscale('log', base=10) + plt.stem(data['data']['size'], data['data']['count']) plt.xlabel('Size (log)') plt.ylabel('Allocations (log)') plt.savefig('%s_%d_count.png' % (output_prefix, pid), bbox_inches='tight') @@ -181,7 +133,7 @@ def main(): args = parser.parse_args() logging.info('Loading the trace') - trace = _LoadTrace(args.trace) + trace = LoadTrace(args.trace) logging.info('Parsing the trace') stats_per_process = _ParseTrace(trace) diff --git a/chromium/tools/memory/partition_allocator/trace_utils.py b/chromium/tools/memory/partition_allocator/trace_utils.py new file mode 100644 index 00000000000..99de229fd6b --- /dev/null +++ b/chromium/tools/memory/partition_allocator/trace_utils.py @@ -0,0 +1,247 @@ +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""Parses traces into Python objects. + +Takes a trace from chrome://tracing and returns a Python dict containing the +result. The functions in the file are not very useful on their own, but are +intended as helpers for the other scripts in this directory. + +This parses an allocation profile generated by PartitionAlloc in the thread +cache. This will only give data on Chrome instances where the thread cache is +enabled, and PA_THREAD_CACHE_ALLOC_STATS is defined, that is non-official +builds. + +To collect a profile: +- Build a non-official chrome version (Should be a release build for accurate + reports; Debug builds have PA-E disabled) +- Collect a trace with the memory-infra category enabled (in chrome://tracing) +- Save it as json.gz, and load it here. +""" + +import gzip +import json + +from matplotlib import pylab as plt +from typing import Callable + + +def LoadTrace(filename: str) -> dict: + """Loads a JSON trace, gzipped or not. This trace should be taken directly + from Chrome (chrome://tracing). + + Args: + filename: Filename, gzipped or not. + + Returns: + A dictionary with the trace content. This is simply the content of the + trace from |filename|, as a Python dictionary. + """ + try: + f = None + if filename.endswith('.gz'): + f = gzip.open(filename, 'r') + else: + f = open(filename, 'r') + return json.load(f) + finally: + if f is not None: + f.close() + + +def _GetAllocatorDumps(trace: dict) -> list: + """Takes in a trace (as returned from |LoadTrace|), and returns the parts + of it related to the allocators. + + Args: + trace: Trace content as returned by LoadTrace. + + Returns: + The parts of the trace related to allocator metrics. Note that these + entries are taken as-is from the trace. + + Each entry of the return value has + the following format. The important field here is 'args', but there are + other unimportant ones as well (shown with ...): + { + 'args': { + 'dumps': { + 'allocators': dict[str, dict], + 'allocator_graph': list[dict], + 'level_of_detail': 'detailed' + } + }, + ... + } + + Of the fields listed above, we mainly care about 'allocators'. Each entry + here corresponds to an allocator or a subset of the allocations for a given + allocator. For example, we have an entry in 'allocators' with key + 'malloc/partitions/allocator/buckets/bucket_1024', which corresponds to the + 1024 byte bucket of PartitionAlloc's main malloc partition. + + Note that in the trace, we have entries for allocators besides just + PartitionAlloc, but in these scripts, we will only be looking at entries + for PartitionAlloc allocators. + + Each entry of 'allocators' has the + following format: + { + 'attrs': dict[str, dict], + 'guid': str + } + + The contents of 'attrs' varies depending on which entry we are looking at, + but generally contains all the relevant information we need for a + particular allocator. The attributes we care about here are mainly: + 'allocated_objects_size', 'size', and 'slot_size'. + + Finally, each entry of 'attrs' has the following format: + { + 'type': str, + 'units': str, + 'value': str + } + + For example, in 'malloc/partitions/allocator/buckets/bucket_1024', 'attrs' + has a 'allocated_objects_size' entry, which might look like so: + { + 'type': 'scalar', + 'units': 'bytes', + 'value': 'ef8000' + } + + The entry we care about here is 'value', which is a string representing a + hexadecimal number. + """ + events = trace['traceEvents'] + memory_infra_events = [ + e for e in events if e['cat'] == 'disabled-by-default-memory-infra' + ] + dumps = [ + e for e in memory_infra_events + if e['name'] == 'periodic_interval' and e['args']['dumps'] + ['level_of_detail'] == 'detailed' and 'allocators' in e['args']['dumps'] + ] + return dumps + + +def _ProcessNamesAndLabels(trace: dict) -> (dict, dict): + """Get mappings of pid to name and pid to label. + + Args: + trace: Trace content as returned by LoadTrace. + + Returns: + A tuple containing two dicts. The first maps pids to names, the second maps + pids to labels. + """ + # Process names and labels. + pid_to_name = {} + pid_to_labels = {} + + metadata_events = [ + e for e in trace['traceEvents'] if e['cat'] == '__metadata' + ] + + process_name_events = [ + e for e in metadata_events if e['name'] == 'process_name' + ] + for e in process_name_events: + pid_to_name[e['pid']] = e['args']['name'] + + process_labels_events = [ + e for e in metadata_events if e['name'] == 'process_labels' + ] + for e in process_labels_events: + pid_to_labels[e['pid']] = e['args']['labels'] + + return pid_to_name, pid_to_labels + + +def ParseTrace(trace: dict, + compute_result: Callable[[dict, dict], None]) -> dict[int, dict]: + """Parses a trace, and returns thread cache stats. + + Args: + trace: As returned by LoadTrace() + compute_result: function taking |result_for_pid| (which it modifies + in-place), and |allocators|. It should add any results we'd like to graph + into |result_for_pid['data']|, as an |np.array|. + + Returns: + {pid -> {'name': str, 'labels': str, 'data': np.array}. + Where the data array contains the data we would like to graph. For example, + it may contain 'size' and 'fragmentation' columns, which is what + |PlotProcessFragmentation| expects. + """ + dumps = _GetAllocatorDumps(trace) + pid_to_name, pid_to_labels = _ProcessNamesAndLabels(trace) + + result = {} + for dump in dumps: + pid = dump['pid'] + allocators = dump['args']['dumps']['allocators'] + + # The browser process also has global dumps, we do not care about these. + # These dumps are also returned from |_GetAllocatorDumps|, but the + # corresponding metadata for them is not returned from + # |_ProcessNamesAndLabels|. We have to special-case things _somewhere_ to + # exclude these dumps, and this seems like the best spot. + if 'global' in allocators: + continue + + # We only use the last dump for a given pid, overwritting all previous + # ones. + result[pid] = { + 'name': pid_to_name[pid], + 'labels': pid_to_labels.get(pid, '') + } + compute_result(result[pid], allocators) + + return result + + +def PlotProcessFragmentation(title, data, output): + """Plots the Fragmentation vs size for a single process. + + Args: + title: Title of the graph + data: Data to plot. Should contain 'size' and 'fragmentation' entries. + output: Filename to save the result to. + """ + plt.figure(figsize=(16, 8)) + plt.title(title) + plt.stem(data['data']['size'], data['data']['fragmentation']) + plt.xscale('log', base=2) + plt.yscale('linear') + plt.ylim(ymin=0, ymax=100) + plt.xlabel('Size (log)') + plt.ylabel('Fragmentation (%)') + plt.savefig(output, bbox_inches='tight') + plt.close() + + +def PlotProcessWaste(title, data, output): + """Plots the Unused memory vs size for a single process. + + Args: + title: Title of the graph + data: Data to plot. Should contain 'size' and 'unused' entries. + output: Filename to save the result to. + """ + plt.figure(figsize=(16, 8)) + plt.title(title) + plt.xscale('log', base=2) + plt.yscale('log', base=2) + plt.stem(data['data']['size'][data['data']['unused'] != 0], + data['data']['unused'][data['data']['unused'] != 0]) + plt.ylim(ymin=1, ymax=2**20) + plt.xlabel('Size (log)') + plt.ylabel('Unused Size (log)') + plt.savefig(output, bbox_inches='tight') + plt.close() + + +def GetAllocatorAttr(attrs: dict, name: str) -> str: + return int(attrs[name]['value'], base=16) diff --git a/chromium/tools/metrics/OWNERS b/chromium/tools/metrics/OWNERS index 0f9fcea0255..1751f19ccf1 100644 --- a/chromium/tools/metrics/OWNERS +++ b/chromium/tools/metrics/OWNERS @@ -2,4 +2,6 @@ # specific individuals. These CLs will be automatically reassigned to a reviewer # within about 5 minutes. This approach helps our team to load-balance incoming # reviews. Googlers can read more about this at go/gwsq-gerrit. -file://base/metrics/OWNERS +chromium-metrics-reviews@google.com + +file://base/metrics/OWNERS #{LAST_RESORT_SUGGESTION} diff --git a/chromium/tools/metrics/actions/actions.xml b/chromium/tools/metrics/actions/actions.xml index d5f28e1ae38..55ab2614046 100644 --- a/chromium/tools/metrics/actions/actions.xml +++ b/chromium/tools/metrics/actions/actions.xml @@ -802,6 +802,11 @@ should be able to be added at any place in this file. <description>User pressed the stop media control button.</description> </action> +<action name="Accel_Microphone_Mute"> + <owner>rtinkoff@google.com</owner> + <description>User pressed the microphone mute toggle key.</description> +</action> + <action name="Accel_Minimize_Top_Window_On_Back"> <owner>minch@chromium.org</owner> <description> @@ -1210,6 +1215,15 @@ should be able to be added at any place in this file. </description> </action> +<action name="Accel_Toggle_Floating"> + <owner>shidi@chromium.org</owner> + <owner>afakhry@chromium.org</owner> + <description> + Metric recorded when the user toggles the Window Floating feature with a + keyboard shortcut. + </description> +</action> + <action name="Accel_Toggle_Fullscreen_Magnifier"> <owner>afakhry@chromium.org</owner> <description> @@ -5443,6 +5457,16 @@ should be able to be added at any place in this file. </description> </action> +<action name="ContentSuggestions.Feed.Engaged"> + <owner>adamta@google.org</owner> + <owner>sczs@chromium.org</owner> + <owner>feed@chromium.org</owner> + <description> + The user has engaged with the feed or scrolled at least 1 inch into it + within a 5-minute session. + </description> +</action> + <action name="ContentSuggestions.Feed.HeaderAction.ManageActivity"> <owner>adamta@google.org</owner> <owner>sczs@chromium.org</owner> @@ -5470,6 +5494,16 @@ should be able to be added at any place in this file. </description> </action> +<action name="ContentSuggestions.Feed.WillRefresh"> + <owner>adamta@google.org</owner> + <owner>sczs@chromium.org</owner> + <owner>feed@chromium.org</owner> + <description> + The feed will trigger a refresh, either manually by the user or because of + the cache expiring. + </description> +</action> + <action name="ContentSuggestions.NotificationsPreferenceOff"> <owner>dgn@chromium.org</owner> <owner>finkm@chromium.org</owner> @@ -7509,6 +7543,14 @@ should be able to be added at any place in this file. <description>Please enter the description of this user action.</description> </action> +<action name="FocusWebContentsPane"> + <owner>pbos@chromium.org</owner> + <description> + Called when a keyboard shortcut is used to put keyboard focus directly on + browser web contents. + </description> +</action> + <action name="FontName"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> <description>Please enter the description of this user action.</description> @@ -8159,6 +8201,12 @@ should be able to be added at any place in this file. <description>The user dismissed the in-product help.</description> </action> +<action name="InProductHelp.InsideTouch"> + <owner>haileywang@chromium.org</owner> + <owner>shaktisahu@chromium.org</owner> + <description>The user tapped inside the in-product help bubble.</description> +</action> + <action name="InProductHelp.NotifyEvent.IPH" not_user_triggered="true"> <owner>dtrainor@chromium.org</owner> <owner>nyquist@chromium.org</owner> @@ -8171,6 +8219,12 @@ should be able to be added at any place in this file. <description>The user triggered a used event in in-product help.</description> </action> +<action name="InProductHelp.OutsideTouch"> + <owner>haileywang@chromium.org</owner> + <owner>shaktisahu@chromium.org</owner> + <description>The user tapped outside the in-product help bubble.</description> +</action> + <action name="InProductHelp.Promos.BubbleClicked"> <owner>collinbaker@chromium.org</owner> <description> @@ -10122,6 +10176,20 @@ should be able to be added at any place in this file. <description>Please enter the description of this user action.</description> </action> +<action name="Keyboard_Microphone_Muted"> + <owner>rtinkoff@chromium.org</owner> + <description> + The user muted the mic by pressing the mic mute keyboard key. + </description> +</action> + +<action name="Keyboard_Microphone_Unmuted"> + <owner>rtinkoff@chromium.org</owner> + <description> + The user unmuted the mic by pressing the mic mute keyboard key. + </description> +</action> + <action name="KeyboardShortcutViewer.CreateWindow"> <owner>wutao@chromium.org</owner> <description> @@ -12531,6 +12599,74 @@ should be able to be added at any place in this file. </description> </action> +<action name="LensSidePanel.CloseButtonClick"> + <owner>stanfield@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>juanmojica@google.com</owner> + <owner>schechter@google.com</owner> + <description> + Close button was clicked on the Lens side panel. Also records the + LensSidePanel.Hide action. + </description> +</action> + +<action name="LensSidePanel.Hide"> + <owner>stanfield@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>juanmojica@google.com</owner> + <owner>schechter@google.com</owner> + <description>The Lens side panel went from showing to hidden.</description> +</action> + +<action name="LensSidePanel.HideChromeSidePanel"> + <owner>stanfield@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>juanmojica@google.com</owner> + <owner>schechter@google.com</owner> + <description> + The Lens side panel clobbered the Chrome side panel (Reading + List/Bookmarks). + </description> +</action> + +<action name="LensSidePanel.LensQueryWhileShowing"> + <owner>stanfield@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>juanmojica@google.com</owner> + <owner>schechter@google.com</owner> + <description> + The user issued a Lens query while the Lens side panel was open. + </description> +</action> + +<action name="LensSidePanel.LoadResultsInNewTab"> + <owner>stanfield@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>juanmojica@google.com</owner> + <owner>schechter@google.com</owner> + <description> + The Lens side panel button to expand results to new tab was clicked. + </description> +</action> + +<action name="LensSidePanel.ResultLinkClick"> + <owner>stanfield@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>juanmojica@google.com</owner> + <owner>schechter@google.com</owner> + <description> + The user clicked a result link in the Lens side panel. + </description> +</action> + +<action name="LensSidePanel.Show"> + <owner>stanfield@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>juanmojica@google.com</owner> + <owner>schechter@google.com</owner> + <description>The Lens side panel went from hidden to showing.</description> +</action> + <action name="LinkNavigationOpenedInForegroundTab"> <owner>meiliang@chromium.org</owner> <owner>sbirch@chromium.org</owner> @@ -13824,6 +13960,38 @@ should be able to be added at any place in this file. <description>Please enter the description of this user action.</description> </action> +<action name="MobileBookmark.SaveFlow.ClosedWithoutEditAction"> + <owner>wylieb@chromium.org</owner> + <owner>chrome-collections@google.com</owner> + <description> + Recorded when a user closes the save flow without editing the boookmark. + </description> +</action> + +<action name="MobileBookmark.SaveFlow.EditBookmark"> + <owner>wylieb@chromium.org</owner> + <owner>chrome-collections@google.com</owner> + <description> + Recorded when a user taps the edit bookmark button in the save flow. + </description> +</action> + +<action name="MobileBookmark.SaveFlow.EditFolder"> + <owner>wylieb@chromium.org</owner> + <owner>chrome-collections@google.com</owner> + <description> + Recorded when a user taps the edit folder button in the save flow. + </description> +</action> + +<action name="MobileBookmark.SaveFlow.Show"> + <owner>wylieb@chromium.org</owner> + <owner>chrome-collections@google.com</owner> + <description> + Recorded when a user saves a bookmark via the improved save flow. + </description> +</action> + <action name="MobileBookmarkManagerClose"> <owner>twellington@google.com</owner> <owner>sczs@chromium.org</owner> @@ -14638,7 +14806,8 @@ should be able to be added at any place in this file. </action> <action name="MobileMenuAddToReadingList"> - <owner>xingliu@chromium.org</owner> + <owner>bttk@chromium.org</owner> + <owner>chrome-collections@google.com</owner> <description>User pressed 'Add to reading list' in the app menu.</description> </action> @@ -16070,6 +16239,7 @@ should be able to be added at any place in this file. </action> <action name="MobileTabGridCloseAllIncognitoTabsConfirmationPresented"> + <obsolete>Deprecated as of 8/2021</obsolete> <owner>ewannpv@chromium.org</owner> <owner>marq@chromium.org</owner> <description> @@ -16088,6 +16258,7 @@ should be able to be added at any place in this file. </action> <action name="MobileTabGridCloseAllRegularTabsConfirmationPresented"> + <obsolete>Deprecated as of 8/2021</obsolete> <owner>ewannpv@chromium.org</owner> <owner>marq@chromium.org</owner> <description> @@ -16097,6 +16268,7 @@ should be able to be added at any place in this file. </action> <action name="MobileTabGridCloseAllTabsConfirmationCanceled"> + <obsolete>Deprecated as of 8/2021</obsolete> <owner>ewannpv@chromium.org</owner> <owner>marq@chromium.org</owner> <description> @@ -16106,6 +16278,7 @@ should be able to be added at any place in this file. </action> <action name="MobileTabGridCloseAllTabsConfirmationConfirmed"> + <obsolete>Deprecated as of 8/2021</obsolete> <owner>ewannpv@chromium.org</owner> <owner>marq@chromium.org</owner> <description> @@ -17411,6 +17584,16 @@ should be able to be added at any place in this file. </description> </action> +<action name="NewTabPage.PreinstalledApps.Clicked"> + <owner>phillis@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <description> + The user clicked on a most visited tile that is a preinstalled extension + app. This action is logged every time the NewTabPage.MostVisited histogram + is logged and when the tile is a preinstalled extension app. + </description> +</action> + <action name="NewTabPage.Promo.EnhancedProtectionPromo.Accepted"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -17451,6 +17634,16 @@ should be able to be added at any place in this file. </description> </action> +<action name="NewTabPage.ViewHierarchyFixed"> + <owner>adamta@google.org</owner> + <owner>sczs@chromium.org</owner> + <owner>feed@chromium.org</owner> + <description> + Recorded when the NTP detects a broken view hierarchy and repairs itself. + TODO(crbug.com/1262536): Remove this when issue is fixed. + </description> +</action> + <action name="NewTabPage_ContentSuggestions_ArticlesUsage" not_user_triggered="true"> <owner>markusheintz@chromium.org</owner> @@ -21502,6 +21695,46 @@ should be able to be added at any place in this file. </description> </action> +<action name="QuickActionSearchWidget.LensQuery"> + <owner>ender@google.com</owner> + <owner>fgorski@chromium.org</owner> + <description> + The user triggered a Lens query from the Quick Actions Search Widget. + </description> +</action> + +<action name="QuickActionSearchWidget.StartDinoGame"> + <owner>ender@google.com</owner> + <owner>fgorski@chromium.org</owner> + <description> + User started the Dino Game from the Quick Action Search Widget. + </description> +</action> + +<action name="QuickActionSearchWidget.StartIncognito"> + <owner>ender@google.com</owner> + <owner>fgorski@chromium.org</owner> + <description> + User opened an incognito tab from the Quick Action Search Widget. + </description> +</action> + +<action name="QuickActionSearchWidget.TextQuery"> + <owner>ender@google.com</owner> + <owner>fgorski@chromium.org</owner> + <description> + The user triggered a text query from the Quick Actions Search Widget. + </description> +</action> + +<action name="QuickActionSearchWidget.VoiceQuery"> + <owner>ender@google.com</owner> + <owner>fgorski@chromium.org</owner> + <description> + The user triggered a voice query from the Quick Actions Search Widget. + </description> +</action> + <action name="ReadingList.Dialog.AddCurrentPage"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> @@ -23013,6 +23246,55 @@ should be able to be added at any place in this file. </description> </action> +<action name="ShareSubmenu.Abandoned"> + <owner>ellyjones@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <description> + The share submenu was opened, but closed without choosing any of the + options. + </description> +</action> + +<action name="ShareSubmenu.CopyLinkSelected"> + <owner>ellyjones@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <description> + The "copy link" option was selected in the share submenu. + </description> +</action> + +<action name="ShareSubmenu.QRCodeSelected"> + <owner>ellyjones@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <description> + The "generate QR code" option was selected in the share submenu. + </description> +</action> + +<action name="ShareSubmenu.SendTabToSelfSelected"> + <owner>ellyjones@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <description> + The "send tab to self" option was selected in the share submenu. + </description> +</action> + +<action name="ShareSubmenu.ThirdPartySelected"> + <owner>ellyjones@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <description> + One of the third-party targets was selected in the share submenu. + </description> +</action> + +<action name="SharingDesktopScreenshot.ScreenshotSavedViaBubble"> + <owner>skare@chromium.org</owner> + <owner>src/components/send_tab_to_self/OWNERS</owner> + <description> + User saved a screenshot captured from the desktop screenshot bubble. + </description> +</action> + <action name="SharingHubAndroid.BottomRowScrolled"> <obsolete> Renamed to SharingHubAndroid.ThirdPartyAppsScrolled 09/2020. @@ -23114,6 +23396,9 @@ should be able to be added at any place in this file. </action> <action name="SharingHubAndroid.LinkToTextSelected"> + <obsolete> + Corresponding option was removed from sharing hub in M95. Never launched. + </obsolete> <owner>gayane@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <description> @@ -23151,6 +23436,14 @@ should be able to be added at any place in this file. </description> </action> +<action name="SharingHubAndroid.SaveImageSelected"> + <owner>gayane@chromium.org</owner> + <owner>src/components/send_tab_to_self/OWNERS</owner> + <description> + The "Save Image" option was selected in the sharing hub. + </description> +</action> + <action name="SharingHubAndroid.ScreenshotSelected"> <owner>kmilka@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> @@ -23300,6 +23593,15 @@ should be able to be added at any place in this file. </description> </action> +<action name="SharingQRCode.DialogLaunched.ContextMenuLink"> + <owner>ellyjones@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <description> + User launched the QR Generator dialog for a link via the context menu on + desktop. + </description> +</action> + <action name="SharingQRCode.DialogLaunched.ContextMenuPage"> <owner>skare@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> @@ -23419,6 +23721,24 @@ should be able to be added at any place in this file. <description>User sets shelf to right alignment on ChromeOS.</description> </action> +<action name="Shelf_BrowserShortcutShelfItem_ShowTabs"> + <owner>erikchen@chromium.org</owner> + <owner>alexbn@chromium.org</owner> + <description> + User interacts with the browser icon in the shelf on ChromeOS to show a + context menu with all the tabs. + </description> +</action> + +<action name="Shelf_BrowserShortcutShelfItem_ShowWindows"> + <owner>erikchen@chromium.org</owner> + <owner>alexbn@chromium.org</owner> + <description> + User interacts with the browser icon in the shelf on ChromeOS to show a + context menu with all the windows. + </description> +</action> + <action name="Shelf_ItemPinned"> <owner>mmourgos@chromium.org</owner> <owner>gzadina@google.com</owner> @@ -23848,8 +24168,7 @@ should be able to be added at any place in this file. <action name="Signin_Impression_FromManageCardsBubble" not_user_triggered="true"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded when showing sign in entry in the manage cards bubble. @@ -23898,8 +24217,7 @@ should be able to be added at any place in this file. </action> <action name="Signin_Impression_FromSaveCardBubble" not_user_triggered="true"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded when showing sign in entry in the save card bubble. @@ -23986,8 +24304,7 @@ should be able to be added at any place in this file. <action name="Signin_ImpressionWithAccount_FromManageCardsBubble" not_user_triggered="true"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded when the personalized sign-in promo is shown with an account in the @@ -24027,8 +24344,7 @@ should be able to be added at any place in this file. <action name="Signin_ImpressionWithAccount_FromSaveCardBubble" not_user_triggered="true"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded when the personalized sign-in promo is shown with an account in the @@ -24097,8 +24413,7 @@ should be able to be added at any place in this file. <action name="Signin_ImpressionWithNoAccount_FromManageCardsBubble" not_user_triggered="true"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded when the personalized sign-in promo is shown with no account in the @@ -24139,8 +24454,7 @@ should be able to be added at any place in this file. <action name="Signin_ImpressionWithNoAccount_FromSaveCardBubble" not_user_triggered="true"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded when the personalized sign-in promo is shown with no account in the @@ -24242,6 +24556,9 @@ should be able to be added at any place in this file. </action> <action name="Signin_Signin_CancelCancelAdvancedSyncSettings"> + <obsolete> + Deprecated as the advanced settings can no longer be canceled. + </obsolete> <owner>tangltom@chromium.org</owner> <description> Recorded when the user clicks the 'Back' button on the 'Cancel sync?' dialog @@ -24332,6 +24649,14 @@ should be able to be added at any place in this file. </description> </action> +<action name="Signin_Signin_FromEnterpriseSignoutSheet"> + <owner>ewannpv@chromium.org</owner> + <owner>jlebel@chromium.org</owner> + <description> + Recorded on sign in start from the enterprise sign out sheet. + </description> +</action> + <action name="Signin_Signin_FromExtensionInstallBubble"> <owner>gogerald@chromium.org</owner> <description> @@ -24375,8 +24700,7 @@ should be able to be added at any place in this file. </action> <action name="Signin_Signin_FromManageCardsBubble"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded on sign in start from access point @@ -24433,8 +24757,7 @@ should be able to be added at any place in this file. </action> <action name="Signin_Signin_FromSaveCardBubble"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded on sign in start from access point @@ -24638,8 +24961,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNewAccount_FromSaveCardBubble"> <obsolete>Deprecated 08/2018</obsolete> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>sebsg@chromium.org</owner> <description> @@ -24715,8 +25037,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNewAccountExistingAccount_FromManageCardsBubble"> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>battre@chromium.org</owner> <description> @@ -24759,8 +25080,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNewAccountExistingAccount_FromSaveCardBubble"> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>battre@chromium.org</owner> <description> @@ -24836,8 +25156,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNewAccountNoExistingAccount_FromManageCardsBubble"> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>battre@chromium.org</owner> <description> @@ -24882,8 +25201,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNewAccountNoExistingAccount_FromSaveCardBubble"> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>battre@chromium.org</owner> <description> @@ -24964,8 +25282,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNewAccountPreDice_FromManageCardsBubble"> <obsolete>Removed M80</obsolete> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>sebsg@chromium.org</owner> <description> @@ -25012,8 +25329,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNewAccountPreDice_FromSaveCardBubble"> <obsolete>Removed M80</obsolete> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>sebsg@chromium.org</owner> <description> @@ -25089,8 +25405,7 @@ should be able to be added at any place in this file. </action> <action name="Signin_SigninNotDefault_FromManageCardsBubble"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded on sign in start from access point @@ -25132,8 +25447,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninNotDefault_FromSaveCardBubble"> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>battre@chromium.org</owner> <description> @@ -25217,8 +25531,7 @@ should be able to be added at any place in this file. </action> <action name="Signin_SigninWithDefault_FromManageCardsBubble"> - <owner>manasverma@google.com</owner> - <owner>jsaul@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <description> Recorded on sign in start from access point @@ -25260,8 +25573,7 @@ should be able to be added at any place in this file. <action name="Signin_SigninWithDefault_FromSaveCardBubble"> <owner>bsazonov@chromium.org</owner> - <owner>jsaul@chromium.org</owner> - <owner>manasverma@google.com</owner> + <owner>jsaul@google.com</owner> <owner>msarda@chromium.org</owner> <owner>battre@chromium.org</owner> <description> @@ -26141,6 +26453,18 @@ should be able to be added at any place in this file. <description>Please enter the description of this user action.</description> </action> +<action name="StatusArea_LiveCaptionDisabled"> + <owner>abigailbklein@google.com</owner> + <description> + Ash system menu: Accessibility: Disable Live Caption + </description> +</action> + +<action name="StatusArea_LiveCaptionEnabled"> + <owner>abigailbklein@google.com</owner> + <description>Ash system menu: Accessibility: Enable Live Caption</description> +</action> + <action name="StatusArea_MagnifierDisabled"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> <description>Please enter the description of this user action.</description> @@ -27397,6 +27721,24 @@ should be able to be added at any place in this file. </description> </action> +<action name="TabGroups_TabGroupBubble_GroupSaved"> + <owner>cyan@chromium.org</owner> + <owner>chrome-desktop-ui-sea@google.com</owner> + <description> + User saved an existing tab group by switching the toggle to the right next + to 'Save group' from the tab group editor bubble. + </description> +</action> + +<action name="TabGroups_TabGroupBubble_GroupUnsaved"> + <owner>cyan@chromium.org</owner> + <owner>chrome-desktop-ui-sea@google.com</owner> + <description> + User unsaved an existing tab group by switching the toggle to the left next + to 'Save group' from the tab group editor bubble. + </description> +</action> + <action name="TabGroups_TabGroupBubble_NameChanged"> <owner>connily@chromium.org</owner> <owner>cyan@chromium.org</owner> @@ -28515,6 +28857,14 @@ should be able to be added at any place in this file. <description>The user set a web app to open in a browser tab.</description> </action> +<action name="WebApp.SetWindowMode.Tabbed"> + <owner>loubrett@google.com</owner> + <owner>desktop-pwas-team@google.com</owner> + <description> + The user set a web app to open in a tabbed app window. + </description> +</action> + <action name="WebApp.SetWindowMode.Window"> <owner>alancutter@chromium.org</owner> <owner>desktop-pwas-team@google.com</owner> @@ -29092,6 +29442,9 @@ should be able to be added at any place in this file. label="For AddToHomescreen IPH feature."/> <suffix name="AddToHomescreenTextBubble" label="For AddToHomescreen IPH feature."/> + <suffix name="AutoDarkOptOut" label="For AutoDarkOptOut dialog feature."/> + <suffix name="AutoDarkUserEducationMessage" + label="For AutoDarkUserEducationMessage feature."/> <suffix name="BadgedReadingList" label="For BadgedReadingList feature."/> <suffix name="Bookmark" label="For Bookmark feature."/> <suffix name="BottomToolbarTip" label="For BottomToolbarTip feature."/> @@ -29144,10 +29497,13 @@ should be able to be added at any place in this file. <suffix name="FeedCardMenu" label="For FeedCardMenu feature."/> <suffix name="FeedHeaderMenu" label="For FeedHeaderMenu feature."/> <suffix name="GlobalMediaControls" label="For GlobalMediaControls feature."/> + <suffix name="GMCCastStartStopFeature" + label="For Global Media Controls Cast start and stop feature."/> <suffix name="HomePageButton" label="For HomePageButton feature."/> <suffix name="HomepageTile" label="For HomepageTile feature."/> <suffix name="IdentityDisc" label="For IdentityDisc feature."/> <suffix name="IncognitoWindow" label="For IncognitoWindow feature."/> + <suffix name="InstanceSwitcher" label="For Instance switcher feature."/> <suffix name="LongPressToolbarTip" label="For LongPressToolbar feature."/> <suffix name="MediaDownload" label="For MediaDownload feature."/> <suffix name="MicToolbar" label="In product help for toolbar mic."/> @@ -29158,6 +29514,7 @@ should be able to be added at any place in this file. label="For NewTabPageHomeButton feature."/> <suffix name="NewTabTip" label="For NewTabTip feature."/> <suffix name="PageInfo" label="In product help for opening PageInfo."/> + <suffix name="PageInfoStoreInfo" label="For PageInfoStoreInfo feature."/> <suffix name="PasswordsAccountStorage" label="For PasswordsAccountStorage feature."/> <suffix name="PreviewsOmniboxUI" @@ -29176,6 +29533,11 @@ should be able to be added at any place in this file. <suffix name="ReopenTab" label="For ReopenTab feature."/> <suffix name="SharedHighlightingBuilder" label="For SharedHighlightingBuilder feature."/> + <suffix name="SharedHighlightingReceiver" + label="For SharedHighlightingReceiver feature."/> + <suffix name="SharingHubLinkToggle" + label="For Sharing Hub link toggle feature."/> + <suffix name="SideSearch" label="For the side search feature."/> <suffix name="StartSurfaceTabSwitcherHomeButton" label="For StartSurfaceTabSwitcherHomeButton feature."/> <suffix name="TabGroupsDragAndDrop" label="For drop-to-merge in tab group."/> @@ -29198,6 +29560,8 @@ should be able to be added at any place in this file. label="For video tutorial summary card."/> <suffix name="VideoTutorial_NTP_VoiceSearch" label="For voice search video tutorial."/> + <suffix name="VideoTutorial_TryNow" + label="For video tutorial Try Now feature."/> <suffix name="WebFeedFollow" label="For Web Feed follow recommendations."/> <suffix name="WebFeedPostFollowDialog" label="For Web Feed successful follow operations."/> diff --git a/chromium/tools/metrics/histograms/README.md b/chromium/tools/metrics/histograms/README.md index b3d0a9f3161..b933c86c850 100644 --- a/chromium/tools/metrics/histograms/README.md +++ b/chromium/tools/metrics/histograms/README.md @@ -685,10 +685,12 @@ This example defines metadata for 12 (= 3 x 4) concrete histograms, such as </histogram> ``` -Note that each token `<variant>` defines what text should be substituted for it, -both in the histogram name and in the summary text. As shorthand, a `<variant>` -that omits the `summary` attribute substitutes the value of the `name` attribute -in the histogram's `<summary>` text as well. +Each token `<variant>` defines what text should be substituted for it, +both in the histogram name and in the summary text. The name part gets +substituted into the histogram name; the summary part gets substituted in +the summary field (the histogram description). As shorthand, a +`<variant>` that omits the `summary` attribute substitutes the value of +the `name` attribute in the histogram's `<summary>` text as well. *** promo Tip: You can declare an optional token by listing an empty name: `<variant diff --git a/chromium/tools/metrics/histograms/enums.xml b/chromium/tools/metrics/histograms/enums.xml index 05ce53ddfe8..9eb471929d5 100644 --- a/chromium/tools/metrics/histograms/enums.xml +++ b/chromium/tools/metrics/histograms/enums.xml @@ -1081,6 +1081,9 @@ Unknown properties are collapsed to zero. --> </enum> <enum name="AccountConsistencyPromoAfterDismissal"> + <obsolete> + Removed 2021-08-23 + </obsolete> <int value="0" label="SignedInOnWebWithDefaultDeviceAccount"> User signed in with the default device account. This account is the first account in the cookies. @@ -1794,6 +1797,14 @@ Unknown properties are collapsed to zero. --> <int value="1" label="NEON support"/> </enum> +<enum name="AndroidAutoDarkModeSettingsChangeSource"> + <summary>See Android.DarkTheme.AutoDarkMode.SettingsChangeSource.*</summary> + <int value="0" label="Theme settings"/> + <int value="1" label="Site settings global"/> + <int value="2" label="App menu"/> + <int value="3" label="Site settings exception list"/> +</enum> + <enum name="AndroidComponentLoaderLoadStatus"> <int value="0" label="Component loaded"/> <int value="1" label="Failed to connect to ComponentsProviderService"/> @@ -1873,6 +1884,7 @@ Unknown properties are collapsed to zero. --> <int value="11" label="OFFLINE_INDICATOR"/> <int value="12" label="OFFLINE_CONTENT_NOTIFICATION"/> <int value="13" label="DOWNLOAD_PROGRESS_MESSAGE"/> + <int value="14" label="DUPLICATE_DOWNLOAD_DIALOG"/> </enum> <enum name="AndroidEnhancedProtectionPromoAction"> @@ -2357,6 +2369,12 @@ Unknown properties are collapsed to zero. --> <int value="4" label="Undos Dismissed (Action) (Deprecated)"/> </enum> +<enum name="AndroidThemeSettingsEntry"> + <summary>See Android.DarkTheme.ThemeSettingsEntry.</summary> + <int value="0" label="Settings"/> + <int value="1" label="Auto dark mode message"/> +</enum> + <enum name="AndroidWebViewActualUiThread"> <obsolete> Removed 02/2020. The ActualUiThread metric has been removed. @@ -2469,6 +2487,7 @@ Unknown properties are collapsed to zero. --> <int value="3" label="Refresh the crash list"/> <int value="4" label="About WebView DevTools"/> <int value="5" label="Components"/> + <int value="6" label="Update the components"/> </enum> <enum name="AndroidWebViewDevUiMetricsTransmission"> @@ -2529,7 +2548,8 @@ Unknown properties are collapsed to zero. --> <enum name="AndroidWebViewSafeModeResult"> <int value="0" label="Success"/> - <int value="1" label="Unknown error"/> + <int value="1" label="Unknown error (Java Exception)"/> + <int value="2" label="At least one action indiciates failure"/> </enum> <enum name="AndroidWebViewSingleOrMultiProcess"> @@ -3037,6 +3057,7 @@ Unknown properties are collapsed to zero. --> <int value="22" label="LAUNCH_SOURCE_ARC"/> <int value="23" label="LAUNCH_SOURCE_INTENT_URL"/> <int value="24" label="LAUNCH_SOURCE_RUN_ON_OS_LOGIN"/> + <int value="25" label="LAUNCH_SOURCE_PROTOCOL_HANDLER"/> </enum> <enum name="AppleScriptCommandEvents"> @@ -3343,8 +3364,8 @@ Unknown properties are collapsed to zero. --> <int value="37" label="Help App (default or help)"/> <int value="38" label="Omnibox, Search Suggest Entity"/> <int value="39" label="Omnibox, Navsuggest"/> - <int value="40" label="Omnibox Rich Entity, Answer"/> - <int value="41" label="Omnibox Rich Entity, Image Entity"/> + <int value="40" label="Omnibox, Answer"/> + <int value="41" label="Omnibox, Calculator"/> <int value="42" label="Local file search"/> <int value="43" label="Drive file search"/> <int value="44" label="Help App (Updates page)"/> @@ -3456,6 +3477,7 @@ Unknown properties are collapsed to zero. --> <int value="11" label="DBus Service (Plugin VM)"/> <int value="12" label="Notification (Plugin VM)"/> <int value="13" label="App Management main view (Borealis)"/> + <int value="14" label="Page info view"/> </enum> <enum name="AppManagementUserAction"> @@ -3532,6 +3554,18 @@ Unknown properties are collapsed to zero. --> <int value="4" label="PROMO_SEEN"/> </enum> +<enum name="AppReadiness"> + <int value="0" label="Unknown"/> + <int value="1" label="Installed and launchable"/> + <int value="2" label="Disabled by SafeBrowsing"/> + <int value="3" label="Disabled by admin policy"/> + <int value="4" label="Disabled by explicit user action"/> + <int value="5" label="Renderer process crashed"/> + <int value="6" label="Uninstalled by user"/> + <int value="7" label="Removed"/> + <int value="8" label="Uninstalled by migration"/> +</enum> + <enum name="AppSeedRequestState"> <obsolete> Removed from code October 2020. @@ -3582,6 +3616,25 @@ Unknown properties are collapsed to zero. --> label="Shortcut install, menu showed 'Install' (failure mode)"/> </enum> +<enum name="AppTypeV2"> + <int value="0" label="Unknown"/> + <int value="1" label="Android app"/> + <int value="2" label="Built-in app"/> + <int value="3" label="Linux app"/> + <int value="4" label="Chrome app opened in a window"/> + <int value="5" label="Chrome app opened in a tab"/> + <int value="6" label="Web app in a window"/> + <int value="7" label="Web app in a tab"/> + <int value="8" label="Mac OS app"/> + <int value="9" label="Plugin VM"/> + <int value="10" label="Standalone browser"/> + <int value="11" label="Remote app"/> + <int value="12" label="Borealis app"/> + <int value="13" label="System web app"/> + <int value="14" label="Chrome browser (inc. web/Chrome apps in tabs)"/> + <int value="15" label="Chrome app opened in Standalone browser"/> +</enum> + <enum name="AppWillTerminateReceived"> <int value="0" label="WasNotReceivedForXte"> ApplicationWillTerminate notification was not received for this XTE. @@ -3766,6 +3819,13 @@ Unknown properties are collapsed to zero. --> <int value="48" label="tel:// Device selected"/> </enum> +<enum name="ArcFileSystemWatcherExceedLimitState"> + <int value="0" + label="inotify exceeds its limit when ArcFileSystemWatcher is started"/> + <int value="1" + label="inotify exceeds its limit while processing a filesystem change"/> +</enum> + <enum name="ArchivemountError"> <int value="0" label="Success">EXIT_SUCCESS</int> <int value="1" label="Failure">EXIT_FAILURE</int> @@ -3839,6 +3899,18 @@ Unknown properties are collapsed to zero. --> <int value="6" label="Web app"/> </enum> +<enum name="ArcMainAccountHashMigrationStatus"> + <int value="0" label="Hash code migration not required as v2 is not set."/> + <int value="1" label="Hash code migration from v2 to v3 successful"/> + <int value="2" label="Hash code migration from v2 to v3 failed"/> + <int value="3" + label="Hash code migration failed as there are multiple account with + the same hash."/> + <int value="4" + label="Hash code migration failed as there are no account matching the + existing valid hash"/> +</enum> + <enum name="ArcMojoConnectionType"> <summary>Types of mojo connections to the ARC container.</summary> <int value="0" label="AppLauncher"/> @@ -5413,6 +5485,19 @@ others/histograms.xml --> <int value="3" label="Initially incomplete & Failure"/> </enum> +<enum name="AutofillAssistantTextToSpeechButtonAction"> + <int value="0" label="Play TTS"/> + <int value="1" label="Disable button"/> + <int value="2" label="Enable button and play TTS"/> +</enum> + +<enum name="AutofillAssistantTextToSpeechEngineEvent"> + <int value="0" label="TTS_EVENT_START"/> + <int value="1" label="TTS_EVENT_END"/> + <int value="2" label="TTS_EVENT_ERROR"/> + <int value="3" label="TTS_EVENT_OTHER"/> +</enum> + <enum name="AutofillAssistantTriggerUIType"> <int value="0" label="UNSPECIFIED_TRIGGER_UI_TYPE"/> <int value="1" label="(External) Shopping cart, first time user"/> @@ -5442,6 +5527,18 @@ others/histograms.xml --> <int value="3" label="Closed without user interaction"/> </enum> +<enum name="AutofillCardUnmaskAuthenticationSelectionDialogResult"> + <int value="0" label="Unspecified"/> + <int value="1" label="User canceled before selecting a challenge option"/> + <int value="2" + label="User canceled after selecting a challenge option, while the + dialog was in pending state"/> + <int value="3" + label="A challenge option was selected and the server returned success"/> + <int value="4" + label="A challenge option was selected and the server returned failure"/> +</enum> + <enum name="AutofillCardUploadDecision"> <obsolete> Deprecated as of 2/2016, replaced by AutofillCardUploadDecisionExpanded. @@ -5510,6 +5607,7 @@ others/histograms.xml --> <int value="9" label="User is logged into an unsupported domain"/> <int value="10" label="Card upload feature flag disabled"/> <int value="11" label="Success, card upload enabled"/> + <int value="12" label="User is in an unlaunched/unsupported country"/> </enum> <enum name="AutofillCreditCardAuthenticationEvents"> @@ -6374,6 +6472,46 @@ others/histograms.xml --> <int value="2" label="User did not interact with the infobar"/> </enum> +<enum name="AutofillOtpAuthEvent"> + <int value="0" label="Unknown result"/> + <int value="1" label="OTP auth succeeded"/> + <int value="2" label="OTP auth failed due to flow being cancelled"/> + <int value="3" + label="OTP auth failed due to generic error in SelectChallengeOption + request"/> + <int value="4" + label="OTP auth failed due to virtual card retrieval error in + SelectChallengeOption request"/> + <int value="5" + label="OTP auth failed due to auth error in UnmaskCard request"/> + <int value="6" + label="OTP auth failed due to virtual card retrieval error in + UnmaskCard request"/> + <int value="7" label="OTP auth temporarily failed due to OTP being expired"/> + <int value="8" + label="OTP auth temporarily failed due to OTP being incorrect"/> +</enum> + +<enum name="AutofillOtpInputDialogError"> + <int value="0" label="Unknown error"/> + <int value="1" label="OTP expired temporary error was shown"/> + <int value="2" label="OTP mismatch temporary error was shown"/> +</enum> + +<enum name="AutofillOtpInputDialogResult"> + <int value="0" label="Unknown result"/> + <int value="1" + label="User closed the OTP input dialog before pressing the OK button"/> + <int value="3" + label="User closed the OTP input dialog after pressing the OK button"/> + <int value="4" + label="OTP input dialog closed automatically after the OTP verification + succeeded"/> + <int value="5" + label="OTP input dialog closed automatically after a server failure + response"/> +</enum> + <enum name="AutofillPredictionSource"> <int value="0" label="PREDICTION_SOURCE_UNKNOWN"/> <int value="1" label="PREDICTION_SOURCE_HEURISTIC"/> @@ -6526,6 +6664,21 @@ others/histograms.xml --> <int value="2" label="Some other item selected"/> </enum> +<enum name="AutofillServerCardUnmaskResult"> + <int value="0" label="Unknown result"/> + <int value="1" label="Local cache hit"/> + <int value="2" + label="Completed risk-based unmasking, no user-facing authentication"/> + <int value="3" label="Completed unmasking via authentication"/> + <int value="4" label="Authentication-related errors"/> + <int value="5" label="Virtual-card-retrieval-related errors"/> + <int value="6" label="Flow was cancelled"/> + <int value="7" + label="FIDO option was the only option provided but user has not opted + in"/> + <int value="8" label="Unexpected errors"/> +</enum> + <enum name="AutofillServerFieldType"> <int value="0" label="NO_SERVER_DATA"/> <int value="1" label="UNKNOWN_TYPE"/> @@ -6838,7 +6991,7 @@ others/histograms.xml --> <int value="0" label="Unknown"/> <int value="1" label="User closed bubble via corner X"/> <int value="2" label="User did not interact with the bubble"/> - <int value="3" label="Bubble lost focus and was deactivated"/> + <int value="3" label="[Deprecated] Bubble lost focus and was deactivated"/> </enum> <enum name="AutofillWalletAddressConversionType"> @@ -6997,7 +7150,7 @@ others/histograms.xml --> <int value="6" label="Destination URL scheme is not HTTP(S) (removed)"/> <int value="7" label="Same site navigation, same-site proactive swap disabled"/> - <int value="8" label="Error page"/> + <int value="8" label="Error page (removed)"/> <int value="9" label="Already has matching browsing instance"/> <int value="10" label="Renderer debug URL"/> <int value="11" label="Not enabled and not needed for back-forward cache"/> @@ -7053,6 +7206,8 @@ others/histograms.xml --> <int value="131080" label="kContent-kWebBluetooth"/> <int value="131081" label="kContent-kWebUSB"/> <int value="131082" label="kContent-kMediaSession"/> + <int value="131083" label="kContent-kMediaSessionService"/> + <int value="131084" label="kContent-kMediaPlay"/> <int value="196608" label="kEmbedder-kUnknown"/> <int value="196609" label="kEmbedder-kPopupBlockerTabHelper"/> <int value="196610" label="kEmbedder-kSafeBrowsingTriggeredPopupBlocker"/> @@ -7098,6 +7253,42 @@ others/histograms.xml --> <int value="58230" label="MediaWebContentsObserver::OnMediaPlaying"/> </enum> +<enum name="BackForwardCacheDisallowActivationReason"> + <int value="0" label="ForTesting"/> + <int value="1" label="LoadPostCommitErrorPage"/> + <int value="2" label="BeginNavigation"/> + <int value="3" label="CapturePaintPreview"/> + <int value="4" label="OpenURL"/> + <int value="5" label="AXEvent"/> + <int value="6" label="AXLocationChange"/> + <int value="7" label="AXUpdateTree"/> + <int value="8" label="AXHitTest"/> + <int value="9" label="AXHitTestCallback"/> + <int value="10" label="AXPerformAction"/> + <int value="11" label="AXSetFocus"/> + <int value="12" label="AXGetNativeView"/> + <int value="13" label="AXGetNativeViewForWindow"/> + <int value="14" label="AXWebContents"/> + <int value="15" label="CertificateErrors"/> + <int value="16" label="CreateChildFrame"/> + <int value="17" label="CommitSameDocumentNavigation"/> + <int value="18" label="FullScreenStateChanged"/> + <int value="19" label="SetNeedsOcclusionTrack"/> + <int value="20" label="DispatchLoad"/> + <int value="21" label="ForwardResourceTimingToParent"/> + <int value="22" label="CapturePaintPreviewProxy"/> + <int value="23" label="ShowContextMenu"/> + <int value="24" label="DetermineActionForHistoryNavigation"/> + <int value="25" label="NavigatingInInactiveFrame"/> + <int value="26" label="PostMessage"/> + <int value="27" label="RequestPermission"/> + <int value="28" label="PermissionRequestSource"/> + <int value="29" label="PermissionAddRequest"/> + <int value="30" label="ContentsPreferredSizeChanged"/> + <int value="31" label="BeginDownload"/> + <int value="32" label="Bug1234857"/> +</enum> + <enum name="BackForwardCacheEligibilityDuringCommit"> <int value="0" label="No longer bfcache-eligible"/> <int value="1" label="Still bfcache-eligible"/> @@ -7174,12 +7365,18 @@ others/histograms.xml --> token, and an experimental config which requires it is active"/> <int value="50" label="Unload handler exists in the main frame, and the current - experimental config doesn't permit it to be BFCached. (removed)"/> + experimental config doesn't permit it to be BFCached."/> <int value="51" label="Unload handler exists in a sub frame, and the current experimental config doesn't permit it to be BFCached."/> <int value="52" label="ServiceWorker is unregistered"/> - <int value="53" label="No valid HTTP response header"/> + <int value="53" label="CacheControlNoStore is present"/> + <int value="54" + label="CacheControlNoStore is present and cookie is modified"/> + <int value="55" + label="CacheControlNoStore is present and HTTPOnly cookie is modified"/> + <int value="56" label="No valid HTTP response header"/> + <int value="57" label="Disallow activation navigations for Bug1234857"/> </enum> <enum name="BackForwardCacheReloadsAfterHistoryNavigation"> @@ -7415,6 +7612,8 @@ Called by update_bad_message_reasons.py.--> <int value="2" label="PMF_INVALID_INITIATOR_ORIGIN"/> <int value="3" label="RFH_INVALID_WEB_UI_CONTROLLER"/> <int value="4" label="RFH_DISPLAY_CAPTURE_PERMISSION_MISSING"/> + <int value="5" label="MSFD_MULTIPLE_CLOSURES_OF_FOCUSABILITY_WINDOW"/> + <int value="6" label="MSFD_MULTIPLE_EXPLICIT_CALLS_TO_FOCUS"/> </enum> <enum name="BadMessageReasonContent"> @@ -7629,7 +7828,7 @@ Called by update_bad_message_reasons.py.--> <int value="191" label="ARH_UNEXPECTED_BITSTREAM"/> <int value="192" label="RDH_NULL_CLIENT"/> <int value="193" label="RVH_WEB_UI_BINDINGS_MISMATCH"/> - <int value="194" label="WCI_NEW_WIDGET_PROCESS_MISMATCH"/> + <int value="194" label="OBSOLETE_WCI_NEW_WIDGET_PROCESS_MISMATCH"/> <int value="195" label="AUTH_INVALID_EFFECTIVE_DOMAIN"/> <int value="196" label="AUTH_INVALID_RELYING_PARTY"/> <int value="197" label="RWH_COPY_REQUEST_ATTEMPT"/> @@ -7643,7 +7842,7 @@ Called by update_bad_message_reasons.py.--> <int value="205" label="RFH_ERROR_PROCESS_NON_ERROR_COMMIT"/> <int value="206" label="RFH_ERROR_PROCESS_NON_UNIQUE_ORIGIN_COMMIT"/> <int value="207" label="OBSOLETE_RFH_CANNOT_RENDER_FALLBACK_CONTENT"/> - <int value="208" label="RFH_CHILD_FRAME_NEEDS_OWNER_ELEMENT_TYPE"/> + <int value="208" label="OBSOLETE_RFH_CHILD_FRAME_NEEDS_OWNER_ELEMENT_TYPE"/> <int value="209" label="OBSOLETE_RFH_INVALID_WEB_REPORTING_CRASH_ID"/> <int value="210" label="RFH_DETACH_MAIN_FRAME"/> <int value="211" label="RFH_BROWSER_INTERFACE_BROKER_MISSING"/> @@ -7686,7 +7885,15 @@ Called by update_bad_message_reasons.py.--> <int value="248" label="MDDH_NOT_TOP_LEVEL"/> <int value="249" label="RFH_DID_CHANGE_IFRAME_ATTRIBUTE"/> <int value="250" label="FARI_LOGOUT_BAD_ENDPOINT"/> - <int value="251" label="RFH_CHILD_FRAME_UNEXPECTED_OWNER_ELEMENT_TYPE"/> + <int value="251" + label="OBSOLETE_RFH_CHILD_FRAME_UNEXPECTED_OWNER_ELEMENT_TYPE"/> + <int value="252" label="RFH_POPUP_REQUEST_WHILE_PRERENDERING"/> + <int value="253" label="RFH_INTERECEPT_DOWNLOAD_WHILE_INACTIVE"/> + <int value="254" label="RFH_CREATE_CHILD_FRAME_SANDBOX_FLAGS"/> + <int value="258" label="RFH_FENCED_FRAME_MOJO_WHEN_DISABLED"/> + <int value="259" label="PMM_SUBSCRIBE_INVALID_ORIGIN"/> + <int value="260" label="PMM_UNSUBSCRIBE_INVALID_ORIGIN"/> + <int value="261" label="PMM_GET_SUBSCRIPTION_INVALID_ORIGIN"/> </enum> <enum name="BadMessageReasonExtensions"> @@ -7736,21 +7943,22 @@ Called by update_bad_message_reasons.py.--> <!-- Generated from components/password_manager/content/browser/bad_message.h. Called by update_bad_message_reasons.py.--> - <int value="1" label="CPMD_BAD_ORIGIN_FORMS_PARSED"/> - <int value="2" label="CPMD_BAD_ORIGIN_FORMS_RENDERED"/> + <int value="1" label="CPMD_BAD_ORIGIN_FORMS_PARSED_OBSOLETE"/> + <int value="2" label="CPMD_BAD_ORIGIN_FORMS_RENDERED_OBSOLETE"/> <int value="3" label="CPMD_BAD_ORIGIN_FORM_SUBMITTED"/> <int value="4" label="CPMD_BAD_ORIGIN_FOCUSED_PASSWORD_FORM_FOUND_OBSOLETE"/> - <int value="5" label="CPMD_BAD_ORIGIN_IN_PAGE_NAVIGATION"/> + <int value="5" label="CPMD_BAD_ORIGIN_IN_PAGE_NAVIGATION_OBSOLETE"/> <int value="6" label="CPMD_BAD_ORIGIN_PASSWORD_NO_LONGER_GENERATED"/> <int value="7" label="CPMD_BAD_ORIGIN_PRESAVE_GENERATED_PASSWORD"/> <int value="8" - label="CPMD_BAD_ORIGIN_SAVE_GENERATION_FIELD_DETECTED_BY_CLASSIFIER"/> - <int value="9" label="CPMD_BAD_ORIGIN_UPON_USER_INPUT_CHANGE"/> + label="CPMD_BAD_ORIGIN_SAVE_GENERATION_FIELD_DETECTED_BY_CLASSIFIER_OBSOLETE"/> + <int value="9" label="CPMD_BAD_ORIGIN_UPON_USER_INPUT_CHANGE_OBSOLETE"/> <int value="10" label="CPMD_BAD_ORIGIN_AUTOMATIC_GENERATION_STATUS_CHANGED"/> <int value="11" label="CPMD_BAD_ORIGIN_SHOW_MANUAL_PASSWORD_GENERATION_POPUP"/> <int value="12" label="CPMD_BAD_ORIGIN_SHOW_PASSWORD_EDITING_POPUP_OBSOLETE"/> - <int value="13" label="CPMD_BAD_ORIGIN_GENERATION_AVAILABLE_FOR_FORM"/> + <int value="13" + label="CPMD_BAD_ORIGIN_GENERATION_AVAILABLE_FOR_FORM_OBSOLETE"/> <int value="14" label="CPMD_BAD_ORIGIN_PRERENDERING"/> </enum> @@ -7834,6 +8042,7 @@ Called by update_bad_message_reasons.py.--> <int value="2" label="Manual fallback sheet"/> <int value="3" label="List of all passwords"/> <int value="4" label="Account chooser dialog"/> + <int value="5" label="Password check - Automated password change"/> </enum> <enum name="BiometricAuthResult"> @@ -8989,6 +9198,11 @@ Called by update_bad_message_reasons.py.--> <int value="1" label="Error"/> </enum> +<enum name="BooleanEscaped"> + <int value="0" label="No Characters Escaped"/> + <int value="1" label="Escaped One or More Characters"/> +</enum> + <enum name="BooleanEverConnected"> <int value="0" label="Never connected"/> <int value="1" label="Previously connected"/> @@ -9312,6 +9526,11 @@ Called by update_bad_message_reasons.py.--> <int value="1" label="Adaptive icon"/> </enum> +<enum name="BooleanIsAddToCart"> + <int value="0" label="Not Add-to-cart"/> + <int value="1" label="Is Add-to-cart"/> +</enum> + <enum name="BooleanIsGenerationTriggeredManually"> <int value="0" label="Password generation was triggered automatically"/> <int value="1" label="A user triggered password generation"/> @@ -9377,6 +9596,11 @@ Called by update_bad_message_reasons.py.--> <int value="1" label="Top Level"/> </enum> +<enum name="BooleanIsTransaction"> + <int value="0" label="Not Transaction"/> + <int value="1" label="Is Transaction"/> +</enum> + <enum name="BooleanIsUseRelinker"> <obsolete> Removed in 2019-07. @@ -9673,6 +9897,11 @@ Called by update_bad_message_reasons.py.--> <int value="1" label="Profile was Signed In"/> </enum> +<enum name="BooleanQueried"> + <int value="0" label="Not Queried"/> + <int value="1" label="Queried"/> +</enum> + <enum name="BooleanRaced"> <int value="0" label="Did Not Race"/> <int value="1" label="Raced"/> @@ -9703,6 +9932,11 @@ Called by update_bad_message_reasons.py.--> <int value="1" label="A recurrent error"/> </enum> +<enum name="BooleanRedirected"> + <int value="0" label="Not redirected"/> + <int value="1" label="Redirected"/> +</enum> + <enum name="BooleanRegistered"> <int value="0" label="Not Registered"/> <int value="1" label="Registered"/> @@ -9779,6 +10013,9 @@ Called by update_bad_message_reasons.py.--> </enum> <enum name="BooleanSafeMode"> + <obsolete> + Deprecated 9/2021. Replaced by VariationsSeedUsage. + </obsolete> <int value="0" label="Regular mode"/> <int value="1" label="Safe mode"/> </enum> @@ -9866,6 +10103,11 @@ Called by update_bad_message_reasons.py.--> <int value="1" label="Streamed"/> </enum> +<enum name="BooleanSubmitted"> + <int value="0" label="Not submitted"/> + <int value="1" label="Submitted"/> +</enum> + <enum name="BooleanSuccess"> <int value="0" label="Failure"/> <int value="1" label="Success"/> @@ -10054,6 +10296,11 @@ Called by update_bad_message_reasons.py.--> <int value="1" label="Initialized to be read frequently"/> </enum> +<enum name="BooleanWin11MenuStyle"> + <int value="0" label="Prior to Win11 Style"/> + <int value="1" label="Win11 Style"/> +</enum> + <enum name="BooleanWiped"> <int value="0" label="Re-enabled"/> <int value="1" label="Wiped out"/> @@ -10484,6 +10731,10 @@ Called by update_bad_message_reasons.py.--> </enum> <enum name="CanvasContextType"> + <obsolete> + Deprecated 09/2021 with the removal of the Blink.Canvas.ContextType and + Blink.OffscreenCanvas.ContextType histograms + </obsolete> <int value="0" label="2d"/> <int value="1" label="(obsolete) webkit-3d"/> <int value="2" label="experimental-webgl"/> @@ -10601,6 +10852,21 @@ Called by update_bad_message_reasons.py.--> <int value="11" label="Aborted because there was no surface"/> </enum> +<enum name="CanvasOverdrawOp"> + <int value="0" label="None (should have 0 counts)"/> + <int value="1" label="Total ops"/> + <int value="2" label="ClearRect op"/> + <int value="3" label="FillRect op"/> + <int value="4" label="PutImageData op"/> + <int value="5" label="DrawImage op"/> + <int value="6" label="ContextReset op"/> + <int value="7" label="ClearForSrcBlendMode op"/> + <int value="8" label="Has opaque shader"/> + <int value="9" label="Has transform"/> + <int value="10" label="Has source-over blend mode"/> + <int value="11" label="Has clear blend mode"/> +</enum> + <enum name="CanvasRenderingAPI"> <int value="0" label="2d"/> <int value="1" label="webgl"/> @@ -10735,6 +11001,7 @@ Called by update_bad_message_reasons.py.--> <int value="4" label="Power Menu"/> <int value="5" label="Snip Key"/> <int value="6" label="Full Screenshot Accelerator"/> + <int value="7" label="Projector app"/> </enum> <enum name="CapturePixelFormat"> @@ -11085,7 +11352,7 @@ histogram as enum --> <int value="25" label="kExploreSites"/> <int value="26" label="kLegacyStrikes"/> <int value="27" label="kWebrtcEventLogs"/> - <int value="28" label="kDrmLicenses"/> + <int value="28" label="kCdmLicenses"/> <int value="29" label="kHostCache"/> <int value="30" label="kTpmAttestationKeys"/> <int value="31" label="kStrikes"/> @@ -11887,6 +12154,21 @@ In case of new special images, values 3 to 9 can be used. --> <int value="90" label="Sneaker"/> <int value="91" label="Van"/> <int value="92" label="Watermelon"/> + <int value="93" label="Person watering plants"/> + <int value="94" label="Person daydreaming"/> + <int value="95" label="Person with flowers"/> + <int value="96" label="Person with cats"/> + <int value="97" label="Artist"/> + <int value="98" label="Person doing tai chi"/> + <int value="99" label="Signing thank you"/> + <int value="100" label="Person with coffee"/> + <int value="101" label="Dog wagging tail"/> + <int value="102" label="Nurse"/> + <int value="103" label="Gamer"/> + <int value="104" label="Bookworm"/> + <int value="105" label="Biking"/> + <int value="106" label="Person in snow"/> + <int value="107" label="Person with megaphone"/> </enum> <enum name="ChromePDFViewerActions"> @@ -12712,6 +12994,25 @@ In case of new special images, values 3 to 9 can be used. --> <int value="7" label="Unknown"/> </enum> +<enum name="ClearOnExitSyncEvent"> + <int value="0" label="Profile startup, sync is disabled"/> + <int value="1" label="Profile startup, sync is paused"/> + <int value="2" label="Profile startup, sync is active"/> + <int value="3" label="Re-login to a sync paused account"/> + <int value="4" label="Logout of a sync paused account"/> + <int value="5" + label="Profile shutdown, sync is active, started paused, consent change"/> + <int value="6" + label="Profile shutdown, sync is active, started paused, no consent + change"/> + <int value="7" + label="Profile shutdown, sync is active, started active, consent change"/> + <int value="8" + label="Profile shutdown, sync is active, started active, no consent + change"/> + <int value="9" label="Profile shutdown, sync is paused"/> +</enum> + <enum name="ClearServerDataEvents"> <int value="0" label="Clear server data started"/> <int value="1" label="Catchup configuration failed"/> @@ -12779,6 +13080,7 @@ In case of new special images, values 3 to 9 can be used. --> <int value="2" label="From backup"/> <int value="3" label="New"/> <int value="4" label="From provisional id"/> + <int value="5" label="From external"/> </enum> <enum name="ClientSidePhishingResult"> @@ -13462,6 +13764,13 @@ Called by update_net_error_codes.py.--> <int value="1" label="Header present"/> </enum> +<enum name="ConditionalFocusDecision"> + <int value="0" label="kExplicitFocusCapturedSurface"/> + <int value="1" label="kExplicitNoFocusChange"/> + <int value="2" label="kMicrotaskClosedWindow"/> + <int value="3" label="kBrowserSideTimerClosedWindow"/> +</enum> + <enum name="ConfigParsingEvent"> <int value="0" label="SUCCESS"/> <int value="1" label="FAILURE"/> @@ -13478,6 +13787,7 @@ Called by update_net_error_codes.py.--> <int value="12" label="FAILURE_SESSION_RATE_IMPACT_UNKNOWN_FEATURE"/> <int value="13" label="FAILURE_TRACKING_ONLY_PARSE"/> <int value="14" label="SUCCESS_FROM_SOURCE"/> + <int value="15" label="FAILURE_SNOOZE_PARAMS_PARSE"/> </enum> <enum name="ConfusionMatrix"> @@ -14042,6 +14352,11 @@ Called by update_net_error_codes.py.--> <int value="77" label="Federated identity sharing"/> <int value="78" label="Federated identity request"/> <int value="79" label="Javascript JIT"/> + <int value="80" label="HTTP allowed"/> + <int value="81" label="Formfill metadata"/> + <int value="82" label="Federated identity active session"/> + <int value="83" label="Auto-darken web content"/> + <int value="84" label="Request desktop site"/> </enum> <enum name="ContentTypeParseableResult"> @@ -14284,7 +14599,8 @@ Called by update_net_error_codes.py.--> <int value="19" label="Go to URL"/> <int value="20" label="Copy link to text"/> <int value="21" label="Search Image with Google Lens"/> - <int value="22" label="Search part of page with Google Lens"/> + <int value="22" label="Search Images with Google Lens"/> + <int value="23" label="Search Images with non-Google visual search provider"/> </enum> <enum name="ContextMenuOptionIOS"> @@ -14655,12 +14971,36 @@ Called by update_net_error_codes.py.--> <int value="15" label="UI button shown"/> </enum> +<enum name="ConversionPostSendReportDeleteEvent"> + <int value="0" label="Started"/> + <int value="1" label="Succeeded"/> + <int value="2" label="Failed"/> +</enum> + +<enum name="ConversionReportSendOutcome"> + <int value="0" label="Sent"/> + <int value="1" label="Failed due to error"/> + <int value="2" label="Dropped due to embedder disabling the API"/> +</enum> + <enum name="ConversionReportStatus"> <int value="0" label="OK"/> <int value="1" label="Internal network error"/> <int value="2" label="External non-200 HTTP error"/> </enum> +<enum name="ConversionStorageCreateReportStatus"> + <int value="0" label="Success"/> + <int value="1" label="Success, but dropped lower-priority report"/> + <int value="2" label="Internal error"/> + <int value="3" label="No capacity for conversion destination"/> + <int value="4" label="No matching impressions"/> + <int value="5" label="Deduplicated against existing report"/> + <int value="6" label="Rate-limited"/> + <int value="7" label="Priority lower than existing reports"/> + <int value="8" label="Dropped for noise"/> +</enum> + <enum name="ConversionStorageSqlInitStatus"> <int value="0" label="Success"/> <int value="1" label="Failed to open DB in memory"/> @@ -15070,6 +15410,8 @@ Called by update_net_error_codes.py.--> <int value="22" label="kHeaderDisallowedByPreflightResponse"/> <int value="23" label="kRedirectContainsCredentials"/> <int value="24" label="kInsecurePrivateNetwork"/> + <int value="25" label="kInvalidPrivateNetworkAccess"/> + <int value="26" label="kUnexpectedPrivateNetworkAccess"/> </enum> <enum name="CorsAccessCheckResult"> @@ -16630,6 +16972,7 @@ metrics consent we also won't be able to send UMA metrics. --> <int value="13" label="AlreadyUploaded"/> <int value="14" label="TooManyRequests"/> <int value="15" label="RetryUploading"/> + <int value="16" label="LaCrosVersionTooOld"/> </enum> <enum name="CrosDiagnosticsRoutineResult"> @@ -19034,6 +19377,10 @@ Called by update_debug_scenarios.py.--> <int value="4" label="kDebugBrowserVsRendererOriginToCommit"/> <int value="5" label="kDebugBackForwardCacheEvictRestoreRace"/> <int value="6" label="kDebugNoResponseHeadForHttpOrHttps"/> + <int value="7" label="kDebugSubframeProxyCreationWithNoRVH"/> + <int value="8" label="kDebugBackForwardCacheEntryExistsOnSubframeHistoryNav"/> + <int value="9" label="kDebugNoRenderFrameProxyHostOnSetFocusedFrame"/> + <int value="10" label="kDebugNoRestoredRFHOnNonRestartedNavigation"/> </enum> <enum name="DeclarativeAPIFunctionType"> @@ -19089,7 +19436,7 @@ Called by update_debug_scenarios.py.--> </enum> <enum name="DefaultAppName"> - <int value="10" label="Calculator"/> + <int value="10" label="Calculator Chrome App"/> <int value="11" label="Text"/> <int value="12" label="Get Help"/> <int value="13" label="Gallery"/> @@ -19124,7 +19471,10 @@ Called by update_debug_scenarios.py.--> <int value="43" label="PrintManagementApp"/> <int value="45" label="ShimlessRMAApp"/> <int value="46" label="OSFeedbackApp"/> - <int value="47" label="A4"/> + <int value="47" label="Cursive"/> + <int value="48" label="Media App Audio"/> + <int value="49" label="Projector"/> + <int value="50" label="Calculator"/> </enum> <enum name="DefaultBrowserAsyncAttemptResult"> @@ -19312,6 +19662,7 @@ Called by update_debug_scenarios.py.--> <int value="1" label="Keyboard shortcut"/> <int value="2" label="Desks restore on first signin"/> <int value="3" label="Template Launched"/> + <int value="4" label="Drag and drop window on the new desk button"/> </enum> <enum name="DesksMoveWindowFromActiveDeskSource"> @@ -19562,6 +19913,9 @@ Called by update_debug_scenarios.py.--> </enum> <enum name="DevToolsColorPickerFixedColor"> + <obsolete> + Removed in M95. + </obsolete> <int value="0" label="AA"/> <int value="1" label="AAA"/> <int value="2" label="APCA"/> @@ -19575,6 +19929,11 @@ Called by update_debug_scenarios.py.--> <int value="1" label="Grouping disabled"/> </enum> +<enum name="DevToolsConsoleShowsCorsErrors"> + <int value="0" label="CORS errors disabled"/> + <int value="1" label="CORS errors enabled"/> +</enum> + <enum name="DevToolsCssEditorOpened"> <int value="0" label="Color Picker opened"/> <int value="1" label="Shadow Editor opened"/> @@ -19658,6 +20017,13 @@ Called by update_debug_scenarios.py.--> <int value="43" label="ignoreListJSFramesOnTimeline"/> <int value="44" label="contrastIssues"/> <int value="45" label="experimentalCookieFeatures"/> + <int value="46" label="localizedDevTools"/> + <int value="47" label="bfcacheDebugging"/> + <int value="48" label="hideIssuesFeature"/> + <int value="49" label="reportingApiDebugging"/> + <int value="50" label="syncSettings"/> + <int value="51" label="groupAndHideIssuesByKind"/> + <int value="52" label="cssTypeComponentLength"/> </enum> <enum name="DevToolsGridOverlayOpenedFrom"> @@ -19961,6 +20327,92 @@ Called by update_debug_scenarios.py.--> <int value="103" label="layers.down"/> <int value="104" label="layers.left"/> <int value="105" label="layers.right"/> + <int value="106" label="help.report-translation-issue"/> +</enum> + +<enum name="DevToolsLanguage"> + <int value="1" label="af - Afrikaans"/> + <int value="2" label="am - Amharic"/> + <int value="3" label="ar - Arabic"/> + <int value="4" label="as - Assamese"/> + <int value="5" label="az - Azerbaijani"/> + <int value="6" label="be - Belarusian"/> + <int value="7" label="bg - Bulgarian"/> + <int value="8" label="bn - Bangla"/> + <int value="9" label="bs - Bosnian"/> + <int value="10" label="ca - Catalan"/> + <int value="11" label="cs - Czech"/> + <int value="12" label="cy - Welsh"/> + <int value="13" label="da - Danish"/> + <int value="14" label="de - German"/> + <int value="15" label="el - Greek"/> + <int value="16" label="en-GB - British English"/> + <int value="17" label="en-US - American English"/> + <int value="18" label="es-419 - Latin American Spanish"/> + <int value="19" label="es - Spanish"/> + <int value="20" label="et - Estonian"/> + <int value="21" label="eu - Basque"/> + <int value="22" label="fa - Persian"/> + <int value="23" label="fi - Finnish"/> + <int value="24" label="fil - Filipino"/> + <int value="25" label="fr-CA - Canadian French"/> + <int value="26" label="fr - French"/> + <int value="27" label="gl - Galician"/> + <int value="28" label="gu - Gujarati"/> + <int value="29" label="he - Hebrew"/> + <int value="30" label="hi - Hindi"/> + <int value="31" label="hr - Croatian"/> + <int value="32" label="hu - Hungarian"/> + <int value="33" label="hy - Armenian"/> + <int value="34" label="id - Indonesian"/> + <int value="35" label="is - Icelandic"/> + <int value="36" label="it - Italian"/> + <int value="37" label="ja - Japanese"/> + <int value="38" label="ka - Georgian"/> + <int value="39" label="kk - Kazakh"/> + <int value="40" label="km - Khmer"/> + <int value="41" label="kn - Kannada"/> + <int value="42" label="ko - Korean"/> + <int value="43" label="ky - Kyrgyz"/> + <int value="44" label="lo - Lao"/> + <int value="45" label="lt - Lithuanian"/> + <int value="46" label="lv - Latvian"/> + <int value="47" label="mk - Macedonian"/> + <int value="48" label="ml - Malayalam"/> + <int value="49" label="mn - Mongolian"/> + <int value="50" label="mr - Marathi"/> + <int value="51" label="ms - Malay"/> + <int value="52" label="my - Burmese"/> + <int value="53" label="ne - Nepali"/> + <int value="54" label="nl - Dutch"/> + <int value="55" label="no - Norwegian"/> + <int value="56" label="or - Odia"/> + <int value="57" label="pa - Punjabi"/> + <int value="58" label="pl - Polish"/> + <int value="59" label="pt-PT - European Portuguese"/> + <int value="60" label="pt - Portuguese"/> + <int value="61" label="ro - Romanian"/> + <int value="62" label="ru - Russian"/> + <int value="63" label="si - Sinhala"/> + <int value="64" label="sk - Slovak"/> + <int value="65" label="sl - Slovenian"/> + <int value="66" label="sq - Albanian"/> + <int value="67" label="sr-Latn - Serbian (Latin)"/> + <int value="68" label="sr - Serbian"/> + <int value="69" label="sv - Swedish"/> + <int value="70" label="sw - Swahili"/> + <int value="71" label="ta - Tamil"/> + <int value="72" label="te - Telugu"/> + <int value="73" label="th - Thai"/> + <int value="74" label="tr - Turkish"/> + <int value="75" label="uk - Ukrainian"/> + <int value="76" label="ur - Urdu"/> + <int value="77" label="uz - Uzbek"/> + <int value="78" label="vi - Vietnamese"/> + <int value="79" label="zh - Chinese"/> + <int value="80" label="zh-HK - Chinese (Hong Kong)"/> + <int value="81" label="zh-TW - Chinese (Taiwan)"/> + <int value="82" label="zu - Zulu"/> </enum> <enum name="DevToolsLinearMemoryInspectorRevealedFrom"> @@ -20211,6 +20663,7 @@ Called by update_debug_scenarios.py.--> <int value="109" label="File handling permission request"/> <int value="110" label="Enterprise confirmation"/> <int value="111" label="App Identity Update Confirmation"/> + <int value="112" label="Bluetooth device pairing credentials"/> </enum> <enum name="DialogOriginRelationship"> @@ -20239,6 +20692,9 @@ Called by update_debug_scenarios.py.--> </enum> <enum name="DifferentPrimaryAccounts"> + <obsolete> + No longer used after 2021-05 and the switch to OAuthMultilogin. + </obsolete> <int value="0" label="Primary Accounts the same"/> <int value="1" label="(obsolete) Primary Accounts different"/> <int value="2" label="No GAIA account in cookie jar"/> @@ -20641,6 +21097,15 @@ Called by update_debug_scenarios.py.--> <int value="2" label="Updated stale entry"/> </enum> +<enum name="DNS.HttpUpgradeResult"> + <int value="0" label="HTTPS record received; upgrade triggered"/> + <int value="1" label="No HTTPS record received"/> + <int value="2" label="HTTPS record received; no upgrade (already https/wss)"/> + <int value="3" label="HTTPS record received; no upgrade (not http(s)/ws(s))"/> + <int value="4" + label="HTTPS record received; http/ws; no upgrade (Finch-disabled)"/> +</enum> + <enum name="DNS.StaleHostResolverRequestOutcome"> <int value="0" label="Returned synchronously (cache, hosts, IP literal etc.)"/> @@ -20656,6 +21121,15 @@ Called by update_debug_scenarios.py.--> <int value="7" label="Returned stale result synchronously."/> </enum> +<enum name="DNS.SvcbHttpsTransactionError"> + <int value="0" label="No transaction error"/> + <int value="1" label="Insecure DNS transaction error (never task-fatal)"/> + <int value="2" label="Non-task-fatal Secure DNS transaction error"/> + <int value="3" + label="Would be task-fatal transaction error but finch param disabled"/> + <int value="4" label="Task-fatal transaction error"/> +</enum> + <enum name="DNS.UdpIdMismatchStatus"> <obsolete> Metrics removed from code 2021-01. @@ -22572,6 +23046,43 @@ Called by update_document_policy_enum.py.--> <int value="4" label="Write to already failed file"/> </enum> +<enum name="DownloadShelfContextMenuAction"> + <int value="0" label="Drop down shown"/> + <int value="1" label="Drop down enabled"/> + <int value="2" label="Show in folder enabled"/> + <int value="3" label="Show in folder clicked"/> + <int value="4" label="Open when complete enabled"/> + <int value="5" label="Open when complete clicked"/> + <int value="6" label="Always open type enabled"/> + <int value="7" label="Always open type clicked"/> + <int value="8" label="Open enabled"/> + <int value="9" label="Open clicked"/> + <int value="10" label="Cancel enabled"/> + <int value="11" label="Cancel clicked"/> + <int value="12" label="Pause enabled"/> + <int value="13" label="Pause clicked"/> + <int value="14" label="Resume Enabled"/> + <int value="15" label="Resume clicked"/> + <int value="16" label="Discard Enabled"/> + <int value="17" label="Discard Clicked"/> + <int value="18" label="Keep Enabled"/> + <int value="19" label="Keep Clicked"/> + <int value="20" label="Learn more scanning enabled"/> + <int value="21" label="Learn more scanning clicked"/> + <int value="22" label="Learn more interrupted enabled"/> + <int value="23" label="Learn more interrupted clicked"/> + <int value="24" label="Learn more mixed content enabled"/> + <int value="25" label="Learn more mixed content clicked"/> + <int value="26" label="Copy to clipboard enabled"/> + <int value="27" label="Copy to clipboard clicked"/> + <int value="28" label="Annotate enabled"/> + <int value="29" label="Annotate clicked"/> + <int value="30" label="Deep scan enabled"/> + <int value="31" label="Deep scan clicked"/> + <int value="32" label="Bypass deep scanning enabled"/> + <int value="33" label="Bypass deep scanning clicked"/> +</enum> + <enum name="DownloadSource"> <int value="0" label="Initiated by Save Package on Non-HTML content"/> <int value="1" label="Initiated by Drag-and-drop"/> @@ -22842,6 +23353,14 @@ Called by update_document_policy_enum.py.--> <int value="2" label="Both entities are non-tombstone"/> </enum> +<enum name="DuplicateDownloadEvent"> + <int value="0" label="Shown"/> + <int value="1" label="Confirmed"/> + <int value="2" label="Canceled"/> + <int value="3" label="Link Clicked"/> + <int value="4" label="Dismissed"/> +</enum> + <enum name="DXGI_COLOR_SPACE_TYPE"> <summary> DirectX color space type. Documented here: @@ -23499,9 +24018,18 @@ Called by update_document_policy_enum.py.--> <int value="4" label="ANGLE D3D11"/> <int value="5" label="ANGLE OpenGL"/> <int value="6" label="ANGLE OpenGL ES"/> - <int value="13" label="Angle D3D11on12"/> - <int value="15" label="Angle OpenGL EGL"/> - <int value="16" label="Angle OpenGL ES EGL"/> + <int value="7" label="ANGLE NULL"/> + <int value="8" label="ANGLE D3D11 NULL"/> + <int value="9" label="ANGLE OpenGL NULL"/> + <int value="10" label="ANGLE OpenGLES NULL"/> + <int value="11" label="ANGLE Vulkan"/> + <int value="12" label="ANGLE Vulkan NULL"/> + <int value="13" label="ANGLE D3D11on12"/> + <int value="14" label="ANGLE SwiftShader"/> + <int value="15" label="ANGLE OpenGL EGL"/> + <int value="16" label="ANGLE OpenGL ES EGL"/> + <int value="17" label="ANGLE Metal"/> + <int value="18" label="ANGLE Metal NULL"/> </enum> <enum name="EligibilityFailureReason"> @@ -24685,6 +25213,7 @@ Called by update_document_policy_enum.py.--> <int value="14" label="Failed video encoder initialization"/> <int value="15" label="Audio encoding error"/> <int value="16" label="Video encoding error"/> + <int value="17" label="Projector transcription error"/> </enum> <enum name="EnhancedBookmarkViewMode"> @@ -24768,6 +25297,27 @@ Called by update_document_policy_enum.py.--> <int value="5" label="Other error"/> </enum> +<enum name="EnterpriseCloudReportingStatusCode"> + <summary>Defined as Code in components/reporting/util/status.h</summary> + <int value="0" label="OK"/> + <int value="1" label="CANCELLED"/> + <int value="2" label="UNKNOWN"/> + <int value="3" label="INVALID_ARGUMENT"/> + <int value="4" label="DEADLINE_EXCEEDED"/> + <int value="5" label="NOT_FOUND"/> + <int value="6" label="ALREADY_EXISTS"/> + <int value="7" label="PERMISSION_DENIED"/> + <int value="8" label="RESOURCE_EXHAUSTED"/> + <int value="9" label="FAILED_PRECONDITION"/> + <int value="10" label="ABORTED"/> + <int value="11" label="OUT_OF_RANGE"/> + <int value="12" label="UNIMPLEMENTED"/> + <int value="13" label="INTERNAL"/> + <int value="14" label="UNAVAILABLE"/> + <int value="15" label="DATA_LOSS"/> + <int value="16" label="UNAUTHENTICATED"/> +</enum> + <enum name="EnterpriseDeviceManagementStatus"> <summary> Status codes produced by DeviceManagementService for requests made to the @@ -26032,7 +26582,6 @@ Called by update_document_policy_enum.py.--> <int value="869" label="JavaScriptJitBlockedForSites"/> <int value="870" label="HttpsOnlyMode"/> <int value="871" label="DesktopSharingHubEnabled"/> - <int value="872" label="RestrictedManagedGuestSessionEnabled"/> <int value="873" label="ReportDeviceAudioStatus"/> <int value="874" label="DeviceHostnameUserConfigurable"/> <int value="875" label="ReportDeviceNetworkConfiguration"/> @@ -26052,6 +26601,30 @@ Called by update_document_policy_enum.py.--> <int value="888" label="EnhancedNetworkVoicesInSelectToSpeakAllowed"/> <int value="889" label="PrintPdfAsImageAvailability"/> <int value="890" label="PrintRasterizePdfDpi"/> + <int value="891" label="DeviceTargetVersionSelector"/> + <int value="892" label="ChromeAppsEnabled"/> + <int value="893" label="BrowserLegacyExtensionPointsBlocked"/> + <int value="894" label="DeviceRestrictedManagedGuestSessionEnabled"/> + <int value="895" label="PrintPostScriptMode"/> + <int value="896" label="PrintPdfAsImageDefault"/> + <int value="897" label="FullRestoreEnabled"/> + <int value="898" label="GhostWindowEnabled"/> + <int value="899" label="CloudUserPolicyOverridesCloudMachinePolicy"/> + <int value="900" label="ReportDeviceSecurityStatus"/> + <int value="901" label="EnableDeviceGranularReporting"/> + <int value="902" label="WebSQLInThirdPartyContextEnabled"/> + <int value="903" label="U2fSecurityKeyApiEnabled"/> + <int value="904" + label="DeviceLoginScreenPromptOnMultipleMatchingCertificates"/> + <int value="905" label="PromptOnMultipleMatchingCertificates"/> + <int value="906" label="SideSearchEnabled"/> + <int value="907" label="AccessCodeCastEnabled"/> + <int value="908" label="AccessCodeCastDeviceDuration"/> + <int value="909" label="NetworkServiceSandboxEnabled"/> + <int value="910" label="DeskTemplatesEnabled"/> + <int value="911" label="PreconfiguredDeskTemplates"/> + <int value="912" label="FastPairEnabled"/> + <int value="913" label="SandboxExternalProtocol"/> </enum> <enum name="EnterprisePolicyDeviceIdValidity"> @@ -26528,6 +27101,11 @@ Called by update_document_policy_enum.py.--> <int value="25" label="InertialGesturePinchUpdate"/> </enum> +<enum name="EventLatencyPinchInputType"> + <int value="0" label="Touchpad"/> + <int value="1" label="Touchscreen"/> +</enum> + <enum name="EventLatencyScrollInputType"> <int value="0" label="Autoscroll"/> <int value="1" label="Scrollbar"/> @@ -26535,6 +27113,12 @@ Called by update_document_policy_enum.py.--> <int value="3" label="Wheel"/> </enum> +<enum name="EventPageShowPersisted"> + <int value="0" label="No in renderer"/> + <int value="1" label="Yes in renderer"/> + <int value="2" label="Yes in browser"/> +</enum> + <enum name="EventPreFilterResult"> <int value="0" label="Unfiltered"/> <int value="1" label="Filtered due to no page handlers"/> @@ -27316,6 +27900,10 @@ Called by update_extension_histograms.py.--> <int value="477" label="ACCESSIBILITY_PRIVATE_ON_SHOW_CHROMEVOX_TUTORIAL"/> <int value="478" label="STORAGE_SESSION_ON_CHANGE"/> <int value="479" label="ACCESSIBILITY_PRIVATE_ON_TOGGLE_DICTATION"/> + <int value="480" label="WEB_AUTHENTICATION_PROXY_ON_ISUVPAA_REQUEST"/> + <int value="481" label="SPEECH_RECOGNITION_PRIVATE_ON_STOP"/> + <int value="482" label="SPEECH_RECOGNITION_PRIVATE_ON_RESULT"/> + <int value="483" label="SPEECH_RECOGNITION_PRIVATE_ON_ERROR"/> </enum> <enum name="ExtensionFileWriteResult"> @@ -28665,7 +29253,7 @@ Called by update_extension_histograms.py.--> <int value="1284" label="ACCESSIBILITY_PRIVATE_TOGGLEDICTATION"/> <int value="1285" label="ACCESSIBILITY_PRIVATE_ENABLEMOUSEEVENTS"/> <int value="1286" label="ACCESSIBILITY_PRIVATE_SENDSYNTHETICMOUSEEVENT"/> - <int value="1287" label="FILEMANAGERPRIVATE_DETECTCHARACTERENCODING"/> + <int value="1287" label="DELETED_FILEMANAGERPRIVATE_DETECTCHARACTERENCODING"/> <int value="1288" label="FILEMANAGERPRIVATEINTERNAL_GETLINUXPACKAGEINFO"/> <int value="1289" label="TABS_GOFORWARD"/> <int value="1290" label="TABS_GOBACK"/> @@ -28814,8 +29402,8 @@ Called by update_extension_histograms.py.--> <int value="1427" label="INPUTMETHODPRIVATE_RESET"/> <int value="1428" label="PRINTING_GETPRINTERINFO"/> <int value="1429" label="AUTOTESTPRIVATE_ISARCPACKAGELISTINITIALREFRESHED"/> - <int value="1430" label="AUTOTESTPRIVATE_STARTTRACING"/> - <int value="1431" label="AUTOTESTPRIVATE_STOPTRACING"/> + <int value="1430" label="DELETED_AUTOTESTPRIVATE_STARTTRACING"/> + <int value="1431" label="DELETED_AUTOTESTPRIVATE_STOPTRACING"/> <int value="1432" label="LOGIN_LOCKMANAGEDGUESTSESSION"/> <int value="1433" label="LOGIN_UNLOCKMANAGEDGUESTSESSION"/> <int value="1434" label="AUTOTESTPRIVATE_SETARCTOUCHMODE"/> @@ -28986,6 +29574,7 @@ Called by update_extension_histograms.py.--> <int value="1591" label="SPEECHRECOGNITIONPRIVATE_STOP"/> <int value="1592" label="FILEMANAGERPRIVATEINTERNAL_STARTIOTASK"/> <int value="1593" label="WALLPAPERPRIVATE_ISSWAENABLED"/> + <int value="1594" label="INPUTMETHODPRIVATE_GETTEXTFIELDBOUNDS"/> </enum> <enum name="ExtensionIconState"> @@ -29607,6 +30196,12 @@ Called by update_extension_permission.py.--> <int value="229" label="kTabGroups"/> <int value="230" label="kScripting"/> <int value="231" label="kWmDesksPrivate"/> + <int value="232" label="kWebAuthenticationProxy"/> + <int value="233" label="kDeclarativeNetRequestWithHostAccess"/> + <int value="234" label="kChromeOSTelemetry"/> + <int value="235" label="kSpeechRecognitionPrivate"/> + <int value="236" label="kChromeOSDiagnostics"/> + <int value="237" label="kChromeOSTelemetrySerialNumber"/> </enum> <enum name="ExtensionPointEnableState"> @@ -29877,6 +30472,12 @@ Called by update_extension_permission.py.--> <int value="2" label="Only allow Certain Sites"/> </enum> +<enum name="FamilyUserDenylistSource"> + <int value="0" label="None"/> + <int value="1" label="Denylist"/> + <int value="2" label="Old Denylist"/> +</enum> + <enum name="FamilyUserLogSegment"> <summary>Filters family user metrics into categories of interest.</summary> <int value="0" label="Other"/> @@ -29886,6 +30487,16 @@ Called by update_extension_permission.py.--> <int value="4" label="Regular User"/> </enum> +<enum name="FastPairEngagementFlowEvent"> + <int value="1" label="Discovery UI Shown"/> + <int value="11" label="Discovery UI Dismissed"/> + <int value="12" label="Discovery UI: Connect Button Pressed"/> + <int value="121" label="Pairing Failed"/> + <int value="122" label="Pairing Succeeded"/> + <int value="1211" label="Pairing Failed: Error UI Dismissed"/> + <int value="1212" label="Pairing Failed: Error UI Settings Button Pressed"/> +</enum> + <enum name="FaultTolerantHeap"> <int value="0" label="FTH_OFF">FTH is completely off.</int> <int value="1" label="FTH_HKLM">FTH is enabled in HKLM.</int> @@ -30924,9 +31535,9 @@ Called by update_use_counter_feature_enum.py.--> <int value="832" label="V8TextEvent_InitTextEvent_Method"/> <int value="833" label="V8SVGSVGElement_UseCurrentView_AttributeGetter"/> <int value="834" label="V8SVGSVGElement_CurrentView_AttributeGetter"/> - <int value="835" label="ClientHintsDPR"/> - <int value="836" label="ClientHintsResourceWidth"/> - <int value="837" label="ClientHintsViewportWidth"/> + <int value="835" label="ClientHintsDPR_DEPRECATED"/> + <int value="836" label="ClientHintsResourceWidth_DEPRECATED"/> + <int value="837" label="ClientHintsViewportWidth_DEPRECATED"/> <int value="838" label="SRIElementIntegrityAttributeButIneligible"/> <int value="839" label="FormDataAppendFile"/> <int value="840" label="FormDataAppendFileWithFilename"/> @@ -32143,7 +32754,7 @@ Called by update_use_counter_feature_enum.py.--> <int value="2014" label="V8SpeechRecognition_Start_Method"/> <int value="2015" label="TableRowDirectionDifferentFromTable"/> <int value="2016" label="TableSectionDirectionDifferentFromTable"/> - <int value="2017" label="ClientHintsDeviceMemory"/> + <int value="2017" label="ClientHintsDeviceMemory_DEPRECATED"/> <int value="2018" label="CSSRegisterProperty"/> <int value="2019" label="RelativeOrientationSensorConstructor"/> <int value="2020" label="SmoothScrollJSInterventionActivated"/> @@ -32543,9 +33154,9 @@ Called by update_use_counter_feature_enum.py.--> <int value="2401" label="TransformStreamConstructor"/> <int value="2402" label="NegativeBackgroundSize"/> <int value="2403" label="NegativeMaskSize"/> - <int value="2404" label="ClientHintsRtt"/> - <int value="2405" label="ClientHintsDownlink"/> - <int value="2406" label="ClientHintsEct"/> + <int value="2404" label="ClientHintsRtt_DEPRECATED"/> + <int value="2405" label="ClientHintsDownlink_DEPRECATED"/> + <int value="2406" label="ClientHintsEct_DEPRECATED"/> <int value="2407" label="CrossOriginHTMLIFrameElementContentDocument"/> <int value="2408" label="CrossOriginHTMLIFrameElementGetSVGDocument"/> <int value="2409" label="CrossOriginHTMLEmbedElementGetSVGDocument"/> @@ -32957,7 +33568,7 @@ Called by update_use_counter_feature_enum.py.--> label="OBSOLETE_CSSValueAppearanceButtonForNonButtonRendered"/> <int value="2775" label="OBSOLETE_CSSValueAppearanceButtonForOthersRendered"/> <int value="2776" label="CustomCursorIntersectsViewport"/> - <int value="2777" label="ClientHintsLang"/> + <int value="2777" label="OBSOLETE_ClientHintsLang"/> <int value="2778" label="LinkRelPreloadImageSrcset"/> <int value="2779" label="V8HTMLMediaElement_Remote_AttributeGetter"/> <int value="2780" label="V8RemotePlayback_WatchAvailability_Method"/> @@ -33591,10 +34202,10 @@ Called by update_use_counter_feature_enum.py.--> <int value="3376" label="SecurePaymentConfirmation"/> <int value="3377" label="OBSOLETE_CSSInvalidVariableUnset"/> <int value="3378" label="ElementInternalsShadowRoot"/> - <int value="3379" label="AnyPiiFieldDetected_PredictedTypeMatch"/> - <int value="3380" label="EmailFieldDetected_PredictedTypeMatch"/> - <int value="3381" label="PhoneFieldDetected_PredictedTypeMatch"/> - <int value="3382" label="EmailFieldDetected_PatternMatch"/> + <int value="3379" label="UserDataFieldFilled_PredictedTypeMatch"/> + <int value="3380" label="EmailFieldFilled_PredictedTypeMatch"/> + <int value="3381" label="PhoneFieldFilled_PredictedTypeMatch"/> + <int value="3382" label="EmailFieldFilled_PatternMatch"/> <int value="3383" label="LastLetterSpacingAffectsRendering"/> <int value="3384" label="V8FontMetadata_GetTables_Method"/> <int value="3385" label="V8FontMetadata_Blob_Method"/> @@ -34211,7 +34822,93 @@ Called by update_use_counter_feature_enum.py.--> <int value="3973" label="NavigatorPdfViewerEnabled"/> <int value="3974" label="CanvasRenderingContext2DContextLostEvent"/> <int value="3975" label="CanvasRenderingContext2DContextRestoredEvent"/> + <int value="3976" label="ClientHintsViewportHeight"/> + <int value="3977" label="V8NavigatorManagedData_GetDirectoryId_Method"/> + <int value="3978" label="V8NavigatorManagedData_GetHostname_Method"/> + <int value="3979" label="V8NavigatorManagedData_GetSerialNumber_Method"/> + <int value="3980" label="V8NavigatorManagedData_GetAnnotatedAssetId_Method"/> + <int value="3981" label="V8NavigatorManagedData_GetAnnotatedLocation_Method"/> + <int value="3982" label="UserDataFieldFilledPreviously"/> + <int value="3983" label="TableCollapsedBorderDifferentToVisual"/> + <int value="3984" label="HighlightAPIRegisterHighlight"/> <int value="3985" label="ReadOrWriteWebDatabaseThirdPartyContext"/> + <int value="3986" label="FontSelectorCSSFontFamilyWebKitPrefixPictograph"/> + <int value="3987" label="FontSelectorCSSFontFamilyWebKitPrefixStandard"/> + <int value="3988" label="FontSelectorCSSFontFamilyWebKitPrefixBody"/> + <int value="3989" label="FontBuilderCSSFontFamilyWebKitPrefixBody"/> + <int value="3990" label="CapabilityDelegationOfPaymentRequest"/> + <int value="3991" label="ConditionalFocus"/> + <int value="3992" label="CredentialManagerGetFederatedCredential"/> + <int value="3993" label="CredentialManagerGetPasswordCredential"/> + <int value="3994" label="CredentialManagerStoreFederatedCredential"/> + <int value="3995" label="CredentialManagerStorePasswordCredential"/> + <int value="3996" label="CredentialManagerCreateFederatedCredential"/> + <int value="3997" label="CredentialManagerCreatePasswordCredential"/> + <int value="3998" label="CanvasRenderingContext2DRoundRect"/> + <int value="3999" + label="NewLayoutOverflowDifferentBlockWithNonEmptyInflowBounds"/> + <int value="4000" label="CanvasRenderingContext2DReset"/> + <int value="4001" label="CanvasRenderingContext2DLetterSpacing"/> + <int value="4002" label="CanvasRenderingContext2DWordSpacing"/> + <int value="4003" label="CanvasRenderingContext2DFontVariantCaps"/> + <int value="4004" label="CanvasRenderingContext2DFontKerning"/> + <int value="4005" label="CanvasRenderingContext2DFontStretch"/> + <int value="4006" label="CanvasRenderingContext2DTextRendering"/> + <int value="4007" label="CSSCascadeLayers"/> + <int value="4008" label="CanvasRenderingContext2DConicGradient"/> + <int value="4009" label="CanvasRenderingContext2DCanvasFilter"/> + <int value="4010" label="HTMLParamElementURLParameter"/> + <int value="4011" label="V8HTMLScriptElement_Supports_Method"/> + <int value="4012" label="HandwritingRecognitionQueryRecognizer"/> + <int value="4013" + label="V8FileSystemFileHandle_CreateSyncAccessHandle_Method"/> + <int value="4014" label="V8FileSystemSyncAccessHandle_Read_Method"/> + <int value="4015" label="V8FileSystemSyncAccessHandle_Write_Method"/> + <int value="4016" label="V8FileSystemSyncAccessHandle_Close_Method"/> + <int value="4017" label="V8FileSystemSyncAccessHandle_Flush_Method"/> + <int value="4018" label="V8FileSystemSyncAccessHandle_GetSize_Method"/> + <int value="4019" label="V8FileSystemSyncAccessHandle_Truncate_Method"/> + <int value="4020" + label="V8SharedArrayBufferConstructedInExtensionWithoutIsolation"/> + <int value="4021" label="MediaSourceExtensionsForWebCodecs"/> + <int value="4023" label="PaymentRequestResponse"/> + <int value="4024" label="PaymentRequestComplete"/> + <int value="4025" label="HTMLCanvasElement_2D"/> + <int value="4026" label="HTMLCanvasElement_WebGL"/> + <int value="4027" label="HTMLCanvasElement_WebGL2"/> + <int value="4028" label="HTMLCanvasElement_BitmapRenderer"/> + <int value="4029" label="HTMLCanvasElement_WebGPU"/> + <int value="4030" label="OffscreenCanvas_2D"/> + <int value="4031" label="OffscreenCanvas_WebGL"/> + <int value="4032" label="OffscreenCanvas_WebGL2"/> + <int value="4033" label="OffscreenCanvas_BitmapRenderer"/> + <int value="4034" label="OffscreenCanvas_WebGPU"/> + <int value="4035" label="CanvasRenderingContext2DHasOverdraw"/> + <int value="4036" label="DigitalGoodsConsume"/> + <int value="4037" label="DigitalGoodsListPurchaseHistory"/> + <int value="4038" label="WebShareContainingFiles"/> + <int value="4039" label="WebShareContainingTitle"/> + <int value="4040" label="WebShareContainingText"/> + <int value="4041" label="WebShareContainingUrl"/> + <int value="4042" label="CoepNoneSharedWorker"/> + <int value="4043" label="CoepRequireCorpSharedWorker"/> + <int value="4044" label="CoepCredentiallessSharedWorker"/> + <int value="4045" label="PaymentRequestBasicCard"/> + <int value="4046" label="ClientHintsDeviceMemory"/> + <int value="4047" label="ClientHintsDPR"/> + <int value="4048" label="ClientHintsResourceWidth"/> + <int value="4049" label="ClientHintsViewportWidth"/> + <int value="4050" label="InlineBoxIgnoringContinuation"/> + <int value="4051" label="OffsetWidthOrHeightIgnoringContinuation"/> + <int value="4052" label="ConditionalFocus"/> + <int value="4053" label="V8Navigator_CreateAdRequest_Method"/> + <int value="4054" label="V8Navigator_FinalizeAd_Method"/> + <int value="4055" label="RegionCapture"/> + <int value="4056" label="AppHistory"/> + <int value="4057" label="FlexboxAlignSingleLineDifference"/> + <int value="4058" label="ExternalProtocolBlockedBySandbox"/> + <int value="4059" label="WebAssemblyDynamicTiering"/> + <int value="4062" label="AutoDarkMode"/> </enum> <enum name="FeaturePolicyAllowlistType"> @@ -34320,6 +35017,7 @@ Called by update_permissions_policy_enum.py.--> <int value="86" label="WindowPlacement"/> <int value="87" label="ClientHintUABitness"/> <int value="88" label="ClientHintUAReduced"/> + <int value="89" label="ClientHintViewportHeight"/> </enum> <enum name="FeaturePolicyImageCompressionFormat"> @@ -34374,6 +35072,12 @@ Called by update_permissions_policy_enum.py.--> <int value="20" label="What's New"/> </enum> +<enum name="FeedContentOrder"> + <int value="0" label="Unspecified"/> + <int value="1" label="Grouped"/> + <int value="2" label="Reverse Chronological"/> +</enum> + <enum name="FeedControlsActions"> <int value="0" label="Clicked on My activity"/> <int value="1" label="Clicked on Manage interests"/> @@ -34586,6 +35290,8 @@ Called by update_permissions_policy_enum.py.--> <int value="39" label="After long-pressing on the feed and seeing the preview, the user tapped on the preview."/> + <int value="40" + label="User tapped Settings link to open feed autoplay settings."/> </enum> <enum name="FeedUserCommandType"> @@ -36214,6 +36920,12 @@ Called by update_permissions_policy_enum.py.--> <int value="5" label="GNOME failure"/> </enum> +<enum name="FormDataEquality"> + <int value="0" label="Shallow comparison is enough to find difference"/> + <int value="1" label="Deep comparison is needed to find difference"/> + <int value="2" label="Equal forms"/> +</enum> + <enum name="FormInputAccessoryAction"> <int value="0" label="PreviousElement"/> <int value="1" label="NextElement"/> @@ -37158,12 +37870,27 @@ Called by update_permissions_policy_enum.py.--> <summary> Integer values encoding the vendor and product IDs for known gamepads. </summary> + <int value="-2004352248" label="Vendor8888Product0308"/> + <int value="-144310271" label="Vendorf766Product0001"/> + <int value="65280" label="PowerALicPro"/> <int value="7929862" label="DragonRiseProduct0006"/> <int value="7929873" label="DragonRiseProduct0011"/> + <int value="7936000" label="DragonRiseProduct1800"/> + <int value="7936067" label="DragonRiseProduct1843"/> + <int value="7936068" label="DragonRiseProduct1844"/> <int value="17896473" label="SteelSeriesBtProduct1419"/> + <int value="17896480" label="SteelSeriesBtProduct1420"/> + <int value="17896497" label="SteelSeriesBtProduct1431"/> + <int value="72332053" label="ThrustMasterProductb315"/> + <int value="72332067" label="ThrustMasterProductb323"/> + <int value="72332070" label="ThrustMasterProductb326"/> + <int value="72332919" label="ThrustMasterProductb677"/> + <int value="73269287" label="MicrosoftProduct0027"/> + <int value="73269893" label="MicrosoftProduct0285"/> <int value="73269902" label="MicrosoftProduct028e"/> <int value="73269903" label="MicrosoftProduct028f"/> <int value="73269905" label="MicrosoftProduct0291"/> + <int value="73269920" label="MicrosoftProduct02a0"/> <int value="73269921" label="MicrosoftProduct02a1"/> <int value="73269969" label="MicrosoftProduct02d1"/> <int value="73269981" label="MicrosoftProduct02dd"/> @@ -37171,42 +37898,182 @@ Called by update_permissions_policy_enum.py.--> <int value="73269987" label="MicrosoftProduct02e3"/> <int value="73269994" label="MicrosoftProduct02ea"/> <int value="73270013" label="MicrosoftProduct02fd"/> + <int value="73270015" label="MicrosoftProduct02ff"/> <int value="73271065" label="MicrosoftProduct0719"/> + <int value="73272064" label="MicrosoftProduct0b00"/> + <int value="73272069" label="MicrosoftProduct0b05"/> + <int value="73272082" label="MicrosoftProduct0b12"/> + <int value="73272083" label="MicrosoftProduct0b13"/> + <int value="74301961" label="LogitechProductc209"/> + <int value="74301973" label="LogitechProductc215"/> <int value="74301974" label="LogitechProductc216"/> <int value="74301976" label="LogitechProductc218"/> <int value="74301977" label="LogitechProductc219"/> + <int value="74301978" label="LogitechProductc21a"/> <int value="74301981" label="LogitechProductc21d"/> <int value="74301982" label="LogitechProductc21e"/> <int value="74301983" label="LogitechProductc21f"/> + <int value="74302018" label="LogitechProductc242"/> + <int value="74302031" label="LogitechProductc24f"/> + <int value="74302048" label="LogitechProductc260"/> + <int value="74302050" label="LogitechProductc262"/> + <int value="74302104" label="LogitechProductc298"/> + <int value="74302105" label="LogitechProductc299"/> + <int value="74302106" label="LogitechProductc29a"/> + <int value="74302107" label="LogitechProductc29b"/> + <int value="78905610" label="CypressProduct010a"/> <int value="82354176" label="SamsungElectronicsProducta000"/> <int value="88867432" label="SonyProduct0268"/> <int value="88868292" label="SonyProduct05c4"/> + <int value="88868293" label="SonyProduct05c5"/> <int value="88869324" label="SonyProduct09cc"/> <int value="88869792" label="SonyProduct0ba0"/> + <int value="88870118" label="SonyProduct0ce6"/> + <int value="91103235" label="ElecomProduct2003"/> + <int value="91103236" label="ElecomProduct2004"/> + <int value="91103247" label="ElecomProduct200f"/> + <int value="91103248" label="ElecomProduct2010"/> + <int value="91103251" label="ElecomProduct2013"/> + <int value="92144390" label="NintendoProduct0306"/> + <int value="92144432" label="NintendoProduct0330"/> + <int value="92151814" label="NintendoProduct2006"/> + <int value="92151815" label="NintendoProduct2007"/> <int value="92151817" label="NintendoProduct2009"/> + <int value="92151822" label="NintendoProduct200e"/> <int value="92479584" label="PadixProduct2060"/> + <int value="92512256" label="PadixProducta000"/> + <int value="92516401" label="PadixProductb031"/> + <int value="94384690" label="VetronixProduct3232"/> + <int value="98764182" label="GenesysLogicProduct0596"/> + <int value="111345929" label="LogitechEuropeProduct0109"/> + <int value="111346699" label="LogitechEuropeProduct040b"/> + <int value="111410956" label="LogitechEuropeProductff0c"/> + <int value="114688037" label="AashimaProduct0025"/> + <int value="121128726" label="MadCatzProduct4716"/> + <int value="121128760" label="MadCatzProduct4738"/> + <int value="121145400" label="MadCatzProduct8838"/> + <int value="129303059" label="MegaWorldProduct0213"/> + <int value="129303314" label="MegaWorldProduct0312"/> + <int value="129303316" label="MegaWorldProduct0314"/> + <int value="135266305" label="PersonalCommunicationSystemsProduct0001"/> + <int value="135266307" label="PersonalCommunicationSystemsProduct0003"/> + <int value="135324929" label="PersonalCommunicationSystemsProducte501"/> <int value="153419781" label="LakeviewResearchProduct0005"/> + <int value="153425664" label="LakeviewResearchProduct1700"/> + <int value="153430017" label="LakeviewResearchProduct2801"/> <int value="153454694" label="LakeviewResearchProduct8866"/> <int value="156594704" label="NvidiaProduct7210"/> <int value="156594708" label="NvidiaProduct7214"/> + <int value="173835522" label="BroadcomProduct8502"/> <int value="184894720" label="AsusTekProduct4500"/> <int value="188940293" label="PlayComProduct0005"/> + <int value="202506245" label="ZeroplusProduct0005"/> + <int value="202510070" label="ZeroplusProduct0ef6"/> + <int value="205865760" label="SonixProduct4320"/> <int value="242155523" label="PdpProduct0003"/> + <int value="242155795" label="PdpProduct0113"/> + <int value="242155806" label="PdpProduct011e"/> + <int value="242155807" label="PdpProduct011f"/> + <int value="242156033" label="PdpProduct0201"/> + <int value="242156051" label="PdpProduct0213"/> + <int value="242156063" label="PdpProduct021f"/> + <int value="242156192" label="PdpProduct02a0"/> + <int value="242156289" label="PdpProduct0301"/> + <int value="242156545" label="PdpProduct0401"/> + <int value="242156563" label="PdpProduct0413"/> + <int value="242156801" label="PdpProduct0501"/> + <int value="242218241" label="PdpProductf501"/> <int value="244252675" label="GreenAsiaProduct0003"/> + <int value="244252680" label="GreenAsiaProduct0008"/> + <int value="244252690" label="GreenAsiaProduct0012"/> + <int value="244256774" label="GreenAsiaProduct1006"/> + <int value="244264976" label="GreenAsiaProduct3010"/> + <int value="244265077" label="GreenAsiaProduct3075"/> + <int value="244265229" label="GreenAsiaProduct310d"/> + <int value="252510220" label="HoriProduct000c"/> + <int value="252510242" label="HoriProduct0022"/> + <int value="252510285" label="HoriProduct004d"/> + <int value="252510310" label="HoriProduct0066"/> + <int value="252510315" label="HoriProduct006b"/> + <int value="252510318" label="HoriProduct006e"/> + <int value="252510344" label="HoriProduct0088"/> + <int value="252510346" label="HoriProduct008a"/> + <int value="252510352" label="HoriProduct0090"/> + <int value="252510401" label="HoriProduct00c1"/> + <int value="252510446" label="HoriProduct00ee"/> + <int value="254804240" label="JessProduct0110"/> + <int value="254804242" label="JessProduct0112"/> <int value="272110610" label="SteelSeriesProduct1412"/> <int value="272110616" label="SteelSeriesProduct1418"/> <int value="272110624" label="SteelSeriesProduct1420"/> + <int value="272110640" label="SteelSeriesProduct1430"/> + <int value="272110641" label="SteelSeriesProduct1431"/> + <int value="298407408" label="MonsterProduct55f0"/> + <int value="301937457" label="LiteStarProduct3331"/> + <int value="301937473" label="LiteStarProduct3341"/> + <int value="306924801" label="NykoProduct4d01"/> + <int value="313197313" label="HoneyBeeProduct0301"/> + <int value="314429461" label="SunLightProductd015"/> + <int value="323293184" label="SinoLiteProduct1000"/> + <int value="323301384" label="SinoLiteProduct3008"/> + <int value="338690720" label="ActivisionProduct02a0"/> + <int value="338708296" label="ActivisionProduct4748"/> + <int value="338753537" label="ActivisionProductf801"/> + <int value="342560001" label="BigBenProduct0d01"/> + <int value="355599361" label="Razer1532Product0401"/> <int value="355600640" label="Razer1532Product0900"/> + <int value="355602432" label="Razer1532Product1000"/> + <int value="378142208" label="GriffinProductfe00"/> + <int value="381682823" label="VanOoijenProduct0487"/> + <int value="381683169" label="VanOoijenProduct05e1"/> <int value="416361536" label="GoogleProduct2c40"/> <int value="416370734" label="GoogleProduct502e"/> <int value="416388096" label="GoogleProduct9400"/> - <int value="550920817" label="Vendor20d6Product6271"/> - <int value="550930917" label="Vendor20d6Product89e5"/> + <int value="424215554" label="AmazonProduct0402"/> + <int value="424215578" label="AmazonProduct041a"/> + <int value="435815943" label="GamewareProduct0607"/> + <int value="439616003" label="KingChuangProduct0203"/> + <int value="439678725" label="KingChuangProductf705"/> + <int value="464323214" label="HarmonixProduct028e"/> + <int value="464384022" label="HarmonixProductf016"/> + <int value="464384037" label="HarmonixProductf025"/> + <int value="464384046" label="HarmonixProductf02e"/> + <int value="464384048" label="HarmonixProductf030"/> + <int value="464384056" label="HarmonixProductf038"/> + <int value="464385281" label="HarmonixProductf501"/> + <int value="464386304" label="HarmonixProductf900"/> + <int value="464386305" label="HarmonixProductf901"/> + <int value="464386561" label="HarmonixProductfa01"/> + <int value="500695051" label="BuffaloKokuyoProduct000b"/> + <int value="500695055" label="BuffaloKokuyoProduct000f"/> + <int value="500695056" label="BuffaloKokuyoProduct0010"/> + <int value="550920817" label="BdaProduct6271"/> + <int value="550930917" label="BdaProduct89e5"/> + <int value="550947437" label="BdaProductca6d"/> <int value="572653664" label="MacAllyProduct0060"/> <int value="572669968" label="MacAllyProduct4010"/> - <int value="595070984" label="Vendor2378Product1008"/> - <int value="595070986" label="Vendor2378Product100a"/> - <int value="674627585" label="Vendor2836Product0001"/> + <int value="595070984" label="OnLiveProduct1008"/> + <int value="595070986" label="OnLiveProduct100a"/> + <int value="616976384" label="XboxThirdPartyProduct5000"/> + <int value="616977152" label="XboxThirdPartyProduct5300"/> + <int value="616977155" label="XboxThirdPartyProduct5303"/> + <int value="616977162" label="XboxThirdPartyProduct530a"/> + <int value="616977178" label="XboxThirdPartyProduct531a"/> + <int value="616977664" label="XboxThirdPartyProduct5500"/> + <int value="616979200" label="XboxThirdPartyProduct5b00"/> + <int value="616979202" label="XboxThirdPartyProduct5b02"/> + <int value="616979716" label="XboxThirdPartyProduct5d04"/> + <int value="617020156" label="XboxThirdPartyProductfafc"/> + <int value="617020157" label="XboxThirdPartyProductfafd"/> + <int value="617020158" label="XboxThirdPartyProductfafe"/> + <int value="627246371" label="ShanWanProduct0523"/> + <int value="636535073" label="GoodBetterBestProductc121"/> + <int value="655831364" label="XiaomiProduct3144"/> + <int value="674627585" label="OuyaProduct0001"/> + <int value="685641986" label="ValveProduct1102"/> + <int value="740433920" label="QanbaProduct2000"/> + <int value="768096288" label="8BitdoProduct3820"/> + <int value="781547301" label="ScufProduct7725"/> <int value="1717962343" label="PrototypeVendorProduct0667"/> <int value="1717998593" label="PrototypeVendorProduct9401"/> </enum> @@ -40317,6 +41184,9 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> </enum> <enum name="HIDContinueScenarioType"> + <obsolete> + Removed in M96. + </obsolete> <summary>Possible detected devices combination on leaving dialog</summary> <int value="0" label="Pointing device only detected."/> <int value="1" label="Keyboard device only detected."/> @@ -40380,6 +41250,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="-1419490329" label="ActivityTracker.Record.Event"/> <int value="-1390672863" label="DataUse.MessageSize.AllServices.Upstream.Background.NotCellular"/> + <int value="-1363801537" label="Crashpad.CrashUpload.Skipped"/> <int value="-1345388508" label="Renderer4.IdealContentsScale"/> <int value="-1321341911" label="DataUse.BackgroundToDataRecievedPerByte.User"/> @@ -40390,6 +41261,9 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="-1267842531" label="PasswordManager.BulkCheck.PasswordCheckReferrer"/> <int value="-1189959109" label="RendererScheduler.TaskCountPerQueueType"/> + <int value="-1096730224" label="Crashpad.CrashReportPending"/> + <int value="-1026485441" + label="UMA.PersistentAllocator.CrashpadMetrics.Errors"/> <int value="-983723378" label="RendererScheduler.TaskDurationPerThreadType"/> <int value="-970685679" label="Bluetooth.MacOS.Errors.DidDiscoverDescriptors"/> @@ -40409,6 +41283,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="-535820174" label="DataUse.MessageSize.AllServices.Downstream.Background.NotCellular"/> <int value="-453454441" label="Bluetooth.MacOS.Errors.DidWriteValue"/> + <int value="-445016785" label="Crashpad.ExceptionEncountered"/> <int value="-436781330" label="Net.URLLoaderThrottleExecutionTime.BeforeWillProcessResponse"/> <int value="-424393552" label="DirectWrite.Fonts.Gfx.InitializeLoopCount"/> @@ -40419,8 +41294,10 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="-343220158" label="Compositing.Renderer.LayersUpdateTime"/> <int value="-334673303" label="UMA.PersistentAllocator.BrowserMetrics.Errors"/> + <int value="-297026085" label="Crashpad.ExceptionCode.Win"/> <int value="-141990989" label="DataUse.AllServices.Background"/> <int value="-132932440" label="DataUse.ContentType.Services"/> + <int value="-94832417" label="Crashpad.CrashReportSize"/> <int value="-48200749" label="DiskCache.0.TotalIOTime"/> <int value="0" label="Missing hash value"/> <int value="19727358" label="DataUse.BytesReceived2.Delegate"/> @@ -40434,9 +41311,11 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="192918458" label="DataUse.MessageSize.AllServices.Downstream.Unknown.Cellular"/> <int value="294030175" label="V8.GC.Event.MainThread.Full.Incremental.Cpp"/> + <int value="410893025" label="Crashpad.CrashUpload.AttemptSuccessful"/> <int value="424952287" label="Network.Shill.Wifi.LinkMonitorResponseTimeSample"/> <int value="433324211" label="Extensions.FunctionCalls"/> + <int value="480662546" label="ActivityTracker.CollectCrash.Event"/> <int value="513321612" label="V8.GC.Event.MainThread.Full.Incremental.Mark.Cpp"/> <int value="536258327" label="Blink.UseCounter.SVGImage.Features"/> @@ -40458,6 +41337,8 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="761823979" label="Crashpad.HandlerLifetimeMilestone"/> <int value="873338882" label="Autofill.FieldPredictionQuality.ByFieldType.Heuristic"/> + <int value="902803399" + label="UMA.PersistentAllocator.CrashpadMetrics.UsedPct"/> <int value="910415681" label="DevTools.ExperimentEnabledAtLaunch"/> <int value="1096524200" label="DevTools.IssueCreated"/> <int value="1126499749" @@ -40484,6 +41365,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> label="Compositing.Renderer.LayerUpdateSkippedDueToBackface"/> <int value="1632894016" label="Autofill.FieldPredictionQuality.ByFieldType.Heuristic.NoSubmission"/> + <int value="1716628481" label="ActivityTracker.CollectCrash.Status"/> <int value="1721222685" label="Blink.UseCounter.MainFrame.Features"/> <int value="1753226325" label="DataUse.MessageSize.AllServices.Downstream.Foreground.Cellular"/> @@ -40502,6 +41384,32 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="2147480259" label="Sqlite.Vfs_Fetch"/> </enum> +<enum name="HistoryClustersFinalState"> + <summary> + The final state, or outcome, of an interaction on the HistoryClusters, or + Journeys, UI. + </summary> + <int value="0" label="Unknown"/> + <int value="1" label="kLinkClick">Link Clicked from UI</int> + <int value="2" label="kCloseTab"> + The UI interaction ended without opening anything on the page. + </int> +</enum> + +<enum name="HistoryClustersInitialState"> + <summary> + The initial state that describes how an interaction with the + HistoryClusters, or Journeys, UI was started. + </summary> + <int value="0" label="Unknown"/> + <int value="1" label="kDirectNavigation"> + The UI was reached via direct navigation, not through any dedicated surface. + </int> + <int value="2" label="kIndirectNavigation"> + The UI was reached via indirect navigation, e.g. a link. + </int> +</enum> + <enum name="HistoryFaviconsRecoveryEnum"> <obsolete> History.FaviconsRecovery no longer tracked as of March 2017. @@ -40608,6 +41516,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="2" label="Grouped Month (Obsolete Feb. 2017)"/> <int value="3" label="Synced Tabs"/> <int value="4" label="Signin Promo"/> + <int value="5" label="Journeys"/> </enum> <enum name="HistoryTopSitesRecoveryEnum"> @@ -40772,6 +41681,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="7" label="kDiagnosticsLog"/> <int value="8" label="kLacrosDownload"/> <int value="9" label="kScan"/> + <int value="10" label="kPhoneHubCameraRoll"/> </enum> <enum name="HoldingSpacePodAction"> @@ -40901,6 +41811,19 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="3" label="Training Mode"/> </enum> +<enum name="HpsTurnOnResult"> + <int value="0" label="Success"/> + <int value="1" label="Version Mismatch, will cause an update"/> + <int value="2" label="SPI flash verification failure, will cause an update"/> + <int value="3" label="MCU flash verification failure, will cause an update"/> + <int value="4" label="Stage 1 did not start"/> + <int value="5" label="Application did not start"/> + <int value="6" label="No response from the device"/> + <int value="7" label="Boot stage timeout other than the above"/> + <int value="8" label="Device reported wrong magic number"/> + <int value="9" label="Fault bit set during boot"/> +</enum> + <enum name="HrefTranslatePrefsFilterStatus"> <int value="0" label="Not in blocklists"/> <int value="1" label="Language in blocklist"/> @@ -42054,6 +42977,12 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="1" label="WITH_DIACRITICS"/> </enum> +<enum name="IMEPaprikaActions"> + <int value="0" label="DELETE"/> + <int value="1" label="SWITCH_TO_VK"/> + <int value="2" label="UNDO"/> +</enum> + <enum name="IMERegisterProxyView"> <obsolete> Removed as of Jan 2020. @@ -42373,6 +43302,12 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="9" label="Canceled"/> </enum> +<enum name="InProductHelp.SnoozeAction"> + <int value="0" label="Unknown"/> + <int value="1" label="Snooze"/> + <int value="2" label="Dismiss"/> +</enum> + <enum name="InputEventTypeForResponsivenessMetric"> <int value="0" label="mousedown"/> <int value="1" label="click"/> @@ -42761,7 +43696,23 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="2" label="Periodic poll"/> </enum> +<enum name="InstallReason"> + <int value="0" label="Installed with unknown reason"/> + <int value="1" + label="Installed with the system and is considered a part of the OS"/> + <int value="2" label="Installed by policy"/> + <int value="3" label="Installed by an OEM"/> + <int value="4" + label="Preinstalled by default, but is not considered a system app"/> + <int value="5" label="Installed by sync"/> + <int value="6" label="Installed by user action"/> + <int value="7" label="Installed by SubApp API"/> +</enum> + <enum name="InstallSource"> + <obsolete> + Removed in M96. Replaced with InstallReason. + </obsolete> <int value="0" label="Installed with unknown source"/> <int value="1" label="Installed with the system and is considered a part of the OS"/> @@ -42773,6 +43724,15 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="6" label="Installed by user action"/> </enum> +<enum name="InstallSource2"> + <int value="0" label="Unknown"/> + <int value="1" label="Installed as part of Chrome OS"/> + <int value="2" label="Installed from sync"/> + <int value="3" label="Installed from Play store"/> + <int value="4" label="Installed from Chrome web store"/> + <int value="5" label="Installed from browser"/> +</enum> + <enum name="InstallStatus"> <obsolete> Removed in M88. @@ -43076,6 +44036,10 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="19" label="Intel ElkhartLake"/> <int value="20" label="Intel JaspterLake"/> <int value="21" label="Intel TigerLake"/> + <int value="22" label="Intel AlderLake"/> + <int value="23" label="Intel AmberLake"/> + <int value="24" label="Intel RocketLake"/> + <int value="25" label="Intel DG1"/> </enum> <enum name="IntelMaxMicroArchitecture"> @@ -43088,6 +44052,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="6" label="SSE4.2"/> <int value="7" label="AVX"/> <int value="8" label="AVX2"/> + <int value="9" label="FMA3"/> </enum> <enum name="IntentHeadersResult"> @@ -43370,6 +44335,17 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="3" label="Store Busy"/> </enum> +<enum name="IOSCredentialProviderNewCredentialUsername"> + <int value="0" label="Credential With Username"/> + <int value="1" label="Credential Without Username"/> +</enum> + +<enum name="IOSCredentialProviderPasswordCreated"> + <int value="0" label="Password Manually Added"/> + <int value="1" label="Password Suggested"/> + <int value="2" label="Password Suggested and Manually Changed"/> +</enum> + <enum name="IOSDefaultBrowserFullscreenPromoAction"> <int value="0" label="Action Button"/> <int value="1" label="Cancel"/> @@ -43484,7 +44460,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="1" label="Open in New Incognito Tab"/> <int value="2" label="Open in New Window"/> <int value="3" label="Open all in New Tabs"/> - <int value="4" label="Copy"/> + <int value="4" label="Copy URL"/> <int value="5" label="Edit"/> <int value="6" label="Move"/> <int value="7" label="Share"/> @@ -43499,9 +44475,14 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="16" label="Add to Bookmarks"/> <int value="17" label="Close Tab"/> <int value="18" label="Edit Bookmark"/> - <int value="19" label="Save"/> - <int value="20" label="Open in Current Tab"/> + <int value="19" label="Save Image"/> + <int value="20" label="Open Image in Current Tab"/> <int value="21" label="Search Image"/> + <int value="22" label="Close all Tabs"/> + <int value="23" label="Select Tabs"/> + <int value="24" label="Open Image in New Tab"/> + <int value="25" label="Copy Image"/> + <int value="26" label="Search with Google Lens"/> </enum> <enum name="IOSMenuScenario"> @@ -43796,6 +44777,9 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> </enum> <enum name="IppAttribute"> + <obsolete> + Removed 2021/09. + </obsolete> <int value="0" label="confirmation-sheet-print"/> <int value="1" label="finishings"/> <int value="2" label="ipp-attribute-fidelity"/> @@ -44585,6 +45569,27 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="2" label="BO"/> </enum> +<enum name="KoreanAction"> + <summary>Actions that are available on the Korean IME.</summary> + <int value="0" label="Unknown"/> + <int value="1" label="Press Hanja key"/> + <int value="2" label="Press Hangeul key"/> + <int value="3" label="Compose out of order"/> +</enum> + +<enum name="KoreanLayout"> + <summary>Layouts that are available on the Korean IME.</summary> + <int value="0" label="Dubeolsik"/> + <int value="1" label="Dubeolsik (Old Hangeul)"/> + <int value="2" label="Sebeolsik (390)"/> + <int value="3" label="Sebeolsik (Final)"/> + <int value="4" label="Sebeolsik (No Shift)"/> + <int value="5" label="Sebeolsik (Old Hangeul)"/> + <int value="6" label="Sebeolsik (Dubeol)"/> + <int value="7" label="Romaja"/> + <int value="8" label="Ahnmatae"/> +</enum> + <enum name="LacrosLaunchMode"> <int value="0" label="Only Ash browser"/> <int value="1" label="Ash and Lacros browser available"/> @@ -45361,6 +46366,7 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="59" label="SBOX_ERROR_CANNOT_INIT_BROKERSERVICES"/> <int value="60" label="SBOX_ERROR_CANNOT_UPDATE_JOB_PROCESS_LIMIT"/> <int value="61" label="SBOX_ERROR_CANNOT_CREATE_LOWBOX_IMPERSONATION_TOKEN"/> + <int value="62" label="SBOX_ERROR_UNSANDBOXED_PROCESS"/> <int value="1002" label="LAUNCH_RESULT_SUCCESS"/> <int value="1003" label="LAUNCH_RESULT_FAILURE"/> </enum> @@ -45562,6 +46568,14 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="9" label="Disabled"/> <int value="10" label="Error: additional web context malformed (nonfatal)"/> <int value="11" label="Success: Image is translatable"/> + <int value="12" label="Error: user context changed"/> + <int value="13" label="Disabled: user context changed"/> + <int value="14" label="Error: unexpected state"/> + <int value="15" label="Disabled: AGSA out of date"/> + <int value="16" label="Disabled: OS out of date"/> + <int value="17" label="Disabled: user not signed in"/> + <int value="18" label="Disabled: UMA reporting is disabled"/> + <int value="19" label="Disabled: user is in Incognito mode"/> </enum> <enum name="LensRegionSearchAspectRatio"> @@ -45583,6 +46597,13 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="0" label="Success"/> <int value="1" label="Failed to open results in a new tab"/> <int value="2" label="Error capturing image from selected region"/> + <int value="3" label="User exited the capture mode via the escape key."/> + <int value="4" + label="User exited the capture mode via the close button on the + instructional bubble."/> + <int value="5" + label="User navigated away from the page while capture mode was open, + closing the capture mode."/> </enum> <enum name="LensSdkError"> @@ -45748,6 +46769,12 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="20" label="kOtherReason"/> </enum> +<enum name="LightTheme"> + <int value="0" label="undefined"/> + <int value="1" label="no"/> + <int value="2" label="yes"/> +</enum> + <enum name="LinkGenerationCopiedLinkType"> <int value="0" label="Copied from new right-click menu generation"/> <int value="1" label="Copied from existing highlight right-click menu"/> @@ -45791,6 +46818,11 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> <int value="3" label="Failure Threshold Reached"/> </enum> +<enum name="LinkToggleState"> + <int value="0" label="Link"/> + <int value="1" label="No Link"/> +</enum> + <enum name="LinkToTextDiagnoseStatus"> <int value="0" label="Show sharing hub is requested for highlighted text"/> <int value="1" label="Selector is requested for highlighted text"/> @@ -45811,6 +46843,9 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> </enum> <enum name="LinuxAudioIO"> + <obsolete> + Deprecated 2021/09, as relevant UMA is deprecated. + </obsolete> <int value="0" label="PulseAudio"/> <int value="1" label="ALSA"/> <int value="2" label="Cras"/> @@ -46598,6 +47633,9 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> </enum> <enum name="LocationPermissionsIOSUI"> + <obsolete> + Removed in September 2021 + </obsolete> <int value="0" label="First Run Location Prompt Not Shown"/> <int value="1" label="First Run Location Permissions Modal Shown"/> </enum> @@ -46786,11 +47824,13 @@ from previous Chrome versions. <int value="-2117048251" label="MediaApp:enabled"/> <int value="-2116440101" label="EnablePenetratingImageSelection:enabled"/> <int value="-2114831248" label="disable-new-ntp"/> + <int value="-2114756847" label="SideSearchClearCacheWhenClosed:disabled"/> <int value="-2113783491" label="ArcFilePickerExperiment:enabled"/> <int value="-2113705745" label="CrossOriginMediaPlaybackRequiresUserGesture:enabled"/> <int value="-2112601037" label="OmniboxRefinedFocusState:enabled"/> <int value="-2112547309" label="ClickToCallReceiver:enabled"/> + <int value="-2111273398" label="SendTabToSelfManageDevicesLink:enabled"/> <int value="-2111196530" label="EnableAssistantLauncherUI:disabled"/> <int value="-2108564200" label="AutofillUpstream:disabled"/> <int value="-2106960993" label="HarfBuzzPDFSubsetter:disabled"/> @@ -46809,9 +47849,13 @@ from previous Chrome versions. <int value="-2099457894" label="Mash:enabled"/> <int value="-2099035488" label="enable-data-reduction-proxy-bypass-warning"/> <int value="-2098610409" label="disable-lcd-text"/> + <int value="-2098294029" label="PageInfoStoreInfo:enabled"/> <int value="-2098243118" label="OmniboxTailSuggestions:disabled"/> + <int value="-2097906903" label="ArcNearbySharing:disabled"/> <int value="-2097895488" label="NotificationScrollBar:enabled"/> <int value="-2097515669" label="disable-cast"/> + <int value="-2095687234" + label="EnterpriseReportingExtensionManifestVersion:enabled"/> <int value="-2095519429" label="FtpProtocol:enabled"/> <int value="-2094897448" label="TranslateIntent:disabled"/> <int value="-2093047873" @@ -46822,6 +47866,7 @@ from previous Chrome versions. <int value="-2090484194" label="ContextualSearchUrlActions:disabled"/> <int value="-2088555929" label="EnableAppGridGhost:enabled"/> <int value="-2088472280" label="KeyboardShortcutViewerApp:disabled"/> + <int value="-2088263177" label="EnableMixedContentDownloadDialog:enabled"/> <int value="-2084849051" label="TabGroupsCollapseFreezing:disabled"/> <int value="-2083998415" label="VrLaunchIntent:enabled"/> <int value="-2083195884" label="enable-firewall-hole-punching"/> @@ -46850,6 +47895,8 @@ from previous Chrome versions. label="AutofillSaveCreditCardUsesStrikeSystemV2:disabled"/> <int value="-2059771509" label="NTPTilesLowerResolutionFavicons:disabled"/> <int value="-2059331227" label="DiceWebSigninInterception:disabled"/> + <int value="-2058862330" + label="ExperimentalAccessibilitySwitchAccessSetupGuide:disabled"/> <int value="-2058762785" label="AllowDownloadResumptionWithoutStrongValidators:disabled"/> <int value="-2058656447" label="ContextualSearchUrlActions:enabled"/> @@ -46884,7 +47931,9 @@ from previous Chrome versions. label="KeepAliveRendererForKeepaliveRequests:enabled"/> <int value="-2037390759" label="IncognitoBrandConsistencyForAndroid:disabled"/> + <int value="-2036629516" label="SideSearchStatePerTab:enabled"/> <int value="-2036149591" label="FaviconsFromWebManifest:disabled"/> + <int value="-2036127998" label="LocalWebApprovals:disabled"/> <int value="-2035126988" label="enabled-new-style-notification"/> <int value="-2033950090" label="AutofillNoLocalSaveOnUploadSuccess:disabled"/> <int value="-2033908928" label="NightLight:enabled"/> @@ -46901,6 +47950,8 @@ from previous Chrome versions. <int value="-2026156288" label="LookalikeUrlNavigationSuggestionsUI:disabled"/> <int value="-2025367104" label="enable-material-design-ntp"/> + <int value="-2025330968" label="Journeys:disabled"/> + <int value="-2024330288" label="RawDraw:enabled"/> <int value="-2023673947" label="TabRestoreSubMenus:disabled"/> <int value="-2022956008" label="ExternalPciDevicesAllowed:disabled"/> <int value="-2021954068" label="TapVisualizerApp:disabled"/> @@ -46932,7 +47983,6 @@ from previous Chrome versions. <int value="-2003354337" label="enable-search-button-in-omnibox-for-str-or-iip"/> <int value="-2002461806" label="ShoppingAssist:enabled"/> - <int value="-2002453030" label="UseOzonePlatform:disabled"/> <int value="-2001869199" label="ShillSandboxing:enabled"/> <int value="-2000567059" label="SimplifyHttpsIndicator:enabled"/> <int value="-1999892428" label="force-ui-direction"/> @@ -46943,8 +47993,11 @@ from previous Chrome versions. label="OmniboxGroupSuggestionsBySearchVsUrl:enabled"/> <int value="-1996087238" label="kAutofillEnableOffersInDownstream:enabled"/> <int value="-1995534832" label="DownloadProgressMessage:disabled"/> + <int value="-1993739187" + label="AutofillHighlightOnlyChangedValuesInPreviewMode:disabled"/> <int value="-1993730028" label="CrostiniPortForwarding:enabled"/> <int value="-1992999120" label="composite-after-paint"/> + <int value="-1992488524" label="AutofillAcrossIframes:disabled"/> <int value="-1990614981" label="StoragePressureUI:disabled"/> <int value="-1989747818" label="TabStripKeyboardFocus:disabled"/> <int value="-1989134646" label="PhoneHubUseBle:disabled"/> @@ -46965,6 +48018,7 @@ from previous Chrome versions. <int value="-1977496883" label="ViewPasswords:enabled"/> <int value="-1975719988" label="GlobalMediaControlsSeamlessTransfer:enabled"/> <int value="-1973722176" label="VoiceSearchOnLocalNtp:enabled"/> + <int value="-1973559591" label="AppDiscoveryForOobe:enabled"/> <int value="-1972383451" label="disable-pinch"/> <int value="-1972312724" label="OfflinePagesLoadSignalCollecting:enabled"/> <int value="-1972219399" label="NTPSaveToOffline:enabled"/> @@ -46988,6 +48042,7 @@ from previous Chrome versions. <int value="-1961062505" label="VrBrowsingInCustomTab:disabled"/> <int value="-1960567385" label="KeepPrefetchedContentSuggestions:enabled"/> <int value="-1959563554" label="ChromeOSAccountManager:enabled"/> + <int value="-1958364669" label="QueryTilesSegmentation:enabled"/> <int value="-1958315092" label="EnableGamepadButtonAxisEvents:disabled"/> <int value="-1957328398" label="MacSystemShareMenu:disabled"/> <int value="-1956747298" label="LayeredAPI:enabled"/> @@ -47025,6 +48080,7 @@ from previous Chrome versions. label="OmniboxUIExperimentHideSuggestionUrlTrivialSubdomains:enabled"/> <int value="-1939003674" label="NetworkServiceInProcess:disabled"/> <int value="-1938263248" label="enable-extension-info-dialog"/> + <int value="-1937145719" label="EnableWebAppUninstallFromOsSettings:enabled"/> <int value="-1937077699" label="http-form-warning"/> <int value="-1936032607" label="enable-experimental-webassembly-features"/> <int value="-1935787681" label="SystemNotifications:disabled"/> @@ -47036,6 +48092,7 @@ from previous Chrome versions. <int value="-1932609987" label="CSSBackdropFilter:disabled"/> <int value="-1932379839" label="OmniboxUIExperimentHideSteadyStateUrlTrivialSubdomains:enabled"/> + <int value="-1931712004" label="ConsolidatedSiteStorageControls:disabled"/> <int value="-1930720286" label="nacl-debug-mask"/> <int value="-1928198763" label="enable-async-dns"/> <int value="-1927080237" label="Vulkan:enabled"/> @@ -47051,6 +48108,7 @@ from previous Chrome versions. label="WalletRequiresFirstSyncSetupComplete:disabled"/> <int value="-1921593903" label="ImeInputLogicHmm:disabled"/> <int value="-1920912991" label="PermissionChip:disabled"/> + <int value="-1920004248" label="FeedBackToTop:disabled"/> <int value="-1919683750" label="EnableOopPrintDrivers:disabled"/> <int value="-1919199528" label="AlwaysShowServerCardsInSyncTransport:disabled"/> @@ -47071,6 +48129,7 @@ from previous Chrome versions. label="OverlayScrollbarFlashAfterAnyScrollUpdate:enabled"/> <int value="-1907565048" label="HtmlBaseUsernameDetector:disabled"/> <int value="-1907342706" label="ReadItLaterInMenu:disabled"/> + <int value="-1905470520" label="FirmwareUpdaterApp:enabled"/> <int value="-1903365454" label="SyncPseudoUSSPreferences:disabled"/> <int value="-1899715534" label="GamepadPollingInterval:enabled"/> <int value="-1899652563" label="ReportFeedUserActions:enabled"/> @@ -47081,16 +48140,20 @@ from previous Chrome versions. label="OmniboxKeywordSpaceTriggeringSetting:disabled"/> <int value="-1898386671" label="PasswordCheck:enabled"/> <int value="-1898229093" label="WebApkGenerator:enabled"/> + <int value="-1898129939" label="U2fPermissionPrompt:enabled"/> + <int value="-1897800883" label="OpenscreenCastStreamingSession:enabled"/> <int value="-1896871201" label="CrossOriginOpenerPolicyReporting:enabled"/> <int value="-1896733769" label="CheckOfflineCapability:disabled"/> <int value="-1896394207" label="PasswordChange:disabled"/> <int value="-1895719323" label="VrBrowsingTabsView:enabled"/> <int value="-1895050832" label="GlobalMediaControlsCastStartStop:disabled"/> <int value="-1894699049" label="AudioFocusEnforcement:disabled"/> + <int value="-1894576813" label="WebBluetoothBondOnDemand:enabled"/> <int value="-1894289914" label="IncognitoScreenshot:disabled"/> <int value="-1894054576" label="FontAccess:enabled"/> <int value="-1893668420" label="AutofillSaveCreditCardUsesStrikeSystem:enabled"/> + <int value="-1893119399" label="U2FSecurityKeyAPI:enabled"/> <int value="-1893019071" label="CSSOMViewScrollCoordinates:disabled"/> <int value="-1892758622" label="SendTabToSelfV2:disabled"/> <int value="-1892555086" label="disable-compositor-animation-timelines"/> @@ -47117,6 +48180,7 @@ from previous Chrome versions. <int value="-1875383510" label="UseGoogleLocalNtp:disabled"/> <int value="-1875168316" label="UseMonitorColorSpace:disabled"/> <int value="-1874908826" label="enable-instant-search-clicks"/> + <int value="-1874842483" label="FeedLoadingPlaceholder:disabled"/> <int value="-1874141108" label="NewOmniboxAnswerTypes:enabled"/> <int value="-1872989945" label="enable-webview-based-signin"/> <int value="-1872867546" label="EnumerateAudioDevices:disabled"/> @@ -47147,6 +48211,7 @@ from previous Chrome versions. <int value="-1855347512" label="FormControlsRefresh:disabled"/> <int value="-1854432127" label="ChromeHomePullToRefreshIphAtTop:disabled"/> <int value="-1854372227" label="VrBrowsingExperimentalFeatures:enabled"/> + <int value="-1853877370" label="CastStreamingVp9:disabled"/> <int value="-1853570433" label="AdvancedPpdAttributes:enabled"/> <int value="-1851980281" label="TabGroupsCollapse:enabled"/> <int value="-1849706663" label="enable-password-force-saving:disabled"/> @@ -47178,26 +48243,35 @@ from previous Chrome versions. <int value="-1835905702" label="FilesZipNoNaCl:enabled"/> <int value="-1835844760" label="ArcVmBalloonPolicy:disabled"/> <int value="-1835608319" label="EnableHeuristicPalmDetectionFilter:disabled"/> + <int value="-1835592983" label="WebAppEnableLaunchHandler:disabled"/> <int value="-1834841895" label="CrostiniWebUIUpgrader:enabled"/> <int value="-1834151268" label="OmniboxDynamicMaxAutocomplete:disabled"/> <int value="-1833149810" label="enable-accessibility-tab-switcher"/> <int value="-1832575380" label="show-saved-copy"/> + <int value="-1832512456" label="LibinputHandleTouchpad:disabled"/> <int value="-1832221649" label="disable-out-of-process-pac"/> + <int value="-1830709105" label="OmniboxPedalsBatch3NonEnglish:disabled"/> <int value="-1830472348" label="CryptAuthV2DeviceSync:enabled"/> <int value="-1830199297" label="force-empty-corb-allowlist"/> <int value="-1827599944" label="QueryTilesLocalOrdering:enabled"/> <int value="-1826649921" label="ContextualSuggestionsButton:disabled"/> <int value="-1826309726" label="ArcCustomTabsExperiment:disabled"/> + <int value="-1824539611" label="U2fPermissionPrompt:disabled"/> <int value="-1823193038" label="QuietNotificationPrompts:disabled"/> <int value="-1823073826" label="TabGroupsSave:disabled"/> <int value="-1822825246" label="DragFromShelfToHomeOrOverview:enabled"/> <int value="-1821058653" label="enable-delay-agnostic-aec"/> <int value="-1818947212" label="OutOfBlinkCors:disabled"/> + <int value="-1818565030" + label="AutofillUseConsistentPopupSettingsIcons:disabled"/> <int value="-1817209284" label="PayWithGoogleV1:enabled"/> <int value="-1816066138" label="CastAllowAllIPs:enabled"/> + <int value="-1813088913" label="CCTResizable90MaximumHeight:disabled"/> + <int value="-1813070975" label="PageContentAnnotations:disabled"/> <int value="-1812579951" label="ContentSuggestionsCategoryRanker:enabled"/> <int value="-1811949013" label="SameSiteByDefaultCookies:disabled"/> <int value="-1811394154" label="disable-webrtc-hw-vp8-encoding"/> + <int value="-1810891359" label="SendTabToSelfManageDevicesLink:disabled"/> <int value="-1810294310" label="AndroidPaymentApps:enabled"/> <int value="-1809969509" label="FilesSinglePartitionFormat:disabled"/> <int value="-1809891158" label="WebAuthenticationCable:enabled"/> @@ -47315,6 +48389,7 @@ from previous Chrome versions. <int value="-1710772665" label="disable-my-files-navigation"/> <int value="-1706483123" label="VmStatusPage:enabled"/> <int value="-1704472714" label="UseMessagesGoogleComDomain:disabled"/> + <int value="-1704022650" label="EnableDangerousDownloadDialog:enabled"/> <int value="-1703709912" label="enable-new-ntp"/> <int value="-1703308540" label="disable-webaudio"/> <int value="-1701123067" label="ShowManagedUi:enabled"/> @@ -47377,6 +48452,7 @@ from previous Chrome versions. <int value="-1660884825" label="ReadLaterNewBadgePromo:enabled"/> <int value="-1656179450" label="EnableOmniboxRichEntities:enabled"/> <int value="-1655535052" label="enable-pointer-events"/> + <int value="-1655281250" label="DefaultCalculatorWebApp:enabled"/> <int value="-1654344175" label="disable-extension-info-dialog"/> <int value="-1653991213" label="CrossOriginIsolated:disabled"/> <int value="-1653838003" label="PauseBackgroundTabs:enabled"/> @@ -47391,6 +48467,8 @@ from previous Chrome versions. <int value="-1644308778" label="WASAPIRawAudioCapture:disabled"/> <int value="-1643933608" label="SyncAutofillWalletOfferData:enabled"/> <int value="-1641832607" label="DragToPinTabs:enabled"/> + <int value="-1641384018" label="SideSearchClearCacheWhenClosed:enabled"/> + <int value="-1640944841" label="HardwareSecureDecryption:disabled"/> <int value="-1639534120" label="VaapiVp9kSVCHWEncoding:enabled"/> <int value="-1639050182" label="NavigationPredictorRendererWarmup:enabled"/> <int value="-1638815914" label="enable-experimental-productivity-features"/> @@ -47401,6 +48479,7 @@ from previous Chrome versions. label="AutofillCreditCardLocalCardMigration:disabled"/> <int value="-1634154256" label="ZeroSuggestRedirectToChrome:enabled"/> <int value="-1633586675" label="TabModalJsDialog:enabled"/> + <int value="-1633416642" label="WallpaperFullScreenPreview:disabled"/> <int value="-1632828661" label="PrivacyReorderedAndroid:disabled"/> <int value="-1631329950" label="ssl-version-max"/> <int value="-1630419335" label="enable-download-notification"/> @@ -47422,6 +48501,7 @@ from previous Chrome versions. <int value="-1619757314" label="touch-scrolling-mode"/> <int value="-1619146163" label="OverrideSitePrefsForHrefTranslate:disabled"/> <int value="-1618707999" label="enable-webfonts-intervention-v2"/> + <int value="-1617805422" label="WebViewUseMetricsUploadService:enabled"/> <int value="-1617183455" label="OfflineRecentPages:disabled"/> <int value="-1616855537" label="enable-manual-password-generation:disabled"/> <int value="-1615901413" label="NewMacNotificationAPI:enabled"/> @@ -47430,6 +48510,8 @@ from previous Chrome versions. label="AutofillLocalCardMigrationUsesStrikeSystemV2:disabled"/> <int value="-1614912400" label="enable-link-disambiguation-popup"/> <int value="-1613583483" label="UseNewAcceptLanguageHeader:enabled"/> + <int value="-1612418793" + label="ExperimentalAccessibilitySwitchAccessSetupGuide:enabled"/> <int value="-1611758030" label="AndroidWebContentsDarkMode:disabled"/> <int value="-1611357520" label="MediaAppPdfInInk:enabled"/> <int value="-1611305202" label="KeepPrefetchedContentSuggestions:disabled"/> @@ -47442,6 +48524,7 @@ from previous Chrome versions. <int value="-1606215707" label="WebAppWindowControlsOverlay:enabled"/> <int value="-1605920602" label="AVFoundationCaptureV2:disabled"/> <int value="-1605567628" label="disable-overlay-scrollbar"/> + <int value="-1604519960" label="SystemKoreanPhysicalTyping:enabled"/> <int value="-1604051051" label="SpecialLocale:disabled"/> <int value="-1603404046" label="V8VmFuture:disabled"/> <int value="-1603074997" label="LensRegionSearch:enabled"/> @@ -47500,6 +48583,7 @@ from previous Chrome versions. <int value="-1560729847" label="AutofillCacheQueryResponses:enabled"/> <int value="-1560650271" label="WasmCodeCache:disabled"/> <int value="-1559789642" label="RunAllFlashInAllowMode:enabled"/> + <int value="-1559292789" label="SideSearch:disabled"/> <int value="-1557747651" label="FractionalScrollOffsets:disabled"/> <int value="-1557527869" label="LoadingWithMojo:disabled"/> <int value="-1555510175" label="PasswordImport:enabled"/> @@ -47516,6 +48600,7 @@ from previous Chrome versions. <int value="-1547953198" label="FullRestore:enabled"/> <int value="-1547247328" label="OverrideTranslateTriggerInIndia:disabled"/> <int value="-1546903171" label="enable-touch-drag-drop"/> + <int value="-1546461079" label="CCTResizableForFirstParties:disabled"/> <int value="-1546351452" label="CrossOriginIsolated:enabled"/> <int value="-1546029755" label="OverrideTranslateTriggerInIndia:enabled"/> <int value="-1545595496" label="RendererSideResourceScheduler:enabled"/> @@ -47782,6 +48867,7 @@ from previous Chrome versions. <int value="-1356379431" label="GlobalMediaControlsOverlayControls:enabled"/> <int value="-1355886577" label="ReleaseNotesNotificationAllChannels:enabled"/> <int value="-1355717940" label="WebViewPowerSchedulerThrottleIdle:enabled"/> + <int value="-1353926640" label="GMSCoreEmoji:disabled"/> <int value="-1353865639" label="InteractiveWindowCycleList:disabled"/> <int value="-1353714232" label="FilesTransferDetails:enabled"/> <int value="-1353195918" label="UseSkiaRenderer:enabled"/> @@ -47793,9 +48879,11 @@ from previous Chrome versions. label="disallow-autofill-sync-credential-for-reauth"/> <int value="-1349826793" label="ArcInputMethod:disabled"/> <int value="-1349532167" label="enable-wifi-credential-sync"/> + <int value="-1349146355" label="Win11StyleMenus:disabled"/> <int value="-1348040371" label="ScanAppStickySettings:disabled"/> <int value="-1346722635" label="gesture-selection"/> <int value="-1345931804" label="TabbedAppOverflowMenuIcons:disabled"/> + <int value="-1345471133" label="JourneysOmniboxAction:enabled"/> <int value="-1344375439" label="ServiceWorkerPaymentApps:disabled"/> <int value="-1343259222" label="RegionalLocalesAsDisplayUI:disabled"/> <int value="-1342961844" label="InlineUpdateFlow:disabled"/> @@ -47808,7 +48896,9 @@ from previous Chrome versions. <int value="-1337185440" label="enable-webvr"/> <int value="-1336110789" label="CastMediaRouteProvider:disabled"/> <int value="-1335017208" label="KeyboardLockAPI:enabled"/> + <int value="-1334976417" label="ArcAllowDataRetention:disabled"/> <int value="-1334909143" label="NtpModulesDragAndDrop:disabled"/> + <int value="-1334336593" label="SystemKoreanPhysicalTyping:disabled"/> <int value="-1334327410" label="ash-enable-touch-view-testing"/> <int value="-1333946113" label="ContentIndexingDownloadHome:disabled"/> <int value="-1332267458" label="RemoveNavigationHistory:enabled"/> @@ -47823,6 +48913,7 @@ from previous Chrome versions. <int value="-1324634193" label="EnablePalmOnMaxTouchMajor:disabled"/> <int value="-1324029365" label="EnableTLS13EarlyData:enabled"/> <int value="-1322882747" label="disable-datasaver-prompt"/> + <int value="-1322830330" label="ContextualSearchNewSettings:enabled"/> <int value="-1321935621" label="WebAppsCrosapi:enabled"/> <int value="-1321640296" label="AutofillDownstreamCvcPromptUseGooglePayLogo:enabled"/> @@ -47868,6 +48959,8 @@ from previous Chrome versions. <int value="-1290053302" label="OfflinePagesInDownloadHomeOpenInCct:disabled"/> <int value="-1289678848" label="SystemDownloadManager:enabled"/> + <int value="-1289078823" + label="EnableDesksTrackpadSwipeImprovements:enabled"/> <int value="-1288130734" label="OpenVR:disabled"/> <int value="-1287511172" label="OmniboxUIExperimentHideSteadyStateUrlSchemeAndSubdomains:disabled"/> @@ -47887,6 +48980,7 @@ from previous Chrome versions. <int value="-1275552094" label="SpectreVariant2Mitigation:disabled"/> <int value="-1274502866" label="AllowDisableMouseAcceleration:enabled"/> <int value="-1272593346" label="NewTabLoadingAnimation:disabled"/> + <int value="-1271921284" label="WebViewThreadSafeMedia:enabled"/> <int value="-1271563519" label="enable-appcontainer"/> <int value="-1271441871" label="AmbientColor:enabled"/> <int value="-1270634957" label="PhoneHubUseBle:enabled"/> @@ -47895,6 +48989,7 @@ from previous Chrome versions. <int value="-1269093329" label="AndroidOmniboxPreviewsBadge:disabled"/> <int value="-1269084216" label="ash-md"/> <int value="-1268836676" label="disable-out-of-process-pdf"/> + <int value="-1268452697" label="CastStreamingAv1:disabled"/> <int value="-1267958145" label="disable-pdf-material-ui"/> <int value="-1265627803" label="WebAppEnableManifestId:enabled"/> <int value="-1262730949" label="EnableDspHotword:enabled"/> @@ -47903,6 +48998,7 @@ from previous Chrome versions. <int value="-1261972671" label="OmniboxDocumentProvider:disabled"/> <int value="-1261263046" label="RemoveUsageOfDeprecatedGaiaSigninEndpoint:disabled"/> + <int value="-1261110018" label="AllowDisableTouchpadHapticFeedback:disabled"/> <int value="-1259901957" label="VrBrowserKeyboard:disabled"/> <int value="-1259627326" label="AllowRepeatedUpdates:disabled"/> <int value="-1258141852" label="ScrollUnification:enabled"/> @@ -47924,14 +49020,12 @@ from previous Chrome versions. <int value="-1251359563" label="SharingRenameDevices:disabled"/> <int value="-1250965985" label="MediaFeeds:enabled"/> <int value="-1250611337" label="ChromeVoxArcSupport:disabled"/> - <int value="-1250326683" - label="MagnifierCaretFollowingFromJavascript:enabled"/> + <int value="-1250222445" label="WebMidi:enabled"/> <int value="-1248478422" label="enable-zip-archiver-packer"/> <int value="-1246840031" label="OptInImeMenu:disabled"/> <int value="-1245617305" label="NewProfilePicker:enabled"/> <int value="-1244772303" label="NtpRealboxMatchOmniboxTheme:enabled"/> <int value="-1243694853" label="DeferAllScript:disabled"/> - <int value="-1243206311" label="OmniboxPedalsDefaultIconColored:disabled"/> <int value="-1242867644" label="BorealisDiskManagement:enabled"/> <int value="-1241868814" label="WebAuthenticationPhoneSupport:disabled"/> <int value="-1241747717" label="enable-android-password-link"/> @@ -47956,6 +49050,7 @@ from previous Chrome versions. <int value="-1228546373" label="UseLookalikesForNavigationSuggestions:enabled"/> <int value="-1227660915" label="WebContentsOcclusion:disabled"/> + <int value="-1226536953" label="DeskTemplateSync:disabled"/> <int value="-1225772151" label="OfflineHome:disabled"/> <int value="-1225629234" label="SyncPseudoUSSFavicons:enabled"/> <int value="-1225198073" label="ReaderModeInCCT:disabled"/> @@ -47998,6 +49093,7 @@ from previous Chrome versions. <int value="-1198304634" label="ProcessSharingWithDefaultSiteInstances:disabled"/> <int value="-1197916855" label="WindowNaming:enabled"/> + <int value="-1197817692" label="CrostiniBullseyeUpgrade:enabled"/> <int value="-1197245070" label="CookieDeprecationMessages:disabled"/> <int value="-1197035323" label="ZeroSuggestRedirectToChrome:disabled"/> <int value="-1195194959" label="XGEOVisibleNetworks:disabled"/> @@ -48039,6 +49135,7 @@ from previous Chrome versions. label="BluetoothAggressiveAppearanceFilter:disabled"/> <int value="-1166715563" label="ChromeOSAssistant:disabled"/> <int value="-1164858657" label="CrostiniUsbAllowUnsupported:disabled"/> + <int value="-1164578922" label="BookmarksRefresh:enabled"/> <int value="-1163777157" label="ContextualSearchSimplifiedServer:disabled"/> <int value="-1162944097" label="enable-color-correct-rendering"/> <int value="-1162636562" label="ReduceHorizontalFlingVelocity:disabled"/> @@ -48057,6 +49154,8 @@ from previous Chrome versions. label="CryptAuthV2DeviceActivityStatusUseConnectivity:enabled"/> <int value="-1156179600" label="OmniboxRichEntitySuggestions:enabled"/> <int value="-1155543191" label="CopylessPaste:disabled"/> + <int value="-1155071457" + label="CCTResizableAllowResizeByUserGesture:disabled"/> <int value="-1154834060" label="OmniboxRichAutocompletion:disabled"/> <int value="-1154819618" label="FilesNG:enabled"/> <int value="-1154343236" label="VrBrowsingTabsView:disabled"/> @@ -48106,6 +49205,7 @@ from previous Chrome versions. <int value="-1117894706" label="DarkLightMode:enabled"/> <int value="-1117104514" label="smbfs-file-shares"/> <int value="-1116278039" label="ShelfAppScaling:disabled"/> + <int value="-1115681358" label="FeedBackToTop:enabled"/> <int value="-1114080030" label="ResourceLoadingHints:enabled"/> <int value="-1113373128" label="WebUIDownloadShelf:enabled"/> <int value="-1112782121" label="AndroidSigninPromos:disabled"/> @@ -48116,6 +49216,7 @@ from previous Chrome versions. <int value="-1105686819" label="ShareUsageRanking:enabled"/> <int value="-1105637876" label="FilteringScrollPrediction:enabled"/> <int value="-1104914981" label="frame-throttle-fps"/> + <int value="-1104609838" label="UserMediaCaptureOnFocus:enabled"/> <int value="-1103221768" label="DefaultChatWebApp:enabled"/> <int value="-1103099187" label="NotificationStackingBarRedesign:disabled"/> <int value="-1102212525" label="enable-tcp-fastopen"/> @@ -48137,6 +49238,7 @@ from previous Chrome versions. <int value="-1084055006" label="disable-web-notification-custom-layouts"/> <int value="-1083736482" label="OmniboxCompactSuggestions:enabled"/> <int value="-1083547717" label="NotificationExpansionAnimation:disabled"/> + <int value="-1083146397" label="AutofillTypeSpecificPopupWidth:enabled"/> <int value="-1082302549" label="scan-cards-in-web-payments"/> <int value="-1082053427" label="OmniboxUIExperimentElideToRegistrableDomain:disabled"/> @@ -48151,6 +49253,7 @@ from previous Chrome versions. <int value="-1074257709" label="ScalableAppList:enabled"/> <int value="-1074107607" label="data-reduction-proxy-experiment"/> <int value="-1073479583" label="ShowArcFilesApp:disabled"/> + <int value="-1071043945" label="VerticalSnap:enabled"/> <int value="-1069628248" label="OmniboxZeroSuggestionsOnSERP:enabled"/> <int value="-1069453905" label="CCTModuleUseIntentExtras:disabled"/> <int value="-1068197506" label="EnhancedNetworkVoices:enabled"/> @@ -48177,6 +49280,7 @@ from previous Chrome versions. <int value="-1052219252" label="disable-captive-portal-bypass-proxy"/> <int value="-1052115254" label="TextfieldFocusOnTapUp:disabled"/> <int value="-1051509976" label="ServiceWorkerOnUI:disabled"/> + <int value="-1050006327" label="FirmwareUpdaterApp:disabled"/> <int value="-1048901516" label="ChromeMemex:enabled"/> <int value="-1048011353" label="LongPressBackNewDesign:disabled"/> <int value="-1046641729" label="TranslateUI:enabled"/> @@ -48212,12 +49316,15 @@ from previous Chrome versions. <int value="-1027124889" label="NtlmV2Enabled:enabled"/> <int value="-1026192558" label="OopRasterizationDDL:enabled"/> <int value="-1025125875" label="AssistantTimersV2:disabled"/> + <int value="-1024731815" label="MessagesForAndroidNearOomReduction:enabled"/> + <int value="-1024065253" label="EnableWireGuard:disabled"/> <int value="-1022971520" label="enable-search-button-in-omnibox-for-str"/> <int value="-1022281869" label="ArcRtVcpuDualCore:enabled"/> <int value="-1022165708" label="BreakingNewsPush:disabled"/> <int value="-1021097344" label="PolicyAtomicGroup:disabled"/> <int value="-1020450980" label="gesture-deletion"/> <int value="-1019967332" label="VrBrowsing:enabled"/> + <int value="-1019760093" label="PrintWithPostScriptType42Fonts:enabled"/> <int value="-1019492310" label="OmniboxUIExperimentJogTextfieldOnPopup:enabled"/> <int value="-1018454657" label="SharingPeerConnectionReceiver:enabled"/> @@ -48238,6 +49345,7 @@ from previous Chrome versions. <int value="-1002537430" label="HudDisplayForPerformanceMetrics:disabled"/> <int value="-1001837588" label="EnableAppReinstallZeroState:enabled"/> <int value="-1000671573" label="TemporaryUnexpireFlagsM80:enabled"/> + <int value="-998970149" label="BookmarksRefresh:disabled"/> <int value="-998731974" label="WinUseBrowserSpellChecker:enabled"/> <int value="-998310305" label="OmniboxContextMenuShowFullUrls:disabled"/> <int value="-998255750" label="ExperimentalKeyboardLockUI:enabled"/> @@ -48255,13 +49363,17 @@ from previous Chrome versions. <int value="-991412904" label="SettingsLandingPageRedesign:disabled"/> <int value="-991253797" label="OmniboxSpeculativeServiceWorkerStartOnQueryInput:disabled"/> + <int value="-990704221" label="TerminalSSH:enabled"/> <int value="-990187062" label="SendTabToSelfShowSendingUI:enabled"/> <int value="-989671895" label="OfflineIndicatorAlwaysHttpProbe:enabled"/> <int value="-989050085" label="AppStoreBillingDebug:enabled"/> <int value="-987470173" label="ClickToCallOpenDialerDirectly:disabled"/> <int value="-987191098" label="FontAccessPersistent:disabled"/> + <int value="-987187004" label="SyncSettingsCategorization:disabled"/> <int value="-984052166" label="DoodlesOnLocalNtp:enabled"/> <int value="-983342281" label="TabSwitcherLongpressMenu:disabled"/> + <int value="-981993135" + label="DesktopPWAsAdditionalWindowingControls:enabled"/> <int value="-981237342" label="SyncUSSAutofillWalletMetadata:disabled"/> <int value="-980889204" label="SharingRenameDevices:enabled"/> <int value="-980317085" label="EnablePasswordsAccountStorage:disabled"/> @@ -48295,12 +49407,14 @@ from previous Chrome versions. <int value="-963683462" label="EnablePalmSuppression:enabled"/> <int value="-962030536" label="ChromeDuetLabeled:enabled"/> <int value="-960077963" label="EnableAuraTooltipsOnWindows:enabled"/> + <int value="-959173180" label="AccessibilityPageZoom:disabled"/> <int value="-958950214" label="AllowDisableMouseAcceleration:disabled"/> <int value="-958372962" label="LacrosSupport:enabled"/> <int value="-957200826" label="enable-spdy-proxy-auth"/> <int value="-956696029" label="scheduler-configuration"/> <int value="-955667686" label="AutofillSuppressCreditCardSaveForAssistant:enabled"/> + <int value="-954789862" label="ProductivityLauncher:enabled"/> <int value="-953215709" label="StorageAccessAPI:enabled"/> <int value="-952996862" label="ArcUseHighMemoryDalvikProfile:enabled"/> <int value="-952971446" label="WebAssemblyCodeProtection:disabled"/> @@ -48345,6 +49459,7 @@ from previous Chrome versions. <int value="-912585719" label="AppManagementIntentSettings:disabled"/> <int value="-912456561" label="MidiManagerWinrt:enabled"/> <int value="-910452816" label="ChromeOSParentalControlsSettings:disabled"/> + <int value="-910007270" label="FeedbackReportQuestionnaire:enabled"/> <int value="-909905655" label="AllowAllSitesToInitiateMirroring:disabled"/> <int value="-909351661" label="OmniboxOnFocusSuggestions:disabled"/> <int value="-908421850" label="PointerEvent:enabled"/> @@ -48386,7 +49501,6 @@ from previous Chrome versions. <int value="-881447505" label="ash-disable-shelf-model-synchronization"/> <int value="-881054479" label="WebAssemblyStreaming:disabled"/> <int value="-880201293" label="OmniboxAssistantVoiceSearch:disabled"/> - <int value="-880087793" label="OmniboxPedalsBatch2:enabled"/> <int value="-879055117" label="ClipboardContentSetting:enabled"/> <int value="-879031960" label="FetchKeepaliveTimeoutSetting:disabled"/> <int value="-879024703" label="pwa-update-dialog-for-name-and-icon:enabled"/> @@ -48431,6 +49545,7 @@ from previous Chrome versions. <int value="-853455968" label="OmniboxDefaultTypedNavigationsToHttps:disabled"/> <int value="-850821337" label="WebContentsForceDark:enabled"/> + <int value="-849792130" label="UserMediaCaptureOnFocus:disabled"/> <int value="-848691867" label="DesktopPWAWindowing:enabled"/> <int value="-847735582" label="NotificationsViaHelperApp:enabled"/> <int value="-847216521" label="ChromeDuplex:enabled"/> @@ -48453,6 +49568,10 @@ from previous Chrome versions. <int value="-832561975" label="enable-picture-in-picture"/> <int value="-831066457" label="IncognitoBrandConsistencyForDesktop:disabled"/> <int value="-825942229" label="tab-management-experiment-type-elderberry"/> + <int value="-825747847" + label="AutofillEnableSupportForMoreStructureInAddresses:enabled"/> + <int value="-825312041" label="CastStreamingAv1:enabled"/> + <int value="-824829316" label="UsbDeviceDefaultAttachToArcVm:enabled"/> <int value="-824199802" label="ContextualSearchSimplifiedServer:enabled"/> <int value="-823394398" label="TargetEmbeddingLookalikes:enabled"/> <int value="-823165021" label="MaterialDesignUserMenu:enabled"/> @@ -48465,6 +49584,7 @@ from previous Chrome versions. <int value="-816895294" label="DiscoverApp:disabled"/> <int value="-816404462" label="TabGroupsAutoCreate:disabled"/> <int value="-815213125" label="SplitSettings:enabled"/> + <int value="-815067606" label="AppDiscoveryRemoteUrlSearch:enabled"/> <int value="-814097014" label="disable-session-crashed-bubble"/> <int value="-813753274" label="VrBrowsing:disabled"/> <int value="-813474479" label="site-per-process"/> @@ -48511,6 +49631,7 @@ from previous Chrome versions. <int value="-777568290" label="FilesTransferDetails:disabled"/> <int value="-777126951" label="FontSrcLocalMatching:enabled"/> <int value="-776686417" label="SiteExplorationUi:disabled"/> + <int value="-775952696" label="FeedStamp:enabled"/> <int value="-775321548" label="UseNewDoodleApi:disabled"/> <int value="-773238824" label="AutoplayWhitelistSettings:disabled"/> <int value="-772679248" label="MojoVideoEncodeAccelerator:enabled"/> @@ -48519,6 +49640,8 @@ from previous Chrome versions. <int value="-771080109" label="GrantNotificationsToDSE:disabled"/> <int value="-770319039" label="enable-touch-editing"/> <int value="-769865314" label="AutofillCacheQueryResponses:disabled"/> + <int value="-767460914" + label="ExperimentalAccessibilityDictationCommands:disabled"/> <int value="-766805224" label="MirroringService:enabled"/> <int value="-764463072" label="WebViewMixedContentAutoupgrades:disabled"/> <int value="-763900417" label="CCTModuleUseIntentExtras:enabled"/> @@ -48578,6 +49701,7 @@ from previous Chrome versions. <int value="-725264428" label="CompositingBasedThrottling:enabled"/> <int value="-723224470" label="enable-password-force-saving:enabled"/> <int value="-722474177" label="browser-side-navigation:disabled"/> + <int value="-722172419" label="SystemChinesePhysicalTyping:disabled"/> <int value="-721685663" label="WebViewMixedContentAutoupgrades:enabled"/> <int value="-721245076" label="DesktopPWAsStayInWindow:disabled"/> <int value="-719819631" label="TranslateUI:disabled"/> @@ -48622,10 +49746,13 @@ from previous Chrome versions. <int value="-695687521" label="double-buffer-compositing"/> <int value="-694622753" label="VizHitTest:disabled"/> <int value="-694187898" label="MashOopViz:disabled"/> + <int value="-693881124" + label="AutofillEnableSupportForMoreStructureInNames:disabled"/> <int value="-688003116" label="FocusFollowsCursor:enabled"/> <int value="-687302378" label="BluetoothFixA2dpPacketSize:enabled"/> <int value="-686788480" label="OsSettingsAppNotificationsPage:enabled"/> <int value="-686761381" label="UseHDRTransferFunction:enabled"/> + <int value="-686617279" label="WebAppEnableLaunchHandler:enabled"/> <int value="-684900739" label="disable-merge-key-char-events"/> <int value="-684503292" label="OmniboxTabSwitchSuggestionsDedicatedRow:enabled"/> @@ -48699,6 +49826,8 @@ from previous Chrome versions. <int value="-629041881" label="MuteNotificationsDuringScreenShare:disabled"/> <int value="-626329144" label="SyncSupportTrustedVaultPassphrase:enabled"/> <int value="-626211146" label="DesktopMinimalUI:disabled"/> + <int value="-625858826" label="EnableDuplicateDownloadDialog:disabled"/> + <int value="-625520587" label="RequestDesktopSiteGlobal:enabled"/> <int value="-624221121" label="CommandLineOnNonRooted:enabled"/> <int value="-623364791" label="ClickToCallReceiver:disabled"/> <int value="-622685174" label="enable-pdf-material-ui"/> @@ -48717,6 +49846,7 @@ from previous Chrome versions. <int value="-612633819" label="NotificationScrollBar:disabled"/> <int value="-612480090" label="FasterLocationReload:enabled"/> <int value="-610411643" label="enable-printer-app-search"/> + <int value="-609747087" label="CanvasOopRasterization:enabled"/> <int value="-609034895" label="QuickActionSearchWidgetAndroid:enabled"/> <int value="-608775184" label="PasswordsWeaknessCheck:enabled"/> <int value="-608065163" label="PermissionChipRequestTypeSensitive:disabled"/> @@ -48741,10 +49871,13 @@ from previous Chrome versions. <int value="-595819071" label="OmniboxUIExperimentBlueTitlesOnPageSuggestions:disabled"/> <int value="-595353721" label="RecordWebAppDebugInfo:enabled"/> + <int value="-594732580" label="CCTResizableForThirdParties:enabled"/> <int value="-594076614" label="PluginVmShowCameraPermissions:disabled"/> <int value="-593536514" label="ExperimentalTabController:enabled"/> + <int value="-593079381" label="component-updater"/> <int value="-592628080" label="DnsProxyEnableDOH:disabled"/> <int value="-591874964" label="LiteVideo:enabled"/> + <int value="-591219096" label="SystemChinesePhysicalTyping:enabled"/> <int value="-589096918" label="ash-enable-fullscreen-app-list"/> <int value="-588669613" label="OmniboxClobberIsZeroSuggestEntrypoint:enabled"/> @@ -48753,19 +49886,20 @@ from previous Chrome versions. <int value="-580897686" label="SharedHighlightingAmp:enabled"/> <int value="-579192400" label="disable-input-view"/> <int value="-577982497" label="CupsPrintersUiOverhaul:enabled"/> - <int value="-575161504" label="IncognitoNtpRealBox:enabled"/> <int value="-574354898" label="PostQuantumCECPQ2:enabled"/> <int value="-574217217" label="kSignInProfileCreationEnterprise:enabled"/> <int value="-574000901" label="AVIF:enabled"/> <int value="-573570330" label="QuickAnswersTranslationCloudAPI:disabled"/> <int value="-572112724" label="DialogTouchBar:disabled"/> <int value="-572012175" label="AssistantEnableStereoAudioInput:disabled"/> + <int value="-571655232" label="SideSearch:enabled"/> <int value="-571236436" label="AppManagement:disabled"/> <int value="-570889908" label="CCTModuleDexLoading:enabled"/> <int value="-570572517" label="OmniboxActiveSearchEngines:enabled"/> <int value="-568448085" label="SharedClipboardReceiver:disabled"/> <int value="-567920515" label="disable-experimental-hotwording"/> <int value="-567743697" label="EnableInputNoiseCancellationUi:enabled"/> + <int value="-565368004" label="AutofillCenterAlignedSuggestions:disabled"/> <int value="-563980787" label="disable-webrtc"/> <int value="-563600258" label="PhotoPickerVideoSupport:disabled"/> <int value="-562771426" label="InstantStart:disabled"/> @@ -48778,8 +49912,10 @@ from previous Chrome versions. <int value="-556662059" label="AuraWindowSubtreeCapture:enabled"/> <int value="-556218705" label="SlowDCTimerInterruptsWin:enabled"/> <int value="-555341956" label="AutofillSaveAndFillVPA:enabled"/> + <int value="-552407626" label="ContextualSearchNewSettings:disabled"/> <int value="-551434067" label="QuickActionSearchWidgetAndroidDinoVariant:enabled"/> + <int value="-549837954" label="RevenLogSource:enabled"/> <int value="-548082154" label="protect-sync-credential:disabled"/> <int value="-547301855" label="SyncPseudoUSSSupervisedUsers:enabled"/> <int value="-545419529" label="LauncherAppSort:disabled"/> @@ -48808,6 +49944,7 @@ from previous Chrome versions. <int value="-530799497" label="MacCoreLocationImplementation:enabled"/> <int value="-530480158" label="EnableSuggestedFiles:enabled"/> <int value="-528927088" label="AutofillCreditCardPopupLayout:disabled"/> + <int value="-528441522" label="AppsShortcutDefaultOff:disabled"/> <int value="-528149352" label="WebRtcUseEchoCanceller3:enabled"/> <int value="-527990339" label="ForceEnableFaceAe:enabled"/> <int value="-526236814" label="WebAssemblyTiering:enabled"/> @@ -48820,6 +49957,7 @@ from previous Chrome versions. <int value="-519960638" label="enable-site-engagement-service"/> <int value="-519844731" label="SignInProfileCreationFlow:enabled"/> <int value="-519345823" label="CrOSEnforceSystemAecNsAgc:enabled"/> + <int value="-519342886" label="PrintWithPostScriptType42Fonts:disabled"/> <int value="-518104091" label="NewAudioRenderingMixingStrategy:enabled"/> <int value="-516845951" label="enable-embedded-extension-options"/> <int value="-515913489" label="EphemeralTabUsingBottomSheet:disabled"/> @@ -48894,6 +50032,7 @@ from previous Chrome versions. <int value="-462205750" label="enable-service-worker-sync"/> <int value="-461292699" label="ContentSuggestionsCategoryOrder:enabled"/> <int value="-460702745" label="ExportTaggedPDF:disabled"/> + <int value="-460486807" label="ConsolidatedSiteStorageControls:enabled"/> <int value="-460313418" label="ProgressBarThrottle:enabled"/> <int value="-460081932" label="CustomFeedbackUi:disabled"/> <int value="-459318667" label="AccessiblePDFForm:enabled"/> @@ -48931,6 +50070,7 @@ from previous Chrome versions. <int value="-424584720" label="ClipboardFilenames:enabled"/> <int value="-424134004" label="WebPaymentsExperimentalFeatures:disabled"/> <int value="-421428607" label="InheritNativeThemeFromParentWidget:disabled"/> + <int value="-421314301" label="ForceShowContinueSection:enabled"/> <int value="-420956156" label="WebApkGenerator:disabled"/> <int value="-420347911" label="MobileIdentityConsistencyFRE:disabled"/> <int value="-419733676" label="IsolatePrerendersMustProbeOrigin:disabled"/> @@ -48951,7 +50091,6 @@ from previous Chrome versions. <int value="-405380243" label="enable-encryption-migration"/> <int value="-403701720" label="DirectActions:enabled"/> <int value="-403649153" label="WebViewBrotliSupport:disabled"/> - <int value="-402700953" label="UseOzonePlatform:enabled"/> <int value="-402038055" label="OmniboxUIExperimentBlueTitlesAndGrayUrlsOnPageSuggestions:enabled"/> <int value="-401170566" @@ -48973,6 +50112,7 @@ from previous Chrome versions. <int value="-395454065" label="DisablePostScriptPrinting:disabled"/> <int value="-395259448" label="VideoPlayerJsModules:disabled"/> <int value="-394734604" label="FillingPasswordsFromAnyOrigin:disabled"/> + <int value="-392813122" label="LibinputHandleTouchpad"/> <int value="-389664522" label="OmniboxUIExperimentHideSteadyStateUrlPathQueryAndRefOnInteraction:enabled"/> <int value="-389283574" label="IPH_PasswordsAccountStorage:disabled"/> @@ -48989,6 +50129,7 @@ from previous Chrome versions. <int value="-378033324" label="disable-win32k-renderer-lockdown"/> <int value="-374657496" label="OmniboxEnableClipboardProvider:enabled"/> <int value="-374423260" label="OmniboxTabSwitchSuggestions:disabled"/> + <int value="-373365335" label="JourneysOmniboxAction:disabled"/> <int value="-373233195" label="SyncUSSAutofillWalletData:enabled"/> <int value="-372171039" label="BlinkGenPropertyTrees:disabled"/> <int value="-371397346" label="ChromeOSSharingHub:enabled"/> @@ -49043,6 +50184,7 @@ from previous Chrome versions. <int value="-336768659" label="NtpPhotosModule:enabled"/> <int value="-334873793" label="MediaSessionNotification:enabled"/> <int value="-333216449" label="MouseSubframeNoImplicitCapture:enabled"/> + <int value="-332010491" label="RetailCoupons:enabled"/> <int value="-329727402" label="disable-files-quick-view"/> <int value="-328361990" label="enable-experimental-extension-apis"/> <int value="-327520505" label="RelatedSearchesAlternateUx:enabled"/> @@ -49057,7 +50199,9 @@ from previous Chrome versions. <int value="-322937746" label="disable-desktop-capture-picker-new-ui"/> <int value="-322827131" label="tab-management-experiment-type-basil"/> <int value="-320820051" label="enable-zero-copy"/> + <int value="-319235277" label="ShareMenu:disabled"/> <int value="-319002650" label="ArcUsbStorageUI:enabled"/> + <int value="-317758331" label="WebViewThreadSafeMedia:disabled"/> <int value="-317195508" label="TabGroupsContinuationAndroid:disabled"/> <int value="-315741215" label="IntentBlockExternalFormRedirectsNoGesture:enabled"/> @@ -49082,9 +50226,11 @@ from previous Chrome versions. <int value="-301228557" label="PageInfoDiscoverability:disabled"/> <int value="-300018686" label="disable-cloud-import"/> <int value="-299841473" label="top-document-isolation:enabled"/> + <int value="-299116652" label="CCTResizable90MaximumHeight:enabled"/> <int value="-298629214" label="AutofillParseMerchantPromoCodeFields:disabled"/> <int value="-298458993" label="SystemNotifications:enabled"/> + <int value="-298243336" label="ChromeOSAmbientModeNewUrl:disabled"/> <int value="-297716805" label="CrossOriginMediaPlaybackRequiresUserGesture:disabled"/> <int value="-296762162" label="ExoOrdinalMotion:enabled"/> @@ -49097,6 +50243,7 @@ from previous Chrome versions. <int value="-288316828" label="enable-delegated-renderer"/> <int value="-286603268" label="hide-android-files-in-files-app"/> <int value="-284547865" label="UnifiedConsent:enabled"/> + <int value="-284328071" label="LocalWebApprovals:enabled"/> <int value="-283388027" label="ManualFallbacksFilling:disabled"/> <int value="-283024110" label="WebXRPlaneDetection:disabled"/> <int value="-281844827" label="AutofillCreditCardAblationExperiment:enabled"/> @@ -49122,6 +50269,7 @@ from previous Chrome versions. <int value="-270261701" label="WebRtcEnableCaptureMultiChannelApm:disabled"/> <int value="-269440655" label="AutofillDownstreamCvcPromptUseGooglePayLogo:disabled"/> + <int value="-269227049" label="PersistentQuotaIsTemporaryQuota:enabled"/> <int value="-268897347" label="DisableCameraFrameRotationAtSource:disabled"/> <int value="-268549184" label="AutofillSaveCreditCardUsesStrikeSystemV2:enabled"/> @@ -49139,6 +50287,7 @@ from previous Chrome versions. <int value="-255157394" label="ButtonARCNetworkDiagnostics:enabled"/> <int value="-254887599" label="google-profile-info"/> <int value="-254158542" label="SubresourceRedirectPreviews:enabled"/> + <int value="-253619457" label="ChromeSharingHubLaunchAdjacent:enabled"/> <int value="-252258023" label="ShimlessRMAFlow:enabled"/> <int value="-250822813" label="PwaImprovedSplashScreen:enabled"/> <int value="-250721831" label="AndroidAutofillAccessibility:disabled"/> @@ -49146,6 +50295,8 @@ from previous Chrome versions. <int value="-249415830" label="FilteringScrollPrediction:disabled"/> <int value="-248223420" label="AutofillKeyboardAccessory:disabled"/> <int value="-247542772" label="CheckOfflineCapability:enabled"/> + <int value="-245813749" + label="AutofillHighlightOnlyChangedValuesInPreviewMode:enabled"/> <int value="-245342115" label="PermissionChip:enabled"/> <int value="-241353344" label="MidiManagerWinrt:disabled"/> <int value="-240531943" label="ContextualSearchRankerQuery:disabled"/> @@ -49178,6 +50329,7 @@ from previous Chrome versions. <int value="-215580565" label="OmniboxEnableClipboardProviderImageSuggestions:disabled"/> <int value="-215534141" label="NativeWindowNavButtons:enabled"/> + <int value="-215103767" label="ShoppingList:disabled"/> <int value="-214618160" label="ESimPolicy:enabled"/> <int value="-213518852" label="protect-sync-credential:enabled"/> <int value="-213214894" label="enable-chromevox-arc-support"/> @@ -49185,8 +50337,10 @@ from previous Chrome versions. <int value="-208435024" label="EnableUsernameCorrection:enabled"/> <int value="-206393363" label="enable-scroll-prediction"/> <int value="-205975637" label="WebUIDarkMode:enabled"/> + <int value="-204978485" label="WallpaperFullScreenPreview:enabled"/> <int value="-204355195" label="secondary-ui-md"/> <int value="-203968600" label="SyncSupportSecondaryAccount:disabled"/> + <int value="-203058505" label="QueryTilesSegmentation:disabled"/> <int value="-202007318" label="AndroidAIAFetching:enabled"/> <int value="-201633741" label="DisplayAlignAssist:enabled"/> <int value="-200805659" label="ContextualSuggestionsButton:enabled"/> @@ -49237,12 +50391,14 @@ from previous Chrome versions. <int value="-167420098" label="WebBluetoothNewPermissionsBackend:enabled"/> <int value="-165756594" label="enable-touch-feedback"/> <int value="-165006916" label="EnableNeuralPalmDetectionFilter:enabled"/> + <int value="-164673139" label="ForceShowContinueSection:disabled"/> <int value="-164539906" label="OmniboxPreserveDefaultMatchAgainstAsyncUpdate:disabled"/> <int value="-162928621" label="ForceStartupSigninPromo:disabled"/> <int value="-161782023" label="AndroidMessagesProdEndpoint:enabled"/> <int value="-160571071" label="InterestFeedV2:enabled"/> <int value="-159877930" label="MaterialDesignUserManager:disabled"/> + <int value="-158938746" label="NtpRealboxPedals:enabled"/> <int value="-158549277" label="enable-embeddedsearch-api"/> <int value="-153299083" label="NewProfilePicker:disabled"/> <int value="-152677714" label="AsmJsToWebAssembly:enabled"/> @@ -49250,11 +50406,11 @@ from previous Chrome versions. <int value="-152439608" label="download-later-debug-on-wifi"/> <int value="-150077791" label="FontAccessChooser:disabled"/> <int value="-148356419" label="PdfViewerPresentationMode:disabled"/> + <int value="-147560822" label="ArcInputOverlay:enabled"/> <int value="-147283486" label="enable-network-portal-notification"/> <int value="-146552997" label="enable-affiliation-based-matching"/> <int value="-146315671" label="PrivacyAdvisor:enabled"/> <int value="-144134779" label="AndroidPayIntegrationV2:disabled"/> - <int value="-143394485" label="SplitSettingsSync:enabled"/> <int value="-143382681" label="InstantTethering:enabled"/> <int value="-143121333" label="WebXRIncubations:enabled"/> <int value="-141516902" label="UseModernMediaControls:enabled"/> @@ -49269,6 +50425,7 @@ from previous Chrome versions. <int value="-135584175" label="EnableAggregatedMlAppRanking:enabled"/> <int value="-135223364" label="AutofillShowTypePredictions:disabled"/> <int value="-133098377" label="SyncPseudoUSSSearchEngines:disabled"/> + <int value="-132786900" label="CommerceDeveloper:disabled"/> <int value="-132082004" label="CacheOneGoogleBar:enabled"/> <int value="-131886819" label="AutofillEnableMerchantBoundVirtualCards:enabled"/> @@ -49280,6 +50437,7 @@ from previous Chrome versions. <int value="-127666141" label="TabGroups:disabled"/> <int value="-127231994" label="VrBrowsingNativeAndroidUi:disabled"/> <int value="-122492389" label="enable-browser-task-scheduler"/> + <int value="-121563330" label="SecurePaymentConfirmationBrowser:disabled"/> <int value="-120521482" label="DirectManipulationStylus:enabled"/> <int value="-120091289" label="CrostiniAppSearch:enabled"/> <int value="-119055644" label="GenericSensor:enabled"/> @@ -49307,6 +50465,7 @@ from previous Chrome versions. <int value="-102537270" label="extension-content-verification"/> <int value="-102387656" label="FillingAcrossAffiliatedWebsites:disabled"/> <int value="-102227288" label="PasswordExport:disabled"/> + <int value="-100702864" label="PageInfoAboutThisSite:disabled"/> <int value="-100148609" label="EvDetailsInPageInfo:disabled"/> <int value="-99781021" label="disable-roboto-font-ui"/> <int value="-97145978" label="DesktopPWAsStayInWindow:enabled"/> @@ -49320,7 +50479,9 @@ from previous Chrome versions. <int value="-89690053" label="MaterialDesignUserManager:enabled"/> <int value="-89567017" label="ChromeColorsCustomColorPicker:enabled"/> <int value="-89434839" label="SystemTrayMicGainSetting:enabled"/> + <int value="-89286848" label="EnableWireGuard:enabled"/> <int value="-88822940" label="ssl-version-min"/> + <int value="-88638121" label="AutofillFixFillableFieldTypes:enabled"/> <int value="-88273414" label="ContentSuggestionsShowSummary:enabled"/> <int value="-87405369" label="PageInfoDiscoverability:enabled"/> <int value="-86788587" label="allow-autofill-sync-credential"/> @@ -49359,6 +50520,7 @@ from previous Chrome versions. <int value="-66535194" label="DesktopMinimalUI:enabled"/> <int value="-64839201" label="SyncUSSAutofillWalletData:disabled"/> <int value="-64824628" label="VizHitTestSurfaceLayer:disabled"/> + <int value="-64747770" label="IncognitoDownloadsWarning:disabled"/> <int value="-59530055" label="ChromeVoxArcSupport:enabled"/> <int value="-59401847" label="ContentSuggestionsLargeThumbnail:disabled"/> <int value="-58338160" label="ChromeShareLongScreenshot:enabled"/> @@ -49370,6 +50532,7 @@ from previous Chrome versions. <int value="-55890693" label="MessagesForAndroidSaveCard:disabled"/> <int value="-55592344" label="SyncPseudoUSSDictionary:disabled"/> <int value="-54796636" label="kids-management-url-classification:disabled"/> + <int value="-52737423" label="EnableMixedContentDownloadDialog:disabled"/> <int value="-52483823" label="disable-new-video-renderer"/> <int value="-52241456" label="enable-single-click-autofill"/> <int value="-51567065" label="EnableFeedbackPanel:disabled"/> @@ -49430,6 +50593,7 @@ from previous Chrome versions. <int value="-15879016" label="OmniboxUIExperimentUnboldSuggestionText:disabled"/> <int value="-13918890" label="disable-download-notification"/> + <int value="-13180015" label="WebUsbDeviceDetection:disabled"/> <int value="-12225998" label="ShareButtonInTopToolbar:disabled"/> <int value="-11983392" label="MagnifierContinuousMouseFollowingModeSetting:enabled"/> @@ -49451,14 +50615,18 @@ from previous Chrome versions. </int> <int value="1343197" label="UseSearchClickForRightClick:enabled"/> <int value="1558582" label="ResamplingInputEvents:enabled"/> + <int value="1618593" label="AutofillUseConsistentPopupSettingsIcons:enabled"/> <int value="2070488" label="EnablePasswordsAccountStorageSavingUi:disabled"/> <int value="3826348" label="DarkenWebsitesCheckboxInThemesSetting:disabled"/> + <int value="4277967" label="SideSearchStatePerTab:disabled"/> <int value="4588113" label="CacheOneGoogleBar:disabled"/> <int value="5654819" label="CrostiniGpuSupport:disabled"/> <int value="6041813" label="PermissionChipGestureSensitive:disabled"/> <int value="6523501" label="lacros-availability-ignore"/> + <int value="7310536" label="WebFeedSort:enabled"/> <int value="7444737" label="NTPSuggestionsStandaloneUI:disabled"/> <int value="7533886" label="disable-offer-store-unmasked-wallet-cards"/> + <int value="7642326" label="hdrnet-override"/> <int value="8891567" label="CaptionSettings:enabled"/> <int value="9609535" label="BrowsingDataLifetimeManager:disabled"/> <int value="10405060" label="BluetoothSessionizedMetrics:disabled"/> @@ -49468,6 +50636,7 @@ from previous Chrome versions. <int value="15614295" label="Portals:enabled"/> <int value="19629326" label="OmniboxExperimentalKeywordMode:enabled"/> <int value="19815558" label="EnableSettingsShortcutSearch:disabled"/> + <int value="20946908" label="CanvasOopRasterization:disabled"/> <int value="21055794" label="OpenXR:enabled"/> <int value="22142588" label="OptimizationGuidePushNotifications:disabled"/> <int value="23121136" label="MobileIdentityConsistencyVar:enabled"/> @@ -49498,6 +50667,7 @@ from previous Chrome versions. <int value="42098736" label="TranslateAndroidManualTrigger:disabled"/> <int value="42844603" label="AndroidSurfaceControl:disabled"/> <int value="42881842" label="EnablePenetratingImageSelection:disabled"/> + <int value="43949416" label="Journeys:enabled"/> <int value="43951968" label="DesktopPWAsCustomTabUI:enabled"/> <int value="44088203" label="ExpensiveBackgroundTimerThrottling:enabled"/> <int value="44240181" label="SharingQRCodeGenerator:disabled"/> @@ -49511,6 +50681,7 @@ from previous Chrome versions. <int value="54258707" label="NewTabstripAnimation:enabled"/> <int value="54571864" label="EnableDisplayZoomSetting:enabled"/> <int value="56072855" label="VaapiWebPImageDecodeAcceleration:disabled"/> + <int value="56605515" label="BookmarksImprovedSaveFlow:enabled"/> <int value="56723110" label="enable-webfonts-intervention"/> <int value="56900498" label="OmniboxOneClickUnelide:enabled"/> <int value="57255632" label="site-isolation-for-password-sites:disabled"/> @@ -49535,6 +50706,8 @@ from previous Chrome versions. <int value="65245449" label="FilesBannerFramework:enabled"/> <int value="66897259" label="ModalPermissionDialogView:enabled"/> <int value="67639499" label="stop-loading-in-background:disabled"/> + <int value="71290103" label="ArcNearbySharing:enabled"/> + <int value="72558615" label="TrafficCountersSettingsUi:enabled"/> <int value="73929836" label="VrBrowsingInCustomTab:enabled"/> <int value="75207621" label="enable-stylus-virtual-keyboard:enabled"/> <int value="75237697" label="ash-enable-new-overview-ui"/> @@ -49547,7 +50720,6 @@ from previous Chrome versions. <int value="79595680" label="OmniboxTabSwitchSuggestions:enabled"/> <int value="79729295" label="WebBundles:enabled"/> <int value="82303171" label="AccountIdMigration:disabled"/> - <int value="82816692" label="IntentHandlingSharing:disabled"/> <int value="83422372" label="ChromeHomePersonalizedOmniboxSuggestions:enabled"/> <int value="84911198" label="ScanCardsInWebPayments:disabled"/> @@ -49602,6 +50774,7 @@ from previous Chrome versions. <int value="123097915" label="FaviconsFromWebManifest:enabled"/> <int value="125581289" label="WebRtcHWVP8Encoding:disabled"/> <int value="125934378" label="enable-password-link"/> + <int value="127338155" label="NtpSafeBrowsingModule:disabled"/> <int value="127789400" label="PrivacyElevatedAndroid:enabled"/> <int value="128086566" label="D3D11VideoDecoder:enabled"/> <int value="128323385" label="WebUIOmniboxPopup:enabled"/> @@ -49617,6 +50790,7 @@ from previous Chrome versions. <int value="138598687" label="HappinessTrackingSurveysForDesktopDevToolsIssuesCookiesSameSite:enabled"/> <int value="139569991" label="SharingDeviceExpiration:disabled"/> + <int value="140257184" label="ChromeOSAmbientModeNewUrl:enabled"/> <int value="143725809" label="DownloadProgressInfoBar:enabled"/> <int value="144868136" label="DesktopPWAsNotificationIconAndTitle:enabled"/> <int value="146229312" label="WebPaymentsExperimentalFeatures:enabled"/> @@ -49653,6 +50827,7 @@ from previous Chrome versions. <int value="174759256" label="LockScreenMediaControls:enabled"/> <int value="174917935" label="ReengagementNotification:disabled"/> <int value="175254474" label="SpectreVariant2Mitigation:enabled"/> + <int value="176526479" label="AccessibilityPageZoom:enabled"/> <int value="176773784" label="EnableHardwareMirrorMode:disabled"/> <int value="178337215" label="enable-md-history"/> <int value="178693406" label="LockScreenMediaControls:disabled"/> @@ -49663,6 +50838,7 @@ from previous Chrome versions. <int value="181150000" label="CrosVmCupsProxy:enabled"/> <int value="182358203" label="AddToHomescreenIPH:enabled"/> <int value="182788555" label="DecoupleSyncFromAndroidMasterSync:disabled"/> + <int value="182986882" label="TerminalSSH:disabled"/> <int value="183208826" label="TabGroups:enabled"/> <int value="185991204" label="enable-webrtc-srtp-encrypted-headers"/> <int value="186463628" label="DnsOverHttps:disabled"/> @@ -49676,11 +50852,15 @@ from previous Chrome versions. <int value="192320180" label="ignore-gpu-blocklist"/> <int value="192693676" label="QueryTilesRemoveTrendingAfterInactivity:disabled"/> + <int value="193865288" label="EnableSuggestedLocalFiles:enabled"/> <int value="194573877" label="MacViewsNativeDialogs:disabled"/> <int value="194895489" label="passive-listeners-default"/> + <int value="195112080" label="DeskTemplateSync:enabled"/> <int value="195335115" label="AudioWorkletRealtimeThread:disabled"/> <int value="195570937" label="EnableHomeLauncher:disabled"/> <int value="196103097" label="PaintPreviewShowOnStartup:disabled"/> + <int value="196578182" + label="AutofillEnableAugmentedPhoneCountryCode:disabled"/> <int value="198719062" label="WebAssemblyLazyCompilation:disabled"/> <int value="198762155" label="SharingPeerConnectionSender:enabled"/> <int value="200347243" label="WebVRExperimentalRendering:disabled"/> @@ -49690,7 +50870,10 @@ from previous Chrome versions. <int value="203776499" label="enable-virtual-keyboard-overscroll"/> <int value="207907053" label="OmniboxUIExperimentBlueSearchLoopAndSearchQuery:enabled"/> + <int value="209341217" + label="WebAuthenticationAuthenticatorAttachment:disabled"/> <int value="209792775" label="TabGroupsAndroid:enabled"/> + <int value="209805234" label="MessagesForAndroidAutoDarkWebContents:enabled"/> <int value="211313007" label="CrOSEnforceSystemAecNs:disabled"/> <int value="212489101" label="AutofillAssistantChromeEntry:enabled"/> <int value="212977039" label="MediaFoundationD3D11VideoCapture:disabled"/> @@ -49698,6 +50881,8 @@ from previous Chrome versions. <int value="215328738" label="ImprovedGeoLanguageData:disabled"/> <int value="215528151" label="NearbySharingWebRtc:enabled"/> <int value="217455219" label="SyncStandaloneTransport:enabled"/> + <int value="217833978" label="GMSCoreEmoji:enabled"/> + <int value="218317796" label="CastStreamingVp9:enabled"/> <int value="218890378" label="ManualSaving:disabled"/> <int value="219117936" label="AllowReaderForAccessibility:enabled"/> <int value="219384037" label="ESimPolicy:disabled"/> @@ -49731,6 +50916,7 @@ from previous Chrome versions. <int value="246106068" label="HandwritingLegacyRecognition:disabled"/> <int value="247200195" label="EnhancedProtectionPromoCard:enabled"/> <int value="250855010" label="WebAssemblyBaseline:disabled"/> + <int value="251367892" label="PersistentQuotaIsTemporaryQuota:disabled"/> <int value="254497185" label="VideoPlayerJsModules:enabled"/> <int value="255375615" label="stop-non-timers-in-background:enabled"/> <int value="258621334" @@ -49757,6 +50943,7 @@ from previous Chrome versions. <int value="277483398" label="ClipboardHistory:disabled"/> <int value="277565405" label="ContextualSearchDefinitions:disabled"/> <int value="278756320" label="disable-app-list-app-info"/> + <int value="280459238" label="ChromeSharingHubLaunchAdjacent:disabled"/> <int value="280644887" label="mash"/> <int value="280925459" label="LiveCaption:disabled"/> <int value="281024089" label="AppServiceExternalProtocol:disabled"/> @@ -49785,6 +50972,7 @@ from previous Chrome versions. <int value="293996306" label="ArrayPrototypeValues:disabled"/> <int value="294150128" label="RelatedSearchesSimplifiedUx:enabled"/> <int value="295661985" label="video-capture-use-gpu-memory-buffer"/> + <int value="296066418" label="CCTResizableForThirdParties:disabled"/> <int value="296215399" label="WindowsMixedReality:disabled"/> <int value="296296761" label="MediaFoundationVideoCapture:disabled"/> <int value="297095559" label="ShowBluetoothDebugLogToggle:disabled"/> @@ -49834,6 +51022,7 @@ from previous Chrome versions. <int value="330138076" label="enable-clear-browsing-data-counters"/> <int value="330439654" label="SyncPseudoUSSExtensions:enabled"/> <int value="330653520" label="ChromeShareHighlightsAndroid:enabled"/> + <int value="331094131" label="WindowControlMenu:disabled"/> <int value="331770879" label="CrostiniAppSearch:disabled"/> <int value="331845034" label="enable-webgl-developer-extensions"/> <int value="332391072" label="cs-contextual-cards-bar-integration"/> @@ -49842,7 +51031,6 @@ from previous Chrome versions. <int value="334802038" label="OfflinePreviews:disabled"/> <int value="335976733" label="NotificationStackingBarRedesign:enabled"/> <int value="336429189" label="DisallowUnsafeHttpDownloads:disabled"/> - <int value="337978465" label="OmniboxPedalsDefaultIconColored:enabled"/> <int value="338662897" label="AndroidNightModeTabReparenting:disabled"/> <int value="339419844" label="EmojiSuggestAddition:enabled"/> <int value="339671131" label="disable-per-user-timezone"/> @@ -49854,13 +51042,17 @@ from previous Chrome versions. <int value="345611669" label="OmniboxLocalZeroSuggestFrecencyRanking:enabled"/> <int value="345664265" label="BlinkHeapIncrementalMarking:disabled"/> + <int value="346406287" label="EnableWebAppUninstallFromOsSettings:disabled"/> <int value="346430505" label="SidePanel:enabled"/> <int value="346711293" label="enable-save-password-bubble"/> + <int value="347948074" label="WebFeedSort:disabled"/> <int value="347981012" label="TabToGTSAnimation:disabled"/> <int value="348449023" label="DesktopPWAsLocalUpdatingThrottlePersistence:enabled"/> <int value="348854923" label="v8-cache-strategies-for-cache-storage"/> <int value="349469694" label="WebGPUService:disabled"/> + <int value="350362421" + label="AutofillEnableAugmentedPhoneCountryCode:enabled"/> <int value="350399958" label="ModuleScriptsImportMetaUrl:disabled"/> <int value="350635266" label="TabGroupsContinuationAndroid:enabled"/> <int value="351005753" label="enable-experimental-accessibility-autoclick"/> @@ -49871,8 +51063,11 @@ from previous Chrome versions. <int value="357138275" label="enable-floating-virtual-keyboard:disabled"/> <int value="358399482" label="enable-high-dpi-fixed-position-compositing"/> <int value="358493847" label="BackgroundLoader:disabled"/> + <int value="358906344" label="NotificationsRefresh:disabled"/> <int value="359601954" label="CrostiniUsbSupport:enabled"/> <int value="359896413" label="SplitPartiallyOccludedQuads:disabled"/> + <int value="359918746" + label="AutofillEnableVirtualCardsRiskBasedAuthentication:disabled"/> <int value="360391863" label="NTPOfflineBadge:enabled"/> <int value="360599302" label="enable-gpu-rasterization"/> <int value="361984896" @@ -49934,19 +51129,24 @@ from previous Chrome versions. <int value="401606992" label="AnimatedImageResume:enabled"/> <int value="401983950" label="enable-spdy4"/> <int value="402143634" label="enable-search-button-in-omnibox-always"/> + <int value="402630521" + label="IPH_KeyboardAccessoryPaymentVirtualCard:enabled"/> <int value="403288255" label="enable-wheel-scroll-latching"/> <int value="403554154" label="SafetyCheckWeakPasswords:enabled"/> <int value="405329388" label="FramebustingNeedsSameOriginOrUserGesture:enabled"/> + <int value="406549604" label="NtpSafeBrowsingModule:enabled"/> <int value="407491045" label="ShowDateInTrayButton:enabled"/> <int value="408190863" label="OmniboxDisableInstantExtendedLimit:disabled"/> <int value="409566604" label="IntentPickerPWAPersistence:enabled"/> <int value="409622437" label="disable-buffer-bw-compression"/> <int value="410400234" label="WebAppEnableProtocolHandlers:disabled"/> <int value="411250226" label="AutoplayMutedVideos:disabled"/> + <int value="411536809" label="AutofillAcrossIframes:enabled"/> <int value="412957264" label="tab-close-buttons-hidden-with-touch"/> <int value="413062443" label="MessagesForAndroidInfrastructure:disabled"/> <int value="413081240" label="enable-new-md-input-view"/> + <int value="413528228" label="AutofillFixFillableFieldTypes:disabled"/> <int value="413695227" label="NTPSuggestionsStandaloneUI:enabled"/> <int value="414114078" label="LitePageServerPreviews:disabled"/> <int value="414342153" label="AssistantIntentPageUrl:disabled"/> @@ -50054,6 +51254,7 @@ from previous Chrome versions. <int value="493903641" label="disable-appcontainer"/> <int value="494733611" label="disable-drop-sync-credential"/> <int value="494939785" label="InsecureFormSubmissionInterstitial:disabled"/> + <int value="496667708" label="ArcInputOverlay:disabled"/> <int value="497137719" label="OmniboxVoiceSearchAlwaysVisible:disabled"/> <int value="497150691" label="AssistEmojiEnhanced:disabled"/> <int value="500177932" label="ArcSmartTextSelection:disabled"/> @@ -50071,6 +51272,7 @@ from previous Chrome versions. <int value="505561325" label="OpenXR:disabled"/> <int value="506680761" label="WebNFC:disabled"/> <int value="508272289" label="SharedHighlightingAmp:disabled"/> + <int value="509602783" label="TrafficCountersSettingsUi:disabled"/> <int value="510066229" label="AutofillEnforceMinRequiredFieldsForQuery:enabled"/> <int value="510814146" label="OfflineBookmarks:enabled"/> @@ -50092,13 +51294,12 @@ from previous Chrome versions. <int value="519140642" label="SendWebUIJavaScriptErrorReports:enabled"/> <int value="520738365" label="OmniboxPedalsBatch2NonEnglish:enabled"/> <int value="520982116" label="BuiltInModuleAll:enabled"/> - <int value="523885852" - label="MagnifierCaretFollowingFromJavascript:disabled"/> <int value="529235584" label="PhoneHub:enabled"/> <int value="530828403" label="AllowStartingServiceManagerOnly:disabled"/> <int value="533064367" label="WebRtcHideLocalIpsWithMdns:disabled"/> <int value="533115840" label="HoldingSpaceInProgressDownloadsIntegration:enabled"/> + <int value="533814676" label="CCTResizableForFirstParties:enabled"/> <int value="535131384" label="OmniboxTailSuggestions:enabled"/> <int value="535194142" label="TemporaryHoldingSpacePreviews:enabled"/> <int value="535976218" label="enable-plugin-power-saver"/> @@ -50107,6 +51308,7 @@ from previous Chrome versions. <int value="538468149" label="OfflinePagesCT:enabled"/> <int value="538600423" label="OmniboxDocumentProvider:enabled"/> <int value="538685995" label="InstallableInkDrop:enabled"/> + <int value="540128020" label="WebMidi:disabled"/> <int value="541667888" label="ContentLanguagesInLanguagePicker:disabled"/> <int value="542930298" label="WebAppEnableLinkCapturing:disabled"/> <int value="542960889" label="HeavyAdIntervention:enabled"/> @@ -50145,6 +51347,7 @@ from previous Chrome versions. <int value="567368307" label="enable-experimental-canvas-features"/> <int value="570469494" label="LoginDetection:disabled"/> <int value="571349694" label="AllowAllSitesToInitiateMirroring:enabled"/> + <int value="571562912" label="InstallableAmbientBadgeMessage:disabled"/> <int value="572915501" label="FilesZipUnpack:disabled"/> <int value="573385109" label="SharedClipboardUI:enabled"/> <int value="575380532" label="ExperimentalAccessibilityLabels:disabled"/> @@ -50162,7 +51365,6 @@ from previous Chrome versions. <int value="584661108" label="OmniboxHistoryQuickProviderAllowButDoNotScoreMidwordTerms:disabled"/> <int value="586021329" label="VibrateRequiresUserGesture:enabled"/> - <int value="587020527" label="UseSodaForLiveCaption:enabled"/> <int value="588333474" label="OfflineIndicator:disabled"/> <int value="589394614" label="OmniboxSuggestionButtonRow:enabled"/> <int value="589924262" label="CryptAuthV2DeviceActivityStatus:enabled"/> @@ -50174,13 +51376,13 @@ from previous Chrome versions. <int value="595168244" label="NotificationExpansionAnimation:enabled"/> <int value="595371145" label="OmniboxRichEntitySuggestions:disabled"/> <int value="596106994" label="CustomFeedbackUi:enabled"/> - <int value="597360137" label="IncognitoNtpRealBox:disabled"/> <int value="597542937" label="TabbedAppOverflowMenuRegroup:enabled"/> <int value="598827460" label="enable-roboto-font-ui"/> <int value="598926697" label="VrLaunchIntent:disabled"/> <int value="600037637" label="AndroidSigninPromos:enabled"/> <int value="600643275" label="OobeRecommendAppsScreen:enabled"/> <int value="602117675" label="NTPBookmarkSuggestions:enabled"/> + <int value="602452004" label="WebBluetoothBondOnDemand:disabled"/> <int value="603326800" label="UsePasswordSeparatedSigninFlow:enabled"/> <int value="603988014" label="NetworkService:enabled"/> <int value="604334859" label="Prerender2:enabled"/> @@ -50205,6 +51407,8 @@ from previous Chrome versions. <int value="620189062" label="TabFreeze:enabled"/> <int value="620989380" label="ImeInputLogicFst:enabled"/> <int value="621484660" label="ReorderBookmarks:disabled"/> + <int value="623112705" + label="IPH_KeyboardAccessoryPaymentVirtualCard:disabled"/> <int value="623772100" label="EnableIncognitoWindowCounter:disabled"/> <int value="623796513" label="AndroidLayoutChangeTabReparenting:disabled"/> <int value="624317932" label="print-pdf-as-image"/> @@ -50285,6 +51489,8 @@ from previous Chrome versions. <int value="666871156" label="KaleidoscopeModule:enabled"/> <int value="667643314" label="LitePageServerPreviews:enabled"/> <int value="669097106" label="NtpRealboxMatchOmniboxTheme:disabled"/> + <int value="669958310" label="EnableSuggestedLocalFiles:disabled"/> + <int value="672067370" label="InstallableAmbientBadgeMessage:enabled"/> <int value="673588373" label="OmniboxPedalSuggestions:disabled"/> <int value="674627327" label="MagnifierNewFocusFollowing:enabled"/> <int value="674788251" label="EnableNewBadgeOnMenuItems:enabled"/> @@ -50321,11 +51527,12 @@ from previous Chrome versions. <int value="698809951" label="WebRtcHWVP8Encoding:enabled"/> <int value="699149897" label="ContentSuggestionsDebugLog:disabled"/> <int value="700346797" label="WheelEventRegions:enabled"/> + <int value="700926106" label="OmniboxPedalsBatch3NonEnglish:enabled"/> <int value="701766325" label="PerNavigationMojoInterface:enabled"/> <int value="701795774" label="WebAppEnableUrlHandlers:enabled"/> <int value="702060507" label="SafetyCheckWeakPasswords:disabled"/> + <int value="703122112" label="ShoppingList:enabled"/> <int value="703469777" label="AndroidNightModeTabReparenting:enabled"/> - <int value="703621694" label="UseSodaForLiveCaption:disabled"/> <int value="705407202" label="AutofillSaveCardImprovedUserConsent:disabled"/> <int value="705411729" label="AccessiblePDFForm:disabled"/> <int value="705712478" label="EnablePalmOnToolTypePalm:disabled"/> @@ -50383,6 +51590,7 @@ from previous Chrome versions. <int value="741219332" label="ShareByDefaultInCCT:enabled"/> <int value="741760108" label="SidePanelPrototype:enabled"/> <int value="742083923" label="MimeHandlerViewInCrossProcessFrame:disabled"/> + <int value="742354263" label="RevenLogSource:disabled"/> <int value="743714331" label="HelpAppLauncherSearch:enabled"/> <int value="744342941" label="SafetyCheckChromeCleanerChild:enabled"/> <int value="745541471" label="PaintHolding:disabled"/> @@ -50396,6 +51604,7 @@ from previous Chrome versions. <int value="747847237" label="PhysicalWeb:enabled"/> <int value="749312701" label="ChromeOSAccountManager:disabled"/> <int value="749516419" label="DragToSnapInClamshellMode:disabled"/> + <int value="749994865" label="MessagesForAndroidSyncError:enabled"/> <int value="752194066" label="enable-app-window-cycling"/> <int value="752416911" label="FastPair:disabled"/> <int value="752939691" label="disable-tab-for-desktop-share"/> @@ -50412,6 +51621,7 @@ from previous Chrome versions. <int value="767543730" label="DoubleTapToZoomInTabletMode:enabled"/> <int value="767549069" label="ScreenTime:enabled"/> <int value="767970385" label="ResamplingScrollEvents:enabled"/> + <int value="768855962" label="PaymentRequestBasicCard:enabled"/> <int value="770680432" label="DecodeLossyWebPImagesToYUV:enabled"/> <int value="772272625" label="simplify-https-indicator"/> <int value="772348426" label="AffiliationBasedMatching:enabled"/> @@ -50428,6 +51638,8 @@ from previous Chrome versions. <int value="779086132" label="enable-data-reduction-proxy-alt"/> <int value="779703052" label="ChromeOSAmbientMode:enabled"/> <int value="779849093" label="OfflinePagesCTSuppressNotifications:disabled"/> + <int value="780177218" + label="AutofillEnableOfferNotificationForPromoCodes:disabled"/> <int value="780743733" label="QueryTilesLocalOrdering:disabled"/> <int value="781085897" label="IncognitoReauthenticationForAndroid:disabled"/> <int value="781573553" label="UnifiedPasswordManagerAndroid:enabled"/> @@ -50438,15 +51650,18 @@ from previous Chrome versions. <int value="787080596" label="DynamicTcmallocTuning:enabled"/> <int value="787385958" label="RegionalLocalesAsDisplayUI:enabled"/> <int value="788130042" label="PrivacySandboxSettings2:enabled"/> + <int value="790411499" label="PageInfoStoreInfo:disabled"/> <int value="791541863" label="NtpPhotosModule:disabled"/> <int value="792307132" label="KeyboardBasedDisplayArrangementInSettings:enabled"/> <int value="792884862" label="EnableSharedImageForWebview:enabled"/> + <int value="793287900" label="VerifyDidCommitParams:disabled"/> <int value="793816915" label="MessagesForAndroidPopupBlocked:disabled"/> <int value="798696013" label="ImeInputLogicMozc:enabled"/> <int value="799680074" label="ContextualSearchTranslationModel:enabled"/> <int value="802463708" label="WebViewSurfaceControl:enabled"/> <int value="803282885" label="PreferHtmlOverPlugins:disabled"/> + <int value="803877391" label="NotificationsRefresh:enabled"/> <int value="803982925" label="CellularForbidAttachApn:disabled"/> <int value="804551127" label="ArcKeyboardShortcutHelperIntegration:disabled"/> <int value="804958673" label="LensCameraAssistedSearch:enabled"/> @@ -50456,6 +51671,7 @@ from previous Chrome versions. <int value="806783713" label="DesktopPWAsTabStripLinkCapturing:enabled"/> <int value="807447752" label="ChromeMemex:disabled"/> <int value="807734471" label="tab-management-experiment-type-disabled"/> + <int value="808855873" label="RequestDesktopSiteGlobal:disabled"/> <int value="809698565" label="WebRtcHybridAgc:enabled"/> <int value="811057677" label="ConfirmNtpSuggestionRemovals:disabled"/> <int value="811374216" label="disable-new-bookmark-apps"/> @@ -50485,6 +51701,8 @@ from previous Chrome versions. <int value="839230937" label="AutofillEnableCardNicknameUpstream:disabled"/> <int value="839798268" label="SafeBrowsingTelemetryForApkDownloads:disabled"/> <int value="840057845" label="HardwareMediaKeyHandling:enabled"/> + <int value="840222947" + label="AutofillEnableOfferNotificationForPromoCodes:enabled"/> <int value="841276069" label="ChromeHomeDoodle:disabled"/> <int value="841343322" label="disable-new-korean-ime"/> <int value="841779535" label="password-export:enabled"/> @@ -50504,6 +51722,8 @@ from previous Chrome versions. <int value="851238417" label="VirtualKeyboardFloatingResizable:enabled"/> <int value="851616920" label="EnableTLS13EarlyData:disabled"/> <int value="852313529" label="RTCUnifiedPlanByDefault:disabled"/> + <int value="853279705" + label="DesktopPWAsAdditionalWindowingControls:disabled"/> <int value="854294457" label="EnableOmniboxRichEntities:disabled"/> <int value="854391022" label="SmartLockUIRevamp:enabled"/> <int value="854730848" label="disable-app-info-dialog-mac"/> @@ -50515,6 +51735,7 @@ from previous Chrome versions. <int value="859449217" label="MagnifierPanningImprovements:enabled"/> <int value="859495772" label="UsernameFirstFlowFallbackCrowdsourcing:disabled"/> + <int value="859913799" label="EnableDesksTrackpadSwipeImprovements:disabled"/> <int value="860336036" label="ChromeModernDesign:enabled"/> <int value="862453793" label="TranslateUI2016Q2:enabled"/> <int value="864024033" label="IsolatePrerendersMustProbeOrigin:enabled"/> @@ -50543,6 +51764,7 @@ from previous Chrome versions. <int value="882893584" label="UseOfHashAffiliationFetcher:disabled"/> <int value="883190338" label="PrintWithReducedRasterization:disabled"/> <int value="884106779" label="supervised-user-safesites"/> + <int value="884892326" label="CSSCascadeLayers:enabled"/> <int value="885186849" label="finch-seed-expiration-age"/> <int value="885971656" label="EnablePlayStoreAppSearch:enabled"/> <int value="886907524" label="autoplay-policy"/> @@ -50570,6 +51792,7 @@ from previous Chrome versions. <int value="912119426" label="InfiniteSessionRestore:disabled"/> <int value="913138924" label="RecurrentInterstitialFeature:disabled"/> <int value="913855453" label="VirtualKeyboardFloatingResizable:disabled"/> + <int value="914708297" label="CCTResizableAllowResizeByUserGesture:enabled"/> <int value="916316159" label="disable-new-app-list-mixer"/> <int value="917285134" label="AutofillAddressProfileSavePrompt:enabled"/> <int value="917561046" label="ConversionMeasurement:disabled"/> @@ -50598,12 +51821,14 @@ from previous Chrome versions. <int value="941036016" label="ContentSuggestionsSettings:disabled"/> <int value="941883332" label="ProactiveTabFreezeAndDiscard:disabled"/> <int value="941948340" label="PlaybackSpeedButton:enabled"/> + <int value="942357311" label="UpcomingSharingFeatures:disabled"/> <int value="942807728" label="NewTabstripAnimation:disabled"/> <int value="943319566" label="enable-intent-picker"/> <int value="943447234" label="NtpDriveModule:disabled"/> <int value="944484780" label="EnableEmbeddedAssistantUI:enabled"/> <int value="946185008" label="EnableAppDataSearch:disabled"/> <int value="946688335" label="OmniboxSpareRenderer:disabled"/> + <int value="948085015" label="WebFilterInterstitialRefresh:disabled"/> <int value="948351976" label="WallpaperWebUI:disabled"/> <int value="948521531" label="StylusHandwriting:disabled"/> <int value="952558794" label="enable-remote-assistance"/> @@ -50681,15 +51906,18 @@ from previous Chrome versions. <int value="1009437086" label="AutofillEnableOfferNotification:disabled"/> <int value="1009976778" label="SidePanel:disabled"/> <int value="1011550878" label="MessagesForAndroidPermissionUpdate:disabled"/> + <int value="1012643576" label="CommerceDeveloper:enabled"/> <int value="1012942422" label="HorizontalTabSwitcherAndroid:disabled"/> <int value="1015012662" label="ChromeOSDirectVideoDecoder:enabled"/> <int value="1015895665" label="drop-sync-credential:enabled"/> <int value="1017364362" label="VrIconInDaydreamHome:enabled"/> + <int value="1017523412" label="ExtensionsMenuAccessControl:disabled"/> <int value="1018797564" label="EnableAppListSearchAutocomplete:disabled"/> <int value="1018998019" label="memlog"/> <int value="1019623058" label="ash-enable-shelf-model-synchronization"/> <int value="1019857902" label="disable-hide-inactive-stacked-tab-close-buttons"/> + <int value="1020127284" label="HardwareSecureDecryption:enabled"/> <int value="1021573543" label="QuickSettingsPWA:disabled"/> <int value="1021848000" label="SharedHighlightingUseBlocklist:disabled"/> <int value="1022424308" label="SignedExchangeSubresourcePrefetch:enabled"/> @@ -50703,6 +51931,7 @@ from previous Chrome versions. <int value="1028817487" label="OmniboxOnFocusSuggestionsContextualWeb:disabled"/> <int value="1030608602" label="AutofillAssistantProactiveHelp:enabled"/> + <int value="1031239808" label="ForceMajorVersion100InUserAgent:disabled"/> <int value="1031281564" label="DisablePeripheralDataAccessProtection:disabled"/> <int value="1033148287" label="NTPShortcuts:disabled"/> @@ -50721,6 +51950,7 @@ from previous Chrome versions. <int value="1044210009" label="SharingPeerConnectionReceiver:disabled"/> <int value="1044928476" label="AllowDownloadResumptionWithoutStrongValidators:enabled"/> + <int value="1045152062" label="SecurePaymentConfirmationBrowser:enabled"/> <int value="1046878091" label="PasswordForceSaving:enabled"/> <int value="1046981538" label="OfflinePagesShowAlternateDinoPage:disabled"/> <int value="1047110483" label="ShelfHotseat:disabled"/> @@ -50748,6 +51978,7 @@ from previous Chrome versions. <int value="1061947013" label="OmniboxDeferredKeyboardPopup:disabled"/> <int value="1062357243" label="remember-cert-error-decisions"/> <int value="1064288458" label="OfflineRecentPages:enabled"/> + <int value="1065451331" label="NtpRealboxPedals:disabled"/> <int value="1065547630" label="EnableInputNoiseCancellationUi:disabled"/> <int value="1065553214" label="ClosedTabCache:enabled"/> <int value="1067618884" label="enable-experimental-input-view-features"/> @@ -50758,6 +51989,8 @@ from previous Chrome versions. <int value="1070449228" label="ContextualSuggestionsCarousel:enabled"/> <int value="1070840417" label="ChromeColors:enabled"/> <int value="1071520357" label="WebAuthenticationTouchId:enabled"/> + <int value="1071962531" + label="AutofillEnableSupportForMoreStructureInAddresses:disabled"/> <int value="1072010558" label="NTPModernLayout:disabled"/> <int value="1072517479" label="ImprovedCookieControls:enabled"/> <int value="1074359194" label="UseSuggestionsEvenIfFew:enabled"/> @@ -50815,11 +52048,13 @@ from previous Chrome versions. <int value="1112051724" label="DetectingHeavyPages:enabled"/> <int value="1112817963" label="WebViewConnectionlessSafeBrowsing:enabled"/> <int value="1113196543" label="ShowManagedUi:disabled"/> + <int value="1113281154" label="enable-raw-draw"/> <int value="1113365156" label="tab-management-experiment-type-chive"/> <int value="1113558288" label="AbusiveOriginNotificationPermissionRevocation:disabled"/> <int value="1114270092" label="PortalsCrossOrigin:disabled"/> <int value="1114629582" label="enable-floating-virtual-keyboard"/> + <int value="1114794286" label="AutofillTypeSpecificPopupWidth:disabled"/> <int value="1115635149" label="EnableUnifiedMultiDeviceSetup:enabled"/> <int value="1116593018" label="CaptureThumbnailOnLoadFinished:disabled"/> <int value="1117270978" label="ArcDocumentsProviderUnknownSize:disabled"/> @@ -50897,6 +52132,7 @@ from previous Chrome versions. <int value="1177120582" label="InstallableInkDrop:disabled"/> <int value="1177174300" label="LayoutNGTable:disabled"/> <int value="1177628103" label="GaiaActionButtons:disabled"/> + <int value="1178640449" label="ProductivityLauncher:disabled"/> <int value="1179013979" label="OmniboxUIExperimentMaxAutocompleteMatches:enabled"/> <int value="1179407596" label="PreemptiveLinkToTextGeneration:enabled"/> @@ -50939,6 +52175,7 @@ from previous Chrome versions. <int value="1211756417" label="SessionRestorePrioritizesBackgroundUseCases:disabled"/> <int value="1211803853" label="OmniboxDocumentProviderAso:enabled"/> + <int value="1212186655" label="EnableDuplicateDownloadDialog:enabled"/> <int value="1212526465" label="MediaAppPdfInInk:disabled"/> <int value="1214219155" label="gamepad-polling-interval"/> <int value="1214455758" label="VideoRotateToFullscreen:disabled"/> @@ -50985,10 +52222,13 @@ from previous Chrome versions. <int value="1243180545" label="HarfBuzzPDFSubsetter:enabled"/> <int value="1243890754" label="ForbidSyncXHRInPageDismissal:disabled"/> <int value="1245889469" label="enable-surface-worker"/> + <int value="1246022849" + label="MessagesForAndroidAutoDarkWebContents:disabled"/> <int value="1246486472" label="SafeBrowsingPasswordCheckIntegrationForSavedPasswordsAndroid:disabled"/> <int value="1247293682" label="topchrome-md"/> <int value="1249215617" label="SelectToSpeakNavigationControl:enabled"/> + <int value="1249861983" label="WebViewUseMetricsUploadService:disabled"/> <int value="1250071868" label="disable-timezone-tracking-option"/> <int value="1250776846" label="DnsProxyEnableDOH:enabled"/> <int value="1251663392" label="ArcImageCopyPasteCompat:disabled"/> @@ -51009,6 +52249,7 @@ from previous Chrome versions. <int value="1261620998" label="IntentPickerPWAPersistence:disabled"/> <int value="1261713150" label="ChromeHomeOptOutSnackbar:disabled"/> <int value="1262469513" label="GesturePropertiesDBusService:disabled"/> + <int value="1265587614" label="AppDiscoveryForOobe:disabled"/> <int value="1265666387" label="DesktopPWAsAppIconShortcutsMenu:disabled"/> <int value="1266156008" label="IdentityDisc:disabled"/> <int value="1266525177" @@ -51032,6 +52273,7 @@ from previous Chrome versions. <int value="1279584261" label="enable-carrier-switching"/> <int value="1280614081" label="show-overdraw-feedback"/> <int value="1281471853" label="UseButtonTranslateBubbleUI:disabled"/> + <int value="1283371794" label="AppDiscoveryRemoteUrlSearch:disabled"/> <int value="1283908088" label="ImprovedLanguageSettings:disabled"/> <int value="1283956865" label="force-tablet-mode"/> <int value="1283960113" label="disable-fixed-position-compositing"/> @@ -51088,12 +52330,12 @@ from previous Chrome versions. <int value="1319024729" label="ServiceWorkerServicification:disabled"/> <int value="1319068611" label="SecondaryUiMd:disabled"/> <int value="1319498514" label="NewMacNotificationAPI:disabled"/> - <int value="1319632929" label="OmniboxPedalsBatch2:disabled"/> <int value="1319638975" label="UseWallpaperStagingUrl:disabled"/> <int value="1319725131" label="enable-distance-field-text"/> <int value="1320201920" label="enable-touchpad-three-finger-click"/> <int value="1320450434" label="ArcUsbStorageUI:disabled"/> <int value="1323808967" label="PlaybackSpeedButton:disabled"/> + <int value="1324043544" label="SyncSettingsCategorization:enabled"/> <int value="1324623677" label="SessionRestorePrioritizesBackgroundUseCases:enabled"/> <int value="1325459977" label="HandwritingGestureEditing:disabled"/> @@ -51153,17 +52395,20 @@ from previous Chrome versions. <int value="1369649674" label="ChromeShareScreenshot:enabled"/> <int value="1370797930" label="ShowBluetoothDeviceBattery:enabled"/> <int value="1371092708" label="disable-desktop-capture-picker-old-ui"/> + <int value="1371190773" + label="AutofillEnableVirtualCardsRiskBasedAuthentication:enabled"/> <int value="1371344350" label="MediaSessionWebRTC:disabled"/> <int value="1371907429" label="enable-wallet-card-import"/> <int value="1372680885" label="enable-mtp-write-support"/> <int value="1373777956" label="disable-threaded-gpu-rasterization"/> <int value="1375165388" label="LazyFrameLoading:enabled"/> <int value="1376437124" label="show-cert-link"/> - <int value="1376446149" label="IntentHandlingSharing:enabled"/> <int value="1377056573" label="browser-side-navigation:enabled"/> <int value="1378310092" label="disable-suggestions-service"/> + <int value="1379182781" label="MessagesForAndroidNearOomReduction:disabled"/> <int value="1379571437" label="ExoPointerLock:disabled"/> <int value="1379944457" label="EnableMessagesWebPush:disabled"/> + <int value="1380367827" label="AllowDisableTouchpadHapticFeedback:enabled"/> <int value="1381746642" label="enable-automatic-password-saving"/> <int value="1381817717" label="EduCoexistence:enabled"/> <int value="1382107019" label="LevelDBPerformRewrite:disabled"/> @@ -51183,13 +52428,13 @@ from previous Chrome versions. <int value="1393500952" label="EnableVirtualKeyboardUkm:disabled"/> <int value="1393722373" label="SaveEditedPDFForm:disabled"/> <int value="1394896630" label="PrinterStatusDialog:enabled"/> - <int value="1394925480" label="SharesheetContentPreviews:enabled"/> <int value="1397053154" label="ContextualSearchLiteralSearchTap:enabled"/> <int value="1397069250" label="NetworkService:disabled"/> <int value="1398049903" label="WebUIDarkMode:disabled"/> <int value="1398333721" label="ForceEnableDevicesPage:disabled"/> <int value="1399950951" label="AutofillTokenPrefixMatching:disabled"/> <int value="1403195370" label="ArcCupsApi:enabled"/> + <int value="1403792475" label="ShareMenu:enabled"/> <int value="1404726271" label="ReduceHorizontalFlingVelocity:enabled"/> <int value="1405459667" label="enable-fast-text-autosizing"/> <int value="1406046556" label="enable-slimming-paint-v175"/> @@ -51218,6 +52463,7 @@ from previous Chrome versions. label="DesktopPWAsFlashAppNameInsteadOfOrigin:enabled"/> <int value="1420007919" label="SyncTrustedVaultPassphrasePromo:disabled"/> <int value="1421620678" label="simple-clear-browsing-data-support-string"/> + <int value="1422462035" label="PaymentRequestBasicCard:disabled"/> <int value="1424775876" label="ToolbarIphAndroid:enabled"/> <int value="1425103276" label="SharedHighlightingV2:enabled"/> <int value="1427427985" @@ -51228,12 +52474,14 @@ from previous Chrome versions. <int value="1429031731" label="CrossOriginEmbedderPolicyCredentialless:enabled"/> <int value="1429923065" label="enable-media-internals:enabled"/> + <int value="1430421070" label="UsbDeviceDefaultAttachToArcVm:disabled"/> <int value="1430924529" label="TranslateIntent:enabled"/> <int value="1431050645" label="PayWithGoogleV1:disabled"/> <int value="1431934725" label="OmniboxAutocompleteTitles:disabled"/> <int value="1434515920" label="ReaderModeInCCT:enabled"/> <int value="1435251818" label="AutofillNoLocalSaveOnUploadSuccess:enabled"/> <int value="1436454450" label="InterestFeedV2:disabled"/> + <int value="1436693426" label="document-transition-slowdown-factor"/> <int value="1437413720" label="CooperativeScheduling:disabled"/> <int value="1438417722" label="MessagesForAndroidReaderMode:enabled"/> <int value="1440618113" label="EnableNetworkingInDiagnosticsApp:disabled"/> @@ -51244,6 +52492,8 @@ from previous Chrome versions. label="OmniboxRemoveSuggestionsFromClipboard:disabled"/> <int value="1442798825" label="enable-quic"/> <int value="1442830837" label="MemoryAblation:disabled"/> + <int value="1443830588" label="VerticalSnap:disabled"/> + <int value="1444066555" label="MessagesForAndroidSyncError:disabled"/> <int value="1446066818" label="WebRtcAnalogAgcClippingControl:enabled"/> <int value="1446349255" label="ArcEnableUsap:disabled"/> <int value="1446946673" label="DesktopRestructuredLanguageSettings:disabled"/> @@ -51382,6 +52632,7 @@ from previous Chrome versions. <int value="1561781431" label="VirtualKeyboardBorderedKey:enabled"/> <int value="1562855415" label="WebRtcUseMinMaxVEADimensions:disabled"/> <int value="1563255033" label="memlog-stack-mode"/> + <int value="1567695310" label="CrostiniBullseyeUpgrade:disabled"/> <int value="1567839560" label="ChromeHomePersonalizedOmniboxSuggestions:disabled"/> <int value="1568172566" @@ -51421,6 +52672,7 @@ from previous Chrome versions. <int value="1597880096" label="FocusMode:disabled"/> <int value="1600850069" label="MobileIdentityConsistency:disabled"/> <int value="1600926040" label="TranslateCompactUI:enabled"/> + <int value="1601012975" label="FeedStamp:disabled"/> <int value="1601231448" label="VirtualKeyboardMultipaste:disabled"/> <int value="1601582484" label="enable-crash-reporter-for-testing"/> <int value="1602627012" label="OverrideSitePrefsForHrefTranslate:enabled"/> @@ -51476,6 +52728,8 @@ from previous Chrome versions. <int value="1636721063" label="AutofillLocalCardMigrationShowFeedback:enabled"/> <int value="1636962093" label="disable-material-design-ntp"/> + <int value="1637611166" + label="ExperimentalAccessibilityDictationCommands:enabled"/> <int value="1637615389" label="PrintServerScaling:enabled"/> <int value="1638123293" label="DeprecateAltClick:disabled"/> <int value="1638582559" label="UpdatedCellularActivationUi:disabled"/> @@ -51498,6 +52752,7 @@ from previous Chrome versions. <int value="1654445970" label="EphemeralTabUsingBottomSheet:enabled"/> <int value="1657713458" label="disable-virtual-keyboard-overscroll"/> <int value="1658644418" label="disable-app-list-voice-search"/> + <int value="1658656322" label="IncognitoDownloadsWarning:enabled"/> <int value="1659082220" label="EnableManualSaving:disabled"/> <int value="1659372520" label="WebXrRenderPath:disabled"/> <int value="1660491118" label="AllowAmbientEQ:enabled"/> @@ -51540,6 +52795,7 @@ from previous Chrome versions. <int value="1691568199" label="AndroidSpellCheckerNonLowEnd:disabled"/> <int value="1692847616" label="ArcEnableWebAppShare:enabled"/> <int value="1693094211" label="FilesNG:disabled"/> + <int value="1693658048" label="AppsShortcutDefaultOff:enabled"/> <int value="1694766748" label="AutofillRestrictUnownedFieldsToFormlessCheckout:enabled"/> <int value="1694798717" label="NewNetErrorPageUI:enabled"/> @@ -51564,6 +52820,10 @@ from previous Chrome versions. <int value="1707873180" label="OmniboxOnFocusSuggestionsContextualWebAllowSRP:disabled"/> <int value="1708118086" label="TextFragmentAnchor:disabled"/> + <int value="1709898387" + label="AutofillUseUnassociatedListedElements:enabled"/> + <int value="1710630380" + label="AutofillEnableSupportForMoreStructureInNames:enabled"/> <int value="1711286384" label="ContextMenuCopyImage:disabled"/> <int value="1712622545" label="Memories:disabled"/> <int value="1712697097" label="QuickAnswersV2:disabled"/> @@ -51571,6 +52831,7 @@ from previous Chrome versions. <int value="1713230497" label="ColorCorrectRendering:disabled"/> <int value="1714016217" label="EnableHeuristicPalmDetectionFilter:enabled"/> <int value="1714520147" label="MBIMode:disabled"/> + <int value="1714746366" label="BookmarksImprovedSaveFlow:disabled"/> <int value="1714922056" label="GlobalMediaControls:disabled"/> <int value="1715338237" label="ContextualSearchSecondTap:disabled"/> <int value="1716104463" label="enable-fullscreen-app-list"/> @@ -51591,6 +52852,7 @@ from previous Chrome versions. <int value="1731522433" label="enable-offer-store-unmasked-wallet-cards"/> <int value="1731612996" label="CrostiniFiles:disabled"/> <int value="1733390925" label="force-enable-stylus-tools"/> + <int value="1733784338" label="CSSCascadeLayers:disabled"/> <int value="1734685331" label="NtpShoppingTasksModule:enabled"/> <int value="1735934914" label="OverlayScrollbarFlashWhenMouseEnter:disabled"/> <int value="1736698988" label="FsNosymfollow:disabled"/> @@ -51604,6 +52866,8 @@ from previous Chrome versions. label="AutofillSuggestVirtualCardsOnIncompleteForm:disabled"/> <int value="1742398600" label="OmniboxUIExperimentBoldUserTextOnSearchSuggestions:enabled"/> + <int value="1743062852" + label="AutofillUseUnassociatedListedElements:disabled"/> <int value="1745053254" label="ClickToCallOpenDialerDirectly:enabled"/> <int value="1747279677" label="disable-delegated-renderer"/> <int value="1748481830" label="AppManagement:enabled"/> @@ -51616,6 +52880,7 @@ from previous Chrome versions. <int value="1757894817" label="PrinterStatusDialog:disabled"/> <int value="1758262950" label="OmniboxUIExperimentVerticalMarginLimitToNonTouchOnly:disabled"/> + <int value="1759323272" label="DefaultCalculatorWebApp:disabled"/> <int value="1760946944" label="MacViewsAutofillPopup:disabled"/> <int value="1761920078" label="OverrideSimilarLanguagesForHrefTranslate:enabled"/> @@ -51624,12 +52889,14 @@ from previous Chrome versions. <int value="1766676896" label="affiliation-based-matching:disabled"/> <int value="1767411597" label="DisallowUnsafeHttpDownloads:enabled"/> <int value="1768759000" label="AutofillProfileServerValidation:disabled"/> + <int value="1769483213" label="AudioUrl:disabled"/> <int value="1770189877" label="ConfirmNtpSuggestionRemovals:enabled"/> <int value="1771548551" label="DisableKeepaliveFetch:enabled"/> <int value="1772454319" label="enable-storage-manager"/> <int value="1775475563" label="malware-interstitial-v3"/> <int value="1775652804" label="OmniboxBookmarkPaths:disabled"/> <int value="1775730290" label="OmniboxKeywordSearchButton:enabled"/> + <int value="1776136073" label="ExtensionsMenuAccessControl:enabled"/> <int value="1776163541" label="DesktopPWAsWebBundles:enabled"/> <int value="1776475705" label="show-composited-layer-borders"/> <int value="1777059507" label="trust-autofill-server-name-types"/> @@ -51643,6 +52910,7 @@ from previous Chrome versions. <int value="1782210532" label="PerNavigationMojoInterface:disabled"/> <int value="1783293530" label="disallow-autofill-sync-credential"/> <int value="1783837132" label="enable-threaded-gpu-rasterization"/> + <int value="1783967606" label="PageContentAnnotations:enabled"/> <int value="1785093465" label="enable-document-passive-event-listeners"/> <int value="1785274337" label="AutofillEnableOfferNotificationCrossTabTracking:disabled"/> @@ -51676,6 +52944,7 @@ from previous Chrome versions. <int value="1803465156" label="enable-zero-suggest-most-visited"/> <int value="1803470125" label="SyncUSSSessions:enabled"/> <int value="1803914892" label="TemporaryUnexpireFlagsM76:enabled"/> + <int value="1806450300" label="WebUsbDeviceDetection:enabled"/> <int value="1807374811" label="CCTModuleCache:enabled"/> <int value="1809940714" label="SpeculativeLaunchServiceWorker:disabled"/> <int value="1810258949" label="DisplayLocking:enabled"/> @@ -51723,12 +52992,14 @@ from previous Chrome versions. <int value="1835075399" label="PostQuantumCECPQ2:disabled"/> <int value="1835523483" label="OmniboxUIExperimentSwapTitleAndUrl:enabled"/> <int value="1835931933" label="ShareUsageRankingFixedMore:enabled"/> + <int value="1836557489" label="EnableDangerousDownloadDialog:disabled"/> <int value="1837330563" label="WebPaymentsMinimalUI:disabled"/> <int value="1837847580" label="MutingCompromisedCredentials:disabled"/> <int value="1838990777" label="V8Future:enabled"/> <int value="1839005510" label="MutingCompromisedCredentials:enabled"/> <int value="1839740266" label="LocationHardReload:disabled"/> <int value="1841793150" label="TwoPanesStartSurfaceAndroid:enabled"/> + <int value="1841976850" label="FeedLoadingPlaceholder:enabled"/> <int value="1842219851" label="enable-incognito-window-counter"/> <int value="1843088575" label="OutOfBlinkCors:enabled"/> <int value="1844110073" label="enable-app-view"/> @@ -51751,7 +53022,7 @@ from previous Chrome versions. <int value="1856270952" label="AutofillAssistantProactiveHelp:disabled"/> <int value="1857000695" label="SendWebUIJavaScriptErrorReports:disabled"/> <int value="1858385315" label="ChromeHomeBottomNavLabels:enabled"/> - <int value="1858919054" label="SplitSettingsSync:disabled"/> + <int value="1858523835" label="VerifyDidCommitParams:enabled"/> <int value="1860597983" label="AndroidSpellChecker:disabled"/> <int value="1860955818" label="PowerScheduler:enabled"/> <int value="1861251313" @@ -51806,6 +53077,7 @@ from previous Chrome versions. <int value="1903206193" label="NewWindowAppMenu:disabled"/> <int value="1903444879" label="VirtualKeyboardApi:disabled"/> <int value="1905465678" label="ContextualSearchSingleActions:enabled"/> + <int value="1906901281" label="WebFilterInterstitialRefresh:enabled"/> <int value="1906942630" label="enable-easy-unlock"/> <int value="1907273605" label="NtpZeroSuggest:disabled"/> <int value="1909117215" label="animated-image-resume"/> @@ -51817,7 +53089,6 @@ from previous Chrome versions. <int value="1914347357" label="AutofillEnableVirtualCard:disabled"/> <int value="1915028326" label="BuiltInModuleKvStorage:disabled"/> <int value="1915178511" label="disable-blink-features"/> - <int value="1915956064" label="SharesheetContentPreviews:disabled"/> <int value="1916637435" label="TranslateSubFrames:enabled"/> <int value="1918984253" label="OmniboxUIExperimentBlueSearchLoopAndSearchQuery:disabled"/> @@ -51852,6 +53123,7 @@ from previous Chrome versions. <int value="1935405622" label="AppServiceInstanceRegistry:disabled"/> <int value="1936810062" label="WebVrVsyncAlign:enabled"/> <int value="1937357350" label="MultilingualTyping:disabled"/> + <int value="1937905990" label="AutofillCenterAlignedSuggestions:enabled"/> <int value="1938279796" label="PromosOnLocalNtp:disabled"/> <int value="1939413645" label="enable-invalid-cert-collection"/> <int value="1939884866" label="web-otp-backend"/> @@ -51888,6 +53160,7 @@ from previous Chrome versions. <int value="1961068026" label="EnableEphemeralGuestProfilesOnDesktop:enabled"/> <int value="1961425320" label="force-qtkit"/> + <int value="1961717207" label="PageInfoAboutThisSite:enabled"/> <int value="1962485086" label="DesktopPWAsLocalUpdating:enabled"/> <int value="1963766060" label="AutofillEnableFixedPaymentsBubbleLogging:enabled"/> @@ -51909,6 +53182,7 @@ from previous Chrome versions. <int value="1976644015" label="enable-forbid-sync-xhr-in-page-dismissal"/> <int value="1976885976" label="DefaultChatWebApp:disabled"/> <int value="1978548617" label="FilesZipMount:enabled"/> + <int value="1978570295" label="RawDraw:disabled"/> <int value="1979222611" label="XRSandbox:disabled"/> <int value="1979472169" label="TabGroupsFeedback:disabled"/> <int value="1980011075" label="debug-packed-apps"/> @@ -51972,19 +53246,25 @@ from previous Chrome versions. <int value="2014629801" label="view-passwords:disabled"/> <int value="2015335629" label="shelf-hover-previews"/> <int value="2015547864" label="NetworkServiceInProcess:enabled"/> + <int value="2018661699" + label="EnterpriseReportingExtensionManifestVersion:disabled"/> <int value="2018956925" label="UseAAudioDriver:disabled"/> <int value="2020107447" label="AndroidPayIntegrationV1:enabled"/> <int value="2020898714" label="HudDisplayForPerformanceMetrics:enabled"/> + <int value="2021142866" label="FeedbackReportQuestionnaire:disabled"/> <int value="2022153130" label="MobileIdentityConsistencyVar:disabled"/> <int value="2022294878" label="WifiSyncAndroid:enabled"/> <int value="2022716687" label="ReadLaterReminderNotification:enabled"/> <int value="2024172900" label="KidsManagementUrlClassification:disabled"/> <int value="2024298022" label="AutofillEnableInfoBarAccountIndicationFooterForSyncUsers:disabled"/> + <int value="2027729007" label="WindowControlMenu:enabled"/> <int value="2027793952" label="EditPasswordsInSettings:disabled"/> <int value="2032558514" label="RemoveUsageOfDeprecatedGaiaSigninEndpoint:enabled"/> + <int value="2032880973" label="U2FSecurityKeyAPI:disabled"/> <int value="2034198538" label="TabHoverCards:enabled"/> + <int value="2035415906" label="Win11StyleMenus:enabled"/> <int value="2037562553" label="OmniboxBubbleUrlSuggestions:disabled"/> <int value="2037756154" label="enable-impl-side-painting"/> <int value="2038036881" label="NewShortcutMapping:enabled"/> @@ -52017,6 +53297,8 @@ from previous Chrome versions. <int value="2068193488" label="SharedClipboardUI:disabled"/> <int value="2069999572" label="AllowSignedHTTPExchangeCertsWithoutExtension:disabled"/> + <int value="2070207131" label="OpenscreenCastStreamingSession:disabled"/> + <int value="2071148245" label="ForceMajorVersion100InUserAgent:enabled"/> <int value="2071229145" label="BloatedRendererDetection:enabled"/> <int value="2071340353" label="progress-bar-completion"/> <int value="2071461362" label="disable-credit-card-scan"/> @@ -52040,9 +53322,12 @@ from previous Chrome versions. <int value="2084477383" label="CrostiniDiskResizing:enabled"/> <int value="2084638930" label="AutofillEnforceMinRequiredFieldsForUpload:enabled"/> + <int value="2085105493" + label="WebAuthenticationAuthenticatorAttachment:enabled"/> <int value="2085186092" label="BulkPrinters:disabled"/> <int value="2085438501" label="ChromeHome:enabled"/> <int value="2087069781" label="ui-debug-tools:enabled"/> + <int value="2088061188" label="LibinputHandleTouchpad:enabled"/> <int value="2088446947" label="enable-ephemeral-guest-profiles-on-desktop"/> <int value="2089897928" label="enable-audio-focus"/> <int value="2089901626" label="QuickSettingsPWA:enabled"/> @@ -52076,6 +53361,7 @@ from previous Chrome versions. <int value="2114843059" label="ContextualSuggestionsOptOut:enabled"/> <int value="2114894984" label="DelayCompetingLowPriorityRequests:enabled"/> <int value="2115848376" label="LacrosSupport:disabled"/> + <int value="2115946659" label="ArcAllowDataRetention:enabled"/> <int value="2118287149" label="HelpAppSearchServiceIntegration:enabled"/> <int value="2118374092" label="MessagesForAndroidReaderMode:disabled"/> <int value="2119964154" label="enable-download-resumption"/> @@ -52088,6 +53374,7 @@ from previous Chrome versions. <int value="2122876605" label="enable-bleeding-edge-rendering-fast-paths"/> <int value="2123183411" label="BlinkHeapIncrementalMarking:enabled"/> <int value="2123567684" label="OptimizeLoadingIPCForSmallResources:enabled"/> + <int value="2125732298" label="RetailCoupons:disabled"/> <int value="2126203058" label="force-show-update-menu-badge"/> <int value="2127648677" label="OmniboxExperimentalSuggestScoring:disabled"/> <int value="2129184006" label="NTPOfflinePageDownloadSuggestions:enabled"/> @@ -52102,6 +53389,7 @@ from previous Chrome versions. <int value="2135408204" label="OverscrollHistoryNavigation:disabled"/> <int value="2137113620" label="ProcessSharingWithStrictSiteInstances:enabled"/> + <int value="2137143068" label="AudioUrl:enabled"/> <int value="2137294324" label="zero-copy-video-capture"/> <int value="2137347307" label="enable-drive-apps-in-app-list"/> <int value="2137554806" @@ -52117,6 +53405,7 @@ from previous Chrome versions. <int value="2141463681" label="enable-offer-upload-credit-cards"/> <int value="2142661816" label="AllowRemoteContextForNotifications:disabled"/> <int value="2142979536" label="EnableManualFallbacksFilling:disabled"/> + <int value="2144581598" label="UpcomingSharingFeatures:enabled"/> </enum> <enum name="LoginDatabaseInitError"> @@ -53392,7 +54681,7 @@ Called by update_use_counter_css.py.--> <int value="409" label="user-zoom"/> <int value="410" label="webkit-dashboard-region"/> <int value="411" label="webkit-overflow-scrolling"/> - <int value="412" label="webkit-app-region"/> + <int value="412" label="alias-webkit-app-region"/> <int value="413" label="alias-webkit-filter"/> <int value="414" label="webkit-box-decoration-break"/> <int value="415" label="webkit-tap-highlight-color"/> @@ -53680,6 +54969,11 @@ Called by update_use_counter_css.py.--> <int value="697" label="container-name"/> <int value="698" label="container-type"/> <int value="699" label="container"/> + <int value="700" label="font-synthesis-weight"/> + <int value="701" label="font-synthesis-style"/> + <int value="702" label="app-region"/> + <int value="703" label="font-synthesis-small-caps"/> + <int value="704" label="font-synthesis"/> </enum> <enum name="MappedEditingCommands"> @@ -53977,6 +55271,17 @@ Called by update_use_counter_css.py.--> <int value="1" label="Clicked"/> </enum> +<enum name="MediaControlsPlaybackSpeed"> + <int value="0" label="0.25"/> + <int value="1" label="0.5"/> + <int value="2" label="0.75"/> + <int value="3" label="1"/> + <int value="4" label="1.25"/> + <int value="5" label="1.5"/> + <int value="6" label="1.75"/> + <int value="7" label="2"/> +</enum> + <enum name="MediaControlsShowReason"> <int value="0" label="Attribute"/> <int value="1" label="Fullscreen"/> @@ -55103,10 +56408,18 @@ Called by update_use_counter_css.py.--> <int value="7" label="Could not identify the source language"/> </enum> +<enum name="MerchantTrustBottomSheetOpenedSource"> + <int value="0" label="Unknown"/> + <int value="1" label="From message"/> + <int value="2" label="From page info"/> +</enum> + <enum name="MerchantTrustMessageClearReason"> <int value="0" label="Unknown"/> <int value="1" label="Navigate to same domain"/> <int value="2" label="Navigate to different domain"/> + <int value="3" label="Message context is no longer valid"/> + <int value="4" label="Switch to different webcontents"/> </enum> <enum name="MessageDismissReason"> @@ -55122,6 +56435,7 @@ Called by update_use_counter_css.py.--> </enum> <enum name="MessageIdentifier"> + <int value="0" label="InvalidMessage"/> <int value="1" label="SavePassword"/> <int value="2" label="UpdatePassword"/> <int value="3" label="GeneratedPasswordSaved"/> @@ -55138,6 +56452,11 @@ Called by update_use_counter_css.py.--> <int value="14" label="PermissionUpdate"/> <int value="15" label="AdsBlocked"/> <int value="16" label="DownloadProgress"/> + <int value="17" label="SyncError"/> + <int value="18" label="SharedHighlighting"/> + <int value="19" label="NearOomReduction"/> + <int value="20" label="InstallableAmbientBadge"/> + <int value="21" label="AutoDarkWebContents"/> </enum> <enum name="MessageLoopProblems"> @@ -55434,6 +56753,13 @@ Called by update_use_counter_css.py.--> <int value="2" label="ResponseReceived"/> </enum> +<enum name="MixedContentDownloadDialogEvent"> + <int value="0" label="dialog shown"/> + <int value="1" label="Dialog confirmed"/> + <int value="2" label="Dialog canceled"/> + <int value="3" label="Dialog dismissed"/> +</enum> + <enum name="MixedContentType"> <int value="0" label="Optionally Blockable Mixed Content"/> <int value="1" label="Optionally Blockable Content with Certificate Errors"/> @@ -55549,9 +56875,9 @@ Called by update_use_counter_css.py.--> <int value="0" label="FRE started"/> <int value="1" label="Welcome shown"/> <int value="2" label="Data saver shown"/> - <int value="3" label="Sign in shown"/> - <int value="4" label="FRE completed w/ user signed in"/> - <int value="5" label="FRE completed w/ user not signed in"/> + <int value="3" label="Sync consent shown"/> + <int value="4" label="FRE completed w/ user signed in and sync"/> + <int value="5" label="FRE completed w/ user not signed in and sync"/> <int value="6" label="Search engine choice dialog shown"/> </enum> @@ -56033,6 +57359,7 @@ Called by update_use_counter_css.py.--> <int value="11" label="Connection lost"/> <int value="12" label="Nearby process crash"/> <int value="13" label="Nearby process Mojo dependency disconnection"/> + <int value="14" label="Received file paylad that wasn't registered"/> </enum> <enum name="MultiDeviceNearbyMessageAction"> @@ -57485,6 +58812,8 @@ Called by update_net_error_codes.py.--> <enum name="NetReportingHeaderType"> <int value="0" label="Report-To"/> <int value="1" label="Invalid Report-To"/> + <int value="2" label="Reporting-Endpoints"/> + <int value="3" label="Invalid Reporting-Endpoints"/> </enum> <enum name="NetReportingReportOutcome"> @@ -57503,6 +58832,11 @@ Called by update_net_error_codes.py.--> <int value="9" label="Delivered"/> </enum> +<enum name="NetReportingUploadHeaderType"> + <int value="0" label="ReportTo"/> + <int value="1" label="ReportingEndpoints"/> +</enum> + <enum name="NetReportingUploadOutcome"> <obsolete> Removed from code June 2020. @@ -58712,6 +60046,7 @@ Called by update_net_trust_anchors.py.--> <int value="7" label="LTE"/> <int value="8" label="UMTS"/> <int value="9" label="Unknown"/> + <int value="10" label="5GNR"/> </enum> <enum name="NetworkCellularUsage"> @@ -59069,6 +60404,13 @@ Called by update_net_trust_anchors.py.--> <int value="3" label="same-site violation"/> </enum> +<enum name="NetworkServiceCorsPreflightMethodAllowed"> + <int value="0" label="Both Disallowed"/> + <int value="1" label="Only normalized_method allowed"/> + <int value="2" label="Only method allowed"/> + <int value="3" label="Both Allowed"/> +</enum> + <enum name="NetworkServiceError"> <int value="0" label="NONE"/> <int value="1" label="AAA_FAILED"/> @@ -59099,6 +60441,43 @@ Called by update_net_trust_anchors.py.--> <int value="26" label="SIM_LOCKED"/> </enum> +<enum name="NetworkServiceSandboxGrantResult"> + <int value="0" label="kSuccess">A data migration was successful.</int> + <int value="1" label="kFailedToCreateCacheDirectory"> + Failed to create cache directory. + </int> + <int value="2" label="kFailedToCreateDataDirectory"> + Failed to create data directory. + </int> + <int value="3" label="kFailedToCopyData">Failed to copy data.</int> + <int value="4" label="kFailedToDeleteOldData">Failed to delete old data.</int> + <int value="5" label="kFailedToGrantSandboxAccessToCache"> + Failed to grant sandbox access to cache directory. + </int> + <int value="6" label="kFailedToGrantSandboxAccessToData"> + Failed to grant sandbox access to data directory. + </int> + <int value="7" label="kDidNotAttemptToGrantSandboxAccess"> + The operation was not attempted because granting sandbox access was not + supported on the current platform configuration, no data paths were + specified (e.g. in-memory) or no unsandboxed_data_path was specified to + migrate from. + </int> + <int value="8" label="kFailedToCreateCheckpointFile"> + Failed to create checkpoint file. + </int> + <int value="9" label="kNoMigrationRequested"> + A valid unsandboxed_data_path was specified but no migration was requested. + </int> + <int value="10" label="kMigrationAlreadySucceeded"> + Migration has already succeeded previously. + </int> + <int value="11" label="kMigrationAlreadySucceededWithNoAccess"> + Migration has already succeeded but it was not possible to grant the sandbox + access to the data directory. + </int> +</enum> + <enum name="NetworkStatus"> <int value="1" label="Offline"/> <int value="2" label="OnlineWifi"/> @@ -59203,6 +60582,15 @@ Called by update_net_trust_anchors.py.--> <int value="3" label="Renamed root partner folder"/> </enum> +<enum name="NewTabPageConcretePage"> + <int value="0" label="Other"/> + <int value="1" label="1P WebUI NTP"/> + <int value="2" label="3P WebUI NTP"/> + <int value="3" label="3P Remote NTP"/> + <int value="4" label="Extension NTP"/> + <int value="5" label="Off the record NTP"/> +</enum> + <enum name="NewTabPageLogoClick"> <int value="0" label="Static logo clicked"/> <int value="1" label="CTA image clicked"/> @@ -59292,6 +60680,12 @@ Called by update_net_trust_anchors.py.--> <int value="1" label="Timed out"/> </enum> +<enum name="NightMode"> + <int value="0" label="undefined"/> + <int value="1" label="no"/> + <int value="2" label="yes"/> +</enum> + <enum name="NormalizedScore"> <int value="0" label="Underflow bucket"/> <int value="1" label="Score in (0, 0.1]"/> @@ -59642,6 +61036,15 @@ Called by update_net_trust_anchors.py.--> label="Background customization unavailable due to search provider"/> </enum> +<enum name="NTPBrokenViewHierarchyRelationship"> + <int value="0" label="ELM collection containing Content Suggestions fixed"/> + <int value="1" label="Discover feed containing ELM collection fixed"/> + <int value="2" label="Discover feed wrapper containing Discover feed fixed"/> + <int value="3" label="NTP containing Discover feed wrapper fixed"/> + <int value="4" + label="Content suggestions view controller not cleaned up on restart"/> +</enum> + <enum name="NTPCustomizeAction"> <int value="0" label="'Chrome backgrounds' menu item clicked."/> <int value="1" label="'Upload an image' menu item clicked."/> @@ -61715,6 +63118,8 @@ Called by update_net_trust_anchors.py.--> <int value="215" label="Nearby Share: Device Visibility"/> <int value="216" label="Nearby Share: Contacts"/> <int value="217" label="Nearby Share: Data Usage"/> + <int value="218" label="Phone Hub Apps: On/Off"/> + <int value="219" label="Phone Hub Camera Roll: On/Off"/> <int value="300" label="Add Account"/> <int value="301" label="Remove Account"/> <int value="302" label="Split Sync On/Off"/> @@ -61875,6 +63280,7 @@ Called by update_net_trust_anchors.py.--> <int value="1705" label="Report an Issue"/> <int value="1706" label="View Terms of Service"/> <int value="1707" label="Open Diagnostics App"/> + <int value="1708" label="Change Device Name"/> <int value="1800" label="Add Kerberos Ticket V2"/> <int value="1801" label="Remove Kerberos Ticket V2"/> <int value="1802" label="Set Active Kerberos Ticket V2"/> @@ -62849,6 +64255,67 @@ Called by update_net_trust_anchors.py.--> <int value="2" label="After Commit"/> </enum> +<enum name="PaintOpDeserializationError"> + <int value="0" label="DrawLooper forbidden"/> + <int value="1" label="Enum value out of range"/> + <int value="2" label="Forbidden SerializedImageType"/> + <int value="3" label="Insufficient remaining bytes in AlignMemory"/> + <int value="4" label="Insufficient remaining bytes in ExtractReadableMemory"/> + <int value="5" label="Insufficient remaining bytes in Read(PaintRecord)"/> + <int value="6" + label="Insufficient remaining bytes in Read(PaintShader) for + color_bytes"/> + <int value="7" + label="Insufficient remaining bytes in Read(PaintShader) for color_size"/> + <int value="8" + label="Insufficient remaining bytes in Read(PaintShader) for positions"/> + <int value="9" label="Insufficient remaining bytes in Read(SkData)"/> + <int value="10" label="Insufficient remaining bytes in Read(SkPath)"/> + <int value="11" label="Insufficient remaining bytes in Read(SkRegion)"/> + <int value="12" label="Insufficient remaining bytes in Read(SkTextBlob)"/> + <int value="13" label="Insufficient remaining bytes in ReadData"/> + <int value="14" label="Insufficient remaining bytes in ReadFlattenable"/> + <int value="15" + label="Insufficient remaining bytes in ReadMatrixConvolutionPaintFilter"/> + <int value="16" label="Insufficient remaining bytes in ReadSimple"/> + <int value="17" label="Invalid PaintShader"/> + <int value="18" label="Invalid PaintShader PositionsSize"/> + <int value="19" label="Invalid PaintShader ScalingBehavior"/> + <int value="20" label="Invalid PaintShader type"/> + <int value="21" label="Invalid PlaneConfig"/> + <int value="22" label="Invalid RasterScale"/> + <int value="23" label="Invalid RecordShaderId"/> + <int value="24" label="Invalid SerializedImageType"/> + <int value="25" label="Invalid SkYUVColorSpace"/> + <int value="26" label="Invalid Subsampling"/> + <int value="27" label="Invalid Typeface"/> + <int value="28" label="Missing PaintCache path entry"/> + <int value="29" label="Missing PaintCache text blob entry"/> + <int value="30" label="Missing SharedImageProvider"/> + <int value="31" label="PaintFilter has too many inputs"/> + <int value="32" label="PaintOpBuffer MakeFromMemory failure"/> + <int value="33" label="PaintRecord forbidden"/> + <int value="34" label="ReadImage failure"/> + <int value="35" label="SharedImage open failure (obsolete)"/> + <int value="36" label="SkColorFilter unflatten failure"/> + <int value="37" label="SkColorSpace deserialize failure"/> + <int value="38" label="SkDrawLooper unflatten failure"/> + <int value="39" label="SkMaskFilter unflatten failure"/> + <int value="40" label="SkPathEffect unflatten failure"/> + <int value="41" label="SkPath ReadFromMemory failure"/> + <int value="42" label="SkRegion ReadFromMemory failure"/> + <int value="43" label="SkTextBlob deserialize failure"/> + <int value="44" label="Unexpected PaintShaderType"/> + <int value="45" label="Unexpected SerializedImageType"/> + <int value="46" label="Zero mailbox"/> + <int value="47" label="Zero region bytes"/> + <int value="48" label="Zero SkPath bytes"/> + <int value="49" label="SharedImageProvider unknown mailbox"/> + <int value="50" label="SharedImageProvider no access"/> + <int value="51" label="SharedImageProvider SkImage creation failed"/> + <int value="52" label="Zero SkColorFilter bytes"/> +</enum> + <enum name="PaletteModeCancelType"> <int value="0" label="Palette laser pointer mode is cancelled."/> <int value="1" label="Palette laser pointer mode is switched out of"/> @@ -63006,6 +64473,12 @@ Called by update_net_trust_anchors.py.--> <int value="8" label="DisplayPort Alt Mode Peripheral"/> <int value="9" label="USB Hub"/> <int value="10" label="USB Peripheral"/> + <int value="11" label="PD Power Source"/> + <int value="12" label="PD Sourcing Device"/> + <int value="13" label="Non-PD Power Source"/> + <int value="14" label="PD Sink"/> + <int value="15" label="PD Sinking Host"/> + <int value="16" label="Non-PD Sink"/> </enum> <enum name="PassiveForcedListenerResultType"> @@ -63165,6 +64638,7 @@ Called by update_net_trust_anchors.py.--> <int value="3" label="Unlock account-store to fill password"/> <int value="4" label="Unlock account-store to generate password"/> <int value="5" label="Re-Signin to unlock account-stored passwords"/> + <int value="6" label="WebAuthn credential"/> </enum> <enum name="PasswordDropdownState"> @@ -63877,6 +65351,9 @@ Called by update_net_trust_anchors.py.--> A credential exists for an affiliated matched site but not for the current security origin. </int> + <int value="10" label="Accepts WebAuthn credentials"> + The form acccepts WebAuthn credentials from an active WebAuthn request. + </int> </enum> <enum name="PasswordManagerHttpCredentialType"> @@ -63937,6 +65414,9 @@ Called by update_net_trust_anchors.py.--> </enum> <enum name="PasswordManagerOsPasswordStatus"> + <obsolete> + Deprecated 09/2021. + </obsolete> <int value="0" label="Unknown"/> <int value="1" label="Unsupported platform"/> <int value="2" label="Password is blank"/> @@ -65283,6 +66763,12 @@ Called by update_net_trust_anchors.py.--> <int value="3" label="Use Android picker"/> </enum> +<enum name="PhotosModuleRequestResult"> + <int value="0" label="kError"/> + <int value="1" label="kSuccess"/> + <int value="2" label="kCached"/> +</enum> + <enum name="PhysicalWebActivityReferer"> <int value="0" label="REFERER_UNDEFINED"/> <int value="1" label="REFERER_NOTIFICATION (Obsolete)"/> @@ -65683,6 +67169,7 @@ Called by update_net_trust_anchors.py.--> <int value="28" label="DOWNLOAD_FAILED_401"/> <int value="29" label="DOWNLOAD_FAILED_403"/> <int value="30" label="DOWNLOAD_FAILED_404"/> + <int value="31" label="DOWNLOAD_SIZE_MISMATCH"/> </enum> <enum name="PluginVmSetupResult"> @@ -65918,6 +67405,9 @@ Called by update_net_trust_anchors.py.--> </enum> <enum name="PostOperationState"> + <obsolete> + Removed in M95. + </obsolete> <int value="0" label="Succeeded">The operation succeeded</int> <int value="1" label="Failed: file not found"> The operation failed and the file operated on is not found. @@ -66144,6 +67634,7 @@ Called by update_net_trust_anchors.py.--> <int value="13" label="kMediumAnimation"/> <int value="14" label="kSmallMainThreadAnimation"/> <int value="15" label="kMediumMainThreadAnimation"/> + <int value="16" label="kScriptExecution"/> </enum> <enum name="PowerSupplyType"> @@ -66604,6 +68095,9 @@ Called by update_net_trust_anchors.py.--> <int value="26" label="kLoginAuthRequested"/> <int value="27" label="kUaChangeRequiresReload"/> <int value="28" label="kBlockedByClient"/> + <int value="29" label="kAudioOutputDeviceRequested"/> + <int value="30" label="kMixedContent"/> + <int value="31" label="kTriggerBackgrounded"/> </enum> <enum name="PrerenderHoverEvent"> @@ -67382,6 +68876,20 @@ Called by update_net_trust_anchors.py.--> <int value="1" label="PriorityChanged"/> </enum> +<enum name="PrivacySandboxAggregationServiceReportStatus"> + <int value="0" label="Ok"/> + <int value="1" label="Network error"/> + <int value="2" label="Server error"/> +</enum> + +<enum name="PrivacySandboxAggregationServiceStorageSqlInitStatus"> + <int value="0" label="Success"/> + <int value="1" label="Failed to open DB in memory"/> + <int value="2" label="Failed to open DB file"/> + <int value="3" label="Failed to create directory"/> + <int value="4" label="Failed to initialize schema"/> +</enum> + <enum name="PrivacySandboxReferrer"> <int value="0" label="Privacy Settings"/> <int value="1" label="Cookie Settings Snackbar"/> @@ -67393,6 +68901,15 @@ Called by update_net_trust_anchors.py.--> <int value="2" label="ToastButton"/> </enum> +<enum name="PrivateNetworkAccessCheckResult"> + <int value="0" label="kAllowedMissingClientSecurityState"/> + <int value="1" label="kAllowedNoLessPublic"/> + <int value="2" label="kAllowedByPolicyAllow"/> + <int value="3" label="kAllowedByPolicyWarn"/> + <int value="4" label="kBlockedByLoadOption"/> + <int value="5" label="kBlockedByPolicyBlock"/> +</enum> + <enum name="PrivateSetMembershipHashDanceComparison"> <int value="0" label="Equal Results"/> <int value="1" label="Different Results"/> @@ -67485,6 +69002,12 @@ Called by update_net_trust_anchors.py.--> <int value="5" label="Valid minidump in background app"/> </enum> +<enum name="ProcessIntegrityResult"> + <int value="0" label="Low integrity level"/> + <int value="1" label="Medium integrity level from Open GL"/> + <int value="2" label="Medium integrity level from Desktop access check"/> +</enum> + <enum name="ProcessNameHash"> <summary> The hash of a lower case process name generated using metrics::HashName. @@ -68010,6 +69533,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="18" label="kExtensionUpdater"/> <int value="19" label="kProfileCreationFlow"/> <int value="20" label="kPendingNotificationCloseEvent"/> + <int value="21" label="kFeedbackDialog"/> </enum> <enum name="ProfileMenuActionableItem"> @@ -68151,14 +69675,6 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="Triggered reset"/> </enum> -<enum name="ProfileSigninStatus"> - <int value="0" label="All profiles signed in"/> - <int value="1" label="All profiles not signed in"/> - <int value="2" label="Mixed signin status"/> - <int value="3" label="Unknown signin status"/> - <int value="4" label="Error getting signin status"/> -</enum> - <enum name="ProfileSync"> <int value="0" label="Signed in to sync"/> <int value="1" label="Signed in to sync from original profile"/> @@ -68176,6 +69692,14 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="3" label="Selected a passphrase"/> </enum> +<enum name="ProfileSyncStatus"> + <int value="0" label="All profiles syncing"/> + <int value="1" label="All profiles not syncing"/> + <int value="2" label="Mixed sync status"/> + <int value="3" label="Unknown sync status"/> + <int value="4" label="Error getting sync status"/> +</enum> + <enum name="ProfileType"> <int value="0" label="Original (default) profile"/> <int value="1" label="Secondary (user-created) profile"/> @@ -69147,6 +70671,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="203" label="QUIC_CONNECTION_ID_LIMIT_ERROR"/> <int value="204" label="QUIC_TOO_MANY_CONNECTION_ID_WAITING_TO_RETIRE"/> <int value="205" label="QUIC_HTTP_RECEIVE_SERVER_PUSH"/> + <int value="206" label="QUIC_INVALID_CHARACTER_IN_FIELD_VALUE"/> </enum> <enum name="QuicFailToSerializePacketLocation"> @@ -70937,7 +72462,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="64" label="InternalFreezableIPC"/> <int value="65" label="InternalContinueScriptLoading"/> <int value="66" label="kWebLocks"/> - <int value="67" label="ExperimentalWebScheduling"/> + <int value="67" label="WebSchedulingPostedTask"/> <int value="68" label="InternalFrameLifecycleControl"/> <int value="69" label="MainThreadTaskQueueNonWaking"/> <int value="70" label="InternalFindInPage"/> @@ -71305,6 +72830,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="113" label="IDC_CONTENT_CONTEXT_SEARCHLENSFORIMAGE"/> <int value="114" label="IDC_CONTENT_CONTEXT_REMOVELINKTOTEXT"/> <int value="115" label="IDC_CONTENT_CONTEXT_LENS_REGION_SEARCH"/> + <int value="116" label="IDC_CONTENT_CONTEXT_WEB_REGION_SEARCH"/> </enum> <enum name="ReopenTabPromoStepAtDismissal"> @@ -71974,6 +73500,13 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="Scan failure"/> </enum> +<enum name="SafeBrowsingNoCachedPopulationReason"> + <int value="0" label="Unknown"/> + <int value="1" label="Not populated due to startup"/> + <int value="2" label="Not populated due to MBB pref changing"/> + <int value="3" label="Not populated due to SB pref changing"/> +</enum> + <enum name="SafeBrowsingParseV4HashResult"> <int value="0" label="PARSE_FROM_STRING_ERROR"/> <int value="1" label="UNEXPECTED_THREAT_ENTRY_TYPE_ERROR"/> @@ -72650,6 +74183,8 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="12" label="ALLOWLISTED_BY_POLICY"/> <int value="13" label="CLASSIFY"/> <int value="14" label="NO_CLASSIFY_HAS_DELAYED_WARNING"/> + <int value="15" label="LOCAL_RESOURCE"/> + <int value="16" label="CHROME_UI_PAGE"/> </enum> <enum name="SBClientDownloadCheckDownloadStats"> @@ -72688,7 +74223,8 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="32" label="SENSITIVE_CONTENT_BLOCK"/> <int value="33" label="DEEP_SCANNED_SAFE"/> <int value="34" label="ADVANCED_PROTECTION_PROMPT"/> - <int value="35" label="BLOCKED_UNSUPPOTED_FILETYPE"/> + <int value="35" label="BLOCKED_UNSUPPORTED_FILETYPE"/> + <int value="36" label="ACCOUNT_COMPROMISE"/> </enum> <enum name="SBClientDownloadCheckResult"> @@ -73216,6 +74752,10 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="6" label="PASSWORD_REUSE_MODAL_BYPASS"/> <int value="7" label="EXTENSION_ALLOWLIST_INSTALL_BYPASS"/> <int value="8" label="NON_ALLOWLISTED_EXTENSION_RE_ENABLED"/> + <int value="9" label="SECURITY_SENSITIVE_SAFE_BROWSING_INTERSTITIAL"/> + <int value="10" label="SECURITY_SENSITIVE_SSL_INTERSTITIAL"/> + <int value="11" label="SECURITY_SENSITIVE_PASSWORD_PROTECTION"/> + <int value="12" label="SECURITY_SENSITIVE_DOWNLOAD"/> </enum> <enum name="SBPhishingClassifierEvent"> @@ -73279,6 +74819,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="6" label="ADF is empty"/> <int value="7" label="Flatbed cover is open"/> <int value="8" label="Communication error"/> + <int value="9" label="Success"/> </enum> <enum name="ScanJobSettingsColorMode"> @@ -73317,6 +74858,11 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="Default"/> </enum> +<enum name="ScanMultiPageToolbarAction"> + <int value="0" label="Remove page"/> + <int value="1" label="Rescan page"/> +</enum> + <enum name="ScheduledNavigationType"> <obsolete> Deprecated August 2018 @@ -73913,6 +75459,12 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="6" label="Warning"/> </enum> +<enum name="SegmentationBooleanSegmentSwitch"> + <int value="0" label="Unknown"/> + <int value="1" label="None to enabled"/> + <int value="2" label="Enabled to none"/> +</enum> + <enum name="SegmentationPlatformModelExecutionStatus"> <int value="0" label="Success"/> <int value="1" label="ExecutionError"/> @@ -73924,6 +75476,9 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="NewTab"/> <int value="5" label="Share"/> <int value="6" label="Voice"/> + <int value="10" label="Dummy"/> + <int value="11" label="ClankStart"/> + <int value="12" label="QueryTiles"/> </enum> <enum name="SegmentationPlatformValidationResult"> @@ -74059,6 +75614,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="2" label="Opened"/> <int value="3" label="TimedOut"/> <int value="4" label="Sent"/> + <int value="5" label="DismissReasonUnknown"/> </enum> <enum name="SendTabToSelfNotifyLocalDevice"> @@ -74380,6 +75936,9 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf </enum> <enum name="ServiceWorkerSite"> + <obsolete> + Removed in November 2021. + </obsolete> <int value="0" label="Other (unused)"/> <int value="1" label="NewTabPage"/> <int value="2" label="WithFetchHandler"/> @@ -74506,6 +76065,14 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="1" label="A session restore deferred one or more tabs"/> </enum> +<enum name="SessionRestoreExitResult"> + <int value="0" label="No Exit"/> + <int value="1" label="Has One Service and Did Schedule"/> + <int value="2" label="Has One Service and No Schedule"/> + <int value="3" label="Is not first service and Did Schedule"/> + <int value="4" label="Is not first service and No Schedule"/> +</enum> + <enum name="SessionRestoreFinishReason"> <int value="0" label="SessionRestore.ForegroundTabFirstPaint4_XX successfully @@ -74524,6 +76091,13 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="A tab's content automatically started to load"/> </enum> +<enum name="SessionRestoreWindowCount"> + <int value="0" label="No window"/> + <int value="1" label="No app window, has normal window"/> + <int value="2" label="Has app window, no normal window"/> + <int value="3" label="Has app window, has normal window"/> +</enum> + <enum name="SessionStartupPref"> <int value="0" label="Open home page (unused)"/> <int value="1" label="Continue from last opened pages"/> @@ -74659,6 +76233,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="Open custom spell check"/> <int value="5" label="Open 'Manage Google Account language'"/> <int value="6" label="Open 'Learn more' link about web languages"/> + <int value="7" label="Open 'Learn more' link about language packs"/> </enum> <enum name="SettingsLanguagesSupportPage"> @@ -74865,6 +76440,11 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf </enum> <enum name="SetupInstallResult"> + <summary> + Return status of the Windows installer. The values in this enum must be kept + in sync with the InstallStatus enum in + //chrome/installer/util/util_constants.h. + </summary> <int value="0" label="First install of Chrome succeeded."/> <int value="1" label="Same version reinstalled for repair."/> <int value="2" label="Chrome successfully updated to new version."/> @@ -74919,6 +76499,8 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="56" label="Autoupdates could not be enabled."/> <int value="57" label="Unpacking the (possibly patched) uncompressed archive failed."/> + <int value="71" label="Rotation of the device trust key failed."/> + <int value="72" label="Rotation of the device trust key succeeded."/> </enum> <enum name="SetupInstallServiceInstallResult"> @@ -75061,6 +76643,8 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <enum name="ShareSourceDesktop"> <int value="0" label="UNKNOWN"/> <int value="1" label="OMNIBOX_SHARING_HUB"/> + <int value="2" label="WEB_CONTEXT_MENU"/> + <int value="3" label="APP_MENU_SHARING_HUB"/> </enum> <enum name="ShareTargetUpdateResult"> @@ -75180,8 +76764,11 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="SharedClipboard"/> <int value="5" label="SmsFetchRequest"/> <int value="6" label="RemoteCopy"/> - <int value="7" label="SignallingMessage"/> - <int value="8" label="IceCandidateMessage"/> + <int value="7" label="PeerConnectionOffer"/> + <int value="8" label="PeerConnectionIceCandidate"/> + <int value="9" label="DiscoveryRequest"/> + <int value="10" label="WebRTCSignalingFrame"/> + <int value="11" label="OptimizationGuidePushNotification"/> </enum> <enum name="SharingRemoteCopyHandleMessageResult"> @@ -75230,6 +76817,17 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="3" label="Screenshot Deleted"/> </enum> +<enum name="SharingScrollCaptureBitmapGenerationStatus"> +<!-- + SharingScrollCaptureBitmapGenerationStatus must be kept in sync with BitmapGenerationStatus defined + in /chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/scroll_capture/ScrollCaptureCallbackImpl.java +--> + + <int value="0" label="Capture Completed"/> + <int value="1" label="Insufficient Memory"/> + <int value="2" label="General Generation Error"/> +</enum> + <enum name="SharingSendMessageResult"> <int value="0" label="Successful"/> <int value="1" label="Device is not found"/> @@ -75335,6 +76933,16 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="1" label="Failure"/> </enum> +<enum name="ShoppingDataProviderFallback"> + <summary> + The different kinds of fallback data used by the ShoppingDataProvider. + </summary> + <int value="0" label="Title"/> + <int value="1" label="Lead Image"/> + <int value="2" label="Fallback Image"/> + <int value="3" label="Price"/> +</enum> + <enum name="ShortcutsCreationResult"> <summary>Result of creating shortcuts for PWA.</summary> <int value="0" label="Success"/> @@ -75434,6 +77042,20 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="3" label="Context menu"/> </enum> +<enum name="ShowChromeStartSegmentationResult"> + <int value="0" label="Uninitialized"/> + <int value="1" label="Dont show Start surface"/> + <int value="2" label="Show Start surface"/> +</enum> + +<enum name="ShowChromeStartSegmentationResultComparison"> + <int value="0" label="Uninitialized."/> + <int value="1" label="Segmentation enabled and logic enabled."/> + <int value="2" label="Segmentation enabled and logic disabled."/> + <int value="3" label="Segmentation disabled and logic enabled."/> + <int value="4" label="Segmentation disabled and logic enabled."/> +</enum> + <enum name="ShownAfterCrashingReason"> <summary> This enum describes the reason that a crashed subframe became visible. @@ -75515,6 +77137,25 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="2" label="Dismiss"/> </enum> +<enum name="SideSearchAvailabilityChangeType"> + <int value="0" label="Become available"/> + <int value="1" label="Become unavailable"/> +</enum> + +<enum name="SideSearchCloseActionType"> + <int value="0" label="Tap on side search toolbar button"/> + <int value="1" label="Tap on side search close button"/> +</enum> + +<enum name="SideSearchNavigationType"> + <int value="0" label="Navigation committed within side search"/> + <int value="1" label="Redirection to tab"/> +</enum> + +<enum name="SideSearchOpenActionType"> + <int value="0" label="Tap on side search toolbar button"/> +</enum> + <enum name="SignedExchangeLoadResult"> <int value="0" label="Loaded successfully"/> <int value="1" label="Served from non-secure origin"/> @@ -76625,7 +78266,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="0" label="History push state or replace state"/> <int value="1" label="Same document backward or forward"/> <int value="2" label="Other fragment navigation"/> - <int value="3" label="AppHistory navigate event respondWith"/> + <int value="3" label="AppHistory navigate event transitionWhile"/> </enum> <enum name="SiteEngagementLevel"> @@ -76721,6 +78362,12 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="4" label="Response allowed after sniffing"/> </enum> +<enum name="SiteLayout"> + <summary>See Android.RequestDesktopSite.Changed</summary> + <int value="0" label="Mobile"/> + <int value="1" label="Desktop"/> +</enum> + <enum name="SkiaFilterQuality"> <int value="0" label="None"/> <int value="1" label="Low"/> @@ -77162,7 +78809,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <enum name="SourceForRefreshTokenOperation"> <int value="0" label="Unknown"/> <int value="1" label="TokenService::LoadCredentials"/> - <int value="2" label="DeprecatedSupervisedUser::InitSync"/> + <int value="2" label="SupervisedUser::InitSync (obsolete)"/> <int value="3" label="InlineLoginHandler::Signin"/> <int value="4" label="PrimaryAccountManager::ClearPrimaryAccount"/> <int value="5" label="PrimaryAccountManager::LegacyPreDiceSigninFlow"/> @@ -77178,7 +78825,10 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="15" label="DiceTurnOnSyncHelper::Abort"/> <int value="16" label="MachineLogon::CredentialProvider"/> <int value="17" label="TokenService::ExtractCredentials"/> - <int value="18" label="AccountReconcilor::RevokeTokensNotInCookies"/> + <int value="18" + label="AccountReconcilor::RevokeTokensNotInCookies (obsolete)"> + Used for force migration to DICE. Removed in M96. + </int> <int value="19" label="LogoutTabHelper::DidFinishNavigation"/> </enum> @@ -77205,6 +78855,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf have WebContents without an associated renderer process - see https://crbug.com/840409). </int> + <int value="6" label="RefusedForPdfContent"/> </enum> <enum name="SpareWebContentsStatus"> @@ -78748,6 +80399,8 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="10" label="Failed event parse error"/> <int value="11" label="Failed event write error"/> <int value="12" label="Failed event serialization"/> + <int value="13" label="Uninitialized recorder"/> + <int value="14" label="Invalid event parsed"/> </enum> <enum name="StructuredMetricsKeyValidationState"> @@ -78945,6 +80598,7 @@ https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf <int value="2" label="Memory quota exceeded"/> <int value="3" label="Serving constraints not met"/> <int value="4" label="Web Bundle fetch failed"/> + <int value="5" label="Web Bundle request was redirected"/> </enum> <enum name="SuccessTimeoutStarted"> @@ -79093,6 +80747,18 @@ would be helpful to identify which type is being sent. <int value="25" label="Incognito-mode clear browsing data"/> <int value="26" label="Close Incognito windows"/> <int value="27" label="Play Chrome Dino game"/> + <int value="28" label="Find my phone"/> + <int value="29" label="Manage Google privacy"/> + <int value="30" label="Manage Google ad settings"/> + <int value="31" label="Manage Chrome settings"/> + <int value="32" label="Manage Chrome downloads"/> + <int value="33" label="View Chrome history"/> + <int value="34" label="Share this page"/> + <int value="35" label="Manage Chrome accessibility"/> + <int value="36" label="Customize Chrome fonts"/> + <int value="37" label="Manage Chrome themes"/> + <int value="38" label="Customize search engines"/> + <int value="39" label="Manage ChromeOS accessibility"/> </enum> <enum name="SuggestionsResponseState"> @@ -79227,41 +80893,41 @@ would be helpful to identify which type is being sent. <int value="299" label="OTHER_ALLOWED_UNKNOWN"> Other navigation; Allowed by default (safety state unknown) </int> - <int value="300" label="LINK_BLOCKED_BLACKLIST"> - Link; Blocked by static blacklist + <int value="300" label="LINK_BLOCKED_DENYLIST"> + Link; Blocked by static denylist </int> - <int value="301" label="TYPED_BLOCKED_BLACKLIST"> - Typed URL; Blocked by static blacklist + <int value="301" label="TYPED_BLOCKED_DENYLIST"> + Typed URL; Blocked by static denylist </int> - <int value="302" label="AUTO_BOOKMARK_BLOCKED_BLACKLIST"> - Bookmark; Blocked by static blacklist + <int value="302" label="AUTO_BOOKMARK_BLOCKED_DENYLIST"> + Bookmark; Blocked by static denylist </int> - <int value="303" label="AUTO_SUBFRAME_BLOCKED_BLACKLIST"> - Subframe navigation; Blocked by static blacklist + <int value="303" label="AUTO_SUBFRAME_BLOCKED_DENYLIST"> + Subframe navigation; Blocked by static denylist </int> - <int value="304" label="MANUAL_SUBFRAME_BLOCKED_BLACKLIST"> - Manual subframe navigation; Blocked by static blacklist + <int value="304" label="MANUAL_SUBFRAME_BLOCKED_DENYLIST"> + Manual subframe navigation; Blocked by static denylist </int> - <int value="305" label="GENERATED_BLOCKED_BLACKLIST"> - Generated from Omnibox; Blocked by static blacklist + <int value="305" label="GENERATED_BLOCKED_DENYLIST"> + Generated from Omnibox; Blocked by static denylist </int> - <int value="306" label="AUTO_TOPLEVEL_BLOCKED_BLACKLIST"> - Automatic toplevel navigation; Blocked by static blacklist + <int value="306" label="AUTO_TOPLEVEL_BLOCKED_DENYLIST"> + Automatic toplevel navigation; Blocked by static denylist </int> - <int value="307" label="FORM_SUBMIT_BLOCKED_BLACKLIST"> - Form submission; Blocked by static blacklist + <int value="307" label="FORM_SUBMIT_BLOCKED_DENYLIST"> + Form submission; Blocked by static denylist </int> - <int value="308" label="RELOAD_BLOCKED_BLACKLIST"> - Reload; Blocked by static blacklist + <int value="308" label="RELOAD_BLOCKED_DENYLIST"> + Reload; Blocked by static denylist </int> - <int value="309" label="KEYWORD_BLOCKED_BLACKLIST"> - Omnibox keyword; Blocked by static blacklist + <int value="309" label="KEYWORD_BLOCKED_DENYLIST"> + Omnibox keyword; Blocked by static denylist </int> - <int value="310" label="KEYWORD_GENERATED_BLOCKED_BLACKLIST"> - URL generated from Omnibox keyword; Blocked by static blacklist + <int value="310" label="KEYWORD_GENERATED_BLOCKED_DENYLIST"> + URL generated from Omnibox keyword; Blocked by static denylist </int> - <int value="399" label="OTHER_BLOCKED_BLACKLIST"> - Other navigation; Blocked by static blacklist + <int value="399" label="OTHER_BLOCKED_DENYLIST"> + Other navigation; Blocked by static denylist </int> <int value="400" label="LINK_BLOCKED_SAFESITES"> Link; Blocked by SafeSites @@ -79371,41 +81037,41 @@ would be helpful to identify which type is being sent. <int value="699" label="OTHER_BLOCKED_DEFAULT"> Other navigation; Blocked by global settings </int> - <int value="700" label="LINK_ALLOWED_WHITELIST"> - Link; Allowed by whitelist + <int value="700" label="LINK_ALLOWED_ALLOWLIST"> + Link; Allowed by allowlist </int> - <int value="701" label="TYPED_ALLOWED_WHITELIST"> - Typed URL; Allowed by whitelist + <int value="701" label="TYPED_ALLOWED_ALLOWLIST"> + Typed URL; Allowed by allowlist </int> - <int value="702" label="AUTO_BOOKMARK_ALLOWED_WHITELIST"> - Bookmark; Allowed by whitelist + <int value="702" label="AUTO_BOOKMARK_ALLOWED_ALLOWLIST"> + Bookmark; Allowed by allowlist </int> - <int value="703" label="AUTO_SUBFRAME_ALLOWED_WHITELIST"> - Subframe navigation; Allowed by whitelist + <int value="703" label="AUTO_SUBFRAME_ALLOWED_ALLOWLIST"> + Subframe navigation; Allowed by allowlist </int> - <int value="704" label="MANUAL_SUBFRAME_ALLOWED_WHITELIST"> - Manual subframe navigation; Allowed by whitelist + <int value="704" label="MANUAL_SUBFRAME_ALLOWED_ALLOWLIST"> + Manual subframe navigation; Allowed by allowlist </int> - <int value="705" label="GENERATED_ALLOWED_WHITELIST"> - Generated from Omnibox; Allowed by whitelist + <int value="705" label="GENERATED_ALLOWED_ALLOWLIST"> + Generated from Omnibox; Allowed by allowlist </int> - <int value="706" label="AUTO_TOPLEVEL_ALLOWED_WHITELIST"> - Automatic toplevel navigation; Allowed by whitelist + <int value="706" label="AUTO_TOPLEVEL_ALLOWED_ALLOWLIST"> + Automatic toplevel navigation; Allowed by allowlist </int> - <int value="707" label="FORM_SUBMIT_ALLOWED_WHITELIST"> - Form submission; Allowed by whitelist + <int value="707" label="FORM_SUBMIT_ALLOWED_ALLOWLIST"> + Form submission; Allowed by allowlist </int> - <int value="708" label="RELOAD_ALLOWED_WHITELIST"> - Reload; Allowed by whitelist + <int value="708" label="RELOAD_ALLOWED_ALLOWLIST"> + Reload; Allowed by allowlist </int> - <int value="709" label="KEYWORD_ALLOWED_WHITELIST"> - Omnibox keyword; Allowed by whitelist + <int value="709" label="KEYWORD_ALLOWED_ALLOWLIST"> + Omnibox keyword; Allowed by allowlist </int> - <int value="710" label="KEYWORD_GENERATED_ALLOWED_WHITELIST"> - URL generated from Omnibox keyword; Allowed by whitelist + <int value="710" label="KEYWORD_GENERATED_ALLOWED_ALLOWLIST"> + URL generated from Omnibox keyword; Allowed by allowlist </int> - <int value="799" label="OTHER_ALLOWED_WHITELIST"> - Other navigation; Allowed by whitelist + <int value="799" label="OTHER_ALLOWED_ALLOWLIST"> + Other navigation; Allowed by allowlist </int> </enum> @@ -79458,6 +81124,27 @@ would be helpful to identify which type is being sent. <int value="8" label="First time user"/> </enum> +<enum name="SurveyPresentationStatusCode"> + <summary> + Results when survey has been download and requested to be shown. Used by + Android.Survey.ShowSurveyStatus. + </summary> + <int value="0" label="Success"/> + <int value="1" label="Account changed or signed out"/> + <int value="2" label="Survey container was invalid"/> + <int value="3" label="Survey data was unavailable"/> + <int value="4" label="Client activity was destroyed"/> + <int value="5" label="Client activity was finishing"/> + <int value="6" label="Client activity was invalid"/> + <int value="7" label="Survey completion style was invalid"/> + <int value="8" label="Survey prompt style was invalid"/> + <int value="9" label="Survey data type was invalid"/> + <int value="10" label="Survey payload was invalid"/> + <int value="11" label="Survey was already running"/> + <int value="12" label="Survey had expired"/> + <int value="13" label="Unknown reason for failure"/> +</enum> + <enum name="SuspendAttempt"> <int value="0" label="Attempted"/> </enum> @@ -79795,12 +81482,6 @@ would be helpful to identify which type is being sent. <int value="22" label="SYNCER_OK"/> </enum> -<enum name="SyncErrorInfoBarAction"> - <int value="0" label="Shown"/> - <int value="1" label="Dismissed"/> - <int value="2" label="Button clicked"/> -</enum> - <enum name="SyncErrorInfobarTypes"> <summary>Possible errors that can trigger a sync error infobar.</summary> <int value="1" label="Sign in needs update"/> @@ -79812,6 +81493,12 @@ would be helpful to identify which type is being sent. <int value="7" label="Sync trusted vault recoverability degraded"/> </enum> +<enum name="SyncErrorPromptUIAction"> + <int value="0" label="Shown"/> + <int value="1" label="Dismissed"/> + <int value="2" label="Button clicked"/> +</enum> + <!-- This must be kept current with //components/sync/protocol/sync_enums.proto's ErrorType. --> @@ -80575,6 +82262,11 @@ would be helpful to identify which type is being sent. label="Opened a recently closed item from a filtered item list"/> </enum> +<enum name="TabSearchRecentlyClosedToggleActions"> + <int value="0" label="Expand the recently closed items section"/> + <int value="1" label="Collapse the recently closed items section"/> +</enum> + <enum name="TabSearchTabSwitchAction"> <int value="0" label="Switch to tab from unfiltered tab list"/> <int value="1" label="Switch to tab from filtered search tab list"/> @@ -80706,6 +82398,9 @@ would be helpful to identify which type is being sent. </enum> <enum name="TempFileFailure"> + <obsolete> + Removed in M95. + </obsolete> <int value="0" label="Creating"/> <int value="1" label="Opening (obsolete)"/> <int value="2" label="Closing (obsolete)"/> @@ -82091,6 +83786,387 @@ Full version information for the fingerprint enum values: <int value="32" label="kMediaCdmOriginData"/> </enum> +<enum name="TrafficAnnotationUniqueIdHash"> +<!-- Generated from tools/traffic_annotation/summary/annotations.xml. The traffic annotation audiotor doesn't check if the following entries are in sync with annotations.xml. TODO(crbug.com/1232623): Remove this enum once the field investigation is concluded. --> + + <int value="485305" label="data_reduction_proxy_config"/> + <int value="516551" label="socket_bio_adapter"/> + <int value="727478" label="metrics_report_ukm"/> + <int value="727528" label="metrics_report_uma"/> + <int value="1112842" label="oauth2_mint_token_flow"/> + <int value="1313982" label="safe_browsing_client_side_phishing_detector"/> + <int value="3464399" label="cablev2_websocket_from_client"/> + <int value="3556498" label="test"/> + <int value="3646641" label="ocsp_start_url_loader"/> + <int value="3989826" label="dom_distiller"/> + <int value="4300475" label="gaia_cookie_manager_external_cc_result"/> + <int value="4306022" label="safe_browsing_binary_upload_app"/> + <int value="4598626" label="gaia_auth_check_connection_info"/> + <int value="4883150" label="heartbeat_sender"/> + <int value="4986170" label="ui_devtools_server"/> + <int value="5021348" label="sync_stop_reporter"/> + <int value="5151071" label="extension_manifest_fetcher"/> + <int value="5154306" label="blob_reader"/> + <int value="5492492" label="google_url_tracker"/> + <int value="5576536" label="cast_udp_transport"/> + <int value="5637379" label="gaia_oauth_client_get_tokens"/> + <int value="6019475" label="safe_browsing_module_loader"/> + <int value="6055066" label="omnibox_documentsuggest"/> + <int value="6483617" label="origin_policy_loader"/> + <int value="7433837" label="refresh_token_annotation_request"/> + <int value="7687691" label="omnibox_zerosuggest"/> + <int value="7754485" label="backdrop_next_image_download"/> + <int value="8250451" label="data_reduction_proxy_warmup"/> + <int value="8561691" label="safe_browsing_v4_get_hash"/> + <int value="8591273" label="chrome_apps_socket_api"/> + <int value="9229948" label="prefetch_proxy_canary_check"/> + <int value="9459438" label="external_policy_fetcher"/> + <int value="10243490" label="query_tiles_fetcher"/> + <int value="10498172" label="per_user_topic_registration_request"/> + <int value="11258689" label="proxy_config_system"/> + <int value="13211343" label="suggestions_image_manager"/> + <int value="13694792" label="desktop_ios_promotion"/> + <int value="13704791" label="floc_remote_permission_service"/> + <int value="13924805" label="proxy_config_windows_resolver"/> + <int value="14257952" label="supervised_user_url_filter"/> + <int value="15418154" label="ntp_snippets_fetch"/> + <int value="15952025" label="dial_get_app_info"/> + <int value="16469669" label="background_fetch_context"/> + <int value="16653985" label="content_suggestion_get_favicon"/> + <int value="16927377" label="lookup_single_password_leak"/> + <int value="17188928" label="websocket_stream"/> + <int value="17400350" label="web_history_query"/> + <int value="17562717" label="history_ui_favicon_request_handler_get_favicon"/> + <int value="18300705" label="gcm_channel_status_request"/> + <int value="18764319" label="webstore_installer"/> + <int value="18870110" label="desktop_screenshot_save"/> + <int value="19185953" label="offline_prefetch"/> + <int value="20053290" label="cryptauth_find_eligible_for_promotion"/> + <int value="20153177" label="quic_chromium_packet_writer"/> + <int value="21145003" label="extension_crx_fetcher"/> + <int value="21498113" label="service_worker_script_load"/> + <int value="21785164" label="intranet_redirect_detector"/> + <int value="22096011" label="test_partial"/> + <int value="22262963" label="enterprise_safe_browsing_realtime_url_lookup"/> + <int value="22265491" label="user_info_fetcher"/> + <int value="22573197" label="cast_udp_socket"/> + <int value="22774132" label="devtools_free_data_source"/> + <int value="23036184" label="openscreen_message"/> + <int value="23472048" label="network_location_provider"/> + <int value="23527666" label="send_message_express"/> + <int value="23537266" label="expect_ct_reporter"/> + <int value="24058523" label="CRD_relay_session_request"/> + <int value="24186190" label="webrtc_event_log_uploader"/> + <int value="25204343" label="cryptauth_toggle_easyunlock"/> + <int value="25790702" label="appcache_update_job"/> + <int value="25844439" label="render_view_context_menu"/> + <int value="25921771" label="webstore_install_helper"/> + <int value="26096088" label="speech_recognition_downstream"/> + <int value="26216847" label="gaia_auth_merge_sessions"/> + <int value="26302604" label="webstore_data_fetcher"/> + <int value="26372521" label="sync_attachment_downloader"/> + <int value="27071967" label="chrome_cleaner"/> + <int value="27833508" label="auction_downloader"/> + <int value="27915688" label="oauth2_access_token_fetcher"/> + <int value="28613769" label="cablev2_websocket_from_authenticator"/> + <int value="29057242" label="gcm_connection_factory"/> + <int value="29061438" label="file_system_connector_to_box"/> + <int value="29188932" label="oauth2_api_call_flow"/> + <int value="29506140" label="receive_messages_express"/> + <int value="29865866" label="headless_url_request"/> + <int value="30516662" label="trusted_vault_request"/> + <int value="30656793" label="nearby_share_update_device"/> + <int value="30913825" label="family_info"/> + <int value="31074955" label="security_key_socket"/> + <int value="31445884" label="gaia_auth_multilogin"/> + <int value="32030464" label="persist_blob_to_indexed_db"/> + <int value="32197336" label="http_server_error_response"/> + <int value="32472991" label="direct_sockets"/> + <int value="32585152" label="gaia_oauth_client_get_token_info"/> + <int value="33703614" label="previews_litepage_origin_prober"/> + <int value="33813109" label="previews_litepage_prober"/> + <int value="34459548" label="puch_client_channel"/> + <int value="34557599" label="hintsfetcher_gethintsrequest"/> + <int value="34767164" label="backdrop_collection_images_download"/> + <int value="35266994" label="early_hints_preload"/> + <int value="35370363" label="suggestions_service"/> + <int value="35380758" label="download_manager_resume"/> + <int value="35473769" label="logo_service"/> + <int value="35565745" label="gaia_auth_list_accounts"/> + <int value="35725390" label="https_server_previews_navigation"/> + <int value="36859107" label="logo_tracker"/> + <int value="36915753" label="spdy_push_stream"/> + <int value="36944304" label="sanitized_image_source"/> + <int value="37249086" label="android_device_manager_socket"/> + <int value="37531401" label="proxy_script_fetcher"/> + <int value="37994740" label="nearby_webrtc_connection"/> + <int value="38197513" label="stream_packet_socket"/> + <int value="38256901" label="ftl_registration_manager"/> + <int value="38670228" label="download_internals_webui_source"/> + <int value="39356976" label="android_web_socket"/> + <int value="39877119" label="gaia_auth_exchange_device_id"/> + <int value="39886742" label="web_push_message"/> + <int value="40127335" label="openscreen_tls_message"/> + <int value="41010697" label="previews_prober"/> + <int value="41154842" label="doodle_service"/> + <int value="41424546" label="dial_url_fetcher"/> + <int value="41749213" label="web_history_delete_url"/> + <int value="41799176" label="memories_remote_model_request"/> + <int value="42848942" label="safe_browsing_extended_reporting"/> + <int value="43206794" label="permission_request_creator"/> + <int value="43759504" label="unwanted_software_report"/> + <int value="44494884" label="icon_catcher_get_large_icon"/> + <int value="44551896" label="chrome_cart_discounts_lookup"/> + <int value="44583172" label="prefetch_download"/> + <int value="44583821" label="safe_browsing_feedback"/> + <int value="45578882" label="undefined"/> + <int value="46188932" label="network_time_component"/> + <int value="47152935" label="sdch_dictionary_fetch"/> + <int value="47815025" label="omnibox_suggest"/> + <int value="48603483" label="sct_auditing"/> + <int value="48673144" label="new_tab_page_handler"/> + <int value="48924790" label="ftl_messaging_client_send_messages"/> + <int value="49160454" label="devtools_http_handler"/> + <int value="49246286" label="backdrop_collection_names_download"/> + <int value="49544361" label="remote_suggestions_provider"/> + <int value="49601082" label="plugins_resource_service"/> + <int value="50422598" label="dial_get_device_description"/> + <int value="50464499" label="extension_install_signer"/> + <int value="50755044" label="popular_sites_fetch"/> + <int value="50808258" label="task_module_service"/> + <int value="50816767" label="lib_address_input"/> + <int value="50859288" label="cloud_print_proxy"/> + <int value="50910588" label="litepages_robots_rules"/> + <int value="51164680" label="profile_avatar"/> + <int value="51586722" label="websocket_basic_stream"/> + <int value="52821843" label="geo_language_provider"/> + <int value="53512439" label="pepper_udp_socket"/> + <int value="53695122" label="credenential_avatar"/> + <int value="54836939" label="cryptauth_enrollment_flow_finish"/> + <int value="54845618" label="update_client"/> + <int value="55663676" label="ftl_messaging_client_ack_messages"/> + <int value="56074781" label="drive_service"/> + <int value="56275203" label="save_file_manager"/> + <int value="56351037" label="download_web_contents_frame"/> + <int value="56434025" label="gcm_subscription"/> + <int value="56866367" label="pdf_plugin_placeholder"/> + <int value="57114284" label="sigined_exchange_validity_pinger"/> + <int value="57143548" label="spdy_session_control"/> + <int value="57144960" label="sync_http_bridge"/> + <int value="57748571" label="affiliation_lookup_by_hash"/> + <int value="57773453" label="navigation_predictor_srp_prefetch"/> + <int value="57785193" label="search_suggest_service"/> + <int value="58596544" label="chrome_cart_get_discounted_link"/> + <int value="59302801" label="services_http_server_error_response"/> + <int value="59568147" label="safe_browsing_binary_upload_connector"/> + <int value="59592717" label="extension_blacklist"/> + <int value="60071001" label="net_error_helper"/> + <int value="60744935" label="devtools_cdp_network_resource"/> + <int value="60921996" label="ocsp_start_url_request"/> + <int value="60946824" label="web_history_expire"/> + <int value="61001455" label="cloud_speech_recognition"/> + <int value="61656965" label="gcm_registration"/> + <int value="61684939" label="omnibox_navigation_observer"/> + <int value="61695471" label="open_screen_tls_message"/> + <int value="62443804" label="webrtc_log_upload"/> + <int value="63171670" label="navigation_url_loader"/> + <int value="63497370" label="webrtc_peer_connection"/> + <int value="64733114" label="content_hash_verification_job"/> + <int value="65957842" label="gcm_checkin"/> + <int value="66322287" label="password_protection_request"/> + <int value="66590631" label="safe_browsing_certificate_error_reporting"/> + <int value="66846958" label="speech_recognition_upstream"/> + <int value="67052219" label="promo_service"/> + <int value="67117364" label="remoting_register_support_host_request"/> + <int value="67638271" label="printer_job_handler"/> + <int value="67750043" label="gaia_create_reauth_proof_token_for_parent"/> + <int value="68561428" label="data_reduction_proxy_pingback"/> + <int value="68745894" label="safe_browsing_get_full_hash"/> + <int value="69585116" label="password_requirements_spec_fetch"/> + <int value="69879956" label="video_tutorial_fetcher"/> + <int value="70796791" label="content_resource_fetcher"/> + <int value="71102679" label="chrome_cleanup_report"/> + <int value="71578042" label="cloud_print_backend"/> + <int value="71663319" label="safe_browsing_binary_upload"/> + <int value="71837756" label="stream_message_pipe_adapter"/> + <int value="72087791" label="worker_script_load"/> + <int value="72157052" label="predictive_prefetch"/> + <int value="72354423" label="invalidation_service"/> + <int value="73107389" label="omnibox_result_change"/> + <int value="73309970" label="payment_instrument_icon_fetcher"/> + <int value="77012883" label="missing"/> + <int value="77597059" label="domain_security_policy"/> + <int value="77673751" label="device_geolocation_request"/> + <int value="77734467" label="managed_configuration_loader"/> + <int value="78408551" label="ntp_custom_link_checker_request"/> + <int value="78447809" label="mirroring_get_setup_info"/> + <int value="78479125" label="notification_client"/> + <int value="78544924" label="supervised_users_blacklist"/> + <int value="78917933" label="one_google_bar_service"/> + <int value="79227717" label="dns_transaction"/> + <int value="79442849" label="sigined_exchange_cert_fetcher"/> + <int value="79895226" label="dns_over_https"/> + <int value="79904729" label="devtools_proxy_config"/> + <int value="79957943" label="safe_browsing_chunk_backup_request"/> + <int value="80134684" label="certificate_verifier_url_loader"/> + <int value="80255301" label="remote_copy_message_handler"/> + <int value="80832574" label="history_notice_utils_popup"/> + <int value="81157007" label="resource_dispatcher_host"/> + <int value="82167736" label="gaia_auth_get_user_info"/> + <int value="82462683" label="gaia_oauth_client_refresh_token"/> + <int value="82509217" label="safe_browsing_v4_update"/> + <int value="83476155" label="gaia_oauth_client_get_user_info"/> + <int value="84045030" label="payment_manifest_downloader"/> + <int value="84165821" label="blink_extension_resource_loader"/> + <int value="84212388" label="omnibox_suggest_deletion"/> + <int value="84575287" label="background_performance_tracer"/> + <int value="84889397" label="cryptauth_enrollment_flow_setup"/> + <int value="85742023" label="interest_feedv2_send"/> + <int value="85988208" label="certificate_verifier_url_request"/> + <int value="86015226" label="floc_event_logger"/> + <int value="87437888" label="gaia_oauth_client_get_account_capabilities"/> + <int value="87439531" label="feed_image_fetcher"/> + <int value="87558948" label="cast_message_handler"/> + <int value="87635401" label="quic_chromium_incoming_session"/> + <int value="87775794" label="adb_client_socket"/> + <int value="87963126" label="qr_code_save"/> + <int value="88754904" label="captive_portal_service"/> + <int value="88863520" label="autofill_query"/> + <int value="88906454" label="xmpp_signal_strategy"/> + <int value="88945310" label="remoting_ice_config_request"/> + <int value="89093734" label="remoting_directory_delete_host"/> + <int value="89492280" label="permission_predictions"/> + <int value="90263263" label="box_access_token_fetcher"/> + <int value="90561372" label="autofill_image_fetcher_card_art_image"/> + <int value="91068704" label="prefetch_visuals"/> + <int value="91597383" label="gaia_auth_login"/> + <int value="91999155" label="nearby_share_contacts"/> + <int value="92125886" label="ntp_custom_background"/> + <int value="92245202" label="interest_feedv2_image_send"/> + <int value="93232258" label="mojo_context_state"/> + <int value="93434368" label="remoting_directory_get_host_list"/> + <int value="94099818" label="bluetooth_socket"/> + <int value="95075845" label="port_forwarding_controller_socket"/> + <int value="95103115" label="query_tiles_image_loader"/> + <int value="95250780" label="open_screen_message"/> + <int value="95588446" label="payments_sync_cards"/> + <int value="95682324" label="ranker_url_fetcher"/> + <int value="95711309" label="ntp_contextual_suggestions_fetch"/> + <int value="95910019" label="drag_download_file"/> + <int value="95951029" label="downloads_dom_handler"/> + <int value="95983790" label="media_router_global_media_controls_image"/> + <int value="96136865" label="auction_report_sender"/> + <int value="96565489" label="cryptauth_device_sync_tickle"/> + <int value="96590038" label="network_location_request"/> + <int value="97159948" label="browser_switcher_ieem_sitelist"/> + <int value="97199008" label="doodle_fetcher"/> + <int value="97978464" label="gaia_auth_fetch_for_uber"/> + <int value="98123737" label="devtools_interceptor"/> + <int value="98658519" label="accounts_image_fetcher"/> + <int value="99279418" label="rlz_ping"/> + <int value="99742369" label="remoting_log_to_server"/> + <int value="100143055" label="optimization_guide_model_download"/> + <int value="100545943" label="webui_content_scripts_download"/> + <int value="100936478" label="photos_service"/> + <int value="101725581" label="cros_recovery_image_download"/> + <int value="101845102" label="blink_resource_loader"/> + <int value="102595701" label="history_notice_utils_notice"/> + <int value="102819690" label="sync_file_system"/> + <int value="102935425" label="safe_browsing_client_side_malware_detector"/> + <int value="103052331" label="floc_id_provider_impl"/> + <int value="103133150" label="icon_cacher"/> + <int value="103172229" label="cast_channel_send"/> + <int value="104798869" label="autofill_upload"/> + <int value="105330607" label="profile_resetter_upload"/> + <int value="105985951" label="gcd_rest_client"/> + <int value="106124561" label="ssl_hmac_channel_authenticator"/> + <int value="106373593" label="optimization_guide_model"/> + <int value="106980485" label="safe_browsing_backup_request"/> + <int value="107267424" label="open_search"/> + <int value="107268760" label="remoting_telemetry_log_writer"/> + <int value="107881858" label="image_annotation"/> + <int value="108665132" label="bidirectional_stream"/> + <int value="108804096" label="domain_reliability_report_upload"/> + <int value="108903331" label="signed_in_profile_avatar"/> + <int value="108986091" label="search_prefetch_service"/> + <int value="109607776" label="javascript_report_error"/> + <int value="109679553" label="brandcode_config"/> + <int value="109891200" label="reporting"/> + <int value="109987793" label="kids_chrome_management_client_classify_url"/> + <int value="110307337" label="web_history_service"/> + <int value="110815970" label="resource_prefetch"/> + <int value="110915076" label="interest_group_update_fetcher"/> + <int value="111565057" label="devtools_hard_coded_data_source"/> + <int value="111712433" label="cloud_print"/> + <int value="111904019" label="affiliation_lookup"/> + <int value="112189210" label="favicon_loader"/> + <int value="112303907" label="blob_read"/> + <int value="113005423" label="webid"/> + <int value="113065062" label="tethering_handler_socket"/> + <int value="113231892" label="url_fetcher_downloader"/> + <int value="113422320" label="conversion_measurement_report"/> + <int value="114468207" label="ssl_name_mismatch_lookup"/> + <int value="114615359" label="web_bundle_loader"/> + <int value="115188287" label="chrome_variations_service"/> + <int value="115192205" label="cast_socket"/> + <int value="115907811" label="safe_browsing_cache_collector"/> + <int value="116426676" label="gaia_auth_log_out"/> + <int value="116443055" label="renderer_initiated_download"/> + <int value="117649486" label="spellcheck_hunspell_dictionary"/> + <int value="117688925" label="remoting_directory_register_host"/> + <int value="117782019" label="device_management_service"/> + <int value="118389509" label="url_prevision_fetcher"/> + <int value="119015679" label="proxy_config_direct"/> + <int value="119210936" label="prefetch_proxy_loader"/> + <int value="119324658" label="safe_browsing_realtime_url_lookup"/> + <int value="119416099" label="load_autofill_gstatic_data"/> + <int value="119542033" label="gcm_unregistration"/> + <int value="120000562" label="cryptauth_find_eligible_unlock_devices"/> + <int value="120623198" label="pepper_tcp_socket"/> + <int value="120830730" label="quic_chromium_incoming_pending_session"/> + <int value="121068967" label="downloads_api_run_async"/> + <int value="123387409" label="prefetch_proxy_probe"/> + <int value="123714070" label="nearby_share_list_public_certificates"/> + <int value="124847649" label="nux_ntp_background_preview"/> + <int value="124950347" label="safe_browsing_incident"/> + <int value="125522256" label="client_download_request"/> + <int value="126122632" label="web_history_expire_between_dates"/> + <int value="127739401" label="whats_new_handler"/> + <int value="128608592" label="web_app_origin_association_download"/> + <int value="129652775" label="devtools_network_resource"/> + <int value="129872904" label="service_worker_navigation_preload"/> + <int value="130931413" label="service_worker_update_checker"/> + <int value="131180348" label="indexed_db_internals_handler"/> + <int value="131236802" label="data_reduction_proxy_secure_proxy_check"/> + <int value="131711536" label="download_recovery_component"/> + <int value="131741641" label="permission_reporting"/> + <int value="132553989" label="spellcheck_lookup"/> + <int value="132657055" label="sync_attachment_uploader"/> + <int value="133221587" label="proxy_config_headless"/> + <int value="133982351" label="gaia_auth_revoke_token"/> + <int value="134272131" label="digital_asset_links"/> + <int value="134289752" label="gaia_auth_exchange_cookies"/> + <int value="134618785" label="well_known_path_that_should_not_exist"/> + <int value="134729048" label="chrome_feedback_report_app"/> + <int value="134755844" label="cast_keep_alive_delegate"/> + <int value="135118587" label="parallel_download_job"/> + <int value="135251783" label="thumbnail_source"/> + <int value="135636011" label="devtools_handle_front_end_messages"/> + <int value="135799714" label="gstatic_change_password_override_urls"/> + <int value="135967426" label="ppapi_download_request"/> + <int value="136028241" label="chrome_HaTS_service"/> + <int value="136117054" label="supervised_user_refresh_token_fetcher"/> + <int value="136248372" label="ftl_messaging_client_receive_messages"/> + <int value="136386805" label="safe_search_service"/> + <int value="136468456" label="proxy_config_settings"/> + <int value="136498680" label="cryptauth_get_my_devices"/> + <int value="137093034" label="ice_config_fetcher"/> + <int value="137116619" label="translate_url_fetcher"/> + <int value="137420486" label="cloud_print_credential_update"/> + <int value="137457845" label="web_history_counter"/> + <int value="137724067" label="safety_check_update_connectivity"/> +</enum> + <enum name="TranslateAssistContentResult"> <int value="0" label="The feature was disabled"/> <int value="1" label="The tab was null"/> @@ -82223,6 +84299,7 @@ Full version information for the fingerprint enum values: <int value="22" label="Identical language translation, use source language Unknown"/> <int value="23" label="Disabled because Autofill Assistant is running."/> + <int value="24" label="Auto translation for predefined target language"/> </enum> <enum name="TranslateLanguage"> @@ -82430,6 +84507,13 @@ Full version information for the fingerprint enum values: <int value="80" label="TRIM_MEMORY_COMPLETE"/> </enum> +<enum name="TruncatingCharacterInCookieStringType"> + <int value="0" label="No truncating character"/> + <int value="1" label="NULL (\x0)"/> + <int value="2" label="New Line (\xD)"/> + <int value="3" label="Line Feed (\xA)"/> +</enum> + <enum name="TrustedVaultDeviceRegistrationState"> <int value="0" label="Already registered"/> <int value="1" label="Local keys are stale"/> @@ -82694,8 +84778,8 @@ Full version information for the fingerprint enum values: <enum name="UnderlayDamageRect"> <int value="0" label="Zero Damage Rect"/> - <int value="1" label="Non-Occluding Damage Only (deprecated)"/> - <int value="2" label="Occluding Damage Only"/> + <int value="1" label="Non-Occluding Damage Only"/> + <int value="2" label="Occluding Damage Only (Deprecated)"/> <int value="3" label="Occluding and Non-Occluding Damages"/> </enum> @@ -82784,6 +84868,12 @@ Full version information for the fingerprint enum values: <int value="3" label="Challenge-response security token"/> </enum> +<enum name="UNNotificationPermissionRequestResult"> + <int value="0" label="Permission request failed"/> + <int value="1" label="Permission denied"/> + <int value="2" label="Permission granted"/> +</enum> + <enum name="UNNotificationPermissionStatus"> <int value="0" label="Permission not requested yet"/> <int value="1" label="Permission denied"/> @@ -83150,6 +85240,29 @@ Full version information for the fingerprint enum values: <int value="1" label="Upload was offered for newly-seen card"/> </enum> +<enum name="URLHostEscapedChar"> + <int value="0" label="Unknown"/> + <int value="1" label="Space"/> + <int value="2" label="Bang"/> + <int value="3" label="DoubleQuote"/> + <int value="4" label="Hash"/> + <int value="5" label="Dollar"/> + <int value="6" label="Ampersand"/> + <int value="7" label="SingleQuote"/> + <int value="8" label="LeftParen"/> + <int value="9" label="RightParen"/> + <int value="10" label="Asterisk"/> + <int value="11" label="Comma"/> + <int value="12" label="LeftAngle"/> + <int value="13" label="Equals"/> + <int value="14" label="RightAngle"/> + <int value="15" label="At"/> + <int value="16" label="BackTick"/> + <int value="17" label="LeftCurly"/> + <int value="18" label="Pipe"/> + <int value="19" label="RightCurly"/> +</enum> + <enum name="URLRequestAnnotationType"> <!-- Not updated since 3/4/2018 as histogram is obsolete.--> @@ -83535,6 +85648,12 @@ Full version information for the fingerprint enum values: <int value="1" label="RequestMobile"/> </enum> +<enum name="UserAgentStringType"> + <int value="0" label="Full user agent string"/> + <int value="1" label="Reduced user agent string"/> + <int value="2" label="Overridden user agent string"/> +</enum> + <enum name="UserCertContentDisposition"> <int value="0" label="No Content-Disposition"/> <int value="1" label="Content-Disposition"/> @@ -83563,6 +85682,9 @@ Full version information for the fingerprint enum values: </enum> <enum name="UserDataMoveResult"> + <obsolete> + Removed from code in M96. + </obsolete> <int value="0" label="CreateTargetFailure"> Failed to create a temporary directory within User Data into which the contents are to be moved for subsequent deletion. @@ -83858,6 +85980,16 @@ Full version information for the fingerprint enum values: </int> </enum> +<enum name="V8CagedMemoryAllocationOutcome"> + <int value="0" label="kSuccess">Allocation succeeded inside the cage.</int> + <int value="1" label="kOutsideCage"> + Allocation failed inside the cage but succeeded outside of it. + </int> + <int value="2" label="kFailure"> + Allocation failed inside and outside of the cage. + </int> +</enum> + <enum name="V8CodeCacheRejectReason"> <int value="1" label="MAGIC_NUMBER_MISMATCH"> Reject due to magic number mismatch @@ -84057,6 +86189,19 @@ Full version information for the fingerprint enum values: <int value="5" label="Rejected: Is a Google domain, but not https."/> </enum> +<enum name="VariationsInvalidStudyReason"> + <int value="0" label="Invalid min_version"/> + <int value="1" label="Invalid max_version"/> + <int value="2" label="Invalid min_os_version"/> + <int value="3" label="Invalid max_os_version"/> + <int value="4" label="Experiment without a name"/> + <int value="5" label="Repeated experiment name"/> + <int value="6" label="Total probability overflow"/> + <int value="7" label="Missing experiment entry for default experient"/> + <int value="8" label="Missing study name"/> + <int value="9" label="Experiment probability overflow"/> +</enum> + <enum name="VariationsPermanentConsistencyCountryResult"> <int value="0" label="Saved pref missing and no country code in seed"/> <int value="1" label="Saved pref missing and country code in seed"/> @@ -84200,6 +86345,22 @@ Full version information for the fingerprint enum values: <int value="15" label="Non-Gzip Full Count"/> </enum> +<enum name="VariationsSeedUsage"> + <int value="0" label="Regular seed used"/> + <int value="1" label="Expired regular seed">No seed used</int> + <int value="2" label="Corrupted regular seed">No seed used</int> + <int value="3" label="Safe seed used"/> + <int value="4" label="Expired safe seed">No seed used</int> + <int value="5" label="Corrupted safe seed">No seed used</int> + <int value="6" label="Regular seed used after loading empty safe seed"/> + <int value="7" label="Expired regular seed after loading empty safe seed"> + No seed used + </int> + <int value="8" label="Corrupted regular seed after loading empty safe seed"> + No seed used + </int> +</enum> + <enum name="VaryType"> <int value="0" label="No Vary header present"/> <int value="1" label="Vary:User-Agent"/> @@ -84648,6 +86809,7 @@ Full version information for the fingerprint enum values: <int value="6" label="Finishing"/> <int value="7" label="No WebContents"/> <int value="8" label="(Obsolete) No video"/> + <int value="9" label="App tasks"/> </enum> <enum name="VideoPersistenceControlsType"> @@ -85113,6 +87275,12 @@ others/histograms.xml --> <int value="2" label="Third Party (CrOS)"/> <int value="3" label="Third Party (Android)"/> <int value="4" label="PPTP"/> + <int value="5" label="WireGuard"/> +</enum> + +<enum name="VPNL2TPIPsecTunnelGroupUsage"> + <int value="0" label="Tunnel group is not used"/> + <int value="1" label="Tunnel group is used"/> </enum> <enum name="VPNRemoteAuthenticationType"> @@ -85133,6 +87301,17 @@ others/histograms.xml --> <int value="6" label="L2TP/IPSec Username/Password"/> </enum> +<enum name="VPNWireGuardAllowedIPsType"> + <int value="0" label="0.0.0.0/0 is set in in at least one of the peers"/> + <int value="1" label="No peer contains 0.0.0.0/0 in its AllowedIPs"/> +</enum> + +<enum name="VPNWireGuardKeyPairSource"> + <int value="0" label="Unknown"/> + <int value="1" label="Input by user"/> + <int value="2" label="Generated inside shill"/> +</enum> + <enum name="VRAssetsComponentUpdateStatus"> <obsolete> Removed 06/2020. @@ -85436,6 +87615,7 @@ others/histograms.xml --> <int value="1668389814" label="Art"/> <int value="1804492839" label="Colors"/> <int value="1894705443" label="Leisure"/> + <int value="1914850019" label="Heritage"/> <int value="2084467495" label="Dessert time"/> <int value="2094027636" label="Solid colors"/> </enum> @@ -85466,8 +87646,11 @@ others/histograms.xml --> <int value="-2111482612" label="Solid Colors - 7593482887976204"/> <int value="-2110074118" label="Togetherness - 18444149073834070778"/> <int value="-2094648855" label="Solid Colors - 3931714047324649"/> + <int value="-2088281608" label="Heritage - 331011041221112"/> + <int value="-2079643564" label="Heritage - 18441528924770609236"/> <int value="-2075846537" label="Composition - 18446099444287215735"/> <int value="-2052639994" label="Landscapes - 3406001502368518"/> + <int value="-2036802440" label="Heritage - 18444825093169798264"/> <int value="-2034367398" label="Landscapes - 8363308608259162"/> <int value="-2028697222" label="Made by Canvas - 18438928296354023802"/> <int value="-2010890067" label="Cityscapes - 18441361086107369645"/> @@ -85478,6 +87661,7 @@ others/histograms.xml --> <int value="-1938230489" label="Element - 18440708087942279975"/> <int value="-1916450445" label="Art - 18446537445211457907"/> <int value="-1910580223" label="Solid Colors - 18444350009783540737"/> + <int value="-1890583571" label="Heritage - 8492875030461421"/> <int value="-1886552792" label="Art - 8008196565073192"/> <int value="-1879435782" label="Illustrations - 6677967891207674"/> <int value="-1878774587" label="Landscapes - 5675002833939653"/> @@ -85486,6 +87670,7 @@ others/histograms.xml --> <int value="-1848694292" label="Solid Colors - 18444545048605305324"/> <int value="-1842680590" label="Illustrations - 4696317262228722"/> <int value="-1834253570" label="Element - 7403164574384894"/> + <int value="-1763557434" label="Heritage - 18439582183915143110"/> <int value="-1756893570" label="Leisure - 7392551787556478"/> <int value="-1747187714" label="Landscapes - 776841872541694"/> <int value="-1741914332" label="Solid Colors - 962603508334372"/> @@ -85493,6 +87678,7 @@ others/histograms.xml --> <int value="-1689000484" label="Togetherness - 18439295116965570012"/> <int value="-1686380267" label="Cityscapes - 1581190523642133"/> <int value="-1677513839" label="Solid Colors - 3228924670847889"/> + <int value="-1667225463" label="Heritage - 18443680188402247817"/> <int value="-1666643127" label="Art - 113140656835401"/> <int value="-1665140063" label="Art - 7267821734066849"/> <int value="-1639283780" label="Leisure - 18443165363585319868"/> @@ -85519,6 +87705,7 @@ others/histograms.xml --> <int value="-1397020104" label="Cityscapes - 3452989100206648"/> <int value="-1389216897" label="Landscapes - 3716322142862207"/> <int value="-1382225891" label="Landscapes - 7848789358209053"/> + <int value="-1379111552" label="Heritage - 6939063748423040"/> <int value="-1346329828" label="Collage - 302823912809244"/> <int value="-1315221908" label="Cityscapes - 18438039904557157996"/> <int value="-1308168417" label="Solid Colors - 737212648320799"/> @@ -85528,6 +87715,7 @@ others/histograms.xml --> <int value="-1274675052" label="Art - 2851414628237460"/> <int value="-1215416857" label="Element - 18445289040653465063"/> <int value="-1206721847" label="Made by Canvas - 18440189784905409225"/> + <int value="-1201999266" label="Heritage - 8821217378890334"/> <int value="-1196759923" label="Collage - 18443143257831171213"/> <int value="-1196759879" label="Landscapes - 998419785770169"/> <int value="-1194600035" label="Landscapes - 18439590254727649693"/> @@ -85588,6 +87776,7 @@ others/histograms.xml --> <int value="-435188694" label="Art - 18444631610789694506"/> <int value="-387775828" label="Cityscapes - 18438479018645979820"/> <int value="-359510740" label="Solid Colors - 18440625901026823468"/> + <int value="-347674537" label="Heritage - 6951507300116567"/> <int value="-344702098" label="Landscapes - 18446494149217895278"/> <int value="-335909288" label="Art - 6686963096251992"/> <int value="-329960828" label="Landscapes - 18445540125327045252"/> @@ -85598,6 +87787,7 @@ others/histograms.xml --> <int value="-288029248" label="Illustrations - 3023519249401280"/> <int value="-275592484" label="Art - 18438681316012772060"/> <int value="-264921592" label="Leisure - 18439547692531424776"/> + <int value="-250481953" label="Heritage - 18442925297777111775"/> <int value="-242251369" label="Solid Colors - 2175301908924823"/> <int value="-217934385" label="Togetherness - 6948539607455183"/> <int value="-213086089" label="Art - 18439421351825281143"/> @@ -85618,6 +87808,7 @@ others/histograms.xml --> <int value="-40293301" label="Landscapes - 6678566730804299"/> <int value="-34451659" label="Landscapes - 18443902699405725493"/> <int value="-14900592" label="Dessert Time - 18445906920144151184"/> + <int value="-8722165" label="Heritage - 7157880817641739"/> <int value="-3017196" label="Art - 1230422227940884"/> <int value="11921136" label="Art - 18441231667880650480"/> <int value="21374230" label="Element - 3650936971339030"/> @@ -85648,9 +87839,12 @@ others/histograms.xml --> <int value="414767910" label="Imaginary - 18446088339992402726"/> <int value="419310910" label="Dessert Time - 2648504887291198"/> <int value="425591336" label="Landscapes - 5270694096929320"/> + <int value="427770466" label="Heritage - 3541007689794146"/> <int value="460520651" label="Illustrations - 3514056802761931"/> + <int value="473587735" label="Heritage - 18443282072844525591"/> <int value="474793699" label="Art - 18446204450198308579"/> <int value="481651970" label="Solid Colors - 5104143911185666"/> + <int value="485050488" label="Heritage - 18444694245218011256"/> <int value="500548057" label="Art - 18442613054405722585"/> <int value="502222590" label="Illustrations - 3440479759716094"/> <int value="507283273" label="Colors - 18438533741719357257"/> @@ -85665,6 +87859,7 @@ others/histograms.xml --> <int value="652440414" label="Togetherness - 18438158975903167326"/> <int value="712360087" label="Solid Colors - 18444153758170857623"/> <int value="723351331" label="Art - 4590504718989091"/> + <int value="731985139" label="Heritage - 3218288446354675"/> <int value="732594745" label="Collage - 6982402080145977"/> <int value="738877507" label="Leisure - 2226962756689987"/> <int value="766726480" label="Leisure - 18440296559765836112"/> @@ -85691,6 +87886,7 @@ others/histograms.xml --> <int value="962509426" label="Solid Colors - 18444943328028834418"/> <int value="971331677" label="Cityscapes - 8606754655262813"/> <int value="982113383" label="Cityscapes - 7805399667956839"/> + <int value="993271315" label="Heritage - 2400861941931539"/> <int value="995793386" label="Art - 18440963598480742890"/> <int value="996011870" label="Floral - 7430096849596254"/> <int value="1006682258" label="Landscapes - 18445475075089023122"/> @@ -85705,6 +87901,7 @@ others/histograms.xml --> <int value="1173629942" label="Colors - 6465464552401910"/> <int value="1192252038" label="Cityscapes - 6488081868804742"/> <int value="1206215167" label="Art - 18445129029773517311"/> + <int value="1243872355" label="Heritage - 18443899384969296995"/> <int value="1250920293" label="Art - 18443102780212086629"/> <int value="1259225205" label="Composition - 18442882001721507957"/> <int value="1280051538" label="Made by Canvas - 3143878686017874"/> @@ -85729,10 +87926,12 @@ others/histograms.xml --> <int value="1517259953" label="Illustrations - 18444680442225331377"/> <int value="1520811358" label="Colors - 273157145869662"/> <int value="1535000622" label="Imaginary - 1900923995439150"/> + <int value="1551836957" label="Heritage - 990184787093277"/> <int value="1561201240" label="Solid Colors - 18440201375495096920"/> <int value="1567507477" label="Art - 2184344624841749"/> <int value="1573305199" label="Collage - 18445466155008572271"/> <int value="1581350106" label="Imaginary - 3113861460884698"/> + <int value="1593019616" label="Heritage - 18440281880393911520"/> <int value="1596391393" label="Solid Colors - 7592202400628705"/> <int value="1602775350" label="Dessert Time - 18438498829025700150"/> <int value="1608128987" label="Floral - 18440852058792401371"/> @@ -85780,6 +87979,7 @@ others/histograms.xml --> <int value="2096017887" label="Dessert Time - 1656717010973151"/> <int value="2111036570" label="Togetherness - 7655330344590490"/> <int value="2111289865" label="Cityscapes - 7963176420751881"/> + <int value="2143896077" label="Heritage - 6067768730927629"/> </enum> <enum name="WallpaperLayout"> @@ -86095,7 +88295,7 @@ others/histograms.xml --> <int value="16" label="InstallURLLoadTimeout"/> <int value="17" label="FailedPlaceholderUninstall"/> <int value="18" label="NotInstallable"/> - <int value="19" label="BookmarkExtensionInstallError"/> + <int value="19" label="DEPRECATED: BookmarkExtensionInstallError"/> <int value="20" label="ApkWebInstallFailed"/> <int value="21" label="CancelledOnWebAppProviderShuttingDown"/> <int value="22" label="WebAppProviderNotReady"/> @@ -86424,6 +88624,15 @@ others/histograms.xml --> <int value="2" label="Blocked"/> </enum> +<enum name="WebAuthenticationU2FClientStatus"> + <summary>Outcome of a DBus method call to u2fd.</summary> + <int value="0" label="OK"/> + <int value="1" label="Unknown Error"> + Method call failed, e.g. because the service was unavailable or the request + timed out. + </int> +</enum> + <enum name="WebBluetoothConnectGATTOutcome"> <int value="0" label="Success"/> <int value="1" label="Device no longer in range"/> @@ -86680,6 +88889,9 @@ others/histograms.xml --> </enum> <enum name="WebOTPServiceDestroyedReason"> + <obsolete> + Deprecated 09/2021. We have learned about the pattern of the destruction. + </obsolete> <int value="0" label="Navigated to new page"/> <int value="1" label="Navigated to existing page"/> <int value="2" label="(Deprecated) Nagivated to same page"/> @@ -87162,9 +89374,10 @@ Called by update_scheduler_enums.py.--> <int value="51" label="KeyboardLock"/> <int value="52" label="WebOTPService"/> <int value="53" label="OutstandingNetworkRequestDirectSocket"/> - <int value="54" label="IsolatedWorldScript"/> + <int value="54" label="InjectedJavascript"/> <int value="55" label="InjectedStyleSheet"/> <int value="56" label="MediaSessionImplOnServiceCreated"/> + <int value="57" label="WebTransport"/> </enum> <enum name="WebShareMethod"> @@ -87210,6 +89423,7 @@ Called by update_scheduler_enums.py.--> <int value="24" label="Safety tip help opened"/> <int value="25" label="Chooser object deleted"/> <int value="26" label="Reset certificate decisions clicked"/> + <int value="27" label="Store info clicked"/> </enum> <enum name="WebSiteSettingsAllSitesAction"> @@ -87227,6 +89441,8 @@ Called by update_scheduler_enums.py.--> <int value="4" label="Clear Site Group Data"/> <int value="5" label="Clear Origin Data"/> <int value="6" label="Enter Site Details"/> + <int value="7" label="Remove Site Group"/> + <int value="8" label="Remove Origin"/> </enum> <enum name="WebsiteSettingsDiscoverabilityAction"> @@ -87235,6 +89451,10 @@ Called by update_scheduler_enums.py.--> label="Page info opened while permission icon was shown in omnibox"/> <int value="2" label="Permissions opened after click on permissions icon"/> <int value="3" label="Permission changed after click on permissions icon"/> + <int value="4" label="Store icon shown in omnibox"/> + <int value="5" + label="Page info opened while store icon was shown in omnibox"/> + <int value="6" label="Store info opened after click on store icon"/> </enum> <enum name="WebSocketCloseCode"> @@ -87976,12 +90196,48 @@ Called by update_scheduler_enums.py.--> <int value="8" label="OS yes, WebView on"/> </enum> +<enum name="WebViewForceDarkMode2"> + <int value="0" label="off"/> + <int value="1" label="auto"/> + <int value="2" label="on"/> +</enum> + +<enum name="WebViewInDarkModeVsLightTheme"> + <int value="0" label="WebView dark, light theme undefined"/> + <int value="1" label="WebView dark, light theme no"/> + <int value="2" label="WebView dark, light theme yes"/> + <int value="3" label="WebView light, light theme undefined"/> + <int value="4" label="WebView light, light theme no"/> + <int value="5" label="WebView light, light theme yes"/> +</enum> + +<enum name="WebViewInDarkModeVsNightMode"> + <int value="0" label="WebView dark, night mode undefined"/> + <int value="1" label="WebView dark, night mode off"/> + <int value="2" label="WebView dark, night mode on"/> + <int value="3" label="WebView light, night mode undefined"/> + <int value="4" label="WebView light, night mode off"/> + <int value="5" label="WebView light, night mode on"/> +</enum> + <enum name="WebViewMixedContentMode"> <int value="0" label="Always allow"/> <int value="1" label="Never allow"/> <int value="2" label="Compatibility Mode"/> </enum> +<enum name="WebViewNightModeVsLightTheme"> + <int value="0" label="Night mode undefined, light theme undefined"/> + <int value="1" label="Night mode undefined, light theme no"/> + <int value="2" label="Night mode undefined, light theme yes"/> + <int value="3" label="Night mode off, light theme undefined"/> + <int value="4" label="Night mode off, light theme no"/> + <int value="5" label="Night mode off, light theme yes"/> + <int value="6" label="Night mode on, light theme undefined"/> + <int value="7" label="Night mode on, light theme no"/> + <int value="8" label="Night mode on, light theme yes"/> +</enum> + <enum name="WebViewOpenWebScreenPortion"> <int value="0" label="ZeroPercent"/> <int value="1" label="TenPercent"/> @@ -88002,6 +90258,24 @@ Called by update_scheduler_enums.py.--> <int value="1" label="OpenWebContentNotVisible"/> </enum> +<enum name="WebViewPrimaryTextLuminanceVsLightTheme"> + <int value="0" label="Text dark, light theme undefined"/> + <int value="1" label="Text dark, light theme no"/> + <int value="2" label="Text dark, light theme yes"/> + <int value="3" label="Text light, light theme undefined"/> + <int value="4" label="Text light, light theme no"/> + <int value="5" label="Text light, light theme yes"/> +</enum> + +<enum name="WebViewPrimaryTextLuminanceVsNightMode"> + <int value="0" label="Text dark, night mode undefined"/> + <int value="1" label="Text dark, night mode off"/> + <int value="2" label="Text dark, night mode on"/> + <int value="3" label="Text light, night mode undefined"/> + <int value="4" label="Text light, night mode off"/> + <int value="5" label="Text light, night mode on"/> +</enum> + <enum name="WebViewUrlScheme"> <int value="0" label="Empty URL"/> <int value="1" label="Unknown scheme"/> @@ -88077,6 +90351,7 @@ Called by update_scheduler_enums.py.--> <int value="1" label="Load succeeded"/> <int value="2" label="Load failed and error page whas shown"/> <int value="3" label="Load failed and was redirected to NTP"/> + <int value="4" label="Load failed and tab was closed"/> </enum> <enum name="WhitelistedDownloadType"> @@ -88153,6 +90428,11 @@ Called by update_scheduler_enums.py.--> <int value="3" label="Not connected (Wake On WiFi disabled)"/> </enum> +<enum name="WiFiCQMNotificationType"> + <int value="0" label="Packet loss"/> + <int value="1" label="Beacon loss"/> +</enum> + <enum name="WiFiPCIStatus"> <int value="0" label="(Bad status) NIC not detected in lspci"/> <int value="1" @@ -89375,6 +91655,9 @@ Called by update_scheduler_enums.py.--> </enum> <enum name="WindowsServiceStatus"> + <obsolete> + Removed in M96. + </obsolete> <int value="0" label="Unknown"/> <int value="1" label="Not Found"/> <int value="2" label="Found"/> @@ -89977,7 +92260,12 @@ Called by update_scheduler_enums.py.--> <int value="999" label="SWAPERROR"/> <int value="1011" label="ERROR_CANTOPEN"/> <int value="1117" label="ERROR_IO_DEVICE"/> + <int value="1127" label="DISK_OPERATION_FAILED"/> + <int value="1175" label="UNABLE_TO_REMOVE_REPLACED"/> + <int value="1176" label="UNABLE_TO_MOVE_REPLACEMENT"/> + <int value="1177" label="UNABLE_TO_MOVE_REPLACEMENT_2"/> <int value="1223" label="ERROR_CANCELLED"/> + <int value="1296" label="CONTENT_BLOCKED"/> <int value="1346" label="ERROR_BAD_IMPERSONATION_LEVEL"/> <int value="1392" label="ERROR_FILE_CORRUPT"/> <int value="1393" label="ERROR_DISK_CORRUPT"/> @@ -89991,6 +92279,7 @@ Called by update_scheduler_enums.py.--> <int value="1784" label="INVALID_USER_BUFFER"/> <int value="1816" label="NOT_ENOUGH_QUOTA"/> <int value="1818" label="RPC_S_CALL_CANCELLED"/> + <int value="1920" label="CANT_ACCESS_FILE"/> <int value="6000" label="ERROR_ENCRYPTION_FAILED"/> <int value="6001" label="ERROR_DECRYPTION_FAILED"/> <int value="7041" label="ERROR_CTX_CONSOLE_DISCONNECT"/> diff --git a/chromium/tools/metrics/histograms/expand_owners.py b/chromium/tools/metrics/histograms/expand_owners.py index 080c30834f2..7616cdb4e52 100644 --- a/chromium/tools/metrics/histograms/expand_owners.py +++ b/chromium/tools/metrics/histograms/expand_owners.py @@ -253,10 +253,11 @@ def _ExtractComponentViaDirmd(path): dirmd_exe = 'dirmd.bat' dirmd_path = os.path.join(*(DIR_ABOVE_TOOLS + ['third_party', 'depot_tools', dirmd_exe])) - dirmd_command = [dirmd_path, 'compute', '--root', root_path, path] - dirmd = subprocess.Popen(dirmd_command, stdout=subprocess.PIPE) + dirmd_command = [dirmd_path, 'read', '-form', 'sparse', root_path, path] + dirmd = subprocess.Popen( + dirmd_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE) if dirmd.wait() != 0: - raise Error('dirmd failed.') + raise Error('dirmd failed: ' + dirmd.stderr.read()) json_out = json.load(dirmd.stdout) # On Windows, dirmd output still uses Unix path separators. if sys.platform == 'win32': diff --git a/chromium/tools/metrics/histograms/histogram_paths.py b/chromium/tools/metrics/histograms/histogram_paths.py index 31e28c6ab72..b255b19a515 100755 --- a/chromium/tools/metrics/histograms/histogram_paths.py +++ b/chromium/tools/metrics/histograms/histogram_paths.py @@ -70,8 +70,9 @@ HISTOGRAMS_INDEX = path_util.GetInputFile( def main(): with open(HISTOGRAMS_INDEX, 'w+') as f: # Force all OSes to use '/' as the separator. - f.write("\n".join( - [path.replace(os.sep, '/') for path in HISTOGRAMS_XMLS_RELATIVE])) + f.write(''.join([ + path.replace(os.sep, '/') + '\n' for path in HISTOGRAMS_XMLS_RELATIVE + ])) if __name__ == '__main__': diff --git a/chromium/tools/metrics/histograms/histograms_index.txt b/chromium/tools/metrics/histograms/histograms_index.txt index 52405bad8f8..c598890e142 100644 --- a/chromium/tools/metrics/histograms/histograms_index.txt +++ b/chromium/tools/metrics/histograms/histograms_index.txt @@ -15,6 +15,7 @@ tools/metrics/histograms/metadata/borealis/histograms.xml tools/metrics/histograms/metadata/browser/histograms.xml tools/metrics/histograms/metadata/chrome/histograms.xml tools/metrics/histograms/metadata/chromeos/histograms.xml +tools/metrics/histograms/metadata/chromeos_hps/histograms.xml tools/metrics/histograms/metadata/cloud/histograms.xml tools/metrics/histograms/metadata/commerce/histograms.xml tools/metrics/histograms/metadata/compositing/histograms.xml @@ -100,6 +101,7 @@ tools/metrics/histograms/metadata/service/histograms.xml tools/metrics/histograms/metadata/session/histograms.xml tools/metrics/histograms/metadata/settings/histograms.xml tools/metrics/histograms/metadata/sharing/histograms.xml +tools/metrics/histograms/metadata/side_search/histograms.xml tools/metrics/histograms/metadata/signin/histograms.xml tools/metrics/histograms/metadata/simple/histograms.xml tools/metrics/histograms/metadata/software/histograms.xml @@ -120,6 +122,7 @@ tools/metrics/histograms/metadata/web_apk/histograms.xml tools/metrics/histograms/metadata/web_audio/histograms.xml tools/metrics/histograms/metadata/web_core/histograms.xml tools/metrics/histograms/metadata/web_rtc/histograms.xml +tools/metrics/histograms/metadata/webapps/histograms.xml tools/metrics/histograms/metadata/webauthn/histograms.xml tools/metrics/histograms/metadata/weblayer/histograms.xml tools/metrics/histograms/metadata/windows/histograms.xml diff --git a/chromium/tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS b/chromium/tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS index 2c6d0b69dac..6ac548f282d 100644 --- a/chromium/tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS +++ b/chromium/tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS @@ -2,6 +2,7 @@ ajuma@chromium.org alcooper@chromium.org alexilin@chromium.org altimin@chromium.org +andypaicu@chromium.org anise@chromium.org ayui@chromium.org bingler@chromium.org @@ -9,7 +10,6 @@ csharrison@chromium.org cthomp@chromium.org curranmax@chromium.org dewittj@chromium.org -dmazzoni@chromium.org dmurph@chromium.org dschinazi@chromium.org drubery@chromium.org @@ -18,9 +18,11 @@ eirage@chromium.org ellyjones@chromium.org ender@google.com evliu@google.com +falken@chromium.org harrisonsean@chromium.org hartmanng@chromium.org iclelland@chromium.org +ioanap@chromium.org javierrobles@chromium.org johnidel@chromium.org jonross@chromium.org @@ -32,6 +34,7 @@ kron@chromium.org lizeb@chromium.org lyf@chromium.org mcrouse@chromium.org +mhasank@chromium.org mlippautz@chromium.org mthiesse@chromium.org nancylingwang@chromium.org @@ -46,7 +49,6 @@ rayankans@chromium.org reillyg@chromium.org rushans@google.com schenney@chromium.org -sebmarchand@chromium.org sebsg@chromium.org shaktisahu@chromium.org shend@chromium.org diff --git a/chromium/tools/metrics/histograms/metadata/accessibility/OWNERS b/chromium/tools/metrics/histograms/metadata/accessibility/OWNERS index 08d2c4c786d..c7055a11440 100644 --- a/chromium/tools/metrics/histograms/metadata/accessibility/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/accessibility/OWNERS @@ -2,5 +2,4 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # Prefer sending CLs to the owners listed below. # Use chromium-metrics-reviews@google.com as a backup. -dmazzoni@chromium.org evliu@google.com diff --git a/chromium/tools/metrics/histograms/metadata/accessibility/histograms.xml b/chromium/tools/metrics/histograms/metadata/accessibility/histograms.xml index dca8ed9d470..c2700895d9e 100644 --- a/chromium/tools/metrics/histograms/metadata/accessibility/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/accessibility/histograms.xml @@ -28,7 +28,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="Accessibility.ActiveTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>janewman@microsoft.com</owner> <summary> @@ -57,19 +57,30 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.Android.OnDemand.EventsDropped" units="count" - expires_after="M99"> - <owner>dmazzoni@chromium.org</owner> + expires_after="2022-04-03"> <owner>mschillaci@google.com</owner> + <owner>abigailbklein@google.com</owner> <summary> Tracks the number of AccessibilityEvents dropped when the OnDemand accessibility services feature is enabled. Recorded at the end of a session. </summary> </histogram> +<histogram name="Accessibility.Android.OnDemand.OneHundredPercentEventsDropped" + units="count" expires_after="2022-04-24"> + <owner>mschillaci@google.com</owner> + <owner>abigailbklein@google.com</owner> + <summary> + Tracks the number of AccessibilityEvents dropped when the OnDemand + accessibility services feature is enabled, and when the total percentage of + dropped events is 100%. Recorded at the end of a session. + </summary> +</histogram> + <histogram name="Accessibility.Android.OnDemand.PercentageDropped" units="%" - expires_after="M99"> - <owner>dmazzoni@chromium.org</owner> + expires_after="2022-04-03"> <owner>mschillaci@google.com</owner> + <owner>abigailbklein@google.com</owner> <summary> Tracks the percentage of AccessibilityEvents dropped when the OnDemand accessibility services feature is enabled. Recorded at the end of a session. @@ -106,7 +117,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.Android.UserFontSizePref.Change" units="%" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>twellington@chromium.org</owner> <owner>skym@chromium.org</owner> <summary> @@ -117,7 +128,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.Android.UserFontSizePref.OnStartup" units="%" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>twellington@chromium.org</owner> <owner>skym@chromium.org</owner> <summary> @@ -155,9 +166,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.AutoDisabled.DisabledTime" units="ms" - expires_after="2021-09-30"> - <owner>dmazzoni@chromium.org</owner> + expires_after="2022-04-17"> <owner>abigailbklein@google.com</owner> + <owner>chrome-a11y-core@google.com</owner> <summary> The total amount of time accessibility was disabled due to being auto-disabled, before being enabled again. @@ -165,9 +176,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.AutoDisabled.EnabledTime" units="ms" - expires_after="2022-02-06"> - <owner>dmazzoni@chromium.org</owner> + expires_after="2022-04-24"> <owner>abigailbklein@google.com</owner> + <owner>chrome-a11y-core@google.com</owner> <summary> The total amount of time accessibility was enabled before being auto-disabled. @@ -175,9 +186,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.AutoDisabled.EventCount" units="count" - expires_after="2022-02-06"> - <owner>dmazzoni@chromium.org</owner> + expires_after="2022-04-17"> <owner>abigailbklein@google.com</owner> + <owner>chrome-a11y-core@google.com</owner> <summary> The number of user input events that were received within one time window, without any accompanying accessibility API usage, that triggered @@ -217,7 +228,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosAlwaysShowA11yMenu" enum="BooleanEnabled" - expires_after="2021-10-25"> + expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>kenjibaheux@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -240,7 +251,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosAutoclick.TrayMenu.ChangeAction" - enum="AutoclickActionType" expires_after="2021-12-26"> + enum="AutoclickActionType" expires_after="2022-04-24"> <owner>katie@chromium.org</owner> <owner>dtseng@chromium.org</owner> <owner>dmazzoni@chromium.org</owner> @@ -252,7 +263,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosCaretHighlight" enum="BooleanEnabled" - expires_after="2021-11-21"> + expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -278,7 +289,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosCursorColor" enum="BooleanEnabled" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -289,7 +300,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosCursorHighlight" enum="BooleanEnabled" - expires_after="2021-11-14"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -299,7 +310,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosDictation" enum="BooleanEnabled" - expires_after="2021-12-26"> + expires_after="2022-08-23"> <owner>anastasi@google.com</owner> <owner>dtseng@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -310,7 +321,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosDictation.Language" enum="LocaleCodeISO639" - expires_after="2021-11-20"> + expires_after="2022-08-23"> <owner>katie@chromium.org</owner> <owner>dtseng@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -322,7 +333,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Accessibility.CrosDictation.ListeningDuration.NetworkRecognition" - units="ms" expires_after="2021-12-06"> + units="ms" expires_after="2022-08-23"> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -334,7 +345,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Accessibility.CrosDictation.ListeningDuration.OnDeviceRecognition" - units="ms" expires_after="2021-12-06"> + units="ms" expires_after="2022-08-23"> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -345,7 +356,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosDictation.ToggleDictationMethod" - enum="CrosDictationToggleDictationMethod" expires_after="2021-11-21"> + enum="CrosDictationToggleDictationMethod" expires_after="2022-08-23"> <owner>anastasi@google.com</owner> <owner>dtseng@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -353,7 +364,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosDictation.UsedOnDeviceSpeech" - enum="BooleanUsage" expires_after="2021-10-06"> + enum="BooleanUsage" expires_after="2022-08-23"> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -363,7 +374,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosDockedMagnifier" enum="BooleanEnabled" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -374,7 +385,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosFocusHighlight" enum="BooleanEnabled" - expires_after="2021-11-21"> + expires_after="2022-05-01"> <owner>dmazzoni@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -384,7 +395,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosHighContrast" enum="BooleanEnabled" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>kenjibaheux@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -395,7 +406,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosLargeCursor" enum="BooleanEnabled" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>kenjibaheux@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -417,7 +428,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosScreenMagnifier" enum="BooleanEnabled" - expires_after="2021-10-31"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>kenjibaheux@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -428,7 +439,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak" enum="BooleanEnabled" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -439,7 +450,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak.BackgroundShading" - enum="BooleanEnabled" expires_after="2022-02-06"> + enum="BooleanEnabled" expires_after="2022-05-01"> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -448,7 +459,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak.BubbleDismissMethod" - enum="CrosSelectToSpeakActivationMethod" expires_after="2022-01-30"> + enum="CrosSelectToSpeakActivationMethod" expires_after="2022-04-17"> <owner>ajitnarayanan@google.com</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -469,7 +480,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak.NavigationControls" - enum="BooleanEnabled" expires_after="2022-01-30"> + enum="BooleanEnabled" expires_after="2022-04-03"> <owner>ajitnarayanan@google.com</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -479,7 +490,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Accessibility.CrosSelectToSpeak.OverrideSpeechRateMultiplier" enum="CrosSelectToSpeakOverrideSpeechRateMultiplier" - expires_after="2022-01-30"> + expires_after="2022-04-24"> <owner>ajitnarayanan@google.com</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -494,7 +505,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak.ParagraphNavigationMethod" - enum="CrosSelectToSpeakActivationMethod" expires_after="2022-01-30"> + enum="CrosSelectToSpeakActivationMethod" expires_after="2022-04-24"> <owner>ajitnarayanan@google.com</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -505,7 +516,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak.SentenceNavigationMethod" - enum="CrosSelectToSpeakActivationMethod" expires_after="2022-01-30"> + enum="CrosSelectToSpeakActivationMethod" expires_after="2022-05-01"> <owner>ajitnarayanan@google.com</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -516,7 +527,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak.StartSpeechMethod" - enum="CrosSelectToSpeakStartSpeechMethod" expires_after="2021-12-26"> + enum="CrosSelectToSpeakStartSpeechMethod" expires_after="2022-04-03"> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -527,7 +538,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSelectToSpeak.StateChangeEvent" - enum="CrosSelectToSpeakStateChangeEvent" expires_after="2021-12-26"> + enum="CrosSelectToSpeakStateChangeEvent" expires_after="2022-04-03"> <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> @@ -597,7 +608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosStickyKeys" enum="BooleanEnabled" - expires_after="M96"> + expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>kenjibaheux@google.com</owner> <owner>tengs@chromium.org</owner> @@ -609,7 +620,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosSwitchAccess" enum="BooleanEnabled" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>anastasi@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -620,7 +631,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.CrosVirtualKeyboard" enum="BooleanEnabled" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>kenjibaheux@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -642,7 +653,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels" enum="BooleanEnabled" - expires_after="2022-01-23"> + expires_after="2022-04-17"> <owner>katie@chromium.org</owner> <owner>dmazzoni@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -653,7 +664,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels.Android" enum="BooleanEnabled" - expires_after="M95"> + expires_after="M105"> <owner>dmazzoni@chromium.org</owner> <owner>mschillaci@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -664,7 +675,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels.Android.DialogOption" - enum="AccessibilityImageLabelModeAndroid" expires_after="M95"> + enum="AccessibilityImageLabelModeAndroid" expires_after="M105"> <owner>dmazzoni@chromium.org</owner> <owner>mschillaci@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -675,7 +686,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels.Android.OnlyOnWifi" - enum="BooleanEnabled" expires_after="M95"> + enum="BooleanEnabled" expires_after="M105"> <owner>dmazzoni@chromium.org</owner> <owner>mschillaci@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -698,7 +709,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels.PageLanguage" enum="LanguageName" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>katie@chromium.org</owner> <owner>dmazzoni@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -709,7 +720,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels.RequestLanguage" enum="LanguageName" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>katie@chromium.org</owner> <owner>dmazzoni@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -721,7 +732,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels.{Result}By{Dimension}" - units="pixels" expires_after="2021-09-30"> + units="pixels" expires_after="2021-12-12"> <owner>dmazzoni@chromium.org</owner> <owner>mschillaci@google.com</owner> <summary> @@ -741,7 +752,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ImageLabels.{Result}By{Length}" - units="characters" expires_after="2021-09-30"> + units="characters" expires_after="2021-12-12"> <owner>dmazzoni@chromium.org</owner> <owner>mschillaci@google.com</owner> <summary> @@ -762,7 +773,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.InactiveTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>janewman@microsoft.com</owner> <summary> @@ -809,7 +820,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.LanguageDetection.LangsPerPage" units="count" - expires_after="2021-11-19"> + expires_after="2022-05-01"> <owner>chrishall@chromium.org</owner> <owner>aboxhall@chromium.org</owner> <owner>dmazzoni@chromium.org</owner> @@ -1099,7 +1110,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ManuallyEnabled" enum="BooleanEnabled" - expires_after="M99"> + expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>kenjibaheux@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -1111,7 +1122,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.ModeFlag" enum="AccessibilityModeFlagEnum" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>aboxhall@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -1152,7 +1163,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.Performance.ProcessDeferredAccessibilityEvents" - units="ms" expires_after="M96"> + units="ms" expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>janewman@microsoft.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -1164,7 +1175,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.Performance.SendPendingAccessibilityEvents" - units="ms" expires_after="M96"> + units="ms" expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>janewman@microsoft.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -1175,7 +1186,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.Performance.Tree.Unserialize" units="ms" - expires_after="M96"> + expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>janewman@microsoft.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -1301,7 +1312,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.WebSpeech.Duration" units="ms" - expires_after="2021-11-30"> + expires_after="2022-04-03"> <owner>evliu@google.com</owner> <owner>chrome-media-ux@google.com</owner> <summary> @@ -1324,7 +1335,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.WinAPIs" enum="AccessibilityWinAPIEnum" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>nektar@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> @@ -1332,7 +1343,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.WinAPIs.GetPropertyValue" - enum="AccessibilityWinAPIGetPropertyValueEnum" expires_after="2021-09-19"> + enum="AccessibilityWinAPIGetPropertyValueEnum" expires_after="2022-03-19"> <owner>dmazzoni@chromium.org</owner> <owner>nektar@chromium.org</owner> <owner>kbabbitt@microsoft.com</owner> @@ -1354,7 +1365,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Accessibility.WinHighContrastTheme" - enum="AccessibilityHighContrastColorScheme" expires_after="2021-12-12"> + enum="AccessibilityHighContrastColorScheme" expires_after="2022-04-10"> <owner>dmazzoni@chromium.org</owner> <owner>almaher@microsoft.com</owner> <owner>weblayoutdev@microsoft.com</owner> @@ -1510,7 +1521,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DomDistiller.InfoBarUsage" enum="BooleanUsage" - expires_after="2022-01-01"> + expires_after="2022-04-10"> <owner>mdjones@chromium.org</owner> <summary> "Used" is recorded when the user clicks the infobar to enter @@ -1564,7 +1575,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DomDistiller.ReaderMode.EntryPoint" - enum="ReaderModeEntryPoint" expires_after="2021-12-12"> + enum="ReaderModeEntryPoint" expires_after="2022-05-01"> <owner>katie@chromium.org</owner> <owner>gilmanmh@google.com</owner> <owner>chrome-a11y-core@google.com</owner> @@ -1583,7 +1594,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DomDistiller.ReaderShownForPageLoad" enum="Boolean" - expires_after="2022-01-01"> + expires_after="2022-04-24"> <owner>mdjones@chromium.org</owner> <summary> Records if the panel became visible at any point after a page was navigated. @@ -1701,7 +1712,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DomDistiller.Time.ViewingReaderModePage" units="ms" - expires_after="2022-01-01"> + expires_after="2022-04-17"> <owner>mdjones@chromium.org</owner> <summary> Records the amount of time a user spent on a Reader Mode Page. @@ -1709,9 +1720,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TextToSpeech.Event" enum="TextToSpeechEvent" - expires_after="2021-09-19"> - <owner>dmazzoni@chromium.org</owner> + expires_after="2022-05-10"> <owner>dtseng@chromium.org</owner> + <owner>katie@chromium.org</owner> <owner>chrome-a11y-core@google.com</owner> <summary> Events fired by the text-to-speech engine when speaking an utterance. @@ -1719,8 +1730,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TextToSpeech.Utterance.FromExtensionAPI" - enum="TextToSpeechFromExtensionAPI" expires_after="2022-01-23"> - <owner>dmazzoni@chromium.org</owner> + enum="TextToSpeechFromExtensionAPI" expires_after="2022-05-10"> + <owner>dtseng@chromium.org</owner> <owner>katie@chromium.org</owner> <summary> Indicates if an utterance spoken via synthesized text-to-speech was @@ -1780,7 +1791,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TextToSpeech.Utterance.HasVoiceName" - enum="TextToSpeechHasVoiceName" expires_after="2021-11-21"> + enum="TextToSpeechHasVoiceName" expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>katie@chromium.org</owner> <summary> @@ -1803,7 +1814,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TextToSpeech.Utterance.Native" enum="TextToSpeechNative" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>katie@chromium.org</owner> <summary> @@ -1825,7 +1836,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TextToSpeech.Utterance.TextLength" units="bytes" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>katie@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/android/histograms.xml b/chromium/tools/metrics/histograms/metadata/android/histograms.xml index d7bf71db89a..4a37f5dd075 100644 --- a/chromium/tools/metrics/histograms/metadata/android/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/android/histograms.xml @@ -81,10 +81,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variants name="MessageIdentifiers"> <variant name=".AddToHomescreenIPH"/> <variant name=".AdsBlocked"/> + <variant name=".AutoDarkWebContents"/> <variant name=".ChromeSurvey"/> <variant name=".DownloadProgress"/> <variant name=".GeneratedPasswordSaved"/> + <variant name=".InstallableAmbientBadge"/> <variant name=".MerchantTrust"/> + <variant name=".NearOomReduction"/> <variant name=".NotificationBlocked"/> <variant name=".PermissionUpdate"/> <variant name=".PopupBlocked"/> @@ -94,6 +97,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name=".SaveCard"/> <variant name=".SavePassword"/> <variant name=".SendTabToSelf"/> + <variant name=".SharedHighlighting"/> + <variant name=".SyncError"/> <variant name=".UpdatePassword"/> </variants> @@ -108,7 +113,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="Android.AdaptiveToolbarButton.Clicked" - enum="AdaptiveToolbarButtonVariant" expires_after="2022-02-15"> + enum="AdaptiveToolbarButtonVariant" expires_after="2022-04-17"> <owner>bttk@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -118,7 +123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.AdaptiveToolbarButton.SessionVariant" - enum="AdaptiveToolbarButtonVariant" expires_after="2022-02-15"> + enum="AdaptiveToolbarButtonVariant" expires_after="2022-04-17"> <owner>bttk@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -129,7 +134,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.AdaptiveToolbarButton.Settings.Changed" - enum="AdaptiveToolbarRadioButtonState" expires_after="2022-02-01"> + enum="AdaptiveToolbarRadioButtonState" expires_after="2022-04-10"> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -140,7 +145,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.AdaptiveToolbarButton.Settings.Startup" - enum="AdaptiveToolbarRadioButtonState" expires_after="2022-02-01"> + enum="AdaptiveToolbarRadioButtonState" expires_after="2022-04-10"> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -162,7 +167,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.AdaptiveToolbarButton.SettingsToggle.Startup" - enum="BooleanEnabled" expires_after="2022-02-01"> + enum="BooleanEnabled" expires_after="2022-04-17"> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -172,7 +177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.AppLaunch.BlockDrawForInitialTabAccuracy" - enum="AppLaunchBlockDrawForInitialTabAccuracy" expires_after="2021-12-15"> + enum="AppLaunchBlockDrawForInitialTabAccuracy" expires_after="2022-04-10"> <owner>sinansahin@google.com</owner> <owner>twellington@chromium.org</owner> <owner>skym@chromium.org</owner> @@ -185,7 +190,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.AppLaunch.DurationDrawWasBlocked" units="ms" - expires_after="2021-12-15"> + expires_after="2022-04-17"> <owner>sinansahin@google.com</owner> <owner>twellington@chromium.org</owner> <owner>skym@chromium.org</owner> @@ -198,7 +203,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.AppNotificationStatus" enum="NotificationAppStatus" - expires_after="2020-11-15"> + expires_after="never"> +<!-- expires-never: Indicates whether Chrome has notification permission. --> + + <owner>dtrainor@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> Records whether notifications are enabled for Chrome, as the Android app, @@ -207,7 +215,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.ArmCpuPart" enum="ArmCpuPart" - expires_after="2022-01-01"> + expires_after="2022-04-10"> <owner>rsesek@chromium.org</owner> <owner>clank-security@google.com</owner> <summary> @@ -324,6 +332,27 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Android.AutofillAssistant.TextToSpeech.ButtonAction" + enum="AutofillAssistantTextToSpeechButtonAction" expires_after="2022-06-08"> + <owner>jainshashank@google.com</owner> + <owner>arbesser@google.com</owner> + <summary> + Reports the resultant action that happens on clicking the autofill assistant + TTS button. This is recorded every time the TTS button is clicked. + </summary> +</histogram> + +<histogram name="Android.AutofillAssistant.TextToSpeech.EngineEvent" + enum="AutofillAssistantTextToSpeechEngineEvent" expires_after="2022-06-08"> + <owner>jainshashank@google.com</owner> + <owner>arbesser@google.com</owner> + <summary> + Reports the various TTS engine events received by the autofill assistant TTS + controller. This is recorded every time the autofill assistant TTS + controller receives a TTS event. + </summary> +</histogram> + <histogram name="Android.BackgroundTaskScheduler.ExactTaskCreated" enum="BackgroundTaskId" expires_after="2021-12-01"> <owner>fgorski@chromium.org</owner> @@ -352,7 +381,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskCanceled" - enum="BackgroundTaskId" expires_after="2021-12-01"> + enum="BackgroundTaskId" expires_after="2022-05-01"> <owner>fgorski@chromium.org</owner> <owner>nyquist@chromium.org</owner> <summary>Records that a specific background task has been canceled.</summary> @@ -381,7 +410,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskExpired" - enum="BackgroundTaskId" expires_after="2021-12-01"> + enum="BackgroundTaskId" expires_after="2022-04-24"> <owner>fgorski@chromium.org</owner> <owner>nator@chromium.org</owner> <owner>knollr@chromium.org</owner> @@ -392,7 +421,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskLoadedNative" - enum="BackgroundTaskId" expires_after="2022-01-30"> + enum="BackgroundTaskId" expires_after="2022-04-17"> <owner>fgorski@chromium.org</owner> <owner>nyquist@chromium.org</owner> <summary> @@ -402,7 +431,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskLoadedNative.FullBrowser" - enum="BackgroundTaskId" expires_after="2021-12-01"> + enum="BackgroundTaskId" expires_after="2022-04-24"> <owner>mheikal@chromium.org</owner> <owner>hanxi@chromium.org</owner> <owner>hnakashima@chromium.org</owner> @@ -413,7 +442,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskLoadedNative.ReducedMode" - enum="BackgroundTaskId" expires_after="2021-12-01"> + enum="BackgroundTaskId" expires_after="2022-04-24"> <owner>mheikal@chromium.org</owner> <owner>hanxi@chromium.org</owner> <owner>hnakashima@chromium.org</owner> @@ -423,7 +452,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskScheduled.Failure" - enum="BackgroundTaskId" expires_after="2021-12-01"> + enum="BackgroundTaskId" expires_after="2022-05-01"> <owner>fgorski@chromium.org</owner> <owner>nyquist@chromium.org</owner> <summary> @@ -432,7 +461,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskScheduled.Success" - enum="BackgroundTaskId" expires_after="2021-12-01"> + enum="BackgroundTaskId" expires_after="2022-04-17"> <owner>fgorski@chromium.org</owner> <owner>nyquist@chromium.org</owner> <summary> @@ -441,7 +470,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.BackgroundTaskScheduler.TaskStarted" - enum="BackgroundTaskId" expires_after="2022-01-30"> + enum="BackgroundTaskId" expires_after="2022-04-03"> <owner>fgorski@chromium.org</owner> <owner>nyquist@chromium.org</owner> <summary>Records that a specific background task has been started.</summary> @@ -470,7 +499,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.ChildProcessStartTimeV2{type}" units="ms" - expires_after="2021-12-13"> + expires_after="2022-10-01"> <owner>cduvall@chromium.org</owner> <owner>boliu@chromium.org</owner> <summary> @@ -556,7 +585,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.ChromeStartupDelegate.FailureReason" - enum="ChromeStartupDelegateFailureType" expires_after="2022-01-09"> + enum="ChromeStartupDelegateFailureType" expires_after="2022-04-17"> <owner>gangwu@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -566,7 +595,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.ChromeStartupDelegate.Result" - enum="ChromeStartupDelegateResult" expires_after="2022-01-09"> + enum="ChromeStartupDelegateResult" expires_after="2022-04-10"> <owner>gangwu@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -695,6 +724,30 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="Android.DarkTheme.AutoDarkMode.SettingsChangeSource.{NewState}" + enum="AndroidAutoDarkModeSettingsChangeSource" expires_after="2022-04-01"> + <owner>nemco@google.com</owner> + <owner>wenyufu@chromium.org</owner> + <owner>clank-app-team@google.com</owner> + <summary> + Source that changed the auto dark web content settings. This includes both + changes to global theme settings as well as individual site exceptions. This + histogram does not take into account whether the browser UI theme is dark or + not (e.g. browser theme could be "light" and user could still + change auto dark mode state in site settings). Recorded when the auto dark + web content settings changes including {NewState} + </summary> + <token key="NewState"> + <variant name=".Disabled" + summary="default value change to Blocked, or a site exception is + added."/> + <variant name=".Enabled" + summary="default value change to Allowed, or a site exception is + removed."/> + </token> +</histogram> + <histogram name="Android.DarkTheme.DarkSearchRequested" enum="Boolean" expires_after="2021-10-25"> <obsolete> @@ -712,7 +765,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DarkTheme.EnabledReason" enum="DarkThemeEnabledReason" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>twellington@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -722,7 +775,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DarkTheme.EnabledState" enum="BooleanEnabled" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>twellington@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -732,7 +785,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DarkTheme.Preference.State" - enum="DarkThemePreferences" expires_after="2021-12-26"> + enum="DarkThemePreferences" expires_after="2022-04-17"> <owner>twellington@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -741,6 +794,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Android.DarkTheme.ThemeSettingsEntry" + enum="AndroidThemeSettingsEntry" expires_after="2022-04-01"> + <owner>nemco@google.com</owner> + <owner>wenyufu@chromium.org</owner> + <owner>clank-app-team@google.com</owner> + <summary> + Entry that navigate the user into the Theme Settings. Recorded when the + Theme settings is opened. + </summary> +</histogram> + <histogram name="Android.DefaultBrowserPromo.DialogShown" enum="AndroidDefaultBrowserPromoType" expires_after="2021-05-30"> <obsolete> @@ -846,7 +910,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DeviceSize.LargestDisplaySize" units="dp" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>twellington@chromium.org</owner> <owner>tedchoc@chromium.org</owner> <owner>clank-app-team@google.com</owner> @@ -858,7 +922,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DeviceSize.SmallestDisplaySize" units="dp" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>twellington@chromium.org</owner> <owner>tedchoc@chromium.org</owner> <owner>clank-app-team@google.com</owner> @@ -880,8 +944,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DirectAction.Perform" enum="DirectActionId" - expires_after="2021-10-10"> - <owner>szermatt@chromium.org</owner> + expires_after="2022-10-10"> + <owner>arbesser@google.com</owner> <owner>autofill_assistant@google.com</owner> <summary> Counts calls to Activity.onPerformDirectAction made by the system on behalf @@ -1007,7 +1071,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DownloadManager.Menu.Action" - enum="Android.DownloadManager.Menu.Actions" expires_after="2022-01-23"> + enum="Android.DownloadManager.Menu.Actions" expires_after="2022-04-17"> <owner>dtrainor@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary>The count of Download Home top level menu actions taken.</summary> @@ -1032,7 +1096,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DownloadManager.NotificationInteraction" - enum="DownloadNotificationInteractions" expires_after="2022-01-02"> + enum="DownloadNotificationInteractions" expires_after="2022-04-24"> <owner>xingliu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -1042,14 +1106,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DownloadManager.OpenSource.Audio" - enum="AndroidDownloadOpenSource" expires_after="2021-12-12"> + enum="AndroidDownloadOpenSource" expires_after="2022-04-24"> <owner>xingliu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary>Records how users open audio download files on Android.</summary> </histogram> <histogram name="Android.DownloadManager.OpenSource.Other" - enum="AndroidDownloadOpenSource" expires_after="2022-02-06"> + enum="AndroidDownloadOpenSource" expires_after="2022-04-10"> <owner>xingliu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -1059,7 +1123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.DownloadManager.OpenSource.Video" - enum="AndroidDownloadOpenSource" expires_after="2022-02-06"> + enum="AndroidDownloadOpenSource" expires_after="2022-04-10"> <owner>xingliu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary>Records how users open video download files on Android.</summary> @@ -1251,7 +1315,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.FontLookup.Blink.DLFontsLatencyFailure" units="ms" - expires_after="2021-09-30"> + expires_after="2022-06-30"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1264,7 +1328,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.FontLookup.Blink.DLFontsLatencySuccess" units="ms" - expires_after="2021-12-05"> + expires_after="2022-06-30"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1292,7 +1356,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.FontLookup.FetchFontName" enum="FetchFontName" - expires_after="2021-12-15"> + expires_after="2022-04-24"> <owner>chouinard@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -1303,7 +1367,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.FontLookup.FetchFontResult" enum="FetchFontResult" - expires_after="2021-12-15"> + expires_after="2022-05-01"> <owner>chouinard@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -1315,7 +1379,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.FontLookup.GmsFontRequest.Time" units="ms" - expires_after="2021-12-15"> + expires_after="2022-05-01"> <owner>chouinard@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -1327,7 +1391,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.FontLookup.MatchLocalFontByUniqueName.Time" units="ms" - expires_after="2021-12-15"> + expires_after="2022-05-01"> <owner>chouinard@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -1381,7 +1445,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.HistoryPage.ClearBrowsingData.PerProfileType" - enum="BrowserProfileType" expires_after="2021-12-31"> + enum="BrowserProfileType" expires_after="2022-04-10"> <owner>sideyilmaz@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -1391,7 +1455,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.HomeButton.PerProfileType" enum="BrowserProfileType" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>sideyilmaz@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -1425,7 +1489,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.InstantApps.ApiCallDurationWithoutApp" units="ms" - expires_after="2022-01-31"> + expires_after="2022-04-03"> <owner>sbirch@google.com</owner> <owner>tedchoc@chromium.org</owner> <summary> @@ -1526,6 +1590,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Android.Intent.WebIntentToOtherBrowser" enum="Boolean" + expires_after="M98"> + <owner>mthiesse@chromium.org</owner> + <owner>yfriedman@chromium.org</owner> + <summary> + When a site attempts to navigate to a supported URL with an intent URL that + targets other browser-like apps. + </summary> +</histogram> + <histogram name="Android.IsLastSharedAppInfoRetrieved" enum="BooleanIsLastSharedAppInfoRetrieved" expires_after="M77"> <owner>tedchoc@chromium.org</owner> @@ -1549,7 +1623,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Android.IsolatedSplits.ContextCreateTime" - units="ms" expires_after="2022-02-06"> + units="ms" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="AndroidFeatureModuleName" --> <owner>cduvall@chromium.org</owner> @@ -1573,7 +1647,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Jank.FrameDuration{Scenario}" units="ms" - expires_after="2021-09-30"> + expires_after="2022-03-31"> <owner>salg@google.com</owner> <owner>ssid@chromium.org</owner> <summary> @@ -1597,7 +1671,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Jank.JankBursts{Scenario}" units="ms" - expires_after="2021-09-30"> + expires_after="2022-03-31"> <owner>salg@google.com</owner> <owner>ssid@chromium.org</owner> <summary> @@ -1623,7 +1697,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Jank.MissedFrames{Scenario}" units="frames" - expires_after="2021-09-30"> + expires_after="2022-03-31"> <owner>salg@google.com</owner> <owner>ssid@chromium.org</owner> <summary> @@ -1643,7 +1717,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.KernelVersion" enum="AndroidKernelVersion" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>rsesek@chromium.org</owner> <summary> Reports the kernel major and minor version from the utsname.release field. @@ -1827,6 +1901,47 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Android.Messages.Enqueued.Hidden" enum="MessageIdentifier" + expires_after="2022-06-01"> + <owner>pavely@chromium.org</owner> + <owner>lazzzis@chromium.org</owner> + <owner>clank-app-team@google.com</owner> + <summary> + Records the message identifier when an enqueued message is not immediately + displayed either because there is another message on the secreen or because + message scope (e.g. tab) is not active. This metric is recorded along with + Android.Messages.Enqueued.Hiding, which records identifier of currently + visible message. + </summary> +</histogram> + +<histogram name="Android.Messages.Enqueued.Hiding" enum="MessageIdentifier" + expires_after="2022-06-01"> + <owner>pavely@chromium.org</owner> + <owner>lazzzis@chromium.org</owner> + <owner>clank-app-team@google.com</owner> + <summary> + Recorded when an enqueued message is not immediately displayed. This metric + records message identifier of a message currently displayed on the screen + (that prevented the enqueued message from getting displayed immediately). + INVALID_MESSAGE is recorded when the message isn't displayed because message + scope (e.g. tab) isn't active or when message queue is suspended. + </summary> +</histogram> + +<histogram name="Android.Messages.Enqueued.Visible" enum="MessageIdentifier" + expires_after="2022-06-01"> + <owner>pavely@chromium.org</owner> + <owner>lazzzis@chromium.org</owner> + <owner>clank-app-team@google.com</owner> + <summary> + Records the message identifier when a message is displayed immediately when + it is enqueued. This includes cases when there are no other messages on the + screen as well as cases when the new message is high priority and causes + some other message to hide. + </summary> +</histogram> + <histogram name="Android.Messages.TimeToAction.Dismiss{MessageIdentifier}" units="ms" expires_after="2022-06-01"> <owner>pavely@chromium.org</owner> @@ -1940,7 +2055,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.NativeBackgroundTask.TaskFinished.FullBrowser" - enum="BackgroundTaskId" expires_after="2021-10-17"> + enum="BackgroundTaskId" expires_after="2023-06-15"> <owner>mheikal@chromium.org</owner> <owner>hanxi@chromium.org</owner> <owner>hnakashima@chromium.org</owner> @@ -1952,7 +2067,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.NativeBackgroundTask.TaskFinished.ReducedMode" - enum="BackgroundTaskId" expires_after="2021-10-17"> + enum="BackgroundTaskId" expires_after="2023-06-15"> <owner>mheikal@chromium.org</owner> <owner>hanxi@chromium.org</owner> <owner>hnakashima@chromium.org</owner> @@ -1978,7 +2093,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.NativeBackgroundTask.TaskStarted.FullBrowser" - enum="BackgroundTaskId" expires_after="2021-10-17"> + enum="BackgroundTaskId" expires_after="2023-06-15"> <owner>mheikal@chromium.org</owner> <owner>hanxi@chromium.org</owner> <owner>hnakashima@chromium.org</owner> @@ -1989,7 +2104,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.NativeBackgroundTask.TaskStarted.ReducedMode" - enum="BackgroundTaskId" expires_after="2021-10-17"> + enum="BackgroundTaskId" expires_after="2023-06-15"> <owner>mheikal@chromium.org</owner> <owner>hanxi@chromium.org</owner> <owner>hnakashima@chromium.org</owner> @@ -2011,7 +2126,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.NTP.Impression" enum="NTPImpressionType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>finkm@chromium.org</owner> <summary> Counts impressions of the NTP on Android. It also counts potential @@ -2044,7 +2159,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Omnibox.InvalidMatch" enum="MatchResult" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>ender@chromium.org</owner> <owner>tedchoc@chromium.org</owner> <owner>mpearson@chromium.org</owner> @@ -2079,7 +2194,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Omnibox.SuggestionList.LayoutTime" - units="microseconds" expires_after="2022-01-23"> + units="microseconds" expires_after="2022-04-17"> <owner>ender@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -2106,7 +2221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Omnibox.SuggestionList.MeasureTime" - units="microseconds" expires_after="2022-01-23"> + units="microseconds" expires_after="2022-04-17"> <owner>ender@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -2134,7 +2249,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Omnibox.SuggestionView.CreateTime" - units="microseconds" expires_after="2021-12-05"> + units="microseconds" expires_after="2022-04-17"> <owner>ender@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -2157,7 +2272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Omnibox.SuggestionView.Reused" enum="BooleanReused" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>ender@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -2188,7 +2303,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Omnibox.UsedSuggestionFromCache" enum="Boolean" - expires_after="2021-10-04"> + expires_after="2022-09-04"> <owner>ender@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> @@ -2209,7 +2324,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.OmniboxFocusReason" enum="OmniboxFocusReason" - expires_after="2022-01-30"> + expires_after="2022-05-01"> <owner>mdjones@chromium.org</owner> <owner>twellington@chromium.org</owner> <owner>amaralp@chromium.org</owner> @@ -2219,7 +2334,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.OpenHistoryFromMenu.PerProfileType" - enum="BrowserProfileType" expires_after="2022-02-02"> + enum="BrowserProfileType" expires_after="2022-04-10"> <owner>sideyilmaz@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -2229,7 +2344,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.PackageStats.CacheSize" units="MB" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>nyquist@chromium.org</owner> <owner>yfriedman@chromium.org</owner> <summary> @@ -2503,7 +2618,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.PlayServices.Installed" enum="BooleanInstalled" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>twellington@chromium.org</owner> <owner>tedchoc@chromium.org</owner> <summary> @@ -2513,7 +2628,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.PlayServices.Version" units="versioncode" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>twellington@chromium.org</owner> <owner>tedchoc@chromium.org</owner> <summary> @@ -2534,8 +2649,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Android.RequestDesktopSite.Changed" enum="SiteLayout" + expires_after="2022-04-01"> + <owner>shuyng@google.com</owner> + <owner>twellington@chromium.org</owner> + <summary> + Records the changes of request desktop site content settings. This is + recorded when a user manually switches the global setting between + mobile/desktop. + </summary> +</histogram> + <histogram name="Android.RequestDesktopSite.TabletEligible" enum="Boolean" - expires_after="M96"> + expires_after="2022-04-17"> <owner>gangwu@chromium.org</owner> <owner>fgorski@chromium.org</owner> <summary> @@ -2546,7 +2672,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.RequestDesktopSite.UseDesktopUserAgent" enum="Boolean" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>gangwu@chromium.org</owner> <owner>fgorski@chromium.org</owner> <summary> @@ -2556,7 +2682,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.RequestDesktopSite.UserSwitchToDesktop" enum="Boolean" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>gangwu@chromium.org</owner> <owner>fgorski@chromium.org</owner> <summary> @@ -2575,7 +2701,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.Rotation.BeginToRendererFrameActivation" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>jonross@chromium.org</owner> <owner>sadrul@chromium.org</owner> <summary> @@ -2637,7 +2763,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.SeccompStatus.RendererSandbox" - enum="AndroidSeccompSandboxStatus" expires_after="2021-12-05"> + enum="AndroidSeccompSandboxStatus" expires_after="2022-04-24"> <owner>rsesek@chromium.org</owner> <summary> Reports the status of the seccomp-bpf sandbox in renderer processes. @@ -2656,7 +2782,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.SelectFileDialogContentSelected" - units="SelectFileDialogContent" expires_after="2022-02-06"> + units="SelectFileDialogContent" expires_after="2022-04-10"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -2668,7 +2794,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.SelectFileDialogImgCount" units="images" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -2680,7 +2806,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.SelectFileDialogScope" enum="SelectFileDialogScope" - expires_after="M96"> + expires_after="2022-04-10"> <owner>peter@chromium.org</owner> <owner>finnur@chromium.org</owner> <summary> @@ -2704,7 +2830,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.StrictMode.OverrideUrlLoadingTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>yfriedman@chromium.org</owner> <owner>wnwen@chromium.org</owner> <summary> @@ -2716,6 +2842,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Android.StrictMode.TabPersistentStore{AndroidTabPersistentStoreTime}" units="ms" expires_after="2021-10-04"> + <obsolete> + No longer used. Removed as of 09/2021. + </obsolete> <owner>wnwen@chromium.org</owner> <owner>yfriedman@chromium.org</owner> <summary> @@ -2724,11 +2853,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> <token key="AndroidTabPersistentStoreTime"> <variant name=""/> - <variant name=".CleanupAllEncryptedTime" summary=""> - <obsolete> - Original code deleted in a refactoring. - </obsolete> - </variant> + <variant name=".CleanupAllEncryptedTime" summary=""/> <variant name=".LoadStateInternalPrefetchTime" summary=""/> <variant name=".LoadStateInternalTime" summary=""/> <variant name=".LoadStateTime" summary=""/> @@ -2845,6 +2970,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Android.Survey.ShowSurveyStatus" + enum="SurveyPresentationStatusCode" expires_after="2022-06-01"> + <owner>aishwaryarj@google.com</owner> + <owner>twellington@chromium.org</owner> + <owner>wenyufu@chromium.org</owner> + <owner>clank-app-team@google.com</owner> + <summary> + The result of the request to show the survey after it has been downloaded. + This request is initiated when the user accepts to take the survey on the + survey prompt. This histogram is agnostic to the content of the survey, + which is configured server side, and will be recorded for all surveys shown + in Chrome. Android only. + </summary> +</histogram> + <histogram name="Android.Survey.SurveyCompleted" enum="BooleanCompleted" expires_after="2022-06-01"> <owner>skym@chromium.org</owner> @@ -2888,7 +3028,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.ThemeColor" enum="Android.ThemeColor" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>sinansahin@google.com</owner> <owner>twellington@chromium.org</owner> <summary> @@ -3113,7 +3253,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.CPSDirectorySize" units="KB" - expires_after="2021-10-08"> + expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>hazems@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3124,7 +3264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.CUSDirectorySize" units="KB" - expires_after="2021-10-08"> + expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>hazems@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3135,7 +3275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.GetFilesDuration" units="ms" - expires_after="2022-01-09"> + expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>hazems@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3147,7 +3287,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.GetFilesResult" - enum="WebViewComponentUpdaterGetFilesResult" expires_after="2022-01-09"> + enum="WebViewComponentUpdaterGetFilesResult" expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>hazems@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3159,7 +3299,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.SafeModeActionExecuted" - enum="Boolean" expires_after="2022-06-30"> + enum="Boolean" expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -3170,7 +3310,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.UnexpectedExit" - enum="Boolean" expires_after="2021-10-08"> + enum="Boolean" expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>hazems@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3182,7 +3322,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.UpdateJobDuration" units="ms" - expires_after="2021-12-12"> + expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>hazems@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3193,7 +3333,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.ComponentUpdater.UpdateJobFilesChanged" - units="count" expires_after="2021-10-08"> + units="count" expires_after="2022-07-01"> <owner>nator@chromium.org</owner> <owner>hazems@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3266,6 +3406,109 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Android.WebView.DarkMode.ForceDarkBehavior" + enum="WebViewForceDarkBehavior" expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records WebView force dark behavior settings on each main frame navigation + entry committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.ForceDarkMode" + enum="WebViewForceDarkMode2" expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records WebView force dark mode settings on each main frame navigation entry + committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.InDarkMode" enum="Boolean" + expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records if WebView is in dark mode on each main frame navigation entry + committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.InDarkModeVsLightTheme" + enum="WebViewInDarkModeVsLightTheme" expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records if the application has light theme and if WebView is in dark mode on + each main frame navigation entry committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.InDarkModeVsNightMode" + enum="WebViewInDarkModeVsNightMode" expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records if the application is in the night mode and if WebView is in dark + mode on each main frame navigation entry committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.LightTheme" enum="LightTheme" + expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records if the application has light theme on each main frame navigation + entry committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.NightMode" enum="NightMode" + expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records application's night mode bit related to + android.content.res.Configuration.UI_MODE_NIGHT_MASK on each main frame + navigation entry committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.NightModeVsLightTheme" + enum="WebViewNightModeVsLightTheme" expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records if application is in night mode and if it has light theme on each + main frame navigation entry committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.PrimaryTextLuminanceVsLightTheme" + enum="WebViewPrimaryTextLuminanceVsLightTheme" expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records if the application has light theme and if its theme's + textColorPrimary attribute is light on each main frame navigation entry + committed. + </summary> +</histogram> + +<histogram name="Android.WebView.DarkMode.PrimaryTextLuminanceVsNightMode" + enum="WebViewPrimaryTextLuminanceVsNightMode" expires_after="2022-01-24"> + <owner>michaelbai@chromium.org</owner> + <owner>src/android_webview/OWNERS</owner> + <summary> + Records if the application is in night mode and if its theme's + textColorPrimary attribute is light on each main frame navigation entry + committed. + </summary> +</histogram> + <histogram name="Android.WebView.DevUi.AppLaunch" enum="Boolean" expires_after="2021-12-14"> <owner>ntfschr@chromium.org</owner> @@ -3559,6 +3802,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Android.WebView.LoadDataWithBaseUrl.HistoryUrl.{Timing}" enum="URLValueForLoadDataWithBaseURL" expires_after="M95"> + <obsolete> + Removed Sep 2021. See result in crbug.com/1244746. + </obsolete> <owner>rakina@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -3575,6 +3821,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Android.WebView.LoadDataWithBaseUrl.IsInMainFrame" enum="BooleanMainFrame" expires_after="M95"> + <obsolete> + Removed Sep 2021. See result in crbug.com/1244746. + </obsolete> <owner>rakina@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -3587,6 +3836,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Android.WebView.LoadDataWithBaseUrl.LoadingUrl" enum="URLValueForLoadDataWithBaseURL" expires_after="M95"> + <obsolete> + Removed Sep 2021. See result in crbug.com/1244746. + </obsolete> <owner>rakina@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -3600,6 +3852,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Android.WebView.LoadDataWithBaseUrl.NextNavigationIsSameDocument" enum="Boolean" expires_after="M95"> + <obsolete> + Removed Sep 2021. See result in crbug.com/1244746. + </obsolete> <owner>rakina@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -3611,6 +3866,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Android.WebView.LoadDataWithBaseUrl.SameUrlReplacement" enum="Boolean" expires_after="M95"> + <obsolete> + Removed Sep 2021. See result in crbug.com/1244746. + </obsolete> <owner>rakina@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -3675,7 +3933,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.MixedContent.Mode" - enum="WebViewMixedContentMode" expires_after="M96"> + enum="WebViewMixedContentMode" expires_after="2022-10-06"> <owner>ntfschr@chromium.org</owner> <owner>carlosil@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> @@ -3980,7 +4238,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.Startup.CreationTime.Stage1.FactoryInit" - units="ms" expires_after="2022-01-30"> + units="ms" expires_after="2022-04-03"> <owner>changwan@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -3990,7 +4248,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.Startup.CreationTime.Stage2.ProviderInit.Cold" - units="ms" expires_after="2022-01-30"> + units="ms" expires_after="2022-04-03"> <owner>changwan@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -4002,7 +4260,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.Startup.CreationTime.Stage2.ProviderInit.Warm" - units="ms" expires_after="2022-01-30"> + units="ms" expires_after="2022-04-03"> <owner>changwan@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -4062,7 +4320,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.Startup.InitType" - enum="AndroidWebViewInitType" expires_after="2021-09-21"> + enum="AndroidWebViewInitType" expires_after="2021-12-21"> <owner>torne@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> @@ -4072,7 +4330,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Android.WebView.SupportLibrary.ClientIsCompat" - enum="WebViewClientTypeEnum" expires_after="2021-11-13"> + enum="WebViewClientTypeEnum" expires_after="2022-10-06"> <owner>ntfschr@chromium.org</owner> <owner>src/android_webview/OWNERS</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/apps/histograms.xml b/chromium/tools/metrics/histograms/metadata/apps/histograms.xml index d96d110a238..6de3cc99583 100644 --- a/chromium/tools/metrics/histograms/metadata/apps/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/apps/histograms.xml @@ -21,6 +21,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> +<variants name="App"> + <variant name="Contacts" summary="Contacts"/> + <variant name="FileManager" summary="FileManager"/> + <variant name="PlayStore" summary="PlayStore"/> +</variants> + <variants name="AppType"> <variant name="Arc" summary="Android apps"/> <variant name="Borealis" summary="Borealis apps"/> @@ -84,6 +90,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. mode."/> </variants> +<variants name="InstallReason"> + <variant name="Oem" summary="Installed by an OEM"/> + <variant name="Policy" summary="Installed by policy"/> + <variant name="Preload" summary="Preinstalled by default"/> + <variant name="SubApp" summary="Installed by SubApp API"/> + <variant name="Sync" summary="Installed by sync"/> + <variant name="System" summary="Installed with the system"/> + <variant name="Unknown" summary="Installed with unknown source"/> + <variant name="User" summary="Installed by user"/> +</variants> + <variants name="InstallSource"> <variant name="Oem" summary="Installed by an OEM"/> <variant name="Policy" summary="Installed by policy"/> @@ -119,8 +136,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="Restore" summary="Restore is clicked"/> </variants> -<histogram name="Apps.ActivatedCount.{AppType}" units="ms" - expires_after="2021-10-28"> +<histogram name="Apps.ActivatedCount.{AppType}" units="units" + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> @@ -143,7 +160,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppInfoDialog.CreateWebAppShortcutSuccess" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>dmurph@chromium.org</owner> <owner>desktop-pwas-team@google.com</owner> <summary> @@ -200,14 +217,27 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppLaunchPerAppType" enum="AppType" - expires_after="2022-04-01"> + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> - <summary>Records an app launch grouped by app type.</summary> + <summary> + Records an app launch grouped by app type. This is recorded when an app is + launched. + </summary> +</histogram> + +<histogram name="Apps.AppLaunchPerAppTypeV2" enum="AppTypeV2" + expires_after="2022-07-01"> + <owner>nancylingwang@chromium.org</owner> + <owner>dominickn@chromium.org</owner> + <summary> + Records an app launch grouped by app type V2. This is recorded when an app + is launched. + </summary> </histogram> <histogram name="Apps.AppLaunchSource" enum="LaunchSource" - expires_after="2022-04-01"> + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary>Records an app launch grouped by launch source.</summary> @@ -262,7 +292,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.AppSearchProvider.QueryTime" units="ms" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>jennyz@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -272,7 +302,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.AppSearchProvider.ZeroStateLatency" units="ms" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>jennyz@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -282,7 +312,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.AppsGridAddPage" enum="AppListAddPageType" - expires_after="2021-11-07"> + expires_after="2022-05-01"> <owner>anasalazar@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -467,7 +497,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.DriveZeroStateProvider.Latency" units="ms" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <owner>wrong@chromium.org</owner> @@ -477,8 +507,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Apps.AppList.DriveZeroStateProvider.ShouldWarm" enum="Boolean" + expires_after="2022-06-30"> + <owner>tby@chromium.org</owner> + <owner>thanhdng@chromium.org</owner> + <owner>wrong@chromium.org</owner> + <summary> + Whether or not the the ItemSuggest cache should be warmed on login. Reported + once per login, when the DriveZeroStateProvider is created. + </summary> +</histogram> + <histogram name="Apps.AppList.DriveZeroStateProvider.Status" - enum="DriveZeroStateProviderStatus" expires_after="2022-01-23"> + enum="DriveZeroStateProviderStatus" expires_after="2022-05-01"> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <owner>wrong@chromium.org</owner> @@ -562,7 +603,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.ItemSuggestCache.ResponseSize" units="bytes" - expires_after="2021-09-19"> + expires_after="2022-01-31"> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <owner>wrong@chromium.org</owner> @@ -574,7 +615,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.ItemSuggestCache.Status" - enum="ItemSuggestCacheStatus" expires_after="2021-11-21"> + enum="ItemSuggestCacheStatus" expires_after="2022-04-17"> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <owner>wrong@chromium.org</owner> @@ -583,6 +624,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Apps.AppList.ItemSuggestCache.UpdateCacheLatency" units="ms" + expires_after="2022-01-31"> + <owner>tby@chromium.org</owner> + <owner>thanhdng@chromium.org</owner> + <owner>wrong@chromium.org</owner> + <summary> + Records the latency from the start of a call to UpdateCache to the time when + results are finalised. Reported once each time results are successfully + obtained, which corresponds to a kOk status being recorded in + Apps.AppList.ItemSuggestCache.Status. + </summary> +</histogram> + <histogram name="Apps.AppList.LauncherSearchProvider.QueryTime" units="ms" expires_after="2021-12-31"> <owner>jennyz@chromium.org</owner> @@ -594,7 +648,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.NumberOfApps" units="count" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>mmourgos@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -615,7 +669,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.OmniboxProvider.QueryTime" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>jennyz@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -638,7 +692,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.OsSettingsProvider.Error" - enum="OsSettingsProviderError" expires_after="2022-01-23"> + enum="OsSettingsProviderError" expires_after="2022-04-24"> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <summary> @@ -649,7 +703,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.OsSettingsProvider.QueryTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>thanhdng@chromium.org</owner> <owner>tby@chromium.org</owner> <summary> @@ -705,7 +759,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.SearchSuccess.Apps" enum="AppListLaunchedFrom" - expires_after="2021-10-29"> + expires_after="2022-10-29"> <owner>thanhdng@chromium.org</owner> <owner>tby@chromium.org</owner> <summary> @@ -714,7 +768,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.SuggestedContent.Enabled" enum="BooleanEnabled" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>wrong@chromium.org</owner> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> @@ -885,7 +939,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.ZeroStateDriveProvider.Relevance" units="score" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>wrong@chromium.org</owner> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> @@ -896,7 +950,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.ZeroStateFileProvider.Latency" units="ms" - expires_after="2021-11-21"> + expires_after="2022-06-30"> <owner>wrong@chromium.org</owner> <owner>tby@chromium.org</owner> <summary> @@ -919,7 +973,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.ZeroStateFileProvider.Relevance" units="score" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>wrong@chromium.org</owner> <owner>tby@chromium.org</owner> <owner>thanhdng@chromium.org</owner> @@ -930,7 +984,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppList.ZeroStateResults.LaunchedItemType" - enum="ZeroStateResultType" expires_after="2021-12-19"> + enum="ZeroStateResultType" expires_after="2022-04-24"> <owner>wrong@chromium.org</owner> <owner>tby@chromium.org</owner> <summary> @@ -1057,7 +1111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Apps.AppList.ZeroStateSearchResultUserActionType" enum="AppListZeroStateSearchResultUserActionType" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>jennyz@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -1100,7 +1154,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListAppMovingType" enum="AppListAppMovingType" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>mmourgos@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -1110,7 +1164,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListAppTypeClicked" enum="AppListAppType" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>charleszhao@chromium.org</owner> <owner>pdyson@chromium.org</owner> <summary> @@ -1188,14 +1242,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListFolder.ShowHide.AnimationSmoothness" units="%" - expires_after="2021-08-29"> - <owner>wutao@chromium.org</owner> + expires_after="2022-05-01"> + <owner>jamescook@chromium.org</owner> + <owner>chromeos-launcher@google.com</owner> <summary> Relative smoothness of animations of showing and hiding app list folder. 100% represents ideally smooth 60 frames per second. 50% represents only 30 frames per second is achieved during the animations. 0% should not happen. This metric is recorded exactly once when the user starts the folder animation in the launcher. + + Warning: this histogram was expired from 2021-08-29 to 2021-09-28; data may + be missing. </summary> </histogram> @@ -1214,7 +1272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListFolderOpened" enum="AppListFolderOpened" - expires_after="2021-10-25"> + expires_after="2022-05-01"> <owner>mmourgos@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -1244,7 +1302,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListLauncherClickedSearchQueryLength" - units="characters" expires_after="2021-12-26"> + units="characters" expires_after="2022-04-24"> <owner>wrong@chromium.org</owner> <owner>tby@chromium.org</owner> <summary> @@ -1255,7 +1313,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListLauncherIssuedSearchQueryLength" - units="characters" expires_after="2022-01-23"> + units="characters" expires_after="2022-04-17"> <owner>jennyz@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -1294,7 +1352,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListPageSwitcherSource" - enum="AppListPageSwitcherSource" expires_after="2021-10-25"> + enum="AppListPageSwitcherSource" expires_after="2022-03-06"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> <owner>newcomer@chromium.org</owner> @@ -1334,7 +1392,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListPlayStoreQueryState" - enum="AppListPlayStoreQueryState" expires_after="2022-01-02"> + enum="AppListPlayStoreQueryState" expires_after="2022-03-06"> <owner>hejq@chromium.org</owner> <summary>The state of a Play Store app search request.</summary> </histogram> @@ -1373,7 +1431,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListRecommendedResponse.Count" units="units" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>napper@chromium.org</owner> <owner>robsc@chromium.org</owner> <owner>thanhdng@chromium.org</owner> @@ -1384,7 +1442,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListRecommendedResponse.Latency" units="ms" - expires_after="2021-12-26"> + expires_after="2022-02-27"> <owner>napper@chromium.org</owner> <owner>robsc@chromium.org</owner> <owner>thanhdng@chromium.org</owner> @@ -1436,7 +1494,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListSearchBoxActivated" - enum="SearchBoxActivationSource" expires_after="2021-12-05"> + enum="SearchBoxActivationSource" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> <owner>newcomer@chromium.org</owner> @@ -1450,7 +1508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListSearchCommenced" units="searches" - expires_after="2021-11-07"> + expires_after="2022-04-24"> <owner>tapted@chromium.org</owner> <summary> The number of searches that are started in the app list. This is gathered @@ -1472,7 +1530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListSearchQueryLength" units="characters" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> <owner>calamity@chromium.org</owner> @@ -1492,7 +1550,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListSearchResultInternalApp.Show" - enum="AppListInternalAppName" expires_after="2021-12-26"> + enum="AppListInternalAppName" expires_after="2022-05-01"> <owner>wutao@chromium.org</owner> <summary> The app list search result of an internal app that was shown to the user. @@ -1542,7 +1600,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListShowSource" enum="AppListShowSource" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>newcomer@chromium.org</owner> <summary> The number of times the different sources for showing the app list are used. @@ -1567,7 +1625,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListSuggestedChipLaunched" units="indices" - expires_after="2022-01-23"> + expires_after="2022-04-17"> <owner>newcomer@chromium.org</owner> <owner>charleszhao@chromium.org</owner> <summary> @@ -1590,7 +1648,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppListUsageByNewUsers" - enum="AppListUsageStateByNewUsers" expires_after="M99"> + enum="AppListUsageStateByNewUsers" expires_after="2022-04-17"> <owner>andrewxu@chromium.org</owner> <owner>tbarzic@chromium.org</owner> <summary> @@ -1606,7 +1664,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.AppsCount.{AppType}" units="Apps" - expires_after="2021-10-28"> + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> @@ -1618,8 +1676,26 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="AppType" variants="AppType"/> </histogram> +<histogram name="Apps.AppsCountPerInstallReason.{AppType}.{InstallReason}" + units="Apps" expires_after="2022-07-01"> + <owner>dominickn@chromium.org</owner> + <owner>nancylingwang@chromium.org</owner> + <summary> + The total number of installed {AppType} for each app type {InstallReason} in + Chrome OS. This is logged when more than 24 hours pass after last log, or + during the system startup phase if more than 24 hours passed after last log. + This histogram is capped at 1000; values above this go into the overflow + bucket. + </summary> + <token key="AppType" variants="AppType"/> + <token key="InstallReason" variants="InstallReason"/> +</histogram> + <histogram name="Apps.AppsCountPerInstallSource.{AppType}.{InstallSource}" - units="Apps" expires_after="2021-10-28"> + units="Apps" expires_after="2022-07-01"> + <obsolete> + Removed in M96. Replaced with Apps.AppsCountPerInstallReason. + </obsolete> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> @@ -1665,7 +1741,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.ArcGhostWindowLaunch" enum="Boolean" - expires_after="2021-11-01"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sstan@chromium.org</owner> <summary> @@ -1743,16 +1819,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.CreateShortcutIcon.Linux.Result" - enum="WebAppCreateShortcutIconLinuxResult" expires_after="M95"> - <owner>phillis@chromium.org</owner> - <owner>cmumford@chromium.org</owner> + enum="WebAppCreateShortcutIconLinuxResult" expires_after="2022-05-01"> + <owner>estade@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> <summary> Records the result of creating shortcut image for web app on Linux. </summary> </histogram> <histogram name="Apps.CreateShortcuts.Linux.Result" - enum="WebAppCreateShortcutLinuxResult" expires_after="2021-12-12"> + enum="WebAppCreateShortcutLinuxResult" expires_after="2022-02-13"> <owner>phillis@chromium.org</owner> <owner>cmumford@chromium.org</owner> <summary> @@ -1761,7 +1837,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.CreateShortcuts.Mac.Result" - enum="WebAppCreateShortcutMacResult" expires_after="2021-12-12"> + enum="WebAppCreateShortcutMacResult" expires_after="2022-05-01"> <owner>phillis@chromium.org</owner> <owner>cmumford@chromium.org</owner> <summary> @@ -1770,7 +1846,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.DefaultAppLaunch{DefaultAppLaunchSource}" - enum="DefaultAppName" expires_after="2021-12-12"> + enum="DefaultAppName" expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <owner>nigeltao@chromium.org</owner> @@ -1816,9 +1892,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Apps.FileHandler.Registration.Linux.RecreateShortcut.Result" enum="FileHandlerRegistrationLinuxRecreateShortcutResult" - expires_after="M95"> - <owner>phillis@chromium.org</owner> - <owner>cmumford@chromium.org</owner> + expires_after="M100"> + <owner>estade@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> <summary> Records the result of re-creating shortcut during file handler registration process for PWA on Linux @@ -1826,25 +1902,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.FileHandler.Registration.Linux.Result" - enum="FileHandlerRegistrationLinuxResult" expires_after="M95"> - <owner>phillis@chromium.org</owner> - <owner>cmumford@chromium.org</owner> + enum="FileHandlerRegistrationLinuxResult" expires_after="M100"> + <owner>estade@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> <summary> - Records the result of file handler registration for PWA on Linux + Records the result of MIME info database update when enabling an app's use + of the PWA File Handling API </summary> </histogram> <histogram name="Apps.FileHandler.Registration.Win.Result" - enum="FileHandlerRegistrationWinResult" expires_after="M95"> - <owner>phillis@chromium.org</owner> - <owner>cmumford@chromium.org</owner> + enum="FileHandlerRegistrationWinResult" expires_after="M100"> + <owner>estade@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> <summary> Records the result of file handler registration for PWA on Windows </summary> </histogram> +<histogram name="Apps.FileHandler.Unregistration.Linux.Result" + enum="FileHandlerRegistrationLinuxResult" expires_after="M100"> + <owner>estade@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records the result of MIME info database update when disabling an app's use + of the PWA File Handling API + </summary> +</histogram> + <histogram name="Apps.FirstLauncherActionByNewUsers" enum="AppListLaunchedFrom" - expires_after="M99"> + expires_after="2022-04-17"> <owner>andrewxu@chromium.org</owner> <owner>tbarzic@chromium.org</owner> <summary> @@ -1897,7 +1984,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.Launcher.InstallAppFromLinkResult" - enum="WebAppInstallResultCode" expires_after="2021-12-12"> + enum="WebAppInstallResultCode" expires_after="2022-05-01"> <owner>dmurph@chromium.org</owner> <owner>desktop-pwas-team@google.com</owner> <summary> @@ -1907,7 +1994,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.Launcher.InstallLocallyShortcutsCreated" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>dmurph@chromium.org</owner> <owner>desktop-pwas-team@google.com</owner> <summary> @@ -2252,7 +2339,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.NumberOfNonSystemFolders" units="folder(s)" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>jamescook@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -2262,7 +2349,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Apps.NumberOfPages" units="page(s)" expires_after="2021-12-12"> +<histogram name="Apps.NumberOfPages" units="page(s)" expires_after="2022-04-17"> <owner>mmourgos@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -2304,7 +2391,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.PaginationTransition.AnimationSmoothness" units="%" - expires_after="2021-10-10"> + expires_after="2022-10-07"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> <owner>newcomer@chromium.org</owner> @@ -2324,7 +2411,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="Apps.PaginationTransition.DragScroll.PresentationTime" units="ms" - expires_after="2021-11-21"> + expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> @@ -2340,7 +2427,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="Apps.PaginationTransition.DragScroll.PresentationTime.MaxLatency" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> @@ -2385,8 +2472,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Apps.PreviousReadinessStatus.{App}" enum="AppReadiness" + expires_after="2021-12-31"> + <owner>nancylingwang@chromium.org</owner> + <owner>dominickn@chromium.org</owner> + <summary> + Recorded the previous readiness status when the app is ready. This is logged + when the app readiness status is ready. + </summary> + <token key="App" variants="App"/> +</histogram> + <histogram name="Apps.RestoreArcAppsResult" enum="RestoreResult" - expires_after="2021-12-30"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sstan@chromium.org</owner> <summary> @@ -2396,7 +2494,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreArcAppStates" enum="ArcRestoreState" - expires_after="2021-12-30"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sstan@chromium.org</owner> <summary> @@ -2406,7 +2504,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreArcWindowCount" units="units" - expires_after="2021-12-30"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sstan@chromium.org</owner> <summary> @@ -2417,7 +2515,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreBrowserResult" enum="RestoreTabResult" - expires_after="2021-12-31"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2427,7 +2525,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoredAppLaunch" enum="AppType" - expires_after="2021-11-01"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2437,7 +2535,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreForCrashNotification" enum="RestoreAction" - expires_after="2021-11-01"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2447,7 +2545,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreInitSetting" enum="RestoreSetting" - expires_after="2021-11-01"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2457,7 +2555,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreNoGhostWindowReason" enum="ArcNoWindowReason" - expires_after="2021-12-31"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sstan@chromium.org</owner> <summary> @@ -2466,7 +2564,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreNotification" enum="RestoreAction" - expires_after="2021-11-01"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2476,7 +2574,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RestoreSetting" enum="RestoreSetting" - expires_after="2021-11-01"> + expires_after="2022-07-01"> <owner>nancylingwang@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2486,7 +2584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RunningDuration.{AppType}" units="ms" - expires_after="2021-10-28"> + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> @@ -2498,7 +2596,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.RunningPercentage.{AppType}" units="%" - expires_after="2021-10-28"> + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> @@ -2565,6 +2663,27 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Apps.SessionRestoreExitResult" enum="SessionRestoreExitResult" + expires_after="2022-07-01"> + <owner>nancylingwang@chromium.org</owner> + <owner>sammiequon@chromium.org</owner> + <summary> + Records the last session restore exit result. This is logged when the + restoration process finishes during the system startup phase. + </summary> +</histogram> + +<histogram name="Apps.SessionRestoreWindowCount" + enum="SessionRestoreWindowCount" expires_after="2022-07-01"> + <owner>nancylingwang@chromium.org</owner> + <owner>sammiequon@chromium.org</owner> + <summary> + Records the restored browser window count from session restore. This is + logged when the restoration process finishes during the system startup + phase. + </summary> +</histogram> + <histogram name="Apps.ShortcutsMenu.Registration.Win.Result" enum="ShortcutsMenuRegistrationWinResult" expires_after="M87"> <obsolete> @@ -2614,7 +2733,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Apps.StateTransition.Drag.PresentationTime" - units="ms" expires_after="2022-02-06"> + units="ms" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> @@ -2640,7 +2759,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Apps.TimeBetweenNewUserSessionActivationAndFirstLauncherAction" - units="ms" expires_after="M99"> + units="ms" expires_after="2022-04-17"> <owner>andrewxu@chromium.org</owner> <owner>tbarzic@chromium.org</owner> <summary> @@ -2654,7 +2773,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Apps.TimeDurationBetweenNewUserSessionActivationAndFirstLauncherOpening" - units="ms" expires_after="M99"> + units="ms" expires_after="2022-04-10"> <owner>andrewxu@chromium.org</owner> <owner>tbarzic@chromium.org</owner> <summary> @@ -2665,7 +2784,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.UsageTime.{AppType}" units="ms" - expires_after="2021-10-28"> + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> @@ -2676,7 +2795,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Apps.UsageTimeV2.{AppTypeV2}" units="ms" - expires_after="2021-12-31"> + expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/tab/OWNERS b/chromium/tools/metrics/histograms/metadata/arc/OWNERS index 12587699ca0..b72f5e00f8a 100644 --- a/chromium/tools/metrics/histograms/metadata/tab/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/arc/OWNERS @@ -2,4 +2,4 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # Prefer sending CLs to the owners listed below. # Use chromium-metrics-reviews@google.com as a backup. -sebmarchand@chromium.org +mhasank@chromium.org diff --git a/chromium/tools/metrics/histograms/metadata/arc/histograms.xml b/chromium/tools/metrics/histograms/metadata/arc/histograms.xml index 2926d38e7a6..201ccfb4ac8 100644 --- a/chromium/tools/metrics/histograms/metadata/arc/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/arc/histograms.xml @@ -76,14 +76,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="Arc.AbiMigration.BootTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>vraheja@chromium.org</owner> <owner>arc-core@google.com</owner> <summary>Time taken for ARC to boot during an Abi Migration event.</summary> </histogram> <histogram name="Arc.AbiMigration.DowngradeDelay" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>vraheja@chromium.org</owner> <owner>arc-core@google.com</owner> <summary> @@ -93,7 +93,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.AbiMigration.Event" enum="ArcCorePriAbiMigEvent" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vraheja@google.com</owner> <owner>arc-core@google.com</owner> <summary> @@ -102,7 +102,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.AbiMigration.FailedAttempts" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vraheja@chromium.org</owner> <owner>arc-core@google.com</owner> <summary> @@ -112,7 +112,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.AccessibilityWithTalkBack" enum="BooleanEnabled" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>hirokisato@chromium.org</owner> <owner>sarakato@chromium.org</owner> <summary> @@ -156,7 +156,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.AdbSideloadingEnablingScreen" - enum="AdbSideloadingPromptEvent" expires_after="M96"> + enum="AdbSideloadingPromptEvent" expires_after="2022-05-01"> <owner>victorhsieh@chromium.org</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -164,7 +164,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Arc.AndroidBootTime" units="ms" expires_after="2021-12-19"> +<histogram name="Arc.AndroidBootTime" units="ms" expires_after="2022-04-24"> <owner>elijahtaylor@google.com</owner> <owner>shihuis@google.com</owner> <summary>The time elapsed for booting up the ARC instance.</summary> @@ -189,7 +189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> -<histogram name="Arc.AppCount" units="units" expires_after="2021-12-19"> +<histogram name="Arc.AppCount" units="units" expires_after="2022-04-24"> <owner>elijahtaylor@google.com</owner> <owner>shihuis@google.com</owner> <summary> @@ -200,7 +200,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.AppInstalledReason" enum="InstallationCounterReasonEnum" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>robsc@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -231,7 +231,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.AppShortcuts.BuildMenuTime" units="ms" - expires_after="2021-08-09"> + expires_after="2022-03-13"> <owner>mmourgos@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -264,13 +264,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.AppsInstalledAtStartup" units="App Count" - expires_after="M92"> + expires_after="M99"> <owner>elijahtaylor@google.com</owner> <owner>shihuis@google.com</owner> <summary> Total number of ARC apps installed on a device measured at startup. Note: This includes launchable apps that are installed by default, such as Play Store and Settings, as well as any vendor specific apps. + + Warning: this histogram was expired after M92 and brought back 2021-09-17; + data may be missing. </summary> </histogram> @@ -390,6 +393,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Arc.Auth.MainAccountHashMigration.Status" + enum="ArcMainAccountHashMigrationStatus" expires_after="2021-12-31"> + <owner>vsomani@google.com</owner> + <owner>arc-core@google.com</owner> + <summary> + Contains the status of the main account hash migration resolution. We record + this metric when migrating the main account hash from java hashcode to use a + cryptographic hash. This is done at the bootup time. + </summary> +</histogram> + <histogram name="Arc.Auth.MainAccountResolution.Status{ArcUserTypes}" enum="ArcAuthMainAccountResolutionStatus" expires_after="2022-07-04"> <owner>mhasank@google.com</owner> @@ -476,7 +490,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>Code installation result for ARC boot continue.</summary> </histogram> -<histogram name="Arc.ChromeOsImeLatency" units="ms" expires_after="2021-10-01"> +<histogram name="Arc.ChromeOsImeLatency" units="ms" expires_after="2022-04-01"> <owner>yhanada@google.com</owner> <owner>arc-framework@google.com</owner> <summary> @@ -487,7 +501,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.ClipboardDragDrop" enum="ArcClipboardDragDropEvent" - expires_after="M95"> + expires_after="2022-04-24"> <owner>tetsui@google.com</owner> <owner>arc-framework@google.com</owner> <summary>The number of clipboard and drag-and-drop events.</summary> @@ -539,7 +553,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.CompanionLibraryApisCounter" - enum="CompanionLibraryApisList" expires_after="2022-01-23"> + enum="CompanionLibraryApisList" expires_after="2022-04-10"> <owner>sstan@google.com</owner> <owner>bartfab@chromium.org</owner> <owner>giovax@google.com</owner> @@ -570,7 +584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.ContainerLifetimeEvent" enum="ArcContainerLifetimeEvent" - expires_after="2021-12-05"> + expires_after="2022-04-03"> <owner>elijahtaylor@google.com</owner> <owner>yusukes@google.com</owner> <summary> @@ -581,7 +595,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.ContainerRestartAfterCrashCount" units="units" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>elijahtaylor@google.com</owner> <owner>yusukes@google.com</owner> <summary> @@ -617,7 +631,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.CumulativeUseTime" units="seconds" - expires_after="2020-02-02"> + expires_after="2022-05-01"> <owner>elijahtaylor@google.com</owner> <owner>shihuis@google.com</owner> <summary> @@ -625,16 +639,25 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. container is active. Reported at most once a day, at which point accumulated time is reset (which means that sum of reported times for a OS version would give an estimate of ARC usage time per OS version). + + Warning: this histogram was expired after 2021-03-12 and brought back + 2021-09-17; data may be missing. </summary> </histogram> <histogram name="Arc.CupsPrinting.PageCount" units="units" expires_after="2020-10-04"> + <obsolete> + Removed 2021-09. + </obsolete> <owner>skau@chromium.org</owner> <owner>vkuzkokov@google.com</owner> <summary> The number of pages sent to a native printer by ARC. Reported for every print job originating in ARC container and sent to a CUPS printer. + + Warning: this histogram was expired after 2020-10-04 and brought back + 2021-09-17; data may be missing. </summary> </histogram> @@ -671,7 +694,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.EngagementTime.ArcTotal" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>maajid@google.com</owner> <owner>shaochuan@google.com</owner> <owner>shihuis@google.com</owner> @@ -685,7 +708,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.EngagementTime.Background" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>maajid@google.com</owner> <owner>shaochuan@google.com</owner> <owner>shihuis@google.com</owner> @@ -697,7 +720,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.EngagementTime.Foreground" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>maajid@google.com</owner> <owner>shaochuan@google.com</owner> <owner>shihuis@google.com</owner> @@ -708,7 +731,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.EngagementTime.Total" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>maajid@google.com</owner> <owner>shaochuan@google.com</owner> <owner>shihuis@google.com</owner> @@ -723,7 +746,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.ExternalStorage.MountedMediaVisibility" - enum="BooleanEnabled" expires_after="2022-01-02"> + enum="BooleanEnabled" expires_after="2022-05-01"> <owner>fukino@chromium.org</owner> <owner>yusukes@chromium.org</owner> <summary> @@ -743,8 +766,34 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Arc.FileSystemWatcher.Created" enum="BooleanEnabled" + expires_after="2022-08-26"> + <owner>risan@google.com</owner> + <owner>youkichihosoi@google.com</owner> + <owner>arc-storage@google.com</owner> + <summary> + How many times ArcFileSystemWatcher is created. Used as baseline for + Arc.FileSystemWatcher.ExceedLimit. + </summary> +</histogram> + +<histogram name="Arc.FileSystemWatcher.ExceedLimit" + enum="ArcFileSystemWatcherExceedLimitState" expires_after="2022-08-26"> + <owner>risan@google.com</owner> + <owner>youkichihosoi@google.com</owner> + <owner>arc-storage@google.com</owner> + <summary> + How many times inotify in ArcFileSystemWatcher exceeds its limit. + ArcFileSystemWatcher watches file system events on files shared with ARC by + using inotify, and requests MediaFileProvider in ARC to index media files + when needed. But the FilePathWatcher imposes a limit for the number of + watches that can be used by ArcFileSystemWatcher. Therefore, it is probable + that some media files are left unindexed. + </summary> +</histogram> + <histogram name="Arc.FirstAppLaunchDelay.TimeDelta" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>yusukes@google.com</owner> <owner>khmel@google.com</owner> <summary> @@ -864,7 +913,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Arc.ImeCount" units="units" expires_after="2021-10-01"> +<histogram name="Arc.ImeCount" units="units" expires_after="2022-04-01"> <owner>yhanada@chromium.org</owner> <owner>tetsui@chromium.org</owner> <summary> @@ -874,7 +923,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.IntentHelper.OpenAppWithIntentAction" - enum="ArcIntentHelperIntentAction" expires_after="2022-01-14"> + enum="ArcIntentHelperIntentAction" expires_after="2022-04-17"> <owner>tsergeant@chromium.org</owner> <owner>chromeos-apps-foundation-team@google.com</owner> <summary> @@ -896,13 +945,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.LaunchedWithGhostWindow" units="apps" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>sstan@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> - <summary> - The number of ARC apps launched with ghost window. Recorded when ARC apps - are restored by full restore component. - </summary> + <summary>The number of ARC apps launched with ghost window.</summary> </histogram> <histogram name="Arc.LowLatencyStylusLibrary.PredictionTarget" units="ms" @@ -915,7 +961,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.LowLatencyStylusLibraryApisCounter" - enum="LowLatencyStylusLibraryApisList" expires_after="2021-12-31"> + enum="LowLatencyStylusLibraryApisList" expires_after="2022-04-24"> <owner>shuanghu@chromium.org</owner> <owner>phshah@chromium.org</owner> <summary> @@ -986,6 +1032,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Arc.NearbyShare.WindowFound" units="units" + expires_after="2022-03-09"> + <owner>ttefera@google.com</owner> + <owner>arc-app-dev@google.com</owner> + <summary> + Records the success or failure of attempts to find NearbyShare window. ARC + NearbyShare finds a window after the "nearby share" button is + clicked in an app. If NearbyShare successfully finds a window, + "true" is recorded onto the histogram. "false" is + recorded in the case a window is not found. + </summary> +</histogram> + <histogram name="Arc.Net.DnsQuery.AndroidApi" enum="BooleanSuccess" expires_after="2022-07-22"> <owner>mhasank@google.com</owner> @@ -1014,7 +1073,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.OptInAction" enum="ArcOptInAction" - expires_after="2021-10-17"> + expires_after="2022-03-17"> <owner>elijahtaylor@google.com</owner> <owner>shihuis@google.com</owner> <summary>Arc OptIn action taken by user.</summary> @@ -1028,7 +1087,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.OptInNetworkErrorAction" enum="ArcOptInNetworkErrorAction" - expires_after="M98"> + expires_after="2022-05-01"> <owner>mhasank@google.com</owner> <owner>arc-core@google.com</owner> <summary> @@ -1039,14 +1098,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.OptInResult" enum="ArcOptInResult" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>elijahtaylor@google.com</owner> <owner>khmel@google.com</owner> <summary>Arc OptIn flow result.</summary> </histogram> <histogram name="Arc.OptInSilentAuthCode" enum="ArcOptInSilentAuthCode" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>elijahtaylor@google.com</owner> <summary> Arc Silent Auth Code status. This status is set during the ARC OptIn flow. @@ -1063,7 +1122,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.OptInSilentAuthCode.SecondaryAccount" - enum="ArcOptInSilentAuthCode" expires_after="2021-12-12"> + enum="ArcOptInSilentAuthCode" expires_after="2022-05-01"> <owner>khmel@google.com</owner> <summary> Arc Silent Auth Code status. This status is set during the minting of an @@ -1130,7 +1189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.PlayStoreSearch.QueryTime" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>hejq@chromium.org</owner> <summary> Time between sending an Play Store app discovery request and the storing @@ -1148,7 +1207,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.PlayStoreSearch.ReturnedAppsTotal" units="apps" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>hejq@chromium.org</owner> <summary> The total number of returned apps of a Play Store app discovery query. @@ -1185,7 +1244,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.PrintPreview.PreviewEvent" enum="PrintPreviewHelperEvents" - expires_after="2021-10-04"> + expires_after="2022-04-04"> <owner>bmgordon@chromium.org</owner> <owner>project-bolton@google.com</owner> <summary> @@ -1434,7 +1493,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.Runtime.Performance.Generic.FirstFrameRendered" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>camurcu@google.com</owner> <owner>khmel@google.com</owner> <summary> @@ -1445,7 +1504,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.Runtime.Performance.Generic.FrameTime" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>camurcu@google.com</owner> <owner>khmel@google.com</owner> <summary> @@ -1455,7 +1514,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.Runtime.Performance.Generic.Jankiness" units="%" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>camurcu@google.com</owner> <owner>khmel@google.com</owner> <summary> @@ -1498,7 +1557,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.SdkVersionUpgradeType" enum="ArcSdkVersionUpgradeType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>niwa@google.com</owner> <owner>yusukes@google.com</owner> <summary> @@ -1519,7 +1578,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.Session.MojoDisconnection{ArcUserTypes}" - enum="ArcMojoConnectionType" expires_after="2021-11-11"> + enum="ArcMojoConnectionType" expires_after="2022-11-11"> <owner>shaochuan@google.com</owner> <owner>khmel@google.com</owner> <owner>ttylenda@google.com</owner> @@ -1550,6 +1609,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Arc.ShareFilesOnExit" enum="ArcShareFilesOnExit" expires_after="M75"> + <obsolete> + Removed in September 2021. Feature launched in 2018, no longer tracked. + </obsolete> <owner>weifangsun@google.com</owner> <owner>djacobo@google.com</owner> <summary> @@ -1588,7 +1650,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.StateByUserType{ArcUserTypes}" enum="ArcEnableState" - expires_after="2021-10-25"> + expires_after="2022-03-25"> <owner>elijahtaylor@google.com</owner> <owner>shihuis@google.com</owner> <owner>khmel@google.com</owner> @@ -1602,7 +1664,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.Supervision.Transition.Result" - enum="ArcSupervisionTransitionResult" expires_after="2022-01-31"> + enum="ArcSupervisionTransitionResult" expires_after="2022-04-03"> <owner>giovax@chromium.org</owner> <owner>arc-commercial@google.com</owner> <summary> @@ -1622,7 +1684,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.Supervision.Transition.Screen.Successful" - enum="BooleanSuccess" expires_after="2022-01-31"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>giovax@chromium.org</owner> <owner>arc-commercial@google.com</owner> <summary> @@ -1695,7 +1757,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Arc.UserInteraction" enum="ArcUserInteraction" - expires_after="2021-12-19"> + expires_after="2022-04-03"> <owner>jhorwich@chromium.org</owner> <owner>elijahtaylor@chromium.org</owner> <owner>shihuis@google.com</owner> diff --git a/chromium/tools/metrics/histograms/metadata/ash/histograms.xml b/chromium/tools/metrics/histograms/metadata/ash/histograms.xml index c6ddd62b9fb..3e73bef7f0f 100644 --- a/chromium/tools/metrics/histograms/metadata/ash/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/ash/histograms.xml @@ -109,7 +109,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Accelerators.WindowSnap" - enum="WindowSnapAcceleratorAction" expires_after="2021-12-12"> + enum="WindowSnapAcceleratorAction" expires_after="2022-04-10"> <owner>amusbach@chromium.org</owner> <owner>xdai@chromium.org</owner> <summary>Captures usage of Alt+[ and Alt+].</summary> @@ -204,7 +204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.AppNotificationBadgingPref" enum="Boolean" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>mmourgos@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -271,6 +271,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Ash.BrowserDataMigrator.AshDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is identified to belong to ash-chrome i.e. the + total size of files that are under profile data directory of ash-chrome that + should remain in the same directory. + </summary> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.CommonDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is duplicated in both ash and lacros data + directory. + </summary> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.CommonDataTimeTakenMS" units="ms" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The time taken for copying common data shared with lacros and ash. + </summary> +</histogram> + <histogram name="Ash.BrowserDataMigrator.CopiedDataSizeMB" units="MB" expires_after="M101"> <owner>ythjkt@chromium.org</owner> @@ -291,6 +321,77 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Ash.BrowserDataMigrator.DryRunAshDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is identified to belong to ash-chrome i.e. the + total size of files that are under profile data directory of ash-chrome that + should remain in the same directory. + + The same as Ash.BrowserDataMigrator.AshDataSizeMB but collected without + actually running the migrator. It is called on every ash launch. + </summary> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.DryRunCommonDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is duplicated in both ash and lacros data + directory. + + The same as Ash.BrowserDataMigrator.CommonDataSizeMB but collected without + actually running the migrator. It is called on every ash launch. + </summary> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.DryRunHasEnoughDiskSpace.{Mode}" + enum="Boolean" expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + Checks if there is enough disk space for profile migration in each modes. + These modes are Copy, Move, DeleteAndCopy and DeleteAndMove. + + Checked upon launch of ash-chrome. + </summary> + <token key="Mode"> + <variant name="Copy"/> + <variant name="DeleteAndCopy"/> + <variant name="DeleteAndMove"/> + <variant name="Move"/> + </token> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.DryRunLacrosDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is identified to belong to lacros-chrome i.e. + the total size of files that are under profile data directory of ash-chrome + that should move to lacros data directory. + + The same as Ash.BrowserDataMigrator.LacrosDataSizeMB but collected without + actually running the migrator. It is called on every ash launch. + </summary> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.DryRunNoCopyDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is identified to be deletable such as cache. + + The same as Ash.BrowserDataMigrator.NoCopyDataSizeMB but collected without + actually running the migrator. It is called on every ash launch. + </summary> +</histogram> + <histogram name="Ash.BrowserDataMigrator.FinalStatus" enum="BrowserDataMigratorFinalStatus" expires_after="M101"> <owner>ythjkt@chromium.org</owner> @@ -301,6 +402,33 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Ash.BrowserDataMigrator.LacrosDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is identified to belong to lacros-chrome i.e. + the total size of files that are under profile data directory of ash-chrome + that should move to lacros data directory. + </summary> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.LacrosDataTimeTakenMS" units="ms" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary>The time taken for copying lacros data.</summary> +</histogram> + +<histogram name="Ash.BrowserDataMigrator.NoCopyDataSizeMB" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + The size of profile data that is identified to be deletable such as cache. + </summary> +</histogram> + <histogram name="Ash.BrowserDataMigrator.TotalTimeTakenMS" units="ms" expires_after="M101"> <owner>ythjkt@chromium.org</owner> @@ -312,7 +440,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.BarButtons.{TabletOrClamshell}" - enum="CaptureModeBarButtonType" expires_after="2021-09-29"> + enum="CaptureModeBarButtonType" expires_after="2022-09-29"> <owner>chinsenj@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -325,7 +453,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Ash.CaptureModeController.CaptureConfiguration.{TabletOrClamshell}" - enum="CaptureModeConfiguration" expires_after="2021-11-13"> + enum="CaptureModeConfiguration" expires_after="2022-09-29"> <owner>chinsenj@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -338,7 +466,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Ash.CaptureModeController.CaptureRegionAdjusted.{TabletOrClamshell}" - units="adjustments" expires_after="2021-11-06"> + units="adjustments" expires_after="2022-09-29"> <owner>chinsenj@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -352,7 +480,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.ConsecutiveScreenshots" - units="consecutive screenshots" expires_after="2022-01-09"> + units="consecutive screenshots" expires_after="2022-09-09"> <owner>chinsenj@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -363,7 +491,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Ash.CaptureModeController.EndRecordingReason.{TabletOrClamshell}" - enum="EndRecordingReason" expires_after="2021-11-23"> + enum="EndRecordingReason" expires_after="2022-09-09"> <owner>afakhry@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -375,7 +503,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.EntryPoint.{TabletOrClamshell}" - enum="CaptureModeEntryType" expires_after="2021-09-29"> + enum="CaptureModeEntryType" expires_after="2022-09-09"> <owner>chinsenj@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -386,7 +514,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.QuickAction" - enum="CaptureQuickAction" expires_after="2021-11-19"> + enum="CaptureQuickAction" expires_after="2022-09-09"> <owner>shidi@chromium.org</owner> <owner>chinsenj@chromium.org</owner> <summary> @@ -396,7 +524,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.ScreenRecordingLength" - units="seconds" expires_after="2022-01-09"> + units="seconds" expires_after="2022-09-09"> <owner>afakhry@chromium.org</owner> <owner>chinsenj@chromium.org</owner> <owner>gzadina@google.com</owner> @@ -408,7 +536,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.ScreenshotsPerDay" units="int" - expires_after="2022-01-30"> + expires_after="2022-09-09"> <owner>afakhry@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -420,7 +548,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.ScreenshotsPerWeek" units="int" - expires_after="2022-01-30"> + expires_after="2022-09-09"> <owner>afakhry@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -433,7 +561,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.CaptureModeController.SwitchesFromInitialCaptureMode" - enum="Boolean" expires_after="2022-01-16"> + enum="Boolean" expires_after="2022-09-09"> <owner>chinsenj@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -453,7 +581,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Clipboard.ConsecutivePastes" units="times" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>newcomer@chromium.org</owner> <owner>multipaste@google.com</owner> <summary> @@ -475,7 +603,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.DisplayFormatDeleted" - enum="ClipboardHistoryDisplayFormat" expires_after="2022-01-02"> + enum="ClipboardHistoryDisplayFormat" expires_after="2022-04-10"> <owner>andrewxu@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -485,7 +613,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.DisplayFormatPasted" - enum="ClipboardHistoryDisplayFormat" expires_after="2022-01-02"> + enum="ClipboardHistoryDisplayFormat" expires_after="2022-04-10"> <owner>andrewxu@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -495,7 +623,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.DisplayFormatShown" - enum="ClipboardHistoryDisplayFormat" expires_after="2022-01-02"> + enum="ClipboardHistoryDisplayFormat" expires_after="2022-04-10"> <owner>andrewxu@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -505,7 +633,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.MenuOptionSelected" - units="index" expires_after="2022-01-02"> + units="index" expires_after="2022-04-03"> <owner>andrewxu@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -515,7 +643,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.NumberOfItemsShown" - units="Items Shown" expires_after="2022-01-02"> + units="Items Shown" expires_after="2022-04-10"> <owner>andrewxu@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -526,7 +654,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.ShowMenu" - enum="ClipboardHistoryTriggerType" expires_after="2022-01-02"> + enum="ClipboardHistoryTriggerType" expires_after="2022-04-10"> <owner>andrewxu@chromium.org</owner> <owner>multipaste@google.com</owner> <summary> @@ -536,7 +664,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.ShowPlaceholderString" - enum="ClipboardHistoryPlaceholderStringType" expires_after="2022-01-02"> + enum="ClipboardHistoryPlaceholderStringType" expires_after="2022-04-10"> <owner>newcomer@chromium.org</owner> <owner>multipaste@google.com</owner> <summary> @@ -547,7 +675,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ContextMenu.UserJourneyTime" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>andrewxu@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -608,7 +736,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ControlToVDelay" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>gzadina@google.com</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -623,7 +751,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ImageModelRequest.Lifetime" units="ms" - expires_after="2021-12-11"> + expires_after="2022-04-24"> <owner>newcomer@chromium.org</owner> <owner>multipaste@google.com</owner> <summary> @@ -633,7 +761,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ImageModelRequest.Runtime" units="ms" - expires_after="2021-12-11"> + expires_after="2022-04-24"> <owner>newcomer@chromium.org</owner> <owner>multipaste@google.com</owner> <summary> @@ -643,7 +771,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.ClipboardHistory.ImageModelRequest.StopReason" - enum="RequestStopReason" expires_after="2021-12-11"> + enum="RequestStopReason" expires_after="2022-04-24"> <owner>newcomer@chromium.org</owner> <owner>multipaste@google.com</owner> <summary> @@ -764,7 +892,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.AnimationSmoothness.DeskActivation" units="%" - expires_after="2022-01-30"> + expires_after="2022-04-17"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <owner>mukai@chromium.org</owner> @@ -789,7 +917,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.AnimationSmoothness.DeskRemoval" units="%" - expires_after="2021-11-29"> + expires_after="2022-04-17"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <owner>mukai@chromium.org</owner> @@ -824,7 +952,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.ConsecutiveDailyVisits" units="days" - expires_after="2022-02-19"> + expires_after="2022-04-24"> <owner>chinsenj@chromium.org</owner> <owner>janetmac@chromium.org</owner> <summary> @@ -878,7 +1006,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.DesksCount3" units="units" - expires_after="2021-11-29"> + expires_after="2022-04-03"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -889,7 +1017,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.DesksSwitch" enum="DesksSwitchSource" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -900,7 +1028,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.MoveWindowFromActiveDesk" - enum="DesksMoveWindowFromActiveDeskSource" expires_after="2021-12-12"> + enum="DesksMoveWindowFromActiveDeskSource" expires_after="2022-04-03"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -915,7 +1043,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NewDesk2" enum="DesksCreationRemovalSource" - expires_after="2021-12-19"> + expires_after="2022-04-03"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -926,7 +1054,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfDeskTraversals" units="units" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>afakhry@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> @@ -940,7 +1068,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_1" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -950,7 +1078,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_2" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -960,7 +1088,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_3" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -970,7 +1098,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_4" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -980,7 +1108,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_5" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -990,7 +1118,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_6" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -1000,7 +1128,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_7" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -1010,7 +1138,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.NumberOfWindowsOnDesk_8" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -1020,7 +1148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.PresentationTime.UpdateGesture" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>afakhry@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> @@ -1049,7 +1177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Desks.RemoveDesk" enum="DesksCreationRemovalSource" - expires_after="2022-01-30"> + expires_after="2022-04-17"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -1144,7 +1272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Display.InternalDisplay.ActiveEffectiveResolution" - enum="EffectiveResolution" expires_after="2021-10-31"> + enum="EffectiveResolution" expires_after="2022-04-03"> <owner>malaykeshav@chromium.org</owner> <owner>oshima@chromium.org</owner> <summary> @@ -1321,7 +1449,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.HotseatGesture" enum="HotseatInAppGesture" - expires_after="2021-08-09"> + expires_after="M106"> <owner>andrewxu@chromium.org</owner> <owner>tbarzic@chromium.org</owner> <summary>Gestures supported by the in-app hotseat.</summary> @@ -1329,7 +1457,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Ash.HotseatTransition.AnimationSmoothness{HotseatTransitionType}" - units="%" expires_after="2021-10-11"> + units="%" expires_after="2022-10-07"> <owner>anasalazar@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -1348,7 +1476,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.HotseatTransition.Drag.PresentationTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>anasalazar@chromium.org</owner> <owner>newcomer@chromium.org</owner> <summary> @@ -1421,7 +1549,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.InteractiveWindowResize.TimeToPresent" units="ms" - expires_after="2021-12-10"> + expires_after="2022-04-17"> <owner>oshima@chromium.org</owner> <owner>mukai@chromium.org</owner> <summary> @@ -1589,7 +1717,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Ash.LoginAnimation.Duration" units="ms" - expires_after="2021-12-10"> + expires_after="2022-04-17"> <owner>oshima@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <!-- Name completed by histogram_suffixes @@ -1603,7 +1731,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Ash.LoginAnimation.Jank" units="%" - expires_after="2021-12-10"> + expires_after="2022-05-01"> <owner>oshima@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <!-- Name completed by histogram_suffixes @@ -1616,7 +1744,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Ash.LoginAnimation.Smoothness" units="%" - expires_after="2021-12-10"> + expires_after="2022-04-24"> <owner>oshima@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <!-- Name completed by histogram_suffixes @@ -1629,7 +1757,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Media.CameraPrivacySwitch.Event" - enum="CameraPrivacySwitchEvent" expires_after="2021-12-31"> + enum="CameraPrivacySwitchEvent" expires_after="2022-05-01"> <owner>tbarzic@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -1647,7 +1775,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Media.CameraPrivacySwitch.TimeFromNotificationToOff" - units="5 seconds" expires_after="2021-12-31"> + units="5 seconds" expires_after="2022-05-01"> <owner>tbarzic@chromium.org</owner> <owner>gzadina@google.com</owner> <summary> @@ -1737,7 +1865,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.NightLight.AutoNightLightNotificationState" - enum="AshAutoNightLightNotificationState" expires_after="2022-01-30"> + enum="AshAutoNightLightNotificationState" expires_after="2022-05-01"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -1759,7 +1887,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.NightLight.ScheduleType" enum="AshNightLightScheduleType" - expires_after="2022-01-16"> + expires_after="2022-04-24"> <owner>afakhry@chromium.org</owner> <summary> The selected Night Light schedule type. Emitted when the user changes the @@ -1827,7 +1955,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.NumberOfVisibleWindowsInPrimaryDisplay" units="Windows" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>jamescook@chromium.org</owner> <summary> An upper bound on the number of windows visible to the user on the primary @@ -1838,7 +1966,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Ash.Overview.AnimationSmoothness.Close" units="%" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="TabletOrClamshellMode" --> @@ -1952,7 +2080,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Overview.Scroll.PresentationTime.TabletMode" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>sammiequon@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -2074,6 +2202,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Ash.PersistentWindow.NumOfWindowsRestored" units="units" expires_after="M82"> + <obsolete> + Expired on M82. Marked as obsolete on 10/2021. Replaced by + Ash.PersistentWindow.NumOfWindowsRestoredOnDisplayAdded. + </obsolete> <owner>zentaro@chromium.org</owner> <owner>cros-peripherals@google.com</owner> <summary> @@ -2083,6 +2215,27 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Ash.PersistentWindow.NumOfWindowsRestoredOnDisplayAdded" + units="units" expires_after="2022-10-31"> + <owner>minch@chromium.org</owner> + <owner>fanafan@chromium.org</owner> + <summary> + The number of windows restored in multi-display scenario, such as due to + disconnecting and reconnecting display, enabling and disabling mirror mode, + entering and leaving dock mode. Zero is not recorded. + </summary> +</histogram> + +<histogram name="Ash.PersistentWindow.NumOfWindowsRestoredOnScreenRotation" + units="units" expires_after="2022-10-31"> + <owner>minch@chromium.org</owner> + <owner>fanafan@chromium.org</owner> + <summary> + Emits the number of windows bounds restored when rotating the screen back to + the previous screen orientation. Zero is not recorded. + </summary> +</histogram> + <histogram name="Ash.PhoneHub.InterstitialScreenEvent.{Screen}" enum="PhoneHubInterstitialScreenEvent" expires_after="2021-10-31"> <obsolete> @@ -2205,13 +2358,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Pip.AndroidPipUseTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>takise@chromium.org</owner> <owner>linben@chromium.org</owner> <summary>How long Android PIP was used for, upon ending the session.</summary> </histogram> -<histogram name="Ash.Pip.Events" enum="AshPipEvents" expires_after="2021-12-19"> +<histogram name="Ash.Pip.Events" enum="AshPipEvents" expires_after="2022-04-17"> <owner>takise@chromium.org</owner> <owner>linben@chromium.org</owner> <summary> @@ -2264,7 +2417,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <owner>tobyhuang@chromium.org</owner> <owner>yilkal@chromium.org</owner> <owner>llin@chromium.org</owner> - <owner>cros-families-eng@google.com</owner> + <owner>cros-projector@google.com</owner> <summary> Recorded whenever the user chooses a marker color on the Projector toolbar in {TabletOrClamshell}. @@ -2277,7 +2430,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <owner>tobyhuang@chromium.org</owner> <owner>yilkal@chromium.org</owner> <owner>llin@chromium.org</owner> - <owner>cros-families-eng@google.com</owner> + <owner>cros-projector@google.com</owner> <summary> Recorded whenever the user opens, closes, or presses a button the Projector toolbar in {TabletOrClamshell}. @@ -2286,7 +2439,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Rotation.AnimationSmoothness" units="%" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>oshima@chromium.org</owner> <owner>wutao@chromium.org</owner> <summary> @@ -2363,7 +2516,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Shelf.NumberOfItems" units="Icons" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>anasalazar@google.com</owner> <owner>mmourgos@google.com</owner> <summary> @@ -2373,7 +2526,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Shelf.NumberOfPinnedItems" units="Icons" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>anasalazar@google.com</owner> <owner>mmourgos@google.com</owner> <summary> @@ -2452,7 +2605,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Shelf.Palette.Assistant.GestureType" - enum="AssistantGestureType" expires_after="2021-12-12"> + enum="AssistantGestureType" expires_after="2022-05-01"> <owner>amehfooz@chromium.org</owner> <owner>cros-status-area@google.com</owner> <owner>gzadina@chromium.org</owner> @@ -2517,7 +2670,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Shelf.Palette.Usage" enum="PaletteTrayOptions" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>amehfooz@chromium.org</owner> <owner>cros-status-area@google.com</owner> <owner>gzadina@chromium.org</owner> @@ -2732,7 +2885,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.SplitView.TimeInSplitView" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>xdai@chromium.org</owner> <summary> The amount of time that the user spent in split view mode. The time is @@ -2764,7 +2917,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.SplitViewResize.AnimationSmoothness.DividerAnimation" - units="%" expires_after="2021-12-26"> + units="%" expires_after="2022-04-17"> <owner>sammiequon@chromium.org</owner> <owner>xdai@chromium.org</owner> <summary> @@ -2826,7 +2979,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.SwipeDownDrag.Tab.PresentationTime.MaxLatency.TabletMode" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2022-06-30"> <owner>xdai@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -2836,7 +2989,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.SwipeDownDrag.Tab.PresentationTime.TabletMode" units="ms" - expires_after="2021-12-19"> + expires_after="2022-06-30"> <owner>xdai@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary>Presentation time while dragging a tab in tablet mode.</summary> @@ -2844,7 +2997,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Ash.SwipeDownDrag.Window.PresentationTime.MaxLatency.TabletMode" - units="ms" expires_after="2021-10-18"> + units="ms" expires_after="2022-06-30"> <owner>xdai@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -2854,7 +3007,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.SwipeDownDrag.Window.PresentationTime.TabletMode" - units="ms" expires_after="2021-10-18"> + units="ms" expires_after="2022-06-30"> <owner>xdai@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -2863,7 +3016,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.SwipeHomeToOverviewGesture" - enum="SwipeHomeToOverviewResult" expires_after="2021-12-12"> + enum="SwipeHomeToOverviewResult" expires_after="2022-05-01"> <owner>andrewxu@chromium.org</owner> <owner>tbarzic@chromium.org</owner> <summary> @@ -2873,7 +3026,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.SystemMenu.DefaultView.VisibleRows" - enum="SystemMenuDefaultViewRows" expires_after="2021-12-12"> + enum="SystemMenuDefaultViewRows" expires_after="2022-04-24"> <owner>amehfooz@chromium.org</owner> <owner>cros-status-area@google.com</owner> <owner>gzadina@chromium.org</owner> @@ -2935,7 +3088,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.TabletMode.AnimationSmoothness.Enter" units="%" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>oshima@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2946,7 +3099,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.TabletMode.AnimationSmoothness.Exit" units="%" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>oshima@chromium.org</owner> <owner>sammiequon@chromium.org</owner> <summary> @@ -2991,7 +3144,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.TouchView.LidAngle" units="degrees" - expires_after="2021-12-05"> + expires_after="2022-04-03"> <owner>oshima@chromium.org</owner> <summary> Chrome OS only. The computed angle between the lid and the keyboard panel. @@ -3002,7 +3155,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.TouchView.TouchViewActive" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-03"> <owner>girard@chromium.org</owner> <summary> The length of time that TouchView is active, for each activation. @@ -3010,25 +3163,25 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.TouchView.TouchViewActivePercentage" units="%" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>girard@chromium.org</owner> <summary>The proportion of time spent in TouchView during a session.</summary> </histogram> <histogram name="Ash.TouchView.TouchViewActiveTotal" units="minutes" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>girard@chromium.org</owner> <summary>The total time that TouchView is active during a session.</summary> </histogram> <histogram name="Ash.TouchView.TouchViewInactive" units="ms" - expires_after="2021-11-21"> + expires_after="2022-04-03"> <owner>girard@chromium.org</owner> <summary>The length of time between TouchView activations.</summary> </histogram> <histogram name="Ash.TouchView.TouchViewInactiveTotal" units="minutes" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>girard@chromium.org</owner> <summary> The total time that TouchView is not active during a session. @@ -3050,7 +3203,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Ash.UnlockAnimation.Jank" units="%" - expires_after="2021-12-10"> + expires_after="2022-04-17"> <owner>oshima@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <!-- Name completed by histogram_suffixes @@ -3063,7 +3216,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Ash.UnlockAnimation.Smoothness" units="%" - expires_after="2021-12-10"> + expires_after="2022-04-17"> <owner>oshima@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <!-- Name completed by histogram_suffixes @@ -3075,6 +3228,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Ash.UserDataStatsRecorder.DataSize.TotalSize" units="MB" + expires_after="M101"> + <owner>ythjkt@chromium.org</owner> + <owner>hidehiko@chromium.org</owner> + <summary> + Records the size of the entire profile data directory. Collected upon + launching ash chrome. + </summary> +</histogram> + <histogram name="Ash.UserDataStatsRecorder.DataSize.{ItemName}" units="MB" expires_after="M101"> <owner>ythjkt@chromium.org</owner> @@ -3092,6 +3255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="AutofillStrikeDatabase"/> <variant name="BlobStorage"/> <variant name="Bookmarks"/> + <variant name="BrowserDataMigrator"/> <variant name="BudgetDatabase"/> <variant name="Cache"/> <variant name="CodeCache"/> @@ -3194,7 +3358,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Wallpaper.CustomLayout" enum="WallpaperLayout" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>xdai@chromium.org</owner> <summary> The custom wallpaper layout type. Recorded when the user sets a new custom @@ -3223,7 +3387,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Wallpaper.Source" enum="WallpaperType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>xdai@chromium.org</owner> <summary> Recorded when a new wallpaper is set, either by the built-in Wallpaper @@ -3233,13 +3397,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.Wallpaper.Type" enum="WallpaperType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>kuscher@google.com</owner> <summary>The wallpaper type. Recorded at user login.</summary> </histogram> <histogram name="Ash.Window.AnimationSmoothness.CrossFade" units="%" - expires_after="2021-12-05"> + expires_after="2022-04-10"> <owner>wutao@chromium.org</owner> <summary> Relative smoothness of cross fade animation when setting window bounds. 100% @@ -3317,7 +3481,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.WindowCycleController.DesksSwitchDistance" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>afakhry@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <summary> @@ -3341,7 +3505,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.WindowCycleController.Items" units="items" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>sammiequon@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <owner>xdai@chromium.org</owner> @@ -3376,7 +3540,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.WindowCycleController.TimeBetweenTaskSwitches" - units="seconds" expires_after="2021-12-12"> + units="seconds" expires_after="2022-04-17"> <owner>sammiequon@chromium.org</owner> <owner>tclaiborne@chromium.org</owner> <owner>xdai@chromium.org</owner> @@ -3387,7 +3551,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.WindowCycleView.AnimationSmoothness.Container" units="%" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>yjliu@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <summary> @@ -3399,7 +3563,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.WindowCycleView.AnimationSmoothness.Show" units="%" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>yjliu@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <summary> @@ -3411,7 +3575,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Ash.WindowDragFromShelfResult" enum="ShelfWindowDragResult" - expires_after="2021-08-09"> + expires_after="M106"> <owner>andrewxu@chromium.org</owner> <owner>tbarzic@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/assistant/histograms.xml b/chromium/tools/metrics/histograms/metadata/assistant/histograms.xml index 555619f7f15..f8bdee99d78 100644 --- a/chromium/tools/metrics/histograms/metadata/assistant/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/assistant/histograms.xml @@ -54,7 +54,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="Assistant.BetterOnboarding.Click" - enum="AssistantBetterOnboardingType" expires_after="2022-01-23"> + enum="AssistantBetterOnboardingType" expires_after="2022-05-01"> <owner>xiaohuic@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -82,7 +82,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.ContextEnabledUserCount" enum="BooleanEnabled" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>updowndota@chromium.org</owner> <owner>xiaohuic@chromium.org</owner> <summary> @@ -94,7 +94,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.DspHotwordDetection" - enum="DspHotwordDetectionStatus" expires_after="2022-02-06"> + enum="DspHotwordDetectionStatus" expires_after="2022-04-10"> <owner>meilinw@chromium.org</owner> <owner>xiaohuic@chromium.org</owner> <summary> @@ -113,11 +113,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.ExitPoint" enum="AssistantExitPoint" - expires_after="2021-08-22"> + expires_after="2022-08-09"> <owner>xiaohuic@chromium.org</owner> <owner>meilinw@chromium.org</owner> <summary> Record the Assistant exit point where Assistant UI becomes invisible. + ChromeOS only. </summary> </histogram> @@ -143,7 +144,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.OptInFlow.GetSettingsRequestTime" units="ms" - expires_after="2021-09-05"> + expires_after="2022-09-01"> <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -154,7 +155,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.OptInFlow.LoadingTimeoutCount" units="timeouts" - expires_after="2021-10-04"> + expires_after="2022-09-01"> <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -165,7 +166,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.OptInFlowStatus" enum="AssistantOptInFlowStatus" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary>Record the status of the Assistant opt-in flow.</summary> @@ -186,7 +187,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.QuerySource" enum="AssistantQuerySource" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>xiaohuic@chromium.org</owner> <owner>meilinw@chromium.org</owner> <summary> @@ -196,7 +197,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.ServiceEnabledUserCount" enum="BooleanEnabled" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>xiaohuic@chromium.org</owner> <owner>meilinw@chromium.org</owner> <summary> @@ -208,9 +209,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.ServiceReadyTime" units="ms" - expires_after="2021-08-29"> + expires_after="2022-08-29"> <owner>xiaohuic@chromium.org</owner> - <owner>jeroendh@google.com</owner> <summary> Amount of time between when the Assistant service is launched, and when the Assistant back-end signals it is ready to process queries. @@ -218,13 +218,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.ServiceStartTime" units="ms" - expires_after="2021-08-29"> + expires_after="2022-08-29"> <owner>updowndota@chromium.org</owner> <summary>Amount of time spent in starting Assistant service.</summary> </histogram> <histogram name="Assistant.SetDspHotwordLocale" enum="BooleanSuccess" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>meilinw@chromium.org</owner> <owner>xiaohuic@chromium.org</owner> <summary> @@ -259,7 +259,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.VoiceSearch.UserEligibility.FailureReason{Timing}" - enum="EligibilityFailureReason" expires_after="2021-08-22"> + enum="EligibilityFailureReason" expires_after="2022-08-22"> <owner>wylieb@chromium.org</owner> <owner>fgorski@chromium.org</owner> <owner>jds@google.com</owner> @@ -280,7 +280,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Assistant.VoiceSearch.UserEligibility{Timing}" - enum="BooleanEligible" expires_after="2021-08-22"> + enum="BooleanEligible" expires_after="2022-08-22"> <owner>wylieb@chromium.org</owner> <owner>fgorski@chromium.org</owner> <owner>jds@google.com</owner> @@ -294,7 +294,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.ActiveImpression" enum="QuickAnswersResultType" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>llin@google.com</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -319,7 +319,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.Click" enum="QuickAnswersResultType" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>llin@google.com</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -342,7 +342,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.Consent" units="impressions" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>llin@google.com</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -392,8 +392,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.ContextMenu.Close" enum="BooleanClicked" - expires_after="2022-01-09"> - <owner>updowndota@google.com</owner> + expires_after="2022-04-10"> + <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> Records whether or not the user interacted (via clicking) with a context @@ -430,7 +430,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.Intent" enum="QuickAnswersIntentType" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>llin@google.com</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -459,8 +459,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.NetworkError.IntentType" - enum="QuickAnswersIntentType" expires_after="2022-01-02"> - <owner>updowndota@google.com</owner> + enum="QuickAnswersIntentType" expires_after="2022-05-01"> + <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> Records the intent type when network error occurs during the quick answers @@ -469,8 +469,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.RequestTextLength.{IntentType}" - units="characters" expires_after="2021-08-29"> - <owner>updowndota@google.com</owner> + units="characters" expires_after="2022-09-01"> + <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> For every quick answer request, records the length of the selected text that @@ -484,7 +484,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.Result" enum="QuickAnswersResultType" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>llin@google.com</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -508,7 +508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="QuickAnswers.SelectedContent.Length" units="characters" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>llin@google.com</owner> <owner>croissant-eng@chromium.org</owner> <summary> @@ -519,7 +519,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="QuickAnswers.V2.Consent" units="impressions" expires_after="2022-09-01"> - <owner>updowndota@google.com</owner> + <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> For every quick answers consent impression, records how many times the user @@ -530,7 +530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="QuickAnswers.V2.Consent.Duration{QuickAnswersV2ConsentResultType}" units="ms" expires_after="2022-09-01"> - <owner>updowndota@google.com</owner> + <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> For every quick answers consent result event, records how long the user has @@ -543,7 +543,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="QuickAnswers.V2.Consent.Impression{QuickAnswersV2ConsentResultType}" units="impressions" expires_after="2022-09-01"> - <owner>updowndota@google.com</owner> + <owner>updowndota@chromium.org</owner> <owner>croissant-eng@chromium.org</owner> <summary> For every quick answers consent result event, records how many times the diff --git a/chromium/tools/metrics/histograms/metadata/autofill/histograms.xml b/chromium/tools/metrics/histograms/metadata/autofill/histograms.xml index e7dd4ff5f8d..14a9393c98f 100644 --- a/chromium/tools/metrics/histograms/metadata/autofill/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/autofill/histograms.xml @@ -47,12 +47,29 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. summary="CVC fallback from FIDO authentication"/> <variant name="CvcThenFido" summary="CVC followed by FIDO authentication"/> <variant name="Fido" summary="FIDO authentication only"/> + <variant name="Otp" summary="OTP auth only"/> + <variant name="OtpFallbackFromFido" + summary="OTP fallback from FIDO authentication"/> +</variants> + +<variants name="Autofill.DialogError"> + <variant name="WithNoTemporaryError" + summary="No temporary error has been shown in the dialog"/> + <variant name="WithPreviousTemporaryError" + summary="A temporary error has been shown in the dialog"/> </variants> <variants name="Autofill.OfferNotification.Type"> <variant name="CardLinkedOffer" summary="The bubble/infobar for an offer that is linked to a credit card."/> + <variant name="FreeListingCouponOffer" + summary="The bubble/infobar for a merchant promo code offer sourced + from the FreeListingCouponService."/> +</variants> + +<variants name="Autofill.OtpAuth.Type"> + <variant name="SmsOtp" summary="The OTP authentication with a SMS OTP."/> </variants> <variants name="Autofill.PaymentBubble.Show"> @@ -77,11 +94,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. summary="Request failed in retrieving the virtual card information."/> </variants> +<variants name="Autofill.ProgressDialog.FlowType"> + <variant name="CardUnmask" + summary="Progress dialog for the VCN Card Unmask Flow"/> +</variants> + <variants name="Autofill.Snackbar.Type"> <variant name="VirtualCard" summary="Snackbar shown after virtual card is autofilled."/> </variants> +<variants name="Autofill.VirtualCardUnmaskFlowType"> + <variant name="Fido" summary="FIDO authentication only"/> + <variant name="Otp" summary="OTP auth only"/> + <variant name="OtpFallbackFromFido" + summary="OTP fallback from FIDO authentication"/> +</variants> + <variants name="AutofillCreditCardWebauthnOptInOrigin"> <variant name=".FromCheckoutFlow" summary="Opt-in from a checkout flow"/> <variant name=".FromSettingsPage" summary="Opt-in from settings page"/> @@ -177,7 +206,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Address.IsEnabled.PageLoad" enum="BooleanEnabled" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>jsaul@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -187,7 +216,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Address.IsEnabled.Startup" enum="BooleanEnabled" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>jsaul@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -196,7 +225,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.AddressesDeletedForDisuse" units="addresses" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -207,7 +236,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.AddressesSuppressedForDisuse" units="addresses" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -221,7 +250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.AddressProfileImportCountrySpecificFieldRequirements" enum="AutofillAddressProfileImportCountrySpecificFieldRequirement" - expires_after="2022-01-09"> + expires_after="2022-12-12"> <owner>koerber@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -232,7 +261,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.AddressProfileImportRequirements" - enum="AutofillAddressProfileImportRequirement" expires_after="2022-01-09"> + enum="AutofillAddressProfileImportRequirement" expires_after="2022-12-12"> <owner>koerber@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -242,7 +271,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.AddressProfileImportStatus" - enum="AutofillAddressProfileImportStatus" expires_after="2022-01-09"> + enum="AutofillAddressProfileImportStatus" expires_after="2022-12-12"> <owner>koerber@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -251,7 +280,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.AddressSuggestionsCount" units="units" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -261,7 +290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.AddressTokenVerificationStatusAtProfileUsage.{AddressType}" - enum="AufofillStructuredTokenVerificationStatus" expires_after="M96"> + enum="AufofillStructuredTokenVerificationStatus" expires_after="M100"> <owner>koerber@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -376,9 +405,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.CardUnmaskDuration.Fido.{CardType}.{Result}" - units="ms" expires_after="2021-10-04"> + units="ms" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks the time it takes to fetch the full PAN of a credit card once user @@ -390,9 +419,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.CardUnmaskDuration.Fido{AutofillRealPanResultGroups}" - units="ms" expires_after="2021-12-05"> + units="ms" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks the time it takes to fetch the full PAN of a credit card once user @@ -405,9 +434,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.BetterAuth.CardUnmaskPreflightCalled" - enum="BooleanHit" expires_after="2021-12-05"> + enum="BooleanHit" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks the number of times Chrome made a GetDetailsForGetRealPan call. A @@ -422,9 +451,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.BetterAuth.CardUnmaskPreflightDuration" units="ms" - expires_after="2021-12-05"> + expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracking the latency of a GetDetailsForGetRealPan call to Payments servers. @@ -435,9 +464,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.BetterAuth.CardUnmaskTypeDecision" - enum="AutofillCreditCardUnmaskDecisionMetric" expires_after="2021-12-05"> + enum="AutofillCreditCardUnmaskDecisionMetric" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> If the user is definitely opted-in to the new auth flow, Payments sends a @@ -449,9 +478,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.FlowEvents.{BetterAuthFlowType}.{CardType}" - enum="AutofillCreditCardAuthenticationEvents" expires_after="2021-12-05"> + enum="AutofillCreditCardAuthenticationEvents" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks when a user completes each step in a card unmasking flow per @@ -464,9 +493,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.FlowEvents{AutofillCreditCardAuthenticationFlows}" - enum="AutofillCreditCardAuthenticationEvents" expires_after="2021-12-05"> + enum="AutofillCreditCardAuthenticationEvents" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks when a user completes each step in a card unmasking flow per @@ -485,9 +514,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.OptInCalled{AutofillCreditCardWebauthnOptInOrigin}" - enum="AutofillCreditCardWebauthnOptInParameters" expires_after="2021-12-05"> + enum="AutofillCreditCardWebauthnOptInParameters" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks when users opt-in either from the settings page or from a checkout @@ -508,9 +537,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.OptInPromoShown{AutofillCreditCardWebauthnOptInOrigin}" - enum="BooleanHit" expires_after="2021-10-04"> + enum="BooleanHit" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Logs the number of times the opt-in promo to use FIDO authentication for @@ -537,9 +566,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.OptInPromoUserDecision{AutofillCreditCardWebauthnOptInOrigin}" - enum="AutofillWebauthnOptInPromoUserDecision" expires_after="2021-12-05"> + enum="AutofillWebauthnOptInPromoUserDecision" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks the user response to the opt-in promo for using FIDO authentication @@ -559,9 +588,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.BetterAuth.OptOutCalled.FromSettingsPage" - enum="BooleanHit" expires_after="2021-12-05"> + enum="BooleanHit" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks the number of times UpdateAutofillUserPreference has been called with @@ -576,9 +605,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.UserPerceivedLatencyOnCardSelection.OptedIn.Duration" - units="ms" expires_after="2021-10-04"> + units="ms" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> The GetDetailsForGetRealPan call is made when card suggestions are shown. @@ -592,9 +621,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.UserPerceivedLatencyOnCardSelection.OptedIn.TimedOutCvcFallback" enum="AutofillCreditCardUserPerceivedLatencyFollowUp" - expires_after="2021-10-04"> + expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> The GetDetailsForGetRealPan call is made when card suggestions are shown. If @@ -607,9 +636,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.UserPerceivedLatencyOnCardSelection{AutofillFidoAuthenticationEnabledState}" - enum="AutofillCreditCardPreflightCallEvent" expires_after="2021-12-05"> + enum="AutofillCreditCardPreflightCallEvent" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> The GetDetailsForGetRealPan call is made when card suggestions are shown. @@ -630,9 +659,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.BetterAuth.UserVerifiabilityCheckDuration" units="ms" - expires_after="2021-10-04"> + expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> Tracks how long it takes to check that the user is verifiable through @@ -643,9 +672,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.BetterAuth.WebauthnResult{AutofillFidoUserVerificationFlow}" - enum="AutofillCreditCardWebauthnResultMetric" expires_after="2021-12-05"> + enum="AutofillCreditCardWebauthnResultMetric" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <owner>autofill-auth-team@google.com</owner> <summary> This metric tracks the result of the WebAuthn prompt when the user attempts @@ -697,8 +726,34 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Autofill.CardUnmaskAuthenticationSelectionDialog.Result" + enum="AutofillCardUnmaskAuthenticationSelectionDialogResult" + expires_after="2022-04-01"> + <owner>siyua@chromium.org</owner> + <owner>jsaul@google.com</owner> + <owner>siashah@chromium.org</owner> + <summary> + Records the result of the Card Unmask Authentication Selection Dialog, such + as user cancelation before/after selecting a challenge option, or automatic + dismissal after a server success/failure for a selected option was returned. + The metric is recorded any time the dialog is dismissed. + </summary> +</histogram> + +<histogram name="Autofill.CardUnmaskAuthenticationSelectionDialog.Shown" + enum="BooleanShown" expires_after="2022-04-01"> + <owner>siyua@chromium.org</owner> + <owner>jsaul@google.com</owner> + <owner>siashah@chromium.org</owner> + <summary> + Records true every time the card unmask challenge option selection dialog + was shown. This dialog is shown when a user needs to select a challenge + option to authenticate a card for payments autofill. + </summary> +</histogram> + <histogram name="Autofill.CardUploadDecisionMetric" - enum="AutofillCardUploadDecisionMetric" expires_after="2021-12-05"> + enum="AutofillCardUploadDecisionMetric" expires_after="2022-04-10"> <owner>jsaul@google.com</owner> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> @@ -710,9 +765,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.CardUploadEnabled" enum="AutofillCardUploadEnabled" - expires_after="2021-10-10"> - <owner>aneeshali@google.com</owner> + expires_after="2022-08-01"> <owner>jsaul@google.com</owner> + <owner>aneeshali@google.com</owner> <summary> Detailed reasons why (or why not) card upload was enabled. When a user submits a form, this check is triggered to decide whether to ask the user if @@ -721,7 +776,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.CreditCard.IsEnabled.PageLoad" enum="BooleanEnabled" - expires_after="2021-12-12"> + expires_after="2022-08-01"> <owner>jsaul@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -731,7 +786,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.CreditCard.IsEnabled.Startup" enum="BooleanEnabled" - expires_after="2021-10-10"> + expires_after="2022-08-01"> <owner>jsaul@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -740,7 +795,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.CreditCardFillingInfoBar" - enum="AutofillCreditCardInfoBar" expires_after="M95"> + enum="AutofillCreditCardInfoBar" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -750,7 +805,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.CreditCardInfoBar{AutofillCreditCardInfoBarSaveType}" - enum="AutofillCreditCardInfoBar" expires_after="2021-12-12"> + enum="AutofillCreditCardInfoBar" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>jsaul@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -797,7 +852,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.CreditCardsDeletedForDisuse" units="units" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>jsaul@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -808,7 +863,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.CreditCardsSuppressedForDisuse" units="units" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>jsaul@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -831,7 +886,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.DaysSinceLastUse.CreditCard" units="days" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -841,7 +896,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.DaysSinceLastUse.Profile" units="days" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -852,7 +907,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.DaysSinceLastUse.StoredCreditCard" units="days" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <!-- Name completed by histogram_suffixes name="AutofillCreditCardType" --> @@ -865,7 +920,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.DaysSinceLastUse.StoredProfile" units="days" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -877,7 +932,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.DeveloperEngagement" - enum="AutofillDeveloperEngagement" expires_after="M95"> + enum="AutofillDeveloperEngagement" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -888,7 +943,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.EditedAutofilledFieldAtSubmission.Aggregate" - enum="AutofilledFieldUserEditingStatus" expires_after="2022-01-09"> + enum="AutofilledFieldUserEditingStatus" expires_after="2022-12-12"> <owner>koerber@google.com</owner> <owner>battre@google.com</owner> <summary> @@ -899,7 +954,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.EditedAutofilledFieldAtSubmission.ByFieldType" enum="AutofilledFieldUserEditingStatusByFieldType" - expires_after="2022-01-09"> + expires_after="2022-12-12"> <owner>koerber@google.com</owner> <owner>battre@google.com</owner> <summary> @@ -918,7 +973,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ExpirationDateFixFlowPrompt.Events" - enum="AutofillExpirationDateFixFlowPromptEvent" expires_after="2021-10-04"> + enum="AutofillExpirationDateFixFlowPromptEvent" expires_after="2022-08-01"> <owner>siashah@google.com</owner> <owner>jsaul@google.com</owner> <owner>payments-autofill-team@google.com</owner> @@ -930,7 +985,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ExpirationDateFixFlowPromptShown" enum="Boolean" - expires_after="2021-10-17"> + expires_after="2022-08-01"> <owner>siashah@google.com</owner> <owner>jsaul@google.com</owner> <owner>payments-autofill-team@google.com</owner> @@ -939,7 +994,32 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Autofill.FieldCount" units="form fields" expires_after="M95"> +<histogram + name="Autofill.ExtractNewForms.ShallowEqualityDiffersFromDeepEquality" + enum="FormDataEquality" expires_after="2022-09-30"> + <owner>evih@google.com</owner> + <owner>schwering@google.com</owner> + <owner>chrome-autofill-alerts@google.com</owner> + <summary> + In UpdateFormCache(), we compare FormData structs to re-extract changed + ones. This metric records: + + - the number of times the shallow comparison is enough to identify a + difference between the forms; + + - the number of times the deep comparison finds a difference between the + forms, but the shallow does not; + + - the number of times none of the comparisons find a difference, i.e. the + forms are equal. + + The metric takes into account every comparison of FormData structs in + UpdateFormCache(). + </summary> +</histogram> + +<histogram name="Autofill.FieldCount" units="form fields" + expires_after="2022-12-12"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -948,7 +1028,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.FieldPredictionQuality.Aggregate{AutofillFieldPredictionSource}" - enum="AutofillFieldPredictionQuality" expires_after="2021-12-12"> + enum="AutofillFieldPredictionQuality" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -964,7 +1044,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.FieldPredictionQuality.ByFieldType{AutofillFieldPredictionSource}" - enum="AutofillFieldPredictionQualityByFieldType" expires_after="2021-12-12"> + enum="AutofillFieldPredictionQualityByFieldType" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -979,7 +1059,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.FieldPrediction{AutofillFieldPredictionSource}" - units="units" expires_after="2021-12-12"> + units="units" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -996,7 +1076,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.FillDuration.FromInteraction.WithAutofill{AutofillFormType}" - units="units" expires_after="2021-12-12"> + units="units" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1012,7 +1092,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.FillDuration.FromInteraction.WithoutAutofill{AutofillFormType}" - units="units" expires_after="2021-12-12"> + units="units" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1027,7 +1107,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.FillDuration.FromLoad.WithAutofill" units="units" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1036,7 +1116,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.FillDuration.FromLoad.WithoutAutofill" units="units" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1045,6 +1125,37 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Autofill.FindFormControlElementByUniqueRendererIdDuration" + units="microseconds" expires_after="2022-08-31"> + <owner>evih@google.com</owner> + <owner>schwering@google.com</owner> + <owner>chrome-autofill-alerts@google.com</owner> + <summary> + Records the time spent to determine if a form control element, given by its + unique renderer id, is in the DOM. It is done by measuring the time it takes + for FindFormControlElementByUniqueRendererId() to execute. + + Note that histogram samples for clients without high-resolution clocks are + dropped. + </summary> +</histogram> + +<histogram name="Autofill.FindFormControlElementsByUniqueRendererIdDuration" + units="microseconds" expires_after="2022-08-31"> + <owner>evih@google.com</owner> + <owner>schwering@google.com</owner> + <owner>chrome-autofill-alerts@google.com</owner> + <summary> + Records the time spent to determine if a vector of form control elements, + given by their unique renderer ids, is in the DOM. It is done by measuring + the time it takes for FindFormControlElementsByUniqueRendererId() to + execute. + + Note that histogram samples for clients without high-resolution clocks are + dropped. + </summary> +</histogram> + <histogram name="Autofill.FormCacheSize" units="forms" expires_after="2022-05-31"> <owner>evih@google.com</owner> @@ -1058,7 +1169,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.FormEvents.Address{AutofillDataAvailability}" - enum="AutofillFormEvent" expires_after="2021-12-12"> + enum="AutofillFormEvent" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>jsaul@google.com</owner> <summary> @@ -1174,7 +1285,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.FormFillSuccessIOS" - enum="BooleanAutofillFormFillSuccessIOS" expires_after="2022-01-02"> + enum="BooleanAutofillFormFillSuccessIOS" expires_after="2022-12-12"> <owner>kazinova@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1183,7 +1294,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.FormSubmission.PerProfileType" - enum="BrowserProfileType" expires_after="2022-02-02"> + enum="BrowserProfileType" expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -1193,14 +1304,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.FormSubmittedState" enum="AutofillFormSubmittedState" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary>The autofill state related to a submitted form.</summary> </histogram> <histogram name="Autofill.Funnel.FillAfterSuggestion{AutofillFormType}" - enum="BooleanAutofillFillAfterSuggestion" expires_after="2022-01-09"> + enum="BooleanAutofillFillAfterSuggestion" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1226,7 +1337,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.Funnel.InteractionAfterParsedAsType{AutofillFormType}" enum="BooleanAutofillInteractionAfterParsedAsType" - expires_after="2022-01-09"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1255,7 +1366,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Funnel.ParsedAsType{AutofillFormType}" - enum="BooleanAutofillParsedAsType" expires_after="2022-01-09"> + enum="BooleanAutofillParsedAsType" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1277,7 +1388,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Funnel.SubmissionAfterFill{AutofillFormType}" - enum="BooleanAutofillSubmissionAfterFill" expires_after="2022-01-09"> + enum="BooleanAutofillSubmissionAfterFill" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1297,7 +1408,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Funnel.SuggestionAfterInteraction{AutofillFormType}" - enum="BooleanAutofillSuggestionAfterInteraction" expires_after="2022-01-09"> + enum="BooleanAutofillSuggestionAfterInteraction" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1319,6 +1430,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Autofill.GetUnownedFormFieldsDuration" units="microseconds" + expires_after="2022-07-31"> + <owner>evih@google.com</owner> + <owner>schwering@google.com</owner> + <owner>chrome-autofill-alerts@google.com</owner> + <summary> + Records the time it takes to get the unowned form field elements. This is + done by measuring the time it takes for GetUnownedFormFieldElements() to + execute. + + Note that histogram samples for clients without high-resolution clocks are + dropped. + </summary> +</histogram> + <histogram name="Autofill.HadUserOptedIn_To_WalletSyncTransportServerCards" enum="BooleanOptedIn" expires_after="2021-11-30"> <owner>jsaul@google.com</owner> @@ -1330,8 +1456,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Autofill.HasPasswordFieldDuration" units="microseconds" + expires_after="2022-08-31"> + <owner>evih@google.com</owner> + <owner>schwering@google.com</owner> + <owner>chrome-autofill-alerts@google.com</owner> + <summary> + Records the time spent to determine if there is a password field in the web + frame. It is done by measuring the time it takes for HasPasswordField() to + execute. + + Note that histogram samples for clients without high-resolution clocks are + dropped. + </summary> +</histogram> + <histogram name="Autofill.HiddenOrPresentationalSelectFieldsFilled" - enum="BooleanHiddenPresentationalAutofilled" expires_after="M95"> + enum="BooleanHiddenPresentationalAutofilled" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1353,6 +1494,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.InvalidProfileData.UsedForMetrics" enum="Boolean" expires_after="M95"> + <obsolete> + Obsolete after M95 because the invalid profile experiment is stopped. + </obsolete> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1365,6 +1509,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.InvalidProfileData.UsedForSuggestion" enum="Boolean" expires_after="M95"> + <obsolete> + Obsolete after M95 because the invalid profile experiment is stopped. + </obsolete> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1376,7 +1523,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.IsEnabled.PageLoad" enum="BooleanEnabled" - expires_after="2022-06-01"> + expires_after="2022-12-12"> <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -1390,7 +1537,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.IsEnabled.Startup" enum="BooleanEnabled" - expires_after="2022-06-01"> + expires_after="2022-12-12"> <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -1403,8 +1550,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Autofill.IsSomeControlElementVisibleDuration" + units="microseconds" expires_after="2022-08-31"> + <owner>evih@google.com</owner> + <owner>schwering@google.com</owner> + <owner>chrome-autofill-alerts@google.com</owner> + <summary> + Records the time spent to determine if at least one form control element + among the given ones is visible and is in the web frame. It is done by + measuring the time it takes for IsSomeControlElementVisible() to execute. + + Note that histogram samples for clients without high-resolution clocks are + dropped. + </summary> +</histogram> + <histogram name="Autofill.KeyMetrics.FillingAcceptance{AutofillFormType}" - enum="BooleanAutofillFillingAcceptance" expires_after="2022-01-09"> + enum="BooleanAutofillFillingAcceptance" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1424,7 +1586,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.KeyMetrics.FillingAssistance{AutofillFormType}" - enum="BooleanAutofillFillingAssistance" expires_after="2022-01-09"> + enum="BooleanAutofillFillingAssistance" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1447,7 +1609,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.KeyMetrics.FillingCorrectness{AutofillFormType}" - enum="BooleanAutofillFillingCorrectness" expires_after="2022-01-09"> + enum="BooleanAutofillFillingCorrectness" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1465,7 +1627,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.KeyMetrics.FillingReadiness{AutofillFormType}" - enum="BooleanAutofillFillingReadiness" expires_after="2022-01-09"> + enum="BooleanAutofillFillingReadiness" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1488,7 +1650,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.KeyMetrics.FormSubmission.Autofilled{AutofillFormType}" - enum="BooleanAutofillSubmission" expires_after="2022-01-09"> + enum="BooleanAutofillSubmission" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1512,7 +1674,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.KeyMetrics.FormSubmission.NotAutofilled{AutofillFormType}" - enum="BooleanAutofillSubmission" expires_after="2022-01-09"> + enum="BooleanAutofillSubmission" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> <owner>nepper@chromium.org</owner> @@ -1537,7 +1699,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.LocalCardMigrationBubbleOffer{AutofillLocalCardMigrationBubbleShow}" - enum="AutofillLocalCardMigrationBubbleOffer" expires_after="2021-11-07"> + enum="AutofillLocalCardMigrationBubbleOffer" expires_after="2022-10-01"> <owner>siyua@chromium.org</owner> <owner>jsaul@google.com</owner> <summary> @@ -1552,7 +1714,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.LocalCardMigrationBubbleResult{AutofillLocalCardMigrationBubbleShow}" - enum="AutofillLocalCardMigrationBubbleResult" expires_after="2022-03-01"> + enum="AutofillLocalCardMigrationBubbleResult" expires_after="2022-10-01"> <owner>siyua@chromium.org</owner> <owner>jsaul@google.com</owner> <summary> @@ -1627,7 +1789,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.LocalCardMigrationDialogUserSelectionPercentage" - units="%" expires_after="2022-03-01"> + units="%" expires_after="2022-05-01"> <owner>siyua@chromium.org</owner> <owner>jsaul@google.com</owner> <summary> @@ -1657,7 +1819,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.ManageCardsPrompt{AutofillManageCardsPrompt}" enum="AutofillManageCardsPrompt" expires_after="2022-06-01"> <owner>jsaul@google.com</owner> - <owner>manasverma@google.com</owner> + <owner>siyua@chromium.org</owner> <summary> The frequency of user interactions with the Manage Cards prompt. {AutofillManageCardsPrompt} @@ -1681,7 +1843,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.NameTokenVerificationStatusAtProfileUsage.{NameType}" - enum="AufofillStructuredTokenVerificationStatus" expires_after="M96"> + enum="AufofillStructuredTokenVerificationStatus" expires_after="M100"> <owner>koerber@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1701,7 +1863,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.NumberOfAutofilledFieldsAtSubmission.{AcceptanceStatus}" - units="fields" expires_after="M96"> + units="fields" expires_after="M100"> <owner>koerber@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1716,7 +1878,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.NumberOfEditedAutofilledFieldsAtSubmission" - units="fields" expires_after="M95"> + units="fields" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1726,7 +1888,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.NumberOfProfilesConsideredForDedupe" units="profiles" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1735,7 +1897,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.NumberOfProfilesRemovedDuringDedupe" units="profiles" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1744,7 +1906,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.NumElementsMatchesNumFields" enum="Boolean" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1768,7 +1930,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Offer.StoredOfferCount" units="offers" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -1778,7 +1940,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Offer.StoredOfferRelatedCardCount" units="cards" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -1788,7 +1950,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Offer.StoredOfferRelatedMerchantCount" - units="merchants" expires_after="2022-02-06"> + units="merchants" expires_after="2022-04-10"> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -1810,7 +1972,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Offer.SuggestedCardsHaveOffer" - enum="AutofillCreditCardOfferSuggestion" expires_after="2021-12-12"> + enum="AutofillCreditCardOfferSuggestion" expires_after="2022-04-24"> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -1821,7 +1983,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Offer.SyncedOfferDataBeingValid" units="offers" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -1833,6 +1995,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.OfferNotificationBubbleOffer.{BubbleType}" enum="BooleanPreviouslyShown" expires_after="2022-04-01"> <owner>siyua@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>payments-autofill-team@google.com</owner> <summary> Records whether the offer notification bubble is the first such offer that @@ -1843,9 +2006,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="Autofill.OfferNotificationBubblePromoCodeButtonClicked.{BubbleType}" + enum="BooleanClicked" expires_after="2022-04-01"> + <owner>jsaul@google.com</owner> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Records when the copy promo code button for an offer notification bubble is + clicked by the user. The subhistogram is the type of offer shown, such as + GPay promo code offer or free-listing coupon offer. + </summary> + <token key="BubbleType" variants="Autofill.OfferNotification.Type"/> +</histogram> + +<histogram name="Autofill.OfferNotificationBubbleResult.{BubbleType}.{ShowType}" enum="AutofillOfferNotificationBubbleResult" expires_after="2022-04-01"> <owner>siyua@chromium.org</owner> + <owner>jsaul@google.com</owner> <owner>payments-autofill-team@google.com</owner> <summary> Records the reason for closing the offer notification bubble. Recorded when @@ -1855,6 +2033,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="ShowType" variants="Autofill.PaymentBubble.Show"/> </histogram> +<histogram name="Autofill.OfferNotificationBubbleSuppressed.{BubbleType}" + enum="BooleanSuppressed" expires_after="2022-04-01"> + <owner>jsaul@google.com</owner> + <owner>yuezhanggg@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Records when the offer notification bubble should show but gets suppressed + due to reasons like show frequency rate control. The subhistogram is the + type of offer shown, such as GPay promo code offer or free-listing coupon + offer. + </summary> + <token key="BubbleType" variants="Autofill.OfferNotification.Type"/> +</histogram> + <histogram name="Autofill.OfferNotificationInfoBarOffer.{OfferType}" enum="BooleanShown" expires_after="2022-04-01"> <owner>siashah@chromium.org</owner> @@ -1879,10 +2072,119 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="OfferType" variants="Autofill.OfferNotification.Type"/> </histogram> +<histogram name="Autofill.OtpAuth.{OtpAuthType}.Attempt" + enum="BooleanAttempted" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Emits true when an OTP authentication starts and does not emit any value + otherwise. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram + name="Autofill.OtpAuth.{OtpAuthType}.RequestLatency.SelectChallengeOptionRequest" + units="ms" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Logs the roundtrip latency of the SelectChallengeOptionRequest in the OTP + authentication. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram + name="Autofill.OtpAuth.{OtpAuthType}.RequestLatency.UnmaskCardRequest" + units="ms" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Logs the roundtrip latency of the UnmaskCardRequest in the OTP + authentication. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram name="Autofill.OtpAuth.{OtpAuthType}.Result" + enum="AutofillOtpAuthEvent" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary>Logs the result of the OTP authentication.</summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram name="Autofill.OtpAuth.{OtpAuthType}.RetriableError" + enum="AutofillOtpAuthEvent" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Logs any retriable failure before the OTP authentication completes. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram name="Autofill.OtpInputDialog.{OtpAuthType}.ErrorMessageShown" + enum="AutofillOtpInputDialogError" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Logs the type of the error when any temporary error is shown in the card + unmask OTP dialog. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram name="Autofill.OtpInputDialog.{OtpAuthType}.NewOtpRequested" + enum="BooleanRequested" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Emits true when the "Get New Code" button is clicked and a new OTP + is requested. Doesn't emit any other value. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram name="Autofill.OtpInputDialog.{OtpAuthType}.Result" + enum="AutofillOtpInputDialogResult" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Logs the reason of the closure when the card unmask OTP dialog is closed. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + +<histogram name="Autofill.OtpInputDialog.{OtpAuthType}.Result.{WithError}" + enum="AutofillOtpInputDialogResult" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Logs the reason of the closure when the card unmask OTP dialog is closed. + This breaks down on whether any temporary error happened before the card + unmask OTP dialog was closed. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> + <token key="WithError" variants="Autofill.DialogError"/> +</histogram> + +<histogram name="Autofill.OtpInputDialog.{OtpAuthType}.Shown" + enum="BooleanShown" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Emits true when the card unmask OTP dialog is shown. Doesn't emit any other + value. + </summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + <histogram name="Autofill.PageTranslationStatus" enum="Boolean" - expires_after="2021-10-25"> - <owner>marsin@google.com</owner> + expires_after="2022-12-12"> <owner>koerber@google.com</owner> + <owner>chrome-autofill-team@google.com</owner> <summary> Tracks whether the visible page language was translated or not upon form submission. @@ -1890,7 +2192,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.PerfectFilling.{FormType}" enum="Boolean" - expires_after="M96"> + expires_after="M100"> <owner>koerber@google.com</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1910,7 +2212,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileActionOnFormSubmitted" - enum="AutofillProfileAction" expires_after="M95"> + enum="AutofillProfileAction" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -1919,7 +2221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileImport.NewProfileDecision" - enum="AutofillProfileImportDecision" expires_after="M96"> + enum="AutofillProfileImportDecision" expires_after="2022-04-17"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -1930,7 +2232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileImport.NewProfileEditedType" - enum="AutofillSettingsVisibleTypes" expires_after="M96"> + enum="AutofillSettingsVisibleTypes" expires_after="M100"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -1942,7 +2244,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileImport.NewProfileNumberOfEditedFields" - units="fields" expires_after="M96"> + units="fields" expires_after="M100"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -1952,7 +2254,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileImport.ProfileImportType" - enum="AutofillProfileImportType" expires_after="M96"> + enum="AutofillProfileImportType" expires_after="2022-04-17"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -1974,7 +2276,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileImport.UpdateProfileAffectedType" - enum="AutofillSettingsVisibleTypes" expires_after="M96"> + enum="AutofillSettingsVisibleTypes" expires_after="2022-04-17"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -1985,8 +2287,51 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Autofill.ProfileImport.UpdateProfileAffectedType.{Decision}" + enum="AutofillSettingsVisibleTypes" expires_after="M98"> + <owner>koerber@google.com</owner> + <owner>src/components/autofill/OWNERS</owner> + <summary> + Logs that a specific type would have changed in a profile update process + that received a specific {Decision}. The update was shown to the user + because a profile similar to an already existing profile was observed in a + form submission. Note that this metric collects the changed types before the + user potentially applies additional edits. The metric is recorded on form + submission once the user decision is final. + </summary> + <token key="Decision"> + <variant name="Accepted" + summary="The user accepted the update flow from the initial prompt."/> + <variant name="Any" summary="Any decision."/> + <variant name="AutoDeclined" + summary="The prompt is suppressed most likely because there is + already another prompt shown on the same tab."/> + <variant name="Declined" + summary="The user declined the update flow from the initial prompt."/> + <variant name="EditAccepted" + summary="The user accepted the update flow from the edit dialog."/> + <variant name="EditDeclined" + summary="The user declined the update flow from the edit dialog."/> + <variant name="Ignored" summary="The user ignored the prompt."/> + <variant name="MessageDeclined" + summary="The user swipes away the update Message. This is only + relevant on mobile."/> + <variant name="MessageTimeout" + summary="The update message timed out before the user interacted. + This is only relevant on mobile."/> + <variant name="Never" + summary="The user selected to never save a new profile on a given + domain or update a specific profile (currently not + supported)."/> + <variant name="Undefined" summary="Undefined"/> + <variant name="UserNotAsked" + summary="No prompt is shown and no decision is needed to proceed with + the process."/> + </token> +</histogram> + <histogram name="Autofill.ProfileImport.UpdateProfileDecision" - enum="AutofillProfileImportDecision" expires_after="M96"> + enum="AutofillProfileImportDecision" expires_after="2022-04-17"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -1998,7 +2343,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileImport.UpdateProfileEditedType" - enum="AutofillSettingsVisibleTypes" expires_after="M96"> + enum="AutofillSettingsVisibleTypes" expires_after="2022-04-17"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -2010,7 +2355,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ProfileImport.UpdateProfileNumberOfAffectedFields" - units="fields" expires_after="M96"> + units="fields" expires_after="2022-04-17"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -2021,8 +2366,50 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="Autofill.ProfileImport.UpdateProfileNumberOfAffectedFields.{Decision}" + units="fields" expires_after="M98"> + <owner>koerber@google.com</owner> + <owner>src/components/autofill/OWNERS</owner> + <summary> + Logs the number of fields that would be changed by an accepted update for + any possible Decision. Note that this metric collects the number of changed + fields before the user potentially applies additional edits. The metric is + recorded on form submission once the user decision is final. + </summary> + <token key="Decision"> + <variant name="Accepted" + summary="The user accepted the update flow from the initial prompt."/> + <variant name="Any" summary="Any decision."/> + <variant name="AutoDeclined" + summary="The prompt is suppressed most likely because there is + already another prompt shown on the same tab."/> + <variant name="Declined" + summary="The user declined the update flow from the initial prompt."/> + <variant name="EditAccepted" + summary="The user accepted the update flow from the edit dialog."/> + <variant name="EditDeclined" + summary="The user declined the update flow from the edit dialog."/> + <variant name="Ignored" summary="The user ignored the prompt."/> + <variant name="MessageDeclined" + summary="The user swipes away the update Message. This is only + relevant on mobile."/> + <variant name="MessageTimeout" + summary="The update message timed out before the user interacted. + This is only relevant on mobile."/> + <variant name="Never" + summary="The user selected to never save a new profile on a given + domain or update a specific profile (currently not + supported)."/> + <variant name="Undefined" summary="Undefined"/> + <variant name="UserNotAsked" + summary="No prompt is shown and no decision is needed to proceed with + the process."/> + </token> +</histogram> + <histogram name="Autofill.ProfileImport.UpdateProfileNumberOfEditedFields" - units="fields" expires_after="M96"> + units="fields" expires_after="2022-04-17"> <owner>koerber@google.com</owner> <owner>src/components/autofill/OWNERS</owner> <summary> @@ -2043,8 +2430,43 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Autofill.ProgressDialog.{FlowType}.Result" + enum="BooleanCanceled" expires_after="2022-04-01"> + <owner>siashah@chromium.org</owner> + <owner>siyua@chromium.org</owner> + <owner>jsaul@google.com</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Records the result of the progress dialog, which can either be canceled + (user canceled while it was in progress) or not canceled (user waited until + confirmation). This dialog is shown in between other dialogs in a flow to + provide a progress state to the user. If the user does not cancel it, after + its related background task completes it moves on to the next dialog in the + flow that it is a part of. The metric is recorded when this dialog is + dismissed, and the result that gets logged is false if the user waited until + confirmation or true if the user canceled the dialog. + </summary> + <token key="FlowType" variants="Autofill.ProgressDialog.FlowType"/> +</histogram> + +<histogram name="Autofill.ProgressDialog.{FlowType}.Shown" enum="BooleanShown" + expires_after="2022-04-01"> + <owner>siashah@chromium.org</owner> + <owner>siyua@chromium.org</owner> + <owner>jsaul@google.com</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Records true every time the progress dialog is shown. This dialog is shown + in between other dialogs in a payments autofill flow to provide a progress + state to the user. If the user does not cancel it, after its related + background task completes it moves on to the next dialog in the flow that it + is a part of. + </summary> + <token key="FlowType" variants="Autofill.ProgressDialog.FlowType"/> +</histogram> + <histogram name="Autofill.QueriedCreditCardFormIsSecure" enum="BooleanSecure" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2054,7 +2476,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Query.BackoffDelay" units="ms" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2063,7 +2485,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Query.FailingPayloadSize" units="bytes" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2075,7 +2497,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Query.HttpResponseOrErrorCode" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-12-12"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2084,20 +2506,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Query.Method" enum="AutofillQueryMethod" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary>The HTTP method used to query the autofill server.</summary> </histogram> -<histogram name="Autofill.Query.RequestDuration" units="ms" expires_after="M95"> +<histogram name="Autofill.Query.RequestDuration" units="ms" + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary>The duration of a network request for a query.</summary> </histogram> <histogram name="Autofill.Query.WasInCache" enum="BooleanCacheHit" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2106,7 +2529,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.RationalizationQuality.PhoneNumber" - enum="AutofillRationalizationQualityMetric" expires_after="M95"> + enum="AutofillRationalizationQualityMetric" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2195,14 +2618,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ScanCreditCard.Completed" enum="BooleanCompleted" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary>Whether a credit card scan was completed or cancelled.</summary> </histogram> <histogram name="Autofill.ScanCreditCard.Duration{CreditCardScanSuccess}" - units="ms" expires_after="M95"> + units="ms" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2216,7 +2639,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ScanCreditCardPrompt" - enum="AutofillScanCreditCardPrompt" expires_after="2021-12-12"> + enum="AutofillScanCreditCardPrompt" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>jsaul@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -2224,7 +2647,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.ServerCardLinkClicked" enum="AutofillSyncState" - expires_after="2022-06-01"> + expires_after="2022-12-12"> <owner>jsaul@google.com</owner> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -2234,15 +2657,51 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Autofill.ServerCardUnmask.{CardType}.Attempt" + enum="BooleanAttempted" expires_after="2022-04-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Emits true when a server card unmasking process starts and does not emit any + value otherwise. + </summary> + <token key="CardType" variants="Autofill.PaymentsRpcCardType"/> +</histogram> + +<histogram name="Autofill.ServerCardUnmask.{CardType}.FormSubmission" + enum="BooleanSubmitted" expires_after="2022-04-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Emits true when a form is submitted with information fetched in a server + card unmasking process, and does not emit any value otherwise. + </summary> + <token key="CardType" variants="Autofill.PaymentsRpcCardType"/> +</histogram> + +<histogram name="Autofill.ServerCardUnmask.{CardType}.Result.{FlowType}" + enum="AutofillServerCardUnmaskResult" expires_after="2022-04-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary> + Logs the result of a server card unmasking process when the unmasking is + finished (whether it succeeded or otherwise reason of the failure). It + includes the type of the card to be unmasked and the flow type (what + authentication used) in the unmasking. + </summary> + <token key="CardType" variants="Autofill.PaymentsRpcCardType"/> + <token key="FlowType" variants="Autofill.VirtualCardUnmaskFlowType"/> +</histogram> + <histogram name="Autofill.ServerQueryResponse" enum="AutofillQueryResult" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary>The usefulness of Autofill server information.</summary> </histogram> <histogram name="Autofill.ServerResponseHasDataForForm" - enum="BooleanHadPredictions" expires_after="M95"> + enum="BooleanHadPredictions" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2274,7 +2733,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StoredCreditCardCount" units="cards" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <!-- Name completed by histogram_suffixes name="AutofillCreditCardType" --> @@ -2296,7 +2755,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StoredCreditCardCount.Server.WithVirtualCardMetadata" - units="units" expires_after="M98"> + units="units" expires_after="2022-04-10"> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -2306,7 +2765,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StoredCreditCardDisusedCount" units="cards" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <!-- Name completed by histogram_suffixes name="AutofillCreditCardType" --> @@ -2319,7 +2778,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StoredProfileCount" units="units" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2328,7 +2787,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StoredProfileCountAtAutofillableFormSubmission" - units="units" expires_after="2021-12-12"> + units="units" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2338,7 +2797,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StoredProfileDisusedCount" units="units" - expires_after="M95"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2408,7 +2867,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StrikeDatabase.StrikesPresentWhenLocalCardSaved" - units="strikes" expires_after="2021-12-20"> + units="strikes" expires_after="2022-04-24"> <owner>jsaul@google.com</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -2418,7 +2877,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.StrikeDatabase.StrikesPresentWhenServerCardSaved" - units="strikes" expires_after="2021-12-20"> + units="strikes" expires_after="2022-05-01"> <owner>jsaul@google.com</owner> <owner>payments-autofill-team@google.com</owner> <summary> @@ -2466,7 +2925,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.SubmittedValuePatterns" enum="AutofillValuePatterns" - expires_after="2022-01-23"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>jsaul@google.com</owner> <owner>koerber@google.com</owner> @@ -2479,7 +2938,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.SuggestionAccepted.OffTheRecord" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -2489,7 +2948,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.SuggestionAcceptedIndex.Autocomplete" - units="position" expires_after="2021-12-12"> + units="position" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2500,7 +2959,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.SuggestionAcceptedIndex{AutofillSuggestionAcceptedIndexSuggestionType}" - units="position" expires_after="2021-12-12"> + units="position" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2519,7 +2978,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.SuggestionShown.OffTheRecord" units="units" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -2528,7 +2987,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Timing.DetermineHeuristicTypes" units="ms" - expires_after="M95"> + expires_after="2022-12-12"> <owner>kenjitoyama@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -2538,7 +2997,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Autofill.Timing.ParseForm" units="ms" expires_after="M95"> +<histogram name="Autofill.Timing.ParseForm" units="ms" + expires_after="2022-12-12"> <owner>kenjitoyama@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> @@ -2549,9 +3009,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.TranslatedPageLanguage" enum="LanguageName" - expires_after="2021-10-25"> - <owner>marsin@google.com</owner> + expires_after="2022-12-12"> <owner>koerber@google.com</owner> + <owner>chrome-autofill-team@google.com</owner> <summary> The visible page language (best guess of the original or the translated language, if translation was used) upon form submission. This is a sparse @@ -2562,7 +3022,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Autofill.UnmaskPrompt.Duration{AutofillUnmaskPromptCloseReasonEvents}" - units="ms" expires_after="2021-10-10"> + units="ms" expires_after="2022-08-01"> <owner>jsaul@google.com</owner> <owner>siyua@chromium.org</owner> <summary> @@ -2580,7 +3040,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.UnmaskPrompt.Events" enum="AutofillUnmaskPromptEvent" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>jsaul@google.com</owner> <owner>siyua@chromium.org</owner> <summary> @@ -2714,7 +3174,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.Upload.FailingPayloadSize" units="bytes" - expires_after="M77"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2783,7 +3243,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.UploadEvent{AutofillUploadEvents}" enum="BooleanSent" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2815,7 +3275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.UsedCachedServerCard" units="uses" - expires_after="2021-12-20"> + expires_after="2022-02-20"> <owner>jsaul@google.com</owner> <owner>siyua@chromium.org</owner> <owner>payments-autofill-team@google.com</owner> @@ -2841,7 +3301,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.UserHappiness{AutofillFormType}" - enum="AutofillUserHappiness" expires_after="2021-12-12"> + enum="AutofillUserHappiness" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2905,7 +3365,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.WalletAddressConversionType" - enum="AutofillWalletAddressConversionType" expires_after="M95"> + enum="AutofillWalletAddressConversionType" expires_after="2022-12-12"> <owner>battre@chromium.org</owner> <owner>chrome-autofill-alerts@google.com</owner> <summary> @@ -2915,7 +3375,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.WebOTP.OneTimeCode.FillDuration.FromInteraction" - units="ms" expires_after="2021-11-07"> + units="ms" expires_after="2022-12-12"> <owner>yigu@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2929,7 +3389,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.WebOTP.OneTimeCode.FillDuration.FromLoad" units="ms" - expires_after="2021-11-07"> + expires_after="2022-12-12"> <owner>yigu@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2941,7 +3401,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.WebOTP.OneTimeCode.FromAutocomplete" units="Boolean" - expires_after="2022-01-09"> + expires_after="2022-12-12"> <owner>yigu@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2953,7 +3413,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.WebOTP.PhoneNumberCollection.ParseResult" - units="Boolean" expires_after="2021-11-07"> + units="Boolean" expires_after="2022-12-12"> <owner>yigu@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2970,7 +3430,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autofill.WebOTP.PhonePlusWebOTPPlusOTC" - enum="PhoneCollectionState" expires_after="2021-11-07"> + enum="PhoneCollectionState" expires_after="2022-12-12"> <owner>yigu@chromium.org</owner> <owner>madjivp@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -3072,6 +3532,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>Whether the user changed autofilled field.</summary> </histogram> +<histogram name="Autofill.{OtpAuthType}.OtpInputDialog.Shown" + enum="AutofillOtpAuthEvent" expires_after="2022-05-01"> + <owner>siyua@chromium.org</owner> + <owner>payments-autofill-team@google.com</owner> + <summary>Logs when the OTP input dialog was shown.</summary> + <token key="OtpAuthType" variants="Autofill.OtpAuth.Type"/> +</histogram> + </histograms> </histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/background/histograms.xml b/chromium/tools/metrics/histograms/metadata/background/histograms.xml index d8250564edc..b38c72433f4 100644 --- a/chromium/tools/metrics/histograms/metadata/background/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/background/histograms.xml @@ -126,7 +126,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackgroundFetch.IncompleteFetchesOnStartup" units="units" - expires_after="M95"> + expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -137,7 +137,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackgroundFetch.Manager{BackgroundFetchManagerAPIsDuration}" - units="ms" expires_after="M95"> + units="ms" expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -192,7 +192,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackgroundFetch.Storage{BackgroundFetchDatabaseStorageErrors}" - enum="BackgroundFetchStorageError" expires_after="M95"> + enum="BackgroundFetchStorageError" expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -270,7 +270,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackgroundMode.OnStartup.IsBackgroundModePrefEnabled" - enum="BooleanEnabled" expires_after="2021-12-05"> + enum="BooleanEnabled" expires_after="2022-04-17"> <owner>mvanouwerkerk@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <summary> @@ -313,7 +313,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackgroundSync.Event.OneShotResultPattern" - enum="BackgroundSyncResultPattern" expires_after="2022-01-02"> + enum="BackgroundSyncResultPattern" expires_after="2022-03-06"> <owner>nator@chromium.org</owner> <owner>rayankans@chromium.org</owner> <summary> @@ -374,7 +374,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackgroundSync.LaunchTask.PlayServicesAvailable" - enum="Boolean" expires_after="2021-09-19"> + enum="Boolean" expires_after="2022-08-19"> <owner>nator@chromium.org</owner> <owner>rayankans@chromium.org</owner> <summary> @@ -409,7 +409,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackgroundSync.Registration.OneShot" - enum="BackgroundSyncStatus" expires_after="2021-12-12"> + enum="BackgroundSyncStatus" expires_after="2022-02-20"> <owner>nator@chromium.org</owner> <owner>rayankans@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/blink/histograms.xml b/chromium/tools/metrics/histograms/metadata/blink/histograms.xml index 55bb60f70d0..237cc34680f 100644 --- a/chromium/tools/metrics/histograms/metadata/blink/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/blink/histograms.xml @@ -49,7 +49,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="Blink.AnchorElementMetricsIntersectionObserver.UpdateTime" - units="microseconds" expires_after="2021-10-10"> + units="microseconds" expires_after="2022-10-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -69,7 +69,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.Animate.UpdateTime" units="microseconds" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -87,7 +87,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Animation.CompositedAnimationFailureReason" - enum="CompositorAnimationsFailureReason" expires_after="2021-12-26"> + enum="CompositorAnimationsFailureReason" expires_after="2022-05-01"> <owner>smcgruer@chromium.org</owner> <owner>animations-dev@chromium.org</owner> <summary> @@ -109,7 +109,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.ContentChangeMode" - enum="BooleanContentChangeMode" expires_after="2022-01-31"> + enum="BooleanContentChangeMode" expires_after="2022-04-24"> <owner>yiyix@chromium.org</owner> <owner>fserb@chromium.org</owner> <summary> @@ -121,7 +121,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.ContextType" enum="CanvasContextType" - expires_after="2021-12-12"> + expires_after="2022-01-31"> + <obsolete> + Retired in M96, replaced by HTMLCanvasElement_* buckets in + Blink.UseCounter.Features wich records at most one count per page visit per + context type, as opposed to one count per context creation. + </obsolete> <owner>fserb@chromium.org</owner> <owner>aaronhk@chromium.org</owner> <summary> @@ -156,7 +161,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.Canvas.DrawImage.Duration2" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="M93"> + <obsolete> + Retired in M94. + </obsolete> <owner>fserb@chromium.org</owner> <owner>aaronhk@chromium.org</owner> <summary> @@ -174,7 +182,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Blink.Canvas.DrawImage.SqrtNumberOfPixels{BlinkCanvasDrawImageSizeType}" - units="sqrt(pixels)" expires_after="2021-12-12"> + units="sqrt(pixels)" expires_after="M93"> + <obsolete> + Retired in M94. + </obsolete> <owner>fserb@chromium.org</owner> <owner>aaronhk@chromium.org</owner> <summary> @@ -202,7 +213,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.Canvas.GetImageDataScaledDuration" - units="microseconds * 10/sqrt(pixels)" expires_after="2022-05-10"> + units="microseconds * 10/sqrt(pixels)" expires_after="M93"> + <obsolete> + Retired in M94. + </obsolete> <owner>fserb@chromium.org</owner> <owner>aaronhk@chromium.org</owner> <summary> @@ -226,7 +240,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.GPUFallbackToCPU" - enum="CanvasGPUFallbackToCPUScenario" expires_after="2021-01-31"> + enum="CanvasGPUFallbackToCPUScenario" expires_after="2022-04-10"> <owner>fserb@chromium.org</owner> <summary>Logs the occurrences of canvas fallback from GPU to CPU.</summary> </histogram> @@ -241,7 +255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.HibernationEvents" enum="CanvasHibernationEvent" - expires_after="2021-04-04"> + expires_after="2022-01-31"> <owner>fserb@chromium.org</owner> <summary> Records the occurrence of events related to 2D canvas GPU resource @@ -250,7 +264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.ImageSmoothingQuality" - enum="ImageSmoothingQuality" expires_after="2021-05-31"> + enum="ImageSmoothingQuality" expires_after="2022-01-31"> <obsolete> Removed in M92. This metric is added to do some research, and the research is now completed. @@ -278,7 +292,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.MaximumInflightResources" - units="canvas resources" expires_after="2021-08-09"> + units="canvas resources" expires_after="2022-01-31"> <owner>aaronhk@chromium.org</owner> <owner>fserb@chromium.org</owner> <summary> @@ -289,7 +303,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.NumCanvasesPerPage" units="canvases" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>aaronhk@chromium.org</owner> <owner>fserb@chromium.org</owner> <summary> @@ -297,8 +311,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Blink.Canvas.OverdrawOp" enum="CanvasOverdrawOp" + expires_after="2022-08-31"> + <owner>junov@chromium.org</owner> + <owner>fserb@chromium.org</owner> + <summary> + Counts 2d canvas draw operations that trigger the overdraw optimization. + </summary> +</histogram> + <histogram base="true" name="Blink.Canvas.PutImageDataScaledDuration" - units="microseconds * 10/sqrt(pixels)" expires_after="2022-05-10"> + units="microseconds * 10/sqrt(pixels)" expires_after="M93"> + <obsolete> + Retired in M94. + </obsolete> <owner>fserb@chromium.org</owner> <owner>aaronhk@chromium.org</owner> <summary> @@ -322,7 +348,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.RasterDuration{BlinkCanvasRasterDurationType}" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-01-31"> <owner>aaronhk@chromium.org</owner> <owner>fserb@chromium.org</owner> <summary> @@ -632,7 +658,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.WebGPUMaxRecycledResourcesCount" - units="Recyclable resources" expires_after="2021-11-06"> + units="Recyclable resources" expires_after="2022-04-24"> <owner>magchen@chromium.org</owner> <owner>enga@chromium.org</owner> <summary> @@ -642,7 +668,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.WebGPUMaxRecycledResourcesInKB" units="KB" - expires_after="2021-11-06"> + expires_after="2022-04-24"> <owner>magchen@chromium.org</owner> <owner>enga@chromium.org</owner> <summary> @@ -653,7 +679,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Canvas.WebGPUStaleResourceCount" - units="recyclable resources" expires_after="2021-11-06"> + units="recyclable resources" expires_after="2022-05-01"> <owner>magchen@chromium.org</owner> <owner>enga@chromium.org</owner> <summary> @@ -672,6 +698,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Blink.Clipboard.Paste.Image" enum="ClipboardPastedImageUrls" expires_after="2021-09-05"> + <obsolete> + Retired in Sept 2021 as enough data was collected. + </obsolete> <owner>huangdarwin@chromium.org</owner> <owner>snianu@microsoft.com</owner> <summary> @@ -740,7 +769,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.CompositingAssignments.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -759,7 +788,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.CompositingCommit.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -782,7 +811,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.CompositingInputs.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -825,7 +854,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.ContentDocumentUpdate.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -845,7 +874,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ContextMenu.ImageSelection.Depth" units="count" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>benwgold@google.com</owner> <owner>flackr@chromium.org</owner> <summary> @@ -858,7 +887,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ContextMenu.ImageSelection.ElapsedTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <owner>benwgold@google.com</owner> <owner>flackr@chromium.org</owner> <summary> @@ -875,7 +904,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ContextMenu.ImageSelection.Outcome" - enum="ImageSelectionOutcome" expires_after="2022-01-09"> + enum="ImageSelectionOutcome" expires_after="2022-04-10"> <owner>benwgold@google.com</owner> <owner>flackr@chromium.org</owner> <summary> @@ -888,7 +917,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ContextMenu.ImageSelection.RetrievalOutcome" - enum="ImageSelectionRetrievalOutcome" expires_after="2022-01-09"> + enum="ImageSelectionRetrievalOutcome" expires_after="2022-04-17"> <owner>benwgold@google.com</owner> <owner>flackr@chromium.org</owner> <summary> @@ -926,7 +955,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.DarkMode.ApplyToImageOnMainThread" units="microseconds" - expires_after="2021-10-10"> + expires_after="2022-04-01"> <owner>pdr@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -954,7 +983,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.DecodedImage.JpegDensity.KiBWeighted" - units="0.01 bits per pixel" expires_after="2021-12-26"> + units="0.01 bits per pixel" expires_after="2022-05-01"> <owner>deymo@google.com</owner> <owner>compression-dev@google.com</owner> <summary> @@ -977,7 +1006,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.DecodedImage.WebPFileFormat" enum="WebPFileFormat" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>mcasas@chromium.org</owner> <owner>andrescj@chromium.org</owner> <summary> @@ -987,13 +1016,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.DecodedImageType" enum="DecodedImageType" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>urvang@chromium.org</owner> - <summary>Image codec inferred during decode.</summary> + <summary> + Image codec inferred during decode. The histogram is incremented when enough + of the image has been downloaded to infer its width and height. Animated + images are counted only once, regardless of how many frames there are. + </summary> </histogram> <histogram base="true" name="Blink.DisplayLockIntersectionObserver.UpdateTime" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-10-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1011,7 +1044,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Blink.EffectiveZoom" units="%" expires_after="2021-11-07"> +<histogram name="Blink.EffectiveZoom" units="%" expires_after="2022-04-17"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -1021,6 +1054,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Blink.Fetch.ReducedUserAgent" enum="Boolean" + expires_after="M100"> + <owner>abeyad@chromium.org</owner> + <owner>aarontag@chromium.org</owner> + <summary> + Whether the User-Agent header that was sent for a subresource request had a + reduced user agent string value. The reduced user agent string is only sent + in the presence of a valid UserAgentReduction origin trial token. This + histogram is recorded when a frame's subresource fetch request is being + prepared. + </summary> +</histogram> + <histogram name="Blink.Fetch.RequestResourceTime" units="microseconds" expires_after="M82"> <owner>csharrison@chromium.org</owner> @@ -1119,7 +1165,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Blink.Fonts.DataAccess.StreamCreation" enum="BooleanSuccess" expires_after="2021-10-15"> - <owner>oyiptong@chromium.org</owner> + <owner>pwnall@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary> @@ -1129,7 +1175,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Fonts.EmojiClusterBrokenness" units="%" - expires_after="2021-09-20"> + expires_after="2022-01-10"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1147,7 +1193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. Removed in M89. Obsolete and unused. This has been replaced with Fonts.AccessAPI.EnumerationCache.* </obsolete> - <owner>oyiptong@chromium.org</owner> + <owner>pwnall@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary> @@ -1188,7 +1234,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Fonts.VariableFontsRatio" - enum="WebFontInstantiationResult" expires_after="2021-12-19"> + enum="WebFontInstantiationResult" expires_after="2022-04-10"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1268,7 +1314,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.ForcedStyleAndLayout.UpdateTime" - units="microseconds" expires_after="2022-02-06"> + units="microseconds" expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1286,7 +1332,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.HandleInputEvents.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1304,7 +1350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.HitTestDocumentUpdate.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1324,7 +1370,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ChunkCount" units="chunks" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1337,7 +1383,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ChunkCount2" units="chunks" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1351,7 +1397,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.InputCharacterCount" units="characters" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1365,7 +1411,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ParsingTimeMax" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1378,7 +1424,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ParsingTimeMax2" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1392,7 +1438,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ParsingTimeMin" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1405,7 +1451,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ParsingTimeMin2" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1419,7 +1465,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ParsingTimeTotal" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1432,7 +1478,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.ParsingTimeTotal2" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1446,7 +1492,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedAverage" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1458,7 +1504,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedAverage2" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1471,7 +1517,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedMax" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1483,7 +1529,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedMax2" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1496,7 +1542,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedMin" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1508,7 +1554,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedMin2" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1521,7 +1567,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedTotal" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1533,7 +1579,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.TokensParsedTotal2" units="tokens" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1546,7 +1592,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.YieldedTimeAverage" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1559,7 +1605,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.YieldedTimeAverage2" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1573,7 +1619,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.YieldedTimeMax" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1586,7 +1632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.YieldedTimeMax2" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1600,7 +1646,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.YieldedTimeMin" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1613,7 +1659,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.HTMLParsing.YieldedTimeMin2" units="microseconds" - expires_after="2021-10-04"> + expires_after="2022-06-30"> <owner>schenney@chromium.org</owner> <owner>dom-dev@chromium.org</owner> <summary> @@ -1627,9 +1673,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ImageDecoders.IncrementalDecodeNeeded" - enum="IncrementalDecodeNeeded" expires_after="2021-09-05"> - <owner>mbarowsky@chromium.org</owner> + enum="IncrementalDecodeNeeded" expires_after="2022-09-15"> <owner>andrescj@chromium.org</owner> + <owner>chromeos-gfx@google.com</owner> <summary> For JPEG and WebP images, whether all image data has been received before decoding begins or whether we are still receiving data and will need to send @@ -1692,7 +1738,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ImageDecoders.Jpeg.Area" units="pixels" - expires_after="2022-02-28"> + expires_after="2022-05-01"> <owner>andrescj@chromium.org</owner> <owner>src/third_party/blink/renderer/platform/image-decoders/OWNERS</owner> <summary> @@ -1707,7 +1753,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ImageDecoders.Jpeg.ColorSpace" enum="JpegColorSpace" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>andrescj@chromium.org</owner> <owner>mcasas@chromium.org</owner> <summary> @@ -1718,8 +1764,73 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Blink.ImageDecoders.Png.FirstDecode.Area" units="pixels" + expires_after="2022-06-30"> + <owner>nigeltao@chromium.org</owner> + <owner>scroggo@google.com</owner> + <summary> + Number of pixels in a completely decoded PNG image frame. + "Complete" and "First" mean the same things as for the + Blink.ImageDecoders.Png.FirstDecode.Time histogram. + </summary> +</histogram> + +<histogram name="Blink.ImageDecoders.{Type}.{Index}Decode.Time" units="ms" + expires_after="2022-06-30"> + <owner>nigeltao@chromium.org</owner> + <owner>scroggo@google.com</owner> + <summary> + Time taken to completely decode an image frame of the {Type} file format. + This includes time spent in codec implementations but excludes time spent + waiting for the network or file cache to deliver the source bytes. + + For incremental decoding, e.g. the source bytes involve multiple network + events, only the final event (producing a complete image frame) triggers a + histogram record, but that record holds the total time spent on that frame. + + Incomplete (partially decoded) image frames (e.g. navigating away from the + web page before any of its images fully loaded) are not recorded here, but + they still might be recorded in the separate Blink.DecodedImageType + histogram if the partial decoding was able to determine width and height. + + An image's frames may be decoded more than once. If so, {Index} + distinguishes whether every decode of every frame is tracked or just the + first (not repeated) decode of the first (not later) frame. + + For an example of repeated (not first) decodes, when switching between tabs + or scrolling a web page, a previously decoded frame may be discarded so that + the backing memory can be re-used elsewhere. When that image comes back into + view, its frame may need decoding again. + + For an example of later (not first) frames, animated images may produce + multiple frames from a single img tag. Looping animations may be able to + cache all of the decoded frames after the first playthrough but, if too big + to cache, playing the loop continually may keep adding Every histogram + records as uncached frames are repeatedly decoded. + + The Every {Index} correlates more with "how much CPU time (which + correlates with battery consumption) is spent overall in {Type} + decoding". The First {Index} correlates more with "how long until + First Contentful Paint". + </summary> + <token key="Type"> + <variant name="Avif"/> + <variant name="Bmp"/> + <variant name="Gif"/> + <variant name="Ico"/> + <variant name="Jpeg"/> + <variant name="Jxl"/> + <variant name="Png"/> + <variant name="WebP"/> + </token> + <token key="Index"> + <variant name="Every"/> + <variant name="First"/> + </token> +</histogram> + <histogram base="true" name="Blink.ImplCompositorCommit.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1747,7 +1858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.IntersectionObservation.UpdateTime" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-10-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1773,7 +1884,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.JavascriptDocumentUpdate.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1796,7 +1907,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.JavascriptIntersectionObserver.UpdateTime" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-10-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1815,7 +1926,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.KeyboardLock.MethodCalled" enum="KeyboardLockMethods" - expires_after="2021-09-30"> + expires_after="2022-06-30"> <owner>joedow@chromium.org</owner> <owner>garykac@chromium.org</owner> <summary> @@ -1824,7 +1935,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Layout.FlexNGRatio.Blocks" units="%" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>ikilpatrick@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1839,7 +1950,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Layout.GridNGRatio.Blocks" units="%" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>ikilpatrick@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1854,7 +1965,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Layout.NGRatio.Blocks" units="%" - expires_after="2021-12-26"> + expires_after="2022-09-30"> <owner>tkent@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1869,7 +1980,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Layout.NGRatio.Calls" units="%" - expires_after="2021-12-26"> + expires_after="2022-09-30"> <owner>tkent@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -1885,7 +1996,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.Layout.UpdateTime" units="microseconds" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -1950,7 +2061,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.LazyLoadIntersectionObserver.UpdateTime" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-10-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2214,7 +2325,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.MainFrame.UpdateTime" units="microseconds" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2247,7 +2358,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.MediaIntersectionObserver.UpdateTime" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-10-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2336,8 +2447,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Blink.Navigator.ReducedUserAgent" enum="Boolean" + expires_after="M100"> + <owner>abeyad@chromium.org</owner> + <owner>aarontag@chromium.org</owner> + <summary> + Whether the navigator.userAgent and navigator.appVersion JavaScript getters + returned a reduced user agent string value. The reduced user agent string is + only returned in the presence of a valid UserAgentReduction origin trial + token. This histogram is recorded when the navigator.userAgent and + navigator.appVersion JavaScript APIs are invoked. + </summary> +</histogram> + +<histogram name="Blink.NotificationManager.GetPermissionStatusTime" units="ms" + expires_after="2022-08-24"> + <owner>cduvall@chromium.org</owner> + <owner>jam@chromium.org</owner> + <summary> + The time taken to query the notification permission status. This is recorded + each time a sync call is made. + </summary> +</histogram> + <histogram name="Blink.OffscreenCanvas.ContextType" enum="CanvasContextType" expires_after="2021-10-17"> + <obsolete> + Retired in M96, replaced by OffscreenCanvas_* buckets in + Blink.UseCounter.Features wich records at most one count per page visit per + context type, as opposed to one count per context creation. + </obsolete> <owner>aaronhk@chromium.org</owner> <owner>fserb@chromium.org</owner> <summary> @@ -2412,7 +2551,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.Paint.UpdateTime" units="microseconds" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2439,7 +2578,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.PrePaint.UpdateTime" units="microseconds" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2489,7 +2628,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ResourceRequest.CompletionDelay" units="ms" - expires_after="2021-10-08"> + expires_after="2022-08-29"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -2499,7 +2638,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ResourceRequest.RedirectDelay" units="ms" - expires_after="2021-10-08"> + expires_after="2022-08-29"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -2509,7 +2648,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ResourceRequest.ResponseDelay" units="ms" - expires_after="2021-10-08"> + expires_after="2022-08-29"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -2519,7 +2658,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.ResourceRequest.StartDelay" units="ms" - expires_after="2021-10-08"> + expires_after="2022-08-29"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -2538,7 +2677,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Script.AsyncScriptCount" units="count" - expires_after="2021-10-04"> + expires_after="2022-04-04"> <owner>dom@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -2619,7 +2758,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.ScrollDocumentUpdate.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2666,7 +2805,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.ServiceDocumentUpdate.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2686,7 +2825,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.BackendAvailability" - enum="WebOTPBackendAvailability" expires_after="2021-12-12"> + enum="WebOTPBackendAvailability" expires_after="2022-04-24"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -2696,7 +2835,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.PendingOriginCount" units="origins" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -2707,7 +2846,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.CrossDeviceFailure" - enum="WebOTPCrossDeviceFailure" expires_after="2021-12-12"> + enum="WebOTPCrossDeviceFailure" expires_after="2022-04-03"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -2718,6 +2857,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Blink.Sms.Receive.DestroyedReason" enum="WebOTPServiceDestroyedReason" expires_after="2021-12-12"> + <obsolete> + Deprecated 09/2021. We have learned about the pattern of the destruction. + </obsolete> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2727,7 +2869,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.Infobar" enum="WebOTPServiceInfobarAction" - expires_after="2021-10-10"> + expires_after="2022-04-24"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2738,7 +2880,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.Outcome" enum="WebOTPServiceOutcome" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2746,7 +2888,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.SmsParsingStatus" enum="SmsParsingStatus" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -2758,7 +2900,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.TimeCancel" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2769,7 +2911,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.TimeCancelOnKeyboardDismissal" units="ms" - expires_after="2021-10-10"> + expires_after="2022-02-20"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2780,7 +2922,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.TimeCancelOnSuccess" units="ms" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2791,7 +2933,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.TimeContinueOnSuccess" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-03"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2802,7 +2944,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.TimeSmsReceive" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2813,7 +2955,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.TimeSuccess" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2825,7 +2967,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.Receive.TimeUserCancel" units="ms" - expires_after="2021-10-10"> + expires_after="2022-05-01"> <owner>yigu@chromium.org</owner> <owner>goto@chromium.org</owner> <owner>web-identity@google.com</owner> @@ -2837,7 +2979,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.Sms.WebContentsVisibleOnReceive" enum="Boolean" - expires_after="2021-10-10"> + expires_after="2022-04-24"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -2860,7 +3002,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.Style.UpdateTime" units="microseconds" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -2889,7 +3031,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.UpdateViewportIntersection.UpdateTime" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-10-10"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -3043,7 +3185,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.UseCounter.FeaturePolicy.Header" - enum="FeaturePolicyFeature" expires_after="2021-10-31"> + enum="FeaturePolicyFeature" expires_after="2022-04-17"> <owner>iclelland@chromium.org</owner> <owner>feature-control@chromium.org</owner> <summary> @@ -3150,6 +3292,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Blink.UseCounter.PermissionsPolicy.Allow" enum="FeaturePolicyFeature" expires_after="2022-05-30"> + <obsolete> + Obsolete in 2021-09. Use Blink.UseCounter.PermissionsPolicy.Allow2 instead. + </obsolete> <owner>iclelland@chromium.org</owner> <owner>feature-control@chromium.org</owner> <summary> @@ -3159,8 +3304,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Blink.UseCounter.PermissionsPolicy.Allow2" + enum="FeaturePolicyFeature" expires_after="2022-05-30"> + <owner>iclelland@chromium.org</owner> + <owner>feature-control@chromium.org</owner> + <summary> + Counts the use of a specific permissions policy feature via the + "allow" attribute on iframes. Each policy is counted only once per + page load. Version 2 fixes the mismatched histogram name with data + collected. + </summary> +</histogram> + <histogram name="Blink.UseCounter.PermissionsPolicy.Header" enum="FeaturePolicyFeature" expires_after="2022-05-30"> + <obsolete> + Obsolete in 2021-09. Use Blink.UseCounter.PermissionsPolicy.Header2 instead. + </obsolete> <owner>iclelland@chromium.org</owner> <owner>feature-control@chromium.org</owner> <summary> @@ -3170,8 +3330,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Blink.UseCounter.PermissionsPolicy.Header2" + enum="FeaturePolicyFeature" expires_after="2022-05-30"> + <owner>iclelland@chromium.org</owner> + <owner>feature-control@chromium.org</owner> + <summary> + Counts the use of a specific permissions policy feature via both + "Feature-Policy" and "Permissions-Policy" HTTP response + header. Each policy is counted only once per page load. Version 2 fixes the + mismatched histogram name with data collected. + </summary> +</histogram> + <histogram name="Blink.UseCounter.PermissionsPolicy.Violation.Enforce" - enum="FeaturePolicyFeature" expires_after="2021-10-31"> + enum="FeaturePolicyFeature" expires_after="2022-04-24"> <owner>iclelland@chromium.org</owner> <owner>feature-control@chromium.org</owner> <summary> @@ -3183,7 +3355,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.UserDrivenDocumentUpdate.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -3213,7 +3385,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.VisibleBeforeLoaded.LazyLoadImages.AboveTheFold" - enum="NQEEffectiveConnectionType" expires_after="2021-12-05"> + enum="NQEEffectiveConnectionType" expires_after="2022-05-01"> <owner>sclittle@chromium.org</owner> <owner>rajendrant@chromium.org</owner> <summary> @@ -3223,7 +3395,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.VisibleBeforeLoaded.LazyLoadImages.BelowTheFold" - enum="NQEEffectiveConnectionType" expires_after="2022-01-09"> + enum="NQEEffectiveConnectionType" expires_after="2022-03-13"> <owner>sclittle@chromium.org</owner> <owner>rajendrant@chromium.org</owner> <summary> @@ -3305,7 +3477,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Blink.WaitForCommit.UpdateTime" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePreFCPSuffixes" --> <!-- Name completed by histogram_suffixes name="BlinkUpdateTimePostFCPSuffixes" --> @@ -3324,7 +3496,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.WebCodecs.ImageDecoder.Success" enum="BooleanSuccess" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -3334,7 +3506,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Blink.WebCodecs.ImageDecoder.Type" enum="DecodedImageType" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -3660,7 +3832,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlinkGC.TimeForIncrementalMarking" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>mlippautz@chromium.org</owner> <owner>oilpan-reviews@chromium.org</owner> <summary> @@ -3680,7 +3852,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="BlinkGC.TimeForMarkingRoots" units="ms" expires_after="M95"> +<histogram name="BlinkGC.TimeForMarkingRoots" units="ms" expires_after="M98"> <owner>omerkatz@chromium.org</owner> <owner>oilpan-reviews@chromium.org</owner> <summary> @@ -3690,7 +3862,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlinkGC.TimeForMarking{BlinkGCTimingTypes}" units="ms" - expires_after="M95"> + expires_after="M98"> <owner>omerkatz@chromium.org</owner> <owner>oilpan-reviews@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/bluetooth/histograms.xml b/chromium/tools/metrics/histograms/metadata/bluetooth/histograms.xml index e1b475c5ea5..f3458f510b9 100644 --- a/chromium/tools/metrics/histograms/metadata/bluetooth/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/bluetooth/histograms.xml @@ -187,6 +187,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Bluetooth.ChromeOS.FastPair.EngagementFunnel.Steps" + enum="FastPairEngagementFlowEvent" expires_after="2022-09-20"> + <owner>shanefitz@google.com</owner> + <owner>julietlevesque@google.com</owner> + <owner>chromeos-cross-device-eng@google.com</owner> + <summary> + Records each step in the Fast Pair flow. Emitted when the discovery UI is + shown, the discovery UI is dismissed, pairing progress begins, pairing + fails, pairing suceeded, the error UI is dismissed, and/or when the setting + button on the error UI is pressed. + </summary> +</histogram> + <histogram name="Bluetooth.ChromeOS.Forget.Result" enum="ForgetResult" expires_after="2022-07-21"> <owner>khorimoto@chromium.org</owner> @@ -372,7 +385,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bluetooth.ConnectedDeviceCount" units="devices" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>adlr@chromium.org</owner> <summary> Counts the number of simulataneously connected Bluetooth devices. Used to @@ -406,7 +419,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Bluetooth.Linux.ConnectToServiceInsecurelyResult" enum="BluetoothAdapterConnectToServiceInsecurelyResult" - expires_after="2022-01-01"> + expires_after="2022-04-03"> <owner>alainm@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -580,7 +593,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bluetooth.Web.Characteristic.ReadValue.Outcome" - enum="WebBluetoothGATTOperationOutcome" expires_after="M97"> + enum="WebBluetoothGATTOperationOutcome" expires_after="M99"> <owner>cmumford@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> @@ -592,7 +605,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bluetooth.Web.Characteristic.StartNotifications.Outcome" - enum="WebBluetoothGATTOperationOutcome" expires_after="M97"> + enum="WebBluetoothGATTOperationOutcome" expires_after="M99"> <owner>cmumford@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> @@ -604,7 +617,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bluetooth.Web.Characteristic.WriteValue.Outcome" - enum="WebBluetoothGATTOperationOutcome" expires_after="M97"> + enum="WebBluetoothGATTOperationOutcome" expires_after="M99"> <owner>cmumford@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> @@ -616,7 +629,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bluetooth.Web.ChooserInteraction" enum="BooleanInvalid" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>reillyg@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> @@ -626,7 +639,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bluetooth.Web.ConnectGATT.Outcome" - enum="WebBluetoothConnectGATTOutcome" expires_after="2022-01-23"> + enum="WebBluetoothConnectGATTOutcome" expires_after="2022-04-10"> <owner>reillyg@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> @@ -1002,7 +1015,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bluetooth.Web.RequestDevice.UnionOfServices.Services" - enum="GATTServiceHash" expires_after="2021-12-19"> + enum="GATTServiceHash" expires_after="2022-04-24"> <owner>reillyg@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/borealis/histograms.xml b/chromium/tools/metrics/histograms/metadata/borealis/histograms.xml index 15b405a6e16..baf8a65a3bc 100644 --- a/chromium/tools/metrics/histograms/metadata/borealis/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/borealis/histograms.xml @@ -123,7 +123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Borealis.Disk.Startup.{TypeOfSpace}Space" units="MB" - expires_after="M95"> + expires_after="2022-04-08"> <owner>danielng@google.com</owner> <owner>src/chrome/browser/ash/borealis/OWNERS</owner> <summary> @@ -216,8 +216,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Borealis.Stability" enum="GuestOsFailureClasses" - expires_after="2021-10-09"> + expires_after="2022-04-08"> <owner>cpelling@google.com</owner> + <owner>src/chrome/browser/ash/borealis/OWNERS</owner> <summary> A record of post-startup failures in Borealis components. Buckets are recorded to when we become aware that the corresponding component has @@ -226,14 +227,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Borealis.Startup.NumAttempts" enum="BooleanAttempted" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>danielng@google.com</owner> <owner>src/chrome/browser/ash/borealis/OWNERS</owner> <summary>Recording every attempt to start Borealis (via the UI).</summary> </histogram> <histogram name="Borealis.Startup.OverallTime" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>danielng@google.com</owner> <owner>src/chrome/browser/ash/borealis/OWNERS</owner> <summary> @@ -243,7 +244,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Borealis.Startup.Result" enum="BorealisStartupResult" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>danielng@google.com</owner> <owner>src/chrome/browser/ash/borealis/OWNERS</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/browser/histograms.xml b/chromium/tools/metrics/histograms/metadata/browser/histograms.xml index c46961a0202..9507c0f8fe9 100644 --- a/chromium/tools/metrics/histograms/metadata/browser/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/browser/histograms.xml @@ -62,7 +62,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="Browser.AnyWindowHasName" enum="Boolean" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>ellyjones@chromium.org</owner> <owner>lgrey@chromium.org</owner> <summary> @@ -72,7 +72,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.BitmapFetcher.Decode" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>manukh@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -80,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.BitmapFetcher.Fetch" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>manukh@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -101,6 +101,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="Survey"> <variant name=".General"/> <variant name=".OnboardingExperience"/> + <variant name=".SmartLock"/> <variant name=".Unlock"/> </token> </histogram> @@ -156,7 +157,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.ContinuousSearch.NumberOfSearchResultsExtracted" - units="count" expires_after="2021-12-12"> + units="count" expires_after="2022-04-17"> <owner>ckitagawa@chromium.org</owner> <owner>fredmello@chromium.org</owner> <owner>yashard@chromium.org</owner> @@ -168,7 +169,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.ContinuousSearch.SearchResultExtractionStatus" - enum="SearchResultExtractorClientStatus" expires_after="2021-12-20"> + enum="SearchResultExtractorClientStatus" expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>fredmello@chromium.org</owner> <owner>yashard@chromium.org</owner> @@ -261,6 +262,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="Browser.ContinuousSearch.UI.ItemClickedAtLeastOnce{ExperimentCategory}" + enum="Boolean" expires_after="2021-12-20"> + <owner>ckitagawa@chromium.org</owner> + <owner>fredmello@chromium.org</owner> + <owner>yashard@chromium.org</owner> + <summary> + Records whether any item was pressed while UI was being shown. It is emmited + when the CSN session is considered ended. Actions that can end the session + include closing the tab, navigating away from the CSN url list or dismissing + the UI. + </summary> + <token key="ExperimentCategory" variants="ContinuousSearchExperiment"/> +</histogram> + +<histogram name="Browser.ContinuousSearch.UI.ProviderButtonClicked{ExperimentCategory}" enum="Boolean" expires_after="2021-12-20"> <owner>ckitagawa@chromium.org</owner> @@ -286,7 +302,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Capture.CompressedOnDiskSize" units="KB" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -297,7 +313,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Capture.NumberOfFramesCaptured" - units="units" expires_after="2022-01-02"> + units="units" expires_after="2022-04-03"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -307,7 +323,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Capture.Success" enum="BooleanSuccess" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -317,7 +333,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Capture.TotalCaptureDuration" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -369,7 +385,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Player.CompositorProcessStartedCorrectly" - units="BooleanSuccess" expires_after="2022-01-02"> + units="BooleanSuccess" expires_after="2022-04-17"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -379,7 +395,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Player.CompositorProcessStartupTime" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-03-06"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -389,7 +405,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Player.LinkClicked" - units="BooleanSuccess" expires_after="2022-01-02"> + units="BooleanSuccess" expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -397,7 +413,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.Player.TimeToFirstBitmap" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -408,7 +424,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.TabbedPlayer.CompositorFailureReason" - enum="TabbedPaintPreviewCompositorFailureReason" expires_after="2022-01-02"> + enum="TabbedPaintPreviewCompositorFailureReason" expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -420,7 +436,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.TabbedPlayer.ExitCause" - enum="TabbedPaintPreviewExitCause" expires_after="2022-01-02"> + enum="TabbedPaintPreviewExitCause" expires_after="2022-04-03"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -431,7 +447,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.TabbedPlayer.FirstPaintBeforeTabLoad" - units="Boolean" expires_after="2022-01-09"> + units="Boolean" expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -442,7 +458,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.TabbedPlayer.HadCapture" units="Boolean" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -454,7 +470,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.TabbedPlayer.SnackbarCount" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -465,7 +481,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.TabbedPlayer.TimeToFirstBitmap" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-03-06"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -509,7 +525,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.PaintPreview.TabService.DiskUsageAtStartup" units="KB" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -520,7 +536,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.Responsiveness.IOJanksTotalPerMinute" units="janks" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>gab@chromium.org</owner> <owner>olivierli@chromium.org</owner> <summary> @@ -534,7 +550,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.Responsiveness.IOJankyIntervalsPerMinute" - units="janks" expires_after="2021-12-12"> + units="janks" expires_after="2022-04-10"> <owner>gab@chromium.org</owner> <owner>olivierli@chromium.org</owner> <summary> @@ -553,7 +569,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.Responsiveness.JankyIntervalsPerThirtySeconds2" - units="janks" expires_after="2022-01-09"> + units="janks" expires_after="2022-03-13"> <!-- JankyIntervalsPerThirtySeconds3 is on probation to replace this --> <owner>erikchen@chromium.org</owner> @@ -574,7 +590,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.Responsiveness.JankyIntervalsPerThirtySeconds3" - units="janks" expires_after="2021-09-30"> + units="janks" expires_after="2022-04-03"> <!-- on probation: expected to graduate as a go/chrome-browser-guiding-metrics --> <owner>etienneb@chromium.org</owner> @@ -706,7 +722,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.Tabs.SelectionToVisibilityRequestTime" - units="microseconds" expires_after="2021-12-19"> + units="microseconds" expires_after="2022-04-24"> <owner>sadrul@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> @@ -769,7 +785,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.WindowCount.Guest" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -781,7 +797,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Browser.WindowCount.Incognito" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -945,7 +961,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserServices.ClientAppDataLoad" units="ms" - expires_after="M98"> + expires_after="2022-04-24"> <owner>peconn@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -956,7 +972,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserServices.ServiceTabResolveInfoQuery" units="ms" - expires_after="M98"> + expires_after="2022-05-01"> <owner>peconn@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -965,7 +981,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="BrowserServices.TwaOpenTime.V2" units="ms" expires_after="M98"> +<histogram name="BrowserServices.TwaOpenTime.V2" units="ms" + expires_after="2022-04-17"> <owner>peconn@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -975,7 +992,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserServices.VerificationResult" - enum="BrowserServicesVerificationResult" expires_after="M98"> + enum="BrowserServicesVerificationResult" expires_after="2022-05-01"> <owner>peconn@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1006,7 +1023,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.AlternativeBrowser" enum="BrowserType" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1018,7 +1035,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.CacheFile.MkDirSuccess" enum="BooleanSuccess" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1028,7 +1045,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.CacheFile.MkTempSuccess" enum="BooleanSuccess" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1039,7 +1056,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.CacheFile.MoveSuccess" enum="BooleanSuccess" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1051,7 +1068,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.Decision" enum="BooleanBrowserSwitch" - expires_after="2021-12-12"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1063,7 +1080,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.DecisionTime" units="ms" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1074,7 +1091,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.ExternalGreylistSize" units="rules" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1084,7 +1101,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.ExternalSitelistSize" units="rules" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1094,7 +1111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.GreylistSize" units="rules" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1104,7 +1121,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.GreylistWildcard" enum="BooleanPresent" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1115,7 +1132,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.IeemSitelistSize" units="rules" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1145,7 +1162,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.UrlListSize" units="rules" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1155,7 +1172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BrowserSwitcher.UrlListWildcard" enum="BooleanPresent" - expires_after="2021-10-04"> + expires_after="2022-04-01"> <owner>nicolaso@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/chrome/histograms.xml b/chromium/tools/metrics/histograms/metadata/chrome/histograms.xml index aa72d8e48a6..6cef9ef21bf 100644 --- a/chromium/tools/metrics/histograms/metadata/chrome/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/chrome/histograms.xml @@ -41,16 +41,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.ProcessSingleton.RemoteHungProcessTerminateReason" - enum="RemoteHungProcessTerminateReason" expires_after="M77"> + enum="RemoteHungProcessTerminateReason" expires_after="2022-04-24"> <owner>gab@chromium.org</owner> - <owner>aseren@yandex-team.ru</owner> + <owner>etienneb@chromium.org</owner> <summary>The reason of remote hang processes termination.</summary> </histogram> <histogram name="Chrome.ProcessSingleton.RemoteProcessInteractionResult" - enum="RemoteProcessInteractionResult" expires_after="M81"> + enum="RemoteProcessInteractionResult" expires_after="2022-04-24"> <owner>gab@chromium.org</owner> - <owner>aseren@yandex-team.ru</owner> + <owner>etienneb@chromium.org</owner> <summary> Used to send the result of interaction with remote process as histograms in case when remote process influences on start. @@ -58,9 +58,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.ProcessSingleton.TerminateProcessErrorCode.Posix" - enum="PopularOSErrno" expires_after="M77"> + enum="PopularOSErrno" expires_after="M98"> <owner>gab@chromium.org</owner> - <owner>aseren@yandex-team.ru</owner> + <owner>etienneb@chromium.org</owner> <summary> The error code of remote process termination on Posix in case when remote process hung. @@ -68,9 +68,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.ProcessSingleton.TerminateProcessErrorCode.Windows" - enum="WinGetLastError" expires_after="M81"> + enum="WinGetLastError" expires_after="M98"> <owner>gab@chromium.org</owner> - <owner>aseren@yandex-team.ru</owner> + <owner>etienneb@chromium.org</owner> <summary> The error code of remote process termination on Windows in case when remote process hung. @@ -78,9 +78,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.ProcessSingleton.TerminateProcessTime" units="ms" - expires_after="2020-03-08"> + expires_after="M98"> <owner>gab@chromium.org</owner> - <owner>aseren@yandex-team.ru</owner> + <owner>etienneb@chromium.org</owner> <summary> Time it takes from TerminateProcess call to the moment when we stop waiting for remote process switches to signal state. @@ -88,16 +88,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.ProcessSingleton.TerminationWaitErrorCode.Windows" - enum="WinGetLastError" expires_after="M81"> + enum="WinGetLastError" expires_after="M98"> <owner>gab@chromium.org</owner> - <owner>aseren@yandex-team.ru</owner> + <owner>etienneb@chromium.org</owner> <summary> The error code of wating for remote process termination on Windows. </summary> </histogram> <histogram name="Chrome.ProcessSingleton.TimeToCreate" units="ms" - expires_after="2018-08-30"> + expires_after="2022-05-01"> + <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary> Time it takes to grab the process singleton. Reported once per successful @@ -106,7 +107,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.ProcessSingleton.TimeToFailure" units="ms" - expires_after="2018-08-30"> + expires_after="2022-05-01"> + <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary> Time it takes to return an error from the process singleton algorithm (nor @@ -116,7 +118,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.ProcessSingleton.TimeToNotify" units="ms" - expires_after="2018-08-30"> + expires_after="2022-04-24"> + <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary> Time it takes to find the process singleton owner and notify it. Reported @@ -145,7 +148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Chrome.Tabs.AnimationSmoothness.TabLoading" units="%" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yichenz@chromium.org</owner> <owner>chromeos-wmp@google.com</owner> <summary> @@ -169,7 +172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeColors.ColorOnLoad" enum="ChromeColorsInfo" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>gayane@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/chromeos/histograms.xml b/chromium/tools/metrics/histograms/metadata/chromeos/histograms.xml index 2fa902f33c2..523c9c3d685 100644 --- a/chromium/tools/metrics/histograms/metadata/chromeos/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/chromeos/histograms.xml @@ -32,6 +32,11 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. <owner>cros-connectivity@google.com</owner> <owner>hsuregan@chromium.org</owner> </variant> + <variant name="FastPair" summary="Fast Pair"> + <owner>shanefitz@google.com</owner> + <owner>julietlevesque@google.com</owner> + <owner>chromeos-cross-device-eng@google.com</owner> + </variant> <variant name="Fingerprint" summary="fingerprint"> <owner>rsorokin@chromium.org</owner> <owner>tomhughes@chromium.org</owner> @@ -46,6 +51,16 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> </variant> + <variant name="NearbyShareBackgroundScanning" + summary="Background scanning for Nearby Share to detect and notify the + user of devices nearby that are attempting to share"> + <owner>hansenmichael@google.com</owner> + <owner>nearby-share-chromeos-eng@google.com</owner> + </variant> + <variant name="SmartLock" summary="Smart Lock"> + <owner>hansberry@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> + </variant> <variant name="StylusDetachedFromDockSession" summary="Time spent from stylus being undocked, to being re-docked"> <owner>kenalba@google.com</owner> @@ -65,7 +80,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="ChromeOS.Apps.ExternalProtocolDialog" - enum="ArcIntentHandlerAction" expires_after="2021-11-21"> + enum="ArcIntentHandlerAction" expires_after="2022-05-21"> <owner>dominickn@chromium.org</owner> <owner>melzhang@chromium.org</owner> <owner>mxcai@chromium.org</owner> @@ -76,7 +91,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Apps.ExternalProtocolDialog.Accepted" - enum="ArcExternalProtocolAction" expires_after="M94"> + enum="ArcExternalProtocolAction" expires_after="2022-05-21"> <owner>dominickn@chromium.org</owner> <owner>melzhang@chromium.org</owner> <owner>mxcai@chromium.org</owner> @@ -88,7 +103,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Apps.ExternalProtocolDialog.Rejected" - enum="ArcExternalProtocolAction" expires_after="M94"> + enum="ArcExternalProtocolAction" expires_after="2022-05-21"> <owner>dominickn@chromium.org</owner> <owner>melzhang@chromium.org</owner> <owner>mxcai@chromium.org</owner> @@ -99,7 +114,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Apps.IntentPickerAction" - enum="ArcIntentHandlerAction" expires_after="2021-12-19"> + enum="ArcIntentHandlerAction" expires_after="2022-05-21"> <owner>elijahtaylor@google.com</owner> <owner>dominickn@chromium.org</owner> <owner>shihuis@google.com</owner> @@ -110,7 +125,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Apps.IntentPickerDestinationPlatform" - enum="ArcIntentHandlerDestinationPlatform" expires_after="2021-12-05"> + enum="ArcIntentHandlerDestinationPlatform" expires_after="2022-05-21"> <owner>elijahtaylor@google.com</owner> <owner>dominickn@chromium.org</owner> <owner>shihuis@google.com</owner> @@ -123,7 +138,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Apps.NumberOfAppsForNotification" - enum="BooleanMultipleApps" expires_after="2021-10-10"> + enum="BooleanMultipleApps" expires_after="2022-07-01"> <owner>dominickn@chromium.org</owner> <owner>nancylingwang@chromium.org</owner> <summary> @@ -133,7 +148,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Apps.OpenBrowser" enum="OpenBrowserType" - expires_after="2020-12-14"> + expires_after="2022-05-21"> <owner>ajlinker@chromium.org</owner> <owner>dominickn@chromium.org</owner> <owner>mxcai@chromium.org</owner> @@ -166,7 +181,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="ChromeOS.Camera.ConfigureStreams.Output.Resolution" units="pixels" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <!-- Name completed by histogram_suffixes name="ChromeOS.Camera.StreamFormat" --> @@ -179,7 +194,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Camera.ConfigureStreamsLatency" units="microseconds" - expires_after="2021-12-05"> + expires_after="2022-10-01"> <owner>wtlee@chromium.org</owner> <owner>chromeos-camera-eng@google.com</owner> <summary> @@ -192,7 +207,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Camera.ErrorType" enum="ChromeOSCameraErrorType" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>wtlee@chromium.org</owner> <owner>chromeos-camera-eng@google.com</owner> <summary> @@ -202,7 +217,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Camera.Facing" enum="ChromeOSCameraFacing" - expires_after="2022-02-06"> + expires_after="2022-10-01"> <owner>wtlee@chromium.org</owner> <owner>chromeos-camera-eng@google.com</owner> <summary> @@ -211,7 +226,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.Camera.Jpeg.Latency" units="microseconds" - expires_after="2021-12-05"> + expires_after="2022-10-01"> <!-- Name completed by histogram_suffixes name="ChromeOS.Camera.JpegProcessMethod" and name="ChromeOS.Camera.JpegProcessType" --> @@ -230,7 +245,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.Camera.Jpeg.Resolution" units="pixels" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <!-- Name completed by histogram_suffixes name="ChromeOS.Camera.JpegProcessMethod" and name="ChromeOS.Camera.JpegProcessType" --> @@ -246,7 +261,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Camera.OpenDeviceClientType" - enum="ChromeOSCameraClientType" expires_after="2022-02-06"> + enum="ChromeOSCameraClientType" expires_after="2022-10-01"> <owner>lnishan@chromium.org</owner> <owner>chromeos-camera-eng@google.com</owner> <summary> @@ -256,7 +271,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Camera.OpenDeviceLatency" units="microseconds" - expires_after="2021-12-05"> + expires_after="2022-10-01"> <owner>wtlee@chromium.org</owner> <owner>chromeos-camera-eng@google.com</owner> <summary> @@ -268,7 +283,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Camera.SessionDuration" units="seconds" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>wtlee@chromium.org</owner> <owner>chromeos-camera-eng@google.com</owner> <summary>Records the session duration in Chrome OS camera service.</summary> @@ -326,7 +341,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.CWP.CollectPerf" - enum="ChromeOSProfileCollectionStatus" expires_after="2021-12-26"> + enum="ChromeOSProfileCollectionStatus" expires_after="2022-05-01"> <owner>aalexand@google.com</owner> <owner>gmx@chromium.org</owner> <summary> @@ -357,7 +372,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.CWP.ParseCPUFrequencies" - enum="ChromeOSParseCPUFrequencyStatus" expires_after="2021-12-12"> + enum="ChromeOSParseCPUFrequencyStatus" expires_after="2022-05-01"> <owner>gmx@chromium.org</owner> <owner>cwp-team@google.com</owner> <summary> @@ -368,7 +383,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.CWP.ParsePSICPU" enum="ChromeOSParsePSICPUStatus" - expires_after="2022-02-25"> + expires_after="2022-05-01"> <owner>dubin@google.com</owner> <owner>cwp-team@google.com</owner> <summary> @@ -390,7 +405,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.CWP.UploadPerf" units="reports" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>aalexand@google.com</owner> <owner>gmx@chromium.org</owner> <summary> @@ -400,7 +415,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.DeviceSettings.FeatureFlagsMigration" - enum="DeviceSettingsFeatureFlagsMigrationStatus" expires_after="2022-01-30"> + enum="DeviceSettingsFeatureFlagsMigrationStatus" expires_after="2022-04-10"> <owner>mnissler@chromium.org</owner> <owner>src/chrome/browser/ash/settings/OWNERS</owner> <summary> @@ -474,7 +489,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.FamilyLink.ChildStatusReportRequest.Size" units="KB" - expires_after="2021-09-09"> + expires_after="2022-08-23"> <owner>tobyhuang@chromium.org</owner> <owner>cros-families-eng@google.com</owner> <summary> @@ -486,7 +501,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ChromeOS.FamilyLink.ChildStatusReportRequest.TimeSinceLastReport" - units="minutes" expires_after="2021-09-09"> + units="minutes" expires_after="2022-08-23"> <owner>tobyhuang@chromium.org</owner> <owner>cros-families-eng@google.com</owner> <summary> @@ -635,7 +650,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.HardwareVerifier.Report" - enum="HardwareVerifierQualificationStatus" expires_after="2021-12-26"> + enum="HardwareVerifierQualificationStatus" expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="HardwareVerifierSupportCategory" --> <owner>itspeter@chromium.org</owner> @@ -648,7 +663,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.HardwareVerifier.Report.IsCompliant" enum="Boolean" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>itspeter@chromium.org</owner> <owner>stimim@chromium.org</owner> <owner>chromeos-hw-checker@google.com</owner> @@ -656,7 +671,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.HardwareVerifier.TimeToFinish" units="ms" - expires_after="2021-11-21"> + expires_after="2022-04-17"> <owner>itspeter@chromium.org</owner> <owner>stimim@chromium.org</owner> <owner>chromeos-hw-checker@google.com</owner> @@ -666,7 +681,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.HardwareVerifier.TimeToProbe" units="ms" - expires_after="2021-11-21"> + expires_after="2022-04-10"> <owner>itspeter@chromium.org</owner> <owner>stimim@chromium.org</owner> <owner>chromeos-hw-checker@google.com</owner> @@ -755,7 +770,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.KeyPermissionsManager.Migration" - enum="KeyPermissionsManagerMigrationStatus" expires_after="2021-12-12"> + enum="KeyPermissionsManagerMigrationStatus" expires_after="2022-05-01"> <owner>omorsi@google.com</owner> <owner>pmarko@google.com</owner> <summary> @@ -774,8 +789,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Lacros.OSChannel" enum="ChromeOSChannel" - expires_after="2021-10-01"> - <owner>jamescook@chromium.org</owner> + expires_after="2022-10-01"> <owner>erikchen@chromium.org</owner> <owner>lacros-team@google.com</owner> <summary> @@ -786,8 +800,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Lacros.StartTime" units="ms" - expires_after="2021-10-01"> - <owner>jamescook@chromium.org</owner> + expires_after="2022-10-01"> <owner>erikchen@chromium.org</owner> <owner>lacros-team@google.com</owner> <summary> @@ -797,6 +810,28 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ChromeOS.LanguagePacks.InstallComplete.Success" + enum="BooleanSuccess" expires_after="2022-10-01"> + <owner>claudiomagni@chromium.org</owner> + <owner>mlcui@google.com</owner> + <owner>dvallet@chromium.org</owner> + <summary> + Records whether a language pack installation was successful after a language + pack installation attempt. + </summary> +</histogram> + +<histogram name="ChromeOS.LanguagePacks.UninstallComplete.Success" + enum="BooleanSuccess" expires_after="2022-10-01"> + <owner>claudiomagni@chromium.org</owner> + <owner>mlcui@google.com</owner> + <owner>dvallet@chromium.org</owner> + <summary> + Records whether a language pack uninstallation was successful after a + language pack uninstallation attempt. + </summary> +</histogram> + <histogram name="ChromeOS.LegacySupervisedUsers.HiddenFromLoginScreen" enum="LegacySupervisedUserStatus" expires_after="2022-04-09"> <owner>tobyhuang@chromium.org</owner> @@ -906,7 +941,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.MachineIdRegen.Reason" enum="ChromeOSMachineIdReason" - expires_after="2022-02-02"> + expires_after="2022-05-01"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -918,7 +953,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.MemoryPressureLevel" enum="MemoryPressureLevel" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>xdai@chromium.org</owner> <summary> The memory pressure level in Chrome OS, which is recorded periodically (once @@ -941,7 +976,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.PlatformKeysService.{Operation}.{KeyType}" - enum="BooleanSuccess" expires_after="2021-09-19"> + enum="BooleanSuccess" expires_after="2022-03-19"> <owner>omorsi@google.com</owner> <owner>mgawad@google.com</owner> <summary> @@ -994,7 +1029,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.PlatformVerification.Result2" - enum="ChromeOSPlatformVerificationResult2" expires_after="2021-12-21"> + enum="ChromeOSPlatformVerificationResult2" expires_after="2022-05-01"> <owner>erikchen@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary> @@ -1016,7 +1051,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.SAML.APILogin" enum="ChromeOSSamlApiUsed" - expires_after="2021-10-02"> + expires_after="2022-04-02"> <owner>mslus@chromium.org</owner> <owner>emaxx@chromium.org</owner> <summary> @@ -1025,7 +1060,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.SAML.InSessionPasswordChangeEvent" - enum="SamlInSessionPasswordChangeEvent" expires_after="2021-09-12"> + enum="SamlInSessionPasswordChangeEvent" expires_after="2022-03-12"> <owner>mslus@chromium.org</owner> <owner>rsorokin@chromium.org</owner> <summary> @@ -1035,7 +1070,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.SAML.InSessionPasswordSyncEvent" - enum="SamlInSessionPasswordSyncEvent" expires_after="2021-10-30"> + enum="SamlInSessionPasswordSyncEvent" expires_after="2022-04-30"> <owner>mslus@chromium.org</owner> <owner>mohammedabdon@chromium.org</owner> <summary> @@ -1045,7 +1080,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.SAML.Provider" enum="ChromeOSSamlProvider" - expires_after="2021-10-17"> + expires_after="2022-04-17"> <owner>mslus@chromium.org</owner> <owner>mohammedabdon@chromium.org</owner> <summary>Records SAML provider when SAML login flow is used.</summary> @@ -1062,7 +1097,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.SAML.Scraping.PasswordCountAll" units="passwords" - expires_after="2021-09-21"> + expires_after="2022-03-21"> <owner>mslus@chromium.org</owner> <owner>emaxx@chromium.org</owner> <summary> @@ -1082,7 +1117,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.SecurityAnomaly" enum="SecurityAnomaly" - expires_after="M98"> + expires_after="2022-04-03"> <owner>jorgelo@chromium.org</owner> <owner>chromeos-security-core@google.com</owner> <summary> @@ -1117,8 +1152,18 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ChromeOS.Settings.Apps.DoNotDisturbOnOff" + enum="BooleanToggled" expires_after="2022-09-01"> + <owner>hsuregan@chromium.org</owner> + <owner>jimmyxgong@chromium.org</owner> + <summary> + Records when a user changes the kDoNotDisturbOnOff setting in the + Notifications subpage of the Apps section. + </summary> +</histogram> + <histogram name="ChromeOS.Settings.Bluetooth.BluetoothOnOff" - enum="BooleanToggled" expires_after="2022-02-06"> + enum="BooleanToggled" expires_after="2022-04-24"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1128,7 +1173,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.BlurredWindowDuration" units="ms" - expires_after="2021-10-01"> + expires_after="2022-09-01"> <owner>khorimoto@chromium.org</owner> <owner>cros-customization@google.com</owner> <summary> @@ -1138,10 +1183,10 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.Device.KeyboardFunctionKeys" - enum="BooleanToggled" expires_after="2021-09-30"> - <owner>khorimoto@chromium.org</owner> - <owner>hsuregan@chromium.org</owner> - <owner>cros-customization@google.com</owner> + enum="BooleanToggled" expires_after="2022-03-15"> + <owner>jimmyxgong@chromium.org</owner> + <owner>zentaro@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> <summary> Records when a user changes the kKeyboardFunctionKeys setting on the Device page. @@ -1161,7 +1206,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.Inputs.ShortcutReminderDismissed" - enum="SettingsInputsShortcutReminderState" expires_after="2022-02-06"> + enum="SettingsInputsShortcutReminderState" expires_after="2022-05-01"> <owner>mlcui@google.com</owner> <owner>cros-borders@google.com</owner> <summary> @@ -1216,7 +1261,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.Languages.Interaction" - enum="SettingsLanguagesPageInteraction" expires_after="2022-02-06"> + enum="SettingsLanguagesPageInteraction" expires_after="2022-04-10"> <owner>myy@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -1226,7 +1271,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.Languages.OfferToTranslateCheckbox" - enum="BooleanChecked" expires_after="2022-02-06"> + enum="BooleanChecked" expires_after="2022-04-24"> <owner>myy@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -1236,7 +1281,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.Languages.SupportPageVisits" - enum="SettingsLanguagesSupportPage" expires_after="2022-02-06"> + enum="SettingsLanguagesSupportPage" expires_after="2022-05-01"> <owner>myy@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -1245,7 +1290,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.Settings.Languages.Toggle" - enum="BooleanToggled" expires_after="2022-02-06"> + enum="BooleanToggled" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="SettingsLanguagesPageToggle" --> <owner>myy@chromium.org</owner> @@ -1257,8 +1302,8 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.LoadCompletedTime" units="ms" - expires_after="2021-10-01"> - <owner>jamescook@chromium.org</owner> + expires_after="2022-04-01"> + <owner>khorimoto@chromium.org</owner> <owner>cros-system-services@google.com</owner> <summary> The amount of time between the render frame host StartProvisionalLoad event @@ -1268,8 +1313,8 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.LoadDocumentTime" units="ms" - expires_after="2021-10-01"> - <owner>jamescook@chromium.org</owner> + expires_after="2022-04-01"> + <owner>khorimoto@chromium.org</owner> <owner>cros-system-services@google.com</owner> <summary> The amount of time between the render frame host StartProvisionalLoad and @@ -1277,6 +1322,16 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ChromeOS.Settings.NotificationPage.PermissionOnOff" + enum="BooleanToggled" expires_after="2022-09-01"> + <owner>hsuregan@chromium.org</owner> + <owner>jimmyxgong@chromium.org</owner> + <summary> + Records when a user changes the notification permission of any app in the + Notifications subpage of the Apps section. + </summary> +</histogram> + <histogram name="ChromeOS.Settings.NumCharsOfQueries" units="characters" expires_after="2022-02-06"> <owner>khorimoto@chromium.org</owner> @@ -1289,7 +1344,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.Settings.NumClicksUntilChange" - units="clicks" expires_after="2021-10-01"> + units="clicks" expires_after="2022-09-01"> <!-- Name completed by histogram_suffixes name="OsSettingsChangeType" --> <owner>khorimoto@chromium.org</owner> @@ -1298,7 +1353,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.Settings.NumNavigationsUntilChange" - units="navigations" expires_after="2021-10-01"> + units="navigations" expires_after="2022-09-01"> <!-- Name completed by histogram_suffixes name="OsSettingsChangeType" --> <owner>khorimoto@chromium.org</owner> @@ -1307,7 +1362,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.Settings.NumSearchesUntilChange" - units="searches" expires_after="2021-10-01"> + units="searches" expires_after="2022-09-01"> <!-- Name completed by histogram_suffixes name="OsSettingsChangeType" --> <owner>khorimoto@chromium.org</owner> @@ -1338,7 +1393,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.PathVisited" enum="WebUISettingsPathHashes" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>khorimoto@chromium.org</owner> <owner>cros-customization@google.com</owner> <summary> @@ -1348,7 +1403,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.People.AddAccountCount" units="accounts" - expires_after="2021-09-30"> + expires_after="2022-03-15"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1371,7 +1426,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SearchLatency" units="ms" - expires_after="2021-10-01"> + expires_after="2022-09-01"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1382,7 +1437,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SearchRequests" - enum="OsSettingSearchRequestTypes" expires_after="2022-02-06"> + enum="OsSettingSearchRequestTypes" expires_after="2022-04-17"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1396,7 +1451,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SearchRequestsPerSession" - units="mojo search requests" expires_after="2021-10-01"> + units="mojo search requests" expires_after="2022-09-01"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1407,7 +1462,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SearchResultSectionSelected" - enum="OsSettingsSection" expires_after="2022-02-06"> + enum="OsSettingsSection" expires_after="2022-04-17"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1417,7 +1472,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SearchResultSettingSelected" - enum="OsSetting" expires_after="2021-10-01"> + enum="OsSetting" expires_after="2022-09-01"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1427,7 +1482,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SearchResultSubpageSelected" - enum="OsSettingsSubpage" expires_after="2022-02-06"> + enum="OsSettingsSubpage" expires_after="2022-04-24"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1437,7 +1492,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SearchResultTypeSelected" - enum="OsSettingsSearchResultType" expires_after="2022-02-06"> + enum="OsSettingsSearchResultType" expires_after="2022-04-24"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1447,7 +1502,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.SettingChanged" enum="OsSetting" - expires_after="2021-10-01"> + expires_after="2022-09-01"> <owner>khorimoto@chromium.org</owner> <owner>hsuregan@chromium.org</owner> <owner>cros-customization@google.com</owner> @@ -1460,7 +1515,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.Settings.TimeUntilChange" units="ms" - expires_after="2021-10-01"> + expires_after="2022-09-01"> <!-- Name completed by histogram_suffixes name="OsSettingsChangeType" --> <owner>khorimoto@chromium.org</owner> @@ -1506,7 +1561,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Settings.WindowOpenDuration" units="ms" - expires_after="2021-10-01"> + expires_after="2022-09-01"> <owner>khorimoto@chromium.org</owner> <owner>cros-customization@google.com</owner> <summary> @@ -1563,7 +1618,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Sharesheet.FileCount" units="files" - expires_after="M97"> + expires_after="2022-05-01"> <owner>dominickn@chromium.org</owner> <owner>melzhang@chromium.org</owner> <summary> @@ -1573,7 +1628,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Sharesheet.FormFactor" - enum="ChromeOSSharesheetFormFactor" expires_after="2021-12-12"> + enum="ChromeOSSharesheetFormFactor" expires_after="2022-04-24"> <owner>dominickn@chromium.org</owner> <owner>melzhang@chromium.org</owner> <summary>Records the form factor when the Sharesheet is invoked.</summary> @@ -1590,7 +1645,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Sharesheet.IsImagePreviewPressed" - enum="BooleanSelected" expires_after="M97"> + enum="BooleanSelected" expires_after="2022-04-24"> <owner>dominickn@chromium.org</owner> <owner>melzhang@chromium.org</owner> <summary> @@ -1616,7 +1671,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.Sharesheet.UserAction" - enum="ChromeOSSharesheetAction" expires_after="2021-12-12"> + enum="ChromeOSSharesheetAction" expires_after="2022-04-10"> <owner>dominickn@chromium.org</owner> <owner>melzhang@chromium.org</owner> <summary>Records user action on sharesheet invocations.</summary> @@ -1798,7 +1853,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.TypeC.CableSpeed" enum="CableSpeedMetric" - expires_after="2021-10-31"> + expires_after="2022-04-30"> <owner>pmalani@chromium.org</owner> <owner>chromeos-power@google.com</owner> <summary> @@ -1808,7 +1863,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.TypeC.PartnerType" enum="PartnerTypeMetric" - expires_after="2021-10-31"> + expires_after="2022-04-30"> <owner>pmalani@chromium.org</owner> <owner>chromeos-power@google.com</owner> <summary> @@ -1819,7 +1874,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.TypeC.WrongConfiguration" - enum="WrongConfigurationMetric" expires_after="2021-10-31"> + enum="WrongConfigurationMetric" expires_after="2022-04-30"> <owner>pmalani@chromium.org</owner> <owner>chromeos-power@google.com</owner> <summary> @@ -1830,7 +1885,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.UrlXattrsCount" units="units" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>jorgelo@chromium.org</owner> <owner>tnagel@chromium.org</owner> <summary> @@ -1841,7 +1896,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ChromeOS.USB.DeviceAttached" - enum="ChromeOSUsbEventTiming" expires_after="2021-10-17"> + enum="ChromeOSUsbEventTiming" expires_after="2022-09-08"> <owner>allenwebb@chromium.org</owner> <owner>jorgelo@chromium.org</owner> <owner>mnissler@chromium.org</owner> @@ -1864,6 +1919,9 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ChromeOS.UserAddingScreen.LoadTimeViewsBased" units="ms" expires_after="2021-09-19"> + <obsolete> + Removed in M96. + </obsolete> <owner>tellier@google.com</owner> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -1874,7 +1932,7 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromeOS.UserTypeByDeviceType.LogSegment" - enum="UserDeviceMatrix" expires_after="2021-12-12"> + enum="UserDeviceMatrix" expires_after="2022-04-24"> <owner>bmalcolm@chromium.org</owner> <owner>cros-client-wa@google.com</owner> <summary> @@ -1888,6 +1946,19 @@ incoming reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ChromeOS.WebAPK.UnlinkedWebAPKCount" units="count" + expires_after="2022-03-14"> + <owner>tsergeant@chromium.org</owner> + <owner>chromeos-apps-foundation-team@google.com</owner> + <summary> + Records the number of installed WebAPKs that were not linked to a Web App + which were found and removed. The presence of these apps indicates that + something went wrong in the WebAPK installation process. Unlinked apps are + detected every startup, this histogram is only recorded when at least 1 app + is found. + </summary> +</histogram> + <histogram name="ChromeOS.WebAPK.{InstallType}.ArcInstallResult" enum="WebApkArcInstallResultChromeOS" expires_after="2022-01-14"> <owner>tsergeant@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/chromeos_hps/histograms.xml b/chromium/tools/metrics/histograms/metadata/chromeos_hps/histograms.xml new file mode 100644 index 00000000000..56035f060e4 --- /dev/null +++ b/chromium/tools/metrics/histograms/metadata/chromeos_hps/histograms.xml @@ -0,0 +1,51 @@ +<!-- +Copyright 2021 The Chromium Authors. All rights reserved. +Use of this source code is governed by a BSD-style license that can be +found in the LICENSE file. +--> + +<!-- +This file is used to generate a comprehensive list of hps (go/cros-hps) histograms +along with a detailed description for each histogram. + +For best practices on writing histogram descriptions, see +https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md + +Please send CLs to chromium-metrics-reviews@google.com rather than to specific +individuals. These CLs will be automatically reassigned to a reviewer within +about 5 minutes. This approach helps the metrics team to load-balance incoming +reviews. Googlers can read more about this at go/gwsq-gerrit. +--> + +<histogram-configuration> + +<histograms> + +<histogram name="ChromeOS.HPS.TurnOn.Result" enum="HpsTurnOnResult" + expires_after="2022-07-01"> + <owner>evanbenn@chromium.org</owner> + <owner>avg@chromium.org</owner> + <owner>chromeos-hps-swe@google.com</owner> + <summary> + Reports the result of each attempt to turn the hps device on. + </summary> +</histogram> + +<histogram name="ChromeOS.HPS.TurnOn.{Result}.Duration" units="ms" + expires_after="2022-07-01"> + <owner>evanbenn@chromium.org</owner> + <owner>avg@chromium.org</owner> + <owner>chromeos-hps-swe@google.com</owner> + <summary> + Measures the time it took to turn on the device, when the result was + {Result}. + </summary> + <token key="Result"> + <variant name="Failed"/> + <variant name="Success"/> + </token> +</histogram> + +</histograms> + +</histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/commerce/histograms.xml b/chromium/tools/metrics/histograms/metadata/commerce/histograms.xml index c26098da784..e6dc98be8a6 100644 --- a/chromium/tools/metrics/histograms/metadata/commerce/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/commerce/histograms.xml @@ -33,20 +33,125 @@ https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histogra summary="Tabs between 1 and 90 days since last usage."/> </variants> +<histogram name="Commerce.Carts.ExtractionElapsedTime" units="ms" + expires_after="2022-06-30"> + <owner>wychen@chromium.org</owner> + <owner>yuezhanggg@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Logged when cart content extraction is executed for ChromeCart. This + histogram records the elapsed time within the JavaScript, so script + parsing/compilation time is excluded. Commerce.Carts.ExtractionExecutionTime + is measured in native, and is the end-to-end elapsed time. + </summary> +</histogram> + <histogram name="Commerce.Carts.ExtractionExecutionTime" units="ms" - expires_after="2021-12-30"> + expires_after="2022-06-30"> <owner>wychen@chromium.org</owner> <owner>yuezhanggg@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> Logged when cart content extraction is executed for ChromeCart. This histogram records the elapsed time between the start and the end of the - extraction JavaScript request execution. + extraction JavaScript request execution. This includes script + parsing/compilation time and sleeping time. + </summary> +</histogram> + +<histogram name="Commerce.Carts.ExtractionLongestTaskTime" units="ms" + expires_after="2022-06-30"> + <owner>wychen@chromium.org</owner> + <owner>yuezhanggg@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Logged when cart content extraction is executed for ChromeCart. This + histogram records the time span of the longest task blocking the main thread + of the renderer process. + </summary> +</histogram> + +<histogram name="Commerce.Carts.ExtractionTimedOut" enum="BooleanTimedOut" + expires_after="2022-06-30"> + <owner>wychen@chromium.org</owner> + <owner>yuezhanggg@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Record whether the cart content extraction has timed out. Logged when cart + content extraction is executed for ChromeCart. + </summary> +</histogram> + +<histogram name="Commerce.Carts.ExtractionTotalTasksTime" units="ms" + expires_after="2022-06-30"> + <owner>wychen@chromium.org</owner> + <owner>yuezhanggg@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Logged when cart content extraction is executed for ChromeCart. This + histogram records the time spent on execution, excluding sleeping time. + </summary> +</histogram> + +<histogram name="Commerce.Carts.FormSubmitIsTransaction" + units="BooleanIsTransaction" expires_after="2022-06-01"> + <owner>wychen@chromium.org</owner> + <owner>yuezhanggg@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Records whether the form submission is a shopping transaction. This has 50% + chance randomized. Logged when there's a form submission. + </summary> +</histogram> + +<histogram name="Commerce.Carts.XHRIsAddToCart" units="BooleanIsAddToCart" + expires_after="2022-06-01"> + <owner>wychen@chromium.org</owner> + <owner>yuezhanggg@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Records whether the XHR is to add a product to a shopping cart. This has 50% + chance randomized. Logged when there's an XHR about to be sent. + </summary> +</histogram> + +<histogram + name="Commerce.PowerBookmarks.ShoppingDataProvider.FallbackDataContent" + enum="ShoppingDataProviderFallback" expires_after="M100"> + <owner>ayman@chromium.org</owner> + <owner>mdjones@chromium.org</owner> + <summary> + Records whick type of fallback data (javascript on-page heuristics) was used + when filling in gaps from Optimization Guide. This does not track whether + the page was actually bookmarked, it only indicates what information might + be missing or how often we get supplementary images when on a product page. + </summary> +</histogram> + +<histogram name="Commerce.PowerBookmarks.ShoppingDataProvider.FallbackDataUsed" + enum="Boolean" expires_after="M100"> + <owner>ayman@chromium.org</owner> + <owner>mdjones@chromium.org</owner> + <summary> + Records whether fallback data (javascript on-page heuristics) was used to + supplement the data provided by Optimization Guide. This does not track + whether the page was actually bookmarked. + </summary> +</histogram> + +<histogram name="Commerce.PowerBookmarks.ShoppingDataProvider.IsProductPage" + enum="Boolean" expires_after="M100"> + <owner>ayman@chromium.org</owner> + <owner>mdjones@chromium.org</owner> + <summary> + Records whether a particular navigation was determined to be a product page + by Optimization Guide. This doesn not track whether the page was actually + bookmarked. </summary> </histogram> <histogram name="Commerce.PriceDrop.NotificationChannelBlocked" enum="Boolean" - expires_after="M97"> + expires_after="2022-06-01"> <owner>zhiyuancai@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -57,7 +162,7 @@ https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histogra </histogram> <histogram name="Commerce.PriceDrop.NotificationChannelCreated" enum="Boolean" - expires_after="M97"> + expires_after="2022-06-01"> <owner>zhiyuancai@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -67,7 +172,7 @@ https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histogra </histogram> <histogram name="Commerce.PriceDrop.SystemNotificationEnabled" enum="Boolean" - expires_after="M97"> + expires_after="2022-06-01"> <owner>zhiyuancai@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/compositing/histograms.xml b/chromium/tools/metrics/histograms/metadata/compositing/histograms.xml index 4574af0a7bf..ad157bc42ba 100644 --- a/chromium/tools/metrics/histograms/metadata/compositing/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/compositing/histograms.xml @@ -21,6 +21,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> +<histogram name="Compositing.Browser.GPUMemoryForTilingsInKb" units="Kb" + expires_after="2022-04-17"> + <owner>pdr@chromium.org</owner> + <owner>paint-dev@chromium.org</owner> + <owner>sky@chromium.org</owner> + <summary> + Warning: this histogram was expired from ~9/2020 to ~8/2021. + + The GPU memory allocated for tilings (in a browser process), summed over all + picture layers. Emitted once per drawing. Nothing is recorded if there are + no picture layers. + + Tilings are used for decomposition of the layer's entire contents at a + picture screenspace resolution to do threaded rasterization. + </summary> +</histogram> + <histogram name="Compositing.Browser.HitTestTimeToFindClosestLayer" units="microseconds" expires_after="2020-12-01"> <obsolete> @@ -41,7 +58,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Browser.LayersUpdateTime" units="microseconds" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>schenney@chromium.org</owner> <owner>animations-dev@chromium.org</owner> <summary> @@ -57,7 +74,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Browser.LayerTreeImpl.CalculateDrawPropertiesUs" - units="microseconds" expires_after="2022-01-02"> + units="microseconds" expires_after="2022-03-06"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -83,7 +100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Browser.NumActivePictureLayers" units="layers" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -139,7 +156,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.DirectRenderer.GL.DrawFrameUs" - units="microseconds" expires_after="2021-12-19"> + units="microseconds" expires_after="2022-04-24"> <owner>weiliangc@chromium.org</owner> <summary> Time spent drawing of composited layers by GLRenderer, in microseconds. This @@ -154,7 +171,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.DirectRenderer.OverlayProcessingUs" - units="microseconds" expires_after="2021-10-01"> + units="microseconds" expires_after="2022-05-01"> <owner>khaslett@chromium.org</owner> <owner>kylechar@chromium.org</owner> <summary> @@ -170,7 +187,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.DirectRenderer.PartialSwap.ExtraDamage" units="%" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -185,7 +202,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.DirectRenderer.PartialSwap.FrameBufferDamage" - units="%" expires_after="2022-02-01"> + units="%" expires_after="2022-04-17"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -199,7 +216,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.DirectRenderer.PartialSwap.RootDamage" units="%" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -211,7 +228,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.DirectRenderer.PartialSwap.TotalDamage" units="%" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -255,7 +272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Display.Draw.Occlusion.Calculation.Time" - units="microseconds" expires_after="2022-02-06"> + units="microseconds" expires_after="2022-04-10"> <owner>yiyix@chromium.org</owner> <owner>chromeos-gfx@chromium.org</owner> <summary> @@ -290,7 +307,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Display.DrawToSwapUs" units="microseconds" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>backer@chromium.org</owner> <owner>rjkroege@chromium.org</owner> <summary> @@ -326,7 +343,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Display.FlattenedRenderPassCount" units="units" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>backer@chromium.org</owner> <owner>rjkroege@chromium.org</owner> <summary> @@ -361,7 +378,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Display.VizDependencyResolvedToGpuStartedDrawUs" - units="microseconds" expires_after="2022-02-09"> + units="microseconds" expires_after="2022-04-10"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -374,7 +391,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Display.VizScheduledDrawToDependencyResolvedUs" - units="microseconds" expires_after="2022-02-09"> + units="microseconds" expires_after="2022-04-10"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -388,7 +405,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Display.VizScheduledDrawToGpuStartedDrawUs" - units="microseconds" expires_after="2022-02-09"> + units="microseconds" expires_after="2022-04-10"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -401,7 +418,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.CALayerResult" enum="CALayerResult" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>ccameron@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -446,8 +463,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Compositing.Renderer.LayerSkippedForDrawPropertiesDueToBackface" - units="boolean" expires_after="M94"> + units="boolean" expires_after="2022-02-01"> <owner>chrishtr@chromium.org</owner> + <owner>dbaron@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> Records whether layer draw properties updates were skipped due to the layer @@ -457,7 +475,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.LayersUpdateTime" units="microseconds" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -489,8 +507,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.LayerUpdateSkippedDueToBackface" - units="boolean" expires_after="2021-10-25"> + units="boolean" expires_after="2022-02-01"> <owner>chrishtr@chromium.org</owner> + <owner>dbaron@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> Records whether a layer update was skipped due to the layer being @@ -500,7 +519,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.LCDTextDisallowedReasonKPixels" - enum="LCDTextDisallowedReason" expires_after="2021-12-05"> + enum="LCDTextDisallowedReason" expires_after="2022-04-03"> <owner>wangxianzhu@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -513,7 +532,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.LCDTextDisallowedReasonLayers" - enum="LCDTextDisallowedReason" expires_after="2021-12-05"> + enum="LCDTextDisallowedReason" expires_after="2022-04-10"> <owner>wangxianzhu@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -523,7 +542,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.NumActiveLayers" units="layers" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -533,7 +552,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.NumActivePictureLayers" units="layers" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -544,7 +563,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.Renderer.NumRenderSurfaces" units="surfaces" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -600,7 +619,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Compositing.ResourcePoolMemoryUsage" units="MB" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>sunnyps@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -610,8 +629,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.SurfaceAggregator.AggregateUs" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-08-19"> <owner>weiliangc@chromium.org</owner> + <owner>kylechar@chromium.org</owner> <summary> Time spent aggregating compositor frames from different surfaces in microseconds. This is logged once per frame. @@ -625,7 +645,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.SurfaceAggregator.CopiedSurfaceCount" - units="surfaces" expires_after="2021-09-05"> + units="surfaces" expires_after="2022-05-01"> <owner>kylechar@chromium.org</owner> <owner>jonross@chromium.org</owner> <summary> @@ -635,7 +655,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.SurfaceAggregator.CopyUs" units="microseconds" - expires_after="2021-09-05"> + expires_after="2022-04-17"> <owner>kylechar@chromium.org</owner> <owner>jonross@chromium.org</owner> <summary> @@ -649,7 +669,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.SurfaceAggregator.DeclareResourceCount" - units="resources" expires_after="2021-09-05"> + units="resources" expires_after="2022-04-17"> <owner>kylechar@chromium.org</owner> <owner>jonross@chromium.org</owner> <summary> @@ -659,7 +679,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.SurfaceAggregator.DeclareResourcesUs" - units="microseconds" expires_after="2021-09-05"> + units="microseconds" expires_after="2022-04-03"> <owner>kylechar@chromium.org</owner> <owner>jonross@chromium.org</owner> <summary> @@ -684,7 +704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.SurfaceAggregator.PrewalkedSurfaceCount" - units="surfaces" expires_after="2021-09-05"> + units="surfaces" expires_after="2022-04-24"> <owner>kylechar@chromium.org</owner> <owner>jonross@chromium.org</owner> <summary> @@ -694,7 +714,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Compositing.SurfaceAggregator.PrewalkUs" units="microseconds" - expires_after="2021-09-05"> + expires_after="2022-04-03"> <owner>kylechar@chromium.org</owner> <owner>jonross@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/content/histograms.xml b/chromium/tools/metrics/histograms/metadata/content/histograms.xml index e38e53f56e5..d839bab43eb 100644 --- a/chromium/tools/metrics/histograms/metadata/content/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/content/histograms.xml @@ -130,7 +130,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentIndex.ContentAdded" enum="ContentIndexCategory" - expires_after="M95"> + expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>platform-capabilities@chromium.org</owner> <summary>Records the category of the content when registered.</summary> @@ -149,14 +149,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentIndex.ContentOpened" enum="ContentIndexCategory" - expires_after="M95"> + expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>platform-capabilities@chromium.org</owner> <summary>Records the category of the entry clicked on by a user.</summary> </histogram> <histogram base="true" name="ContentIndex.Database" - enum="ServiceWorkerStatusCode" expires_after="M95"> + enum="ServiceWorkerStatusCode" expires_after="M99"> <!-- Name completed by histogram_suffixes name="ContentIndexDatabaseTask" --> <owner>rayankans@chromium.org</owner> @@ -165,7 +165,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentIndex.NumEntriesAvailable" units="entries" - expires_after="M95"> + expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>platform-capabilities@chromium.org</owner> <summary> @@ -174,7 +174,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentIndex.RegistrationBlocked" enum="ContentIndexCategory" - expires_after="M95"> + expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>platform-capabilities@chromium.org</owner> <summary> @@ -183,7 +183,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSettings.AllowStorageAccessSync" units="ms" - expires_after="2021-12-29"> + expires_after="2022-04-03"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -192,6 +192,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ContentSettings.DefaultAutoDarkWebContetntSetting" + enum="ContentSetting" expires_after="2022-06-19"> + <owner>wenyufu@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> + <summary> + The default auto dark web content setting at profile open. Recorded for + Android only. + </summary> +</histogram> + <histogram name="ContentSettings.DefaultAutoplaySetting" enum="ContentSetting" expires_after="2022-06-19"> <owner>engedy@chromium.org</owner> @@ -284,6 +294,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>The default popups setting at profile open.</summary> </histogram> +<histogram name="ContentSettings.DefaultRequestDesktopSiteSetting" + enum="ContentSetting" expires_after="2022-04-01"> + <owner>shuyng@google.com</owner> + <owner>twellington@chromium.org</owner> + <summary> + The request desktop site content setting at profile open. Recorded for + Android only. + </summary> +</histogram> + <histogram name="ContentSettings.DefaultSoundSetting" enum="ContentSetting" expires_after="2022-06-19"> <owner>engedy@chromium.org</owner> @@ -401,7 +421,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSettings.ExtensionNonEmbeddedSettingSet" - enum="ContentType" expires_after="M100"> + enum="ContentType" expires_after="2022-05-01"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -422,7 +442,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSettings.NumberOfExceptions" units="units" - expires_after="M100"> + expires_after="2022-04-24"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -432,7 +452,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSettings.PermissionRequested" enum="PermissionType" - expires_after="M100"> + expires_after="2022-04-17"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -517,7 +537,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSettings.Popups" enum="ContentSettingPopupAction" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>charleszhao@chromium.org</owner> <owner>lazzzis@google.com</owner> <owner>src/components/blocked_content/OWNERS</owner> @@ -528,7 +548,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSettings.Popups.BlockerActions" - enum="PopupBlockerAction" expires_after="2021-10-31"> + enum="PopupBlockerAction" expires_after="M101"> <owner>csharrison@chromium.org</owner> <owner>lazzzis@google.com</owner> <owner>src/components/blocked_content/OWNERS</owner> @@ -594,7 +614,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSettings.Popups.StrongBlockerActions" - enum="StrongPopupBlockerAction" expires_after="2021-12-19"> + enum="StrongPopupBlockerAction" expires_after="2022-04-24"> <owner>csharrison@chromium.org</owner> <summary> Counts of various events related to the strong popup blocker (aka abusive @@ -603,7 +623,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.ActivityLoggingEnabled" enum="Boolean" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>rogerm@chromium.org</owner> <owner>feed@chromium.org</owner> <summary> @@ -692,6 +712,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ContentSuggestions.Feed.BrokenNTPHierarchy" + enum="NTPBrokenViewHierarchyRelationship" expires_after="M99"> + <owner>adamta@google.com</owner> + <owner>sczs@chromium.org</owner> + <owner>feed@chromium.org</owner> + <summary> + When the NTP view hierarchy is fixed upon NTP creation, this hisotgram logs + which part was broken. Temporary log used to gather info for + crbug.com/1262536. + </summary> +</histogram> + <histogram name="ContentSuggestions.Feed.CommitMutationCount" units="operations" expires_after="2020-10-01"> <owner>carlosk@chromium.org</owner> @@ -704,7 +736,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.ContentAgeOnLoad.BlockingRefresh" - units="ms" expires_after="2022-03-01"> + units="ms" expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -718,7 +750,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.ContentAgeOnLoad.NotRefreshed" - units="ms" expires_after="2022-03-01"> + units="ms" expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -737,7 +769,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <owner>vincb@google.com</owner> <owner>feed@chromium.org</owner> - <owner>src/chrome/browser/android/feed/OWNERS</owner> + <owner>src/components/feed/OWNERS</owner> <summary>Actions related to the feed controls.</summary> </histogram> @@ -756,7 +788,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.DisplayStatusOnOpen" - enum="ContentSuggestionsDisplayStatus" expires_after="2021-10-25"> + enum="ContentSuggestionsDisplayStatus" expires_after="2022-04-24"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -878,7 +910,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ContentSuggestions.Feed.LoadStepLatency" - units="ms" expires_after="2022-03-01"> + units="ms" expires_after="2022-05-01"> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> <summary> @@ -892,7 +924,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.LoadStreamStatus.LoadMore" - enum="FeedLoadStreamStatus" expires_after="2022-03-01"> + enum="FeedLoadStreamStatus" expires_after="2022-05-01"> <owner>harringtond@chromium.org</owner> <owner>carlosk@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -916,7 +948,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.Network.CompressedResponseSizeKB" - units="KB" expires_after="2022-03-01"> + units="KB" expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -928,7 +960,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.Network.Duration" units="ms" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -979,7 +1011,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.Network.ResponseSizeKB" units="KB" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -990,7 +1022,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.Network.ResponseStatus" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-03-01"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1013,7 +1045,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.Network.TokenFetchStatus" - enum="GoogleServiceAuthError" expires_after="2022-03-01"> + enum="GoogleServiceAuthError" expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1024,7 +1056,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.NoticeCardFulfilled" enum="Boolean" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>vincb@google.com</owner> <owner>feed@chromium.org</owner> <summary> @@ -1035,7 +1067,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.NoticeCardFulfilled2" enum="Boolean" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>vincb@google.com</owner> <owner>feed@chromium.org</owner> <summary> @@ -1228,7 +1260,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.TimeSpentInFeed" units="ms" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>carlosk@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1276,7 +1308,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.UploadActionsBatchStatus" - enum="FeedUploadActionsBatchStatus" expires_after="2021-12-01"> + enum="FeedUploadActionsBatchStatus" expires_after="2022-04-03"> <owner>iwells@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1286,7 +1318,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.UploadActionsStatus" - enum="FeedUploadActionsStatus" expires_after="2022-01-30"> + enum="FeedUploadActionsStatus" expires_after="2022-04-03"> <owner>iwells@chromium.org</owner> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1307,7 +1339,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.UserActions" enum="FeedUserActionType" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>harringtond@chromium.org</owner> <owner>carlosk@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1318,7 +1350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.UserActions.Commands" - enum="FeedUserCommandType" expires_after="2022-03-01"> + enum="FeedUserCommandType" expires_after="2022-05-01"> <owner>harringtond@chromium.org</owner> <owner>sczs@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1330,7 +1362,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.UserJourney.GetMore.FailureDuration" - units="ms" expires_after="2022-03-01"> + units="ms" expires_after="2022-05-01"> <owner>harringtond@chromium.org</owner> <owner>carlosk@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1341,7 +1373,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.UserJourney.GetMore.SuccessDuration" - units="ms" expires_after="2022-03-01"> + units="ms" expires_after="2022-05-01"> <owner>harringtond@chromium.org</owner> <owner>carlosk@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1406,7 +1438,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.VisitDuration" units="ms" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>harringtond@chromium.org</owner> <owner>freedjm@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -1492,7 +1524,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContentSuggestions.Feed.WebFeed.FollowByIdResult" - units="index" expires_after="2022-07-01"> + enum="WebFeedSubscriptionRequestStatus" expires_after="2022-07-01"> <owner>harringtond@chromium.org</owner> <owner>feed@chromium.org</owner> <summary> @@ -1516,10 +1548,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="ContentShown" summary="after the Following feed is shown, and some content is displayed."/> - <variant name="EngagedWithFeed" + <variant name="Engaged" summary="after the user has been recorded as FeedEngagementType 'Engaged', reported at most once per day when the user - interacts with the Following Feed."/> + interacts with either the For-You or Following Feeds."/> <variant name="NoContentShown" summary="after the Following Feed is shown, and no content is available for display."/> @@ -1537,6 +1569,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="ContentSuggestions.Feed.WebFeed.LoadedCardCount.{ContentOrder}" + units="index" expires_after="2022-07-01"> + <owner>harringtond@chromium.org</owner> + <owner>feed@chromium.org</owner> + <summary> + Android: Reports the total number of {ContentOrder} cards in the Following + feed when data is successfully loaded to be presented to the user. Reported + after an initial load. Only one of 'Grouped' or 'ReverseChron' is reported + for each stream load. + </summary> + <token key="ContentOrder"> + <variant name="Grouped" summary="Grouped"/> + <variant name="ReverseChron" summary="ReverseChron"/> + </token> +</histogram> + +<histogram name="ContentSuggestions.Feed.WebFeed.NewFollow.IsRecommended" + enum="Boolean" expires_after="2022-09-01"> + <owner>harringtond@chromium.org</owner> + <owner>feed@chromium.org</owner> + <summary> + Whether the followed web feed was recommended by the server. + + Reported upon successfully following a web feed. Reported as 'true' if the + web feed was recommended, even if the user did not see or interact with + recommendation UI. + </summary> +</histogram> + <histogram name="ContentSuggestions.Feed.WebFeed.Opened" units="index" expires_after="never"> <!-- expires-never: key feature metric. We will need the Opened @@ -1566,6 +1628,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ContentSuggestions.Feed.WebFeed.RefreshContentOrder" + enum="FeedContentOrder" expires_after="2022-09-01"> + <owner>harringtond@chromium.org</owner> + <owner>feed@chromium.org</owner> + <summary> + The content order requested when refreshing content on the Following feed. + Reported before sending a refresh request to the server. Not reported for + NextPage requests. + </summary> +</histogram> + <histogram name="ContentSuggestions.Feed.WebFeed.RefreshRecommendedFeeds" enum="WebFeedRefreshStatus" expires_after="2022-07-01"> <owner>harringtond@chromium.org</owner> @@ -1848,6 +1921,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. Android: status of pulling-to-refresh the {FeedType} stream per the user request. Reported when the refresh completes. </summary> + <token key="FeedType"> + <variant name="Feed" summary="For-You Feed"/> + <variant name="Feed.WebFeed" summary="Web Feed"/> + </token> </histogram> <histogram name="ContentSuggestions.{FeedType}.ReachedEndOfFeed" units="index" diff --git a/chromium/tools/metrics/histograms/metadata/content_creation/histograms.xml b/chromium/tools/metrics/histograms/metadata/content_creation/histograms.xml index e5ebcc296e0..090236a94c4 100644 --- a/chromium/tools/metrics/histograms/metadata/content_creation/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/content_creation/histograms.xml @@ -25,7 +25,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="NoteCreation.CreationStatus" enum="BooleanCreated" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>sebsg@chromium.org</owner> <owner>chrome-creation@google.com</owner> <summary> @@ -35,7 +35,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NoteCreation.Funnel" enum="NoteCreationFunnel" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>sebsg@chromium.org</owner> <owner>chrome-creation@google.com</owner> <summary> @@ -45,14 +45,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NoteCreation.NoteShared" enum="BooleanShared" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>sebsg@chromium.org</owner> <owner>chrome-creation@google.com</owner> <summary>Records whether the created note was shared or not.</summary> </histogram> <histogram name="NoteCreation.NumberOfTemplateChanges" - units="Number of changes" expires_after="2021-12-01"> + units="Number of changes" expires_after="2022-04-10"> <owner>sebsg@chromium.org</owner> <owner>chrome-creation@google.com</owner> <summary> @@ -61,7 +61,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NoteCreation.SelectedTemplate" enum="NoteTemplate" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>sebsg@chromium.org</owner> <owner>chrome-creation@google.com</owner> <summary> @@ -70,7 +70,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NoteCreation.ShareDestination" enum="NoteShareDestination" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>sebsg@chromium.org</owner> <owner>chrome-creation@google.com</owner> <summary> @@ -101,7 +101,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.AndroidShareSheet.SharedState" - enum="LinkGenerationSharedStatus" expires_after="2021-11-12"> + enum="LinkGenerationSharedStatus" expires_after="2022-04-03"> <owner>sebsg@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -111,7 +111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.AsyncTask.Iterations" units="iterations" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -122,7 +122,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.AsyncTask.SearchDuration" units="ms" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -133,7 +133,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.Desktop.CopiedLinkType" - enum="LinkGenerationCopiedLinkType" expires_after="2021-11-12"> + enum="LinkGenerationCopiedLinkType" expires_after="2022-04-03"> <owner>sebsg@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -142,7 +142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.Error" - enum="LinkGenerationError" expires_after="2021-12-31"> + enum="LinkGenerationError" expires_after="2022-04-03"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -153,7 +153,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.Error.Iterations" - units="iterations" expires_after="2021-12-31"> + units="iterations" expires_after="2022-05-01"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -163,7 +163,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.Error.Requested" - enum="LinkGenerationError" expires_after="2021-12-31"> + enum="LinkGenerationError" expires_after="2022-04-10"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -173,7 +173,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.Error.TimeToGenerate" - units="ms" expires_after="2021-12-31"> + units="ms" expires_after="2022-04-10"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -183,7 +183,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.Iterations" units="iterations" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -193,7 +193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.ParamLength" units="characters" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -205,7 +205,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.SelectionLength" - units="characters" expires_after="2021-12-31"> + units="characters" expires_after="2022-04-24"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -215,7 +215,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.SelectorParameters" - enum="TextFragmentAnchorParameters" expires_after="2021-12-31"> + enum="TextFragmentAnchorParameters" expires_after="2022-04-17"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -225,7 +225,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.StateAtRequest" - enum="LinkGenerationState" expires_after="2021-11-12"> + enum="LinkGenerationState" expires_after="2022-04-10"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -235,7 +235,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated.TimeToGenerate" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -245,7 +245,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkGenerated{Requested}" - units="BooleanSuccess" expires_after="2021-12-31"> + units="BooleanSuccess" expires_after="2021-12-01"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -262,7 +262,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SharedHighlights.LinkToTextDiagnoseStatus" - enum="LinkToTextDiagnoseStatus" expires_after="2021-11-12"> + enum="LinkToTextDiagnoseStatus" expires_after="2022-04-17"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/cookie/histograms.xml b/chromium/tools/metrics/histograms/metadata/cookie/histograms.xml index 2d303bf2b73..a7ec9a2f06d 100644 --- a/chromium/tools/metrics/histograms/metadata/cookie/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/cookie/histograms.xml @@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.CookiePrefix" enum="CookiePrefix" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>estark@chromium.org</owner> <summary> Number of times a cookie was set with a name prefixed by @@ -90,7 +90,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.CookieSchemeRequestScheme" enum="CookieRequestScheme" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -101,7 +101,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.CookieSourceScheme" enum="CookieSourceScheme" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>estark@chromium.org</owner> <summary> For each cookie added to the store, record whether its source URL has a @@ -110,7 +110,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.CookieSourceSchemeName" enum="CookieSourceSchemeName" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -160,7 +160,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cookie.Count2" units="units" expires_after="2022-02-06"> +<histogram name="Cookie.Count2" units="units" expires_after="2022-04-10"> <owner>bingler@chromium.org</owner> <owner>morlovich@chromium.org</owner> <summary> @@ -191,7 +191,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> -<histogram name="Cookie.DomainSet" enum="Boolean" expires_after="2022-01-23"> +<histogram name="Cookie.DomainSet" enum="Boolean" expires_after="2022-04-17"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -212,7 +212,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.ExpirationDurationMinutesNonSecure" units="minutes" - expires_after="2021-10-31"> + expires_after="2022-04-17"> <owner>kaustubhag@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary>Number of minutes until non-Secure cookie expires when set.</summary> @@ -247,6 +247,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Cookie.FromStorageWithValidLength" enum="BooleanValid" + expires_after="2022-03-11"> + <owner>bingler@chromium.org</owner> + <owner>awillia@chromium.org</owner> + <summary> + If a canonical cookie has a valid name+value length. Logged whenever a + cookie is created FromStorage and if this cookie IsCanonical. + </summary> +</histogram> + <histogram name="Cookie.HeaderLength" units="bytes" expires_after="2020-09-13"> <owner>mkwst@chromium.org</owner> <summary> @@ -255,7 +265,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.IncludedRequestEffectiveSameSite" - enum="CookieEffectiveSameSite" expires_after="2021-10-25"> + enum="CookieEffectiveSameSite" expires_after="2022-04-24"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -265,7 +275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.IncludedResponseEffectiveSameSite" - enum="CookieEffectiveSameSite" expires_after="2021-10-25"> + enum="CookieEffectiveSameSite" expires_after="2022-04-24"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -287,7 +297,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.IsSamePartyValid" enum="BooleanValid" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>cfredric@chromium.org</owner> <owner>kaustubhag@chromium.org</owner> <summary> @@ -326,7 +336,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.LoadProblem" enum="CookieLoadProblem" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>morlovich@chromium.org</owner> <summary> Recorded when a problem is recorded when loading the persistent cookie @@ -348,7 +358,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.NumDomainPurgedKeys" units="keys" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>cfredric@chromium.org</owner> <owner>kaustubhag@chromium.org</owner> <summary> @@ -361,7 +371,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cookie.NumKeys" units="keys" expires_after="2021-12-05"> +<histogram name="Cookie.NumKeys" units="keys" expires_after="2022-04-17"> <owner>cfredric@chromium.org</owner> <owner>kaustubhag@chromium.org</owner> <summary> @@ -372,7 +382,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.PerFirstPartySetCount" units="cookies" - expires_after="2022-01-05"> + expires_after="2022-04-17"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -383,7 +393,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.Port.OmniboxURLNavigation.Localhost" - enum="InterestingCookiePorts" expires_after="2022-01-09"> + enum="InterestingCookiePorts" expires_after="2022-05-01"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -404,7 +414,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.Port.OmniboxURLNavigation.RemoteHost" - enum="InterestingCookiePorts" expires_after="2022-01-09"> + enum="InterestingCookiePorts" expires_after="2022-05-01"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -521,7 +531,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.RequestSameSiteContext" enum="SameSiteCookieContext" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>bingler@chromium.org</owner> <owner>morlovich@chromium.org</owner> <summary> @@ -547,7 +557,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SameParty.ReadExclusionDecidedBySameParty" - enum="Boolean" expires_after="2022-01-06"> + enum="Boolean" expires_after="2022-03-13"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -557,7 +567,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SameParty.SetExclusionDecidedBySameParty" - enum="Boolean" expires_after="2022-01-06"> + enum="Boolean" expires_after="2022-03-13"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -567,7 +577,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SamePartyCookieSameSiteAttributeValue" - enum="CookieSameSiteString" expires_after="2022-01-02"> + enum="CookieSameSiteString" expires_after="2022-04-03"> <owner>cfredric@chromium.org</owner> <owner>kaustubhag@chromium.org</owner> <summary> @@ -578,7 +588,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SamePartyReadIncluded.InclusionUnderSameSite" - enum="BooleanIncluded" expires_after="2022-01-05"> + enum="BooleanIncluded" expires_after="2022-04-03"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -589,7 +599,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SamePartyReadIncluded.IsHTTP" enum="BooleanHTTPVsJS" - expires_after="2022-01-05"> + expires_after="2022-04-10"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -599,7 +609,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SamePartyReadIncluded.PartyContextSize" - units="registrable domains" expires_after="2022-01-05"> + units="registrable domains" expires_after="2022-04-03"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -615,7 +625,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SamePartySetIncluded.InclusionUnderSameSite" - enum="BooleanIncluded" expires_after="2022-01-05"> + enum="BooleanIncluded" expires_after="2022-04-10"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -626,7 +636,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SamePartySetIncluded.IsHTTP" enum="BooleanHTTPVsJS" - expires_after="2022-01-05"> + expires_after="2022-04-10"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -636,7 +646,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SamePartySetIncluded.PartyContextSize" - units="registrable domains" expires_after="2022-01-05"> + units="registrable domains" expires_after="2022-04-03"> <owner>cfredric@chromium.org</owner> <owner>bingler@chromium.org</owner> <summary> @@ -652,7 +662,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.SameSiteAttributeValue" enum="CookieSameSiteString" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>bingler@chromium.org</owner> <owner>miketaylr@chromium.org</owner> <summary> @@ -801,7 +811,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cookie.TimeBlockedOnLoad" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>nharper@chromium.org</owner> <summary> The amount of time (ms) between the cookie store load starting and @@ -880,6 +890,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Cookie.TimeDatabaseMigrationToV16" units="ms" + expires_after="2022-02-01"> + <owner>dylancutler@chromium.org</owner> + <owner>kaustubhag@chromium.org</owner> + <summary> + The amount of time (ms) to migrate a v15 cookie database to v16. Migration + occurs upon first startup of a browser version with v15 database code. + </summary> +</histogram> + <histogram name="Cookie.TimeDatabaseMigrationToV9" units="ms" expires_after="2018-08-30"> <owner>erikchen@chromium.org</owner> @@ -927,7 +947,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cookie.Type" enum="CookieType" expires_after="2021-12-19"> +<histogram name="Cookie.TruncatingCharacterInCookieString" + enum="TruncatingCharacterInCookieStringType" expires_after="2022-03-31"> + <owner>bingler@chromium.org</owner> + <owner>awillia@chromium.org</owner> + <summary> + Measures which character caused the cookie string to be truncated. Logged + whenever a cookie is created via CanonicalCookie::Create(). + </summary> +</histogram> + +<histogram name="Cookie.Type" enum="CookieType" expires_after="2022-04-24"> <owner>mkwst@chromium.org</owner> <summary>For each cookie added to the store, record it's type(s).</summary> </histogram> diff --git a/chromium/tools/metrics/histograms/metadata/cras/histograms.xml b/chromium/tools/metrics/histograms/metadata/cras/histograms.xml index 7a5e59f4470..087136b5931 100644 --- a/chromium/tools/metrics/histograms/metadata/cras/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/cras/histograms.xml @@ -21,7 +21,29 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> -<histogram name="Cras.Busyloop" units="units" expires_after="2021-12-01"> +<histogram name="Cras.A2dp100msFailureOverStream" units="units" + expires_after="2022-04-17"> + <owner>hychao@chromium.org</owner> + <owner>chromeos-audio@google.com</owner> + <summary> + For each of bluetooth A2DP stream period, track the sum of all period + lengths of consecutive packet write failures observerd by CRAS that is + longer than 100ms. + </summary> +</histogram> + +<histogram name="Cras.A2dp20msFailureOverStream" units="units" + expires_after="2022-04-10"> + <owner>hychao@chromium.org</owner> + <owner>chromeos-audio@google.com</owner> + <summary> + For each of bluetooth A2DP stream period, track the sum of all period + lengths of consecutive packet write failures observerd by CRAS that is + longer than 20ms. + </summary> +</histogram> + +<histogram name="Cras.Busyloop" units="units" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Cras.TimePeriod" --> @@ -46,7 +68,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cras.DeviceGain" units="level" expires_after="2021-12-01"> +<histogram name="Cras.DeviceGain" units="level" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Cras.DeviceType" --> @@ -73,7 +95,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.DeviceTypeInput" enum="CrasDeviceType" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -84,7 +106,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.DeviceTypeOutput" enum="CrasDeviceType" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -94,7 +116,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cras.DeviceVolume" units="level" expires_after="2022-01-30"> +<histogram name="Cras.DeviceVolume" units="level" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="Cras.DeviceType" --> @@ -106,7 +128,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.FetchDelayMilliSeconds" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Cras.ClientType" and name="Cras.StreamType" --> @@ -153,7 +175,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.HfpWidebandSpeechPacketLoss" units="units" - expires_after="2022-01-30"> + expires_after="2022-04-17"> <owner>enshuo@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -164,7 +186,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.HfpWidebandSpeechSupported" units="BooleanSupported" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>hychao@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -200,7 +222,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.HighestInputHardwareLevel" units="frames" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -244,7 +266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.InputDeviceBluetoothNarrowBandMicRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>hychao@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -267,7 +289,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.InputDeviceBluetoothWideBandMicRuntime" units="seconds" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>hychao@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -300,7 +322,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.InputDeviceHotwordRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-05-01"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -344,7 +366,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.InputDeviceMicRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -421,7 +443,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.InputDeviceUSBRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -459,7 +481,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackFirstTimeInput" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -473,7 +495,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackFirstTimeOutput" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -487,7 +509,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackFrequencyAfterReschedulingInput" - units="count" expires_after="2021-12-01"> + units="count" expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -498,7 +520,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackFrequencyAfterReschedulingOutput" - units="count" expires_after="2021-12-01"> + units="count" expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -510,7 +532,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackFrequencyInput" units="count" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -521,7 +543,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackFrequencyOutput" units="count" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -532,7 +554,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackSecondTimeInput" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -543,7 +565,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.MissedCallbackSecondTimeOutput" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -554,7 +576,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.OutputDeviceA2DPRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -599,7 +621,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.OutputDeviceHDMIRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -610,7 +632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.OutputDeviceHeadphoneRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -621,7 +643,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.OutputDeviceHFPRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -643,7 +665,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.OutputDeviceInternalSpeakerRuntime" units="seconds" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -654,7 +676,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.OutputDeviceLineoutRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -687,7 +709,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.OutputDeviceUSBRuntime" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -715,7 +737,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.RtcDevicePair" enum="CrasDevicePair" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -788,7 +810,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.StreamCallbackThreshold" units="frames" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="Cras.Direction" and name="Cras.ClientType" --> @@ -803,7 +825,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.StreamClientTypeInput" enum="CrasClientType" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -813,7 +835,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.StreamClientTypeOutput" enum="CrasClientType" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -822,7 +844,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cras.StreamEffects" units="value" expires_after="2021-12-01"> +<histogram name="Cras.StreamEffects" units="value" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="Cras.Direction" and name="Cras.ClientType" --> @@ -835,7 +857,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cras.StreamFlags" units="value" expires_after="2021-12-01"> +<histogram name="Cras.StreamFlags" units="value" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Cras.Direction" and name="Cras.ClientType" --> @@ -848,7 +870,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Cras.StreamRuntime" units="seconds" expires_after="2021-12-01"> +<histogram name="Cras.StreamRuntime" units="seconds" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Cras.Direction" and name="Cras.ClientType" and @@ -864,7 +886,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.StreamSamplingFormat" enum="AlsaSampleFormatType" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Cras.Direction" and name="Cras.ClientType" --> @@ -878,7 +900,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.StreamSamplingRate" units="bps" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Cras.Direction" and name="Cras.ClientType" --> @@ -910,7 +932,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.UnderrunsPerDevice" units="count" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>yuhsuan@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -921,7 +943,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.WebRTC.Audio.ApmCaptureInputLevelAverageRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-04-24"> <owner>hychao@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -935,7 +957,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.WebRTC.Audio.ApmCaptureInputLevelPeakRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-04-24"> <owner>hychao@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -949,7 +971,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.WebRTC.Audio.ApmCaptureOutputLevelAverageRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-05-01"> <owner>hychao@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> @@ -962,7 +984,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cras.WebRTC.Audio.ApmCaptureOutputLevelPeakRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-05-01"> <owner>hychao@chromium.org</owner> <owner>chromeos-audio@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/cros/histograms.xml b/chromium/tools/metrics/histograms/metadata/cros/histograms.xml index 8f76f9dc273..eb3db9deb28 100644 --- a/chromium/tools/metrics/histograms/metadata/cros/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/cros/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Cros.CrOSActionRecorderEvent" enum="CrOSActionRecorderEvent" - expires_after="2022-01-30"> + expires_after="2022-05-01"> <owner>charleszhao@chromium.org</owner> <owner>tby@chromium.org</owner> <summary> @@ -34,7 +34,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisks.ArchiveType" enum="CrosDisksArchiveType" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>fdegros@chromium.org</owner> <owner>chromeos-files-app@google.com</owner> <summary> @@ -44,7 +44,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisks.DeviceMediaType" enum="CrosDisksDeviceMediaType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>fdegros@chromium.org</owner> <owner>chromeos-files-app@google.com</owner> <summary> @@ -54,7 +54,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisks.FilesystemType" enum="CrosDisksFilesystemType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>fdegros@chromium.org</owner> <owner>chromeos-files-app@google.com</owner> <summary> @@ -64,7 +64,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisks.Fuse.Archivemount" enum="ArchivemountError" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>fdegros@chromium.org</owner> <owner>chromeos-files-app@google.com</owner> <summary> @@ -74,7 +74,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisks.Fuse.FuseZip" enum="FuseZipError" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>fdegros@chromium.org</owner> <owner>chromeos-files-app@google.com</owner> <summary> @@ -84,7 +84,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisks.Fuse.Rar2fs" enum="Rar2fsError" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>fdegros@chromium.org</owner> <owner>chromeos-files-app@google.com</owner> <summary> @@ -94,7 +94,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisksClient.FormatCompletedError" - enum="CrosDisksClientFormatError" expires_after="2022-01-16"> + enum="CrosDisksClientFormatError" expires_after="2022-03-20"> <owner>austinct@chromium.org</owner> <summary> The error code of disk format signals received from the Chrome OS cros-disks @@ -103,7 +103,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisksClient.FormatTime" units="ms" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>austinct@chromium.org</owner> <summary> Time taken for the Chrome OS cros-disks daemon to perform a format @@ -122,7 +122,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CrosDisksClient.MountErrorMountType" - enum="CrosDisksMountTypeError" expires_after="2021-12-19"> + enum="CrosDisksMountTypeError" expires_after="2022-04-03"> <owner>dats@chromium.org</owner> <owner>fdegros@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/cross_device/histograms.xml b/chromium/tools/metrics/histograms/metadata/cross_device/histograms.xml index 1aaf1dbc9a0..0aabf904c05 100644 --- a/chromium/tools/metrics/histograms/metadata/cross_device/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/cross_device/histograms.xml @@ -57,7 +57,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AndroidSms.FcmMessageDispatchSuccess" - enum="AndroidSmsFcmMessageType" expires_after="2022-02-02"> + enum="AndroidSmsFcmMessageType" expires_after="2022-04-17"> <owner>azeemarshad@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -68,7 +68,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AndroidSms.MultiDeviceFeatureState" - enum="MultiDevice_FeatureState" expires_after="2022-02-02"> + enum="MultiDevice_FeatureState" expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -132,7 +132,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.ClientAppMetadata.IsManufacturerEmpty" - enum="BooleanEmpty" expires_after="2021-10-06"> + enum="BooleanEmpty" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -143,7 +143,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.ClientAppMetadata.IsModelEmpty" enum="BooleanEmpty" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -153,7 +153,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.ClientAppMetadataInstanceIdTokenFetch.Result" - enum="InstanceIDResult" expires_after="2021-12-05"> + enum="InstanceIDResult" expires_after="2022-08-23"> <owner>khorimoto@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -163,7 +163,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.ClientAppMetadataInstanceIdTokenFetch.Retries" - units="retries" expires_after="2021-12-05"> + units="retries" expires_after="2022-08-23"> <owner>khorimoto@chromium.org</owner> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> @@ -175,7 +175,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSync.Result" enum="BooleanSuccess" - expires_after="2022-02-06"> + expires_after="2022-08-23"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary>Indicates success of performing a DeviceSync.</summary> @@ -183,7 +183,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncService.ClientAppMetadataFetch.AsyncTaskResult" - enum="CryptAuthAsyncTaskResult" expires_after="2021-10-06"> + enum="CryptAuthAsyncTaskResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -195,7 +195,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncService.ClientAppMetadataFetch.ExecutionTime" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -206,7 +206,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncService.GcmRegistration.ExecutionTime" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -217,7 +217,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncService.GcmRegistration.Success" - enum="BooleanSuccess" expires_after="2021-10-06"> + enum="BooleanSuccess" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -227,7 +227,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncService.Initialization.ExecutionTime" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -238,7 +238,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncSoftwareFeaturesResult" - enum="BooleanSuccess" expires_after="2022-01-02"> + enum="BooleanSuccess" expires_after="2022-08-23"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -251,7 +251,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncSoftwareFeaturesResult.Failures" - enum="CryptAuthSoftwareFeature" expires_after="2021-10-06"> + enum="CryptAuthSoftwareFeature" expires_after="2022-08-23"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -263,7 +263,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceActivityGetter.ApiCallResult.GetDevicesActivityStatus" - enum="CryptAuthApiCallResult" expires_after="2022-02-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -275,7 +275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceActivityGetter.ExecutionTime.GetDevicesActivityStatus" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -287,7 +287,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceNotifier.ApiCallResult.NotifyGroupDevices" - enum="CryptAuthApiCallResult" expires_after="2021-12-19"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -299,7 +299,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceNotifier.ExecutionTime.NotifyGroupDevices" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -311,7 +311,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.AsyncTaskResult.DeviceMetadataDecryption" - enum="CryptAuthAsyncTaskResult" expires_after="2022-02-06"> + enum="CryptAuthAsyncTaskResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -326,7 +326,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.AsyncTaskResult.GroupPrivateKeyDecryption" - enum="CryptAuthAsyncTaskResult" expires_after="2022-02-06"> + enum="CryptAuthAsyncTaskResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -338,7 +338,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.ExecutionTime.DeviceMetadataDecryption" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -350,7 +350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.ExecutionTime.GroupPrivateKeyDecryption" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -362,7 +362,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.IsGroupPrivateKeyConsistent" - enum="BooleanConsistent" expires_after="2021-10-06"> + enum="BooleanConsistent" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -374,7 +374,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.IsLocalDeviceMetadataConsistent" - enum="BooleanConsistent" expires_after="2022-02-06"> + enum="BooleanConsistent" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -385,7 +385,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.MetadataDecryptionSuccess" - enum="BooleanSuccess" expires_after="2022-02-06"> + enum="BooleanSuccess" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -396,7 +396,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.DeviceSyncer.MetadataParsingSuccess" - enum="BooleanSuccess" expires_after="2022-02-06"> + enum="BooleanSuccess" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -409,7 +409,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusGetter.ApiCallResult.GetFeatureStatuses" - enum="CryptAuthApiCallResult" expires_after="2022-02-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -421,7 +421,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusGetter.CorrectNumberOfDevicesInResponse" - enum="BooleanExpected" expires_after="2022-02-06"> + enum="BooleanExpected" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -433,7 +433,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusGetter.ExecutionTime.GetFeatureStatuses" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -445,7 +445,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusGetter.IsDuplicateDeviceId" - enum="BooleanDuplicate" expires_after="2022-02-06"> + enum="BooleanDuplicate" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -457,7 +457,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusGetter.IsKnownFeatureType" - enum="BooleanKnown" expires_after="2022-02-06"> + enum="BooleanKnown" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -471,7 +471,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusGetter.IsUnsupportedFeatureMarkedEnabled" - enum="Boolean" expires_after="2022-02-06"> + enum="Boolean" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -484,7 +484,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusGetter.WasDeviceInResponseRequested" - enum="BooleanRequested" expires_after="2022-02-06"> + enum="BooleanRequested" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -496,7 +496,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusSetter.ApiCallResult.SetFeatureStatuses" - enum="CryptAuthApiCallResult" expires_after="2022-02-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -508,7 +508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.FeatureStatusSetter.ExecutionTime.SetFeatureStatuses" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -520,7 +520,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.GroupPrivateKeySharer.ApiCallResult.ShareGroupPrivateKey" - enum="CryptAuthApiCallResult" expires_after="2022-02-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -532,7 +532,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.GroupPrivateKeySharer.AsyncTaskResult.GroupPrivateKeyEncryption" - enum="CryptAuthAsyncTaskResult" expires_after="2021-12-05"> + enum="CryptAuthAsyncTaskResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -547,7 +547,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.GroupPrivateKeySharer.EncryptionSuccess" - enum="BooleanSuccess" expires_after="2022-02-06"> + enum="BooleanSuccess" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -560,7 +560,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.GroupPrivateKeySharer.ExecutionTime.GroupPrivateKeyEncryption" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -572,7 +572,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.GroupPrivateKeySharer.ExecutionTime.ShareGroupPrivateKey" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -584,7 +584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.GroupPrivateKeySharer.IsEncryptingKeyEmpty" - enum="Boolean" expires_after="2022-02-06"> + enum="Boolean" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -597,7 +597,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.InvocationReason" - enum="CryptAuthV2InvocationReason" expires_after="2022-02-06"> + enum="CryptAuthV2InvocationReason" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -608,7 +608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.ApiCallResult.FirstSyncMetadata" - enum="CryptAuthApiCallResult" expires_after="2022-02-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -620,7 +620,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.ApiCallResult.SecondSyncMetadata" - enum="CryptAuthApiCallResult" expires_after="2022-02-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -632,7 +632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.AsyncTaskResult.GroupKeyCreation" - enum="CryptAuthAsyncTaskResult" expires_after="2022-02-06"> + enum="CryptAuthAsyncTaskResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -644,7 +644,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.AsyncTaskResult.LocalDeviceMetadataEncryption" - enum="CryptAuthAsyncTaskResult" expires_after="2022-02-06"> + enum="CryptAuthAsyncTaskResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -656,7 +656,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.ExecutionTime.FirstSyncMetadata" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -668,7 +668,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.ExecutionTime.GroupKeyCreation" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -680,7 +680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.ExecutionTime.LocalDeviceMetadataEncryption" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -692,7 +692,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.ExecutionTime.SecondSyncMetadata" - units="ms" expires_after="2021-10-06"> + units="ms" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -704,7 +704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.IsDeviceMetadataPacketValid" - enum="Boolean" expires_after="2022-02-06"> + enum="Boolean" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -715,7 +715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.MetadataSyncer.IsDuplicateDeviceId" - enum="Boolean" expires_after="2022-02-06"> + enum="Boolean" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -727,7 +727,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.RemoteDeviceProvider.NumV1Devices" - units="count" expires_after="2021-12-05"> + units="count" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -739,7 +739,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.RemoteDeviceProvider.NumV2Devices" - units="count" expires_after="2021-12-05"> + units="count" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -752,7 +752,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.RemoteDeviceProvider.PercentageOfV1DevicesReplacedByV2Devices" - units="%" expires_after="2021-12-05"> + units="%" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -767,7 +767,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.RemoteDeviceProvider.PercentageOfV2DevicesWithDecryptedPublicKey" - units="%" expires_after="2021-10-06"> + units="%" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -781,7 +781,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.DeviceSyncV2.RemoteDeviceProvider.RatioOfV2ToV1Devices" - units="%" expires_after="2021-12-05"> + units="%" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -798,7 +798,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.Result.DidDeviceRegistryChange" - enum="BooleanChanged" expires_after="2021-10-06"> + enum="BooleanChanged" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -809,7 +809,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.Result.ResultCode" - enum="CryptAuthV2DeviceSyncResultCode" expires_after="2022-02-06"> + enum="CryptAuthV2DeviceSyncResultCode" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -819,7 +819,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.DeviceSyncV2.Result.ResultType" - enum="CryptAuthV2DeviceSyncResultType" expires_after="2022-02-06"> + enum="CryptAuthV2DeviceSyncResultType" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -829,7 +829,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.Enrollment.Result" enum="BooleanSuccess" - expires_after="2022-01-16"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -838,7 +838,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.ApiCallResult.EnrollKeys" - enum="CryptAuthApiCallResult" expires_after="2021-10-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -849,7 +849,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.ApiCallResult.SyncKeys" - enum="CryptAuthApiCallResult" expires_after="2021-10-06"> + enum="CryptAuthApiCallResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -860,7 +860,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.AsyncTaskResult.KeyCreation" - enum="CryptAuthAsyncTaskResult" expires_after="2022-02-06"> + enum="CryptAuthAsyncTaskResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -871,7 +871,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.ExecutionTime.EnrollKeys" units="ms" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -882,7 +882,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.ExecutionTime.KeyCreation" units="ms" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -893,7 +893,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.ExecutionTime.SyncKeys" units="ms" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -904,7 +904,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.InvocationReason" - enum="CryptAuthV2InvocationReason" expires_after="2022-02-06"> + enum="CryptAuthV2InvocationReason" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -914,7 +914,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.Result.ResultCode" - enum="CryptAuthV2EnrollmentResult" expires_after="2022-02-06"> + enum="CryptAuthV2EnrollmentResult" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -924,7 +924,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.Result.Success" enum="BooleanSuccess" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -934,7 +934,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.EnrollmentV2.UserKeyPairState" - enum="CryptAuthV2EnrollmentUserKeyPairState" expires_after="2021-10-06"> + enum="CryptAuthV2EnrollmentUserKeyPairState" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -945,7 +945,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.Gcm.Message.FeatureType" enum="CryptAuthFeatureType" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -956,7 +956,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.Gcm.Message.IsDeviceSyncGroupNameValid" - enum="Boolean" expires_after="2021-10-06"> + enum="Boolean" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -968,7 +968,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.Gcm.Message.IsKnownFeatureType" enum="Boolean" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -980,7 +980,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.Gcm.Message.TargetService.AreTickleTypeAndTargetServiceBothSpecified" - enum="Boolean" expires_after="2021-10-06"> + enum="Boolean" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -994,7 +994,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="CryptAuth.Gcm.Message.TargetService.FromRegistrationTickleType" - enum="CryptAuthTargetService" expires_after="2021-10-06"> + enum="CryptAuthTargetService" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1006,7 +1006,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.Gcm.Message.TargetService.FromTargetServiceValue" - enum="CryptAuthTargetService" expires_after="2021-10-06"> + enum="CryptAuthTargetService" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1018,7 +1018,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.Gcm.Registration.AttemptTimeWithRetries" units="ms" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1034,7 +1034,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.Gcm.Registration.Result" enum="GCMClientResult" - expires_after="2021-10-06"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1050,7 +1050,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.GetLocalDeviceMetadata.HasId" enum="BooleanPresent" - expires_after="2022-02-02"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1062,7 +1062,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.GetLocalDeviceMetadata.IsReady" enum="BooleanReady" - expires_after="2022-02-02"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1075,7 +1075,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.GetLocalDeviceMetadata.Result" enum="BooleanSuccess" - expires_after="2022-02-02"> + expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1086,7 +1086,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.InstanceId.DidInstanceIdChange" - enum="BooleanChanged" expires_after="2022-02-06"> + enum="BooleanChanged" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1097,7 +1097,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CryptAuth.InstanceId.DidInstanceIdTokenChange" - enum="BooleanChanged" expires_after="2021-12-05"> + enum="BooleanChanged" expires_after="2022-08-23"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1108,7 +1108,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.AuthEvent.DidUserManuallyUnlockPhone" - enum="EasyUnlockDidUserManuallyUnlockPhone" expires_after="2022-02-02"> + enum="EasyUnlockDidUserManuallyUnlockPhone" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1120,7 +1120,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.AuthEvent.SignIn" enum="EasyUnlockAuthEvent" - expires_after="2022-02-02"> + expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1132,7 +1132,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.AuthEvent.SignIn.Duration" units="ms" - expires_after="2022-02-02"> + expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1142,7 +1142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.AuthEvent.Unlock" enum="EasyUnlockAuthEvent" - expires_after="2022-02-02"> + expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1154,7 +1154,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.AuthEvent.Unlock.Duration" units="ms" - expires_after="2022-02-02"> + expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1166,7 +1166,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.AuthProximity.RemoteDeviceModelHash" - enum="EasyUnlockDeviceModelHash" expires_after="2022-02-02"> + enum="EasyUnlockDeviceModelHash" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1179,7 +1179,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.AuthProximity.RollingRssi" units="dBm" - expires_after="2022-02-02"> + expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1199,7 +1199,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EasyUnlock.RemoteLockScreenState" - enum="EasyUnlockRemoteLockScreenState" expires_after="2022-02-02"> + enum="EasyUnlockRemoteLockScreenState" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1257,7 +1257,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.BluetoothDiscoverySessionStarted" - enum="BooleanSuccess" expires_after="2022-02-02"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1266,7 +1266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.BluetoothDiscoverySessionStopped" - enum="BooleanSuccess" expires_after="2022-02-02"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1276,7 +1276,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.ConnectionToHostResult.Failure" enum="InstantTethering_ConnectionToHostResult_Failure" - expires_after="2022-02-02"> + expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1295,7 +1295,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.ConnectionToHostResult.Failure.ClientConnection" enum="InstantTethering_ConnectionToHostResult_Failure_ClientConnection" - expires_after="2022-02-02"> + expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1315,7 +1315,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.ConnectionToHostResult.Failure.TetheringTimeout" enum="InstantTethering_ConnectionToHostResult_Failure_TetheringTimeout" - expires_after="2022-02-02"> + expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1347,7 +1347,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.ConnectionToHostResult.ProvisioningFailureRate" enum="InstantTethering_ConnectionToHostResult_ProvisioningFailureRate" - expires_after="2022-02-02"> + expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1367,7 +1367,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.ConnectionToHostResult.SuccessRate.Background" enum="InstantTethering_ConnectionToHostResult_SuccessRate" - expires_after="2022-02-02"> + expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1384,7 +1384,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.FeatureState" - enum="InstantTethering_FeatureState" expires_after="2022-02-02"> + enum="InstantTethering_FeatureState" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1400,7 +1400,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.HostScanBatchDuration" units="ms" - expires_after="2022-02-02"> + expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1434,7 +1434,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.HotspotUsageDuration" units="ms" - expires_after="2022-02-02"> + expires_after="2022-04-17"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1445,7 +1445,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.KeepAliveTickle.Result" enum="BooleanSuccess" - expires_after="2022-02-02"> + expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1455,7 +1455,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.MultiDeviceFeatureState" - enum="MultiDevice_FeatureState" expires_after="2022-02-02"> + enum="MultiDevice_FeatureState" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1467,7 +1467,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.NotificationInteractionType" enum="InstantTethering_NotificationInteractionType" - expires_after="2022-02-02"> + expires_after="2022-04-17"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1477,7 +1477,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.Performance.ConnectTetheringResponseDuration" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1487,7 +1487,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.Performance.ConnectToHostDuration.Background" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-04-17"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1498,7 +1498,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.Performance.ConnectToHotspotDuration" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1510,7 +1510,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.Performance.DisconnectTetheringRequestDuration" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1520,7 +1520,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.Performance.KeepAliveTickleResponseDuration" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1531,7 +1531,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="InstantTethering.Performance.TetherAvailabilityResponseDuration" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1541,7 +1541,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.SessionCompletionReason" - enum="InstantTethering_SessionCompletionReason" expires_after="2022-02-02"> + enum="InstantTethering_SessionCompletionReason" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1553,7 +1553,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.UserPreference.OnStartup" - enum="BooleanEnabled" expires_after="2022-02-02"> + enum="BooleanEnabled" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1564,7 +1564,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InstantTethering.UserPreference.OnToggle" - enum="BooleanEnabled" expires_after="2022-02-02"> + enum="BooleanEnabled" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1574,8 +1574,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="MultiDevice.BetterTogetherSuite.DoesMultiDeviceSetupClientExist" + enum="BooleanSuccess" expires_after="2022-02-13"> + <owner>julietlevesque@google.com</owner> + <owner>better-together-dev@google.com</owner> + <summary> + Indicates whether or not the MultiDeviceSetupClient exists when passed into + the MultideviceHandler constructor. We expect the client to always exist if + the MultiDevice suite is allowed by policy. Recorded twice after sign-in, + during the creation of the MultiDevice (a.k.a. Connected Devices) settings + page UI handler, and during the creation of the chrome:://settings page UI + handler. Only recorded if the MultiDevice suite is allowed by policy. + </summary> +</histogram> + <histogram name="MultiDevice.BetterTogetherSuite.MultiDeviceFeatureState" - enum="MultiDevice_FeatureState" expires_after="2021-12-12"> + enum="MultiDevice_FeatureState" expires_after="2022-04-17"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1586,7 +1601,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.DeviceSyncService.FindEligibleDevices.Result" - enum="BooleanSuccess" expires_after="2021-12-12"> + enum="BooleanSuccess" expires_after="2022-02-13"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Result of trying to find eligible devices.</summary> @@ -1614,7 +1629,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.DeviceSyncService.ForceSyncNow.Result" enum="MultiDevice_DeviceSyncService_ForceCryptAuthOperationResult" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Result for when ForceSyncNow is called.</summary> @@ -1639,7 +1654,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.DeviceSyncService.SetSoftwareFeatureState.Result" - enum="BooleanSuccess" expires_after="2022-01-16"> + enum="BooleanSuccess" expires_after="2022-03-20"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary>Result of enabling and disabling features for devices.</summary> @@ -1659,7 +1674,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.ForgetHostConfirmed" enum="MultiDevice_VerifyAndForgetHostConfirmationState" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1668,7 +1683,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.PostOOBESetupFlow.PageShown" - enum="MultiDevice_PostOOBESetupFlow_Page" expires_after="2021-12-12"> + enum="MultiDevice_PostOOBESetupFlow_Page" expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1685,7 +1700,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.GattConnectionToAuthentication.EffectiveSuccessRateWithRetries" - enum="BooleanSuccess" expires_after="2021-12-12"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1698,7 +1713,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.Performance.ConnectionToAuthenticationDuration.Background" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-04-17"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1714,7 +1729,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.Performance.ReceiveAdvertisementToConnectionDuration.Background" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1730,7 +1745,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.Performance.StartScanToAuthenticationDuration.Background" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-17"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1747,7 +1762,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.Performance.StartScanToConnectionDuration.Background" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1763,7 +1778,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.Performance.StartScanToReceiveAdvertisementDuration.Background" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-17"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1779,7 +1794,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.ReceiveAdvertisementToAuthentication.EffectiveSuccessRateWithRetries" - enum="BooleanSuccess" expires_after="2021-12-19"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1791,7 +1806,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.SecureChannel.BLE.ReceiveAdvertisementToGattConnection.EffectiveSuccessRateWithRetries" - enum="BooleanSuccess" expires_after="2021-12-12"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1802,7 +1817,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.SecureChannel.Nearby.ConnectionMedium" - enum="SecureChannelNearbyConnectionMedium" expires_after="2022-01-30"> + enum="SecureChannelNearbyConnectionMedium" expires_after="2022-04-03"> <owner>khorimoto@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1828,7 +1843,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.SecureChannel.Nearby.DisconnectionReason" - enum="MultiDeviceNearbyDisconnectionReason" expires_after="2022-01-01"> + enum="MultiDeviceNearbyDisconnectionReason" expires_after="2022-05-01"> <owner>khorimoto@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1843,7 +1858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.SecureChannel.Nearby.EffectiveConnectionResult" - enum="BooleanSuccess" expires_after="2022-01-30"> + enum="BooleanSuccess" expires_after="2022-04-03"> <owner>khorimoto@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1859,7 +1874,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.SecureChannel.Nearby.MessageAction" - enum="MultiDeviceNearbyMessageAction" expires_after="2021-11-30"> + enum="MultiDeviceNearbyMessageAction" expires_after="2022-05-01"> <owner>khorimoto@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1891,7 +1906,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.SecureChannel.Nearby.SendMessageResult" - enum="BooleanSuccess" expires_after="2022-01-30"> + enum="BooleanSuccess" expires_after="2022-04-03"> <owner>khorimoto@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1916,7 +1931,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.Setup.HasDuplicateEligibleHostDeviceNames" - enum="BooleanDuplicate" expires_after="2021-12-26"> + enum="BooleanDuplicate" expires_after="2022-04-03"> <owner>nohle@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1928,7 +1943,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.Setup.HostStatus" - enum="MultiDevice_Setup_HostStatus" expires_after="2021-12-12"> + enum="MultiDevice_Setup_HostStatus" expires_after="2022-04-17"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1939,7 +1954,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDevice.Setup.HostVerifier.DoesHostHaveCryptoData" - enum="Boolean" expires_after="2021-12-12"> + enum="Boolean" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1954,7 +1969,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MultiDevice.VerifyButtonClicked" enum="MultiDevice_VerifyAndForgetHostConfirmationState" - expires_after="2021-12-12"> + expires_after="2022-02-20"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1963,7 +1978,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDeviceSetup.OOBE.UserChoice" - enum="MultiDeviceSetupOOBEUserChoice" expires_after="2021-12-19"> + enum="MultiDeviceSetupOOBEUserChoice" expires_after="2022-04-24"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <owner>hsuregan@chromium.org</owner> @@ -1974,7 +1989,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDeviceSetup_NotificationClicked" - enum="MultiDeviceSetupNotification" expires_after="2021-12-12"> + enum="MultiDeviceSetupNotification" expires_after="2022-02-20"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -1984,7 +1999,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiDeviceSetup_NotificationDismissed" - enum="MultiDeviceSetupNotification" expires_after="2021-12-12"> + enum="MultiDeviceSetupNotification" expires_after="2022-02-20"> <owner>danlee@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2058,14 +2073,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.AuthMethodChoice.SignIn" - enum="SmartLockAuthMethodChoice" expires_after="2022-02-01"> + enum="SmartLockAuthMethodChoice" expires_after="2022-04-17"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary>Records the user's sign in method choice.</summary> </histogram> <histogram name="SmartLock.AuthMethodChoice.SignIn.PasswordState" - enum="SmartLockAuthEventPasswordState" expires_after="2022-02-01"> + enum="SmartLockAuthEventPasswordState" expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2075,14 +2090,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.AuthMethodChoice.Unlock" - enum="SmartLockAuthMethodChoice" expires_after="2022-02-01"> + enum="SmartLockAuthMethodChoice" expires_after="2022-04-10"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary>Records the user's unlock method choice.</summary> </histogram> <histogram name="SmartLock.AuthMethodChoice.Unlock.PasswordState" - enum="SmartLockAuthEventPasswordState" expires_after="2022-02-01"> + enum="SmartLockAuthEventPasswordState" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2092,7 +2107,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.AuthResult" enum="BooleanSuccess" - expires_after="2022-02-01"> + expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2102,7 +2117,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.AuthResult.SignIn" enum="BooleanSuccess" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2112,7 +2127,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.AuthResult.SignIn.Failure" - enum="SmartLockAuthResultFailureReason" expires_after="2022-02-01"> + enum="SmartLockAuthResultFailureReason" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2132,7 +2147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.AuthResult.Unlock" enum="BooleanSuccess" - expires_after="2022-02-01"> + expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2142,7 +2157,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.AuthResult.Unlock.Failure" - enum="SmartLockAuthResultFailureReason" expires_after="2022-02-01"> + enum="SmartLockAuthResultFailureReason" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2164,7 +2179,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.EnabledDevicesCount" units="devices" - expires_after="2022-02-02"> + expires_after="2022-05-01"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2175,7 +2190,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.EnabledState" enum="SmartLockEnabledState" - expires_after="2022-02-02"> + expires_after="2022-04-17"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2198,7 +2213,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.FindAndConnectToHostResult.Unlock" - enum="SmartLockFindAndConnectToHostResult" expires_after="2022-02-02"> + enum="SmartLockFindAndConnectToHostResult" expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2208,7 +2223,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.GetRemoteStatus.SignIn" enum="BooleanSuccess" - expires_after="2022-02-02"> + expires_after="2022-04-10"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2219,7 +2234,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SmartLock.GetRemoteStatus.SignIn.Failure" enum="SmartLockGetRemoteStatusResultFailureReason" - expires_after="2022-02-02"> + expires_after="2022-04-10"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2229,7 +2244,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.GetRemoteStatus.Unlock" enum="BooleanSuccess" - expires_after="2022-02-02"> + expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2240,7 +2255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SmartLock.GetRemoteStatus.Unlock.Failure" enum="SmartLockGetRemoteStatusResultFailureReason" - expires_after="2022-02-02"> + expires_after="2022-04-03"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2250,7 +2265,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SmartLock.MultiDeviceFeatureState" - enum="MultiDevice_FeatureState" expires_after="2022-02-02"> + enum="MultiDevice_FeatureState" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>better-together-dev@google.com</owner> <summary> @@ -2262,7 +2277,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SmartLock.Performance.AuthenticationToReceiveFirstRemoteStatusDuration.Unlock" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="SmartLockStatusTypes" --> <owner>hansberry@chromium.org</owner> @@ -2285,7 +2300,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SmartLock.Performance.ShowLockScreenToShowFirstStatusToUserDuration.Unlock" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="SmartLockStatusTypes" --> <owner>hansberry@chromium.org</owner> @@ -2309,7 +2324,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SmartLock.Performance.StartScanToReceiveFirstRemoteStatusDuration.Unlock" - units="ms" expires_after="2022-02-02"> + units="ms" expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="SmartLockStatusTypes" --> <owner>hansberry@chromium.org</owner> @@ -2354,7 +2369,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WifiSync.MultiDeviceFeatureState" - enum="MultiDevice_FeatureState" expires_after="2022-03-01"> + enum="MultiDevice_FeatureState" expires_after="2022-05-01"> <owner>cvandermerwe@google.com</owner> <owner>better-together-dev@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/crostini/histograms.xml b/chromium/tools/metrics/histograms/metadata/crostini/histograms.xml index e12e701bded..09d865d36a4 100644 --- a/chromium/tools/metrics/histograms/metadata/crostini/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/crostini/histograms.xml @@ -45,7 +45,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.AppLaunchResult" enum="CrostiniResult" - expires_after="2022-01-06"> + expires_after="2022-04-10"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.AppsInstalledAtLogin" units="apps" - expires_after="2022-01-06"> + expires_after="2022-05-01"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -113,7 +113,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.Backup" enum="CrostiniExportContainerResult" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary>Result of crostini backup.</summary> @@ -166,7 +166,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.CleanSession.RestarterResult" enum="CrostiniResult" - expires_after="2022-01-06"> + expires_after="2022-05-01"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -177,7 +177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.ContainerOsVersion" enum="CrostiniContainerOsVersion" - expires_after="2022-01-06"> + expires_after="2022-04-10"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -187,7 +187,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.Crosvm.CpuPercentage" units="%" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -208,7 +208,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.Crosvm.RssPercentage" units="%" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -219,7 +219,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.DiskResize.Result" enum="CrostiniDiskImageStatus" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>davidmunro@google.com</owner> <summary> @@ -241,7 +241,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.DiskType" enum="CrostiniDiskImageType" - expires_after="2022-01-06"> + expires_after="2022-04-24"> <owner>clumptini@google.com</owner> <owner>davidmunro@google.com</owner> <summary> @@ -286,7 +286,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.FilesystemCorruption" enum="CorruptionStates" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -296,7 +296,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.InstallSource" enum="CrostiniInstallSource" - expires_after="2022-01-06"> + expires_after="2022-04-10"> <owner>clumptini@google.com</owner> <owner>sidereal@google.com</owner> <summary> @@ -330,7 +330,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.Restarter.Started" enum="BooleanAttempted" - expires_after="2022-01-06"> + expires_after="2022-05-01"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -340,7 +340,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.RestarterResult" enum="CrostiniResult" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -401,7 +401,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.SettingsEvent" enum="CrostiniSettingsEvent" - expires_after="2022-01-06"> + expires_after="2022-04-24"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <owner>victorhsieh@chromium.org</owner> @@ -409,7 +409,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.Setup.Started" enum="BooleanAttempted" - expires_after="2022-01-06"> + expires_after="2022-05-01"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -419,7 +419,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.SetUpLxdContainerUser.UnknownResult" - enum="BooleanYesNo" expires_after="2021-12-31"> + enum="BooleanYesNo" expires_after="2022-05-01"> <owner>davidmunro@google.com</owner> <owner>clumptini@google.com</owner> <summary> @@ -431,7 +431,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.SetupResult" enum="CrostiniSetupResult" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -500,7 +500,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.Stability" enum="GuestOsFailureClasses" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -511,7 +511,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.TerminalSettingsChanged" - enum="CrostiniTerminalSetting" expires_after="2022-01-06"> + enum="CrostiniTerminalSetting" expires_after="2022-04-17"> <owner>joelhockey@chromium.org</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -532,7 +532,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.TimeToInstallCancel" units="ms" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -555,7 +555,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.TimeToInstallSuccess" units="ms" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -577,7 +577,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Crostini.UninstallResult" enum="CrostiniUninstallResult" - expires_after="2022-01-06"> + expires_after="2022-03-13"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> @@ -597,7 +597,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Crostini.UnsupportedNotification.Reason" - enum="CrostiniUnsupportedNotificationReason" expires_after="2022-01-06"> + enum="CrostiniUnsupportedNotificationReason" expires_after="2022-04-17"> <owner>clumptini@google.com</owner> <owner>tbuckley@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/cryptohome/histograms.xml b/chromium/tools/metrics/histograms/metadata/cryptohome/histograms.xml index fa2b3ab71cc..ecf49de0e1b 100644 --- a/chromium/tools/metrics/histograms/metadata/cryptohome/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/cryptohome/histograms.xml @@ -63,7 +63,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.DeprecatedApiCalled" - enum="CryptohomeDeprecatedApiCalled" expires_after="2021-12-12"> + enum="CryptohomeDeprecatedApiCalled" expires_after="2022-04-03"> <owner>apronin@chromium.org</owner> <owner>louiscollard@chromium.org</owner> <owner>zuan@chromium.org</owner> @@ -194,7 +194,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.DiskCleanupProgress" - enum="CryptohomeDiskCleanupProgress" expires_after="2021-12-26"> + enum="CryptohomeDiskCleanupProgress" expires_after="2022-04-03"> <owner>dlunev@chromium.org</owner> <owner>sarthakkukreti@chromium.org</owner> <summary> @@ -206,14 +206,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.DiskCleanupResult" - enum="CryptohomeDiskCleanupResult" expires_after="2022-01-23"> + enum="CryptohomeDiskCleanupResult" expires_after="2022-04-17"> <owner>vsavu@google.com</owner> <owner>dlunev@chromium.org</owner> <summary>Records the result of triggering disk cleanup.</summary> </histogram> <histogram name="Cryptohome.Errors" enum="CryptohomeError" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>apronin@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary>Cryptohome errors.</summary> @@ -269,7 +269,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.HomedirEncryptionType" enum="HomedirEncryptionType" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>dspaid@chromium.org</owner> <summary> The encryption type used for a user's cryptohome directory. This is logged @@ -288,7 +288,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Cryptohome.LECredential" - enum="CryptohomeLECredError" expires_after="2022-01-09"> + enum="CryptohomeLECredError" expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="LECredentialOps" --> <owner>pmalani@chromium.org</owner> @@ -319,7 +319,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.MigrationToGaiaId" - enum="CryptohomeMigrationToGaiaId" expires_after="M97"> + enum="CryptohomeMigrationToGaiaId" expires_after="2022-05-01"> <owner>alemate@chromium.org</owner> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -401,7 +401,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.OOPMountOperationResult" - enum="CryptohomeOOPMountOperationResult" expires_after="2021-12-12"> + enum="CryptohomeOOPMountOperationResult" expires_after="2022-05-01"> <owner>betuls@chromium.org</owner> <owner>jorgelo@chromium.org</owner> <summary> @@ -421,7 +421,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.RestoreSELinuxContextResultForHome" - enum="BooleanSuccess" expires_after="2022-02-25"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>betuls@chromium.org</owner> <owner>jorgelo@chromium.org</owner> <summary> @@ -443,7 +443,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TimeBetweenFreeDiskSpace" units="s" - expires_after="2022-01-01"> + expires_after="2022-05-01"> <owner>vsavu@google.com</owner> <owner>dlunev@chromium.org</owner> <owner>sarthakkukreti@chromium.org</owner> @@ -455,7 +455,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TimeSessionUnlock" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>kerrnel@chromium.org</owner> <owner>mnissler@chromium.org</owner> <summary> @@ -498,7 +498,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TimeToMountEx" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>jorgelo@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary> @@ -528,7 +528,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TimeToPerformEphemeralMount" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>jorgelo@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary> @@ -539,7 +539,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TimeToPerformMount" units="ms" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>betuls@chromium.org</owner> <owner>jorgelo@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> @@ -562,7 +562,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TimeToPerformOOPMountOperation" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>jorgelo@chromium.org</owner> <owner>betuls@chromium.org</owner> <summary> @@ -572,7 +572,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TimeToTakeTpmOwnership" units="ms" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>apronin@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary> @@ -582,7 +582,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.TpmResults" enum="CryptohomeTpmResults" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>afakhry@chromium.org</owner> <summary> The errors resulting from interacting with the Trusted Platform Module (TPM) @@ -591,7 +591,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cryptohome.UserSubdirHasCorrectGroup" enum="BooleanCorrect" - expires_after="2022-02-01"> + expires_after="2022-04-03"> <owner>austinct@chromium.org</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -644,7 +644,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> -<histogram name="CryptohomeClient" units="ms" expires_after="2022-01-16"> +<histogram name="CryptohomeClient" units="ms" expires_after="2022-03-20"> <owner>zuan@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/custom_tabs/histograms.xml b/chromium/tools/metrics/histograms/metadata/custom_tabs/histograms.xml index 793721fcf08..f565fd25381 100644 --- a/chromium/tools/metrics/histograms/metadata/custom_tabs/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/custom_tabs/histograms.xml @@ -35,7 +35,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CustomTabs.ClientAppId" enum="ClientAppId" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>yusufo@chromium.org</owner> <summary> Android: AppId declared by the launching application in EXTRA_APPLICATION_ID @@ -84,7 +84,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CustomTabs.ConnectionStatusOnReturn.GSA" - enum="CustomTabsConnection" expires_after="2021-12-12"> + enum="CustomTabsConnection" expires_after="2022-04-24"> <owner>peconn@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -121,7 +121,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CustomTabs.DetachedResourceRequest.FinalStatus" - enum="NetErrorCodes" expires_after="2021-12-12"> + enum="NetErrorCodes" expires_after="2022-02-13"> <owner>lizeb@chromium.org</owner> <owner>cct-team@google.com</owner> <summary> @@ -326,7 +326,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CustomTabs.WarmupStateOnLaunch" enum="WarmupStateOnLaunch" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>lizeb@chromium.org</owner> <summary> Recorded only on Android. Reports whether warmup() has been called when a diff --git a/chromium/tools/metrics/histograms/metadata/data_reduction_proxy/histograms.xml b/chromium/tools/metrics/histograms/metadata/data_reduction_proxy/histograms.xml index 3a79cdb2d9c..73309faba78 100644 --- a/chromium/tools/metrics/histograms/metadata/data_reduction_proxy/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/data_reduction_proxy/histograms.xml @@ -280,7 +280,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataReductionProxy.LastWeekAggregateKB.Services" - enum="DataUseServicesHash" expires_after="2021-12-26"> + enum="DataUseServicesHash" expires_after="2022-02-27"> <owner>rajendrant@chromium.org</owner> <owner>bengr@chromium.org</owner> <summary> @@ -295,7 +295,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="DataReductionProxy.LastWeekAggregateKB.UserTraffic.Downstream.ContentType" - enum="DataUseContentType" expires_after="2021-12-26"> + enum="DataUseContentType" expires_after="2022-02-27"> <owner>rajendrant@chromium.org</owner> <owner>bengr@chromium.org</owner> <summary> @@ -385,7 +385,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataReductionProxy.StartupState" - enum="DataReductionProxyStartupState" expires_after="2022-01-16"> + enum="DataReductionProxyStartupState" expires_after="2022-03-20"> <owner>rajendrant@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -397,7 +397,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataReductionProxy.ThisWeekAggregateKB.Services" - enum="DataUseServicesHash" expires_after="2021-12-26"> + enum="DataUseServicesHash" expires_after="2022-02-27"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -412,7 +412,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="DataReductionProxy.ThisWeekAggregateKB.UserTraffic.Downstream.ContentType" - enum="DataUseContentType" expires_after="2021-12-26"> + enum="DataUseContentType" expires_after="2022-02-27"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -426,7 +426,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataReductionProxy.UIAction" enum="DataReductionProxyUIAction" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>bengr@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/dev/histograms.xml b/chromium/tools/metrics/histograms/metadata/dev/histograms.xml index 8b69ba56684..4baea708fce 100644 --- a/chromium/tools/metrics/histograms/metadata/dev/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/dev/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="DevTools.ActionTaken" enum="DevToolsAction" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>alph@chromium.org</owner> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> @@ -30,7 +30,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.BackgroundService.ClearEvents" - enum="ServiceWorkerStatusCode" expires_after="M92"> + enum="ServiceWorkerStatusCode" expires_after="M99"> <owner>yangguo@chromium.org</owner> <owner>rayankans@chromium.org</owner> <owner>bmeurer@chromium.org</owner> @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.BackgroundService.GetEvents" - enum="ServiceWorkerStatusCode" expires_after="M92"> + enum="ServiceWorkerStatusCode" expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> @@ -53,7 +53,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.BackgroundService.LogEvent" - enum="ServiceWorkerStatusCode" expires_after="M92"> + enum="ServiceWorkerStatusCode" expires_after="M99"> <owner>rayankans@chromium.org</owner> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> @@ -65,7 +65,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.BackgroundService.StartRecording" - enum="DevToolsBackgroundService" expires_after="2021-08-09"> + enum="DevToolsBackgroundService" expires_after="2022-07-09"> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> <owner>rayankans@chromium.org</owner> @@ -78,6 +78,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="DevTools.ColorPicker.FixedColor" enum="DevToolsColorPickerFixedColor" expires_after="2021-10-04"> + <obsolete> + Removed in M95 because it is no longer needed for analysis. + </obsolete> <owner>yangguo@chromium.org</owner> <owner>mathias@chromium.org</owner> <owner>alexrudenko@chromium.org</owner> @@ -101,6 +104,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="DevTools.ConsoleShowsCorsErrors" + enum="DevToolsConsoleShowsCorsErrors" expires_after="2022-03-20"> + <owner>dsv@chromium.org</owner> + <owner>bmeurer@chromium.org</owner> + <owner>yangguo@chromium.org</owner> + <summary> + Records if showing CORS erros in DevTools Console is enabled. + </summary> +</histogram> + <histogram name="DevTools.CssEditorOpened" enum="DevToolsCssEditorOpened" expires_after="2021-09-14"> <owner>yangguo@chromium.org</owner> @@ -202,7 +215,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.ExperimentEnabled" enum="DevtoolsExperiments" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>yangguo@chromium.org</owner> <owner>brgoddar@microsoft.com</owner> <owner>shanejc@microsoft.com</owner> @@ -212,7 +225,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.ExperimentEnabledAtLaunch" enum="DevtoolsExperiments" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>yangguo@chromium.org</owner> <owner>brgoddar@microsoft.com</owner> <owner>shanejc@microsoft.com</owner> @@ -248,7 +261,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DevTools.InspectElement" units="ms" expires_after="2021-12-05"> +<histogram name="DevTools.InspectElement" units="ms" expires_after="2022-05-01"> <owner>alph@chromium.org</owner> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> @@ -259,7 +272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.IssueCreated" enum="DevToolsIssueCreated" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> <summary> @@ -268,7 +281,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.IssuesPanelIssueExpanded" - enum="DevToolsIssuesPanelIssueExpanded" expires_after="2022-01-02"> + enum="DevToolsIssuesPanelIssueExpanded" expires_after="2022-04-17"> <owner>yangguo@chromium.org</owner> <owner>jegarc@microsoft.com</owner> <summary> @@ -277,7 +290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.IssuesPanelOpenedFrom" - enum="DevToolsIssuesPanelOpenedFrom" expires_after="2021-12-05"> + enum="DevToolsIssuesPanelOpenedFrom" expires_after="2022-05-01"> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> <summary> @@ -286,7 +299,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.IssuesPanelResourceOpened" - enum="DevToolsIssuesPanelResourceOpened" expires_after="2022-01-02"> + enum="DevToolsIssuesPanelResourceOpened" expires_after="2022-04-17"> <owner>yangguo@chromium.org</owner> <owner>jegarc@microsoft.com</owner> <summary> @@ -296,7 +309,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.KeybindSetSettingChanged" enum="DevToolsKeybindSets" - expires_after="2021-10-31"> + expires_after="2022-09-21"> <owner>yangguo@chromium.org</owner> <owner>jalyn@microsoft.com</owner> <owner>leo.lee@microsoft.com</owner> @@ -307,7 +320,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.KeyboardShortcutFired" - enum="DevToolsKeyboardShortcutAction" expires_after="2021-10-31"> + enum="DevToolsKeyboardShortcutAction" expires_after="2022-09-21"> <owner>yangguo@chromium.org</owner> <owner>jalyn@microsoft.com</owner> <owner>leo.lee@microsoft.com</owner> @@ -317,19 +330,31 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram base="true" name="DevTools.Launch" units="ms" expires_after="M94"> +<histogram name="DevTools.Language" enum="DevToolsLanguage" + expires_after="2022-02-06"> + <owner>bmeurer@chromium.org</owner> + <owner>szuend@chromium.org</owner> + <owner>yangguo@chromium.org</owner> + <summary> + The actual display language used for the DevTools UI. Logged once per + DevTools session when DevTools is booted up. + </summary> +</histogram> + +<histogram base="true" name="DevTools.Launch" units="ms" + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="DevToolsLaunchPanels" --> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> <summary> Measures the time until a given tool is interactive during a cold start of - the DevTools. + DevTools. </summary> </histogram> <histogram name="DevTools.LinearMemoryInspector.RevealedFrom" - enum="DevToolsLinearMemoryInspectorRevealedFrom" expires_after="M96"> + enum="DevToolsLinearMemoryInspectorRevealedFrom" expires_after="2022-04-10"> <owner>sawallner@chromium.org</owner> <owner>kimanh@chromium.org</owner> <summary> @@ -338,7 +363,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.LinearMemoryInspector.Target" - enum="DevToolsLinearMemoryInspectorTarget" expires_after="M96"> + enum="DevToolsLinearMemoryInspectorTarget" expires_after="2022-04-17"> <owner>sawallner@chromium.org</owner> <owner>kimanh@chromium.org</owner> <summary> @@ -356,15 +381,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DevTools.PanelClosed" enum="DevToolsPanel" expires_after="M94"> +<histogram name="DevTools.PanelClosed" enum="DevToolsPanel" + expires_after="2021-12-05"> <owner>yangguo@chromium.org</owner> <owner>joselea@microsoft.com</owner> - <owner>shanejc@microsoft.com</owner> - <summary>Specified DevTools panel was closed.</summary> + <summary> + Specified DevTools panel was closed. Fires immediately after closing a panel + using the "x" button in the panel title. + </summary> </histogram> <histogram name="DevTools.PanelShown" enum="DevToolsPanel" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>alph@chromium.org</owner> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> @@ -380,7 +408,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DevTools.SidebarPaneShown" enum="DevToolsSidebarPane" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>changhaohan@chromium.org</owner> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/direct/histograms.xml b/chromium/tools/metrics/histograms/metadata/direct/histograms.xml index 45a8c179108..884fac7c357 100644 --- a/chromium/tools/metrics/histograms/metadata/direct/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/direct/histograms.xml @@ -22,26 +22,37 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="DirectWrite.Fonts.Gfx.InitializeLoopCount" units="units" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>etienneb@chromium.org</owner> <summary> The number of iterations that was required to initialize Direct Write. This - metric is taken by the browser process at startup. The value -1 is reported - when the initialization failed. The fallback path using GDI is used instead - of DWrite. + metric is recorded by the browser process at startup. The value -1 is + reported when the initialization failed. The fallback path using GDI is used + instead of DWrite. + </summary> +</histogram> + +<histogram name="DirectWrite.Fonts.Gfx.InitializeTime" units="ms" + expires_after="M98"> + <owner>etienneb@chromium.org</owner> + <owner>gab@chromium.org</owner> + <summary> + Time it takes to initialize GFX fonts. This metric is taken by the browser + process at startup. It includes the time required to initialize Direct + Write. This metric is recorded only on Windows. </summary> </histogram> <histogram name="DirectWrite.Fonts.Proxy.CreateFontFaceResult" enum="Hresult" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary>Records the error returned from CreateFontFace.</summary> </histogram> <histogram name="DirectWrite.Fonts.Proxy.EmptyFamilyResultsRatio" - units="percentage of empty family results" expires_after="2021-10-15"> + units="percentage of empty family results" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -56,14 +67,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.Fallback.CacheSize" units="Count" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary>Records how many font families are in the fallback cache.</summary> </histogram> <histogram name="DirectWrite.Fonts.Proxy.FallbackResult" - enum="DirectWriteFontFallbackResult" expires_after="2021-10-15"> + enum="DirectWriteFontFallbackResult" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -74,15 +85,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.FamilyCount" units="families" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> + <owner>layout-dev@chromium.org</owner> <summary> The number of font families as seen by the font proxy in the renderer. </summary> </histogram> <histogram name="DirectWrite.Fonts.Proxy.FamilyCountIndexingStart" - units="font files" expires_after="2021-10-15"> + units="font files" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -96,7 +108,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.FontProxyError" - enum="DirectWriteFontProxyError" expires_after="2021-10-15"> + enum="DirectWriteFontProxyError" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -105,14 +117,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.GetSystemFontCollectionResult" - enum="Hresult" expires_after="2021-10-15"> + enum="Hresult" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary>Records the error returned from GetSystemFontCollection.</summary> </histogram> <histogram name="DirectWrite.Fonts.Proxy.IndexingSpeed" - units="font files per second" expires_after="2021-10-15"> + units="font files per second" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -123,7 +135,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LastResortFontCount" units="fonts" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -133,7 +145,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LastResortFontFileCount" units="files" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -142,7 +154,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LoaderType" - enum="DirectWriteFontLoaderType" expires_after="2021-10-15"> + enum="DirectWriteFontLoaderType" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -153,7 +165,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LoadFamilyResult" - enum="DirectWriteLoadFamilyResult" expires_after="2021-10-15"> + enum="DirectWriteLoadFamilyResult" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -164,7 +176,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LoadFamilyTime" units="ms" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -174,7 +186,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LookupTableBuildTime" units="ms" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -186,7 +198,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LookupTableDiskCacheHit" - units="BooleanSuccess" expires_after="2021-10-15"> + units="BooleanSuccess" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -198,7 +210,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LookupTablePersistSuccess" - units="BooleanSuccess" expires_after="2021-10-15"> + units="BooleanSuccess" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -209,7 +221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LookupTableReadyTime" units="ms" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -227,7 +239,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.LookupTableSize" units="KB" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -238,7 +250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.MessageFilterError" - enum="DirectWriteMessageFilterError" expires_after="2021-10-15"> + enum="DirectWriteMessageFilterError" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -247,7 +259,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.MostFrequentScanningFailure" - enum="Hresult" expires_after="2021-10-15"> + enum="Hresult" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -261,7 +273,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.NumFontFiles" units="font files" - expires_after="2021-10-15"> + expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> @@ -273,7 +285,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DirectWrite.Fonts.Proxy.TableBuildTimedOut" - units="BooleanTimedout" expires_after="2021-10-15"> + units="BooleanTimedout" expires_after="2022-10-15"> <owner>drott@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/disk/histograms.xml b/chromium/tools/metrics/histograms/metadata/disk/histograms.xml index cb35f139d54..9e9c947ca3a 100644 --- a/chromium/tools/metrics/histograms/metadata/disk/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/disk/histograms.xml @@ -123,9 +123,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DiskCache.0.Error" enum="DiskCacheError" expires_after="M85"> - <owner>rvargas@chromium.org</owner> - <summary>Critical error ids.</summary> +<histogram name="DiskCache.0.Error" enum="DiskCacheError" + expires_after="2022-05-01"> + <owner>wfh@chromium.org</owner> + <owner>src/net/disk_cache/OWNERS</owner> + <summary> + Critical error ids. Reported each time the disk backed blockfile cache + encounters an error or a critical error. Warning: this histogram was expired + from Oct 2020 to Sep 2021; data may be missing. + </summary> </histogram> <histogram name="DiskCache.0.FillupAge" units="hours" expires_after="M85"> diff --git a/chromium/tools/metrics/histograms/metadata/download/histograms.xml b/chromium/tools/metrics/histograms/metadata/download/histograms.xml index a2b8b0fc087..cd49e0cc5f1 100644 --- a/chromium/tools/metrics/histograms/metadata/download/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/download/histograms.xml @@ -52,7 +52,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.BandwidthOverallBytesPerSecond2" units="bytes/second" - expires_after="2021-12-31"> + expires_after="2022-03-06"> <owner>qinmin@chromium.org</owner> <owner>xingliu@chromium.org</owner> <summary> @@ -105,7 +105,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Download.Counts" enum="DownloadCountType" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <!-- Name completed by histogram_suffixes name="DownloadSource" --> <owner>xingliu@chromium.org</owner> @@ -125,7 +125,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.DangerousDialog.Events" - enum="DangerousDownloadDialogEvent" expires_after="2021-12-26"> + enum="DangerousDownloadDialogEvent" expires_after="2022-04-17"> <owner>qinmin@chromium.org</owner> <owner>xingliu@chromium.org</owner> <summary> @@ -136,7 +136,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.DangerousFile.DownloadValidatedByType" - enum="SBClientDownloadExtensions" expires_after="2021-12-26"> + enum="SBClientDownloadExtensions" expires_after="2022-04-17"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@chromium.org</owner> <summary> @@ -183,7 +183,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.DownloadDangerPrompt" - enum="SBClientDownloadExtensions" expires_after="2022-01-09"> + enum="SBClientDownloadExtensions" expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -224,6 +224,37 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>The size of successfully completed downloads.</summary> </histogram> +<histogram name="Download.DuplicateDialogEvent.{Type}" + enum="DuplicateDownloadEvent" expires_after="M99"> + <owner>qinmin@chromium.org</owner> + <owner>clank-downloads@chromium.org</owner> + <summary> + Records user interactions on the duplicate download dialog on Android, + either for a regular download or an offline page. One user interaction could + trigger multiple histograms to be recorded. For example, clicking the text + link could record both the link click histogram and the dialog dismiss + histogram. + </summary> + <token key="Type"> + <variant name="Download"/> + <variant name="OfflinePage"/> + </token> +</histogram> + +<histogram name="Download.DuplicateInfobarEvent.{Type}" + enum="DuplicateDownloadEvent" expires_after="M99"> + <owner>qinmin@chromium.org</owner> + <owner>clank-downloads@chromium.org</owner> + <summary> + Records user interactions on the duplicate download infobar on Android, + either for a regular download or an offline page. + </summary> + <token key="Type"> + <variant name="Download"/> + <variant name="OfflinePage"/> + </token> +</histogram> + <histogram name="Download.DuplicateInProgressDownloadIdCount" units="duplicates" expires_after="2019-07-30"> <owner>qinmin@chromium.org</owner> @@ -256,6 +287,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Download.InitiatedByWindowOpener" enum="DownloadInitiatedByWindowOpenerType" expires_after="M85"> + <obsolete> + Expired after M85. No longer in use. + </obsolete> <owner>meacer@chromium.org</owner> <owner>jdeblasio@chromium.org</owner> <summary> @@ -273,18 +307,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Download.InsecureBlocking.Extensions" - enum="InsecureDownloadExtensions" expires_after="M94"> + enum="InsecureDownloadExtensions" expires_after="2022-03-27"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <owner>cthomp@chromium.org</owner> <summary> Records file extension of download to support analysis for mixed content - file download blocking. + file download blocking. Warning: this histogram was expired from M94 through + M95; data may be missing. </summary> </histogram> <histogram name="Download.InsecureBlocking.Totals" - enum="InsecureDownloadSecurityStatus" expires_after="2022-01-23"> + enum="InsecureDownloadSecurityStatus" expires_after="2022-03-27"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <owner>cthomp@chromium.org</owner> @@ -295,14 +330,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Download.InsecureBlocking.Verification" - enum="DownloadContentType" expires_after="M92"> + enum="DownloadContentType" expires_after="2022-03-27"> + <obsolete> + Expired after M92. No longer in use. + </obsolete> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <owner>cthomp@chromium.org</owner> <summary> Records mime-type of download to support analysis for mixed content file download blocking. This is a temporary metric for investigating differences - in metrics. + in metrics. Warning: this histogram was expired from M92 through M95; data + may be missing. </summary> </histogram> @@ -469,7 +508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Later.Events" enum="DownloadLaterEvent" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>xingliu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -478,7 +517,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Later.ScheduledDownloadSize" units="Mb" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>xingliu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -488,7 +527,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Download.Later.UI.DialogChoice" - enum="DownloadLaterDialogChoice" expires_after="2022-01-09"> + enum="DownloadLaterDialogChoice" expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="DownloadDialogSource" --> <owner>xingliu@chromium.org</owner> @@ -501,7 +540,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Later.UI.Events" enum="DownloadLaterUiEvent" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>xingliu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -531,6 +570,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Download.MixedContentDialog.Events" + enum="MixedContentDownloadDialogEvent" expires_after="2022-03-31"> + <owner>qinmin@chromium.org</owner> + <owner>xingliu@chromium.org</owner> + <summary> + Records user interactions with the mixed content download dialog on Android. + Records when the dialog is shown, or when user clicks on a button or + dismisses the dialog. + </summary> +</histogram> + <histogram name="Download.Mobile.DangerousDownloadInfobarEvent" enum="DangerousDownloadInfobarEvent" expires_after="2022-03-31"> <owner>qinmin@chromium.org</owner> @@ -571,7 +621,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.OpenDownloads.PerProfileType" - enum="BrowserProfileType" expires_after="2021-12-31"> + enum="BrowserProfileType" expires_after="2022-04-24"> <owner>sideyilmaz@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -582,7 +632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.OpenDownloadsFromMenu.PerProfileType" - enum="BrowserProfileType" expires_after="2021-12-31"> + enum="BrowserProfileType" expires_after="2022-04-17"> <owner>sideyilmaz@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -612,7 +662,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.OverwrittenDownloadRemovedFromHistory" - units="downloads" expires_after="2022-02-06"> + units="downloads" expires_after="2022-04-24"> <owner>qinmin@chromium.org</owner> <owner>chrome-downloads@google.com</owner> <summary> @@ -731,7 +781,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Progress.InfoBar.CloseButtonClicked" - enum="DownloadInfoBarState" expires_after="M97"> + enum="DownloadInfoBarState" expires_after="2022-04-10"> <owner>shaktisahu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -741,7 +791,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Progress.InfoBar.Shown" - enum="DownloadInfoBar.ShownState" expires_after="2022-02-01"> + enum="DownloadInfoBar.ShownState" expires_after="2022-04-10"> <owner>shaktisahu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -941,6 +991,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Download.Service.Files.FreeDiskSpace" units="%" expires_after="2021-09-05"> + <obsolete> + Deprecated 09/2021 + </obsolete> <owner>xingliu@chromium.org</owner> <summary> The percentage of free disk space to total disk space. Recorded during @@ -969,7 +1022,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Service.Finish.Type" - enum="Download.Service.CompletionType" expires_after="2021-12-05"> + enum="Download.Service.CompletionType" expires_after="2022-04-10"> <owner>xingliu@chromium.org</owner> <summary>The completion type for downloads in download service.</summary> </histogram> @@ -1071,8 +1124,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Download.Shelf.VisibleTime" units="ms" + expires_after="2022-10-10"> + <owner>anise@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@chromium.org</owner> + <summary> + The time that the download shelf was visible until it was closed. This + histogram excludes times when DoUnhide() and DoHide() are called (i.e., when + the full screen state changes). + </summary> +</histogram> + <histogram name="Download.Shelf.WebUI.LoadCompletedTime" units="ms" - expires_after="M97"> + expires_after="2022-04-10"> <owner>kerenzhu@chromium.org</owner> <owner>robliao@chromium.org</owner> <owner>romanarora@chromium.org</owner> @@ -1085,7 +1149,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Shelf.WebUI.LoadDocumentTime" units="ms" - expires_after="M97"> + expires_after="2022-04-17"> <owner>kerenzhu@chromium.org</owner> <owner>robliao@chromium.org</owner> <owner>romanarora@chromium.org</owner> @@ -1146,6 +1210,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Download.ShelfContextMenuAction" + enum="DownloadShelfContextMenuAction" expires_after="2022-10-11"> + <owner>anise@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@chromium.org</owner> + <summary> + This histogram is used to record the different actions and events associated + with the download shelf context menu on Linux, MacOS, and Windows. + Specifically, it records when the dropdown button was clicked as well when + DownloadCommands were enabled or executed. Each action or enable event is + only emitted once; as a result, it is safe to compute a ratio by dividing + enabled events by clicked events. + </summary> +</histogram> + <histogram name="Download.ShowDangerousDownloadConfirmationPrompt" enum="DownloadItem.DangerType" expires_after="M77"> <owner>dtrainor@chromium.org</owner> @@ -1188,7 +1266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Start.ContentType.NormalProfile" - enum="DownloadContentType" expires_after="2022-01-02"> + enum="DownloadContentType" expires_after="2022-05-01"> <owner>shaktisahu@chromium.org</owner> <owner>clank-downloads@google.com</owner> <summary> @@ -1197,7 +1275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Download.Start.PerProfileType" enum="BrowserProfileType" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>sideyilmaz@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/enterprise/OWNERS b/chromium/tools/metrics/histograms/metadata/enterprise/OWNERS index 9dfc9412668..8bed734a7ec 100644 --- a/chromium/tools/metrics/histograms/metadata/enterprise/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/enterprise/OWNERS @@ -4,3 +4,4 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # Use chromium-metrics-reviews@google.com as a backup. poromov@chromium.org zmin@chromium.org +amraboelkher@chromium.org diff --git a/chromium/tools/metrics/histograms/metadata/enterprise/histograms.xml b/chromium/tools/metrics/histograms/metadata/enterprise/histograms.xml index 55e31b857c8..f072ee5db5b 100644 --- a/chromium/tools/metrics/histograms/metadata/enterprise/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/enterprise/histograms.xml @@ -33,6 +33,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name=".DeviceRefreshEnterpriseMachineCertificate" summary="Refresh enterprise machine certificate"/> <variant name=".DeviceRemotePowerwash" summary="Powerwash"/> + <variant name=".DeviceResetEuicc" summary="Reset EUICC"/> <variant name=".DeviceRunDiagnosticRoutine" summary="Run diagnostic routine"/> <variant name=".DeviceScreenshot" summary="Screenshot"/> <variant name=".DeviceSetVolume" summary="Set volume"/> @@ -46,8 +47,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name=".InitialEnrollment" summary="Initial Enrollment Exchange"/> </variants> +<variants name="PolicyLevel"> + <variant name="Mandatory" summary="Mandatory Policy"/> + <variant name="Recommended" summary="Recommended Policy"/> +</variants> + <histogram name="Enterprise.AccountStatusCheckResult" - enum="EnterpriseAccountStatus" expires_after="M99"> + enum="EnterpriseAccountStatus" expires_after="2022-05-01"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -170,6 +176,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Enterprise.AutoEnrollmentPrivateSetMembershipHashDanceComparison" enum="PrivateSetMembershipHashDanceComparison" expires_after="2022-01-02"> + <obsolete> + Removed in Aug 2021 since the data is no longer required after PSM became + the source of truth for initial enrollment in M94. + </obsolete> <owner>amraboelkher@google.com</owner> <owner>mpolzer@google.com</owner> <summary> @@ -193,7 +203,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.AutoEnrollmentPrivateSetMembershipSuccessTime" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-04-10"> <owner>amraboelkher@google.com</owner> <owner>mpolzer@google.com</owner> <summary> @@ -239,6 +249,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Enterprise.AutoEnrollmentPsmHashDanceDifferentResultsComparison" enum="PsmHashDanceDifferentResultsComparison" expires_after="2022-03-01"> + <obsolete> + Removed in Aug 2021 since the data is no longer required after PSM became + the source of truth for initial enrollment in M94. + </obsolete> <owner>amraboelkher@google.com</owner> <owner>mpolzer@google.com</owner> <summary> @@ -365,7 +379,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.CBCMPolicyRefresh" enum="EnterprisePolicyRefresh" - expires_after="2022-01-01"> + expires_after="2022-04-24"> <owner>anthonyvd@chromium.org</owner> <owner>cbe-eng@google.com</owner> <summary> @@ -375,6 +389,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Enterprise.CBCMRealTimeReportEnqueue" + enum="EnterpriseCloudReportingStatusCode" expires_after="2022-10-01"> + <owner>zmin@chromium.org</owner> + <owner>src/chrome/browser/enterprise/reporting/OWNERS</owner> + <summary> + Recorded when real time report enter the queue. It indicates whether the + report is pushed to the queue successfully or not. + </summary> +</histogram> + +<histogram name="Enterprise.CBCMRealTimeReportQueueConfigurationCreation" + enum="EnterpriseCloudReportingStatusCode" expires_after="2022-10-01"> + <owner>zmin@chromium.org</owner> + <owner>src/chrome/browser/enterprise/reporting/OWNERS</owner> + <summary> + Recorded when real time report queue is created. It indicates whether the + configuration is created successfully or not. + </summary> +</histogram> + +<histogram name="Enterprise.CBCMRealTimeReportQueueCreation" + enum="EnterpriseCloudReportingStatusCode" expires_after="2022-10-01"> + <owner>zmin@chromium.org</owner> + <owner>src/chrome/browser/enterprise/reporting/OWNERS</owner> + <summary> + Recorded when real time report queue is created. It indicates whether the + queue is created successfully or not. + </summary> +</histogram> + <histogram name="Enterprise.CBCMRemoteCommand.Executed" enum="RemoteCommandExecutionStatus" expires_after="2022-01-01"> <owner>anthonyvd@chromium.org</owner> @@ -434,7 +478,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.CloudExtensionRequestUpdated" - enum="EnterpriseCloudExtensionRequestListUpdate" expires_after="2021-10-01"> + enum="EnterpriseCloudExtensionRequestListUpdate" expires_after="2022-10-01"> <owner>zmin@chromium.org</owner> <owner>src/chrome/browser/enterprise/reporting/OWNERS</owner> <summary> @@ -445,7 +489,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.CloudReportingBasicRequestSize" units="KB" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>zmin@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -456,7 +500,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.CloudReportingRequestCount" units="requests" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>zmin@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -466,7 +510,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.CloudReportingRequestSize" units="KB" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>zmin@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -476,7 +520,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.CloudReportingResponse" - enum="EnterpriseCloudReportingResponse" expires_after="2022-02-01"> + enum="EnterpriseCloudReportingResponse" expires_after="2022-04-17"> <owner>zmin@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -499,7 +543,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DeviceLocalAccountPolicyInvalidations2" - enum="EnterprisePolicyInvalidations" expires_after="2021-10-17"> + enum="EnterprisePolicyInvalidations" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -514,7 +558,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DeviceLocalAccountPolicyRefresh3" - enum="EnterprisePolicyRefresh" expires_after="2022-03-01"> + enum="EnterprisePolicyRefresh" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -562,7 +606,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DevicePolicyInvalidations2" - enum="EnterprisePolicyInvalidations" expires_after="2022-03-01"> + enum="EnterprisePolicyInvalidations" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -578,7 +622,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DevicePolicyRefresh3" - enum="EnterprisePolicyRefresh" expires_after="2022-03-01"> + enum="EnterprisePolicyRefresh" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -627,7 +671,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DeviceRemoteCommand.Received" - enum="RemoteCommandReceivedStatus" expires_after="2022-03-01"> + enum="RemoteCommandReceivedStatus" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -651,7 +695,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DeviceRemoteCommandInvalidations" - enum="EnterprisePolicyInvalidations" expires_after="2022-03-01"> + enum="EnterprisePolicyInvalidations" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -668,7 +712,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DeviceSettings.MissingPolicyMitigated" - units="BooleanSuccess" expires_after="2021-10-04"> + units="BooleanSuccess" expires_after="2022-10-04"> <owner>poromov@chromium.org</owner> <owner>managed-devices@google.com</owner> <summary> @@ -679,7 +723,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.DeviceSettings.UpdatedStatus" - enum="DeviceSettingsStatus" expires_after="2021-10-04"> + enum="DeviceSettingsStatus" expires_after="2022-10-04"> <owner>poromov@chromium.org</owner> <owner>managed-devices@google.com</owner> <summary> @@ -690,7 +734,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.CaptureModeInitBlocked" enum="BooleanBlocked" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -700,7 +744,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.ClipboardReadBlocked" enum="BooleanBlocked" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -710,7 +754,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.DataTransferControllerStarted" enum="Boolean" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -720,8 +764,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Enterprise.Dlp.DataTransferReportingTimeDiff" units="ms" + expires_after="2022-05-01"> + <owner>jkopanski@google.com</owner> + <owner>chromeos-dlp@google.com</owner> + <summary> + Time difference between current and the latest sent Data Leak Prevention + reporting events for data transfers for which sources and destinations are + the same. + </summary> +</histogram> + <histogram name="Enterprise.Dlp.DlpPolicyPresent" enum="Boolean" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -731,7 +786,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.DragDropBlocked" enum="BooleanBlocked" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -750,7 +805,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.PrintingBlocked" enum="BooleanBlocked" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary>Result of Data Leak Prevention evaluation for printing.</summary> @@ -776,7 +831,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.ReportedEventStatus" enum="GoogleRpcCode" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -785,7 +840,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.ReportedReportLevelRestriction" - enum="EnterpriseDlpPolicyRestriction" expires_after="2022-03-01"> + enum="EnterpriseDlpPolicyRestriction" expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -795,7 +850,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.RestrictionConfigured" - enum="EnterpriseDlpPolicyRestriction" expires_after="2022-03-01"> + enum="EnterpriseDlpPolicyRestriction" expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -805,7 +860,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.ScreenShareBlocked" enum="BooleanBlocked" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -824,7 +879,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.ScreenshotBlocked" enum="BooleanBlocked" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -833,7 +888,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Dlp.VideoCaptureBlocked" enum="BooleanBlocked" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <owner>chromeos-dlp@google.com</owner> <summary> @@ -1020,7 +1075,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Enrollment" enum="EnterpriseEnrollmentType" - expires_after="2021-12-19"> + expires_after="2022-04-03"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -1053,7 +1108,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentForced" enum="EnterpriseEnrollmentType" - expires_after="2021-11-21"> + expires_after="2022-05-01"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -1062,7 +1117,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentForcedAttestationBased" - enum="EnterpriseEnrollmentType" expires_after="2021-11-21"> + enum="EnterpriseEnrollmentType" expires_after="2022-05-01"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -1072,7 +1127,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentForcedInitial" - enum="EnterpriseEnrollmentType" expires_after="2021-10-01"> + enum="EnterpriseEnrollmentType" expires_after="2022-02-01"> <owner>raleksandrov@google.com</owner> <owner>pmarko@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -1083,7 +1138,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentForcedInitialAttestationBased" - enum="EnterpriseEnrollmentType" expires_after="2021-10-01"> + enum="EnterpriseEnrollmentType" expires_after="2022-02-01"> <owner>raleksandrov@google.com</owner> <owner>pmarko@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -1094,7 +1149,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentForcedInitialManualFallback" - enum="EnterpriseEnrollmentType" expires_after="2021-10-01"> + enum="EnterpriseEnrollmentType" expires_after="2022-02-01"> <owner>raleksandrov@google.com</owner> <owner>pmarko@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -1115,7 +1170,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentRecovery" enum="EnterpriseEnrollmentType" - expires_after="2021-10-01"> + expires_after="2022-02-01"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -1126,7 +1181,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentTime.Cancel" units="ms" - expires_after="2021-10-01"> + expires_after="2022-04-24"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -1135,7 +1190,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentTime.Failure" units="ms" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -1144,7 +1199,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnrollmentTime.Success" units="ms" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -1153,7 +1208,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnterCriticalPolicySectionDelay.Total" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>grt@chromium.org</owner> <owner>zmin@chromium.org</owner> <summary> @@ -1184,7 +1239,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.EnterCriticalPolicySectionError" - enum="WinGetLastError" expires_after="2021-12-31"> + enum="WinGetLastError" expires_after="2022-04-10"> <owner>grt@chromium.org</owner> <owner>zmin@chromium.org</owner> <summary> @@ -1209,7 +1264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.FCMInvalidationService.CBCMPolicyInvalidations" - enum="EnterprisePolicyInvalidations" expires_after="2022-01-01"> + enum="EnterprisePolicyInvalidations" expires_after="2022-05-01"> <owner>anthonyvd@chromium.org</owner> <owner>chrome-enterprise-team-core@google.com</owner> <summary> @@ -1237,7 +1292,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Enterprise.FCMInvalidationService.DeviceLocalAccountPolicyInvalidations2" - enum="EnterprisePolicyInvalidations" expires_after="2022-03-01"> + enum="EnterprisePolicyInvalidations" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1256,7 +1311,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Enterprise.FCMInvalidationService.DeviceLocalAccountPolicyRefresh3" - enum="EnterprisePolicyRefresh" expires_after="2022-03-01"> + enum="EnterprisePolicyRefresh" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1292,7 +1347,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.FCMInvalidationService.DevicePolicyRefresh3" - enum="EnterprisePolicyRefresh" expires_after="2022-03-01"> + enum="EnterprisePolicyRefresh" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1325,7 +1380,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Enterprise.FCMInvalidationService.PolicyInvalidationsRegistrationResult" - enum="BooleanSuccess" expires_after="2022-03-01"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1338,7 +1393,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.FCMInvalidationService.PolicyRefresh2" - enum="EnterprisePolicyRefresh" expires_after="2022-03-01"> + enum="EnterprisePolicyRefresh" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1409,7 +1464,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.FirstRun.AppRestrictionLoadTime.Medium" units="ms" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>skym@chromium.org</owner> <owner>twellington@chromium.org</owner> <owner>wenyufu@chromium.org</owner> @@ -1451,7 +1506,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.InvalidDevicePolicyFilesStatus" - enum="InvalidDevicePolicyFilesStatus" expires_after="2022-01-01"> + enum="InvalidDevicePolicyFilesStatus" expires_after="2022-04-17"> <owner>emaxx@chromium.org</owner> <owner>igorcov@chromium.org</owner> <owner>vsavu@google.com</owner> @@ -1570,7 +1625,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.OnBulkDataEntry.DataSize" units="bytes" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -1587,7 +1642,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Policies" enum="EnterprisePolicies" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>mnissler@chromium.org</owner> <summary> A set of enterprise policy rules that are in use. This is recorded every 24 @@ -1596,7 +1651,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.Policies.IgnoredByPolicyGroup" - enum="EnterprisePolicies" expires_after="2022-01-09"> + enum="EnterprisePolicies" expires_after="2022-04-24"> <owner>ydago@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1619,6 +1674,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Enterprise.Policies.{PolicyLevel}" enum="EnterprisePolicies" + expires_after="2022-03-15"> + <owner>qiutanw@google.com</owner> + <owner>zmin@chromium.org</owner> + <summary> + A set of {PolicyLevel} enterprise policy rules that are in use. This is + recorded for each {PolicyLevel} policy every 24 hours and at startup, if the + last recording was earlier than a day before. + </summary> + <token key="PolicyLevel" variants="PolicyLevel"/> +</histogram> + <histogram name="Enterprise.PolicyHasVerifiedCachedKey" enum="BooleanValidKeyExists" expires_after="M77"> <obsolete> @@ -1631,7 +1698,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.PolicyInvalidations" - enum="EnterprisePolicyInvalidations" expires_after="2022-03-01"> + enum="EnterprisePolicyInvalidations" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1643,7 +1710,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.PolicyInvalidationsRegistrationResult" - enum="BooleanSuccess" expires_after="2022-03-01"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1692,7 +1759,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.PolicyUpdatePeriod.Device" units="days" - expires_after="M95"> + expires_after="2022-10-01"> <owner>rbock@google.com</owner> <owner>igorcov@chromium.org</owner> <summary> @@ -1701,7 +1768,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.PolicyUpdatePeriod.MachineLevelUser" units="days" - expires_after="M95"> + expires_after="2022-10-01"> <owner>zmin@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <summary> @@ -1711,7 +1778,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.PolicyUpdatePeriod.User" units="days" - expires_after="M95"> + expires_after="2022-10-01"> <owner>rbock@google.com</owner> <owner>igorcov@chromium.org</owner> <summary> @@ -1720,7 +1787,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.PolicyUserVerification" - enum="EnterprisePolicyUserVerification" expires_after="M100"> + enum="EnterprisePolicyUserVerification" expires_after="2022-04-17"> <owner>poromov@chromium.org</owner> <owner>chromeos-commercial-stability@google.com</owner> <summary>Tracking the results of policy user verification.</summary> @@ -1805,7 +1872,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.RemoteCommandInvalidationsRegistrationResult" - enum="BooleanSuccess" expires_after="2022-03-01"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -1893,7 +1960,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.SystemLogUploadResult" - enum="EnterpriseSystemLogUploadResult" expires_after="2021-12-19"> + enum="EnterpriseSystemLogUploadResult" expires_after="2022-05-01"> <owner>bmalcolm@chromium.org</owner> <owner>cros-client-wa@google.com</owner> <summary>Result of a single attempt to upload system logs.</summary> @@ -2030,7 +2097,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.UserPolicyChromeOS.ChildUser.OAuthTokenError" - enum="GoogleServiceAuthError" expires_after="2021-12-19"> + enum="GoogleServiceAuthError" expires_after="2022-02-20"> <owner>agawronska@chromium.org</owner> <owner>michaelpg@chromium.org</owner> <summary>Failure reason for OAuth token fetch for child user.</summary> @@ -2184,7 +2251,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.UserRemoteCommand.Received.Unsigned" - enum="RemoteCommandReceivedStatus" expires_after="2022-03-01"> + enum="RemoteCommandReceivedStatus" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -2196,7 +2263,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.UserRemoteCommandInvalidations" - enum="EnterprisePolicyInvalidations" expires_after="2022-03-01"> + enum="EnterprisePolicyInvalidations" expires_after="2022-05-01"> <owner>asumaneev@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -2210,7 +2277,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.UserSession.Logins" - enum="EnterpriseUserSessionLogins" expires_after="2022-01-23"> + enum="EnterpriseUserSessionLogins" expires_after="2022-04-24"> <owner>xiyuan@chromium.org</owner> <owner>sduraisamy@chromium.org</owner> <summary>Tracks the sign-in events on an enrolled device.</summary> @@ -2237,7 +2304,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Enterprise.VpdUpdateStatus" units="units" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>igorcov@chromium.org</owner> <owner>tnagel@chromium.org</owner> <summary> @@ -2322,7 +2389,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EnterpriseCheck.IsDomainJoined" enum="BooleanEnabled" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>pastarmovj@chromium.org</owner> <owner>rogerta@chromium.org</owner> <owner>zmin@chromium.org</owner> @@ -2333,7 +2400,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EnterpriseCheck.IsEnterpriseUser" enum="BooleanEnabled" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>pastarmovj@chromium.org</owner> <owner>rogerta@chromium.org</owner> <owner>zmin@chromium.org</owner> @@ -2345,7 +2412,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EnterpriseCheck.IsFullyManaged2" enum="IsFullyManagedBoolean" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>twellington@google.com</owner> <owner>tedchcoc@chromium.org</owner> <summary> @@ -2356,7 +2423,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EnterpriseCheck.IsLocalMachine" enum="Boolean" - expires_after="2021-11-01"> + expires_after="2022-10-01"> <owner>rogerta@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <owner>zmin@chromium.org</owner> @@ -2367,7 +2434,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EnterpriseCheck.IsLocalUser" enum="Boolean" - expires_after="2021-11-01"> + expires_after="2022-10-01"> <owner>pastarmovj@chromium.org</owner> <owner>rogerta@chromium.org</owner> <owner>zmin@chromium.org</owner> @@ -2379,7 +2446,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EnterpriseCheck.IsManaged2" enum="BooleanEnabled" - expires_after="2022-01-02"> + expires_after="2022-10-01"> <owner>rogerta@chromium.org</owner> <owner>pastarmovj@chromium.org</owner> <owner>zmin@chromium.org</owner> @@ -2452,7 +2519,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="EnterpriseCheck.OSType" enum="OsSuite" - expires_after="2021-10-04"> + expires_after="2022-08-23"> <owner>pastarmovj@chromium.org</owner> <owner>rogerta@chomium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/event/histograms.xml b/chromium/tools/metrics/histograms/metadata/event/histograms.xml index f3df2cfb966..ac43d460304 100644 --- a/chromium/tools/metrics/histograms/metadata/event/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/event/histograms.xml @@ -21,13 +21,254 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> +<variants name="EventLatencyBreakdown"> + <variant name="Activation" summary="the duration of the activation stage"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="BeginImplFrameToSendBeginMainFrame" + summary="the time from when the compositor impl frame is started to when + BeginMainFrame is sent"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="BrowserToRendererCompositor" + summary="the time from when the event is generated until the first + compositor stage after the event arrives in the renderer"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="Commit" summary="the duration of the commit stage"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="EndActivateToSubmitCompositorFrame" + summary="the time from when an activation is complete to the next + SubmitCompositorFrame"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="EndCommitToActivation" + summary="the time from when a commit is complete to the beginning of the + next activation"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit" + summary="the time from when the BeginMainFrame is sent to the beginning + of the commit"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.Animate" + summary="the time portion of SendBeginMainFrameToCommit spent on + animations"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.BeginMainSentToStarted" + summary="the time portion of SendBeginMainFrameToCommit spent before + starting main thread work"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.Composite" + summary="the time portion of SendBeginMainFrameToCommit spent on + compositing"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.CompositeCommit" + summary="the time portion of SendBeginMainFrameToCommit spent on + composite commit"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.CompositingAssignments" + summary="the time portion of SendBeginMainFrameToCommit spent on + updating compositing assignments"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.CompositingInputs" + summary="the time portion of SendBeginMainFrameToCommit spent on + updating compositing inputs"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.HandleInputEvents" + summary="the time portion of SendBeginMainFrameToCommit spent on + handling imput events"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.LayoutUpdate" + summary="the time portion of SendBeginMainFrameToCommit spent on layout + update"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.Paint" + summary="the time portion of SendBeginMainFrameToCommit spent on paint"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.Prepaint" + summary="the time portion of SendBeginMainFrameToCommit spent on + prepaint"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.ScrollingCoordinator" + summary="the time portion of SendBeginMainFrameToCommit spent on + scrolling coordinator"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.StyleUpdate" + summary="the time portion of SendBeginMainFrameToCommit spent on style + update"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SendBeginMainFrameToCommit.UpdateLayers" + summary="the time portion of SendBeginMainFrameToCommit spent on + updating layers"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="SubmitCompositorFrameToPresentationCompositorFrame" + summary="the time from when the compositor frame is submitted to the + display compositor to when it is presented"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant + name="SubmitCompositorFrameToPresentationCompositorFrame.ReceivedCompositorFrameToStartDraw" + summary="the time from when the compositor frame is received to when it + starts to draw"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant + name="SubmitCompositorFrameToPresentationCompositorFrame.StartDrawToSwapStart" + summary="the time from when the compositor frame is started to draw to + when it starts swap"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant + name="SubmitCompositorFrameToPresentationCompositorFrame.SubmitToReceiveCompositorFrame" + summary="the time from when the compositor frame is submitted to when it + is received"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant + name="SubmitCompositorFrameToPresentationCompositorFrame.SwapEndToPresentationCompositorFrame" + summary="the time from when the compositor frame ends swap to when it is + presented"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant + name="SubmitCompositorFrameToPresentationCompositorFrame.SwapStartToSwapEnd" + summary="the time from when the compositor frame starts to swap to when + it ends swap"> + <obsolete> + Obsolete as of M90. Breakdowns are being tracked in UKM. + </obsolete> + </variant> + <variant name="TotalLatency" + summary="total latency from when the event is generated until the frame + is presented on screen"/> +</variants> + +<variants name="EventLatencyEventType"> + <variant name="GestureDoubleTap" summary="gesture-double-tap events"/> + <variant name="GestureLongPress" summary="gesture-long-press events"/> + <variant name="GestureLongTap" summary="gesture-long-tap events"/> + <variant name="GestureShowPress" summary="gesture-show-press events"/> + <variant name="GestureTap" summary="gesture-tap events"/> + <variant name="GestureTapCancel" summary="gesture-tap-cancel events"/> + <variant name="GestureTapDown" summary="gesture-tap-down events"/> + <variant name="GestureTapUnconfirmed" + summary="gesture-tap-unconfirmed events"/> + <variant name="GestureTwoFingerTap" summary="gesture-two-finger-tap events"/> + <variant name="KeyPressed" summary="key-pressed events"/> + <variant name="KeyReleased" summary="key-released events"/> + <variant name="MouseDragged" summary="mouse-dragged events"/> + <variant name="MousePressed" summary="mouse-pressed events"/> + <variant name="MouseReleased" summary="mouse-released events"/> + <variant name="MouseWheel" summary="mouse-wheel events"/> + <variant name="TouchMoved" summary="touch-moved events"/> + <variant name="TouchPressed" summary="touch-pressed events"/> + <variant name="TouchReleased" summary="touch-released events"/> +</variants> + +<variants name="EventLatencyPinchEventType"> + <variant name="GesturePinchBegin" summary="gesture-pinch-begin events"/> + <variant name="GesturePinchEnd" summary="gesture-pinch-end events"/> + <variant name="GesturePinchUpdate" + summary="gesture-pinch-update events in a scroll sequence"/> +</variants> + +<variants name="EventLatencyPinchInputType"> + <variant name="Touchpad" summary="touchpad"/> + <variant name="Touchscreen" summary="touchscreen"/> +</variants> + +<variants name="EventLatencyScrollEventType"> + <variant name="FirstGestureScrollUpdate" + summary="the first gesture-scroll-update event in a scroll sequence"/> + <variant name="GestureScrollBegin" summary="gesture-scroll-begin events"/> + <variant name="GestureScrollEnd" summary="gesture-scroll-end events"/> + <variant name="GestureScrollUpdate" + summary="non-inertial gesture-scroll-update events in a scroll sequence + except for the first one"/> + <variant name="InertialGestureScrollUpdate" + summary="inertial gesture-scroll-update events in a scroll sequence"/> +</variants> + +<variants name="EventLatencyScrollInputType"> + <variant name="Autoscroll" summary="autoscroll"/> + <variant name="Scrollbar" summary="scrollbar"/> + <variant name="Touchscreen" summary="touchscreen"/> + <variant name="Wheel" summary="mouse wheel or touchpad"/> +</variants> + <variants name="TopControlsState"> <variant name=".NoTopControlsMoved" summary="Top controls did not change."/> <variant name=".TopControlsMoved" summary="Top controls changed."/> </variants> <histogram name="Event.AggregatedLatency.Renderer2" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>flackr@chromium.org</owner> <summary> Time between initiation of any input event and the renderer receiving and @@ -70,7 +311,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.AsyncTargeting.ResponseTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>sadrul@chromium.org</owner> <owner>event-targeting@chromium.org</owner> <summary> @@ -114,7 +355,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Event.DownEventCount.PerInputFormFactorDestinationCombination2" - enum="DownEventInputFormFactorDestinationCombination2" expires_after="M100"> + enum="DownEventInputFormFactorDestinationCombination2" + expires_after="2022-04-17"> <owner>tbuckley@chromium.org</owner> <summary> The number of down events received per destination, input and form factor @@ -241,7 +483,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.InputEventPrediction.Scroll.PredictionJitter" - units="pixels" expires_after="M97"> + units="pixels" expires_after="2022-03-06"> <owner>eirage@chromium.org</owner> <owner>axantoine@google.com</owner> <summary> @@ -255,7 +497,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.InputEventPrediction.Scroll.VisualJitter" units="pixels" - expires_after="M97"> + expires_after="2022-03-06"> <owner>eirage@chromium.org</owner> <owner>axantoine@google.com</owner> <summary> @@ -299,7 +541,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.EndToEnd.KeyPress" units="microseconds" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>flackr@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -342,7 +584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.EndToEnd.TouchpadPinch2" units="microseconds" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>nzolghadr@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -362,7 +604,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.HitTest" units="microseconds" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -381,7 +623,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.HitTestRecursive" units="microseconds" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -415,7 +657,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Event.Latency.OS2" units="ms" expires_after="2021-12-01"> +<histogram name="Event.Latency.OS2" units="ms" expires_after="2022-04-10"> <owner>flackr@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -557,7 +799,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. name="Event.Latency.ScrollBegin.Scrollbar.BrowserNotifiedToBeforeGpuSwap2" units="microseconds" expires_after="2021-12-01"> <owner>flackr@chromium.org</owner> - <owner>dlibby@microsoft.com</owner> + <owner>gerchiko@microsoft.com</owner> <owner>input-dev@chromium.org</owner> <summary> Time between the display compositor receives the notification of the first @@ -568,6 +810,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. in the browser process. Team: input-dev@chromium.org. + + Warning: This metric may include reports from clients with low-resolution + clocks (i.e. on Windows, ref. |TimeTicks::IsHighResolution()|). Such reports + will cause this metric to have an abnormal distribution. When considering + revising this histogram, see UMA_HISTOGRAM_CUSTOM_MICROSECONDS_TIMES for the + solution. </summary> </histogram> @@ -592,9 +840,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.ScrollBegin.Scrollbar.HandledToRendererSwap2" - units="microseconds" expires_after="2020-12-01"> + units="microseconds" expires_after="2021-12-01"> <owner>nzolghadr@chromium.org</owner> - <owner>dlibby@microsoft.com</owner> + <owner>gerchiko@microsoft.com</owner> <owner>input-dev@chromium.org</owner> <summary> Time between the first ScrollUpdate gesture event in a given scroll gesture @@ -613,9 +861,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Event.Latency.ScrollBegin.Scrollbar.RendererSwapToBrowserNotified2" - units="microseconds" expires_after="2020-12-01"> + units="microseconds" expires_after="2021-12-01"> <owner>nzolghadr@chromium.org</owner> - <owner>dlibby@microsoft.com</owner> + <owner>gerchiko@microsoft.com</owner> <owner>input-dev@chromium.org</owner> <summary> Time between the renderer starts to swap a frame (generates compositor @@ -626,13 +874,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. historically the display compositor lived in the browser process. Team: input-dev@chromium.org. + + Warning: This metric may include reports from clients with low-resolution + clocks (i.e. on Windows, ref. |TimeTicks::IsHighResolution()|). Such reports + will cause this metric to have an abnormal distribution. When considering + revising this histogram, see UMA_HISTOGRAM_CUSTOM_MICROSECONDS_TIMES for the + solution. </summary> </histogram> <histogram name="Event.Latency.ScrollBegin.Scrollbar.TimeToHandled2" - units="microseconds" expires_after="2020-12-01"> + units="microseconds" expires_after="2021-12-01"> <owner>nzolghadr@chromium.org</owner> - <owner>dlibby@microsoft.com</owner> + <owner>gerchiko@microsoft.com</owner> <owner>input-dev@chromium.org</owner> <summary> Time between initial creation of a scrollbar event and the first generated @@ -654,7 +908,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. name="Event.Latency.ScrollBegin.Scrollbar.TimeToScrollUpdateSwapBegin4" units="microseconds" expires_after="2021-12-12"> <owner>nzolghadr@chromium.org</owner> - <owner>dlibby@microsoft.com</owner> + <owner>gerchiko@microsoft.com</owner> <owner>input-dev@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -676,7 +930,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.ScrollBegin.TimeToScrollUpdateSwapBegin2" - units="microseconds" expires_after="2022-01-16"> + units="microseconds" expires_after="2022-03-20"> <owner>nzolghadr@chromium.org</owner> <summary> Time between initial creation of a wheel/touch event and start of the frame @@ -723,7 +977,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.ScrollBegin.Touch.AverageLagPresentation" - units="pixels" expires_after="M97"> + units="pixels" expires_after="2022-05-01"> <owner>flackr@chromium.org</owner> <owner>joalmei@microsoft.org</owner> <owner>input-dev@chromium.org</owner> @@ -875,7 +1129,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Event.Latency.ScrollBegin.Wheel.BrowserNotifiedToBeforeGpuSwap2" - units="microseconds" expires_after="2021-12-01"> + units="microseconds" expires_after="2022-05-01"> <owner>flackr@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -960,7 +1214,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.ScrollBegin.Wheel.TimeToScrollUpdateSwapBegin4" - units="microseconds" expires_after="2022-01-02"> + units="microseconds" expires_after="2022-03-06"> <owner>flackr@chromium.org</owner> <summary> Time between initial creation of a wheel event and the start of the frame @@ -980,7 +1234,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Event.Latency.ScrollInertial.Touch.BrowserNotifiedToBeforeGpuSwap2" - units="microseconds" expires_after="2021-12-01"> + units="microseconds" expires_after="2022-04-17"> <owner>flackr@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -1196,7 +1450,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Event.Latency.ScrollUpdate.Scrollbar.TimeToScrollUpdateSwapBegin4" - units="microseconds" expires_after="2021-12-01"> + units="microseconds" expires_after="2022-04-10"> <owner>flackr@chromium.org</owner> <owner>arakeri@microsoft.com</owner> <owner>input-dev@chromium.org</owner> @@ -1219,7 +1473,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.ScrollUpdate.TimeToScrollUpdateSwapBegin2" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-24"> <owner>nzolghadr@chromium.org</owner> <summary> Time between initial creation of a wheel/touch event and start of the frame @@ -1318,7 +1572,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.ScrollUpdate.Touch.AverageLagPresentation" - units="pixels" expires_after="M97"> + units="pixels" expires_after="2022-03-06"> <owner>flackr@chromium.org</owner> <owner>joalmei@microsoft.com</owner> <owner>input-dev@chromium.org</owner> @@ -1618,7 +1872,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.Latency.ScrollUpdate.Wheel.TimeToScrollUpdateSwapBegin4" - units="microseconds" expires_after="2022-01-02"> + units="microseconds" expires_after="2022-03-06"> <owner>flackr@chromium.org</owner> <summary> Time between initial creation of a wheel event and start of the frame swap @@ -1668,8 +1922,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Event.PageShow.Persisted" enum="EventPageShowPersisted" + expires_after="2022-10-01"> + <owner>hajimehoshi@chromium.org</owner> + <owner>fergal@chromium.org</owner> + <summary> + Records whether the pageshow event had its persisted flag set in renderer or + browser. This flag is on if and only if the page is restored from + back-forward cache. This flag is off e.g. during the page load. This is + recorded when pageshow event fires on a main frame in renderer, or when + browser triggers this event on a main frame. This was a boolean on M95 and + before, is extended to an enum EventPageShoerPersisted as of M96. + </summary> +</histogram> + <histogram name="Event.PassiveListeners" enum="EventResultType" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>dtapuska@chromium.org</owner> <summary> The result of handling of MouseWheel, TouchStart, TouchMove, TouchEnd events @@ -1859,7 +2127,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Event.UserActivation.TriggerFor{ActivationGatedApiType}" - enum="UserActivationTriggerEnum" expires_after="2021-09-30"> + enum="UserActivationTriggerEnum" expires_after="2022-06-30"> <owner>mustaq@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -1904,18 +2172,70 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram base="true" name="EventLatency" units="microseconds" +<histogram name="EventLatency.TotalLatency" units="microseconds" + expires_after="2022-04-24"> + <owner>mohsen@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + Tracks the total latency of all event types from when the event is generated + until the frame containing updates from that event is presented on the + screen. + + This histogram only records metrics on machines with high-resolution clocks. + </summary> +</histogram> + +<histogram name="EventLatency.{EventType}.{Breakdown}" units="microseconds" expires_after="2022-01-16"> <owner>mohsen@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> - Tracks the duration of various stages an event goes through from when it is - generated on the browser side until it ends up generating a frame that is - eventually presented to the user. If the frame is dropped, nothing is - reported. + Tracks {Breakdown} for {EventType}. This histogram only records metrics on machines with high-resolution clocks. </summary> + <token key="EventType" variants="EventLatencyEventType"/> + <token key="Breakdown" variants="EventLatencyBreakdown"/> +</histogram> + +<histogram name="EventLatency.{PinchEventType}.{PinchInputType}.{Breakdown}" + units="microseconds" expires_after="2022-01-16"> + <owner>mohsen@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + Tracks {Breakdown} for {PinchEventType} by {PinchInputType}. + + This histogram only records metrics on machines with high-resolution clocks. + </summary> + <token key="PinchEventType" variants="EventLatencyPinchEventType"/> + <token key="PinchInputType" variants="EventLatencyPinchInputType"/> + <token key="Breakdown" variants="EventLatencyBreakdown"/> +</histogram> + +<histogram name="EventLatency.{ScrollEventType}.{ScrollInputType}.{Breakdown}" + units="microseconds" expires_after="2022-01-16"> + <owner>mohsen@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + Tracks {Breakdown} for {ScrollEventType} by {ScrollInputType}. + + This histogram only records metrics on machines with high-resolution clocks. + </summary> + <token key="ScrollEventType" variants="EventLatencyScrollEventType"/> + <token key="ScrollInputType" variants="EventLatencyScrollInputType"/> + <token key="Breakdown" variants="EventLatencyBreakdown"> + <variant name="TotalLatencyToSwapBegin" + summary="total latency from when the event is generated until the + gpu-swap is started"/> + <variant name="TotalLatencyToSwapEnd" + summary="total latency from when the event is generated until the + gpu-swap is completed"> + <obsolete> + Deprecated as of 07/2020. Replaced with TotalLatencyToSwapBegin variant + which measures what we actually intended to measure. + </obsolete> + </variant> + </token> </histogram> </histograms> diff --git a/chromium/tools/metrics/histograms/metadata/extension/histograms.xml b/chromium/tools/metrics/histograms/metadata/extension/histograms.xml index 7d7353ede0d..db961cf467d 100644 --- a/chromium/tools/metrics/histograms/metadata/extension/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/extension/histograms.xml @@ -53,7 +53,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ExtensionBlacklist.SilentInstall" enum="ExtensionLocation" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ExtensionBlacklist.UnblacklistInstalled" - enum="ExtensionLocation" expires_after="2022-01-30"> + enum="ExtensionLocation" expires_after="2022-04-03"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/extensions/histograms.xml b/chromium/tools/metrics/histograms/metadata/extensions/histograms.xml index dab256be5c4..d8a7bd0b7d1 100644 --- a/chromium/tools/metrics/histograms/metadata/extensions/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/extensions/histograms.xml @@ -330,7 +330,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.BookmarkAppLaunchContainer" - enum="AppLaunchContainer" expires_after="2021-12-12"> + enum="AppLaunchContainer" expires_after="2022-04-10"> <owner>phillis@chromium.org</owner> <owner>benwells@chromium.org</owner> <owner>dominickn@chromium.org</owner> @@ -342,7 +342,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.BookmarkAppLaunchSource" enum="AppLaunchSource" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>phillis@chromium.org</owner> <owner>benwells@chromium.org</owner> <owner>dominickn@chromium.org</owner> @@ -652,6 +652,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="ExtensionsDatabaseOpen"> <variant name=""/> <variant name=".Rules" summary="Rules backing stores"/> + <variant name=".Scripts" summary="Scripts backing stores"/> <variant name=".Settings" summary="Settings backing stores"/> <variant name=".State" summary="State backing stores"/> </token> @@ -678,7 +679,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeContentActionCreated" - enum="DeclarativeContentActionType" expires_after="2021-09-20"> + enum="DeclarativeContentActionType" expires_after="2022-09-20"> <owner>kelvinjiang@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -688,7 +689,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.CreateVerifiedMatcherTime" - units="ms" expires_after="2021-11-14"> + units="ms" expires_after="2022-04-17"> <owner>karandeepb@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -701,7 +702,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.DeclarativeNetRequest.EvaluateBeforeRequestTime.SingleExtension2" - units="microseconds" expires_after="2021-10-10"> + units="microseconds" expires_after="2022-10-01"> <owner>karandeepb@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -714,7 +715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.DeclarativeNetRequest.EvaluateRequestTime.AllExtensions3" - units="microseconds" expires_after="2021-10-10"> + units="microseconds" expires_after="2022-10-01"> <owner>karandeepb@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -727,7 +728,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.IndexAndPersistRulesTime" - units="ms" expires_after="2021-10-25"> + units="ms" expires_after="2022-10-01"> <owner>karandeepb@chromium.org</owner> <owner>lazyboy@chromium.org</owner> <summary> @@ -749,7 +750,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.LoadRulesetResult" - enum="LoadRulesetResult" expires_after="2021-11-14"> + enum="LoadRulesetResult" expires_after="2022-04-24"> <owner>karandeepb@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -759,7 +760,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.ManifestEnabledRulesCount2" - units="rules" expires_after="2021-10-25"> + units="rules" expires_after="2022-10-01"> <owner>karandeepb@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -771,6 +772,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.DeclarativeNetRequest.ManifestRulesCount2" units="rules" expires_after="2022-03-31"> + <obsolete> + Deprecated and removed from code as of 08/2021. + </obsolete> <owner>karandeepb@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -794,7 +798,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.RequestHeaderAdded" - enum="WebRequest.RequestHeader" expires_after="2022-01-02"> + enum="WebRequest.RequestHeader" expires_after="2022-05-01"> <owner>karandeepb@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <owner>kelvinjiang@chromium.org</owner> @@ -806,7 +810,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.RequestHeaderChanged" - enum="WebRequest.RequestHeader" expires_after="2021-12-19"> + enum="WebRequest.RequestHeader" expires_after="2022-05-01"> <owner>karandeepb@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <owner>kelvinjiang@chromium.org</owner> @@ -842,7 +846,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.ResponseHeaderChanged" - enum="WebRequest.ResponseHeader" expires_after="2021-10-31"> + enum="WebRequest.ResponseHeader" expires_after="2022-04-24"> <owner>karandeepb@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <owner>kelvinjiang@chromium.org</owner> @@ -854,7 +858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.ResponseHeaderRemoved" - enum="WebRequest.ResponseHeader" expires_after="2021-12-19"> + enum="WebRequest.ResponseHeader" expires_after="2022-05-01"> <owner>karandeepb@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <owner>kelvinjiang@chromium.org</owner> @@ -878,7 +882,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DeclarativeNetRequest.UpdateDynamicRulesStatus" - enum="UpdateDynamicRulesStatus" expires_after="2021-11-14"> + enum="UpdateDynamicRulesStatus" expires_after="2022-04-24"> <owner>karandeepb@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <summary> @@ -924,7 +928,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DidCreateScriptContext_Blessed" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -947,7 +951,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DidCreateScriptContext_ContentScript" units="ms" - expires_after="2021-12-01"> + expires_after="2022-05-01"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -1015,7 +1019,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DidInitializeServiceWorkerContextOnWorkerThread" - units="ms" expires_after="2021-12-01"> + units="ms" expires_after="2022-04-24"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -1067,7 +1071,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.DisableReason" enum="ExtensionDisableReason" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -1115,9 +1119,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.EsbAllowlistOmahaAttribute" - enum="ExtensionAllowlistOmahaAttributeValue" expires_after="2021-10-01"> + enum="ExtensionAllowlistOmahaAttributeValue" expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Reports the value of the Safe Browsing CRX allowlist custom omaha attribute when an update check occurs for an extension. @@ -1148,7 +1152,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.EventPageIdleTime" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary>The time an extension's event page has spent unloaded.</summary> @@ -1260,7 +1264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ExtensionAddDisabledRemotelyReason2" - enum="ExtensionUpdateCheckDataKey" expires_after="2021-10-10"> + enum="ExtensionUpdateCheckDataKey" expires_after="2022-10-10"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1273,9 +1277,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ExtensionCacheCount" units="units" - expires_after="2021-10-04"> + expires_after="2022-05-01"> <owner>burunduk@chromium.org</owner> - <owner>snijhara@google.com</owner> + <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> <summary> Number of cached extensions on disk. Reported on Chrome OS during user @@ -1284,9 +1288,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ExtensionCacheSize" units="MB" - expires_after="2021-10-04"> + expires_after="2022-05-01"> <owner>burunduk@chromium.org</owner> - <owner>snijhara@google.com</owner> + <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> <summary> Total size of .crx files in cache on disk. Reported on Chrome OS during user @@ -1309,7 +1313,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ExtensionDisabledRemotely2" - enum="ExtensionUpdateCheckDataKey" expires_after="2022-01-02"> + enum="ExtensionUpdateCheckDataKey" expires_after="2022-03-06"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1344,7 +1348,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ExtensionReenabledRemotely" units="count" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1400,7 +1404,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ExtensionUninstalled" units="units" - expires_after="2021-11-14"> + expires_after="2022-05-01"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary>An extension has been uninstalled.</summary> @@ -1487,7 +1491,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledAndBlackListed" units="count" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>managed-devices@google.com</owner> @@ -1500,7 +1504,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.ForceInstalledCacheStatus" enum="ExtensionInstallationDownloadingCacheStatus" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>poromov@chromium.org</owner> @@ -1511,7 +1515,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledCreationStage" - enum="ExtensionInstallCreationStage" expires_after="2021-12-26"> + enum="ExtensionInstallCreationStage" expires_after="2022-04-03"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>managed-devices@google.com</owner> @@ -1526,7 +1530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledDownloadingStage" - enum="ExtensionInstallationDownloadingStage" expires_after="2022-02-06"> + enum="ExtensionInstallationDownloadingStage" expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1542,7 +1546,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.ForceInstalledFailureCacheStatus" enum="ExtensionInstallationDownloadingCacheStatus" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1556,7 +1560,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledFailureCrxInstallError" - enum="ExtensionInstallationCrxInstallError" expires_after="2022-02-06"> + enum="ExtensionInstallationCrxInstallError" expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1569,7 +1573,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledFailureManifestInvalidAppStatusError" - enum="ManifestInvalidAppStatusError" expires_after="2022-01-23"> + enum="ManifestInvalidAppStatusError" expires_after="2022-04-03"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>managed-devices@google.com</owner> @@ -1584,8 +1588,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledFailureNoUpdatesInfo" - enum="ExtensionNoUpdatesInfo" expires_after="2021-12-12"> - <owner>snijhara@google.com</owner> + enum="ExtensionNoUpdatesInfo" expires_after="2022-04-24"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>managed-devices@google.com</owner> @@ -1600,7 +1603,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledFailureReason3" - enum="ExtensionInstallationFailureReason" expires_after="2022-02-06"> + enum="ExtensionInstallationFailureReason" expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="ExtensionSource" --> <owner>burunduk@chromium.org</owner> @@ -1636,7 +1639,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledFailureSandboxUnpackFailureReason2" - enum="ExtensionUnpackFailureReason" expires_after="2022-02-01"> + enum="ExtensionUnpackFailureReason" expires_after="2022-04-03"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1702,7 +1705,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.ForceInstalledFailureStuckInInitialCreationStageAreExtensionsEnabled" - enum="BooleanEnabled" expires_after="2022-02-01"> + enum="BooleanEnabled" expires_after="2022-04-10"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>managed-devices@google.com</owner> @@ -1722,7 +1725,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.ForceInstalledFailureWithCrxHeaderInvalidIsCWS" enum="IsForceInstalledExtensionFailedWithCrxHeaderInvalidFromCWSBoolean" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>managed-devices@google.com</owner> @@ -1736,10 +1739,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.ForceInstalledFailureWithCrxHeaderInvalidIsFromCache" - enum="BooleanCacheHit" expires_after="2022-01-09"> + enum="BooleanCacheHit" expires_after="2022-04-03"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> - <owner>snijhara@google.com</owner> <owner>managed-devices@google.com</owner> <summary> Records whether the extension is downloaded from cache or not. Recorded for @@ -1750,7 +1752,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledLoadTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1761,7 +1763,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledNotLoadedDisableReason" - enum="ExtensionDisableReason" expires_after="2022-02-06"> + enum="ExtensionDisableReason" expires_after="2022-04-10"> <owner>swapnilgupta@google.com</owner> <owner>burunduk@chromium.org</owner> <owner>managed-devices@google.com</owner> @@ -1774,8 +1776,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledReadyTime" units="ms" - expires_after="2021-10-04"> - <owner>snijhara@google.com</owner> + expires_after="2022-02-01"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1787,7 +1788,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.ForceInstalledSessionsWithNonMisconfigurationFailureOccured" - enum="Boolean" expires_after="2022-02-06"> + enum="Boolean" expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1803,7 +1804,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledStage2" - enum="ExtensionInstallationStage" expires_after="2021-10-04"> + enum="ExtensionInstallationStage" expires_after="2022-02-01"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1821,7 +1822,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledTimedOutAndNotInstalledCount" - units="units" expires_after="2022-02-06"> + units="units" expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1832,7 +1833,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledTimedOutCount" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1880,7 +1881,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalledTotalCandidateCount" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1894,7 +1895,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalled{ErrorType}FetchTries" - units="retries" expires_after="2021-10-04"> + units="retries" expires_after="2022-02-01"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1916,7 +1917,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceInstalled{ErrorType}NetworkErrorCode" - enum="NetErrorCodes" expires_after="2021-10-04"> + enum="NetErrorCodes" expires_after="2022-02-01"> <owner>burunduk@chromium.org</owner> <owner>swapnilgupta@google.com</owner> <owner>managed-devices@google.com</owner> @@ -1938,7 +1939,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ForceToolbarPinnedCount" units="extensions" - expires_after="2022-02-06"> + expires_after="2022-04-24"> + <obsolete> + Code removed 2021/10. + </obsolete> <owner>nicolaso@chromium.org</owner> <owner>chrome-enterprise-team-core@google.com</owner> <summary> @@ -1948,6 +1952,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Extensions.ForceToolbarPinnedCount2" units="extensions" + expires_after="2022-04-24"> + <owner>nicolaso@chromium.org</owner> + <owner>chrome-enterprise-team-core@google.com</owner> + <summary> + Number of force installed extensions that are "force-pinned" in + the ExtensionSettings policy. Recorded after policies are parsed, or + refreshed. Only recorded if non-zero. + </summary> +</histogram> + <histogram name="Extensions.FromWebstoreInconsistency" enum="ExtensionFromWebstoreInconcistencyEnum" expires_after="2018-08-30"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> @@ -2018,7 +2033,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.Functions.FailedTotalExecutionTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -2076,7 +2091,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.Functions.SucceededTotalExecutionTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -2089,7 +2104,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.Functions.SynchronousExecutionTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -2128,9 +2143,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.GoogleDocOffline.AvailabilityOnResourceRequest" - enum="GoogleDocsExtensionAvailablity" expires_after="2021-11-21"> + enum="GoogleDocsExtensionAvailablity" expires_after="2022-09-01"> <owner>rhalavati@chromium.org</owner> - <owner>chrome-privacy-core@google.com</owner> + <owner>chrome-incognito@google.com</owner> <summary> This histogram records requests to use resources from Google Docs Offline extension, along with whether the extension has been available or not and @@ -2139,6 +2154,28 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Extensions.Greylist.Disabled" enum="ExtensionLocation" + expires_after="2022-09-07"> + <owner>xinghuilu@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@chromium.org</owner> + <summary> + Emits the Extension::Location of a newly-disabled greylisted extension. + Logged when SafeBrowsingVerdictHandler greylists and disables an installed + extension. + </summary> +</histogram> + +<histogram name="Extensions.Greylist.Enabled" enum="ExtensionLocation" + expires_after="2022-09-07"> + <owner>xinghuilu@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@chromium.org</owner> + <summary> + Emits the Extension::Location of an extension that was ungreylisted. Logged + when SafeBrowsingVerdictHandler ungreylists and enables an installed + extension. + </summary> +</histogram> + <histogram name="Extensions.HasPermissions_AutoDisable3" enum="Boolean" expires_after="2018-08-30"> <obsolete> @@ -2537,9 +2574,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.InstallFrictionDialogAction" - enum="ExtensionInstallFrictionDialogAction" expires_after="2021-10-01"> + enum="ExtensionInstallFrictionDialogAction" expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Action taken in the extension install friction dialog displayed to Enhanced Safe Browsing users before installing an extension that is not included in @@ -2548,7 +2585,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.InstallPrompt.TimeToCancel" units="ms" - expires_after="M95"> + expires_after="2022-09-20"> <owner>kelvinjiang@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -2559,7 +2596,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.InstallPrompt.TimeToInstall" units="ms" - expires_after="M95"> + expires_after="2022-09-20"> <owner>kelvinjiang@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -2570,7 +2607,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.InstallPrompt.Type2" - enum="ExtensionInstallPromptType" expires_after="2021-12-12"> + enum="ExtensionInstallPromptType" expires_after="2022-04-03"> <owner>meacer@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <summary> @@ -2800,14 +2837,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>The number of platform apps loaded at profile open.</summary> </histogram> -<histogram name="Extensions.LoadTheme" units="units" expires_after="2021-12-19"> +<histogram name="Extensions.LoadTheme" units="units" expires_after="2022-04-24"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary>The number of themes loaded at profile open.</summary> </histogram> <histogram name="Extensions.LoadType" enum="ExtensionType" - expires_after="2021-12-05"> + expires_after="2022-04-10"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -2827,6 +2864,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.LockedFullscreenStateRequest" enum="LockedFullscreenState" expires_after="2020-01-01"> + <obsolete> + 2021.09.07 - Removed. + </obsolete> <owner>isandrk@chromium.org</owner> <owner>jhastings@chromium.org</owner> <summary> @@ -2835,6 +2875,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Extensions.Management_Refresh" units="ms" expires_after="M100"> + <owner>jam@chromium.org</owner> + <owner>cduvall@chromium.org</owner> + <summary> + Measures how long ExtensionManagement::Refresh takes. This reloads all + enterprise-related policies for all extensions, and is called both at + startup and any time the enterprise policy changes. + </summary> +</histogram> + <histogram name="Extensions.ManifestFetchFailureRetryCountGoogleUrl" units="units" expires_after="M77"> <owner>Please list the metric's owners. Add more owner tags as needed.</owner> @@ -3068,6 +3118,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.Navigation.Permissions" enum="ExtensionNavigationPermissions" expires_after="M95"> + <obsolete> + 2021.08.30 - Removed. + </obsolete> <owner>dtapuska@chromium.org</owner> <owner>kouhei@chromium.org</owner> <summary> @@ -3100,7 +3153,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.NewTabPageOverrides" units="units" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>rdevlin.cronin@chromium.org</owner> <owner>kelvinjiang@chromium.org</owner> <summary> @@ -3129,9 +3182,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.NotAllowlistedDisabled" units="extensions" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> The total number of disabled extensions that are not present in the Enhanced Safe Browsing CRX allowlist. Recorded for all users on profile @@ -3140,9 +3193,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.NotAllowlistedDisabledAndEsbUser" - units="extensions" expires_after="2021-10-01"> + units="extensions" expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> The total number of disabled extensions that are not present in the Enhanced Safe Browsing CRX allowlist. Recorded for only for Enhanced Safe Browsing @@ -3151,9 +3204,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.NotAllowlistedEnabled" units="extensions" - expires_after="2021-12-05"> + expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> The total number of enabled extensions that are not present in the Enhanced Safe Browsing CRX allowlist. Recorded for all users on profile @@ -3162,9 +3215,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.NotAllowlistedEnabledAndEsbUser" units="extensions" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> The total number of enabled extensions that are not present in the Enhanced Safe Browsing CRX allowlist. Recorded for only for Enhanced Safe Browsing @@ -3399,7 +3452,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ProcessManagerStartupHostsTime2" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -3527,7 +3580,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.SearchEngineOverrides" units="units" - expires_after="2021-10-04"> + expires_after="2022-10-04"> <owner>rdevlin.cronin@chromium.org</owner> <owner>kelvinjiang@chromium.org</owner> <summary> @@ -3537,7 +3590,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ServiceWorkerBackground.RegistrationStatus" - enum="Boolean" expires_after="2021-10-01"> + enum="Boolean" expires_after="2022-10-01"> <owner>lazyboy@chromium.org</owner> <owner>dbertoni@chromium.org</owner> <summary> @@ -3546,7 +3599,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ServiceWorkerBackground.RegistrationTime" - units="ms" expires_after="2021-10-01"> + units="ms" expires_after="2022-10-01"> <owner>lazyboy@chromium.org</owner> <owner>dbertoni@chromium.org</owner> <summary> @@ -3555,7 +3608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ServiceWorkerBackground.StartWorkerStatus" - enum="Boolean" expires_after="2021-10-01"> + enum="Boolean" expires_after="2022-10-01"> <owner>lazyboy@chromium.org</owner> <owner>dbertoni@chromium.org</owner> <summary> @@ -3564,7 +3617,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.ServiceWorkerBackground.StartWorkerTime" units="ms" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>lazyboy@chromium.org</owner> <owner>dbertoni@chromium.org</owner> <summary> @@ -3642,7 +3695,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.StartupPagesOverrides" units="units" - expires_after="2021-10-10"> + expires_after="2022-10-10"> <owner>rdevlin.cronin@chromium.org</owner> <owner>kelvinjiang@chromium.org</owner> <summary> @@ -3673,7 +3726,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.Toolbar.InvocationSource" - enum="ExtensionActionInvocationSource" expires_after="2022-01-02"> + enum="ExtensionActionInvocationSource" expires_after="2022-05-01"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -3844,7 +3897,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.WebRequest.KeepaliveRequestState" - enum="ExtensionInProgressRequestState" expires_after="2022-01-02"> + enum="ExtensionInProgressRequestState" expires_after="2022-04-24"> <owner>yhirano@chromium.org</owner> <owner>kinuko@chromium.org</owner> <summary> @@ -4074,9 +4127,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Extensions.WebStoreInstall.EsbAllowlistParameter" - enum="WebStoreInstallAllowlistParameter" expires_after="2021-10-01"> + enum="WebStoreInstallAllowlistParameter" expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Reports the Safe Browsing CRX allowlist state received from Chrome Web Store when a user presses on "Add to Chrome" in Chrome Web Store. @@ -4085,9 +4138,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.WebStoreInstall.NotAllowlistedInstalledWithFriction" - enum="Boolean" expires_after="2021-10-01"> + enum="Boolean" expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Reports when a user with install friction dialog enabled tries to install an extension that is not included in the Safe Browsing CRX allowlist. 'True' if @@ -4098,9 +4151,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Extensions.WebStoreInstall.NotAllowlistedInstalledWithoutFriction" - enum="Boolean" expires_after="2021-10-01"> + enum="Boolean" expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> - <owner>lucferron@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Reports when a user with install friction dialog disabled tries to install an extension that is not included in the Safe Browsing CRX allowlist. 'True' diff --git a/chromium/tools/metrics/histograms/metadata/feature_engagement/histograms.xml b/chromium/tools/metrics/histograms/metadata/feature_engagement/histograms.xml index 605ecbab0ed..4b70a7a1861 100644 --- a/chromium/tools/metrics/histograms/metadata/feature_engagement/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/feature_engagement/histograms.xml @@ -39,6 +39,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="IPH_AddToHomescreenTextBubble" summary="educating users about adding website shortcuts to their home screen (using a text bubble)"/> + <variant name="IPH_AutoDarkOptOut" + summary="educating users about disabling auto dark feature globally"/> + <variant name="IPH_AutoDarkUserEducationMessage" + summary="message educating users about adding disabling auto dark web + contents feature globally"/> <variant name="IPH_BadgedReadingList" summary="badged reading list"/> <variant name="IPH_Bookmark" summary="bookmark"/> <variant name="IPH_BottomToolbarTip" summary="bottom toolbar"/> @@ -123,6 +128,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="IPH_FeedHeaderMenu" summary="feed header menu on NTP"/> <variant name="IPH_FeedSwipeRefresh" summary="swipe refreshing feeds on NTP"/> <variant name="IPH_GlobalMediaControls" summary="the Global Media Controls"/> + <variant name="IPH_GMCCastStartStop" + summary="Cast start stop in the Zenith dialog"/> <variant name="IPH_HomePageButton" summary="home page button"> <obsolete> This feature was deprecated in M79 @@ -141,6 +148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variant> <variant name="IPH_IdentityDisc" summary="Identity Disc"/> <variant name="IPH_IncognitoWindow" summary="incognito window"/> + <variant name="IPH_InstanceSwitcher" summary="instance switcher"/> <variant name="IPH_KeyboardAccessoryAddressFilling" summary="address autofill suggestions"/> <variant name="IPH_KeyboardAccessoryPasswordFilling" @@ -164,6 +172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="IPH_NewTabPageHomeButton" summary="new tab page button"/> <variant name="IPH_NewTabTip" summary="new tab tip"/> <variant name="IPH_PageInfo" summary="opening PageInfo"/> + <variant name="IPH_PageInfoStoreInfo" summary="PageInfoStoreInfo feature"/> <variant name="IPH_PasswordsAccountStorage" summary="passwords account storage"/> <variant name="IPH_PreviewsOmniboxUI" @@ -192,6 +201,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="IPH_SharedHighlightingBuilder" summary="the in product help message to notify the user that the share action can preemptively share a link-to-text"/> + <variant name="IPH_SharedHighlightingReceiver" + summary="the in product help message encouraging users to create + highlights"/> + <variant name="IPH_SharingHubLinkToggle" + summary="turning on link sharing in the Sharing Hub"/> + <variant name="IPH_SideSearch" summary="side search discovery"/> <variant name="IPH_StartSurfaceTabSwitcherHomeButton" summary="home button on the tab switcher when start surface is enabled"/> <variant name="IPH_TabGroupsDragAndDrop" @@ -216,6 +231,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. summary="Video tutorial summary card on NTP"/> <variant name="IPH_VideoTutorial_NTP_VoiceSearch" summary="Video tutorial card on NTP about voice search in chrome"/> + <variant name="IPH_VideoTutorial_TryNow" + summary="Video tutorial Try Now feature"/> <variant name="IPH_WebFeedFollow" summary="proactive Web Feed follow recommendations"/> <variant name="IPH_WebFeedPostFollowDialog" @@ -224,7 +241,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="InProductHelp.Config.ParsingEvent" enum="ConfigParsingEvent" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>nyquist@chromium.org</owner> <owner>xingliu@chromium.org</owner> <summary> @@ -270,7 +287,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InProductHelp.Db.TotalEvents" units="events" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>nyquist@chromium.org</owner> <owner>xingliu@chromium.org</owner> <summary> @@ -373,6 +390,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="IPHFeature" variants="IPHFeature"/> </histogram> +<histogram name="InProductHelp.TextBubble.ShownTime" units="ms" + expires_after="2022-10-01"> + <owner>haileywang@chromium.org</owner> + <owner>shaktisahu@chromium.org</owner> + <summary> + The time duration for which the in-product help bubble is shown. + </summary> +</histogram> + </histograms> </histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/file/histograms.xml b/chromium/tools/metrics/histograms/metadata/file/histograms.xml index 1f0ca13a9c6..13471bc4bcb 100644 --- a/chromium/tools/metrics/histograms/metadata/file/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/file/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="FileBrowser.ChangeDirectory.RootType" - enum="FileManagerRootType" expires_after="M98"> + enum="FileManagerRootType" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ComputersCount" units="Computers" - expires_after="M98"> + expires_after="2022-05-01"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -43,7 +43,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="FileBrowser.Create" enum="FileDialogType" expires_after="M98"> +<histogram name="FileBrowser.Create" enum="FileDialogType" + expires_after="2022-04-03"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -51,7 +52,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="FileBrowser.DirectoryScan" units="ms" expires_after="M98"> +<histogram name="FileBrowser.DirectoryScan" units="ms" + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -71,7 +73,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.DownloadDestination.IsGoogleDrive.Started" - enum="BooleanEnabled" expires_after="M98"> + enum="BooleanEnabled" expires_after="2022-04-03"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -81,7 +83,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Downloads.DirectoryPercentageOfDiskUsage" - units="%" expires_after="M98"> + units="%" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -92,7 +94,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Downloads.DirectorySizeMiB" units="MiB" - expires_after="M98"> + expires_after="2022-04-17"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -102,7 +104,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="FileBrowser.DownloadsCount" units="units" expires_after="M98"> +<histogram name="FileBrowser.DownloadsCount" units="units" + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -113,7 +116,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.DriveDuplicateFinder.LongComputeHash" units="ms" - expires_after="M98"> + expires_after="2022-04-24"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -123,7 +126,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.DriveDuplicateFinder.LongSearchByHash" units="ms" - expires_after="M98"> + expires_after="2022-05-01"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -133,21 +136,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.DriveHostedFilePinSuccess" enum="BooleanSuccess" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>austinct@chromium.org</owner> <owner>dats@chromium.org</owner> <summary>Tracks success rate of pinning hosted files in Drive.</summary> </histogram> <histogram name="FileBrowser.DrivePinSuccess" enum="BooleanSuccess" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>austinct@chromium.org</owner> <owner>dats@chromium.org</owner> <summary>Tracks success rate of pinning files in Drive.</summary> </histogram> <histogram name="FileBrowser.FileSystemProviderMounted" - enum="FileSystemProviderMountType" expires_after="M98"> + enum="FileSystemProviderMountType" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -167,7 +170,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.FolderShortcut.Count" units="units" - expires_after="M98"> + expires_after="2022-05-01"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -197,7 +200,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.FormatFileSystemType" - enum="FileManagerFormatFileSystemType" expires_after="M98"> + enum="FileManagerFormatFileSystemType" expires_after="2022-04-10"> <owner>austinct@chromium.org</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -208,7 +211,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="FileBrowser.HoldingSpace.TimeFromFirstWelcomeBannerShowToFirstPin" - units="ms" expires_after="2022-01-05"> + units="ms" expires_after="2022-04-10"> <owner>dmblack@google.com</owner> <owner>tbarzic@chromium.org</owner> <summary> @@ -337,7 +340,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Location.OnEntryExpandedOrCollapsed.TopLevel" - enum="FileManagerRootType" expires_after="M98"> + enum="FileManagerRootType" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -359,7 +362,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Location.OnEntrySelected.TopLevel" - enum="FileManagerRootType" expires_after="M98"> + enum="FileManagerRootType" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -370,7 +373,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.MediaImport.Cancelled" enum="BooleanCanceled" - expires_after="M98"> + expires_after="2022-04-24"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -390,7 +393,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.MediaImport.ErrorCount" units="count" - expires_after="2021-11-21"> + expires_after="2022-04-24"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -399,7 +402,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.MediaImport.ImportCount" units="count" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -409,7 +412,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.MediaImport.ImportMB" units="MBytes" - expires_after="2021-11-21"> + expires_after="2022-04-24"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -419,7 +422,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.MediaImport.Started" enum="BooleanAttempted" - expires_after="2021-11-21"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -429,7 +432,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.MenuItemSelected" enum="FileManagerMenuCommands" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -438,7 +441,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Notification.Show" - enum="FileManagerNotificationType" expires_after="M98"> + enum="FileManagerNotificationType" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -456,7 +459,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.OpenFiles.RootType" enum="FileManagerRootType" - expires_after="M98"> + expires_after="2022-04-03"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -541,7 +544,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.QuickView.DialogType" enum="FileDialogType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -550,21 +553,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.QuickView.FileType" enum="ViewFileType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary>File types that were tried to be opened with quick view.</summary> </histogram> <histogram name="FileBrowser.QuickView.FileTypeOnLaunch" enum="ViewFileType" - expires_after="M98"> + expires_after="2022-05-01"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary>File types that were selected when quick view is launched.</summary> </histogram> <histogram name="FileBrowser.QuickView.VolumeType" enum="FileManagerVolumeType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary>The volume type where quick view is opened.</summary> @@ -578,7 +581,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Recent.LoadArcMedia" units="ms" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -588,7 +591,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Recent.LoadCrostini" units="ms" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -607,7 +610,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="FileBrowser.Recent.LoadDrive" units="ms" expires_after="M98"> +<histogram name="FileBrowser.Recent.LoadDrive" units="ms" + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -616,7 +620,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="FileBrowser.Recent.LoadTotal" units="ms" expires_after="M98"> +<histogram name="FileBrowser.Recent.LoadTotal" units="ms" + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -626,14 +631,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Share.ActionSource" enum="SharingActionSource" - expires_after="2021-11-05"> + expires_after="2022-04-24"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary>Chrome OS File Browser: the source of file sharing action.</summary> </histogram> <histogram name="FileBrowser.Share.FileCount" units="files" - expires_after="2021-11-05"> + expires_after="2022-04-17"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -643,7 +648,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.Share.FileType" enum="ViewFileType" - expires_after="2021-11-05"> + expires_after="2022-04-24"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -705,7 +710,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.SWA.Create" enum="FileDialogType" - expires_after="M99"> + expires_after="2022-04-17"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -727,7 +732,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ToggleFileListType" enum="FileManagerListType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -747,7 +752,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingFileType.Offline" enum="ViewFileType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -758,7 +763,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingFileType.Online" enum="ViewFileType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -769,7 +774,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingRootType" enum="FileManagerRootType" - expires_after="M98"> + expires_after="2022-04-03"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -779,7 +784,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingRootType.Offline" - enum="FileManagerRootType" expires_after="M98"> + enum="FileManagerRootType" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -790,7 +795,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingRootType.Online" enum="FileManagerRootType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -801,7 +806,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingTaskType" enum="FileManagerTaskType" - expires_after="M98"> + expires_after="2022-04-03"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -811,7 +816,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingTaskType.Offline" - enum="FileManagerTaskType" expires_after="M98"> + enum="FileManagerTaskType" expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -822,7 +827,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.ViewingTaskType.Online" enum="FileManagerTaskType" - expires_after="M98"> + expires_after="2022-04-10"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -833,7 +838,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FileBrowser.VolumeType" enum="FileManagerVolumeType" - expires_after="M98"> + expires_after="2022-04-03"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -928,7 +933,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ZipFileCreator.Result" enum="ZipFileCreator.Result" - expires_after="M100"> + expires_after="2022-04-17"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/fingerprint/histograms.xml b/chromium/tools/metrics/histograms/metadata/fingerprint/histograms.xml index 60ef33a2b5c..fd38fe92b29 100644 --- a/chromium/tools/metrics/histograms/metadata/fingerprint/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/fingerprint/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Fingerprint.Auth.ScanResult" enum="FingerprintScanResult" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>rsorokin@chromium.org</owner> <owner>tomhughes@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -35,7 +35,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Enroll.ScanResult" enum="FingerprintScanResult" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>rsorokin@chromium.org</owner> <owner>tomhughes@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -48,14 +48,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Reset.ResetContextMode" - enum="FingerprintSensorMode" expires_after="2022-01-02"> + enum="FingerprintSensorMode" expires_after="2022-05-01"> <owner>tomhughes@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> <summary>The mode FPMCU was in when we reset context.</summary> </histogram> <histogram name="Fingerprint.SetContext.SetContextMode" - enum="FingerprintSensorMode" expires_after="2022-01-02"> + enum="FingerprintSensorMode" expires_after="2022-05-01"> <owner>hesling@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> <summary>The mode FPMCU was in when we set its context.</summary> @@ -69,7 +69,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.AttemptsCountBeforeSuccess" units="count" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -79,7 +79,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.AuthSuccessful" enum="BooleanSuccess" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -90,7 +90,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.EnrolledFingerCount" units="count" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -98,7 +98,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.Match.Duration.Capture" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -109,7 +109,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.Match.Duration.Matcher" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -119,7 +119,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.Match.Duration.Overall" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -140,7 +140,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.MatchIgnoredDueToPowerButtonPress" - enum="BooleanIgnored" expires_after="2022-01-02"> + enum="BooleanIgnored" expires_after="2022-05-01"> <owner>ravisadineni@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> <summary> @@ -161,7 +161,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.NoMatch.Duration.Capture" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -172,7 +172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.NoMatch.Duration.Matcher" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -182,7 +182,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.NoMatch.Duration.Overall" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -193,7 +193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.ReadPositiveMatchSecret.Success" - enum="BooleanSuccess" expires_after="2022-01-02"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>hesling@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> <summary> @@ -202,7 +202,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.RecordFormatVersion" - enum="FingerprintRecordFormatVersion" expires_after="2022-01-02"> + enum="FingerprintRecordFormatVersion" expires_after="2022-05-01"> <owner>hesling@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> <summary> @@ -211,7 +211,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Unlock.Result" enum="FingerprintUnlockResult" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>rsorokin@chromium.org</owner> <owner>tomhughes@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -223,7 +223,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.UnlockEnabled" enum="BooleanEnabled" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -234,7 +234,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Updater.NoUpdate.Duration.Overall" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>tomhughes@chromium.org</owner> <owner>hesling@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> @@ -245,7 +245,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Updater.Reason" enum="FingerprintUpdaterReason" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>tomhughes@chromium.org</owner> <owner>hesling@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> @@ -255,7 +255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Updater.Status" enum="FingerprintUpdaterStatus" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>tomhughes@chromium.org</owner> <owner>hesling@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> @@ -263,7 +263,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Fingerprint.Updater.Update.Duration.Overall" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>tomhughes@chromium.org</owner> <owner>hesling@chromium.org</owner> <owner>chromeos-fingerprint@google.com</owner> diff --git a/chromium/tools/metrics/histograms/metadata/gcm/histograms.xml b/chromium/tools/metrics/histograms/metadata/gcm/histograms.xml index 10148af591f..8f100e5947e 100644 --- a/chromium/tools/metrics/histograms/metadata/gcm/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/gcm/histograms.xml @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GCM.CheckinRequestStatus" enum="GCMCheckinRequestStatus" - expires_after="M98"> + expires_after="2022-04-10"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary>Status code of the outcome of a GCM checkin request.</summary> @@ -305,7 +305,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GCM.RegistrationRequestStatus" - enum="GCMRegistrationRequestStatus" expires_after="2022-01-16"> + enum="GCMRegistrationRequestStatus" expires_after="2022-03-20"> <owner>peter@chromium.org</owner> <summary> Status code of the outcome of a GCM registration request. The Unknown error @@ -390,7 +390,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GCM.SendWebPushMessageResult" enum="SendWebPushMessageResult" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -421,9 +421,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="GCM.StoreSizeKB" units="KB" expires_after="2018-08-30"> - <owner>zea@chromium.org</owner> - <summary>Size of the GCM persistent store in kilobytes at startup.</summary> +<histogram name="GCM.StoreSizeKB" units="KB" expires_after="2022-01-16"> + <owner>peter@chromium.org</owner> + <owner>rayankans@chromium.org</owner> + <summary> + Size of the GCM persistent store in kilobytes at startup. Warning: this + histogram was expired from 2018-08-30 to 2021-09-20; data may be missing. + </summary> </histogram> <histogram name="GCM.StoreUpdateSucceeded" enum="BooleanSuccess" diff --git a/chromium/tools/metrics/histograms/metadata/geolocation/histograms.xml b/chromium/tools/metrics/histograms/metadata/geolocation/histograms.xml index 87ce05bc9a9..4af7f95ad38 100644 --- a/chromium/tools/metrics/histograms/metadata/geolocation/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/geolocation/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Geolocation.AuthorizationActionExistingUser" - enum="GeolocationAuthorizationAction" expires_after="2021-12-19"> + enum="GeolocationAuthorizationAction" expires_after="2022-04-10"> <owner>mattreynolds@chromium.org</owner> <owner>device-dev@chromium.org</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Geolocation.AuthorizationActionNewUser" - enum="GeolocationAuthorizationAction" expires_after="2021-12-12"> + enum="GeolocationAuthorizationAction" expires_after="2022-04-10"> <owner>mattreynolds@chromium.org</owner> <owner>device-dev@chromium.org</owner> <summary> @@ -86,7 +86,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Geolocation.LocationUpdate.ErrorCode" - enum="GeopositionErrorCode" expires_after="2022-01-23"> + enum="GeopositionErrorCode" expires_after="2022-04-17"> <owner>mattreynolds@chromium.org</owner> <owner>device-dev@chromium.org</owner> <summary>Error code for the geoposition sent to the renderers.</summary> @@ -227,7 +227,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GeolocationDisclosure.InfoBarVisibleTime" units="ms" - expires_after="M100"> + expires_after="2022-04-17"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -236,7 +236,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GeolocationDisclosure.PostDisclosureDSESetting" - enum="BooleanAllowed" expires_after="M100"> + enum="BooleanAllowed" expires_after="2022-04-24"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -247,7 +247,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GeolocationDisclosure.PreDisclosureDSESetting" - enum="BooleanAllowed" expires_after="M100"> + enum="BooleanAllowed" expires_after="2022-04-24"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/google/histograms.xml b/chromium/tools/metrics/histograms/metadata/google/histograms.xml index a1cd888bdbb..b59e3751590 100644 --- a/chromium/tools/metrics/histograms/metadata/google/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/google/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="GoogleUpdate.ErrorHresult" enum="Hresult" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>grt@chromium.org</owner> <owner>ydago@chromium.org</owner> <summary>The HRESULT for a failed on-demand update check.</summary> @@ -217,14 +217,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GoogleUpdate.UpdateErrorCode" enum="GoogleUpdateErrorCode" - expires_after="2021-12-31"> + expires_after="2022-03-06"> <owner>grt@chromium.org</owner> <owner>ydago@chromium.org</owner> <summary>The error code for a failed on-demand update check.</summary> </histogram> <histogram name="GoogleUpdate.UpgradeResult" enum="GoogleUpdateUpgradeStatus" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>grt@chromium.org</owner> <owner>ydago@chromium.org</owner> <summary>The result of an on-demand update check.</summary> diff --git a/chromium/tools/metrics/histograms/metadata/gpu/histograms.xml b/chromium/tools/metrics/histograms/metadata/gpu/histograms.xml index ce7f96ea236..8a556e2de04 100644 --- a/chromium/tools/metrics/histograms/metadata/gpu/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/gpu/histograms.xml @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ANGLE.D3D11CreateDeviceError" enum="Hresult" - expires_after="2021-06-30"> + expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -54,7 +54,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ANGLE.D3D11FeatureLevel" enum="D3DFeatureLevel" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -79,7 +79,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ANGLE.D3D9InitializeResult" enum="D3D9InitializeResult" - expires_after="2021-10-31"> + expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -89,7 +89,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="GPU.ANGLE.D3DCompileMS" units="ms" expires_after="2021-06-30"> +<histogram name="GPU.ANGLE.D3DCompileMS" units="ms" expires_after="2022-04-17"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -100,7 +100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ANGLE.DisplayInitializeMS" units="ms" - expires_after="2021-06-30"> + expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -147,7 +147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ANGLE.ProgramCache.LoadBinarySuccess" - enum="BooleanSuccess" expires_after="2021-08-29"> + enum="BooleanSuccess" expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -158,7 +158,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ANGLE.ProgramCache.ProgramBinarySizeBytes" units="bytes" - expires_after="2021-06-30"> + expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -168,7 +168,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ANGLE.SupportsDXGI1_2" enum="BooleanSupported" - expires_after="2021-06-30"> + expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -262,7 +262,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.BlocklistFeatureTestResults" - enum="GPUBlocklistFeatureTestResults" expires_after="2021-12-01"> + enum="GPUBlocklistFeatureTestResults" expires_after="2022-04-24"> <owner>vmiura@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -272,7 +272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.BlocklistTestResultsPerEntry" - enum="GPUBlocklistTestResultPerEntry" expires_after="2021-12-01"> + enum="GPUBlocklistTestResultPerEntry" expires_after="2022-05-01"> <owner>vmiura@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -308,7 +308,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ContextLost" enum="ContextLostReason" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>sievers@chromium.org</owner> <summary> The reason a GPU command buffer context of a given type was lost. @@ -338,7 +338,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.D3D11FeatureLevel" enum="D3D11FeatureLevel" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>sadrul@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -348,7 +348,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.D3D12FeatureLevel" enum="D3D12FeatureLevel" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -358,7 +358,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.D3D12HighestShaderModel" enum="D3DShaderModel" - expires_after="2022-01-07"> + expires_after="2022-04-03"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -368,7 +368,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.D3DShaderModel" enum="ShaderModel" - expires_after="2021-08-29"> + expires_after="2022-04-10"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -443,7 +443,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.CreateSwapChainForComposition" - enum="Hresult" expires_after="2021-10-04"> + enum="Hresult" expires_after="2022-10-01"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -465,7 +465,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.DCLayer.YUVOverlayCount" - units="overlays" expires_after="2021-12-12"> + units="overlays" expires_after="2022-04-24"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -486,7 +486,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.DCLayerResult.Texture" - enum="DCLayerResult" expires_after="2021-12-12"> + enum="DCLayerResult" expires_after="2022-05-01"> <owner>sunnyps@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -496,7 +496,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="GPU.DirectComposition.DCLayerResult.Video" - enum="DCLayerResult" expires_after="2022-02-01"> + enum="DCLayerResult" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="GPU.ProtectedVideoType" --> <owner>magchen@chromium.org</owner> @@ -508,7 +508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.DcompDeviceCreateSurface" enum="Hresult" - expires_after="2021-10-04"> + expires_after="2022-10-01"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -549,7 +549,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.HardwareOverlaysSupported" - enum="BooleanOverlaySupported" expires_after="2021-10-01"> + enum="BooleanOverlaySupported" expires_after="2022-10-01"> <owner>magchen@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -559,7 +559,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.IsUnderlay" enum="BooleanUnderlay" - expires_after="2022-01-30"> + expires_after="2022-05-01"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -579,7 +579,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.OverlayFormatUsed3" enum="DXGI_FORMAT" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>sunnyps@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -621,7 +621,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="GPU.DirectComposition.SwapChainCreationResult3" - enum="Hresult" expires_after="2021-10-04"> + enum="Hresult" expires_after="2022-10-01"> <!-- Name completed by histogram_suffixes name="GPU.ProtectedVideoType" --> <owner>magchen@chromium.org</owner> @@ -681,7 +681,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.DirectComposition.VideoPresentationMode" - enum="DirectCompositionVideoPresentationMode" expires_after="2022-01-02"> + enum="DirectCompositionVideoPresentationMode" expires_after="2022-03-06"> <owner>sunnyps@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -689,7 +689,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="GPU.DoLinkProgramTime" units="ms" expires_after="2021-06-30"> +<histogram name="GPU.DoLinkProgramTime" units="ms" expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -714,7 +714,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.EGLDisplayType" enum="EGLDisplayType" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>zmo@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary>The display type used to ask for an EGLDisplay.</summary> @@ -768,8 +768,43 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Gpu.GL.GetErrorDuration.GLImageEGL.BindTexImage" + units="microseconds" expires_after="2022-03-31"> + <owner>berlu@chromium.org</owner> + <owner>chromeos-gfx-compositor@google.com</owner> + <summary> + The time that elapsed for a call to glGetError to complete while trying to + bind a GLImageEGL to a texture. The goal is to measure the impact of the + potential sync barrier that glGetError represents. Only reported for + platforms supporting high resolution clocks. + </summary> +</histogram> + +<histogram name="Gpu.GL.GetErrorResult.GLImageEGL.BindTexImage" + enum="BooleanError" expires_after="2022-03-31"> + <owner>berlu@chromium.org</owner> + <owner>chromeos-gfx-compositor@google.com</owner> + <summary> + Whether glGetError actually returned an error while trying to bind a + GLImageEGL to a texture. The goal is to evaluate how often the call to + glGetError might actually serve its purpose. + </summary> +</histogram> + +<histogram name="Gpu.GL.ProgramBuildTime" units="ms" expires_after="M82"> + <owner>ccameron@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + The time that elapsed between a call to glCreateProgram and the call to + query GL_LINK_STATUS via glGetProgramiv in Skia's GrGLInterface. This + encompasses the creation of the vertex, fragment, and geometry shaders, + their compilation, and their linking. This is called for every program + created by Skia via the GrGLInterface. + </summary> +</histogram> + <histogram name="GPU.GLImplementation" enum="GLImplementation" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -823,7 +858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="GPU.GpuCount" units="gpus" expires_after="2022-01-30"> +<histogram name="GPU.GpuCount" units="gpus" expires_after="2022-04-03"> <owner>zmo@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -847,7 +882,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.GPUInitializationTime.V3" units="ms" - expires_after="2021-12-15"> + expires_after="2022-04-10"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -866,7 +901,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.GPUProcessExitCode" enum="GPUProcessExitCode" - expires_after="2022-01-30"> + expires_after="2022-04-24"> <owner>zmo@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -884,7 +919,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.GPUProcessLaunchTime" units="ms" - expires_after="2022-01-16"> + expires_after="2022-04-10"> <owner>vmiura@chromium.org</owner> <summary> Startup time of the GPU process as measured by the GPU process host. @@ -905,7 +940,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.GPUProcessTerminationStatus2" enum="GpuTerminationStatus" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vmiura@chromium.org</owner> <summary> Counts for each time the GPU Process Host detects the process dies. @@ -923,7 +958,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.HasDiscreteGpu" enum="HasDiscreteGpu" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>sadrul@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -933,7 +968,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.InitializeOneOffMediumTime" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -943,7 +978,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.IntelGpuGeneration" enum="IntelGpuGeneration" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -953,7 +988,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.IntelGpuSeriesType" enum="IntelGpuSeriesType" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>sunnyps@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -972,7 +1007,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.IOSurface.CreateTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>ccameron@chromium.org</owner> <summary> The time that it took for a call to IOSurfaceCreate to complete. @@ -988,13 +1023,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.IOSurface.TexImageTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>ccameron@chromium.org</owner> <summary> The time that it took for a call to CGLTexImageIOSurface2D to complete. </summary> </histogram> +<histogram name="Gpu.Mac.Backpressure" units="ms" expires_after="M80"> + <owner>ccameron@chromium.org</owner> + <owner>khushalsagar@chromium.org</owner> + <summary> + The time that the GPU's main CPU thread spends waiting for previous frames' + GPU work to complete. Recorded at every frame. + </summary> +</histogram> + <histogram name="GPU.MaxMSAASampleCount" units="samples" expires_after="2020-07-06"> <owner>senorblanco@chromium.org</owner> @@ -1004,8 +1048,54 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Gpu.Metal.TestShaderCompileTime" units="ms" + expires_after="M85"> + <owner>ccameron@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + Compiling a MTLLibrary will sometimes hang forever. When initializing the + gpu process, a test shader is compiled to see if the MTLCompilerService is + responding or not. This records the time that it took for the compile to + succeeded, up to 1 minute. After 1 minute, a timeout sentinel value of 3 + minutes is reported. + </summary> +</histogram> + +<histogram name="Gpu.Metal.TestShaderLinkTime" units="ms" expires_after="M85"> + <owner>ccameron@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + Linking a MTLRenderPipelineState will sometimes hang forever. When + initializing the GPU process, a test shader is compiled to see if the + MTLCompilerService is responding or not. This records the time that it took + for the compile to succeeded, up to 1 minute. After 1 minute, a timeout + sentinel value of 3 minutes is reported. + </summary> +</histogram> + +<histogram name="Gpu.MetalProxy.NewLibraryTime" units="ms" expires_after="M82"> + <owner>ccameron@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + The time that it takes to create a new MTLLibrary, including all retries. + Recorded after every call to -[MTLDeviceProxy newLibraryWithSource:] + completes. + </summary> +</histogram> + +<histogram name="Gpu.MetalProxy.NewRenderPipelineStateTime" units="ms" + expires_after="M82"> + <owner>ccameron@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + The time that it takes to create a new MTLRenderPipelineState, including all + retries. Recorded after every call to -[MTLDeviceProxy + newRenderPipelineStateWithDescriptor:] completes. + </summary> +</histogram> + <histogram name="GPU.MultiGpu.AMD" enum="AMDDeviceId" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>zmo@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -1015,7 +1105,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.MultiGpu.Nvidia" enum="NvidiaDeviceId" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>zmo@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -1025,8 +1115,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.OopRaster.GlyphCacheMiss" - enum="OopRasterGlyphCacheMissType" expires_after="2021-12-19"> + enum="OopRasterGlyphCacheMissType" expires_after="M110"> <owner>khushalsagar@chromium.org</owner> + <owner>penghuang@chromium.org</owner> <summary> During OutOfProcess(Oop) raster, the renderer generates and sends the requisite glyph data for rasterizing a tile with the serialized paint @@ -1050,7 +1141,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="GPU.Output.HDR" enum="Boolean" expires_after="2021-12-12"> +<histogram name="GPU.Output.HDR" enum="Boolean" expires_after="2022-04-24"> <owner>hubbe@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1060,8 +1151,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="GPU.PaintOpReader.DeserializationError" + enum="PaintOpDeserializationError" expires_after="2022-09-15"> + <owner>junov@chromium.org</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + Records the reason why the deserialization of a PaintOp failed. Recorded in + PaintOpReader::Read* methods when the decoding a paint op fails. These + failures are typically caused by an invalid or unexpected state or invalid + serialized data. + </summary> +</histogram> + <histogram name="GPU.PassthroughDoLinkProgramTime" units="ms" - expires_after="2021-06-30"> + expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -1072,6 +1175,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="GPU.PreferredGLImplementation" enum="GLImplementation" expires_after="2021-08-01"> + <obsolete> + Removed in M93 + </obsolete> <owner>jonahr@google.com</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -1080,6 +1186,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="GPU.ProcessIntegrityResult" enum="ProcessIntegrityResult" + expires_after="2021-12-12"> + <owner>zmo@chromium.org</owner> + <owner>ssmole@microsoft.com</owner> + <owner>graphics-dev@chromium.org</owner> + <summary> + Summarize the configurations for the integrity level of GPU process, logged + by the Browser process before launching GPU process, used for configuring + the GPU sandbox. + </summary> +</histogram> + <histogram name="GPU.ProcessLifetimeEvents.DisplayCompositor" enum="GPUProcessLifetimeEvent" expires_after="M85"> <owner>vmiura@chromium.org</owner> @@ -1092,7 +1210,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ProcessLifetimeEvents.HardwareAccelerated" - enum="GPUProcessLifetimeEvent" expires_after="2022-01-23"> + enum="GPUProcessLifetimeEvent" expires_after="2022-04-24"> <owner>vmiura@chromium.org</owner> <summary> Recorded once for every GPU process launch and crash when GPU process is @@ -1103,7 +1221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ProcessLifetimeEvents.SwiftShader" - enum="GPUProcessLifetimeEvent" expires_after="2022-01-09"> + enum="GPUProcessLifetimeEvent" expires_after="2022-04-24"> <owner>vmiura@chromium.org</owner> <summary> Recorded once for every GPU process launch and crash when GPU process is @@ -1142,7 +1260,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.ProgramCache.CacheHit" enum="BooleanSuccess" - expires_after="2021-06-30"> + expires_after="2022-01-02"> <owner>jonahr@google.com</owner> <owner>angle-team@google.com</owner> <summary> @@ -1201,6 +1319,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="GPU.RequestedGLImplementation" enum="GLImplementation" expires_after="2021-08-01"> + <obsolete> + Removed in M93 + </obsolete> <owner>jonahr@google.com</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -1220,7 +1341,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.Scheduler.RunTaskTime" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>kylechar@chromium.org</owner> <owner>chrome-gpu-metrics@google.com</owner> <summary> @@ -1287,7 +1408,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.SharedImage.ContentConsumed" enum="BooleanMatched" - expires_after="2022-01-01"> + expires_after="2022-04-17"> <owner>penghuang@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -1308,7 +1429,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.SoftwareRendering" enum="BooleanSoftwareRendering" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>sadrul@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -1330,7 +1451,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.SupportsDX12" enum="BooleanSupported" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -1349,7 +1470,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.SwapTimeUs" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>vasilyt@chromium.org</owner> <owner>backer@chromium.org</owner> <summary> @@ -1436,7 +1557,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.Vulkan.PipelineCache.LoadCacheHit" enum="BooleanCacheHit" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>backer@chromium.org</owner> <owner>penghuang@chromium.org</owner> <owner>vasilyt@chromium.org</owner> @@ -1459,7 +1580,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.Vulkan.PipelineCache.Size" units="KB" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>backer@chromium.org</owner> <owner>penghuang@chromium.org</owner> <owner>vasilyt@chromium.org</owner> @@ -1471,7 +1592,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.Vulkan.PipelineCache.StoreDuration" units="microseconds" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>backer@chromium.org</owner> <owner>penghuang@chromium.org</owner> <owner>vasilyt@chromium.org</owner> @@ -1483,7 +1604,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.Vulkan.PipelineCache.vkCreateGraphicsPipelines" - units="microseconds" expires_after="2022-01-02"> + units="microseconds" expires_after="2022-03-06"> <owner>backer@chromium.org</owner> <owner>penghuang@chromium.org</owner> <owner>vasilyt@chromium.org</owner> @@ -1519,7 +1640,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.WatchdogThread.Event" enum="GpuWatchdogThreadEvent" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -1529,7 +1650,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.WatchdogThread.ExtraThreadTime" units="# timeouts" - expires_after="2021-10-04"> + expires_after="2021-09-01"> + <obsolete> + Removed 08/2021. + </obsolete> <!-- Name completed by histogram_suffixes name="GPU.WatchdogStage" --> <owner>magchen@chromium.org</owner> @@ -1541,7 +1665,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.WatchdogThread.ExtraThreadTime.NumOfUsers" - units="# timeouts" expires_after="2021-10-04"> + units="# timeouts" expires_after="2021-09-01"> + <obsolete> + Removed 08/2021. + </obsolete> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -1553,7 +1680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GPU.WatchdogThread.Timeout" enum="GpuWatchdogTimeoutEvent" - expires_after="2021-11-21"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="GPU.WatchdogStage" --> <owner>magchen@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/hang_watcher/histograms.xml b/chromium/tools/metrics/histograms/metadata/hang_watcher/histograms.xml index 5796fe1201d..3c6857a475d 100644 --- a/chromium/tools/metrics/histograms/metadata/hang_watcher/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/hang_watcher/histograms.xml @@ -33,7 +33,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="HangWatcher.IsThreadHung.{ProcessType}.{ThreadType}" - enum="BooleanHung" expires_after="2021-10-23"> + enum="BooleanHung" expires_after="2022-10-23"> <owner>olivierli@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/histogram_suffixes_list.xml b/chromium/tools/metrics/histograms/metadata/histogram_suffixes_list.xml index 3cfa4fb9a1d..57dbdd6aa80 100644 --- a/chromium/tools/metrics/histograms/metadata/histogram_suffixes_list.xml +++ b/chromium/tools/metrics/histograms/metadata/histogram_suffixes_list.xml @@ -1065,6 +1065,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram_suffixes name="AutofillSaveCreditCardPromptPreviousUserDecision" separator="."> + <obsolete> + Removed 2021/09. + </obsolete> <suffix name="NoPreviousDecision" label="User previous decision not on record"/> <suffix name="PreviouslyAccepted" @@ -5354,241 +5357,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <affected-histogram name="Enterprise.ResourceCacheTiming"/> </histogram_suffixes> -<histogram_suffixes name="EventLatencyBreakdowns" separator="."> - <suffix name="Activation" label="The duration of the activation stage."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="BeginImplFrameToSendBeginMainFrame" - label="The time from when the compositor impl frame is started to when - BeginMainFrame is sent."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="BrowserToRendererCompositor" - label="The time from when the event is generated until the first - compositor stage after the event arrives in the renderer."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="Commit" label="The duration of the commit stage."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="EndActivateToSubmitCompositorFrame" - label="The time from when an activation is complete to the next - SubmitCompositorFrame."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="EndCommitToActivation" - label="The time from when a commit is complete to the beginning of the - next activation."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit" - label="The time from when the BeginMainFrame is sent to the beginning of - the commit."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.Animate" - label="The time portion of SendBeginMainFrameToCommit spent on - animations."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.BeginMainSentToStarted" - label="The time portion of SendBeginMainFrameToCommit spent before - starting main thread work."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.Composite" - label="The time portion of SendBeginMainFrameToCommit spent on - compositing."> - <obsolete> - Obsolete as of https://crrev.com/794384 and M86. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.CompositeCommit" - label="The time portion of SendBeginMainFrameToCommit spent on composite - commit."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.CompositingAssignments" - label="The time portion of SendBeginMainFrameToCommit spent on updating - compositing assignments."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.CompositingInputs" - label="The time portion of SendBeginMainFrameToCommit spent on updating - compositing inputs."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.HandleInputEvents" - label="The time portion of SendBeginMainFrameToCommit spent on handling - imput events."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.LayoutUpdate" - label="The time portion of SendBeginMainFrameToCommit spent on layout - update."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.Paint" - label="The time portion of SendBeginMainFrameToCommit spent on paint."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.Prepaint" - label="The time portion of SendBeginMainFrameToCommit spent on prepaint."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.ScrollingCoordinator" - label="The time portion of SendBeginMainFrameToCommit spent on scrolling - coordinator."> - <obsolete> - Merged into SendBeginMainFrameToCommit.CompositeCommit in - https://crrev.com/815947 in M88. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.StyleUpdate" - label="The time portion of SendBeginMainFrameToCommit spent on style - update."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SendBeginMainFrameToCommit.UpdateLayers" - label="The time portion of SendBeginMainFrameToCommit spent on updating - layers."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="SubmitCompositorFrameToPresentationCompositorFrame" - label="The time from when the compositor frame is submitted to the - display compositor to when it is presented."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix - name="SubmitCompositorFrameToPresentationCompositorFrame.ReceivedCompositorFrameToStartDraw" - label="The time from when the compositor frame is received to when it - starts to draw."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix - name="SubmitCompositorFrameToPresentationCompositorFrame.StartDrawToSwapStart" - label="The time from when the compositor frame is started to draw to - when it starts swap."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix - name="SubmitCompositorFrameToPresentationCompositorFrame.SubmitToReceiveCompositorFrame" - label="The time from when the compositor frame is submitted to when it - is received."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix - name="SubmitCompositorFrameToPresentationCompositorFrame.SwapEndToPresentationCompositorFrame" - label="The time from when the compositor frame ends swap to when it is - presented."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix - name="SubmitCompositorFrameToPresentationCompositorFrame.SwapStartToSwapEnd" - label="The time from when the compositor frame starts to swap to when it - ends swap."> - <obsolete> - Obsolete as of M90. Breakdowns are being tracked in UKM. - </obsolete> - </suffix> - <suffix name="TotalLatency" - label="Total latency from when the event is generated until the frame - is presented on screen."/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Autoscroll"/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Scrollbar"/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Touchscreen"/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Wheel"/> - <affected-histogram name="EventLatency.GestureDoubleTap"/> - <affected-histogram name="EventLatency.GestureLongPress"/> - <affected-histogram name="EventLatency.GestureLongTap"/> - <affected-histogram name="EventLatency.GesturePinchBegin.Touchscreen"/> - <affected-histogram name="EventLatency.GesturePinchBegin.Wheel"/> - <affected-histogram name="EventLatency.GesturePinchEnd.Touchscreen"/> - <affected-histogram name="EventLatency.GesturePinchEnd.Wheel"/> - <affected-histogram name="EventLatency.GesturePinchUpdate.Touchscreen"/> - <affected-histogram name="EventLatency.GesturePinchUpdate.Wheel"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Autoscroll"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Scrollbar"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Touchscreen"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Wheel"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Autoscroll"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Scrollbar"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Touchscreen"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Wheel"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Autoscroll"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Scrollbar"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Touchscreen"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Wheel"/> - <affected-histogram name="EventLatency.GestureShowPress"/> - <affected-histogram name="EventLatency.GestureTap"/> - <affected-histogram name="EventLatency.GestureTapCancel"/> - <affected-histogram name="EventLatency.GestureTapDown"/> - <affected-histogram name="EventLatency.GestureTapUnconfirmed"/> - <affected-histogram name="EventLatency.GestureTwoFingerTap"/> - <affected-histogram - name="EventLatency.InertialGestureScrollUpdate.Autoscroll"/> - <affected-histogram - name="EventLatency.InertialGestureScrollUpdate.Scrollbar"/> - <affected-histogram - name="EventLatency.InertialGestureScrollUpdate.Touchscreen"/> - <affected-histogram name="EventLatency.InertialGestureScrollUpdate.Wheel"/> - <affected-histogram name="EventLatency.KeyPressed"/> - <affected-histogram name="EventLatency.KeyReleased"/> - <affected-histogram name="EventLatency.MouseDragged"/> - <affected-histogram name="EventLatency.MousePressed"/> - <affected-histogram name="EventLatency.MouseReleased"/> - <affected-histogram name="EventLatency.MouseWheel"/> - <affected-histogram name="EventLatency.TouchMoved"/> - <affected-histogram name="EventLatency.TouchPressed"/> - <affected-histogram name="EventLatency.TouchReleased"/> -</histogram_suffixes> - <histogram_suffixes name="EventLatencyOS" separator="."> <suffix name="KEY_PRESSED" label=""/> <suffix name="MOUSE_PRESSED" label=""/> @@ -5617,135 +5385,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </affected-histogram> </histogram_suffixes> -<histogram_suffixes name="EventLatencyPinchTypes" separator="."> - <suffix base="true" name="Touchscreen" - label="Event latency for touchscreen pinch events."/> - <suffix base="true" name="Wheel" - label="Event latency for touchpad pinch events."/> - <affected-histogram name="EventLatency.GesturePinchBegin"/> - <affected-histogram name="EventLatency.GesturePinchEnd"/> - <affected-histogram name="EventLatency.GesturePinchUpdate"/> -</histogram_suffixes> - -<histogram_suffixes name="EventLatencyScrollBreakdowns" separator="."> - <suffix name="TotalLatencyToSwapBegin" - label="Total latency from when the event is generated until the - gpu-swap is started."/> - <suffix name="TotalLatencyToSwapEnd" - label="Total latency from when the event is generated until the gpu-swap - is completed."> - <obsolete> - Deprecated as of 07/2020. Replaced with TotalLatencyToSwapBegin suffix - which measures what we actually intended to measure. - </obsolete> - </suffix> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Autoscroll"/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Scrollbar"/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Touchscreen"/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate.Wheel"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Autoscroll"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Scrollbar"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Touchscreen"/> - <affected-histogram name="EventLatency.GestureScrollBegin.Wheel"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Autoscroll"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Scrollbar"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Touchscreen"/> - <affected-histogram name="EventLatency.GestureScrollEnd.Wheel"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Autoscroll"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Scrollbar"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Touchscreen"/> - <affected-histogram name="EventLatency.GestureScrollUpdate.Wheel"/> - <affected-histogram - name="EventLatency.InertialGestureScrollUpdate.Autoscroll"/> - <affected-histogram - name="EventLatency.InertialGestureScrollUpdate.Scrollbar"/> - <affected-histogram - name="EventLatency.InertialGestureScrollUpdate.Touchscreen"/> - <affected-histogram name="EventLatency.InertialGestureScrollUpdate.Wheel"/> -</histogram_suffixes> - -<histogram_suffixes name="EventLatencyScrollTypes" separator="."> - <suffix base="true" name="Autoscroll" - label="Event latency for autoscroll events."/> - <suffix base="true" name="Scrollbar" - label="Event latency for scrollbar scroll events."/> - <suffix base="true" name="Touchscreen" - label="Event latency for touchscreen scroll events."/> - <suffix base="true" name="Wheel" - label="Event latency for mousewheel scroll events."/> - <affected-histogram name="EventLatency.FirstGestureScrollUpdate"/> - <affected-histogram name="EventLatency.GestureScrollBegin"/> - <affected-histogram name="EventLatency.GestureScrollEnd"/> - <affected-histogram name="EventLatency.GestureScrollUpdate"/> - <affected-histogram name="EventLatency.InertialGestureScrollUpdate"/> -</histogram_suffixes> - -<histogram_suffixes name="EventLatencyTotal" separator="."> - <suffix name="TotalLatency" - label="Total latency from when the event is generated until the frame - is presented on screen for all event types."/> - <affected-histogram name="EventLatency"/> -</histogram_suffixes> - -<histogram_suffixes name="EventLatencyTypes" separator="."> - <suffix base="true" name="FirstGestureScrollUpdate" - label="Event latency for the first gesture-scroll-update event in a - scroll sequence."/> - <suffix base="true" name="GestureDoubleTap" - label="Event latency for gesture-double-tap event."/> - <suffix base="true" name="GestureLongPress" - label="Event latency for gesture-long-press event."/> - <suffix base="true" name="GestureLongTap" - label="Event latency for gesture-long-tap event."/> - <suffix base="true" name="GesturePinchBegin" - label="Event latency for gesture-ping-begin event."/> - <suffix base="true" name="GesturePinchEnd" - label="Event latency for gesture-ping-end event."/> - <suffix base="true" name="GesturePinchUpdate" - label="Event latency for gesture-ping-update event."/> - <suffix base="true" name="GestureScrollBegin" - label="Event latency for gesture-scroll-begin event."/> - <suffix base="true" name="GestureScrollEnd" - label="Event latency for gesture-scroll-end event."/> - <suffix base="true" name="GestureScrollUpdate" - label="Event latency for non-inertial gesture-scroll-update events in a - scroll sequence except for the first one."/> - <suffix base="true" name="GestureShowPress" - label="Event latency for gesture-show-press event."/> - <suffix base="true" name="GestureTap" - label="Event latency for gesture-tap event."/> - <suffix base="true" name="GestureTapCancel" - label="Event latency for gesture-tap-cancel event."/> - <suffix base="true" name="GestureTapDown" - label="Event latency for gesture-tap-down event."/> - <suffix base="true" name="GestureTapUnconfirmed" - label="Event latency for gesture-tap-unconfirmed event."/> - <suffix base="true" name="GestureTwoFingerTap" - label="Event latency for gesture-two-finger-tap event."/> - <suffix base="true" name="InertialGestureScrollUpdate" - label="Event latency for an inertial gesture-scroll-update event in a - scroll sequence."/> - <suffix base="true" name="KeyPressed" - label="Event latency for key-pressed event."/> - <suffix base="true" name="KeyReleased" - label="Event latency for key-released event."/> - <suffix base="true" name="MouseDragged" - label="Event latency for mouse-dragged event."/> - <suffix base="true" name="MousePressed" - label="Event latency for mouse-pressed event."/> - <suffix base="true" name="MouseReleased" - label="Event latency for mouse-released event."/> - <suffix base="true" name="MouseWheel" - label="Event latency for mouse-wheel event."/> - <suffix base="true" name="TouchMoved" - label="Event latency for touch-moved event."/> - <suffix base="true" name="TouchPressed" - label="Event latency for touch-pressed event."/> - <suffix base="true" name="TouchReleased" - label="Event latency for touch-released event."/> - <affected-histogram name="EventLatency"/> -</histogram_suffixes> - <histogram_suffixes name="ExitFunnels" separator="."> <suffix name="BackgroundOff" label=""/> <suffix name="BackgroundOn" label=""/> @@ -6925,6 +6564,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="ImportantFileWriterSuffix" separator="."> + <obsolete> + Various histograms using these suffixes removed in M80, M84, M89, and M95. + </obsolete> <suffix name="BookmarkStorage" label=""/> <suffix name="FeedbackReport" label=""/> <suffix name="Local_State" label="Local State file"/> @@ -6941,7 +6583,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <affected-histogram name="ImportantFile.FileOpenError"/> <affected-histogram name="ImportantFile.FileRenameError"/> <affected-histogram name="ImportantFile.FileWriteError"/> - <affected-histogram name="ImportantFile.SerializationDuration"/> <affected-histogram name="ImportantFile.TempFileFailures"/> <affected-histogram name="ImportantFile.TimeToWrite"/> </histogram_suffixes> @@ -7310,6 +6951,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="LegacyTLS" separator="."> + <obsolete> + No longer is use as of 2021-10. + </obsolete> <suffix name="LegacyTLS_NotTriggered" label="Page didn't trigger legacy TLS warning"/> <suffix name="LegacyTLS_Triggered" label="Page triggered legacy TLS warning"/> @@ -7372,6 +7016,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="CartDatabase" label="Database for chrome cart."/> <suffix name="CommerceSubscriptionDatabase" label="Database for Chrome commerce subscriptions."/> + <suffix name="CouponDatabase" label="Database for coupons in Chrome."/> <suffix name="DomDistillerStore" label="Databases for DomDistillerStore"> <obsolete> Deprecated since 2019-10. @@ -7452,7 +7097,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="UsageStatsWebsiteEvent" label="UsageStats database for WebsiteEvents."/> <suffix name="VideoDecodeStatsDB" label="Database for video decode stats"/> - <suffix name="VideoTutorialsDatabase" label="Database for video tutorials."/> + <suffix name="VideoTutorialsDatabase" + label="Database for video tutorials (deprecated)."/> + <suffix name="VideoTutorialsV2Database" + label="Database for video tutorials."/> <affected-histogram name="LevelDB.ApproximateMemoryUse"/> <affected-histogram name="LevelDB.ApproximateMemTableMemoryUse"/> <affected-histogram name="LevelDB.Open"/> @@ -7768,98 +7416,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <affected-histogram name="Media.Audio.InputStartupSuccessMac"/> </histogram_suffixes> -<histogram_suffixes name="MachineLearningServiceLoadModelResultEvent" - separator="." ordering="prefix"> - <suffix name="TextClassifier" label="On-device text classification model."/> - <affected-histogram name="MachineLearningService.LoadModelResult.Event"/> -</histogram_suffixes> - -<histogram_suffixes name="MachineLearningServiceModels" separator="." - ordering="prefix"> - <suffix name="smart_dim_model_20190521_v3" - label="Obsolete smart dim model identifier."> - <obsolete> - This model identifier deprecated after M84, use SmartDimModel instead. - </obsolete> - </suffix> - <suffix name="SmartDimModel" label="Predict whether to cancel screen dims."/> - <suffix name="TestModel" label="A simple model for testing purpose."/> - <suffix name="TopCatModel" label="Predict the next app to be launched."> - <obsolete> - TopCat model deprecated 2020-06. - </obsolete> - </suffix> - <affected-histogram - name="MachineLearningService.CreateGraphExecutorResult.CpuTimeMicrosec"/> - <affected-histogram - name="MachineLearningService.CreateGraphExecutorResult.ElapsedTimeMicrosec"> - <obsolete> - Removed 2020-02-01 because elapsed time should be measured by clients, if - they need it. - </obsolete> - </affected-histogram> - <affected-histogram - name="MachineLearningService.CreateGraphExecutorResult.Event"/> - <affected-histogram - name="MachineLearningService.CreateGraphExecutorResult.TotalMemoryDeltaKb"/> - <affected-histogram - name="MachineLearningService.ExecuteResult.CpuTimeMicrosec"/> - <affected-histogram - name="MachineLearningService.ExecuteResult.ElapsedTimeMicrosec"> - <obsolete> - Removed 2020-02-01 because elapsed time should be measured by clients, if - they need it. - </obsolete> - </affected-histogram> - <affected-histogram name="MachineLearningService.ExecuteResult.Event"/> - <affected-histogram - name="MachineLearningService.ExecuteResult.TotalMemoryDeltaKb"/> - <affected-histogram - name="MachineLearningService.LoadModelResult.CpuTimeMicrosec"/> - <affected-histogram - name="MachineLearningService.LoadModelResult.ElapsedTimeMicrosec"> - <obsolete> - Removed 2020-02-01 because elapsed time should be measured by clients, if - they need it. - </obsolete> - </affected-histogram> - <affected-histogram name="MachineLearningService.LoadModelResult.Event"/> - <affected-histogram - name="MachineLearningService.LoadModelResult.TotalMemoryDeltaKb"/> -</histogram_suffixes> - -<histogram_suffixes name="MachineLearningServiceRequests" separator="." - ordering="prefix"> - <suffix base="true" name="CreateGraphExecutorResult" label=""/> - <suffix base="true" name="ExecuteResult" label=""/> - <suffix name="HandwritingModel.LoadModelResult" label=""/> - <suffix name="HandwritingModel.Recognize" label=""/> - <suffix base="true" name="LoadModelResult" label=""/> - <suffix name="TextClassifier.Annotate" label=""/> - <suffix name="TextClassifier.FindLanguages" label=""/> - <suffix name="TextClassifier.LoadModelResult" label=""/> - <suffix name="TextClassifier.SuggestSelection" label=""/> - <suffix name="TextSuggester.LoadModelResult" label=""/> - <suffix name="TextSuggester.Suggest" label=""/> - <suffix name="WebPlatformHandwritingModel.GetPrediction" label=""/> - <suffix name="WebPlatformHandwritingModel.LoadModelResult" label=""/> - <affected-histogram name="MachineLearningService.CpuTimeMicrosec"/> - <affected-histogram name="MachineLearningService.ElapsedTimeMicrosec"> - <obsolete> - Removed 2020-02-01 because elapsed time should be measured by clients, if - they need it. - </obsolete> - </affected-histogram> - <affected-histogram name="MachineLearningService.PrivateMemoryDeltaKb"> - <obsolete> - Deprecated 07/2019, because we change to record total (shared+unshared) - memory rather than only private memory. Replaced by - MachineLearningService.TotalMemoryDeltaKb. - </obsolete> - </affected-histogram> - <affected-histogram name="MachineLearningService.TotalMemoryDeltaKb"/> -</histogram_suffixes> - <histogram_suffixes name="MainFrameNavigation" separator="_"> <suffix name="MainFrame" label="Main frame navigation."/> <affected-histogram name="ServiceWorker.NavPreload.ConcurrentTime"/> @@ -8391,6 +7947,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="Mobile_Messages_Type" separator="."> + <suffix name="InfobarTypeAutofillAddressProfile" + label="Recorded for Autofill Address Messages."/> <suffix name="InfobarTypeConfirm" label="Recorded for Confirm Messages."/> <suffix name="InfobarTypePasswordSave" label="Recorded for Save Password Messages."/> @@ -10392,7 +9950,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="MostVisited" label="Loaded client-side suggestions."/> <suffix name="NewTab" label="NTP loaded on a new tab."/> <suffix name="Startup" label="NTP loaded during browser startup."/> - <suffix name="Web" label="Loaded server-side NTP."/> + <suffix name="Web" label="Loaded server-side NTP."> + <obsolete> + Removed in 09 2021. + </obsolete> + </suffix> <suffix name="WebUI3PNTP" label="Loaded 3P WebUI NTP."/> <suffix name="WebUINTP" label="Loaded WebUI NTP."/> <affected-histogram name="NewTabPage.LoadTime"/> @@ -10411,7 +9973,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. Deprecated NTP replaced by WebUI NTP M91. </obsolete> </affected-histogram> - <affected-histogram name="NewTabPage.LoadTime.Web"/> + <affected-histogram name="NewTabPage.LoadTime.Web"> + <obsolete> + Removed in 09 2021. + </obsolete> + </affected-histogram> </histogram_suffixes> <histogram_suffixes name="NextTabState" separator="_"> @@ -11162,6 +10728,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="Edu-coexistence-login.Done" label=""/> <suffix name="Eula.AcceptedWithoutStats" label=""/> <suffix name="Eula.AcceptedWithStats" label=""/> + <suffix name="Eula.AlreadyAccepted" label=""/> <suffix name="Eula.Back" label=""/> <suffix name="Family-link-notice.Done" label=""/> <suffix name="Fingerprint-setup.Done" label=""/> @@ -11233,11 +10800,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="OptimizationGuide_OptimizationTargets" separator="."> + <suffix name="SegmentationChromeStartAndroid" label="Chrome Start Android"/> + <suffix name="SegmentationDummyFeature" label="Dummy feature"/> <suffix name="LanguageDetection" label="Language detection"/> <suffix name="ModelValidation" label="Model validation triggered via CLI"/> + <suffix name="NotificationPermissions" label="Notification permissions"/> <suffix name="PageEntities" label="Page entities"/> <suffix name="PageTopics" label="Page topics"/> <suffix name="PainfulPageLoad" label="Painful page load"/> + <suffix name="SegmentationQueryTiles" label="Query tiles"/> <suffix name="SegmentationNewTab" label="Segmentation: New tab page user"/> <suffix name="SegmentationShare" label="Segmentation: Share user"/> <suffix name="SegmentationVoice" label="Segmentation: Voice user"/> @@ -11262,6 +10833,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="OptimizationGuide_OptimizationTypes" separator="."> + <suffix name="AboutThisSite" + label="Provides 'About this site' data about the site being visited"/> + <suffix name="BloomFilterValidation" + label="Validates bloom filer allowlist/blocklist based hints"/> <suffix name="CompressPublicImages" label="Compresses public images"/> <suffix name="DeferAllScript" label="Defers execution of script"/> <suffix name="DelayAsyncScriptExecution" @@ -11302,7 +10877,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. logged-in"/> <suffix name="MerchantTrustSignals" label="Provides trust data related to the merchant."/> - <suffix name="None" label="No optimization type"/> + <suffix name="MerchantTrustSignalsV2" + label="Provides trust data related to the merchant -- version 2."/> + <suffix name="MetadataFetchValidation" + label="Validates metadata fetch on navigation"/> <suffix name="NoScript" label="Disables the fetching and execution of JavaScript"> <obsolete> @@ -13009,28 +12587,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </affected-histogram> </histogram_suffixes> -<histogram_suffixes name="PermissionPromptDisposition" separator="."> - <suffix name="AnchoredBubble" - label="A bubble under the site settings padlock"/> - <suffix name="CustomModalDialog" label="Other custom modal dialogs"/> - <suffix name="LocationBarLeftChip" - label="A chip on the left-hand side of the location bar that shows a - bubble when clicked"/> - <suffix name="LocationBarLeftQuietChip" - label="A less prominent version of a chip on the left-hand side of the - location bar that shows a bubble when clicked"/> - <suffix name="LocationBarRightAnimatedIcon" - label="An animated indicator on the right-hand side of the location bar"/> - <suffix name="LocationBarRightStaticIcon" - label="A static indicator on the right-hand side of the location bar"/> - <suffix name="MiniInfobar" - label="An initially-collapsed infobar at the bottom of the page"/> - <suffix name="ModalDialog" label="A modal dialog"/> - <suffix name="NoneVisible" label="There was no UI being shown"/> - <suffix name="NotApplicable" label="No permission prompt at all"/> - <affected-histogram name="Permissions.Action.WithDisposition"/> -</histogram_suffixes> - <histogram_suffixes name="PermissionRequestGesture" separator="."> <suffix name="Gesture" label="With user gesture"/> <suffix name="NoGesture" label="Without user gesture"/> @@ -13170,18 +12726,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <affected-histogram name="UMA.PersistentAllocator.Allocs"/> </histogram_suffixes> -<histogram_suffixes name="PhoneHubFeature" separator="."> - <suffix name="NotificationBadge" label="Notification badge sub-feature."> - <obsolete> - Removed in M88, as the feature will not be included in the M89 launch. - </obsolete> - </suffix> - <suffix name="Notifications" label="Notifications sub-feature."/> - <suffix name="TaskContinuation" label="Task continuation sub-feature."/> - <suffix name="TopLevelFeature" label="Top level Phone Hub feature."/> - <affected-histogram name="PhoneHub.MultiDeviceFeatureState"/> -</histogram_suffixes> - <histogram_suffixes name="PhoneNumberRegexVariant" separator="."> <obsolete> Removed in M82 as the experiment has been stopped. @@ -13815,23 +13359,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. label="Only counting memory used by Partition allocator."/> <suffix name="PartitionAlloc.AllocatedObjects" label="Only counting objects allocated using Partition allocator."/> - <suffix name="PartitionAlloc.MaxAllocatedMemory.ArrayBuffer" + <suffix name="PartitionAlloc.MaxAllocatedSize.ArrayBuffer" label="Highwatermark for allocated memory for the ArrayBuffer partition."/> - <suffix name="PartitionAlloc.MaxAllocatedMemory.Buffer" + <suffix name="PartitionAlloc.MaxAllocatedSize.Buffer" label="Highwatermark for allocated memory for the Buffer partition."/> - <suffix name="PartitionAlloc.MaxAllocatedMemory.FastMalloc" + <suffix name="PartitionAlloc.MaxAllocatedSize.FastMalloc" label="Highwatermark for allocated memory for the FastMalloc partition."/> - <suffix name="PartitionAlloc.MaxAllocatedMemory.Layout" + <suffix name="PartitionAlloc.MaxAllocatedSize.Layout" label="Highwatermark for allocated memory for the Layout partition."/> - <suffix name="PartitionAlloc.MaxCommittedMemory.ArrayBuffer" + <suffix name="PartitionAlloc.MaxCommittedSize.ArrayBuffer" label="Highwatermark for committed memory for the ArrayBuffer partition."/> - <suffix name="PartitionAlloc.MaxCommittedMemory.Buffer" + <suffix name="PartitionAlloc.MaxCommittedSize.Buffer" label="Highwatermark for committed memory for the Buffer partition."/> - <suffix name="PartitionAlloc.MaxCommittedMemory.FastMalloc" + <suffix name="PartitionAlloc.MaxCommittedSize.FastMalloc" label="Highwatermark for committed memory for the FastMalloc partition."/> - <suffix name="PartitionAlloc.MaxCommittedMemory.Layout" + <suffix name="PartitionAlloc.MaxCommittedSize.Layout" label="Highwatermark for committed memory for the Layout partition."/> <suffix name="PartitionAlloc.Partitions.ArrayBuffer" label="Only counting memory used by Array Buffer partition."/> @@ -13952,6 +13496,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="History" label="Only counting memory used by History service."/> <suffix name="LevelDatabase" label="Only counting memory used by Level databases."/> + <suffix name="Malloc.BRPQuarantined" + label="Memory used by objects quarantined by BRP, recorded when + USE_BACKUP_REF_PTR build flag is enabled."/> + <suffix name="Malloc.BRPQuarantinedCount" + label="Number of slots quarantined by BRP, recorded when + USE_BACKUP_REF_PTR build flag is enabled."/> <suffix name="Malloc.ThreadCache" label="Memory used by all thread caches, recorded when PartitionAlloc is used as malloc()."/> @@ -15234,16 +14784,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. label="Records metrics for consumer real time URL lookup service."/> <suffix name="Enterprise" label="Records metrics for enterprise real time URL lookup service."/> + <affected-histogram name="SafeBrowsing.PageLoadToken.RealTimeCheckHasToken"/> <affected-histogram name="SafeBrowsing.RT.Backoff.State"/> <affected-histogram name="SafeBrowsing.RT.GetCache.Time"/> <affected-histogram name="SafeBrowsing.RT.GetCacheResult"/> <affected-histogram name="SafeBrowsing.RT.HasTokenInRequest"/> <affected-histogram name="SafeBrowsing.RT.HasValidCacheManager"/> <affected-histogram name="SafeBrowsing.RT.IsLookupSuccessful"/> + <affected-histogram name="SafeBrowsing.RT.IsPopulationMbbOrEsb"/> <affected-histogram name="SafeBrowsing.RT.Network.Result"/> <affected-histogram name="SafeBrowsing.RT.Network.Time"/> <affected-histogram name="SafeBrowsing.RT.Request.Size"/> <affected-histogram name="SafeBrowsing.RT.Request.UserPopulation"/> + <affected-histogram name="SafeBrowsing.RT.Response.VerdictType"/> <affected-histogram name="SafeBrowsing.RT.ThreatInfoSize"/> </histogram_suffixes> @@ -15877,7 +15430,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="FETCH_SHARED_WORKER" label="FETCH_SHARED_WORKER"/> <suffix name="FETCH_SUB_FRAME" label="FETCH_SUB_FRAME"/> <suffix name="FETCH_SUB_RESOURCE" label="FETCH_SUB_RESOURCE"/> - <suffix name="FOREIGN_FETCH" label="FOREIGN_FETCH"/> + <suffix name="FOREIGN_FETCH" label="FOREIGN_FETCH"> + <obsolete> + Has not been emitted since Foreign Fetch was removed ca. 2018. + </obsolete> + </suffix> <suffix name="GEOFENCING" label="GEOFENCING"> <obsolete> Deprecated as of 5/2016 because geofencing got removed. @@ -15911,7 +15468,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="SYNC" label="SYNC"/> <suffix name="UNKNOWN" label="UNKNOWN"/> <affected-histogram name="ServiceWorker.EventDispatchingDelay"/> - <affected-histogram name="ServiceWorker.StartWorker.StatusByPurpose"/> <affected-histogram name="ServiceWorker.StartWorker.Time_DuringStartup"/> <affected-histogram name="ServiceWorker.StartWorker.Time_ExistingReadyProcess"/> @@ -15921,6 +15477,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="ServiceWorker_FailureStreak" separator="_"> + <obsolete> + Removed in September 2021. + </obsolete> <suffix name="1" label="Failed one time."/> <suffix name="2" label="Failed two times."/> <suffix name="3" label="Failed three times."/> @@ -15928,6 +15487,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="ServiceWorker_LookupRegistrationResult" separator="."> + <obsolete> + Removed in September 2021. + </obsolete> <suffix name="DoesNotExist" label="The registration doesn't exist."/> <suffix name="Error" label="Failed to look up the registration."/> <suffix name="Exists" label="The registration exists."/> @@ -16594,13 +16156,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram_suffixes name="SharingMessage" separator="."> <suffix name="ACK_MESSAGE" label="Ack Message"/> <suffix name="CLICK_TO_CALL_MESSAGE" label="Click To Call Message"/> - <suffix name="ICE_CANDIDATE_MESSAGE" label="Ice Candidate Message"/> + <suffix name="DISCOVERY_REQUEST" label="Discovery Request Message"/> + <suffix name="OPTIMIZATION_GUIDE_PUSH_NOTIFICATION" + label="Optimization Guide Push Notification Message"/> + <suffix name="PEER_CONNECTION_ICE_CANDIDATES_MESSAGE" + label="Peer Connection Ice Candidates Message"/> + <suffix name="PEER_CONNECTION_OFFER_MESSAGE" + label="Peer Connection Offer Message"/> <suffix name="PING_MESSAGE" label="Ping Message"/> <suffix name="REMOTE_COPY_MESSAGE" label="Remote Copy Message"/> <suffix name="SHARED_CLIPBOARD_MESSAGE" label="Shared Clipboard Message"/> - <suffix name="SIGNALLING_MESSAGE" label="Signalling Message"/> <suffix name="SMS_FETCH_REQUEST" label="SMS Fetch Request"/> <suffix name="UNKNOWN_MESSAGE" label="Unknown Message"/> + <suffix name="WEB_RTC_SIGNALING_FRAME" label="Web RTC Signalling Message"/> <affected-histogram name="Sharing.DeviceLastUpdatedAge"> <obsolete> Removed in M89. @@ -16788,6 +16356,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram_suffixes> <histogram_suffixes name="Signin_Reconciler" separator="."> + <obsolete> + No longer used after 2021-05 and the switch to OAuthMultilogin. + </obsolete> <suffix name="FirstRun" label="First execution of the reconciler after the profile was loaded or the new_profile_management flag was toggled."/> @@ -17540,27 +17111,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="ABORTED" label="When configuration gets aborted."/> <suffix name="OK" label="When configuration is successful"/> <suffix name="UNRECOVERABLE_ERROR" - label="When configuration encounters an unrecoverable error"/> + label="When configuration encounters an unrecoverable error"> + <obsolete> + Removed 06/2020, no longer used. + </obsolete> + </suffix> <affected-histogram name="Sync.ConfigureTime_Initial"/> <affected-histogram name="Sync.ConfigureTime_Subsequent"/> </histogram_suffixes> -<histogram_suffixes name="SyncErrorInfoBarType" separator="."> - <suffix name="AuthError" label="Auth error."/> - <suffix name="ClientOutOfDate" label="Client out of date."/> - <suffix name="PassphraseRequired" label="Passphrase required."/> - <suffix name="SyncSetupIncomplete" label="Sync setup incomplete."/> - <suffix name="TrustedVaultKeyRequiredForEverything" - label="Trusted vault keys required for everything."/> - <suffix name="TrustedVaultKeyRequiredForPasswords" - label="Trusted vault keys required for passwords."/> - <suffix name="TrustedVaultRecoverabilityDegradedForEverything" - label="Trusted vault recoverability degraded for everything."/> - <suffix name="TrustedVaultRecoverabilityDegradedForPasswords" - label="Trusted vault recoverability degraded for passwords."/> - <affected-histogram name="Signin.SyncErrorInfoBar"/> -</histogram_suffixes> - <histogram_suffixes name="SyncFaviconRequestOrigin" separator="."> <suffix name="HISTORY" label="Request made by chrome://history."/> <suffix name="RECENTLY_CLOSED_TABS" @@ -17741,7 +17300,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <affected-histogram name="Sync.ModelTypeEntityChange3"/> <affected-histogram name="Sync.ModelTypeErrorSite"/> <affected-histogram name="Sync.ModelTypeMemoryKB"/> - <affected-histogram name="Sync.ModelTypeStoreCommitWriteBatchOutcome"/> + <affected-histogram name="Sync.ModelTypeStoreCommitWriteBatchOutcome"> + <obsolete> + Deprecated 09/2021. No longer needed. + </obsolete> + </affected-histogram> <affected-histogram name="Sync.ModelTypeTimeUntilEncryptionKeyFound"/> <affected-histogram name="Sync.ModelTypeUndecryptablePendingUpdatesDropped"/> <affected-histogram name="Sync.NonReflectionUpdateFreshnessPossiblySkewed"> @@ -18739,6 +18302,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <suffix name="Eche" label="Eche"/> <suffix name="Help" label="Help"/> <suffix name="Media" label="Media"/> + <suffix name="MediaAudio" label="MediaAudio"> + <obsolete> + Deprecated as of 2021-09-30. + </obsolete> + </suffix> <suffix name="OSFeedback" label="OSFeedback"/> <suffix name="OSSettings" label="OS Settings"/> <suffix name="Personalization" label="Personalization"/> diff --git a/chromium/tools/metrics/histograms/metadata/history/OWNERS b/chromium/tools/metrics/histograms/metadata/history/OWNERS index cad8f957c00..bfb97f89c94 100644 --- a/chromium/tools/metrics/histograms/metadata/history/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/history/OWNERS @@ -5,3 +5,7 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # For History.ClearBrowsingData.* histograms dullweber@chromium.org + +# For History.Clusters* histograms +mcrouse@chromium.org +sophiechang@chromium.org diff --git a/chromium/tools/metrics/histograms/metadata/history/histograms.xml b/chromium/tools/metrics/histograms/metadata/history/histograms.xml index 22feba429ce..e7c6bb31970 100644 --- a/chromium/tools/metrics/histograms/metadata/history/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/history/histograms.xml @@ -170,7 +170,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.ClearBrowsingData.FailedTasksChrome" - enum="ChromeBrowsingDataRemoverTasks" expires_after="2021-12-19"> + enum="ChromeBrowsingDataRemoverTasks" expires_after="2022-04-17"> <owner>dullweber@chromium.org</owner> <owner>msramek@chromium.org</owner> <summary> @@ -226,7 +226,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.ClearBrowsingData.InstalledAppExcluded" - units="Boolean" expires_after="2022-02-16"> + units="Boolean" expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -239,7 +239,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.ClearBrowsingData.InstalledAppsDialogAction" - enum="InstalledAppsDialogActions" expires_after="2022-02-22"> + enum="InstalledAppsDialogActions" expires_after="2022-04-24"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -249,7 +249,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.ClearBrowsingData.InstalledAppsDialogShown" - units="Boolean" expires_after="2022-02-22"> + units="Boolean" expires_after="2022-04-24"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -261,7 +261,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.ClearBrowsingData.InstalledDeselectedNum" - units="units" expires_after="2022-02-16"> + units="units" expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -273,7 +273,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.ClearBrowsingData.InstalledDeselectedPercent" - units="%" expires_after="2022-02-16"> + units="%" expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -374,7 +374,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.ClearBrowsingData.UserDeletedFromTab" - enum="ClearBrowsingDataTab" expires_after="2022-02-06"> + enum="ClearBrowsingDataTab" expires_after="2022-04-17"> <owner>dullweber@chromium.org</owner> <owner>msramek@chromium.org</owner> <summary> @@ -383,6 +383,258 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="History.Clusters.Actions.DidMakeQuery" units="BooleanQueried" + expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logged when the user closes the chrome://history/journeys page (e.g. closed + tab, navigated in the same tab, or closed browser). Logs whether the user + made a query on their history from the journeys page. + </summary> +</histogram> + +<histogram name="History.Clusters.Actions.FinalState" + units="HistoryClustersFinalState" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logged when the user closes the chrome://history/journeys page (e.g. closed + tab, navigated in the same tab, or closed browser). Logs the final state + that ended the use of the journeys page (e.g., a link click away from the + page). + </summary> +</histogram> + +<histogram name="History.Clusters.Actions.InitialState" + units="HistoryClustersInitialState" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logged when the user closes the chrome://history/journeys page (e.g. closed + tab, navigated in the same tab, or closed browser). Logs the state that + started the use of the journeys page (e.g., a direct navigation to journeys + page). + </summary> +</histogram> + +<histogram name="History.Clusters.Actions.LinksOpened" units="links opened" + expires_after="M101"> + <owner>manukh@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logged when the user closed the chrome://history/journeys page (e.g. closed + tab, navigated in the same tab, or closed browser). Logs the # of links + opened from the journeys page. + </summary> +</histogram> + +<histogram name="History.Clusters.Actions.NumQueries" + units="number queries made" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logged when the user closes the chrome://history/journeys page (e.g. closed + tab, navigated in the same tab, or closed browser). Logs the number of + queries the user made while on the journeys page, only logged if at least + one query was made. + </summary> +</histogram> + +<histogram name="History.Clusters.Backend.BatchEntityLookupLatency" units="ms" + expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the latency of querying entities for all the visits being clustered by + the on-device backend. Logged when clusters have been calculated based on + any request to cluster visits, which could be triggered from several things, + including loading the journeys UI, putting a query in the journeys page, + etc.. + </summary> +</histogram> + +<histogram name="History.Clusters.Backend.BatchEntityLookupSize" units="count" + expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the number of entities to be queried for their metadata when preparing + to start clustering. The number of entities is the size of the entire batch + which is over all visits provided to the backend for clustering. Logged when + clusters are requested based on any request to cluster visits, which could + be triggered from several things, including loading the journeys UI, putting + a query in the journeys page, etc.. + </summary> +</histogram> + +<histogram name="History.Clusters.Backend.ClusterSize.{ClusterStatistic}" + units="number visits" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the {ClusterStatistic} of all clusters determined by the on-device + backend. Logged when clusters have been calculated based on any request to + cluster visits, which could be triggered from several things, including + loading the + </summary> + <token key="ClusterStatistic"> + <variant name="Max" summary="maximum cluster size"/> + <variant name="Min" summary="minimum cluster size"/> + </token> +</histogram> + +<histogram name="History.Clusters.Backend.GetClusterLatency" units="ms" + expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the latency of clustering visits performed by the on-device backend. + Logged when clusters have been calculated based on any request to cluster + visits, which could be triggered from several things, including loading the + journeys UI, putting a query in the journeys page, etc.. + </summary> +</histogram> + +<histogram name="History.Clusters.Backend.NumClustersReturned" + units="number clusters returned" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the total number of clusters returned for requested visits. Logged when + clusters have been calculated based on any request to cluster visits, which + could be triggered from several things, including loading the journeys UI, + putting a query in the journeys page, etc.. + </summary> +</histogram> + +<histogram + name="History.Clusters.Backend.NumKeywordsPerCluster.{KeywordStatistic}" + units="number keywords" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the {KeywordStatistic} over all clusters determined by the on-device + backend. Logged when clusters have been calculated based on any request to + cluster visits, which could be triggered from several things, including + loading the journeys UI, putting a query in the journeys page, etc.. + </summary> + <token key="KeywordStatistic"> + <variant name="Max" summary="maximum keywords"/> + <variant name="Min" summary="minimum keywords"/> + </token> +</histogram> + +<histogram name="History.Clusters.Backend.NumVisitsToCluster" + units="number visits" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the total number of visits requested to be clustered by the backend. + Logged when any request to cluster visits is made, which could be triggered + from several things, including loading the journeys UI, putting a query in + the journeys page, etc.. + </summary> +</histogram> + +<histogram name="History.Clusters.PercentClustersFilteredByQuery" + units="percent clusters filtered" expires_after="M101"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Logs the percentage of clusters that were filtered by the specified queried. + Logged when any request to cluster visits is made and a query has been + specified in the UI. + </summary> +</histogram> + +<histogram name="History.Clusters.ServiceLatency" units="ms" + expires_after="M101"> + <owner>tommycli@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Records the time taken between the History Clusters WebUI handler requests a + batch of clusters, and when we get the clusters back from the Service. + + This request occurs when the page is first loaded, when the page is + refreshed, when the user changes the History search terms, and when the user + scrolls to the bottom of the page and requests the next batch of clusters + from the service. + + This metric doesn't distinguish between any of these cases. This metric is + recorded on all requests, whether or not it returns clusters. + + This does not take into account the time spent in JavaScript, or updating + the DOM. + </summary> +</histogram> + +<histogram name="History.Clusters.UIActions.Cluster.{ClusterAction}" + units="index" expires_after="2022-02-25"> + <owner>mahmadi@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Recorded every time the user {ClusterAction} in chrome://history/journeys. + The value represents the 0-indexed index of the cluster. + </summary> + <token key="ClusterAction"> + <variant name="Deleted" summary="deletes a history cluster"/> + <variant name="RelatedSearchClicked" + summary="clicks a related search suggestion"/> + <variant name="RelatedVisitsVisibilityToggled" + summary="toggles visibility of the default-hidden related visits"/> + <variant name="VisitClicked" summary="clicks a visit"/> + </token> +</histogram> + +<histogram + name="History.Clusters.UIActions.RelatedSearch.{RelatedSearchAction}" + units="index" expires_after="2022-02-25"> + <owner>mahmadi@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Recorded every time the user {RelatedSearchAction} a related search + suggestion in a history cluster in chrome://history/journeys. The value + represents the 0-indexed index of the related search suggestion in the + respective cluster. + </summary> + <token key="RelatedSearchAction"> + <variant name="Clicked" summary="clicks"/> + </token> +</histogram> + +<histogram name="History.Clusters.UIActions.ToggledVisibility" + units="BooleanVisible" expires_after="2022-02-25"> + <owner>mahmadi@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Recorded every time the user toggles the visibility of the history clusters + Web UI shown at chrome://history/journeys from the history Web UI sidebar. + The value represents the visibility of the history clusters Web UI. + </summary> +</histogram> + +<histogram name="History.Clusters.UIActions.{VisitType}Visit.{VisitAction}" + units="index" expires_after="2022-02-25"> + <owner>mahmadi@chromium.org</owner> + <owner>chrome-memories@google.com</owner> + <summary> + Recorded every time the user {VisitAction} a {VisitType} in a history + cluster in chrome://history/journeys. The value represents the 0-indexed + index of the visit in the respective cluster. + </summary> + <token key="VisitAction"> + <variant name="Clicked" summary="clicks"/> + <variant name="Deleted" summary="deletes"/> + </token> + <token key="VisitType"> + <variant name="" summary="visit"/> + <variant name="nonSRP" + summary="visit to a url other than the default search results page"/> + <variant name="SRP" summary="visit to the default search results page"/> + </token> +</histogram> + <histogram name="History.DatabaseAdvancedMetricsTime" units="ms" expires_after="M77"> <owner>shess@chromium.org</owner> @@ -432,7 +684,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.DomainCount1Day" units="domains" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>mpearson@chromium.org</owner> <owner>mjzhang@chromium.org</owner> <owner>chrome-analysis-team@google.com</owner> @@ -444,6 +696,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. latest unreported day, while the profile remains open. If no domains are visited in a given day, a count of 0 will be reported for that day. + Warning: this histogram is logged incorrectly on ChromeOS. See + http://crbug.com/1237591 + Warning about delayed data: Chrome may upload logs on a given day without uploading this histogram. This can happen because Chrome uploads logs initially upon startup. This histogram is emitted shortly _after_ startup. @@ -467,7 +722,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.DomainCount28Day" units="domains" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>mpearson@chromium.org</owner> <owner>mjzhang@chromium.org</owner> <owner>chrome-analysis-team@google.com</owner> @@ -480,6 +735,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. period, while the profile remains open. If no domains are visited during a 28-day period, a count of 0 will be reported for that period. + Warning: this histogram is logged incorrectly on ChromeOS. See + http://crbug.com/1237591 + Warning about delayed data: Chrome may upload logs on a given day without uploading this histogram. This can happen because Chrome uploads logs initially upon startup. This histogram is emitted shortly _after_ startup. @@ -503,7 +761,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.DomainCount7Day" units="domains" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>mpearson@chromium.org</owner> <owner>mjzhang@chromium.org</owner> <owner>chrome-analysis-team@google.com</owner> @@ -516,6 +774,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. period, while the profile remains open. If no domains are visited during a 7-day period, a count 0 will be reported for that period. + Warning: this histogram is logged incorrectly on ChromeOS. See + http://crbug.com/1237591 + Warning about delayed data: Chrome may upload logs on a given day without uploading this histogram. This can happen because Chrome uploads logs initially upon startup. This histogram is emitted shortly _after_ startup. @@ -539,7 +800,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.DomainCountQueryTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-20"> <owner>mpearson@chromium.org</owner> <owner>mjzhang@chromium.org</owner> <owner>chrome-analysis-team@google.com</owner> @@ -617,12 +878,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.HistoryPageView" enum="HistoryPageView" - expires_after="2021-03-01"> + expires_after="2022-05-01"> <owner>calamity@chromium.org</owner> <owner>src/chrome/browser/resources/history/OWNERS</owner> <summary> The page of the History page shown to the user. Logged each time the user loads the History page or switches pages. + + This histogram expired on 2021-03-01, was renewed on 2021-09-01, and may + have incomplete data within that range. </summary> </histogram> @@ -694,7 +958,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.InMemoryURLHistoryItems" units="items" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -705,7 +969,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.InMemoryURLIndexingTime" units="ms" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>mpearson@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary> @@ -715,7 +979,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.InMemoryURLIndexingTime.RoundTripTime" units="ms" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>tommycli@chromium.org</owner> <owner>mpearson@chromium.org</owner> <summary> @@ -741,7 +1005,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.InMemoryURLIndexSaveCacheTime" units="ms" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>tommycli@chromium.org</owner> <owner>mpearson@chromium.org</owner> <summary> @@ -763,7 +1027,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.MonthlyHostCount" units="hosts" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>mpearson@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> @@ -776,7 +1040,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.MonthlyURLCount" units="urls" - expires_after="2021-10-04"> + expires_after="2022-04-04"> <owner>mpearson@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> @@ -788,6 +1052,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="History.MonthlyVisitCount" units="visits" expires_after="2021-10-04"> + <obsolete> + Removed September 2021. + </obsolete> <owner>mpearson@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> @@ -919,7 +1186,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.VisitTableCount" units="visits" - expires_after="2021-10-04"> + expires_after="2022-04-04"> <owner>mpearson@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> @@ -929,7 +1196,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.WeeklyHostCount" units="hosts" - expires_after="2021-10-10"> + expires_after="2022-04-17"> <owner>mpearson@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> @@ -940,7 +1207,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="History.WeeklyURLCount" units="URLs" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>mpearson@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> @@ -952,6 +1219,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="History.WeeklyVisitCount" units="visits" expires_after="2021-10-04"> + <obsolete> + Removed September 2021. + </obsolete> <owner>mpearson@chromium.org</owner> <owner>sky@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/holding_space/histograms.xml b/chromium/tools/metrics/histograms/metadata/holding_space/histograms.xml index 218dd33593b..6a2524d059a 100644 --- a/chromium/tools/metrics/histograms/metadata/holding_space/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/holding_space/histograms.xml @@ -46,6 +46,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. summary="Items backed by a download file originating from Lacros Chrome."/> <variant name="NearbyShare" summary="Items backed by a nearby shared file."/> + <variant name="PhoneHubCameraRoll" + summary="Recent photos and videos taken on connected Android phone."/> <variant name="PinnedFile" summary="Items pinned explicitly by the user."/> <variant name="PrintedPdf" summary="Items backed by a printed PDF file."/> <variant name="Scan" summary="Items backed by a scanned file."/> @@ -55,7 +57,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="HoldingSpace.Animation.BubbleResize.Smoothness" units="%" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -67,7 +69,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Animation.PodResize.Smoothness" units="%" - expires_after="2021-09-24"> + expires_after="2022-01-30"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -79,7 +81,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Downloads.Action.All" - enum="HoldingSpaceDownloadsAction" expires_after="2022-01-30"> + enum="HoldingSpaceDownloadsAction" expires_after="2022-04-10"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -89,7 +91,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.FilesAppChip.Action.All" - enum="HoldingSpaceFilesAppChipAction" expires_after="2022-01-30"> + enum="HoldingSpaceFilesAppChipAction" expires_after="2022-04-10"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -99,7 +101,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Item.Action.All" enum="HoldingSpaceItemAction" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -109,7 +111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Item.Action.{action}" enum="HoldingSpaceItemType" - expires_after="2021-09-24"> + expires_after="2022-01-30"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -120,7 +122,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Item.Action.{action}.Extension" - enum="HoldingSpaceExtension" expires_after="2021-09-24"> + enum="HoldingSpaceExtension" expires_after="2022-01-30"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -131,7 +133,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Item.Count.{type}" units="items" - expires_after="2021-09-24"> + expires_after="2022-01-30"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -142,7 +144,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Item.FailureToLaunch" enum="HoldingSpaceItemType" - expires_after="2021-09-24"> + expires_after="2022-04-24"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -152,7 +154,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Item.FailureToLaunch.Extension" - enum="HoldingSpaceExtension" expires_after="2021-09-24"> + enum="HoldingSpaceExtension" expires_after="2022-04-24"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -162,7 +164,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.Pod.Action.All" enum="HoldingSpacePodAction" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -172,7 +174,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.TimeFromFirstAvailabilityToFirstAdd" units="ms" - expires_after="2021-09-24"> + expires_after="2022-01-30"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -182,7 +184,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.TimeFromFirstAvailabilityToFirstEntry" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> @@ -192,7 +194,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HoldingSpace.TimeFromFirstEntryToFirstPin" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>dmblack@google.com</owner> <owner>gzadina@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/image/histograms.xml b/chromium/tools/metrics/histograms/metadata/image/histograms.xml index 004a79c715f..c99343ec076 100644 --- a/chromium/tools/metrics/histograms/metadata/image/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/image/histograms.xml @@ -65,6 +65,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. summary="Showing cache patterns only for NewTabPageAnimatedLogo."/> <variant name=".OfflinePages" summary="Showing cache patterns only for OfflinePages."/> + <variant name=".PriceDropNotification" + summary="Images fetched for the icon of price drop notification."/> <variant name=".QueryTiles" summary="Showing Query tiles images."/> <variant name=".VideoTutorialsIPH" summary="Showing thumbnails for video tutorials IPH."/> @@ -95,7 +97,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ImageAnnotationService.AccessibilityV1.ClientResult" - enum="ImageAnnotationServiceClientResult" expires_after="2021-12-12"> + enum="ImageAnnotationServiceClientResult" expires_after="2022-04-24"> <owner>dmazzoni@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>martis@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/input/histograms.xml b/chromium/tools/metrics/histograms/metadata/input/histograms.xml index 3a70b0cd56b..ffd2b979eed 100644 --- a/chromium/tools/metrics/histograms/metadata/input/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/input/histograms.xml @@ -22,19 +22,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="InputMethod.ActiveCount" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>myy@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> - The number of active input methods. Recorded when the user logs in to Chrome - OS or each cold start of Chrome on Android. The active input methods are - selected by user in the language settings page on Chrome OS and in system - language settings on Android. + The number of enabled input methods. Recorded when the user logs in to + Chrome OS or each cold start of Chrome on Android. The enabled input methods + are selected by user in the language settings page on Chrome OS and in + system language settings on Android. NOTE: 'Active' in the metric name is a + legacy misnomer; 'active' should refer to just the single current aka. + activated input method that is one of the enabled input methods whose total + count is being tracked by this metric. </summary> </histogram> <histogram name="InputMethod.Assistive.Autocorrect.Actions" - enum="IMEAutocorrectActions" expires_after="2021-12-26"> + enum="IMEAutocorrectActions" expires_after="2022-03-26"> <owner>jopalmer@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -44,7 +47,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Autocorrect.Actions.VK" - enum="IMEAutocorrectActions" expires_after="2021-10-22"> + enum="IMEAutocorrectActions" expires_after="2022-03-22"> <owner>jopalmer@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -54,7 +57,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Autocorrect.Count" - enum="IMETextInputClient" expires_after="2022-01-30"> + enum="IMETextInputClient" expires_after="2022-04-10"> <owner>myy@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -65,7 +68,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Autocorrect.Delay" units="ms" - expires_after="2021-12-26"> + expires_after="2022-03-26"> <owner>jopalmer@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -75,7 +78,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.CandidateGenerationTime.MultiWord" - units="ms" expires_after="2021-10-04"> + units="ms" expires_after="2022-05-31"> <owner>curtismcmullan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -86,7 +89,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Coverage" enum="IMEAssistiveAction" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>jiwan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -96,7 +99,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Disabled" enum="IMEAssistiveAction" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>jiwan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -108,7 +111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Disabled.Emoji" - enum="IMEAssistiveDisabledReason" expires_after="2022-01-23"> + enum="IMEAssistiveDisabledReason" expires_after="2022-05-01"> <owner>myy@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -144,7 +147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.DismissedAccuracy.MultiWord" units="%" - expires_after="2021-10-04"> + expires_after="2022-05-31"> <owner>curtismcmullan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -156,7 +159,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.EmojiSuggestAddition.AcceptanceIndex" - units="times" expires_after="2022-01-23"> + units="times" expires_after="2022-05-01"> <owner>myy@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -167,7 +170,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Grammar.Actions" - enum="IMEGrammarActions" expires_after="2022-01-31"> + enum="IMEGrammarActions" expires_after="2022-03-31"> <owner>jiwan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -176,6 +179,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="InputMethod.Assistive.Grammar.CapitalizationCorrection" + enum="IMEGrammarActions" expires_after="2022-03-31"> + <owner>jiwan@google.com</owner> + <owner>essential-inputs-team@google.com</owner> + <summary> + The actions taken by on-device grammar checker, such as underlining a word. + Recorded after a grammar checker action is performed and the suggestion is + only correcting the capitalization of the text. + </summary> +</histogram> + <histogram name="InputMethod.Assistive.InsufficientData" enum="IMEAssistiveAction" expires_after="2022-01-02"> <owner>jiwan@google.com</owner> @@ -188,7 +202,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Match" enum="IMEAssistiveAction" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>jiwan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -201,7 +215,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.NotAllowed" enum="IMEAssistiveAction" - expires_after="2021-09-19"> + expires_after="2022-03-19"> <owner>jiwan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -213,7 +227,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.Success" enum="IMEAssistiveAction" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>jiwan@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -285,7 +299,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Assistive.UserPref.Emoji" enum="BooleanEnabled" - expires_after="2022-01-23"> + expires_after="2022-05-01"> <owner>myy@google.com</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -319,14 +333,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.AutoCorrectLevel" enum="IMECorrectionLevel" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary>The auto-correction level for suggestion engine.</summary> </histogram> <histogram name="InputMethod.Category" enum="InputMethodCategory" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -336,7 +350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.CharactersPerSession" units="characters" - expires_after="2021-11-01"> + expires_after="2022-06-30"> <owner>keithlee@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -360,7 +374,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Commit.Type2" enum="IMECommitType2" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>dvallet@chromium.org</owner> <owner>shuchen@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> @@ -388,7 +402,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Handwriting.Actions" enum="ImeHandwritingActions" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -398,7 +412,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Handwriting.AlternateMultiToSingle" units="index" - expires_after="2021-08-07"> + expires_after="2022-03-07"> <owner>curtismcmullan@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -409,7 +423,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Handwriting.AlternateSelected" units="index" - expires_after="2021-08-07"> + expires_after="2022-03-07"> <owner>curtismcmullan@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -419,7 +433,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Handwriting.AlternateSingleToMulti" units="index" - expires_after="2021-08-07"> + expires_after="2022-03-07"> <owner>curtismcmullan@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -430,7 +444,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Handwriting.CharsEdited10s" units="chars" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -440,7 +454,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.Handwriting.CharsEdited5s" units="chars" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -459,8 +473,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="InputMethod.Handwriting.LanguageModelLoadTime" units="ms" + expires_after="2022-06-01"> + <owner>curtismcmullan@chromium.org</owner> + <owner>essential-inputs-team@google.com</owner> + <summary> + The number of milliseconds taken to load the language model required for the + handwriting input method. Recorded every time a new language model is loaded + for the handwriting input method. + </summary> +</histogram> + <histogram name="InputMethod.ID2" enum="InputMethodID2" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>tranbaoduy@chromium.org</owner> <owner>shuchen@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> @@ -485,7 +510,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.ImeMenu.EmojiHandwritingVoiceButton" - enum="ImeMenuButtonType" expires_after="2021-12-12"> + enum="ImeMenuButtonType" expires_after="2022-05-01"> <owner>dvallet@chromium.org</owner> <owner>azurewei@chromium.org</owner> <owner>shuchen@chromium.org</owner> @@ -497,7 +522,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.ImeSwitch" enum="IMESwitchType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>dvallet@chromium.org</owner> <owner>shuchen@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> @@ -505,7 +530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.KeyEventLatency" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary>Time taken by the engine to handle a key event.</summary> @@ -668,6 +693,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="InputMethod.PhysicalKeyboard.Korean.Action" + enum="KoreanAction" expires_after="2022-03-31"> + <owner>shend@chromium.org</owner> + <owner>essential-inputs-team@google.com</owner> + <summary> + Action performed on the Korean IME. Recorded whenever one of the actions is + performed. + </summary> +</histogram> + +<histogram name="InputMethod.PhysicalKeyboard.Korean.Layout" + enum="KoreanLayout" expires_after="2022-03-31"> + <owner>shend@chromium.org</owner> + <owner>essential-inputs-team@google.com</owner> + <summary> + The layout used by the Korean IME. Recorded when the user focuses on a new + input field. + </summary> +</histogram> + +<histogram name="InputMethod.PhysicalKeyboard.Korean.MultipleSyllables" + enum="Boolean" expires_after="2022-03-31"> + <owner>shend@chromium.org</owner> + <owner>essential-inputs-team@google.com</owner> + <summary> + Whether multiple syllables is enabled by the Korean IME. Recorded when the + user focuses on a new input field. + </summary> +</histogram> + <histogram name="InputMethod.PkCommit.Index" units="units" expires_after="2021-10-10"> <owner>shend@chromium.org</owner> @@ -690,7 +745,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.SessionDuration" units="ms" - expires_after="2021-11-01"> + expires_after="2022-06-30"> <owner>keithlee@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -723,14 +778,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.SystemEmojiPicker.TriggerType" - enum="VirtualKeyboardEmojiTriggerType" expires_after="M95"> + enum="VirtualKeyboardEmojiTriggerType" expires_after="2022-04-17"> <owner>jopalmer@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary>How emojis were inserted.</summary> </histogram> <histogram name="InputMethod.VirtualKeyboard.BackspaceCount" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -774,7 +829,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.CharactersCommitted" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -784,7 +839,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.CharactersPerMinute" - units="charactersPerMinute" expires_after="2021-11-01"> + units="charactersPerMinute" expires_after="2022-06-30"> <owner>keithlee@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -798,7 +853,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.CharactersPerSession" - units="characters" expires_after="2021-11-01"> + units="characters" expires_after="2022-06-30"> <owner>keithlee@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -812,7 +867,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.ContainerBehavior" - enum="VirtualKeyboardContainerType" expires_after="2021-12-12"> + enum="VirtualKeyboardContainerType" expires_after="2022-04-24"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -833,7 +888,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.Duration" units="seconds" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary>How long the virtual keyboard was visible.</summary> @@ -849,7 +904,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.Emoji.TriggerType" - enum="VirtualKeyboardEmojiTriggerType" expires_after="2021-12-12"> + enum="VirtualKeyboardEmojiTriggerType" expires_after="2022-04-24"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary>How emojis were inserted.</summary> @@ -863,7 +918,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.FocusedByStylus" enum="Boolean" - expires_after="M95"> + expires_after="M100"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -911,7 +966,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.InitLatency.KeyboardShownLongTail" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-05-01"> <owner>jopalmer@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -945,7 +1000,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.Layout" enum="IMEVKLayout" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -978,7 +1033,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.Multipaste.Actions" - enum="IMEMultipasteAction" expires_after="2022-01-31"> + enum="IMEMultipasteAction" expires_after="2022-04-03"> <owner>jiwan@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -988,6 +1043,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="InputMethod.VirtualKeyboard.Paprika.Actions" + enum="IMEPaprikaActions" expires_after="M100"> + <owner>jopalmer@chromium.org</owner> + <owner>essential-inputs-team@google.com</owner> + <summary> + Type of action performed by the user in Paprika. Recorded when the action is + performed. Only for Chrome OS + </summary> +</histogram> + <histogram name="InputMethod.VirtualKeyboard.PreferredLayoutForStylus" enum="IMEVKLayout" expires_after="2021-12-12"> <owner>shend@chromium.org</owner> @@ -1021,7 +1086,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.SessionDuration" units="ms" - expires_after="2021-11-01"> + expires_after="2022-06-30"> <owner>keithlee@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> @@ -1036,7 +1101,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="InputMethod.VirtualKeyboard.SwitchMode" enum="IMEVKMode" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>shend@chromium.org</owner> <owner>essential-inputs-team@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/installer/histograms.xml b/chromium/tools/metrics/histograms/metadata/installer/histograms.xml index 72115185097..37888142b96 100644 --- a/chromium/tools/metrics/histograms/metadata/installer/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/installer/histograms.xml @@ -146,7 +146,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Installer.PowerwashCount" units="powerwashes" - expires_after="2021-12-29"> + expires_after="2022-04-10"> <owner>kimjae@chromium.org</owner> <owner>chromeos-core-services@chromium.org</owner> <summary> @@ -188,7 +188,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Installer.Recovery.Reason" enum="ChromeOSRecoveryReason" - expires_after="2021-12-29"> + expires_after="2022-04-10"> <owner>kimjae@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/interstitial/histograms.xml b/chromium/tools/metrics/histograms/metadata/interstitial/histograms.xml index a34ddded6c6..12718fd9827 100644 --- a/chromium/tools/metrics/histograms/metadata/interstitial/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/interstitial/histograms.xml @@ -27,6 +27,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.captive_portal" enum="CaptivePortalBlockingPageEvent" expires_after="M85"> + <obsolete> + Expired after M85. No longer in use. + </obsolete> <owner>meacer@chromium.org</owner> <summary> User action when the user is shown a captive portal error page. @@ -35,6 +38,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl.captive_portal" enum="SSLCaptivePortal" expires_after="M85"> + <obsolete> + Expired after M85. No longer in use. + </obsolete> <owner>meacer@chromium.org</owner> <summary> Record possible states of captive portals. This histogram is emitted @@ -46,7 +52,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="interstitial.ssl.cause.nonoverridable" enum="SSLErrorCauses" - expires_after="2021-10-25"> + expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>estark@chromium.org</owner> <owner>carlosil@chromium.org</owner> <summary> @@ -63,7 +71,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="interstitial.ssl.cause.overridable" enum="SSLErrorCauses" - expires_after="2021-11-07"> + expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>estark@chromium.org</owner> <owner>carlosil@chromium.org</owner> <summary> @@ -81,6 +91,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl.clockstate.build_time" enum="ClockStates" expires_after="M85"> + <obsolete> + Expired after M85. No longer in use. + </obsolete> <owner>mab@chromium.org</owner> <summary> State of the system clock, as inferred from the build timestamp, when an SSL @@ -90,6 +103,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl.clockstate.network3" enum="NetworkClockStates" expires_after="M85"> + <obsolete> + Expired after M85. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <owner>mab@chromium.org</owner> <summary> @@ -100,6 +116,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl.connection_type" enum="ResourcePrefetchPredictorNetworkType" expires_after="M77"> + <obsolete> + Expired after M77. No longer in use. + </obsolete> <owner>felt@chromium.org</owner> <owner>carlosil@chromium.org</owner> <summary> @@ -109,7 +128,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="interstitial.ssl.did_user_revoke_decisions2" - enum="BooleanRevoked" expires_after="2022-01-02"> + enum="BooleanRevoked" expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>carlosil@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -121,6 +142,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl.visited_site_after_warning" enum="Boolean" expires_after="M77"> + <obsolete> + Expired after M77. No longer in use. + </obsolete> <owner>carlosil@chromium.org</owner> <summary> Records when a user visits a site after clicking through a certificate @@ -129,7 +153,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="interstitial.ssl_error_handler" enum="SSLErrorHandlerEvent" - expires_after="M94"> + expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>meacer@chromium.org</owner> <owner>carlosil@chromium.org</owner> <owner>estark@chromium.org</owner> @@ -138,6 +164,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl_error_handler.cert_date_error_delay" units="ms" expires_after="M77"> + <obsolete> + Expired after M77. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <summary> When handling a certificate date error, Chrome (under certain Variations @@ -152,7 +181,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="interstitial.ssl_error_type" enum="SSLErrorTypes" - expires_after="2022-01-02"> + expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>estark@chromium.org</owner> <owner>carlosil@chromium.org</owner> <summary> @@ -163,6 +194,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl_nonoverridable.is_recurrent_error" enum="BooleanRecurrentError" expires_after="M72"> + <obsolete> + Expired after M72. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <summary> Recorded when a non-overridable SSL interstitial is shown. The value is true @@ -173,6 +207,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl_nonoverridable.is_recurrent_error.ct_error" enum="BooleanRecurrentError" expires_after="M72"> + <obsolete> + Expired after M72. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <summary> Recorded when a non-overridable SSL interstitial is shown for a Certificate @@ -184,6 +221,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl_overridable.is_recurrent_error" enum="BooleanRecurrentError" expires_after="M72"> + <obsolete> + Expired after M72. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <summary> Recorded when an overridable SSL interstitial is shown. The value is true if @@ -194,6 +234,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl_overridable.is_recurrent_error.ct_error" enum="BooleanRecurrentError" expires_after="M72"> + <obsolete> + Expired after M72. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <summary> Recorded when an overridable SSL interstitial is shown for a Certificate @@ -205,6 +248,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl_recurrent_error.action" enum="RecurrentErrorAction" expires_after="M72"> + <obsolete> + Expired after M72. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <summary> Recorded whenever the user sees or proceeds through an SSL interstitial for @@ -215,6 +261,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.ssl_recurrent_error.ct_error.action" enum="RecurrentErrorAction" expires_after="M72"> + <obsolete> + Expired after M72. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <summary> Recorded whenever the user sees or proceeds through an SSL interstitial for @@ -224,9 +273,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="interstitial.{SecurityInterstitialLookalikeType}decision" - enum="SecurityInterstitialDecision" expires_after="M94"> + enum="SecurityInterstitialDecision" expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>estark@chromium.org</owner> <owner>carlosil@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> User decision when presented with a security interstitial. As of M44, subresource interstitials were split into their own entries. As of M52, @@ -246,7 +298,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="interstitial.{SecurityInterstitialLookalikeType}decision.repeat_visit" - enum="SecurityInterstitialDecision" expires_after="M94"> + enum="SecurityInterstitialDecision" expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>carlosil@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -265,7 +319,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="interstitial.{SecurityInterstitialLookalikeType}interaction" - enum="SecurityInterstitialInteraction" expires_after="M94"> + enum="SecurityInterstitialInteraction" expires_after="never"> +<!-- expires-never: Used for long term monitoring of security errors --> + <owner>estark@chromium.org</owner> <owner>carlosil@chromium.org</owner> <summary> @@ -284,7 +340,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TypedNavigationUpgradeThrottle.Event" - enum="TypedNavigationUpgradeThrottleEvent" expires_after="2021-12-12"> + enum="TypedNavigationUpgradeThrottleEvent" expires_after="2022-04-10"> <owner>meacer@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -296,6 +352,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="TypedNavigationUpgradeThrottle.UpgradeFailTime" units="ms" expires_after="2021-08-09"> + <obsolete> + Expired after 2021-08. No longer in use. + </obsolete> <owner>meacer@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -308,6 +367,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="TypedNavigationUpgradeThrottle.UpgradeSuccessTime" units="ms" expires_after="2021-08-09"> + <obsolete> + Expired after 2021-08. No longer in use. + </obsolete> <owner>meacer@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/invalidation/histograms.xml b/chromium/tools/metrics/histograms/metadata/invalidation/histograms.xml index 37e40ee9e66..b2ba640f29e 100644 --- a/chromium/tools/metrics/histograms/metadata/invalidation/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/invalidation/histograms.xml @@ -159,6 +159,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Invalidations.GCMUpstreamRequest" + enum="GCMUpstreamMessageStatus" expires_after="M76"> + <owner>nyquist@chromium.org</owner> + <owner>khushalsagar@chromium.org</owner> + <owner>melandory@chromium.org</owner> + <summary> + Status of sending outgoing invalidation message through GCM upsteam. + </summary> +</histogram> + <histogram name="Invalidations.StatusChanged" enum="InvalidatorState" expires_after="M85"> <obsolete> diff --git a/chromium/tools/metrics/histograms/metadata/ios/histograms.xml b/chromium/tools/metrics/histograms/metadata/ios/histograms.xml index c1c9695f85c..527dc811e5b 100644 --- a/chromium/tools/metrics/histograms/metadata/ios/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/ios/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="IOS.Allocator.ShimInstalled" enum="Boolean" - expires_after="2022-01-28"> + expires_after="2022-04-10"> <owner>rohitrao@chromium.org</owner> <owner>justincohen@chromium.org</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.CommittedNavigationHasContext" enum="Boolean" - expires_after="2021-09-24"> + expires_after="2022-09-24"> <owner>ajuma@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> @@ -46,7 +46,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.CommittedURLMatchesCurrentItem" enum="Boolean" - expires_after="2021-09-24"> + expires_after="2022-09-24"> <owner>ajuma@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> @@ -59,7 +59,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.ContentExtension.DisplayCount" units="count" - expires_after="2021-12-11"> + expires_after="2022-04-24"> <owner>javierrobles@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -150,7 +150,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.CredentialExtension.DisplayCount" units="count" - expires_after="2021-12-11"> + expires_after="2022-04-10"> <owner>javierrobles@chromium.org</owner> <owner>djean@chromium.org</owner> <summary> @@ -193,8 +193,30 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="IOS.CredentialExtension.NewCredentialUsername" + enum="IOSCredentialProviderNewCredentialUsername" + expires_after="2022-03-31"> + <owner>javierrobles@chromium.org</owner> + <owner>rkgibson@google.com</owner> + <summary> + Recorded when a new credential is created via the Credential Provider + extension and tracks the username state of the new credential. Reported when + Chrome is put in the foreground. + </summary> +</histogram> + +<histogram name="IOS.CredentialExtension.PasswordCreated" + enum="IOSCredentialProviderPasswordCreated" expires_after="2022-03-31"> + <owner>javierrobles@chromium.org</owner> + <owner>rkgibson@google.com</owner> + <summary> + Recorded when a new password is created via the Credential Provider + extension. Reported when Chrome is put in the foreground. + </summary> +</histogram> + <histogram name="IOS.CredentialExtension.PasswordUseCount" units="count" - expires_after="2021-12-11"> + expires_after="2022-04-10"> <owner>javierrobles@chromium.org</owner> <owner>djean@chromium.org</owner> <summary> @@ -205,7 +227,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.CredentialExtension.QuickPasswordUseCount" units="count" - expires_after="2021-12-11"> + expires_after="2022-04-24"> <owner>javierrobles@chromium.org</owner> <owner>djean@chromium.org</owner> <summary> @@ -238,7 +260,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.CredentialExtension.SearchCount" units="count" - expires_after="2021-12-11"> + expires_after="2022-04-10"> <owner>javierrobles@chromium.org</owner> <owner>djean@chromium.org</owner> <summary> @@ -261,7 +283,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.CredentialExtension.ShowPasswordCount" units="count" - expires_after="2021-12-11"> + expires_after="2022-04-24"> <owner>javierrobles@chromium.org</owner> <owner>djean@chromium.org</owner> <summary> @@ -314,7 +336,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.DefaultBrowserFullscreenPromoRemindMe" - enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-01-16"> + enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-04-10"> <owner>thegreenfrog@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -324,7 +346,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.DefaultBrowserFullscreenPromoRemindMeSecondPromo" - enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2021-12-19"> + enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-04-10"> <owner>thegreenfrog@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -334,7 +356,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.DefaultBrowserFullscreenTailoredPromoAllTabs" - enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-02-01"> + enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-04-03"> <owner>javierrobles@chromium.org</owner> <owner>rkgibson@chromium.org</owner> <summary> @@ -344,7 +366,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.DefaultBrowserFullscreenTailoredPromoMadeForIOS" - enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-02-01"> + enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-04-03"> <owner>javierrobles@chromium.org</owner> <owner>rkgibson@chromium.org</owner> <summary> @@ -354,7 +376,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.DefaultBrowserFullscreenTailoredPromoStaySafe" - enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-02-01"> + enum="IOSDefaultBrowserFullscreenPromoAction" expires_after="2022-04-03"> <owner>javierrobles@chromium.org</owner> <owner>rkgibson@chromium.org</owner> <summary> @@ -477,7 +499,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.FinishedURLMatchesCurrentItem" enum="Boolean" - expires_after="2021-10-26"> + expires_after="2022-10-26"> <owner>ajuma@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> @@ -509,9 +531,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.Incognito.BiometricAuthEnabled" enum="Boolean" - expires_after="2021-11-05"> + expires_after="2022-09-20"> <owner>stkhapugin@chromium.org</owner> - <owner>javierrobles@chromium.org</owner> + <owner>gambard@chromium.org</owner> <summary> Logged once per app launch. Logs whether the biometric incognito authentication setting is enabled. This metric is designed to measure % of @@ -520,6 +542,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="IOS.Incognito.BiometricReauthAttemptSuccessful" enum="Boolean" + expires_after="2022-09-20"> + <owner>stkhapugin@chromium.org</owner> + <owner>gambard@chromium.org</owner> + <summary> + Logged when the user attempt to reauthenticate to display the incognito + tabs. This metric is designed to measure the success of the reauth. + </summary> +</histogram> + <histogram name="IOS.Incognito.TimeSpent" units="ms" expires_after="2022-01-16"> <owner>olivierrobin@chromium.org</owner> <owner>thegreenfrog@chromium.org</owner> @@ -579,7 +611,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.IsEligibleDefaultBrowserPromoUser" enum="BooleanEligible" - expires_after="2021-09-21"> + expires_after="2022-10-21"> <owner>thegreenfrog@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -612,7 +644,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.LocationPermissions.FirstRunModal.Interaction" - enum="LocationPermissionsFirstRunModalIOSEnum" expires_after="2021-12-05"> + enum="LocationPermissionsFirstRunModalIOSEnum" expires_after="2022-04-17"> <owner>thegreenfrog@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -621,7 +653,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.LocationPermissionsUI" enum="LocationPermissionsIOSUI" - expires_after="2021-12-05"> + expires_after="M96"> + <obsolete> + Deprecated 09/2021 as it is launched + </obsolete> <owner>thegreenfrog@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -691,7 +726,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.MetricKit.ApplicationResumeTime" units="ms" - expires_after="2021-11-14"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -704,7 +739,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.MetricKit.AverageSuspendedMemory" units="MB" - expires_after="2021-10-31"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -744,7 +779,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.MetricKit.BackgroundTimePerDay" units="ms" - expires_after="2021-10-04"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -787,7 +822,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.MetricKit.ForegroundTimePerDay" units="s" - expires_after="2021-11-21"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -805,7 +840,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.MetricKit.PeakMemoryUsage" units="MB" - expires_after="2022-01-23"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -824,7 +859,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.MetricKit.TimeToFirstDraw" units="ms" - expires_after="2022-01-23"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -864,7 +899,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.NTP.Impression" enum="IOSNTPImpression" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>gambard@chromium.org</owner> <summary> The type of NTP impressions on iOS, split by type of suggestions shown @@ -894,7 +929,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.PageLoadCount.Counts" - enum="IOSPageLoadCountNavigationType" expires_after="2021-12-19"> + enum="IOSPageLoadCountNavigationType" expires_after="2022-04-10"> <owner>gambard@chromium.org</owner> <owner>bling-team@google.com</owner> <summary>The number of navigation started events by navigation type.</summary> @@ -930,6 +965,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="IOS.ReadingList.ImageTooLargeFailure" units="KB" + expires_after="2022-06-11"> + <owner>olivierrobin@chromium.org</owner> + <owner>justincohen@chromium.org</owner> + <summary> + Distillation of the page failed because an image was too big (>1MB). + Recorded on distillation attempt. + </summary> +</histogram> + <histogram name="IOS.ReadingList.Javascript.ExecutionTime" units="ms" expires_after="2022-06-11"> <owner>thegreenfrog@chromium.org</owner> @@ -977,8 +1022,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="IOS.ReadingList.PageTooLargeFailure" units="KB" + expires_after="2022-06-11"> + <owner>olivierrobin@chromium.org</owner> + <owner>justincohen@chromium.org</owner> + <summary> + Distillation of the page failed because the page was too big (>10MB). + Recorded on distillation attempt. + </summary> +</histogram> + <histogram name="IOS.Reauth.Password.Autofill" enum="ReauthenticationEvent" - expires_after="2021-12-11"> + expires_after="2022-05-01"> <owner>javierrobles@chromium.org</owner> <owner>sarraf@google.com</owner> <summary> @@ -988,7 +1043,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.Reauth.Password.ManualFallback" - enum="ReauthenticationEvent" expires_after="2021-12-11"> + enum="ReauthenticationEvent" expires_after="2022-05-01"> <owner>javierrobles@chromium.org</owner> <owner>sarraf@google.com</owner> <summary> @@ -1020,7 +1075,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.RestoreNavigationItemCount" units="rank" - expires_after="2021-11-07"> + expires_after="2022-09-12"> <owner>gambard@chromium.org</owner> <owner>justincohen@chromium.org</owner> <summary> @@ -1034,7 +1089,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.RestoreNavigationTime" units="ms" - expires_after="2021-11-07"> + expires_after="2022-09-12"> <owner>gambard@chromium.org</owner> <owner>justincohen@chromium.org</owner> <summary> @@ -1048,7 +1103,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.SafeBrowsing.RedirectedRequestResponseHostsMatch" - enum="BooleanMatched" expires_after="2021-11-06"> + enum="BooleanMatched" expires_after="2022-11-06"> <owner>ajuma@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> @@ -1103,7 +1158,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.ShareExtension.ReceivedEntry" - enum="IOSShareExtensionReceivedEntryType" expires_after="2021-12-11"> + enum="IOSShareExtensionReceivedEntryType" expires_after="2022-05-01"> <owner>javierrobles@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary>Type of the item received from the iOS share extension.</summary> @@ -1120,7 +1175,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.ShareExtension.Source" - enum="IOSShareExtensionReceivedEntrySource" expires_after="2021-12-11"> + enum="IOSShareExtensionReceivedEntrySource" expires_after="2022-05-01"> <owner>javierrobles@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -1155,7 +1210,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="IOS.Snapshots.CacheSize" units="KB" expires_after="2021-11-14"> +<histogram name="IOS.Snapshots.CacheSize" units="KB" expires_after="2022-11-14"> <owner>ajuma@chromium.org</owner> <owner>edchin@chromium.org</owner> <summary> @@ -1163,7 +1218,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="IOS.Snapshots.ImageSize" units="KB" expires_after="2021-11-28"> +<histogram name="IOS.Snapshots.ImageSize" units="KB" expires_after="2022-05-01"> <owner>ajuma@chromium.org</owner> <owner>edchin@chromium.org</owner> <summary> @@ -1289,7 +1344,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.TabSwitcher.PageChangeInteraction" - enum="IOSTabSwitcherPageChangeInteraction" expires_after="M99"> + enum="IOSTabSwitcherPageChangeInteraction" expires_after="2022-05-01"> <owner>marq@chromium.org</owner> <owner>bling-team@google.com</owner> <summary> @@ -1299,7 +1354,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.TabSwitcher.TimeSpent" units="ms" - expires_after="2022-01-28"> + expires_after="2022-05-01"> <owner>mrefaat@chromium.org</owner> <owner>marq@chromium.org</owner> <summary> @@ -1309,7 +1364,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.Web.URLDidChangeToEmptyURL" enum="BooleanHit" - expires_after="2021-11-30"> + expires_after="2022-05-01"> <owner>gambard@chromium.org</owner> <owner>justincohen@chromium.org</owner> <summary> @@ -1320,7 +1375,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="IOS.WidgetKit.Action" enum="IOSWidgetKitAction" - expires_after="2021-12-11"> + expires_after="2022-04-03"> <owner>javierrobles@chromium.org</owner> <owner>muradyan@google.com</owner> <summary> @@ -1348,8 +1403,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="IOS.WindowIDInjection.ElapsedTime" units="ms" + expires_after="2022-04-17"> + <owner>michaeldo@chromium.org</owner> + <owner>rohitrao@chromium.org</owner> + <summary> + Measures the time taken for windowID injection to complete. Logged once per + pageload. + </summary> +</histogram> + <histogram name="IOS.WKWebViewClobberedHistory" enum="Boolean" - expires_after="2021-09-24"> + expires_after="2022-09-24"> <owner>ajuma@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/local/histograms.xml b/chromium/tools/metrics/histograms/metadata/local/histograms.xml index fafac2c6eea..ee2b3f2e1cc 100644 --- a/chromium/tools/metrics/histograms/metadata/local/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/local/histograms.xml @@ -280,7 +280,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LocalStorage.RendererAreaCacheHit" - enum="LocalStorageRendererAreaCacheHitEnum" expires_after="M97"> + enum="LocalStorageRendererAreaCacheHitEnum" expires_after="2022-05-01"> <owner>mek@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/login/histograms.xml b/chromium/tools/metrics/histograms/metadata/login/histograms.xml index ea26866f949..5f53a3a486e 100644 --- a/chromium/tools/metrics/histograms/metadata/login/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/login/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Login.ArcBugReportBackupTime" units="ms" - expires_after="2021-10-30"> + expires_after="2022-03-30"> <owner>mhasank@google.com</owner> <owner>arc-core@google.com</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.ArcContinueBootImpulseTime" units="ms" - expires_after="2021-10-30"> + expires_after="2022-03-30"> <owner>mhasank@google.com</owner> <owner>arc-core@google.com</owner> <summary> @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.BrowserShutdownTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>xiyuan@chromium.org</owner> <summary> Tracks the browser process shutdown time from when SIGTERM is sent to the @@ -77,7 +77,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.FailureReason" enum="LoginFailureReason" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>achuith@chromium.org</owner> <summary>Chrome OS login failure reason.</summary> </histogram> @@ -129,7 +129,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.OfflineLoginWithHiddenUserPods" - enum="ChromeOSHiddenUserPodsOfflineLogin" expires_after="M95"> + enum="ChromeOSHiddenUserPodsOfflineLogin" expires_after="M105"> <owner>mslus@chromium.org</owner> <owner>chromeos-commercial-identity@google.com</owner> <summary> @@ -138,7 +138,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.OfflineSuccess.Attempts" units="units" - expires_after="2022-01-23"> + expires_after="2022-04-17"> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> @@ -157,7 +157,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.PasswordChanged.ReauthReason" enum="LoginReauthReasons" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> @@ -168,6 +168,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Login.PasswordChangeFlow" enum="LoginPasswordChangeFlow" expires_after="2021-10-10"> + <obsolete> + Removed in M96. + </obsolete> <owner>xiyuan@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -176,7 +179,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.PasswordNotChanged.ReauthReason" - enum="LoginReauthReasons" expires_after="2022-01-23"> + enum="LoginReauthReasons" expires_after="2022-04-10"> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> @@ -186,7 +189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.PasswordStoreSites.InitializedBeforeQuery" - enum="Boolean" expires_after="2022-01-30"> + enum="Boolean" expires_after="2022-04-03"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -204,7 +207,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.PromptToCompleteLoginTime" units="ms" - expires_after="2022-01-16"> + expires_after="2022-04-24"> <owner>rsorokin@chromium.org</owner> <owner>achuith@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -214,7 +217,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Login.PromptToLoginTime" units="ms" expires_after="2022-01-23"> +<histogram name="Login.PromptToLoginTime" units="ms" expires_after="2022-04-10"> <owner>elijahtaylor@google.com</owner> <owner>yusukes@chromium.org</owner> <owner>rsorokin@chromium.org</owner> @@ -226,7 +229,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.SessionExitType" enum="LoginSessionExitType" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>iby@chromium.org</owner> <summary> Tracks whether a ChromeOS user was logged out because Chrome repeatedly @@ -241,13 +244,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.SuccessReason" enum="LoginSuccessReason" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>achuith@chromium.org</owner> <summary>Chrome OS login success reason.</summary> </histogram> <histogram name="Login.SwitchToFeatureFlagMappingStatus" - enum="LoginFeatureFlagMappingStatus" expires_after="2021-11-30"> + enum="LoginFeatureFlagMappingStatus" expires_after="2022-04-10"> <owner>mnissler@chromium.org</owner> <owner>xiyuan@chromium.org</owner> <summary> @@ -260,7 +263,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.TokenCheckResponseTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> @@ -282,7 +285,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.UsersActive28Days" units="users" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>alemate@chromium.org</owner> <owner>achuith@chromium.org</owner> <summary> @@ -292,7 +295,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.UsersActiveDaily" units="users" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>alemate@chromium.org</owner> <owner>achuith@chromium.org</owner> <summary> @@ -302,7 +305,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.UsersActiveWeekly" units="users" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>alemate@chromium.org</owner> <owner>achuith@chromium.org</owner> <summary> @@ -323,7 +326,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Login.UserType" enum="LoginUserType" - expires_after="2021-12-19"> + expires_after="2022-04-17"> <owner>cmasone@chromium.org</owner> <summary> Chrome OS histogram that keeps track of the way a user logs in and whether diff --git a/chromium/tools/metrics/histograms/metadata/media/histograms.xml b/chromium/tools/metrics/histograms/metadata/media/histograms.xml index cc13064a8a8..23aa309404a 100644 --- a/chromium/tools/metrics/histograms/metadata/media/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/media/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Media.AImageReaderGLOwner.AcquireImageResult" - enum="MediaStatus" expires_after="2021-11-25"> + enum="MediaStatus" expires_after="2022-04-17"> <owner>vikassoni@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -34,7 +34,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AImageReaderGLOwner.HasFence" enum="Boolean" - expires_after="2022-01-08"> + expires_after="2022-04-10"> <owner>vasilyt@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -60,14 +60,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Android.MediaPlayerSuccess" enum="MediaPlayerExitStatus" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>tguilbert@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary>Android: Whether MediaPlayer exited without errors.</summary> </histogram> <histogram name="Media.Android.MediaPlayerWatchTime" - enum="MediaPlayerWatchTimeType" expires_after="2022-02-06"> + enum="MediaPlayerWatchTimeType" expires_after="2022-05-01"> <owner>sandersd@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -146,14 +146,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Autoplay" enum="AutoplaySource" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary>Records the autoplay source of audios.</summary> </histogram> <histogram name="Media.Audio.Capture.DetectedMissingCallbacks" - enum="BooleanMissingCallbacks" expires_after="2022-02-06"> + enum="BooleanMissingCallbacks" expires_after="2022-04-10"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -163,7 +163,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.FramesProvided" units="frames" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>guidou@chromium.org</owner> <owner>armax@chromium.org</owner> <summary> @@ -182,7 +182,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.Glitches" units="glitches" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -214,7 +214,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.LargestGlitchMs" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -225,7 +225,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.LostFramesInMs" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -237,7 +237,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.LowLatencyCallbackError" - enum="BooleanError" expires_after="2021-12-12"> + enum="BooleanError" expires_after="2022-04-17"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -337,7 +337,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.Win.Glitches" units="glitches" - expires_after="2021-10-08"> + expires_after="2022-10-08"> <owner>henrika@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -350,7 +350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.Win.InitError" enum="Hresult" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>tommi@chromium.org</owner> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> @@ -361,7 +361,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.Win.InitError.FormatRelated" - enum="AudioStreamFormatRelatedInitError" expires_after="2021-12-12"> + enum="AudioStreamFormatRelatedInitError" expires_after="2022-04-17"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -374,6 +374,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.Audio.Capture.Win.MonotonicTimestamps" enum="BooleanSuccess" expires_after="2021-10-08"> + <obsolete> + Removed as of 2021-09-30. + </obsolete> <owner>henrika@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -386,7 +389,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Capture.Win.Open" enum="AudioStreamOpenResult" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>gudiou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -396,6 +399,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.Audio.Capture.Win.TimestampErrors" units="errors" expires_after="2021-10-08"> + <obsolete> + Removed as of 2021-09-30. + </obsolete> <owner>henrika@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -409,6 +415,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.Audio.Capture.Win.TimeUntilFirstTimestampError" units="ms" expires_after="2021-10-08"> + <obsolete> + Removed as of 2021-09-30. + </obsolete> <owner>henrika@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -542,7 +551,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.InputStartupSuccessMac" enum="BooleanSuccess" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>henrika@chromium.org</owner> <owner>webrtc-audio@google.com</owner> <summary> @@ -573,7 +582,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.MaxOutputStreamsPerInputStream" units="streams" - expires_after="M99"> + expires_after="2022-04-10"> <owner>saza@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -604,7 +613,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.OutputDeviceAuthorizationTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>armax@chromium.org</owner> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> @@ -670,7 +679,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Processing.TotalDelayMs" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>armax@chromium.org</owner> <owner>guidou@chromium.org</owner> <summary> @@ -691,7 +700,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.RawProcessingSupportedWin" enum="BooleanSupported" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>henrika@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -703,7 +712,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.FramesRequested" units="frames" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -718,7 +727,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.GetSourceDataTime.WebRTC" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-05-01"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -735,7 +744,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.GetSourceDataTimeMax.WebRTC" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-02-13"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -752,7 +761,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.Glitches" units="glitches" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -763,7 +772,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.LargestGlitchMs" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -774,7 +783,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.LostFramesInMs" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -786,7 +795,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.OutputDeviceAuthorizationTime" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>olka@chromium.org</owner> <owner>henrika@chromium.org</owner> <summary> @@ -802,7 +811,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.OutputDeviceAuthorizationTimedOut" - enum="BooleanTimedOut" expires_after="2022-01-30"> + enum="BooleanTimedOut" expires_after="2022-04-03"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -812,7 +821,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Audio.Render.OutputDeviceStatus" - enum="OutputDeviceStatus" expires_after="2021-12-12"> + enum="OutputDeviceStatus" expires_after="2022-04-17"> <owner>dalecurtis@chromium.org</owner> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> @@ -835,7 +844,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.Audio.Render.SinkCache.GetOutputDeviceInfoCacheUtilization" - enum="GetOutputDeviceInfoCacheHit" expires_after="2021-12-12"> + enum="GetOutputDeviceInfoCacheHit" expires_after="2022-05-01"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -967,7 +976,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AudioCapturerAudioGlitches" enum="AudioGlitchResult" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -977,7 +986,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AudioCapturerDroppedData" units="%" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -988,9 +997,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AudioCapturerMissedReadDeadline" units="%" - expires_after="2021-10-04"> - <owner>gudou@chromium.org</owner> + expires_after="2022-10-04"> <owner>olka@chromium.org</owner> + <owner>gudou@chromium.org</owner> <summary> The percentage of input audio data blocks that had to be buffered because there was not room in the shared memory ring buffer on the browser/renderer @@ -1007,7 +1016,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AudioCodecProfile.AAC" enum="AudioCodecProfile" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary>Audio codec profile used in HTML5 media for AAC playback.</summary> @@ -1049,9 +1058,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AudioOutputController.CallbackError" enum="BooleanError" - expires_after="2021-10-09"> - <owner>guidou@chromium.org</owner> + expires_after="2022-10-09"> <owner>olka@chromium.org</owner> + <owner>guidou@chromium.org</owner> <summary> A boolean that reflects whether or not an error was reported during audio rendering, reported after a stream has stopped, if it was started. @@ -1122,10 +1131,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.AudioOutputResampler.OpenLowLatencyStream" enum="AudioOutputResamplerLowLatencyOpenStreamResult" - expires_after="2021-10-09"> + expires_after="2022-10-09"> + <owner>olka@chromium.org</owner> <owner>armax@chromium.org</owner> <owner>guidou@chromium.org</owner> - <owner>olka@chromium.org</owner> <summary> Whether a low latency stream to be rendered through the resampler was opened successfully or which type of fallback stream was used instead. In case a @@ -1215,7 +1224,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AudioRendererAudioGlitches" enum="AudioGlitchResult" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>henrika@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -1225,7 +1234,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.AudioRendererImpl.SinkStatus" enum="OutputDeviceStatus" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>armax@chromium.org</owner> <owner>dalecurtis@chromium.org</owner> <owner>guidou@chromium.org</owner> @@ -1331,7 +1340,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Capabilities.DecodingInfo.Time.Video" units="ms" - expires_after="2021-12-05"> + expires_after="never"> +<!-- expires-never: performance monitoring. --> + <owner>chcunningham@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1341,7 +1352,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Capabilities.DecodingInfo.Time.Video.Clear" units="ms" - expires_after="2021-10-10"> + expires_after="never"> +<!-- expires-never: performance monitoring. --> + <owner>chcunningham@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1353,7 +1366,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Capabilities.DecodingInfo.Time.Video.Encrypted" - units="ms" expires_after="2021-01-15"> + units="ms" expires_after="never"> +<!-- expires-never: performance monitoring. --> + <owner>chcunningham@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1385,8 +1400,54 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Media.ConditionalFocus.Decision" + enum="ConditionalFocusDecision" expires_after="2022-08-26"> + <owner>eladalon@chromium.org</owner> + <owner>toprice@chromium.org</owner> + <summary> + Records (1) explicit conditional-focus API invocations, (2) microtask-borne + decisions and (3) timer-triggered decisions. + </summary> +</histogram> + +<histogram name="Media.ConditionalFocus.ExplicitLateCall" units="ms" + expires_after="2022-08-26"> + <owner>eladalon@chromium.org</owner> + <owner>toprice@chromium.org</owner> + <summary> + Records the delay experienced by late explicit invocations of the focus() + API. By "late" we mean those calls which had no effect, on account + of arriving after the browser-side timer forced an implicit decision. (Note + that post-microtask explicit invocations are not recorded. They're simply an + application error.) + </summary> +</histogram> + +<histogram name="Media.ConditionalFocus.ExplicitOnTimeCall" units="ms" + expires_after="2022-08-26"> + <owner>eladalon@chromium.org</owner> + <owner>toprice@chromium.org</owner> + <summary> + Records the delay experienced by on-time explicit invocations of the focus() + API. By "on-time" we mean those calls which had an effect, on + account of arriving before either the microtask or the browser-side timer + forced an implicit decision. + </summary> +</histogram> + +<histogram name="Media.ConditionalFocus.MicrotaskDelay" units="ms" + expires_after="2022-08-26"> + <owner>eladalon@chromium.org</owner> + <owner>toprice@chromium.org</owner> + <summary> + Track the delay distribution of invocations of the microtask. Measure this + independently of whether an explicit API call was made, and independently of + whether the browser-side timer expired. + </summary> +</histogram> + <histogram base="true" name="Media.ConfigChangeDecoderSelectionTime" units="ms" - expires_after="2021-09-25"> + expires_after="2022-06-25"> <owner>cassew@google.com</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1419,7 +1480,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Controls.Show.Audio" enum="MediaControlsShowReason" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>steimel@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1431,7 +1492,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Controls.Show.Video" enum="MediaControlsShowReason" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>steimel@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1451,7 +1512,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.CrosGlobalMediaControls.PinAction" enum="BooleanPinned" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>jazzhsue@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1460,7 +1521,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.CrosGlobalMediaControls.QuickSettingUserAction" - enum="MediaSessionAction" expires_after="2021-12-12"> + enum="MediaSessionAction" expires_after="2022-04-24"> <owner>jazzhsue@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1469,7 +1530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.CrosGlobalMediaControls.RepeatUsageInQuickSetting" - enum="BooleanIsRepeat" expires_after="2021-12-12"> + enum="BooleanIsRepeat" expires_after="2022-05-01"> <owner>jazzhsue@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1479,7 +1540,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.CrosGlobalMediaControls.RepeatUsageOnShelf" - enum="BooleanIsRepeat" expires_after="2021-12-12"> + enum="BooleanIsRepeat" expires_after="2022-04-24"> <owner>jazzhsue@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -1499,7 +1560,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.D3D11.DecoderLifetimeProgression" - enum="D3D11LifetimeProgression" expires_after="2021-12-19"> + enum="D3D11LifetimeProgression" expires_after="2022-05-01"> <owner>liberato@chromium.org</owner> <owner>tmathmeyer@chromium.org</owner> <summary> @@ -1510,7 +1571,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.D3D11.H264Status" enum="MediaStatusCode" - expires_after="2021-11-14"> + expires_after="2022-05-01"> <owner>liberato@chromium.org</owner> <owner>tmathmeyer@chromium.org</owner> <summary> @@ -1631,7 +1692,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.DXVAVDA.DecoderLifetimeProgression" - enum="DXVALifetimeProgression" expires_after="2021-12-19"> + enum="DXVALifetimeProgression" expires_after="2022-04-24"> <owner>liberato@chromium.org</owner> <owner>tmathmeyer@chromium.org</owner> <summary> @@ -1653,7 +1714,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.DXVAVDA.UseD3D11" enum="DXVADXVersion" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>liberato@chromium.org</owner> <owner>tmathmeyer@chromium.org</owner> <owner>sandersd@chromium.org</owner> @@ -1692,7 +1753,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Media.EME.CdmFileIO.TimeTo" units="ms" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>jrummell@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2194,7 +2255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.GlobalMediaControls.DismissReason" - enum="GlobalMediaControlsDismissReason" expires_after="2021-12-26"> + enum="GlobalMediaControlsDismissReason" expires_after="2022-04-24"> <owner>steimel@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2205,7 +2266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.GlobalMediaControls.EntryPoint" - enum="GlobalMediaControlsEntryPoint" expires_after="2022-02-01"> + enum="GlobalMediaControlsEntryPoint" expires_after="2022-04-03"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <owner>media-dev@chromium.org</owner> @@ -2216,7 +2277,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.GlobalMediaControls.HasDefaultPresentationRequest" - enum="Boolean" expires_after="2022-02-01"> + enum="Boolean" expires_after="2022-04-24"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <owner>media-dev@chromium.org</owner> @@ -2228,7 +2289,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.GlobalMediaControls.InteractionDelayAfterPause" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-05-01"> <owner>steimel@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2251,7 +2312,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.GlobalMediaControls.RepeatUsage" enum="BooleanIsRepeat" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>steimel@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2262,7 +2323,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.GlobalMediaControls.UserActionFocus" - enum="BooleanFocused" expires_after="2022-02-06"> + enum="BooleanFocused" expires_after="2022-05-01"> <owner>steimel@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2291,6 +2352,29 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Media.GpuArcVideoDecodeAccelerator.InstanceCount.All" + units="instances" expires_after="2022-09-15"> + <owner>andrescj@chromium.org</owner> + <owner>chromeos-gfx-video@google.com</owner> + <summary> + Counts how many GpuArcVideoDecodeAccelerator instances are alive at the time + a new GpuArcVideoDecodeAccelerator is created. + </summary> +</histogram> + +<histogram name="Media.GpuArcVideoDecodeAccelerator.InstanceCount.Initialized" + units="instances" expires_after="2022-09-15"> + <owner>andrescj@chromium.org</owner> + <owner>chromeos-gfx-video@google.com</owner> + <summary> + Counts how many GpuArcVideoDecodeAccelerator instances that have gone + through initialization (i.e., have an underlying + media::VideoDecodeAccelerator) are alive at the time a + GpuArcVideoDecodeAccelerator goes through initialization and successfully + creates its underlying media::VideoDecodeAccelerator. + </summary> +</histogram> + <histogram name="Media.GpuMemoryBufferVideoFramePool.UnsupportedFormat" enum="VideoPixelFormatUnion" expires_after="2022-01-06"> <owner>dcastagna@chromium.org</owner> @@ -2426,7 +2510,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Media.InitialDecoderSelectionTime" units="ms" - expires_after="2021-09-25"> + expires_after="2022-06-25"> <owner>cassew@google.com</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2459,7 +2543,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.InputStreamDurationWithoutCallback" units="ms" - expires_after="2021-12-12"> + expires_after="2022-12-12"> <owner>olka@chromium.org</owner> <owner>henrika@chromium.org</owner> <summary> @@ -2640,6 +2724,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.LinuxAudioIO" enum="LinuxAudioIO" expires_after="2021-10-25"> + <obsolete> + Deprecated as of 2021/09. + </obsolete> <owner>dalecurtis@chromium.org</owner> <summary> Audio IO layer used by the Linux OS, sampled once at startup of the browser. @@ -2696,7 +2783,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.LowLatencyAudioCaptureStartupSuccess" - enum="AudioCaptureStartupResult" expires_after="2022-02-06"> + enum="AudioCaptureStartupResult" expires_after="2022-04-10"> <owner>armax@chromium.org</owner> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> @@ -2718,7 +2805,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.MeanTimeBetweenRebuffers" units="ms" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>dalecurtis@chromium.org</owner> <summary> The total watch time (see Media.WatchTime) of a given playback divided by @@ -2727,7 +2814,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.MediaElement.ContentTypeParseable" - enum="ContentTypeParseableResult" expires_after="2021-12-19"> + enum="ContentTypeParseableResult" expires_after="2022-05-01"> <owner>jrummell@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2768,6 +2855,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Media.MediaFoundationRenderer.PlaybackError" enum="Hresult" + expires_after="2022-08-30"> + <owner>xhwang@chromium.org</owner> + <owner>media-dev@chromium.org</owner> + <summary> + Recorded when the MediaFoundationRenderer his a playback error. Some errors + are part of the normal user flow (e.g. sleep/resume) and are not a bug. + </summary> +</histogram> + <histogram name="Media.MediaKeysListener.RegisterHotKeyResult" enum="BooleanSuccess" expires_after="M82"> <owner>steimel@chromium.org</owner> @@ -2794,12 +2891,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.MicrophoneMuted" enum="MicrophoneMuteResult" - expires_after="2021-10-31"> + expires_after="2022-10-31"> <owner>henrika@chromium.org</owner> <owner>webrtc-audio@google.com</owner> <summary> Heuristically detects if the user has muted the microphone or not. Measured - approximately four times per minute. + approximately four times per minute while an audio input stream is active. </summary> </histogram> @@ -2842,7 +2939,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.MojoVideoDecoder.ActiveInstances" units="units" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>sandersd@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2890,6 +2987,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.MojoVideoDecoderServiceTiming.{Impl}.{Method}" units="ms" expires_after="M95"> + <obsolete> + Removed Aug 2021. + </obsolete> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -2950,7 +3050,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.MSE.DetectedShakaPackagerInMp4" enum="BooleanDetected" - expires_after="2021-10-25"> + expires_after="2022-04-17"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -3087,7 +3187,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Notification.Cast.Count" units="count" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <owner>media-dev@chromium.org</owner> @@ -3112,7 +3212,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.Notification.Cast.StartStop" enum="GlobalMediaControlsCastActionAndEntryPoint" - expires_after="2022-02-01"> + expires_after="2022-04-03"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <owner>media-dev@chromium.org</owner> @@ -3123,7 +3223,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Notification.Cast.UserAction" enum="MediaSessionAction" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <owner>media-dev@chromium.org</owner> @@ -3144,7 +3244,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Notification.Count" units="count" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>beccahughes@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -3166,7 +3266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Notification.Source" enum="MediaNotificationSource" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>beccahughes@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -3177,7 +3277,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Notification.UserAction" enum="MediaSessionAction" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>beccahughes@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -3187,7 +3287,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.OutputStreamDuration" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <summary> @@ -3199,7 +3299,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.PeakWebMediaPlayerCount" units="players" - expires_after="M95"> + expires_after="M100"> <owner>dalecurtis@google.com</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -3384,7 +3484,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.AllowedByPage" enum="BooleanEnabled" - expires_after="2021-11-07"> + expires_after="2022-04-17"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Tracks whether a web page allows content to be remoted.</summary> @@ -3407,7 +3507,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.AudioCodec" enum="AudioCodec" - expires_after="2021-11-07"> + expires_after="2022-04-17"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Audio codec used while remoting content.</summary> @@ -3430,7 +3530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.Compatibility" enum="RemotingCompatibility" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -3441,21 +3541,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.SessionDuration" units="ms" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Measures the duration of each remoting session.</summary> </histogram> <histogram name="Media.Remoting.SessionStartTrigger" - enum="RemotingStartTrigger" expires_after="2021-11-07"> + enum="RemotingStartTrigger" expires_after="2022-04-17"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Tracks the trigger for starting a remoting session.</summary> </histogram> <histogram name="Media.Remoting.SessionStopTrigger" enum="RemotingStopTrigger" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="RemotingSessionDuration" --> <owner>jophba@chromium.org</owner> @@ -3464,7 +3564,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.ShortSessionDuration" units="ms" - expires_after="2021-11-07"> + expires_after="2022-04-24"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -3483,7 +3583,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.TimeUntilRemoteInitialized" units="ms" - expires_after="2021-11-07"> + expires_after="2022-04-24"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -3493,14 +3593,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.TrackConfiguration" - enum="RemotingTrackConfiguration" expires_after="2021-11-07"> + enum="RemotingTrackConfiguration" expires_after="2022-05-01"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Tracks whether audio or video or both are remoted.</summary> </histogram> <histogram name="Media.Remoting.VideoAspectRatio" units="%" - expires_after="2021-11-07"> + expires_after="2022-05-01"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Aspect ratio of video while remoting content.</summary> @@ -3516,7 +3616,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Remoting.VideoCodec" enum="VideoCodec" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>jophba@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Video codec used while remoting content.</summary> @@ -3547,7 +3647,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.AverageQueueLengthX10" - units="frames" expires_after="2021-12-12"> + units="frames" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3558,7 +3658,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.DrainedFramesPermille" - units="permille" expires_after="2021-12-12"> + units="permille" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3569,7 +3669,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.DroppedFramesPermille" - units="permille" expires_after="2021-12-12"> + units="permille" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3580,7 +3680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.EnterDrainModeCount" - units="count" expires_after="2021-12-12"> + units="count" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3589,8 +3689,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Media.RtcLowLatencyVideoRenderer.MaxQueueLength" + units="frames" expires_after="2022-10-10"> + <owner>kron@chromium.org</owner> + <owner>webrtc-video@google.com</owner> + <summary> + The maximum queue length that is observed when Render() is called in the RTC + low-latency video renderer. Repeatedly measured with a period of 100 s for + as long as the stream is active. + </summary> +</histogram> + <histogram name="Media.RtcLowLatencyVideoRenderer.MaxSizeDropQueueCount" - units="count" expires_after="2021-10-10"> + units="count" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3601,7 +3712,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.NoNewFrameToRenderPermille" - units="permille" expires_after="2021-12-12"> + units="permille" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3612,7 +3723,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.ReduceSteadyStateCount" - units="count" expires_after="2021-12-12"> + units="count" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3623,7 +3734,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.TotalFrames" units="frames" - expires_after="2021-12-12"> + expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3634,7 +3745,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RtcLowLatencyVideoRenderer.TryToRenderFrameCount" - units="count" expires_after="2021-12-12"> + units="count" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3644,7 +3755,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RTCVideoDecoderError" enum="MediaStatusCode" - expires_after="2021-11-07"> + expires_after="2022-04-03"> <owner>posciak@chromium.org</owner> <owner>liberato@chromium.org</owner> <owner>webrtc-video@google.com</owner> @@ -3656,7 +3767,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RTCVideoDecoderFallbackReason.{Codecs}" - enum="RTCVideoDecoderFallbackReason" expires_after="2021-10-10"> + enum="RTCVideoDecoderFallbackReason" expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3694,7 +3805,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RTCVideoDecoderInitializationLatencyMs" units="ms" - expires_after="2021-12-12"> + expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3703,6 +3814,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Media.RTCVideoDecoderMaxInFlightDecodes" units="frames" + expires_after="2022-04-10"> + <owner>liberato@chromium.org</owner> + <owner>webrtc-video@google.com</owner> + <summary> + Max number of frames sent for video decode via the DecoderStream adapter, + that have not also returned a decoded video frame. The metric is emitted + once per RTCVideoDecoderStreamAdapter instance, as the max observed value + over that instance's lifetime. + </summary> +</histogram> + <histogram name="Media.RTCVideoDecoderProfile" enum="VideoCodecProfile" expires_after="never"> <!-- expires-never: Codec and container support planning metric. --> @@ -3714,7 +3837,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.RTCVideoDecoderReinitializationLatencyMs" units="ms" - expires_after="2021-10-10"> + expires_after="2022-10-10"> <owner>kron@chromium.org</owner> <owner>webrtc-video@google.com</owner> <summary> @@ -3800,7 +3923,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Session.RequestAudioFocusResult" enum="BooleanSuccess" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>steimel@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -4031,7 +4154,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Ui.GetDisplayMedia.UserInteraction" - enum="GetDisplayMediaUserInteraction" expires_after="2022-01-01"> + enum="GetDisplayMediaUserInteraction" expires_after="2022-04-10"> <owner>eladalon@chromium.org</owner> <owner>guidou@chromium.org</owner> <owner>agpalak@chromium.org</owner> @@ -4078,7 +4201,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VaapiVideoDecoder.VaapiWrapperCreationSuccess" - enum="BooleanSuccess" expires_after="2021-12-05"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>mcasas@chromium.org</owner> <owner>chromeos-gfx-video@google.com</owner> <summary> @@ -4088,7 +4211,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VaapiWrapper.VADisplayStateInitializeSuccess" - enum="BooleanSuccess" expires_after="2021-10-04"> + enum="BooleanSuccess" expires_after="2022-10-04"> <owner>mcasas@chromium.org</owner> <owner>chromeos-gfx-video@google.com</owner> <summary> @@ -4118,7 +4241,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VAVDA.VaapiWrapperCreationSuccess" enum="BooleanSuccess" - expires_after="2021-10-04"> + expires_after="2022-10-04"> <owner>mcasas@chromium.org</owner> <owner>chromeos-gfx-video@google.com</owner> <summary> @@ -4127,7 +4250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Video.Autoplay" enum="AutoplaySource" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -4147,7 +4270,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Video.Autoplay.Muted.PlayMethod.BecomesVisible" - enum="Boolean" expires_after="2022-02-06"> + enum="Boolean" expires_after="2022-04-24"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -4160,7 +4283,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Video.Autoplay.Muted.PlayMethod.OffscreenDuration" - units="ms" expires_after="2022-02-06"> + units="ms" expires_after="2022-04-24"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -4170,7 +4293,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.Video.Autoplay.Muted.UnmuteAction" enum="BooleanSuccess" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -4245,7 +4368,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Media.Video.Roughness" units="ms" expires_after="2022-01-16"> +<histogram name="Media.Video.Roughness" units="ms" expires_after="2022-04-10"> <owner>eugene@chromium.org</owner> <owner>videostack-eng@chromium.org</owner> <summary> @@ -4284,7 +4407,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Device.SupportedPixelFormat" - enum="VideoPixelFormatUnion" expires_after="2021-12-12"> + enum="VideoPixelFormatUnion" expires_after="2022-05-01"> <owner>eshr@google.com</owner> <owner>handellm@google.com</owner> <summary> @@ -4309,7 +4432,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Error" enum="VideoCaptureError" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>mcasas@chromium.org</owner> <owner>guidou@chromium.org</owner> <owner>armax@chromium.org</owner> @@ -4340,7 +4463,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.FrameRate" units="fps" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>mcasas@chromium.org</owner> <owner>guidou@chromium.org</owner> <owner>armax@chromium.org</owner> @@ -4362,7 +4485,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Mac.Device.CapturedIOSurface" - enum="Boolean" expires_after="2021-12-12"> + enum="Boolean" expires_after="2022-04-24"> <owner>eshr@google.com</owner> <owner>handellm@google.com</owner> <summary> @@ -4374,7 +4497,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.VideoCapture.Mac.Device.CapturedWithRequestedPixelFormat" - enum="Boolean" expires_after="2021-12-12"> + enum="Boolean" expires_after="2022-05-01"> <owner>eshr@google.com</owner> <owner>handellm@google.com</owner> <summary> @@ -4397,7 +4520,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Mac.Device.RequestedPixelFormat" - enum="VideoPixelFormatUnion" expires_after="2021-12-12"> + enum="VideoPixelFormatUnion" expires_after="2022-04-24"> <owner>eshr@google.com</owner> <owner>handellm@google.com</owner> <summary> @@ -4472,7 +4595,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Start" enum="Boolean" - expires_after="2022-01-26"> + expires_after="2022-04-17"> <owner>toprice@chromium.org</owner> <owner>guidou@chromium.org</owner> <summary> @@ -4482,7 +4605,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.StartOutcome" - enum="VideoCaptureStartOutcome" expires_after="2022-01-26"> + enum="VideoCaptureStartOutcome" expires_after="2022-04-17"> <owner>toprice@chromium.org</owner> <owner>guidou@chromium.org</owner> <summary> @@ -4501,7 +4624,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Win.Device.CapturePixelFormat" - enum="VideoPixelFormatUnion" expires_after="2022-02-28"> + enum="VideoPixelFormatUnion" expires_after="2022-05-01"> <owner>ilnik@google.com</owner> <owner>video-cmi-mpp@google.com</owner> <summary> @@ -4511,7 +4634,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Win.Device.InternalPixelFormat" - enum="VideoPixelFormatUnion" expires_after="2022-02-28"> + enum="VideoPixelFormatUnion" expires_after="2022-05-01"> <owner>ilnik@google.com</owner> <owner>video-cmi-mpp@google.com</owner> <summary> @@ -4521,7 +4644,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCapture.Win.Device.RequestedPixelFormat" - enum="VideoPixelFormatUnion" expires_after="2022-02-28"> + enum="VideoPixelFormatUnion" expires_after="2022-05-01"> <owner>ilnik@google.com</owner> <owner>video-cmi-mpp@google.com</owner> <summary> @@ -4570,7 +4693,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Media.VideoCapture.Windows.NumberOfRetriesNeededForMFGetDeviceStreamCategory" - units="retries" expires_after="2022-02-01"> + units="retries" expires_after="2022-05-01"> <owner>guidou@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> <summary> @@ -4607,7 +4730,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCaptureManager.DeviceSessionLockDuration" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-10"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -4618,7 +4741,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoCaptureManager.DeviceSessionWasLocked" - enum="Boolean" expires_after="2021-12-12"> + enum="Boolean" expires_after="2022-04-10"> <owner>dalecurtis@chromium.org</owner> <owner>media-dev@chromium.org</owner> <summary> @@ -4855,6 +4978,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Media.VideoRotation" enum="VideoRotation" expires_after="M79"> + <obsolete> + Went untouched since M79. Removed as of 11/21. + </obsolete> <owner>dalecurtis@chromium.org</owner> <summary>Metadata rotation in mp4 videos. Emitted during demuxing.</summary> </histogram> @@ -4905,7 +5031,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Media.WatchTime" units="ms" expires_after="2021-12-26"> +<histogram name="Media.WatchTime" units="ms" expires_after="2022-05-01"> <owner>dalecurtis@chromium.org</owner> <summary> Watch time is defined as the amount of elapsed media time for audio+video @@ -5003,6 +5129,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> <token key="VaapiClientName"> <variant name="VaapiImageDecodeAcceleratorWorker" summary=""/> + <variant name="VaapiImageProcessorBackend" summary=""/> <variant name="VaapiJpegEncodeAccelerator" summary=""/> <variant name="VaapiJpegEncodeAccelerator.Vpp" summary=""/> <variant name="VaapiMjpegDecodeAccelerator" summary=""/> @@ -5079,7 +5206,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="MediaRouter.Cast.App.Availability" units="ms" - expires_after="2022-02-01"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="MediaRouterSuccess" --> <owner>takumif@chromium.org</owner> @@ -5092,7 +5219,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Cast.Channel.ConnectResult" enum="BooleanSuccess" - expires_after="2021-11-07"> + expires_after="2022-04-17"> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5102,7 +5229,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Cast.Channel.Error" - enum="MediaRouterCastChannelError" expires_after="2022-01-09"> + enum="MediaRouterCastChannelError" expires_after="2022-04-17"> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5113,7 +5240,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Cast.Discovery.CachedSinksAvailableCount" - units="devices" expires_after="2021-11-07"> + units="devices" expires_after="2022-05-01"> <owner>btolsch@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5123,7 +5250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Cast.Discovery.ConnectedDevicesCount" - units="devices" expires_after="2022-01-09"> + units="devices" expires_after="2022-04-10"> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5133,7 +5260,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Cast.Discovery.KnownDevicesCount" units="devices" - expires_after="2021-11-07"> + expires_after="2022-05-01"> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5143,7 +5270,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Cast.Discovery.SinkSource" - enum="MediaRouterCastSinkSource" expires_after="2022-01-09"> + enum="MediaRouterCastSinkSource" expires_after="2022-05-01"> <owner>btolsch@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>The source of discovery for a newly-created Cast sink.</summary> @@ -5209,14 +5336,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.CastStreaming.Session.Launch" units="ms" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Total time to launch a Cast Streaming mirror session.</summary> </histogram> <histogram name="MediaRouter.CastStreaming.Session.Length" units="ms" - expires_after="2022-02-01"> + expires_after="2022-05-01"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5273,7 +5400,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.CastStreaming.Start.Failure.Native" - enum="MirroringServiceErrorType" expires_after="2022-02-01"> + enum="MirroringServiceErrorType" expires_after="2022-05-01"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5284,7 +5411,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.CastStreaming.Start.Success" enum="MirrorType" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5324,7 +5451,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Dial.AvailableDevicesCount" units="devices" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>mfoltz@chromium.org</owner> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> @@ -5335,7 +5462,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Dial.CreateRoute" - enum="MediaRouterDialCreateRouteResult" expires_after="2022-02-01"> + enum="MediaRouterDialCreateRouteResult" expires_after="2022-04-03"> <owner>takumif@chromium.org</owner> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> @@ -5392,7 +5519,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Dial.TerminateRoute" - enum="MediaRouterDialTerminateRouteResult" expires_after="2022-02-01"> + enum="MediaRouterDialTerminateRouteResult" expires_after="2022-04-10"> <owner>takumif@chromium.org</owner> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> @@ -5403,7 +5530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Icon.Click.Location" - enum="MediaRouterDialogOpenOrigin" expires_after="2022-02-01"> + enum="MediaRouterDialogOpenOrigin" expires_after="2022-04-17"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>Location the user clicked to open the Media Router dialog.</summary> @@ -5447,7 +5574,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.PresentationRequest.AvailabilityUrlType" - enum="PresentationUrlType" expires_after="2022-02-01"> + enum="PresentationUrlType" expires_after="2022-04-24"> <owner>takumif@chromium.org</owner> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> @@ -5457,7 +5584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.PresentationRequest.UrlBySink" - enum="PresentationUrlBySink" expires_after="2022-02-01"> + enum="PresentationUrlBySink" expires_after="2022-04-24"> <owner>mfoltz@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5467,7 +5594,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Provider.CreateRoute.Result" - enum="MediaRouteProviderResult" expires_after="2022-02-01"> + enum="MediaRouteProviderResult" expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="MediaRouteProvider" --> <owner>takumif@chromium.org</owner> @@ -5481,7 +5608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Provider.JoinRoute.Result" - enum="MediaRouteProviderResult" expires_after="2022-02-01"> + enum="MediaRouteProviderResult" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="MediaRouteProvider" --> <owner>takumif@chromium.org</owner> @@ -5495,7 +5622,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Provider.TerminateRoute.Result" - enum="MediaRouteProviderResult" expires_after="2022-02-01"> + enum="MediaRouteProviderResult" expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="MediaRouteProvider" --> <owner>takumif@chromium.org</owner> @@ -5556,17 +5683,47 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Sink.SelectedType" enum="MediaSinkType" + expires_after="2022-04-03"> + <owner>takumif@chromium.org</owner> + <owner>openscreen-eng@google.com</owner> + <summary> + The type of the Media Sink that media is being cast to. Recorded each time + the user selects a Media Sink to start casting. Recorded for all the UI + entry points. + </summary> +</histogram> + +<histogram name="MediaRouter.Sink.SelectedType.CastAndDialPresent.{Ui}" + enum="MediaSinkType" expires_after="2022-02-01"> + <owner>takumif@chromium.org</owner> + <owner>openscreen-eng@google.com</owner> + <summary> + The type of the Media Sink that media is being cast to, when both Cast and + DIAL sinks are available for casting. Recorded each time the user selects a + Media Sink to start casting from {Ui}. + </summary> + <token key="Ui"> + <variant name="CastHarmony"/> + <variant name="GlobalMediaControls"/> + </token> +</histogram> + +<histogram name="MediaRouter.Sink.SelectedType.{Ui}" enum="MediaSinkType" expires_after="2022-02-01"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> - The type of the Media Sink that media is being Cast to. Recorded each time - the user selects a Media Sink to start Casting. + The type of the Media Sink that media is being cast to. Recorded each time + the user selects a Media Sink to start casting from {Ui}. </summary> + <token key="Ui"> + <variant name="CastHarmony"/> + <variant name="GlobalMediaControls"/> + </token> </histogram> <histogram name="MediaRouter.Source.CastingSource" - enum="MediaRouterSourceTypes" expires_after="2022-02-01"> + enum="MediaRouterSourceTypes" expires_after="2022-04-03"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5621,7 +5778,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Ui.Action.StartLocalPosition" - enum="MediaRouterSinkPositionLabel" expires_after="2022-02-01"> + enum="MediaRouterSinkPositionLabel" expires_after="2022-04-24"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>The index of the sink that was selected in the sink list.</summary> @@ -5637,14 +5794,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Ui.Action.StopRoute" enum="MediaRouteType" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary>The number of times a user stops different types of routes.</summary> </histogram> <histogram name="MediaRouter.Ui.Device.Count" units="units" - expires_after="2022-02-01"> + expires_after="2022-04-03"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5685,7 +5842,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MediaRouter.Ui.Dialog.ActivationLocationAndCastMode" enum="MediaRouterDialogActivationLocationAndCastMode" - expires_after="2022-02-01"> + expires_after="2022-04-03"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5695,7 +5852,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Ui.Dialog.IconStateAtOpen" - enum="MediaRouterIconState" expires_after="2022-02-01"> + enum="MediaRouterIconState" expires_after="2022-04-24"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5725,7 +5882,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.Ui.FirstAction" enum="MediaRouterUserAction" - expires_after="2022-02-01"> + expires_after="2022-05-01"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -5755,7 +5912,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MediaRouter.WiredDisplay.AvailableDevicesCount" units="units" - expires_after="2022-02-01"> + expires_after="2022-05-01"> <owner>takumif@chromium.org</owner> <owner>openscreen-eng@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/memory/OWNERS b/chromium/tools/metrics/histograms/metadata/memory/OWNERS index bf2c10eab67..0130c020ff6 100644 --- a/chromium/tools/metrics/histograms/metadata/memory/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/memory/OWNERS @@ -3,4 +3,3 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # Prefer sending CLs to the owners listed below. # Use chromium-metrics-reviews@google.com as a backup. lizeb@chromium.org -sebmarchand@chromium.org diff --git a/chromium/tools/metrics/histograms/metadata/memory/histograms.xml b/chromium/tools/metrics/histograms/metadata/memory/histograms.xml index 465a208abd2..eb6547335d8 100644 --- a/chromium/tools/metrics/histograms/metadata/memory/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/memory/histograms.xml @@ -43,7 +43,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.AudioService.PrivateSwapFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-04-10"> <owner>olka@chromium.org</owner> <owner>guidou@chromium.org</owner> <summary> @@ -80,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.AudioService.SharedMemoryFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-04-10"> <owner>olka@chromium.org</owner> <owner>guidou@chromium.org</owner> <summary> @@ -281,7 +281,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Browser.MemoryFootprint.Active" units="MB" - expires_after="2021-10-31"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -308,7 +308,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Browser.MemoryFootprint.Background" units="MB" - expires_after="2021-09-12"> + expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -352,7 +352,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Browser.MemoryFootprint.NumOpenTabs" units="tabs" - expires_after="2021-11-14"> + expires_after="2022-11-14"> <owner>ajuma@chromium.org</owner> <owner>rkgibson@google.com</owner> <summary> @@ -367,7 +367,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Browser.MemoryFootprint.OnBackground" units="MiB" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -403,7 +403,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Browser.PrivateSwapFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-04-10"> <owner>erikchen@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary> @@ -439,7 +439,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Browser.SharedMemoryFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-04-10"> <owner>erikchen@chromium.org</owner> <summary> A rough estimate of the shared memory footprint of the browser process. @@ -457,7 +457,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Discardable.FreeListReleaseTime" units="microseconds" - expires_after="2021-08-01"> + expires_after="2022-04-24"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -470,7 +470,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Discardable.FreelistSize.Dirty" units="KiB" - expires_after="2021-12-04"> + expires_after="2022-04-10"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -480,7 +480,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Discardable.FreelistSize.Foreground" units="KiB" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -490,7 +490,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Discardable.LargeAllocationFromFreelist" - enum="BooleanLargeAllocationFromFreelist" expires_after="2021-09-12"> + enum="BooleanLargeAllocationFromFreelist" expires_after="2022-02-06"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -500,7 +500,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Discardable.LockingSuccess" - enum="BooleanLockingSuccess" expires_after="2022-01-16"> + enum="BooleanLockingSuccess" expires_after="2022-04-24"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -510,7 +510,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Discardable.Size.Foreground" units="KiB" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -520,7 +520,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Discardable.VirtualSize.Foreground" units="KiB" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -530,7 +530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.DiscardableAllocationSize" units="KB" - expires_after="2021-10-10"> + expires_after="2022-02-06"> <owner>reveman@chromium.org</owner> <owner>thiabaud@google.com</owner> <summary> @@ -564,7 +564,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.Experimental.Browser2.Custom" units="bytes" - expires_after="2022-01-10"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="ProcessMemoryAllocatorCustom2" --> <owner>sashamcintosh@chromium.org</owner> @@ -581,7 +581,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.Experimental.Browser2.Small" units="KB" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="ProcessMemoryAllocatorSmall2" --> <owner>erikchen@chromium.org</owner> @@ -731,7 +731,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.Experimental.Gpu2" units="MB" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="ProcessMemoryAllocator2" --> <owner>erikchen@chromium.org</owner> @@ -746,7 +746,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.Experimental.Gpu2.Custom" units="bytes" - expires_after="2022-01-10"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="ProcessMemoryAllocatorCustom2" --> <owner>sashamcintosh@chromium.org</owner> @@ -1100,7 +1100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Experimental.Renderer.HighestPrivateMemoryFootprint" - units="MB" expires_after="2022-01-16"> + units="MB" expires_after="2022-04-03"> <owner>tasak@google.com</owner> <owner>bartekn@google.com</owner> <summary> @@ -1172,7 +1172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.Experimental.Renderer2" units="MB" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="ProcessMemoryAllocator2" --> <owner>erikchen@chromium.org</owner> @@ -1204,7 +1204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.Experimental.Renderer2.Small" units="KB" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <!-- Name completed by histogram_suffixes name="ProcessMemoryAllocatorSmall2" --> <owner>erikchen@chromium.org</owner> @@ -1219,7 +1219,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.Experimental.Renderer2.Tiny" units="bytes" - expires_after="2022-01-10"> + expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="ProcessMemoryAllocatorTiny2" --> <owner>sashamcintosh@chromium.org</owner> @@ -1236,7 +1236,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Experimental.Total2.PrivateMemoryFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-04-17"> <owner>erikchen@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary> @@ -1267,7 +1267,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Memory.Experimental.UserLevelMemoryPressureSignal.RendererPrivateMemoryFootprintBefore" - units="MB" expires_after="2021-12-26"> + units="MB" expires_after="2022-05-01"> <owner>keishi@chromium.org</owner> <owner>tasak@chromium.org</owner> <summary> @@ -1553,7 +1553,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Gpu.SharedMemoryFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <owner>erikchen@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary> @@ -1586,7 +1586,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.LowMemoryKiller.Count" units="low-memory kills" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>vovoy@google.com</owner> <owner>wvk@google.com</owner> <summary> @@ -1596,7 +1596,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.LowMemoryKiller.FirstKillLatency" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>vovoy@google.com</owner> <owner>wvk@google.com</owner> <summary> @@ -1607,7 +1607,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.LowMemoryKiller.FreedSize" units="KB" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>vovoy@google.com</owner> <owner>wvk@google.com</owner> <summary>The memory size freed by each low memory kill event.</summary> @@ -1624,7 +1624,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.NativeLibrary.MappedAndResidentMemoryFootprint3" - units="KB" expires_after="2022-01-30"> + units="KB" expires_after="2022-04-03"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary> @@ -1640,7 +1640,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Memory.NativeLibrary.MappedAndResidentMemoryFootprintCollectionStatus" - enum="MappedAndResidentPagesDumpState" expires_after="2021-08-22"> + enum="MappedAndResidentPagesDumpState" expires_after="2022-04-24"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary> @@ -1656,8 +1656,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.NativeLibrary.NotResidentOrderedCodeMemoryFootprint" - units="KB" expires_after="2021-08-01"> + units="KB" expires_after="2022-01-30"> <owner>lizeb@chromium.org</owner> + <owner>pasko@chromium.org</owner> <summary> The size of the native library code which was ordered, yet is not resident in memory, across all processes. This metric is computed by parsing @@ -1670,8 +1671,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.NativeLibrary.ResidentNotOrderedCodeMemoryFootprint" - units="KB" expires_after="2019-12-01"> + units="KB" expires_after="2022-01-30"> <owner>lizeb@chromium.org</owner> + <owner>pasko@chromium.org</owner> <summary> The size of the native library code which is outside the ordered section, yet is resident in memory, across all processes. This metric is computed by @@ -1685,7 +1687,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.NetworkService.PrivateMemoryFootprint" units="MiB" - expires_after="2022-01-10"> + expires_after="2022-04-03"> <owner>mmenke@chromium.org</owner> <owner>morlovich@chromium.org</owner> <owner>erikchen@chromium.org</owner> @@ -1749,7 +1751,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.NetworkService.SharedMemoryFootprint" units="MiB" - expires_after="2022-01-10"> + expires_after="2022-05-01"> <owner>mmenke@chromium.org</owner> <owner>morlovich@chromium.org</owner> <owner>erikchen@chromium.org</owner> @@ -1777,7 +1779,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.OOMKill.Contents.MemAvailableMB" units="MB" - expires_after="2021-11-07"> + expires_after="2022-04-24"> <owner>oshima@chromium.org</owner> <owner>alemate@chromium.org</owner> <summary> @@ -1790,7 +1792,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.OOMKill.Contents.MemGraphicsMB" units="MB" - expires_after="2021-11-07"> + expires_after="2022-05-01"> <owner>oshima@chromium.org</owner> <owner>alemate@chromium.org</owner> <summary> @@ -1856,7 +1858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.OOMKills.Count" units="kills" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>vovoy@google.com</owner> <owner>wvk@google.com</owner> <summary>Cumulative count of OOM kills in one user session.</summary> @@ -1886,10 +1888,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.PaintPreviewCompositor.PrivateMemoryFootprint" - units="MB" expires_after="2021-10-17"> + units="MB" expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>fredmello@chromium.org</owner> - <owner>mahmoudi@chromium.org</owner> + <owner>yashard@chromium.org</owner> <summary> A rough estimate of the private memory footprint of the paint preview compositor process. @@ -1907,10 +1909,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.PaintPreviewCompositor.PrivateSwapFootprint" units="MB" - expires_after="2021-10-17"> + expires_after="2021-12-17"> <owner>ckitagawa@chromium.org</owner> <owner>fredmello@chromium.org</owner> - <owner>mahmoudi@chromium.org</owner> + <owner>yashard@chromium.org</owner> <summary> An amount of private memory of the paint preview compositor process placed in swap (VmSwap). @@ -1921,10 +1923,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.PaintPreviewCompositor.ResidentSet" units="MiB" - expires_after="2021-10-17"> + expires_after="2021-12-17"> <owner>ckitagawa@chromium.org</owner> <owner>fredmello@chromium.org</owner> - <owner>mahmoudi@chromium.org</owner> + <owner>yashard@chromium.org</owner> <summary> The size of the resident memory in a paint preview compositor process. This is influenced by factors we control (e.g. memory that is not accessed can be @@ -1945,10 +1947,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.PaintPreviewCompositor.SharedMemoryFootprint" - units="MB" expires_after="2021-10-17"> + units="MB" expires_after="2021-12-17"> <owner>ckitagawa@chromium.org</owner> <owner>fredmello@chromium.org</owner> - <owner>mahmoudi@chromium.org</owner> + <owner>yashard@chromium.org</owner> <summary> A rough estimate of the shared memory footprint of the paint preview compositor process. @@ -1971,7 +1973,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.OnDiskSize.5min" units="KiB" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -1981,7 +1983,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.Read.Latency" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -1994,7 +1996,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.Read.Size" units="KiB" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2004,7 +2006,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.Read.Throughput" units="MiBps" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2014,7 +2016,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.TotalReadTime.5min" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2024,7 +2026,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.TotalSize.5min" units="KiB" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2034,7 +2036,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.TotalWriteTime.5min" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2044,7 +2046,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.UnparkedSize.5min" units="KiB" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2054,7 +2056,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.Write.Latency" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2067,7 +2069,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.Write.Size" units="KiB" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2077,7 +2079,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableImage.Write.Throughput" units="MiBps" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>thiabaud@google.com</owner> <owner>lizeb@chromium.org</owner> <summary> @@ -2134,7 +2136,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableString.Decompression.Latency" - units="microseconds" expires_after="M82"> + units="microseconds" expires_after="M98"> <owner>lizeb@chromium.org</owner> <summary> Time to decompress a ParkableString, in us. Note: This metric drops reports @@ -2145,7 +2147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableString.Decompression.SizeKb" units="KB" - expires_after="M82"> + expires_after="M98"> <owner>lizeb@chromium.org</owner> <summary> Original size of a compressed ParkableString, recorded at decompression @@ -2154,7 +2156,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableString.Decompression.ThroughputMBps" - units="MBps" expires_after="M82"> + units="MBps" expires_after="M98"> <owner>lizeb@chromium.org</owner> <summary> Original size of a compressed ParkableString, recorded at decompression @@ -2254,7 +2256,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ParkableString.Read.Latency" units="microseconds" - expires_after="M87"> + expires_after="2022-04-24"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary> @@ -2265,15 +2267,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Memory.ParkableString.Read.SinceLastDiskWrite" units="ms" + expires_after="2022-04-24"> + <owner>lizeb@chromium.org</owner> + <owner>pasko@chromium.org</owner> + <summary> + When reading a parked string from disk, time since it was last parked. + </summary> +</histogram> + <histogram name="Memory.ParkableString.Read.SizeKb" units="KB" - expires_after="M87"> + expires_after="2022-04-24"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary>Size read from disk for a ParkableString.</summary> </histogram> <histogram name="Memory.ParkableString.Read.ThroughputMBps" units="MBps" - expires_after="M87"> + expires_after="M98"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary>Read throughput from disk for a ParkableString.</summary> @@ -2337,7 +2348,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.PartitionAlloc.ThreadCache.BatchFillRate{ThreadType}" - units="%" expires_after="M92"> + units="%" expires_after="M97"> <owner>lizeb@chromium.org</owner> <owner>bartekn@chromium.org</owner> <summary> @@ -2353,7 +2364,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.PartitionAlloc.ThreadCache.HitRate{ThreadType}" - units="%" expires_after="M92"> + units="%" expires_after="M97"> <owner>lizeb@chromium.org</owner> <owner>bartekn@chromium.org</owner> <summary> @@ -2384,7 +2395,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="never"> <!-- expires-never: Generic system health metric used to diagnose various performance issues. --> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The time spent in each memory pressure state, in seconds. Recorded when the @@ -2407,10 +2418,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Memory.PressureWindowDuration" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="Memory.Pressure.TransitionType" --> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The time spent in each of the memory pressure state. Recorded when @@ -2420,7 +2431,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.ProcessCount" units="processes" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <owner>creis@chromium.org</owner> <owner>nasko@chromium.org</owner> <summary> @@ -2502,7 +2513,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Renderer.SharedMemoryFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-04-10"> <owner>erikchen@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary> @@ -2514,7 +2525,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.RendererProcessCount" units="processes" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>creis@chromium.org</owner> <owner>nasko@chromium.org</owner> <summary> @@ -2533,7 +2544,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.RenderProcessHost.Count.All" units="processes" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -2553,7 +2564,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.RenderProcessHost.Count.InitializedAndNotDead" - units="processes" expires_after="2021-12-26"> + units="processes" expires_after="2022-05-01"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -2617,7 +2628,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Total.RendererPrivateMemoryFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-04-03"> <owner>tommckee@chromium.org</owner> <summary> A rough estimate of the private memory footprint of all renderer processes. @@ -2663,7 +2674,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Total.SharedMemoryFootprint" units="MB" - expires_after="2022-01-10"> + expires_after="2022-03-13"> <owner>erikchen@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary> @@ -2675,7 +2686,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.Total.SystemCommitLimit" units="GB" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>sadrul@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -2778,7 +2789,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Memory.WorkingSetTrim.ArcVmTrimCountPer30Mins" - units="VMsTrimmed" expires_after="M99"> + units="VMsTrimmed" expires_after="2022-04-03"> <owner>yusukes@chromium.org</owner> <owner>bgeffon@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/mobile/histograms.xml b/chromium/tools/metrics/histograms/metadata/mobile/histograms.xml index b659ef2306d..b917c926599 100644 --- a/chromium/tools/metrics/histograms/metadata/mobile/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/mobile/histograms.xml @@ -67,7 +67,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mobile.AppMenu.TimeToTakeAction.Abandoned" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>gangwu@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -80,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mobile.AppMenu.TimeToTakeAction.SelectedItem" units="ms" - expires_after="2022-01-23"> + expires_after="2022-05-01"> <owner>gangwu@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -778,7 +778,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileFre.ChildAccountStatusDuration" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>skym@chromium.org</owner> <owner>wenyufu@chromium.org</owner> <summary> @@ -801,7 +801,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="MobileFre.FromLaunch" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>skym@chromium.org</owner> <owner>wenyufu@chromium.org</owner> <summary> @@ -850,7 +850,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileFre.NativeInitialized" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>skym@chromium.org</owner> <owner>wenyufu@chromium.org</owner> <summary> @@ -901,7 +901,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileFre.Progress" enum="MobileFreProgress" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>bsazonov@chromium.org</owner> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> @@ -1010,7 +1010,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileIntent.FirstPartyToInternalScheme" enum="Boolean" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>peconn@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1057,7 +1057,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileOmnibox.PressedClipboardSuggestionAge" units="ms" - expires_after="2021-11-07"> + expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <summary> @@ -1104,6 +1104,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="MobileSignInPromo.NTPContentSuggestions.ImpressionsTilXButton" + units="impressions" expires_after="2022-04-01"> + <owner>bsazonov@chromium.org</owner> + <owner>chrome-signin-team@google.com</owner> + <summary> + Counts how many times the explicit "X"-to-close button is clicked + per impression. Recorded when the signin promo is dismissed using the + "X". + </summary> +</histogram> + <histogram name="MobileSignInPromo.SettingsManager.ImpressionsTilDismiss" units="impressions" expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> @@ -1137,7 +1148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileStartup.DailyLaunchCount" units="units" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>tedchoc@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -1186,7 +1197,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileStartup.IntentToCreationTime" units="ms" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>tedchoc@chromium.org</owner> <owner>twellington@chromium.org</owner> <owner>yfriedman@chromium.org</owner> @@ -1198,7 +1209,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileStartup.LaunchCause" enum="LaunchCause" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>mthiesse@chromium.org</owner> <owner>tedchoc@chromium.org</owner> <owner>yfriedman@chromium.org</owner> @@ -1211,7 +1222,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MobileStartup.LaunchType" enum="LaunchType" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>tedchoc@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/navigation/histograms.xml b/chromium/tools/metrics/histograms/metadata/navigation/histograms.xml index 9dceec92765..4b9dc9b797c 100644 --- a/chromium/tools/metrics/histograms/metadata/navigation/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/navigation/histograms.xml @@ -35,7 +35,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.AllSites.EvictedAfterDocumentRestoredReason" enum="BackForwardCacheEvictedAfterDocumentRestoredReason" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -50,7 +50,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackForwardCache.AllSites.HistoryNavigationOutcome" - enum="BackForwardCacheHistoryNavigationOutcome" expires_after="2021-12-26"> + enum="BackForwardCacheHistoryNavigationOutcome" expires_after="2022-04-10"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -64,7 +64,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.AllSites.HistoryNavigationOutcome.BlocklistedFeature" - enum="WebSchedulerTrackedFeature" expires_after="2022-01-02"> + enum="WebSchedulerTrackedFeature" expires_after="2022-04-17"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -81,7 +81,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.AllSites.HistoryNavigationOutcome.BrowsingInstanceNotSwappedReason" enum="BackForwardCacheBrowsingInstanceNotSwappedReason" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -123,7 +123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.AllSites.HistoryNavigationOutcome.DisabledForRenderFrameHostReason2" enum="BackForwardCacheDisabledForRenderFrameHostReason2" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>carlscab@chromium.org</owner> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> @@ -143,7 +143,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.AllSites.HistoryNavigationOutcome.NotRestoredReason" - enum="BackForwardCacheNotRestoredReason" expires_after="2021-12-19"> + enum="BackForwardCacheNotRestoredReason" expires_after="2022-04-17"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -173,7 +173,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.EvictedAfterDocumentRestoredReason" enum="BackForwardCacheEvictedAfterDocumentRestoredReason" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -189,7 +189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackForwardCache.Eviction.Renderer" - enum="BackForwardCacheRendererEvictionReason" expires_after="2022-02-06"> + enum="BackForwardCacheRendererEvictionReason" expires_after="2022-04-17"> <owner>rakina@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -199,7 +199,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackForwardCache.Eviction.TimeUntilProcessKilled" units="ms" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -257,7 +257,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackForwardCache.HistoryNavigationOutcome.BlocklistedFeature" - enum="WebSchedulerTrackedFeature" expires_after="2021-12-19"> + enum="WebSchedulerTrackedFeature" expires_after="2022-04-03"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -275,7 +275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.HistoryNavigationOutcome.BrowsingInstanceNotSwappedReason" enum="BackForwardCacheBrowsingInstanceNotSwappedReason" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -319,7 +319,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.HistoryNavigationOutcome.DisabledForRenderFrameHostReason2" enum="BackForwardCacheDisabledForRenderFrameHostReason2" - expires_after="2022-01-01"> + expires_after="2022-04-03"> <owner>carlscab@chromium.org</owner> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> @@ -337,8 +337,28 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="BackForwardCache.HistoryNavigationOutcome.DisallowActivationReason" + enum="BackForwardCacheDisallowActivationReason" expires_after="2021-11-30"> + <owner>carlscab@chromium.org</owner> + <owner>hajimehoshi@chromium.org</owner> + <owner>bfcache-dev@chromium.org</owner> + <summary> + For history navigations, records the reason passed to + RenderFrameHost::IsInactiveAndDisallowActivation calls. + + The metric is recorded when a history navigation commits and emits a sample + for each reason. Compare this with + BackForwardCache.HistoryNavigationOutcome, which contains the total number + of navigations which where not cached + + This is recorded for all websites regardless whether back-forward cache is + enabled or not. + </summary> +</histogram> + <histogram name="BackForwardCache.HistoryNavigationOutcome.NotRestoredReason" - enum="BackForwardCacheNotRestoredReason" expires_after="2021-12-19"> + enum="BackForwardCacheNotRestoredReason" expires_after="2022-04-24"> <owner>hajimehoshi@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -438,7 +458,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.ReloadsAndHistoryNavigations" enum="BackForwardCacheReloadsAndHistoryNavigations" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>sreejakshetty@chromium.org</owner> <owner>altimin@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> @@ -468,7 +488,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BackForwardCache.Restore.NavigationToFirstPaint" units="ms" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>sreejakshetty@chromium.org</owner> <owner>altimin@chromium.org</owner> <owner>bfcache-dev@chromium.org</owner> @@ -505,7 +525,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BackForwardCache.UnexpectedRendererToBrowserMessage.InterfaceName" - enum="MojoInterfaceName" expires_after="2022-01-01"> + enum="MojoInterfaceName" expires_after="2022-04-17"> <owner>carlscab@google.com</owner> <owner>bfcache-dev@chromium.org</owner> <summary> @@ -739,7 +759,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Navigation.EngagementTime.HTTP" units="ms" expires_after="M94"> +<histogram name="Navigation.EngagementTime.HTTP" units="ms" + expires_after="2022-01-09"> <owner>estark@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -749,7 +770,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.EngagementTime.HTTPS" units="ms" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>estark@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -759,7 +780,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.EngagementTime.Ratio" units="%" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>estark@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -845,7 +866,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.IsSameSiteInstance" - enum="NavigationIsSameSiteInstance" expires_after="2022-01-16"> + enum="NavigationIsSameSiteInstance" expires_after="2022-04-24"> <owner>arthursonzogni@chromium.org</owner> <owner>clamy@chromium.org</owner> <owner>nasko@chromium.org</owner> @@ -894,7 +915,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.MainFrame.SiteEngagementLevel" - enum="SiteEngagementLevel" expires_after="2021-12-12"> + enum="SiteEngagementLevel" expires_after="2022-04-24"> <owner>meacer@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -914,17 +935,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.MainFrameHasRTLDomain2" enum="Boolean" - expires_after="M92"> + expires_after="2022-04-12"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> Whether the main-frame navigation was to a URL with an RTL domain name. This - is only recorded for finished navigations and not attempts. + is only recorded for finished navigations and not attempts. Warning: this + histogram was expired from M92 through M95; data may be missing. </summary> </histogram> <histogram name="Navigation.MainFrameHasRTLDomainDifferentPage2" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-12"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -937,7 +959,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.MainFrameProfileType2" enum="BrowserProfileType" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -947,17 +969,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.MainFrameScheme2" enum="NavigationScheme" - expires_after="2021-06-01"> + expires_after="2022-02-06"> <owner>elawrence@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> The scheme of the URL for each main-frame navigation. This is only recorded - for finished navigations and not attempts. + for finished navigations and not attempts. Warning: this histogram was + expired from 2021-06-01 through M95; data may be missing. </summary> </histogram> <histogram name="Navigation.MainFrameSchemeDifferentPage2" - enum="NavigationScheme" expires_after="2022-02-06"> + enum="NavigationScheme" expires_after="2022-04-10"> <owner>elawrence@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -969,7 +992,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.MainFrameSchemeDifferentPageOTR2" - enum="NavigationScheme" expires_after="2021-12-12"> + enum="NavigationScheme" expires_after="2022-04-24"> <owner>elawrence@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -1006,7 +1029,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.OnBeforeUnloadOverheadTime" units="ms" - expires_after="M89"> + expires_after="M110"> <owner>clamy@chromium.org</owner> <owner>nasko@chromium.org</owner> <summary> @@ -1019,6 +1042,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Navigation.OnReceiveResponseToOnStartLoadingResponseBody" units="ms" expires_after="M85"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1031,7 +1057,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.OriginAgentCluster.Result" - enum="OriginAgentClusterEndResult" expires_after="2022-01-26"> + enum="OriginAgentClusterEndResult" expires_after="2022-04-10"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>wjmaclean@chromium.org</owner> @@ -1076,8 +1102,25 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Navigation.QueueTime.{Method}.{FrameType}" units="ms" + expires_after="2022-09-08"> + <owner>cduvall@chromium.org</owner> + <owner>jam@chromium.org</owner> + <summary> + Measures the amount of time the task to run {Method} was queued before + running. Logged every time {Method} is run for a {FrameType} in + NavigationURLLoaderImpl with a valid queue time. + </summary> + <token key="Method"> + <variant name="OnReceiveRedirect"/> + <variant name="OnReceiveResponse"/> + <variant name="OnStartLoadingResponseBody"/> + </token> + <token key="FrameType" variants="FrameTypes"/> +</histogram> + <histogram name="Navigation.ReadyToCommitUntilCommit2" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>clamy@chromium.org</owner> <owner>nasko@chromium.org</owner> <summary> @@ -1091,7 +1134,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.RendererDidNavigateTime.{FrameType}" units="ms" - expires_after="2021-10-15"> + expires_after="2022-09-07"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1114,7 +1157,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.RequiresDedicatedProcess" - enum="NavigationRequiresDedicatedProcess" expires_after="2021-12-21"> + enum="NavigationRequiresDedicatedProcess" expires_after="2022-04-03"> <owner>alexmos@chromium.org</owner> <owner>lukasza@chromium.org</owner> <summary> @@ -1125,7 +1168,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.RequiresDedicatedProcess.HTTPOrHTTPS" - enum="NavigationRequiresDedicatedProcess" expires_after="2021-12-21"> + enum="NavigationRequiresDedicatedProcess" expires_after="2022-05-01"> <owner>alexmos@chromium.org</owner> <owner>lukasza@chromium.org</owner> <summary> @@ -1147,7 +1190,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.StartToCommit" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>nasko@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -1195,7 +1238,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Navigation.TimeToReadyToCommit2" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>clamy@chromium.org</owner> <owner>nasko@chromium.org</owner> <summary> @@ -1242,6 +1285,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Navigation.UserAgentStringType" enum="UserAgentStringType" + expires_after="M100"> + <owner>abeyad@chromium.org</owner> + <owner>aarontag@chromium.org</owner> + <summary> + The type of the user agent string value sent in the User-Agent header on a + navigation request. The reduced user agent string is only sent in the + presence of a valid UserAgentReduction origin trial token. This histogram is + recorded when a NavigationRequest is constructed, prior to sending the + request to the network stack. + </summary> +</histogram> + <histogram name="Navigation.VerifyDidCommitParams" enum="VerifyDidCommitParamsDifference" expires_after="2021-12-26"> <owner>rakina@chromium.org</owner> @@ -1405,7 +1461,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NavigationSuggestion.Event2" enum="NavigationSuggestionEvent" - expires_after="2021-10-25"> + expires_after="2022-05-01"> <owner>meacer@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -1423,7 +1479,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Prerender.Experimental.PrerenderCancelledInterface" enum="PrerenderCancelledInterface" expires_after="2022-01-27"> - <owner>falken@chromium.org</owner> <owner>nhiroki@chromium.org</owner> <owner>toyoshim@chromium.org</owner> <owner>lingqi@chromium.org</owner> @@ -1470,7 +1525,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Prerender.Experimental.PrerenderHostFinalStatus" enum="PrerenderHostFinalStatus" expires_after="2022-01-27"> - <owner>falken@chromium.org</owner> <owner>nhiroki@chromium.org</owner> <owner>toyoshim@chromium.org</owner> <owner>lingqi@chromium.org</owner> @@ -1480,6 +1534,151 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Prerender.FinalStatus" enum="PrerenderFinalStatus" + expires_after="2022-04-03"> + <owner>ryansturm@chromium.org</owner> + <owner>tbansal@chromium.org</owner> + <summary> + Final status for prerender pages - either success, or why it was canceled. + </summary> +</histogram> + +<histogram name="Prerender.NetworkBytesTotalForProfile" units="bytes" + expires_after="M77"> + <owner>hajimehoshi@chromium.org</owner> + <owner>jkarlin@chromium.org</owner> + <owner>kouhei@chromium.org</owner> + <summary> + Number of bytes transferred on the network for URLRequests (not including + HTTP/TLS/TCP/IP overhead). Reported on event of a PrerenderContents + deletion. Includes prerender bytes. Bytes are only counted when prerendering + is enabled and not in a control group. The sum of the distribution for a + single user represents all of that user's network transfers for resource for + that time period while prerendering was enabled. + </summary> +</histogram> + +<histogram name="Prerender.NetworkBytesWasted" units="bytes" + expires_after="M77"> + <owner>hajimehoshi@chromium.org</owner> + <owner>jkarlin@chromium.org</owner> + <owner>kouhei@chromium.org</owner> + <summary> + Number of bytes transferred on the network for URLRequests (not including + HTTP/TLS/TCP/IP overhead) for a prerender that was not used. All + nostate-prefetch bytes are currently counted as wasted because it is hard to + track byte use in HTTP cache. + </summary> +</histogram> + +<histogram name="Prerender.NoStatePrefetchMainResourceRedirects" + units="redirects" expires_after="M85"> + <owner>droger@chromium.org</owner> + <owner>mattcary@chromium.org</owner> + <owner>pasko@chromium.org</owner> + <summary> + Length of the redirect chain for main resources loaded by NoStatePrefetch. + Recorded when the final response in the chain is received. + </summary> +</histogram> + +<histogram name="Prerender.NoStatePrefetchRendererLifetimeExtension" units="ms" + expires_after="M77"> + <owner>jam@chromium.org</owner> + <summary> + Time a prefetch renderer is kept alive after parsing to wait for + subresources to finish loading. + </summary> +</histogram> + +<histogram name="Prerender.NoStatePrefetchRendererParseTime" units="ms" + expires_after="M81"> + <owner>jam@chromium.org</owner> + <summary> + Time between prefetch renderer startup and when parsing is complete. + </summary> +</histogram> + +<histogram name="Prerender.NoStatePrefetchResponseTypes" + enum="NoStatePrefetchResponseType" expires_after="M85"> + <owner>droger@chromium.org</owner> + <owner>mattcary@chromium.org</owner> + <owner>pasko@chromium.org</owner> + <summary> + Type of responses received by NoStatePrefetch, distinguishing cacheable + resources from no-store resources, and main resources from sub-resources. + Recorded when a response is received, including on each redirect. + </summary> +</histogram> + +<histogram name="Prerender.NoStatePrefetchSubResourceRedirects" + units="redirects" expires_after="M85"> + <owner>droger@chromium.org</owner> + <owner>mattcary@chromium.org</owner> + <owner>pasko@chromium.org</owner> + <summary> + Length of the redirect chain for sub-resources loaded by NoStatePrefetch. + Recorded when the final response in the chain is received. + </summary> +</histogram> + +<histogram name="Prerender.PrerenderLoadComplete" units="BooleanSuccess" + expires_after="2022-03-30"> + <owner>gambard@chromium.org</owner> + <owner>justincohen@chromium.org</owner> + <summary> + Whether the load was completed when the pre-render was used. If the + prerender is cancelled, this is not logged. Only on iOS. + </summary> +</histogram> + +<histogram name="Prerender.PrerenderLoadedOnFirstNTP" enum="Boolean" + expires_after="M81"> + <owner>justincohen@chromium.org</owner> + <summary> + Whether or not a successful prerender happens on a NTP with no history. + </summary> +</histogram> + +<histogram name="Prerender.PrerenderLoadedOnIndex" units="units" + expires_after="M81"> + <owner>justincohen@chromium.org</owner> + <summary> + The last comitted index before a successful preload is committed. Recorded + only on iOS. + </summary> +</histogram> + +<histogram name="Prerender.PrerendersPerSessionCount" units="units" + expires_after="2021-04-22"> + <owner>ryansturm@chromium.org</owner> + <owner>tbansal@chromium.org</owner> + <summary> + The number of sessions that have at least X successful prerenders. Recorded + only on iOS since 2017-09. + </summary> +</histogram> + +<histogram name="Prerender.PrerenderTimeSaved" units="ms" + expires_after="2022-03-30"> + <owner>gambard@chromium.org</owner> + <owner>justincohen@chromium.org</owner> + <summary> + This is the time from when a prerendered page begins to load to when it is + swapped in as the main page load or to when the pre-loaded page is fully + loaded, whichever came first. Recorded when the swap occurs, only on iOS. + </summary> +</histogram> + +<histogram name="Prerender.TabContentsDeleterTimeout" + enum="BooleanCloseTimeout" expires_after="M85"> + <owner>pasko@chromium.org</owner> + <summary> + A boolean that indicates how often we fail to delete an old prerendered tab + before the timeout. + </summary> +</histogram> + </histograms> </histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/nearby/histograms.xml b/chromium/tools/metrics/histograms/metadata/nearby/histograms.xml index 00e0820c89a..e3229a893fb 100644 --- a/chromium/tools/metrics/histograms/metadata/nearby/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/nearby/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Nearby.Connections.Bluetooth.Adapter.SetName.Result" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Connections.Bluetooth.Adapter.SetScanMode.Result" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -43,7 +43,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Connections.Bluetooth.ClassicMedium.ConnectToService.Duration" - units="ms" expires_after="2022-02-23"> + units="ms" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Connections.Bluetooth.LEMedium.StartAdvertising.Result" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -93,7 +93,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Connections.Bluetooth.LEMedium.StopScanning.Result" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary>Records whether BLE scanning has been stopped successfully.</summary> @@ -125,7 +125,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Connections.InstantMessaging.TachyonIceConfigFetcher.CacheHit" - enum="BooleanCacheHit" expires_after="2022-02-23"> + enum="BooleanCacheHit" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -147,7 +147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Connections.InstantMessaging.TachyonIceConfigFetcher.OAuthTokenFetchResult" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -158,7 +158,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Connections.InstantMessaging.TachyonIceConfigFetcher.Result" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -216,7 +216,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Connections.UtilityProcessShutdownReason" enum="NearbyConnectionsUtilityProcessShutdownReason" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -229,7 +229,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Connections.UtilityProcessShutdownReason.DisconnectedMojoDependency" enum="NearbyConnectionsUtilityProcessMojoDependencyName" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>hansberry@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -243,7 +243,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Share.Certificates.Manager.BluetoothMacAddressPresentForPrivateCertificateCreation" - enum="BooleanPresent" expires_after="2022-02-23"> + enum="BooleanPresent" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -277,7 +277,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Share.Certificates.Manager.DownloadPublicCertificatesCount" - units="certificates" expires_after="2022-02-23"> + units="certificates" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -301,7 +301,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Share.Certificates.Manager.DownloadPublicCertificatesHttpResult" - enum="NearbyShareHttpResult" expires_after="2022-02-23"> + enum="NearbyShareHttpResult" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -325,7 +325,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Share.Certificates.Manager.DownloadPublicCertificatesSuccessRate" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -337,7 +337,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Share.Certificates.Manager.GetDecryptedPublicCertificateResult" enum="NearbyShareCertificateManagerGetDecryptedPublicCertificateResult" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -347,7 +347,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Certificates.Storage.InitializeAttemptCount" - units="attempts" expires_after="2022-02-23"> + units="attempts" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -358,7 +358,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Nearby.Share.Certificates.Storage.InitializeAttemptResult" enum="NearbyShareCertificateStorageInitializationResult" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -369,7 +369,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Certificates.Storage.InitializeSuccessDuration" - units="ms" expires_after="2022-02-23"> + units="ms" expires_after="2022-04-24"> <owner>cvandermerwe@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -400,7 +400,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Connection.EstablishOutgoingConnection.Success" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -414,7 +414,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Connection.EstablishOutgoingConnectionStatus" - enum="NearbyShareFinalStatus" expires_after="2022-02-23"> + enum="NearbyShareFinalStatus" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -427,7 +427,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Connection.TimeToEstablishOutgoingConnection" - units="ms" expires_after="2022-02-23"> + units="ms" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -476,7 +476,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Contacts.DownloadResult" enum="BooleanSuccess" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -490,7 +490,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Contacts.HttpResult" enum="NearbyShareHttpResult" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -599,7 +599,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Discovery.FurthestDiscoveryProgress" - enum="NearbyShareDiscoveryProgress" expires_after="2022-02-23"> + enum="NearbyShareDiscoveryProgress" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -655,7 +655,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Enabled" enum="NearbyShareEnabledState" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -668,7 +668,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.EnabledStateChanged" enum="BooleanEnabled" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -680,7 +680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.IsKnownContact" enum="BooleanKnown" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -691,7 +691,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.LocalDeviceData.DeviceDataUpdater.HttpResult" - enum="NearbyShareHttpResult" expires_after="2022-02-23"> + enum="NearbyShareHttpResult" expires_after="2022-04-24"> <owner>cclem@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -702,7 +702,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Medium.ChangedToMedium" - enum="NearbyConnectionsMedium" expires_after="2022-02-23"> + enum="NearbyConnectionsMedium" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -733,7 +733,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Medium.InitiateBandwidthUpgradeResult" - enum="BooleanSuccess" expires_after="2022-02-23"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -747,7 +747,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Medium.RequestedBandwidthUpgradeResult" - enum="BooleanUpgraded" expires_after="2022-02-23"> + enum="BooleanUpgraded" expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -758,7 +758,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Onboarding.Duration" units="ms" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>cvandermerwe@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -768,7 +768,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Onboarding.EntryPoint" - enum="NearbyShareOnboardingEntryPoint" expires_after="2022-02-23"> + enum="NearbyShareOnboardingEntryPoint" expires_after="2022-04-24"> <owner>cvandermerwe@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -780,7 +780,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Onboarding.Result" - enum="NearbyShareOnboardingFinalState" expires_after="2022-02-23"> + enum="NearbyShareOnboardingFinalState" expires_after="2022-04-24"> <owner>cvandermerwe@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -831,7 +831,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Payload.Medium" enum="NearbyShareUpgradedMedium" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -967,7 +967,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.TimeFromInitiateSendToRemoteDeviceNotification" - units="ms" expires_after="2022-02-23"> + units="ms" expires_after="2022-04-24"> <owner>cvandermerwe@google.com</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -982,7 +982,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.TimeFromLocalAcceptToTransferStart" units="ms" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>cvandermerwe@google.com</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -1175,7 +1175,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.Transfer.Success" enum="BooleanSuccess" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> @@ -1253,7 +1253,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Nearby.Share.VisibilityChoice" enum="NearbyShareVisibility" - expires_after="2022-02-23"> + expires_after="2022-04-24"> <owner>nohle@chromium.org</owner> <owner>nearby-share-chromeos-eng@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/net/histograms.xml b/chromium/tools/metrics/histograms/metadata/net/histograms.xml index e1111bc9e0b..a3d17265b15 100644 --- a/chromium/tools/metrics/histograms/metadata/net/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/net/histograms.xml @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="Net.AlternateProtocolBrokenLocation" - enum="BrokenAlternateProtocolLocation" expires_after="2022-02-06"> + enum="BrokenAlternateProtocolLocation" expires_after="2022-04-10"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -51,7 +51,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.AlternateProtocolUsage" enum="AlternateProtocolUsage" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -61,7 +61,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.AlternateProtocolUsageGoogle" - enum="AlternateProtocolUsage" expires_after="2022-01-16"> + enum="AlternateProtocolUsage" expires_after="2022-04-03"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -71,7 +71,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.AlternateServiceFailed" enum="NetErrorCodes" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>tbansal@chromium.org</owner> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> @@ -318,6 +318,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Net.CertVerifier.InvalidRsaPssParams" enum="Boolean" + expires_after="2022-03-01"> + <owner>bcb@chromium.org</owner> + <owner>rsleevi@chromium.org</owner> + <summary> + While parsing an RSASSA-PSS signature algorithm, whether any invalid + parameters were encountered that currently are not enforced as parsing + errors. + </summary> +</histogram> + <histogram base="true" name="Net.CertVerifier.NameNormalizationPrivateRoots" enum="NetCertificateNameNormalization" expires_after="2021-12-12"> <owner>mattm@chromium.org</owner> @@ -371,7 +382,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.CertVerifier_TrialComparisonResult" - enum="CertVerifierTrialComparisonResult" expires_after="2021-12-26"> + enum="CertVerifierTrialComparisonResult" expires_after="2022-04-03"> <owner>mattm@chromium.org</owner> <owner>rsleevi@chromium.org</owner> <summary> @@ -383,7 +394,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.ConnectionInfo.MainFrame" enum="ConnectionInfo" - expires_after="2022-01-16"> + expires_after="2022-04-17"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -394,7 +405,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.ConnectionInfo.SubResource" enum="ConnectionInfo" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -414,7 +425,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.Cors.AccessCheckError" enum="CorsAccessCheckError" - expires_after="M98"> + expires_after="2022-05-01"> <owner>toyoshim@chromium.org</owner> <owner>yhirano@chromium.org</owner> <summary> @@ -446,7 +457,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.Cors.PreflightCacheKeySize" units="bytes" - expires_after="M98"> + expires_after="2022-05-01"> <owner>toyoshim@chromium.org</owner> <owner>yhirano@chromium.org</owner> <summary> @@ -456,7 +467,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.Cors.PreflightCacheResult" enum="CorsPreflightCacheResult" - expires_after="M98"> + expires_after="2022-04-24"> <owner>toyoshim@chromium.org</owner> <owner>yhirano@chromium.org</owner> <summary> @@ -466,7 +477,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.Cors.PreflightCheckError" enum="CorsAccessCheckError" - expires_after="M98"> + expires_after="2022-05-01"> <owner>toyoshim@chromium.org</owner> <owner>yhirano@chromium.org</owner> <summary> @@ -476,7 +487,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.CountOfBrokenAlternativeServices" units="services" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -499,7 +510,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.CountOfRecentlyBrokenAlternativeServices" units="services" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -583,7 +594,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Nsswitch.Compatible" enum="BooleanValid" - expires_after="2022-01-15"> + expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -595,7 +606,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Nsswitch.FileChange" enum="BooleanChanged" - expires_after="2022-01-15"> + expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -605,7 +616,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Nsswitch.HostsFound" enum="BooleanFound" - expires_after="2022-01-15"> + expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -627,7 +638,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Nsswitch.IncompatibleService" - enum="NsswitchService" expires_after="2022-01-15"> + enum="NsswitchService" expires_after="2022-04-17"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -651,7 +662,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Nsswitch.Read" enum="BooleanReceived" - expires_after="2022-01-15"> + expires_after="2022-04-17"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -663,7 +674,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Nsswitch.TooLarge" enum="BooleanExceeded" - expires_after="2022-01-15"> + expires_after="2022-04-17"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -673,7 +684,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Resolv.Compatible" enum="BooleanValid" - expires_after="2022-01-15"> + expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -686,7 +697,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Resolv.FileChange" enum="BooleanChanged" - expires_after="2022-01-15"> + expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -696,7 +707,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Resolv.Read" enum="BooleanReceived" - expires_after="2022-01-15"> + expires_after="2022-04-17"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -707,7 +718,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.Resolv.Valid" enum="BooleanValid" - expires_after="2022-01-15"> + expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -718,7 +729,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.DnsConfig.SecureDnsMode" enum="SecureDnsModeDetails" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>ericorth@chromium.org</owner> <owner>doh-core@google.com</owner> <summary> @@ -786,8 +797,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Net.DNS.DnsTask.HttpUpgrade" enum="DNS.HttpUpgradeResult" + expires_after="2022-08-14"> + <owner>ericorth@chromium.org</owner> + <owner>src/net/OWNERS</owner> + <summary> + Enumeration of whether or not a DNS-based http->https upgrade is + triggered by HostResolver and the reason why. Recorded for all successfully + completed HTTPS record transactions. + </summary> +</histogram> + <histogram name="Net.DNS.DnsTask.SuccessTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -797,6 +819,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Net.DNS.DnsTask.SvcbHttpsTransactionError" + enum="DNS.SvcbHttpsTransactionError" expires_after="2022-08-14"> + <owner>ericorth@chromium.org</owner> + <owner>src/net/OWNERS</owner> + <summary> + Enumeration of whether or not an HTTPS (SVCB) record transaction succeeded + and whether or not any failure is fatal to the DnsTask. Recorded for all + completed HTTPS record transactions. + </summary> +</histogram> + <histogram name="Net.DNS.DnsTransaction.AttemptType" enum="DNS.AttemptType" expires_after="2022-08-14"> <owner>ericorth@chromium.org</owner> @@ -1218,7 +1251,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.InsecureDnsTask.FailureTime" units="ms" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>ericorth@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -1227,7 +1260,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.JobQueueTime.Failure" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>dmcardle@chromium.org</owner> <owner>ericorth@chromium.org</owner> <summary> @@ -1238,7 +1271,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.JobQueueTime.PerTransaction" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>dmcardle@chromium.org</owner> <owner>ericorth@chromium.org</owner> <summary> @@ -1251,7 +1284,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.JobQueueTime.Success" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>dmcardle@chromium.org</owner> <owner>ericorth@chromium.org</owner> <summary> @@ -1262,7 +1295,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.ProbeSequence.ConfigChange.Failure.AttemptTime" - units="ms" expires_after="2022-01-30"> + units="ms" expires_after="2022-04-03"> <owner>ericorth@chromium.org</owner> <owner>doh-core@google.com</owner> <summary> @@ -1272,7 +1305,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.ProbeSequence.ConfigChange.Success.AttemptTime" - units="ms" expires_after="2022-01-16"> + units="ms" expires_after="2022-03-20"> <owner>ericorth@chromium.org</owner> <owner>doh-core@google.com</owner> <summary> @@ -1282,7 +1315,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.ProbeSequence.NetworkChange.Failure.AttemptTime" - units="ms" expires_after="2022-02-06"> + units="ms" expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>doh-core@google.com</owner> <summary> @@ -1292,7 +1325,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DNS.ProbeSequence.NetworkChange.Success.AttemptTime" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-24"> <owner>ericorth@chromium.org</owner> <owner>doh-core@google.com</owner> <summary> @@ -1599,7 +1632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.DomainReliability.BeaconOutcome" - enum="DomainReliabilityBeaconOutcome" expires_after="2021-12-11"> + enum="DomainReliabilityBeaconOutcome" expires_after="2022-05-01"> <owner>mmenke@chromium.org</owner> <owner>src/net/network_error_logging/OWNERS</owner> <summary> @@ -1693,7 +1726,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.ErrorPageCounts" enum="NetErrorPageEvents" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>edwardjung@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -1844,7 +1877,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.HasBrokenNEON" enum="BooleanBroken" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>davidben@chromium.org</owner> <summary> Records, on startup, for ARM devices running Android, whether the CPU is @@ -1853,7 +1886,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.HttpAuthCount" enum="HttpAuthCount" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>asanka@chromium.org</owner> <owner>mmenke@chromium.org</owner> <summary> @@ -1882,7 +1915,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.HttpAuthTarget" enum="HttpAuthTarget" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>asanka@chromium.org</owner> <owner>mmenke@chromium.org</owner> <summary> @@ -1920,8 +1953,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="net.HttpIdentSrcURL" units="requests" expires_after="M85"> + <owner>tsepez@chromium.org</owner> + <summary> + Count of requests which contained a basic auth username and password + embedded in the URL itself. + </summary> +</histogram> + <histogram name="Net.HttpJob.PrefilterBytesRead" units="bytes" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>jkarlin@chromium.org</owner> <owner>shivanisha@chromium.org</owner> <summary> @@ -1941,7 +1982,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.HttpJob.TotalTime.TLS13" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>davidben@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -1952,7 +1993,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.HttpJob.TotalTime.TLS13.Google" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>davidben@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -2085,7 +2126,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.HttpTimeToFirstByte.TLS13" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>davidben@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -2096,7 +2137,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.HttpTimeToFirstByte.TLS13.Google" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>davidben@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -2260,7 +2301,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.NetworkChangeNotifierMac.GetCurrentConnectionTypeWaitTime" - units="ms" expires_after="2022-02-19"> + units="ms" expires_after="2022-05-01"> <owner>ajuma@chromium.org</owner> <owner>pauljensen@chromium.org</owner> <summary> @@ -2336,6 +2377,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Net.Ntlm.HashDependsOnLocale" enum="Boolean" expires_after="2021-10-25"> + <obsolete> + Removed in 2021/09. + </obsolete> <owner>eroman@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -2357,7 +2401,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Net.Port.Alpaca" enum="AlpacaPort" expires_after="2021-12-31"> +<histogram name="Net.Port.Alpaca" enum="AlpacaPort" expires_after="2022-04-17"> <owner>ricea@chromium.org</owner> <owner>yhirano@chromium.org</owner> <summary> @@ -2462,7 +2506,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicActiveSessions" units="units" - expires_after="2022-01-16"> + expires_after="2022-05-01"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -2481,7 +2525,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicChromiumClientStream.HandleOnCloseConnectionError" - enum="QuicErrorCodes" expires_after="2022-02-09"> + enum="QuicErrorCodes" expires_after="2022-05-01"> <owner>renjietang@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -2832,7 +2876,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicNumSentClientHellos" units="units" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary>The number of client hello messages sent.</summary> @@ -2856,7 +2900,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.AbortedPendingStreamRequests" - units="stream requests" expires_after="2021-12-12"> + units="stream requests" expires_after="2022-05-01"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -2867,7 +2911,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.AcceptChForOrigin" enum="Boolean" - expires_after="M99"> + expires_after="2022-04-10"> <owner>bnc@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -2879,7 +2923,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.AcceptChFrameReceivedViaAlps" - enum="AcceptChEntries" expires_after="M99"> + enum="AcceptChEntries" expires_after="2022-04-10"> <owner>bnc@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -2931,7 +2975,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.CertVerificationResult" enum="NetErrorCodes" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3115,7 +3159,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ConnectionCloseErrorCodeClient" - enum="QuicErrorCodes" expires_after="2022-01-16"> + enum="QuicErrorCodes" expires_after="2022-03-20"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3125,7 +3169,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ConnectionCloseErrorCodeClientGoogle" - enum="QuicErrorCodes" expires_after="2022-01-16"> + enum="QuicErrorCodes" expires_after="2022-04-24"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3135,7 +3179,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ConnectionCloseErrorCodeServer" - enum="QuicErrorCodes" expires_after="2022-01-16"> + enum="QuicErrorCodes" expires_after="2022-03-20"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3145,7 +3189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ConnectionCloseErrorCodeServerGoogle" - enum="QuicErrorCodes" expires_after="2022-01-16"> + enum="QuicErrorCodes" expires_after="2022-04-03"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3155,7 +3199,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ConnectionCloseErrorCodeServerIetfApplication" - enum="QuicHttp3ErrorCodes" expires_after="2021-12-05"> + enum="QuicHttp3ErrorCodes" expires_after="2022-04-24"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3198,7 +3242,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ConnectionCloseErrorCodeServerIetfTransport" - enum="QuicTransportErrorCodes" expires_after="2021-12-05"> + enum="QuicTransportErrorCodes" expires_after="2022-04-17"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3277,7 +3321,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ConnectionMigration" - enum="QuicConnectionMigrationStatus" expires_after="2022-02-06"> + enum="QuicConnectionMigrationStatus" expires_after="2022-04-10"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3464,7 +3508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.HandshakeConfirmedTime" units="Milliseconds" - expires_after="2022-01-16"> + expires_after="2022-04-24"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3684,7 +3728,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.MaxReordering" units="units" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3776,7 +3820,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.NumPendingStreamRequests" - units="stream requests" expires_after="2022-01-16"> + units="stream requests" expires_after="2022-04-17"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3806,7 +3850,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.NumTotalStreams" units="units" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3890,7 +3934,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.PacketRetransmitsPerMille" units="permille" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3920,7 +3964,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.PendingStreamsWaitTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -3940,7 +3984,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.PortMigration" - enum="QuicConnectionMigrationStatus" expires_after="2022-01-16"> + enum="QuicConnectionMigrationStatus" expires_after="2022-04-17"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary>The result of a QUIC port migration attempt.</summary> @@ -4067,7 +4111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.QuicVersion" units="units" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary>Version of the QUIC protocol used for this connection.</summary> @@ -4188,7 +4232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.RstStreamErrorCodeServer" - enum="QuicRstStreamErrorCodes" expires_after="2021-12-12"> + enum="QuicRstStreamErrorCodes" expires_after="2022-04-10"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -4319,7 +4363,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.StreamCloseErrorCodeServer.HandshakeConfirmed" - enum="QuicErrorCodes" expires_after="2022-01-16"> + enum="QuicErrorCodes" expires_after="2022-05-01"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -4525,7 +4569,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.VerifyProofTime" units="ms" - expires_after="2022-01-16"> + expires_after="2022-04-10"> <owner>dschinazi@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -4576,7 +4620,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ZeroRttReason" - enum="SSLHandshakeEarlyDataReason" expires_after="2022-01-16"> + enum="SSLHandshakeEarlyDataReason" expires_after="2022-04-10"> <owner>nharper@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -4586,7 +4630,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ZeroRttReasonGoogle" - enum="SSLHandshakeEarlyDataReason" expires_after="2022-01-16"> + enum="SSLHandshakeEarlyDataReason" expires_after="2022-04-03"> <owner>renjietang@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary> @@ -4608,7 +4652,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.QuicSession.ZeroRttState" enum="ZeroRttState" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>renjietang@chromium.org</owner> <owner>src/net/quic/OWNERS</owner> <summary>Whether 0-RTT was successfully used in the connection.</summary> @@ -4841,7 +4885,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.Reporting.HeaderType" enum="NetReportingHeaderType" - expires_after="2021-11-18"> + expires_after="2022-04-24"> <owner>rodneyding@google.com</owner> <owner>src/net/reporting/OWNERS</owner> <summary> @@ -4863,6 +4907,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Net.Reporting.UploadHeaderType" + enum="NetReportingUploadHeaderType" expires_after="2022-02-18"> + <owner>rodneyding@google.com</owner> + <owner>src/net/reporting/OWNERS</owner> + <summary> + The type of header that produced the endpoint used for uploading reports for + the Reporting API, recorded when reports have been succesfully uploaded, + counted once for each report. + </summary> +</histogram> + <histogram name="Net.ResourceLoader.ReadDeferral" units="ms" expires_after="M77"> <owner>clamy@chromium.org</owner> @@ -4873,7 +4928,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.RestrictedCookieManager.SiteForCookiesOK" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>morlovich@chromium.org</owner> <owner>src/net/cookies/OWNERS</owner> <summary> @@ -4883,7 +4938,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.RestrictedCookieManager.TopFrameOriginOK" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>morlovich@chromium.org</owner> <owner>src/net/cookies/OWNERS</owner> <summary> @@ -5029,7 +5084,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SpdySession.AlpsAcceptChEntries" enum="AcceptChEntries" - expires_after="M99"> + expires_after="2022-04-10"> <owner>bnc@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -5041,7 +5096,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SpdySession.AlpsDecoderStatus" enum="AlpsDecoderError" - expires_after="M99"> + expires_after="2022-04-10"> <owner>bnc@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -5052,7 +5107,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SpdySession.AlpsSettingParameterCount" units="parameters" - expires_after="M99"> + expires_after="2022-04-10"> <owner>bnc@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -5063,7 +5118,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SpdySession.ClosedOnError" enum="NetErrorCodes" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary>Net error codes when SpdySession was closed.</summary> @@ -5113,14 +5168,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SpdySessionErrorDetails2" enum="SpdyProtocolErrorDetails2" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary>The type of SPDY Protocol error encountered.</summary> </histogram> <histogram name="Net.SpdySessionErrorDetails_Google2" - enum="SpdyProtocolErrorDetails2" expires_after="2021-12-05"> + enum="SpdyProtocolErrorDetails2" expires_after="2022-05-01"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -5159,7 +5214,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SpdyStreamsPerSession" units="units" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>dschinazi@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary>The number of streams issued over a single session.</summary> @@ -5259,7 +5314,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SSLHandshakeDetails" enum="SSLHandshakeDetails" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>davidben@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -5271,7 +5326,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SSLHandshakeEarlyDataReason" - enum="SSLHandshakeEarlyDataReason" expires_after="2021-12-31"> + enum="SSLHandshakeEarlyDataReason" expires_after="2022-04-03"> <owner>davidben@chromium.org</owner> <owner>svaldez@chromium.org</owner> <owner>src/net/OWNERS</owner> @@ -5284,7 +5339,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SSLHandshakeEarlyDataReason.Google" - enum="SSLHandshakeEarlyDataReason" expires_after="2021-12-31"> + enum="SSLHandshakeEarlyDataReason" expires_after="2022-04-10"> <owner>davidben@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -5306,7 +5361,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SSLLegacyCryptoFallback" enum="SSLLegacyCryptoFallback" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>davidben@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -5332,7 +5387,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.SSLRSAKeyUsage.UnknownRoot" enum="RSAKeyUsage" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>davidben@chromium.org</owner> <summary> For each TLS connection which uses a unknown root, an RSA key, and TLS 1.2 @@ -5463,7 +5518,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.TcpConnectAttempt.LatencyPercentRTT.Success" units="%" - expires_after="2021-10-25"> + expires_after="2022-04-17"> <owner>eroman@chromium.org</owner> <owner>src/net/OWNERS</owner> <summary> @@ -5514,7 +5569,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Net.TrustTokens.NetErrorForFetchFailure" - enum="NetErrorCodes" expires_after="2022-01-15"> + enum="NetErrorCodes" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="TrustTokenOperationType" --> <owner>davidvc@chromium.org</owner> @@ -5529,7 +5584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Net.TrustTokens.NetErrorForTrustTokenOperation" - enum="NetErrorCodes" expires_after="2022-01-15"> + enum="NetErrorCodes" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="TrustTokenOperationType" --> <owner>davidvc@chromium.org</owner> @@ -5595,7 +5650,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Net.TrustTokens.RequestHelperFactoryOutcome" - enum="TrustTokenRequestHelperFactoryOutcome" expires_after="2022-01-15"> + enum="TrustTokenRequestHelperFactoryOutcome" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="TrustTokenOperationType" --> <owner>davidvc@chromium.org</owner> @@ -5651,7 +5706,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.URLLoaderThrottleDeferTime.WillProcessResponse.{Throttle}" - units="ms" expires_after="2021-09-21"> + units="ms" expires_after="2022-03-13"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -5662,7 +5717,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.URLLoaderThrottleDeferTime.WillStartRequest.{Throttle}" - units="ms" expires_after="2021-09-21"> + units="ms" expires_after="2022-03-13"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -5695,7 +5750,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.URLRequest.ReferrerHasInformativePath" - enum="BooleanPathIsInformative" expires_after="2021-11-07"> + enum="BooleanPathIsInformative" expires_after="2022-05-31"> <!-- Name completed by histogram_suffixes name="ReferrerPolicySameOrigin" --> <owner>davidvc@chromium.org</owner> @@ -5709,7 +5764,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Net.URLRequest.ReferrerPolicyForRequest" - enum="URLRequestReferrerPolicy" expires_after="2021-11-07"> + enum="URLRequestReferrerPolicy" expires_after="2022-05-31"> <!-- Name completed by histogram_suffixes name="ReferrerPolicySameOrigin" --> <owner>davidvc@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/network/histograms.xml b/chromium/tools/metrics/histograms/metadata/network/histograms.xml index e963894a3f0..b5c5fbd66ff 100644 --- a/chromium/tools/metrics/histograms/metadata/network/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/network/histograms.xml @@ -142,7 +142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.DisableProfile.Result" - enum="HermesResponseStatus" expires_after="2021-11-01"> + enum="HermesResponseStatus" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -155,7 +155,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.EnableProfile.Result" - enum="HermesResponseStatus" expires_after="2021-11-01"> + enum="HermesResponseStatus" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -185,7 +185,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.InstallViaQrCode.OperationResult" - enum="NetworkCellularESimInstallViaQrCodeResult" expires_after="2021-11-01"> + enum="NetworkCellularESimInstallViaQrCodeResult" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -200,7 +200,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.InstallViaQrCode.Result" - enum="HermesResponseStatus" expires_after="2022-03-01"> + enum="HermesResponseStatus" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -216,7 +216,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.ProfileDiscovery.Latency" units="ms" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivity@google.com</owner> <owner>hsuregan@chromium.org</owner> @@ -264,7 +264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Cellular.ESim.RequestPendingProfiles.OperationResult" enum="NetworkCellularESimRequestPendingProfilesResult" - expires_after="2021-11-01"> + expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -279,7 +279,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.RequestPendingProfiles.Result" - enum="HermesResponseStatus" expires_after="2021-11-01"> + enum="HermesResponseStatus" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -290,7 +290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.ServiceAtLogin.Count" units="units" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivit@google.com</owner> <summary> @@ -300,7 +300,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.SetupFlowResult" - enum="ESimSetupFlowResult" expires_after="2022-03-01"> + enum="ESimSetupFlowResult" expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivity@google.com</owner> <owner>hsuregan@chromium.org</owner> @@ -310,7 +310,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.StatusAtLogin" - enum="NetworkCellularESimProfileStatus" expires_after="2022-03-01"> + enum="NetworkCellularESimProfileStatus" expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivity@google.com</owner> <owner>hsuregan@chromium.org</owner> @@ -322,7 +322,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Cellular.ESim.UninstallProfile.OperationResult" enum="NetworkCellularESimUninstallOperationResult" - expires_after="2021-11-01"> + expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -336,7 +336,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.UninstallProfile.Result" - enum="HermesResponseStatus" expires_after="2021-11-01"> + enum="HermesResponseStatus" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -347,7 +347,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.ESim.Usage.Count" enum="NetworkCellularUsage" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivity@google.com</owner> <summary> @@ -357,7 +357,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.InhibitResult" - enum="NetworkCellularInhibitResult" expires_after="2021-11-01"> + enum="NetworkCellularInhibitResult" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -383,7 +383,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.PrepareCellularConnection.OperationResult" - enum="NetworkCellularPrepareForConnectionResult" expires_after="2021-11-01"> + enum="NetworkCellularPrepareForConnectionResult" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>khorimoto@chromium.org</owner> <owner>cros-connectivity@google.com</owner> @@ -397,7 +397,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.PSim.OtaActivationResult" - enum="NetworkCellularPSimActivationResult" expires_after="2021-11-01"> + enum="NetworkCellularPSimActivationResult" expires_after="2022-09-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivity@google.com</owner> <owner>hsuregan@chromium.org</owner> @@ -408,7 +408,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.PSim.ServiceAtLogin.Count" units="units" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-system-services-networking@google.com</owner> <summary> @@ -429,7 +429,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.PSim.StatusAtLogin" - enum="NetworkCellularPSimActivationState" expires_after="2022-03-01"> + enum="NetworkCellularPSimActivationState" expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivity@google.com</owner> <owner>hsuregan@chromium.org</owner> @@ -440,7 +440,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Cellular.PSim.Usage.Count" enum="NetworkCellularUsage" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>azeemarshad@chromium.org</owner> <owner>cros-connectivity@google.com</owner> <summary> @@ -583,7 +583,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.DnsProxy.DnsOverHttpsMode" - enum="DnsProxy.DnsOverHttpsMode" expires_after="2021-12-01"> + enum="DnsProxy.DnsOverHttpsMode" expires_after="2022-04-03"> <owner>garrick@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -604,7 +604,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.DnsProxy.NameserverTypes" - enum="DnsProxy.NameserverType" expires_after="2021-12-01"> + enum="DnsProxy.NameserverType" expires_after="2022-04-03"> <owner>garrick@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -792,7 +792,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Radio.PossibleWakeupTrigger.ResolveHostPurpose" - units="ResolveHostPurpose" expires_after="2022-02-01"> + enum="ResolveHostPurpose" expires_after="2022-04-10"> <owner>bashi@chromium.org</owner> <owner>blink-network-stack@google.com</owner> <summary> @@ -803,7 +803,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Radio.PossibleWakeupTrigger.URLLoaderAnnotationId" - units="TrafficAnnotationUniqueIdHash" expires_after="2022-02-01"> + enum="TrafficAnnotationUniqueIdHash" expires_after="2022-04-10"> <owner>bashi@chromium.org</owner> <owner>blink-network-stack@google.com</owner> <summary> @@ -814,7 +814,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Cellular.3GPPRegistrationDelayedDrop" enum="NetworkCellular3GPPRegistrationDelayedDrop" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -847,7 +847,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.ConnectResult" - enum="PlatformCellularConnectResult" expires_after="2021-12-01"> + enum="PlatformCellularConnectResult" expires_after="2022-04-03"> <owner>danielwinkler@google.com</owner> <owner>cros-connectivity@google.com</owner> <summary> @@ -860,7 +860,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.DevicePresenceStatus" - enum="BooleanPresent" expires_after="2022-01-30"> + enum="BooleanPresent" expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -880,7 +880,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.Drop" enum="NetworkCellularTechnology" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -901,7 +901,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.IPv6ConnectivityStatus" - enum="IPv6ConnectivityStatus" expires_after="2021-12-01"> + enum="IPv6ConnectivityStatus" expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -911,7 +911,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.NetworkConnectionIPType" - enum="NetworkConnectionIPType" expires_after="2021-12-01"> + enum="NetworkConnectionIPType" expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -942,7 +942,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.PortalAttemptsToOnline" units="units" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -953,7 +953,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.PortalResult" - enum="NetworkPortalResult" expires_after="2021-12-01"> + enum="NetworkPortalResult" expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -972,7 +972,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.SignalStrengthBeforeDrop" units="units" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -982,7 +982,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeOnline" units="seconds" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -993,7 +993,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToConfig" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1003,7 +1003,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToConnect" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1013,7 +1013,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToDisable" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1023,7 +1023,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToEnable" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1033,7 +1033,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToInitialize" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1043,7 +1043,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToOnline" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1053,7 +1053,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToPortal" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>ejcaruso@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1063,7 +1063,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Cellular.TimeToRedirectFound" units="ms" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>matthewmwang@chromium.org</owner> <owner>hugobenichi@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> @@ -1085,7 +1085,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.ConnectionDiagnosticsIssue" - enum="ConnectionDiagnosticsIssue" expires_after="2021-12-01"> + enum="ConnectionDiagnosticsIssue" expires_after="2022-04-10"> <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1108,7 +1108,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.CumulativeTimeOnline" units="seconds" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS device time on line in the previous 24-hour sample period. @@ -1121,8 +1122,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.DailyChosenFractionOnline.Cellular" units="%" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS fraction of daily cumulative time on a cellular connection when @@ -1134,8 +1136,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.DailyChosenFractionOnline.Wifi" units="%" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS fraction of daily cumulative time on a WiFi connection when both @@ -1147,8 +1150,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.DailyChosenTimeOnline.Any" units="seconds" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS daily cumulative time on line when both cellular and WiFi adaptors @@ -1161,7 +1165,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.DailyChosenTimeOnline.Cellular" units="seconds" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS daily cumulative time on a cellular connection when both cellular @@ -1173,8 +1178,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.DailyChosenTimeOnline.Wifi" units="seconds" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS daily cumulative time on a WiFi connection when both cellular and @@ -1187,7 +1193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.DarkResumeActionResult" enum="ShillSuspendTerminationDarkResumeActionResult" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1229,7 +1235,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.DeviceConnectionStatus" enum="ConnectionStatus" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1260,7 +1266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.DHCPClientStatus" enum="NetworkDhcpClientStatus" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1471,7 +1477,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.MonthlyChosenFractionOnline.Cellular" units="%" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS fraction of monthly cumulative time on a cellular connection when @@ -1483,8 +1490,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.MonthlyChosenFractionOnline.Wifi" units="%" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-05-01"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS fraction of monthly cumulative time on a WiFi connection when both @@ -1497,7 +1505,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.MonthlyChosenTimeOnline.Any" units="seconds" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS monthly cumulative time on line when both cellular and WiFi @@ -1509,8 +1518,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.MonthlyChosenTimeOnline.Cellular" - units="seconds" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + units="seconds" expires_after="2022-04-17"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS monthly cumulative time on a cellular connection when both @@ -1522,8 +1532,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.MonthlyChosenTimeOnline.Wifi" units="seconds" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS monthly cumulative time on a WiFi connection when both cellular @@ -1535,7 +1546,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.PortalDetectionMultiProbeResult" - enum="PortalDetectionMultiProbeResult" expires_after="2021-12-01"> + enum="PortalDetectionMultiProbeResult" expires_after="2022-05-01"> <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1546,7 +1557,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.PPPMTUValue" units="bytes" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>akhouderchah@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1591,7 +1602,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.SuspendActionTimeTaken" units="ms" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network diagnostic metric sampling the time in milliseconds it @@ -1643,7 +1655,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Vpn.Driver" enum="VPNDriver" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>akhouderchah@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1652,8 +1664,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Network.Shill.Vpn.L2tpIpsecTunnelGroupUsage" + enum="VPNL2TPIPsecTunnelGroupUsage" expires_after="2022-01-30"> + <owner>jiejiang@chromium.org</owner> + <owner>cros-connectivity@google.com</owner> + <owner>cros-network-metrics@google.com</owner> + <summary> + Chrome OS network usage metric emitted on each successful L2TP/IPsec VPN + connection that tracks whether tunnel group is used. The tunnel group + property needs to be set when connecting to some Cisco L2TP/IPsec VPN. + </summary> +</histogram> + <histogram name="Network.Shill.Vpn.RemoteAuthenticationType" - enum="VPNRemoteAuthenticationType" expires_after="2021-12-01"> + enum="VPNRemoteAuthenticationType" expires_after="2022-05-01"> <owner>akhouderchah@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1662,8 +1686,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Network.Shill.Vpn.TimeOnline" units="ms" - expires_after="2022-01-30"> +<histogram name="Network.Shill.Vpn.TimeOnline" units="seconds" + expires_after="2022-04-24"> <owner>akhouderchah@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1697,7 +1721,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Vpn.UserAuthenticationType" - enum="VPNUserAuthenticationType" expires_after="2022-01-30"> + enum="VPNUserAuthenticationType" expires_after="2022-04-24"> <owner>akhouderchah@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1706,6 +1730,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Network.Shill.Vpn.WireGuardAllowedIPsType" + enum="VPNWireGuardAllowedIPsType" expires_after="2022-01-30"> + <owner>jiejiang@chromium.org</owner> + <owner>cros-network-metrics@google.com</owner> + <summary> + Chrome OS network usage metric emitted on each successful WireGuard VPN + connection that tracks the type of the allowed IPs set in this connection. + </summary> +</histogram> + +<histogram name="Network.Shill.Vpn.WireGuardKeyPairSource" + enum="VPNWireGuardKeyPairSource" expires_after="2022-01-30"> + <owner>jiejiang@chromium.org</owner> + <owner>cros-network-metrics@google.com</owner> + <summary> + Chrome OS network usage metric emitted on each successful WireGuard VPN + connection that tracks the source of the key pair used in this connection. + </summary> +</histogram> + +<histogram name="Network.Shill.Vpn.WireGuardPeersNum" units="WireGuard peers" + expires_after="2022-01-30"> + <owner>jiejiang@chromium.org</owner> + <owner>cros-network-metrics@google.com</owner> + <summary> + Chrome OS network usage metric emitted on each successful WireGuard VPN + connection that tracks the number of peers used in in this connection. + </summary> +</histogram> + <histogram name="Network.Shill.WiFi.Ap80211kSupport" enum="WiFiAp80211kSupport" expires_after="2021-12-01"> <owner>matthewmwang@chromium.org</owner> @@ -1759,7 +1813,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.ApChannelSwitch" enum="WiFiApChannelSwitch" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -1769,8 +1823,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.ApDisconnectReason" enum="WiFiReasonCode" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-03"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. Reason code reported when the AP disconnects @@ -1779,8 +1833,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.ApDisconnectType" enum="WiFiStatusType" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. Broad category of reason AP disconnected a @@ -1789,8 +1843,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.AssocFailureType" enum="WiFiStatusCode" - expires_after="2022-01-30"> - <owner>akhouderchah@chromium.org</owner> + expires_after="2022-04-03"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. Status code reported when an 802.11 @@ -1801,8 +1855,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.AuthFailureType" enum="WiFiStatusCode" - expires_after="2022-01-30"> - <owner>akhouderchah@chromium.org</owner> + expires_after="2022-04-03"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. Status code reported when an 802.11 @@ -1814,7 +1868,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.AutoConnectableServices" units="units" expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric sampling the number of wifi services available for @@ -1824,7 +1879,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.AvailableBSSesAtConnect" units="units" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric sampling the number of BSSes (endpoints) available @@ -1844,8 +1899,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.Channel" enum="NetworkChannelType" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. The channel used for each successful WiFi @@ -1854,8 +1909,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.ClientDisconnectReason" - enum="WiFiReasonCode" expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + enum="WiFiReasonCode" expires_after="2022-04-03"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. Reason code reported when the client @@ -1864,8 +1919,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.ClientDisconnectType" enum="WiFiStatusType" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. Broad category of reason client disconnected @@ -1873,9 +1928,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Network.Shill.WiFi.CQMNotification" + enum="WiFiCQMNotificationType" expires_after="2022-09-01"> + <owner>kuabhs@chromium.org</owner> + <owner>cros-network-metrics@google.com</owner> + <summary> + Chrome OS Wifi Connection Quality Monitor(CQM) Notifications metric. This is + emitted when any packet or beacon loss is observed for signal strength + greater than -80 dBm. This metric is rate-limited such that it is never + emitted more than once every 6 minutes. + </summary> +</histogram> + <histogram name="Network.Shill.WiFi.DarkResumeUnmatchedScanResultsReceived" - enum="DarkResumeUnmatchedScanResultReceived" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + enum="DarkResumeUnmatchedScanResultReceived" expires_after="2022-05-01"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric that tracks whether any unmatched scan results are @@ -1887,7 +1954,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.DarkResumeWakeReason" enum="DarkResumeWakeReason" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric that tracks the wake reason for dark resume. @@ -1895,8 +1962,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.DevicePresenceStatus" enum="BooleanPresent" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric that tracks the presence of a WiFi device in the @@ -1905,8 +1972,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.Disconnect" enum="NetworkDisconnectType" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric that tracks whether an 802.11 wireless @@ -1916,8 +1983,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.EapInnerProtocol" enum="EAPInnerProtocol" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric sampled on each successful 802.1x wireless @@ -1926,8 +1993,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.EapOuterProtocol" enum="EAPOuterProtocol" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric sampled on each successful 802.1x wireless @@ -1937,7 +2004,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Wifi.ExpiredLeaseLengthSeconds2" units="seconds" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric that tracks the length of a lease for a @@ -1948,7 +2015,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Wifi.FallbackDNSTestResult" enum="FallbackDNSTestResult" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric that tracks the result of the fallback @@ -2000,7 +2067,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.HiddenSSIDNetworkCount" units="units" - expires_after="2022-01-30"> + expires_after="2022-04-17"> <owner>tnagel@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <owner>cros-privacy-core@google.com</owner> @@ -2015,7 +2082,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.HS20Support" enum="HotspotSupport" - expires_after="2021-12-01"> + expires_after="2022-04-24"> <owner>kglund@google.com</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -2027,8 +2094,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.IPv6ConnectivityStatus" - enum="IPv6ConnectivityStatus" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + enum="IPv6ConnectivityStatus" expires_after="2022-05-01"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric that tracks the presence of complete IPv6 @@ -2153,7 +2220,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.NeighborLinkMonitorFailure" - enum="NeighborLinkMonitorFailureType" expires_after="2022-01-30"> + enum="NeighborLinkMonitorFailureType" expires_after="2022-04-17"> <owner>jiejiang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -2165,7 +2232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Wifi.NetworkConnectionIPType" enum="NetworkConnectionIPType" expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric that tracks the types of IP configuration used for @@ -2175,7 +2242,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Wifi.NetworkProblemDetected" enum="NetworkProblemType" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric that tracks the network problems @@ -2185,7 +2252,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Wifi.PhyMode" enum="NetworkPhyModeType" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. The channel type used for each successful @@ -2195,7 +2262,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Wifi.PortalAttempts" units="units" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network diagnostic metric sampling the number of portal detection @@ -2205,8 +2273,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.PortalAttemptsToOnline" units="units" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network diagnostic metric sampling the total number of portal @@ -2217,8 +2286,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.PortalResult" enum="NetworkPortalResult" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>matthewmwang@chromium.org</owner> + <owner>stevenjb@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network diagnostic metric sampling the result of portal detections @@ -2228,7 +2298,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.RegulatoryDomain" enum="RegulatoryDomain" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric that tracks which country the WiFi regulatory @@ -2238,8 +2308,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.RememberedNetworkCount" units="units" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-03"> + <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network diagnostic metric sampling the number of 802.11 wireless @@ -2250,8 +2320,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.RememberedSystemNetworkCount" units="units" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric sampling the number of 802.11 wireless networks @@ -2266,8 +2336,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.RememberedUserNetworkCount" units="units" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>matthewmwang@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric sampling the number of 802.11 wireless networks @@ -2303,8 +2373,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.ScanResult" enum="WiFiScanResult" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric describing, for a WiFi scan attempt, what @@ -2314,7 +2384,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.ScanTimeInEbusy" units="ms" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric describing, for a WiFi scan attempt, how many @@ -2323,8 +2393,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.Security" enum="NetworkSecurityType" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric. The security setting for each successful @@ -2333,7 +2403,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.ServiceErrors" enum="NetworkServiceError" - expires_after="2021-12-01"> + expires_after="2022-04-17"> <owner>kuabhs@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> @@ -2355,8 +2425,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.SignalAtDisconnect" units="negative dBm" - expires_after="2021-12-01"> - <owner>silberst@google.com</owner> + expires_after="2022-04-24"> + <owner>kuabhs@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric indicating the negative of the dBm received signal @@ -2365,8 +2435,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.SignalStrength" units="negative dBm" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>kuabhs@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric indicating the negative of the dBm received signal @@ -2416,9 +2486,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.SupplicantAttempts" units="attempts" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> - <owner>chromeos-kernel-wifi@google.com</owner> + expires_after="2022-04-17"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Number of attempts required for a WiFi device to be established with WPA @@ -2434,9 +2503,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.SuspendDurationWoWOffConnected" - units="seconds" expires_after="2021-12-01"> - <owner>semenzato@chromium.org</owner> - <owner>briannorris@chromium.org</owner> + units="seconds" expires_after="2022-05-01"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Time spent in suspended state, on a resume, for the case when wake on wifi @@ -2446,9 +2514,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.SuspendDurationWoWOffDisconnected" - units="seconds" expires_after="2021-12-01"> - <owner>semenzato@chromium.org</owner> - <owner>briannorris@chromium.org</owner> + units="seconds" expires_after="2022-05-01"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Time spent in suspended state, on a resume, for the case when wake on wifi @@ -2458,8 +2525,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.SuspendDurationWoWOnConnected" units="seconds" expires_after="2021-12-01"> - <owner>semenzato@chromium.org</owner> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Time spent in suspended state, on a resume, for the case when wake on wifi @@ -2470,8 +2536,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.SuspendDurationWoWOnDisconnected" units="seconds" expires_after="2021-12-01"> - <owner>semenzato@chromium.org</owner> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Time spent in suspended state, on a resume, for the case when wake on wifi @@ -2480,8 +2545,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeOnline" units="seconds" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric sampling the time spent using WiFi to transport @@ -2491,8 +2556,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeResumeToReady" units="ms" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-03"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time from the resume event @@ -2503,7 +2568,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.Wifi.TimeToConfig" units="ms" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time to configure Layer 3 @@ -2512,8 +2577,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeToConnect" units="ms" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time to connect to a WiFi @@ -2523,8 +2588,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeToInitialize" units="ms" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-05-01"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time to initialize an @@ -2533,8 +2598,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeToJoin" units="ms" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-17"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time to join (associate @@ -2543,8 +2608,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeToOnline" units="ms" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time to determine that an @@ -2553,8 +2618,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeToPortal" units="ms" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-05-01"> + <owner>matthewmwang@chromium.org</owner> + <owner>hugobenichi@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time to determine that an @@ -2576,8 +2642,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeToScan" units="ms" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-03"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time to scan WiFi until a @@ -2586,8 +2652,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.TimeToScanAndConnect" units="ms" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric sampling the time between the beginning @@ -2598,8 +2664,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.TransmitBitrateMbps" units="Mbps" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric that tracks the transmit bitrate in @@ -2609,8 +2675,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.Wifi.UnreliableLinkSignalStrength" units="units" - expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric sampling the signal strength (0-100) of the wifi @@ -2620,8 +2686,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.UserInitiatedConnectionFailureReason" - enum="ConnectionFailureReason" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + enum="ConnectionFailureReason" expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric that tracks the reasons of failed @@ -2632,8 +2698,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.UserInitiatedConnectionResult" - enum="ConnectionResult" expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + enum="ConnectionResult" expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network performance metric that tracks the result of @@ -2643,7 +2709,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.VerifyWakeOnWiFiSettingsResult" enum="VerifyWakeOnWiFiSettingsResult" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network diagnostic metric sampling the number of times NIC wake on @@ -2654,8 +2720,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.WakeOnWiFiFeaturesEnabledState" - enum="WakeOnWiFiFeaturesEnabledState" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + enum="WakeOnWiFiFeaturesEnabledState" expires_after="2022-04-10"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric that tracks the wake on WiFi features that @@ -2665,7 +2731,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.WakeOnWiFiThrottled" enum="WakeOnWiFiThrottled" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric that tracks whether wake on WiFi was disabled @@ -2677,7 +2743,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Network.Shill.WiFi.WakeReasonReceivedBeforeOnDarkResume" enum="WakeReasonReceivedBeforeOnDarkResume" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network metric that tracks whether a wake reason was received @@ -2686,8 +2752,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Network.Shill.WiFi.WiFiConnectionStatusAfterWake" - enum="WiFiConnectionStatusAfterWake" expires_after="2021-12-01"> - <owner>briannorris@chromium.org</owner> + enum="WiFiConnectionStatusAfterWake" expires_after="2022-04-10"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Chrome OS network usage metric that tracks the WiFi connection status after @@ -2899,7 +2965,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NetworkService.CorsForcedOffForIsolatedWorldOrigin" - enum="BooleanForceDisabled" expires_after="2021-10-10"> + enum="BooleanForceDisabled" expires_after="2021-09-30"> + <obsolete> + Removed in September 2021. + </obsolete> <owner>lukasza@chromium.org</owner> <owner>rdevlin.cronin@chromium.org</owner> <summary> @@ -2913,6 +2982,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="NetworkService.CorsPreflightMethodAllowed" + enum="NetworkServiceCorsPreflightMethodAllowed" expires_after="M97"> + <owner>hiroshige@chromium.org</owner> + <owner>toyoshim@chromium.org</owner> + <summary> + Whether method or normalized method are allowed in CORS preflight request in + PreflightResult::EnsureAllowedCrossOriginMethod(), to measure the impact of + https://crbug.com/1228178. + + Logged for preflight requests that have method checked (i.e. those without + errors before EnsureAllowedCrossOriginMethod). + </summary> +</histogram> + <histogram name="NetworkService.CrossOriginResourcePolicy.ReportOnlyResult" enum="NetworkServiceCorpResult" expires_after="2020-09-30"> <owner>mkwst@chromium.org</owner> @@ -2932,6 +3015,30 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="NetworkService.GrantSandboxResult" + enum="NetworkServiceSandboxGrantResult" expires_after="2022-04-17"> + <owner>wfh@chromium.org</owner> + <owner>mmenke@chromium.org</owner> + <summary> + The result of the attempt to grant the sandbox access to a network context + data files, and migrate the data if a migration is requested. This is + reported each time a network context instance is created on the network + service, even when the sandbox is not enabled or no migration is requested. + </summary> +</histogram> + +<histogram name="NetworkService.GrantSandboxToCacheResult" + enum="NetworkServiceSandboxGrantResult" expires_after="2022-04-10"> + <owner>wfh@chromium.org</owner> + <owner>mmenke@chromium.org</owner> + <summary> + The result of the attempt to grant the sandbox access to a network context + HTTP cache files. This is reported each time a network context instance is + created on the network service and it has a valid HTTP cache path and HTTP + cache is enabled. + </summary> +</histogram> + <histogram name="NetworkService.MdnsResponder.ServiceError" enum="MdnsResponderServiceError" expires_after="M81"> <owner>qingsi@chromium.org</owner> @@ -2995,9 +3102,53 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="NetworkService.TimeToGrantCacheAccess" units="ms" + expires_after="2022-05-01"> + <owner>wfh@chromium.org</owner> + <owner>mmenke@chromium.org</owner> + <summary> + The time taken to permit the sandbox access to the cache directory during + network context initialization. This is recorded each time a network context + is created with a valid disk cache specified. This histogram is platform + dependent so values from different platforms cannot be directly compared. On + Windows, this records the amount of time taken to set the filesystem ACLs to + allow the sandbox access to the cache directory. + </summary> +</histogram> + +<histogram name="NetworkService.TimeToGrantDataAccess" units="ms" + expires_after="M97"> + <owner>wfh@chromium.org</owner> + <owner>mmenke@chromium.org</owner> + <summary> + The time taken to permit the sandbox access to the data directory during + network context initialization. This is recorded each time a network context + is created with a valid set of NetworkContextFilePaths with + unsandboxed_data_path specified indicating it could be sandboxed. This + histogram is platform dependent so values from different platforms cannot be + directly compared. On Windows, this records the amount of time taken to set + the filesystem ACLs to allow the sandbox access to the data directory. + </summary> +</histogram> + +<histogram name="NetworkService.TimeToMigrateData" units="ms" + expires_after="2022-04-17"> + <owner>wfh@chromium.org</owner> + <owner>mmenke@chromium.org</owner> + <summary> + The time taken to copy the network context data files from the unsandboxed + data path to the new sandbox data path. This is recorded each time an + unmigrated network context is created with a valid set of data file paths, + an unsandboxed_data_path to migrate from, and trigger_migration specified. + This could include several logs from the same client for the same network + context if the migration fails, since this is reported each time the + migration is attempted. + </summary> +</histogram> + <histogram name="NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility" - enum="RequestInitiatorOriginLockCompatibility" expires_after="2022-01-09"> + enum="RequestInitiatorOriginLockCompatibility" expires_after="2022-04-10"> <owner>lukasza@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>jam@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/new_tab_page/histograms.xml b/chromium/tools/metrics/histograms/metadata/new_tab_page/histograms.xml index 23efa60725a..8cb32b1be21 100644 --- a/chromium/tools/metrics/histograms/metadata/new_tab_page/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/new_tab_page/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="NewTabPage.ActionAndroid2" enum="NewTabPageActionAndroid2" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>twellington@chromium.org</owner> <owner>finkm@chromium.org</owner> <summary> @@ -34,7 +34,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.ActioniOS" enum="NewTabPageActioniOS" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>justincohen@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> @@ -104,7 +104,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Carts.CartCount" units="count" - expires_after="2021-12-30"> + expires_after="2022-03-06"> <owner>wychen@chromium.org</owner> <owner>yuezhanggg@chromium.org</owner> <owner>chrome-shopping@google.com</owner> @@ -126,7 +126,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Carts.ClickCart.HasDiscount" - enum="BooleanHasDiscount" expires_after="2021-12-30"> + enum="BooleanHasDiscount" expires_after="2022-04-24"> <owner>meiliang@chromium.org</owner> <owner>yuezhanggg@chromium.org</owner> <owner>chrome-shopping@google.com</owner> @@ -182,7 +182,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Carts.DiscountCountAtLoad" units="count" - expires_after="2021-12-30"> + expires_after="2022-04-17"> <owner>meiliang@chromium.org</owner> <owner>yuezhanggg@chromium.org</owner> <owner>chrome-shopping@google.com</owner> @@ -195,7 +195,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="NewTabPage.Click" enum="NTPElement" expires_after="2022-01-01"> +<histogram name="NewTabPage.Click" enum="NTPElement" expires_after="2022-04-10"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -207,8 +207,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="NewTabPage.ConcretePage" enum="NewTabPageConcretePage" + expires_after="2022-06-01"> + <owner>danpeng@google.com</owner> + <owner>tiborg@chromium.org</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Records the concrete page loaded when navigating to chrome://newtab. + Recorded on every NTP load. + </summary> +</histogram> + <histogram name="NewTabPage.ContentSuggestions.ArticlesListVisible" - enum="BooleanVisible" expires_after="2022-01-09"> + enum="BooleanVisible" expires_after="2022-04-03"> <owner>freedjm@chromium.org</owner> <owner>feed@chromium.org</owner> <summary> @@ -496,7 +507,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.ContentSuggestions.Preferences.RemoteSuggestions" - enum="BooleanEnabled" expires_after="2021-12-26"> + enum="BooleanEnabled" expires_after="2022-04-03"> <owner>carlosk@chromium.org</owner> <owner>freedjm@chromium.org</owner> <owner>feed@chromium.org</owner> @@ -713,9 +724,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.CustomizeChromeBackgroundAction" - enum="NTPCustomizeChromeBackgroundAction" expires_after="2021-08-29"> - <owner>dbeam@chromium.org</owner> + enum="NTPCustomizeChromeBackgroundAction" expires_after="2022-01-01"> + <owner>danpeng@google.com</owner> + <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> + <owner>chrome-desktop-ntp@google.com</owner> <summary> Captures the actions performed when configuring a 'Chrome background' image on the New Tab Page. Since most actions are sequential, this may indicate @@ -724,7 +737,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Customized" enum="NTPCustomizedFeatures" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -735,7 +748,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.CustomizedShortcuts" - enum="NTPCustomizedShortcutSettings" expires_after="2022-01-01"> + enum="NTPCustomizedShortcutSettings" expires_after="2022-04-03"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -759,7 +772,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.CustomizeShortcutAction" - enum="NTPCustomizeShortcutAction" expires_after="2022-01-01"> + enum="NTPCustomizeShortcutAction" expires_after="2022-04-03"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -770,7 +783,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Drive.FileClick" units="index" - expires_after="2022-01-01"> + expires_after="2022-04-10"> <owner>tiborg@chromium.org</owner> <owner>aee@chromium.org</owner> <owner>andrevincent@google.com</owner> @@ -780,6 +793,32 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="NewTabPage.HasCredentials" enum="BooleanYesNo" + expires_after="2022-06-30"> + <owner>danpeng@google.com</owner> + <owner>tiborg@chromium.org</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Logs whether Chrome has valid user credentials for the profile the NTP is + loading in. Logged when the NTP starts loading. Only logged on the 1P NTP. + Note that even if the user has Google as their default search engine, + Incognito and Guest mode NTPs are not considered 1P and don't log this + histogram. + </summary> +</histogram> + +<histogram name="NewTabPage.Height" units="pixels" expires_after="2022-06-01"> + <owner>danpeng@google.com</owner> + <owner>tiborg@chromium.org</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Height of the NTP viewport in CSS pixels. Logged when the NTP loads. Only + logged on the 1P NTP. Note that even if the user has Google as their default + search engine, Incognito and Guest mode NTPs are not considered 1P and don't + log this histogram. + </summary> +</histogram> + <histogram name="NewTabPage.Languages.UILanguageRatioInTwoTopLanguages" units="%" expires_after="M77"> <owner>jkrcal@chromium.org</owner> @@ -840,7 +879,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="NewTabPage.LoadTime" units="ms" expires_after="2022-01-01"> +<histogram name="NewTabPage.LoadTime" units="ms" expires_after="2022-03-06"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -902,7 +941,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.LogoShown" enum="NewTabPageLogoShown" - expires_after="2022-01-16"> + expires_after="2022-05-01"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -925,7 +964,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.MainUi.ShownTime" units="ms" - expires_after="2021-11-12"> + expires_after="2022-04-17"> <owner>tiborg@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> <summary> @@ -946,7 +985,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.DataRequest" enum="NtpModules" - expires_after="2022-01-01"> + expires_after="2022-04-17"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -991,7 +1030,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="NewTabPage.Modules.EnabledOnNTPLoad" - enum="BooleanEnabled" expires_after="2022-01-01"> + enum="BooleanEnabled" expires_after="2022-04-10"> <owner>danielms@google.com</owner> <owner>tiborg@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1022,7 +1061,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.Hover" enum="NtpModules" - expires_after="2022-01-01"> + expires_after="2022-04-10"> <owner>danielms@google.com</owner> <owner>tiborg@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1035,7 +1074,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.Impression" units="ms" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1049,7 +1088,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.ImpressionRatio" units="perdecage" - expires_after="2022-01-01"> + expires_after="2022-03-06"> <owner>danielms@google.com</owner> <owner>tiborg@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1069,7 +1108,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.LoadDuration" units="ms" - expires_after="2022-01-01"> + expires_after="2022-03-06"> <owner>danielms@google.com</owner> <owner>tiborg@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1079,7 +1118,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.Loaded" units="ms" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1103,7 +1142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.ShownTime" units="ms" - expires_after="2022-01-01"> + expires_after="2022-03-06"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1114,7 +1153,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.Usage" units="count" - expires_after="2022-01-01"> + expires_after="2022-04-03"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1126,7 +1165,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Modules.VisibleOnNTPLoad" enum="BooleanVisible" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1184,8 +1223,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="NewTabPage.NumberOfPreinstalledApps" units="count" + expires_after="M97"> + <owner>phillis@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + The number of preinstalled apps that are in NTP tiles. Recorded when new tab + page is loaded. Recorded before reloading the suggestions, navigating to a + URL, switching tabs, changing the active window or closing the tab/shutting + down Chrome. + </summary> +</histogram> + <histogram name="NewTabPage.NumberOfTiles" units="units" - expires_after="2022-01-16"> + expires_after="2022-04-10"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1202,7 +1253,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.OneGoogleBar.RequestLatency" units="ms" - expires_after="2021-11-21"> + expires_after="2022-04-17"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1223,8 +1274,75 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="NewTabPage.Photos.DataRequest" + enum="PhotosModuleRequestResult" expires_after="2022-06-30"> + <owner>jerem@google.com</owner> + <owner>tiborg@chromium.org</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Logs the state of Photos module API requests. Only logged on the 1P NTP. + Note that even if the user has Google as their default search engine, + Incognito and Guest mode NTPs are not considered 1P and don't log this + histogram. + </summary> +</histogram> + +<histogram name="NewTabPage.Photos.DataResponseCount" units="count" + expires_after="2022-06-30"> + <owner>jerem@google.com</owner> + <owner>tiborg@chromium.org</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Logs the number of memories in the photos module response. Only logged on + the 1P NTP. Note that even if the user has Google as their default search + engine, Incognito and Guest mode NTPs are not considered 1P and don't log + this histogram. + </summary> +</histogram> + +<histogram name="NewTabPage.Photos.ImageLoad" enum="BooleanSuccess" + expires_after="2022-06-30"> + <owner>tiborg@chromium.org</owner> + <owner>jerem@google.com</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Logged every time we try to load an image in the photos module. This + histogram logs 'Success' when loading was successful and 'Failure' when + there was an error. Only logged on the 1P NTP. Note that even if the user + has Google as their default search engine, Incognito and Guest mode NTPs are + not considered 1P and don't log this histogram. + </summary> +</histogram> + +<histogram name="NewTabPage.Photos.ModuleShown" enum="BooleanOptedIn" + expires_after="2022-06-30"> + <owner>tiborg@chromium.org</owner> + <owner>jerem@google.com</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Logged every time the photos module is shown to the user. This histogram + logs 'Not opted-in' when the opt-in screen was shown and 'Opted-in' when + memories were shown. Only logged on the 1P NTP. Note that even if the user + has Google as their default search engine, Incognito and Guest mode NTPs are + not considered 1P and don't log this histogram. + </summary> +</histogram> + +<histogram name="NewTabPage.Photos.UserOptIn" enum="BooleanOptedIn" + expires_after="2022-06-30"> + <owner>tiborg@chromium.org</owner> + <owner>jerem@google.com</owner> + <owner>chrome-desktop-ntp@google.com</owner> + <summary> + Logged every time the user decides to opt in ('Opted-in') or out ('Not + opted-in') from seeing the photos module. Only logged on the 1P NTP. Note + that even if the user has Google as their default search engine, Incognito + and Guest mode NTPs are not considered 1P and don't log this histogram. + </summary> +</histogram> + <histogram name="NewTabPage.Promo.EnhancedProtectionPromo" - enum="AndroidEnhancedProtectionPromoAction" expires_after="2022-01-09"> + enum="AndroidEnhancedProtectionPromoAction" expires_after="2022-03-13"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-core@google.com</owner> <summary> @@ -1235,7 +1353,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="NewTabPage.Promo.EnhancedProtectionPromo.ImpressionUntilAction" - units="units" expires_after="2022-01-16"> + units="units" expires_after="2022-03-20"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-core@google.com</owner> <summary> @@ -1247,7 +1365,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="NewTabPage.Promo.EnhancedProtectionPromo.ImpressionUntilDismissal" - units="units" expires_after="2022-01-23"> + units="units" expires_after="2022-03-27"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-core@google.com</owner> <summary> @@ -1348,7 +1466,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.Realbox.CharTypedToRepaintLatency.ToPaint" - units="ms" expires_after="2022-01-01"> + units="ms" expires_after="2022-05-01"> <owner>mahmadi@chromium.org</owner> <owner>tommycli@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1363,7 +1481,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.RecipeTasks.RecipeClick" units="index" - expires_after="2022-01-01"> + expires_after="2022-04-24"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1398,7 +1516,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.RecipeTasks.RelatedSearchDownloadCount" - units="count" expires_after="2022-01-01"> + units="count" expires_after="2022-03-06"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1481,7 +1599,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.SearchAvailableLoadTime2.ColdStart" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-20"> <owner>fgorski@chromium.org</owner> <owner>ender@google.com</owner> <owner>yyushkina@chromium.org</owner> @@ -1507,8 +1625,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="NewTabPage.SearchSuggestions.IndexClicked" units="units" expires_after="never"> -<!-- expires-never: part of top-line metric (internal: go/chrome-browser-nsm) --> - + <obsolete> + Not recorded since deprecation of search suggestions. Marked obsolete + 09/2021. + </obsolete> <owner>dbeam@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-analysis-team@google.com</owner> @@ -1522,6 +1642,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="NewTabPage.SearchSuggestions.RequestLatencyV2" units="ms" expires_after="M82"> + <obsolete> + Not recorded since deprecation of search suggestions. Marked obsolete + 09/2021. + </obsolete> <owner>dbeam@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <summary> @@ -1532,6 +1656,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="NewTabPage.SearchSuggestions.RequestStatusV2" enum="NTPSearchSuggestionsRequestStatus" expires_after="M82"> + <obsolete> + Not recorded since deprecation of search suggestions. Marked obsolete + 09/2021. + </obsolete> <owner>dbeam@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <summary> @@ -1542,6 +1670,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="NewTabPage.SearchSuggestions.ShownCount" units="units" expires_after="M82"> + <obsolete> + Not recorded since deprecation of search suggestions. Marked obsolete + 09/2021. + </obsolete> <owner>dbeam@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <summary> @@ -1585,7 +1717,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.ShoppingTasks.RelatedSearchDownloadCount" - units="count" expires_after="2021-12-19"> + units="count" expires_after="2022-02-20"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1749,7 +1881,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.SuggestionsImpression" enum="MostVisitedTileIndex" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1873,7 +2005,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.TileTitle" enum="NTPTileTitleSource" - expires_after="2022-01-01"> + expires_after="2022-04-10"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1884,7 +2016,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.TileTitleClicked" enum="NTPTileTitleSource" - expires_after="2022-01-01"> + expires_after="2022-04-10"> <owner>danielms@google.com</owner> <owner>tiborg@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1895,7 +2027,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.TileType" enum="NTPTileVisualType" - expires_after="2021-10-25"> + expires_after="2022-04-10"> <owner>dbeam@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <summary> @@ -1906,7 +2038,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.TileTypeClicked" enum="NTPTileVisualType" - expires_after="2021-10-25"> + expires_after="2022-04-10"> <owner>dbeam@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <summary> @@ -1916,7 +2048,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.TimeSinceLastNTP" units="ms" - expires_after="2022-01-01"> + expires_after="2022-04-17"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> @@ -1931,7 +2063,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="NewTabPage.TimeSpent" units="ms" expires_after="2022-01-09"> +<histogram name="NewTabPage.TimeSpent" units="ms" expires_after="2022-04-03"> <owner>freedjm@chromium.org</owner> <owner>feed@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> @@ -1943,7 +2075,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.TimeSpentBeforeDismissLens" units="ms" - expires_after="M97"> + expires_after="2022-04-17"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <owner>fgorski@chromium.org</owner> @@ -2016,7 +2148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NewTabPage.VoiceActions" enum="NewTabPageVoiceAction" - expires_after="2022-01-16"> + expires_after="2022-04-24"> <owner>tiborg@chromium.org</owner> <owner>yyushkina@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> diff --git a/chromium/tools/metrics/histograms/metadata/notifications/histograms.xml b/chromium/tools/metrics/histograms/metadata/notifications/histograms.xml index bba23548ea5..1409d6495fc 100644 --- a/chromium/tools/metrics/histograms/metadata/notifications/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/notifications/histograms.xml @@ -21,6 +21,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> +<variants name="MacOSNotificationStyle"> + <variant name="Alert" summary="Alert: Stays on screen"/> + <variant name="Alerts"> + <obsolete> + Replaced by Alert in 2021/09. + </obsolete> + </variant> + <variant name="Banner" summary="Banner: Auto dismisses"/> + <variant name="Banners"> + <obsolete> + Replaced by Banner in 2021/09. + </obsolete> + </variant> +</variants> + <histogram name="Notifications.Actions" enum="NotificationActionType" expires_after="M85"> <owner>dewittj@chromium.org</owner> @@ -31,7 +46,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Android.Build" enum="BooleanSuccess" - expires_after="M96"> + expires_after="2022-04-03"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -56,7 +71,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Android.SitesChannel" enum="BooleanUsage" - expires_after="2021-10-25"> + expires_after="2022-04-10"> <owner>peter@chromium.org</owner> <summary> Recorded when the Sites channel (which we hope to deprecate) is used as a @@ -136,7 +151,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Blocker.ScreenCapture.ClosedCount" - units="notifications" expires_after="2022-01-23"> + units="notifications" expires_after="2022-04-24"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -147,7 +162,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Blocker.ScreenCapture.MutedCount" - units="notifications" expires_after="2022-01-23"> + units="notifications" expires_after="2022-04-10"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -160,7 +175,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Blocker.ScreenCapture.ReplacedCount" - units="notifications" expires_after="2022-01-23"> + units="notifications" expires_after="2022-04-24"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -171,7 +186,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Blocker.ScreenCapture.RevealDuration" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -182,7 +197,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Blocker.ScreenCapture.SessionDuration" - units="ms" expires_after="2022-01-23"> + units="ms" expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -193,7 +208,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Blocker.ScreenCapture.SnoozedCount" - units="notifications" expires_after="2021-11-21"> + units="notifications" expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -232,7 +247,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Cros.Actions" enum="NotificationTypeDetailed" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>tbarzic@chromium.org</owner> <owner>tengs@chromium.org</owner> <owner>gzadina@google.com</owner> @@ -253,7 +268,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.DeleteBeforeWriteResult" - enum="NotificationDatabaseStatus" expires_after="2022-01-02"> + enum="NotificationDatabaseStatus" expires_after="2022-05-01"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -264,7 +279,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.DeleteResult" - enum="NotificationDatabaseStatus" expires_after="2022-01-02"> + enum="NotificationDatabaseStatus" expires_after="2022-04-24"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -284,7 +299,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.DestroyResult" - enum="NotificationDatabaseStatus" expires_after="2022-01-02"> + enum="NotificationDatabaseStatus" expires_after="2022-04-24"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -294,7 +309,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.ExpiredNotificationCount" - units="notifications" expires_after="2022-01-02"> + units="notifications" expires_after="2022-04-03"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -306,10 +321,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.OldestNotificationTimeInMinutes" - units="minutes" expires_after="2021-12-26"> + units="minutes" expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> - <owner>adelm@google.com</owner> <summary> Records the age of the oldest notification for an origin. Logged after handling a push event for that origin. @@ -338,7 +352,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.ReadForServiceWorkerResult" - enum="NotificationDatabaseStatus" expires_after="2021-10-31"> + enum="NotificationDatabaseStatus" expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -370,7 +384,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.ReadResult" - enum="NotificationDatabaseStatus" expires_after="2021-12-26"> + enum="NotificationDatabaseStatus" expires_after="2022-04-10"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -380,7 +394,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Database.WriteResult" - enum="NotificationDatabaseStatus" expires_after="2021-12-26"> + enum="NotificationDatabaseStatus" expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -422,7 +436,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.LoadProfileResult" enum="BooleanSuccess" - expires_after="M96"> + expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -442,10 +456,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. will continue to pass along the event. Logged on every action received by the system (click or close) on any {Style} style notification. </summary> - <token key="Style"> - <variant name="Alert"/> - <variant name="Banner"/> - </token> + <token key="Style" variants="MacOSNotificationStyle"/> </histogram> <histogram name="Notifications.macOS.Delivered.{Style}" enum="BooleanSuccess" @@ -456,10 +467,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. Whether delivering a notification to the system was successful or not. Logged every time we pass a notification with {Style} style to the system. </summary> - <token key="Style"> - <variant name="Alert"/> - <variant name="Banner"/> - </token> + <token key="Style" variants="MacOSNotificationStyle"/> </histogram> <histogram name="Notifications.macOS.LaunchedViaNotificationAction" @@ -475,7 +483,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.macOS.ServiceProcessKilled" units="ms" - expires_after="M96"> + expires_after="2022-04-03"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -485,7 +493,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.macOS.ServiceProcessRuntime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -541,7 +549,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.NotifierType" enum="NotifierType" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>tbarzic@chromium.org</owner> <owner>tengs@chromium.org</owner> <owner>gzadina@google.com</owner> @@ -552,7 +560,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Permissions.RevokeDeleteCount" units="units" - expires_after="2021-10-25"> + expires_after="2022-04-24"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -562,9 +570,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="Notifications.Permissions.UNNotification.{Style}.PermissionRequest" + enum="UNNotificationPermissionRequestResult" expires_after="M98"> + <owner>knollr@chromium.org</owner> + <owner>peter@chromium.org</owner> + <summary> + The permission request result for sending out UNNotifications through the + MacNotificationServiceUN. This is recorded when instantiating the service + which happens at Chrome startup and each time we start the service after + shutting it down when there were no more notifications on screen. + </summary> + <token key="Style" variants="MacOSNotificationStyle"/> +</histogram> + +<histogram name="Notifications.Permissions.UNNotification.{Style}.PermissionStatus" - enum="UNNotificationPermissionStatus" expires_after="2021-10-25"> - <owner>adelm@google.com</owner> + enum="UNNotificationPermissionStatus" expires_after="M98"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -573,15 +594,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. which happens at Chrome startup and each time we start the service after shutting it down when there were no more notifications on screen. </summary> - <token key="Style"> - <variant name="Alerts"/> - <variant name="Banners"/> - </token> + <token key="Style" variants="MacOSNotificationStyle"/> </histogram> <histogram name="Notifications.Permissions.UNNotification.{Style}.Style" - enum="UNNotificationStyle" expires_after="M94"> - <owner>adelm@google.com</owner> + enum="UNNotificationStyle" expires_after="M98"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -591,10 +608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. service after shutting it down when there were no more notifications on screen. </summary> - <token key="Style"> - <variant name="Alerts"/> - <variant name="Banners"/> - </token> + <token key="Style" variants="MacOSNotificationStyle"/> </histogram> <histogram name="Notifications.PerNotificationActions" @@ -609,7 +623,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.PersistentNotificationActionCount" - units="buttons" expires_after="2021-12-26"> + units="buttons" expires_after="2022-04-17"> <owner>peter@chromium.org</owner> <summary> The number of action buttons the developer provided for a persistent Web @@ -618,7 +632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.PersistentNotificationDisplayResult" - enum="PersistentNotificationDisplayResult" expires_after="2021-12-26"> + enum="PersistentNotificationDisplayResult" expires_after="2022-04-03"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -628,7 +642,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.PersistentWebNotificationClickEventResult" - enum="ServiceWorkerStatusCode" expires_after="M98"> + enum="ServiceWorkerStatusCode" expires_after="2022-05-01"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -638,7 +652,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.PersistentWebNotificationClickResult" - enum="PlatformNotificationStatus" expires_after="2021-12-26"> + enum="PlatformNotificationStatus" expires_after="2022-04-03"> <owner>peter@chromium.org</owner> <owner>deepak.m1@samsung.com</owner> <summary> @@ -658,7 +672,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.PersistentWebNotificationCloseResult" - enum="PlatformNotificationStatus" expires_after="2021-12-26"> + enum="PlatformNotificationStatus" expires_after="2022-05-01"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -668,7 +682,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Scheduler.BackgroundTask.Event" - enum="NotificationSchedulerBackgroundTaskEvent" expires_after="2021-12-31"> + enum="NotificationSchedulerBackgroundTaskEvent" expires_after="2022-05-01"> <owner>xingliu@chromium.org</owner> <owner>hesen@chromium.org</owner> <summary> @@ -717,7 +731,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Scheduler.IconDb.RecordCount" units="records" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>xingliu@chromium.org</owner> <owner>hesen@chromium.org</owner> <summary> @@ -791,7 +805,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Scheduler.NotificationDb.InitResult" - enum="BooleanSuccess" expires_after="2021-12-31"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>xingliu@chromium.org</owner> <owner>hesen@chromium.org</owner> <summary> @@ -822,7 +836,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Notifications.Scheduler.NotificationLifeCycleEvent" enum="NotificationSchedulerNotificationLifeCycleEvent" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="NotificationSchedulerClientType" --> <owner>xingliu@chromium.org</owner> @@ -858,7 +872,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Scheduler.UserAction" - enum="NotificationSchedulerUserActionType" expires_after="2021-12-31"> + enum="NotificationSchedulerUserActionType" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="NotificationSchedulerClientType" --> <owner>xingliu@chromium.org</owner> @@ -1007,7 +1021,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.CloseStatus" - enum="WindowsNotificationCloseStatus" expires_after="M94"> + enum="WindowsNotificationCloseStatus" expires_after="M98"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1017,7 +1031,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.CreateToastManagerErrorCode" - enum="Hresult" expires_after="M94"> + enum="Hresult" expires_after="M98"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1029,7 +1043,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.DisplayFailure" enum="Hresult" - expires_after="M94"> + expires_after="2022-05-01"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1052,7 +1066,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.GetDisplayedLaunchIdStatus" - enum="WindowsNotificationGetDisplayedLaunchIdStatus" expires_after="M94"> + enum="WindowsNotificationGetDisplayedLaunchIdStatus" expires_after="M98"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1063,7 +1077,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.GetDisplayedStatus" - enum="WindowsNotificationGetDisplayedStatus" expires_after="M94"> + enum="WindowsNotificationGetDisplayedStatus" expires_after="M98"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1086,7 +1100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.GetSettingPolicy" - enum="WindowsNotificationGetSettingPolicy" expires_after="M94"> + enum="WindowsNotificationGetSettingPolicy" expires_after="M98"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1096,7 +1110,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.GetSettingPolicyStartup" - enum="WindowsNotificationGetSettingPolicy" expires_after="2022-01-02"> + enum="WindowsNotificationGetSettingPolicy" expires_after="2022-04-17"> <owner>finnur@chromium.org</owner> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> @@ -1107,7 +1121,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.GetSettingStatus" - enum="WindowsNotificationGetSettingStatus" expires_after="2022-01-02"> + enum="WindowsNotificationGetSettingStatus" expires_after="2022-04-24"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1117,7 +1131,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.GetSettingStatusStartup" - enum="WindowsNotificationGetSettingStatus" expires_after="M94"> + enum="WindowsNotificationGetSettingStatus" expires_after="2022-05-01"> <owner>finnur@chromium.org</owner> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> @@ -1138,7 +1152,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.HistoryStatus" - enum="WindowsNotificationHistoryStatus" expires_after="M94"> + enum="WindowsNotificationHistoryStatus" expires_after="M98"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1158,7 +1172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.OnFailedStatus" - enum="WindowsNotificationOnFailedStatus" expires_after="M94"> + enum="WindowsNotificationOnFailedStatus" expires_after="M98"> <owner>chengx@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1168,7 +1182,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.SetReadyCallbackStatus2" - enum="WindowsNotificationSetReadyCallbackStatus2" expires_after="M94"> + enum="WindowsNotificationSetReadyCallbackStatus2" expires_after="M98"> <owner>chengx@chromium.org</owner> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> @@ -1179,7 +1193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.ShowFailedErrorCode" enum="Hresult" - expires_after="M94"> + expires_after="M98"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -1190,7 +1204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Notifications.Windows.StartMenuShortcutStatus" - enum="WindowsNotificationStartMenuShortcutStatus" expires_after="M94"> + enum="WindowsNotificationStartMenuShortcutStatus" expires_after="M98"> <owner>chengx@chromium.org</owner> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/obsolete_histograms.xml b/chromium/tools/metrics/histograms/metadata/obsolete_histograms.xml index 2ac44e49c26..35c9d498e3b 100644 --- a/chromium/tools/metrics/histograms/metadata/obsolete_histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/obsolete_histograms.xml @@ -9545,24 +9545,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Compositing.Browser.GPUMemoryForTilingsInKb" units="Kb" - expires_after="M87"> - <obsolete> - Removed September, 2020. Memory.GPU.PeakMemoryUsage.PageLoad can be used to - track overall GPU memory usage. - </obsolete> - <owner>pdr@chromium.org</owner> - <owner>paint-dev@chromium.org</owner> - <summary> - The GPU memory allocated for tilings (in a browser process), summed over all - picture layers. Emitted once per drawing. Nothing is recorded if there are - no picture layers. - - Tilings are used for decomposition of the layer's entire contents at a - picture screenspace resolution to do threaded rasterization. - </summary> -</histogram> - <histogram name="Compositing.Browser.PictureMemoryUsageKb" units="KB" expires_after="M85"> <obsolete> @@ -85730,35 +85712,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Uptime.LoginPromptSetupTimeAfterLogout" units="ms" - expires_after="M85"> - <obsolete> - Removed 09/2020. No direct replacement. - </obsolete> - <owner>hajimehoshi@chromium.org</owner> - <owner>kouhei@chromium.org</owner> - <summary> - Measures the time elapsed on Chrome OS for setting up for a login after a - logout. More specifically, it is the time between when the Cryptohome is - unmounted (the last step in the logout process) and when the login prompt is - again visible after a logout. - </summary> -</histogram> - -<histogram name="Uptime.Logout" units="ms" expires_after="M85"> - <obsolete> - Removed 09/2020. No direct replacement. - </obsolete> - <owner>hajimehoshi@chromium.org</owner> - <owner>kouhei@chromium.org</owner> - <summary> - Measures the time elapsed on Chrome OS when performing a logout. More - specifically, it is the time between when a logout is initiated and when the - Cryptohome is unmounted, signaling the last step in the logout process. This - statistic is not collected when the logout is part of a restart or shutdown. - </summary> -</histogram> - <histogram name="Uptime.ProcessesTerminatedToXTerminatedAfterLogout" units="ms" expires_after="2018-06-06"> <obsolete> diff --git a/chromium/tools/metrics/histograms/metadata/offline/histograms.xml b/chromium/tools/metrics/histograms/metadata/offline/histograms.xml index 7d17445b988..8cd5ded73e3 100644 --- a/chromium/tools/metrics/histograms/metadata/offline/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/offline/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Offline.Measurements.HttpProbeResult" - enum="OfflineMeasurementsHttpProbeResult" expires_after="M100"> + enum="OfflineMeasurementsHttpProbeResult" expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -36,7 +36,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Offline.Measurements.IsAirplaneModeEnabled" - enum="BooleanEnabled" expires_after="M95"> + enum="BooleanEnabled" expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -52,7 +52,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Offline.Measurements.IsRoaming" enum="Boolean" - expires_after="M95"> + expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -69,7 +69,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Offline.Measurements.MeasurementInterval" units="minutes" - expires_after="M95"> + expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -80,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Offline.Measurements.TimeBetweenChecks" units="minutes" - expires_after="M95"> + expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -91,7 +91,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Offline.Measurements.UserState" - enum="OfflineMeasurementsUserState" expires_after="M95"> + enum="OfflineMeasurementsUserState" expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -157,7 +157,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OfflineIndicator.ShownDurationV2" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -205,7 +205,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="OfflineIndicator.ShownDurationV2.InForegroundWithoutBeingBackgrounded" - units="ms" expires_after="2021-12-05"> + units="ms" expires_after="2022-05-01"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -221,7 +221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OfflineIndicator.ShownDurationV2.NumTimesBackgrounded" - units="times backgrounded" expires_after="2021-12-05"> + units="times backgrounded" expires_after="2022-05-01"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -269,7 +269,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OfflinePages.AccessPageCount" - enum="OfflinePagesNamespaceEnumeration" expires_after="2021-10-31"> + enum="OfflinePagesNamespaceEnumeration" expires_after="2022-04-24"> <owner>dimich@chromium.org</owner> <owner>offline-dev@chromium.org</owner> <summary> @@ -728,7 +728,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OfflinePages.DidNavigationThrottleCancelNavigation" - enum="Boolean" expires_after="M100"> + enum="Boolean" expires_after="2022-04-17"> <owner>curranmax@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -813,7 +813,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OfflinePages.OfflineUsage" enum="OfflinePagesOfflineUsage" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>dimich@chromium.org</owner> <owner>offline-dev@chromium.org</owner> <summary> @@ -948,7 +948,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OfflinePages.Prefetching.FinishedItemErrorCode" - enum="OfflinePrefetchItemErrorCode" expires_after="2022-01-02"> + enum="OfflinePrefetchItemErrorCode" expires_after="2022-03-06"> <owner>carlosk@chromium.org</owner> <owner>offline-dev@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/omnibox/histograms.xml b/chromium/tools/metrics/histograms/metadata/omnibox/histograms.xml index a1cc22c86ca..6c16a74cf66 100644 --- a/chromium/tools/metrics/histograms/metadata/omnibox/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/omnibox/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Omnibox.AnswerParseSuccess" enum="BooleanSuccess" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>jdonnelly@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.AnswerParseType" enum="SuggestionAnswerType" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -47,7 +47,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.BitmapFetchLatency" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <!-- Name completed by histogram_suffixes name="Omnibox.BitmapFetchLatencyCacheSplit" --> <owner>manukh@chromium.org</owner> @@ -64,7 +64,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.CharTypedToRepaintLatency" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>asvitkine@chromium.org</owner> @@ -96,7 +96,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.CharTypedToRepaintLatency.InsertToPresent" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>asvitkine@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -124,7 +124,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.CharTypedToRepaintLatency.ToPaint" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-24"> <owner>asvitkine@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -137,7 +137,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ClipboardSuggestionRemovedAge" units="ms" - expires_after="2021-09-01"> + expires_after="2022-05-01"> <owner>gangwu@chromium.org</owner> <owner>fgorski@chromium.org</owner> <summary> @@ -148,7 +148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ClipboardSuggestionShownAge" units="ms" - expires_after="2021-09-19"> + expires_after="2022-03-19"> <owner>gangwu@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <summary> @@ -166,7 +166,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ClipboardSuggestionShownNumTimes" units="units" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>gangwu@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <summary> @@ -196,7 +196,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ClipboardSuggestionShownWithCurrentURL" - enum="BooleanPresent" expires_after="M93"> + enum="BooleanPresent" expires_after="2022-10-01"> <owner>gangwu@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <summary> @@ -221,7 +221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.CutOrCopyAllText" units="count" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -232,7 +232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.DocumentSuggest.Requests" - enum="OmniboxDocumentSuggestRequests" expires_after="2021-12-12"> + enum="OmniboxDocumentSuggestRequests" expires_after="2022-04-10"> <owner>manukh@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -244,7 +244,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.DocumentSuggest.ResultCount" units="count" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>manukh@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -274,7 +274,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.EnteredKeywordMode2" enum="OmniboxEnteredKeywordMode2" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -288,7 +288,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.FocusResultedInNavigation" enum="BooleanNavigated" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>ender@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> @@ -320,7 +320,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.FocusToOpenTimeAnyPopupState3" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -371,7 +371,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.InputType" enum="OmniboxInputType" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -389,7 +389,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.IsPasteAndGo" enum="Boolean" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -427,7 +427,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.JustDeletedText" enum="Boolean" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -603,7 +603,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.NumTypedTerms" units="terms" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -639,7 +639,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Omnibox.PaintTime" units="ms" expires_after="2022-01-02"> +<histogram name="Omnibox.PaintTime" units="ms" expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -672,7 +672,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.PedalShown" enum="SuggestionPedalType" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>orinj@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -692,7 +692,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Omnibox.ProviderTime2" units="ms" expires_after="2022-01-02"> +<histogram name="Omnibox.ProviderTime2" units="ms" expires_after="2022-04-17"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -701,7 +701,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Omnibox.QueryTime2" units="ms" expires_after="2022-01-02"> +<histogram name="Omnibox.QueryTime2" units="ms" expires_after="2022-03-06"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -712,6 +712,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Omnibox.ResumeJourneyShown" units="position" + expires_after="2022-08-24"> + <owner>tommycli@chromium.org</owner> + <owner>chrome-omnibox-team@google.com</owner> + <summary> + Emits the position of any "Resume Journey" omnibox actions shown + in the popup. The position index is 0-based, so an action shown in the + topmost match is logged as value 0, consistent with + Omnibox.SelectedPosition. + + Note that these are emitted when the user uses the omnibox to go somewhere. + When that happens, one count is emitted per action visible in the popup. + These are NOT emitted per-keystroke, in order to make this a suitable + denominator for Omnibox.SuggestionUsed.ResumeJourney. + </summary> +</histogram> + <histogram name="Omnibox.Search.OffTheRecord" enum="BooleanOffTheRecord" expires_after="2022-02-02"> <owner>rhalavati@chromium.org</owner> @@ -724,7 +741,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SearchEngineType" enum="OmniboxSearchEngineType" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -734,7 +751,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SearchPrefetch.PrefetchEligibilityReason" - enum="SearchPrefetchEligibilityReason" expires_after="2022-01-02"> + enum="SearchPrefetchEligibilityReason" expires_after="2022-04-03"> <owner>ryansturm@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -746,7 +763,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SearchPrefetch.PrefetchFinalStatus" - enum="SearchPrefetchFinalStatus" expires_after="2022-01-02"> + enum="SearchPrefetchFinalStatus" expires_after="2022-04-03"> <owner>ryansturm@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -756,7 +773,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SearchPrefetch.PrefetchServingReason" - enum="SearchPrefetchServingReason" expires_after="2022-01-02"> + enum="SearchPrefetchServingReason" expires_after="2022-04-03"> <owner>ryansturm@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -766,7 +783,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SearchProviderMatches" units="units" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -778,7 +795,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SelectedPosition" units="position" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -828,7 +845,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestionUsed.AnswerInSuggest" - enum="SuggestionAnswerOptionalType" expires_after="2022-01-02"> + enum="SuggestionAnswerOptionalType" expires_after="2022-04-17"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -841,7 +858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestionUsed.OfferedTabMatch" enum="BooleanOffered" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>gangwu@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -864,7 +881,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestionUsed.Pedal" enum="SuggestionPedalType" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>orinj@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -880,9 +897,31 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Omnibox.SuggestionUsed.ResumeJourney" units="position" + expires_after="2022-08-24"> + <owner>tommycli@chromium.org</owner> + <owner>chrome-omnibox-team@google.com</owner> + <summary> + Logs the position of "Resume Journey" omnibox actions actually + selected by the user. The position index is 0-based, so a selected action in + the topmost match is logged as value 0, consistent with + Omnibox.SelectedPosition. + + This can be combined with Omnibox.ResumeJourneyShown to compute the Usage + (or CTR) of the "Resume Journey" omnibox action on a per-position + basis. + + It's safe to compare the total count of this metric to the total count of + Omnibox.ResumeJourneyShown because within a single popup, only zero or one + "Resume Journey" can be shown. If multiple actions start being + shown in the popup, comparing to the total count becomes misleading to + interpret as a CTR. + </summary> +</histogram> + <histogram name="Omnibox.SuggestionUsed.Search.Experimental.NavigationToFirstMeaningfulPaint" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-04-03"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -894,7 +933,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Omnibox.SuggestionUsed.Search.NavigationToFirstContentfulPaint" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-03-06"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -905,7 +944,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestionUsed.SelectedTabMatch" - enum="BooleanSelected" expires_after="2022-01-23"> + enum="BooleanSelected" expires_after="2022-04-03"> <owner>gangwu@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> @@ -935,7 +974,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Omnibox.SuggestionUsed.URL.Experimental.NavigationToFirstMeaningfulPaint" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-04-24"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -946,7 +985,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestionUsed.URL.NavigationToFirstContentfulPaint" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-04-10"> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -957,7 +996,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestRequest.Failure.GoogleResponseTime" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>cch@chromium.org</owner> @@ -969,7 +1008,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestRequest.Success.GoogleResponseTime" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>cch@chromium.org</owner> @@ -981,7 +1020,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestRequest.Success.PrefetchImagesCount" - units="count" expires_after="2022-01-02"> + units="count" expires_after="2022-05-01"> <owner>manukh@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> @@ -992,7 +1031,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.SuggestRequests" enum="OmniboxSuggestRequests" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>cch@chromium.org</owner> @@ -1003,7 +1042,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.TabMatchTime" units="microseconds" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>gangwu@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <owner>mpearson@chromium.org</owner> @@ -1034,7 +1073,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.TimeSpentBeforeDismissLens" units="ms" - expires_after="M97"> + expires_after="2022-04-24"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <owner>fgorski@chromium.org</owner> @@ -1048,7 +1087,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ToggleSuggestionGroupId.Off" enum="SuggestionGroupId" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>mahmadi@google.com</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -1060,7 +1099,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ToggleSuggestionGroupId.On" enum="SuggestionGroupId" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>mahmadi@google.com</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> @@ -1131,7 +1170,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ZeroSuggest.Eligible.OnFocusV2" - enum="ZeroSuggestEligibleOnFocus" expires_after="2022-01-02"> + enum="ZeroSuggestEligibleOnFocus" expires_after="2022-04-17"> <owner>mpearson@chromium.org</owner> <owner>jdonnelly@chromium.org</owner> <summary> @@ -1191,7 +1230,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Omnibox.ZeroSuggestRequests" enum="OmniboxZeroSuggestRequests" - expires_after="2021-10-31"> + expires_after="2022-04-03"> <owner>ender@chromium.org</owner> <owner>tommycli@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> diff --git a/chromium/tools/metrics/histograms/metadata/oobe/histograms.xml b/chromium/tools/metrics/histograms/metadata/oobe/histograms.xml index 85a9e0970d8..03578c56a84 100644 --- a/chromium/tools/metrics/histograms/metadata/oobe/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/oobe/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="OOBE.ArcTermsOfServiceScreen.ReviewFollowingSetup" - enum="BooleanChecked" expires_after="2021-12-05"> + enum="BooleanChecked" expires_after="2022-05-01"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.BootToSignInCompleted" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>alemate@chromium.org</owner> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -80,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.EulaScreen.UserActions" enum="EulaScreenUserAction" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -102,7 +102,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.FingerprintSetupScreen.UserActions" - enum="FingerprintSetupScreenUserAction" expires_after="2021-10-10"> + enum="FingerprintSetupScreenUserAction" expires_after="2022-04-24"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -111,7 +111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="OOBE.GaiaLoginTime" units="ms" expires_after="2021-10-01"> +<histogram name="OOBE.GaiaLoginTime" units="ms" expires_after="2022-04-01"> <owner>dkuzmin@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -122,7 +122,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.GaiaPasswordChangedScreen.UserActions" - enum="GaiaPasswordChangedScreenUserAction" expires_after="2021-10-01"> + enum="GaiaPasswordChangedScreenUserAction" expires_after="2022-02-01"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -132,7 +132,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.GaiaScreen.LoginRequests" enum="GaiaLoginVariant" - expires_after="2021-11-20"> + expires_after="2022-04-24"> <owner>yunkez@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -143,7 +143,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.GaiaScreen.SuccessLoginRequests" enum="GaiaLoginVariant" - expires_after="2021-11-20"> + expires_after="2022-04-24"> <owner>yunkez@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -180,7 +180,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.MarketingOptInScreen.Event" - enum="MarketingOptInScreenEvent" expires_after="2021-12-05"> + enum="MarketingOptInScreenEvent" expires_after="2022-04-24"> <owner>rrsilva@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -230,7 +230,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.PinSetupScreen.UserActions" - enum="PinSetupScreenUserAction" expires_after="2022-02-06"> + enum="PinSetupScreenUserAction" expires_after="2022-04-10"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -264,7 +264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.RecommendApps.Fetcher.ResponseParseResult" - enum="RecommendAppsResponseParseResult" expires_after="2022-02-06"> + enum="RecommendAppsResponseParseResult" expires_after="2022-04-24"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <owner>chromesky-eng@google.com</owner> @@ -272,7 +272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.RecommendApps.Screen.Action" - enum="RecommendAppsScreenAction" expires_after="2022-02-06"> + enum="RecommendAppsScreenAction" expires_after="2022-04-17"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <owner>chromesky-eng@google.com</owner> @@ -280,7 +280,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.RecommendApps.Screen.SelectedAppCount" units="apps" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <owner>chromesky-eng@google.com</owner> @@ -296,7 +296,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.RecommendApps.Screen.State" - enum="RecommendAppsScreenState" expires_after="2022-02-06"> + enum="RecommendAppsScreenState" expires_after="2022-04-17"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <owner>chromesky-eng@google.com</owner> @@ -314,7 +314,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.StepCompletionTimeByExitReason" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary>Time spent on specific OOBE screen grouped by exit reason.</summary> @@ -332,8 +332,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.SyncConsentScreen.Behavior" enum="SyncConsentBehavior" - expires_after="2021-12-12"> - <owner>jamescook@chromium.org</owner> + expires_after="2022-04-24"> + <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> Whether the sync consent screen was shown, skipped with sync disabled, or @@ -344,7 +344,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.SyncConsentScreen.IsCapabilityKnown" enum="BooleanKnown" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>yunkez@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -354,7 +354,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.SyncConsentScreen.IsMinorUser" enum="Boolean" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>yunkez@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -365,7 +365,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.SyncConsentScreen.LoadingTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>yunkez@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -375,7 +375,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.SyncConsentScreen.ReviewFollowingSetup" - enum="BooleanChecked" expires_after="2022-02-01"> + enum="BooleanChecked" expires_after="2022-04-24"> <owner>raleksandrov@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -385,8 +385,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.SyncConsentScreen.SyncEnabled" enum="BooleanEnabled" - expires_after="2021-12-12"> - <owner>jamescook@chromium.org</owner> + expires_after="2022-04-24"> + <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> Final state of the sync service at the end of the sync consent OOBE step. @@ -396,8 +396,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.SyncConsentScreen.UserChoice" - enum="SyncConsentUserChoice" expires_after="2021-10-10"> - <owner>jamescook@chromium.org</owner> + enum="SyncConsentUserChoice" expires_after="2022-04-10"> + <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> Which button the user clicked on the out-of-box sync consent screen. @@ -406,7 +406,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.UpdateScreen.StageTime.Check" units="ms" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>dkuzmin@google.com</owner> <owner>cros-oac@google.com</owner> <summary> @@ -457,7 +457,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.WebUI.LoadTime.FirstRun" units="ms" - expires_after="2022-01-01"> + expires_after="2022-04-17"> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> @@ -476,7 +476,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OOBE.WelcomeScreen.A11yUserActions" - enum="WelcomeScreenA11yUserAction" expires_after="2022-02-01"> + enum="WelcomeScreenA11yUserAction" expires_after="2022-04-24"> <owner>dkuzmin@google.com</owner> <owner>cros-oac@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/optimization/histograms.xml b/chromium/tools/metrics/histograms/metadata/optimization/histograms.xml index 7e980b9dea5..aa209a79fd8 100644 --- a/chromium/tools/metrics/histograms/metadata/optimization/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/optimization/histograms.xml @@ -43,7 +43,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="OptimizationGuide.ApplyDecisionAsync" - enum="OptimizationGuideOptimizationTypeDecision" expires_after="2022-01-02"> + enum="OptimizationGuideOptimizationTypeDecision" expires_after="2022-04-17"> <owner>sophiechang@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -116,7 +116,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OptimizationGuide.HintsFetcher.GetHintsRequest.FetchLatency" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-04-17"> <owner>sophiechang@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -147,7 +147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OptimizationGuide.HintsFetcher.GetHintsRequest.NetErrorCode" - enum="NetErrorCodes" expires_after="2022-01-02"> + enum="NetErrorCodes" expires_after="2022-03-06"> <owner>mcrouse@chromium.org</owner> <owner>sophiechang@chromium.org</owner> <summary> @@ -157,7 +157,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OptimizationGuide.HintsFetcher.GetHintsRequest.Status" - enum="HttpResponseCode" expires_after="2022-01-02"> + enum="HttpResponseCode" expires_after="2022-03-06"> <owner>mcrouse@chromium.org</owner> <owner>sophiechang@chromium.org</owner> <summary> @@ -293,7 +293,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="OptimizationGuide.HintsManager.RaceNavigationFetchAttemptStatus" enum="OptimizationGuideRaceNavigationFetchAttemptStatus" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>mcrouse@chromium.org</owner> <owner>sophiechang@chromium.org</owner> <summary> @@ -498,6 +498,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="OptimizationGuide.PageContentAnnotationsService.PageEntitiesExecutionLatency" + units="ms" expires_after="M106"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-intelligence-core@google.com</owner> + <summary> + Records the execution latency for the PageEntities model from when the model + manager requests the execution to completion and only if a result is + returned. Recorded once per model execution attempt. + </summary> +</histogram> + +<histogram name="OptimizationGuide.PageContentAnnotationsService.RelatedSearchesExtracted" enum="BooleanAnnotated" expires_after="M106"> <owner>mahmadi@chromium.org</owner> @@ -623,6 +635,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="OptimizationGuide.PredictionManager.IsDownloadUrlValid" units="BooleanValid" expires_after="M106"> + <obsolete> + Replaced by + OptimizationGuide.PredictionManager.IsDownloadUrlValid.{OptimizationTarget} + in M96. + </obsolete> <owner>sophiechang@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -631,6 +648,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="OptimizationGuide.PredictionManager.IsDownloadUrlValid.{OptimizationTarget}" + units="BooleanValid" expires_after="M106"> + <owner>sophiechang@chromium.org</owner> + <owner>mcrouse@chromium.org</owner> + <summary> + Records whether the download URL for {OptimizationTarget} received from the + remote Optimization Guide server is valid. + </summary> + <token key="OptimizationTarget" variants="OptimizationTarget"/> +</histogram> + <histogram base="true" name="OptimizationGuide.PredictionManager.ModelTypeChanged" units="BooleanChanged" expires_after="M106"> @@ -668,6 +697,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="OptimizationGuide.PredictionModelDownloadManager.ReplaceFileError" enum="PlatformFileError" expires_after="M106"> + <obsolete> + Replaced by + OptimizationGuide.PredictionModelDownloadManager.ReplaceFileError.{OptimizationTarget} + in M96. + </obsolete> <owner>mcrouse@chromium.org</owner> <owner>sophiechang@chromium.org</owner> <summary> @@ -678,6 +712,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="OptimizationGuide.PredictionModelDownloadManager.ReplaceFileError.{OptimizationTarget}" + enum="PlatformFileError" expires_after="M106"> + <owner>mcrouse@chromium.org</owner> + <owner>sophiechang@chromium.org</owner> + <summary> + Records the exact error whenever writing a model file fails at the step + where the model is moved from the scratch directory to its final location. + Recorded every time a {OptimizationTarget} model file is downloaded and + being processed for storage. + </summary> + <token key="OptimizationTarget" variants="OptimizationTarget"/> +</histogram> + <histogram base="true" name="OptimizationGuide.PredictionModelEvaluationLatency" units="ms" expires_after="M106"> @@ -692,7 +740,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OptimizationGuide.PredictionModelExpired" - units="BooleanExpired" expires_after="M106"> + units="BooleanExpired" expires_after="M96"> + <obsolete> + Deprecated in favor of OptimizationTarget variant as of 09/2021. + </obsolete> <owner>sophiechang@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -702,6 +753,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="OptimizationGuide.PredictionModelExpired.{OptimizationTarget}" + enum="BooleanExpired" expires_after="M106"> + <owner>sophiechang@chromium.org</owner> + <owner>chrome-intelligence-core@google.com</owner> + <summary> + Records whether a prediction model for an OptimizationTarget expired if it + was not updated or used within the configured expiration time, but can + change subject to Finch or server configuration. Recorded once per browser + startup. + </summary> + <token key="OptimizationTarget" variants="OptimizationTarget"/> +</histogram> + <histogram name="OptimizationGuide.PredictionModelFetcher.GetModelsRequest.HostCount" units="total host count" expires_after="M94"> @@ -798,7 +862,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OptimizationGuide.ProcessHintsResult" - enum="OptimizationGuideProcessHintsResult" expires_after="2022-01-02"> + enum="OptimizationGuideProcessHintsResult" expires_after="2022-04-10"> <owner>mcrouse@chromium.org</owner> <owner>sophiechang@chromium.org</owner> <summary> @@ -880,7 +944,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OptimizationGuide.RemoteFetchingEnabled" - units="BooleanEnabled" expires_after="2022-01-02"> + units="BooleanEnabled" expires_after="2022-04-03"> <owner>sophiechang@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -916,6 +980,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="OptimizationGuide.ValidateMetadataFetch.Result" enum="Boolean" + expires_after="M106"> + <owner>robertogden@chromium.org</owner> + <owner>chrome-intelligence-core@google.com</owner> + <summary> + Records whether the metadata fetch validation received the hints correctly. + Recorded on iOS when the mainframe navigation commits. + </summary> +</histogram> + </histograms> </histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/others/OWNERS b/chromium/tools/metrics/histograms/metadata/others/OWNERS index c07feef5d2c..654f4507e9b 100644 --- a/chromium/tools/metrics/histograms/metadata/others/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/others/OWNERS @@ -4,8 +4,6 @@ # can read more about chromium-metrics-reviews@google.com at go/gwsq-gerrit. per-file histograms.xml=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS -# For the Discarding.* and PerformanceMonitor.* histograms: -sebmarchand@chromium.org # For display, mouse, and input related histograms. zentaro@chromium.org # For the TrustedWebActivity.* histograms: diff --git a/chromium/tools/metrics/histograms/metadata/others/histograms.xml b/chromium/tools/metrics/histograms/metadata/others/histograms.xml index 84905b01c4d..98e3c18c7f5 100644 --- a/chromium/tools/metrics/histograms/metadata/others/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/others/histograms.xml @@ -81,7 +81,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="AccountManager.AccountAdditionResultStatus" - enum="AccountManagerAccountAdditionResultStatus" expires_after="2022-02-01"> + enum="AccountManagerAccountAdditionResultStatus" expires_after="2022-04-24"> <owner>sinhak@chromium.org</owner> <owner>anastasiian@chromium.org</owner> <summary> @@ -93,7 +93,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.AccountAdditionSource" - enum="AccountManagerAccountAdditionSource" expires_after="2022-02-06"> + enum="AccountManagerAccountAdditionSource" expires_after="2022-04-24"> <owner>sinhak@chromium.org</owner> <owner>anastasiian@chromium.org</owner> <summary> @@ -120,7 +120,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.EduCoexistence.FetchAccessTokenResult" - enum="GoogleServiceAuthError" expires_after="2022-02-06"> + enum="GoogleServiceAuthError" expires_after="2022-04-10"> <owner>sinhak@chromium.org</owner> <owner>anastasiian@chromium.org</owner> <summary> @@ -159,7 +159,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.EduCoexistenceV2.InSessionFlowResult" - enum="EduCoexistenceFlowV2Result" expires_after="2022-01-02"> + enum="EduCoexistenceFlowV2Result" expires_after="2022-04-03"> <owner>agawronska@chromium.org</owner> <owner>danan@chromium.org</owner> <owner>yilkal@chromium.org</owner> @@ -171,7 +171,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.EduCoexistenceV2.OnboardingFlowResult" - enum="EduCoexistenceFlowV2Result" expires_after="2022-01-02"> + enum="EduCoexistenceFlowV2Result" expires_after="2022-04-03"> <owner>agawronska@chromium.org</owner> <owner>danan@chromium.org</owner> <owner>yilkal@chromium.org</owner> @@ -183,7 +183,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.InitializationTime" units="microseconds" - expires_after="2021-08-09"> + expires_after="2022-05-01"> <owner>sinhak@chromium.org</owner> <owner>anastasiian@chromium.org</owner> <summary> @@ -193,7 +193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.ManageAccountsServiceType" - enum="GaiaServiceType" expires_after="2022-01-24"> + enum="GaiaServiceType" expires_after="2022-05-01"> <owner>sinhak@chromium.org</owner> <owner>anastasiian@chromium.org</owner> <summary> @@ -203,6 +203,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="AccountManager.Migrations.Result" enum="BooleanSuccess" expires_after="2021-08-09"> + <obsolete> + Removed in M95. All users have migrated to the new Account Manager. Not + needed anymore. + </obsolete> <owner>sinhak@chromium.org</owner> <summary> Tracks the final result of migrating accounts to Chrome OS Account Manager. @@ -212,6 +216,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="AccountManager.Migrations.StepResult" enum="BooleanSuccess" expires_after="2021-01-24"> + <obsolete> + Removed in M95. All users have migrated to the new Account Manager. Not + needed anymore. + </obsolete> <!-- Name completed by histogram_suffixes name="AccountManagerMigrationSteps" --> @@ -225,6 +233,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="AccountManager.MirrorReauthenticationRequest" enum="BooleanHit" expires_after="2021-08-09"> + <obsolete> + Removed in M95. https://crbug.com/1012649 was fixed. Not needed anymore. + </obsolete> <owner>sinhak@chromium.org</owner> <owner>anastasiian@chromium.org</owner> <summary> @@ -235,8 +246,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.NumAccounts" units="count" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>sinhak@chromium.org</owner> + <owner>anastasiian@chromium.org</owner> <summary> Tracks the number of accounts stored in Chrome OS Account Manager by a given user. This is recorded only once per session, at login time. @@ -244,7 +256,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AccountManager.TokenLoadStatus" - enum="AccountManagerTokenLoadStatus" expires_after="2021-12-12"> + enum="AccountManagerTokenLoadStatus" expires_after="2022-02-06"> <owner>sinhak@chromium.org</owner> <owner>anastasiian@chromium.org</owner> <summary> @@ -344,7 +356,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AddSupervisionDialog.Enrollment" - enum="AddSupervisionEnrollment" expires_after="2022-01-09"> + enum="AddSupervisionEnrollment" expires_after="2022-04-24"> <owner>tobyhuang@chromium.org</owner> <owner>michaelpg@chromium.org</owner> <owner>danan@chromium.org</owner> @@ -362,30 +374,32 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AddSupervisionDialog.EnrollmentCompletedUserTime" units="ms" - expires_after="2021-09-08"> + expires_after="2022-08-23"> <owner>tobyhuang@chromium.org</owner> <owner>michaelpg@chromium.org</owner> <owner>danan@chromium.org</owner> <summary> Measures the amount of time in milliseconds for users to successfully enroll - in supervision. + in supervision. Elapsed time is measured starting from when the Add + Supervision dialog was first opened. </summary> </histogram> <histogram name="AddSupervisionDialog.EnrollmentNotCompletedUserTime" - units="ms" expires_after="2021-09-08"> + units="ms" expires_after="2022-08-23"> <owner>tobyhuang@chromium.org</owner> <owner>michaelpg@chromium.org</owner> <owner>danan@chromium.org</owner> <summary> Measures the amount of time in milliseconds for users to exit the Add Supervision dialog without enrollment. This can happen if the user closes - the Add Supervision dialog or signs out to switch accounts. + the Add Supervision dialog or signs out to switch accounts. Elapsed time is + measured starting from when the Add Supervision dialog was first opened. </summary> </histogram> <histogram name="AddSupervisionDialog.SignoutCompletedUserTime" units="ms" - expires_after="2021-09-08"> + expires_after="2022-08-23"> <owner>tobyhuang@chromium.org</owner> <owner>michaelpg@chromium.org</owner> <owner>danan@chromium.org</owner> @@ -484,7 +498,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Ads.Media.Duration" units="ms" expires_after="2022-02-06"> +<histogram name="Ads.Media.Duration" units="ms" expires_after="2022-04-24"> <owner>johnidel@chromium.org</owner> <owner>dalecurtis@chromium.org</owner> <summary> @@ -598,7 +612,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AnimatedImage.NumOfFramesSkipped" units="count" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>khushalsagar@chromium.org</owner> <summary> If the frame rate for the image animation can not be reached, frames in the @@ -670,6 +684,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="API.StorageAccess.AllowedRequests" enum="StorageAccessResult" expires_after="2020-11-27"> + <obsolete> + Removed 2021/09. + </obsolete> + <owner>mkwst@chromium.org</owner> + <owner>brandm@microsoft.com</owner> + <summary> + Records if various requests to access storage are allowed or not and if the + Storage Access API unblocked the request or not. Recorded whenever a + decision to access storage like getting/setting cookies or opening an + indexeddb connection is made in CookieSettings. + + This histogram erroneously recorded ALLOW when cookies were globally + blocked. + </summary> +</histogram> + +<histogram name="API.StorageAccess.AllowedRequests2" enum="StorageAccessResult" + expires_after="2022-03-27"> <owner>mkwst@chromium.org</owner> <owner>brandm@microsoft.com</owner> <summary> @@ -728,7 +760,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AppBanners.DisplayEvent" enum="AppBannersDisplayEvent" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>pjmclachlan@google.com</owner> <owner>pcovell@google.com</owner> <summary> @@ -740,7 +772,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AppBanners.InstallableStatusCode" - enum="AppBannersInstallableStatusCode" expires_after="2021-12-12"> + enum="AppBannersInstallableStatusCode" expires_after="2022-05-01"> <owner>dominickn@chromium.org</owner> <owner>pjmclachlan@google.com</owner> <summary> @@ -753,7 +785,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AppBanners.InstallEvent" enum="AppBannersInstallEvent" - expires_after="2022-01-16"> + expires_after="2022-05-01"> <owner>pjmclachlan@google.com</owner> <owner>pcovell@google.com</owner> <summary> @@ -789,6 +821,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.Manifest.ChromeHeader" enum="BooleanPresent" expires_after="M82"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>pwnall@chromium.org</owner> <owner>mek@chromium.org</owner> <summary> @@ -799,6 +834,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.Manifest.DangerousMode" enum="BooleanPresent" expires_after="M82"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>pwnall@chromium.org</owner> <owner>mek@chromium.org</owner> <summary> @@ -809,6 +847,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.Manifest.InterceptUsage" enum="AppCacheManifestInterceptUsage" expires_after="M82"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>pwnall@chromium.org</owner> <owner>mek@chromium.org</owner> <summary> @@ -818,6 +859,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="appcache.ReinitAttempt" units="units" expires_after="M85"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>mek@chromium.org</owner> <summary> Tracks the number of times the appcache reinit process occurs. The boolean @@ -828,6 +872,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.Canceled" enum="BooleanCanceled" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary>Tracks whether the update job was canceled.</summary> @@ -835,6 +882,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ExistingCorruptionFixedInUpdate" units="resources" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -848,6 +898,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ExistingResourceCheck" units="units" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -858,6 +911,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ExistingResourceCorrupt" units="units" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -871,6 +927,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ExistingResourceCorruptionRecovery" units="units" expires_after="2022-01-30"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -889,6 +948,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ExistingResourceNotCorrupt" units="resources" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -901,7 +963,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="appcache.UpdateJob.ExistingResourceOnlyCorrupt" - units="resources" expires_after="2021-12-12"> + units="resources" expires_after="2022-02-13"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>enne@chromium.org</owner> <summary> @@ -917,6 +982,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ExistingResourceOnlyNotCorrupt" units="resources" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>enne@chromium.org</owner> <summary> @@ -932,6 +1000,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ExistingResourceReused" units="units" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -942,6 +1013,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.FinalInternalState" enum="AppCacheUpdateJobInternalState" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary>Tracks the final internal state for the update job.</summary> @@ -949,6 +1023,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="appcache.UpdateJob.ResourceFreshness" units="days" expires_after="2021-10-05"> + <obsolete> + Removed in M96. Appcache was disabled in M95. + </obsolete> <owner>cmp@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -968,7 +1045,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AppManagement.AppDetailViews" enum="AppManagementUserAction" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="AppType" --> <owner>jshikaram@chromium.org</owner> @@ -980,7 +1057,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AppManagement.EntryPoints" enum="AppManagementEntryPoint" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>jshikaram@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary>The ways the user opens up the App Management interface.</summary> @@ -1187,7 +1264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Autocomplete.Events" enum="AutocompleteEvents" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>seblalancette@chromium.org</owner> <summary> Autocomplete events recorded when the user interacts with suggestions served @@ -1253,7 +1330,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AutocompleteActionPredictor.DatabaseAction" - enum="AutocompleteActionPredictorDatabaseAction" expires_after="2022-01-02"> + enum="AutocompleteActionPredictorDatabaseAction" expires_after="2022-05-01"> <owner>tbansal@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <owner>jdonnelly@chromium.org</owner> @@ -1273,7 +1350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="AutocompleteActionPredictor.MatchIsInDb" units="units" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>tbansal@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <owner>jdonnelly@chromium.org</owner> @@ -1438,6 +1515,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="BatteryStatus.StartAndroid" enum="BooleanSuccess" expires_after="M92"> + <obsolete> + Removed 2021-09-02 due to being unused in the codebase. + </obsolete> <owner>timvolodine@chromium.org</owner> <owner>src/services/device/battery/OWNERS</owner> <summary> @@ -1470,7 +1550,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>Records whenever a Blimp tab toggles visibility.</summary> </histogram> -<histogram name="BlueZ.AdapterLost" units="seconds" expires_after="2021-12-31"> +<histogram name="BlueZ.AdapterLost" units="seconds" expires_after="2022-04-17"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records a duration of a Bluetooth adapter @@ -1480,7 +1560,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.AdvertisementMonitor.NumOfMonitors" units="count" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>apusaka@chromium.org</owner> <owner>chromeos-bt-platform-sw-core@google.com</owner> <summary> @@ -1526,7 +1606,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> -<histogram name="BlueZ.ChipLost2" units="seconds" expires_after="2021-12-31"> +<histogram name="BlueZ.ChipLost2" units="seconds" expires_after="2022-04-10"> <owner>sonnysasaka@chromium.org</owner> <summary> This is specific to Chrome OS. Records a duration of a Bluetooth adapter @@ -1536,7 +1616,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.NumberOfExistingAdvertisements" units="advertisements" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the number of existing advertisements @@ -1573,7 +1653,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.ReasonOfDisconnection" enum="BlueZReasonOfDisconnection" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the reason of Bluetooth disconnection @@ -1593,7 +1673,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.ResultOfConnection" enum="BlueZResultOfConnection" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the outcomes of connection requests @@ -1603,7 +1683,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.ResultOfPairing" enum="BlueZResultOfPairing" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the outcomes of pairing with remote @@ -1624,7 +1704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.TimeLengthOfDiscoverable" units="seconds" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the duration when the local device is @@ -1635,7 +1715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.TimeLengthOfDiscovering" units="seconds" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the duration for the local device to @@ -1646,7 +1726,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.TimeLengthOfPairing" units="seconds" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the duration taken to finish a @@ -1656,7 +1736,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.TimeLengthOfSetupConnection" units="seconds" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the duration taken to finish a @@ -1667,7 +1747,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BlueZ.TypeOfDiscovery" enum="BlueZTypeOfDiscovery" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>mcchou@chromium.org</owner> <summary> This is specific to Chrome OS. Records the types of device discovery @@ -1724,7 +1804,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="BookmarkManager.ResultsRenderedTime" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>calamity@chromium.org</owner> <owner>dbeam@chromium.org</owner> <summary> @@ -1735,7 +1815,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.AddedPerProfileType" enum="BrowserProfileType" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <component>UI>Browser>Bookmarks</component> @@ -1748,7 +1828,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.BookmarkAllTabsWithTabsCount.Incognito" units="tabs" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <component>UI>Browser>Bookmarks</component> @@ -1770,7 +1850,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.BookmarksBarStatus.OnReadingListOpened" - enum="BookmarkBarPrefAndState" expires_after="2021-12-19"> + enum="BookmarkBarPrefAndState" expires_after="2022-04-24"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <component>UI>Browser>Bookmarks</component> @@ -1804,7 +1884,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.Count.OnProfileLoad" units="bookmarks" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>supertri@chromium.org</owner> <owner>isherman@chromium.org</owner> <owner>aidanday@google.com</owner> @@ -1936,14 +2016,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.EntryPoint" enum="BookmarksEntryPoint" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>ianwen@chromium.org</owner> <component>UI>Browser>Bookmarks</component> <summary>How users add a new bookmark.</summary> </histogram> <histogram name="Bookmarks.LaunchLocation" enum="BookmarkLaunchLocation" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>ianwen@chromium.org</owner> <component>UI>Browser>Bookmarks</component> <summary>Logs a UI location from which a bookmark is launched.</summary> @@ -1964,7 +2044,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.OpenBookmarkManager.PerProfileType" - enum="BrowserProfileType" expires_after="2022-03-01"> + enum="BrowserProfileType" expires_after="2022-05-01"> <owner>roagarwal@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <component>UI>Browser>Bookmarks</component> @@ -2014,7 +2094,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.OpenBookmarkType" enum="BookmarkType" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>wychen@chromium.org</owner> <component>UI>Browser>Bookmarks</component> <summary> @@ -2024,7 +2104,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.ReadingList.NumberOfItems" units="items" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>shaktisahu@chromium.org</owner> <owner>xingliu@chromium.org</owner> <component>UI>Browser>Bookmarks</component> @@ -2036,7 +2116,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.ReadingList.NumberOfReadItems" units="items" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>shaktisahu@chromium.org</owner> <owner>xingliu@chromium.org</owner> <component>UI>Browser>Bookmarks</component> @@ -2048,7 +2128,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.ReadingList.NumberOfUnreadItems" units="items" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>shaktisahu@chromium.org</owner> <owner>xingliu@chromium.org</owner> <component>UI>Browser>Bookmarks</component> @@ -2060,7 +2140,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.StarEntryPoint.ClickedAction" - enum="StarEntryPointAction" expires_after="2021-12-12"> + enum="StarEntryPointAction" expires_after="2022-04-24"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <component>UI>Browser>Bookmarks</component> @@ -2070,7 +2150,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Bookmarks.UsageCountPerProfileType" enum="BrowserProfileType" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <component>UI>Browser>Bookmarks</component> @@ -2080,14 +2160,25 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="BootTime.Total2" units="ms" expires_after="2022-01-02"> +<histogram name="BootTime.Login2" units="ms" expires_after="2022-04-03"> + <owner>rsorokin@chromium.org</owner> + <owner>antrim@chromium.org</owner> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@chromium.org</owner> + <summary> + Time from the moment sign in authentication is started until the first user + session UI elements become ready to use. (Chrome OS). + </summary> +</histogram> + +<histogram name="BootTime.Total2" units="ms" expires_after="2022-04-03"> <owner>bccheng@chromium.org</owner> <owner>semenzato@chromium.org</owner> <summary>Time from power on to login panel ready (Chrome OS).</summary> </histogram> <histogram name="BrotliFilter.CompressionPercent" units="%" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>eustas@chromium.org</owner> <summary>Compressed/Decompressed size ratio.</summary> </histogram> @@ -2130,7 +2221,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Canvas.TextMetrics.SetFont2" units="microseconds" - expires_after="2022-01-31"> + expires_after="M93"> + <obsolete> + Retired in M94. + </obsolete> <owner>yiyix@chromium.org</owner> <owner>fserb@chromium.org</owner> <summary> @@ -2412,7 +2506,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Cast.Sender.RemotePlayback.InitiationLocation" - enum="RemotePlaybackInitiationLocation" expires_after="2022-01-05"> + enum="RemotePlaybackInitiationLocation" expires_after="2022-04-17"> <owner>muyaoxu@google.com</owner> <owner>openscreen-eng@google.com</owner> <summary> @@ -2548,7 +2642,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChildProcess.Crashed.UtilityProcessHash" - enum="UtilityProcessNameHash" expires_after="2021-12-19"> + enum="UtilityProcessNameHash" expires_after="2022-04-10"> <owner>wfh@chromium.org</owner> <owner>chrome-stability-core@google.com</owner> <summary> @@ -2652,7 +2746,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChildProcess.Launched.UtilityProcessHash" - enum="UtilityProcessNameHash" expires_after="2021-12-12"> + enum="UtilityProcessNameHash" expires_after="2022-04-10"> <owner>wfh@chromium.org</owner> <summary> Count of child utility process launches, bucketed by the hash of their @@ -2662,7 +2756,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromiumAndroidLinker.BrowserLoadTime" units="ms" - expires_after="M99"> + expires_after="2022-10-01"> <obsolete> Replaced by ChromiumAndroidLinker.BrowserLoadTime2 in 2021-07. </obsolete> @@ -2674,7 +2768,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromiumAndroidLinker.RelroAvailableImmediately" - enum="BooleanRelroAvailableImmediately" expires_after="2021-07-07"> + enum="BooleanRelroAvailableImmediately" expires_after="2022-10-01"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary> @@ -2685,7 +2779,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromiumAndroidLinker.RelroProvidedSuccessfully" - enum="BooleanSuccess" expires_after="2021-07-07"> + enum="BooleanSuccess" expires_after="2022-10-01"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary> @@ -2701,7 +2795,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromiumAndroidLinker.RelroSharingStatus" - enum="RelroSharingStatus" expires_after="2021-05-06"> + enum="RelroSharingStatus" expires_after="2022-10-01"> <owner>lizeb@chromium.org</owner> <owner>pasko@chromium.org</owner> <summary> @@ -2712,7 +2806,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromiumAndroidLinker.RendererLoadTime" units="ms" - expires_after="M99"> + expires_after="2022-10-01"> <obsolete> Replaced by ChromiumAndroidLinker.ChildLoadTime2 in 2021-07. </obsolete> @@ -2724,7 +2818,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ChromiumAndroidLinker.{ProcessType}LoadTime2" units="ms" - expires_after="2022-07-20"> + expires_after="2022-10-01"> <owner>pasko@chromium.org</owner> <owner>rsesek@chromium.org</owner> <summary> @@ -2983,7 +3077,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Clipboard.Read" enum="ClipboardFormatRead" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>huangdarwin@chromium.org</owner> <owner>src/ui/base/clipboard/OWNERS</owner> <summary> @@ -3011,7 +3105,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Clipboard.Write" enum="ClipboardFormatWrite" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>huangdarwin@chromium.org</owner> <owner>src/ui/base/clipboard/OWNERS</owner> <summary> @@ -3095,7 +3189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="CompositorLatency" units="microseconds" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -3113,7 +3207,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="CompositorLatency.CompositorOnlyFrame" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-17"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -3144,7 +3238,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="CompositorLatency.DroppedFrame" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-24"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -3163,7 +3257,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="CompositorLatency.MissedDeadlineFrame" - units="microseconds" expires_after="2022-01-23"> + units="microseconds" expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -3181,7 +3275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="CompositorLatency.Type" enum="FrameReportType" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -3191,10 +3285,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.External.Modeset.AttemptSucceeded" - enum="BooleanSuccess" expires_after="2021-09-19"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + enum="BooleanSuccess" expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Modeset attempt result of an external display. Every time an external display is connected/disconnected, or when the display mode of the external @@ -3205,10 +3299,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.External.Modeset.FinalStatus" - enum="BooleanSuccess" expires_after="2021-09-19"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + enum="BooleanSuccess" expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Modeset attempt result of an internal display. This is recorded after Chrome attempted all the available modes and finally modeset the display. All the @@ -3218,10 +3312,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.External.Modeset.RefreshRate" units="Hz" - expires_after="2021-10-25"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Refresh rate of the mode for the display we're about to modeset. This is recorded every time an external display is connected/disconnected, or when @@ -3230,10 +3324,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.External.Modeset.Resolution" - enum="DisplayResolution" expires_after="2021-10-30"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + enum="DisplayResolution" expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> DisplayResolution of the mode for the external display we're about to modeset. 0 means the display was powered off. This is recorded every time an @@ -3243,10 +3337,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.Internal.Modeset.AttemptSucceeded" - enum="BooleanSuccess" expires_after="2021-10-04"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + enum="BooleanSuccess" expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Modeset attempt result of an internal display. Chrome might try additional modes after a failed attempt. Every time an external display is @@ -3258,10 +3352,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.Internal.Modeset.FinalStatus" - enum="BooleanSuccess" expires_after="2021-10-04"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + enum="BooleanSuccess" expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Modeset attempt result of an internal display. This is recorded after Chrome attempted all the available modes and finally modeset the display. All the @@ -3271,10 +3365,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.Internal.Modeset.RefreshRate" units="Hz" - expires_after="2021-10-04"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Refresh rate of the mode for the display we're about to modeset. This is recorded every time the internal display is powered on/off, or when an @@ -3283,10 +3377,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.Internal.Modeset.Resolution" - enum="DisplayResolution" expires_after="2022-01-23"> - <owner>dcastagna@chromium.org</owner> - <owner>marcheu@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + enum="DisplayResolution" expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> DisplayResolution of the mode for the internal display we're about to modeset. 0 means the display was powered off. This is recorded every time @@ -3296,10 +3390,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.Modeset.MstExternalDisplaysCount" - units="count" expires_after="2022-01-23"> + units="count" expires_after="2022-09-01"> <owner>gildekel@chromium.org</owner> - <owner>dcastagna@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Total number of external displays connected via MST and being configured. This is recorded every time an external display is connected/disconnected, @@ -3308,10 +3402,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.Modeset.MstExternalDisplaysPercentage" - units="%" expires_after="2022-01-23"> + units="%" expires_after="2022-09-01"> <owner>gildekel@chromium.org</owner> - <owner>dcastagna@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Percentage of external displays connected via MST and being configured. This is recorded every time an external display is connected/disconnected, or @@ -3320,10 +3414,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ConfigureDisplays.Modeset.TotalExternalDisplaysCount" - units="count" expires_after="2022-01-23"> + units="count" expires_after="2022-09-01"> <owner>gildekel@chromium.org</owner> - <owner>dcastagna@chromium.org</owner> - <owner>chromeos-gfx@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@chromium.org</owner> <summary> Total number of external displays being configured. This is recorded every time an external display is connected/disconnected, or when the display mode @@ -3421,7 +3515,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.CancelSystemTouches" enum="BooleanHit" - expires_after="2021-12-26"> + expires_after="2022-01-02"> <owner>michaeldo@chromium.org</owner> <owner>src/ios/web/OWNERS</owner> <summary> @@ -3444,7 +3538,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.DOMElementFrame" enum="ContextMenuDOMElementFrame" - expires_after="2021-10-04"> + expires_after="2022-01-02"> <owner>michaeldo@chromium.org</owner> <owner>src/ios/web/OWNERS</owner> <summary> @@ -3455,6 +3549,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ContextMenu.iOS.CopyImage" enum="ContextMenuIOSCopyImage" expires_after="2021-12-05"> + <obsolete> + Previously removed from code. + </obsolete> <owner>mrsuyi@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> @@ -3475,7 +3572,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.LensChip.Event" enum="LensChipEvent" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <summary> @@ -3485,7 +3582,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.LensSupportStatus" enum="LensSupportStatus" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>benwgold@google.com</owner> <owner>lens-chrome@google.com</owner> <summary> @@ -3541,7 +3638,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="ContextMenu.SelectedOptionDesktop" - enum="ContextMenuOptionDesktop" expires_after="2022-01-09"> + enum="ContextMenuOptionDesktop" expires_after="2022-04-03"> <owner>avi@chromium.org</owner> <owner>mpearson@chromium.org</owner> <summary> @@ -3573,7 +3670,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.Shown" enum="BooleanPresent" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>mpearson@chromium.org</owner> <owner>twellington@chromium.org</owner> <owner>clank-app-team@google.com</owner> @@ -3604,7 +3701,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.TimeToSelectShare" units="ms" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -3614,7 +3711,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.TimeToTakeAction.Abandoned" units="ms" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>twellington@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -3627,7 +3724,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.TimeToTakeAction.SelectedItem" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>twellington@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -3639,14 +3736,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ContextMenu.URLClicked" enum="BooleanClicked" - expires_after="2021-10-31"> + expires_after="2022-04-03"> <owner>twellington@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary>Logged when the URL is clicked. Android only.</summary> </histogram> <histogram name="ContextMenu.ViewsTextServices.Emoji" enum="Boolean" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>yyushkina@chromium.org</owner> <summary> Number of times the emoji item in the views text services context menu is @@ -3688,6 +3785,31 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Conversions.CreateReportStatus" + enum="ConversionStorageCreateReportStatus" expires_after="M98"> + <owner>apaseltiner@chromium.org</owner> + <owner>johnidel@chromium.org</owner> + <owner>measurement-api-dev+metrics@google.com</owner> + <summary> + Measures how often conversions are stored successfully or rejected and why. + Recorded once for each conversion event processed by the attribution storage + layer. + </summary> +</histogram> + +<histogram name="Conversions.DeleteSentReportOperation" + enum="ConversionPostSendReportDeleteEvent" expires_after="M98"> + <owner>apaseltiner@chromium.org</owner> + <owner>johnidel@chromium.org</owner> + <owner>measurement-api-dev+metrics@google.com</owner> + <summary> + Measures how often conversions are deleted after being sent. Recorded once + for each deletion started and each deletion completed. Deletion may fail if + the browser was shut down before the deletion completed, or if there was an + error during storage. + </summary> +</histogram> + <histogram name="Conversions.ExtraReportDelay" units="ms" expires_after="2021-12-19"> <obsolete> @@ -3774,7 +3896,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Conversions.RegisteredConversionsPerPage" units="conversions" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>johnidel@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -3787,7 +3909,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Conversions.RegisteredImpressionsPerPage" units="impressions" - expires_after="M95"> + expires_after="2022-04-03"> <owner>johnidel@chromium.org</owner> <owner>csharrison@chromium.org</owner> <owner>linnan@chromium.org</owner> @@ -3843,13 +3965,26 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Conversions.ReportSendOutcome" + enum="ConversionReportSendOutcome" expires_after="2021-12-19"> + <owner>linnan@chromium.org</owner> + <owner>johnidel@chromium.org</owner> + <owner>measurement-api-dev+metrics@google.com</owner> + <summary> + Records the high level request status of a conversion report. Recorded once + per conversion report. For conversion report that has been retried, only the + last retry will be counted. + </summary> +</histogram> + <histogram name="Conversions.ReportStatus" enum="ConversionReportStatus" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>johnidel@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> Records the high level request status of a conversion report. Recorded for - every conversion report sent. + every conversion report sent. For conversion report that has been retried, + every retry will be counted. </summary> </histogram> @@ -3911,7 +4046,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Conversions.TimeFromConversionToReportSend" units="hours" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>johnidel@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -3920,6 +4055,33 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Conversions.UniqueReportingOriginsPerPage.Conversions" + units="origins" expires_after="2022-01-09"> + <owner>linnan@chromium.org</owner> + <owner>johnidel@chromium.org</owner> + <owner>measurement-api-dev+metrics@google.com</owner> + <summary> + Records the number of unique reporting origins for registered conversions on + a given top-level page load. Recorded when the page navigates away or is + otherwise closed. Only recorded for non-off-the-record profiles (OTR + profiles have the feature disabled). + </summary> +</histogram> + +<histogram name="Conversions.UniqueReportingOriginsPerPage.Impressions" + units="origins" expires_after="2022-01-09"> + <owner>linnan@chromium.org</owner> + <owner>johnidel@chromium.org</owner> + <owner>measurement-api-dev+metrics@google.com</owner> + <summary> + Records the number of unique reporting origins for registered event + impressions and navigation impressions attempted on a given top-level page + load. Recorded when the page navigates away or is otherwise closed. Only + recorded for non-off-the-record profiles (OTR profiles have the feature + disabled). + </summary> +</histogram> + <histogram name="CopylessPaste.CacheHit" enum="CopylessCacheHit" expires_after="2020-03-01"> <owner>wychen@chromium.org</owner> @@ -4136,7 +4298,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataUse.AllServicesKB" enum="DataUseServicesHash" - expires_after="2021-12-20"> + expires_after="2022-04-24"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -4151,7 +4313,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DataUse.AppTabState" units="bytes" expires_after="2021-12-20"> +<histogram name="DataUse.AppTabState" units="bytes" expires_after="2022-02-20"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -4197,7 +4359,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataUse.BytesReceived2" units="bytes" - expires_after="2021-12-20"> + expires_after="2022-04-17"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -4206,7 +4368,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DataUse.BytesSent" units="bytes" expires_after="2021-12-20"> +<histogram name="DataUse.BytesSent" units="bytes" expires_after="2022-02-20"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -4216,7 +4378,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataUse.ContentType.UserTrafficKB" enum="DataUseContentType" - expires_after="2021-12-20"> + expires_after="2022-04-24"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -4257,7 +4419,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DataUse.TrafficSize.User" units="bytes" - expires_after="2021-12-20"> + expires_after="2022-04-24"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -4418,8 +4580,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DemoMode.ActiveApp" enum="DemoModeApp" - expires_after="2021-12-05"> +<histogram name="DemoMode.ActiveApp" enum="DemoModeApp" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4428,8 +4589,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DemoMode.AppLaunched" enum="DemoModeApp" - expires_after="2021-12-05"> +<histogram name="DemoMode.AppLaunched" enum="DemoModeApp" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4440,7 +4600,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.AppLaunchSource" enum="DemoModeAppLaunchSource" - expires_after="2021-08-09"> + expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4449,7 +4609,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DemoMode.DwellTime" units="seconds" expires_after="2021-12-05"> +<histogram name="DemoMode.DwellTime" units="seconds" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4461,7 +4621,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.IdleLogoutWarningEvent" - enum="DemoModeIdleLogoutWarningEvent" expires_after="2021-08-09"> + enum="DemoModeIdleLogoutWarningEvent" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4473,7 +4633,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.ResourcesRemoval.Reason" - enum="DemoModeResourcesRemovalReason" expires_after="M92"> + enum="DemoModeResourcesRemovalReason" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4485,7 +4645,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.ResourcesRemoval.Result" - enum="DemoModeResourcesRemovalResult" expires_after="M92"> + enum="DemoModeResourcesRemovalResult" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4499,8 +4659,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DemoMode.SessionLength" units="minutes" - expires_after="2021-12-05"> +<histogram name="DemoMode.SessionLength" units="minutes" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4514,7 +4673,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.Setup.DownloadDuration" units="minutes" - expires_after="2021-08-09"> + expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4524,7 +4683,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.Setup.EnrollDuration" units="minutes" - expires_after="2021-12-05"> + expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4534,7 +4693,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.Setup.LoadingDuration" units="minutes" - expires_after="2021-08-09"> + expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4545,8 +4704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="DemoMode.Setup.NumRetries" units="units" - expires_after="2021-08-09"> +<histogram name="DemoMode.Setup.NumRetries" units="units" expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4557,7 +4715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DemoMode.UniqueAppsLaunched" units="units" - expires_after="2021-08-09"> + expires_after="M109"> <owner>drcrash@chromium.org</owner> <owner>cros-demo-mode-eng@google.com</owner> <summary> @@ -4592,6 +4750,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="DigitalGoods.CrossSite" enum="Boolean" + expires_after="2022-03-29"> + <owner>glenrob@chromium.org</owner> + <owner>dominickn@chromium.org</owner> + <owner>rouslan@chromium.org</owner> + <owner>web-payments-team@google.com</owner> + <summary> + Records whether the |GetDigitalGoodsService| method was called from a + cross-site sub-frame. This metric is emitted when the cross-site check is + made in the renderer, i.e. only when the payment method is non-empty and the + script context is not being destroyed. + </summary> +</histogram> + <histogram name="DirectSockets.PermissionDeniedFailures" enum="DirectSocketPermissionFailureType" expires_after="2022-1-20"> <owner>ericwilligers@chromium.org</owner> @@ -4605,8 +4777,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Discarding.DiscardCandidatesCount" units="tabs" - expires_after="2021-12-12"> - <owner>sebmarchand@chromium.org</owner> + expires_after="2022-05-01"> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of tabs discard candidates. This is recorded each time Chrome @@ -4630,7 +4802,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.HighPMFPolicy.DiscardAttemptsCount" units="tabs" expires_after="2021-12-06"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of tab discard attempts during a high-PMF session. Recorded at @@ -4643,7 +4815,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.HighPMFPolicy.DiscardSuccess" units="BooleanSuccess" expires_after="2021-12-06"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Indicates if a tab has been successfully discarded during a high-PMF @@ -4653,7 +4825,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.HighPMFPolicy.MemoryPressureLevel" enum="MemoryPressureLevel" expires_after="2022-02-06"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The memory pressure level when the High-PMF policy decides to discard a tab. @@ -4663,7 +4835,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.HighPMFPolicy.MemoryReclaimedKbAfterDiscardingATab" units="KB" expires_after="2021-12-06"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The amount of memory that has been reclaimed after discarding a tab during a @@ -4674,7 +4846,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.HighPMFPolicy.SuccessfulDiscardsCount" units="tabs" expires_after="2021-12-06"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of successful tab discards during a high-PMF session. Recorded at @@ -4687,7 +4859,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.LargestTabFootprint" units="MiB" expires_after="2021-02-28"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The largest tab's resident set among all the urgent discarding candidates. @@ -4696,7 +4868,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.OldestTabFootprint" units="MiB" expires_after="2021-02-28"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary>The resident set of the oldest urgent discarding candidate.</summary> </histogram> @@ -4707,7 +4879,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. Removed 03/2021, replaced by Discarding.OnCriticalPressure.TotalRSS_Mb2. The new histogram is now guaranteed to be recorded before discarding any tab. </obsolete> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> An estimate of the total resident set of Chrome when receiving a critical @@ -4719,7 +4891,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.OnCriticalPressure.TotalRSS_Mb2" units="MB" expires_after="2021-10-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> An estimate of the total resident set of Chrome when receiving a critical @@ -4748,7 +4920,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.OnCriticalPressure.TotalRSS_PercentOfRAM2" units="%" expires_after="2021-10-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> An estimate of the total resident set of Chrome when receiving a critical @@ -4788,7 +4960,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.WinOSPressureSignals.AvailableMemoryMbOnLowMemoryNotification" units="MB" expires_after="2021-05-02"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The amount of physical memory available when receiving a low memory @@ -4798,7 +4970,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.WinOSPressureSignals.LowMemorySessionLength" units="ms" expires_after="2021-05-02"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The time it takes to receive a high memory notification from the OS after @@ -4809,7 +4981,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Discarding.WinOSPressureSignals.PressureLevelOnLowMemoryNotification" enum="MemoryPressureLevel" expires_after="2021-05-02"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The memory pressure level when receiving a low memory notification from the @@ -4817,34 +4989,76 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Display.BlockZeroSerialNumberType" - enum="BlockZeroSerialNumberType" expires_after="2022-07-01"> +<histogram name="Display.External.BlockZeroSerialNumberType" + enum="BlockZeroSerialNumberType" expires_after="2022-09-01"> <owner>gildekel@chromium.org</owner> - <owner>chromeos-gfx@google.com</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@google.com</owner> <summary> - The type of serial number retrived from block zero of a display's EDID + The type of serial number retrieved from block zero of a display's EDID during EDID parsing. </summary> </histogram> +<histogram name="Display.External.NumOfSerialNumbersProvided" units="count" + expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@google.com</owner> + <summary> + The number of serial numbers provided in an EDID (i.e. via block zero and/or + the serial number descriptor block). Values should be in the range of 0-2. + </summary> +</histogram> + +<histogram name="Display.External.ParseEdidOptionals" enum="ParseEdidOptionals" + expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@google.com</owner> + <summary> + The availability (or lack thereof) of tracked optional fields during EDID + parsing of external. + </summary> +</histogram> + <histogram name="Display.GenerateDisplayId.CollisionDetection" - enum="BooleanDisplayIdCollision" expires_after="2022-08-01"> - <owner>gildekel@google.com</owner> - <owner>chromeos-gfx@google.com</owner> + enum="BooleanDisplayIdCollision" expires_after="2022-09-01"> + <obsolete> + Replaced by Display.MultipleDisplays.GenerateId.CollisionDetection in M95. + </obsolete> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@google.com</owner> + <summary> + Whether or not displays produced identical display IDs due to insufficient + EDIDs. This may occur when identical displays (same make and model) lack + serial numbers in both the EDID's block zero or S/N descriptor block. + Recorded every time Chrome OS detects a change in display configuration and + attempts to get an updated list of available displays. + </summary> +</histogram> + +<histogram name="Display.MultipleDisplays.GenerateId.CollisionDetection" + enum="BooleanDisplayIdCollision" expires_after="2022-09-01"> + <owner>gildekel@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@google.com</owner> <summary> - Whether or not two (or more) connected displays produced identical display - IDs due to insufficient EDIDs. This may occur when identical displays (same - make and model) lack serial numbers in both the EDID's block zero or S/N + Whether or not multiple connected displays produced identical display IDs + due to incomplete EDIDs. This may occur when identical displays (same make + and model) lack serial numbers in both the EDID's block zero or S/N descriptor block. Recorded every time Chrome OS detects a change in display configuration and attempts to get an updated list of available displays. </summary> </histogram> <histogram name="Display.ParseEdidFailure" enum="ParseEdidFailure" - expires_after="2021-11-14"> - <owner>sashamcintosh@chromium.org</owner> + expires_after="2022-09-01"> <owner>gildekel@chromium.org</owner> - <owner>chromeos-gfx@google.com</owner> + <owner>sashamcintosh@chromium.org</owner> + <owner>seanpaul@chromium.org</owner> + <owner>chromeos-gfx-display@google.com</owner> <summary> Type of failure that occurs during EDID parsing. Typically the failure is caused by a mismatch between the EDID size and the expected offset of the @@ -4852,16 +5066,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Display.ParseEdidOptionals" enum="ParseEdidOptionals" - expires_after="2022-07-01"> - <owner>gildekel@chromium.org</owner> - <owner>chromeos-gfx@google.com</owner> - <summary> - The availability (or lack thereof) of tracked optional fields during EDID - parsing of external. - </summary> -</histogram> - <histogram name="DisplayManager.InternalDisplayZoomPercentage" units="%" expires_after="2022-06-15"> <owner>zentaro@chromium.org</owner> @@ -5109,7 +5313,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DocumentScan.ScanFailed" enum="DocumentScanSaneBackend" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>fletcherw@chromium.org</owner> <owner>bmgordon@chromium.org</owner> <owner>project-bolton@google.com</owner> @@ -5120,7 +5324,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DocumentScan.ScanRequested" enum="DocumentScanSaneBackend" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>fletcherw@chromium.org</owner> <owner>bmgordon@chromium.org</owner> <owner>project-bolton@google.com</owner> @@ -5131,7 +5335,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="DocumentScan.ScanSucceeded" enum="DocumentScanSaneBackend" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>fletcherw@chromium.org</owner> <owner>bmgordon@chromium.org</owner> <owner>project-bolton@google.com</owner> @@ -5350,7 +5554,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Downgrade.UserDataDirMove.FailureCount" units="count" expires_after="2020-12-31"> + <obsolete> + Deprecated as of M96 + </obsolete> <owner>grt@chromium.org</owner> + <owner>ydago@chromium.org</owner> <summary> The number of items within User Data that could not be moved aside following a downgrade. @@ -5359,6 +5567,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Downgrade.UserDataDirMove.Result" enum="UserDataMoveResult" expires_after="2020-12-31"> + <obsolete> + Deprecated as of M96 + </obsolete> <owner>grt@chromium.org</owner> <owner>ydago@chromium.org</owner> <summary> @@ -5368,7 +5579,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Drive.PushNotificationInitiallyEnabled" enum="BooleanEnabled" - expires_after="2021-10-25"> + expires_after="2022-05-01"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -5379,7 +5590,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Drive.PushNotificationRegistered" enum="BooleanRegistered" - expires_after="2021-10-25"> + expires_after="2022-05-01"> <owner>simmonsjosh@google.com</owner> <owner>src/ui/file_manager/OWNERS</owner> <summary> @@ -5691,7 +5902,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ExploreSites.CatalogRequestResult" - enum="ExploreSitesCatalogUpdateRequestResult" expires_after="2021-12-05"> + enum="ExploreSitesCatalogUpdateRequestResult" expires_after="2022-05-01"> <owner>dewittj@chromium.org</owner> <owner>petewil@chromium.org</owner> <summary>Results of the Explore Sites network request for a catalog.</summary> @@ -5766,7 +5977,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ExploreSites.MonthlyHostCount" units="hosts" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>dimich@chromium.org</owner> <summary> Number of unique hosts visited by the user during the last 30 days. Reported @@ -5799,7 +6010,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ExploreSites.RequestStatus" enum="ExploreSitesRequestStatus" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>dimich@chromium.org</owner> <owner>freedjm@chromium.org</owner> <summary> @@ -5905,6 +6116,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="FamilyUser.DenylistSource" enum="FamilyUserDenylistSource" + expires_after="2022-08-06"> + <owner>courtneywong@chromium.org</owner> + <owner>cros-families-eng@google.com</owner> + <summary> + Records the source from which the website filter denylist was loaded either + at login or when web content filter settings change. The default behavior is + to load the current denylist. If that fails, then loading the old denylist + will be attempted. If that also fails, then it is logged that there is no + denylist source. + </summary> +</histogram> + <histogram name="FamilyUser.DeviceOwner" enum="Boolean" expires_after="2021-12-19"> <owner>agawronska@chromium.org</owner> @@ -5945,7 +6169,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.FamilyLinkUsersCount" units="Number of Users" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -5957,7 +6181,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.GaiaUsersCount" units="Number of Users" - expires_after="2022-02-12"> + expires_after="2022-04-17"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -6026,7 +6250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.NewUserAdded" enum="NewUserAdded" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -6053,7 +6277,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.SessionEngagement.Duration" units="ms" - expires_after="2022-06-28"> + expires_after="2022-10-04"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -6066,7 +6290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.SessionEngagement.Total" units="Hour of day" - expires_after="2022-06-28"> + expires_after="2022-10-04"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -6080,7 +6304,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.SessionEngagement.Weekday" units="Hour of day" - expires_after="2021-11-14"> + expires_after="2022-10-04"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -6093,7 +6317,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.SessionEngagement.Weekend" units="Hour of day" - expires_after="2021-11-14"> + expires_after="2022-10-04"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -6106,7 +6330,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FamilyUser.TimeLimitPolicyTypes" enum="TimeLimitPolicyType" - expires_after="2021-12-12"> + expires_after="2022-10-04"> <owner>agawronska@chromium.org</owner> <owner>tobyhuang@chromium.org</owner> <owner>xiqiruan@chromium.org</owner> @@ -6339,7 +6563,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Feedback.HappinessTrackingSurvey.ShouldShowSurveyReason" enum="HappinessTrackingSurveyShouldShowSurveyReasons" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>sauski@google.com</owner> <owner>msramek@chromium.org</owner> <summary> @@ -6357,7 +6581,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Feedback.TrustSafetySentiment.SurveyRequested" - enum="TrustSafetySentimentFeatureArea" expires_after="M98"> + enum="TrustSafetySentimentFeatureArea" expires_after="2022-04-17"> <owner>sauski@google.com</owner> <owner>chrome-hats-eng@google.com</owner> <summary> @@ -6367,7 +6591,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Feedback.TrustSafetySentiment.TriggerOccurred" - enum="TrustSafetySentimentFeatureArea" expires_after="M98"> + enum="TrustSafetySentimentFeatureArea" expires_after="2022-04-17"> <owner>sauski@google.com</owner> <owner>chrome-hats-eng@google.com</owner> <summary> @@ -6385,7 +6609,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FirstRun.LaunchSource" enum="FirstRunLaunchSource" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>jlebel@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -6433,7 +6657,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FirstRun.NewUserExperience.NtpBackgroundInteraction" - enum="NuxNtpBackgroundInteractions" expires_after="2022-02-06"> + enum="NuxNtpBackgroundInteractions" expires_after="2022-04-10"> <owner>hcarmona@chromium.org</owner> <owner>johntlee@chromium.org</owner> <summary> @@ -6537,7 +6761,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="FirstUserAction.HandsetUserActionType" - enum="FirstUserActionType" expires_after="2021-10-25"> + enum="FirstUserActionType" expires_after="2022-09-12"> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -6591,6 +6815,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Fonts.AccessAPI.EnumerationCache.DuplicateFontCount" units="count" expires_after="M90"> + <obsolete> + Removed in M95 + </obsolete> <owner>oyiptong@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary> @@ -6602,6 +6829,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Fonts.AccessAPI.EnumerationCache.Dwrite.FamilyCount" units="families" expires_after="M90"> + <obsolete> + Removed in M95 + </obsolete> <owner>oyiptong@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary> @@ -6613,6 +6843,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Fonts.AccessAPI.EnumerationCache.Dwrite.GetSystemFontCollectionResult" enum="Hresult" expires_after="M90"> + <obsolete> + Removed in M95 + </obsolete> <owner>oyiptong@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary> @@ -6624,6 +6857,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Fonts.AccessAPI.EnumerationCache.Dwrite.MostFrequentEnumerationFailure" enum="Hresult" expires_after="M90"> + <obsolete> + Removed in M95 + </obsolete> <owner>oyiptong@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary> @@ -6649,6 +6885,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Fonts.AccessAPI.EnumerationCache.Fontconfig.FontCount" units="count" expires_after="M90"> + <obsolete> + Removed in M95 + </obsolete> <owner>oyiptong@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary>The number of fonts returned by fontconfig.</summary> @@ -6657,6 +6896,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Fonts.AccessAPI.EnumerationCache.Fontconfig.IncompleteFontCount" units="count" expires_after="M90"> + <obsolete> + Removed in M95 + </obsolete> <owner>oyiptong@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary> @@ -6666,6 +6908,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Fonts.AccessAPI.EnumerationTime" units="ms" expires_after="2021-06-20"> + <obsolete> + Removed in M95 + </obsolete> <owner>oyiptong@chromium.org</owner> <owner>storage-dev@chromium.org</owner> <summary>Time spent enumerating fonts.</summary> @@ -6726,7 +6971,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Gamepad.KnownGamepadConnectedWithId" - enum="GamepadVendorProduct" expires_after="2021-12-12"> + enum="GamepadVendorProduct" expires_after="2022-04-17"> <owner>mattreynolds@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> @@ -6743,7 +6988,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Gamepad.UnknownGamepadConnected" enum="GamepadSource" - expires_after="2021-11-21"> + expires_after="2022-05-01"> <owner>mattreynolds@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> @@ -6760,7 +7005,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GestureNavigation.Activated" enum="GestureNavigationDirection" - expires_after="2021-12-28"> + expires_after="2022-04-24"> <owner>jinsukkim@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -6772,7 +7017,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GestureNavigation.Cancelled" enum="GestureNavigationDirection" - expires_after="2021-12-28"> + expires_after="2022-05-01"> <owner>jinsukkim@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -6783,7 +7028,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GestureNavigation.Completed" enum="GestureNavigationDirection" - expires_after="2021-12-28"> + expires_after="2022-04-17"> <owner>jinsukkim@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -6793,7 +7038,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GestureNavigation.Reversed" enum="GestureNavigationDirection" - expires_after="2021-12-28"> + expires_after="2022-05-01"> <owner>jinsukkim@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -6847,7 +7092,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="GestureNavigation.Type" enum="GestureNavigationType" - expires_after="2021-12-28"> + expires_after="2022-04-17"> <owner>jinsukkim@chromium.org</owner> <owner>clank-app-team@google.com</owner> <summary> @@ -6858,98 +7103,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Gpu.GL.GetErrorDuration.GLImageEGL.BindTexImage" - units="microseconds" expires_after="2022-03-31"> - <owner>berlu@chromium.org</owner> - <owner>chromeos-gfx-compositor@google.com</owner> - <summary> - The time that elapsed for a call to glGetError to complete while trying to - bind a GLImageEGL to a texture. The goal is to measure the impact of the - potential sync barrier that glGetError represents. Only reported for - platforms supporting high resolution clocks. - </summary> -</histogram> - -<histogram name="Gpu.GL.GetErrorResult.GLImageEGL.BindTexImage" - enum="BooleanError" expires_after="2022-03-31"> - <owner>berlu@chromium.org</owner> - <owner>chromeos-gfx-compositor@google.com</owner> - <summary> - Whether glGetError actually returned an error while trying to bind a - GLImageEGL to a texture. The goal is to evaluate how often the call to - glGetError might actually serve its purpose. - </summary> -</histogram> - -<histogram name="Gpu.GL.ProgramBuildTime" units="ms" expires_after="M82"> - <owner>ccameron@chromium.org</owner> - <owner>graphics-dev@chromium.org</owner> - <summary> - The time that elapsed between a call to glCreateProgram and the call to - query GL_LINK_STATUS via glGetProgramiv in Skia's GrGLInterface. This - encompasses the creation of the vertex, fragment, and geometry shaders, - their compilation, and their linking. This is called for every program - created by Skia via the GrGLInterface. - </summary> -</histogram> - -<histogram name="Gpu.Mac.Backpressure" units="ms" expires_after="M80"> - <owner>ccameron@chromium.org</owner> - <owner>khushalsagar@chromium.org</owner> - <summary> - The time that the GPU's main CPU thread spends waiting for previous frames' - GPU work to complete. Recorded at every frame. - </summary> -</histogram> - -<histogram name="Gpu.Metal.TestShaderCompileTime" units="ms" - expires_after="M85"> - <owner>ccameron@chromium.org</owner> - <owner>graphics-dev@chromium.org</owner> - <summary> - Compiling a MTLLibrary will sometimes hang forever. When initializing the - gpu process, a test shader is compiled to see if the MTLCompilerService is - responding or not. This records the time that it took for the compile to - succeeded, up to 1 minute. After 1 minute, a timeout sentinel value of 3 - minutes is reported. - </summary> -</histogram> - -<histogram name="Gpu.Metal.TestShaderLinkTime" units="ms" expires_after="M85"> - <owner>ccameron@chromium.org</owner> - <owner>graphics-dev@chromium.org</owner> - <summary> - Linking a MTLRenderPipelineState will sometimes hang forever. When - initializing the GPU process, a test shader is compiled to see if the - MTLCompilerService is responding or not. This records the time that it took - for the compile to succeeded, up to 1 minute. After 1 minute, a timeout - sentinel value of 3 minutes is reported. - </summary> -</histogram> - -<histogram name="Gpu.MetalProxy.NewLibraryTime" units="ms" expires_after="M82"> - <owner>ccameron@chromium.org</owner> - <owner>graphics-dev@chromium.org</owner> - <summary> - The time that it takes to create a new MTLLibrary, including all retries. - Recorded after every call to -[MTLDeviceProxy newLibraryWithSource:] - completes. - </summary> -</histogram> - -<histogram name="Gpu.MetalProxy.NewRenderPipelineStateTime" units="ms" - expires_after="M82"> - <owner>ccameron@chromium.org</owner> - <owner>graphics-dev@chromium.org</owner> - <summary> - The time that it takes to create a new MTLRenderPipelineState, including all - retries. Recorded after every call to -[MTLDeviceProxy - newRenderPipelineStateWithDescriptor:] completes. - </summary> -</histogram> - <histogram name="Graphics.PresentationTimestamp.InvalidBeforeSwap" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -6987,7 +7142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.95pctPercentDroppedFrames_1sWindow" - units="%" expires_after="2021-11-12"> + units="%" expires_after="2022-04-17"> <owner>behdadb@chromium.org</owner> <owner>sadrul@chromium.org</owner> <summary> @@ -7009,7 +7164,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.Checkerboarding" units="%" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7025,7 +7180,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.Diagnostic.DiscardedDependentCount" - units="dependent reporters" expires_after="2022-02-01"> + units="dependent reporters" expires_after="2022-04-17"> <owner>sadrul@chromium.org</owner> <owner>behdadb@chromium.org</owner> <summary> @@ -7158,7 +7313,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.MaxPercentDroppedFrames_1sWindow" - units="%" expires_after="2022-01-16"> + units="%" expires_after="2022-04-10"> <owner>behdadb@chromium.org</owner> <owner>sadrul@chromium.org</owner> <summary> @@ -7172,7 +7327,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.MaxStale" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>mjzhang@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> @@ -7195,7 +7350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.PercentDroppedFrames" units="%" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7216,7 +7371,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.PercentDroppedFrames.AllAnimations" - units="%" expires_after="2022-02-06"> + units="%" expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>ericrk@chromium.org</owner> <summary> @@ -7237,7 +7392,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.PercentDroppedFrames.AllInteractions" - units="%" expires_after="2022-02-06"> + units="%" expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>ericrk@chromium.org</owner> <summary> @@ -7258,7 +7413,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.PercentDroppedFrames.AllSequences" - units="%" expires_after="2022-02-06"> + units="%" expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>ericrk@chromium.org</owner> <summary> @@ -7277,7 +7432,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Graphics.Smoothness.PercentMissedDeadlineFrames" - units="%" expires_after="2021-09-30"> + units="%" expires_after="2022-09-30"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7296,7 +7451,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.PercentMissedDeadlineFrames.AllAnimations" - units="%" expires_after="2021-09-30"> + units="%" expires_after="2022-09-30"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7316,7 +7471,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Graphics.Smoothness.PercentMissedDeadlineFrames.AllInteractions" - units="%" expires_after="2021-09-30"> + units="%" expires_after="2022-09-30"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7335,7 +7490,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.PercentMissedDeadlineFrames.AllSequences" - units="%" expires_after="2021-09-30"> + units="%" expires_after="2022-09-30"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7354,7 +7509,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Graphics.Smoothness.PerSession.95pctPercentDroppedFrames_1sWindow" - units="%" expires_after="2022-01-23"> + units="%" expires_after="2022-04-17"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7371,7 +7526,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.PerSession.AveragePercentDroppedFrames" - units="%" expires_after="2022-01-23"> + units="%" expires_after="2022-04-03"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7387,7 +7542,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Graphics.Smoothness.PerSession.MaxPercentDroppedFrames_1sWindow" - units="%" expires_after="2022-01-23"> + units="%" expires_after="2022-03-27"> <owner>sadrul@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> <summary> @@ -7419,7 +7574,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Graphics.Smoothness.Stale" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>sadrul@chromium.org</owner> <owner>mjzhang@chromium.org</owner> <owner>graphics-dev@chromium.org</owner> @@ -7484,7 +7639,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="GridTabSwitcher.FramePerSecond" units="frame/sec" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>yusufo@chromium.org</owner> <owner>wychen@chromium.org</owner> <summary> @@ -7539,7 +7694,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Hardware.Display.Count.OnChange" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>sashamcintosh@chromium.org</owner> <owner>chromeos-gfx@chromium.org</owner> <summary> @@ -7549,7 +7704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Hardware.Display.Count.OnStartup" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>sashamcintosh@chromium.org</owner> <owner>chromeos-gfx@chromium.org</owner> <summary> @@ -7571,7 +7726,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Hardware.TotalDiskSpace" units="GB" expires_after="2021-12-12"> +<histogram name="Hardware.TotalDiskSpace" units="GB" expires_after="2022-04-17"> <owner>sadrul@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -7633,6 +7788,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="HIDDetection.OOBEDevicesDetectedOnContinuePressed" enum="HIDContinueScenarioType" expires_after="M94"> + <obsolete> + Removed in M96. + </obsolete> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> @@ -7643,6 +7801,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="HIDDetection.OOBEDialogShown" units="units" expires_after="M94"> + <obsolete> + Removed in M96. + </obsolete> <owner>rsorokin@chromium.org</owner> <owner>cros-oac@google.com</owner> <summary> @@ -7652,7 +7813,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HIDDetection.TimesDialogShownPerOOBECompleted" units="units" - expires_after="M97"> + expires_after="2022-04-17"> <owner>rsorokin@chromium.org</owner> <owner>alemate@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -7747,7 +7908,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HttpCache.MaxFileSizeOnInit" units="KB" - expires_after="2021-12-12"> + expires_after="2022-02-20"> <owner>shivanisha@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <summary> @@ -7777,7 +7938,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="HttpCache.Pattern" enum="HttpCachePattern" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>morlovich@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <summary>For each http cache transaction, the recorded pattern.</summary> @@ -7802,7 +7963,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Hwsec.Attestation.Status" - enum="HwsecAttestationOpsStatus" expires_after="2021-12-26"> + enum="HwsecAttestationOpsStatus" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="AttestationOps" --> <owner>garryxiao@chromium.org</owner> @@ -7813,13 +7974,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Hyphenation.Open" units="ms" expires_after="2021-09-12"> +<histogram name="Hyphenation.Open" units="ms" expires_after="2022-04-24"> <owner>kojii@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary>The time it takes to open a hyphenation dictionary.</summary> </histogram> -<histogram name="Hyphenation.Open.File" units="ms" expires_after="2021-09-12"> +<histogram name="Hyphenation.Open.File" units="ms" expires_after="2021-12-12"> <owner>kojii@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary>The time it takes to open a hyphenation dictionary file.</summary> @@ -7894,6 +8055,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ImportantFile.FileCreateError" enum="PlatformFileError" expires_after="2022-01-16"> + <obsolete> + Removed in M95. Most failures are NO_SPACE. + </obsolete> <owner>grt@chromium.org</owner> <owner>xaerox@yandex-team.ru</owner> <summary> @@ -7903,6 +8067,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ImportantFile.FileDeleteNoRetryError" enum="PlatformFileError" expires_after="2021-11-14"> + <obsolete> + Removed in M95. + </obsolete> <owner>grt@chromium.org</owner> <owner>xaerox@yandex-team.ru</owner> <summary> @@ -7913,6 +8080,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ImportantFile.FileDeleteRetryExceededError" enum="PlatformFileError" expires_after="2021-12-19"> + <obsolete> + Removed in M95. + </obsolete> <owner>grt@chromium.org</owner> <owner>xaerox@yandex-team.ru</owner> <summary> @@ -7922,6 +8092,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ImportantFile.FileDeleteRetrySuccessCount" units="attept number" expires_after="2021-12-19"> + <obsolete> + Removed in M95. + </obsolete> <owner>grt@chromium.org</owner> <owner>xaerox@yandex-team.ru</owner> <summary> @@ -7932,6 +8105,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ImportantFile.FileRenameError" enum="PlatformFileError" expires_after="2021-12-05"> + <obsolete> + Removed in M95. Most failures are ACCESS_DENIED. + </obsolete> <owner>grt@chromium.org</owner> <owner>xaerox@yandex-team.ru</owner> <summary> @@ -7940,7 +8116,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ImportantFile.FileReplaceRetryCount" units="attempt count" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>brucedawson@chromium.org</owner> <owner>grt@chromium.org</owner> <summary> @@ -7952,6 +8128,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ImportantFile.FileWriteError" enum="PlatformFileError" expires_after="2021-12-05"> + <obsolete> + Removed in M95. Most failures are NO_SPACE. + </obsolete> <owner>grt@chromium.org</owner> <owner>xaerox@yandex-team.ru</owner> <summary> @@ -7960,7 +8139,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="ImportantFile.SerializationDuration" units="ms" +<histogram name="ImportantFile.SerializationDuration{File}" units="ms" expires_after="2021-12-12"> <owner>battre@chromium.org</owner> <owner>gab@chromium.org</owner> @@ -7971,10 +8150,23 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. serialization (e.g. bookmarks), it excludes the time spent on the background thread, and only logs the time spent on the foreground thread. </summary> + <token key="File"> + <variant name="" summary="Unknown file"/> + <variant name=".BookmarkStorage" summary="Bookmarks file"/> + <variant name=".FeedbackReport" summary="Feedback Report file"/> + <variant name=".Local_State" summary="Local State file"/> + <variant name=".Preferences" summary="Preferences file"/> + <variant name=".Secure_Preferences" summary="Secure Preferences file"/> + <variant name=".StructuredMetricsPersistentProto" + summary="Structured metrics persistent proto"/> + </token> </histogram> <histogram name="ImportantFile.TempFileFailures" enum="TempFileFailure" expires_after="2021-12-19"> + <obsolete> + Removed in M95. Most failures are NO_SPACE. + </obsolete> <owner>grt@chromium.org</owner> <owner>lassey@google.com</owner> <summary> @@ -8246,16 +8438,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Invalidations.GCMUpstreamRequest" - enum="GCMUpstreamMessageStatus" expires_after="M76"> - <owner>nyquist@chromium.org</owner> - <owner>khushalsagar@chromium.org</owner> - <owner>melandory@chromium.org</owner> - <summary> - Status of sending outgoing invalidation message through GCM upsteam. - </summary> -</histogram> - <histogram name="IPC.AttachmentBrokerPrivileged.BrokerAttachmentError" enum="IPCAttachmentBrokerPrivilegedBrokerAttachmentError" expires_after="M85"> @@ -8310,7 +8492,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.AcquireKerberosTgtTime" units="ms" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8320,7 +8502,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.DailyActiveUsers" enum="KerberosUserType" - expires_after="M97"> + expires_after="2022-04-03"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8332,7 +8514,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.EncryptionTypesAcquireKerberosTgt" - enum="KerberosEncryptionTypes" expires_after="M97"> + enum="KerberosEncryptionTypes" expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8343,7 +8525,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.NumberOfAccounts.Managed" units="units" - expires_after="M97"> + expires_after="2022-04-03"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8354,7 +8536,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.NumberOfAccounts.RememberedPassword" units="units" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8366,7 +8548,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.NumberOfAccounts.Total" units="units" - expires_after="M97"> + expires_after="2022-04-03"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8376,7 +8558,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.NumberOfAccounts.Unmanaged" units="units" - expires_after="M97"> + expires_after="2022-04-03"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8387,7 +8569,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.NumberOfAccounts.UseLoginPassword" units="units" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8399,7 +8581,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.Result.AcquireKerberosTgt" enum="KerberosErrorType" - expires_after="M97"> + expires_after="2022-04-03"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8409,7 +8591,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.Result.AddAccount" enum="KerberosErrorType" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8419,7 +8601,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.Result.ClearAccounts" enum="KerberosErrorType" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8430,7 +8612,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.Result.GetKerberosFiles" enum="KerberosErrorType" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8441,7 +8623,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.Result.ListAccounts" enum="KerberosErrorType" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8461,7 +8643,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kerberos.Result.SetConfig" enum="KerberosErrorType" - expires_after="M97"> + expires_after="2022-04-10"> <owner>fsandrade@chromium.org</owner> <owner>tomdobro@chromium.org</owner> <summary> @@ -8493,7 +8675,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Keyboard.ShortcutViewer.StartupTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>jamescook@chromium.org</owner> <owner>msw@chromium.org</owner> <owner>wutao@chromium.org</owner> @@ -8505,7 +8687,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kiosk.Launch.CryptohomeFailure" enum="LoginFailureReason" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>xiyuan@chromium.org</owner> <owner>apotapchuk@chromium.org</owner> <summary>Tracks cryptohome failure during kiosk launch.</summary> @@ -8519,7 +8701,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Kiosk.LaunchType" enum="KioskLaunchType" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>xiyuan@chromium.org</owner> <owner>aghuie@chromium.org</owner> <summary> @@ -8529,7 +8711,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageDetection.TFLiteModel.LanguageDetectionModelState" - enum="LanguageDetectionModelState" expires_after="M98"> + enum="LanguageDetectionModelState" expires_after="2022-04-17"> <owner>mcrouse@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8539,7 +8721,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageDetection.TFLiteModel.WasModelAvailableForDetection" - enum="BooleanAvailable" expires_after="M98"> + enum="BooleanAvailable" expires_after="2022-04-03"> <owner>mcrouse@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8549,6 +8731,29 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="LanguageDetection.TFLiteModel.WasModelRequestDeferred" + enum="BooleanDeferred" expires_after="2022-04-24"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-language@google.com</owner> + <summary> + Whether the request to load the TFLite-based language detection model + deferred because the associated frame was hidden. This is recorded once per + render frame only in frames that the model is not already available. + </summary> +</histogram> + +<histogram + name="LanguageDetection.TFLiteModel.WasModelUnavailableDueToDeferredLoad" + enum="Boolean" expires_after="2022-04-24"> + <owner>mcrouse@chromium.org</owner> + <owner>chrome-language@google.com</owner> + <summary> + Whether the model was unavilable for detecting the page language because the + request to load the model was deferred because the frame was hidden when the + translate agent was initialized. This is recorded once per page load. + </summary> +</histogram> + <histogram name="LanguageSettings.Actions" enum="LanguageSettingsActionType" expires_after="2021-12-01"> <owner>perrier@chromium.org</owner> @@ -8562,7 +8767,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageSettings.AppLanguagePrompt.Action" - enum="LanguageSettingsAppLanguagePromptAction" expires_after="2021-12-01"> + enum="LanguageSettingsAppLanguagePromptAction" expires_after="2022-04-10"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8573,11 +8778,25 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="LanguageSettings.AppLanguagePrompt.IsTopLanguageSelected" +<histogram name="LanguageSettings.AppLanguagePrompt.IsOnline" enum="BooleanYesNo" expires_after="2021-12-01"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> + Whether or not the device is online when the App Language Prompt should be + shown. If offline the prompt is not shown and will be shown the next time + Chrome starts and is online. + + Reported each time all other conditions for showing the App Language Prompt + have been met. + </summary> +</histogram> + +<histogram name="LanguageSettings.AppLanguagePrompt.IsTopLanguageSelected" + enum="BooleanYesNo" expires_after="2022-04-17"> + <owner>perrier@chromium.org</owner> + <owner>chrome-language@google.com</owner> + <summary> Whether or not the language selected for the app language prompt is one of the top suggested languages or not. @@ -8622,7 +8841,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageSettings.PageImpression" - enum="LanguageSettingsPageType" expires_after="2022-01-30"> + enum="LanguageSettingsPageType" expires_after="2022-04-03"> <owner>googleo@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8633,7 +8852,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageSettings.SplitInstallFinalStatus" - enum="LanguageSettingsSplitInstallStatus" expires_after="2021-12-01"> + enum="LanguageSettingsSplitInstallStatus" expires_after="2022-05-01"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8645,7 +8864,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.AcceptLanguage" enum="LanguageName" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8655,7 +8874,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.AcceptLanguage.Count" units="units" - expires_after="2022-01-30"> + expires_after="2022-04-17"> <owner>dvallet@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8665,7 +8884,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.ApplicationLanguage" enum="LanguageName" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8675,7 +8894,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.MostFrequentPageLanguages" enum="LanguageName" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8693,7 +8912,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.UI.Android.Availability" - enum="LanguageUsage.UI.Android.Availability" expires_after="2022-01-30"> + enum="LanguageUsage.UI.Android.Availability" expires_after="2022-04-03"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8721,7 +8940,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.UI.Android.Correctness.NoOverride" - enum="LanguageUsage.UI.Android.Correctness" expires_after="2022-01-30"> + enum="LanguageUsage.UI.Android.Correctness" expires_after="2022-04-10"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8735,7 +8954,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.UI.Android.Correctness.Override" - enum="LanguageUsage.UI.Android.Correctness" expires_after="2022-01-30"> + enum="LanguageUsage.UI.Android.Correctness" expires_after="2022-04-10"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8750,7 +8969,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LanguageUsage.UI.Android.OverrideLanguage" - enum="LocaleCodeISO639" expires_after="2021-12-01"> + enum="LocaleCodeISO639" expires_after="2022-04-03"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8764,7 +8983,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="LanguageUsage.UI.Android.OverrideLanguage.IsSystemLanguage" enum="LanguageUsage.UI.Android.OverrideLanguage.IsSystemLanguage" - expires_after="2021-12-01"> + expires_after="2022-04-10"> <owner>perrier@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -8793,7 +9012,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Launch.HomeScreen" enum="LaunchFromHomeScreen" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>dominickn@chromium.org</owner> <owner>hartmanng@chromium.org</owner> <owner>peconn@chromium.org</owner> @@ -8803,7 +9022,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Launch.HomeScreenSource" enum="LaunchFromHomeScreenSource" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>dominickn@chromium.org</owner> <owner>hartmanng@chromium.org</owner> <owner>peconn@chromium.org</owner> @@ -8846,7 +9065,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Launch.WebAppDisplayMode" enum="WebAppDisplayMode" - expires_after="M96"> + expires_after="2022-04-17"> <owner>peter@chromium.org</owner> <owner>yfriedman@chromium.org</owner> <summary> @@ -9053,7 +9272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Lens.ImageClassification.ClassificationTime.EarlyTerminatedMs" - units="ms" expires_after="2022-01-16"> + units="ms" expires_after="2022-03-20"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <summary> @@ -9064,7 +9283,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Lens.ImageClassification.ClassificationTime.SuccessOnQueryResultMs" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-05-01"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <summary> @@ -9074,7 +9293,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Lens.ImageClassification.ResultState" - enum="LensClassifyResultState" expires_after="2021-12-26"> + enum="LensClassifyResultState" expires_after="2022-04-03"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <summary> @@ -9084,7 +9303,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Lens.ImageClassification.SdkError" enum="LensSdkError" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <summary> @@ -9095,7 +9314,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Lens.Omnibox.LensSupportStatus" enum="LensSupportStatus" - expires_after="2021-11-18"> + expires_after="2022-04-03"> <owner>yusuyoutube@google.com</owner> <owner>benwgold@google.com</owner> <owner>fgorski@chromium.org</owner> @@ -9126,6 +9345,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="2021-08-24"> <owner>nyquist@chromium.org</owner> <owner>salg@google.com</owner> + <owner>chrome-owp-storage@google.com</owner> <summary> The approximate MemTable memory use of a LevelDB in bytes. Recorded right after initializing an on-disk database. @@ -9133,7 +9353,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LevelDBEnv.DeleteTableBackupFile" enum="BooleanSuccess" - expires_after="2020-12-31"> + expires_after="2022-08-01"> <owner>cmumford@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -9142,23 +9362,28 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LevelDBEnv.IOError" enum="LevelDBIOErrorMethods" - expires_after="M95"> + expires_after="2022-08-01"> <owner>dmurph@chromium.org</owner> <owner>pwnall@chromium.org</owner> + <owner>chrome-owp-storage@google.com</owner> <summary>Methods where leveldb's Chromium environment has IO errors.</summary> </histogram> -<histogram name="LevelDBEnv.MissingFiles" units="files" expires_after="M95"> +<histogram name="LevelDBEnv.MissingFiles" units="files" + expires_after="2022-08-01"> <owner>dmurph@chromium.org</owner> <owner>pwnall@chromium.org</owner> + <owner>chrome-owp-storage@google.com</owner> <summary> Number of backup files found without corresponding ldb files. As measured by GetChildren when used in LevelDB clients other than IndexedDB. </summary> </histogram> -<histogram name="LevelDBWrapper.CommitDelay" units="ms" expires_after="M95"> +<histogram name="LevelDBWrapper.CommitDelay" units="ms" + expires_after="2022-08-01"> <owner>mek@chromium.org</owner> + <owner>chrome-owp-storage@google.com</owner> <summary> Delay between the browser process receiving changes and those changes being written to the DB. @@ -9351,7 +9576,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="LiteVideo.HintAgent.HasHint" units="boolean" - expires_after="M96"> + expires_after="2022-02-20"> <owner>rajendrant@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -9403,7 +9628,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="LoadingPredictor.OptimizationHintsReceiveStatus" enum="LoadingPredictorOptimizationHintsReceiveStatus" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>sophiechang@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -9548,9 +9773,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="MachineLearningService.CpuTimeMicrosec" units="microseconds" expires_after="2022-01-15"> -<!-- Name completed by histogram_suffixes - name="MachineLearningServiceRequests" --> - <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> <summary> @@ -9561,7 +9783,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.CpuUsageMilliPercent" - units="1/1000ths of %" expires_after="2022-01-15"> + units="1/1000ths of %" expires_after="2022-03-20"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <summary> @@ -9581,24 +9803,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="MachineLearningService.DocumentScanner.LoadModelResult.Event" - enum="MachineLearningServiceLoadModelResultEvent" - expires_after="2022-12-31"> - <owner>wtlee@chromium.org</owner> - <owner>chromeos-camera-eng@google.com</owner> - <summary> - The result of loading document scanner, which can be OK or some specific - error. - </summary> -</histogram> - <histogram name="MachineLearningService.DocumentScanner.{RequestName}.Event" enum="MachineLearningServiceDocumentScannerResultEvent" expires_after="2022-12-31"> <owner>wtlee@chromium.org</owner> <owner>chromeos-camera-eng@google.com</owner> <summary> - The result of document scanner request, which can be OK or ERROR. + The result of DocumentScanner.{RequestName} request, which can be OK or + ERROR. </summary> <token key="RequestName"> <variant name="DetectCornersFromJPEG"/> @@ -9617,7 +9829,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.GrammarChecker.Check.Event" - enum="Boolean" expires_after="2021-12-31"> + enum="Boolean" expires_after="2022-05-01"> <owner>jiwan@chromium.org</owner> <owner>amoylan@chromium.org</owner> <summary>The result of grammar check, which can be OK or ERROR.</summary> @@ -9637,7 +9849,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MachineLearningService.HandwritingModel.LoadModelResult.Event" enum="MachineLearningServiceLoadHandwritingModelResultEvent" - expires_after="2022-01-15"> + expires_after="2022-04-10"> <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> <owner>charleszhao@chromium.org</owner> @@ -9649,7 +9861,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.HandwritingModel.Recognize.Event" - enum="Boolean" expires_after="2022-01-15"> + enum="Boolean" expires_after="2022-03-20"> <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> <owner>charleszhao@chromium.org</owner> @@ -9682,7 +9894,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.MojoConnectionEvent" - enum="MachineLearningServiceMojoConnectionEvent" expires_after="2022-01-15"> + enum="MachineLearningServiceMojoConnectionEvent" expires_after="2022-04-10"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <summary> @@ -9692,7 +9904,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.NumWorkerProcess" units="count" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>honglinyu@chromium.org</owner> @@ -9703,7 +9915,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.PeakTotalMemoryKb" units="KB" - expires_after="2022-01-15"> + expires_after="2022-03-20"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>honglinyu@chromium.org</owner> @@ -9714,7 +9926,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.ProcessError" - enum="MachineLearningServiceProcessError" expires_after="2022-01-15"> + enum="MachineLearningServiceProcessError" expires_after="2022-04-03"> <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> <owner>honglinyu@chromium.org</owner> @@ -9762,7 +9974,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.TotalMemoryKb" units="KB" - expires_after="2022-01-15"> + expires_after="2022-03-20"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>honglinyu@chromium.org</owner> @@ -9774,7 +9986,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MachineLearningService.WebPlatformHandwritingModel.GetPrediction.Event" - enum="Boolean" expires_after="2022-01-15"> + enum="Boolean" expires_after="2022-04-10"> <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> <owner>charleszhao@chromium.org</owner> @@ -9787,7 +9999,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="MachineLearningService.WebPlatformHandwritingModel.LoadModelResult.Event" enum="MachineLearningServiceLoadHandwritingModelResultEvent" - expires_after="2022-01-15"> + expires_after="2022-05-01"> <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> <owner>charleszhao@chromium.org</owner> @@ -9799,7 +10011,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.WorkerProcessAcceptMojoConnectionTime" - units="microseconds" expires_after="2022-01-15"> + units="microseconds" expires_after="2022-04-17"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>honglinyu@chromium.org</owner> @@ -9810,7 +10022,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MachineLearningService.WorkerProcessCleanUpTime" - units="microseconds" expires_after="2022-01-15"> + units="microseconds" expires_after="2022-04-10"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>honglinyu@chromium.org</owner> @@ -9833,41 +10045,269 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="MachineLearningService.{ObsoleteRequestName}.CpuTimeMicrosec" + units="microseconds" expires_after="M95"> + <obsolete> + Removed in M95. + </obsolete> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <summary> + CPU time (for one CPU core) of obsolete {ObsoleteRequestName} request. + </summary> + <token key="ObsoleteRequestName"> + <variant name="CreateGraphExecutorResult"/> + <variant name="ExecuteResult"/> + <variant name="LoadModelResult"/> + <variant name="smart_dim_model_20190521_v3.CreateGraphExecutorResult"/> + <variant name="smart_dim_model_20190521_v3.ExecuteResult"/> + <variant name="smart_dim_model_20190521_v3.LoadModelResult"/> + <variant name="TopCatModel.CreateGraphExecutorResult"/> + <variant name="TopCatModel.ExecuteResult"/> + <variant name="TopCatModel.LoadModelResult"/> + </token> +</histogram> + +<histogram + name="MachineLearningService.{ObsoleteRequestName}.CreateGraphExecutorResult.Event" + enum="MachineLearningServiceCreateGraphExecutorResultEvent" + expires_after="M95"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <summary> + The result of obsolete {ObsoleteRequestName} CreateGraphExecutor request. + </summary> + <token key="ObsoleteRequestName"> + <variant name="smart_dim_model_20190521_v3"/> + <variant name="TopCatModel"/> + </token> +</histogram> + +<histogram + name="MachineLearningService.{ObsoleteRequestName}.ElapsedTimeMicrosec" + units="microseconds" expires_after="2020-02-01"> + <obsolete> + Removed 2020-02-01 because the elapsed time of {ObsoleteRequestName} request + should be measured by clients, if they need it. + </obsolete> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <summary/> + <token key="ObsoleteRequestName"> + <variant name="CreateGraphExecutorResult"/> + <variant name="ExecuteResult"/> + <variant name="HandwritingModel.LoadModelResult"/> + <variant name="HandwritingModel.Recognize"/> + <variant name="LoadModelResult"/> + <variant name="smart_dim_model_20190521_v3.CreateGraphExecutorResult"/> + <variant name="smart_dim_model_20190521_v3.ExecuteResult"/> + <variant name="smart_dim_model_20190521_v3.LoadModelResult"/> + <variant name="SmartDimModel.CreateGraphExecutorResult"/> + <variant name="SmartDimModel.ExecuteResult"/> + <variant name="SmartDimModel.LoadModelResult"/> + <variant name="TestModel.CreateGraphExecutorResult"/> + <variant name="TestModel.ExecuteResult"/> + <variant name="TestModel.LoadModelResult"/> + <variant name="TextClassifier.Annotate"/> + <variant name="TextClassifier.FindLanguages"/> + <variant name="TextClassifier.LoadModelResult"/> + <variant name="TextClassifier.SuggestSelection"/> + <variant name="TextSuggester.LoadModelResult"/> + <variant name="TextSuggester.Suggest"/> + <variant name="TopCatModel.CreateGraphExecutorResult"/> + <variant name="TopCatModel.ExecuteResult"/> + <variant name="TopCatModel.LoadModelResult"/> + <variant name="WebPlatformHandwritingModel.GetPrediction"/> + <variant name="WebPlatformHandwritingModel.LoadModelResult"/> + </token> +</histogram> + +<histogram + name="MachineLearningService.{ObsoleteRequestName}.ExecuteResult.Event" + enum="MachineLearningServiceExecuteResultEvent" expires_after="M95"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <summary> + The result of obsolete {ObsoleteRequestName} Execute request. + </summary> + <token key="ObsoleteRequestName"> + <variant name="smart_dim_model_20190521_v3"/> + <variant name="TopCatModel"/> + </token> +</histogram> + +<histogram + name="MachineLearningService.{ObsoleteRequestName}.LoadModelResult.Event" + enum="MachineLearningServiceLoadModelResultEvent" expires_after="M95"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <summary> + The result of obsolete {ObsoleteRequestName} LoadModel request. + </summary> + <token key="ObsoleteRequestName"> + <variant name="smart_dim_model_20190521_v3"/> + <variant name="TopCatModel"/> + </token> +</histogram> + +<histogram + name="MachineLearningService.{ObsoleteRequestName}.PrivateMemoryDeltaKb" + units="KB" expires_after="2019-07-01"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <owner>honglinyu@chromium.org</owner> + <summary> + Deprecated 07/2019, because we change to record total (shared+unshared) + memory rather than only private memory. Replaced by + MachineLearningService.{ObsoleteRequestName}.TotalMemoryDeltaKb. + </summary> + <token key="ObsoleteRequestName"> + <variant name="CreateGraphExecutorResult"/> + <variant name="ExecuteResult"/> + <variant name="HandwritingModel.LoadModelResult"/> + <variant name="HandwritingModel.Recognize"/> + <variant name="LoadModelResult"/> + <variant name="TextClassifier.Annotate"/> + <variant name="TextClassifier.FindLanguages"/> + <variant name="TextClassifier.LoadModelResult"/> + <variant name="TextClassifier.SuggestSelection"/> + <variant name="TextSuggester.LoadModelResult"/> + <variant name="TextSuggester.Suggest"/> + <variant name="WebPlatformHandwritingModel.GetPrediction"/> + <variant name="WebPlatformHandwritingModel.LoadModelResult"/> + </token> +</histogram> + +<histogram + name="MachineLearningService.{ObsoleteRequestName}.TotalMemoryDeltaKb" + units="KB" expires_after="M95"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <owner>honglinyu@chromium.org</owner> + <summary> + Memory usage increase caused by obsolete {ObsoleteRequestName} request. + </summary> + <token key="ObsoleteRequestName"> + <variant name="CreateGraphExecutorResult"/> + <variant name="ExecuteResult"/> + <variant name="LoadModelResult"/> + <variant name="smart_dim_model_20190521_v3.CreateGraphExecutorResult"/> + <variant name="smart_dim_model_20190521_v3.ExecuteResult"/> + <variant name="smart_dim_model_20190521_v3.LoadModelResult"/> + <variant name="TopCatModel.CreateGraphExecutorResult"/> + <variant name="TopCatModel.ExecuteResult"/> + <variant name="TopCatModel.LoadModelResult"/> + </token> +</histogram> + <histogram name="MachineLearningService.{RequestName}.CpuTimeMicrosec" - enum="MachineLearningServiceLoadModelResultEvent" - expires_after="2022-12-31"> + units="microseconds" expires_after="2022-01-15"> <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> <summary> - CPU time (for one CPU core) of one Chrome OS ML Service request. Reported - for all users; users without high-resolution clocks will report 0 for short + CPU time (for one CPU core) of {RequestName} request. Reported for all + users; users without high-resolution clocks will report 0 for short requests. </summary> <token key="RequestName"> -<!-- TODO(b/195618587): Refactor for other ML service metrics --> - <variant name="DocumentScanner.DetectCornersFromJPEG"/> <variant name="DocumentScanner.DetectCornersFromNV12"/> <variant name="DocumentScanner.DoPostProcessing"/> <variant name="DocumentScanner.LoadModelResult"/> + <variant name="HandwritingModel.LoadModelResult"/> + <variant name="HandwritingModel.Recognize"/> + <variant name="SmartDimModel.CreateGraphExecutorResult"/> + <variant name="SmartDimModel.ExecuteResult"/> + <variant name="SmartDimModel.LoadModelResult"/> + <variant name="TestModel.CreateGraphExecutorResult"/> + <variant name="TestModel.ExecuteResult"/> + <variant name="TestModel.LoadModelResult"/> + <variant name="TextClassifier.Annotate"/> + <variant name="TextClassifier.FindLanguages"/> + <variant name="TextClassifier.LoadModelResult"/> + <variant name="TextClassifier.SuggestSelection"/> + <variant name="TextSuggester.LoadModelResult"/> + <variant name="TextSuggester.Suggest"/> + <variant name="WebPlatformHandwritingModel.GetPrediction"/> + <variant name="WebPlatformHandwritingModel.LoadModelResult"/> </token> </histogram> -<histogram name="MachineLearningService.{RequestName}.TotalMemoryDeltaKb" - units="KB" expires_after="2022-12-31"> +<histogram + name="MachineLearningService.{RequestName}.CreateGraphExecutorResult.Event" + enum="MachineLearningServiceCreateGraphExecutorResultEvent" + expires_after="2022-01-15"> <owner>amoylan@chromium.org</owner> <owner>alanlxl@chromium.org</owner> - <owner>honglinyu@chromium.org</owner> <summary> - Memory usage increase caused by one Chrome OS ML Service request. + The result of {RequestName} CreateGraphExecutor request, which can be OK or + some specific error. + </summary> + <token key="RequestName"> + <variant name="SmartDimModel"/> + <variant name="TestModel"/> + </token> +</histogram> + +<histogram name="MachineLearningService.{RequestName}.ExecuteResult.Event" + enum="MachineLearningServiceExecuteResultEvent" expires_after="2022-01-15"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <summary> + The result of {RequestName} Execute request, which can be OK or some + specific error. + </summary> + <token key="RequestName"> + <variant name="SmartDimModel"/> + <variant name="TestModel"/> + </token> +</histogram> + +<histogram name="MachineLearningService.{RequestName}.LoadModelResult.Event" + enum="MachineLearningServiceLoadModelResultEvent" + expires_after="2022-01-15"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <summary> + The result of {RequestName} LoadModel request, which can be OK or some + specific error. </summary> <token key="RequestName"> -<!-- TODO(b/195618587): Refactor for other ML service metrics --> + <variant name="DocumentScanner"/> + <variant name="SmartDimModel"/> + <variant name="TestModel"/> + <variant name="TextClassifier"/> + <variant name="TextSuggester"/> + </token> +</histogram> +<histogram name="MachineLearningService.{RequestName}.TotalMemoryDeltaKb" + units="KB" expires_after="2022-12-31"> + <owner>amoylan@chromium.org</owner> + <owner>alanlxl@chromium.org</owner> + <owner>honglinyu@chromium.org</owner> + <summary>Memory usage increase caused by {RequestName} request.</summary> + <token key="RequestName"> <variant name="DocumentScanner.DetectCornersFromJPEG"/> <variant name="DocumentScanner.DetectCornersFromNV12"/> <variant name="DocumentScanner.DoPostProcessing"/> <variant name="DocumentScanner.LoadModelResult"/> + <variant name="HandwritingModel.LoadModelResult"/> + <variant name="HandwritingModel.Recognize"/> + <variant name="SmartDimModel.CreateGraphExecutorResult"/> + <variant name="SmartDimModel.ExecuteResult"/> + <variant name="SmartDimModel.LoadModelResult"/> + <variant name="TestModel.CreateGraphExecutorResult"/> + <variant name="TestModel.ExecuteResult"/> + <variant name="TestModel.LoadModelResult"/> + <variant name="TextClassifier.Annotate"/> + <variant name="TextClassifier.FindLanguages"/> + <variant name="TextClassifier.LoadModelResult"/> + <variant name="TextClassifier.SuggestSelection"/> + <variant name="TextSuggester.LoadModelResult"/> + <variant name="TextSuggester.Suggest"/> + <variant name="WebPlatformHandwritingModel.GetPrediction"/> + <variant name="WebPlatformHandwritingModel.LoadModelResult"/> </token> </histogram> @@ -9883,7 +10323,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ManagedUsers.FilteringResult" - enum="SupervisedUserSafetyFilterResult" expires_after="2021-12-26"> + enum="SupervisedUserSafetyFilterResult" expires_after="2022-04-10"> <owner>agawronska@chromium.org</owner> <owner>cros-families@google.com</owner> <summary> @@ -9940,7 +10380,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ManagedUsers.SafeSitesDelay" units="ms" - expires_after="2021-10-15"> + expires_after="2022-10-04"> <owner>agawronska@chromium.org</owner> <owner>cros-families-eng@google.com</owner> <summary> @@ -9950,7 +10390,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ManagedUsers.SafetyFilter" - enum="SupervisedUserSafetyFilterResult" expires_after="2021-09-27"> + enum="SupervisedUserSafetyFilterResult" expires_after="2022-08-19"> <owner>agawronska@chromium.org</owner> <owner>cros-families-eng@google.com</owner> <summary> @@ -9958,7 +10398,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. includes the outcome of the filter (i.e. allowed, blocked, or unknown) and the page transition type (how the user got there, e.g. typed URL, clicked link). This only includes URL requests that were handled by the SafeSites - filter (both online and the static blacklist). + filter (both online and the static blocklist). </summary> </histogram> @@ -9984,7 +10424,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Manifest.HasProperty" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>mgiuca@chromium.org</owner> <summary> Tracks which properties of a Manifest were present when it was parsed. If a @@ -9995,7 +10435,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Manifest.ParseIdResult" enum="ManifestParseIdResultType" - expires_after="M99"> + expires_after="2022-05-01"> <owner>phillis@chromium.org</owner> <owner>desktop-pwas-team@chromium.org</owner> <summary>Tracks the result of parsing id field in the Manifest.</summary> @@ -10012,7 +10452,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MerchantTrust.BottomSheet.CloseReason" - enum="BottomSheet.StateChangeReason" expires_after="M95"> + enum="BottomSheet.StateChangeReason" expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10022,7 +10462,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MerchantTrust.BottomSheet.DurationFullyOpened" units="ms" - expires_after="M95"> + expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10032,7 +10472,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MerchantTrust.BottomSheet.DurationHalfOpened" units="ms" - expires_after="M95"> + expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10042,7 +10482,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MerchantTrust.BottomSheet.DurationPeeked" units="ms" - expires_after="M95"> + expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10052,7 +10492,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MerchantTrust.BottomSheet.IsFullyViewed" enum="Boolean" - expires_after="M95"> + expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10062,7 +10502,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MerchantTrust.BottomSheet.IsHalfViewed" enum="Boolean" - expires_after="M95"> + expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10071,19 +10511,30 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="MerchantTrust.BottomSheet.OpenSource" + enum="MerchantTrustBottomSheetOpenedSource" expires_after="M102"> + <owner>zhiyuancai@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Records which ui the bottom sheet is opened from. Recorded when the bottom + sheet is opened. Implemented for Android. + </summary> +</histogram> + <histogram name="MerchantTrust.Message.ClearReason" - enum="MerchantTrustMessageClearReason" expires_after="M95"> + enum="MerchantTrustMessageClearReason" expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> - Records the reason that the merchant trust message is cleared in the - MessageDispatcher queue. Right now we only record message being cleared when - user navigates away from current page. Implemented for Android. + Records why the prepared merchant trust message is cleared. Recorded when + the prepared message is cleared. Implemented for Android. In M96 and later + this includes MESSAGE_CONTEXT_NO_LONGER_VALID and + SWITCH_TO_DIFFERENT_WEBCONTENTS. </summary> </histogram> <histogram name="MerchantTrust.Message.DismissReason" - enum="MessageDismissReason" expires_after="M95"> + enum="MessageDismissReason" expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10093,17 +10544,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MerchantTrust.Message.DurationPrepared" units="ms" - expires_after="M95"> + expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> - Records the duration in milliseconds that the merchant trust message is in - the MessageDispatcher queue. Implemented for Android. + Records the duration in milliseconds from the merchant trust message being + prepared to it being shown or cleared. Implemented for Android. </summary> </histogram> <histogram name="MerchantTrust.Message.DurationShown" units="ms" - expires_after="M95"> + expires_after="M102"> <owner>ayman@chromium.org</owner> <owner>chrome-shopping@google.com</owner> <summary> @@ -10112,6 +10563,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="MerchantTrust.PageInfo.IsStoreInfoVisible" + enum="BooleanVisible" expires_after="M102"> + <owner>zhiyuancai@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Records whether the store info row is visible in page info. Recorded when + the page info is opened. Implemented for Android. + </summary> +</histogram> + <histogram name="Mist.SwitchResult" enum="MistSwitchResult" expires_after="M77"> <owner>akhouderchah@chromium.org</owner> <owner>benchan@chromium.org</owner> @@ -10367,7 +10828,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.Channel.Linux.SharedMemWriteBytes_Fail_NoSpace" - units="bytes" expires_after="2022-01-02"> + units="bytes" expires_after="2022-03-06"> <owner>bgeffon@chromium.org</owner> <owner>rockot@google.com</owner> <summary> @@ -10377,7 +10838,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.Channel.Linux.SharedMemWriteBytes_Fail_TooLarge" - units="bytes" expires_after="2022-01-02"> + units="bytes" expires_after="2022-03-06"> <owner>bgeffon@chromium.org</owner> <owner>rockot@google.com</owner> <summary> @@ -10395,7 +10856,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.Channel.WriteMessageLatency" units="ms" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>amistry@chromium.org</owner> <owner>bgeffon@chromium.org</owner> <owner>rockot@google.com</owner> @@ -10406,7 +10867,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.Channel.WriteMessageSize" units="bytes" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>amistry@chromium.org</owner> <owner>bgeffon@chromium.org</owner> <owner>rockot@google.com</owner> @@ -10424,7 +10885,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.Channel.WriteQueuePendingMessages" units="count" - expires_after="2021-11-07"> + expires_after="2022-04-24"> <owner>amistry@chromium.org</owner> <owner>bgeffon@chromium.org</owner> <owner>rockot@google.com</owner> @@ -10435,7 +10896,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.Channel.WritevBatchedMessages" units="messages" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>amistry@chromium.org</owner> <owner>bgeffon@chromium.org</owner> <owner>rockot@google.com</owner> @@ -10443,7 +10904,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.Connector.MaxUnreadMessageQuotaUsed" units="messages" - expires_after="2021-12-26"> + expires_after="2022-02-27"> <owner>siggi@chromium.org</owner> <owner>rockot@chromium.org</owner> <summary> @@ -10456,7 +10917,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Mojo.InvalidUTF8String" units="BooleanValid" - expires_after="2021-09-23"> + expires_after="2022-04-01"> <owner>rsesek@chromium.org</owner> <owner>chrome-mojo@google.com</owner> <summary> @@ -10547,7 +11008,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MPArch.ChildProcessLaunchFirst" units="units" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>ppi@chromium.org</owner> <summary> The time it takes to spawn the first child subprocess (including sandbox @@ -10556,7 +11017,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MPArch.ChildProcessLaunchSubsequent" units="units" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>ppi@chromium.org</owner> <summary> The time it takes to spawn child sub processes not counting the first one. @@ -10614,7 +11075,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="MultiProfile.UsersPerSessionIncremental" units="units" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>skuhne@chromium.org</owner> <summary> The number of users simultaneously signed into a multiprofile session on @@ -10636,7 +11097,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NativeFileSystemAPI.FileChooserResult" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>mek@chromium.org</owner> <owner>src/content/browser/file_system_access/OWNERS</owner> <summary> @@ -10646,7 +11107,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NativeFileSystemAPI.ReadPermissionRequestOutcome" - enum="NativeFileSystemPermissionRequestOutcome" expires_after="2021-12-05"> + enum="NativeFileSystemPermissionRequestOutcome" expires_after="2022-05-01"> <owner>mek@chromium.org</owner> <owner>src/content/browser/file_system_access/OWNERS</owner> <summary> @@ -10676,7 +11137,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NativeSmbFileShare.AuthenticationMethod" - enum="NativeSmbFileShare_AuthMethod" expires_after="M94"> + enum="NativeSmbFileShare_AuthMethod" expires_after="M102"> <owner>simmonsjosh@google.com</owner> <owner>src/chrome/browser/ash/smb_client/OWNERS</owner> <summary> @@ -10686,7 +11147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NativeSmbFileShare.GetSharesResult" - enum="NativeSmbFileShare_MountResult" expires_after="M94"> + enum="NativeSmbFileShare_MountResult" expires_after="M102"> <owner>simmonsjosh@google.com</owner> <owner>src/chrome/browser/ash/smb_client/OWNERS</owner> <summary> @@ -10695,8 +11156,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="NativeSmbFileShare.MountCount" units="units" - expires_after="M94"> +<histogram name="NativeSmbFileShare.MountCount" units="Active Mounts" + expires_after="M102"> <owner>simmonsjosh@google.com</owner> <owner>src/chrome/browser/ash/smb_client/OWNERS</owner> <summary> @@ -10706,7 +11167,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NativeSmbFileShare.MountResult" - enum="NativeSmbFileShare_MountResult" expires_after="M94"> + enum="NativeSmbFileShare_MountResult" expires_after="M102"> <owner>simmonsjosh@google.com</owner> <owner>src/chrome/browser/ash/smb_client/OWNERS</owner> <summary> @@ -10741,6 +11202,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="NativeSmbFileShare.RemountResult" enum="NativeSmbFileShare_MountResult" expires_after="M94"> + <obsolete> + Removed in M94. + </obsolete> <owner>simmonsjosh@google.com</owner> <owner>src/chrome/browser/ash/smb_client/OWNERS</owner> <summary> @@ -10757,7 +11221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NativeTheme.GetSystemColor.UsesColorProvider" enum="Boolean" - expires_after="2021-12-08"> + expires_after="2022-05-01"> <owner>pkasting@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary>Records if the color provider computed the color.</summary> @@ -10775,7 +11239,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NCN.NetworkOperatorMCCMNC" units="units" - expires_after="2021-11-14"> + expires_after="2021-10-27"> + <obsolete> + Deprecated in 10/2021 because the location permission protected API is + required to get this information and this isn't a must-have histogram. + </obsolete> <owner>tbansal@chromium.org</owner> <owner>bengr@google.com</owner> <summary> @@ -10786,14 +11254,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="net.HttpIdentSrcURL" units="requests" expires_after="M85"> - <owner>tsepez@chromium.org</owner> - <summary> - Count of requests which contained a basic auth username and password - embedded in the URL itself. - </summary> -</histogram> - <histogram name="Networks.RememberedShared" units="units" expires_after="2020-08-01"> <owner>stevenjb@chromium.org</owner> @@ -10882,7 +11342,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NQE.EffectiveConnectionType.OnECTComputation" - enum="NQEEffectiveConnectionType" expires_after="2021-12-19"> + enum="NQEEffectiveConnectionType" expires_after="2022-05-01"> <owner>tbansal@chromium.org</owner> <owner>src/net/nqe/OWNERS</owner> <summary> @@ -10961,7 +11421,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NQE.RTT.ObservationSource" enum="NQEObservationSource" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>tbansal@chromium.org</owner> <owner>bengr@chromium.org</owner> <summary> @@ -10995,7 +11455,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="NQE.TransportRTT.OnECTComputation" units="ms" - expires_after="2021-11-21"> + expires_after="2022-04-24"> <owner>bengr@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -11118,7 +11578,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="OffscreenCanvas.TextMetrics.SetFont2" units="microseconds" - expires_after="2022-01-31"> + expires_after="M93"> + <obsolete> + Retired in M94. + </obsolete> <owner>yiyix@chromium.org</owner> <owner>fserb@chromium.org</owner> <summary> @@ -11517,7 +11980,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaintHolding.CommitTrigger2" enum="PaintHoldingCommitTrigger2" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>schenney@chromium.org</owner> <owner>paint-dev@chromium.org</owner> <summary> @@ -11567,7 +12030,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PDF.Actions" enum="ChromePDFViewerActions" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>hnakashima@chromium.org</owner> <summary> Tracks user actions in the PDF viewer. Logged when the document is opened @@ -11579,7 +12042,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PDF.FormType" enum="PDFFormTypes" expires_after="2022-02-06"> +<histogram name="PDF.FormType" enum="PDFFormTypes" expires_after="2022-04-17"> <owner>rharrison@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary> @@ -11588,7 +12051,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PDF.HasAttachment" enum="Boolean" expires_after="2021-12-19"> +<histogram name="PDF.HasAttachment" enum="Boolean" expires_after="2022-04-17"> <owner>hnakashima@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary> @@ -11598,7 +12061,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PDF.IsTagged" enum="BooleanIsTagged" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>dmazzoni@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary> @@ -11607,7 +12070,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PDF.LinkHighlightOverlapsInPage" units="overlaps" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>thestig@chromium.org</owner> <owner>ankk@microsoft.com</owner> <owner>mohitb@microsoft.com</owner> @@ -11621,7 +12084,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PDF.LoadStatus" enum="ChromePDFViewerLoadStatus" - expires_after="2022-01-16"> + expires_after="2022-04-17"> <owner>kmoon@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary> @@ -11631,7 +12094,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PDF.PageCount" units="pages" expires_after="2022-01-16"> +<histogram name="PDF.PageCount" units="pages" expires_after="2022-04-10"> <owner>hnakashima@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary> @@ -11639,7 +12102,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PDF.Version" enum="PDFVersion" expires_after="2021-12-12"> +<histogram name="PDF.Version" enum="PDFVersion" expires_after="2022-04-10"> <owner>dhoss@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary>Tracks versions of documents opened in the PDF viewer.</summary> @@ -11654,7 +12117,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Pepper.InterfaceUsed" enum="PepperInterface" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>bbudge@chromium.org</owner> <owner>raymes@chromium.org</owner> <summary> @@ -11851,7 +12314,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PerformanceMonitor.AverageCPU2.{ProcessName}{UsageScenario}" units="hundredth of percent" expires_after="2022-01-30"> <owner>fdoray@chromium.org</owner> - <owner>sebmarchand@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Average CPU utilization of a process, read out at each two-minute interval. @@ -11896,9 +12358,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="PerformanceMonitor.EnergyImpact.{ProcessName}{UsageScenario}" - units="ScaledUnits" expires_after="2021-10-30"> - <owner>lgrey@chromium.org</owner> - <owner>markchang@chromium.org</owner> + units="ScaledUnits" expires_after="2022-10-30"> + <owner>olivierli@chromium.org</owner> + <owner>catan-team@chromium.org</owner> <summary> (Mac only) A synthetic power use estimate, as displayed in macOS Activity Monitor and the battery menu. This incorporates CPU utilization, idle @@ -11933,9 +12395,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PerformanceMonitor.IdleWakeups.{ProcessName}{UsageScenario}" - units="WakeupsPerSecond" expires_after="2021-10-30"> - <owner>lgrey@chromium.org</owner> - <owner>markchang@chromium.org</owner> + units="WakeupsPerSecond" expires_after="2022-10-30"> + <owner>olivierli@chromium.org</owner> + <owner>catan-team@chromium.org</owner> <summary> The average CPU idle wakeups per second, sampled every two minutes. @@ -11954,9 +12416,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PerformanceMonitor.PackageExitIdleWakeups.{ProcessName}{UsageScenario}" - units="WakeupsPerSecond" expires_after="2021-10-30"> - <owner>lgrey@chromium.org</owner> - <owner>markchang@chromium.org</owner> + units="WakeupsPerSecond" expires_after="2022-10-30"> + <owner>olivierli@chromium.org</owner> + <owner>catan-team@chromium.orgg</owner> <summary> (Mac only) The average package exit idle wakeups per second, sampled every two minutes. This is a subset of wakeups that indicate that the processor @@ -11976,26 +12438,44 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="UsageScenario" variants="UsageScenario"/> </histogram> -<histogram name="PerformanceMonitor.ResourceCoalition.BytesReadPerSecond" +<histogram name="PerformanceMonitor.ResourceCoalition.Availability" + enum="CoalitionIDAvailability" expires_after="2021-11-30"> + <owner>fdoray@chromium.org</owner> + <owner>catan-team@chromium.org</owner> + <summary> + Details about whether or not it's possible to get coalition resource usage + data on the system. Only on macOS, recorded once at startup. + </summary> +</histogram> + +<histogram + name="PerformanceMonitor.ResourceCoalition.BytesReadPerSecond{UsageScenario}" units="milliBytesPerSecond" expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The IO reads reported by the resource coalition mechanism on macOS. Reported every 2 minutes. The data is reported as the rate per second during this interval with a millibyte granularity. </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> </histogram> -<histogram name="PerformanceMonitor.ResourceCoalition.BytesWrittenPerSecond" +<histogram + name="PerformanceMonitor.ResourceCoalition.BytesWrittenPerSecond{UsageScenario}" units="milliBytesPerSecond" expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The IO writes reported by the resource coalition mechanism on macOS. Reported every 2 minutes. The data is reported as the rate per second during this interval with a millibyte granularity. </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> </histogram> <histogram name="PerformanceMonitor.ResourceCoalition.CPUTime" @@ -12015,9 +12495,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PerformanceMonitor.ResourceCoalition.CPUTime2" +<histogram name="PerformanceMonitor.ResourceCoalition.CPUTime2{UsageScenario}" units="hundredth of percent" expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Average CPU utilization reported by the resource coalition mechanism on @@ -12026,6 +12506,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. histogram is capped at 20000 (equivalent to 2 cores fully loaded). I.e. 4 cores busy at 25% each will read as 25 * 4 * 100 = 10000. </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> </histogram> <histogram name="PerformanceMonitor.ResourceCoalition.Energy" @@ -12042,6 +12525,28 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="PerformanceMonitor.ResourceCoalition.EnergyImpact{UsageScenario}" + units="centi-EnergyImpact" expires_after="2021-11-30"> + <owner>siggi@chromium.org</owner> + <owner>catan-team@chromium.org</owner> + <summary> + (Mac only) A synthetic power use estimate, as displayed in macOS Activity + Monitor and the battery menu. This incorporates CPU utilization, idle + wakeups, IO, and task QoS level using per-machine-model weights. Divide by + 100 to match Activity Monitor's scale. Recorded every two minutes, only + available on macs with an Intel CPU. + + This EnergyImpact score is computed from the usage reported by the resource + coalition mechanism on macOS. It accounts for the resource usage of all + Chrome processes no matter how short-lived, as well as XPC services running + on Chrome's behalf. + </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> +</histogram> + <histogram name="PerformanceMonitor.ResourceCoalition.GPUTime" units="hundredth of percent" expires_after="2021-11-30"> <obsolete> @@ -12058,9 +12563,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PerformanceMonitor.ResourceCoalition.GPUTime2" +<histogram name="PerformanceMonitor.ResourceCoalition.GPUTime2{UsageScenario}" units="hundredth of percent" expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Average GPU utilization reported by the resource coalition mechanism on @@ -12068,40 +12573,77 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. 0-100% range and is multiplied by 100. The histogram is capped at 10000 (equivalent to the GPU being used 100% of the time). </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> </histogram> <histogram - name="PerformanceMonitor.ResourceCoalition.InterruptWakeupsPerSecond" + name="PerformanceMonitor.ResourceCoalition.InterruptWakeupsPerSecond{UsageScenario}" units="milliWakeupsPerSecond" expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The interrupt wakeup rate reported by the resource coalition mechanism on macOS. Reported every 2 minutes. The data is reported as the rate per second during this interval with a milliwakeup granularity. </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> </histogram> <histogram - name="PerformanceMonitor.ResourceCoalition.PlatformIdleWakeupsPerSecond" + name="PerformanceMonitor.ResourceCoalition.PlatformIdleWakeupsPerSecond{UsageScenario}" units="milliWakeupsPerSecond" expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The platform idle wakeup rate reported by the resource coalition mechanism on macOS. Reported every 2 minutes. The data is reported as the rate per second during this interval with a milliwakeup granularity. </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> </histogram> -<histogram name="PerformanceMonitor.ResourceCoalition.Power" units="milliwatts" - expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> +<histogram name="PerformanceMonitor.ResourceCoalition.Power{UsageScenario}" + units="milliwatts" expires_after="2021-11-30"> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The power usage reported by the resource coalition mechanism on macOS. Reported every 2 minutes. Only available on devices with an ARM CPU. </summary> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> +</histogram> + +<histogram + name="PerformanceMonitor.ResourceCoalition.QoSLevel.{QoSLevel}{UsageScenario}" + units="hundredth of percent" expires_after="2021-11-30"> + <owner>fdoray@chromium.org</owner> + <owner>catan-team@chromium.org</owner> + <summary> + Average CPU time spent in a given QoS level, as reported by the resource + coalition mechanism on macOS. Read out at each two-minute interval. The + utilization is in the 0-100% range and is multiplied by 100. The histogram + is capped at 10000 (equivalent to the GPU being used 100% of the time). + </summary> + <token key="QoSLevel"> + <variant name="Background"/> + <variant name="Default"/> + <variant name="Legacy"/> + <variant name="Maintenance"/> + <variant name="UserInitiated"/> + <variant name="UserInteractive"/> + <variant name="Utility"/> + </token> +<!-- Usage scenario variant defined in tools/metrics/histograms/metadata/power/histograms.xml --> + + <token key="UsageScenario" variants="UsageScenario"/> </histogram> <histogram name="PeriodicBackgroundSync.Event.BatchSize" units="events" @@ -12126,7 +12668,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PeriodicBackgroundSync.Event.Time" units="ms" - expires_after="2021-10-04"> + expires_after="2022-09-04"> <owner>nator@chromium.org</owner> <owner>rayankans@chromium.org</owner> <summary> @@ -12136,19 +12678,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram base="true" name="PhoneHub.MultiDeviceFeatureState" - enum="MultiDevice_FeatureState" expires_after="2022-02-06"> -<!-- Name completed by histogram_suffixes name="PhoneHubFeature" --> - - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> - <summary> - Indicates the feature state of Phone Hub features. This metric is emitted to - at the creation of the user session (when the user logs in), and when - feature state updates occur. - </summary> -</histogram> - <histogram name="PictureInPictureWindow.ButtonPressed" enum="OverlayWindowControl" expires_after="M85"> <owner>fbeaufort@chromium.org</owner> @@ -12316,9 +12845,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PLT.iOS.RendererInitiatedPageLoadTime2" units="ms" - expires_after="2022-08-09"> + expires_after="never"> +<!-- expires-never: guiding metric (internal: go/chrome-browser-guiding-metrics) --> + <owner>djean@chromium.org</owner> <owner>ajuma@chromium.org</owner> + <owner>chrome-analysis-team@google.com</owner> <summary> Page load time for Renderer-initiated navigations. @@ -12359,6 +12891,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. Chromium changes, this metric can move due to exogenous factors such as changes in what type of web page people are looking at or changes in the implementation of popular websites. + + Do not modify this metric in any way without contacting + chrome-analysis-team@google.com. </summary> </histogram> @@ -12475,7 +13010,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchedSignedExchangeCache.BodySize" units="bytes" - expires_after="M99"> + expires_after="2022-04-24"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -12486,7 +13021,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchedSignedExchangeCache.BodySizeTotal" units="bytes" - expires_after="M99"> + expires_after="2022-05-01"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -12498,7 +13033,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchedSignedExchangeCache.Count" units="count" - expires_after="M99"> + expires_after="2022-05-01"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -12510,7 +13045,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchedSignedExchangeCache.HeadersSizeTotal" units="bytes" - expires_after="M99"> + expires_after="2022-05-01"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -12539,151 +13074,6 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Prerender.FinalStatus" enum="PrerenderFinalStatus" - expires_after="2021-10-31"> - <owner>ryansturm@chromium.org</owner> - <owner>tbansal@chromium.org</owner> - <summary> - Final status for prerender pages - either success, or why it was canceled. - </summary> -</histogram> - -<histogram name="Prerender.NetworkBytesTotalForProfile" units="bytes" - expires_after="M77"> - <owner>hajimehoshi@chromium.org</owner> - <owner>jkarlin@chromium.org</owner> - <owner>kouhei@chromium.org</owner> - <summary> - Number of bytes transferred on the network for URLRequests (not including - HTTP/TLS/TCP/IP overhead). Reported on event of a PrerenderContents - deletion. Includes prerender bytes. Bytes are only counted when prerendering - is enabled and not in a control group. The sum of the distribution for a - single user represents all of that user's network transfers for resource for - that time period while prerendering was enabled. - </summary> -</histogram> - -<histogram name="Prerender.NetworkBytesWasted" units="bytes" - expires_after="M77"> - <owner>hajimehoshi@chromium.org</owner> - <owner>jkarlin@chromium.org</owner> - <owner>kouhei@chromium.org</owner> - <summary> - Number of bytes transferred on the network for URLRequests (not including - HTTP/TLS/TCP/IP overhead) for a prerender that was not used. All - nostate-prefetch bytes are currently counted as wasted because it is hard to - track byte use in HTTP cache. - </summary> -</histogram> - -<histogram name="Prerender.NoStatePrefetchMainResourceRedirects" - units="redirects" expires_after="M85"> - <owner>droger@chromium.org</owner> - <owner>mattcary@chromium.org</owner> - <owner>pasko@chromium.org</owner> - <summary> - Length of the redirect chain for main resources loaded by NoStatePrefetch. - Recorded when the final response in the chain is received. - </summary> -</histogram> - -<histogram name="Prerender.NoStatePrefetchRendererLifetimeExtension" units="ms" - expires_after="M77"> - <owner>jam@chromium.org</owner> - <summary> - Time a prefetch renderer is kept alive after parsing to wait for - subresources to finish loading. - </summary> -</histogram> - -<histogram name="Prerender.NoStatePrefetchRendererParseTime" units="ms" - expires_after="M81"> - <owner>jam@chromium.org</owner> - <summary> - Time between prefetch renderer startup and when parsing is complete. - </summary> -</histogram> - -<histogram name="Prerender.NoStatePrefetchResponseTypes" - enum="NoStatePrefetchResponseType" expires_after="M85"> - <owner>droger@chromium.org</owner> - <owner>mattcary@chromium.org</owner> - <owner>pasko@chromium.org</owner> - <summary> - Type of responses received by NoStatePrefetch, distinguishing cacheable - resources from no-store resources, and main resources from sub-resources. - Recorded when a response is received, including on each redirect. - </summary> -</histogram> - -<histogram name="Prerender.NoStatePrefetchSubResourceRedirects" - units="redirects" expires_after="M85"> - <owner>droger@chromium.org</owner> - <owner>mattcary@chromium.org</owner> - <owner>pasko@chromium.org</owner> - <summary> - Length of the redirect chain for sub-resources loaded by NoStatePrefetch. - Recorded when the final response in the chain is received. - </summary> -</histogram> - -<histogram name="Prerender.PrerenderLoadComplete" units="BooleanSuccess" - expires_after="2022-03-30"> - <owner>gambard@chromium.org</owner> - <owner>justincohen@chromium.org</owner> - <summary> - Whether the load was completed when the pre-render was used. If the - prerender is cancelled, this is not logged. Only on iOS. - </summary> -</histogram> - -<histogram name="Prerender.PrerenderLoadedOnFirstNTP" enum="Boolean" - expires_after="M81"> - <owner>justincohen@chromium.org</owner> - <summary> - Whether or not a successful prerender happens on a NTP with no history. - </summary> -</histogram> - -<histogram name="Prerender.PrerenderLoadedOnIndex" units="units" - expires_after="M81"> - <owner>justincohen@chromium.org</owner> - <summary> - The last comitted index before a successful preload is committed. Recorded - only on iOS. - </summary> -</histogram> - -<histogram name="Prerender.PrerendersPerSessionCount" units="units" - expires_after="2021-04-22"> - <owner>ryansturm@chromium.org</owner> - <owner>tbansal@chromium.org</owner> - <summary> - The number of sessions that have at least X successful prerenders. Recorded - only on iOS since 2017-09. - </summary> -</histogram> - -<histogram name="Prerender.PrerenderTimeSaved" units="ms" - expires_after="2022-03-30"> - <owner>gambard@chromium.org</owner> - <owner>justincohen@chromium.org</owner> - <summary> - This is the time from when a prerendered page begins to load to when it is - swapped in as the main page load or to when the pre-loaded page is fully - loaded, whichever came first. Recorded when the swap occurs, only on iOS. - </summary> -</histogram> - -<histogram name="Prerender.TabContentsDeleterTimeout" - enum="BooleanCloseTimeout" expires_after="M85"> - <owner>pasko@chromium.org</owner> - <summary> - A boolean that indicates how often we fail to delete an old prerendered tab - before the timeout. - </summary> -</histogram> - <histogram name="Previews.CacheControlNoTransform.BlockedPreview" enum="PreviewsType" expires_after="2021-08-09"> <obsolete> @@ -12922,7 +13312,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Privacy.AccuracyTip.AccuracyTipInteraction" - enum="AccuracyTipInteraction" expires_after="M96"> + enum="AccuracyTipInteraction" expires_after="2022-04-17"> <owner>dullweber@chromium.org</owner> <owner>eokoyomon@chromium.org</owner> <summary> @@ -12932,7 +13322,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Privacy.AccuracyTip.AccuracyTipTimeOpen" units="ms" - expires_after="M96"> + expires_after="M98"> <owner>dullweber@chromium.org</owner> <owner>eokoyomon@chromium.org</owner> <summary> @@ -12942,7 +13332,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Privacy.AccuracyTip.NumDialogsShown" units="dialogs" - expires_after="M96"> + expires_after="2022-04-24"> <owner>dullweber@chromium.org</owner> <owner>eokoyomon@chromium.org</owner> <summary> @@ -12952,12 +13342,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Privacy.AccuracyTip.PageStatus" enum="AccuracyTipStatus" - expires_after="M96"> + expires_after="2022-04-03"> <owner>dullweber@chromium.org</owner> <owner>eokoyomon@chromium.org</owner> <summary>The accuracy status of a page. Recorded on each page load.</summary> </histogram> +<histogram name="Privacy.ClearOnExitSyncEvent" enum="ClearOnExitSyncEvent" + expires_after="M100"> + <owner>sauski@google.com</owner> + <owner>chrome-friendly-settings@google.com</owner> + <summary> + Interactions between sync and the cookies clear on exit setting. Only + recorded when the user has cookies clear on exit enabled. + </summary> +</histogram> + <histogram name="Privacy.ConsentAuditor.ConsentGiven.Feature" enum="ConsentAuditorFeature" expires_after="M85"> <owner>markusheintz@google.com</owner> @@ -13003,7 +13403,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Privacy.ThirdPartyCookieBlockingEnabledForSite" enum="Boolean" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>dullweber@chromium.org</owner> <owner>huanzhong@chromium.org</owner> <summary> @@ -13028,8 +13428,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="PrivacySandbox.AggregationService.ReportStatus" + enum="PrivacySandboxAggregationServiceReportStatus" + expires_after="2022-01-16"> + <owner>alexmt@chromium.org</owner> + <owner>linnan@chromium.org</owner> + <summary> + Records the high level request status of each aggregatable report. These + reports are requested by APIs that rely on private, secure aggregation (e.g. + Attribution Reporting API). + + Recorded for every aggregatable report sent. It might retry in case of + failure but only the final status will be counted for each report. + </summary> +</histogram> + +<histogram name="PrivacySandbox.AggregationService.Storage.Sql.InitStatus" + enum="PrivacySandboxAggregationServiceStorageSqlInitStatus" + expires_after="2022-01-16"> + <owner>alexmt@chromium.org</owner> + <owner>linnan@chromium.org</owner> + <summary> + Records initialization statuses of AggregationServiceStorageSql. Note: + currently AggregationServiceStorageSql is initialized lazily. + </summary> +</histogram> + <histogram name="Process.Sandbox.Launch.Error" enum="WinGetLastError" - expires_after="2021-10-04"> + expires_after="never"> +<!-- expires-never: metric needed for diagnosing sandbox issues. --> + <owner>forshaw@chromium.org</owner> <owner>wfh@chromium.org</owner> <summary> @@ -13100,7 +13528,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProtoDB.InitStatus" enum="LevelDBStatus" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>nyquist@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary>The LevelDB Status from a ProtoDatabase Init call.</summary> @@ -13130,7 +13558,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProtoDB.SharedDbInitStatus" enum="ProtoDatabaseInitState" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>ssid@chromium.org</owner> <owner>salg@chromium.org</owner> <summary> @@ -13221,7 +13649,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.CheckOriginForAbuseTime" units="ms" - expires_after="M98"> + expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -13232,7 +13660,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.DeliverQueuedMessageTime" units="ms" - expires_after="M98"> + expires_after="2022-04-17"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -13244,7 +13672,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.DeliveryStatus" enum="PushEventStatus" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13276,7 +13704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.GetRegistrationStatus" - enum="PushGetRegistrationStatus" expires_after="2022-01-02"> + enum="PushGetRegistrationStatus" expires_after="2022-04-24"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13287,7 +13715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.MessageHandledTime" units="ms" - expires_after="M98"> + expires_after="2022-04-24"> <owner>knollr@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -13323,7 +13751,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.RegistrationStatus" - enum="PushRegistrationStatus" expires_after="2022-01-02"> + enum="PushRegistrationStatus" expires_after="2022-04-17"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13363,7 +13791,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.UnregistrationGCMResult" enum="GCMClientResult" - expires_after="M98"> + expires_after="2022-04-24"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13374,7 +13802,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.UnregistrationIIDResult" enum="InstanceIDResult" - expires_after="M98"> + expires_after="2022-04-24"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13385,7 +13813,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.UnregistrationReason" - enum="PushUnregistrationReason" expires_after="M98"> + enum="PushUnregistrationReason" expires_after="2022-04-24"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13395,7 +13823,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.UnregistrationStatus" - enum="PushUnregistrationStatus" expires_after="M98"> + enum="PushUnregistrationStatus" expires_after="2022-05-01"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13405,7 +13833,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PushMessaging.UserVisibleStatus" enum="PushUserVisibleStatus" - expires_after="M98"> + expires_after="2022-04-17"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -13489,7 +13917,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ReadingList.BookmarkBarState.On{Frequency}AddToReadingList" - enum="BookmarkBarState" expires_after="M96"> + enum="BookmarkBarState" expires_after="2022-02-20"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -13571,6 +13999,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>Number of read entries in reading list.</summary> </histogram> +<histogram name="ReadingList.SyncStateMatchesBookmarks" enum="BooleanMatched" + expires_after="2022-02-20"> + <owner>corising@chromium.org</owner> + <owner>chrome-desktop-ui-sea@google.com</owner> + <summary> + Records whether the reading list and bookmarks sync states match on startup + when not in Incognito or guest mode (Desktop only). + </summary> +</histogram> + <histogram name="ReadingList.Unread.AgeOnDeletion" units="hours" expires_after="2022-03-15"> <owner>gambard@chromium.org</owner> @@ -13588,7 +14026,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ReadingList.WebUI.InitialEntriesRenderTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -13599,7 +14037,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ReadingList.WebUI.LoadCompletedTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -13610,7 +14048,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ReadingList.WebUI.LoadDocumentTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -13635,7 +14073,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ReadingList.WindowDisplayedDuration" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -13647,7 +14085,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ReadingList.{ReadStatus}.Count.{Variation}" units="count" - expires_after="M96"> + expires_after="2022-02-20"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -13822,7 +14260,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="RenderViewContextMenu.Shown" enum="RenderViewContextMenuItem" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>avi@chromium.org</owner> <owner>edwardjung@chromium.org</owner> <owner>mpearson@chromium.org</owner> @@ -14320,7 +14758,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SB2.RemoteCall.CanCheckUrl" enum="BooleanCanCheckUrl" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14349,7 +14787,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="SB2.RemoteCall.Elapsed" units="ms" expires_after="2022-01-09"> +<histogram name="SB2.RemoteCall.Elapsed" units="ms" expires_after="2022-03-13"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14378,7 +14816,7 @@ Safe Browsing lookups, which is critical for security. --> </histogram> <histogram name="SB2.RemoteCall.Result" enum="SB2RemoteCallResult" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14419,7 +14857,7 @@ Safe Browsing lookups, which is critical for security. --> </histogram> <histogram base="true" name="SB2.RequestDestination" enum="RequestDestination" - expires_after="2022-01-11"> + expires_after="2022-04-17"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14588,7 +15026,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SBIRS.UploadResult" enum="ReportProcessingResult" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>caitkp@google.com</owner> <summary> The result of an attempted report upload by the safe browsing incident @@ -14629,7 +15067,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SBMultipartUploader.FailedUploadDuration" units="s" - expires_after="M95"> + expires_after="2022-09-29"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14643,7 +15081,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SBMultipartUploader.NetworkRequestResponseCodeOrError" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="M95"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-09-29"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14658,7 +15096,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SBMultipartUploader.RetriesNeeded" units="retries" - expires_after="M95"> + expires_after="2022-09-29"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14671,7 +15109,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SBMultipartUploader.SuccessfulUploadDuration" units="s" - expires_after="M95"> + expires_after="2022-09-29"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14684,7 +15122,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SBMultipartUploader.UploadSize" units="bytes" - expires_after="M95"> + expires_after="2022-09-29"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14698,7 +15136,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SBMultipartUploader.UploadSuccess" enum="BooleanSuccess" - expires_after="M95"> + expires_after="2022-09-29"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -14808,7 +15246,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Servicification.Startup3" enum="ServicificationStartupMode" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>hanxi@chromium.org</owner> <owner>yfriedman@chromium.org</owner> <owner>hnakashima@chromium.org</owner> @@ -15108,7 +15546,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SignedExchange.LoadResult2" enum="SignedExchangeLoadResult" - expires_after="M99"> + expires_after="2022-04-03"> <owner>ksakamoto@chromium.org</owner> <owner>kinuko@chromium.org</owner> <owner>horo@chromium.org</owner> @@ -15296,7 +15734,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteEngagementService.EngagementScore" units="units" - expires_after="2021-09-12"> + expires_after="2022-03-12"> <owner>calamity@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary> @@ -15307,7 +15745,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteEngagementService.EngagementScoreBucket" units="%" - expires_after="2021-08-22"> + expires_after="2022-03-12"> <owner>calamity@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary> @@ -15318,7 +15756,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteEngagementService.EngagementType" - enum="SiteEngagementServiceEngagementType" expires_after="2022-01-16"> + enum="SiteEngagementServiceEngagementType" expires_after="2022-03-20"> <owner>calamity@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary> @@ -15328,7 +15766,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteEngagementService.MeanEngagement" units="units" - expires_after="2021-08-22"> + expires_after="2022-03-12"> <owner>calamity@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary> @@ -15339,7 +15777,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteEngagementService.MedianEngagement" units="units" - expires_after="2021-09-12"> + expires_after="2022-03-12"> <owner>calamity@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary> @@ -15350,7 +15788,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteEngagementService.OriginsEngaged" units="units" - expires_after="2022-01-23"> + expires_after="2022-03-12"> <owner>calamity@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary> @@ -15387,7 +15825,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteEngagementService.TotalEngagement" units="units" - expires_after="2022-01-16"> + expires_after="2022-03-12"> <owner>calamity@chromium.org</owner> <owner>dominickn@chromium.org</owner> <summary> @@ -15398,7 +15836,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolatedCodeCache.JS.Behaviour" - enum="SiteIsolatedCodeCacheJSBehaviour" expires_after="2022-01-16"> + enum="SiteIsolatedCodeCacheJSBehaviour" expires_after="2022-03-20"> <owner>mythria@chromium.org</owner> <owner>v8-team@google.com</owner> <summary> @@ -15430,7 +15868,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.BrowsingInstanceCount" units="units" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <summary> @@ -15543,7 +15981,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.IsPasswordFormSubmittedInDedicatedProcess" - enum="SiteIsolationIsDedicatedProcess" expires_after="2021-12-05"> + enum="SiteIsolationIsDedicatedProcess" expires_after="2022-04-03"> <owner>alexmos@chromium.org</owner> <owner>lukasza@chromium.org</owner> <summary> @@ -15596,7 +16034,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.OutOfProcessIframes" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -15617,7 +16055,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.ProxyCountPerBrowsingInstance" units="units" - expires_after="2021-09-30"> + expires_after="2022-08-18"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -15640,7 +16078,7 @@ should be kept until we remove incident reporting. --> <histogram name="SiteIsolation.ReusePendingOrCommittedSite.TimeSinceReusableProcessDestroyed" - units="ms" expires_after="2022-01-09"> + units="ms" expires_after="2022-04-10"> <owner>jessemckenna@google.com</owner> <owner>olivierli@chromium.org</owner> <summary> @@ -15653,7 +16091,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.SavedOAuthSites.Size" units="origins" - expires_after="2021-11-30"> + expires_after="2022-04-03"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -15665,7 +16103,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.SavedUserTriggeredIsolatedOrigins.Size" - units="origins" expires_after="2022-01-30"> + units="origins" expires_after="2022-04-03"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -15678,7 +16116,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.SavedWebTriggeredIsolatedOrigins.Size" - units="origins" expires_after="2021-11-30"> + units="origins" expires_after="2022-04-03"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -15691,7 +16129,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SiteIsolation.SiteInstancesPerBrowsingInstance" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>alexmos@chromium.org</owner> <owner>creis@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -15869,7 +16307,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SpellCheck.SpellingService.Enabled" enum="BooleanEnabled" - expires_after="2021-10-10"> + expires_after="2022-04-17"> <owner>groby@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -15880,7 +16318,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SpellCheck.SpellingService.RequestDuration" units="ms" - expires_after="2022-01-16"> + expires_after="2022-04-24"> <owner>yyushkina@google.com</owner> <owner>gujen@google.com</owner> <owner>chrome-language@google.com</owner> @@ -15900,7 +16338,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SpellCheck.SpellingService.RequestResultType" - enum="ServiceRequestResultType" expires_after="2021-11-07"> + enum="ServiceRequestResultType" expires_after="2022-05-01"> <owner>yyushkina@google.com</owner> <owner>gujen@google.com</owner> <owner>chrome-language@google.com</owner> @@ -15912,7 +16350,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SpellCheck.SuggestionHitRatio" units="%" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>gujen@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -15921,7 +16359,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram base="true" name="Spellcheck.Windows.ChromeLocalesSupport" - units="locales" expires_after="2021-12-12"> + units="locales" expires_after="2022-04-24"> <owner>gujen@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -15941,7 +16379,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram base="true" name="Spellcheck.Windows.SpellcheckLocalesSupport" - units="locales" expires_after="2021-12-12"> + units="locales" expires_after="2022-04-24"> <owner>gujen@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -15957,7 +16395,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram base="true" name="Spellcheck.Windows.SpellcheckRequestDuration" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-05-01"> <owner>gujen@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -15971,7 +16409,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram base="true" name="Spellcheck.Windows.SuggestionGatheringDuration" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-02-20"> <owner>gujen@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -16300,7 +16738,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Style.InvalidationTime" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>futhark@chromium.org</owner> <summary> Microseconds spent in StyleEngine::InvalidateStyle. Only samples from high @@ -16309,7 +16747,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Style.RebuildLayoutTreeTime" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>futhark@chromium.org</owner> <summary> Microseconds spent in RebuildLayoutTree called from Document::UpdateStyle. @@ -16317,7 +16755,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Style.RecalcTime" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>futhark@chromium.org</owner> <summary> Microseconds spent in RecalcStyle called from Document::UpdateStyle. @@ -16325,7 +16763,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SubresourceWebBundles.BundleFetchErrorCode" - enum="NetErrorCodes" expires_after="M99"> + enum="NetErrorCodes" expires_after="2022-04-10"> <owner>ksakamoto@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -16335,7 +16773,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SubresourceWebBundles.ContentLength" units="bytes" - expires_after="M99"> + expires_after="2022-04-03"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -16345,14 +16783,14 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SubresourceWebBundles.LoadResult" - enum="SubresourceWebBundleLoadResult" expires_after="M99"> + enum="SubresourceWebBundleLoadResult" expires_after="2022-04-03"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary>The result of loading subresource web bundles.</summary> </histogram> <histogram name="SubresourceWebBundles.MaxMemoryUsagePerProcess" units="bytes" - expires_after="M99"> + expires_after="2022-04-03"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -16363,7 +16801,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SubresourceWebBundles.ReceivedSize" units="bytes" - expires_after="M99"> + expires_after="2022-04-03"> <owner>horo@chromium.org</owner> <owner>webpackage-dev@chromium.org</owner> <summary> @@ -16438,7 +16876,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SupervisedUsers.ExtensionInstallDialog" - enum="SupervisedUserExtensionInstallDialog" expires_after="2022-01-09"> + enum="SupervisedUserExtensionInstallDialog" expires_after="2022-05-01"> <owner>tobyhuang@chromium.org</owner> <owner>agawronska@chromium.org</owner> <owner>danan@chromium.org</owner> @@ -16500,7 +16938,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SupervisedUsers.ExtensionsMayRequestPermissions" - enum="BooleanEnabled" expires_after="2021-11-14"> + enum="BooleanEnabled" expires_after="2022-03-20"> <owner>tobyhuang@chromium.org</owner> <owner>cros-families@google.com</owner> <summary> @@ -16585,7 +17023,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SupervisedUsers.PerAppTimeLimits.AppsWithTimeLimit" - units="Apps" expires_after="2021-11-21"> + units="Apps" expires_after="2022-04-24"> <owner>agawronska@chromium.org</owner> <owner>yilkal@chromium.org</owner> <owner>cros-families@google.com</owner> @@ -16607,7 +17045,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="SupervisedUsers.PerAppTimeLimits.Engagement" units="Apps" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>agawronska@chromium.org</owner> <owner>yilkal@chromium.org</owner> <owner>cros-families@google.com</owner> @@ -16630,7 +17068,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Supervision.ParentAccessCode.Action" - enum="ParentAccessCodeAction" expires_after="2021-12-19"> + enum="ParentAccessCodeAction" expires_after="2022-02-20"> <owner>agawronska@chromium.org</owner> <owner>cros-families-eng@google.com</owner> <summary> @@ -16640,7 +17078,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Supervision.ParentAccessCode.Usage" - enum="ParentAccessCodeUsage" expires_after="2021-12-19"> + enum="ParentAccessCodeUsage" expires_after="2022-02-20"> <owner>agawronska@chromium.org</owner> <owner>cros-families-eng@google.com</owner> <summary> @@ -16779,7 +17217,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Tablet.AppWindowDrag.CountOfPerUserSession" units="times" - expires_after="2021-12-01"> + expires_after="2022-05-01"> <owner>minch@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -16790,7 +17228,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Tablet.AppWindowDrag.InSplitView.CountOfPerUserSession" - units="times" expires_after="2022-01-30"> + units="times" expires_after="2022-05-01"> <owner>minch@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -16811,7 +17249,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Tablet.TabDrag.CountOfPerUserSession" units="times" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>minch@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -16832,7 +17270,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="Tablet.TabDrag.InSplitView.CountOfPerUserSession" - units="times" expires_after="2022-02-06"> + units="times" expires_after="2022-05-01"> <owner>minch@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary> @@ -16884,7 +17322,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="TextFragmentAnchor.ElementIdFragmentFound" enum="Boolean" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>nburris@chromium.org</owner> <owner>bokan@chromium.org</owner> <summary> @@ -16895,7 +17333,7 @@ should be kept until we remove incident reporting. --> </histogram> <histogram name="TextFragmentAnchor.LinkOpenSource" - enum="TextFragmentLinkOpenSource" expires_after="2021-12-31"> + enum="TextFragmentLinkOpenSource" expires_after="2022-04-03"> <owner>gayane@chromium.org</owner> <owner>chrome-shared-highlighting@google.com</owner> <summary> @@ -17410,6 +17848,9 @@ should be kept until we remove incident reporting. --> <histogram name="TileManager.ExceededMemoryBudget" enum="TileMemoryBudget" expires_after="2021-10-25"> + <obsolete> + Removed Sept 2021 due to lack of use. + </obsolete> <owner>pdr@chromium.org</owner> <owner>vmpstr@chromium.org</owner> <summary> @@ -17558,7 +17999,7 @@ should be kept until we use this API. --> </histogram> <histogram name="TouchBar.Default.Metrics" enum="DefaultTouchBarActions" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>ellyjones@chromium.org</owner> <owner>chrome-mac-dev@google.com</owner> <summary>Tracks the usage of the default touch bar buttons.</summary> @@ -17734,7 +18175,7 @@ should be kept until we use this API. --> </histogram> <histogram name="Tracing.Background.FinalizationDisallowedReason" - enum="TracingFinalizationDisallowedReason" expires_after="2021-12-12"> + enum="TracingFinalizationDisallowedReason" expires_after="2022-04-03"> <owner>ssid@chromium.org</owner> <summary> Reason why background tracing finalization was not allowed. Also see @@ -17744,7 +18185,7 @@ should be kept until we use this API. --> </histogram> <histogram name="Tracing.Background.FinalizingTraceSizeInKB" units="KB" - expires_after="2021-12-05"> + expires_after="2022-04-10"> <owner>oysteine@chromium.org</owner> <summary> The size, in kilobytes, of a finalized trace ready to be uploaded. @@ -17770,7 +18211,7 @@ should be kept until we use this API. --> </histogram> <histogram name="Tracing.Background.ScenarioState" - enum="BackgroundTracingState" expires_after="2021-12-19"> + enum="BackgroundTracingState" expires_after="2022-04-03"> <owner>oysteine@chromium.org</owner> <summary> Records state of the Background Tracing system, from when scenarios are @@ -17789,7 +18230,7 @@ should be kept until we use this API. --> </histogram> <histogram name="Tracing.SharedBufferIsValid" enum="BooleanSuccess" - expires_after="2021-09-19"> + expires_after="2022-09-19"> <owner>eseckler@chromium.org</owner> <owner>tracing@chromium.org</owner> <summary> @@ -17798,6 +18239,15 @@ should be kept until we use this API. --> </summary> </histogram> +<histogram name="Tracing.ViewHierarchyDump.DumpDuration" units="ms" + expires_after="2022-07-01"> + <owner>khokhlov@google.com</owner> + <owner>tracing@chromium.org</owner> + <summary> + Records the time it takes to dump a full view hierarchy into the trace. + </summary> +</histogram> + <histogram name="TrustedWebActivity.ClearDataDialogOnClearAppDataAccepted" enum="Boolean" expires_after="M98"> <owner>peconn@chromium.org</owner> @@ -17830,7 +18280,7 @@ should be kept until we use this API. --> </histogram> <histogram name="TrustedWebActivity.LocationDelegationEnrolled" enum="Boolean" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>eirage@chromium.org</owner> <owner>peconn@chromium.org</owner> <summary> @@ -17905,7 +18355,7 @@ should be kept until we use this API. --> </histogram> <histogram name="TrustedWebActivity.SplashScreenShown" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>peconn@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -17934,7 +18384,7 @@ should be kept until we use this API. --> </summary> </histogram> -<histogram name="UI.DeviceScale" units="%" expires_after="2021-12-12"> +<histogram name="UI.DeviceScale" units="%" expires_after="2022-05-01"> <owner>bsep@chromium.org</owner> <summary> The device scales available on the system at startup. A system may report @@ -18044,7 +18494,7 @@ should be kept until we use this API. --> </histogram> <histogram name="UpgradeDetector.RollbackReason" - enum="UpgradeDetectorRollbackReason" expires_after="M100"> + enum="UpgradeDetectorRollbackReason" expires_after="2022-05-01"> <owner>mpolzer@google.com</owner> <owner>managed-platforms@google.com</owner> <summary> @@ -18060,13 +18510,17 @@ should be kept until we use this API. --> </histogram> <histogram name="Uptime.ChromeExecToLoginPromptVisibleAfterLogout" units="ms" - expires_after="M77"> - <owner>hajimehoshi@chromium.org</owner> - <owner>kouhei@chromium.org</owner> + expires_after="2022-09-13"> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@google.com</owner> + <owner>xiyuan@chromium.org</owner> <summary> Measures the time elapsed on Chrome OS between when Chrome is started, and when the login prompt is again visible after a logout. This statistic is only collected when preceeded by a logout. + + Warning: this histogram was expired from M77 to M96 some data may be + missing. </summary> </histogram> @@ -18079,56 +18533,125 @@ should be kept until we use this API. --> </summary> </histogram> +<histogram name="Uptime.LoginPromptSetupTimeAfterLogout" units="ms" + expires_after="2022-09-13"> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@google.com</owner> + <owner>xiyuan@chromium.org</owner> + <summary> + Measures the time elapsed on Chrome OS for setting up for a login after a + logout. More specifically, it is the time between when the Cryptohome is + unmounted (the last step in the logout process) and when the login prompt is + again visible after a logout. + + Warning: this histogram was expired from M85 to M96 some data may be + missing. + </summary> +</histogram> + +<histogram name="Uptime.Logout" units="ms" expires_after="2022-09-13"> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@google.com</owner> + <owner>xiyuan@chromium.org</owner> + <summary> + Measures the time elapsed on Chrome OS when performing a logout. More + specifically, it is the time between when a logout is initiated and when the + Cryptohome is unmounted, signaling the last step in the logout process. This + statistic is not collected when the logout is part of a restart or shutdown. + + Warning: this histogram was expired from 09/2020 to M96 some data may be + missing. + </summary> +</histogram> + <histogram name="Uptime.LogoutToLoginPromptVisible" units="ms" - expires_after="M77"> - <owner>hajimehoshi@chromium.org</owner> - <owner>kouhei@chromium.org</owner> + expires_after="2022-09-13"> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@google.com</owner> + <owner>xiyuan@chromium.org</owner> <summary> Measures the time elapsed on Chrome OS between initiating a logout and the next time the login prompt is visible again. This statistic is not collected if the machine is shutdown between the logout initiation and the prompt becoming visible. + + Warning: this histogram was expired from M77 to M96 some data may be + missing. </summary> </histogram> <histogram name="Uptime.LogoutToUIStopAfterLogout" units="ms" - expires_after="M77"> - <owner>hajimehoshi@chromium.org</owner> - <owner>kouhei@chromium.org</owner> + expires_after="2022-09-13"> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@google.com</owner> + <owner>xiyuan@chromium.org</owner> <summary> Measures the time elapsed on Chrome OS between when a logout is initiated and the UI has stopped (and Chrome has exited) during the logout process. This statistic is not collected if the logout is part of a restart or shutdown. + + Warning: this histogram was expired from M77 to M96 some data may be + missing. </summary> </histogram> <histogram name="Uptime.OtherProcessesTerminatedToChromeExecAfterLogout" - units="ms" expires_after="M77"> - <owner>hajimehoshi@chromium.org</owner> - <owner>kouhei@chromium.org</owner> + units="ms" expires_after="2022-09-13"> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@google.com</owner> + <owner>xiyuan@chromium.org</owner> <summary> Measures the time elapsed on Chrome OS between when all user-associated processes have been terminated during the logout process and when Chrome is - started again to show the login screen. Since at least ChromeOS M62, - equivalent to Uptime.XTerminatedToChromeExecAfterLogout. + started again to show the login screen. + + Warning: this histogram was expired from M77 to M96 some data may be + missing. </summary> </histogram> <histogram name="Uptime.UIStopToProcessesTerminatedAfterLogout" units="ms" - expires_after="M77"> - <owner>hajimehoshi@chromium.org</owner> - <owner>kouhei@chromium.org</owner> + expires_after="2022-09-13"> + <owner>alemate@chromium.org</owner> + <owner>cros-oac@google.com</owner> + <owner>xiyuan@chromium.org</owner> <summary> Measures the time elapsed on Chrome OS between when the UI has stopped (Chrome has exited), and when all other associated processes have been terminated during the logout process. This statistic is not collected if the logout is part of a restart or shutdown. + + Warning: this histogram was expired from M77 to M96 some data may be + missing. + </summary> +</histogram> + +<histogram name="URL.Host.DidEscape" enum="BooleanEscaped" + expires_after="2022-09-09"> + <owner>wanderview@chromium.org</owner> + <owner>dcheng@chromium.org</owner> + <summary> + Measures whether DoSimpleHost() in url_canon_host.cc escaped any characters + in the ASCII table. This is recorded every time a URL hostname is + successfully parsed. + </summary> +</histogram> + +<histogram name="URL.Host.EscapeChar" enum="URLHostEscapedChar" + expires_after="2022-09-09"> + <owner>wanderview@chromium.org</owner> + <owner>dcheng@chromium.org</owner> + <summary> + This histogram records which ASCII characters are escaped in DoSimpleHost(). + Each escaped character is recorded separately, but only once for any + invocation of DoSimpleHost(). This can potentially be recorded every time a + URL hostname is parsed, but only if parsing escaped at least one character. </summary> </histogram> <histogram name="UsageStats.Events" enum="UsageStatsEvents" - expires_after="2021-11-14"> + expires_after="2022-04-24"> <owner>pnoland@chromium.org</owner> <owner>fgorski@chromium.org</owner> <summary> @@ -18214,7 +18737,7 @@ should be kept until we use this API. --> </histogram> <histogram name="UserManager.LoginUserType" enum="UserType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>achuith@chromium.org</owner> <summary> The number of users of different types that log in to the system (Chrome @@ -18326,7 +18849,7 @@ regressions. --> </histogram> <histogram name="Viewport.DidScalePage" enum="BooleanDidScalePage" - expires_after="M97"> + expires_after="M108"> <owner>bokan@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -18338,7 +18861,7 @@ regressions. --> </histogram> <histogram name="Viewport.MaxPageScale" enum="PageScaleFactorRange" - expires_after="M97"> + expires_after="M108"> <owner>bokan@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -18352,7 +18875,7 @@ regressions. --> </histogram> <histogram name="Viewport.MetaTagType" enum="MetaTagTypeEnum" - expires_after="M97"> + expires_after="M108"> <owner>bokan@chromium.org</owner> <owner>input-dev@chromium.org</owner> <summary> @@ -18419,7 +18942,7 @@ regressions. --> </histogram> <histogram name="Viz.DisplayCompositor.OverlayNumProposedCandidates" - units="units" expires_after="2022-01-09"> + units="units" expires_after="2022-04-17"> <owner>petermcneeley@chromium.org</owner> <owner>dcastagna@chromium.org</owner> <summary> @@ -18430,7 +18953,7 @@ regressions. --> </histogram> <histogram name="Viz.DisplayCompositor.OverlayQuadMaterial" - enum="OverlayQuadMaterial" expires_after="2022-01-09"> + enum="OverlayQuadMaterial" expires_after="2022-04-17"> <owner>petermcneeley@chromium.org</owner> <owner>dcastagna@chromium.org</owner> <summary> @@ -18440,7 +18963,7 @@ regressions. --> </histogram> <histogram name="Viz.DisplayCompositor.OverlayStrategy" - enum="OverlayStrategies" expires_after="2022-01-09"> + enum="OverlayStrategies" expires_after="2022-03-13"> <owner>dcastagna@chromium.org</owner> <owner>hoegsberg@chromium.org</owner> <summary> @@ -18450,7 +18973,7 @@ regressions. --> </histogram> <histogram name="Viz.DisplayCompositor.OverlaySwitchInterval" units="ms" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>petermcneeley@chromium.org</owner> <owner>dcastagna@chromium.org</owner> <summary> @@ -18460,7 +18983,7 @@ regressions. --> </histogram> <histogram name="Viz.DisplayCompositor.RootDamageRect.Overlay" - enum="BooleanOverlayDamageRect" expires_after="2021-12-01"> + enum="BooleanOverlayDamageRect" expires_after="2022-04-17"> <owner>magchen@chromium.org</owner> <owner>zmo@chromium.org</owner> <summary> @@ -18500,7 +19023,7 @@ regressions. --> </histogram> <histogram name="Viz.FrameSinkVideoCapturer.RGBA.CaptureDuration" units="ms" - expires_after="2021-11-21"> + expires_after="2022-05-01"> <owner>samans@chromium.org</owner> <owner>sadrul@chromium.org</owner> <owner>viz-team-wat@google.com</owner> @@ -18800,7 +19323,7 @@ regressions. --> </histogram> <histogram name="Web.CurrentOriginEqualsLastCommittedOrigin" - enum="BooleanEqual" expires_after="2021-11-17"> + enum="BooleanEqual" expires_after="2022-11-17"> <owner>ajuma@chromium.org</owner> <owner>gambard@chromium.org</owner> <summary> @@ -18815,500 +19338,8 @@ regressions. --> </summary> </histogram> -<histogram name="Webapp.AddToHomescreenDialog.Timeout" units="ms" - expires_after="M98"> - <owner>dominickn@chromium.org</owner> - <owner>peconn@chromium.org</owner> - <summary> - Records the number of milliseconds that the add to homescreen dialog - required to check installability eligibility. - </summary> -</histogram> - -<histogram name="Webapp.AddToHomescreenMediator.AppTypeToMenuEntry" - enum="AppTypeToMenuEntry" expires_after="2022-01-02"> - <owner>finnur@chromium.org</owner> - <owner>beverloo@chromium.org</owner> - <summary> - Keeps track of what verbiage was shown in the App menu versus what was - actually installed. - </summary> -</histogram> - -<histogram name="Webapp.CheckServiceWorker.Status" - enum="ServiceWorkerOfflineCapability" expires_after="2022-02-06"> - <owner>asamidoi@chromium.org</owner> - <owner>chrome-worker@google.com</owner> - <summary> - Records the result of the check if a PWA has a service worker with a fetch - event handler when the CheckOfflineCapability feature is disabled. When the - feature is enabled, records the result of the check if a PWA supports - offline pages with a service worker. - </summary> -</histogram> - -<histogram name="Webapp.CheckServiceWorker.Time" units="ms" - expires_after="2022-02-06"> - <owner>asamidoi@chromium.org</owner> - <owner>chrome-worker@google.com</owner> - <summary> - Records the time to complete the check if a PWA has a service worker with a - fetch event handler when the CheckOfflineCapability feature is disabled. - When the feature is enabled, records the time to complete the check if a PWA - supports offline pages with a service worker. - </summary> -</histogram> - -<histogram base="true" name="WebApp.Engagement" - enum="SiteEngagementServiceEngagementType" expires_after="2022-01-16"> - <owner>calamity@chromium.org</owner> - <owner>mgiuca@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <summary> - The type of engagement (navigation, user input, etc.) which led to an - accumulation in site engagement within a web app window or tab. Should be - collected for a subset of SiteEngagementService.EngagementType, which is - triggered for all browsing contexts. Recorded at the time of engagement - accumulation (e.g., when mouse is clicked). - </summary> -</histogram> - -<histogram name="WebApp.Icon.HttpStatusCodeClassOnCreate" - enum="HttpStatusCodeClass" expires_after="2021-01-01"> - <owner>alancutter@chromium.org</owner> - <owner>mgiuca@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <summary> - The HTTP status code class returned for each icon loaded during a WebApp's - creation. See corresponding - Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnCreate histogram for legacy - extension-based system. Recorded when WebAppDataRetriever starts downloading - icons. - </summary> -</histogram> - -<histogram name="WebApp.Icon.HttpStatusCodeClassOnSync" - enum="HttpStatusCodeClass" expires_after="2021-01-01"> - <owner>alancutter@chromium.org</owner> - <owner>mgiuca@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <summary> - The HTTP status code class returned for each icon loaded when syncing a - WebApp. See Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnSync histogram - for legacy extension-based system. Recorded when WebAppDataRetriever starts - downloading icons. - </summary> -</histogram> - -<histogram name="WebApp.Icon.HttpStatusCodeClassOnUpdate" - enum="HttpStatusCodeClass" expires_after="2021-01-01"> - <owner>alancutter@chromium.org</owner> - <owner>raymes@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <summary> - The HTTP status code class returned for each icon loaded when updating a - WebApp. Recorded when WebAppDataRetriever starts downloading icons. - </summary> -</histogram> - -<histogram name="Webapp.Install.DisplayMode2" enum="WebAppDisplayMode" - expires_after="2022-01-02"> - <owner>ericwilligers@chromium.org</owner> - <owner>peter@chromium.org</owner> - <owner>yfriedman@chromium.org</owner> - <summary> - Records the display mode (as defined in the Web App Manifest spec) at the - install time of a WebApp. Fixes a bug in the data collection for desktop web - apps. - </summary> -</histogram> - -<histogram name="Webapp.Install.InstallBounce" enum="WebappInstallSource" - expires_after="2021-12-26"> - <owner>dominickn@chromium.org</owner> - <owner>alancutter@chromium.org</owner> - <summary> - Records when a web app install bounced for different install sources. A - bounce is when the user uninstalls the web app within 1 hour of installing - it. - </summary> -</histogram> - -<histogram name="Webapp.Install.InstallEvent" enum="WebappInstallSource" - expires_after="2022-01-16"> - <owner>dominickn@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <owner>calamity@chromium.org</owner> - <summary> - Records the mechanism and source from which a web app installation was - triggered, regardless of whether the installation was successful. - </summary> -</histogram> - -<histogram name="Webapp.Install.UninstallEvent" enum="WebappUninstallSource" - expires_after="2022-04-12"> - <owner>dmurph@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <owner>sunggch@microsoft.com</owner> - <summary> - Records the mechanism and source from which a web app uninstallation was - triggered, regardless of whether the uninstallation was successful. - </summary> -</histogram> - -<histogram name="WebApp.InstallConfirmation.CloseReason" - enum="WidgetClosedReason" expires_after="2021-12-12"> - <owner>dmurph@chromium.org</owner> - <owner>desktop-pwa-team@google.com</owner> - <summary> - Records the reason that the WebApp install confirmation dialog is closed. - This dialog is shown when the user clicks on the 'install' icon in the - omnibox for websites that are installable. This metric is intended to give - data for an experiment to choose the best install icon. - </summary> -</histogram> - -<histogram name="WebApp.InstallIphPromo.Result" enum="WebAppInstallIphResult" - expires_after="2021-12-12"> - <owner>phillis@chromium.org</owner> - <owner>dmurph@chromium.org</owner> - <summary> - Records the result of user reaction to In Product Help promo for Web App - Install. - </summary> -</histogram> - -<histogram name="Webapp.InstallResult" enum="WebAppInstallResultCode" - expires_after="2022-01-16"> -<!-- Name completed by histogram_suffixes name="WebAppType" --> - - <owner>calamity@chromium.org</owner> - <owner>ortuno@chromium.org</owner> - <summary>Records the result code of Web App installs.</summary> -</histogram> - -<histogram base="true" - name="Webapp.InstallResultExtensionDisabledReason.System.Profiles" - enum="ExtensionDisableReason" expires_after="2020-12-31"> - <obsolete> - Removed 11/2020, as the relevant code path is no longer executed after BMO - launch. - </obsolete> - <owner>calamity@chromium.org</owner> - <owner>ortuno@chromium.org</owner> - <summary> - Records why System Web App .crx extension is disabled during System Web App - installs. Certain properties of the profile might cause Extensions to be - disabled as soon as they are installed. For example, kiosk profile might set - policies to disable all Extensions, including System Web Apps which are - considered Extensions. - </summary> -</histogram> - -<histogram base="true" - name="Webapp.InstallResultExtensionError.System.Profiles" - enum="ExtensionInstallationCrxInstallError" expires_after="2020-12-31"> - <obsolete> - Removed 11/2020, as the relevant code path is no longer executed after BMO - launch. - </obsolete> - <owner>calamity@chromium.org</owner> - <owner>ortuno@chromium.org</owner> - <summary> - Records .crx extension error code when System Web App install fails. - </summary> -</histogram> - -<histogram name="WebApp.Launcher.LaunchResult" - enum="WebAppLauncherLaunchResult" expires_after="2022-07-01"> - <owner>davidbienvenu@chromium.org</owner> - <owner>jessemckenna@google.com</owner> - <summary> - The result of a Progressive Web App (PWA) launcher's attempt to launch - Chrome. Windows-only. - </summary> -</histogram> - -<histogram name="WebApp.Launcher.UpdateResult" - enum="WebAppLauncherUpdateResult" expires_after="2022-07-01"> - <owner>davidbienvenu@chromium.org</owner> - <owner>jessemckenna@google.com</owner> - <summary> - The result of updating a single Progressive Web App (PWA) launcher with the - latest version of chrome_pwa_launcher.exe. Windows-only. - </summary> -</histogram> - -<histogram name="WebApp.Migration.UserDisplayModeCleanUp" - enum="BooleanMigrated" expires_after="2021-01-01"> - <obsolete> - Removed 12/2020. - </obsolete> - <owner>alancutter@chromium.org</owner> - <owner>dxie@google.com</owner> - <owner>loyso@google.com</owner> - <owner>mgiuca@google.com</owner> - <summary> - The result of deploying a follow up migration after a migration bug - (https://crbug.com/1125020) that caused users' web apps to open in a browser - tab instead of a standalone window. This follow up migration only runs once - at startup for all Chrome profiles. If it fails it will retry until - successful on subsequent start ups, metrics are only recorded on success. - </summary> -</histogram> - -<histogram name="WebApp.Mover.Result" enum="WebAppMoverResult" - expires_after="2021-12-12"> - <owner>dmurph@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records the result of running the WebAppMover, which runs on Chrome startup. - It uninstalls a set of WebApps and then installs a single WebApp as a - replacement. - </summary> -</histogram> - -<histogram name="Webapp.NavigationStatus" enum="BooleanSuccess" - expires_after="2021-10-25"> - <owner>peter@chromium.org</owner> - <owner>hartmanng@chromium.org</owner> - <summary> - Records whether the top-level navigations in standalone Web Apps result in - presenting the web content or showing the error page. - </summary> -</histogram> - -<histogram name="WebApp.Preinstalled.ConfigErrorCount" units="apps" - expires_after="2021-12-12"> - <owner>alancutter@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records how many preinstalled web app config files failed to parse as valid - JSON with valid fields. See preinstalled_web_app_utils.cc ParseConfig(). - This is recorded at start up. - </summary> -</histogram> - -<histogram name="WebApp.Preinstalled.DisabledCount" units="apps" - expires_after="2021-12-12"> - <owner>alancutter@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records how many preinstalled web apps configs were disabled for the device. - This is recorded at start up. - </summary> -</histogram> - -<histogram name="WebApp.Preinstalled.EnabledCount" units="apps" - expires_after="2021-12-26"> - <owner>alancutter@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records how many preinstalled web apps configs were enabled for the device. - This is recorded at start up. - </summary> -</histogram> - -<histogram name="WebApp.Preinstalled.UninstallAndReplaceCount" units="apps" - expires_after="2021-12-12"> - <owner>alancutter@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records how many preinstalled web app installations uninstalled and replaced - an old default app (web app or Chrome app). This corresponds to the - "uninstall_and_replace" field in preinstalled web app configs. - </summary> -</histogram> - -<histogram name="WebApp.Shortcuts.Creation.Result" - enum="ShortcutsCreationResult" expires_after="2021-09-19"> - <owner>phillis@chromium.org</owner> - <owner>dmurph@chromium.org</owner> - <summary>Records the result of shortcut creation for PWA.</summary> -</histogram> - -<histogram name="WebApp.Shortcuts.Deletion.Success" enum="BooleanSuccess" - expires_after="M93"> - <obsolete> - Removed on M93. Not needed anymore. - </obsolete> - <owner>phillis@chromium.org</owner> - <owner>dmurph@chromium.org</owner> - <owner>sunggch@microsoft.com</owner> - <summary> - Records the result of shortcut deletion for a PWA. This occurs when an - installed PWA is uninstalled, which can be triggered by user, policy admin, - or sync system depending on the situation. - </summary> -</histogram> - -<histogram name="Webapp.SyncInitiatedUninstallResult" enum="BooleanSuccess" - expires_after="2022-01-01"> - <owner>alancutter@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <summary> - Records uninstallation result for sync initiated uninstalls in the new - USS-based web applications system. - </summary> -</histogram> - -<histogram name="Webapp.SystemApps.BackgroundTaskStartDelay" units="ms" - expires_after="2022-01-05"> - <owner>dominicschulz@google.com</owner> - <owner>qjw@chromium.org</owner> - <summary> - Records how long the SWA background task waits for the system to become idle - before starting to run. Recorded in milliseconds, from 1 millisecond to 1 - hour. This is logged when a SWA background task starts. - </summary> -</histogram> - -<histogram name="Webapp.SystemApps.BadNavigate.Type" units="App ID" - expires_after="2021-09-01"> - <owner>calamity@chromium.org</owner> - <owner>qjw@chromium.org</owner> - <summary> - Records the type of System Web App that caused a bad navigation. This is - used to trigger a Perfetto trace to provide more debugging information. See - crbug.com/1201820 for more details. - </summary> -</histogram> - -<histogram name="Webapp.SystemApps.FreshInstallDuration" units="ms" - expires_after="2022-01-16"> - <owner>calamity@chromium.org</owner> - <owner>ortuno@chromium.org</owner> - <summary> - Records the time taken to perform a fresh install of all system web apps. It - measures the time from when we dispatch a call to install them, until we get - all the installation results. This intentionally excludes the scenario where - we don't request to install all the apps for consistency. Recorded in - milliseconds, from 1 millisecond to 3 minutes. - </summary> -</histogram> - -<histogram name="WebApp.UninstallDialog.AppMenuUninstallSuccess" enum="Boolean" - expires_after="M95"> - <obsolete> - Removed in M92. - </obsolete> - <owner>dmurph@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records the result of uninstalling a WebApp when the user clicks on - "Uninstall" from the 3-dot menu of the respective WebApp window. - </summary> -</histogram> - -<histogram name="WebApp.UninstallDialog.AppsPageUninstallSuccess" - enum="Boolean" expires_after="M95"> - <obsolete> - Removed in M92. - </obsolete> - <owner>dmurph@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records the result of uninstalling an app from the chrome://apps page. This - happens whena user right-clicks on a greyed out webapp icon in the - chrome://apps page and clicks "Uninstall". - </summary> -</histogram> - -<histogram name="Webapp.UninstallDialogAction" - enum="WebappUninstallDialogAction" expires_after="2022-01-16"> - <owner>benwells@chromium.org</owner> - <owner>dominickn@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <summary> - Records the user response to the dialog shown when uninstalling a web app. - </summary> -</histogram> - -<histogram name="Webapp.Update.ManifestUpdateResult" - enum="WebAppManifestUpdateResult" expires_after="2021-12-12"> - <owner>alancutter@chromium.org</owner> - <owner>desktop-pwas-team@chromium.org</owner> - <owner>loyso@chromium.org</owner> - <owner>raymes@chromium.org</owner> - <summary> - Records the result of web app manifest update checks during page - navigations. Note that "No app in scope" results are ignored due - to the expected several orders of magnitude higher volume than all other - update results. - </summary> -</histogram> - -<histogram name="Webapp.Update.ManifestUpdateResult.DefaultApp" - enum="WebAppManifestUpdateResult" expires_after="M96"> - <owner>alancutter@chromium.org</owner> - <owner>tsergeant@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Identical to Webapp.Update.ManifestUpdateResult but restricted to just - default installed web apps. - </summary> -</histogram> - -<histogram name="WebApp.UrlHandling.DialogState" - enum="WebAppUrlHandlingDialogState" expires_after="2022-06-25"> - <owner>mek@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records the user action taken on the URL Handling intent picker dialog. - </summary> -</histogram> - -<histogram name="WebApp.UrlHandling.GetValidProfilesAtStartUp" - units="microseconds" expires_after="2022-06-20"> - <owner>mek@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Measure the time it takes to collect (loading as needed) the set of profiles - eligible to handle a URL by a PWA at startup for URL Handling. Emitted for - users with high resolution clocks only. - </summary> -</histogram> - -<histogram name="WebApp.UrlHandling.LoadWebAppRegistrarsAtStartUp" - units="microseconds" expires_after="2022-06-20"> - <owner>mek@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Measure the time it takes to load all the web app registrars for URL - Handling at startup. Emitted for users with high resolution clocks only. - </summary> -</histogram> - -<histogram name="Webapp.WebAppOriginAssociationFetchResult" - enum="WebAppOriginAssociationFetchResult" expires_after="2022-03-05"> - <owner>mek@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records the result of web app origin association file fetch when url - handlers are present. Happens when PWA is installed or updated. - </summary> -</histogram> - -<histogram name="Webapp.WebAppOriginAssociationParseResult" - enum="WebAppOriginAssociationParseResult" expires_after="2022-03-05"> - <owner>mek@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary> - Records the result of web app origin association file parsing. Happens after - an web app origin association file is fetched. - </summary> -</histogram> - -<histogram name="Webapp.WebAppUrlLoaderPrepareForLoadResult" - enum="WebAppUrlLoaderResult" expires_after="2022-01-09"> - <owner>qjw@chromium.org</owner> - <owner>ortuno@chromium.org</owner> - <owner>desktop-pwas-team@google.com</owner> - <summary>Records the result of WebAppUrlLoader::PrepareForLoad().</summary> -</histogram> - <histogram name="WebContentsObserver.{Method}" units="ms" - expires_after="2021-09-15"> + expires_after="2022-09-07"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -19376,7 +19407,7 @@ regressions. --> </histogram> <histogram name="WebFont.BlankTextShownTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>kenjibaheux@chromium.org</owner> <owner>ksakamoto@chromium.org</owner> <summary> @@ -19387,7 +19418,7 @@ regressions. --> </histogram> <histogram name="WebFont.CacheHit" enum="WebFontCacheHit" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>hajimehoshi@chromium.org</owner> <owner>kenjibaheux@chromium.org</owner> <owner>kouhei@chromium.org</owner> @@ -19411,7 +19442,7 @@ regressions. --> </histogram> <histogram name="WebFont.DownloadTime.0.Under10KB" units="ms" - expires_after="2022-01-15"> + expires_after="2022-05-01"> <owner>kenjibaheux@chromium.org</owner> <owner>ksakamoto@chromium.org</owner> <summary> @@ -19461,7 +19492,7 @@ regressions. --> </histogram> <histogram name="WebFont.DownloadTime.LoadError" units="ms" - expires_after="2022-01-15"> + expires_after="2022-03-20"> <owner>kenjibaheux@chromium.org</owner> <owner>ksakamoto@chromium.org</owner> <summary> @@ -19484,7 +19515,7 @@ regressions. --> </histogram> <histogram name="WebFont.HadBlankText" enum="BooleanHadBlankText" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>kenjibaheux@chromium.org</owner> <owner>ksakamoto@chromium.org</owner> <summary> @@ -19518,7 +19549,7 @@ regressions. --> </histogram> <histogram name="WebFont.LocalFontUsed" enum="BooleanUsage" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>hajimehoshi@chromium.org</owner> <owner>kenjibaheux@chromium.org</owner> <owner>kouhei@chromium.org</owner> @@ -19591,7 +19622,7 @@ regressions. --> </histogram> <histogram name="WebShare.ApiCount" enum="WebShareMethod" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>mgiuca@chromium.org</owner> <summary> Counts the number of calls to navigator.share. Includes both successful and @@ -19615,7 +19646,7 @@ regressions. --> </histogram> <histogram name="WebsiteSettings.Action" enum="WebsiteSettingsAction" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>estark@chromium.org</owner> <owner>dullweber@chromium.org</owner> <summary> @@ -19635,17 +19666,18 @@ regressions. --> </histogram> <histogram name="WebsiteSettings.AllSitesAction2" - enum="WebSiteSettingsAllSitesAction2" expires_after="2021-08-09"> + enum="WebSiteSettingsAllSitesAction2" expires_after="2022-04-10"> <owner>jarrydg@chromium.org</owner> <owner>mxcai@chromium.org</owner> <summary> Tracks actions with the "All Sites" page in website settings - starting in M82. + starting in M82. No data available for M94, was temporarily expired. Values + 7 and 8 were added with M96. </summary> </histogram> <histogram name="WebsiteSettings.Discoverability.Action" - enum="WebsiteSettingsDiscoverabilityAction" expires_after="M96"> + enum="WebsiteSettingsDiscoverabilityAction" expires_after="2022-04-03"> <owner>eokoyomon@chromium.org</owner> <owner>dullweber@chromium.org</owner> <summary> @@ -19654,7 +19686,7 @@ regressions. --> </histogram> <histogram name="WebsiteSettings.Discoverability.TimeToClickHighlight" - units="ms" expires_after="M96"> + units="ms" expires_after="M98"> <owner>eokoyomon@chromium.org</owner> <owner>dullweber@chromium.org</owner> <summary> @@ -19663,8 +19695,18 @@ regressions. --> </summary> </histogram> +<histogram name="WebsiteSettings.Discoverability.TimeToClickHighlightStoreInfo" + units="ms" expires_after="M100"> + <owner>zhiyuancai@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Records the amount of time between when the page info is opened and the + highlighted store info section is clicked. + </summary> +</histogram> + <histogram name="WebsiteSettings.Discoverability.TimeToOpen" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>eokoyomon@chromium.org</owner> <owner>dullweber@chromium.org</owner> <summary> @@ -19673,6 +19715,16 @@ regressions. --> </summary> </histogram> +<histogram name="WebsiteSettings.Discoverability.TimeToOpenFromStoreIcon" + units="ms" expires_after="M100"> + <owner>zhiyuancai@chromium.org</owner> + <owner>chrome-shopping@google.com</owner> + <summary> + Records the amount of time the store icon is shown in the omnibox before the + user clicks into page info. + </summary> +</histogram> + <histogram name="WebsiteSettings.Menu.PermissionChanged" enum="ContentType" expires_after="M81"> <owner>miguelg@chromium.org</owner> @@ -19750,10 +19802,11 @@ regressions. --> </histogram> <histogram name="WebsiteSettings.OriginInfo.PermissionChanged" - enum="ContentType" expires_after="2021-12-26"> + enum="ContentType" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Count of how often a specific content type (permission) is changed using the Origin Info dialog. @@ -19764,10 +19817,11 @@ regressions. --> </histogram> <histogram name="WebsiteSettings.OriginInfo.PermissionChanged.Allowed" - enum="ContentType" expires_after="2021-08-22"> + enum="ContentType" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Count of how often a specific content type (permission) is set to 'Allowed' using the Origin Info dialog. @@ -19778,10 +19832,11 @@ regressions. --> </histogram> <histogram name="WebsiteSettings.OriginInfo.PermissionChanged.Blocked" - enum="ContentType" expires_after="2021-08-22"> + enum="ContentType" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Count of how often a specific content type (permission) is set to 'Blocked' using the Origin Info dialog. @@ -19812,13 +19867,13 @@ regressions. --> </histogram> <histogram name="WebUI.CreatedForUrl" enum="WebUIUrlHashes" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>dbeam@chromium.org</owner> <summary>URLs for which Chrome creates WebUIControllers.</summary> </histogram> <histogram name="WebUI.Settings.PathVisited" enum="WebUISettingsPathHashes" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>dschuyler@chromium.org</owner> <owner>tbuckley@chromium.org</owner> <owner>bettes@chromium.org</owner> @@ -19831,7 +19886,7 @@ regressions. --> </histogram> <histogram name="WebUITabStrip.CloseAction" enum="WebUITabStripCloseActions" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>collinbaker@chromium.org</owner> <owner>tluk@chromium.org</owner> <summary> @@ -19842,7 +19897,7 @@ regressions. --> </histogram> <histogram name="WebUITabStrip.CloseTabAction" - enum="WebUITabStripCloseTabActions" expires_after="2021-12-26"> + enum="WebUITabStripCloseTabActions" expires_after="2022-05-01"> <owner>johntlee@chromium.org</owner> <owner>dpapad@chromium.org</owner> <summary> @@ -19881,7 +19936,7 @@ regressions. --> </histogram> <histogram name="WebUITabStrip.OpenAction" enum="WebUITabStripOpenActions" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>collinbaker@chromium.org</owner> <owner>tluk@chromium.org</owner> <summary> @@ -19892,7 +19947,7 @@ regressions. --> </histogram> <histogram name="WebUITabStrip.OpenDuration" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>collinbaker@chromium.org</owner> <owner>tluk@chromium.org</owner> <summary> @@ -19903,7 +19958,7 @@ regressions. --> </histogram> <histogram name="WebUITabStrip.TabActivation" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>robliao@chromium.org</owner> <owner>johntlee@chromium.org</owner> <summary> @@ -19922,7 +19977,7 @@ regressions. --> </histogram> <histogram name="WebUITabStrip.TabDataReceived" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>robliao@chromium.org</owner> <owner>johntlee@chromium.org</owner> <summary> @@ -20034,15 +20089,27 @@ regressions. --> </histogram> <histogram name="WhatsNew.LoadEvent" enum="WhatsNewLoadEvent" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>rbpotter@chromium.org</owner> <owner>mahmadi@chromium.org</owner> <summary> Records load events for the What's New page when a load event occurs. This tracks how many times loading remote content is attempted, and whether it - succeeds, fails and results in an error page, or fails and redirects to the - New Tab Page. Load is attempted when the page is first opened, and success - or failure will occur when the network request completes. Desktop only. + succeeds, fails and results in an error page, fails and redirects to the New + Tab Page, or fails and closes the tab. Load is attempted when the page is + first opened, and success or failure will occur when the network request + completes. Desktop only. + </summary> +</histogram> + +<histogram name="WhatsNew.LoadResponseCode" + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-05-01"> + <owner>rbpotter@chromium.org</owner> + <owner>mahmadi@chromium.org</owner> + <summary> + Records the net error or HTTP response code of the network request for the + remote content for the iframe in the What's New page. This request is + triggered when the What's New page is opened. Desktop only. </summary> </histogram> @@ -20117,7 +20184,7 @@ regressions. --> </histogram> <histogram name="WrenchMenu.MenuAction" enum="WrenchMenuAction" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>ainslie@chromium.org</owner> <owner>edwardjung@chromium.org</owner> <summary>Number of times that each menu item is clicked.</summary> @@ -20133,7 +20200,7 @@ regressions. --> </histogram> <histogram name="WrenchMenu.TimeToAction" units="units" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>ainslie@chromium.org</owner> <owner>edwardjung@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/page/histograms.xml b/chromium/tools/metrics/histograms/metadata/page/histograms.xml index f6e7c59c6c2..a8ef027981f 100644 --- a/chromium/tools/metrics/histograms/metadata/page/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/page/histograms.xml @@ -64,7 +64,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="PageActionController.ExtensionsWithPageActions" units="units" - expires_after="2021-12-01"> + expires_after="2022-05-01"> <owner>rdevlin.cronin@chromium.org</owner> <owner>extensions-core@chromium.org</owner> <summary> @@ -119,7 +119,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.BackForwardCache.Event" - enum="PageLoadBackForwardCacheEvent" expires_after="2021-12-19"> + enum="PageLoadBackForwardCacheEvent" expires_after="2022-05-01"> <owner>altimin@chromium.org</owner> <owner>bmcquade@chromium.org</owner> <owner>hajimehoshi@chromium.org</owner> @@ -236,7 +236,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.Ads.HeavyAds.DisallowedByBlocklist" - enum="BooleanBlocked" expires_after="2021-10-04"> + enum="BooleanBlocked" expires_after="2022-10-04"> <owner>johnidel@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <summary> @@ -298,7 +298,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.Ads.Memory.MainFrame.Max" units="KiB" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -334,7 +334,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.Ads.Memory.UpdateCount" units="count" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -348,7 +348,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.Ads.Resources.Bytes.Ads2" units="KB" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>johnidel@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <summary> @@ -359,8 +359,39 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="PageLoad.Clients.AMP.Experimental.LayoutInstability.MaxCumulativeShiftScore.Subframe.SessionWindow.Gap1000ms.Max5000ms.Bucketing50_GoodRange" + units="scorex10000" expires_after="2021-10-01"> + <obsolete> + Removed in 10/2021. + </obsolete> + <owner>sullivan@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + Experimental version of + PageLoad.Clients.AMP.LayoutInstability.MaxCumulativeShiftScore.Subframe.SessionWindow.Gap1000ms.Max5000ms + which uses 50 buckets for the 0.0-0.1 range. + + This metric will be removed when bucket size is decided in crbug.com/1230786 + + Measures the maximum cumulative layout shift (bit.ly/cls-explainer) that has + occurred in the AMP subframe. The gap between two consecutive shifts in a + window is not bigger than 1000ms and the maximum window size is 5000ms. This + metric's integral value is 10x the fractional cumulative layout shift score + described in the explainer. If {Bfcache} is triggered, we record the metric + when the user navigates away or closes the page after the page was restored + from back-forward cache. Otherwise, we record it at the end of the page + lifetime, such as when the page is being navigated away from or when a tab + is being closed. + + Recorded for non same-document AMP navigations in the main frame, at the end + of the AMP document lifetime, such as when the document is being navigated + away from. + </summary> +</histogram> + +<histogram name="PageLoad.Clients.AMP.Experimental.PageTiming.InputToNavigation.Subframe" - units="ms" expires_after="M97"> + units="ms" expires_after="2022-05-01"> <owner>bmcquade@chromium.org</owner> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> @@ -377,7 +408,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.AMP.Experimental.PageTiming.MainFrameToSubFrameNavigationDelta.Subframe" - units="ms" expires_after="M97"> + units="ms" expires_after="2022-04-24"> <owner>bmcquade@chromium.org</owner> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> @@ -445,8 +476,41 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="PageLoad.Clients.AMP.InteractiveTiming.{NormalizedResponsivenessMetric}.{UserInteractionLatency}.SubFrame{FullNavigation}" + units="ms" expires_after="2022-05-01"> + <owner>hbsong@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + The {NormalizedResponsivenessMetric} of a page load, in AMP subframes, in + ms. For this metric, we measure the latency of a user interaction by the + {UserInteractionLatency} within the user interaction. Full navigation means + we only include non-same-document navigations, otherwise we only include + same-document navigations. + + Recorded at the end of the AMP document lifetime, such as when the document + is being navigated away from. + </summary> + <token key="FullNavigation"> + <variant name=""/> + <variant name=".FullNavigation"/> + </token> + <token key="NormalizedResponsivenessMetric"> + <variant name="AverageUserInteractionLatencyOverBudget"/> + <variant name="SlowUserInteractionLatencyOverBudget.HighPercentile"/> + <variant name="SlowUserInteractionLatencyOverBudget.HighPercentile2"/> + <variant name="SumOfUserInteractionLatencyOverBudget"/> + <variant name="WorstUserInteractionLatency"/> + <variant name="WorstUserInteractionLatencyOverBudget"/> + </token> + <token key="UserInteractionLatency"> + <variant name="MaxEventDuration"/> + <variant name="TotalEventDuration"/> + </token> +</histogram> + +<histogram name="PageLoad.Clients.AMP.LayoutInstability.CumulativeShiftScore.Subframe" - units="scorex10" expires_after="M97"> + units="scorex10" expires_after="2022-03-06"> <owner>bmcquade@chromium.org</owner> <owner>skobes@chromium.org</owner> <owner>sullivan@chromium.org</owner> @@ -464,7 +528,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.AMP.LayoutInstability.CumulativeShiftScore.Subframe.FullNavigation" - units="scorex10" expires_after="M97"> + units="scorex10" expires_after="2022-03-06"> <owner>bmcquade@chromium.org</owner> <owner>skobes@chromium.org</owner> <owner>sullivan@chromium.org</owner> @@ -481,6 +545,35 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="PageLoad.Clients.AMP.LayoutInstability.MaxCumulativeShiftScore.Subframe.SessionWindow.Gap1000ms.Max5000ms2" + units="scorex10000" expires_after="never"> +<!-- expires-never: used in server pipeline to derive additional metrics --> + + <owner>sullivan@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + Measures the maximum cumulative layout shift (bit.ly/cls-explainer) that has + occurred in the AMP subframe. The gap between two consecutive shifts in a + window is not bigger than 1000ms and the maximum window size is 5000ms. This + metric's integral value is 10x the fractional cumulative layout shift score + described in the explainer. If {Bfcache} is triggered, we record the metric + when the user navigates away or closes the page after the page was restored + from back-forward cache. Otherwise, we record it at the end of the page + lifetime, such as when the page is being navigated away from or when a tab + is being closed. + + Recorded for non same-document AMP navigations in the main frame, at the end + of the AMP document lifetime, such as when the document is being navigated + away from. + + Replaces + PageLoad.Clients.AMP.LayoutInstability.MaxCumulativeShiftScore.Subframe.SessionWindow.Gap1000ms.Max5000ms + and increases granularity in order to get more coverage for ~40% of the + values in the 0-0.1 range. + </summary> +</histogram> + +<histogram name="PageLoad.Clients.AMP.LayoutInstability.MaxCumulativeShiftScore.Subframe.{Navigation}{Window}.Gap{Gap}.Max{MaxWindowSize}" units="scorex10" expires_after="M97"> <owner>hbsong@chromium.org</owner> @@ -513,7 +606,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.AMP.PaintTiming.InputToFirstContentfulPaint.Subframe" - units="ms" expires_after="M97"> + units="ms" expires_after="2022-04-03"> <owner>bmcquade@chromium.org</owner> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> @@ -529,7 +622,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.AMP.PaintTiming.InputToFirstContentfulPaint.Subframe.FullNavigation" - units="ms" expires_after="M97"> + units="ms" expires_after="2022-04-03"> <owner>bmcquade@chromium.org</owner> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> @@ -544,7 +637,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.AMP.PaintTiming.InputToLargestContentfulPaint.Subframe" - units="ms" expires_after="M97"> + units="ms" expires_after="2022-04-03"> <owner>bmcquade@chromium.org</owner> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> @@ -566,7 +659,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.AMP.PaintTiming.InputToLargestContentfulPaint.Subframe.FullNavigation" - units="ms" expires_after="M97"> + units="ms" expires_after="2022-04-03"> <owner>bmcquade@chromium.org</owner> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> @@ -703,7 +796,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.Scheme.HTTP.PaintTiming.UnderStat" - enum="PageLoadTimingUnderStat" expires_after="2022-01-30"> + enum="PageLoadTimingUnderStat" expires_after="2022-04-03"> <owner>tbansal@chromium.org</owner> <summary> Records if the time from navigation to first contentful paint was less than @@ -731,7 +824,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.Scheme.HTTPS.PaintTiming.UnderStat" - enum="PageLoadTimingUnderStat" expires_after="2022-01-30"> + enum="PageLoadTimingUnderStat" expires_after="2022-04-03"> <owner>tbansal@chromium.org</owner> <summary> Records if the time from navigation to first contentful paint was less than @@ -760,6 +853,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.ServiceWorker2.PageTransition" enum="CorePageTransition" expires_after="M85"> + <obsolete> + Expired in October 2020. Removed from the code in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <summary> The core transition type for main frame page loads controlled by a service @@ -890,7 +986,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Clients.ThirdParty.Frames.NavigationToFirstContentfulPaint3" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-04-17"> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> <summary> @@ -901,7 +997,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.ThirdParty.Origins.CookieRead2" units="Count" - expires_after="2021-12-05"> + expires_after="2022-08-30"> <owner>jkarlin@chromium.org</owner> <owner>yaoxia@chromium.org</owner> <summary> @@ -911,7 +1007,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.ThirdParty.Origins.CookieWrite2" - units="Count" expires_after="2021-12-05"> + units="Count" expires_after="2022-08-30"> <owner>jkarlin@chromium.org</owner> <owner>yaoxia@chromium.org</owner> <summary> @@ -922,7 +1018,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.ThirdParty.Origins.LocalStorageAccess2" - units="Count" expires_after="2021-09-05"> + units="Count" expires_after="2022-08-30"> <owner>yaoxia@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <summary> @@ -932,7 +1028,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Clients.ThirdParty.Origins.SessionStorageAccess2" - units="Count" expires_after="2021-09-12"> + units="Count" expires_after="2022-08-30"> <owner>yaoxia@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <summary> @@ -969,7 +1065,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PageLoad.Cpu.TotalUsage" units="ms" expires_after="2022-01-23"> +<histogram name="PageLoad.Cpu.TotalUsage" units="ms" expires_after="2022-04-10"> <owner>alexmt@chromium.org</owner> <owner>johnidel@chromium.org</owner> <summary> @@ -981,7 +1077,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Cpu.TotalUsageForegrounded" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-17"> <owner>alexmt@chromium.org</owner> <owner>johnidel@chromium.org</owner> <summary> @@ -993,7 +1089,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.DocumentTiming.NavigationToDOMContentLoadedEventFired" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-17"> <owner>bmcquade@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -1003,7 +1099,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.DocumentTiming.NavigationToLoadEventFired" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>bmcquade@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -1013,7 +1109,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PageLoad.Experimental.AbortTiming.Background" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-02-20"> <owner>bmcquade@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -1097,7 +1193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.Bytes.Network" units="KB" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>jkarlin@chromium.org</owner> <summary> The number of prefiltered (e.g., compressed) response body KiloBytes loaded @@ -1108,7 +1204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.Bytes.NetworkIncludingHeaders" - units="KB" expires_after="2021-12-12"> + units="KB" expires_after="2022-04-17"> <owner>jkarlin@chromium.org</owner> <summary> The number of prefiltered (e.g., compressed) KiloBytes loaded over the @@ -1119,7 +1215,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.Bytes.Total2" units="KB" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> <summary> @@ -1188,7 +1284,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.EarlyHints.EarlyHintsToFinalResponseStart" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2021-09-28"> + <obsolete> + Removed 09/2021. + </obsolete> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1201,7 +1300,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.EarlyHints.FinalRequestStartToEarlyHints" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2021-09-28"> + <obsolete> + Removed 09/2021. + </obsolete> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1213,7 +1315,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.EarlyHints.FirstRequestStartToEarlyHints" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2021-09-28"> + <obsolete> + Removed 09/2021. + </obsolete> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1262,8 +1367,62 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="PageLoad.Experimental.LayoutInstability.MaxCumulativeShiftScore.AfterBackForwardCacheRestore.SessionWindow.Gap1000ms.Max5000ms.Bucketing50_GoodRange" + units="scorex10000" expires_after="2021-10-01"> + <obsolete> + Removed in 10/2021. + </obsolete> + <owner>sullivan@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + Experimental version of + PageLoad.LayoutInstability.MaxCumulativeShiftScore.AfterBackForwardCacheRestore.SessionWindow.Gap1000ms.Max5000ms + which uses 50 buckets for the 0.0-0.1 range. + + This metric will be removed when bucket size is decided in crbug.com/1230786 + + Measures the maximum cumulative layout shift (bit.ly/cls-explainer) that has + occurred in after back forward cache restore. The gap between two + consecutive shifts in a window is not bigger than 1000ms and the maximum + window size is 5000ms. This metric's integral value is 10x the fractional + cumulative layout shift score described in the explainer. If {Bfcache} is + triggered, we record the metric when the user navigates away or closes the + page after the page was restored from back-forward cache. Otherwise, we + record it at the end of the page lifetime, such as when the page is being + navigated away from or when a tab is being closed. + </summary> +</histogram> + +<histogram + name="PageLoad.Experimental.LayoutInstability.MaxCumulativeShiftScore.SessionWindow.Gap1000ms.Max5000ms.Bucketing50_GoodRange" + units="scorex10000" expires_after="2021-10-01"> + <obsolete> + Removed in 10/2021. + </obsolete> + <owner>sullivan@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + Experimental version of + PageLoad.LayoutInstability.MaxCumulativeShiftScore.SessionWindow.Gap1000ms.Max5000ms + which uses 50 buckets for the 0.0-0.1 range. + + This metric will be removed when bucket size is decided in crbug.com/1230786 + + Measures the maximum cumulative layout shift (bit.ly/cls-explainer) that has + occurred in a Window. The gap between two consecutive shifts in a window is + not bigger than 1000ms and the maximum window size is 5000ms. This metric's + integral value is 10x the fractional cumulative layout shift score described + in the explainer. If {Bfcache} is triggered, we record the metric when the + user navigates away or closes the page after the page was restored from + back-forward cache. Otherwise, we record it at the end of the page lifetime, + such as when the page is being navigated away from or when a tab is being + closed. + </summary> +</histogram> + <histogram name="PageLoad.Experimental.Memory.Core.MainFrame.Max" units="KiB" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -1277,7 +1436,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.Memory.Core.Subframe.Aggregate.Max" - units="KiB" expires_after="2022-01-02"> + units="KiB" expires_after="2022-03-06"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -1292,7 +1451,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.Memory.Core.Total.Max" units="KiB" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -1307,7 +1466,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.Memory.Core.UpdateReceived" - units="BooleanReceived" expires_after="2021-08-31"> + units="BooleanReceived" expires_after="2021-09-30"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -1380,7 +1539,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.NavigationTiming.NavigationStartToFinalLoaderCallback" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2022-04-10"> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1391,7 +1550,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.NavigationTiming.NavigationStartToFinalRequestStart" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2022-04-17"> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1402,7 +1561,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.NavigationTiming.NavigationStartToFinalResponseStart" - units="ms" expires_after="2021-12-19"> + units="ms" expires_after="2022-04-10"> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1413,7 +1572,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.NavigationTiming.NavigationStartToFirstLoaderCallback" - units="ms" expires_after="2022-02-06"> + units="ms" expires_after="2022-04-24"> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1424,7 +1583,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.NavigationTiming.NavigationStartToFirstRequestStart" - units="ms" expires_after="2022-01-16"> + units="ms" expires_after="2022-04-10"> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1435,7 +1594,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.NavigationTiming.NavigationStartToFirstResponseStart" - units="ms" expires_after="2022-02-06"> + units="ms" expires_after="2022-04-17"> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1446,7 +1605,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.NavigationTiming.NavigationStartToNavigationCommitSent" - units="ms" expires_after="2022-01-16"> + units="ms" expires_after="2022-04-17"> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -1456,7 +1615,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.PageLoadType" enum="PageLoadType" - expires_after="2021-10-10"> + expires_after="2022-08-30"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -1471,7 +1630,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PageTiming.CachedResourceLoadTime.{RequestDestination}" - units="ms" expires_after="2021-10-05"> + units="ms" expires_after="2022-04-05"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1484,7 +1643,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PageTiming.CommitSentToFirstSubresourceLoadStart" - units="ms" expires_after="2021-10-05"> + units="ms" expires_after="2022-04-05"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1496,7 +1655,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PageTiming.NavigationToFirstSubresourceLoadStart" - units="ms" expires_after="2021-10-05"> + units="ms" expires_after="2022-04-05"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1507,7 +1666,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PageTiming.ResourceLoadTime.{RequestDestination}" - units="ms" expires_after="2021-10-05"> + units="ms" expires_after="2022-04-05"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1520,7 +1679,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PageTiming.TotalSubresourceLoadTimeAtFirstContentfulPaint" - units="ms" expires_after="2021-10-05"> + units="ms" expires_after="2022-04-05"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1532,7 +1691,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PaintTiming.FirstEligibleToPaintToFirstPaint" - units="ms" expires_after="2021-11-06"> + units="ms" expires_after="2022-04-06"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1553,7 +1712,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.PaintTiming.InputToFirstContentfulPaint" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-05-01"> <owner>sullivan@chromium.org</owner> <summary> The time between the OS-level input event that initiated a navigation, and @@ -1594,7 +1753,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PaintTiming.NavigationToFirstEligibleToPaint" - units="ms" expires_after="2021-11-06"> + units="ms" expires_after="2022-04-06"> <owner>cduvall@chromium.org</owner> <owner>jam@chromium.org</owner> <summary> @@ -1605,7 +1764,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-17"> <owner>ksakamoto@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -1629,7 +1788,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Experimental.TotalForegroundDuration" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-20"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -1698,7 +1857,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.FrameCounts.AdFrames.PerFrame.UserActivation" - enum="AdUserActivationStatus" expires_after="2021-10-01"> + enum="AdUserActivationStatus" expires_after="2022-10-01"> <owner>johnidel@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -1714,7 +1873,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.FrameCounts.AdFrames.Total" units="Ad frames" - expires_after="2021-10-01"> + expires_after="2022-10-01"> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> <summary> @@ -1853,7 +2012,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.InteractiveTiming.FirstInputTimestamp4" units="ms" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -1917,6 +2076,37 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="PageLoad.InteractiveTiming.{NormalizedResponsivenessMetric}{Bfcache}.{UserInteractionLatency}" + units="ms" expires_after="2022-05-01"> + <owner>hbsong@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + The {NormalizedResponsivenessMetric} of a page load {Bfcache}, in ms. For + this metric, we measure the latency of a user interaction by the + {UserInteractionLatency} within the user interaction. + + Recorded at the end of the page load lifetime, such as when users navigate + to a new web page. + </summary> + <token key="Bfcache"> + <variant name=""/> + <variant name=".AfterBackForwardCacheRestore"/> + </token> + <token key="NormalizedResponsivenessMetric"> + <variant name="AverageUserInteractionLatencyOverBudget"/> + <variant name="SlowUserInteractionLatencyOverBudget.HighPercentile"/> + <variant name="SlowUserInteractionLatencyOverBudget.HighPercentile2"/> + <variant name="SumOfUserInteractionLatencyOverBudget"/> + <variant name="WorstUserInteractionLatency"/> + <variant name="WorstUserInteractionLatencyOverBudget"/> + </token> + <token key="UserInteractionLatency"> + <variant name="MaxEventDuration"/> + <variant name="TotalEventDuration"/> + </token> +</histogram> + <histogram name="PageLoad.Internal.ClientRedirect.FirstPaintToNavigation" units="ms" expires_after="M77"> <owner>bmcquade@chromium.org</owner> @@ -1942,7 +2132,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Internal.ErrorCode" enum="InternalErrorLoadEvent" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>csharrison@chromium.org</owner> <owner>bmcquade@chromium.org</owner> <summary> @@ -2023,7 +2213,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Internal.PaintTiming.LargestContentfulPaint.ContentType" - enum="LargestContentType" expires_after="2021-12-12"> + enum="LargestContentType" expires_after="2022-04-24"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2036,7 +2226,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.Internal.PaintTiming.LargestContentfulPaint.MainFrame.ContentType" - enum="LargestContentType" expires_after="2021-12-12"> + enum="LargestContentType" expires_after="2022-05-01"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2146,7 +2336,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Internal.Renderer.PresentationTime.DeltaFromSwapTime" - units="ms" expires_after="2021-12-31"> + units="ms" expires_after="2022-04-24"> <owner>jonross@chromium.org</owner> <owner>sadrul@chromium.org</owner> <summary> @@ -2166,7 +2356,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Internal.Renderer.PresentationTime.Valid" - enum="Boolean" expires_after="2021-12-31"> + enum="Boolean" expires_after="2022-04-24"> <owner>jonross@chromium.org</owner> <owner>sadrul@chromium.org</owner> <summary> @@ -2231,7 +2421,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.LayoutInstability.CumulativeShiftScore.MainFrame" - units="scorex10" expires_after="2021-12-12"> + units="scorex10" expires_after="2022-04-17"> <owner>bmcquade@chromium.org</owner> <owner>skobes@chromium.org</owner> <summary> @@ -2256,6 +2446,56 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="PageLoad.LayoutInstability.MaxCumulativeShiftScore.AfterBackForwardCacheRestore.SessionWindow.Gap1000ms.Max5000ms2" + units="scorex10000" expires_after="never"> +<!-- expires-never: used in server pipeline to derive additional metrics --> + + <owner>sullivan@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + Measures the maximum cumulative layout shift (bit.ly/cls-explainer) that has + occurred in after back forward cache restore. The gap between two + consecutive shifts in a window is not bigger than 1000ms and the maximum + window size is 5000ms. This metric's integral value is 10x the fractional + cumulative layout shift score described in the explainer. If {Bfcache} is + triggered, we record the metric when the user navigates away or closes the + page after the page was restored from back-forward cache. Otherwise, we + record it at the end of the page lifetime, such as when the page is being + navigated away from or when a tab is being closed. + + Replaces + PageLoad.LayoutInstability.MaxCumulativeShiftScore.AfterBackForwardCacheRestore.SessionWindow.Gap1000ms.Max5000ms + and increases granularity in order to get more coverage for ~5% of values in + the 0-0.1 range. + </summary> +</histogram> + +<histogram + name="PageLoad.LayoutInstability.MaxCumulativeShiftScore.SessionWindow.Gap1000ms.Max5000ms2" + units="scorex10000" expires_after="never"> +<!-- expires-never: used in server pipeline to derive additional metrics --> + + <owner>sullivan@chromium.org</owner> + <owner>speed-metrics-dev@chromium.org</owner> + <summary> + Measures the maximum cumulative layout shift (bit.ly/cls-explainer) that has + occurred in a Window. The gap between two consecutive shifts in a window is + not bigger than 1000ms and the maximum window size is 5000ms. This metric's + integral value is 10x the fractional cumulative layout shift score described + in the explainer. If {Bfcache} is triggered, we record the metric when the + user navigates away or closes the page after the page was restored from + back-forward cache. Otherwise, we record it at the end of the page lifetime, + such as when the page is being navigated away from or when a tab is being + closed. + + Replaces + PageLoad.LayoutInstability.MaxCumulativeShiftScore.SessionWindow.Gap1000ms.Max5000ms + and increases granularity to get coverage for ~25% of the values in the + 0-0.1 range. + </summary> +</histogram> + +<histogram name="PageLoad.LayoutInstability.MaxCumulativeShiftScore.{Bfcache}{Window}.Gap{Gap}.Max{MaxWindowSize}" units="scorex10" expires_after="2021-12-29"> <owner>hbsong@chromium.org</owner> @@ -2287,7 +2527,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Memory.Aggregate.Max" units="KiB" - expires_after="2021-08-31"> + expires_after="2021-09-30"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -2305,7 +2545,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.Memory.PerFrame.Max" units="KiB" - expires_after="2021-08-31"> + expires_after="2021-09-30"> <owner>cammie@chromium.org</owner> <owner>jkarlin@chromium.org</owner> <owner>johnidel@chromium.org</owner> @@ -2332,7 +2572,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PageTiming.ForegroundDuration" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>bmcquade@chromium.org</owner> <summary> For page loads that start in the foreground, measures the duration of time @@ -2369,7 +2609,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PageTiming.NavigationToFirstForeground" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>bmcquade@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -2380,7 +2620,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PaintTiming.ForegroundToFirstContentfulPaint" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-17"> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2461,7 +2701,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PaintTiming.NavigationToFirstImagePaint" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>sullivan@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2472,7 +2712,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PaintTiming.NavigationToFirstPaint" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>ksakamoto@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2525,7 +2765,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PaintTiming.NavigationToLargestContentfulPaint" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-17"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <owner>chrome-analysis-team@google.com</owner> @@ -2549,7 +2789,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PageLoad.PaintTiming.NavigationToLargestContentfulPaint.MainFrame" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-17"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2565,7 +2805,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PaintTiming.NavigationToLargestContentfulPaint2" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-04-03"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2577,8 +2817,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram + name="PageLoad.PaintTiming.NavigationToLargestContentfulPaint2.CrossSiteSubFrame" + units="ms" expires_after="2022-04-24"> + <owner>sisidovski@google.com</owner> + <owner>kouhei@chromium.org</owner> + <summary> + Similar to PaintTiming.NavigationToLargestContentfulPaint2, this measures + the time in milliseconds from navigation timing's navigation start to the + time when the page first paints the largest content (text or image) in the + cross-site subframe which is the top candidate of largest contentful paint. + </summary> +</histogram> + +<histogram name="PageLoad.PaintTiming.NavigationToLargestContentfulPaint2.MainFrame" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-04-03"> <owner>npm@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> <summary> @@ -2590,7 +2843,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.PaintTiming.ParseStartToFirstContentfulPaint" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-03"> <owner>bmcquade@chromium.org</owner> <owner>csharrison@chromium.org</owner> <owner>speed-metrics-dev@chromium.org</owner> @@ -2601,7 +2854,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.ParseTiming.NavigationToParseStart" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>bmcquade@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -2633,7 +2886,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageLoad.ParseTiming.ParseBlockedOnScriptLoad" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>bmcquade@chromium.org</owner> <owner>csharrison@chromium.org</owner> <summary> @@ -2792,7 +3045,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PageSerialization.MhtmlLoading.LoadResult" - enum="MhtmlLoadResult" expires_after="2021-10-31"> + enum="MhtmlLoadResult" expires_after="2022-05-01"> <owner>sclittle@chromium.org</owner> <owner>offline-dev@chromium.org</owner> <summary>Reports the result of an attempt to load an MHTML archive.</summary> diff --git a/chromium/tools/metrics/histograms/metadata/password/OWNERS b/chromium/tools/metrics/histograms/metadata/password/OWNERS index c5b08ee3c5d..359ffc9a284 100644 --- a/chromium/tools/metrics/histograms/metadata/password/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/password/OWNERS @@ -2,6 +2,7 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # Prefer sending CLs to the owners listed below. # Use chromium-metrics-reviews@google.com as a backup. +ioanap@chromium.org vasilii@chromium.org vsemeniuk@google.com diff --git a/chromium/tools/metrics/histograms/metadata/password/histograms.xml b/chromium/tools/metrics/histograms/metadata/password/histograms.xml index d05a5e6852c..19cadbbf238 100644 --- a/chromium/tools/metrics/histograms/metadata/password/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/password/histograms.xml @@ -27,7 +27,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="KeyboardAccessory.AccessoryActionImpression" - enum="AccessoryAction" expires_after="2022-02-06"> + enum="AccessoryAction" expires_after="2022-04-10"> <owner>fhorschig@chromium.org</owner> <owner>ioanap@chromium.org</owner> <summary> @@ -37,7 +37,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="KeyboardAccessory.AccessoryActionSelected" - enum="AccessoryAction" expires_after="2022-02-06"> + enum="AccessoryAction" expires_after="2022-04-10"> <owner>fhorschig@chromium.org</owner> <owner>ioanap@chromium.org</owner> <summary> @@ -47,7 +47,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="KeyboardAccessory.AccessoryBarShown" - enum="AccessoryBarContents" expires_after="2022-02-06"> + enum="AccessoryBarContents" expires_after="2022-04-10"> <owner>fhorschig@chromium.org</owner> <owner>ioanap@chromium.org</owner> <summary> @@ -58,7 +58,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="KeyboardAccessory.AccessorySheetSuggestionCount" units="count" - expires_after="2021-10-04"> + expires_after="2021-12-05"> <owner>fhorschig@chromium.org</owner> <owner>ioanap@chromium.org</owner> <summary> @@ -89,7 +89,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="KeyboardAccessory.AccessoryToggleClicked" - enum="AccessoryToggleType" expires_after="2022-02-06"> + enum="AccessoryToggleType" expires_after="2022-04-17"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -100,7 +100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="KeyboardAccessory.AccessoryToggleImpression" - enum="AccessoryToggleType" expires_after="2022-02-06"> + enum="AccessoryToggleType" expires_after="2022-04-17"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -110,7 +110,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="KeyboardAccessory.DisabledSavingAccessoryImpressions" - enum="BooleanShown" expires_after="M95"> + enum="BooleanShown" expires_after="M98"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -123,7 +123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="KeyboardAccessory.GenerationDialogChoice.{GenerationType}" - enum="GenerationDialogChoice" expires_after="M95"> + enum="GenerationDialogChoice" expires_after="M98"> <owner>ioanap@chromium.org</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -138,7 +138,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordBubble.CompromisedBubble.CheckClicked" - enum="BooleanClicked" expires_after="2022-01-16"> + enum="BooleanClicked" expires_after="2022-05-01"> <owner>vasilii@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -148,7 +148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordBubble.CompromisedBubble.Type" - enum="PasswordBubbleFollowupType" expires_after="2022-01-16"> + enum="PasswordBubbleFollowupType" expires_after="2022-05-01"> <owner>vasilii@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -158,7 +158,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordBubble.DisplayDisposition" - enum="PasswordBubbleDisplayDisposition" expires_after="2021-12-12"> + enum="PasswordBubbleDisplayDisposition" expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <summary> When the password management bubble opened, what state was it in? @@ -166,7 +166,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordGeneration.Event" enum="PasswordGenerationEvent" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>kazinova@google.com</owner> <owner>kolos@chromium.org</owner> <owner>vasilii@chromium.org</owner> @@ -183,7 +183,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordGeneration.GeneratedPasswordWasEdited" - enum="BooleanGeneratedPasswordWasEdited" expires_after="2022-01-16"> + enum="BooleanGeneratedPasswordWasEdited" expires_after="2022-04-24"> <owner>kolos@chromium.org</owner> <summary> Measures the frequency of user editing of generated passwords. Uploaded once @@ -203,14 +203,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordGeneration.PopupShown" - enum="PasswordGenerationPopupShown" expires_after="2021-12-12"> + enum="PasswordGenerationPopupShown" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary>Records an entry if (and only if) a popup was shown.</summary> </histogram> <histogram name="PasswordGeneration.SubmissionAvailableEvent" - enum="PasswordSubmissionEvent" expires_after="M95"> + enum="PasswordSubmissionEvent" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>kolos@chromium.org</owner> <summary> @@ -221,7 +221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordGeneration.SubmissionEvent" - enum="PasswordSubmissionEvent" expires_after="2022-01-16"> + enum="PasswordSubmissionEvent" expires_after="2022-04-03"> <owner>kazinova@google.com</owner> <owner>kolos@chromium.org</owner> <summary> @@ -232,7 +232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordGeneration.UploadStarted" enum="Boolean" - expires_after="M95"> + expires_after="M99"> <owner>kazinova@google.com</owner> <owner>kolos@chromium.org</owner> <owner>vasilii@chromium.org</owner> @@ -246,7 +246,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordGeneration.UserDecision" - enum="PasswordGenerationUserEvent" expires_after="2022-02-06"> + enum="PasswordGenerationUserEvent" expires_after="2022-04-10"> <owner>ioanap@chromium.org</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -264,7 +264,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AbleToSavePasswordsOnSuccessfulLogin" - enum="BooleanSuccess" expires_after="2021-12-26"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <owner>src/components/password_manager/OWNERS</owner> <summary> @@ -275,7 +275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AcceptedSaveUpdateSubmissionIndicatorEvent" - enum="SubmissionIndicatorEvent" expires_after="2021-12-26"> + enum="SubmissionIndicatorEvent" expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -286,7 +286,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccessPasswordInSettings" - enum="AccessPasswordInSettingsEvent" expires_after="2021-12-12"> + enum="AccessPasswordInSettingsEvent" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -315,7 +315,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.AccountsPerSiteHiRes" - units="units" expires_after="2021-12-26"> + units="units" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -327,7 +327,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStorage.ClearedOnStartup" - enum="PasswordAccountStoreClearedOnStartup" expires_after="M95"> + enum="PasswordAccountStoreClearedOnStartup" expires_after="2022-05-31"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -337,7 +337,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStorage.ClearedOptInForAllAccounts" - units="accounts" expires_after="M95"> + units="accounts" expires_after="2022-05-31"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -349,9 +349,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStorage.MoveToAccountStoreFlowAccepted" - enum="PasswordManager.MoveToAccountStoreTrigger" expires_after="M95"> + enum="PasswordManager.MoveToAccountStoreTrigger" expires_after="2022-05-31"> <owner>treib@chromium.org</owner> <owner>victorvianna@google.com</owner> + <owner>mamir@chromium.org</owner> <summary> When the user accepts to move a password from the profile store to the account store, this records what user action caused the moving flow to be @@ -361,9 +362,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStorage.MoveToAccountStoreFlowOffered" - enum="PasswordManager.MoveToAccountStoreTrigger" expires_after="M95"> + enum="PasswordManager.MoveToAccountStoreTrigger" expires_after="2022-05-31"> <owner>treib@chromium.org</owner> <owner>victorvianna@google.com</owner> + <owner>mamir@chromium.org</owner> <summary> When the user is offered to move a password from the profile store to the account store, this records what user action caused the moving flow to be @@ -373,7 +375,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.AccountStorage.MoveToAccountStorePasswordsCount" - units="credentials" expires_after="M95"> + units="credentials" expires_after="2022-05-31"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -385,7 +387,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStorage.NumOptedInAccountsAfterOptIn" - units="accounts" expires_after="2021-12-12"> + units="accounts" expires_after="2022-05-31"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -396,7 +398,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStorage.NumOptedInAccountsAfterOptOut" - units="accounts" expires_after="M95"> + units="accounts" expires_after="2022-05-31"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -408,9 +410,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.AccountStorage.SignedInAccountFoundDuringOptOut" - enum="Boolean" expires_after="2021-12-12"> + enum="Boolean" expires_after="2022-05-31"> <owner>treib@chromium.org</owner> <owner>victorvianna@google.com</owner> + <owner>mamir@chromium.org</owner> <summary> Records whether a signed-in account was still found by the time Chrome attempted to opt out the user of passwords account storage and clear the @@ -423,9 +426,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.AccountStorage.UnsyncedPasswordsFoundDuringSignOut" - units="passwords" expires_after="2021-12-12"> + units="passwords" expires_after="2022-05-31"> <owner>treib@chromium.org</owner> <owner>victorvianna@google.com</owner> + <owner>mamir@chromium.org</owner> <summary> Records how many passwords in the account store were unsynced when the user signed out of their Google Account. Recorded only in Win/Mac/Linux when a @@ -434,7 +438,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.AccountStorageUserStateDuration" - units="ms" expires_after="M95"> + units="ms" expires_after="2022-05-31"> <!-- Name completed by histogram_suffixes name="PasswordAccountStorageUserState" --> <owner>mamir@chromium.org</owner> @@ -468,7 +472,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.AccountStore.AccountsPerSiteHiRes" - units="units" expires_after="2021-12-12"> + units="units" expires_after="2022-05-01"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <owner>vasilii@chromium.org</owner> @@ -495,6 +499,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.AccountStore.EmptyUsernames.CountInDatabase" units="units" expires_after="M95"> + <obsolete> + Obsolete since M95. + </obsolete> <owner>vasilii@chromium.org</owner> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> @@ -505,7 +512,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStore.InaccessiblePasswords" - units="saved passwords" expires_after="M95"> + units="saved passwords" expires_after="2022-02-20"> <owner>vasilii@chromium.org</owner> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> @@ -516,7 +523,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.AccountStore.TimesPasswordUsed" - units="PasswordUses" expires_after="M95"> + units="PasswordUses" expires_after="2022-05-31"> <owner>battre@chromium.org</owner> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> @@ -531,7 +538,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="PasswordManager.AccountStore.TotalAccountsHiRes.ByType" units="units" - expires_after="2021-12-12"> + expires_after="2022-05-31"> <owner>battre@chromium.org</owner> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> @@ -546,7 +553,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="PasswordManager.AccountStore.TotalAccountsHiRes.WithScheme" - units="accounts" expires_after="M95"> + units="accounts" expires_after="2022-05-31"> <owner>battre@chromium.org</owner> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> @@ -561,7 +568,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStoreBlocklistedEntriesAfterOptIn" - units="credentials" expires_after="M95"> + units="credentials" expires_after="2022-05-31"> <owner>treib@chromium.org</owner> <owner>mamir@chromium.org</owner> <summary> @@ -571,7 +578,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStoreCredentialsAfterOptIn" - units="credentials" expires_after="M95"> + units="credentials" expires_after="2022-05-31"> <owner>treib@chromium.org</owner> <owner>mamir@chromium.org</owner> <summary> @@ -582,6 +589,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.AccountStoreVsProfileStore.{DifferenceType}" units="accounts" expires_after="M95"> + <obsolete> + Obsolete since M95. + </obsolete> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -609,7 +619,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AccountStoreVsProfileStore2.{DifferenceType}" - units="accounts" expires_after="M95"> + units="accounts" expires_after="2022-05-31"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -636,7 +646,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AffiliationBackend.FetchSize" units="facets" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -647,7 +657,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AffiliationBackend.FirstFetchDelay" units="ms" - expires_after="M96"> + expires_after="2022-05-01"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -658,7 +668,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AffiliationBackend.SubsequentFetchDelay" - units="ms" expires_after="M96"> + units="ms" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -670,7 +680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AffiliationFetcher.FetchErrorCode" - enum="NetErrorCodes" expires_after="M96"> + enum="NetErrorCodes" expires_after="2022-05-01"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -681,7 +691,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AffiliationFetcher.FetchHttpResponseCode" - enum="HttpResponseCode" expires_after="M96"> + enum="HttpResponseCode" expires_after="2022-05-01"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -692,7 +702,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AffiliationFetcher.FetchResult" - enum="AffiliationFetchResult" expires_after="M96"> + enum="AffiliationFetchResult" expires_after="2022-04-17"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -702,7 +712,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AffiliationService.GetChangePasswordUsage" - enum="GetChangePasswordUrlMetric" expires_after="2022-01-23"> + enum="GetChangePasswordUrlMetric" expires_after="2022-04-03"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -711,7 +721,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AllPasswordsBottomSheet.UserAction" - enum="AllPasswordsBottomSheetActions" expires_after="2021-10-25"> + enum="AllPasswordsBottomSheetActions" expires_after="M96"> + <obsolete> + Obsolete since M96. + </obsolete> <owner>redatawfik@google.com</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -799,7 +812,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.ApplySyncChanges.AddLoginSyncError" - enum="PasswordAddLoginSyncError" expires_after="2021-12-05"> + enum="PasswordAddLoginSyncError" expires_after="2022-04-24"> <owner>mamir@chromium.org</owner> <owner>mastiz@chromium.org</owner> <summary> @@ -832,7 +845,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AutomaticChange.AcceptanceWithAutoButton" - enum="PasswordCheckResolutionAction" expires_after="2021-12-19"> + enum="PasswordCheckResolutionAction" expires_after="2022-02-20"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <summary> @@ -842,7 +855,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AutomaticChange.AcceptanceWithoutAutoButton" - enum="PasswordCheckResolutionAction" expires_after="2021-12-12"> + enum="PasswordCheckResolutionAction" expires_after="2022-04-17"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <summary> @@ -852,7 +865,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AutomaticChange.ForSitesWithScripts" - enum="PasswordCheckResolutionAction" expires_after="2022-01-09"> + enum="PasswordCheckResolutionAction" expires_after="2022-03-13"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <summary> @@ -863,7 +876,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.AutoSigninFirstRunDialog" - enum="AutoSigninFirstRun" expires_after="2021-10-31"> + enum="AutoSigninFirstRun" expires_after="2022-04-30"> <owner>vasilii@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -872,9 +885,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BiometricAuthPwdFill.AuthRequester" - enum="BiometricAuthRequester" expires_after="2021-10-31"> + enum="BiometricAuthRequester" expires_after="2022-04-03"> <owner>ioanap@chromium.org</owner> - <owner>fhosrchig@google.com</owner> + <owner>fhorschig@chromium.org</owner> <summary> Recorded when a password filling surface or the account chooser dialog requests to re-auth the user via biometrics. It records the UI surface that @@ -883,9 +896,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BiometricAuthPwdFill.AuthResult" - enum="BiometricAuthResult" expires_after="2021-10-31"> + enum="BiometricAuthResult" expires_after="2022-04-03"> <owner>ioanap@chromium.org</owner> - <owner>fhosrchig@google.com</owner> + <owner>fhorschig@chromium.org</owner> <summary> Records the result of the attempt to re-auth the user via biometrics when filling a password or signing in from the account chooser dialog. @@ -893,9 +906,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BiometricAuthPwdFill.CanAuthenticate" - enum="BiometricsAvailability" expires_after="2021-10-31"> + enum="BiometricsAvailability" expires_after="2022-04-10"> <owner>ioanap@chromium.org</owner> - <owner>fhosrchig@google.com</owner> + <owner>fhorschig@chromium.org</owner> <summary> Recorded whenever a password filling surface or the account chooser dialog checks whether it can use biometrics to re-authenticate the user. @@ -903,7 +916,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.BlacklistedSitesHiRes" - units="sites" expires_after="2021-12-12"> + units="sites" expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -938,7 +951,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.CanceledTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -947,7 +960,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.CheckedCredentials" - units="credentials" expires_after="2021-12-12"> + units="credentials" expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -957,14 +970,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.Error" - enum="PasswordLeakDetectionError" expires_after="2021-12-12"> + enum="PasswordLeakDetectionError" expires_after="2022-04-17"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary>Error encountered during the password bulk check.</summary> </histogram> <histogram name="PasswordManager.BulkCheck.LeaksFound" units="credentials" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -973,7 +986,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.PasswordCheckReferrer" - enum="PasswordCheckReferrer" expires_after="2022-01-23"> + enum="PasswordCheckReferrer" expires_after="2022-04-17"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -983,7 +996,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.PasswordCheckReferrerAndroid" - enum="PasswordCheckReferrerAndroid" expires_after="2021-12-26"> + enum="PasswordCheckReferrerAndroid" expires_after="2022-04-10"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -993,7 +1006,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.Time" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -1002,7 +1015,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.TimePerCredential" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -1012,14 +1025,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.BulkCheck.UserAction" - enum="PasswordCheckInteraction" expires_after="2021-12-12"> + enum="PasswordCheckInteraction" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary>User actions performed on the Password Check settings page.</summary> </histogram> <histogram name="PasswordManager.BulkCheck.UserActionAndroid" - enum="PasswordCheckUIUserActionAndroid" expires_after="2021-12-12"> + enum="PasswordCheckUIUserActionAndroid" expires_after="2022-04-24"> <owner>ioanap@chromium.org</owner> <owner>fhorschigg@chromium.org</owner> <summary>User actions performed on the Password Check settings view.</summary> @@ -1042,7 +1055,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.CertificateErrorsWhileSeeingForms" - enum="PasswordCertificateError" expires_after="M95"> + enum="PasswordCertificateError" expires_after="M99"> <owner>battre@chromium.org</owner> <owner>kazinova@google.com</owner> <owner>chrome-password-manager-metrics-alerts@google.com</owner> @@ -1068,7 +1081,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.CleanedUpPasswords" units="units" - expires_after="M95"> + expires_after="2021-12-05"> <owner>vasilii@chromium.org</owner> <owner>src/components/password_manager/OWNERS</owner> <summary> @@ -1096,7 +1109,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.CompromisedCredentials.CountLeaked" - units="credentials" expires_after="2022-02-06"> + units="credentials" expires_after="2022-04-10"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -1106,7 +1119,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.CompromisedCredentials.CountLeakedAfterBulkCheck" - units="credentials" expires_after="2022-02-06"> + units="credentials" expires_after="2022-04-10"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -1116,7 +1129,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.CompromisedCredentials.CountPhished" - units="credentials" expires_after="2022-02-06"> + units="credentials" expires_after="2022-04-17"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -1125,7 +1138,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.CredentialEditError" - enum="CredentialEditError" expires_after="M97"> + enum="CredentialEditError" expires_after="M101"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -1135,7 +1148,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.CredentialEntryActions.{CredentialEntryType}" - enum="CredentialEntryAction" expires_after="M97"> + enum="CredentialEntryAction" expires_after="M101"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -1150,18 +1163,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.CredentialsCountFromAccountStoreAfterUnlock" - units="credentials" expires_after="M95"> + units="credentials" expires_after="2022-05-31"> <owner>fhorschig@chromium.org</owner> <owner>mamir@chromium.org</owner> <summary> - Records how many credentials from the account store are available to a user - right after they unlocked the account store. If a credential is an exact - duplicate with a local credential, it still counts into this metric. + Recorded after unlocking the account store from the password filling flow. + Records how many credentials from the account store can be used to fill the + current password form. If a credential is an exact duplicate with a local + credential, it still counts into this metric. </summary> </histogram> <histogram name="PasswordManager.CredentialsWithDuplicates" units="units" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1191,7 +1205,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.DefaultPasswordStoreSet" - enum="PasswordManager.Store" expires_after="2021-12-26"> + enum="PasswordManager.Store" expires_after="2022-04-10"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -1201,7 +1215,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.DeleteUndecryptableLoginsReturnValue" - enum="DeleteCorruptedPasswordsResult" expires_after="2021-12-05"> + enum="DeleteCorruptedPasswordsResult" expires_after="2022-05-01"> <owner>vasilii@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -1212,7 +1226,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.DropdownShown.OffTheRecord" units="units" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -1222,7 +1236,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.DynamicFormChanges" units="units" - expires_after="M95"> + expires_after="M99"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -1235,7 +1249,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.EditsInSaveBubble" - enum="PasswordManagerEditsInSaveBubbleEnum" expires_after="2022-01-02"> + enum="PasswordManagerEditsInSaveBubbleEnum" expires_after="2022-04-17"> <owner>vasilii@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -1259,7 +1273,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.Enabled" enum="BooleanEnabled" - expires_after="2022-02-22"> + expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1282,7 +1296,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.FilledCredentialWasFromAndroidApp" - enum="PasswordManagerFilledAndroidCredentials" expires_after="M95"> + enum="PasswordManagerFilledAndroidCredentials" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1291,7 +1305,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.FillingAssistance" - enum="PasswordManagerFillingAssistance" expires_after="2021-12-12"> + enum="PasswordManagerFillingAssistance" expires_after="2022-04-17"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -1315,7 +1329,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.FillingSource" - enum="PasswordManagerFillingSource" expires_after="2022-01-02"> + enum="PasswordManagerFillingSource" expires_after="2022-04-03"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -1327,7 +1341,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.FillSuggestionsIncludeAndroidAppCredentials" - enum="PasswordManagerOfferedAndroidCredentials" expires_after="M95"> + enum="PasswordManagerOfferedAndroidCredentials" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1350,7 +1364,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.FirstWaitForUsernameReason" - enum="PasswordManagerFirstWaitForUsernameReason" expires_after="2021-12-12"> + enum="PasswordManagerFirstWaitForUsernameReason" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -1363,7 +1377,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.FormDataDeserializationStatus" - enum="FormDataDeserializationStatus" expires_after="M95"> + enum="FormDataDeserializationStatus" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1384,7 +1398,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.FormVisited.PerProfileType" - enum="BrowserProfileType" expires_after="2022-02-02"> + enum="BrowserProfileType" expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -1394,7 +1408,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.GeneratedFormHasNoFormManager" - enum="BooleanFormManager" expires_after="M95"> + enum="BooleanFormManager" expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>kolos@chromium.org</owner> <summary> @@ -1448,7 +1462,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.HttpCredentials" - enum="PasswordManagerHttpCredentialType" expires_after="M95"> + enum="PasswordManagerHttpCredentialType" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1460,7 +1474,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.HttpPasswordMigrationCount" - units="saved credentials" expires_after="M95"> + units="saved credentials" expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1470,7 +1484,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.HttpPasswordMigrationMode" - enum="HttpPasswordMigrationMode" expires_after="M95"> + enum="HttpPasswordMigrationMode" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1480,7 +1494,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.ImportedPasswordsPerUserInCSV" units="units" - expires_after="M95"> + expires_after="M98"> <owner>vasilii@chromium.org</owner> <owner>src/components/password_manager/OWNERS</owner> <summary> @@ -1490,7 +1504,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.ImportPasswordFromCSVResult" - enum="PasswordImportFromCSVResult" expires_after="M95"> + enum="PasswordImportFromCSVResult" expires_after="M98"> <owner>vasilii@chromium.org</owner> <owner>src/components/password_manager/OWNERS</owner> <summary> @@ -1500,7 +1514,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.InaccessiblePasswords" units="saved passwords" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <owner>mamir@chromium.org</owner> <summary> @@ -1528,7 +1542,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.IsSyncPasswordHashSaved" - enum="IsSyncPasswordHashSaved" expires_after="2021-12-12"> + enum="IsSyncPasswordHashSaved" expires_after="2022-05-01"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1539,7 +1553,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.IsSyncPasswordHashSavedForAdvancedProtectionUser" - enum="IsSyncPasswordHashSaved" expires_after="2021-10-11"> + enum="IsSyncPasswordHashSaved" expires_after="2022-10-11"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1550,7 +1564,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.ItemSelected.OffTheRecord" units="units" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -1560,7 +1574,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.JavaScriptOnlyValueInSubmittedForm" - enum="JavaScriptOnlyValueInPasswordForm" expires_after="2021-10-10"> + enum="JavaScriptOnlyValueInPasswordForm" expires_after="2022-02-28"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -1596,7 +1610,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.AnalyzeSingleLeakResponseResult" - enum="PasswordAnalyzeLeakResponseResult" expires_after="2021-12-12"> + enum="PasswordAnalyzeLeakResponseResult" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary>Result of analyzing a single leak response.</summary> @@ -1614,7 +1628,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.LeakDetection.DialogDismissalReason" enum="PasswordLeakDetectionDialogDismissalReason" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1637,7 +1651,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.Error" - enum="PasswordLeakDetectionError" expires_after="M96"> + enum="PasswordLeakDetectionError" expires_after="2022-04-17"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1646,7 +1660,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.HttpResponseCode" - enum="HttpResponseCode" expires_after="2021-10-10"> + enum="HttpResponseCode" expires_after="2022-04-17"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1656,7 +1670,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.IsPasswordReused" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -1666,7 +1680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.IsPasswordSaved" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>vasilii@chromium.org</owner> <owner>vsemeniuk@google.com</owner> <summary> @@ -1688,7 +1702,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.LookupSingleLeakResponseResult" - enum="PasswordLeakLookupResponseResult" expires_after="2021-12-19"> + enum="PasswordLeakLookupResponseResult" expires_after="2022-04-10"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1711,7 +1725,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.NotifyIsLeakedTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1721,7 +1735,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.ObtainAccessTokenTime" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1731,7 +1745,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.PrepareSingleLeakRequestTime" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1740,7 +1754,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.ReceiveSingleLeakResponseTime" - units="ms" expires_after="M100"> + units="ms" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1750,7 +1764,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.SingleLeakResponsePrefixes" - units="prefixes" expires_after="2021-12-12"> + units="prefixes" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1760,7 +1774,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LeakDetection.SingleLeakResponseSize" - units="bytes" expires_after="2021-12-12"> + units="bytes" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1770,14 +1784,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.LoginDatabaseInit" - enum="LoginDatabaseInitError" expires_after="2021-12-26"> + enum="LoginDatabaseInitError" expires_after="2022-04-17"> <owner>vasilii@chromium.org</owner> <owner>mamir@chromium.org</owner> <summary>An error on LoginDatabase initialization.</summary> </histogram> <histogram name="PasswordManager.ManagePasswordsReferrer" - enum="ManagePasswordsReferrer" expires_after="2021-12-12"> + enum="ManagePasswordsReferrer" expires_after="2022-04-17"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1813,7 +1827,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.MediationOptional" - enum="CredentialManagerGetResult" expires_after="M94"> + enum="CredentialManagerGetResult" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1823,7 +1837,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.MediationRequired" - enum="CredentialManagerGetResult" expires_after="M94"> + enum="CredentialManagerGetResult" expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1834,7 +1848,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.MediationSilent" - enum="CredentialManagerGetResult" expires_after="M94"> + enum="CredentialManagerGetResult" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1844,7 +1858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.MergeSyncData.AddLoginSyncError" - enum="PasswordAddLoginSyncError" expires_after="2021-12-05"> + enum="PasswordAddLoginSyncError" expires_after="2022-05-01"> <owner>mamir@chromium.org</owner> <owner>mastiz@chromium.org</owner> <summary> @@ -1866,7 +1880,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.MoveUIDismissalReason" - enum="PasswordManagerUIDismissalReason" expires_after="2021-12-26"> + enum="PasswordManagerUIDismissalReason" expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="PasswordAccountStorageUserState" --> <owner>mamir@chromium.org</owner> @@ -1879,7 +1893,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.NewlySavedPasswordIsGenerated" - enum="BooleanNewlySavedPasswordIsGenerated" expires_after="2021-12-12"> + enum="BooleanNewlySavedPasswordIsGenerated" expires_after="2022-04-17"> <owner>nepper@chromium.org</owner> <owner>battre@chromium.org</owner> <owner>kolos@chromium.org</owner> @@ -1890,7 +1904,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.NonSyncPasswordHashChange" - enum="GaiaPasswordHashChange" expires_after="2021-10-04"> + enum="GaiaPasswordHashChange" expires_after="2022-10-04"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1902,6 +1916,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.NumFormManagersCleared" units="count" expires_after="2021-09-19"> + <obsolete> + Removed in M96. + </obsolete> <owner>vasilii@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -1925,7 +1942,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.OsPasswordStatus" - enum="PasswordManagerOsPasswordStatus" expires_after="2021-12-12"> + enum="PasswordManagerOsPasswordStatus" expires_after="2021-09-23"> + <obsolete> + Removed in M96. + </obsolete> <owner>vasilii@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -1947,7 +1967,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordDropdownItemSelected" - enum="PasswordDropdownSelectedOption" expires_after="2021-12-12"> + enum="PasswordDropdownSelectedOption" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1956,14 +1976,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordDropdownShown" - enum="PasswordDropdownState" expires_after="2021-10-10"> + enum="PasswordDropdownState" expires_after="2022-02-28"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary>Logs the state of the password dropdown when it's shown.</summary> </histogram> <histogram name="PasswordManager.PasswordEditUpdatedValues" - enum="PasswordEditUpdatedValues" expires_after="2021-12-12"> + enum="PasswordEditUpdatedValues" expires_after="2022-04-24"> <owner>vsemeniuk@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -1973,7 +1993,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordReuse.NumberOfMatches" - units="credentials" expires_after="2022-01-23"> + units="credentials" expires_after="2022-04-03"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2020,7 +2040,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordReuse.TotalPasswords" - units="credentials" expires_after="2022-02-06"> + units="credentials" expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2050,7 +2070,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordScriptsFetcher.CacheState" - enum="PasswordScriptsFetcherCacheState" expires_after="2021-12-12"> + enum="PasswordScriptsFetcherCacheState" expires_after="2022-04-17"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <summary> @@ -2061,7 +2081,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordManager.PasswordScriptsFetcher.HttpResponseAndNetErrorCode" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-12-12"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-04-17"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <summary> @@ -2071,14 +2091,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordScriptsFetcher.ParsingResult" - enum="PasswordScriptsFetcherParsingResult" expires_after="2021-12-12"> + enum="PasswordScriptsFetcherParsingResult" expires_after="2022-04-17"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <summary>Result of parsing of a list of available password scripts.</summary> </histogram> <histogram name="PasswordManager.PasswordScriptsFetcher.ResponseTime" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-04-24"> <owner>kolos@chromium.org</owner> <owner>battre@chromium.org</owner> <summary> @@ -2086,6 +2106,44 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="PasswordManager.PasswordStore.GetAllLoginsAsync" units="ms" + expires_after="2021-09-29"> + <obsolete> + Renamed to PasswordManager.PasswordStore.GetAllLoginsAsync.Latency on + 2021-09-29. + </obsolete> + <owner>fhorschig@chromium.org</owner> + <owner>vasilii@chromium.org</owner> + <summary> + Real-time duration of the asynchronous call to get all logins from the + PasswordStore backend. + </summary> +</histogram> + +<histogram + name="PasswordManager.PasswordStoreAndroidBackend.GetAllLoginsAsync.Latency" + units="ms" expires_after="2022-06-30"> + <owner>fhorschig@chromium.org</owner> + <owner>vasilii@chromium.org</owner> + <summary> + Real-time duration of the asynchronous call to retrieve all logins from the + PasswordStore Android backend. Recorded when the asynchronous job has + returned. + </summary> +</histogram> + +<histogram + name="PasswordManager.PasswordStoreAndroidBackend.GetAllLoginsAsync.Success" + enum="BooleanSuccess" expires_after="2022-06-30"> + <owner>fhorschig@chromium.org</owner> + <owner>vasilii@chromium.org</owner> + <summary> + Records whether GetAllLoginsAsync() succeeded in retrieving all logins from + the PasswordStore Android backend. Recorded when the asynchronous job has + returned. False is emitted if an error occurs; otherwise true is emitted. + </summary> +</histogram> + <histogram name="PasswordManager.PasswordStoreDeletionsHaveSynced" enum="BooleanSuccess" expires_after="M92"> <obsolete> @@ -2104,7 +2162,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordStoreInitResult" enum="BooleanSuccess" - expires_after="M95"> + expires_after="M98"> <owner>vasilii@chromium.org</owner> <owner>src/components/password_manager/OWNERS</owner> <summary> @@ -2114,7 +2172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.PasswordSyncState" enum="PasswordSyncState" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2146,7 +2204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.ReauthToAccessPasswordInSettings" - enum="PasswordManager.ReauthResult" expires_after="M95"> + enum="PasswordManager.ReauthResult" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2180,7 +2238,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.RequirementsSpecFetcher.HttpResponseCode" - enum="HttpResponseCode" expires_after="M95"> + enum="HttpResponseCode" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -2189,7 +2247,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.RequirementsSpecFetcher.NetErrorCode" - enum="NetErrorCodes" expires_after="M95"> + enum="NetErrorCodes" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -2198,7 +2256,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.RequirementsSpecFetcher.NetworkDuration" - units="ms" expires_after="M95"> + units="ms" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -2208,7 +2266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.RequirementsSpecFetcher.Result" - enum="PasswordRequirementsFetcherResult" expires_after="M95"> + enum="PasswordRequirementsFetcherResult" expires_after="M99"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -2217,7 +2275,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.ReusedPasswordType" enum="ReusedPasswordType" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2250,7 +2308,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.SaveUIDismissalReason" - enum="PasswordManagerUIDismissalReason" expires_after="2021-12-12"> + enum="PasswordManagerUIDismissalReason" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="PasswordAccountStorageUserState" --> <owner>vasilii@chromium.org</owner> @@ -2271,7 +2329,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.SavingOnUsernameFirstFlow" - enum="SavingOnUsernameFirstFlow" expires_after="2021-10-10"> + enum="SavingOnUsernameFirstFlow" expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2282,7 +2340,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.StoreDecryptionResult" - enum="PasswordDecryptionResult" expires_after="2022-02-09"> + enum="PasswordDecryptionResult" expires_after="2022-05-01"> <owner>cfroussios@chromium.org</owner> <owner>kazinova@google.com</owner> <summary> @@ -2291,7 +2349,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.StoresUsedForFillingInLast28Days" - enum="PasswordManagerFillingSource" expires_after="2022-01-31"> + enum="PasswordManagerFillingSource" expires_after="2022-04-03"> <owner>mamir@chromium.org</owner> <owner>treib@chromium.org</owner> <summary> @@ -2325,7 +2383,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.SubmittedFormType" enum="PasswordFormType" - expires_after="M95"> + expires_after="M99"> <owner>kazinova@google.com</owner> <owner>kolos@chromium.org</owner> <summary> @@ -2346,7 +2404,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.SuccessfulLoginHappened" - enum="BooleanSuccessfulLoginHappenedOnHttps" expires_after="2022-01-23"> + enum="BooleanSuccessfulLoginHappenedOnHttps" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>kolos@chromium.org</owner> <summary> @@ -2357,7 +2415,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.SuccessfulSubmissionIndicatorEvent" - enum="SubmissionIndicatorEvent" expires_after="2021-12-26"> + enum="SubmissionIndicatorEvent" expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2378,7 +2436,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.SyncMetadataReadError" - enum="PasswordSyncMetadataReadError" expires_after="2022-02-06"> + enum="PasswordSyncMetadataReadError" expires_after="2022-04-10"> <owner>mamir@chromium.org</owner> <owner>mastiz@chromium.org</owner> <summary> @@ -2398,7 +2456,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.TimeBetweenStoreAndServer" units="ms" - expires_after="2021-10-25"> + expires_after="2022-04-25"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -2409,7 +2467,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.TimesPasswordUsed" - units="PasswordUses" expires_after="2021-10-28"> + units="PasswordUses" expires_after="2022-04-28"> <owner>kazinova@google.com</owner> <owner>battre@chromium.org</owner> <summary> @@ -2422,7 +2480,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.TotalAccountsHiRes.ByType" - units="units" expires_after="2021-12-26"> + units="units" expires_after="2022-04-03"> <owner>battre@chromium.org</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2434,7 +2492,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordManager.TotalAccountsHiRes.WithScheme" - units="accounts" expires_after="2022-01-02"> + units="accounts" expires_after="2022-04-17"> <owner>battre@chromium.org</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2447,7 +2505,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.TouchToFill.CredentialIndex" units="index" - expires_after="2021-12-19"> + expires_after="2022-04-17"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -2457,7 +2515,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.TouchToFill.DismissalReason" - enum="BottomSheet.StateChangeReason" expires_after="2021-12-19"> + enum="BottomSheet.StateChangeReason" expires_after="2022-04-17"> <owner>ioanap@chromium.org</owner> <owner>fhorschig@chromium.org</owner> <summary> @@ -2483,7 +2541,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.UIDismissalReason" - enum="PasswordManagerUIDismissalReason" expires_after="2021-12-19"> + enum="PasswordManagerUIDismissalReason" expires_after="2022-04-17"> <owner>vasilii@chromium.org</owner> <summary> Why was the password manager's UI (bubble or infobar) closed? Save and @@ -2505,7 +2563,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.UpdateUIDismissalReason" - enum="PasswordManagerUIDismissalReason" expires_after="2021-12-12"> + enum="PasswordManagerUIDismissalReason" expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <summary>Why was the update password UI (bubble or infobar) closed?</summary> </histogram> @@ -2541,7 +2599,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.WeakCheck.CheckedPasswords" units="passwords" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2550,7 +2608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.WeakCheck.PasswordScore" - enum="PasswordWeaknessScore" expires_after="2021-12-12"> + enum="PasswordWeaknessScore" expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2560,14 +2618,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordManager.WeakCheck.Time" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary>The time it took to complete the passwords weak check.</summary> </histogram> <histogram name="PasswordManager.WeakCheck.WeakPasswords" units="passwords" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>kazinova@google.com</owner> <owner>vasilii@chromium.org</owner> <summary> @@ -2637,6 +2695,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordProtection.AndroidVisualFeaturesNativeViewHeight" units="dip" expires_after="2021-10-04"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2650,6 +2711,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordProtection.AndroidVisualFeaturesNativeViewNull" enum="BooleanNull" expires_after="2021-10-04"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2663,6 +2727,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordProtection.AndroidVisualFeaturesNativeViewWidth" units="dip" expires_after="2021-10-04"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2676,6 +2743,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PasswordProtection.AndroidVisualFeaturesViewNull" enum="BooleanNull" expires_after="2021-10-04"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2688,7 +2758,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.DomFeatureExtractionDuration" units="ms" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2733,7 +2803,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.ModalWarningDialogAction" - enum="PasswordProtectionWarningAction" expires_after="2021-12-19"> + enum="PasswordProtectionWarningAction" expires_after="2022-04-03"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2744,7 +2814,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.ModalWarningDialogLifetime" units="ms" - expires_after="2021-11-14"> + expires_after="2022-10-06"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2787,7 +2857,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.PasswordProtectionResponseOrErrorCode" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-11-29"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-04-24"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2829,7 +2899,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="PasswordProtection.RequestOutcome" - enum="PasswordProtectionRequestOutcome" expires_after="2021-12-12"> + enum="PasswordProtectionRequestOutcome" expires_after="2022-04-17"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2840,7 +2910,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.RequestReferringAppSource" - enum="PasswordProtectionReferringAppSource" expires_after="2021-12-15"> + enum="PasswordProtectionReferringAppSource" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2851,7 +2921,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.RequestWithToken.{TriggerType}" - units="BooleanSent" expires_after="2021-10-06"> + units="BooleanSent" expires_after="2022-04-06"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2863,7 +2933,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.SampleReportSent" units="Boolean" - expires_after="2021-10-31"> + expires_after="2022-10-31"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2874,7 +2944,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PasswordProtection.Verdict" enum="PasswordProtectionVerdict" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/payment/histograms.xml b/chromium/tools/metrics/histograms/metadata/payment/histograms.xml index a1986dfc9b2..b48dc28eec6 100644 --- a/chromium/tools/metrics/histograms/metadata/payment/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/payment/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="PaymentRequest.CheckoutFunnel" - enum="PaymentRequestCheckoutFunnelSteps" expires_after="2021-12-31"> + enum="PaymentRequestCheckoutFunnelSteps" expires_after="2022-03-06"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> @@ -51,7 +51,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.Events" units="bitfield value" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> @@ -61,7 +61,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.Events2" units="bitfield value" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> @@ -71,7 +71,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.JourneyLoggerHasRecorded" enum="Boolean" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> @@ -250,7 +250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.TimeToCheckout.Completed" units="ms" - expires_after="2021-12-31"> + expires_after="2022-03-06"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> @@ -271,7 +271,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.TimeToCheckout.Completed.SkippedShow" - units="ms" expires_after="2021-12-31"> + units="ms" expires_after="2022-03-06"> <!-- Name completed by histogram_suffixes name="PaymentRequestCompletedInstrument" --> <owner>rouslan@chromium.org</owner> @@ -283,7 +283,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.TimeToCheckout.OtherAborted" units="ms" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> @@ -293,7 +293,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.TimeToCheckout.UserAborted" units="ms" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="PaymentRequestPaymentSheetShowStatus" --> <owner>rouslan@chromium.org</owner> @@ -305,7 +305,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.TransactionAmount.Completed" - enum="PaymentRequestTransactionSize" expires_after="2021-12-31"> + enum="PaymentRequestTransactionSize" expires_after="2022-03-06"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> @@ -315,7 +315,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PaymentRequest.TransactionAmount.Triggered" - enum="PaymentRequestTransactionSize" expires_after="2021-12-31"> + enum="PaymentRequestTransactionSize" expires_after="2022-03-06"> <owner>rouslan@chromium.org</owner> <owner>web-payments-team@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/permissions/OWNERS b/chromium/tools/metrics/histograms/metadata/permissions/OWNERS index 0911e08c5e1..9306fd21cbb 100644 --- a/chromium/tools/metrics/histograms/metadata/permissions/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/permissions/OWNERS @@ -2,4 +2,5 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # Prefer sending CLs to the owners listed below. # Use chromium-metrics-reviews@google.com as a backup. +andypaicu@chromium.org ravjit@chromium.org diff --git a/chromium/tools/metrics/histograms/metadata/permissions/histograms.xml b/chromium/tools/metrics/histograms/metadata/permissions/histograms.xml index eb715905c0f..88ff6f46744 100644 --- a/chromium/tools/metrics/histograms/metadata/permissions/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/permissions/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="BrowserDialogs.ExternalProtocol.HandleState" - enum="HandleStateType" expires_after="2022-01-31"> + enum="HandleStateType" expires_after="2022-05-01"> <owner>engedy@chromium.org</owner> <owner>ravjit@chromium.org</owner> <owner>dominickn@chromium.org</owner> @@ -43,21 +43,55 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> - Tracks whether a permission was granted, rejected, etc. The suffix of the - histogram indicates which particular permission. + Tracks user interactions on permission prompts, aggregated across all UI + dispositions, including quiet permission prompts due to CPSS or Crowd Deny. + + One sample is recorded each time a permission request triggers a prompt, + even if the prompt UI is never seen by the user. This histogram does not + include permission requests that are granted/denied because the user had + previously made a decision; nor requests that are denied by Permission + Policy, per-site permission embargo, or are cancelled while queued. + + The suffix of the histogram indicates which particular permission. </summary> </histogram> -<histogram name="Permissions.Action.WithDisposition" enum="PermissionAction" - expires_after="2021-12-12"> +<histogram name="Permissions.Action.WithDisposition.{DispositionType}" + enum="PermissionAction" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Tracks the action that a user had taken per permission prompt UI disposition. Suffixed by the UI disposition that the prompt used. Recorded when a permission prompt has been resolved. </summary> + <token key="DispositionType"> + <variant name="AnchoredBubble" + summary="A bubble under the site settings padlock"/> + <variant name="CustomModalDialog" summary="Other custom modal dialogs"/> + <variant name="LocationBarLeftChip" + summary="A chip on the left-hand side of the location bar that shows + a bubble when clicked"/> + <variant name="LocationBarLeftQuietChip" + summary="A less prominent version of a chip on the left-hand side of + the location bar that shows a bubble when clicked"/> + <variant name="LocationBarRightAnimatedIcon" + summary="An animated indicator on the right-hand side of the location + bar"/> + <variant name="LocationBarRightStaticIcon" + summary="A static indicator on the right-hand side of the location + bar"/> + <variant name="MessageUI" + summary="A message bubble near top of the screen and below the + location bar (alternative to Infobar UI)"/> + <variant name="MiniInfobar" + summary="An initially-collapsed infobar at the bottom of the page"/> + <variant name="ModalDialog" summary="A modal dialog"/> + <variant name="NoneVisible" summary="There was no UI being shown"/> + <variant name="NotApplicable" summary="No permission prompt at all"/> + </token> </histogram> <histogram name="Permissions.API.CreatedPermissionStatusObjects" units="units" @@ -73,7 +107,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.AutoBlocker.EmbargoPromptSuppression" - enum="PermissionEmbargoStatus" expires_after="M100"> + enum="PermissionEmbargoStatus" expires_after="2022-05-01"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -90,7 +124,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.AutoBlocker.EmbargoStatus" - enum="PermissionEmbargoStatus" expires_after="M100"> + enum="PermissionEmbargoStatus" expires_after="2022-04-24"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -113,7 +147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.BatteryLevel.Accepted.LocationSettingsDialog" - units="%" expires_after="M96"> + units="%" expires_after="2022-04-24"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> @@ -170,7 +204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Chip.TimeToInteraction" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>bsep@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>olesiamarukhno@google.com</owner> @@ -181,7 +215,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.CrowdDeny.DidHoldbackQuietUi" enum="Boolean" - expires_after="M96"> + expires_after="2022-05-01"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> @@ -199,7 +233,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.CrowdDeny.PreloadData.DelayedPushNotification" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-03-06"> <owner>elklm@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -227,7 +261,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.CrowdDeny.PreloadData.NotificationUxQuality" - enum="CrowdDenyNotificationUxQuality" expires_after="2021-12-12"> + enum="CrowdDenyNotificationUxQuality" expires_after="2022-04-24"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> @@ -238,7 +272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.CrowdDeny.PreloadData.VersionAtAbuseCheckTime" - units="date" expires_after="2021-12-12"> + units="date" expires_after="2022-04-17"> <owner>elklm@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -260,7 +294,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.CrowdDeny.SafeBrowsing.RequestDuration" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> @@ -272,7 +306,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.CrowdDeny.SafeBrowsing.Verdict" - enum="CrowdDenySafeBrowsingVerdict" expires_after="M100"> + enum="CrowdDenySafeBrowsingVerdict" expires_after="2022-05-01"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -349,7 +383,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Engagement.Accepted" units="%" - expires_after="2021-12-26"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -359,7 +393,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Engagement.AcceptedOnce" units="%" - expires_after="2022-01-02"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -370,7 +404,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Engagement.Denied" units="%" - expires_after="2021-10-25"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -380,7 +414,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Engagement.Dismissed" units="%" - expires_after="2021-10-25"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -390,7 +424,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Engagement.Ignored" units="%" - expires_after="2021-10-25"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -400,7 +434,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.MissingOSLevelPermission.Action" - enum="PermissionAction" expires_after="2022-01-02"> + enum="PermissionAction" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> @@ -412,10 +446,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.MissingOSLevelPermission.ShouldShow" - enum="Boolean" expires_after="2021-04-04"> + enum="Boolean" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Recorded when the "Chrome needs permission..." infobar might be displayed to the user because a site already has the permission but Chrome @@ -428,7 +463,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.PredictionService.GeolocationRequest" - enum="BooleanSent" expires_after="M96"> + enum="BooleanSent" expires_after="2022-04-17"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -439,7 +474,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.PredictionService.Request" enum="BooleanSent" - expires_after="M96"> + expires_after="2022-04-10"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -450,9 +485,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Accepted" enum="PermissionRequestType" - expires_after="2021-12-26"> + expires_after="2022-08-25"> <owner>dominickn@chromium.org</owner> <owner>kcarattini@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Tracks the permission bubbles (merged and non-merged) that are accepted. Merged bubbles are considered accepted if all permissions are allowed. @@ -460,7 +496,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Accepted.PriorDismissCount2" units="units" - expires_after="2021-12-31"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -473,7 +509,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Accepted.PriorIgnoreCount2" units="units" - expires_after="2021-12-31"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -524,9 +560,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Denied" enum="PermissionRequestType" - expires_after="2021-12-26"> + expires_after="2022-08-25"> <owner>dominickn@chromium.org</owner> <owner>kcarattini@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Tracks the permission bubbles (merged and non-merged) that are denied. Merged bubbles are considered denied if any permission is denied. @@ -547,7 +584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Denied.PriorIgnoreCount2" units="units" - expires_after="2021-12-31"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -560,7 +597,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Dismissed.PriorDismissCount2" units="units" - expires_after="2021-12-31"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -573,7 +610,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Dismissed.PriorIgnoreCount2" units="units" - expires_after="2021-12-31"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -586,7 +623,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Ignored.PriorDismissCount2" units="units" - expires_after="2021-12-31"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -599,7 +636,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Ignored.PriorIgnoreCount2" units="units" - expires_after="2021-12-31"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -612,10 +649,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Infobar.DetailsExpanded" enum="Boolean" - expires_after="M82"> + expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Tracks whether the user has expanded the infobar notification permission request. @@ -623,7 +661,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.Prompt.Shown" enum="PermissionRequestType" - expires_after="2021-08-22"> + expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -667,7 +705,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.QuietChip.TimeToInteraction" units="ms" - expires_after="2021-10-25"> + expires_after="2022-08-25"> <owner>elklm@chromium.org</owner> <owner>engedy@chromium.org</owner> <summary> @@ -681,10 +719,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Permissions.QuietNotificationPrompts.DidEnableAdapativelyInPrefs" - enum="Boolean" expires_after="2021-10-10"> + enum="Boolean" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Records, each time the quiet UI gets enabled in preferences, whether it was enabled by the adaptive activation logic. @@ -693,10 +732,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Permissions.QuietNotificationPrompts.EnabledStateInPrefsChangedTo" - enum="BooleanEnabled" expires_after="2021-10-10"> + enum="BooleanEnabled" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Records when the quiet notification permission UI state changes, that is, it either gets enabled or disabled, in preferences. @@ -704,10 +744,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.QuietNotificationPrompts.IsEnabledInPrefs" - enum="BooleanEnabled" expires_after="2021-12-12"> + enum="BooleanEnabled" expires_after="2022-08-25"> <owner>andypaicu@chromium.org</owner> <owner>engedy@chromium.org</owner> <owner>hkamila@chromium.org</owner> + <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> Records whether the quiet notification permission UI is enabled in preferences at profile creation. No sample recorded when notifications are @@ -716,7 +757,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Permissions.Revocation.ElapsedTimeSinceGrant" - units="seconds" expires_after="2021-10-25"> + units="seconds" expires_after="2022-08-25"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -747,7 +788,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Permissions.Usage.ElapsedTimeSinceGrant" - units="seconds" expires_after="2021-10-25"> + units="seconds" expires_after="2022-04-17"> <owner>engedy@chromium.org</owner> <owner>src/components/permissions/PERMISSIONS_OWNERS</owner> <summary> @@ -758,7 +799,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Permissions.WebHid.ChooserClosed" enum="WebHidChooserClosed" - expires_after="2022-01-20"> + expires_after="2022-04-10"> <owner>mattreynolds@chromium.org</owner> <owner>deviceapi-team@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/phonehub/histograms.xml b/chromium/tools/metrics/histograms/metadata/phonehub/histograms.xml index 3740cd7ba6a..46015dd04cc 100644 --- a/chromium/tools/metrics/histograms/metadata/phonehub/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/phonehub/histograms.xml @@ -22,9 +22,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="PhoneHub.Adoption.FeatureStatusChangesSinceLogin" - enum="PhoneHubFeatureStatus" expires_after="M98"> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + enum="PhoneHubFeatureStatus" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> The feature status changes to PhoneHub after login. Note that this does not include the steady state feature status on user login or the status changes @@ -33,16 +33,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.Adoption.LoginFeatureStatus" - enum="PhoneHubFeatureStatus" expires_after="M98"> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + enum="PhoneHubFeatureStatus" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary>The steady state feature status of PhoneHub on user login.</summary> </histogram> <histogram name="PhoneHub.CompletedUserAction" enum="PhoneHubUserAction" - expires_after="2022-01-30"> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Measures actions taken by the user as part of the Phone Hub feature; emitted when the user attempts the actions described in the PhoneHubUserAction enum. @@ -51,9 +51,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="PhoneHub.Connection.Duration" units="ms" expires_after="M99"> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> +<histogram name="PhoneHub.Connection.Duration" units="ms" + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> The duration of time the phone is in the connected state, and becomes disconnected. @@ -61,30 +62,32 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.Connection.Result" enum="BooleanSuccess" - expires_after="2022-01-30"> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Measures PhoneHub connection success rate, considering attempts where the phone is not nearby as failures. </summary> </histogram> -<histogram name="PhoneHub.Connectivity.Duration" units="ms" expires_after="M98"> +<histogram name="PhoneHub.Connectivity.Duration" units="ms" + expires_after="2022-10-31"> <obsolete> Renamed to PhoneHub.Connection.Duration on 1/2021 in M89. </obsolete> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> The duration of time the phone is in the connected state, and becomes disconnected. </summary> </histogram> -<histogram name="PhoneHub.Connectivity.Latency" units="ms" expires_after="M98"> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> +<histogram name="PhoneHub.Connectivity.Latency" units="ms" + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> The duration of time the phone is in the connecting state, and becomes connected. @@ -92,19 +95,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.Connectivity.Success" enum="BooleanSuccess" - expires_after="M98"> + expires_after="2022-10-31"> <obsolete> Renamed to PhoneHub.Connection.Result on 11/2020 in M89. </obsolete> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary>The success rate of connecting to the Phone.</summary> </histogram> <histogram name="PhoneHub.InterstitialScreenEvent.{Screen}" - enum="PhoneHubInterstitialScreenEvent" expires_after="2021-10-31"> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + enum="PhoneHubInterstitialScreenEvent" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary>Events for the given PhoneHub interstitial screen. {Screen}</summary> <!-- The entries below should be a subset of the PhoneHubScreen enum --> @@ -133,10 +136,38 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="PhoneHub.MultiDeviceFeatureState{PhoneHubFeature}" + enum="MultiDevice_FeatureState" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> + <summary> + Indicates the feature state of Phone Hub features. This metric is emitted to + at the creation of the user session (when the user logs in), and when + feature state updates occur. {PhoneHubFeature} + </summary> + <token key="PhoneHubFeature"> + <variant name=""> + <obsolete> + Base histogram. Use suffixes of this histogram instead. + </obsolete> + </variant> + <variant name=".CameraRoll" summary="Camera roll sub-feature."/> + <variant name=".NotificationBadge" + summary="Notification badge sub-feature."> + <obsolete> + Removed in M88, as the feature will not be included in the M89 launch. + </obsolete> + </variant> + <variant name=".Notifications" summary="Notifications sub-feature."/> + <variant name=".TaskContinuation" summary="Task continuation sub-feature."/> + <variant name=".TopLevelFeature" summary="Top level Phone Hub feature."/> + </token> +</histogram> + <histogram name="PhoneHub.NotificationAccessSetup.SuccessfulSetupDuration" - units="ms" expires_after="M98"> + units="ms" expires_after="2022-10-31"> <owner>nohle@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Records the time it takes for the user to successfully go through the Chromebook UI that guides them through granting Phone Hub notifications @@ -147,9 +178,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.NotificationAccessSetup.{AllStatusesOrLastStatus}" - enum="PhoneHubNotificationAccessSetupStatus" expires_after="M98"> + enum="PhoneHubNotificationAccessSetupStatus" expires_after="2022-10-31"> <owner>nohle@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Records {AllStatusesOrLastStatus} the Chromebook UI that guides them through granting Phone Hub notifications access on their phone. Emitted each time @@ -165,9 +196,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.NotificationCount" units="notifications" - expires_after="2022-01-02"> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> The number of PhoneHub notifications, logged each time a notification is added or removed. @@ -175,9 +206,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.NotificationInteraction" - enum="PhoneHubNotificationInteraction" expires_after="2022-01-23"> - <owner>meilinw@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + enum="PhoneHubNotificationInteraction" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Events logged after the user interacts with a PhoneHub notification by sending an inline reply or dismissing it. @@ -185,43 +216,43 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.NotificationOptIn" - enum="PhoneHubInterstitialScreenEvent" expires_after="2021-10-31"> + enum="PhoneHubInterstitialScreenEvent" expires_after="2022-10-31"> <obsolete> Renamed to PhoneHub.NotificationOptInEvents on 1/2021 in M89. </obsolete> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary>Events for the given notification opt-in prompt.</summary> </histogram> <histogram name="PhoneHub.NotificationOptInEvents" - enum="PhoneHubInterstitialScreenEvent" expires_after="2022-01-02"> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + enum="PhoneHubInterstitialScreenEvent" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary>Events for the given notification opt-in prompt.</summary> </histogram> <histogram name="PhoneHub.OptInEntryPoint" enum="PhoneHubOptInEntryPoint" - expires_after="2022-01-30"> - <owner>meilinw@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary>Tracks the UI surface with which users enable Phone Hub.</summary> </histogram> <histogram name="PhoneHub.QuickActionClicked" enum="PhoneHubQuickAction" - expires_after="2022-01-02"> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary>Event logged after the user clicks on a quick action.</summary> </histogram> <histogram name="PhoneHub.Screen.OnSettingsButtonClicked" enum="PhoneHubScreen" - expires_after="2021-10-31"> + expires_after="2022-10-31"> <obsolete> Renamed to PhoneHub.ScreenOnSettingsButtonClicked on 1/2021 in M89. </obsolete> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Logs the current screen when the settings button is clicked in the tray bubble. @@ -229,9 +260,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.ScreenOnSettingsButtonClicked" enum="PhoneHubScreen" - expires_after="2022-01-02"> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Logs the current screen when the settings button is clicked in the tray bubble. @@ -239,9 +270,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.ScreenOn{BubbleEvent}" enum="PhoneHubScreen" - expires_after="2021-10-31"> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Logs the current screen for the PhoneHub tray given bubble event (i.e. on bubble open or close). @@ -253,9 +284,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.TabContinuationChipClicked" units="tab index" - expires_after="2021-10-31"> - <owner>tengs@chromium.org</owner> - <owner>khorimoto@chromium.org</owner> + expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> After a tab continuation chip is clicked, the index of the tab is logged. Tab indices are ordered left-to-right, top-to-bottom in a standard LTR @@ -264,9 +295,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.TaskCompletion.TetherConnection.Result" - enum="PhoneHubTetherConnectionResult" expires_after="2021-12-01"> - <owner>khorimoto@chromium.org</owner> - <owner>phonehub-dev@google.com</owner> + enum="PhoneHubTetherConnectionResult" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Logs the result of attempting a tether connection to measure the connection success rate. @@ -274,9 +305,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.TaskCompletion.{MessageType}.Result" - enum="PhoneHubMessageResult" expires_after="2021-12-03"> - <owner>khorimoto@chromium.org</owner> - <owner>phonehub-dev@google.com</owner> + enum="PhoneHubMessageResult" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Tracks the result of each type of message request. Logged each time a request message was sent and a response was received. @@ -292,9 +323,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PhoneHub.Usage.SentMessageTypeCount" - enum="PhoneHubMessageType" expires_after="M98"> - <owner>khorimoto@chromium.org</owner> - <owner>better-together-dev@google.com</owner> + enum="PhoneHubMessageType" expires_after="2022-10-31"> + <owner>jonmann@chromium.org</owner> + <owner>chromeos-cross-device-eng@google.com</owner> <summary> Counts for each command sent. Note that PhoneHubMessageType also includes message types that are recieved by CrOS. Those will always have a zero value diff --git a/chromium/tools/metrics/histograms/metadata/platform/histograms.xml b/chromium/tools/metrics/histograms/metadata/platform/histograms.xml index 3d2f372195e..e7a1763b337 100644 --- a/chromium/tools/metrics/histograms/metadata/platform/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/platform/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Platform.AnyCrashesDaily" units="count per day" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> <owner>sonnyrao@chromium.org</owner> @@ -34,7 +34,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.AnyCrashesWeekly" units="count per week" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> <owner>sonnyrao@chromium.org</owner> @@ -67,7 +67,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.BootMode.DevSwitch" - enum="Platform.BootMode.SwitchStatus" expires_after="2021-11-07"> + enum="Platform.BootMode.SwitchStatus" expires_after="2022-04-03"> <owner>mnissler@chromium.org</owner> <owner>dossym@chromium.org</owner> <summary> @@ -77,7 +77,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.BootMode.FirmwareWriteProtect" - enum="Platform.BootMode.FirmwareWriteProtect" expires_after="2021-11-07"> + enum="Platform.BootMode.FirmwareWriteProtect" expires_after="2022-04-17"> <owner>mnissler@chromium.org</owner> <owner>dossym@chromium.org</owner> <summary> @@ -144,7 +144,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.CpuFrequencyThermalScaling" units="%" - expires_after="2021-11-07"> + expires_after="2022-04-17"> <owner>sonnyrao@chromium.org</owner> <owner>chromeos-performance@google.com</owner> <summary> @@ -166,7 +166,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Cr50.BoardIdFlags" enum="Cr50BoardIdFlags" - expires_after="2021-12-19"> + expires_after="2022-03-20"> <owner>apronin@chromium.org</owner> <owner>vbendeb@chromium.org</owner> <summary> @@ -177,7 +177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Cr50.BoardIdOfRlzMismatch" enum="Cr50CrosRlzCodes" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>vbendeb@chromium.org</owner> <owner>apronin@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> @@ -189,7 +189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Cr50.FlashLog" enum="Cr50FlashLogs" - expires_after="2021-12-05"> + expires_after="2022-03-20"> <owner>apronin@chromium.org</owner> <owner>vbendeb@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> @@ -213,7 +213,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Cr50.RlzOfBoardIdMismatch" enum="Cr50CrosRlzCodes" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>vbendeb@chromium.org</owner> <owner>apronin@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> @@ -226,7 +226,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.CrOS.CrashSenderRemoveReason" - enum="CrosCrashSenderRemoveReason" expires_after="2021-12-12"> + enum="CrosCrashSenderRemoveReason" expires_after="2022-09-01"> <owner>iby@chromium.org</owner> <owner>mutexlox@chromium.org</owner> <owner>cros-telemetry@google.com</owner> @@ -256,7 +256,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Crouton.Started" enum="Platform.Crouton.Started" - expires_after="2021-10-04"> + expires_after="2022-10-04"> <owner>drinkcat@chromium.org</owner> <owner>dnschneid@chromium.org</owner> <summary> @@ -302,7 +302,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.DetachableBase.ActivePercent" units="%" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>drinkcat@chromium.org</owner> <owner>fshao@chromium.org</owner> <owner>chromeos-kukui@google.com</owner> @@ -314,7 +314,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.DetachableBase.AttachedOnBoot" enum="BooleanAttached" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>drinkcat@chromium.org</owner> <owner>fshao@chromium.org</owner> <owner>chromeos-kukui@google.com</owner> @@ -325,7 +325,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.DetachableBase.PairResult" - enum="DetachableBasePairResult" expires_after="2022-02-06"> + enum="DetachableBasePairResult" expires_after="2022-04-24"> <owner>drinkcat@chromium.org</owner> <owner>fshao@chromium.org</owner> <owner>chromeos-kukui@google.com</owner> @@ -333,7 +333,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.DetachableBase.PendingRWUpdate" - enum="DetachableBasePendingRWUpdate" expires_after="2022-02-06"> + enum="DetachableBasePendingRWUpdate" expires_after="2022-04-24"> <owner>drinkcat@chromium.org</owner> <owner>fshao@chromium.org</owner> <owner>chromeos-kukui@google.com</owner> @@ -352,7 +352,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.DetachableBase.ROUpdateResult" - enum="DetachableBaseROUpdateResult" expires_after="2022-01-16"> + enum="DetachableBaseROUpdateResult" expires_after="2022-04-24"> <owner>drinkcat@chromium.org</owner> <owner>fshao@chromium.org</owner> <owner>chromeos-kukui@google.com</owner> @@ -360,7 +360,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.DetachableBase.RWUpdateResult" - enum="DetachableBaseRWUpdateResult" expires_after="2021-12-12"> + enum="DetachableBaseRWUpdateResult" expires_after="2022-04-24"> <owner>drinkcat@chromium.org</owner> <owner>fshao@chromium.org</owner> <owner>chromeos-kukui@google.com</owner> @@ -397,7 +397,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.DiskUsageChronos" units="KB" - expires_after="2021-12-05"> + expires_after="2022-04-10"> <owner>keescook@google.com</owner> <summary> Chrome OS KB in use in the /home/chronos filesystem tree. Logged once a day @@ -405,7 +405,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Platform.DiskUsageVar" units="KB" expires_after="2021-12-05"> +<histogram name="Platform.DiskUsageVar" units="KB" expires_after="2022-05-01"> <owner>keescook@google.com</owner> <summary> Chrome OS KB in use in the /var filesystem tree. Logged once a day during @@ -474,7 +474,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.IntelMaxMicroArchitecture" - enum="IntelMaxMicroArchitecture" expires_after="2022-01-16"> + enum="IntelMaxMicroArchitecture" expires_after="2022-04-03"> <owner>fbarchard@chromium.org</owner> <owner>pwnall@chromium.org</owner> <summary> @@ -484,10 +484,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.KernelCrashesDaily" units="count per day" - expires_after="2022-01-09"> + expires_after="never"> +<!-- expires-never: Used to assess Chrome OS platform stability. --> + <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> - <owner>sonnyrao@chromium.org</owner> + <owner>bgeffon@chromium.org</owner> + <owner>cros-telemetry@google.com</owner> <summary> Count of kernel crashes during the previous day, or the most recent day the device was in use. Reported at most once a day. @@ -495,10 +498,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.KernelCrashesPerActiveYear" units="count per year" - expires_after="2022-01-09"> + expires_after="never"> +<!-- expires-never: Used to assess Chrome OS platform stability. --> + <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> - <owner>sonnyrao@chromium.org</owner> + <owner>bgeffon@chromium.org</owner> + <owner>cros-telemetry@google.com</owner> <summary> Count of kernel crashes since the last OS update, normalized as number of crashes per year of active use (active use = device is ON and not asleep). @@ -507,10 +513,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.KernelCrashesPerCpuYear" units="count per CPU year" - expires_after="2021-07-02"> + expires_after="never"> +<!-- expires-never: Used to assess Chrome OS platform stability. --> + <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> - <owner>sonnyrao@chromium.org</owner> + <owner>bgeffon@chromium.org</owner> + <owner>cros-telemetry@google.com</owner> <summary> Count of kernel crashes since the last OS update, normalized as number crashes per year of CPU time. Reported daily. @@ -518,20 +527,26 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.KernelCrashesSinceUpdate" units="count" - expires_after="2021-07-02"> + expires_after="never"> +<!-- expires-never: Used to assess Chrome OS platform stability. --> + <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> - <owner>sonnyrao@chromium.org</owner> + <owner>bgeffon@chromium.org</owner> + <owner>cros-telemetry@google.com</owner> <summary> Count of kernel crashes since the last OS update, reported daily. </summary> </histogram> <histogram name="Platform.KernelCrashesWeekly" units="count per week" - expires_after="2022-01-09"> + expires_after="never"> +<!-- expires-never: Used to assess Chrome OS platform stability. --> + <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> - <owner>sonnyrao@chromium.org</owner> + <owner>bgeffon@chromium.org</owner> + <owner>cros-telemetry@google.com</owner> <summary> Count of kernel crashes during the previous epoch-week, or the most recent epoch-week the device was in use. Reported at most once a week. Epoch-weeks @@ -540,10 +555,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.KernelCrashInterval" units="seconds" - expires_after="2022-01-09"> + expires_after="never"> +<!-- expires-never: Used to assess Chrome OS platform stability. --> + <owner>grundler@chromium.org</owner> <owner>groeck@chromium.org</owner> - <owner>sonnyrao@chromium.org</owner> + <owner>bgeffon@chromium.org</owner> + <owner>cros-telemetry@google.com</owner> <summary> Time elapsed between the last two kernel crashes. Sent after every kernel crash. @@ -561,7 +579,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.LogicalCpuCount" units="units" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>sonnyrao@chromium.org</owner> <owner>chromeos-performance@google.com</owner> <summary> @@ -593,7 +611,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Platform.Meminfo" units="KB" expires_after="2022-01-16"> +<histogram name="Platform.Meminfo" units="KB" expires_after="2022-04-03"> <owner>hajimehoshi@chromium.org</owner> <owner>kouhei@chromium.org</owner> <owner>sonnyrao@chromium.org</owner> @@ -603,7 +621,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Platform.Memory.ARC" units="MiB" expires_after="2021-12-05"> +<histogram name="Platform.Memory.ARC" units="MiB" expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="ProcessMemoryType" --> <owner>sonnyrao@chromium.org</owner> @@ -615,7 +633,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Memory.Browser" units="MiB" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="ProcessMemoryType" --> <owner>sonnyrao@chromium.org</owner> @@ -627,7 +645,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Memory.Daemons" units="MiB" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="ProcessMemoryType" --> <owner>sonnyrao@chromium.org</owner> @@ -648,7 +666,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Memory.Renderers" units="MiB" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="ProcessMemoryType" --> <owner>sonnyrao@chromium.org</owner> @@ -715,7 +733,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.MountEncrypted.EncryptionKeyStatus" - enum="MountEncryptedEncryptionKeyStatus" expires_after="2021-12-21"> + enum="MountEncryptedEncryptionKeyStatus" expires_after="2022-04-24"> <owner>apronin@chromium.org</owner> <owner>mnissler@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> @@ -727,7 +745,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.MountEncrypted.SystemKeyStatus" - enum="MountEncryptedSystemKeyStatus" expires_after="2021-12-21"> + enum="MountEncryptedSystemKeyStatus" expires_after="2022-04-24"> <owner>apronin@chromium.org</owner> <owner>mnissler@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> @@ -815,7 +833,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.SATA.PercentageUsed" units="%" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>asavery@chromium.org</owner> <owner>gwendal@chromium.org</owner> <summary> @@ -855,8 +873,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.StatefulFreeSpace" units="MB" - expires_after="2021-10-01"> - <owner>jamescook@chromium.org</owner> + expires_after="2022-04-01"> + <owner>asavery@chromium.org</owner> <owner>gwendal@chromium.org</owner> <summary> Chrome OS stateful partition space free. Sampled once daily. @@ -864,7 +882,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.StatefulLifetimeWrites" units="GiB" - expires_after="2021-10-25"> + expires_after="2022-04-24"> <owner>asavery@chromium.org</owner> <owner>gwendal@chromium.org</owner> <summary> @@ -898,7 +916,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Platform.StatefulUsage" units="%" expires_after="2021-12-05"> +<histogram name="Platform.StatefulUsage" units="%" expires_after="2022-04-10"> <owner>achuith@chromium.org</owner> <owner>omrilio@chromium.org</owner> <summary>Chrome OS stateful partition usage level.</summary> @@ -964,7 +982,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.SwapInLong" units="pages/second" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>sonnyrao@chromium.org</owner> <owner>chromeos-memory@google.com</owner> <summary> @@ -989,7 +1007,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.SwapOutLong" units="pages/second" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>sonnyrao@chromium.org</owner> <owner>chromeos-memory@google.com</owner> <summary> @@ -998,7 +1016,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.SwapOutShort" units="pages/second" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>sonnyrao@chromium.org</owner> <owner>chromeos-memory@google.com</owner> <summary> @@ -1007,7 +1025,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Temperature.Sensor00" units="Celsius" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>fletcherw@chromium.org</owner> <summary> Temperature reading from EC temperature sensor 0 (TSR0) taken every 30s. @@ -1049,7 +1067,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Temperature.Sensor02" units="Celsius" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>fletcherw@chromium.org</owner> <summary> Temperature reading from EC temperature sensor 2 (TSR2) taken every 30s. @@ -1124,7 +1142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Thermal.Temperature.Cpu.0" units="Celsius" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>julanhsu@google.com</owner> <owner>caiz@google.com</owner> <summary> @@ -1159,7 +1177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.TPM.AuthErrorCode" enum="TPMResultCodeEnum" - expires_after="2021-12-21"> + expires_after="2022-04-24"> <owner>yich@google.com</owner> <owner>cros-hwsec-userland-eng+uma@chromium.org</owner> <summary> @@ -1190,7 +1208,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.TPM.DictionaryAttackCounter" units="units" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>cylai@chromium.org</owner> <owner>cros-hwsec-userland-eng+uma@chromium.org</owner> <summary> @@ -1200,7 +1218,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.TPM.DictionaryAttackResetStatus" - enum="CrosTPMDictionaryAttackResetStatusEnum" expires_after="2022-02-06"> + enum="CrosTPMDictionaryAttackResetStatusEnum" expires_after="2022-04-10"> <owner>cylai@chromium.org</owner> <owner>cros-hwsec-userland-eng+uma@chromium.org</owner> <summary> @@ -1210,7 +1228,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.TPM.ErrorCode" enum="TPMResultCodeEnum" - expires_after="2021-12-21"> + expires_after="2022-04-24"> <owner>yich@google.com</owner> <owner>cros-hwsec-userland-eng+uma@chromium.org</owner> <summary> @@ -1256,7 +1274,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.TPM.TimeToTakeOwnership" units="ms" - expires_after="2021-10-08"> + expires_after="2022-04-04"> <owner>yich@google.com</owner> <owner>cylai@google.com</owner> <owner>cros-hwsec+uma@chromium.org</owner> @@ -1274,7 +1292,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.TPM.VersionFingerprint" enum="TPMVersionFingerprint" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>mnissler@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary> @@ -1298,21 +1316,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.Trunks.FirstTimeoutWritingCommand" - enum="TPMCommandCode" expires_after="2022-01-14"> + enum="TPMCommandCode" expires_after="2022-04-10"> <owner>chingkang@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary>Command code of the first timeout writing TPM command</summary> </histogram> <histogram name="Platform.Trunks.FirstTimeoutWritingTime" units="seconds" - expires_after="2022-01-14"> + expires_after="2022-04-17"> <owner>chingkang@chromium.org</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary>System uptime when first timeout writing TPM command occurs</summary> </histogram> <histogram name="Platform.Trunks.TpmErrorCode" enum="TPMResponseCode" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>yich@google.com</owner> <owner>cros-hwsec+uma@chromium.org</owner> <summary> @@ -1322,7 +1340,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.U2F.Command" enum="Cr50U2FCommands" - expires_after="2021-12-21"> + expires_after="2022-02-20"> <owner>cylai@chromium.org</owner> <owner>cros-hwsec-userland-eng+uma@chromium.org</owner> <summary>Records occurrences of U2F commands sent to cr50.</summary> @@ -1336,7 +1354,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.UnaggregatedUsageTime" units="seconds" - expires_after="2022-01-08"> + expires_after="2022-04-03"> <owner>mutexlox@chromium.org</owner> <owner>iby@chromium.org</owner> <owner>cros-telemetry@google.com</owner> @@ -1403,8 +1421,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.WiFiDeviceCount" units="wifi devices" - expires_after="2022-01-30"> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-24"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Sample collected 10s after boot, showing how many WiFi interfaces are @@ -1413,10 +1431,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.WiFiDisapppearedFromPCI" units="units" - expires_after="2022-01-30"> - <owner>rajatja@chromium.org</owner> - <owner>briannorris@chromium.org</owner> - <owner>chromeos-kernel-wifi@google.com</owner> + expires_after="2022-04-17"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Logged (with a constant value of 1) if a WiFi device experienced a PCI @@ -1428,9 +1444,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.WiFiStatusAfterForcedPCIRescan" enum="WiFiPCIStatus" - expires_after="2022-01-30"> - <owner>rajatja@chromium.org</owner> - <owner>briannorris@chromium.org</owner> + expires_after="2022-04-10"> + <owner>norvez@chromium.org</owner> <owner>cros-network-metrics@google.com</owner> <summary> Shows the WiFi status after the PCI bus is rescanned to recover WiFi. The UI @@ -1468,7 +1483,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Platform.ZramCompressionRatioPercent" units="%" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>sonnyrao@chromium.org</owner> <owner>chromeos-memory@google.com</owner> <summary> @@ -1566,7 +1581,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PlatformThread.Mac.AttemptedRealtimePeriod" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-04-24"> <owner>olka@chromium.org</owner> <owner>handellm@chromium.org</owner> <summary> @@ -1576,7 +1591,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PlatformThread.Mac.SucceededRealtimePeriod" - units="microseconds" expires_after="2022-01-09"> + units="microseconds" expires_after="2022-05-01"> <owner>olka@chromium.org</owner> <owner>handellm@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/plugin/histograms.xml b/chromium/tools/metrics/histograms/metadata/plugin/histograms.xml index 59c56e477dd..499bc459f9e 100644 --- a/chromium/tools/metrics/histograms/metadata/plugin/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/plugin/histograms.xml @@ -28,7 +28,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Plugin.FlashUsage" enum="FlashUsage" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yzshen@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary>Collects Flash usage data.</summary> @@ -115,7 +115,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PluginVm.AppsInstalledAtLogin" units="apps" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>timloh@google.com</owner> <owner>joelhockey@google.com</owner> <summary> @@ -125,14 +125,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PluginVm.DlcUseResult" enum="PluginVmDlcUseResult" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>kimjae@google.com</owner> <owner>timloh@google.com</owner> <summary>Recorded at each time PluginVM DLC is installed.</summary> </histogram> <histogram name="PluginVm.EngagementTime.Background" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>timloh@google.com</owner> <owner>joelhockey@google.com</owner> <summary> @@ -143,7 +143,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PluginVm.EngagementTime.Foreground" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>timloh@google.com</owner> <owner>joelhockey@google.com</owner> <summary> @@ -153,7 +153,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PluginVm.EngagementTime.PluginVmTotal" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>timloh@google.com</owner> <owner>joelhockey@google.com</owner> <summary> @@ -164,7 +164,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PluginVm.EngagementTime.Total" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>timloh@google.com</owner> <owner>joelhockey@google.com</owner> <summary> @@ -200,14 +200,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PluginVm.SetupFailureReason" enum="PluginVmSetupFailureReason" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>timloh@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary>Recorded when the Plugin VM installer fails.</summary> </histogram> <histogram name="PluginVm.SetupResult" enum="PluginVmSetupResult" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>joelhockey@chromium.org</owner> <owner>okalitova@chromium.org</owner> <owner>timloh@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/power/OWNERS b/chromium/tools/metrics/histograms/metadata/power/OWNERS index daf3cdd9c7f..e94d94072d9 100644 --- a/chromium/tools/metrics/histograms/metadata/power/OWNERS +++ b/chromium/tools/metrics/histograms/metadata/power/OWNERS @@ -2,5 +2,4 @@ per-file OWNERS=file://tools/metrics/histograms/metadata/METRIC_REVIEWER_OWNERS # Prefer sending CLs to the owners listed below. # Use chromium-metrics-reviews@google.com as a backup. -sebmarchand@chromium.org tby@chromium.org diff --git a/chromium/tools/metrics/histograms/metadata/power/histograms.xml b/chromium/tools/metrics/histograms/metadata/power/histograms.xml index 81e626ce494..a63e4b93936 100644 --- a/chromium/tools/metrics/histograms/metadata/power/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/power/histograms.xml @@ -58,7 +58,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </variants> <histogram name="Power.ApproxCpuTimeSecondsPerCoreTypeAndFrequency" - units="50 MHz" expires_after="2021-12-19"> + units="50 MHz" expires_after="2022-04-24"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -82,7 +82,25 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </summary> </histogram> -<histogram name="Power.BacklightLevelOnAC" units="%" expires_after="2022-01-02"> +<histogram name="Power.AvgCpuLoad.{ProcessType}" units="%" + expires_after="2022-10-04"> + <owner>eseckler@chromium.org</owner> + <owner>khokhlov@chromium.org</owner> + <summary> + Records the average CPU load caused by the corresponding process over the + last 30 (or more) seconds. Emitted at the end of each such period, so not + more often that once in 30 sec. Note that CPU load can be greater than 100% + on milti-core systems. + </summary> + <token key="ProcessType"> + <variant name="Browser"/> + <variant name="GPU"/> + <variant name="Other"/> + <variant name="Renderer"/> + </token> +</histogram> + +<histogram name="Power.BacklightLevelOnAC" units="%" expires_after="2022-04-17"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -92,7 +110,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.BacklightLevelOnBattery" units="%" - expires_after="2021-11-07"> + expires_after="2022-04-10"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -102,7 +120,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.BatteryChargeHealth" units="%" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -125,7 +143,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.BatteryDischargeRate" units="mW" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -151,7 +169,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.BatteryDischargeRateWhileSuspended" units="mW" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -172,7 +190,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </summary> </histogram> -<histogram name="Power.BatteryPercentDrop" units="%" expires_after="2021-12-12"> +<histogram name="Power.BatteryPercentDrop" units="%" expires_after="2022-04-10"> <owner>ryansturm@chromium.org</owner> <owner>tbansal@chromium.org</owner> <summary> @@ -197,7 +215,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.BatteryRemainingAtEndOfSessionOnBattery" units="%" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -207,7 +225,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.BatteryRemainingAtStartOfSessionOnAC" units="%" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -226,7 +244,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.BatteryRemainingWhenChargeStarts" units="%" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -238,7 +256,6 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml <histogram name="Power.BatterySamplingDelay" units="microseconds" expires_after="2021-11-26"> <owner>etiennep@chromium.org</owner> - <owner>sebmarchand@chromium.org</owner> <owner>fdoray@chromium.org</owner> <summary> The delay in microseconds between the time a battery charge level query was @@ -268,7 +285,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.ConnectedChargingPorts" - enum="PowerConnectedChargingPorts" expires_after="2021-12-26"> + enum="PowerConnectedChargingPorts" expires_after="2022-04-24"> <owner>bleung@chromium.org</owner> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> @@ -285,7 +302,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.CpuAffinityExperiments.ProcessAffinityMode" - enum="CpuAffinityMode" expires_after="2021-10-04"> + enum="CpuAffinityMode" expires_after="2022-10-04"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -296,7 +313,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.CpuAffinityExperiments.ProcessAffinityUpdateSuccess" - enum="BooleanSuccess" expires_after="2021-10-04"> + enum="BooleanSuccess" expires_after="2022-10-04"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -307,7 +324,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.CpuTimeSecondsPerCoreTypeAndFrequency" units="50 MHz" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -350,7 +367,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.CpuTimeSecondsPerProcessType" enum="ProcessType2" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -390,7 +407,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.CpuTimeSecondsPerThreadType.{ProcessType}" - enum="CpuTimeMetricsThreadType" expires_after="2021-10-10"> + enum="CpuTimeMetricsThreadType" expires_after="2022-10-04"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -481,7 +498,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.ExternalBrightnessReadResult" - enum="ExternalDisplayReceiveResult" expires_after="M100"> + enum="ExternalDisplayReceiveResult" expires_after="2022-05-01"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -526,7 +543,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.FirmwareResumeTimeOnAC" units="ms" - expires_after="2021-10-31"> + expires_after="2022-03-31"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -536,7 +553,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.FirmwareResumeTimeOnBattery" units="ms" - expires_after="2021-08-29"> + expires_after="2022-03-31"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -547,7 +564,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml <histogram name="Power.ForegroundBatteryDrain.30SecondsAvg{Exclusive}{DarkeningType}" - units="uAh" expires_after="2021-11-07"> + units="uAh" expires_after="2022-11-07"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -597,7 +614,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.ForegroundBatteryDrain.30Seconds{Exclusive}" units="uAh" - expires_after="2021-11-07"> + expires_after="2022-11-07"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -645,7 +662,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.ForegroundBatteryDrain{Exclusive}" units="0.1 mAh" - expires_after="2021-11-07"> + expires_after="2022-11-07"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -766,8 +783,26 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </token> </histogram> +<histogram name="Power.IdleCpuLoad.{ProcessType}" units="%" + expires_after="2022-10-04"> + <owner>eseckler@chromium.org</owner> + <owner>khokhlov@chromium.org</owner> + <summary> + Records the average CPU load caused by the corresponding process over the + last 5 sec (or more) of Idle power mode. Emitted at the end of each such + period, so not more often that once in 5 sec. Note that CPU load can be + greater than 100% on milti-core systems. + </summary> + <token key="ProcessType"> + <variant name="Browser"/> + <variant name="GPU"/> + <variant name="Other"/> + <variant name="Renderer"/> + </token> +</histogram> + <histogram name="Power.IdleScreenDimCountDaily" units="count" - expires_after="M100"> + expires_after="2022-04-17"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -782,7 +817,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.IdleScreenOffCountDaily" units="count" - expires_after="M100"> + expires_after="2022-05-01"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -797,7 +832,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.IdleSuspendCountDaily" units="count" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -811,7 +846,8 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </summary> </histogram> -<histogram name="Power.IdleTimeAfterDimOnAC" units="ms" expires_after="M100"> +<histogram name="Power.IdleTimeAfterDimOnAC" units="ms" + expires_after="2022-04-24"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -821,7 +857,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.IdleTimeAfterDimOnBattery" units="ms" - expires_after="M100"> + expires_after="2022-04-17"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -831,7 +867,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.IdleTimeAfterScreenOffOnAC" units="ms" - expires_after="M100"> + expires_after="2022-05-01"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -841,7 +877,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.IdleTimeAfterScreenOffOnBattery" units="ms" - expires_after="M100"> + expires_after="2022-04-17"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -850,7 +886,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </summary> </histogram> -<histogram name="Power.IdleTimeOnAC" units="ms" expires_after="M100"> +<histogram name="Power.IdleTimeOnAC" units="ms" expires_after="2022-04-24"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -897,7 +933,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.KernelSuspendTimeOnBattery" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -953,7 +989,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.Mac.AppleSMCOpened" enum="BooleanSuccess" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>lgrey@chromium.org</owner> <summary> When metrics collection started, records true if a handle to the System @@ -996,7 +1032,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.Mac.IsOnBattery2" enum="BooleanOnBattery" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>avi@chromium.org</owner> <owner>lgrey@chromium.org</owner> <summary> @@ -1022,7 +1058,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml Replaced by Power.MainScreenBrightness2 in July 2021. The new histogram allows value superior to 100% as sometime reported by the OS. </obsolete> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The level of the screen backlight in percent if it's not available. Only @@ -1032,7 +1068,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml <histogram name="Power.MainScreenBrightness2" units="%" expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The level of the screen backlight in percent if it's not available. Only @@ -1043,8 +1079,8 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.MainScreenBrightnessAvailable" units="Boolean" - expires_after="2021-11-30"> - <owner>sebmarchand@chromium.org</owner> + expires_after="2022-04-10"> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Indicates if the screen backlight level value is available. Recorded every @@ -1075,7 +1111,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.NumberOfSessionsPerCharge" units="units" - expires_after="2021-10-04"> + expires_after="2022-03-31"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -1096,7 +1132,8 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </summary> </histogram> -<histogram name="Power.PowerButtonDownTime" units="ms" expires_after="M100"> +<histogram name="Power.PowerButtonDownTime" units="ms" + expires_after="2022-04-24"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -1124,7 +1161,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.PowerButtonPressInTabletMode" - enum="PowerButtonPressType" expires_after="2021-12-12"> + enum="PowerButtonPressType" expires_after="2022-05-01"> <owner>minch@chromium.org</owner> <owner>xdai@chromium.org</owner> <summary> @@ -1135,7 +1172,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.PowerScheduler.ProcessPowerModeChange.{ProcessType}" - enum="PowerMode" expires_after="2021-10-04"> + enum="PowerMode" expires_after="2022-10-04"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -1151,7 +1188,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.PowerScheduler.ThrottlingDuration" units="ms" - expires_after="2021-10-29"> + expires_after="2022-10-04"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -1162,7 +1199,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.PowerScheduler.ThrottlingDurationPerCpuAffinityMode" - enum="CpuAffinityMode" expires_after="2021-10-29"> + enum="CpuAffinityMode" expires_after="2022-10-04"> <owner>eseckler@chromium.org</owner> <owner>skyostil@chromium.org</owner> <summary> @@ -1175,7 +1212,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.PowerSupplyMaxPower" units="W" - expires_after="2021-10-31"> + expires_after="2022-04-17"> <owner>bleung@chromium.org</owner> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> @@ -1186,7 +1223,8 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </summary> </histogram> -<histogram name="Power.PowerSupplyMaxVoltage" units="V" expires_after="M100"> +<histogram name="Power.PowerSupplyMaxVoltage" units="V" + expires_after="2022-04-17"> <owner>bleung@chromium.org</owner> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> @@ -1198,7 +1236,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.PowerSupplyType" enum="PowerSupplyType" - expires_after="2021-10-31"> + expires_after="2022-04-10"> <owner>bleung@chromium.org</owner> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> @@ -1219,14 +1257,14 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.SmartCharging.Messages" enum="SmartChargingMessages" - expires_after="2021-11-15"> + expires_after="2022-05-01"> <owner>thanhdng@chromium.org</owner> <owner>napper@chromium.org</owner> <summary>Type of messages that are reported by smart charging.</summary> </histogram> <histogram name="Power.SuspendAttempt" enum="SuspendAttempt" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -1237,7 +1275,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.SuspendAttemptsBeforeCancel" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -1249,7 +1287,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.SuspendAttemptsBeforeSuccess" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -1260,7 +1298,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.SuspendResult" enum="SuspendResult" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>puthik@chromium.org</owner> <owner>chromeos-platform-power@google.com</owner> <summary> @@ -1287,7 +1325,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="Power.UserBrightnessAdjustmentsPerSessionOnAC" units="units" - expires_after="M100"> + expires_after="2022-05-01"> <owner>tbroch@chromium.org</owner> <owner>napper@chromium.org</owner> <summary> @@ -1309,7 +1347,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.DimImminent.Action" enum="PowerMLDimImminentAction" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>napper@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <summary> @@ -1319,7 +1357,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.ModelDim.Result" enum="PowerMLFinalResult" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>napper@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <summary> @@ -1329,7 +1367,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.ModelNoDim.Result" enum="PowerMLFinalResult" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>napper@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <summary> @@ -1339,7 +1377,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.NonModelDim.Result" enum="PowerMLFinalResult" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>napper@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <summary> @@ -1360,7 +1398,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml <histogram name="PowerML.SmartDimComponent.LoadComponentEvent" enum="PowerMLSmartDimComponentLoadComponentEvent" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>napper@chromium.org</owner> @@ -1371,7 +1409,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.SmartDimComponent.VersionType" - enum="PowerMLSmartDimComponentVersionType" expires_after="2021-12-12"> + enum="PowerMLSmartDimComponentVersionType" expires_after="2022-04-24"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>napper@chromium.org</owner> @@ -1382,7 +1420,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.SmartDimComponent.WorkerType" - enum="PowerMLSmartDimComponentWorkerType" expires_after="2021-12-12"> + enum="PowerMLSmartDimComponentWorkerType" expires_after="2022-04-17"> <owner>alanlxl@chromium.org</owner> <owner>amoylan@chromium.org</owner> <owner>napper@chromium.org</owner> @@ -1404,7 +1442,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.SmartDimModel.RequestCanceledDuration" units="ms" - expires_after="2021-10-24"> + expires_after="2022-02-20"> <owner>amoylan@chromium.org</owner> <owner>napper@chromium.org</owner> <owner>napper@chromium.org</owner> @@ -1416,7 +1454,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.SmartDimModel.RequestCompleteDuration" units="ms" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>amoylan@chromium.org</owner> <owner>napper@chromium.org</owner> <owner>napper@chromium.org</owner> @@ -1428,7 +1466,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.SmartDimModel.Result" - enum="PowerMLSmartDimModelResult" expires_after="2021-12-19"> + enum="PowerMLSmartDimModelResult" expires_after="2022-04-24"> <owner>napper@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <summary> @@ -1441,7 +1479,7 @@ Also used in tools/metrics/histograms/metadata/others/histograms.xml </histogram> <histogram name="PowerML.SmartDimParameter.Result" - enum="PowerMLSmartDimParameterResult" expires_after="2021-12-26"> + enum="PowerMLSmartDimParameterResult" expires_after="2022-05-01"> <owner>napper@chromium.org</owner> <owner>thanhdng@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/prefetch/histograms.xml b/chromium/tools/metrics/histograms/metadata/prefetch/histograms.xml index 5c36388b155..a0b7bb5beba 100644 --- a/chromium/tools/metrics/histograms/metadata/prefetch/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/prefetch/histograms.xml @@ -255,7 +255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchProxy.AfterClick.Mainframe.CookieWaitTime" units="ms" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>robertogden@chromium.org</owner> <owner>ryansturm@chromium.org</owner> <owner>tbansal@chromium.org</owner> @@ -278,7 +278,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchProxy.Prefetch.Mainframe.BodyLength" units="bytes" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>robertogden@chromium.org</owner> <owner>ryansturm@chromium.org</owner> <owner>tbansal@chromium.org</owner> @@ -302,7 +302,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchProxy.Prefetch.Mainframe.CookiesToCopy" units="count" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>robertogden@chromium.org</owner> <owner>ryansturm@chromium.org</owner> <owner>tbansal@chromium.org</owner> @@ -360,7 +360,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchProxy.Prefetch.Mainframe.TotalTime" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>robertogden@chromium.org</owner> <owner>ryansturm@chromium.org</owner> <owner>tbansal@chromium.org</owner> @@ -429,7 +429,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrefetchProxy.SpareRenderer.CountStartedOnSRP" units="count" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>robertogden@chromium.org</owner> <owner>ryansturm@chromium.org</owner> <owner>tbansal@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/print/histograms.xml b/chromium/tools/metrics/histograms/metadata/print/histograms.xml index c1c1b5e87fe..d96c6657e5a 100644 --- a/chromium/tools/metrics/histograms/metadata/print/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/print/histograms.xml @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrintPreview.InitialDisplayTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>thestig@chromium.org</owner> <owner>dhoss@chromium.org</owner> <summary> @@ -151,7 +151,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrintPreview.NumberOfPrinters" units="units" - expires_after="2021-11-07"> + expires_after="2022-04-24"> <owner>thestig@chromium.org</owner> <owner>dhoss@chromium.org</owner> <summary> @@ -161,6 +161,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PrintPreview.PrintDocumentSize.HTML" units="KB" expires_after="2021-03-07"> + <obsolete> + XXX Removed 10/2020 as it is launched and no longer needed for analysis. + </obsolete> <owner>thestig@chromium.org</owner> <owner>dmazzoni@chromium.org</owner> <summary> @@ -170,6 +173,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="PrintPreview.PrintDocumentSize.PDF" units="KB" expires_after="2020-12-31"> + <obsolete> + XXX Removed 10/2020 as it is launched and no longer needed for analysis. + </obsolete> <owner>thestig@chromium.org</owner> <owner>dhoss@chromium.org</owner> <summary> @@ -178,7 +184,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrintPreview.PrintDocumentType" - enum="PrintPreviewPrintDocumentTypeBuckets" expires_after="2022-02-11"> + enum="PrintPreviewPrintDocumentTypeBuckets" expires_after="2022-04-17"> <owner>rbpotter@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -218,7 +224,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrintPreview.PrintSettings" enum="PrintSettings" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -307,14 +313,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="PrintPreview.RenderToPDFTime" units="ms" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary>Time taken to render to PDF for print preview.</summary> </histogram> <histogram name="PrintPreview.UserAction" enum="PrintPreviewUserActionType" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/printing/histograms.xml b/chromium/tools/metrics/histograms/metadata/printing/histograms.xml index 68347db46f8..3aa8d4f67f2 100644 --- a/chromium/tools/metrics/histograms/metadata/printing/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/printing/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Printing.ConversionSize.Emf" units="KB" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.ConversionSize.EmfWithGdiText" units="KB" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.ConversionSize.EmfWithReducedRasterization" - units="KB" expires_after="2021-09-30"> + units="KB" expires_after="2022-09-30"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -52,7 +52,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.ConversionSize.EmfWithReducedRasterizationAndGdiText" - units="KB" expires_after="2021-09-30"> + units="KB" expires_after="2022-09-30"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -63,7 +63,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.ConversionSize.PostScript2" units="KB" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -73,7 +73,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.ConversionSize.PostScript3" units="KB" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -82,8 +82,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Printing.ConversionSize.PostScript3WithType42Fonts" units="KB" + expires_after="2022-09-30"> + <owner>thestig@chromium.org</owner> + <owner>awscreen@chromium.org</owner> + <summary> + On Windows, the average size of a printed page after converting to level 3 + PostScript with Type 42 fonts. Recorded after conversion. + </summary> +</histogram> + <histogram name="Printing.ConversionSize.Pwg" units="KB" - expires_after="2021-09-30"> + expires_after="2022-09-30"> <owner>thestig@chromium.org</owner> <owner>awscreen@chromium.org</owner> <summary> @@ -93,7 +103,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.AddressResolutionResult" enum="BooleanSuccess" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>skau@chromium.org</owner> <owner>cros-printing-dev@chromium.org</owner> <summary> @@ -103,7 +113,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.HighestIppVersion" enum="IppVersion" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>skau@chromium.org</owner> <owner>pawliczek@chromium.org</owner> <summary> @@ -116,6 +126,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Printing.CUPS.IppAttributes" enum="IppAttribute" expires_after="M93"> + <obsolete> + Removed 2021-09. + </obsolete> <owner>vkuzkokov@chromium.org</owner> <owner>skau@chromium.org</owner> <summary> @@ -126,6 +139,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Printing.CUPS.IppAttributesCount" units="count" expires_after="M82"> + <obsolete> + Removed 2021-09. + </obsolete> <owner>vkuzkokov@chromium.org</owner> <owner>skau@chromium.org</owner> <summary> @@ -135,7 +151,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.IppAttributesSuccess" enum="BooleanSuccess" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>skau@chromium.org</owner> <owner>cros-printing-dev@chromium.org</owner> <summary> @@ -149,6 +165,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Printing.CUPS.IppAttributesUsed" units="count" expires_after="M93"> + <obsolete> + Removed 2021-09. + </obsolete> <owner>vkuzkokov@chromium.org</owner> <owner>skau@chromium.org</owner> <summary> @@ -158,7 +177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.IppDeviceReachable" enum="BooleanSuccess" - expires_after="2022-01-23"> + expires_after="2022-04-17"> <owner>skau@chromium.org</owner> <owner>cros-printing-dev@chromium.org</owner> <summary> @@ -168,8 +187,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.JobDuration.JobCancelled" units="ms" - expires_after="2021-06-01"> - <owner>skau@chromium.org</owner> + expires_after="2022-04-24"> + <owner>bmgordon@chromium.org</owner> <owner>project-bolton@google.com</owner> <summary> Records the print job duration of a cancelled print job. Includes time spent @@ -178,8 +197,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.JobDuration.JobDone" units="ms" - expires_after="2022-02-06"> - <owner>skau@chromium.org</owner> + expires_after="2022-04-17"> + <owner>bmgordon@chromium.org</owner> <owner>project-bolton@google.com</owner> <summary> Records the print job duration of a done/completed print job. Includes time @@ -202,7 +221,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.MigratedMakeAndModel" enum="BooleanMigrated" - expires_after="2021-10-10"> + expires_after="2022-04-10"> <owner>luum@chromium.org</owner> <owner>cros-printing-dev@chromium.org</owner> <summary> @@ -213,7 +232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.NearbyNetworkPrintersCount" units="printers" - expires_after="2021-11-21"> + expires_after="2022-04-17"> <owner>skau@chromium.org</owner> <owner>project-bolton@google.com</owner> <summary> @@ -224,8 +243,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.PrintDocumentSize" units="KB" - expires_after="2021-10-04"> - <owner>skau@chromium.org</owner> + expires_after="2022-04-17"> + <owner>bmgordon@chromium.org</owner> <owner>project-bolton@google.com</owner> <summary> Records the total size of the printed document (PDF) sent to CUPS. Only @@ -234,7 +253,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.PrinterAdded" enum="PrinterProtocol" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>skau@chromium.org</owner> <owner>src/chromeos/printing/OWNERS</owner> <summary> @@ -244,7 +263,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.PrinterRemoved" enum="PrinterProtocol" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>skau@chromium.org</owner> <owner>src/chromeos/printing/OWNERS</owner> <summary> @@ -254,7 +273,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.PrintersDiscovered" units="printers" - expires_after="2021-10-01"> + expires_after="2022-04-24"> <owner>skau@chromium.org</owner> <owner>src/chromeos/printing/OWNERS</owner> <summary> @@ -347,7 +366,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.ProtocolUsed" enum="PrinterProtocol" - expires_after="2022-01-30"> + expires_after="2022-04-17"> <owner>skau@chromium.org</owner> <owner>cros-printing-dev@chromium.org</owner> <summary> @@ -359,7 +378,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.TotalNetworkPrintersCount" units="printers" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>skau@chromium.org</owner> <owner>project-bolton@google.com</owner> <summary> @@ -370,7 +389,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Printing.CUPS.UnknownPpdColorModel" enum="Boolean" - expires_after="2021-09-30"> + expires_after="2022-03-31"> <owner>dhoss@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary> @@ -435,7 +454,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Printing.PrintBackend.DriversRequiringElevatedPrivilegeEncountered" - enum="BooleanFound" expires_after="2021-09-30"> + enum="BooleanFound" expires_after="2022-03-31"> <owner>awscreen@chromium.org</owner> <owner>thestig@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/profile/histograms.xml b/chromium/tools/metrics/histograms/metadata/profile/histograms.xml index 9533dd08038..7a9b6fe4ee6 100644 --- a/chromium/tools/metrics/histograms/metadata/profile/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/profile/histograms.xml @@ -22,13 +22,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Profile.AddNewUser" enum="ProfileAddNewUser" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>rogerta@chromium.org</owner> <summary>The frequency of ways that new user profiles are added.</summary> </histogram> <histogram name="Profile.AddSignInFlowOutcome" - enum="ProfileAddSignInFlowOutcome" expires_after="2022-01-23"> + enum="ProfileAddSignInFlowOutcome" expires_after="2022-04-03"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -38,7 +38,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.AllAccounts.Categories" - enum="ProfileAllAccountsCategories" expires_after="2022-02-06"> + enum="ProfileAllAccountsCategories" expires_after="2022-04-17"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -52,7 +52,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.AllAccounts.Names" enum="ProfileAllAccountsNames" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -84,20 +84,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.Avatar" enum="ProfileAvatar" - expires_after="2022-01-09"> + expires_after="2022-05-01"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary>The frequency of selection of each avatar.</summary> </histogram> -<histogram name="Profile.BookmarksSize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.BookmarksSize" units="MB" expires_after="2022-04-24"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the bookmarks database.</summary> </histogram> <histogram name="Profile.BrowserActive.PerProfile" enum="Profile" - expires_after="2022-01-16"> + expires_after="2022-04-17"> <owner>msarda@chromium.org</owner> <owner>tangltom@chromium.org</owner> <summary> @@ -115,7 +115,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.ColorsUniqueness" enum="ProfileColorsUniqueness" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -125,7 +125,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Profile.CookiesSize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.CookiesSize" units="MB" expires_after="2022-04-24"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the cookies database.</summary> @@ -160,6 +160,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Profile.Delete" enum="BooleanProfileSignedIn" expires_after="2021-07-31"> + <obsolete> + Removed in M96. + </obsolete> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -171,7 +174,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.DeleteProfileAction" enum="ProfileDeleteAction" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <owner>anthonyvd@chromium.org</owner> @@ -185,7 +188,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.DeleteProfileContext" enum="ProfileDeleteContext" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -196,7 +199,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.Destroyer.OffTheRecord" enum="ProfileDestructionType" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>rhalavati@chromium.org</owner> <owner>chrome-privacy-core@google.com</owner> <summary> @@ -230,20 +233,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Profile.ExtensionSize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.ExtensionSize" units="MB" expires_after="2022-04-17"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the extension cookies database.</summary> </histogram> -<histogram name="Profile.FaviconsSize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.FaviconsSize" units="MB" expires_after="2022-04-24"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the favicons database.</summary> </histogram> <histogram name="Profile.Guest.ForcedByPolicy" enum="BooleanForced" - expires_after="2022-02-02"> + expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -253,7 +256,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.Guest.OTR.Lifetime" units="minutes" - expires_after="2022-02-02"> + expires_after="2022-04-17"> <owner>rhalavati@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -284,14 +287,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> -<histogram name="Profile.HistorySize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.HistorySize" units="MB" expires_after="2022-04-24"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the history database.</summary> </histogram> <histogram name="Profile.Incognito.Lifetime" units="minutes" - expires_after="2022-02-02"> + expires_after="2022-04-03"> <owner>rhalavati@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -303,7 +306,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.Incognito.MainFrameNavigationsPerSession" - units="navigations" expires_after="2022-02-02"> + units="navigations" expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -315,7 +318,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.Incognito.MovedToBackgroundAfterDuration" - units="minutes" expires_after="2022-02-22"> + units="minutes" expires_after="2022-04-24"> <owner>rhalavati@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -326,7 +329,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.Incognito.ResumedAfterReportedDuration" - units="minutes" expires_after="2022-02-22"> + units="minutes" expires_after="2022-04-24"> <owner>rhalavati@chromium.org</owner> <owner>chrome-incognito@google.com</owner> <summary> @@ -338,7 +341,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.KeepAliveLeakAtShutdown" enum="ProfileKeepAliveOrigin" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>nicolaso@chromium.org</owner> <owner>cbe-eng@google.com</owner> <summary> @@ -360,7 +363,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.Menu.OpenedAfterAvatarAnimation" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>droger@chromium.org</owner> <owner>jkrcal@chromium.org</owner> <summary> @@ -385,7 +388,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NetUserCount" enum="ProfileNetUserCount" - expires_after="2021-11-07"> + expires_after="2022-04-24"> <owner>rogerta@chromium.org</owner> <summary> Counts of users added and deleted. Percentages are not meaningful. Please @@ -394,7 +397,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NukeFromDisk.Result" enum="NukeProfileResult" - expires_after="2021-08-29"> + expires_after="2022-04-17"> <owner>nicolaso@chromium.org</owner> <owner>cbe-eng@google.com</owner> <summary> @@ -408,7 +411,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NumberOfAccountsPerProfile" units="units" - expires_after="2021-10-25"> + expires_after="2022-04-10"> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -419,7 +422,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NumberOfActiveProfiles" units="profiles" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>droger@chromium.org</owner> <owner>feuunk@chromium.org</owner> <summary> @@ -462,7 +465,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NumberOfProfiles" units="profiles" - expires_after="2022-01-23"> + expires_after="2022-04-03"> <owner>droger@chromium.org</owner> <owner>jkrcal@chromium.org</owner> <summary> @@ -475,7 +478,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NumberOfProfilesAtProfileSwitch" units="profiles" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -502,7 +505,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NumberOfSignedInProfiles" units="profiles" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>droger@chromium.org</owner> <owner>jkrcal@chromium.org</owner> <summary> @@ -531,7 +534,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.NumberOfUnusedProfiles" units="profiles" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -541,7 +544,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.PercentageOfManagedProfiles" units="units" - expires_after="2022-01-24"> + expires_after="2022-04-17"> <owner>agawronska@chromium.org</owner> <owner>michaelpg@chromium.org</owner> <owner>cros-families@google.com</owner> @@ -587,7 +590,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Profile.State.Avatar" enum="ProfileAvatarState" - expires_after="2022-01-23"> + expires_after="2022-05-01"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -598,7 +601,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Profile.State.LastUsed" units="days" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -608,7 +611,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Profile.State.Name" enum="ProfileNameState" - expires_after="2022-01-23"> + expires_after="2022-05-01"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -619,7 +622,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Profile.State.SyncEnabled" enum="BooleanEnabled" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -629,7 +632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Profile.State.UnconsentedPrimaryAccountType" - enum="ProfileUnconsentedPrimaryAccountType" expires_after="2022-01-23"> + enum="ProfileUnconsentedPrimaryAccountType" expires_after="2022-04-17"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -688,7 +691,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Profile.TopSitesSize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.TopSitesSize" units="MB" expires_after="2022-05-01"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the top sites database.</summary> @@ -701,7 +704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>Total size of all history databases.</summary> </histogram> -<histogram name="Profile.TotalSize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.TotalSize" units="MB" expires_after="2022-04-10"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Total size of the profile data (excluding sub-folders).</summary> @@ -789,20 +792,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Profile.VisitedLinksSize" units="MB" - expires_after="2022-01-31"> + expires_after="2022-05-01"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the visited links database.</summary> </histogram> -<histogram name="Profile.WebDataSize" units="MB" expires_after="2022-01-31"> +<histogram name="Profile.WebDataSize" units="MB" expires_after="2022-05-01"> <owner>etienneb@chromium.org</owner> <owner>gab@chromium.org</owner> <summary>Size of the web data database.</summary> </histogram> <histogram name="ProfileChooser.HasProfilesShown" enum="BooleanShown" - expires_after="2021-10-25"> + expires_after="2022-04-24"> <owner>vasilii@chromium.org</owner> <owner>ewald@chromium.org</owner> <summary> @@ -812,7 +815,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.AskOnStartup" enum="BooleanEnabled" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>msalama@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -823,7 +826,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.AskOnStartupChanged" enum="BooleanEnabled" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>msalama@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -855,7 +858,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.Shown" enum="ProfilePickerEntryPoint" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>msalama@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -865,7 +868,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.StartupTime.BeforeCreation" units="ms" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>msalama@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -876,7 +879,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.StartupTime.FirstPaint" units="ms" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>msalama@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -886,7 +889,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.StartupTime.FirstPaint.FromApplicationStart" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-04-03"> <owner>alexilin@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -920,7 +923,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.UiVisited" enum="ProfilePickerPages" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>msalama@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -930,7 +933,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ProfilePicker.UserAction" enum="ProfilePickerAction" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>msalama@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/quota/histograms.xml b/chromium/tools/metrics/histograms/metadata/quota/histograms.xml index 04da824498b..66dfbab7396 100644 --- a/chromium/tools/metrics/histograms/metadata/quota/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/quota/histograms.xml @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.AvailableDiskSpace" units="MB" - expires_after="2021-12-21"> + expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -75,7 +75,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Quota.DiskspaceShortage" units="MB" expires_after="2022-01-18"> +<histogram name="Quota.DiskspaceShortage" units="MB" expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -96,7 +96,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.EvictedBucketDaysSinceAccess" units="units" - expires_after="2022-01-19"> + expires_after="2022-04-24"> <owner>ayui@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -117,7 +117,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.EvictedBytesPerRound" units="MB" - expires_after="2021-12-14"> + expires_after="2022-02-20"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -177,7 +177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.GlobalTemporaryPoolSize" units="MB" - expires_after="2022-01-18"> + expires_after="2022-04-24"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -187,13 +187,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.GlobalUsageOfPersistentStorage" units="MB" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <summary>Global usage of persistent storage.</summary> </histogram> <histogram name="Quota.GlobalUsageOfTemporaryStorage" units="MB" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <summary>Global usage of temporary storage.</summary> </histogram> @@ -233,7 +233,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.PercentDiskAvailable" units="%" - expires_after="2021-12-21"> + expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -243,7 +243,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.PercentDiskAvailable2" units="%" - expires_after="2022-01-18"> + expires_after="2022-04-24"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -253,7 +253,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.PercentUsedByOrigin" units="%" - expires_after="2022-01-18"> + expires_after="2022-05-01"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -263,7 +263,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Quota.PercentUsedForTemporaryStorage2" units="%" - expires_after="2021-11-29"> + expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -283,7 +283,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Quota.QuotaForOrigin" units="MB" expires_after="2022-01-18"> +<histogram name="Quota.QuotaForOrigin" units="MB" expires_after="2022-04-17"> <owner>jarrydg@chromium.org</owner> <owner>chrome-owp-storage@google.com</owner> <summary> @@ -329,8 +329,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>Time spent to an eviction round.</summary> </histogram> -<histogram name="Quota.TotalDiskSpace" units="MB" expires_after="2021-10-10"> +<histogram name="Quota.TotalDiskSpace" units="MB" expires_after="2022-10-06"> <owner>jarrydg@chromium.org</owner> + <owner>chrome-owp-storage@google.com</owner> <summary> Total disk space for the storage directory. Logged at irregular intervals. </summary> diff --git a/chromium/tools/metrics/histograms/metadata/renderer/histograms.xml b/chromium/tools/metrics/histograms/metadata/renderer/histograms.xml index 54a59c2eaec..f9baa9cceb7 100644 --- a/chromium/tools/metrics/histograms/metadata/renderer/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/renderer/histograms.xml @@ -51,9 +51,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Renderer.DelegatedInkTrail.LatencyImprovement.{Renderer}.{Prediction}" - units="ms" expires_after="M95"> + units="ms" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> + <owner>joalmei@microsoft.com</owner> <summary> The latency improvement provided by the delegated ink trail API, both with and without prediction, in milliseconds. This latency improvement is the @@ -73,9 +73,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Renderer.DelegatedInkTrail.LatencyImprovementWithPrediction.Experiment{Number}" - units="ms" expires_after="M95"> + units="ms" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> + <owner>joalmei@microsoft.com</owner> <summary> The latency improvement provided by predicting extra delegated ink points when using the delegated ink trail API with SkiaRenderer in milliseconds. @@ -94,9 +94,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.DelegatedInkTrail.Prediction.WrongDirection" - enum="BooleanDirection" expires_after="M95"> + enum="BooleanDirection" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> + <owner>joalmei@microsoft.com</owner> <summary> Boolean that indicates whether the prediction is in the same direction as the real trajectory at the same prediction time. True means the direction is @@ -109,9 +109,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.DelegatedInkTrail.Prediction.{Direction}Prediction" - units="pixels" expires_after="M95"> + units="pixels" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> + <owner>joalmei@microsoft.com</owner> <summary> {Direction}shoot distance in pixels between a predicted point and the corresponding interpolated real point that occurred at the prediction time. @@ -127,9 +127,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.DelegatedInkTrail.Prediction.{Type}Jitter" - units="pixels" expires_after="M95"> + units="pixels" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> + <owner>joalmei@microsoft.com</owner> <summary> Euclidean distance in pixels between two successive variations of delegated ink trail deltas which are the difference beween a predicted delegated ink @@ -148,9 +148,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Renderer.DelegatedInkTrail.PredictionExperiment{Number}.Frame{ScoreType}" - units="pixels" expires_after="M95"> + units="pixels" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> <owner>joalmei@microsoft.com</owner> <summary> Distance in pixels between a predicted point and the corresponding @@ -177,9 +176,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Renderer.DelegatedInkTrail.PredictionExperiment{Number}.WrongDirection" - enum="BooleanDirection" expires_after="M95"> + enum="BooleanDirection" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> + <owner>joalmei@microsoft.com</owner> <summary> Whether the prediction is in the same direction as the real trajectory at the same prediction time. @@ -197,9 +196,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Renderer.DelegatedInkTrail.PredictionExperiment{Number}.{ScoreType}" - units="pixels" expires_after="M95"> + units="pixels" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> <owner>joalmei@microsoft.com</owner> <summary> Distance in pixels between a predicted point and the corresponding @@ -223,9 +221,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Renderer.DelegatedInkTrail.PredictionExperiment{Number}.{Type}Jitter" - units="pixels" expires_after="M95"> + units="pixels" expires_after="M98"> <owner>jonross@chromium.org</owner> - <owner>mabian@microsoft.com</owner> + <owner>joalmei@microsoft.com</owner> <summary> Euclidean distance in pixels between two successive variations of delegated ink trail deltas which are the difference beween a predicted delegated ink @@ -247,10 +245,37 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> -<histogram name="Renderer.Font.PrimaryFont.FCP" units="ms" - expires_after="2021-10-31"> +<histogram name="Renderer.Font.PrimaryFont.DomContentLoaded" units="ms" + expires_after="2022-01-31"> + <owner>kojii@chromium.org</owner> + <owner>tkent@chromium.org</owner> + <owner>yosin@chromium.org</owner> + <owner>layout-dev@chromium.org</owner> + <summary> + The time spent acquiring the primary font consumed in the main tread before + DomContentLoaded. On Windows, this includes IPC roundtrip to browser process + and DirectWriteFontProxy and DirectWrite calls. + </summary> +</histogram> + +<histogram name="Renderer.Font.PrimaryFont.DomContentLoaded.Style" units="ms" + expires_after="2022-01-31"> + <owner>kojii@chromium.org</owner> + <owner>tkent@chromium.org</owner> <owner>yosin@chromium.org</owner> + <owner>layout-dev@chromium.org</owner> + <summary> + The time spent acquiring the primary font consumed in style recalc, in the + main tread before DomContentLoaded. On Windows, this includes IPC roundtrip + to browser process and DirectWriteFontProxy and DirectWrite calls. + </summary> +</histogram> + +<histogram name="Renderer.Font.PrimaryFont.FCP" units="ms" + expires_after="2022-04-03"> <owner>kojii@chromium.org</owner> + <owner>tkent@chromium.org</owner> + <owner>yosin@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> The time spent acquiring the primary font consumed in the main tread before @@ -260,9 +285,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.Font.PrimaryFont.FCP.Style" units="ms" - expires_after="2021-10-31"> - <owner>yosin@chromium.org</owner> + expires_after="2022-04-03"> <owner>kojii@chromium.org</owner> + <owner>tkent@chromium.org</owner> + <owner>yosin@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> The time spent acquiring the primary font consumed in style recalc, in the @@ -271,10 +297,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Renderer.Font.SystemFallback.FCP" units="ms" - expires_after="2021-10-31"> +<histogram name="Renderer.Font.SystemFallback.DomContentLoaded" units="ms" + expires_after="2022-01-31"> + <owner>kojii@chromium.org</owner> + <owner>tkent@chromium.org</owner> <owner>yosin@chromium.org</owner> + <owner>layout-dev@chromium.org</owner> + <summary> + The time spent finding the system fallback font consumed in the main tread + before DomContentLoaded. On Windows, this includes IPC roundtrip to browser + process and DirectWriteFontProxy and DirectWrite calls. + </summary> +</histogram> + +<histogram name="Renderer.Font.SystemFallback.FCP" units="ms" + expires_after="2022-04-10"> <owner>kojii@chromium.org</owner> + <owner>tkent@chromium.org</owner> + <owner>yosin@chromium.org</owner> <owner>layout-dev@chromium.org</owner> <summary> The time spent finding the system fallback font consumed in the main tread @@ -311,6 +351,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Renderer.OnReceiveResponseToOnStartLoadingResponseBody" units="ms" expires_after="M85"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -322,7 +365,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.PaintPreview.Capture.MainFrameBlinkCaptureDuration" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-04-10"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -333,7 +376,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.PaintPreview.Capture.MainFrameSuccess" - enum="BooleanSuccess" expires_after="2021-08-29"> + enum="BooleanSuccess" expires_after="2022-01-02"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -343,7 +386,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.PaintPreview.Capture.SubframeBlinkCaptureDuration" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-03-06"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -354,7 +397,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.PaintPreview.Capture.SubframeSuccess" - enum="BooleanSuccess" expires_after="2021-10-31"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>ckitagawa@chromium.org</owner> <owner>mahmoudi@chromium.org</owner> <owner>fredmello@chromium.org</owner> @@ -379,7 +422,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer.ProcessLifetime2.{Resolution}" units="ms" - expires_after="2021-08-29"> + expires_after="2022-02-28"> <owner>olivierli@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> @@ -443,6 +486,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="RendererScheduler.QueueingDurationPerQueueType" units="ms" expires_after="2021-10-10"> + <obsolete> + Removed in M92. + </obsolete> <!-- Name completed by histogram_suffixes name="RendererScheduler.QueueType" --> <owner>kdillon@chromium.org</owner> @@ -456,7 +502,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="RendererScheduler.RendererMainThreadLoad5" units="%" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>altimin@chromium.org</owner> <summary> Renderer main thread load (percentage of time spent in tasks), reported in diff --git a/chromium/tools/metrics/histograms/metadata/renderer4/histograms.xml b/chromium/tools/metrics/histograms/metadata/renderer4/histograms.xml index 15d9dbd7d59..d045cd5357a 100644 --- a/chromium/tools/metrics/histograms/metadata/renderer4/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/renderer4/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Renderer4.Browser.RasterTaskSchedulingDelayNoAtRasterDecodes" - units="microseconds" expires_after="2021-09-30"> + units="microseconds" expires_after="2022-09-30"> <owner>andrescj@chromium.org</owner> <owner>chromeos-gfx@google.com</owner> <summary> @@ -36,7 +36,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer4.Browser.RasterTaskTotalDuration" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-24"> <owner>khushalsagar@chromium.org</owner> <owner>chrome-gpu@google.com</owner> <summary> @@ -123,7 +123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer4.GpuRasterizationEnabled" enum="BooleanEnabled" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>ericrk@chromium.org</owner> <owner>enne@chromium.org</owner> <summary> @@ -133,7 +133,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Renderer4.ImageDecodeTaskDurationUs" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="DecodedImageType" --> <!-- Name completed by histogram_suffixes name="OutOfRaster" --> @@ -179,7 +179,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer4.MainThreadGestureScrollReason" - enum="MainThreadScrollingReason" expires_after="M97"> + enum="MainThreadScrollingReason" expires_after="2022-04-10"> <owner>flackr@chromium.org</owner> <owner>pdr@chromium.org</owner> <owner>input-dev@chromium.org</owner> @@ -194,7 +194,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer4.MainThreadWheelScrollReason" - enum="MainThreadScrollingReason" expires_after="M97"> + enum="MainThreadScrollingReason" expires_after="2022-04-03"> <owner>flackr@chromium.org</owner> <owner>pdr@chromium.org</owner> <owner>input-dev@chromium.org</owner> @@ -232,7 +232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer4.Renderer.RasterTaskSchedulingDelayNoAtRasterDecodes" - units="microseconds" expires_after="2021-09-30"> + units="microseconds" expires_after="2022-09-30"> <owner>andrescj@chromium.org</owner> <owner>chromeos-gfx@google.com</owner> <summary> @@ -246,7 +246,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer4.Renderer.RasterTaskTotalDuration" - units="microseconds" expires_after="2022-02-06"> + units="microseconds" expires_after="2022-04-10"> <owner>khushalsagar@chromium.org</owner> <owner>chrome-gpu@google.com</owner> <summary> @@ -272,7 +272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Renderer4.ScrollingThread" enum="ScrollingThreadStatus" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="ScrollSourceDevice" --> <owner>bokan@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/safe_browsing/histograms.xml b/chromium/tools/metrics/histograms/metadata/safe_browsing/histograms.xml index 522c6bb7b93..d4bb5e6feda 100644 --- a/chromium/tools/metrics/histograms/metadata/safe_browsing/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/safe_browsing/histograms.xml @@ -38,6 +38,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. summary="real time URL check warning bypass"/> </variants> +<variants name="MetricsCollectorSecuritySensitiveEventType"> + <variant name="Download" summary="download"/> + <variant name="PasswordProtection" summary="password protection"/> + <variant name="SafeBrowsingInterstitial" + summary="safe browsing interstitial"/> + <variant name="SSLInterstitial" summary="SSL interstitial"/> +</variants> + <variants name="MetricsCollectorUserState"> <variant name="EnhancedProtection" summary="enhanced protection"/> <variant name="Managed" summary="Safe Browsing managed mode"/> @@ -67,7 +75,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="SafeBrowsing.AdvancedProtection.APTokenFetchStatus" - enum="GoogleServiceAuthError" expires_after="2022-01-23"> + enum="GoogleServiceAuthError" expires_after="2022-05-01"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -80,7 +88,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.AdvancedProtection.TokenFetchStatus" - enum="GoogleServiceAuthError" expires_after="2021-11-21"> + enum="GoogleServiceAuthError" expires_after="2022-04-24"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -103,7 +111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.AndroidTelemetry.ApkDownload.IsMimeTypeApk" - enum="BooleanIsMimeTypeApk" expires_after="2022-02-05"> + enum="BooleanIsMimeTypeApk" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -113,7 +121,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.AndroidTelemetry.ApkDownload.Outcome" - enum="ApkDownloadTelemetryOutcome" expires_after="2022-01-09"> + enum="ApkDownloadTelemetryOutcome" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -123,7 +131,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.BlockingPage.RequestDestination" - enum="RequestDestination" expires_after="2021-12-12"> + enum="RequestDestination" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -169,7 +177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.BrowserThrottle.TotalDelay" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -181,7 +189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.CheckBrowseUrl.HasLocalMatch" - enum="BooleanMatched" expires_after="2022-02-06"> + enum="BooleanMatched" expires_after="2022-04-17"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -192,7 +200,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.CheckUrl.Timeout" enum="BooleanTimedOut" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -202,7 +210,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.CredentialPhishedStatusChange" - enum="CredentialPhishedStatus" expires_after="2021-12-01"> + enum="CredentialPhishedStatus" expires_after="2022-04-10"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -228,6 +236,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram + name="SafeBrowsing.Daily.SecuritySensitiveCountLast28Days.{UserState}.{EventType}" + units="events" expires_after="2022-03-08"> + <owner>bhatiarohit@google.com</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Logs the total number of security sensitive {EventType} in the last 28 days. + Recorded for all non-Incognito profiles that are under {UserState} every 24 + hours and at startup if the last recording was more than 24 hours ago. + </summary> + <token key="UserState" variants="MetricsCollectorUserState"/> + <token key="EventType" variants="MetricsCollectorSecuritySensitiveEventType"> + <variant name="AllEvents" summary="any type of events"/> + </token> +</histogram> + <histogram name="SafeBrowsing.DeepScan.Download.BypassedByUser.Duration" units="ms" expires_after="2022-02-01"> <owner>domfc@chromium.org</owner> @@ -241,7 +265,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.DeepScan.Download.BytesPerSeconds" units="bytes" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -252,7 +276,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.DeepScan.Download.Duration" units="ms" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -306,7 +330,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.DeepScan.Download.Success.Duration" units="ms" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -316,7 +340,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.DeepScan.Download.Timeout.Duration" units="ms" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -492,7 +516,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.DeepScan.Paste.BytesPerSeconds" units="bytes" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -514,7 +538,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.DeepScan.Paste.Duration" units="ms" - expires_after="2022-02-01"> + expires_after="2022-05-01"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -631,7 +655,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.DeepScan.Upload.Duration" units="ms" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>domfc@chromium.org</owner> <owner>webprotect-team@google.com</owner> <summary> @@ -815,7 +839,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.EsbDisabled.LastBypassEventType" - enum="SBMetricsCollectorEventType" expires_after="2022-02-05"> + enum="SBMetricsCollectorEventType" expires_after="2022-04-10"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -826,7 +850,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.EsbDisabled.LastEnabledInterval" units="days" - expires_after="2022-03-01"> + expires_after="2022-05-01"> <owner>anise@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -960,7 +984,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SafeBrowsing.NavigationObserver.IdentifyReferrerChainByEventURLTime" - units="ms" expires_after="2022-01-23"> + units="ms" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -971,7 +995,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SafeBrowsing.NavigationObserver.IdentifyReferrerChainByWebContentsTime" - units="ms" expires_after="2022-01-23"> + units="ms" expires_after="2022-05-01"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1004,6 +1028,46 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="SafeBrowsing.NoCachedPopulationReason" + enum="SafeBrowsingNoCachedPopulationReason" expires_after="2021-12-10"> + <owner>drubery@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Whenever Safe Browsing sends a request with no cached user population to + compare it to, we record the reason the cache is empty. + </summary> +</histogram> + +<histogram name="SafeBrowsing.PageLoadToken.PasswordProtectionHasToken" + units="BooleanExists" expires_after="2022-10-08"> + <owner>xinghuilu@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records whether a page load token is found before password protection + request is sent. Logged only when real time URL check is enabled. + </summary> +</histogram> + +<histogram name="SafeBrowsing.PageLoadToken.RealTimeCheckHasToken" + units="BooleanExists" expires_after="2022-10-08"> + <owner>xinghuilu@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records whether a page load token is found before real time URL check + request is sent. Logged only when the check is on a subframe URL. + </summary> +</histogram> + +<histogram name="SafeBrowsing.PageLoadToken.TokenCount" units="entries" + expires_after="2022-10-08"> + <owner>xinghuilu@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records the number of page load tokens stored in verdict cache manager. + Logged each time after a periodic clean up on expired tokens is performed. + </summary> +</histogram> + <histogram name="SafeBrowsing.PakIntegrity.{PakFile}" enum="BooleanSuccess" expires_after="2022-05-01"> <owner>rsesek@chromium.org</owner> @@ -1021,7 +1085,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.Policy.AllowlistDomainsTotalSize" units="bytes" - expires_after="2022-02-26"> + expires_after="2022-05-01"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1033,8 +1097,25 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="SafeBrowsing.PopulationMatchesCachedValue.{Field}" + enum="BooleanMatched" expires_after="2021-12-10"> + <owner>drubery@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Whenever the ChromeUserPopulation proto is created (almost every time Safe + Browsing is contacted), we compare it to a cached value. This histogram + records whether the cached value has the same value in {Field} as the newly + created value. + </summary> + <token key="Field"> + <variant name="Mbb" summary="Make Browsing Better preference"/> + <variant name="Population" summary="Safe Browsing population"/> + <variant name="UserAgent" summary="User agent"/> + </token> +</histogram> + <histogram name="SafeBrowsing.Pref.Daily.Extended" enum="BooleanEnabled" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1045,7 +1126,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.Pref.Daily.SafeBrowsingModeManaged" - enum="BooleanManagedPref" expires_after="2022-01-26"> + enum="BooleanManagedPref" expires_after="2022-04-24"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1056,7 +1137,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.Pref.Daily.SafeBrowsingState" - enum="SafeBrowsingState" expires_after="2021-11-04"> + enum="SafeBrowsingState" expires_after="2022-10-06"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1103,7 +1184,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.Pref.MainProfile.SafeBrowsingState" - enum="SafeBrowsingState" expires_after="2022-05-01"> + enum="SafeBrowsingState" expires_after="2022-10-01"> <owner>jeffcyr@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1124,7 +1205,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.ReferrerAttributionResult" - enum="SafeBrowsingAttributionResultTypes" expires_after="2021-10-31"> + enum="SafeBrowsingAttributionResultTypes" expires_after="2022-10-31"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1136,6 +1217,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SafeBrowsing.ReferrerHasInvalidTabID" enum="BooleanInvalid" expires_after="2021-10-25"> + <obsolete> + Removed 09-2021 due to lack of use + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1146,7 +1230,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.ReferrerURLChainSize" units="units" - expires_after="2021-10-25"> + expires_after="2022-10-25"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1182,7 +1266,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.AllowlistSizeTooSmall" - enum="BooleanUnavailable" expires_after="2022-01-12"> + enum="BooleanUnavailable" expires_after="2022-05-01"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1195,7 +1279,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.AllStoresAvailable" enum="BooleanAvailable" - expires_after="2021-10-17"> + expires_after="2022-10-06"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1206,7 +1290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.Backoff.State" enum="BooleanEnabled" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1217,7 +1301,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.CacheManager.CleanUpTime" units="ms" - expires_after="2022-01-23"> + expires_after="2022-05-01"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1227,7 +1311,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.CacheManager.RealTimeVerdictCount" - units="entries" expires_after="2021-12-26"> + units="entries" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1237,7 +1321,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.CanCheckDatabase" enum="BooleanEnabled" - expires_after="2021-11-14"> + expires_after="2022-10-06"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1247,7 +1331,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.GetCache.FallbackThreatType" - enum="SBThreatType" expires_after="2021-12-16"> + enum="SBThreatType" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1260,7 +1344,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.GetCache.Time" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1271,7 +1355,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.GetCacheResult" - enum="SafeBrowsingRTLookupResponseVerdictType" expires_after="2022-01-02"> + enum="SafeBrowsingRTLookupResponseVerdictType" expires_after="2022-03-06"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1283,7 +1367,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.GetToken.Time" units="ms" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1294,7 +1378,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.HasTokenFromFetcher" enum="BooleanHasToken" - expires_after="2022-01-16"> + expires_after="2022-04-17"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1305,7 +1389,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.HasTokenInRequest" enum="BooleanHasToken" - expires_after="2022-01-16"> + expires_after="2022-04-10"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1317,6 +1401,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SafeBrowsing.RT.HasValidCacheManager" enum="BooleanValid" expires_after="2021-08-29"> + <obsolete> + Removed from code in M95. Not useful. + </obsolete> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1327,7 +1414,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.IsLookupServiceAvailable" - enum="BooleanAvailable" expires_after="2022-01-16"> + enum="BooleanAvailable" expires_after="2022-03-20"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1339,7 +1426,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.IsLookupSuccessful" enum="BooleanSuccess" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1349,8 +1436,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="SafeBrowsing.RT.IsPopulationMbbOrEsb" enum="Boolean" + expires_after="2022-04-17"> + <owner>drubery@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records whether the user population field is from the enabled populations + (MBB and ESB) or not. Logged on every real time lookup. + </summary> +</histogram> + <histogram name="SafeBrowsing.RT.LocalMatch.Result" - enum="SafeBrowsingAllowlistAsyncMatch" expires_after="2022-02-06"> + enum="SafeBrowsingAllowlistAsyncMatch" expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1376,7 +1473,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.Network.Result" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-02-06"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1388,7 +1485,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.Network.Time" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1411,7 +1508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.Request.Size" units="bytes" - expires_after="2022-01-08"> + expires_after="2022-03-13"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1421,7 +1518,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.RT.Request.UserPopulation" - enum="SafeBrowsingUserPopulation" expires_after="2022-01-16"> + enum="SafeBrowsingUserPopulation" expires_after="2022-04-10"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1489,8 +1586,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="SafeBrowsing.RT.Response.VerdictType" + enum="SafeBrowsingRTLookupResponseVerdictType" expires_after="2022-09-10"> + <owner>xinghuilu@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Logs the verdict type of the response from real time URL check. Logged each + time a response is received and the threat info size is greater than 0. + </summary> +</histogram> + <histogram name="SafeBrowsing.RT.ThreatInfoSize" units="verdicts" - expires_after="2021-12-19"> + expires_after="2022-04-17"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1501,7 +1608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="SafeBrowsing.Settings.UserAction" - enum="SafeBrowsingSettingsUserAction" expires_after="2021-12-19"> + enum="SafeBrowsingSettingsUserAction" expires_after="2022-04-03"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1512,7 +1619,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.TokenFetcher.ErrorType" - enum="GoogleServiceAuthError" expires_after="2021-12-12"> + enum="GoogleServiceAuthError" expires_after="2022-04-24"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1587,7 +1694,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.V4Database.Size" units="KB" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1607,7 +1714,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.V4GetHash.CacheHit.Result" - enum="SafeBrowsingV4FullHashCacheResult" expires_after="2021-12-12"> + enum="SafeBrowsingV4FullHashCacheResult" expires_after="2022-04-17"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary>Track cache hits for V4 full hashes.</summary> @@ -1623,7 +1730,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.V4GetHash.CountOfPrefixes" units="prefixes" - expires_after="2021-12-03"> + expires_after="2022-04-17"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1648,7 +1755,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SafeBrowsing.V4GetHash.Network.Time" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1672,7 +1779,7 @@ Safe Browsing lookup mechanism is working as expected --> </histogram> <histogram name="SafeBrowsing.V4GetHash.Result" - enum="SafeBrowsingV4OperationResult" expires_after="2022-02-06"> + enum="SafeBrowsingV4OperationResult" expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1746,7 +1853,7 @@ Safe Browsing lookup mechanism is working as expected --> </histogram> <histogram name="SafeBrowsing.V4ProcessFullUpdate.AdditionsHashesCount2" - units="entries" expires_after="2021-08-29"> + units="entries" expires_after="2022-08-20"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1802,7 +1909,7 @@ and applied correctly. --> </histogram> <histogram name="SafeBrowsing.V4ProcessPartialUpdate.AdditionsHashesCount" - units="entries" expires_after="2022-01-09"> + units="entries" expires_after="2022-04-17"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1812,7 +1919,7 @@ and applied correctly. --> </histogram> <histogram name="SafeBrowsing.V4ProcessPartialUpdate.ApplyUpdate.Result" - enum="SafeBrowsingV4ApplyUpdateResult" expires_after="2021-11-07"> + enum="SafeBrowsingV4ApplyUpdateResult" expires_after="2022-04-17"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1865,7 +1972,7 @@ and applied correctly. --> </histogram> <histogram name="SafeBrowsing.V4ProcessPartialUpdate.RemovalsHashesCount" - units="entries" expires_after="2021-11-07"> + units="entries" expires_after="2022-10-06"> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1926,7 +2033,7 @@ and applied correctly. --> </histogram> <histogram name="SafeBrowsing.V4Store.NewFileNameExists.{NewFileNames}" - enum="Boolean" expires_after="2021-09-09"> + enum="Boolean" expires_after="2022-09-09"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1939,7 +2046,7 @@ and applied correctly. --> </histogram> <histogram name="SafeBrowsing.V4Store.OldFileNameExists.{OldFileNames}" - enum="Boolean" expires_after="2021-09-09"> + enum="Boolean" expires_after="2022-09-09"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1952,7 +2059,7 @@ and applied correctly. --> </histogram> <histogram name="SafeBrowsing.V4Store.OldFileNameInUse.{OldFileNames}" - enum="Boolean" expires_after="2021-09-09"> + enum="Boolean" expires_after="2022-09-09"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -1965,7 +2072,7 @@ and applied correctly. --> </histogram> <histogram name="SafeBrowsing.V4Store.RenameStatus.{NewFileNames}" - enum="PlatformFileError" expires_after="2021-09-09"> + enum="PlatformFileError" expires_after="2022-09-09"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2003,7 +2110,7 @@ security at risk. --> </histogram> <histogram name="SafeBrowsing.V4Update.Network.Result" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-01-30"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-04-03"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2028,7 +2135,7 @@ risk. --> </histogram> <histogram name="SafeBrowsing.V4Update.ResponseSizeKB" units="KB" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2108,7 +2215,7 @@ failing to fetch the updates which puts users' security at risk. --> </histogram> <histogram name="SafeBrowsingBinaryUploadRequest.DlpResult" - enum="BooleanSuccess" expires_after="2022-01-23"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2119,7 +2226,7 @@ failing to fetch the updates which puts users' security at risk. --> </histogram> <histogram name="SafeBrowsingBinaryUploadRequest.Duration" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2130,7 +2237,7 @@ failing to fetch the updates which puts users' security at risk. --> </histogram> <histogram name="SafeBrowsingBinaryUploadRequest.MalwareResult" - enum="BooleanSuccess" expires_after="2022-01-23"> + enum="BooleanSuccess" expires_after="2022-04-10"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2156,7 +2263,7 @@ failing to fetch the updates which puts users' security at risk. --> </histogram> <histogram name="SafeBrowsingBinaryUploadRequest.Result" - enum="SafeBrowsingBinaryUploadResult" expires_after="2022-01-23"> + enum="SafeBrowsingBinaryUploadResult" expires_after="2022-04-10"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2167,7 +2274,7 @@ failing to fetch the updates which puts users' security at risk. --> </histogram> <histogram name="SafeBrowsingBinaryUploadRequest.TimeToGetFCMToken" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2177,7 +2284,7 @@ failing to fetch the updates which puts users' security at risk. --> </histogram> <histogram name="SafeBrowsingBinaryUploadService.ActiveRequestsAtShutdown" - units="requests" expires_after="2022-01-31"> + units="requests" expires_after="2022-04-24"> <owner>domfc@chromium.org</owner> <owner>jgingras@chromium.org</owner> <owner>webprotect-eng@google.com</owner> @@ -2190,6 +2297,9 @@ failing to fetch the updates which puts users' security at risk. --> <histogram name="SafeBrowsingFCMService.IncomingMessageHasKey" enum="Boolean" expires_after="M95"> + <obsolete> + Removed 09-2021 since all recorded values were True + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2202,7 +2312,7 @@ failing to fetch the updates which puts users' security at risk. --> </histogram> <histogram name="SafeBrowsingFCMService.IncomingMessageHasValidToken" - enum="Boolean" expires_after="2021-12-12"> + enum="Boolean" expires_after="2022-05-01"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2217,6 +2327,9 @@ failing to fetch the updates which puts users' security at risk. --> <histogram name="SafeBrowsingFCMService.IncomingMessageParsedBase64" enum="BooleanSuccess" expires_after="M95"> + <obsolete> + Removed 09-2021 since all recorded values were True + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -2231,6 +2344,9 @@ failing to fetch the updates which puts users' security at risk. --> <histogram name="SafeBrowsingFCMService.IncomingMessageParsedProto" enum="BooleanSuccess" expires_after="M95"> + <obsolete> + Removed 09-2021 since all recorded values were True + </obsolete> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/sb_client/histograms.xml b/chromium/tools/metrics/histograms/metadata/sb_client/histograms.xml index 47be10c0360..c966df98921 100644 --- a/chromium/tools/metrics/histograms/metadata/sb_client/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/sb_client/histograms.xml @@ -65,7 +65,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientDownload.DeepScanTrigger" enum="SBDeepScanTriggers" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -87,8 +87,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="SBClientDownload.DocumentAnalysisSuccess" units="Boolean" + expires_after="2022-08-15"> + <owner>anise@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + For each Office file analyzed by the SafeBrowsing download service, records + if analysis by maldoca was successful. + </summary> +</histogram> + <histogram name="SBClientDownload.DownloadExtensions" - enum="SBClientDownloadExtensions" expires_after="2022-01-02"> + enum="SBClientDownloadExtensions" expires_after="2022-04-10"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <owner>mattm@chromium.org</owner> @@ -125,7 +135,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientDownload.DownloadRequestNetError" enum="NetErrorCodes" - expires_after="2022-01-16"> + expires_after="2022-04-24"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <owner>mattm@chromium.org</owner> @@ -170,7 +180,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientDownload.DownloadRequestResponseCode" - enum="HttpResponseCode" expires_after="2021-11-07"> + enum="HttpResponseCode" expires_after="2022-04-24"> <owner>vakh@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <owner>mattm@chromium.org</owner> @@ -194,6 +204,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="SBClientDownload.ExtractDocumentFeaturesTimeMedium" units="ms" + expires_after="2022-08-15"> + <owner>anise@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records the time it takes for the SafeBrowsing download service to extract + info from an Office document. + </summary> +</histogram> + <histogram name="SBClientDownload.ExtractRarFeaturesTimeMedium" units="ms" expires_after="2021-05-05"> <obsolete> @@ -241,6 +261,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SBClientDownload.SafeDownloadOpenedLatency.{ShowAction}" units="ms" expires_after="2022-05-20"> + <obsolete> + Removed 09-2021 in favor of SBClientDownload.SafeDownloadOpenedLatency2 + which filters autopened downloads. + </obsolete> <owner>xinghuilu@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -255,6 +279,68 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="SBClientDownload.SafeDownloadOpenedLatency2.{ShowAction}" + units="ms" expires_after="2022-05-20"> + <owner>xinghuilu@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records the latency between when a safe download is completed and when the + user {ShowAction}. Users can open the download either from the download + shelf or from the downloads page. Note that if the user opens the same + download for several times, this metric is recorded each time. Excludes + downloads that were auto opened. + </summary> + <token key="ShowAction"> + <variant name="OpenDirectly" summary="opens the download directly"/> + <variant name="ShowInFolder" summary="clicks show in folder"/> + </token> +</histogram> + +<histogram + name="SBClientDownload.SafeDownloadOpenedLatencyByContentType.{DownloadContent}" + units="ms" expires_after="2022-09-30"> + <owner>anise@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records the latency between when a safe {DownloadContent} download is + completed and when the user opens the download either from the download + shelf or from the downloads page. Note that if the user opens the same + download for several times, this metric is recorded each time. Also, this + metrics excludes downloads that were auto opened. + </summary> + <token key="DownloadContent"> + <variant name="APK" summary="apk"/> + <variant name="ARCHIVE" summary="archive"/> + <variant name="AUDIO" summary="audio"/> + <variant name="CRX" summary="crx"/> + <variant name="DMG" summary="dmg"/> + <variant name="DOCUMENT" summary="document"/> + <variant name="EBOOK" summary="ebook"/> + <variant name="EXECUTABLE" summary="executable"/> + <variant name="FONT" summary="font"/> + <variant name="IMAGE" summary="image"/> + <variant name="MAX" summary="max"/> + <variant name="OCTET_STREAM" summary="octet stream"/> + <variant name="PDF" summary="pdf"/> + <variant name="PRESENTATION" summary="presentation"/> + <variant name="SPREADSHEET" summary="spreadsheet"/> + <variant name="TEXT" summary="text"/> + <variant name="UNRECOGNIZED" summary="unrecognized"/> + <variant name="VIDEO" summary="video"/> + <variant name="WEB" summary="web"/> + </token> +</histogram> + +<histogram name="SBClientDownload.ServerRequestsDeepScanningPrompt" + enum="BooleanRequested" expires_after="2022-03-01"> + <owner>drubery@chromium.org</owner> + <owner>chrome-safebrowsing-alerts@google.com</owner> + <summary> + Records how often users in a population consented to deep scanning are + actually prompted for deep scanning. + </summary> +</histogram> + <histogram name="SBClientDownload.UserGestureFileType.Attributes" enum="SBClientDownloadUserGestureFileTypeAttributes" expires_after="2022-08-10"> @@ -419,7 +505,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.CacheDetectsPhishing" - enum="BooleanIsPhishing" expires_after="2021-09-17"> + enum="BooleanIsPhishing" expires_after="2022-09-17"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -430,7 +516,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SBClientPhishing.CancelClassificationReason" enum="SBClientPhishingCancelClassificationReason" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -454,7 +540,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.Classifier.Event" - enum="SBPhishingClassifierEvent" expires_after="2021-12-05"> + enum="SBPhishingClassifierEvent" expires_after="2022-04-24"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -481,7 +567,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SBClientPhishing.ClientModelDownloadResponseOrErrorCode" enum="CombinedHttpResponseAndNetErrorCode" expires_after="M94"> - <owner>drubery@google.com</owner> + <obsolete> + Remove 09-2021 + </obsolete> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Response or error codes from the SafeBrowsing service. Logged after a @@ -572,7 +660,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.FlatBufferMappedRegionValid" - enum="BooleanSuccess" expires_after="2021-11-25"> + enum="BooleanSuccess" expires_after="2022-04-03"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -583,7 +671,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.FlatBufferScorer.CreationStatus" - enum="SBClientPhishingScorerCreationStatus" expires_after="M94"> + enum="SBClientPhishingScorerCreationStatus" expires_after="M97"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -676,7 +764,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.PhishingDetectionDuration" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -699,17 +787,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SBClientPhishing.PreClassificationCheckResult" enum="SBClientDetectionPreClassificationCheckResult" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Records the result of phishing pre-classification checks. This is recorded on every classification attempt (roughly every page load). + + Starting in M95, the PRIVATE_IP bucket was split to include LOCAL_RESOURCE + and CHROME_UI_PAGE. </summary> </histogram> <histogram name="SBClientPhishing.ProtobufScorer.CreationStatus" - enum="SBClientPhishingScorerCreationStatus" expires_after="M94"> + enum="SBClientPhishingScorerCreationStatus" expires_after="2022-04-03"> <owner>bhatiarohit@google.com</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -805,7 +896,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.TermFeatureChunkTime" units="ms" - expires_after="2021-10-17"> + expires_after="2022-10-17"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -814,7 +905,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.TermFeatureIterations" units="units" - expires_after="2021-10-31"> + expires_after="2022-10-17"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -823,7 +914,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.TermFeatureTimeout" units="units" - expires_after="2021-10-17"> + expires_after="2022-10-17"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -866,7 +957,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.VisualComparisonTime" units="ms" - expires_after="2021-12-05"> + expires_after="2022-04-03"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -876,7 +967,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SBClientPhishing.VisualFeatureTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/scanning/histograms.xml b/chromium/tools/metrics/histograms/metadata/scanning/histograms.xml index 138e43378ee..47e51eadcf5 100644 --- a/chromium/tools/metrics/histograms/metadata/scanning/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/scanning/histograms.xml @@ -21,6 +21,77 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> +<histogram name="Scanning.CombinedImageSizeInKbBeforePdf" units="KB" + expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + Records the total size of the scanned images stored in memory right before + they are converted into the final PDF. + </summary> +</histogram> + +<histogram name="Scanning.MultiPageScan.CombinedImageSizeInKbBeforePdf" + units="KB" expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + During a multi-page scan session, records the total size of the scanned + images stored in memory at the moment the user clicks save to convert them + into the final PDF. + </summary> +</histogram> + +<histogram name="Scanning.MultiPageScan.NumPagesScanned" units="pages" + expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + Records the number of pages scanned in a saved multi-page scan session. + </summary> +</histogram> + +<histogram name="Scanning.MultiPageScan.PageScanResult" + enum="ScanJobFailureReason" expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + Records the success status of each page scan in a multi-page scan session. + </summary> +</histogram> + +<histogram name="Scanning.MultiPageScan.PDFGenerationTime" units="ms" + expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + Records the amount of time it takes from the user clicking save on their + multi-page scan session to the PDF file being generated and saved. + </summary> +</histogram> + +<histogram name="Scanning.MultiPageScan.SessionDuration" units="ms" + expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + Records the time between a user starting the first scan in a multi-page scan + session to the time the user clicks save to end the session. This does not + record when a multi-page scan session ends prematurely without the PDF being + saved. + </summary> +</histogram> + +<histogram name="Scanning.MultiPageScan.ToolbarAction" + enum="ScanMultiPageToolbarAction" expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + Records when a user clicks an action on the action toolbar in a multi-page + scan session. + </summary> +</histogram> + <histogram name="Scanning.NumCompletedScansInSession" units="scans" expires_after="2022-06-15"> <owner>gavinwill@chromium.org</owner> @@ -43,7 +114,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Scanning.NumDetectedScannersAtLogin" units="scanners" - expires_after="M99"> + expires_after="2022-04-17"> <owner>gavinwill@chromium.org</owner> <owner>masonwilde@google.com</owner> <owner>cros-peripherals@google.com</owner> @@ -61,7 +132,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Scanning.NumPagesScanned" units="pages" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>gavinwill@chromium.org</owner> <owner>cros-peripherals@google.com</owner> <summary>Records the number of pages scanned in a successful scan.</summary> @@ -76,6 +147,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Scanning.PDFGenerationTime" units="ms" + expires_after="2022-09-03"> + <owner>gavinwill@chromium.org</owner> + <owner>cros-peripherals@google.com</owner> + <summary> + Records the amount of time it takes from the final document in a scan job + being scanned to the PDF file being generated and saved. + </summary> +</histogram> + <histogram name="Scanning.ReadyTime" units="ms" expires_after="2022-06-15"> <owner>gavinwill@chromium.org</owner> <owner>cros-peripherals@google.com</owner> diff --git a/chromium/tools/metrics/histograms/metadata/scheduler/histograms.xml b/chromium/tools/metrics/histograms/metadata/scheduler/histograms.xml index d7cc9436d6a..55dcb1d6ba2 100644 --- a/chromium/tools/metrics/histograms/metadata/scheduler/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/scheduler/histograms.xml @@ -254,7 +254,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Scheduling.Renderer.DeadlineMode" - enum="RendererSchedulerDeadlineMode" expires_after="2022-01-01"> + enum="RendererSchedulerDeadlineMode" expires_after="2022-04-17"> <owner>weiliangc@chromium.org</owner> <owner>chrome-gpu-metrics@chromium.org</owner> <summary> @@ -290,7 +290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Scheduling.Renderer.DrawIntervalWithCustomPropertyAnimations2" - units="microseconds" expires_after="2022-02-01"> + units="microseconds" expires_after="2022-05-01"> <owner>xidachen@chromium.org</owner> <owner>animations-dev@chromium.org</owner> <summary> @@ -308,6 +308,36 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Scheduling.Renderer.FrameProduction.TimeOverused" + units="microseconds" expires_after="2022-08-15"> + <owner>behdadb@chromium.org</owner> + <owner>chrome-gpu-metrics@chromium.org</owner> + <summary> + Measures the difference in time allotted to the Renderer, by the Scheduler, + for frame production, from the time elapsed when the compositor frame is + submitted. This value would show the time used after the anticipated + deadline. + + This metric uses UMA_HISTOGRAM_CUSTOM_MICROSECONDS_TIMES so only users with + high resolution clocks will report this metric. + </summary> +</histogram> + +<histogram name="Scheduling.Renderer.FrameProduction.TimeUnused" + units="microseconds" expires_after="2022-08-15"> + <owner>behdadb@chromium.org</owner> + <owner>chrome-gpu-metrics@chromium.org</owner> + <summary> + Measures the difference in time allotted to the Renderer, by the Scheduler, + for frame production, from the time elapsed when the compositor frame is + submitted. This value would show the time remaining after submit before the + anticipated deadline. + + This metric uses UMA_HISTOGRAM_CUSTOM_MICROSECONDS_TIMES so only users with + high resolution clocks will report this metric. + </summary> +</histogram> + <histogram name="Scheduling.Renderer.PendingTreeRasterDuration" units="microseconds" expires_after="2020-02-16"> <owner>khushalsagar@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/search/histograms.xml b/chromium/tools/metrics/histograms/metadata/search/histograms.xml index fc0543ee8c8..d11b16a950c 100644 --- a/chromium/tools/metrics/histograms/metadata/search/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/search/histograms.xml @@ -43,7 +43,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.ContextualSearch.All.Searches" - enum="BooleanBottomSearchKind" expires_after="M95"> + enum="BooleanBottomSearchKind" expires_after="2022-04-03"> <!-- TODO(donnd): change expires_after to never once established and approved. --> @@ -231,7 +231,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.ContextualSearch.ResolveRequested" - enum="ContextualSearchGestureIsTap" expires_after="2021-08-09"> + enum="ContextualSearchGestureIsTap" expires_after="2022-04-04"> <owner>donnd@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -242,7 +242,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.ContextualSearch.SelectionExpanded" - enum="ContextualSearchGestureIsTap" expires_after="2021-10-10"> + enum="ContextualSearchGestureIsTap" expires_after="2022-04-04"> <owner>donnd@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -277,7 +277,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.ContextualSearch.TranslationNeeded" - enum="ContextualSearchGestureIsTap" expires_after="2021-10-25"> + enum="ContextualSearchGestureIsTap" expires_after="2022-04-04"> <owner>donnd@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -290,7 +290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.ContextualSearch.TranslationsOptInIPHShown" - enum="BooleanPreviouslyShown" expires_after="2021-12-26"> + enum="BooleanPreviouslyShown" expires_after="2022-04-04"> <owner>donnd@chromium.org</owner> <owner>contextual-search-eng@google.com</owner> <summary> @@ -301,7 +301,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.ContextualSearch.TranslationsOptInIPHWorked" - enum="BooleanOptedIn" expires_after="2021-10-25"> + enum="BooleanOptedIn" expires_after="2022-04-04"> <owner>donnd@chromium.org</owner> <owner>contextual-search-eng@google.com</owner> <summary> @@ -746,6 +746,28 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Search.ContextualSearchPrivacyOptInPreferenceStateChange" + enum="BooleanOptedIn" expires_after="M99"> + <owner>donnd@chromium.org</owner> + <owner>contextual-search-eng@google.com</owner> + <summary> + The Contextual Search privacy opt-in preference state after a modification + from the preference menu. Recorded when the opt-in switch in Settings page + is toggled. Implemented for Android. + </summary> +</histogram> + +<histogram name="Search.ContextualSearchPromoCardChoice" enum="BooleanOptedIn" + expires_after="M99"> + <owner>donnd@chromium.org</owner> + <owner>contextual-search-eng@google.com</owner> + <summary> + The user's choice in the Contextual Search promo card. Recorded when the 'No + thanks' or 'Turn on' button on the Contextual Search Promo Card is chosen. + Implemented for Android. + </summary> +</histogram> + <histogram name="Search.ContextualSearchPromoOpenCount" units="opens" expires_after="M77"> <owner>donnd@chromium.org</owner> @@ -756,6 +778,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Search.ContextualSearchPromoOpenCount2" units="opens" + expires_after="M99"> + <owner>donnd@chromium.org</owner> + <owner>contextual-search-eng@chromium.org</owner> + <summary> + The total count of times that the revised promo has been shown. Once the + user decides, this counter is no longer updated. Logged for each show of the + promo card. Implemented for Android. + </summary> +</histogram> + <histogram name="Search.ContextualSearchPromoOutcomeByGesture" enum="ContextualSearchOutcomeByGesture" expires_after="M72"> <owner>donnd@chromium.org</owner> @@ -808,7 +841,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.ContextualSearchQuickActions.Category" - enum="ContextualSearchQuickActionCategory" expires_after="2021-10-04"> + enum="ContextualSearchQuickActionCategory" expires_after="2022-04-04"> <owner>donnd@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -1163,7 +1196,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.DefaultSearchProviderType" - enum="OmniboxSearchEngineType" expires_after="2022-01-02"> + enum="OmniboxSearchEngineType" expires_after="2022-04-03"> <owner>mpearson@chromium.org</owner> <owner>csharp@chromium.org</owner> <summary> @@ -1433,8 +1466,44 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Search.RegionSearch.Lens.RegionAspectRatio" + enum="LensRegionSearchAspectRatio" expires_after="2022-05-01"> + <owner>juanmojica@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>stanfield@google.com</owner> + <owner>lens-chrome-eng@google.com</owner> + <summary> + Records an enum representing the aspect ratio of the region selected after + using the Lens Region Search feature. + </summary> +</histogram> + +<histogram name="Search.RegionSearch.Lens.RegionViewportProportion" units="pct" + expires_after="2022-05-01"> + <owner>juanmojica@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>stanfield@google.com</owner> + <owner>lens-chrome-eng@google.com</owner> + <summary> + Records a percentage to represent the proportion of the selected region to + the screen after selecting a region with the Lens Region Search feature. + </summary> +</histogram> + +<histogram name="Search.RegionSearch.Lens.Result" + enum="LensRegionSearchCaptureResult" expires_after="2022-05-01"> + <owner>juanmojica@google.com</owner> + <owner>benwgold@google.com</owner> + <owner>stanfield@google.com</owner> + <owner>lens-chrome-eng@google.com</owner> + <summary> + Records an enum representing the result of the capture of the region for + Lens Region Search feature. + </summary> +</histogram> + <histogram name="Search.RelatedSearches.AllUserPermissions" - enum="ContextualSearchPermissions" expires_after="2021-12-19"> + enum="ContextualSearchPermissions" expires_after="2022-04-24"> <owner>donnd@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> <summary> @@ -1448,7 +1517,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.CarouselLastVisibleItemPosition" - units="position" expires_after="M95"> + units="position" expires_after="2022-04-17"> <owner>donnd@chromium.org</owner> <owner>gangwu@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> @@ -1462,7 +1531,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.CarouselScrollAndClick" - enum="ScrollAndClickStatus" expires_after="M95"> + enum="ScrollAndClickStatus" expires_after="2022-04-17"> <owner>donnd@chromium.org</owner> <owner>gangwu@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> @@ -1474,7 +1543,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.CarouselScrolled" enum="Boolean" - expires_after="M95"> + expires_after="2022-04-17"> <owner>donnd@chromium.org</owner> <owner>gangwu@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> @@ -1487,7 +1556,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.CTR" enum="BooleanClicked" - expires_after="M95"> + expires_after="M99"> <owner>donnd@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> <summary> @@ -1516,7 +1585,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.NumberOfSuggestionsClicked2" - units="selected" expires_after="M95"> + units="selected" expires_after="2022-04-24"> <owner>donnd@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> <summary> @@ -1527,7 +1596,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.QualifiedUsers" enum="Boolean" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>donnd@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> <summary> @@ -1542,7 +1611,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.SelectedCarouselIndex" units="position" - expires_after="M95"> + expires_after="2022-04-03"> <owner>donnd@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> <summary> @@ -1553,7 +1622,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.RelatedSearches.SelectedSuggestionIndex" - units="position" expires_after="M95"> + units="position" expires_after="2022-04-03"> <owner>donnd@chromium.org</owner> <owner>related-searches-vteam@google.com</owner> <summary> @@ -1600,7 +1669,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Search.TemplateURL.Events" enum="SearchTemplateURLEvent" - expires_after="2021-12-05"> + expires_after="2022-05-01"> <owner>tommycli@chromium.org</owner> <owner>chrome-omnibox-team@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/security/histograms.xml b/chromium/tools/metrics/histograms/metadata/security/histograms.xml index 93e2612e9cc..dfd58236bd1 100644 --- a/chromium/tools/metrics/histograms/metadata/security/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/security/histograms.xml @@ -54,6 +54,113 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Security.DataDecoder.Image.DecodingTime" units="ms" + expires_after="2022-04-10"> + <owner>lukasza@chromium.org</owner> + <owner>rsesek@chromium.org</owner> + <summary> + Logged once for every invocation of `data_decoder::DecodeImage` and/or + `data_decoder::DecodeImageIsolated`. Logs the time that has elapsed while + decoding the image (typically this happens in the Utility process). The time + is recorded in all the cases (including empty input which don't require + actual image decoding). + </summary> +</histogram> + +<histogram name="Security.DataDecoder.Image.Isolated.EndToEndTime" units="ms" + expires_after="2022-04-10"> + <owner>lukasza@chromium.org</owner> + <owner>rsesek@chromium.org</owner> + <summary> + Logged once for every invocation of `data_decoder::DecodeImageIsolated`. + Logs the time that has elapsed between 1) invocation of DecodeImageIsolated + and 2) calling the completion callback (both of these events happen in the + Browser process). The elapsed time covers A) spawning the utility process, + B) decoding the image, C) IPC overhead. + + Note that there are 2 sets of similar metrics: + Security.DataDecoder.Image.Isolated. and + Security.DataDecoder.Image.Reusable. In the Isolated case a Utility process + is spawned for each image decoding operation and the ...End2End and + ...ProcessOverhead metrics always include process spawning overhead. In the + Reusable case a Utility process may get reused when decoding a batch of + images, and the ...End2End and ...ProcessOverhead metrics may or may not + include process spawning overhead (the process will only need to be spawned + for the first image in a batch + after the process has been shut down due to + inactivity). + </summary> +</histogram> + +<histogram name="Security.DataDecoder.Image.Isolated.ProcessOverhead" + units="ms" expires_after="2022-04-10"> + <owner>lukasza@chromium.org</owner> + <owner>rsesek@chromium.org</owner> + <summary> + Logged once for every invocation of `data_decoder::DecodeImageIsolated`. + Logs the overhead of using a separate process for decoding the images by + calculating the difference between ...Image.Isolated.EndToEndTime and the + ...Image.DecodingTime metrics. + + Note that there are 2 sets of similar metrics: + Security.DataDecoder.Image.Isolated. and + Security.DataDecoder.Image.Reusable. In the Isolated case a Utility process + is spawned for each image decoding operation and the ...End2End and + ...ProcessOverhead metrics always include process spawning overhead. In the + Reusable case a Utility process may get reused when decoding a batch of + images, and the ...End2End and ...ProcessOverhead metrics may or may not + include process spawning overhead (the process will only need to be spawned + for the first image in a batch + after the process has been shut down due to + inactivity). + </summary> +</histogram> + +<histogram name="Security.DataDecoder.Image.Reusable.EndToEndTime" units="ms" + expires_after="2022-04-10"> + <owner>lukasza@chromium.org</owner> + <owner>rsesek@chromium.org</owner> + <summary> + Logged once for every invocation of `data_decoder::DecodeImage`. Logs the + time that has elapsed between 1) invocation of DecodeImage and 2) calling + the completion callback (both of these events happen in the Browser + process). The elapsed time covers A) spawning the utility process (if + needed), B) decoding the image, C) IPC overhead. + + Note that there are 2 sets of similar metrics: + Security.DataDecoder.Image.Isolated. and + Security.DataDecoder.Image.Reusable. In the Isolated case a Utility process + is spawned for each image decoding operation and the ...End2End and + ...ProcessOverhead metrics always include process spawning overhead. In the + Reusable case a Utility process may get reused when decoding a batch of + images, and the ...End2End and ...ProcessOverhead metrics may or may not + include process spawning overhead (the process will only need to be spawned + for the first image in a batch + after the process has been shut down due to + inactivity). + </summary> +</histogram> + +<histogram name="Security.DataDecoder.Image.Reusable.ProcessOverhead" + units="ms" expires_after="2022-04-10"> + <owner>lukasza@chromium.org</owner> + <owner>rsesek@chromium.org</owner> + <summary> + Logged once for every invocation of `data_decoder::DecodeImage`. Logs the + overhead of using a separate process for decoding the images by calculating + the difference between ...Image.Reusable.EndToEndTime and the + ...Image.DecodingTime metrics. + + Note that there are 2 sets of similar metrics: + Security.DataDecoder.Image.Isolated. and + Security.DataDecoder.Image.Reusable. In the Isolated case a Utility process + is spawned for each image decoding operation and the ...End2End and + ...ProcessOverhead metrics always include process spawning overhead. In the + Reusable case a Utility process may get reused when decoding a batch of + images, and the ...End2End and ...ProcessOverhead metrics may or may not + include process spawning overhead (the process will only need to be spawned + for the first image in a batch + after the process has been shut down due to + inactivity). + </summary> +</histogram> + <histogram name="Security.HttpsFirstMode.NavigationEvent" enum="HttpsFirstModeNavigationEvent" expires_after="2022-01-31"> <owner>cthomp@chromium.org</owner> @@ -66,7 +173,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.HttpsFirstMode.SettingChanged" enum="BooleanEnabled" - expires_after="2022-01-31"> + expires_after="2022-04-24"> <owner>cthomp@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -77,7 +184,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.HttpsFirstMode.SettingEnabledAtStartup" - enum="BooleanEnabled" expires_after="2022-01-31"> + enum="BooleanEnabled" expires_after="2022-04-10"> <owner>cthomp@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -89,6 +196,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.LegacyTLS.DownloadStarted" enum="Boolean" expires_after="2021-08-09"> + <obsolete> + Expired after 2021-08. No longer in use. + </obsolete> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -103,6 +213,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.LegacyTLS.FormSubmission" enum="Boolean" expires_after="2021-08-09"> + <obsolete> + Expired after 2021-08. No longer in use. + </obsolete> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -115,6 +228,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.LegacyTLS.OnCommit" enum="Boolean" expires_after="2021-08-09"> + <obsolete> + Expired after 2021-08. No longer in use. + </obsolete> <owner>cthomp@chromium.org</owner> <owner>estark@chromium.org</owner> <owner>security-enamel@chromium.org</owner> @@ -126,6 +242,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.LegacyTLS.PageInfo.Action" enum="WebsiteSettingsAction" expires_after="M92"> + <obsolete> + Expired after M92. No longer in use. + </obsolete> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -135,7 +254,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.MixedForm.InterstitialTriggerState" - enum="MixedFormInterstitialTriggeredState" expires_after="2021-12-26"> + enum="MixedFormInterstitialTriggeredState" expires_after="2022-04-24"> <owner>carlosil@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -146,7 +265,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Security.PageEndReason" enum="PageEndReason" - expires_after="2021-10-10"> + expires_after="2022-04-10"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -242,7 +361,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.PageInfo.TimeOpen" units="units" - expires_after="2022-02-01"> + expires_after="2022-04-10"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -252,7 +371,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.PageInfo.TimeOpen.Action" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -262,7 +381,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.PageInfo.TimeOpen.NoAction" units="units" - expires_after="2021-10-10"> + expires_after="2022-04-10"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -273,6 +392,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.PasswordEntry.SiteEngagementLevel" enum="SiteEngagementLevel" expires_after="2021-10-31"> + <obsolete> + Expired after 2021-10. No longer in use. + </obsolete> <owner>meacer@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -284,6 +406,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.PasswordFocus.SiteEngagementLevel" enum="SiteEngagementLevel" expires_after="2021-01-31"> + <obsolete> + Expired after 2021-01. No longer in use. + </obsolete> <owner>meacer@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -293,8 +418,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Security.PrivateNetworkAccess.CheckResult" + enum="PrivateNetworkAccessCheckResult" expires_after="M107"> + <owner>titouan@chromium.org</owner> + <owner>clamy@chromium.org</owner> + <owner>mkwst@chromium.org</owner> + <summary> + Result of the Private Network Access Check on a new connection. Recorded + once per call to network::URLLoader::OnConnected(), which may be more than + once per URL request. + </summary> +</histogram> + <histogram name="Security.SafetyTips.DownloadStarted" enum="SafetyTipStatus" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -307,7 +444,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.FormSubmission" enum="SafetyTipStatus" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -320,7 +457,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.Interaction" enum="SafetyTipInteraction" - expires_after="2021-12-25"> + expires_after="2022-04-03"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -332,7 +469,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.OpenTime.CloseTab" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-17"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -342,7 +479,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.OpenTime.Dismiss" units="ms" - expires_after="2021-12-25"> + expires_after="2022-04-17"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -389,7 +526,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.OpenTime.LeaveSite" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -409,7 +546,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.OpenTime.StartNewNavigation" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -419,7 +556,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.OpenTime.SwitchTab" units="ms" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>jdeblasio@chromium.org</owner> <owner>estark@chromium.org</owner> <summary> @@ -439,7 +576,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Security.SafetyTips.ReputationCheckComplete" - enum="SafetyTipStatus" expires_after="2021-12-26"> + enum="SafetyTipStatus" expires_after="2022-05-01"> <owner>jdeblasio@chromium.org</owner> <owner>src/chrome/browser/reputation/OWNERS</owner> <summary> @@ -460,7 +597,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SafetyTips.SafetyTipShown" enum="SafetyTipStatus" - expires_after="2021-12-25"> + expires_after="2022-04-10"> <owner>jdeblasio@chromium.org</owner> <owner>livvielin@chromium.org</owner> <summary> @@ -536,7 +673,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SCTAuditing.OptIn.ReportDeduplicated" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -590,6 +727,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.SecurityLevel.CryptographicScheme" enum="SecurityLevel" expires_after="2021-09-01"> + <obsolete> + Expired after 2021-09. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -635,7 +775,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SecurityLevel.InsecureMainFrameFormSubmission" - enum="SecurityLevel" expires_after="2021-10-31"> + enum="SecurityLevel" expires_after="2022-04-10"> <owner>estark@chromium.org</owner> <owner>livvielin@chromium.org</owner> <summary> @@ -649,6 +789,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.SecurityLevel.InsecureMainFrameNonFormNavigation" enum="SecurityLevel" expires_after="2021-09-01"> + <obsolete> + Expired after 2021-09. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <owner>livvielin@chromium.org</owner> <summary> @@ -660,6 +803,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Security.SecurityLevel.NoncryptographicScheme" enum="SecurityLevel" expires_after="2021-09-01"> + <obsolete> + Expired after 2021-09. No longer in use. + </obsolete> <owner>estark@chromium.org</owner> <owner>trusty-transport@chromium.org</owner> <summary> @@ -679,7 +825,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Security.SecurityLevel.OnCommit" enum="SecurityLevel" - expires_after="2022-02-01"> + expires_after="2022-04-24"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> @@ -729,7 +875,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Security.TimeOnPage2" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>cthomp@chromium.org</owner> <owner>security-enamel@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/segmentation_platform/histograms.xml b/chromium/tools/metrics/histograms/metadata/segmentation_platform/histograms.xml index 5aa2c996a41..5bb88001ebf 100644 --- a/chromium/tools/metrics/histograms/metadata/segmentation_platform/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/segmentation_platform/histograms.xml @@ -21,6 +21,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> +<variants name="BooleanModel"> + <variant name="ChromeStartAndroid"/> + <variant name="QueryTiles"/> +</variants> + <variants name="ModelExecutionStatus"> <variant name="ExecutionError"/> <variant name="InvalidMetadata"/> @@ -28,8 +33,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <variant name="Unknown"/> </variants> +<variants name="SegmentationKey"> + <variant name="AdaptiveToolbar"/> + <variant name="ChromeStartAndroid"/> + <variant name="DummyFeature"/> + <variant name="QueryTiles"/> +</variants> + <variants name="SegmentationModel"> + <variant name="ChromeStartAndroid"/> + <variant name="Dummy"/> <variant name="NewTab"/> + <variant name="QueryTiles"/> <variant name="Share"/> <variant name="Unknown"/> <variant name="Voice"/> @@ -59,9 +74,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="SegmentID" variants="SegmentationModel"/> </histogram> +<histogram name="SegmentationPlatform.AdaptiveToolbar.SegmentSelected.Startup" + enum="AdaptiveToolbarButtonVariant" expires_after="2022-04-24"> + <owner>shaktisahu@chromium.org</owner> + <owner>chrome-segmentation-platform@google.com</owner> + <summary> + Records the selected segment to be shown for the adaptive toolbar button. + Recorded on chrome startup. + </summary> +</histogram> + <histogram name="SegmentationPlatform.AdaptiveToolbar.SegmentSelection.Computed" - enum="AdaptiveToolbarButtonVariant" expires_after="2022-02-01"> + enum="AdaptiveToolbarButtonVariant" expires_after="2022-04-03"> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -72,6 +97,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SegmentationPlatform.AdaptiveToolbar.SegmentSelection.Startup" enum="AdaptiveToolbarButtonVariant" expires_after="2022-02-01"> + <obsolete> + Removed 09/2021 in favor of + SegmentationPlatform.AdaptiveToolbar.SegmentSelected.Startup. + </obsolete> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -81,7 +110,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SegmentationPlatform.AdaptiveToolbar.SegmentSwitched" - enum="AdaptiveToolbarSegmentSwitch" expires_after="2022-02-01"> + enum="AdaptiveToolbarSegmentSwitch" expires_after="2022-04-10"> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> <summary> @@ -120,7 +149,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SegmentationPlatform.Maintenance.SignalIdentifierCount" - units="ids" expires_after="2022-02-01"> + units="ids" expires_after="2022-04-24"> <owner>nyquist@chromium.org</owner> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> @@ -182,7 +211,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SegmentationPlatform.ModelDelivery.Received" - enum="SegmentationPlatformSegmentationModel" expires_after="2022-02-01"> + enum="SegmentationPlatformSegmentationModel" expires_after="2022-04-10"> <owner>nyquist@chromium.org</owner> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> @@ -339,9 +368,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="SegmentationModel" variants="SegmentationModel"/> </histogram> +<histogram name="SegmentationPlatform.ModelScore.{SegmentID}" units="%" + expires_after="2022-02-01"> + <owner>shaktisahu@chromium.org</owner> + <owner>chrome-segmentation-platform@google.com</owner> + <summary> + Records the segmentation platform model evaluation score for the given + {SegmentID}. Recorded whenever the model evaluation is completed + successfully. + </summary> + <token key="SegmentID" variants="SegmentationModel"/> +</histogram> + <histogram name="SegmentationPlatform.SignalDatabase.GetSamples.DatabaseEntryCount" - units="entries" expires_after="2022-02-01"> + units="entries" expires_after="2022-04-24"> <owner>nyquist@chromium.org</owner> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> @@ -356,7 +397,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SegmentationPlatform.SignalDatabase.GetSamples.Result" - enum="BooleanSuccess" expires_after="2022-02-01"> + enum="BooleanSuccess" expires_after="2022-04-24"> <owner>nyquist@chromium.org</owner> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> @@ -369,7 +410,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SegmentationPlatform.SignalDatabase.GetSamples.SampleCount" - units="samples" expires_after="2022-02-01"> + units="samples" expires_after="2022-05-01"> <owner>nyquist@chromium.org</owner> <owner>shaktisahu@chromium.org</owner> <owner>chrome-segmentation-platform@google.com</owner> @@ -396,6 +437,30 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="SignalType" variants="SignalType"/> </histogram> +<histogram name="SegmentationPlatform.{BooleanModel}.SegmentSwitched" + enum="SegmentationBooleanSegmentSwitch" expires_after="2022-02-01"> + <owner>shaktisahu@chromium.org</owner> + <owner>chrome-segmentation-platform@google.com</owner> + <summary> + Records the segment selection switch from an old value to a new segment + after a model evaluation completes. Recorded only if the selected segment + switches to a new value. + </summary> + <token key="BooleanModel" variants="BooleanModel"/> +</histogram> + +<histogram + name="SegmentationPlatform.{SegmentationKey}.SegmentSelection.Computed2" + enum="SegmentationPlatformSegmentationModel" expires_after="2022-02-01"> + <owner>shaktisahu@chromium.org</owner> + <owner>chrome-segmentation-platform@google.com</owner> + <summary> + Records the result of segment selection. Recorded whenever the segment + selection is updated. + </summary> + <token key="SegmentationKey" variants="SegmentationKey"/> +</histogram> + </histograms> </histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/service/histograms.xml b/chromium/tools/metrics/histograms/metadata/service/histograms.xml index 594210d4eb1..7a33298b1cf 100644 --- a/chromium/tools/metrics/histograms/metadata/service/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/service/histograms.xml @@ -21,6 +21,53 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> +<variants name="ServiceWorkerEventType"> + <variant name="ACTIVATE"/> + <variant name="BACKGROUND_FETCH_ABORT"/> + <variant name="BACKGROUND_FETCH_CLICK"/> + <variant name="BACKGROUND_FETCH_FAIL"/> + <variant name="BACKGROUND_FETCH_SUCCESS"/> + <variant name="COOKIE_CHANGE"/> + <variant name="FETCH_MAIN_FRAME"/> + <variant name="FETCH_SHARED_WORKER"/> + <variant name="FETCH_SUB_FRAME"/> + <variant name="FETCH_SUB_RESOURCE"/> + <variant name="FOREIGN_FETCH"> + <obsolete> + Has not been emitted since Foreign Fetch was removed ca. 2018. + </obsolete> + </variant> + <variant name="GEOFENCING"> + <obsolete> + Deprecated as of 5/2016 because geofencing got removed. + </obsolete> + </variant> + <variant name="INSTALL"/> + <variant name="LONG_RUNNING_MESSAGE"/> + <variant name="MESSAGE"/> + <variant name="NAVIGATION_HINT"/> + <variant name="NAVIGATION_HINT_LINK_MOUSE_DOWN"> + <obsolete> + This experiment was turned down, see https://crbug.com/616502. + </obsolete> + </variant> + <variant name="NAVIGATION_HINT_LINK_TAP_DOWN"> + <obsolete> + This experiment was turned down, see https://crbug.com/616502. + </obsolete> + </variant> + <variant name="NAVIGATION_HINT_LINK_TAP_UNCONFIRMED"> + <obsolete> + This experiment was turned down, see https://crbug.com/616502. + </obsolete> + </variant> + <variant name="NOTIFICATION_CLICK"/> + <variant name="NOTIFICATION_CLOSE"/> + <variant name="PUSH"/> + <variant name="SYNC"/> + <variant name="UNKNOWN"/> +</variants> + <histogram name="ServiceWorker.AbortPaymentEvent.Time" units="ms" expires_after="2021-12-31"> <owner>rouslan@chromium.org</owner> @@ -35,7 +82,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.ActivateEvent.Time" units="ms" expires_after="2022-07-23"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> Execution time of ServiceWorkerGlobalScope.onactivate. Includes the time for @@ -45,7 +93,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.ActivateEventStatus" enum="ServiceWorkerStatusCode" expires_after="2022-07-23"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The result of dispatching the activate event to the worker. This is recorded @@ -301,18 +350,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.FetchEvent.Fallback.Time" units="ms" - expires_after="2021-08-01"> - <owner>falken@chromium.org</owner> + expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken between dispatching a FetchEvent to a Service Worker and receiving a fallback-to-network reply. + + This histogram was expired between roughly 2021-08-01 and 2021-09-30. </summary> </histogram> <histogram name="ServiceWorker.FetchEvent.HasResponse.Time" units="ms" - expires_after="2021-10-17"> - <owner>falken@chromium.org</owner> + expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken between dispatching a FetchEvent to a Service Worker and @@ -322,8 +375,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.FetchEvent.MainResource.Status" - enum="ServiceWorkerStatusCode" expires_after="2021-12-26"> - <owner>falken@chromium.org</owner> + enum="ServiceWorkerStatusCode" expires_after="2022-05-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The result of dispatching a fetch event to a Service Worker for a main @@ -334,7 +388,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.FetchEvent.QueuingTime" units="ms" expires_after="2022-02-06"> <owner>asamidoi@chromium.org</owner> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time that a fetch event was queued. The start time is when the event is @@ -345,8 +399,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.FetchEvent.Subresource.Status" - enum="ServiceWorkerStatusCode" expires_after="2021-12-26"> - <owner>falken@chromium.org</owner> + enum="ServiceWorkerStatusCode" expires_after="2022-05-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The result of dispatching a fetch event to a Service Worker for a @@ -356,6 +411,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.FetchEvent.WaitUntil.Time" units="ms" expires_after="2021-06-30"> + <obsolete> + Removed in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -379,7 +437,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.InstallEvent.All.FetchCount" units="fetches" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>wanderview@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -389,7 +447,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.InstallEvent.{type}.Status" enum="ServiceWorkerStatusCode" expires_after="2022-07-23"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The result of dispatching the install event to the worker. This histogram @@ -404,7 +463,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.InstallEvent.{type}.Time" units="ms" expires_after="2022-07-23"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken between dispatching an InstallEvent to a Service Worker and @@ -436,7 +496,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.MainFrame.MainResource.FetchHandlerEndToFallbackNetwork" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -453,7 +513,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.MainFrame.MainResource.FetchHandlerEndToResponseReceived" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -470,7 +530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.MainFrame.MainResource.FetchHandlerStartToFetchHandlerEnd" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -486,7 +546,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.MainFrame.MainResource.ForwardServiceWorkerToWorkerReady2" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -501,7 +561,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.MainFrame.MainResource.ResponseReceivedToCompleted2" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -517,7 +577,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.MainFrame.MainResource.StartToForwardServiceWorker" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -533,7 +593,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.MainFrame.MainResource.WorkerReadyToFetchHandlerStart" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -549,7 +609,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.Subresource.FetchHandlerEndToFallbackNetwork" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -566,7 +626,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.Subresource.FetchHandlerEndToResponseReceived" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -583,7 +643,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.Subresource.ForwardServiceWorkerToWorkerReady" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -598,7 +658,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.Subresource.ResponseReceivedToCompleted2" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -613,7 +673,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.LoadTiming.Subresource.WorkerReadyToFetchHandlerEnd" - units="ms" expires_after="2021-10-31"> + units="ms" expires_after="2022-09-20"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -627,7 +687,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.LookupRegistration.MainResource.Time" units="ms" - expires_after="2021-10-31"> + expires_after="2022-09-20"> + <obsolete> + Removed in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -643,6 +706,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.MainFramePageLoad" enum="ServiceWorkerSite" expires_after="2021-10-17"> + <obsolete> + Removed in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -685,6 +751,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.PageLoad" enum="ServiceWorkerSite" expires_after="2021-12-26"> + <obsolete> + Removed in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary>Counts page loads controlled by a service worker.</summary> @@ -713,7 +782,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="ServiceWorker.PushEvent.Time" units="ms" expires_after="M96"> +<histogram name="ServiceWorker.PushEvent.Time" units="ms" + expires_after="2022-04-24"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -751,7 +821,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.RegisteredStorageKeyCount" units="origins" expires_after="2022-04-29"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The number of StorageKeys that have a service worker registration. Recorded @@ -760,6 +831,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.Runtime" units="ms" expires_after="2020-07-30"> + <obsolete> + Expired in July 2020. Removed in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -772,6 +846,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.ScriptCachedMetadataSize" units="bytes" expires_after="2021-12-19"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -784,6 +861,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.ScriptCachedMetadataTotalSize" units="bytes" expires_after="2021-05-18"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -796,6 +876,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.ScriptCount" units="count" expires_after="2021-05-18"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -807,6 +890,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.ScriptSize" units="bytes" expires_after="2021-05-18"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -818,6 +904,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.ScriptTotalSize" units="bytes" expires_after="2021-05-18"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -829,6 +918,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.SendStopWorker.Status" enum="ServiceWorkerStatusCode" expires_after="M85"> + <obsolete> + Removed from the code in April 2017. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -843,6 +935,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.StartForNavigationHint.Result" enum="ServiceWorkerStartForNavigationHintResult" expires_after="2021-02-16"> + <obsolete> + Removed September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -851,8 +946,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.StartNewWorker.Time" units="ms" - expires_after="2021-01-31"> - <owner>falken@chromium.org</owner> + expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken to start a Service Worker that has not yet installed, from @@ -860,11 +956,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. script execution). This may include script download time. The metric is not recorded if DevTools was ever attached to the Service Worker during startup. See also ServiceWorker.StartWorker.Time for installed workers. + + This histogram was expired between approximately Feb through Sep 2021. </summary> </histogram> <histogram name="ServiceWorker.StartTiming.BrowserThreadHopTime" units="microseconds" expires_after="M80"> + <obsolete> + No longer emitted since ServiceWorkerOnUI shipped in September 2020 (M86): + https://crbug.com/824858 + </obsolete> <owner>kinuko@chromium.org</owner> <summary> The sum of all the times spent posting tasks between the UI and IO threads @@ -882,8 +984,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.StartTiming.ClockConsistency" - enum="CrossProcessTimeDelta" expires_after="2020-07-30"> - <owner>falken@chromium.org</owner> + enum="CrossProcessTimeDelta" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> Recorded on each successful service worker startup. @@ -895,12 +998,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. If the clocks and timing were inconsistent, ServiceWorker.StartTiming.* metrics (other than this one) are not recorded. + + This histogram was expired between roughly 2021-07-30 and 2021-09-31. </summary> </histogram> <histogram name="ServiceWorker.StartTiming.Duration" units="ms" - expires_after="2021-07-30"> - <owner>falken@chromium.org</owner> + expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken to start a service worker that is already installed, from @@ -909,13 +1015,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. if DevTools was ever attached to the Service Worker during startup. It does not include time, if any, waiting for the service worker to finish stopping before asking it to start, if that occurred. + + This histogram was expired between roughly 2021-07-30 and 2021-09-31. </summary> </histogram> <histogram name="ServiceWorker.StartTiming.ReceivedStartWorkerToScriptEvaluationStart" units="ms" expires_after="2021-12-05"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) the renderer receiving the start worker IPC message, @@ -926,7 +1035,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.StartTiming.ScriptEvaluationEndToEnd" units="ms" expires_after="2021-12-05"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) initial JavaScript evaluation finishing on the @@ -939,7 +1049,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.StartTiming.ScriptEvaluationStartToScriptEvaluationEnd" units="ms" expires_after="2021-12-05"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) initial JavaScript evaluation starting on the worker @@ -951,7 +1062,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.StartTiming.SentStartWorkerToReceivedStartWorker" units="ms" expires_after="2021-12-05"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) the browser sending the start worker IPC message, to @@ -961,41 +1073,51 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.StartTiming.StartToReceivedStartWorker" - units="ms" expires_after="2021-07-30"> - <owner>falken@chromium.org</owner> + units="ms" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) the start of service worker startup, to (b) the renderer receiving the start worker IPC message. Recorded when ServiceWorker.StartTiming.Duration is recorded. + + This histogram was expired between roughly 2021-07-30 and 2021-09-31. </summary> </histogram> <histogram name="ServiceWorker.StartTiming.StartToScriptEvaluationEnd" - units="ms" expires_after="2021-07-30"> - <owner>falken@chromium.org</owner> + units="ms" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) the start of service worker startup, to (b) initial JavaScript evaluation finishing on the worker thread. Recorded when ServiceWorker.StartTiming.Duration is recorded. + + This histogram was expired between roughly 2021-07-30 and 2021-09-31. </summary> </histogram> <histogram name="ServiceWorker.StartTiming.StartToScriptEvaluationStart" - units="ms" expires_after="2021-07-30"> - <owner>falken@chromium.org</owner> + units="ms" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) the start of service worker startup, to (b) initial JavaScript evaluation starting on the worker thread. Recorded when ServiceWorker.StartTiming.Duration is recorded. + + This histogram was expired between roughly 2021-07-30 and 2021-09-31. </summary> </histogram> <histogram name="ServiceWorker.StartTiming.StartToSentStartWorker" units="ms" expires_after="2021-12-05"> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken from (a) the start of service worker startup, to (b) the @@ -1006,6 +1128,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.StartWorker.AfterFailureStreak" enum="ServiceWorkerStatusCode" expires_after="2021-01-31"> + <obsolete> + Expired in January 2021. Removed from the code in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -1016,6 +1141,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.StartWorker.FailureStreak" units="count" expires_after="2021-01-31"> + <obsolete> + Expired in January 2021. Removed from the code in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -1027,6 +1155,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.StartWorker.FailureStreakEnded" units="count" expires_after="2021-01-31"> + <obsolete> + Expired in January 2021. Removed from the code in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -1036,18 +1167,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.StartWorker.Purpose" - enum="ServiceWorkerMetrics.EventType" expires_after="2021-01-31"> - <owner>falken@chromium.org</owner> + enum="ServiceWorkerMetrics.EventType" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The purpose for starting up a service worker. Recorded only for installed workers. + + This histogram was expired between approximately Feb through Sep 2021. </summary> </histogram> <histogram name="ServiceWorker.StartWorker.Status" - enum="ServiceWorkerStatusCode" expires_after="2021-12-12"> - <owner>falken@chromium.org</owner> + enum="ServiceWorkerStatusCode" expires_after="2022-04-17"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The result of trying to start a Service Worker that is already installed. @@ -1056,20 +1191,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="ServiceWorker.StartWorker.StatusByPurpose" - enum="ServiceWorkerStatusCode" expires_after="2021-08-22"> - <owner>falken@chromium.org</owner> +<histogram + name="ServiceWorker.StartWorker.StatusByPurpose_{ServiceWorkerEventType}" + enum="ServiceWorkerStatusCode" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> - The result of trying to start a service worker for a particular event type - (see ServiceWorker.StartWorker.Status for the total). Only recorded for - installed workers. For event type: + The result of trying to start a service worker for the event type + {ServiceWorkerEventType} (see ServiceWorker.StartWorker.Status for all start + attempts). Only recorded for installed workers. </summary> + <token key="ServiceWorkerEventType" variants="ServiceWorkerEventType"/> </histogram> <histogram name="ServiceWorker.StartWorker.Time" units="ms" - expires_after="2021-12-12"> - <owner>falken@chromium.org</owner> + expires_after="2022-04-17"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> The time taken to start a Service Worker that is already installed, from @@ -1081,26 +1220,35 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.StartWorker.Timeout.StartPurpose" - enum="ServiceWorkerMetrics.EventType" expires_after="2021-01-31"> - <owner>falken@chromium.org</owner> + enum="ServiceWorkerMetrics.EventType" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> Records the start purpose for a service worker that timed out while starting up. Recorded only for installed workers. + + This histogram was expired between approximately Feb through Sep 2021. </summary> </histogram> <histogram name="ServiceWorker.StartWorker.TimeoutPhase" - enum="EmbeddedWorkerStartingPhase" expires_after="2021-01-31"> - <owner>falken@chromium.org</owner> + enum="EmbeddedWorkerStartingPhase" expires_after="2022-09-01"> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> - The phase the EmbeddedWorker was in when ServiceWorker startup timed out. + The phase the ServiceWorker was in when ServiceWorker startup timed out. + + This histogram was expired between approximately Feb through Sep 2021. </summary> </histogram> <histogram name="ServiceWorker.StopWorker.Time" units="ms" expires_after="2020-07-30"> + <obsolete> + Expired in July 2020. Removed from the code in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary>The time taken to stop a Service Worker.</summary> @@ -1125,7 +1273,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="ServiceWorker.Storage.RetryCountForRecovery" units="retries" - expires_after="2021-11-17"> + expires_after="2022-10-04"> <owner>bashi@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -1138,6 +1286,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.WorkerForMessageFound" enum="Boolean" expires_after="M85"> + <obsolete> + Removed from the code in March 2018. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -1150,6 +1301,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="ServiceWorker.WorkerStopped" enum="ServiceWorkerStoppedStatus" expires_after="2021-08-09"> + <obsolete> + Removed in September 2021. + </obsolete> <owner>falken@chromium.org</owner> <owner>chrome-worker@google.com</owner> <summary> @@ -1157,6 +1311,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="ServiceWorker.{operation}Time" units="ms" + expires_after="2022-08-24"> + <owner>cduvall@chromium.org</owner> + <owner>chrome-worker@google.com</owner> + <summary> + The time taken to query the content settings in the browser process for the + ${operation} operation. This is recorded each time a sync call is made. + </summary> + <token key="operation"> + <variant name="AllowCacheStorage"/> + <variant name="AllowIndexedDB"/> + <variant name="AllowWebLocks"/> + <variant name="RequestFileSystemAccess"/> + </token> +</histogram> + <histogram name="ServiceWorkerCache.Cache" units="ms" expires_after="M95"> <owner>wanderview@chromium.org</owner> <owner>dmurph@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/session/histograms.xml b/chromium/tools/metrics/histograms/metadata/session/histograms.xml index 627a27bd215..4f5c92d35ae 100644 --- a/chromium/tools/metrics/histograms/metadata/session/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/session/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Session.Background.TotalDuration" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -47,7 +47,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Session.IsActive" enum="BooleanActive" expires_after="M100"> +<histogram name="Session.IsActive" enum="BooleanActive" + expires_after="2022-04-17"> <owner>rogerm@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -58,7 +59,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. "stability logs" or "persistent UMA" data related to the previous session but not uploaded during the previous session). - Recorded on Windows, Mac, and Linux. + Recorded on Android, iOS, Windows, Mac, and Linux. For information on what's considered "active", see the histogram description for Session.TotalDuration. @@ -78,7 +79,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Session.OpenedTabCounts" units="operations" - expires_after="2022-01-30"> + expires_after="2022-04-10"> <owner>rohitrao@chromium.org</owner> <owner>marq@chromium.org</owner> <summary> @@ -375,7 +376,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Session.TotalDuration.TouchMode" units="times" - expires_after="2021-11-14"> + expires_after="2022-04-24"> <owner>collinbaker@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -550,7 +551,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Session.WebStates.NavigationItem" units="KB" - expires_after="2021-11-07"> + expires_after="2022-05-01"> <owner>djean@chromium.org</owner> <owner>sdefresne@chromium.org</owner> <summary> @@ -561,7 +562,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Session.WebStates.ReadFromFileTime" units="ms" - expires_after="2021-10-10"> + expires_after="2022-09-15"> <owner>justincohen@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -582,7 +583,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Session.WebStates.SerializedSize" units="KB" - expires_after="2021-10-10"> + expires_after="2022-09-15"> <owner>justincohen@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -593,7 +594,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Session.WebStates.WriteToFileTime" units="ms" - expires_after="2021-12-10"> + expires_after="2022-09-15"> <owner>justincohen@chromium.org</owner> <owner>rohitrao@chromium.org</owner> <summary> @@ -668,7 +669,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SessionRestore.UnrecoverableWriteErrorCount" - units="operations" expires_after="2022-01-23"> + units="operations" expires_after="2022-04-03"> <owner>sky@chromium.org</owner> <owner>davidbienvenu@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/settings/histograms.xml b/chromium/tools/metrics/histograms/metadata/settings/histograms.xml index 739a62418b1..eeea888e3b6 100644 --- a/chromium/tools/metrics/histograms/metadata/settings/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/settings/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Settings.AdvancedSpellcheck.OnStartup" enum="BooleanEnabled" - expires_after="M98"> + expires_after="2022-04-17"> <owner>harrisonsean@chromium.org</owner> <owner>chrome-friendly-settings@google.com</owner> <summary> @@ -30,8 +30,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Settings.AllSites.DeprecatedRedirect" enum="BooleanRedirected" + expires_after="M101"> + <owner>sauski@google.com</owner> + <owner>chrome-friendly-settings@google.com</owner> + <summary> + Whether or not navigations to the All Sites page occured because the user + was redirected from the deprecated Site Data page. + </summary> +</histogram> + <histogram name="Settings.AutocompleteSearches.OnStartup" enum="BooleanEnabled" - expires_after="M98"> + expires_after="2022-04-24"> <owner>harrisonsean@chromium.org</owner> <owner>chrome-friendly-settings@google.com</owner> <summary> @@ -58,7 +68,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.GivenShowHomeButton_HomePageIsNewTabPage" - enum="Boolean" expires_after="2022-01-09"> + enum="Boolean" expires_after="2022-04-17"> <owner>mpearson@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -78,7 +88,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.Homepage.LocationType" enum="HomepageLocationType" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>bttk@chromium.org</owner> <owner>twellington@chromium.org</owner> <owner>wenyufu@chromium.org</owner> @@ -89,7 +99,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.HomePageEngineType" enum="OmniboxSearchEngineType" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>mpearson@chromium.org</owner> <owner>csharp@chromium.org</owner> <summary> @@ -167,7 +177,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.PinUnlockSetup" enum="LockScreenProgress" - expires_after="M97"> + expires_after="2022-04-10"> <owner>rsorokin@chromium.org</owner> <owner>jessejames@chromium.org</owner> <owner>cros-oac@google.com</owner> @@ -178,7 +188,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.PreloadStatus.OnStartup" enum="BooleanEnabled" - expires_after="M98"> + expires_after="2022-04-17"> <owner>harrisonsean@chromium.org</owner> <owner>chrome-friendly-settings@google.com</owner> <summary> @@ -188,7 +198,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.PrivacyElementInteractions" - enum="SettingsPrivacyElementInteractions" expires_after="2021-12-26"> + enum="SettingsPrivacyElementInteractions" expires_after="2022-04-10"> <owner>harrisonsean@chromium.org</owner> <owner>msramek@chromium.org</owner> <owner>sauski@chromium.org</owner> @@ -199,7 +209,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.PrivacySandbox.Enabled" - enum="SettingsPrivacySandboxEnabled" expires_after="2021-12-12"> + enum="SettingsPrivacySandboxEnabled" expires_after="2022-04-24"> <owner>harrisonseean@chromium.org</owner> <owner>msramek@chromium.org</owner> <owner>chrome-friendly-settings@google.com</owner> @@ -223,7 +233,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.SafetyCheck.ChromeCleanerResult" - enum="SafetyCheckChromeCleanerStatus" expires_after="2021-12-12"> + enum="SafetyCheckChromeCleanerStatus" expires_after="2022-04-24"> <owner>rainhard@chromium.org</owner> <owner>msramek@chromium.org</owner> <summary> @@ -240,7 +250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.SafetyCheck.Interactions" - enum="SettingsSafetyCheckInteractions" expires_after="2021-12-26"> + enum="SettingsSafetyCheckInteractions" expires_after="2022-05-01"> <owner>rainhard@chromium.org</owner> <owner>msramek@chromium.org</owner> <owner>anaudrey@chromium.org</owner> @@ -252,21 +262,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.SafetyCheck.PasswordsResult" - enum="SafetyCheckPasswordsStatus" expires_after="2021-12-26"> + enum="SafetyCheckPasswordsStatus" expires_after="2022-04-10"> <owner>andzaytsev@google.com</owner> <owner>msramek@chromium.org</owner> <summary>Resulting state of the safety check password check.</summary> </histogram> <histogram name="Settings.SafetyCheck.SafeBrowsingResult" - enum="SafetyCheckSafeBrowsingStatus" expires_after="2021-12-26"> + enum="SafetyCheckSafeBrowsingStatus" expires_after="2022-04-03"> <owner>andzaytsev@google.com</owner> <owner>msramek@chromium.org</owner> <summary>Resulting state of the safety check Safe Browsing check.</summary> </histogram> <histogram name="Settings.SafetyCheck.UpdatesResult" - enum="SafetyCheckUpdateStatus" expires_after="2021-12-26"> + enum="SafetyCheckUpdateStatus" expires_after="2022-04-10"> <owner>andzaytsev@google.com</owner> <owner>msramek@chromium.org</owner> <summary>Resulting state of the safety check updates check.</summary> @@ -325,7 +335,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.ShowHomeButton" enum="BooleanEnabled" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>mpearson@chromium.org</owner> <owner>twellington@chromium.org</owner> <summary> @@ -404,7 +414,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Settings.StartupPageLoadSettings" enum="SessionStartupPref" - expires_after="2022-01-16"> + expires_after="2022-04-10"> <owner>mpearson@chromium.org</owner> <owner>tiborg@chromium.org</owner> <owner>chrome-desktop-ntp@google.com</owner> diff --git a/chromium/tools/metrics/histograms/metadata/sharing/histograms.xml b/chromium/tools/metrics/histograms/metadata/sharing/histograms.xml index 1a986caea0f..9c20945e28c 100644 --- a/chromium/tools/metrics/histograms/metadata/sharing/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/sharing/histograms.xml @@ -41,7 +41,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.ClickToCallAppsToShow" units="apps" - expires_after="2021-10-25"> + expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="SharingClickToCallUi" --> <owner>mvanouwerkerk@chromium.org</owner> @@ -53,7 +53,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.ClickToCallDevicesToShow" units="devices" - expires_after="M98"> + expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="SharingClickToCallUi" --> <owner>mvanouwerkerk@chromium.org</owner> @@ -65,7 +65,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.ClickToCallDialerPresent" enum="BooleanPresent" - expires_after="M98"> + expires_after="2022-04-24"> <owner>mvanouwerkerk@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -134,7 +134,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.DefaultSharesheetAndroid.Opened" enum="ShareOrigin" - expires_after="M97"> + expires_after="2022-04-17"> <owner>sophey@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> @@ -219,6 +219,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Sharing.LongScreenshots.BitmapSelectedHeight" units="pixels" + expires_after="M98"> + <owner>skare@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <summary> + Height of the long screenshot output from the region-selection dialog. + Recorded on region selection dialog confirmation. + </summary> +</histogram> + <histogram name="Sharing.LongScreenshots.Event" enum="SharingLongScreenshotsEvent" expires_after="M98"> <owner>skare@chromium.org</owner> @@ -245,7 +255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Sharing.MessageAckTime" units="ms" expires_after="M97"> +<histogram name="Sharing.MessageAckTime" units="ms" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="SharingChannelType", name="SharingDevicePlatform" and name="SharingMessage" --> @@ -270,7 +280,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.MessageReceivedType" enum="SharingMessageType" - expires_after="M98"> + expires_after="2022-05-01"> <owner>mvanouwerkerk@chromium.org</owner> <owner>peter@chromium.org</owner> <summary> @@ -337,7 +347,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.RemoteCopyReceivedTextSize" units="bytes" - expires_after="M97"> + expires_after="2022-05-01"> <owner>mvanouwerkerk@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -377,7 +387,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.RemoteCopyWriteTextDetectionTime" units="ms" - expires_after="M97"> + expires_after="2022-05-01"> <owner>mvanouwerkerk@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> @@ -397,7 +407,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.Screenshot.Action" enum="SharingScreenshotAction" - expires_after="M97"> + expires_after="M105"> <owner>jeffreycohen@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> @@ -407,7 +417,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.ScreenshotFallback.Action" - enum="SharingScreenshotFallbackAction" expires_after="M97"> + enum="SharingScreenshotFallbackAction" expires_after="M105"> <owner>jeffreycohen@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> @@ -416,15 +426,41 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.ScreenshotsAndroid.IsEditorDismissedOnStart" - enum="Boolean" expires_after="M97"> + enum="Boolean" expires_after="2022-05-01"> <owner>jeffreycohen@chromium.org</owner> <owner>kristipark@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary>Whether the editor was dismissed during editor recreation.</summary> </histogram> +<histogram name="Sharing.ScrollCapture.BitmapGeneratorStatus" + enum="SharingScrollCaptureBitmapGenerationStatus" + expires_after="2022-05-01"> + <owner>yashard@chromium.org</owner> + <owner>ckitagawa@chromium.org</owner> + <owner>src/components/paint_preview/OWNERS</owner> + <summary> + Records the status of the Bitmap Generator when capturing scroll capture + long screenshot. Recorded after the page capture request is sent to the + paint_preview capture service and compositor, when the service is no longer + busy. This metric is only emitted on Android S+. + </summary> +</histogram> + +<histogram name="Sharing.ScrollCapture.SuccessfulCaptureDuration" units="ms" + expires_after="2022-05-01"> + <owner>yashard@chromium.org</owner> + <owner>ckitagawa@chromium.org</owner> + <owner>src/components/paint_preview/OWNERS</owner> + <summary> + Records the total time spent capturing a long screenshot of a page using + scroll capture. It is recorded when a scroll capture request successfully + finishes. This metric is only emitted on Android S+. + </summary> +</histogram> + <histogram name="Sharing.SendAckMessageResult" enum="SharingSendMessageResult" - expires_after="M97"> + expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="SharingChannelType", name="SharingDevicePlatform" and name="SharingMessage" --> @@ -437,7 +473,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.SendMessageResult" enum="SharingSendMessageResult" - expires_after="M97"> + expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes SharingChannelType, SharingDevicePlatform, SharingMessage, and SharingPulseInterval. --> @@ -451,8 +487,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.SendTabToSelf.NotificationStatus" - enum="SendTabToSelfNotificationStatus" expires_after="M97"> - <owner>kmilka@chromium.org</owner> + enum="SendTabToSelfNotificationStatus" expires_after="2022-04-17"> + <owner>ellyjones@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> Status of STTS notifications. Recorded whenever a target device is chosen, a @@ -535,7 +571,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.ShareTargetUpdate.ResourceBundleResult" - enum="ShareTargetUpdateResult" expires_after="M98"> + enum="ShareTargetUpdateResult" expires_after="2022-05-01"> <owner>jeffreycohen@chromium.org</owner> <owner>kristipark@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> @@ -564,7 +600,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.SharingHubAndroid.Opened" enum="ShareOrigin" - expires_after="M97"> + expires_after="2022-04-17"> <owner>sophey@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> @@ -589,8 +625,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.SharingHubAndroid.ThirdPartyAppUsage" - enum="SharingHubBottomRowIndex" expires_after="M97"> - <owner>kmilka@chromium.org</owner> + enum="SharingHubBottomRowIndex" expires_after="2022-04-17"> + <owner>sophey@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> Records the index of the third party app selected from the bottom row of the @@ -598,9 +634,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram + name="Sharing.SharingHubAndroid.TimeToSaveScreenshotImageBeforeShare" + units="ms" expires_after="M98"> + <owner>skare@chromium.org</owner> + <owner>src/chrome/browser/share/OWNERS</owner> + <summary> + Records the amount of time taken to save the output bitmap from the image + editor to temporary storage and generate a URI. Recorded when the followup + share actions panel is displayed. + </summary> +</histogram> + <histogram name="Sharing.SharingHubAndroid.TimeToShare" units="ms" - expires_after="M97"> - <owner>kmilka@chromium.org</owner> + expires_after="2022-04-17"> + <owner>sophey@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> Records the amount of time taken for the user to select a share target after @@ -609,8 +657,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.SharingHubAndroid.TimeToShowShareSheet" units="ms" - expires_after="M97"> - <owner>kmilka@chromium.org</owner> + expires_after="2022-04-17"> + <owner>sophey@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> Records the amount of time taken for the custom share sheet to open after a @@ -618,8 +666,30 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Sharing.SharingHubAndroid.{DetailedContentType}.{ShareStatus}" + enum="LinkToggleState" expires_after="M98"> + <owner>sophey@chromium.org</owner> + <owner>src/components/send_tab_to_self/OWNERS</owner> + <summary> + Records what the link toggle state is when a share of a + {DetailedContentType} is {ShareStatus}. + </summary> + <token key="DetailedContentType"> + <variant name="Gif"/> + <variant name="HighlightedText"/> + <variant name="Image"/> + <variant name="NotSpecified"/> + <variant name="Screenshot"/> + <variant name="Webnotes"/> + </token> + <token key="ShareStatus"> + <variant name="Completed"/> + <variant name="InProgress"/> + </token> +</histogram> + <histogram name="Sharing.SharingHubDesktop.CrOSSharesheetResult" - enum="SharingHubSharesheetResult" expires_after="M97"> + enum="SharingHubSharesheetResult" expires_after="2022-04-03"> <owner>kristipark@chromium.org</owner> <owner>src/components/send_tab_to_self/OWNERS</owner> <summary> @@ -629,7 +699,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.SmsFetcherAvailableDeviceCount" units="devices" - expires_after="M96"> + expires_after="2022-04-17"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -640,7 +710,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.SmsFetcherClientNameIsEmpty" enum="BooleanEmpty" - expires_after="M96"> + expires_after="M100"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -650,8 +720,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Sharing.SmsFetcherScreenOnAndUnlocked" enum="Boolean" + expires_after="M100"> + <owner>yigu@chromium.org</owner> + <owner>web-identity@google.com</owner> + <summary> + Records whether the phone is on and unlocked when we show the notification + to users. False if either the phone is locked or the phone does not have a + screen lock but the screen is off. This is logged once per notification. + </summary> +</histogram> + <histogram name="Sharing.SmsFetcherTapWithChromeDestroyed" enum="Boolean" - expires_after="M96"> + expires_after="M100"> <owner>yigu@chromium.org</owner> <owner>web-identity@google.com</owner> <summary> @@ -663,7 +744,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sharing.WebRtc.IceConfigFetched" units="ice_servers" - expires_after="M97"> + expires_after="2022-04-03"> <owner>peter@chromium.org</owner> <owner>knollr@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/side_search/histograms.xml b/chromium/tools/metrics/histograms/metadata/side_search/histograms.xml new file mode 100644 index 00000000000..d41e9e1c77e --- /dev/null +++ b/chromium/tools/metrics/histograms/metadata/side_search/histograms.xml @@ -0,0 +1,120 @@ +<!-- +Copyright 2021 The Chromium Authors. All rights reserved. +Use of this source code is governed by a BSD-style license that can be +found in the LICENSE file. +--> + +<!-- +This file is used to generate a comprehensive list of Side Search histograms +along with a detailed description for each histogram. + +For best practices on writing histogram descriptions, see +https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md + +Please send CLs to chromium-metrics-reviews@google.com rather than to specific +individuals. These CLs will be automatically reassigned to a reviewer within +about 5 minutes. This approach helps the metrics team to load-balance incoming +reviews. Googlers can read more about this at go/gwsq-gerrit. +--> + +<histogram-configuration> + +<histograms> + +<histogram name="SideSearch.AvailabilityChanged" + enum="SideSearchAvailabilityChangeType" expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + Denotes Side Search's availability. Recorded when side search becomes + available or unavailable, more specifically when the side search button + becomes visible or becomes invisible. + </summary> +</histogram> + +<histogram name="SideSearch.CloseAction" enum="SideSearchCloseActionType" + expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + The type of action taken to close Side Search. Recorded when side search + panel is closed. + </summary> +</histogram> + +<histogram name="SideSearch.LoadCompletedTime" units="ms" + expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + The amount of time between the render frame host StartProvisionalLoad event + and the render frame DocumentOnLoadCompleted event for the Side Search + Result Page. Recorded when DocumentOnLoadCompleted event triggered. + </summary> +</histogram> + +<histogram name="SideSearch.LoadDocumentTime" units="ms" + expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + The amount of time between the render frame host StartProvisionalLoad and + DidFinishDocumentLoad events for the Side Search Result Page. Recorded when + DidFinishDocumentLoad events triggered. + </summary> +</histogram> + +<histogram name="SideSearch.Navigation" enum="SideSearchNavigationType" + expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + The type of navigation of Side Search. Recorded when user clicks on a link + from side search panel. It either navigates the link within the side search + panel or redirects to the tab. + </summary> +</histogram> + +<histogram name="SideSearch.NavigationCommittedWithinSideSearchCountPerJourney" + units="navigations" expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + Number of navigations committed within the side search panel in the same + side panel web contents for a given search journey. Recorded when the + current search journey ends. + </summary> +</histogram> + +<histogram name="SideSearch.OpenAction" enum="SideSearchOpenActionType" + expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + The type of action taken to open Side Search. Recorded when side search + panel is open. + </summary> +</histogram> + +<histogram name="SideSearch.RedirectionToTabCountPerJourney" + units="navigations" expires_after="2022-09-29"> + <owner>yuhengh@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>romanarora@chromium.org</owner> + <summary> + Number of navigations redirected to the tab in the same side panel web + contents for a given search journey. Recorded when the current search + journey ends. + </summary> +</histogram> + +</histograms> + +</histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/signin/histograms.xml b/chromium/tools/metrics/histograms/metadata/signin/histograms.xml index 5af849d822b..8be0684f598 100644 --- a/chromium/tools/metrics/histograms/metadata/signin/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/signin/histograms.xml @@ -21,7 +21,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> -<histogram name="Signin" enum="SigninHelperFlow" expires_after="M85"> +<histogram name="Signin" enum="SigninHelperFlow" expires_after="2022-04-10"> <owner>mlerman@chromium.org</owner> <summary> Tracks user interactions as they sign in through a flow. The suffix of the @@ -47,7 +47,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Signin.AccountCapabilities.FetchResult" - enum="AccountCapabilitiesFetchResult" expires_after="2021-11-01"> + enum="AccountCapabilitiesFetchResult" expires_after="2022-04-10"> <owner>alexilin@chromium.org</owner> <owner>msarda@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> @@ -94,7 +94,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Signin.AccountConsistencyPromoAction" - enum="AccountConsistencyPromoAction" expires_after="2022-01-02"> + enum="AccountConsistencyPromoAction" expires_after="2022-04-03"> <owner>bsazonov@chromium.org</owner> <owner>aliceywang@chromium.org</owner> <summary> @@ -104,7 +104,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Signin.AccountConsistencyPromoAction.Shown.Count" - units="counts" expires_after="2022-01-02"> + units="counts" expires_after="2022-04-10"> <owner>aliceywang@chromium.org</owner> <owner>triploblastic@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> @@ -112,11 +112,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. Every time the account picker bottom sheet is shown as part of the web sign-in flow this histogram records the number of times bottom sheet was shown (Android and iOS only). + + NOTE: This stopped being recorded on Android on 10/2021. </summary> </histogram> <histogram name="Signin.AccountConsistencyPromoAction.SignedIn.Count" - units="counts" expires_after="2022-01-02"> + units="counts" expires_after="2022-04-17"> <owner>aliceywang@chromium.org</owner> <owner>triploblastic@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> @@ -124,11 +126,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. This histogram records the number of times the account picker bottom sheet was shown before the user signed-in through the bottom sheet (Android and iOS only). + + NOTE: This stopped being recorded on Android on 10/2021. </summary> </histogram> <histogram name="Signin.AccountConsistencyPromoAfterDismissal" enum="AccountConsistencyPromoAfterDismissal" expires_after="2022-01-02"> + <obsolete> + Removed 2021-08-23 + </obsolete> <owner>triploblastic@chromium.org</owner> <owner>aliceywang@chromium.org</owner> <summary> @@ -150,7 +157,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Signin.AccountFetcher.AccountAvatarFetchTime" units="ms" - expires_after="2021-12-16"> + expires_after="2022-04-17"> <owner>triploblastic@chromium.org</owner> <owner>aliceywang@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> @@ -165,7 +172,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Signin.AccountFetcher.AccountUserInfoFetchTime" units="ms" - expires_after="2021-12-16"> + expires_after="2022-04-10"> <owner>triploblastic@chromium.org</owner> <owner>aliceywang@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> @@ -205,7 +212,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.AccountTracker.GaiaIdMigrationState" - enum="OAuth2LoginAccountRevokedMigrationState" expires_after="2022-01-09"> + enum="OAuth2LoginAccountRevokedMigrationState" expires_after="2022-04-03"> <owner>msarda@chromium.org</owner> <owner>sdefresne@chromium.org</owner> <summary> @@ -243,7 +250,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.AndroidAccountInfoFetchTime" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>aliceywang@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -268,7 +275,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.AndroidDeviceAccountsNumberWhenEnteringFRE" - units="count" expires_after="2022-02-06"> + units="count" expires_after="2022-04-24"> <owner>bsazonov@chromium.org</owner> <owner>aliceywang@chromium.org</owner> <summary> @@ -278,7 +285,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.AndroidGetAccountIdsTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-22"> <owner>alexilin@chromium.org</owner> <owner>bsazonov@chromium.org</owner> <summary> @@ -287,7 +294,7 @@ prefs when the profile is loaded. --> </histogram> <histogram base="true" name="Signin.AndroidGetAccountsTime" units="ms" - expires_after="M96"> + expires_after="2022-04-22"> <owner>alexilin@chromium.org</owner> <owner>bsazonov@chromium.org</owner> <summary> @@ -322,7 +329,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.AndroidNumberOfDeviceAccounts" units="accounts" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>triploblastic@chromium.org</owner> <owner>aliceywang@chromium.org</owner> <summary> @@ -357,7 +364,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.AuthError" enum="GoogleServiceAuthError" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -394,7 +401,7 @@ prefs when the profile is loaded. --> </histogram> <histogram base="true" name="Signin.CookieJar.SignedInCountWithPrimary" - units="accounts" expires_after="2022-01-09"> + units="accounts" expires_after="2022-03-13"> <owner>jkrcal@chromium.org</owner> <owner>droger@chromium.org</owner> <!-- Name completed by histogram_suffixes name="UnconsentedPrimaryAccountType" --> @@ -509,7 +516,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.Extensions.GetAuthTokenResult" - enum="GetAuthTokenResult" expires_after="2021-12-12"> + enum="GetAuthTokenResult" expires_after="2022-05-01"> <!-- Name completed by histogram_suffixes name="GetAuthTokenType" --> <owner>alexilin@chromium.org</owner> @@ -590,7 +597,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.Intercept.AccountInfoFetchDuration" units="ms" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>alexilin@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -609,7 +616,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.Intercept.HeuristicOutcome" - enum="SigninInterceptHeuristicOutcome" expires_after="2021-12-19"> + enum="SigninInterceptHeuristicOutcome" expires_after="2022-04-24"> <owner>droger@chromium.org</owner> <owner>alexilin@chromium.org</owner> <summary> @@ -619,7 +626,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.Intercept.ProfileCreationDuration" units="ms" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>alexilin@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -629,7 +636,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.Intercept.ProfileSwitchDuration" units="ms" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>alexilin@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -697,7 +704,7 @@ prefs when the profile is loaded. --> </histogram> <histogram base="true" name="Signin.InterceptResult" - enum="SigninInterceptResult" expires_after="2021-12-19"> + enum="SigninInterceptResult" expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="SigninInterceptType" --> <owner>alexilin@chromium.org</owner> @@ -733,6 +740,9 @@ prefs when the profile is loaded. --> <histogram name="Signin.IOSGaiaCookiePresentOnNavigation" enum="BooleanPresent" expires_after="2022-01-30"> + <obsolete> + Removed 2020-12. + </obsolete> <owner>fernandex@chromium.org</owner> <owner>msarda@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> @@ -746,8 +756,8 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.IOSGaiaCookieStateOnSignedInNavigation" - enum="GaiaCookieStateOnSignedInNavigation" expires_after="2022-02-06"> - <owner>fernandex@chromium.org</owner> + enum="GaiaCookieStateOnSignedInNavigation" expires_after="2022-04-10"> + <owner>jebel@chromium.org</owner> <owner>msarda@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -761,9 +771,8 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.IOSLoginMethodAndSyncState" - enum="SigninIOSLoginMethodAndSyncState" expires_after="2021-09-12"> + enum="SigninIOSLoginMethodAndSyncState" expires_after="2022-04-01"> <owner>jebel@chromium.org</owner> - <owner>fernandex@chromium.org</owner> <owner>msarda@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -780,8 +789,7 @@ prefs when the profile is loaded. --> </histogram> <histogram name="Signin.IOSNumberOfDeviceAccounts" units="accounts" - expires_after="2021-11-07"> - <owner>fernandex@chromium.org</owner> + expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> <owner>msarda@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> @@ -834,9 +842,10 @@ the browser and content area. --> </histogram> <histogram name="Signin.LoadedIdentities.Count" units="identities" - expires_after="2021-10-25"> + expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> <owner>msarda@chromium.org</owner> + <owner>chrome-signin-team@google.com</owner> <summary> Counts the number of identities loaded by SSO library using the keychain API. The metric is recorded every time SSO updates the identity list (either @@ -846,9 +855,10 @@ the browser and content area. --> </histogram> <histogram name="Signin.LoadedIdentities.Duration" units="ms" - expires_after="2021-10-25"> + expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> <owner>msarda@chromium.org</owner> + <owner>chrome-signin-team@google.com</owner> <summary> Tracks the time it takes to load identities by SSO library using the keychain API. The metric is recorded every time SSO updates the identity @@ -858,9 +868,10 @@ the browser and content area. --> </histogram> <histogram name="Signin.LoadedIdentities.DurationPerIdentity" units="ms" - expires_after="2021-10-25"> + expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> <owner>msarda@chromium.org</owner> + <owner>chrome-signin-team@google.com</owner> <summary> Tracks the time it takes to load one identity in average by SSO library using the keychain API. This value is the total time taken by the keychain @@ -958,8 +969,9 @@ should be kept to monitor/debug signin Multilogin issues--> <histogram name="Signin.Reconciler.AddedToCookieJar" units="accounts" expires_after="never"> -<!-- expires-never: used to detect and debug signin issues --> - + <obsolete> + No longer emitted after 2021-05 and the switch to OAuthMultilogin. + </obsolete> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -983,8 +995,9 @@ should be kept to monitor/debug signin Multilogin issues--> <histogram name="Signin.Reconciler.DifferentPrimaryAccounts" enum="DifferentPrimaryAccounts" expires_after="never"> -<!-- expires-never: used to detect and debug signin issues --> - + <obsolete> + No longer emitted after 2021-05 and the switch to OAuthMultilogin. + </obsolete> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -1043,7 +1056,7 @@ should be kept to monitor/debug signin Multilogin issues--> <histogram name="Signin.Reconciler.RejectedRequestsDueToThrottler.{RequestType}" - units="requests" expires_after="M95"> + units="requests" expires_after="2022-09-30"> <owner>droger@chromium.org</owner> <owner>msarda@chromium.org</owner> <owner>msalama@chromium.org</owner> @@ -1063,8 +1076,9 @@ should be kept to monitor/debug signin Multilogin issues--> <histogram name="Signin.Reconciler.RemovedFromCookieJar" units="accounts" expires_after="never"> -<!-- expires-never: used to detect and debug signin issues --> - + <obsolete> + No longer emitted after 2021-05 and the switch to OAuthMultilogin. + </obsolete> <owner>msarda@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -1221,10 +1235,10 @@ OAuth Multilogin call. --> </histogram> <histogram name="Signin.SignedInAccountsViewImpression" enum="BooleanShown" - expires_after="2021-10-25"> - <owner>fernandex@chromium.org</owner> + expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> <owner>msarda@chromium.org</owner> + <owner>chrome-signin-team@google.com</owner> <summary> Track the number of times the view that displays the accounts that are signed is shown. This view only exists on iOS and is shown every time the @@ -1302,7 +1316,7 @@ kept as long as profile signout is possible --> </histogram> <histogram name="Signin.SSOAuth.GetIdentities.ErrorCode" - enum="SigninSSOAuthGetIdentitiesErrorCode" expires_after="2021-10-25"> + enum="SigninSSOAuthGetIdentitiesErrorCode" expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> @@ -1312,11 +1326,10 @@ kept as long as profile signout is possible --> </histogram> <histogram base="true" name="Signin.SSOIdentityListRequest.CacheState" - enum="SigninSSOIdentityListRequestCacheState" expires_after="2021-10-25"> + enum="SigninSSOIdentityListRequestCacheState" expires_after="2022-04-01"> <!-- Name completed by histogram_suffixes name="SigninSSOIdentityListRequestCacheRequestState" --> <owner>jlebel@chromium.org</owner> - <owner>fernandex@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> Tracks the SSO identity cache state before calling -[GCRSSOService @@ -1326,11 +1339,10 @@ kept as long as profile signout is possible --> </histogram> <histogram base="true" name="Signin.SSOIdentityListRequest.Duration" units="ms" - expires_after="2021-10-25"> + expires_after="2022-04-01"> <!-- Name completed by histogram_suffixes name="SigninSSOIdentityListRequestDurationCacheState" --> <owner>jlebel@chromium.org</owner> - <owner>fernandex@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> Tracks the time it takes to call -[GCRSSOService identitiesWithError:] or @@ -1340,9 +1352,8 @@ kept as long as profile signout is possible --> <histogram name="Signin.SSOIdentityListRequest.FetchIdentitiesWithCallback.Duration" - units="ms" expires_after="2021-11-14"> + units="ms" expires_after="2022-04-01"> <owner>jlebel@chromium.org</owner> - <owner>fernandex@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <summary> Tracks the time between -[GCRSSOService fetchIdentitiesWithCallback:] and @@ -1453,20 +1464,41 @@ kept as long as profile signout is possible --> </summary> </histogram> -<histogram base="true" name="Signin.SyncErrorInfoBar" - enum="SyncErrorInfoBarAction" expires_after="2021-12-12"> -<!-- Name completed by histogram_suffixes name="SyncErrorInfoBarType" --> - +<histogram name="Signin.SyncError{PromptUI}{SyncErrorReason}" + enum="SyncErrorPromptUIAction" expires_after="2022-03-12"> <owner>triploblastic@chromium.org</owner> <owner>bsazonov@chromium.org</owner> <summary> - Records various UI and user action events related to the sync error infobar. - Android only. + Records various UI and user action events related to the sync error + {PromptUI}. Android only. </summary> + <token key="PromptUI"> + <variant name="InfoBar" summary="infobar ui"/> + <variant name="Message" summary="message ui"/> + </token> + <token key="SyncErrorReason"> + <variant name=""> + <obsolete> + Base histogram. Use suffixes of this histogram instead. + </obsolete> + </variant> + <variant name=".AuthError" summary="Auth error."/> + <variant name=".ClientOutOfDate" summary="Client out of date."/> + <variant name=".PassphraseRequired" summary="Passphrase required."/> + <variant name=".SyncSetupIncomplete" summary="Sync setup incomplete."/> + <variant name=".TrustedVaultKeyRequiredForEverything" + summary="Trusted vault keys required for everything."/> + <variant name=".TrustedVaultKeyRequiredForPasswords" + summary="Trusted vault keys required for passwords."/> + <variant name=".TrustedVaultRecoverabilityDegradedForEverything" + summary="Trusted vault recoverability degraded for everything."/> + <variant name=".TrustedVaultRecoverabilityDegradedForPasswords" + summary="Trusted vault recoverability degraded for passwords."/> + </token> </histogram> <histogram name="Signin.SyncFirstSetupCompleteSource" - enum="SyncFirstSetupCompleteSource" expires_after="2021-10-10"> + enum="SyncFirstSetupCompleteSource" expires_after="2022-04-01"> <owner>triploblastic@chromium.org</owner> <owner>bsazonov@chromium.org</owner> <summary>Tracks where FirstSetupComplete bit is set from.</summary> @@ -1499,6 +1531,9 @@ should be kept for as long as we store refresh tokens in an SQLite DB. --> <histogram name="Signin.TransactionalReauthGaiaNavigationDuration.FromConfirmClick" units="ms" expires_after="2021-10-31"> + <obsolete> + Removed 2021-09. + </obsolete> <owner>alexilin@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -1510,6 +1545,9 @@ should be kept for as long as we store refresh tokens in an SQLite DB. --> <histogram name="Signin.TransactionalReauthGaiaNavigationDuration.FromReauthStart" units="ms" expires_after="2021-10-31"> + <obsolete> + Removed 2021-09. + </obsolete> <owner>alexilin@chromium.org</owner> <owner>droger@chromium.org</owner> <summary> @@ -1519,7 +1557,7 @@ should be kept for as long as we store refresh tokens in an SQLite DB. --> </histogram> <histogram name="Signin.TransactionalReauthResult" enum="SigninReauthResult" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <!-- Name completed by histogram_suffixes name="TransactionalReauthEntryPoint" --> @@ -1533,7 +1571,7 @@ name="TransactionalReauthEntryPoint" --> </histogram> <histogram name="Signin.TransactionalReauthUserAction" - enum="SigninReauthUserAction" expires_after="2022-01-02"> + enum="SigninReauthUserAction" expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="TransactionalReauthEntryPoint" --> @@ -1573,7 +1611,7 @@ Chrome adds accounts to the Gaia cookies. --> </histogram> <histogram name="Signin.UserRequestedWipeDataOnSignout" enum="BooleanRequested" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>triploblastic@google.com</owner> <owner>bsazonov@chromium.org</owner> <summary>User requested to wipe local device data on signout.</summary> diff --git a/chromium/tools/metrics/histograms/metadata/software/histograms.xml b/chromium/tools/metrics/histograms/metadata/software/histograms.xml index 49d25d6b4e4..d0cc24e9b4a 100644 --- a/chromium/tools/metrics/histograms/metadata/software/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/software/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="SoftwareReporter.Cleaner.ChromePromptChannelError" - enum="SoftwareReporterChromePromptChannelError" expires_after="M95"> + enum="SoftwareReporterChromePromptChannelError" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -35,7 +35,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.Cleaner.CleaningTime" units="ms" - expires_after="M95"> + expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -49,6 +49,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.Cleaner.CleanupResult" enum="SoftwareReporterCleanupResult" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -61,6 +64,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.Cleaner.DownloadStatus" enum="SoftwareReporterCleanerDownloadStatus" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -72,7 +78,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.Cleaner.DownloadStatusErrorCode" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="M95"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -85,6 +91,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.Cleaner.HasRebooted" enum="BooleanRebooted" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -97,6 +106,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.Cleaner.RebootResponse" enum="Boolean" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -111,7 +123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.Cleaner.RunningTime" units="ms" - expires_after="M95"> + expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -123,7 +135,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.Cleaner.ScanningTime" units="ms" - expires_after="M95"> + expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -138,6 +150,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.Cleaner.SettingsPageActiveOnRebootRequired" enum="SoftwareReporterCleanerSettingsPageActiveOnRebootRequired" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -149,18 +164,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.Cleaner.TimeToCompleteDownload" units="ms" - expires_after="2021-07-21"> + expires_after="M100"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> - The time between the first attempt to download the Chrome Cleanup tool and a - successful download or the last unsuccessful attempt to download without - retrying. + Expired in 2021-07-21 so there may be some missing data. The time between + the first attempt to download the Chrome Cleanup tool and a successful + download or the last unsuccessful attempt to download without retrying. </summary> </histogram> <histogram name="SoftwareReporter.CleanerLogsAcceptance" enum="BooleanAccepted" - expires_after="M95"> + expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -175,6 +190,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.CleanupCard" enum="Boolean" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -186,7 +204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.CleanupStarted" - enum="SoftwareReporterCleanupStarted" expires_after="M95"> + enum="SoftwareReporterCleanupStarted" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -198,7 +216,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.ConfigurationErrors" - enum="SoftwareReporterConfigurationError" expires_after="M95"> + enum="SoftwareReporterConfigurationError" expires_after="2022-10-01"> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -208,8 +226,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.FoundUwSReadError" enum="BooleanError" - expires_after="M95"> - <owner>drubery@chromium.org</owner> + expires_after="2022-05-01"> + <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> Whether there was an error reading the registry key containing UwS found by @@ -218,7 +236,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.IPCDisconnected" - enum="SoftwareReporterIPCDisconnected" expires_after="M95"> + enum="SoftwareReporterIPCDisconnected" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -235,14 +253,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.LastUploadResult" enum="BooleanSuccess" - expires_after="M95"> - <owner>drubery@chromium.org</owner> + expires_after="M100"> + <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary>The result of the most recent SRT log upload.</summary> </histogram> <histogram name="SoftwareReporter.LogsUploadEnabled" - enum="SoftwareReporterLogsUploadEnabled" expires_after="M95"> + enum="SoftwareReporterLogsUploadEnabled" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -255,7 +273,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.LogsUploadResult" - enum="SoftwareReporterLogsUploadResult" expires_after="M95"> + enum="SoftwareReporterLogsUploadResult" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -268,7 +286,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.LogsUploadResultRegistryError" - enum="SoftwareReporterLogsUploadResultRegistryError" expires_after="M95"> + enum="SoftwareReporterLogsUploadResultRegistryError" + expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -280,7 +299,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.MajorVersion" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -292,7 +311,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.MemoryUsed" units="KB" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -302,7 +321,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.MinorVersion" units="units" - expires_after="2021-09-19"> + expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -313,7 +332,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.NoPromptReason" - enum="SoftwareReporterNoPromptReason" expires_after="M95"> + enum="SoftwareReporterNoPromptReason" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -327,6 +346,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.NumberOfFilesToDelete" units="counts" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -339,6 +361,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.OnDemandUpdateRequired" enum="BooleanRequired" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -350,7 +375,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.OnDemandUpdateSucceeded" - enum="BooleanSuccess" expires_after="M95"> + enum="BooleanSuccess" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -362,7 +387,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.PostCleanupSettingsReset" units="counts" - expires_after="M95"> + expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -374,7 +399,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.PromptDialogResponse" - enum="SoftwareReporterPromptDialogResponse" expires_after="M95"> + enum="SoftwareReporterPromptDialogResponse" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -387,6 +412,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.PromptShownWithType" enum="SoftwareReporterPromptShownWithType" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -401,7 +429,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.ReporterSequenceType" - enum="SoftwareReporterSequenceType" expires_after="M95"> + enum="SoftwareReporterSequenceType" expires_after="2022-08-25"> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -413,7 +441,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.RunningTimeAccordingToChrome" units="ms" - expires_after="2022-01-21"> + expires_after="2022-03-27"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -425,7 +453,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SoftwareReporter.RunningTimeWithoutSleep" units="ms" - expires_after="2022-01-21"> + expires_after="2022-04-17"> <owner>drubery@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> <summary> @@ -438,6 +466,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.ScannerLogsAcceptance" enum="BooleanAccepted" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> @@ -451,6 +482,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SoftwareReporter.TaggedProfileForResetting" enum="Boolean" expires_after="M95"> + <obsolete> + Removed 09-2021 + </obsolete> <owner>drubery@chromium.org</owner> <owner>bdea@chromium.org</owner> <owner>chrome-safebrowsing-alerts@google.com</owner> diff --git a/chromium/tools/metrics/histograms/metadata/stability/histograms.xml b/chromium/tools/metrics/histograms/metadata/stability/histograms.xml index 61e7bf54272..3383785ad4d 100644 --- a/chromium/tools/metrics/histograms/metadata/stability/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/stability/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Stability.Android.OomKillReverseRank" units="rank" - expires_after="2021-10-31"> + expires_after="2022-05-01"> <owner>boliu@chromium.org</owner> <owner>ssid@chromium.org</owner> <summary> @@ -64,7 +64,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.Android.ProcessedRealMinidumps" - enum="AndroidProcessedMinidumps" expires_after="2021-11-23"> + enum="AndroidProcessedMinidumps" expires_after="2022-04-10"> <owner>mheikal@chromium.org</owner> <owner>smaier@chromium.org</owner> <owner>wnwen@chromium.org</owner> @@ -77,7 +77,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.Android.ProcessedSimulatedMinidumps" - enum="AndroidProcessedMinidumps" expires_after="2021-11-23"> + enum="AndroidProcessedMinidumps" expires_after="2022-05-01"> <owner>mheikal@chromium.org</owner> <owner>smaier@chromium.org</owner> <owner>wnwen@chromium.org</owner> @@ -90,7 +90,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.Android.RendererCrash" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>wnwen@chromium.org</owner> <summary> Counts renderer crashes including OOMs. Android only. Mirrors old stability @@ -130,7 +130,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Stability.Android.SystemExitReason" - enum="AndroidProcessExitReason" expires_after="2022-03-01"> + enum="AndroidProcessExitReason" expires_after="2022-05-01"> <owner>boliu@chromium.org</owner> <owner>ssid@chromium.org</owner> <owner>wnwen@chromium.org</owner> @@ -142,7 +142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.BadMessageTerminated.Autofill" - enum="BadMessageReasonAutofill" expires_after="M95"> + enum="BadMessageReasonAutofill" expires_after="2022-09-16"> <owner>vollick@chromium.org</owner> <owner>battre@chromium.org</owner> <summary> @@ -163,7 +163,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.BadMessageTerminated.Content" - enum="BadMessageReasonContent" expires_after="2022-01-16"> + enum="BadMessageReasonContent" expires_after="2022-03-20"> <owner>jam@chromium.org</owner> <owner>jamescook@chromium.org</owner> <summary> @@ -173,7 +173,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.BadMessageTerminated.Extensions" - enum="BadMessageReasonExtensions" expires_after="2021-11-14"> + enum="BadMessageReasonExtensions" expires_after="2022-04-03"> <owner>jamescook@chromium.org</owner> <owner>karandeepb@chromium.org</owner> <summary> @@ -228,7 +228,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.ChildFrameCrash.ShownAfterCrashingReason" - enum="ShownAfterCrashingReason" expires_after="2021-12-05"> + enum="ShownAfterCrashingReason" expires_after="2022-08-18"> <owner>alexmos@chromium.org</owner> <owner>boliu@chromium.org</owner> <owner>lukasza@chromium.org</owner> @@ -240,7 +240,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.ChildFrameCrash.TabMarkedForReload" - enum="BooleanMarkedForReload" expires_after="2021-09-30"> + enum="BooleanMarkedForReload" expires_after="2022-08-18"> <owner>alexmos@chromium.org</owner> <owner>boliu@chromium.org</owner> <summary> @@ -250,7 +250,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.ChildFrameCrash.TabMarkedForReload.Visibility" - enum="FrameVisibility" expires_after="2021-09-30"> + enum="FrameVisibility" expires_after="2022-08-18"> <owner>alexmos@chromium.org</owner> <owner>boliu@chromium.org</owner> <summary> @@ -261,7 +261,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.ChildFrameCrash.Visibility" enum="CrashVisibility" - expires_after="2022-02-06"> + expires_after="2022-08-18"> <owner>alexmos@chromium.org</owner> <owner>boliu@chromium.org</owner> <owner>lfg@chromium.org</owner> @@ -313,6 +313,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Stability.Experimental.BrowserCrash" enum="Boolean" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -336,6 +339,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Stability.Experimental.Counts2" enum="StabilityEventType" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -345,7 +351,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.Experimental.PageLoads" enum="StabilityPageLoadType" - expires_after="2022-01-16"> + expires_after="2022-04-10"> <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> @@ -359,6 +365,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Stability.Experimental.ProcessId" units="process id" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -369,6 +378,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Stability.Experimental.RandInt" units="random number" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -378,6 +390,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Stability.Experimental.SessionId" units="session id" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -436,7 +451,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.Internals.SystemCrashCount" units="crashes" - expires_after="2021-10-20"> + expires_after="2022-10-20"> <owner>davidbienvenu@chromium.org</owner> <owner>jessemckenna@google.com</owner> <summary> @@ -547,7 +562,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.iOS.UTE.HasPossibleExplanation" - enum="BooleanHasPossibleExplanation" expires_after="2021-12-12"> + enum="BooleanHasPossibleExplanation" expires_after="2022-04-24"> <owner>michaeldo@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -627,7 +642,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Stability.iOS.UTE.TimeBetweenUTEAndNextLaunch" units="ms" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>michaeldo@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/startup/histograms.xml b/chromium/tools/metrics/histograms/metadata/startup/histograms.xml index 2831f3f9ca3..fa5d19304b9 100644 --- a/chromium/tools/metrics/histograms/metadata/startup/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/startup/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="Startup.AfterStartupTaskCount" units="units" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>michaeln@chromium.org</owner> <summary> The number of after-startup tasks that were queued prior to startup @@ -31,7 +31,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.AfterStartupTaskDelayedUntilTime" units="ms" - expires_after="2021-11-21"> + expires_after="2022-04-17"> <owner>michaeln@chromium.org</owner> <summary> Time from the process creation until deferred after-startup tasks began @@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Startup.Android.Cold.TimeToFirstContentfulPaint" - units="ms" expires_after="2022-01-16"> + units="ms" expires_after="2022-03-20"> <owner>pasko@chromium.org</owner> <owner>alexilin@chromium.org</owner> <summary> @@ -79,7 +79,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Startup.Android.Cold.TimeToFirstNavigationCommit" - units="ms" expires_after="2022-01-16"> + units="ms" expires_after="2022-03-20"> <owner>pasko@chromium.org</owner> <owner>alexilin@chromium.org</owner> <summary> @@ -93,7 +93,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.Android.Cold.TimeToFirstVisibleContent" units="ms" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>yfriedman@chromium.org</owner> <owner>yashard@chromium.org</owner> <summary> @@ -106,7 +106,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.Android.Cold.TimeToVisibleContent" units="ms" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>yashard@chromium.org</owner> <owner>ckitagawa@chromium.org</owner> <summary> @@ -120,7 +120,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Startup.Android.FeedContentFirstLoadedTime" - units="ms" expires_after="2022-02-06"> + units="ms" expires_after="2022-04-17"> <!-- Name completed by histogram_suffixes name="JavaStartMode" --> <owner>hanxi@chromium.org</owner> @@ -135,7 +135,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.Android.FeedsLoadingPlaceholderShown.Instant" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-05-01"> <owner>hanxi@chromium.org</owner> <owner>spdonghao@chromium.org</owner> <owner>wychen@chromium.org</owner> @@ -162,7 +162,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Startup.Android.FirstDrawCompletedTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="JavaStartMode" --> <owner>hanxi@chromium.org</owner> @@ -183,8 +183,29 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Startup.Android.ShowChromeStartSegmentationResult" + enum="ShowChromeStartSegmentationResult" expires_after="2022-08-09"> + <owner>hanxi@chromium.org</owner> + <owner>ssid@chromium.org</owner> + <summary> + The result from segmentation platform that determines whether or not to show + Start surface at startup. Recorded during startup. + </summary> +</histogram> + +<histogram name="Startup.Android.ShowChromeStartSegmentationResultComparison" + enum="ShowChromeStartSegmentationResultComparison" + expires_after="2022-08-09"> + <owner>hanxi@chromium.org</owner> + <owner>ssid@chromium.org</owner> + <summary> + Records the comparison of result from segmentation and code logic for when + to show Start surface at startup. Recorded during startup. + </summary> +</histogram> + <histogram base="true" name="Startup.Android.SingleTabTitleAvailableTime" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-02-20"> <!-- Name completed by histogram_suffixes name="JavaStartMode" --> <owner>hanxi@chromium.org</owner> @@ -198,8 +219,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Startup.Android.StartSurfaceShownAtStartup" units="Boolean" + expires_after="2022-10-07"> + <owner>hanxi@chromium.org</owner> + <owner>spdonghao@chromium.org</owner> + <owner>wychen@chromium.org</owner> + <summary> + Records whether the Start surface homepage is showing at a cold startup when + the Start surface is enabled. This histogram is recorded in a deferred + startup task after Chrome is launched. + </summary> +</histogram> + <histogram name="Startup.Android.StartupTabPreloader.TabLoaded" units="Boolean" - expires_after="2021-10-25"> + expires_after="2022-09-01"> <owner>skyostil@chromium.org</owner> <summary> Android: Whether or not creation of a profile lead to the @@ -210,14 +243,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.Android.StartupTabPreloader.TabTaken" units="Boolean" - expires_after="2020-11-08"> + expires_after="2022-09-01"> <owner>skyostil@chromium.org</owner> <summary> Android: Whether or not a tab speculatively created by the StartupTabPreloader was subsequently adopted by ChromeTabCreator. Recorded when a tab is loaded, assuming a StartupTabPreloader has been constructed for intents with a url for either regular Chrome or a Custom Tab will be - loaded. + loaded. Warning: this histogram was expired from 2020-11-08 through M95. </summary> </histogram> @@ -283,7 +316,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.BringToForegroundReason" - enum="BooleanBringToForegroundReason" expires_after="2022-01-23"> + enum="BooleanBringToForegroundReason" expires_after="2022-04-03"> <owner>peter@chromium.org</owner> <summary> Records the cause, each time Chrome is brought to the foreground. Currently @@ -293,7 +326,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.BrowserMainRunnerImplInitializeLongTime" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>robliao@chromium.org</owner> <summary> The amount of time that elapsed during BrowserMainRunnerImpl::Initialize. @@ -319,7 +352,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.BrowserMessageLoopFirstIdle" units="ms" - expires_after="2022-01-31"> + expires_after="2022-04-10"> <owner>gab@chromium.org</owner> <owner>etienneb@chromium.org</owner> <summary> @@ -400,8 +433,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.BrowserWindow.FirstPaint" units="ms" - expires_after="2022-01-23"> - <owner>sebmarchand@chromium.org</owner> + expires_after="2022-04-10"> + <owner>gab@chromium.org</owner> <owner>mblsha@yandex-team.ru</owner> <summary> Time from application start to the time the first Browser window has @@ -518,6 +551,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Startup.ConsecutiveLoadsWithoutLaunch" units="count" + expires_after="2022-09-30"> + <owner>olivierrobin@chromium.org</owner> + <owner>ajuma@chromium.org</owner> + <summary> + [IOS] The number of time +load was called but no scene was activated. + Recorded when first scene is becomes active. + </summary> +</histogram> + <histogram name="Startup.CreateFirstProfile" units="ms" expires_after="never"> <!-- expires-never: used to diagnose regressions to Startup.FirstWebContents.NonEmptyPaint3 --> @@ -529,6 +572,21 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram base="true" name="Startup.DoUpgradeTasks.{Status}" units="ms" + expires_after="M99"> + <owner>gab@chromium.org</owner> + <owner>etienneb@chromium.org</owner> + <summary> + Records the time it took to complete upgrade_util::DoUpgradeTasks() when + {Status}. + </summary> + <token key="Status"> + <variant name="NoRelaunch"/> + <variant name="RelaunchFailed"/> + <variant name="RelaunchSucceeded"/> + </token> +</histogram> + <histogram name="Startup.FirstWebContents.FinishReason" enum="StartupProfilingFinishReason" expires_after="never"> <!-- expires-never: used to understand user behavior shifts when Startup.FirstWebContents.NonEmptyPaint3 regresses --> @@ -647,7 +705,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.MobileSessionStartAction" - enum="MobileSessionStartAction" expires_after="2022-01-09"> + enum="MobileSessionStartAction" expires_after="2022-03-13"> <owner>thegreenfrog@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -657,7 +715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.MobileSessionStartFromApps" - enum="MobileSessionCallerApp" expires_after="2022-01-09"> + enum="MobileSessionCallerApp" expires_after="2022-04-03"> <owner>thegreenfrog@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary>The calling application (if any).</summary> @@ -727,7 +785,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.PreMainMessageLoopRunImplLongTime" units="ms" - expires_after="2021-10-25"> + expires_after="2022-05-01"> <owner>rkaplow@chromium.org</owner> <summary> The amount of time that elapsed during @@ -744,7 +802,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Startup.Temperature" enum="StartupTemperature" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <!-- expires-after: Diagnosis metric for changes in StartupTemperature suffix. Shouldn't truly expire but kColdStartHardFaultCountThreshold should be surveyed yearly. --> @@ -759,6 +817,47 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Startup.TimeFromProcessCreationToDidFinishLaunchingCall" + units="ms" expires_after="2022-09-30"> + <owner>olivierrobin@chromium.org</owner> + <owner>ajuma@chromium.org</owner> + <summary> + [IOS] The duration between process spawn (returned by sysctl) and call to + [UIApplicationDelegate didFinishLaunching:]. Recorded when first scene is + becomes active. + </summary> +</histogram> + +<histogram name="Startup.TimeFromProcessCreationToLoad" units="ms" + expires_after="2022-09-30"> + <owner>olivierrobin@chromium.org</owner> + <owner>ajuma@chromium.org</owner> + <summary> + [IOS] The duration between process spawn (returned by sysctl) and library + load (logged on +load method). Recorded when first scene is becomes active. + </summary> +</histogram> + +<histogram name="Startup.TimeFromProcessCreationToMainCall" units="ms" + expires_after="2022-09-30"> + <owner>olivierrobin@chromium.org</owner> + <owner>ajuma@chromium.org</owner> + <summary> + [IOS] The duration between process spawn (returned by sysctl) and call to + main. Recorded when first scene is becomes active. + </summary> +</histogram> + +<histogram name="Startup.TimeFromProcessCreationToSceneConnection" units="ms" + expires_after="2022-09-30"> + <owner>olivierrobin@chromium.org</owner> + <owner>ajuma@chromium.org</owner> + <summary> + [IOS] The duration between process spawn (returned by sysctl) and call to + the first scene connection. Recorded when first scene is becomes active. + </summary> +</histogram> + <histogram name="Startup.WebFooterExperiment.DidFirstVisuallyNonEmptyPaint" units="ms" expires_after="M89"> <obsolete> diff --git a/chromium/tools/metrics/histograms/metadata/storage/histograms.xml b/chromium/tools/metrics/histograms/metadata/storage/histograms.xml index d668337f1f0..ce696b7aa73 100644 --- a/chromium/tools/metrics/histograms/metadata/storage/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/storage/histograms.xml @@ -431,7 +431,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Storage.InterestGroup.DBMaintenanceTime" units="microseconds" - expires_after="M95"> + expires_after="M100"> <owner>behamilton@google.com</owner> <owner>pauljensen@chromium.org</owner> <summary> @@ -444,13 +444,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Storage.InterestGroup.PerSiteCount" units="groups" - expires_after="M95"> + expires_after="M100"> <owner>behamilton@google.com</owner> <owner>pauljensen@chromium.org</owner> <summary> Records the number of interest groups loaded for a single group owner when running an ad auction. Recorded for each owner involved in a running ad - auction. Caveat: the loading code only loads the most recent 1000 entries. + auction. </summary> </histogram> diff --git a/chromium/tools/metrics/histograms/metadata/subresource/histograms.xml b/chromium/tools/metrics/histograms/metadata/subresource/histograms.xml index f1ab8782e74..c5ea67edae1 100644 --- a/chromium/tools/metrics/histograms/metadata/subresource/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/subresource/histograms.xml @@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <histogram name="SubresourceFilter.Actions2" enum="SubresourceFilterActions2" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>alexmt@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -46,7 +46,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Browser.InvalidCount" - units="count" expires_after="2022-01-31"> + units="count" expires_after="2022-04-17"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -59,7 +59,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Browser.ListLength" - units="length" expires_after="2022-01-31"> + units="length" expires_after="2022-04-17"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -72,7 +72,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Browser.RedundantCount" - units="count" expires_after="2022-01-31"> + units="count" expires_after="2022-04-17"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -101,7 +101,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SubresourceFilter.CnameAlias.Browser.WasBlockedBasedOnAliasCount" - units="count" expires_after="2022-01-31"> + units="count" expires_after="2022-04-10"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -114,7 +114,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Renderer.HadAliases" - units="BooleanHadAliases" expires_after="2022-01-31"> + units="BooleanHadAliases" expires_after="2022-04-10"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -127,7 +127,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Renderer.InvalidCount" - units="count" expires_after="2022-01-31"> + units="count" expires_after="2022-04-17"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -140,7 +140,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Renderer.ListLength" - units="length" expires_after="2022-01-31"> + units="length" expires_after="2022-04-17"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -153,7 +153,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Renderer.RedundantCount" - units="count" expires_after="2022-01-31"> + units="count" expires_after="2022-04-17"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -168,7 +168,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Renderer.WasAdTaggedBasedOnAlias" - units="BooleanTagged" expires_after="2022-01-31"> + units="BooleanTagged" expires_after="2022-04-10"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -181,7 +181,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.CnameAlias.Renderer.WasBlockedBasedOnAlias" - units="BooleanBlocked" expires_after="2022-01-31"> + units="BooleanBlocked" expires_after="2022-04-10"> <owner>cammie@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -333,7 +333,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.Experimental.ReadyToCommitResultsInCommit2" - enum="Boolean" expires_after="2022-01-12"> + enum="Boolean" expires_after="2022-04-10"> <owner>alexmt@chromium.org</owner> <owner>johnidel@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> @@ -350,7 +350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="SubresourceFilter.Experimental.ReadyToCommitResultsInCommit2.RestrictedAdFrameNavigation" - enum="Boolean" expires_after="2022-01-12"> + enum="Boolean" expires_after="2022-04-24"> <owner>alexmt@chromium.org</owner> <owner>johnidel@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> @@ -382,7 +382,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.IndexRuleset.NumUnsupportedRules" - units="rules" expires_after="M90"> + units="rules" expires_after="2022-09-15"> <owner>jkarlin@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -391,11 +391,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ruleset indexing process and it reaches the point where rules are getting indexed. This is logged when a new ruleset is indexed for the first time on Chrome start. + + Warning: This metric expired after M90 (around 05/2021) and was unexpired + 09/2021. Data may be missing. </summary> </histogram> <histogram name="SubresourceFilter.IndexRuleset.Verify.Status" - enum="SubresourceFilterVerifyStatus" expires_after="2021-12-12"> + enum="SubresourceFilterVerifyStatus" expires_after="2022-04-24"> <owner>alexmt@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -505,7 +508,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.PageLoad.ActivationList" - enum="ActivationList" expires_after="2022-01-16"> + enum="ActivationList" expires_after="2022-03-20"> <owner>alexmt@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -515,7 +518,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.PageLoad.ActivationState" - enum="SubresourceFilterActivationState" expires_after="2022-01-16"> + enum="SubresourceFilterActivationState" expires_after="2022-03-20"> <owner>alexmt@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -572,7 +575,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.PageLoad.NumSubresourceLoads.MatchedRules" - units="resource loads" expires_after="2021-12-19"> + units="resource loads" expires_after="2022-04-03"> <owner>jkarlin@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -671,7 +674,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.SafeBrowsing.TotalCheckTime" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>alexmt@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> @@ -685,7 +688,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="SubresourceFilter.SubresourceLoad.Evaluation.CPUDuration" - units="microseconds" expires_after="2022-01-12"> + units="microseconds" expires_after="2022-04-17"> <owner>alexmt@chromium.org</owner> <owner>chrome-ads-histograms@google.com</owner> <summary> diff --git a/chromium/tools/origin_trials/third_party/ed25519/DIR_METADATA b/chromium/tools/metrics/histograms/metadata/sync/DIR_METADATA index b21fcd91daa..5099a4e6fb1 100644 --- a/chromium/tools/origin_trials/third_party/ed25519/DIR_METADATA +++ b/chromium/tools/metrics/histograms/metadata/sync/DIR_METADATA @@ -7,6 +7,5 @@ # https://source.chromium.org/chromium/infra/infra/+/main:go/src/infra/tools/dirmd/proto/dir_metadata.proto monorail { - component: "Internals>OriginTrials" -} -team_email: "experimentation-dev@chromium.org"
\ No newline at end of file + component: "Services>Sync" +}
\ No newline at end of file diff --git a/chromium/tools/metrics/histograms/metadata/sync/histograms.xml b/chromium/tools/metrics/histograms/metadata/sync/histograms.xml index a6b30708fad..2571c2edf68 100644 --- a/chromium/tools/metrics/histograms/metadata/sync/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/sync/histograms.xml @@ -76,7 +76,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarkEntityReuploadNeeded.On{UpdateType}" - enum="Boolean" expires_after="M95"> + enum="Boolean" expires_after="2022-02-14"> <owner>mastiz@chromium.org</owner> <owner>rushans@google.com</owner> <component>Services>Sync</component> @@ -91,7 +91,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarkGUIDSource2" enum="BookmarkGUIDSource" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -105,7 +105,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarkModelMerger.ReachableInputUpdates" - units="bookmarks" expires_after="2021-10-25"> + units="bookmarks" expires_after="2022-04-03"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -118,7 +118,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarkModelMerger.UnsyncedEntitiesUponCompletion" - units="bookmarks" expires_after="2021-10-25"> + units="bookmarks" expires_after="2022-04-17"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -131,7 +131,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarkModelMerger.ValidInputUpdates" units="bookmarks" - expires_after="2021-10-25"> + expires_after="2022-04-10"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -161,7 +161,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarksGUIDDuplicates" enum="BookmarksGUIDDuplicates" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>mastiz@chromium.org</owner> <owner>rushans@google.com</owner> <component>Services>Sync</component> @@ -173,7 +173,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarksModelMetadataCorruptionReason" - enum="SyncBookmarkModelMetadataCorruptionReason" expires_after="2021-12-12"> + enum="SyncBookmarkModelMetadataCorruptionReason" expires_after="2022-04-24"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -186,7 +186,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.BookmarkSpecificsExcludingFoldersContainFavicon" - enum="Boolean" expires_after="2021-10-25"> + enum="Boolean" expires_after="2022-04-03"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -226,7 +226,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.CommitResponse" enum="SyncerErrorValues" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="SyncModelType" --> <owner>rushans@google.com</owner> @@ -253,7 +253,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.ConfigureDataTypes" enum="SyncModelTypes" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>mastiz@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -291,7 +291,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ConfigureTime_Subsequent" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>victorvianna@google.com</owner> <owner>jkrcal@chromium.org</owner> <component>Services>Sync</component> @@ -386,7 +386,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.CryptographerPendingKeys" - enum="SyncCryptographerPendingKeysState" expires_after="2021-12-05"> + enum="SyncCryptographerPendingKeysState" expires_after="2022-05-01"> <owner>mastiz@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -407,7 +407,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.CustomEncryption" enum="SyncCustomEncryptionEvent" - expires_after="2022-01-03"> + expires_after="2022-05-01"> <owner>mastiz@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -435,7 +435,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.CustomSync3" enum="SyncModelTypes" - expires_after="2021-12-16"> + expires_after="2022-04-10"> <owner>treib@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -452,7 +452,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.DataTypeRunFailures2" enum="SyncModelTypes" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>jkrcal@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -464,7 +464,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.DataTypeStartFailures2" enum="SyncModelTypes" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>jkrcal@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -510,7 +510,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.E2ELatency" units="ms" - expires_after="2022-02-01"> + expires_after="2022-04-17"> <owner>mastiz@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -536,7 +536,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.InitialState" enum="SyncInitialState" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>treib@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -554,7 +554,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="never"> <!-- expires-never: For monitoring FCM based invalidations. --> - <owner>mmoskvitin@chromium.org</owner> + <owner>mmoskvitin@google.com</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> <summary> @@ -563,7 +563,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.InvalidBookmarkSpecifics" - enum="InvalidBookmarkSpecificsError" expires_after="2021-10-01"> + enum="InvalidBookmarkSpecificsError" expires_after="2022-04-10"> <owner>mastiz@chromium.org</owner> <owner>rushans@google.com</owner> <component>Services>Sync</component> @@ -574,7 +574,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.KeystoreDecryptionFailed" - enum="SyncKeystoreDecryptionFailure" expires_after="2021-11-07"> + enum="SyncKeystoreDecryptionFailure" expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -584,7 +584,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.Local.Enabled" enum="BooleanEnabled" - expires_after="2021-12-05"> + expires_after="2022-04-10"> <owner>pastarmovj@chromium.org</owner> <component>Services>Sync</component> <summary> @@ -631,6 +631,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Sync.LocalDeviceInfoDeletionReuploaded" enum="Boolean" + expires_after="2022-01-31"> + <owner>rushans@google.com</owner> + <owner>treib@chromium.org</owner> + <component>Services>Sync</component> + <summary> + Recorded after receiving an incoming deletion of local DeviceInfo during + incremental update. Counts whether the local DeviceInfo is marked to be + reuploaded. + </summary> +</histogram> + <histogram name="Sync.LocalSyncTransportDataStartupState" enum="LocalSyncTransportDataStartupState" expires_after="2021-11-21"> <owner>rushans@google.com</owner> @@ -660,7 +672,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.ModelTypeBlockedDueToUndecryptableUpdate" - enum="SyncModelTypes" expires_after="2021-12-12"> + enum="SyncModelTypes" expires_after="2022-04-03"> <owner>victorvianna@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -674,7 +686,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Sync.ModelTypeBlockedDueToUndecryptableUpdate.SomeKeysAvailable" - enum="SyncModelTypes" expires_after="M92"> + enum="SyncModelTypes" expires_after="2021-08-17"> + <obsolete> + Removed on 08/2021. + </obsolete> <owner>mastiz@chromium.org</owner> <owner>mmoskvitin@google.com</owner> <owner>victorvianna@google.com</owner> @@ -692,7 +707,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeConfigurationTime.Ephemeral" - units="ms" expires_after="2022-01-02"> + units="ms" expires_after="2022-03-06"> <owner>jkrcal@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -706,7 +721,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeConfigurationTime.Persistent" - units="ms" expires_after="2021-12-05"> + units="ms" expires_after="2022-04-10"> <owner>jkrcal@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -720,7 +735,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeCount4" units="entries" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>jkrcal@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -734,7 +749,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeEntityChange3" - enum="SyncEntityChange" expires_after="2021-12-19"> + enum="SyncEntityChange" expires_after="2022-04-24"> <owner>jkrcal@chromium.org</owner> <component>Services>Sync</component> <summary> @@ -746,7 +761,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeErrorSite" - enum="SyncModelTypeErrorSite" expires_after="2021-10-10"> + enum="SyncModelTypeErrorSite" expires_after="2022-04-10"> <!-- Name completed by histogram_suffixes name="SyncModelType" --> <owner>jkrcal@chromium.org</owner> @@ -760,7 +775,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.ModelTypeIncrementalUpdateReceived" enum="SyncModelTypes" - expires_after="2021-08-31"> + expires_after="2022-04-10"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -772,7 +787,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.ModelTypeInitialUpdateReceived" enum="SyncModelTypes" - expires_after="2021-08-31"> + expires_after="2022-04-03"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -783,7 +798,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeMemoryKB" units="KB" - expires_after="2022-01-09"> + expires_after="2022-04-17"> <owner>mastiz@chromium.org</owner> <owner>jkrcal@chromium.org</owner> <component>Services>Sync</component> @@ -795,7 +810,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeOrphanMetadata" - enum="SyncModelTypes" expires_after="2021-09-05"> + enum="SyncModelTypes" expires_after="2022-03-05"> <owner>jkrcal@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -829,6 +844,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram base="true" name="Sync.ModelTypeStoreCommitWriteBatchOutcome" enum="LevelDBStatus" expires_after="2021-10-10"> + <obsolete> + Deprecated 09/2021. + </obsolete> <!-- Name completed by histogram_suffixes name="SyncModelType" --> <owner>qjw@chromium.org</owner> @@ -843,7 +861,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeTimeUntilEncryptionKeyFound" - units="GetUpdatesResponses" expires_after="2021-10-06"> + units="GetUpdatesResponses" expires_after="2022-02-06"> + <obsolete> + Replaced with Sync.ModelTypeTimeUntilEncryptionKeyFound2 on 10/2021 (M96). + </obsolete> <owner>victorvianna@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -904,8 +925,25 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram base="true" name="Sync.ModelTypeTimeUntilEncryptionKeyFound2" + units="GetUpdates" expires_after="2022-02-06"> + <owner>victorvianna@google.com</owner> + <owner>mastiz@chromium.org</owner> + <component>Services>Sync</component> + <summary> + Records how long it took from the moment the first update encrypted with + this key was received by ModelTypeWorker, to the moment where the key was + available to the Cryptographer. The time is measured by the number of + GetUpdates cycles performed by the worker *while* the Cryptographer didn't + have pending keys (and thus the key should have been known in theory). + + This replaced Sync.ModelTypeTimeUntilEncryptionKeyFound which used to + measure the same time in GetUpdatesResponse-s. + </summary> +</histogram> + <histogram base="true" name="Sync.ModelTypeUndecryptablePendingUpdatesDropped" - units="SyncEntity" expires_after="2021-10-06"> + units="SyncEntity" expires_after="2022-02-06"> <owner>victorvianna@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -918,7 +956,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.ModelTypeUpdateDrop" enum="SyncModelTypes" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <!-- Name completed by histogram_suffixes name="SyncModelTypeUpdateDrop" --> <owner>jkrcal@chromium.org</owner> @@ -931,7 +969,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.NonReflectionUpdateFreshnessPossiblySkewed2" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>mastiz@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -945,7 +983,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.PassphraseType" enum="SyncPassphraseType" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>treib@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1045,7 +1083,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.PostedClientToServerMessage" - enum="SyncClientToServerMessageContents" expires_after="2021-12-12"> + enum="SyncClientToServerMessageContents" expires_after="2022-04-17"> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> <summary> @@ -1073,7 +1111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.PostedClientToServerMessageError2" enum="SyncErrorType" - expires_after="2021-12-14"> + expires_after="2022-04-17"> <owner>mastiz@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -1085,7 +1123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.PostedClientToServerMessageLatency" units="ms" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> <summary> @@ -1095,7 +1133,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.PostedDataTypeCommitRequest" enum="SyncModelTypes" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>mastiz@chromium.org</owner> <owner>jkrcal@chromium.org</owner> <component>Services>Sync</component> @@ -1109,7 +1147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.PostedDataTypeGetUpdatesRequest" enum="SyncModelTypes" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>mastiz@chromium.org</owner> <owner>jkrcal@chromium.org</owner> <component>Services>Sync</component> @@ -1123,7 +1161,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.PostedGetUpdatesOrigin" enum="SyncGetUpdatesOrigin" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>mastiz@chromium.org</owner> <owner>jkrcal@chromium.org</owner> <component>Services>Sync</component> @@ -1149,7 +1187,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.ProblematicServerSideBookmarks" - enum="RemoteBookmarkUpdateError" expires_after="2021-12-26"> + enum="RemoteBookmarkUpdateError" expires_after="2022-04-17"> <owner>mastiz@chromium.org</owner> <owner>rushans@google.com</owner> <component>Services>Sync</component> @@ -1160,7 +1198,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.ProblematicServerSideBookmarksDuringMerge" - enum="RemoteBookmarkUpdateError" expires_after="2021-12-26"> + enum="RemoteBookmarkUpdateError" expires_after="2022-04-03"> <owner>rushans@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1171,8 +1209,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.RecordedUserEventType" enum="SyncUserEventType" - expires_after="2021-09-30"> - <owner>mmoskvitin@chromium.org</owner> + expires_after="2022-05-01"> + <owner>mmoskvitin@google.com</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> <summary> @@ -1199,8 +1237,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.RedundantInvalidationPerModelType2" enum="SyncModelTypes" - expires_after="2021-12-16"> - <owner>mmoskvitin@chromium.org</owner> + expires_after="2022-05-01"> + <owner>mmoskvitin@google.com</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> <summary> @@ -1224,7 +1262,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.SharingMessage.CommitResult" - enum="SyncSharingMessageCommitErrorCode" expires_after="2021-12-12"> + enum="SyncSharingMessageCommitErrorCode" expires_after="2022-04-24"> <owner>rushans@google.com</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -1234,7 +1272,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.Startup.DeferredInitTrigger" - enum="SyncDeferredInitTrigger" expires_after="2021-12-19"> + enum="SyncDeferredInitTrigger" expires_after="2022-04-24"> <owner>mastiz@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -1242,7 +1280,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.Startup.PolicyLoadStartupDelay" units="ms" - expires_after="2021-11-01"> + expires_after="2022-04-17"> <owner>ydago@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -1270,7 +1308,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.Startup.PolicyLoadTimeout2" enum="Boolean" - expires_after="2021-11-01"> + expires_after="2022-04-17"> <owner>ydago@chromium.org</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> @@ -1307,7 +1345,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.StopSource" enum="SyncStopSource" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>treib@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1351,7 +1389,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.SyncErrorInfobarDisplayed" enum="SyncErrorInfobarTypes" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>fernandex@chromium.org</owner> <owner>chrome-signin-team@google.com</owner> <component>Services>Sync</component> @@ -1362,7 +1400,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.SyncEverything2" enum="Boolean" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>treib@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1375,7 +1413,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultAccessTokenFetchSuccess" enum="Boolean" - expires_after="2021-11-01"> + expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1386,7 +1424,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultAddKeysAttemptIsSuccessful" enum="Boolean" - expires_after="2021-11-01"> + expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1397,7 +1435,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultDeviceRegistrationState" - enum="TrustedVaultDeviceRegistrationState" expires_after="2021-11-01"> + enum="TrustedVaultDeviceRegistrationState" expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1409,7 +1447,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultErrorShownOnStartup" enum="Boolean" - expires_after="2021-11-01"> + expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1421,7 +1459,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultFetchedKeysCount" units="keys" - expires_after="2021-11-01"> + expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1431,7 +1469,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultFetchKeysAttempt" - enum="TrustedVaultFetchKeysAttempt" expires_after="2021-11-01"> + enum="TrustedVaultFetchKeysAttempt" expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1439,7 +1477,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultKeyRetrievalTrigger" - enum="TrustedVaultUserActionTrigger" expires_after="2021-11-01"> + enum="TrustedVaultUserActionTrigger" expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1451,7 +1489,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultRecoverabilityDegradedFixTrigger" - enum="TrustedVaultUserActionTrigger" expires_after="2021-11-01"> + enum="TrustedVaultUserActionTrigger" expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1463,7 +1501,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultRecoverabilityDegradedOnStartup" - enum="Boolean" expires_after="2021-11-01"> + enum="Boolean" expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1476,7 +1514,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TrustedVaultURLFetchResponse" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-11-01"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-05-01"> <owner>mmoskvitin@google.com</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1488,7 +1526,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Sync.TypedURLDatabaseError" enum="SyncTypedUrlDatabaseError" - expires_after="2021-12-20"> + expires_after="2022-04-10"> <owner>jkrcal@chromium.org</owner> <owner>mastiz@chromium.org</owner> <component>Services>Sync</component> @@ -1500,7 +1538,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram base="true" name="Sync.UndecryptedEntitiesOnDataTypeDisabled" - units="sync entities" expires_after="2021-12-12"> + units="sync entities" expires_after="2022-04-17"> <owner>victorvianna@google.com</owner> <owner>treib@chromium.org</owner> <component>Services>Sync</component> diff --git a/chromium/tools/metrics/histograms/metadata/tab/histograms.xml b/chromium/tools/metrics/histograms/metadata/tab/histograms.xml index 6056735abe4..40acf709734 100644 --- a/chromium/tools/metrics/histograms/metadata/tab/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/tab/histograms.xml @@ -111,34 +111,40 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Tab.Count.Guest" units="units" expires_after="2022-02-06"> +<histogram name="Tab.Count.Guest" units="units" expires_after="2022-04-17"> <owner>rhalavati@chromium.org</owner> - <owner>chrome-privacy-core@google.com</owner> + <owner>chrome-incognito@google.com</owner> <summary> Number of open tabs in each guest window. Recorded once a new tab in a guest window is opened and adds one to the bucket of number of tabs in that particular window (it does not count the total number of tabs in all open guest windows). Please note that this metric double counts the lower numbers, meaning that if user opens three tabs (without closing any in - between), then buckets 1, 2, and 3 will all be incremented in turn. + between), then buckets 1, 2, and 3 will all be incremented in turn. The + metric also overcounts the tabs that are moved from one window to another as + they are recorded both when they are created in the first window and when + they are added to the second window. </summary> </histogram> -<histogram name="Tab.Count.Incognito" units="units" expires_after="2022-02-06"> +<histogram name="Tab.Count.Incognito" units="units" expires_after="2022-04-10"> <owner>rhalavati@chromium.org</owner> - <owner>chrome-privacy-core@google.com</owner> + <owner>chrome-incognito@google.com</owner> <summary> Number of open tabs in each incognito window. Recorded once a new tab is opened in an incognito window and adds one to the bucket of number of tabs in that particular window (it does not count the total number of tabs in all open incognito windows). Please note that this metric double counts the lower numbers, meaning that if user opens three tabs (without closing any in - between), then buckets 1, 2, and 3 will all be incremented in turn. + between), then buckets 1, 2, and 3 will all be incremented in turn. The + metric also overcounts the tabs that are moved from one window to another as + they are recorded both when they are created in the first window and when + they are added to the second window. </summary> </histogram> <histogram name="Tab.ExternalApplicationOpened" enum="ExternalLauncherOption" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>mrefaat@chromium.org</owner> <owner>bling-team@google.com</owner> <summary> @@ -160,7 +166,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Tab.NewTab" enum="NewTabType" expires_after="2022-01-23"> +<histogram name="Tab.NewTab" enum="NewTabType" expires_after="2022-04-03"> <owner>tbergquist@chromium.org</owner> <owner>bsep@chromium.org</owner> <summary> @@ -280,7 +286,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tab.Preview.TimeToFirstUsableFrameAfterStartCapture" - units="ms" expires_after="2021-12-12"> + units="ms" expires_after="2022-02-13"> <owner>dfried@chromium.org</owner> <owner>collinbaker@chromium.org</owner> <summary> @@ -290,7 +296,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tab.Preview.TimeToNotifyObserversAfterCaptureReceived" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-02-13"> <owner>dfried@chromium.org</owner> <owner>collinbaker@chromium.org</owner> <summary> @@ -304,7 +310,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tab.Preview.TimeToStoreAfterFrameReceived" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-02-13"> <owner>dfried@chromium.org</owner> <owner>collinbaker@chromium.org</owner> <summary> @@ -316,7 +322,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tab.Preview.TimeToStoreAfterTabSwitch" units="ms" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>dfried@chromium.org</owner> <owner>collinbaker@chromium.org</owner> <summary> @@ -456,7 +462,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tab.Screenshot.Action" enum="TabScreenshotAction" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>skare@chromium.org</owner> <summary> Records actions taken after one or more screenshots of a page were taken. @@ -468,7 +474,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tab.Screenshot.ScreenshotsPerPage" units="screenshots" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>skare@chromium.org</owner> <summary> Records the number of screenshots taken of a specific page. It is recorded @@ -478,7 +484,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tab.StateAtRendererTermination" enum="TabForegroundState" - expires_after="2022-01-09"> + expires_after="2022-04-03"> <owner>gambard@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> <summary> @@ -615,7 +621,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabGroups.CollapsedGroupCountPerLoad" units="groups" - expires_after="2022-01-16"> + expires_after="2022-04-03"> <owner>cyan@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -645,7 +651,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabGroups.SessionsPerGroup" units="sessions" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>yusufo@chromium.org</owner> <owner>wychen@chromium.org</owner> <summary> @@ -703,7 +709,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabGroups.UserCustomizedGroupCountPerLoad" units="groups" - expires_after="2022-01-16"> + expires_after="2022-04-17"> <owner>connily@chromium.org</owner> <owner>cyan@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> @@ -714,7 +720,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabGroups.UserGroupCount" units="groups" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yusufo@chromium.org</owner> <owner>wychen@chromium.org</owner> <summary> @@ -724,7 +730,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabGroups.UserGroupCountPerLoad" units="groups" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>connily@chromium.org</owner> <owner>cyan@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> @@ -735,7 +741,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabGroups.UserNamedGroupCount" units="groups" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>yusufo@chromium.org</owner> <owner>wychen@chromium.org</owner> <summary> @@ -1006,8 +1012,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabManager.Discarding.DiscardCount" units="Discards" - expires_after="M100"> - <owner>sebmarchand@chromium.org</owner> + expires_after="2022-04-17"> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Cumulative number of tabs discarded due to low memory conditions, recorded @@ -1045,8 +1051,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabManager.Discarding.DiscardToReloadTime" units="ms" - expires_after="M100"> - <owner>sebmarchand@chromium.org</owner> + expires_after="2022-05-01"> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Elapsed time between a tab getting discarded to eventually being reloaded by @@ -1056,7 +1062,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="TabManager.Discarding.InactiveToReloadTime" units="ms" expires_after="M100"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Elapsed time between the time a tab switched from being active to inactive @@ -1065,8 +1071,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabManager.Discarding.ReloadCount" units="Reloads" - expires_after="M100"> - <owner>sebmarchand@chromium.org</owner> + expires_after="2022-04-17"> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Cumulative number of discarded tabs that have been reloaded by the user, @@ -1078,7 +1084,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="TabManager.Discarding.ReloadToCloseTime" units="ms" expires_after="M100"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Elapsed time between the last time a discarded tab was reloaded and the time @@ -1458,7 +1464,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Tabs.CountAtStartup" units="tabs" expires_after="2021-12-12"> +<histogram name="Tabs.CountAtStartup" units="tabs" expires_after="2022-04-24"> <owner>marq@chromium.org</owner> <summary>[Android and iOS] The number of tabs open at cold launch.</summary> </histogram> @@ -1554,11 +1560,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Tabs.LiveNTPCountAtResume" units="tabs" + expires_after="2022-04-10"> + <owner>thegreenfrog@chromium.org</owner> + <owner>bling-team@google.com</owner> + <summary> + [iOS] The number of live allocated NTP tabs when the app comes out of a + background state. A live NTP is one whose UI classes are initialized. + </summary> +</histogram> + <histogram name="Tabs.MaxTabsInADay{BatteryState}" units="tabs" expires_after="never"> <!-- expires-never: https://crbug.com/966137 --> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The maximum number of tabs that Chrome displays at the same time over the @@ -1575,7 +1592,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="never"> <!-- expires-never: https://crbug.com/966137 --> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The maximum number of tabs per window that Chrome displays over the course @@ -1592,7 +1610,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="never"> <!-- expires-never: https://crbug.com/966137 --> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The maximum number of windows existing at the same time over the course of a @@ -1605,7 +1624,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="BatteryState" variants="BatteryState"/> </histogram> -<histogram name="Tabs.NTPCountAtResume" units="tabs" expires_after="2021-12-12"> +<histogram name="Tabs.NTPCountAtResume" units="tabs" expires_after="2022-04-10"> <owner>gogerald@chromium.org</owner> <owner>nasims@google.com</owner> <summary> @@ -1614,7 +1633,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.NTPCountAtStartup" units="tabs" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>gogerald@chromium.org</owner> <owner>nasims@google.com</owner> <summary>[iOS] The number of NTP tabs open at cold launch.</summary> @@ -1624,7 +1643,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="never"> <!-- expires-never: https://crbug.com/966137 --> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of tabs total at resume from sleep/hibernate. This is being @@ -1634,7 +1654,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.PersistedTabData.Deserialize.Critical" - enum="BooleanSuccess" expires_after="2022-02-07"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -1660,7 +1680,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.PersistedTabData.Storage.Delete.File" - enum="BooleanSuccess" expires_after="2022-02-07"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -1673,7 +1693,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.PersistedTabData.Storage.Exists.File" - enum="BooleanSuccess" expires_after="2022-02-07"> + enum="BooleanSuccess" expires_after="2022-05-01"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -1701,7 +1721,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.PersistedTabData.Storage.LoadTime.File" units="ms" - expires_after="2022-01-13"> + expires_after="2022-03-20"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -1741,7 +1761,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Tabs.PersistedTabData.Storage.Save.File.FirstStorageRequestType" - enum="FileStorageRequestType" expires_after="2022-03-01"> + enum="FileStorageRequestType" expires_after="2022-05-01"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -1754,7 +1774,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.PersistedTabData.Storage.SaveTime.File" units="ms" - expires_after="2022-01-13"> + expires_after="2022-03-20"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -1767,7 +1787,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.SadTab.CrashCreated" units="tabs" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>sonnyrao@chromium.org</owner> <owner>jamescook@chromium.org</owner> <summary> @@ -1781,7 +1801,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.SadTab.CrashDisplayed" units="tabs" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>sonnyrao@chromium.org</owner> <owner>jamescook@chromium.org</owner> <summary> @@ -1794,7 +1814,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.SadTab.Feedback.Event" enum="SadTabEvent" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>sonnyrao@chromium.org</owner> <owner>jamescook@chromium.org</owner> <summary> @@ -1821,7 +1841,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.SadTab.KillCreated.OOM" units="tabs" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>sonnyrao@chromium.org</owner> <owner>jamescook@chromium.org</owner> <summary> @@ -1836,7 +1856,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.SadTab.KillDisplayed" units="tabs" - expires_after="2021-12-05"> + expires_after="2022-04-24"> <owner>sonnyrao@chromium.org</owner> <owner>jamescook@chromium.org</owner> <summary> @@ -1888,7 +1908,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.SadTab.Reload.Event" enum="SadTabEvent" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>sonnyrao@chromium.org</owner> <owner>jamescook@chromium.org</owner> <summary> @@ -1933,7 +1953,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.ScrubbedInInterval.KeyPress" units="tabs" - expires_after="2021-10-01"> + expires_after="2022-02-13"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -1945,7 +1965,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.ScrubbedInInterval.MousePress" units="tabs" - expires_after="2021-10-01"> + expires_after="2022-04-24"> <owner>corising@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -1975,7 +1995,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.ShoppingPersistedTabData.FoundBuyableProductAnnotation" - enum="FoundBuyableProductAnnotation" expires_after="2022-02-06"> + enum="FoundBuyableProductAnnotation" expires_after="2022-04-10"> <owner>yusufo@chromium.org</owner> <owner>ayman@chromium.org</owner> <owner>davidjm@chromium.org</owner> @@ -2133,7 +2153,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabCountInGroupPerLoad" units="tabs" - expires_after="2021-09-19"> + expires_after="2022-03-19"> <owner>connily@chromium.org</owner> <owner>cyan@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> @@ -2197,7 +2217,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> -<histogram name="Tabs.TabCountPerLoad" units="tabs" expires_after="2021-12-05"> +<histogram name="Tabs.TabCountPerLoad" units="tabs" expires_after="2022-04-10"> <owner>mpearson@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <owner>sbirch@google.com</owner> @@ -2213,7 +2233,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabCountPerWindow" units="tabs" - expires_after="2021-12-05"> + expires_after="2022-04-10"> <owner>mpearson@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -2229,7 +2249,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="never"> <!-- expires-never: https://crbug.com/966137 --> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Counts the number of tabs across all windows, reported every 5 minutes. @@ -2271,7 +2292,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.CloseAction" enum="TabSearchCloseActions" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary> @@ -2287,7 +2308,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.NumTabsClosedPerInstance" units="tabs" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary> @@ -2300,7 +2321,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.NumTabsOnOpen" units="tabs" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary> @@ -2311,7 +2332,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.NumWindowsOnOpen" units="windows" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary> @@ -2338,7 +2359,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.PageHandlerConstructionDelay" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <owner>yuhengh@chromium.org</owner> @@ -2356,6 +2377,40 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Tabs.TabSearch.RecentlyClosedSectionToggleAction" + enum="TabSearchRecentlyClosedToggleActions" expires_after="2022-01-23"> + <owner>romanarora@chromium.org</owner> + <owner>robliao@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>yuhengh@chromium.org</owner> + <summary> + Tab Search is a feature that allows users to better search for and switch to + their desired tabs. The Tab Search UI displays both open and recently closed + tabs under different list sections. The recently closed section can be + expanded or collapsed by the user by clicking a button. + + This metric tracks the recently closed section being expandeded or collapsed + via the toggle button. + </summary> +</histogram> + +<histogram name="Tabs.TabSearch.RecentlyClosedSectionToggleStateOnOpen" + enum="TabSearchRecentlyClosedToggleActions" expires_after="2022-01-23"> + <owner>romanarora@chromium.org</owner> + <owner>robliao@chromium.org</owner> + <owner>tluk@chromium.org</owner> + <owner>yuhengh@chromium.org</owner> + <summary> + Tab Search is a feature that allows users to better search for and switch to + their desired tabs. The Tab Search UI displays both open and recently closed + tabs under different list sections. The recently closed section can be + expanded or collapsed by the user by clicking a button. + + This metric tracks if the recently closed section is in an expanded or + collapsed state at the time of opening the Tab Search dialog. + </summary> +</histogram> + <histogram name="Tabs.TabSearch.WebUI.IndexOf{Action}TabIn{State}List" units="tabs" expires_after="2021-11-21"> <owner>tluk@chromium.org</owner> @@ -2394,7 +2449,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.WebUI.LoadCompletedTime" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary> @@ -2405,7 +2460,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.WebUI.LoadDocumentTime" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary> @@ -2431,7 +2486,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.WebUI.TabListDataReceived" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <owner>yuhengh@chromium.org</owner> @@ -2481,7 +2536,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.WindowDisplayedDuration3" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <summary> @@ -2504,7 +2559,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.WindowTimeToShowCachedWebView" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <owner>yuhengh@chromium.org</owner> @@ -2523,7 +2578,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Tabs.TabSearch.WindowTimeToShowUncachedWebView" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>tluk@chromium.org</owner> <owner>robliao@chromium.org</owner> <owner>yuhengh@chromium.org</owner> @@ -2548,7 +2603,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Tabs.TabState.LoadTime" units="ms" expires_after="2022-01-13"> +<histogram name="Tabs.TabState.LoadTime" units="ms" expires_after="2022-05-01"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -2558,7 +2613,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Tabs.TabState.SaveTime" units="ms" expires_after="2022-01-13"> +<histogram name="Tabs.TabState.SaveTime" units="ms" expires_after="2022-03-20"> <owner>yusufo@chromium.org</owner> <owner>nyquist@chromium.org</owner> <owner>dtrainor@chromium.org</owner> @@ -2743,7 +2798,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Tabs.UnusedAndClosedInInterval.Count{Tabs_TabUsageIntervalLength}" units="tabs" expires_after="M95"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of tabs that haven't been interacted with, visible or audible @@ -2762,7 +2818,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Tabs.UnusedInInterval.Count{Tabs_TabUsageIntervalLength}" units="tabs" expires_after="M95"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of tabs that haven't been interacted with, visible or audible or @@ -2782,7 +2839,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Tabs.UsedAndClosedInInterval.Count{Tabs_TabUsageIntervalLength}" units="tabs" expires_after="M95"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of tabs that have been interacted with, visible or audible over a @@ -2801,7 +2859,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Tabs.UsedInInterval.Count{Tabs_TabUsageIntervalLength}" units="tabs" expires_after="M95"> - <owner>sebmarchand@chromium.org</owner> + <owner>chrisha@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> The number of tabs that have been interacted with, visible or audible during @@ -2822,7 +2881,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. expires_after="never"> <!-- expires-never: https://crbug.com/966137 --> - <owner>sebmarchand@chromium.org</owner> + <owner>fdoray@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> Counts the number of Chrome windows, reported every 5 minutes. Desktop only. @@ -2830,7 +2889,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <token key="BatteryState" variants="BatteryState"/> </histogram> -<histogram name="Tabs.WindowWidth" units="DIPs" expires_after="2021-12-26"> +<histogram name="Tabs.WindowWidth" units="DIPs" expires_after="2022-04-17"> <owner>collinbaker@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -2898,7 +2957,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabStrip.TabCountOnPageLoad" units="tabs" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>yusufo@chromium.org</owner> <owner>wychen@chromium.org</owner> <summary> @@ -2910,7 +2969,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabStrip.TimeToCreateNewTabFromPress" units="ms" - expires_after="2021-11-14"> + expires_after="2022-05-01"> <owner>robliao@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> <summary> @@ -2919,7 +2978,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="TabStrip.TimeToSwitch" units="ms" expires_after="2022-01-16"> +<histogram name="TabStrip.TimeToSwitch" units="ms" expires_after="2022-03-20"> <owner>connily@chromium.org</owner> <owner>cyan@chromium.org</owner> <owner>chrome-desktop-ui-sea@google.com</owner> @@ -2935,7 +2994,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TabStrip.UserStatus" enum="TabStripUserStatus" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>yusufo@chromium.org</owner> <owner>wychen@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/translate/histograms.xml b/chromium/tools/metrics/histograms/metadata/translate/histograms.xml index 9aa4565ff4b..a2228a318d9 100644 --- a/chromium/tools/metrics/histograms/metadata/translate/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/translate/histograms.xml @@ -32,7 +32,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.AlwaysTranslateLang" units="units" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ApplicationStart.AlwaysTranslateLanguage" - enum="LocaleCodeISO639" expires_after="M98"> + enum="LocaleCodeISO639" expires_after="2022-04-24"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -70,7 +70,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ApplicationStart.NeverTranslateLanguage" - enum="LocaleCodeISO639" expires_after="M98"> + enum="LocaleCodeISO639" expires_after="2022-04-17"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -85,7 +85,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ApplicationStart.NeverTranslateLanguage.Count" - units="languages" expires_after="M98"> + units="languages" expires_after="2022-04-10"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -98,7 +98,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ApplicationStart.NeverTranslateSite.Count" - units="sites" expires_after="M98"> + units="sites" expires_after="2022-04-10"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -111,13 +111,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.BubbleUiEvent" enum="TranslateBubbleUiEvent" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>groby@google.com</owner> <owner>chrome-language@google.com</owner> <summary>Tracks UI events related to the translate bubble.</summary> </histogram> -<histogram name="Translate.CaptureText" units="ms" expires_after="M99"> +<histogram name="Translate.CaptureText" units="ms" expires_after="2022-04-17"> <owner>sclittle@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -130,7 +130,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.CLD3.LanguageDetected" enum="LocaleCodeISO639" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -161,14 +161,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.CompactInfobar.Event" enum="TranslateCompactUIEvent" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary>Various user actions performed in the translate infobar.</summary> </histogram> <histogram name="Translate.CompactInfobar.Language.AlwaysTranslate" - enum="LocaleCodeISO639" expires_after="2021-12-12"> + enum="LocaleCodeISO639" expires_after="2022-04-24"> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -178,7 +178,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.CompactInfobar.Language.MoreLanguages" - enum="LocaleCodeISO639" expires_after="2021-12-12"> + enum="LocaleCodeISO639" expires_after="2022-04-24"> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -187,7 +187,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.CompactInfobar.Language.NeverTranslate" - enum="LocaleCodeISO639" expires_after="2021-12-12"> + enum="LocaleCodeISO639" expires_after="2022-04-03"> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -197,7 +197,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.CompactInfobar.Language.PageNotIn" - enum="LocaleCodeISO639" expires_after="2021-12-12"> + enum="LocaleCodeISO639" expires_after="2022-04-03"> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -217,6 +217,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Translate.CompactInfobar.TranslationsPerPage" units="translations" expires_after="2021-10-10"> + <obsolete> + Removed M95. No longer used. + </obsolete> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -250,7 +253,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.DeclineTranslate" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -287,7 +290,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ExplicitLanguageAsk.Event" - enum="TranslateExplicitAskPromptEventType" expires_after="2021-12-12"> + enum="TranslateExplicitAskPromptEventType" expires_after="2022-04-24"> <owner>yyushkina@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -297,7 +300,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ExplicitLanguageAsk.LanguageAdded" - enum="LocaleCodeISO639" expires_after="2021-12-12"> + enum="LocaleCodeISO639" expires_after="2022-04-24"> <owner>yyushkina@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -307,7 +310,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ExplicitLanguageAsk.LanguageRemoved" - enum="LocaleCodeISO639" expires_after="2021-12-12"> + enum="LocaleCodeISO639" expires_after="2022-04-24"> <owner>yyushkina@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -317,7 +320,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.HrefHint.PrefsFilterStatus" - enum="HrefTranslatePrefsFilterStatus" expires_after="2021-11-14"> + enum="HrefTranslatePrefsFilterStatus" expires_after="2022-05-14"> <owner>sclittle@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -332,7 +335,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.HrefHint.Status" enum="HrefTranslateStatus" - expires_after="2021-11-14"> + expires_after="2022-05-14"> + <owner>sclittle@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -368,7 +372,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.InitiationStatus.v2" - enum="TranslateInitiationStatus" expires_after="2021-12-12"> + enum="TranslateInitiationStatus" expires_after="2022-04-17"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -379,7 +383,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.LanguageDetection.ContentLength" units="characters" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>sclittle@chromium.org</owner> <owner>megjablon@chromium.org</owner> <owner>chrome-language@google.com</owner> @@ -422,7 +426,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.LanguageDeterminedDuration" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>sclittle@chromium.org</owner> <owner>megjablon@chromium.org</owner> <owner>chrome-language@google.com</owner> @@ -488,7 +492,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.MenuTranslation.IsAvailable" enum="BooleanAvailable" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>cuianthony@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -498,7 +502,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.MenuTranslation.UnavailableReasons" - enum="MenuTranslationUnavailableReason" expires_after="2022-01-09"> + enum="MenuTranslationUnavailableReason" expires_after="2022-04-03"> <owner>cuianthony@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -525,7 +529,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ModifyOriginalLang" units="units" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -535,7 +539,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ModifyTargetLang" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-10"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -545,7 +549,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.NeverTranslateLang" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -565,7 +569,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.AutofillAssistantDeferredTriggerDecision" - enum="BooleanDeferred" expires_after="M105"> + enum="BooleanDeferred" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -578,7 +582,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.FinalSourceLanguage" - enum="LocaleCodeISO639" expires_after="2021-12-12"> + enum="LocaleCodeISO639" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -592,7 +596,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.FinalState" enum="TranslateState" - expires_after="2021-12-12"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -606,7 +610,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.FinalTargetLanguage" - enum="LocaleCodeISO639" expires_after="2021-10-10"> + enum="LocaleCodeISO639" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -620,7 +624,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.HrefHint.TriggerDecision" - enum="TranslateTriggerDecision" expires_after="M105"> + enum="TranslateTriggerDecision" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -633,7 +637,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.InitialSourceLanguage" - enum="LocaleCodeISO639" expires_after="M105"> + enum="LocaleCodeISO639" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -647,7 +651,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.InitialState" enum="TranslateState" - expires_after="2021-12-12"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -661,7 +665,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.InitialTargetLanguage" - enum="LocaleCodeISO639" expires_after="2021-12-19"> + enum="LocaleCodeISO639" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -675,7 +679,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.InitialTargetLanguage.Origin" - enum="TranslateTargetLanguageOrigin" expires_after="M95"> + enum="TranslateTargetLanguageOrigin" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -690,7 +694,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Translate.PageLoad.IsInitialSourceLanguageInUsersContentLanguages" - enum="Boolean" expires_after="2021-10-31"> + enum="Boolean" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -705,7 +709,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.NumReversions" units="reversions" - expires_after="2021-12-12"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -718,7 +722,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.NumTargetLanguageChanges" - units="target language changes" expires_after="2021-12-12"> + units="target language changes" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -731,7 +735,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.NumTranslations" units="translations" - expires_after="2021-12-12"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -743,7 +747,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.Ranker.Decision" - enum="TranslateRankerDecision" expires_after="2021-12-12"> + enum="TranslateRankerDecision" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -756,7 +760,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.Ranker.Timer.ShouldOfferTranslation" - units="ms" expires_after="M95"> + units="ms" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -770,7 +774,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.Ranker.Version" units="version" - expires_after="2021-12-12"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -782,7 +786,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.PageLoad.TriggerDecision" - enum="TranslateTriggerDecision" expires_after="2021-12-12"> + enum="TranslateTriggerDecision" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -819,8 +823,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. units="trigger decisions" expires_after="M92"> <obsolete> Removed M92. This histogram was used to estimate the impact of masking on - Translate.PageLoad.TriggerDecision. We found that masking w as having - minimal impact, so this histogram is no longer needed. + Translate.PageLoad.TriggerDecision. We found that masking was having minimal + impact, so this histogram is no longer needed. </obsolete> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> @@ -953,7 +957,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.RevertTranslation" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -963,7 +967,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.ShowErrorUI" enum="TranslateError" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -988,7 +992,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.SourceLanguage" enum="LocaleCodeISO639" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>yyushkina@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -998,7 +1002,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.TargetLanguage" enum="LocaleCodeISO639" - expires_after="2021-12-12"> + expires_after="2022-04-03"> <owner>yyushkina@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -1008,7 +1012,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.TargetLanguage.Origin" - enum="TranslateTargetLanguageOrigin" expires_after="2021-12-12"> + enum="TranslateTargetLanguageOrigin" expires_after="2022-04-17"> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -1052,7 +1056,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translate" enum="BooleanTranslate" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -1062,7 +1066,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translate.AMPCacheURL" enum="BooleanTranslate" - expires_after="2021-10-10"> + expires_after="2022-04-10"> <owner>sclittle@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1073,7 +1077,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.TranslateAssistContentResult" - enum="TranslateAssistContentResult" expires_after="2021-10-25"> + enum="TranslateAssistContentResult" expires_after="2022-06-12"> <owner>jds@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -1107,7 +1111,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.TranslateSubframe.SuccessPercentage" units="%" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>sclittle@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1131,7 +1135,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.LanguageDetection.ContentLength" - units="characters" expires_after="2021-12-12"> + units="characters" expires_after="2022-06-30"> <owner>megjablon@chromium.org</owner> <owner>chrome-language@google.com</owner> <summary> @@ -1142,7 +1146,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.SourceLanguage" enum="LocaleCodeISO639" - expires_after="M98"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1155,7 +1159,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.Status" enum="TranslationStatus" - expires_after="2022-02-06"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1175,7 +1179,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.TargetLanguage" enum="LocaleCodeISO639" - expires_after="M98"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1188,7 +1192,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.TargetLanguage.Origin" - enum="TranslateTargetLanguageOrigin" expires_after="M95"> + enum="TranslateTargetLanguageOrigin" expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1200,7 +1204,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.TimeToBeReady" units="ms" - expires_after="M106"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1213,7 +1217,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.TimeToLoad" units="ms" - expires_after="M106"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1226,7 +1230,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.TimeToTranslate" units="ms" - expires_after="M106"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1239,7 +1243,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.Translation.Type" enum="TranslationType" - expires_after="M98"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1253,7 +1257,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.UiInteraction.Event" enum="TranslateUIInteraction" - expires_after="M95"> + expires_after="2022-06-30"> <owner>curranmax@google.com</owner> <owner>megjablon@google.com</owner> <owner>chrome-language@google.com</owner> @@ -1296,7 +1300,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Translate.UserActionDuration" units="ms" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>kenjibaheux@google.com</owner> <owner>chrome-language@google.com</owner> <summary> @@ -1307,7 +1311,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="TranslateModelService.LanguageDetectionModel.PendingRequestCallbacks" - units="requests" expires_after="M98"> + units="requests" expires_after="2022-04-03"> <owner>mcrouse@chromium.org</owner> <owner>chrome-language@chromium.org</owner> <summary> @@ -1318,7 +1322,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="TranslateModelService.LanguageDetectionModel.WasLoaded" - enum="BooleanLoaded" expires_after="M98"> + enum="BooleanLoaded" expires_after="2022-04-10"> <owner>mcrouse@chromium.org</owner> <owner>chrome-language@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/ukm/histograms.xml b/chromium/tools/metrics/histograms/metadata/ukm/histograms.xml index 455b86366d1..f35fcedaa8e 100644 --- a/chromium/tools/metrics/histograms/metadata/ukm/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/ukm/histograms.xml @@ -70,7 +70,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.Entries.Dropped" enum="UkmDataDroppedReason" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -80,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.Entries.Dropped.ByEntryHash" enum="UkmEventNameHash" - expires_after="2021-11-14"> + expires_after="2022-04-17"> <owner>jwd@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -92,7 +92,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.Entries.Recorded.ByEntryHash" enum="UkmEventNameHash" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>yrsun@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -104,7 +104,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.Entries.SerializedCount2" units="entries" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary>Number of serialized UKM entries when storing a UKM log.</summary> @@ -135,7 +135,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.IOSLog.OnSuccess" units="records" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>rkaplow@chromium.org</owner> <summary> Number of times when UKM.LogSize.OnSuccess was recorded on iOS. Recorded @@ -151,7 +151,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="UKM.LogSize.OnSuccess" units="KB" expires_after="2021-12-19"> +<histogram name="UKM.LogSize.OnSuccess" units="KB" expires_after="2022-04-24"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -174,7 +174,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.LogUpload.ResponseOrErrorCode" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-12-26"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-05-01"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -225,7 +225,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.ResetReason" enum="UkmResetReason" - expires_after="2022-01-09"> + expires_after="2022-04-24"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -235,7 +235,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.Sources.Dropped" enum="UkmDataDroppedReason" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -245,7 +245,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.Sources.KeptSourcesCount" units="sources" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -284,7 +284,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.Sources.UnsentSourcesCount" units="sources" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -294,7 +294,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.UnsentLogs.DroppedSize" units="bytes" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> @@ -304,7 +304,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UKM.UnsentLogs.NumDropped" units="units" - expires_after="2021-12-19"> + expires_after="2022-05-01"> <owner>rkaplow@chromium.org</owner> <owner>ukm-team@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/uma/histograms.xml b/chromium/tools/metrics/histograms/metadata/uma/histograms.xml index a27cccca23b..90e438eb8e6 100644 --- a/chromium/tools/metrics/histograms/metadata/uma/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/uma/histograms.xml @@ -144,7 +144,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.ActualLogUploadInterval" units="minutes" - expires_after="2021-12-26"> + expires_after="2022-04-03"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -184,7 +184,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.CleanExitBeaconConsistency2" - enum="UmaCleanExitConsistency2" expires_after="2022-01-18"> + enum="UmaCleanExitConsistency2" expires_after="2022-04-17"> <owner>asvitkine@chromium.org</owner> <owner>justincohen@chromium.org</owner> <owner>olivierrobin@chromium.org</owner> @@ -226,6 +226,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>The source of the client id when its creation is forced.</summary> </histogram> +<histogram name="UMA.DataValidation.LogNormal" units="random values" + expires_after="2021-11-14"> + <owner>sweilun@chromium.org</owner> + <owner>src/base/metrics/OWNERS</owner> + <summary> + This is logged with a random value drawn from an artificial log normal + distribution in every ongoing metrics logs (not logs about the previous + session) and used for data validation. The mean and standard deviation + parameters of the log normal distribution are controlled by artificial A/B + experiments so that we can assess the accuracy and power of data from field + trials. + </summary> +</histogram> + <histogram name="UMA.EnrollmentStatus" enum="EnrollmentStatus" expires_after="never"> <!-- expires-never: used internally for filtering --> @@ -240,7 +254,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.EntropySourceType" enum="UmaEntropySourceType" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -284,6 +298,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="UMA.FileMetricsProvider.MergeHistogram.{Type}" enum="HistogramNameHash" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -297,7 +314,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.InitSequence" enum="UmaInitSequence" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -310,7 +327,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.IsClonedInstall" enum="BooleanCloned" - expires_after="2021-11-14"> + expires_after="2022-04-17"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -390,7 +407,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="UMA.LogSize.OnSuccess" units="KB" expires_after="2021-12-26"> +<histogram name="UMA.LogSize.OnSuccess" units="KB" expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -403,7 +420,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.LogUpload.Canceled.CellularConstraint" - enum="BooleanCanceled" expires_after="2022-01-16"> + enum="BooleanCanceled" expires_after="2022-03-20"> <owner>holte@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -414,7 +431,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.LogUpload.ResponseOrErrorCode" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-12-26"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-05-01"> <owner>holte@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -436,7 +453,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.LowEntropySource3Value" units="units" - expires_after="2021-12-26"> + expires_after="2022-04-10"> <owner>asvitkine@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -448,7 +465,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.LowEntropySourceValue" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>asvitkine@chromium.org</owner> <owner>mpearson@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -461,7 +478,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.MachineIdState" enum="UmaMachineIdState" - expires_after="2021-12-06"> + expires_after="2022-04-24"> <owner>jwd@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -473,7 +490,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.MetricsIDsReset" enum="BooleanHit" - expires_after="2021-12-06"> + expires_after="2022-04-17"> <owner>jwd@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -489,7 +506,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.MetricsReporting.Toggle" enum="MetricsReportingChange" - expires_after="2021-10-31"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -500,6 +517,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="UMA.MetricsService.Initialize" enum="Boolean" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -509,7 +529,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.MetricsService.Initialize.Time" units="microseconds" - expires_after="2021-10-31"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -521,7 +541,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.NegativeSamples.Histogram" enum="HistogramNameHash" - expires_after="2022-01-02"> + expires_after="2022-04-10"> <owner>asvitkine@chromium.org</owner> <owner>bcwhite@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -531,7 +551,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.NegativeSamples.Increment" units="increment" - expires_after="2021-10-31"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>bcwhite@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -541,7 +561,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.NegativeSamples.Reason" enum="NegativeSampleReason" - expires_after="2021-10-31"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>bcwhite@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -577,6 +597,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="UMA.PersistentHistograms.DriveType" enum="WindowsDriveType" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -588,6 +611,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="UMA.PersistentHistograms.HistogramsInStartupFile" enum="HistogramNameHash" expires_after="2021-10-31"> + <obsolete> + Removed 2021/09 + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>chrome-metrics-team@google.com</owner> <summary> @@ -599,7 +625,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.PersistentHistograms.InitResult" - enum="PersistentHistogramsInitResult" expires_after="2022-01-02"> + enum="PersistentHistogramsInitResult" expires_after="2022-03-06"> <owner>bcwhite@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -609,7 +635,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.PrimaryUserType" enum="UserType" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>michaelpg@chromium.org</owner> <owner>yilkal@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -618,7 +644,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="UMA.ProfileSignInStatus" enum="ProfileSigninStatus" +<histogram name="UMA.ProfileSignInStatus" enum="ProfileSyncStatus" expires_after="never"> <!-- expires-never: For the signin_status filter in dynamic table. --> @@ -626,7 +652,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <owner>isherman@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> - An enum representing the signin status of all opened profiles during one UMA + WARNING: despite the name, this histogram is about *sync*, not sign-in. + + An enum representing the sync status of all opened profiles during one UMA session. Reported incorrect data on ChromeOS before M80. @@ -634,7 +662,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.ProtoCompressionRatio" units="%" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -644,8 +672,29 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="UMA.Pseudo.{Metrics}" units="seconds/MB" + expires_after="2021-11-14"> + <owner>sweilun@chromium.org</owner> + <owner>src/base/metrics/OWNERS</owner> + <summary> + This is the pseudo {Metrics} metric. It's logged alongside with the real + metric. The value of this pseudo metric is a linear function (ax + b) of the + real value (x). The multiplicative factor (a) and additive factor (b) are + controlled by field trial experiments. This metric is used for data + validation and to help us better assess the accuracy and power of data from + field trials. + </summary> + <token key="Metrics"> + <variant name="Memory.Browser.MemoryFootprint"/> + <variant name="Memory.Total.PrivateMemoryFootprint"/> + <variant name="PageLoad.InteractiveTiming.FirstInputDelay4"/> + <variant name="PageLoad.LayoutInstability.CumulativeShiftScore"/> + <variant name="PageLoad.PaintTiming.NavigationToLargestContentfulPaint2"/> + </token> +</histogram> + <histogram name="UMA.ReadAndTruncateMetricsFromFile.DiscardedCount" - units="samples" expires_after="2021-12-26"> + units="samples" expires_after="2022-04-17"> <owner>iby@chromium.org</owner> <owner>cros-telemetry@google.com</owner> <summary> @@ -660,7 +709,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.ReadAndTruncateMetricsFromFile.ReadCount" units="samples" - expires_after="2021-12-26"> + expires_after="2022-04-17"> <owner>iby@chromium.org</owner> <owner>cros-telemetry@google.com</owner> <summary> @@ -676,7 +725,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.SamplingRatePerMille" units="samples per mille" - expires_after="2022-01-02"> + expires_after="2022-05-01"> <owner>jwd@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -703,8 +752,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="UMA.StructuredMetrics.ClientInitializationSuccessful" + enum="BooleanSuccess" expires_after="M97"> + <owner>jongahn@chromium.org</owner> + <owner>tby@chromium.org</owner> + <summary> + Emitted on initialization of structured metrics client. Records whether the + client was initialized successfully. + </summary> +</histogram> + <histogram name="UMA.StructuredMetrics.EventRecordingState" - enum="StructuredMetricsEventRecordingState" expires_after="2021-12-01"> + enum="StructuredMetricsEventRecordingState" expires_after="2022-04-24"> <owner>tby@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>asvitkine@chromium.org</owner> @@ -715,8 +774,18 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="UMA.StructuredMetrics.EventsRecordedUsingMojo" enum="Boolean" + expires_after="2022-03-27"> + <owner>jongahn@chromium.org</owner> + <owner>tby@chromium.org</owner> + <summary> + Emitted each time a structured metric event is written. Records true if the + mojo API was used. + </summary> +</histogram> + <histogram name="UMA.StructuredMetrics.InternalError" - enum="StructuredMetricsInternalError" expires_after="2021-12-01"> + enum="StructuredMetricsInternalError" expires_after="2022-02-27"> <owner>tby@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>asvitkine@chromium.org</owner> @@ -727,7 +796,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.StructuredMetrics.KeyValidationState" - enum="StructuredMetricsKeyValidationState" expires_after="2021-12-01"> + enum="StructuredMetricsKeyValidationState" expires_after="2022-04-24"> <owner>tby@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>asvitkine@chromium.org</owner> @@ -739,7 +808,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.StructuredMetrics.NumEventsInUpload" units="count" - expires_after="2022-01-30"> + expires_after="2022-04-24"> <owner>tby@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>asvitkine@chromium.org</owner> @@ -774,7 +843,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.TruncatedEvents.UserAction" units="events" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -784,7 +853,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.UnsentLogs.Dropped" units="units" - expires_after="2022-01-02"> + expires_after="2022-04-03"> <owner>holte@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -794,7 +863,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UMA.UnsentLogs.DroppedSize" units="bytes" - expires_after="2021-10-31"> + expires_after="2022-04-03"> <owner>akirabaruah@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>asvitkine@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/update_engine/histograms.xml b/chromium/tools/metrics/histograms/metadata/update_engine/histograms.xml index a61cb3a0114..bf48c2abbb4 100644 --- a/chromium/tools/metrics/histograms/metadata/update_engine/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/update_engine/histograms.xml @@ -38,7 +38,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.DownloadErrorCode" - enum="UpdateEngineDownloadErrorCode" expires_after="2021-12-29"> + enum="UpdateEngineDownloadErrorCode" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -53,7 +53,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.DownloadSource" - enum="UpdateEngineDownloadSource" expires_after="2021-12-29"> + enum="UpdateEngineDownloadSource" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -67,7 +67,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.DurationMinutes" units="minutes" - expires_after="2021-12-29"> + expires_after="2022-04-10"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -95,7 +95,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.InternalErrorCode" - enum="UpdateEngineErrorCode" expires_after="2021-12-29"> + enum="UpdateEngineErrorCode" expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -109,7 +109,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.Number" units="count" - expires_after="2021-12-29"> + expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -123,7 +123,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.PayloadBytesDownloadedMiB" units="MiB" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -136,7 +136,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.PayloadDownloadSpeedKBps" units="KBps" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -151,7 +151,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.PayloadSizeMiB" units="MiB" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -164,7 +164,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.PayloadType" - enum="UpdateEnginePayloadFormat" expires_after="2021-12-29"> + enum="UpdateEnginePayloadFormat" expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -180,7 +180,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.Result" enum="UpdateEngineAttemptResult" - expires_after="2021-12-29"> + expires_after="2022-04-10"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -193,7 +193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.TimeSinceLastAttemptMinutes" - units="minutes" expires_after="2021-12-29"> + units="minutes" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -208,7 +208,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Attempt.TimeSinceLastAttemptUptimeMinutes" - units="minutes" expires_after="2021-12-29"> + units="minutes" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -223,7 +223,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.CertificateCheck.Download" - enum="UpdateEngineCertificateCheckStatus" expires_after="2021-12-29"> + enum="UpdateEngineCertificateCheckStatus" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -238,7 +238,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.CertificateCheck.UpdateCheck" - enum="UpdateEngineCertificateCheckStatus" expires_after="2021-12-29"> + enum="UpdateEngineCertificateCheckStatus" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -267,7 +267,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Check.Reaction" enum="UpdateEngineCheckReaction" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -283,7 +283,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Check.Result" enum="UpdateEngineCheckResult" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -336,7 +336,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Check.TimeSinceLastCheckMinutes" units="minutes" - expires_after="2021-12-29"> + expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -350,7 +350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Check.TimeSinceLastCheckUptimeMinutes" - units="minutes" expires_after="2021-12-29"> + units="minutes" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -364,7 +364,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.ConsecutiveUpdate.Count" units="updates" - expires_after="2021-12-29"> + expires_after="2022-04-10"> <owner>vyshu@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -377,7 +377,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.ConsecutiveUpdate.Failed" enum="BooleanHit" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>vyshu@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -390,7 +390,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Daily.OSAgeDays" units="days" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -439,7 +439,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.FailedUpdateCount" units="count" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -454,7 +454,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.InstallDateProvisioningSource" - enum="UpdateEngineInstallDateProvisioningSource" expires_after="2021-12-29"> + enum="UpdateEngineInstallDateProvisioningSource" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -500,7 +500,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.KernelKey.MinVersion" units="units" - expires_after="2021-12-29"> + expires_after="2022-05-01"> <owner>poromov@chromium.org</owner> <summary> Minimum kernel key version already set in the TPM. This value specifies @@ -513,7 +513,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.Rollback.Result" enum="BooleanSuccess" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -526,7 +526,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.AttemptCount" units="count" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -539,7 +539,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.BytesDownloadedMiB" units="MiB" - expires_after="2021-12-29"> + expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -567,7 +567,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.BytesDownloadedMiBHttpServer" - units="MiB" expires_after="2021-12-29"> + units="MiB" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -581,7 +581,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.BytesDownloadedMiBHttpsServer" - units="MiB" expires_after="2021-12-29"> + units="MiB" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -595,7 +595,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.DownloadOverheadPercentage" - units="%" expires_after="2021-12-29"> + units="%" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -608,7 +608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.DownloadSourcesUsed" - enum="UpdateEngineDownloadSources" expires_after="2021-12-29"> + enum="UpdateEngineDownloadSources" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -651,7 +651,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.PayloadSizeMiB" units="MiB" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -664,7 +664,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.PayloadType" - enum="UpdateEnginePayloadFormat" expires_after="2021-12-29"> + enum="UpdateEnginePayloadFormat" expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -678,7 +678,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.RebootCount" units="count" - expires_after="2021-12-29"> + expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -691,7 +691,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.TotalDurationMinutes" - units="minutes" expires_after="2021-12-29"> + units="minutes" expires_after="2022-04-17"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -721,7 +721,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.UpdatesAbandonedCount" - units="count" expires_after="2021-12-29"> + units="count" expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> @@ -735,7 +735,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="UpdateEngine.SuccessfulUpdate.UrlSwitchCount" units="count" - expires_after="2021-12-29"> + expires_after="2022-04-24"> <owner>ahassani@chromium.org</owner> <owner>chromeos-core-services@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/v8/histograms.xml b/chromium/tools/metrics/histograms/metadata/v8/histograms.xml index bddf8d0fd0c..8790ce78795 100644 --- a/chromium/tools/metrics/histograms/metadata/v8/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/v8/histograms.xml @@ -40,6 +40,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary>Array buffer sizes for which V8 failed to allocate memory.</summary> </histogram> +<histogram name="V8.CagedMemoryAllocationOutcome" + enum="V8CagedMemoryAllocationOutcome" expires_after="2022-09-30"> + <owner>saelo@chromium.org</owner> + <owner>ishell@chromium.org</owner> + <summary> + The outcome of attempts to allocate memory pages inside the virtual memory + cage. Recorded at each allocation attempt, such as when allocating WASM + memory buffers, but only if the virtual memory cage is active. + </summary> +</histogram> + <histogram name="V8.CodeCacheRejectReason" enum="V8CodeCacheRejectReason" expires_after="M77"> <owner>yangguo@chromium.org</owner> @@ -48,7 +59,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.CodeCacheSizeRatio" units="%" expires_after="2021-12-05"> +<histogram name="V8.CodeCacheSizeRatio" units="%" expires_after="2022-05-01"> <owner>yangguo@chromium.org</owner> <summary>Cache size to source size ratio when caching compiled code.</summary> </histogram> @@ -82,7 +93,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileDeserializeMicroSeconds" units="microseconds" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>vogelheim@chromium.org</owner> <summary> Time spent deseriailzing code, used by V8 code caching. @@ -110,7 +121,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileLazyMicroSeconds" units="microseconds" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>hablich@chromium.org</owner> <summary> Aggregated time spent compiling functions lazily during a single script @@ -125,7 +136,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileMicroSeconds" units="microseconds" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>yangguo@chromium.org</owner> <summary> Time spent in V8 compiler (full codegen) excluding parser. @@ -139,7 +150,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileScript.CacheBehaviour" enum="V8CacheBehaviour" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>leszeks@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary> @@ -150,7 +161,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileScriptMicroSeconds" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>leszeks@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary> @@ -165,7 +176,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileScriptMicroSeconds.BackgroundThread" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-24"> <owner>leszeks@chromium.org</owner> <owner>rmcilroy@chromium.org</owner> <owner>v8-runtime@google.com</owner> @@ -182,7 +193,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileScriptMicroSeconds.ConsumeCache" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-17"> <owner>leszeks@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary> @@ -294,7 +305,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileScriptMicroSeconds.ProduceCache" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-05-01"> <owner>leszeks@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary> @@ -310,7 +321,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.CompileScriptMicroSeconds.StreamingFinalization" - units="microseconds" expires_after="2021-12-12"> + units="microseconds" expires_after="2022-04-24"> <owner>leszeks@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary> @@ -339,7 +350,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.DebugFeatureUsage" enum="V8DebugFeature" - expires_after="2022-01-10"> + expires_after="2022-04-24"> <owner>yangguo@chromium.org</owner> <owner>bmeurer@chromium.org</owner> <summary> @@ -371,7 +382,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.ExecuteMicroSeconds" units="microseconds" - expires_after="M100"> + expires_after="2022-04-24"> <owner>cbruni@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary> @@ -383,7 +394,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.CollectionRate.Full.Cpp" units="KB/ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> The percentage of managed C++ memory that has been collected by a garbage collection of the managed C++ heap. Reported at the end of the garbage @@ -394,7 +405,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.Efficiency.Full.Cpp" units="KB/ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> The speed at which garbage collection of the managed C++ heap reclaims unused memory. Reported at the end of the garbage collection cycle. @@ -404,7 +415,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.Efficiency.MainThread.Full.Cpp" units="KB/ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> The speed at which garbage collection of the managed C++ heap reclaims unused memory on the main thread only. This histogram ignores concurrent @@ -412,27 +423,29 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.GC.Cycle.Full.Compact.Cpp" units="ms" expires_after="M100"> +<histogram name="V8.GC.Cycle.Full.Compact.Cpp" units="ms" + expires_after="2022-05-01"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on compaction during a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. </summary> </histogram> -<histogram name="V8.GC.Cycle.Full.Cpp" units="ms" expires_after="M100"> +<histogram name="V8.GC.Cycle.Full.Cpp" units="ms" expires_after="2022-05-01"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Overall duration of a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. </summary> </histogram> -<histogram name="V8.GC.Cycle.Full.Mark.Cpp" units="ms" expires_after="M100"> +<histogram name="V8.GC.Cycle.Full.Mark.Cpp" units="ms" + expires_after="2022-04-17"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on marking during a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. @@ -441,26 +454,87 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.Full.Sweep.Cpp" units="ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on sweeping during a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. </summary> </histogram> -<histogram name="V8.GC.Cycle.Full.Weak.Cpp" units="ms" expires_after="M100"> +<histogram name="V8.GC.Cycle.Full.Weak.Cpp" units="ms" + expires_after="2022-05-01"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on weakness handling during a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. </summary> </histogram> +<histogram name="V8.GC.Cycle.MainThread.Full.Atomic.Compact.Cpp" units="ms" + expires_after="M100"> + <owner>omerkatz@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> + <summary> + Overall duration of compaction on the main thread during the atomic pause of + a garbage collection of the managed C++ heap. There is only a single atomic + pause compaction event per cycle but it may cover several sub-events. + Reported at the end of the garbage collection cycle. + </summary> +</histogram> + +<histogram name="V8.GC.Cycle.MainThread.Full.Atomic.Cpp" units="ms" + expires_after="2022-05-01"> + <owner>omerkatz@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> + <summary> + Overall main thread duration of the atomic pause of a garbage collection of + the managed C++ heap. There is only a single atomic pause event per cycle + but it may cover several sub-events. Reported at the end of the garbage + collection cycle. + </summary> +</histogram> + +<histogram name="V8.GC.Cycle.MainThread.Full.Atomic.Mark.Cpp" units="ms" + expires_after="2022-04-24"> + <owner>omerkatz@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> + <summary> + Overall duration of marking on the main thread during the atomic pause of a + garbage collection of the managed C++ heap. There is only a single atomic + pause marking event per cycle but it may cover several sub-events. Reported + at the end of the garbage collection cycle. + </summary> +</histogram> + +<histogram name="V8.GC.Cycle.MainThread.Full.Atomic.Sweep.Cpp" units="ms" + expires_after="2022-05-01"> + <owner>omerkatz@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> + <summary> + Overall duration of sweeping on the main thread during the atomic pasue of a + garbage collection of the managed C++ heap. There is only a single atomic + pause sweeping event per cycle but it may cover several sub-events. Reported + at the end of the garbage collection cycle. + </summary> +</histogram> + +<histogram name="V8.GC.Cycle.MainThread.Full.Atomic.Weak.Cpp" units="ms" + expires_after="2022-05-01"> + <owner>omerkatz@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> + <summary> + Overall duration of weakness handling on the main thread during the atomic + pause of a garbage collection of the managed C++ heap. There is only a + single atomic pause weakness handling event per cycle but it may cover + several sub-events. Reported at the end of the garbage collection cycle. + </summary> +</histogram> + <histogram name="V8.GC.Cycle.MainThread.Full.Compact.Cpp" units="ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on compaction on the main thread during a whole garbage collection of the cpp heap. Reported at the end of the garbage collection @@ -471,7 +545,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.MainThread.Full.Cpp" units="ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Main thread only duration of a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. @@ -479,9 +553,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GC.Cycle.MainThread.Full.Mark.Cpp" units="ms" - expires_after="M100"> + expires_after="2022-04-17"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on marking on the main thread during a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection @@ -490,9 +564,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GC.Cycle.MainThread.Full.Sweep.Cpp" units="ms" - expires_after="M100"> + expires_after="2022-04-24"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on sweeping on the main thread during a whole garbage collection of the managed C++ heap. Reported at the end of the garbage collection @@ -503,7 +577,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.MainThread.Full.Weak.Cpp" units="ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent on weakness handling on the main thread during a whole garbage collection of the managed C++ heap. Reported at the end of the garbage @@ -512,9 +586,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GC.Cycle.Memory.Freed.Full.Cpp" units="KB" - expires_after="M100"> + expires_after="2022-04-24"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Amount of allocated memory freed by a garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. @@ -524,7 +598,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.Objects.After.Full.Cpp" units="KB" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Amount of used memory after a garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. @@ -534,7 +608,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.Objects.Before.Full.Cpp" units="KB" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Amount of used memory before a garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. @@ -544,7 +618,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Cycle.Objects.Freed.Full.Cpp" units="KB" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Amount of used memory freed by a garbage collection of the managed C++ heap. Reported at the end of the garbage collection cycle. @@ -553,8 +627,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Event.MainThread.Full.Atomic.Compact.Cpp" units="ms" expires_after="M100"> + <obsolete> + Removed 09/2021. Renamed to V8.GC.Cycle.MainThread.Full.Atomic.Compact.Cpp. + </obsolete> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual compaction steps on the main thread during the atomic pause of a garbage collection of the managed C++ heap. @@ -563,8 +640,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Event.MainThread.Full.Atomic.Cpp" units="ms" expires_after="M100"> + <obsolete> + Removed 09/2021. Renamed to V8.GC.Cycle.MainThread.Full.Atomic.Cpp. + </obsolete> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual steps on the main thread during the atomic pause of a garbage collection of the managed C++ heap. @@ -573,8 +653,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Event.MainThread.Full.Atomic.Mark.Cpp" units="ms" expires_after="M100"> + <obsolete> + Removed 09/2021. Renamed to V8.GC.Cycle.MainThread.Full.Atomic.Mark.Cpp. + </obsolete> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual marking steps on the main thread during the atomic pause of a garbage collection of the managed C++ heap. @@ -583,8 +666,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Event.MainThread.Full.Atomic.Sweep.Cpp" units="ms" expires_after="M100"> + <obsolete> + Removed 09/2021. Renamed to V8.GC.Cycle.MainThread.Full.Atomic.Sweep.Cpp. + </obsolete> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual sweeping steps on the main thread during the atomic pause of a garbage collection of the managed C++ heap. @@ -593,8 +679,11 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Event.MainThread.Full.Atomic.Weak.Cpp" units="ms" expires_after="M100"> + <obsolete> + Removed 09/2021. Renamed to V8.GC.Cycle.MainThread.Full.Atomic.Weak.Cpp. + </obsolete> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual weakness handling steps on the main thread during the atomic pause of a garbage collection of the managed C++ heap. @@ -604,7 +693,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Event.MainThread.Full.Incremental.Cpp" units="ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual incremental steps on the main thread during a garbage collection of the managed C++ heap. @@ -614,7 +703,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.Event.MainThread.Full.Incremental.Mark.Cpp" units="ms" expires_after="M100"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual incremental marking steps on the main thread during a garbage collection of the managed C++ heap. @@ -622,9 +711,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GC.Event.MainThread.Full.Incremental.Sweep.Cpp" units="ms" - expires_after="M100"> + expires_after="2022-04-24"> <owner>omerkatz@chromium.org</owner> - <owner>oilpan-reviews@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Duration of individual incremental sweeping steps on the main thread during a garbage collection of the managed C++ heap. @@ -632,9 +721,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GC.TimeToCollectionOnBackground" units="microseconds" - expires_after="2022-02-06"> + expires_after="2022-05-01"> <owner>dinfuehr@chromium.org</owner> - <owner>ulan@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time between requesting GC from background thread and actually starting collection on main thread. This is reported each time a background thread @@ -651,7 +740,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GC.TimeToSafepoint" units="microseconds" expires_after="2022-02-06"> <owner>dinfuehr@chromium.org</owner> - <owner>ulan@chromium.org</owner> + <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent in stopping other threads to reach a safepoint. This is reported each time a safepoint is reached. @@ -664,8 +753,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.GCBackgroundMarking" units="ms" expires_after="2021-12-12"> - <owner>ulan@chromium.org</owner> +<histogram name="V8.GCBackgroundMarking" units="ms" expires_after="2022-04-24"> + <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent in background tasks doing marking in one GC cycle. It is recorded @@ -675,7 +764,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCBackgroundScavenger" units="ms" expires_after="2021-12-19"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent in background tasks doing scavenging in one GC cycle. It is @@ -684,7 +773,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCBackgroundSweeping" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> Time spent in background tasks doing sweeping in one GC cycle. It is @@ -692,7 +781,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.GCCompactor" units="ms" expires_after="2021-12-12"> +<histogram name="V8.GCCompactor" units="ms" expires_after="2022-05-01"> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary>Time spent in mark-sweep phase of GC.</summary> @@ -716,8 +805,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.GCFinalizeMC" units="ms" expires_after="2021-12-12"> - <owner>ulan@chromium.org</owner> +<histogram name="V8.GCFinalizeMC" units="ms" expires_after="2022-04-17"> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -727,7 +816,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCFinalizeMC.Clear" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -738,7 +827,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCFinalizeMC.Epilogue" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -748,7 +837,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCFinalizeMC.Evacuate" units="ms" expires_after="2021-12-05"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -758,7 +847,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCFinalizeMC.Finish" units="ms" expires_after="2022-08-09"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -768,7 +857,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCFinalizeMC.Mark" units="ms" expires_after="2022-08-09"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -779,7 +868,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCFinalizeMC.Prologue" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -788,7 +877,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCFinalizeMC.Sweep" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -799,7 +888,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCFinalizeMCBackground" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -810,7 +899,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCFinalizeMCForeground" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -820,8 +909,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCFinalizeMCReduceMemory" units="ms" - expires_after="2021-10-10"> - <owner>ulan@chromium.org</owner> + expires_after="2022-05-01"> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -832,7 +921,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCFinalizeMCReduceMemoryBackground" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -843,7 +932,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCFinalizeMCReduceMemoryForeground" units="ms" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -852,7 +941,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.GCIncrementalMarking" units="ms" expires_after="2021-10-10"> +<histogram name="V8.GCIncrementalMarking" units="ms" expires_after="M100"> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary>Time spent doing incremental marking steps during GC.</summary> @@ -866,22 +955,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCIncrementalMarkingReason" enum="GarbageCollectionReason" - expires_after="2021-12-12"> - <owner>ulan@chromium.org</owner> + expires_after="2022-04-24"> + <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary>Reason an incremental marking was started in V8.</summary> </histogram> <histogram name="V8.GCIncrementalMarkingStart" units="ms" - expires_after="2021-10-10"> + expires_after="2022-05-01"> <owner>hpayer@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary>Time spent in starting incremental marking.</summary> </histogram> <histogram name="V8.GCIncrementalMarkingSum" units="ms" - expires_after="2021-12-12"> - <owner>ulan@chromium.org</owner> + expires_after="2022-04-17"> + <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> The total time spent in incremental marking steps in one GC cycle. It is @@ -912,13 +1001,13 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.GCMarkCompactReason" enum="GarbageCollectionReason" - expires_after="2021-12-12"> - <owner>ulan@chromium.org</owner> + expires_after="2022-04-24"> + <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary>Reason a mark-compact garbage collection was started in V8.</summary> </histogram> -<histogram name="V8.GCMarkingSum" units="ms" expires_after="2021-12-12"> +<histogram name="V8.GCMarkingSum" units="ms" expires_after="2022-02-13"> <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary> @@ -962,7 +1051,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.GCScavengeReason" enum="GarbageCollectionReason" expires_after="2022-04-01"> - <owner>ulan@chromium.org</owner> + <owner>mlippautz@chromium.org</owner> <owner>v8-memory-sheriffs@google.com</owner> <summary>Reason a scavenge garbage collection was started in V8.</summary> </histogram> @@ -989,7 +1078,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.LiftoffBailoutReasons" enum="LiftoffBailoutReason" - expires_after="2021-12-19"> + expires_after="2022-04-10"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1003,6 +1092,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="V8.MaxArrayBufferCageReservationSize" units="GB" expires_after="2022-06-30"> + <obsolete> + Removed 09/2021. Superseded by V8.VirtualMemoryCageSizeGB. + </obsolete> <owner>saelo@chromium.org</owner> <owner>ishell@chromium.org</owner> <summary> @@ -1084,7 +1176,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.MemoryHeapSampleTotalCommitted" units="KB" - expires_after="2021-11-07"> + expires_after="2022-04-10"> <owner>hpayer@chromium.org</owner> <summary> The total size of committed memory used by V8 after each GC in KB. @@ -1100,7 +1192,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.RegExpBacktracks" units="backtracks" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>jgruber@chromium.org</owner> <owner>mvstanton@chromium.org</owner> <summary> @@ -1303,6 +1395,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="V8.VirtualMemoryCageSizeGB" units="GB" + expires_after="2022-09-30"> + <owner>saelo@chromium.org</owner> + <owner>ishell@chromium.org</owner> + <summary> + Size of the virtual memory cage, in GB. + + Recorded during initialization of V8, after the virtual memory cage has been + created. If the initial reservation attempt fails, the size of the cage is + reduced until either the reservation succeeds or a minimum size is reached. + A value of zero indicates that even the minimum size could not be reserved, + implying that the cage initialization failed. + + This value excludes the size of any guard regions placed around the cage and + so represents only the usable size of the cage. + </summary> +</histogram> + <histogram name="V8.WasmAddressSpaceUsageMiB" units="MB" expires_after="2022-02-15"> <owner>ecmziegler@chromium.org</owner> @@ -1315,7 +1425,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.WasmCatchCount" units="count" expires_after="2021-11-24"> +<histogram name="V8.WasmCatchCount" units="count" expires_after="2022-09-01"> <owner>thibaudm@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1325,7 +1435,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmCompileFunctionMicroSeconds" units="microseconds" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1342,7 +1452,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmCompileFunctionPeakMemoryBytes" units="bytes" - expires_after="2022-02-15"> + expires_after="2022-04-17"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1353,7 +1463,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmCompileHugeFunctionMilliSeconds" units="ms" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>clemensb@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1364,7 +1474,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmCompileHugeFunctionPeakMemoryBytes" units="bytes" - expires_after="2022-02-15"> + expires_after="2022-04-17"> <owner>clemensb@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1375,7 +1485,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmCompileModuleAsyncMicroSeconds" units="microseconds" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1387,7 +1497,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmCompileModuleMicroSeconds" units="microseconds" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1404,7 +1514,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmCompileModuleStreamingMicroSeconds" - units="microseconds" expires_after="2022-02-06"> + units="microseconds" expires_after="2022-04-10"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1430,7 +1540,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmFinishModuleStreamingMicroSeconds" units="microseconds" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>bbudge@chromium.org</owner> <owner>clemensb@chromium.org</owner> <owner>adamk@chromium.org</owner> @@ -1460,7 +1570,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmFunctionsPerModule" units="functions" - expires_after="2022-02-06"> + expires_after="2022-04-17"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1483,7 +1593,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmInstantiateModuleMicroSeconds" units="microseconds" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1523,7 +1633,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmMemoryAllocationResult" enum="WasmAllocationResult" - expires_after="2021-12-12"> + expires_after="2022-09-01"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>ahaas@chromium.org</owner> @@ -1534,7 +1644,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmMemoryProtectionKeysSupport" units="BooleanSupported" - expires_after="2021-10-04"> + expires_after="2022-09-01"> <owner>clemensb@chromium.org</owner> <owner>jkummerow@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> @@ -1560,7 +1670,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmModuleCodeSizeBaselineMiB" units="MB" - expires_after="2022-02-15"> + expires_after="2022-09-01"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1571,7 +1681,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmModuleCodeSizeMiB" units="MB" - expires_after="2022-02-15"> + expires_after="2022-04-24"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1594,7 +1704,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmModuleCodeSizeTopTierMiB" units="MB" - expires_after="2021-10-04"> + expires_after="2022-09-01"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1605,7 +1715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmModuleNumberOfCodeGCsTriggered" units="gcs" - expires_after="2021-12-12"> + expires_after="2022-09-01"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>clemensb@chromium.org</owner> @@ -1627,7 +1737,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmModuleSizeBytes" units="bytes" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>ecmziegler@chromium.org</owner> <owner>adamk@chromium.org</owner> <owner>ahaas@chromium.org</owner> @@ -1639,7 +1749,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmModulesPerEngine" units="count" - expires_after="2021-12-05"> + expires_after="2022-09-01"> <owner>clemensb@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1649,7 +1759,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmModulesPerIsolate" units="count" - expires_after="2021-12-05"> + expires_after="2022-09-01"> <owner>clemensb@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1658,7 +1768,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.WasmReThrowCount" units="count" expires_after="2021-11-24"> +<histogram name="V8.WasmReThrowCount" units="count" expires_after="2022-09-01"> <owner>thibaudm@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1667,7 +1777,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="V8.WasmThrowCount" units="count" expires_after="2021-11-24"> +<histogram name="V8.WasmThrowCount" units="count" expires_after="2022-09-01"> <owner>thibaudm@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1690,7 +1800,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmTimeBetweenCatchMilliseconds" units="ms" - expires_after="2021-11-24"> + expires_after="2022-09-01"> <owner>thibaudm@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1700,7 +1810,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmTimeBetweenRethrowsMilliseconds" units="ms" - expires_after="2021-11-24"> + expires_after="2022-09-01"> <owner>thibaudm@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> @@ -1710,7 +1820,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="V8.WasmTimeBetweenThrowsMilliseconds" units="ms" - expires_after="2021-11-24"> + expires_after="2022-09-01"> <owner>thibaudm@chromium.org</owner> <owner>ecmziegler@chromium.org</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/variations/histograms.xml b/chromium/tools/metrics/histograms/metadata/variations/histograms.xml index 8b87fac4d71..7e0de30d2eb 100644 --- a/chromium/tools/metrics/histograms/metadata/variations/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/variations/histograms.xml @@ -52,7 +52,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.ExtendedSafeMode.GotVariationsFileContents" - enum="BooleanSuccess" expires_after="2022-01-22"> + enum="BooleanSuccess" expires_after="2022-04-03"> <owner>caitlinfischer@google.com</owner> <owner>src/base/metrics/OWNERS</owner> <component>Internals>Metrics>Variations</component> @@ -66,7 +66,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.ExtendedSafeMode.WritePrefsTime" - units="microseconds" expires_after="2022-01-22"> + units="microseconds" expires_after="2022-04-03"> <owner>caitlinfischer@google.com</owner> <owner>src/base/metrics/OWNERS</owner> <component>Internals>Metrics>Variations</component> @@ -102,7 +102,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <summary> The result of attempting to fetch an initial variations seed during Android Chrome first run. Records both the HTTP code and various error values in one - enumeration. + enumeration. Prior to M95, non-200 HTTP codes were counted as IOException. + Starting with M95, these codes are logged separately. </summary> </histogram> @@ -119,6 +120,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Variations.FirstRunPrefsDebug" enum="VariationsFirstRunPrefEvents" expires_after="2021-08-29"> + <obsolete> + Removed 2021/08. + </obsolete> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> @@ -128,7 +132,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.FirstRunResult" enum="VariationsFirstRunResult" - expires_after="2021-10-25"> + expires_after="2022-06-14"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -140,7 +144,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.Headers.DomainOwner" enum="VariationsHeadersOwner" - expires_after="2021-11-08"> + expires_after="2022-04-24"> <owner>caitlinfischer@google.com</owner> <owner>src/base/metrics/OWNERS</owner> <component>Internals>Metrics</component> @@ -155,7 +159,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.Headers.ExperimentCount" units="units" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -166,7 +170,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.Headers.RequestContextCategory" - enum="VariationsHeadersRequestContextCategory" expires_after="2021-11-08"> + enum="VariationsHeadersRequestContextCategory" expires_after="2022-04-24"> <owner>asvitkine@chromium.org</owner> <owner>jwd@chromium.org</owner> <owner>caitlinfischer@google.com</owner> @@ -205,6 +209,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </token> </histogram> +<histogram name="Variations.InvalidStudyReason" + enum="VariationsInvalidStudyReason" expires_after="2022-02-26"> + <owner>jwd@chromium.org</owner> + <owner>src/base/metrics/OWNERS</owner> + <summary> + Records the reason for rejecting an invalid study. Recorded when processing + the variations seed at startup and when simulating a new seed. + </summary> +</histogram> + <histogram name="Variations.LoadPermanentConsistencyCountryResult" enum="VariationsPermanentConsistencyCountryResult" expires_after="2022-04-22"> @@ -255,7 +269,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.ResourceRequestsAllowed" - enum="VariationsResourceRequestsAllowedState" expires_after="2021-12-26"> + enum="VariationsResourceRequestsAllowedState" expires_after="2022-06-14"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -267,7 +281,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SafeMode.FellBackToSafeMode2" - enum="BooleanSafeMode" expires_after="2021-12-07"> + enum="BooleanSafeMode" expires_after="2021-08-29"> + <obsolete> + Replaced by Variations.SeedUsage in September 2021, M95. + </obsolete> <owner>isherman@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -280,7 +297,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SafeMode.LoadSafeSeed.Result" - enum="VariationsSeedLoadResult" expires_after="2021-12-07"> + enum="VariationsSeedLoadResult" expires_after="2022-06-14"> <owner>isherman@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -294,7 +311,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SafeMode.LoadSafeSeed.SignatureValidity" - enum="VariationSeedSignature" expires_after="2021-12-07"> + enum="VariationSeedSignature" expires_after="2022-06-14"> <owner>isherman@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -308,7 +325,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SafeMode.StoreSafeSeed.Result" - enum="VariationsSeedStoreResult" expires_after="2021-12-07"> + enum="VariationsSeedStoreResult" expires_after="2022-06-14"> <owner>isherman@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -321,7 +338,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SafeMode.StoreSafeSeed.SignatureValidity" - enum="VariationSeedSignature" expires_after="2021-12-07"> + enum="VariationSeedSignature" expires_after="2022-06-14"> <owner>isherman@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -405,7 +422,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SeedDateChange" enum="VariationsSeedDateChange" - expires_after="2021-12-26"> + expires_after="2022-06-14"> <owner>jwd@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -418,32 +435,24 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> -<histogram name="Variations.SeedFetchResponseOrErrorCode" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-12-26"> - <owner>asvitkine@chromium.org</owner> - <owner>rkaplow@chromium.org</owner> - <owner>src/base/metrics/OWNERS</owner> - <summary> - HTTP response codes and network error encountered by VariationsService when - attempting to fetch a variations seed from the server over an HTTPS - connection. - </summary> -</histogram> - -<histogram name="Variations.SeedFetchResponseOrErrorCode.HTTP" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2021-10-25"> +<histogram name="Variations.SeedFetchResponseOrErrorCode{ConnectionType}" + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-06-14"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> <summary> HTTP response codes and network error encountered by VariationsService when - attempting to fetch a variations seed from the server over an HTTP - connection. + attempting to fetch a variations seed from the server over an + {ConnectionType} connection. </summary> + <token key="ConnectionType"> + <variant name="" summary="HTTPS"/> + <variant name=".HTTP" summary="HTTP"/> + </token> </histogram> <histogram name="Variations.SeedFreshness" units="minutes" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -482,7 +491,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SeedLoadResult" enum="VariationsSeedLoadResult" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -494,7 +503,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SeedProcessingTime" units="ms" - expires_after="2021-12-26"> + expires_after="2022-02-27"> <owner>isherman@chromium.org</owner> <owner>asvitkine@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -505,7 +514,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.SeedStoreResult" enum="VariationsSeedStoreResult" - expires_after="2021-10-25"> + expires_after="2022-06-14"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -515,6 +524,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Variations.SeedUsage" enum="VariationsSeedUsage" + expires_after="2022-06-14"> + <owner>caitlinfischer@google.com</owner> + <owner>src/base/metrics/OWNERS</owner> + <summary> + Captures details about Chrome's attempt to use a VariationsSeed, e.g. + whether Chrome used a safe seed. Recorded once during Chrome startup after + attempting to load a seed and before field trials are created. + </summary> +</histogram> + <histogram name="Variations.SimulateSeed.Duration" units="ms" expires_after="2018-08-30"> <owner>asvitkine@chromium.org</owner> @@ -570,7 +590,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.StoreSeed.DataSize" units="KiB" - expires_after="2021-12-26"> + expires_after="2022-06-14"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> @@ -615,7 +635,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Variations.UserChannel" enum="UserChannels" - expires_after="2021-12-26"> + expires_after="2022-05-01"> <owner>asvitkine@chromium.org</owner> <owner>rkaplow@chromium.org</owner> <owner>src/base/metrics/OWNERS</owner> diff --git a/chromium/tools/metrics/histograms/metadata/video_tutorials/histograms.xml b/chromium/tools/metrics/histograms/metadata/video_tutorials/histograms.xml index ae80cc99687..661e9c1b33a 100644 --- a/chromium/tools/metrics/histograms/metadata/video_tutorials/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/video_tutorials/histograms.xml @@ -42,7 +42,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="VideoTutorials.LanguagePicker.LanguageSelected" - units="position" expires_after="2022-02-01"> + units="position" expires_after="2022-04-24"> <owner>shaktisahu@chromium.org</owner> <owner>chrome-upboarding-eng@google.com</owner> <summary> @@ -53,7 +53,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="VideoTutorials.Player.LoadTimeLatency" units="ms" - expires_after="2022-02-01"> + expires_after="2022-05-01"> <owner>shaktisahu@chromium.org</owner> <owner>chrome-upboarding-eng@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/web_apk/histograms.xml b/chromium/tools/metrics/histograms/metadata/web_apk/histograms.xml index afb8e490922..a5dfc0c4e5d 100644 --- a/chromium/tools/metrics/histograms/metadata/web_apk/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/web_apk/histograms.xml @@ -58,7 +58,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Install.GooglePlayErrorCode" - enum="WebApkInstallGooglePlayErrorCode" expires_after="2022-02-01"> + enum="WebApkInstallGooglePlayErrorCode" expires_after="2022-05-01"> <owner>hartmanng@chromium.org</owner> <owner> src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS @@ -70,7 +70,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Install.GooglePlayInstallResult" - enum="WebApkGooglePlayInstallResult" expires_after="2022-01-16"> + enum="WebApkGooglePlayInstallResult" expires_after="2022-03-20"> <owner>hartmanng@chromium.org</owner> <owner> src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS @@ -82,7 +82,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Install.InstallDuration" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-17"> <owner>hartmanng@chromium.org</owner> <owner> src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS @@ -95,7 +95,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Install.InstallEvent" enum="WebApkInstallEvent" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>hartmanng@chromium.org</owner> <owner> src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS @@ -108,7 +108,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Install.PathToInstall" enum="PwaInstallPath" - expires_after="2021-11-18"> + expires_after="2022-04-10"> <owner>finnur@chromium.org</owner> <owner>peter@chromium.org</owner> <owner> @@ -142,7 +142,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Install.RequestTokenDurationV2" units="ms" - expires_after="2022-01-23"> + expires_after="2022-03-27"> <owner>hartmanng@chromium.org</owner> <owner>rayankans@chromium.org</owner> <owner> @@ -169,7 +169,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Navigation.InScope" enum="Boolean" - expires_after="2021-09-19"> + expires_after="2022-03-19"> <owner>hartmanng@chromium.org</owner> <owner> src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS @@ -261,7 +261,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Startup.Cold.ShellLaunchToSplashscreenVisible" - units="ms" expires_after="2021-12-26"> + units="ms" expires_after="2022-02-27"> <owner>mheikal@chromium.org</owner> <owner>yfriedman@chromium.org</owner> <summary> @@ -295,7 +295,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.Update.GooglePlayUpdateResult" - enum="WebApkGooglePlayInstallResult" expires_after="2021-12-12"> + enum="WebApkGooglePlayInstallResult" expires_after="2022-05-01"> <owner>hartmanng@chromium.org</owner> <owner> src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS @@ -344,7 +344,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebApk.WebApkService.BindSuccess" enum="BooleanSuccess" - expires_after="2021-09-19"> + expires_after="2022-03-19"> <owner>hartmanng@chromium.org</owner> <owner> src/chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS diff --git a/chromium/tools/metrics/histograms/metadata/web_audio/histograms.xml b/chromium/tools/metrics/histograms/metadata/web_audio/histograms.xml index 76d5cb45143..6326c524244 100644 --- a/chromium/tools/metrics/histograms/metadata/web_audio/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/web_audio/histograms.xml @@ -31,7 +31,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioBuffer.NumberOfChannels" units="units" - expires_after="2021-11-14"> + expires_after="2022-04-17"> <owner>hongchan@chromium.org</owner> <summary> The number of channels requested by createBuffer(). Recorded for every call @@ -40,7 +40,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioBuffer.SampleRate384kHz" units="Hz" - expires_after="2021-12-26"> + expires_after="2022-04-24"> <owner>hongchan@chromium.org</owner> <summary> The sample rate (in Hz) requested by createBuffer(). Recorded for every call @@ -49,7 +49,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioBuffer.SampleRateRatio384kHz" units="units" - expires_after="2021-10-25"> + expires_after="2022-04-24"> <owner>hongchan@chromium.org</owner> <summary> The ratio of the buffer sample rate from createBuffer() to the context @@ -69,7 +69,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioContext.HardwareSampleRate" units="Hz" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>hongchan@chromium.org</owner> <summary> The hardware sample rate (in Hz) used by an AudioContext. Recorded for every @@ -100,7 +100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioContext.MaxChannelsAvailable" units="units" - expires_after="2022-01-06"> + expires_after="2022-04-10"> <owner>hongchan@chromium.org</owner> <summary> The maximum number of (hardware) channels available in an AudioContext. @@ -110,7 +110,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioContextOptions.sampleRate" units="Hz" - expires_after="2021-12-31"> + expires_after="2022-04-24"> <owner>hongchan@chromium.org</owner> <summary> The sample rate requested by developer to be used as the sample rate when @@ -120,7 +120,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioContextOptions.sampleRateRatio" units="units" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>hongchan@chromium.org</owner> <summary> The ratio of the user-selected sample rate to the hardware sample rate of an @@ -141,7 +141,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.AudioDestination.HardwareBufferSize" units="units" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>hongchan@chromium.org</owner> <summary> The buffer size (in audio frames) for WebAudio rendering recommended by the @@ -160,9 +160,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.Autoplay.CrossOrigin" enum="WebAudioAutoplayStatus" - expires_after="2021-10-04"> + expires_after="2022-04-24"> <owner>hongchan@chromium.org</owner> - <owner>media-dev@chromium.org</owner> <summary> The autoplay status of an AudioContext when destroyed in a cross-origin frame. @@ -179,7 +178,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.BiquadFilter.Type" enum="BiquadFilterType" - expires_after="2022-01-06"> + expires_after="2022-05-01"> <owner>hongchan@chromium.org</owner> <summary> The type of the BiquadFilterNode. Recorded each time the type is set. This @@ -190,7 +189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.ConvolverNode.ImpulseResponseLength" units="ms" - expires_after="2021-12-19"> + expires_after="2021-12-31"> <owner>hongchan@chromium.org</owner> <summary> The duration in millisec of impulse responses for a ConvolverNode. Recorded @@ -258,7 +257,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.PannerNode.PanningModel" enum="PanningModelType" - expires_after="2022-01-06"> + expires_after="2022-04-24"> <owner>hongchan@chromium.org</owner> <summary> The panning model for the PannerNode. Recorded once with the default value @@ -270,7 +269,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.PushPullFIFO.UnderflowGlitches" enum="Boolean" - expires_after="2022-01-06"> + expires_after="2022-04-24"> <owner>hongchan@chromium.org</owner> <summary> Captures if WebAudio caused glitches or not due to the FIFO underflow. It is @@ -280,7 +279,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAudio.PushPullFIFO.UnderflowPercentage" units="%" - expires_after="2022-01-06"> + expires_after="2022-04-17"> <owner>hongchan@chromium.org</owner> <summary> Percentage of FIFO underflow happened due to the the missed deadline of diff --git a/chromium/tools/metrics/histograms/metadata/web_core/histograms.xml b/chromium/tools/metrics/histograms/metadata/web_core/histograms.xml index 19cb01b3122..68309286215 100644 --- a/chromium/tools/metrics/histograms/metadata/web_core/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/web_core/histograms.xml @@ -30,7 +30,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </variants> <histogram name="WebCore.DistillabilityUs" units="microseconds" - expires_after="2021-12-12"> + expires_after="2022-02-13"> <owner>wychen@chromium.org</owner> <owner>gilmanmh@google.com</owner> <summary> @@ -47,7 +47,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebCore.Document.execCommand" enum="MappedEditingCommands" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>yosin@chromium.org</owner> <owner>kojii@chromium.org</owner> <summary> @@ -66,6 +66,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="WebCore.FindInPage.DurationBetweenKeystrokes" units="ms" + expires_after="2022-02-01"> + <owner>jarhar@chromium.org</owner> + <owner>vmpstr@chromium.org</owner> + <summary> + Records the amount of time between keystrokes the user made while typing a + search query into the find-in-page browser dialog. Reported on each Find + request that extends the text of the previous request. This will be used in + order to determine how long we should make the find-in-page scroll delay: + http://crbug.com/1250158 + </summary> +</histogram> + <histogram name="WebCore.FindInPage.NumberOfTasksPerRequest{FindInPageRequestEndState}" units="tasks" expires_after="2021-04-04"> @@ -105,7 +118,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebCore.FindInPage.TaskDuration" units="ms" - expires_after="2021-12-19"> + expires_after="2022-04-24"> <owner>rakina@chromium.org</owner> <owner>altimin@chromium.org</owner> <summary> @@ -870,14 +883,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebCore.Scripts.Async.NotStreamingReason" - enum="NotStreamingReason" expires_after="2021-12-12"> + enum="NotStreamingReason" expires_after="2022-02-20"> <owner>leszeks@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary>Reason for not streaming an async script.</summary> </histogram> <histogram name="WebCore.Scripts.Async.StartedStreaming" enum="BooleanStreamed" - expires_after="2021-12-12"> + expires_after="2022-02-20"> <owner>leszeks@chromium.org</owner> <owner>v8-runtime@google.com</owner> <summary>Whether an async script was streamed or not.</summary> diff --git a/chromium/tools/metrics/histograms/metadata/web_rtc/histograms.xml b/chromium/tools/metrics/histograms/metadata/web_rtc/histograms.xml index 0aa30d9e7b2..44e702bbeb0 100644 --- a/chromium/tools/metrics/histograms/metadata/web_rtc/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/web_rtc/histograms.xml @@ -133,7 +133,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc.ClippingPredictor.F1Score" units="%" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>alessiob@chromium.org</owner> <owner>silen@chromium.org</owner> <summary> @@ -143,8 +143,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="WebRTC.Audio.Agc.ClippingPredictor.Precision" units="%" + expires_after="2022-04-24"> + <owner>silen@chromium.org</owner> + <owner>alessiob@chromium.org</owner> + <summary> + Logs the precision for the clipping predictor used in AgcManagerDirect. A + log call is made every 30 seconds during an active WebRTC call using the + analog gain controller and the clipping predictor feature. + </summary> +</histogram> + <histogram name="WebRTC.Audio.Agc.ClippingPredictor.PredictionInterval" - units="frames" expires_after="2021-12-31"> + units="frames" expires_after="2022-04-03"> <owner>alessiob@chromium.org</owner> <owner>silen@chromium.org</owner> <summary> @@ -156,8 +167,19 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="WebRTC.Audio.Agc.ClippingPredictor.Recall" units="%" + expires_after="2022-05-01"> + <owner>silen@chromium.org</owner> + <owner>alessiob@chromium.org</owner> + <summary> + Logs the recall for the clipping predictor used in AgcManagerDirect. A log + call is made every 30 seconds during an active WebRTC call using the analog + gain controller and the clipping predictor feature. + </summary> +</histogram> + <histogram name="WebRTC.Audio.Agc.DigitalGainApplied" units="dB" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>alessiob@chromium.org</owner> <summary> Logs adaptive digital compression gain that is applied by AgcManagerDirect. @@ -167,7 +189,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc.DigitalGainUpdated" units="dB" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>alessiob@chromium.org</owner> <summary> Logs adaptive digital compression gain that is applied by AgcManagerDirect. @@ -177,7 +199,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc.InputClippingRate" units="%" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>silen@chromium.org</owner> <owner>alessiob@chromium.org</owner> <owner>minyue@chromium.org</owner> @@ -189,7 +211,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc2.DigitalGainApplied" units="dB" - expires_after="2021-12-31"> + expires_after="2022-04-17"> <owner>alessiob@chromium.org</owner> <summary> Logs adaptive digital compression gain that is applied by @@ -210,7 +232,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc2.FixedDigitalGainCurveRegion.Identity" - units="seconds" expires_after="2021-12-31"> + units="seconds" expires_after="2022-04-24"> <owner>alessiob@chromium.org</owner> <summary> The Fixed-Digital part of the AGC protects from saturation by reducing the @@ -222,7 +244,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc2.FixedDigitalGainCurveRegion.Knee" - units="seconds" expires_after="2021-12-31"> + units="seconds" expires_after="2022-05-01"> <owner>alessiob@chromium.org</owner> <summary> The Fixed-Digital part of the AGC protects from saturation by reducing the @@ -233,7 +255,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc2.FixedDigitalGainCurveRegion.Limiter" - units="seconds" expires_after="2021-12-31"> + units="seconds" expires_after="2022-05-01"> <owner>alessiob@chromium.org</owner> <summary> The Fixed-Digital part of the AGC protects from saturation by reducing the @@ -245,7 +267,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Agc2.FixedDigitalGainCurveRegion.Saturation" - units="seconds" expires_after="2021-12-31"> + units="seconds" expires_after="2022-05-01"> <owner>alessiob@chromium.org</owner> <summary> The Fixed-Digital part of the AGC protects from saturation by reducing the @@ -257,7 +279,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.AgcClippingAdjustmentAllowed" enum="Boolean" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>hlundin@chromium.org</owner> <summary> The automatic gain control (AGC) in WebRTC tries to adjust the microphone @@ -270,7 +292,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.AgcSetLevel" units="level" - expires_after="2021-12-31"> + expires_after="2022-04-03"> <owner>hlundin@chromium.org</owner> <summary> The automatic gain control (AGC) in WebRTC tries to adjust the microphone @@ -281,7 +303,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.ApmCaptureInputLevelAverageRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-04-10"> <owner>hlundin@chromium.org</owner> <summary> This histogram reports the average RMS of the signal coming in to WebRTC's @@ -293,7 +315,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.ApmCaptureInputLevelPeakRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-04-17"> <owner>hlundin@chromium.org</owner> <summary> This histogram reports the peak RMS of the signal coming in to WebRTC's @@ -305,7 +327,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.ApmCaptureOutputLevelAverageRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-03-06"> <owner>peah@chromium.org</owner> <summary> This histogram reports the average RMS of the signal in the output of @@ -317,7 +339,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.ApmCaptureOutputLevelPeakRms" - units="dBFS (negated)" expires_after="2021-12-31"> + units="dBFS (negated)" expires_after="2022-03-06"> <owner>peah@chromium.org</owner> <summary> This histogram reports the peak RMS of the signal in the output of WebRTC's @@ -339,7 +361,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.AudioInterruptionMs" units="ms" - expires_after="2022-01-23"> + expires_after="2022-04-10"> <owner>hlundin@chromium.org</owner> <owner>ivoc@chromium.org</owner> <summary> @@ -447,8 +469,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.AverageExcessBufferDelayMs" units="ms" - expires_after="2021-12-19"> + expires_after="2022-09-13"> <owner>hlundin@chromium.org</owner> + <owner>gustaf@chromium.org</owner> <summary> Measures the average waiting time in the buffer for each packet. The waiting time is the time elapsed from the packet arrives until it is decoded. The @@ -459,7 +482,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.DelayedPacketOutageEventMs" units="ms" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>hlundin@chromium.org</owner> <summary> Measures the duration of each packet loss concealment (a.k.a. expand) event @@ -471,7 +494,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.DelayedPacketOutageEventsPerMinute" - units="events/minute" expires_after="2022-01-02"> + units="events/minute" expires_after="2022-03-06"> <owner>hlundin@chromium.org</owner> <summary> Counts the number of delayed packet outage events per minute. The range is @@ -496,7 +519,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.BufferDelay" units="Blocks" - expires_after="2021-10-19"> + expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -507,7 +530,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.CaptureSaturation" enum="Boolean" - expires_after="2021-10-19"> + expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -519,7 +542,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.Clockdrift" enum="ClockdriftLevel" - expires_after="2021-10-19"> + expires_after="2022-09-13"> <owner>gustaf@chromium.org</owner> <owner>peah@chromium.org</owner> <summary> @@ -529,7 +552,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.DelayChanges" - enum="WebRTCEventFrequency" expires_after="2021-12-19"> + enum="WebRTCEventFrequency" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -541,7 +564,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.EchoPathDelay" units="Blocks" - expires_after="2021-12-19"> + expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -609,7 +632,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.Erle{WebRTCEchoCancellerEstimate}" - units="dB" expires_after="2021-10-19"> + units="dB" expires_after="2022-09-13"> <owner>gustaf@chromium.org</owner> <owner>peah@chromium.org</owner> <summary> @@ -625,7 +648,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.Erl{WebRTCEchoCancellerEstimate}" - units="dB (shifted)" expires_after="2021-10-19"> + units="dB (shifted)" expires_after="2022-09-13"> <owner>gustaf@chromium.org</owner> <owner>peah@chromium.org</owner> <summary> @@ -641,7 +664,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.FilterDelay" units="Blocks" - expires_after="2021-10-19"> + expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -655,7 +678,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.MaxCaptureJitter" - units="frames (10 ms)" expires_after="2021-10-19"> + units="frames (10 ms)" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>gustaf@chromium.org</owner> <summary> @@ -665,7 +688,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.MaxRenderJitter" - units="frames (10 ms)" expires_after="2021-10-19"> + units="frames (10 ms)" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>gustaf@chromium.org</owner> <summary> @@ -675,7 +698,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.MaxSkewShiftCount" - units="events/minute" expires_after="2021-10-19"> + units="events/minute" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -692,7 +715,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.MinCaptureJitter" - units="frames (10 ms)" expires_after="2021-10-19"> + units="frames (10 ms)" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>gustaf@chromium.org</owner> <summary> @@ -702,7 +725,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.MinRenderJitter" - units="frames (10 ms)" expires_after="2021-10-19"> + units="frames (10 ms)" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>gustaf@chromium.org</owner> <summary> @@ -727,7 +750,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.ReliableDelayEstimates" - enum="WebRTCAecDelayEstimateReliability" expires_after="2021-10-19"> + enum="WebRTCAecDelayEstimateReliability" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -739,7 +762,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.RenderOverruns" - enum="WebRTCEventFrequency" expires_after="2021-12-19"> + enum="WebRTCEventFrequency" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -750,7 +773,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.RenderUnderruns" - enum="WebRTCEventFrequency" expires_after="2021-12-19"> + enum="WebRTCEventFrequency" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -761,7 +784,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.EchoCanceller.UsableLinearEstimate" - enum="Boolean" expires_after="2021-10-19"> + enum="Boolean" expires_after="2022-09-13"> <owner>peah@chromium.org</owner> <owner>saza@chromium.org</owner> <summary> @@ -774,7 +797,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.Encoder.CodecType" enum="WebRtcAudioCodecs" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>aleloi@chromium.org</owner> <summary> Histogram of audio codec usage. Every sample corresponds to 5 seconds of @@ -783,7 +806,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.ExpandRatePercent" units="%" - expires_after="2022-01-16"> + expires_after="2022-03-20"> <owner>hlundin@chromium.org</owner> <summary> Measures the expand rate for an incoming WebRTC audio stream. The expand @@ -806,7 +829,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.ReceiverDeviceDelayMs" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>hlundin@chromium.org</owner> <summary> The sound card's buffering delay for the receiving side. Sampled once every @@ -815,7 +838,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.ReceiverJitterBufferDelayMs" units="ms" - expires_after="2022-01-02"> + expires_after="2022-03-06"> <owner>hlundin@chromium.org</owner> <summary> The jitter buffer delay for the receiving side. Sampled once every 10 ms @@ -840,7 +863,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.SpeechExpandRatePercent" units="%" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>hlundin@chromium.org</owner> <summary> Measures the audible expand rate for an incoming WebRTC audio stream. The @@ -852,7 +875,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Audio.TargetBitrateInKbps" units="kbps" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>hlundin@chromium.org</owner> <summary> The target bitrate in kbps that the audio codec should try to produce on @@ -892,7 +915,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.AudioOutputSampleRate" enum="AudioSampleRate" - expires_after="2022-01-09"> + expires_after="2022-04-10"> <owner>henrika@chromium.org</owner> <owner>webrtc-audio@google.com</owner> <summary>Audio output sample rate for WebRTC (in Hz).</summary> @@ -908,20 +931,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.BWE.InitialBandwidthEstimate" units="kbps" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>holmer@chromium.org</owner> <summary>The bandwidth estimate 2 seconds into a WebRTC call.</summary> </histogram> <histogram name="WebRTC.BWE.InitiallyLostPackets" units="packets" - expires_after="2021-12-19"> + expires_after="2022-02-20"> <owner>holmer@chromium.org</owner> <summary> The number of video packets lost durig the first 2 seconds in a WebRTC call. </summary> </histogram> -<histogram name="WebRTC.BWE.InitialRtt" units="ms" expires_after="2021-12-19"> +<histogram name="WebRTC.BWE.InitialRtt" units="ms" expires_after="2022-02-20"> <owner>holmer@chromium.org</owner> <summary> The round-trip time as measured 2 seconds into a WebRTC call. @@ -1026,7 +1049,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.BWE.RampUpTimeTo2000kbpsInMs" units="ms" - expires_after="2022-02-28"> + expires_after="2022-05-01"> <owner>holmer@chromium.org</owner> <summary> The time it takes the estimated bandwidth to reach 2000 kbps from the first @@ -1064,7 +1087,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Call.BitrateReceivedInKbps" units="kbps" - expires_after="2022-02-21"> + expires_after="2022-05-01"> <owner>holmer@chromium.org</owner> <summary> Average total bitrate received during a call (audio + video + RTCP), counted @@ -1084,7 +1107,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Call.LifetimeInSeconds" units="seconds" - expires_after="2022-02-21"> + expires_after="2022-04-24"> <owner>asapersson@chromium.org</owner> <summary> The lifetime of a call. Recorded when a Call instance is destroyed. @@ -1092,7 +1115,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Call.PacerBitrateInKbps" units="kbps" - expires_after="2022-02-21"> + expires_after="2022-05-01"> <owner>holmer@chromium.org</owner> <summary> Average pacer bitrate during a call, counted from first packet sent until @@ -1112,7 +1135,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Call.TimeReceivingAudioRtpPacketsInSeconds" units="s" - expires_after="2022-02-06"> + expires_after="2022-04-10"> <owner>saza@chromium.org</owner> <summary> The amount of time between the arrival of the first and last audio RTP @@ -1124,7 +1147,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Call.TimeReceivingVideoRtpPacketsInSeconds" units="s" - expires_after="2021-12-12"> + expires_after="2022-04-17"> <owner>saza@chromium.org</owner> <summary> The amount of time between the arrival of the first and last video RTP @@ -1136,7 +1159,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.Call.VideoBitrateReceivedInKbps" units="kbps" - expires_after="2022-02-21"> + expires_after="2022-05-01"> <owner>holmer@chromium.org</owner> <summary> Average video bitrate received during a call, counted from first packet @@ -1146,7 +1169,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.DataChannelAggregateType" - enum="DataChannelAggregateType" expires_after="2021-12-31"> + enum="DataChannelAggregateType" expires_after="2022-06-30"> <owner>orphis@chromium.org</owner> <owner>toprice@chromium.org</owner> <summary> @@ -1156,7 +1179,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.DataChannelCounters" enum="DataChannelCounters" - expires_after="2021-12-31"> + expires_after="2022-06-30"> <owner>orphis@chromium.org</owner> <owner>toprice@chromium.org</owner> <summary> @@ -1165,8 +1188,20 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="WebRTC.DataChannelMaxPacketLifeTime" units="ms" + expires_after="2022-06-30"> + <owner>orphis@chromium.org</owner> + <owner>toprice@chromium.org</owner> + <summary> + Recorded when a data channel is created. The length of the time window + during which transmissions and retransmissions may occur in unreliable mode. + It is set to the value used in the configuration when a RTCDataChannel is + created. + </summary> +</histogram> + <histogram name="WebRTC.DataChannelMaxRetransmits" units="units" - expires_after="2021-12-31"> + expires_after="2022-06-30"> <owner>orphis@chromium.org</owner> <owner>toprice@chromium.org</owner> <summary> @@ -1179,18 +1214,22 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="WebRTC.DataChannelMaxRetransmitTime" units="ms" expires_after="2021-12-31"> + <obsolete> + Replaced by WebRTC.DataChannelMaxPacketLifeTime to align better with the + specification in M93. + </obsolete> <owner>orphis@chromium.org</owner> <owner>toprice@chromium.org</owner> <summary> Recorded when a data channel is created. The length of the time window during which transmissions and retransmissions may occur in unreliable mode. It is set to the value used in the configuration when a RTCDataChannel is - created. Expired in M78. Revived in M93. + created. Expired in M78. </summary> </histogram> <histogram name="WebRTC.DataChannelSctpErrorCode" - enum="DataChannelSctpErrorCode" expires_after="2021-12-31"> + enum="DataChannelSctpErrorCode" expires_after="2022-06-30"> <owner>orphis@chromium.org</owner> <owner>toprice@chromium.org</owner> <summary> @@ -1257,7 +1296,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.DesktopCaptureCounters" enum="DesktopCaptureCounters" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>guidou@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> <summary> @@ -1284,7 +1323,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.MediaStreamDevices.HasPanTiltZoomCamera" - enum="BooleanAvailable" expires_after="M100"> + enum="BooleanAvailable" expires_after="2022-04-24"> <owner>reillyg@chromium.org</owner> <owner>device-dev@chromium.org</owner> <summary> @@ -1314,7 +1353,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.AddIceCandidate" - enum="AddIceCandidateResult" expires_after="2022-02-09"> + enum="AddIceCandidateResult" expires_after="2022-05-01"> <owner>hta@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> <summary> @@ -1377,7 +1416,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.ConnectionState" - enum="IceConnectionStates" expires_after="2021-12-12"> + enum="IceConnectionStates" expires_after="2022-04-17"> <owner>qingsi@google.com</owner> <owner>jeroendb@google.com</owner> <summary> @@ -1521,7 +1560,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.KeyProtocol" - enum="PeerConnectionKeyProtocol" expires_after="2022-01-09"> + enum="PeerConnectionKeyProtocol" expires_after="2022-04-24"> <owner>hta@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> <summary> @@ -1701,7 +1740,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.SdpFormatReceived" - enum="PeerConnectionSdpFormatReceived" expires_after="2021-12-12"> + enum="PeerConnectionSdpFormatReceived" expires_after="2022-04-24"> <owner>steveanton@chromium.org</owner> <owner>hta@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> @@ -1718,7 +1757,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.SdpFormatReceivedAnswer" - enum="PeerConnectionSdpFormatReceived" expires_after="2021-12-12"> + enum="PeerConnectionSdpFormatReceived" expires_after="2022-05-01"> <owner>steveanton@chromium.org</owner> <owner>hta@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> @@ -1730,7 +1769,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.SdpSemanticNegotiated" - enum="PeerConnectionSdpSemanticNegotiated" expires_after="2021-11-07"> + enum="PeerConnectionSdpSemanticNegotiated" expires_after="2022-05-01"> <owner>hta@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> <summary> @@ -1743,7 +1782,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.SdpSemanticRequested" - enum="PeerConnectionSdpSemanticRequested" expires_after="2021-12-05"> + enum="PeerConnectionSdpSemanticRequested" expires_after="2022-05-01"> <owner>hta@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> <summary> @@ -1838,7 +1877,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.ThermalState" enum="ThermalState" - expires_after="2022-02-06"> + expires_after="2022-04-24"> <owner>eshr@google.com</owner> <owner>hbos@chromium.org</owner> <summary> @@ -1867,7 +1906,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.PeerConnection.UsagePattern" - enum="WebRtcPeerConnectionUsagePattern" expires_after="2022-02-06"> + enum="WebRtcPeerConnectionUsagePattern" expires_after="2022-04-24"> <owner>hta@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> <summary> @@ -1878,7 +1917,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.ReceivedAudioTrackDuration" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>perkj@chromium.org</owner> <summary> Durations of audio tracks received over a PeerConnection. The stopwatch @@ -1888,7 +1927,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.ReceivedVideoTrackDuration" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>perkj@chromium.org</owner> <summary> Durations of video tracks received over a PeerConnection. The stopwatch @@ -1898,7 +1937,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.ReliableDataChannelMessageSize" units="bytes" - expires_after="2021-12-05"> + expires_after="2022-04-17"> <owner>perkj@chromium.org</owner> <summary> Sizes of messages sent over reliable data channels. The size of an @@ -1914,7 +1953,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.SentAudioTrackDuration" units="ms" - expires_after="2022-01-30"> + expires_after="2022-04-03"> <owner>perkj@chromium.org</owner> <summary> Durations of audio tracks sent over a PeerConnection. The stopwatch starts @@ -1924,7 +1963,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.SentVideoTrackDuration" units="ms" - expires_after="2022-01-09"> + expires_after="2022-03-13"> <owner>perkj@chromium.org</owner> <summary> Durations of video tracks sent over a PeerConnection. The stopwatch starts @@ -2026,7 +2065,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.UnreliableDataChannelMessageSize" units="bytes" - expires_after="2021-11-21"> + expires_after="2022-04-17"> <owner>perkj@chromium.org</owner> <summary> Sizes of messages sent over unreliable data channels. The size of an @@ -3833,7 +3872,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRTC.webkitApiCount" enum="RTCAPIName" - expires_after="2022-01-23"> + expires_after="2022-04-24"> <owner>guidou@chromium.org</owner> <owner>hbos@chromium.org</owner> <owner>mcasas@chromium.org</owner> @@ -3892,7 +3931,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRtcTextLogging.UploadFailureNetErrorCode" - enum="NetErrorCodes" expires_after="2021-12-01"> + enum="NetErrorCodes" expires_after="2022-05-01"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> @@ -3903,7 +3942,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebRtcTextLogging.UploadFailureReason" - enum="WebRtcLoggingUploadFailureReason" expires_after="2021-12-01"> + enum="WebRtcLoggingUploadFailureReason" expires_after="2022-05-01"> <owner>guidou@chromium.org</owner> <owner>olka@chromium.org</owner> <owner>webrtc-dev@chromium.org</owner> diff --git a/chromium/tools/metrics/histograms/metadata/webapps/histograms.xml b/chromium/tools/metrics/histograms/metadata/webapps/histograms.xml new file mode 100644 index 00000000000..5d5fb62725c --- /dev/null +++ b/chromium/tools/metrics/histograms/metadata/webapps/histograms.xml @@ -0,0 +1,564 @@ +<!-- +Copyright 2021 The Chromium Authors. All rights reserved. +Use of this source code is governed by a BSD-style license that can be +found in the LICENSE file. +--> + +<!-- +This file is used to generate a comprehensive list of Simple histograms +along with a detailed description for each histogram. + +For best practices on writing histogram descriptions, see +https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md + +Please send CLs to chromium-metrics-reviews@google.com rather than to specific +individuals. These CLs will be automatically reassigned to a reviewer within +about 5 minutes. This approach helps the metrics team to load-balance incoming +reviews. Googlers can read more about this at go/gwsq-gerrit. +--> + +<histogram-configuration> + +<histograms> + +<histogram name="Webapp.AddToHomescreenDialog.Timeout" units="ms" + expires_after="2022-04-17"> + <owner>dominickn@chromium.org</owner> + <owner>peconn@chromium.org</owner> + <summary> + Records the number of milliseconds that the add to homescreen dialog + required to check installability eligibility. + </summary> +</histogram> + +<histogram name="Webapp.AddToHomescreenMediator.AppTypeToMenuEntry" + enum="AppTypeToMenuEntry" expires_after="2022-04-03"> + <owner>finnur@chromium.org</owner> + <owner>beverloo@chromium.org</owner> + <summary> + Keeps track of what verbiage was shown in the App menu versus what was + actually installed. + </summary> +</histogram> + +<histogram name="Webapp.CheckServiceWorker.Status" + enum="ServiceWorkerOfflineCapability" expires_after="2022-04-17"> + <owner>asamidoi@chromium.org</owner> + <owner>chrome-worker@google.com</owner> + <summary> + Records the result of the check if a PWA has a service worker with a fetch + event handler when the CheckOfflineCapability feature is disabled. When the + feature is enabled, records the result of the check if a PWA supports + offline pages with a service worker. + </summary> +</histogram> + +<histogram name="Webapp.CheckServiceWorker.Time" units="ms" + expires_after="2022-02-06"> + <owner>asamidoi@chromium.org</owner> + <owner>chrome-worker@google.com</owner> + <summary> + Records the time to complete the check if a PWA has a service worker with a + fetch event handler when the CheckOfflineCapability feature is disabled. + When the feature is enabled, records the time to complete the check if a PWA + supports offline pages with a service worker. + </summary> +</histogram> + +<histogram name="WebApp.Database.WriteResult" enum="BooleanSuccess" + expires_after="2022-09-01"> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records if modifying data in the web app database was successful. Recorded + whenever the database is written to, which can happen on large events like + installing a web app, as well as small events like changing a the user + display preference for a web app. + </summary> +</histogram> + +<histogram base="true" name="WebApp.Engagement" + enum="SiteEngagementServiceEngagementType" expires_after="2022-04-10"> + <owner>calamity@chromium.org</owner> + <owner>mgiuca@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <summary> + The type of engagement (navigation, user input, etc.) which led to an + accumulation in site engagement within a web app window or tab. Should be + collected for a subset of SiteEngagementService.EngagementType, which is + triggered for all browsing contexts. Recorded at the time of engagement + accumulation (e.g., when mouse is clicked). + </summary> +</histogram> + +<histogram name="WebApp.Icon.HttpStatusCodeClassOnCreate" + enum="HttpStatusCodeClass" expires_after="2021-01-01"> + <owner>alancutter@chromium.org</owner> + <owner>mgiuca@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <summary> + The HTTP status code class returned for each icon loaded during a WebApp's + creation. See corresponding + Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnCreate histogram for legacy + extension-based system. Recorded when WebAppDataRetriever starts downloading + icons. + </summary> +</histogram> + +<histogram name="WebApp.Icon.HttpStatusCodeClassOnSync" + enum="HttpStatusCodeClass" expires_after="2021-01-01"> + <owner>alancutter@chromium.org</owner> + <owner>mgiuca@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <summary> + The HTTP status code class returned for each icon loaded when syncing a + WebApp. See Extensions.BookmarkApp.Icon.HttpStatusCodeClassOnSync histogram + for legacy extension-based system. Recorded when WebAppDataRetriever starts + downloading icons. + </summary> +</histogram> + +<histogram name="WebApp.Icon.HttpStatusCodeClassOnUpdate" + enum="HttpStatusCodeClass" expires_after="2021-01-01"> + <owner>alancutter@chromium.org</owner> + <owner>raymes@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <summary> + The HTTP status code class returned for each icon loaded when updating a + WebApp. Recorded when WebAppDataRetriever starts downloading icons. + </summary> +</histogram> + +<histogram name="Webapp.Install.DisplayMode2" enum="WebAppDisplayMode" + expires_after="2022-04-10"> + <owner>ericwilligers@chromium.org</owner> + <owner>peter@chromium.org</owner> + <owner>yfriedman@chromium.org</owner> + <summary> + Records the display mode (as defined in the Web App Manifest spec) at the + install time of a WebApp. Fixes a bug in the data collection for desktop web + apps. + </summary> +</histogram> + +<histogram name="Webapp.Install.InstallBounce" enum="WebappInstallSource" + expires_after="2022-04-03"> + <owner>dominickn@chromium.org</owner> + <owner>alancutter@chromium.org</owner> + <summary> + Records when a web app install bounced for different install sources. A + bounce is when the user uninstalls the web app within 1 hour of installing + it. + </summary> +</histogram> + +<histogram name="Webapp.Install.InstallEvent" enum="WebappInstallSource" + expires_after="2022-03-20"> + <owner>dominickn@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <owner>calamity@chromium.org</owner> + <summary> + Records the mechanism and source from which a web app installation was + triggered, regardless of whether the installation was successful. + </summary> +</histogram> + +<histogram name="Webapp.Install.UninstallEvent" enum="WebappUninstallSource" + expires_after="2022-04-12"> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <owner>sunggch@microsoft.com</owner> + <summary> + Records the mechanism and source from which a web app uninstallation was + triggered, regardless of whether the uninstallation was successful. + </summary> +</histogram> + +<histogram name="WebApp.InstallConfirmation.CloseReason" + enum="WidgetClosedReason" expires_after="2022-05-01"> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwa-team@google.com</owner> + <summary> + Records the reason that the WebApp install confirmation dialog is closed. + This dialog is shown when the user clicks on the 'install' icon in the + omnibox for websites that are installable. This metric is intended to give + data for an experiment to choose the best install icon. + </summary> +</histogram> + +<histogram name="WebApp.InstallIphPromo.Result" enum="WebAppInstallIphResult" + expires_after="2022-05-01"> + <owner>phillis@chromium.org</owner> + <owner>dmurph@chromium.org</owner> + <summary> + Records the result of user reaction to In Product Help promo for Web App + Install. + </summary> +</histogram> + +<histogram name="Webapp.InstallResult" enum="WebAppInstallResultCode" + expires_after="2022-03-20"> +<!-- Name completed by histogram_suffixes name="WebAppType" --> + + <owner>calamity@chromium.org</owner> + <owner>ortuno@chromium.org</owner> + <summary>Records the result code of Web App installs.</summary> +</histogram> + +<histogram base="true" + name="Webapp.InstallResultExtensionDisabledReason.System.Profiles" + enum="ExtensionDisableReason" expires_after="2020-12-31"> + <obsolete> + Removed 11/2020, as the relevant code path is no longer executed after BMO + launch. + </obsolete> + <owner>calamity@chromium.org</owner> + <owner>ortuno@chromium.org</owner> + <summary> + Records why System Web App .crx extension is disabled during System Web App + installs. Certain properties of the profile might cause Extensions to be + disabled as soon as they are installed. For example, kiosk profile might set + policies to disable all Extensions, including System Web Apps which are + considered Extensions. + </summary> +</histogram> + +<histogram base="true" + name="Webapp.InstallResultExtensionError.System.Profiles" + enum="ExtensionInstallationCrxInstallError" expires_after="2020-12-31"> + <obsolete> + Removed 11/2020, as the relevant code path is no longer executed after BMO + launch. + </obsolete> + <owner>calamity@chromium.org</owner> + <owner>ortuno@chromium.org</owner> + <summary> + Records .crx extension error code when System Web App install fails. + </summary> +</histogram> + +<histogram name="WebApp.Launcher.LaunchResult" + enum="WebAppLauncherLaunchResult" expires_after="2022-07-01"> + <owner>davidbienvenu@chromium.org</owner> + <owner>jessemckenna@google.com</owner> + <summary> + The result of a Progressive Web App (PWA) launcher's attempt to launch + Chrome. Windows-only. + </summary> +</histogram> + +<histogram name="WebApp.Launcher.UpdateResult" + enum="WebAppLauncherUpdateResult" expires_after="2022-07-01"> + <owner>davidbienvenu@chromium.org</owner> + <owner>jessemckenna@google.com</owner> + <summary> + The result of updating a single Progressive Web App (PWA) launcher with the + latest version of chrome_pwa_launcher.exe. Windows-only. + </summary> +</histogram> + +<histogram name="WebApp.Migration.UserDisplayModeCleanUp" + enum="BooleanMigrated" expires_after="2021-01-01"> + <obsolete> + Removed 12/2020. + </obsolete> + <owner>alancutter@chromium.org</owner> + <owner>dxie@google.com</owner> + <owner>loyso@google.com</owner> + <owner>mgiuca@google.com</owner> + <summary> + The result of deploying a follow up migration after a migration bug + (https://crbug.com/1125020) that caused users' web apps to open in a browser + tab instead of a standalone window. This follow up migration only runs once + at startup for all Chrome profiles. If it fails it will retry until + successful on subsequent start ups, metrics are only recorded on success. + </summary> +</histogram> + +<histogram name="WebApp.Mover.Result" enum="WebAppMoverResult" + expires_after="2022-04-24"> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records the result of running the WebAppMover, which runs on Chrome startup. + It uninstalls a set of WebApps and then installs a single WebApp as a + replacement. + </summary> +</histogram> + +<histogram name="Webapp.NavigationStatus" enum="BooleanSuccess" + expires_after="2021-10-25"> + <owner>peter@chromium.org</owner> + <owner>hartmanng@chromium.org</owner> + <summary> + Records whether the top-level navigations in standalone Web Apps result in + presenting the web content or showing the error page. + </summary> +</histogram> + +<histogram name="WebApp.Preinstalled.ConfigErrorCount" units="apps" + expires_after="2022-04-03"> + <owner>alancutter@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records how many preinstalled web app config files failed to parse as valid + JSON with valid fields. See preinstalled_web_app_utils.cc ParseConfig(). + This is recorded at start up. + </summary> +</histogram> + +<histogram name="WebApp.Preinstalled.DisabledCount" units="apps" + expires_after="2022-04-17"> + <owner>alancutter@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records how many preinstalled web apps configs were disabled for the device. + This is recorded at start up. + </summary> +</histogram> + +<histogram name="WebApp.Preinstalled.EnabledCount" units="apps" + expires_after="2022-05-01"> + <owner>alancutter@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records how many preinstalled web apps configs were enabled for the device. + This is recorded at start up. + </summary> +</histogram> + +<histogram name="WebApp.Preinstalled.UninstallAndReplaceCount" units="apps" + expires_after="2022-04-17"> + <owner>alancutter@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records how many preinstalled web app installations uninstalled and replaced + an old default app (web app or Chrome app). This corresponds to the + "uninstall_and_replace" field in preinstalled web app configs. + </summary> +</histogram> + +<histogram name="WebApp.Shortcuts.Creation.Result" + enum="ShortcutsCreationResult" expires_after="2022-09-19"> + <owner>phillis@chromium.org</owner> + <owner>dmurph@chromium.org</owner> + <summary>Records the result of shortcut creation for PWA.</summary> +</histogram> + +<histogram name="WebApp.Shortcuts.Deletion.Success" enum="BooleanSuccess" + expires_after="M93"> + <obsolete> + Removed on M93. Not needed anymore. + </obsolete> + <owner>phillis@chromium.org</owner> + <owner>dmurph@chromium.org</owner> + <owner>sunggch@microsoft.com</owner> + <summary> + Records the result of shortcut deletion for a PWA. This occurs when an + installed PWA is uninstalled, which can be triggered by user, policy admin, + or sync system depending on the situation. + </summary> +</histogram> + +<histogram name="Webapp.SyncInitiatedUninstallResult" enum="BooleanSuccess" + expires_after="2022-04-24"> + <owner>alancutter@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <summary> + Records uninstallation result for sync initiated uninstalls in the new + USS-based web applications system. + </summary> +</histogram> + +<histogram name="Webapp.SystemApps.BackgroundTaskStartDelay" units="ms" + expires_after="2022-04-24"> + <owner>dominicschulz@google.com</owner> + <owner>qjw@chromium.org</owner> + <summary> + Records how long the SWA background task waits for the system to become idle + before starting to run. Recorded in milliseconds, from 1 millisecond to 1 + hour. This is logged when a SWA background task starts. + </summary> +</histogram> + +<histogram name="Webapp.SystemApps.BadNavigate.Type" units="App ID" + expires_after="2021-09-01"> + <owner>calamity@chromium.org</owner> + <owner>qjw@chromium.org</owner> + <summary> + Records the type of System Web App that caused a bad navigation. This is + used to trigger a Perfetto trace to provide more debugging information. See + crbug.com/1201820 for more details. + </summary> +</histogram> + +<histogram name="Webapp.SystemApps.FreshInstallDuration" units="ms" + expires_after="2022-03-20"> + <owner>calamity@chromium.org</owner> + <owner>ortuno@chromium.org</owner> + <summary> + Records the time taken to perform a fresh install of all system web apps. It + measures the time from when we dispatch a call to install them, until we get + all the installation results. This intentionally excludes the scenario where + we don't request to install all the apps for consistency. Recorded in + milliseconds, from 1 millisecond to 3 minutes. + </summary> +</histogram> + +<histogram name="WebApp.Uninstall.IconDataSuccess" enum="BooleanSuccess" + expires_after="2022-09-01"> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records if removing icon data from disk was successful during non-sync + webapp uninstall, before the webapp is removed from the database. Uninstall + can occur from the user, enterprise policy, device policy (but not or chrome + sync). + </summary> +</histogram> + +<histogram name="WebApp.Uninstall.OsHookSuccess" enum="BooleanSuccess" + expires_after="2022-09-01"> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records if uninstalling OS hooks was successful during non-sync webapp + uninstall, before the webapp is removed from the database. Uninstall can + occur from the user, enterprise policy, device policy (but not or chrome + sync). + </summary> +</histogram> + +<histogram name="WebApp.Uninstall.Result" enum="BooleanSuccess" + expires_after="2022-09-01"> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records if non-sync uninstallation was successful. Uninstall can occur from + the user, enterprise policy, device policy (but not or chrome sync). + </summary> +</histogram> + +<histogram name="WebApp.UninstallDialog.AppMenuUninstallSuccess" enum="Boolean" + expires_after="M95"> + <obsolete> + Removed in M92. + </obsolete> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records the result of uninstalling a WebApp when the user clicks on + "Uninstall" from the 3-dot menu of the respective WebApp window. + </summary> +</histogram> + +<histogram name="WebApp.UninstallDialog.AppsPageUninstallSuccess" + enum="Boolean" expires_after="M95"> + <obsolete> + Removed in M92. + </obsolete> + <owner>dmurph@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records the result of uninstalling an app from the chrome://apps page. This + happens whena user right-clicks on a greyed out webapp icon in the + chrome://apps page and clicks "Uninstall". + </summary> +</histogram> + +<histogram name="Webapp.UninstallDialogAction" + enum="WebappUninstallDialogAction" expires_after="2022-05-01"> + <owner>benwells@chromium.org</owner> + <owner>dominickn@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <summary> + Records the user response to the dialog shown when uninstalling a web app. + </summary> +</histogram> + +<histogram name="Webapp.Update.ManifestUpdateResult" + enum="WebAppManifestUpdateResult" expires_after="2022-04-24"> + <owner>alancutter@chromium.org</owner> + <owner>desktop-pwas-team@chromium.org</owner> + <owner>loyso@chromium.org</owner> + <owner>raymes@chromium.org</owner> + <summary> + Records the result of web app manifest update checks during page + navigations. Note that "No app in scope" results are ignored due + to the expected several orders of magnitude higher volume than all other + update results. + </summary> +</histogram> + +<histogram name="Webapp.Update.ManifestUpdateResult.DefaultApp" + enum="WebAppManifestUpdateResult" expires_after="M96"> + <owner>alancutter@chromium.org</owner> + <owner>tsergeant@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Identical to Webapp.Update.ManifestUpdateResult but restricted to just + default installed web apps. + </summary> +</histogram> + +<histogram name="WebApp.UrlHandling.DialogState" + enum="WebAppUrlHandlingDialogState" expires_after="2022-06-25"> + <owner>mek@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records the user action taken on the URL Handling intent picker dialog. + </summary> +</histogram> + +<histogram name="WebApp.UrlHandling.GetValidProfilesAtStartUp" + units="microseconds" expires_after="2022-06-20"> + <owner>mek@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Measure the time it takes to collect (loading as needed) the set of profiles + eligible to handle a URL by a PWA at startup for URL Handling. Emitted for + users with high resolution clocks only. + </summary> +</histogram> + +<histogram name="WebApp.UrlHandling.LoadWebAppRegistrarsAtStartUp" + units="microseconds" expires_after="2022-06-20"> + <owner>mek@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Measure the time it takes to load all the web app registrars for URL + Handling at startup. Emitted for users with high resolution clocks only. + </summary> +</histogram> + +<histogram name="Webapp.WebAppOriginAssociationFetchResult" + enum="WebAppOriginAssociationFetchResult" expires_after="2022-03-05"> + <owner>mek@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records the result of web app origin association file fetch when url + handlers are present. Happens when PWA is installed or updated. + </summary> +</histogram> + +<histogram name="Webapp.WebAppOriginAssociationParseResult" + enum="WebAppOriginAssociationParseResult" expires_after="2022-03-05"> + <owner>mek@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary> + Records the result of web app origin association file parsing. Happens after + an web app origin association file is fetched. + </summary> +</histogram> + +<histogram name="Webapp.WebAppUrlLoaderPrepareForLoadResult" + enum="WebAppUrlLoaderResult" expires_after="2022-03-13"> + <owner>qjw@chromium.org</owner> + <owner>ortuno@chromium.org</owner> + <owner>desktop-pwas-team@google.com</owner> + <summary>Records the result of WebAppUrlLoader::PrepareForLoad().</summary> +</histogram> + +</histograms> + +</histogram-configuration> diff --git a/chromium/tools/metrics/histograms/metadata/webauthn/histograms.xml b/chromium/tools/metrics/histograms/metadata/webauthn/histograms.xml index 3c1078df33d..c4b3573e98a 100644 --- a/chromium/tools/metrics/histograms/metadata/webauthn/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/webauthn/histograms.xml @@ -39,7 +39,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.CableV1DiscoveryEvent" - enum="WebAuthenticationCableV1DiscoveryEvent" expires_after="2021-12-12"> + enum="WebAuthenticationCableV1DiscoveryEvent" expires_after="2022-05-01"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> @@ -49,7 +49,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.CableV2.AOADiscoveryEvent" - enum="WebAuthenticationAOADiscoveryEvent" expires_after="2021-11-19"> + enum="WebAuthenticationAOADiscoveryEvent" expires_after="2022-04-10"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> @@ -58,7 +58,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.CableV2.DiscoveryEvent" - enum="WebAuthenticationCableV2DiscoveryEvent" expires_after="2021-11-19"> + enum="WebAuthenticationCableV2DiscoveryEvent" expires_after="2022-04-03"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> @@ -67,7 +67,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.CableV2.MobileEvent" - enum="WebAuthenticationCableV2MobileEvent" expires_after="2021-11-19"> + enum="WebAuthenticationCableV2MobileEvent" expires_after="2022-04-03"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> @@ -77,14 +77,14 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.CableV2.MobileResult" - enum="WebAuthenticationCableV2MobileResult" expires_after="2021-11-19"> + enum="WebAuthenticationCableV2MobileResult" expires_after="2022-04-03"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary>Records the outcome of caBLEv2 transactions.</summary> </histogram> <histogram name="WebAuthentication.CableV2.RendezvousTime" units="ms" - expires_after="2021-11-19"> + expires_after="2022-04-10"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> @@ -95,7 +95,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.CableV2.TunnelEvent" - enum="WebAuthenticationCableV2TunnelEvent" expires_after="2021-11-19"> + enum="WebAuthenticationCableV2TunnelEvent" expires_after="2022-04-10"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> @@ -104,7 +104,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.CableV2.TunnelServerError" - enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-02-01"> + enum="CombinedHttpResponseAndNetErrorCode" expires_after="2022-04-10"> <owner>agl@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> @@ -115,34 +115,68 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="WebAuthentication.ChromeOS.GetAssertionStatus" enum="WebAuthenticationChromeOSGetAssertionResult" - expires_after="2022-01-23"> - <owner>yichengli@chromium.org</owner> + expires_after="2022-05-01"> <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> <summary>Records the outcome of GetAssertion on Chrome OS.</summary> </histogram> <histogram name="WebAuthentication.ChromeOS.MakeCredentialStatus" enum="WebAuthenticationChromeOSMakeCredentialResult" expires_after="2022-01-23"> - <owner>yichengli@chromium.org</owner> <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> <summary>Records the outcome of MakeCredential on Chrome OS.</summary> </histogram> <histogram name="WebAuthentication.ChromeOS.StartupRecordCount" units="records" - expires_after="2021-11-19"> - <owner>yichengli@chromium.org</owner> + expires_after="2022-08-31"> <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> <summary> Records the number of records of the user's WebAuthn credentials created on Chrome OS. </summary> </histogram> +<histogram name="WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledDuration" + units="ms" expires_after="2022-08-31"> + <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> + <summary>The duration of a u2fd IsU2fEnabled request.</summary> +</histogram> + +<histogram name="WebAuthentication.ChromeOS.U2FClient.IsU2fEnabledStatus" + enum="WebAuthenticationU2FClientStatus" expires_after="2022-01-23"> + <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> + <summary> + Records whether a u2fd IsU2fEnabled DBus call completed successfully or + encountered an error. + </summary> +</histogram> + +<histogram name="WebAuthentication.ChromeOS.U2FClient.IsUvpaaDuration" + units="ms" expires_after="2022-08-31"> + <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> + <summary>The duration of a u2fd IsUvpaa request.</summary> +</histogram> + +<histogram name="WebAuthentication.ChromeOS.U2FClient.IsUvpaaStatus" + enum="WebAuthenticationU2FClientStatus" expires_after="2022-01-23"> + <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> + <summary> + Records whether a u2fd IsUvpaa DBus call completed successfully or + encountered an error. + </summary> +</histogram> + <histogram name="WebAuthentication.ChromeOS.UserVerificationRequired" enum="Boolean" expires_after="2021-11-19"> - <owner>yichengli@chromium.org</owner> <owner>martinkr@google.com</owner> + <owner>chrome-webauthn@google.com</owner> <summary> Records whether the Chrome OS platform authenticator should try to verify the user (instead of requiring power button press). Note that a @@ -166,7 +200,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="WebAuthentication.GetAssertionRequestTransport" - enum="WebAuthenticationFidoTransport" expires_after="2022-01-30"> + enum="WebAuthenticationFidoTransport" expires_after="2022-04-24"> <owner>kenrb@chromium.org</owner> <owner>martinkr@google.com</owner> <summary> diff --git a/chromium/tools/metrics/histograms/metadata/windows/histograms.xml b/chromium/tools/metrics/histograms/metadata/windows/histograms.xml index 6bb964f1780..b40cb5aae6a 100644 --- a/chromium/tools/metrics/histograms/metadata/windows/histograms.xml +++ b/chromium/tools/metrics/histograms/metadata/windows/histograms.xml @@ -22,8 +22,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histograms> <variants name="FileOperations"> - <variant name=".DeleteFile.NonRecursive" summary=""/> - <variant name=".DeleteFile.Recursive" summary=""/> + <variant name=".DeleteFile.NonRecursive" summary=""> + <obsolete> + Removed in M95. + </obsolete> + </variant> + <variant name=".DeleteFile.Recursive" summary=""> + <obsolete> + Removed in M95. + </obsolete> + </variant> </variants> <histogram name="Windows.ApplockerRunning" enum="Boolean" expires_after="M83"> @@ -48,7 +56,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.CetEnabled" enum="BooleanEnabled" - expires_after="2021-12-01"> + expires_after="2022-04-03"> <owner>ajgo@chromium.org</owner> <owner>wfh@chromium.org</owner> <summary> @@ -60,7 +68,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.ChromeDllPrefetchResult" enum="FilePrefetchResult" - expires_after="2021-12-12"> + expires_after="2022-04-24"> <owner>brucedawson@chromium.org</owner> <owner>jessemckenna@google.com</owner> <summary> @@ -82,7 +90,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.FileDeleteLastRetryError" enum="WinGetLastError" - expires_after="2021-12-31"> + expires_after="2022-05-01"> <owner>grt@chromium.org</owner> <owner>davidbienvenu@chromium.org</owner> <summary> @@ -92,7 +100,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.FileDeleteRetryCount" units="attempts" - expires_after="2021-12-31"> + expires_after="2022-04-10"> <owner>grt@chromium.org</owner> <owner>davidbienvenu@chromium.org</owner> <summary> @@ -104,6 +112,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Windows.FilesystemError{FileOperations}" enum="WinGetLastError" expires_after="M81"> + <obsolete> + Removed in M95. + </obsolete> <owner>grt@chromium.org</owner> <summary> The Windows error code relating to a failed attempt to operate on a file or @@ -145,7 +156,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.HighResolutionTimerUsage" units="%" - expires_after="2022-02-12"> + expires_after="2022-04-24"> <owner>olivierli@chromium.org</owner> <owner>catan-team@chromium.org</owner> <summary> @@ -156,7 +167,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.HypervPresent" enum="BooleanEnabled" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>rkc@chromium.org</owner> <owner>rockot@chromium.org</owner> <summary> @@ -229,6 +240,16 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Windows.Menu.Win11Style" enum="BooleanWin11MenuStyle" + expires_after="M97"> + <owner>kylixrd@chromium.org</owner> + <owner>robliao@chromium.org</owner> + <summary> + Indicates whether Windows 11 style menus are used. Recorded on menu + configuration initialization. + </summary> +</histogram> + <histogram name="Windows.ModuleInspector.ReadCacheResult" enum="InspectionResultsCacheReadResult" expires_after="M78"> <owner>chrisha@chromium.org</owner> @@ -329,6 +350,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Windows.PostOperationState{FileOperations}" enum="PostOperationState" expires_after="M81"> + <obsolete> + Removed in M95. + </obsolete> <owner>grt@chromium.org</owner> <summary> The state of an item in the filesystem following an operation on it. @@ -344,7 +368,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.ProcessorFamily" enum="ProcessorFamily" - expires_after="2021-12-12"> + expires_after="2022-05-01"> <owner>rkc@chromium.org</owner> <owner>rockot@chromium.org</owner> <summary> @@ -356,7 +380,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </histogram> <histogram name="Windows.ProcessorVirtualizationFirmwareEnabled" - enum="BooleanEnabled" expires_after="2021-12-12"> + enum="BooleanEnabled" expires_after="2022-04-24"> <owner>rkc@chromium.org</owner> <owner>rockot@chromium.org</owner> <summary> @@ -367,6 +391,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. <histogram name="Windows.ServiceStatus.SSP" units="WindowsServiceStatus" expires_after="2021-12-12"> + <obsolete> + Removed in M96. + </obsolete> <owner>wfh@chromium.org</owner> <owner>ajgo@chromium.org</owner> <summary> @@ -431,6 +458,17 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. </summary> </histogram> +<histogram name="Windows.UnpinShortcut.ProcessError" enum="BooleanError" + expires_after="2022-04-24"> + <owner>davidbienvenu@chromium.org</owner> + <owner>grt@chromium.org</owner> + <summary> + Indicates whether a connection error occured between the browser and the + shell handler process. This is usually caused by a crash in the utility + process. This is logged every time shortcuts are unpinned from the taskbar. + </summary> +</histogram> + </histograms> </histogram-configuration> diff --git a/chromium/tools/metrics/histograms/update_histogram_enum.py b/chromium/tools/metrics/histograms/update_histogram_enum.py index 23beab635a5..61f06a9d09b 100644 --- a/chromium/tools/metrics/histograms/update_histogram_enum.py +++ b/chromium/tools/metrics/histograms/update_histogram_enum.py @@ -7,6 +7,7 @@ If the file was pretty-printed, the updated version is pretty-printed too. """ +import io import logging import os import re @@ -26,8 +27,6 @@ ENUMS_PATH = histogram_paths.ENUMS_XML class UserError(Exception): - def __init__(self, message): - Exception.__init__(self, message) @property def message(self): @@ -61,13 +60,13 @@ def ReadHistogramValues(filename, start_marker, end_marker, strip_k_prefix): 'k' should be stripped. Returns: - A boolean indicating wheather the histograms.xml file would be changed. + A dictionary from enum value to enum label. Raises: DuplicatedValue: An error when two enum labels share the same value. """ # Read the file as a list of lines - with open(path_util.GetInputFile(filename)) as f: + with io.open(path_util.GetInputFile(filename)) as f: content = f.readlines() START_REGEX = re.compile(start_marker) @@ -218,7 +217,7 @@ def _GetOldAndUpdatedXml(histogram_enum_name, source_enum_values, and returns both in XML format. """ Log('Reading existing histograms from "{0}".'.format(ENUMS_PATH)) - with open(ENUMS_PATH, 'r', encoding='utf-8') as f: + with io.open(ENUMS_PATH, 'r', encoding='utf-8') as f: histograms_doc = minidom.parse(f) f.seek(0) xml = f.read() @@ -302,7 +301,7 @@ def UpdateHistogramFromDict(histogram_enum_name, source_enum_values, Log('Cancelled.') return - with open(ENUMS_PATH, 'w', encoding='utf-8') as f: + with io.open(ENUMS_PATH, 'w', encoding='utf-8') as f: f.write(new_xml) Log('Done.') diff --git a/chromium/tools/metrics/histograms/update_use_counter_feature_enum.py b/chromium/tools/metrics/histograms/update_use_counter_feature_enum.py index eadcab826b9..fc58d2c8ef1 100755 --- a/chromium/tools/metrics/histograms/update_use_counter_feature_enum.py +++ b/chromium/tools/metrics/histograms/update_use_counter_feature_enum.py @@ -19,10 +19,10 @@ from update_histogram_enum import ReadHistogramValues from update_histogram_enum import UpdateHistogramEnum -def PrintEnumForDashboard(enum_dict): - """Prints enum_items formatted for use in uma.py of Chromium dashboard.""" - for key in sorted(enum_dict.iterkeys()): - print(' %d: \'%s\',' % (key, enum_dict[key])) +def PrintEnumForDashboard(dictionary): + """Prints dictionary formatted for use in uma.py of Chromium dashboard.""" + for key, value in sorted(dictionary.items()): + print(' %d: \'%s\',' % (key, value)) if __name__ == '__main__': @@ -40,8 +40,10 @@ if __name__ == '__main__': END_MARKER = '^kNumberOfFeatures' if options.dashboard: - enum_dict, ignored = ReadHistogramValues(source_path, START_MARKER, - END_MARKER, strip_k_prefix=True) + enum_dict = ReadHistogramValues(source_path, + START_MARKER, + END_MARKER, + strip_k_prefix=True) PrintEnumForDashboard(enum_dict) else: UpdateHistogramEnum( diff --git a/chromium/tools/metrics/histograms/validate_format.py b/chromium/tools/metrics/histograms/validate_format.py index d2c7e0a25e7..6918690d559 100755 --- a/chromium/tools/metrics/histograms/validate_format.py +++ b/chromium/tools/metrics/histograms/validate_format.py @@ -5,17 +5,53 @@ """Verifies that the histograms XML file is well-formatted.""" -import os +import logging import sys +import xml.dom.minidom import extract_histograms import histogram_paths import merge_xml +# The allowlist of namespaces that are split across multiple files. +_NAMESPACES_IN_MULTIPLE_FILES = ['chromeos'] + + +def CheckNamespaces(): + namespaces = {} + has_errors = False + # Iterate over HISTOGRAMS_XMLS rather than ALL_XMLS because it's fine for + # histogram namespaces in obsolete_histograms.xml to also appear in + # non-obsolete histograms.xml files. + for path in histogram_paths.HISTOGRAMS_XMLS: + tree = xml.dom.minidom.parse(path) + + def _GetNamespace(node): + return node.getAttribute('name').lower().split('.')[0] + + namespaces_in_file = set( + _GetNamespace(node) for node in extract_histograms.IterElementsWithTag( + tree, 'histogram', depth=3)) + for namespace in namespaces_in_file: + if (namespace in namespaces + and namespace not in _NAMESPACES_IN_MULTIPLE_FILES): + logging.error( + 'Namespace %s has already been used in %s. it\'s recommended to ' + 'put histograms with the same namespace in the same file. If you ' + 'intentionally want to split a namespace across multiple files, ' + 'please add the namespace to the |_NAMESPACES_IN_MULTIPLE_FILES| ' + 'in the validate_format.py.' % (namespace, namespaces[namespace])) + has_errors = True + namespaces[namespace] = path + + return has_errors + + def main(): doc = merge_xml.MergeFiles(histogram_paths.ALL_XMLS, should_expand_owners=True) _, errors = extract_histograms.ExtractHistogramsFromDom(doc) + errors = errors or CheckNamespaces() sys.exit(errors) if __name__ == '__main__': diff --git a/chromium/tools/metrics/structured/OWNERS b/chromium/tools/metrics/structured/OWNERS index a5a1018a222..7c7e11aae14 100644 --- a/chromium/tools/metrics/structured/OWNERS +++ b/chromium/tools/metrics/structured/OWNERS @@ -1 +1,2 @@ tby@chromium.org +jongahn@chromium.org diff --git a/chromium/tools/metrics/structured/codegen.py b/chromium/tools/metrics/structured/codegen.py index 0c87b327e34..7e7fff7c4bf 100644 --- a/chromium/tools/metrics/structured/codegen.py +++ b/chromium/tools/metrics/structured/codegen.py @@ -138,12 +138,15 @@ class EventInfo: self.name_hash = Util.event_name_hash(project_info.name, self.name) self.validator_name = '{}EventValidator'.format(self.name) self.validator_snake_name = Util.camel_to_snake(self.validator_name) + self.project_name = project_info.name self.metrics = event.metrics def build_metric_hash_map(self) -> str: metric_infos = (MetricInfo(metric) for metric in self.metrics) - return ',\n '.join('{{\"{}\", {}::kEventNameHash}}'.format( - metric_info.name, self.validator_name) for metric_info in metric_infos) + return ',\n '.join( + '{{\"{}\", {{ Event::MetricType::{}, UINT64_C({})}}}}'.format( + metric_info.name, metric_info.type_enum, metric_info.hash) + for metric_info in metric_infos) def build_validator_init(self) -> str: return ('static {} {};').format(self.validator_name, @@ -164,12 +167,18 @@ class MetricInfo: if metric.type == 'hmac-string': self.type = 'std::string&' self.setter = 'AddHmacMetric' + self.type_enum = 'kHmac' + self.base_value = 'base::Value(value)' elif metric.type == 'int': self.type = 'int64_t' self.setter = 'AddIntMetric' + self.type_enum = 'kLong' + self.base_value = 'base::Value(base::NumberToString(value))' elif metric.type == 'raw-string': self.type = 'std::string&' self.setter = 'AddRawStringMetric' + self.type_enum = 'kRawString' + self.base_value = 'base::Value(value)' else: raise ValueError('Invalid metric type.') diff --git a/chromium/tools/metrics/structured/gen_events.py b/chromium/tools/metrics/structured/gen_events.py index f0200ecabf2..14952048b8f 100755 --- a/chromium/tools/metrics/structured/gen_events.py +++ b/chromium/tools/metrics/structured/gen_events.py @@ -2,7 +2,6 @@ # Copyright 2021 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. - """A utility for generating classes for structured metrics events. Takes as input a structured.xml file describing all events and produces a C++ @@ -17,7 +16,7 @@ import model import templates parser = argparse.ArgumentParser( - description='Generate structured metrics events') + description='Generate structured metrics events') parser.add_argument('--input', help='Path to structured.xml') parser.add_argument('--output', help='Path to generated files.') @@ -36,12 +35,12 @@ def main(): metric_template=templates.HEADER_METRIC_TEMPLATE).write_file() codegen.Template(data, - args.output, - 'structured_events.cc', - file_template=templates.IMPL_FILE_TEMPLATE, - project_template=templates.IMPL_PROJECT_TEMPLATE, - event_template=templates.IMPL_EVENT_TEMPLATE, - metric_template=templates.IMPL_METRIC_TEMPLATE).write_file() + args.output, + 'structured_events.cc', + file_template=templates.IMPL_FILE_TEMPLATE, + project_template=templates.IMPL_PROJECT_TEMPLATE, + event_template=templates.IMPL_EVENT_TEMPLATE, + metric_template=templates.IMPL_METRIC_TEMPLATE).write_file() return 0 diff --git a/chromium/tools/metrics/structured/gen_mojo_events.py b/chromium/tools/metrics/structured/gen_mojo_events.py new file mode 100755 index 00000000000..279ffdcf455 --- /dev/null +++ b/chromium/tools/metrics/structured/gen_mojo_events.py @@ -0,0 +1,52 @@ +#!/usr/bin/env python3 +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""A utility for generating classes for structured metrics events. + +Takes as input a structured.xml file describing all events and produces a C++ +header and implementation file exposing builders for those events. + +TODO(crbug.com/1249222): Rename this to gen_events.py once migration is +complete. +""" + +import argparse +import sys + +import codegen +import model +import templates_mojo_events as templates + +parser = argparse.ArgumentParser( + description='Generate structured metrics mojo events') +parser.add_argument('--input', help='Path to structured.xml') +parser.add_argument('--output', help='Path to generated files.') + + +def main(): + args = parser.parse_args() + data = model.Model(open(args.input).read()) + + codegen.Template( + data, + args.output, + 'structured_mojo_events.h', + file_template=templates.HEADER_FILE_TEMPLATE, + project_template=templates.HEADER_PROJECT_TEMPLATE, + event_template=templates.HEADER_EVENT_TEMPLATE, + metric_template=templates.HEADER_METRIC_TEMPLATE).write_file() + + codegen.Template(data, + args.output, + 'structured_mojo_events.cc', + file_template=templates.IMPL_FILE_TEMPLATE, + project_template=templates.IMPL_PROJECT_TEMPLATE, + event_template=templates.IMPL_EVENT_TEMPLATE, + metric_template=templates.IMPL_METRIC_TEMPLATE).write_file() + + return 0 + + +if __name__ == '__main__': + sys.exit(main()) diff --git a/chromium/tools/metrics/structured/structured.xml b/chromium/tools/metrics/structured/structured.xml index d868ab65128..c54c47086c6 100644 --- a/chromium/tools/metrics/structured/structured.xml +++ b/chromium/tools/metrics/structured/structured.xml @@ -254,6 +254,155 @@ </event> </project> +<project name="NeutrinoDevices"> + <owner>pdyson@chromium.org</owner> + <id>per-project</id> + <scope>device</scope> + <summary> + Project for recording events to monitor the creation of Neutrino Devices. + </summary> + + <event name="ClientIdChanged"> + <summary> + Records the client id being changed to a new value. This does not include + when the client id is cleared (see ClientIdCleared below). + </summary> + <metric name="InitialClientId" type="hmac-string"> + <summary> + The client id before it is changed. + </summary> + </metric> + <metric name="FinalClientId" type="hmac-string"> + <summary> + The client id after it is changed. + </summary> + </metric> + <metric name="Log2TimeSinceInstallation" type="int"> + <summary> + The time since installation. Recorded as the integer floor of the log + base 2 of the time duration measured in days. Negative values indicate + periods shorter than one day. + </summary> + </metric> + <metric name="Log2TimeSinceMetricsEnabled" type="int"> + <summary> + The time since metrics enabled. Recorded as the integer floor of the log + base 2 of the time duration measured in days. Negative values indicate + periods shorter than one day. + </summary> + </metric> + <metric name="Location" type="int"> + <summary> + An integer indicating the location in the code. This can be used to perform + a partial stack trace to see which code was executed in the lead up to the + client id being changed. + </summary> + </metric> + <metric name="DaysSinceKeyRotation" type="int"> + <summary> + The number of days since the key was rotated. + </summary> + </metric> + </event> + + <event name="ClientIdCleared"> + <summary> + Records when the client id is cleared. + </summary> + <metric name="InitialClientId" type="hmac-string"> + <summary> + The client id before it is changed. + </summary> + </metric> + <metric name="Log2TimeSinceInstallation" type="int"> + <summary> + The time since installation. Recorded as the integer floor of the log + base 2 of the time duration measured in days. Negative values indicate + periods shorter than one day. + </summary> + </metric> + <metric name="Log2TimeSinceMetricsEnabled" type="int"> + <summary> + The time since metrics enabled. Recorded as the integer floor of the log + base 2 of the time duration measured in days. Negative values indicate + periods shorter than one day. + </summary> + </metric> + </event> + + <event name="Enrollment"> + <summary> + Records the enrollment status, either managed or unmanaged. + </summary> + <metric name="ClientId" type="hmac-string"> + <summary> + The client id. + </summary> + </metric> + <metric name="Location" type="int"> + <summary> + An integer indicating the location in the code. This can be used to perform + a partial stack trace to see which code was executed in the lead up to the + client id being changed. + </summary> + </metric> + <metric name="IsManagedDevice" type="int"> + <summary> + Whether the device is managed. 1: Managed, 0: Unmanaged. + </summary> + </metric> + <metric name="IsManagedPolicy" type="int"> + <summary> + Whether the metrics reporting policy is managed. 1: Managed, 0: + Unmanaged. + </summary> + </metric> + </event> + + <event name="CodePoint"> + <summary> + Records that execution reached a particular point in the code. + </summary> + <metric name="ClientId" type="hmac-string"> + <summary> + The client id. + </summary> + </metric> + <metric name="Location" type="int"> + <summary> + An integer indicating the location in the code. This can be used to perform + a partial stack trace to see which code was executed in the lead up to the + client id being changed. + </summary> + </metric> + </event> +</project> + +<project name="StructuredMetrics"> + <owner>jongahn@chromium.org</owner> + <owner>tby@chromium.org</owner> + <id>per-project</id> + <scope>device</scope> + <summary> + Structured Metrics is a logging framework for events. This project is used + for monitoring the framework itself. + </summary> + + <event name="Initialization"> + <summary> + Records metadata about initialization of Structured Metrics and will be + recorded immediately after initialization is successful. Will be sent once + per initialization during browser process initialization. + </summary> + <metric name="Platform" type="int"> + <summary> + The platform for which the client is initialized on. 0: Uninitialized, 1: + ASH_CHROME, 2: LACROS_CHROME. + </summary> + </metric> + </event> +</project> + <project name="TestProjectOne"> <owner>tby@chromium.org</owner> <id>per-project</id> diff --git a/chromium/tools/metrics/structured/templates.py b/chromium/tools/metrics/structured/templates.py index 3d8f86d06a2..c4f96a503ee 100644 --- a/chromium/tools/metrics/structured/templates.py +++ b/chromium/tools/metrics/structured/templates.py @@ -14,6 +14,7 @@ HEADER_FILE_TEMPLATE = """\ #include <cstdint> #include <string> +#include "components/metrics/structured/enums.h" #include "components/metrics/structured/event_base.h" namespace metrics {{ diff --git a/chromium/tools/metrics/structured/templates_mojo_events.py b/chromium/tools/metrics/structured/templates_mojo_events.py new file mode 100644 index 00000000000..09db0d6d625 --- /dev/null +++ b/chromium/tools/metrics/structured/templates_mojo_events.py @@ -0,0 +1,105 @@ +# -*- coding: utf-8 -*- +# Copyright 2021 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. +"""Templates for generating event builder classes for structured metrics. + +TODO(crbug.com/1249222): Rename this file to structured_events once migration is +complete. +""" + +HEADER_FILE_TEMPLATE = """ +// Generated from gen_mojo_events.py. DO NOT EDIT! +// source: structured.xml + +#ifndef {file.guard_path} +#define {file.guard_path} + +#include <cstdint> +#include <string> + +#include "components/metrics/structured/event.h" + +namespace metrics {{ +namespace structured {{ +namespace events {{ +namespace v2 {{ + +{project_code} + +}} // namespace v2 +}} // namespace events +}} // namespace structured +}} // namespace metrics + +#endif // {file.guard_path}\ +""" + +HEADER_PROJECT_TEMPLATE = """\ +namespace {project.namespace} {{ + +{event_code}\ +}} // namespace {project.namespace} + +""" + +HEADER_EVENT_TEMPLATE = """\ +class {event.name} final : public ::metrics::structured::Event {{ + public: + {event.name}(); + ~{event.name}() override; + + {metric_code}\ +}}; + +""" + +HEADER_METRIC_TEMPLATE = """\ + {event.name}& Set{metric.name}(const {metric.type} value); +""" + +IMPL_FILE_TEMPLATE = """\ +// Generated from gen_events.py. DO NOT EDIT! +// source: structured.xml + +#include "components/metrics/structured/structured_mojo_events.h" + +#include "base/strings/string_number_conversions.h" +#include "base/values.h" + +namespace metrics {{ +namespace structured {{ +namespace events {{ +namespace v2 {{ + +{project_code} +}} // namespace v2 +}} // namespace events +}} // namespace structured +}} // namespace metrics\ +""" + +IMPL_PROJECT_TEMPLATE = """\ +namespace {project.namespace} {{ + +{event_code}\ +}} // namespace {project.namespace} + +""" + +IMPL_EVENT_TEMPLATE = """\ +{event.name}::{event.name}() : + ::metrics::structured::Event(\"{event.project_name}\", + \"{event.name}\") {{}} +{event.name}::~{event.name}() = default; +{metric_code}\ +""" + +IMPL_METRIC_TEMPLATE = """\ +{event.name}& {event.name}::Set{metric.name}(const {metric.type} value) {{ + AddMetric(\"{metric.name}\", Event::MetricType::{metric.type_enum}, + {metric.base_value}); + return *this; +}} + +""" diff --git a/chromium/tools/metrics/structured/templates_validator.py b/chromium/tools/metrics/structured/templates_validator.py index 83b42025541..9430b780537 100644 --- a/chromium/tools/metrics/structured/templates_validator.py +++ b/chromium/tools/metrics/structured/templates_validator.py @@ -40,9 +40,12 @@ IMPL_FILE_TEMPLATE = """\ #include "base/containers/fixed_flat_map.h" #include "base/strings/string_piece.h" +#include "components/metrics/structured/enums.h" +#include "components/metrics/structured/event.h" #include "components/metrics/structured/event_validator.h" #include "components/metrics/structured/project_validator.h" #include "third_party/abseil-cpp/absl/types/optional.h" +#include "third_party/metrics_proto/structured_data.pb.h" namespace metrics {{ namespace structured {{ @@ -84,22 +87,31 @@ class {project.validator} final : public ::metrics::structured::ProjectValidator {{ public: {project.validator}(); - ~{project.validator}() override; + ~{project.validator}(); absl::optional<const EventValidator*> GetEventValidator( - const std::string& event_name) override; + const std::string& event_name) const override; static constexpr uint64_t kProjectNameHash = UINT64_C({project.name_hash}); + static constexpr IdType kIdType = IdType::{project.id_type}; + static constexpr IdScope kIdScope = IdScope::{project.id_scope}; + static constexpr EventType kEventType = + StructuredEventProto_EventType_{project.event_type}; }}; {project.validator}::{project.validator}() : - ::metrics::structured::ProjectValidator({project.validator}::kProjectNameHash) + ::metrics::structured::ProjectValidator( + {project.validator}::kProjectNameHash, + {project.validator}::kIdType, + {project.validator}::kIdScope, + {project.validator}::kEventType +) {{}} {project.validator}::~{project.validator}() = default; absl::optional<const EventValidator*> {project.validator}::GetEventValidator( - const std::string& event_name) {{ + const std::string& event_name) const {{ const auto it = k{project.validator}EventMap.find(event_name); if (it == k{project.validator}EventMap.end()) return absl::nullopt; @@ -130,8 +142,8 @@ class {event.validator_name} final : static constexpr uint64_t kEventNameHash = UINT64_C({event.name_hash}); - absl::optional<uint64_t> GetMetricHash(const std::string& metric_name) - const override; + absl::optional<MetricMetadata> + GetMetricMetadata(const std::string& metric_name) const override; }}; {event.validator_name}::{event.validator_name}() : @@ -140,10 +152,11 @@ class {event.validator_name} final : {event.validator_name}::~{event.validator_name}() = default; -absl::optional<uint64_t> {event.validator_name}::GetMetricHash( - const std::string& metric_name) const {{ - static constexpr auto metric_hash_map = base::MakeFixedFlatMap< - base::StringPiece, uint64_t>({{ +absl::optional<EventValidator::MetricMetadata> +{event.validator_name}::GetMetricMetadata(const std::string& metric_name) +const {{ + static constexpr auto metric_hash_map = base::MakeFixedFlatMap< + base::StringPiece, EventValidator::MetricMetadata>({{ {metric_hash_map} }}); const auto* it = metric_hash_map.find(metric_name); diff --git a/chromium/tools/metrics/ukm/ukm.xml b/chromium/tools/metrics/ukm/ukm.xml index 575a222310c..6ecea5fab1c 100644 --- a/chromium/tools/metrics/ukm/ukm.xml +++ b/chromium/tools/metrics/ukm/ukm.xml @@ -155,11 +155,25 @@ be describing additional metrics about the same event. Records an enum value representing which action in the accuracy tip was taken. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> <metric name="TimeSpent"> <summary> The amount of time spent on the dialog until it was closed. In seconds. </summary> + <aggregation> + <history> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> </metric> </event> @@ -174,6 +188,13 @@ be describing additional metrics about the same event. <summary> The accuracy tip status that was determined for a pageload. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> </event> @@ -440,6 +461,28 @@ be describing additional metrics about the same event. site-wide framework and not a reader experience. </summary> </metric> + <metric + name="SubFrame.InteractiveTiming.AverageUserInteractionLatencyOverBudget.MaxEventduration"> + <summary> + The average value of user interaction latency above budget of a page load + in AMP subframes, in ms. For this metric, we measure the latency of user + interactions by Responsiveness.UserInteraction.MaxEventDuration and we + deduct a budget from the original value. If the latency value is below the + budget, it will be treated as 0 ms. Each type of interaction has its own + budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.AverageUserInteractionLatencyOverBudget.TotalEventduration"> + <summary> + The average value of user interaction latency above budget of a page load + in AMP subframes, in ms. For this metric, we measure the latency of user + interactions by Responsiveness.UserInteraction.TotalEventDuration and we + deduct a budget from the original value. If the latency value is below the + budget, it will be treated as 0 ms. Each type of interaction has its own + budget. + </summary> + </metric> <metric name="SubFrame.InteractiveTiming.FirstInputDelay3"> <obsolete> Removed July 2019 in favor of FirstInputDelay4. @@ -460,6 +503,112 @@ be describing additional metrics about the same event. </summary> </metric> <metric + name="SubFrame.InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile.MaxEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page load in AMP subframes, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile.TotalEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page load in AMP subframes, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile2.MaxEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page load in AMP subframes, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile2.TotalEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page load in AMP subframes, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.SumOfUserInteractionLatencyOverBudget.MaxEventduration"> + <summary> + The sum of user interaction latency above budget of a page load in AMP + subframes, in ms. For this metric, we measure the latency of user + interactions by Responsiveness.UserInteraction.MaxEventDuration and we + deduct a budget from the original value. If the latency value is below the + budget, it will be treated as 0 ms. Each type of interaction has its own + budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.SumOfUserInteractionLatencyOverBudget.TotalEventduration"> + <summary> + The sum of user interaction latency above budget of a page load in AMP + subframes, in ms. For this metric, we measure the latency of user + interactions by Responsiveness.UserInteraction.TotalEventDuration and we + deduct a budget from the original value. If the latency value is below the + budget, it will be treated as 0 ms. Each type of interaction has its own + budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.WorstUserInteractionLatency.MaxEventduration"> + <summary> + The maximum value of high percentile of user interaction latency above + budget of a page load in AMP subframes, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.WorstUserInteractionLatency.TotalEventduration"> + <summary> + The maximum value of high percentile of user interaction latency above + budget of a page load in AMP subframes, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.WorstUserInteractionLatencyOverBudget.MaxEventduration"> + <summary> + The maximum value of user interaction latency above budget of a page load + in AMP subframes, in ms. For this metric, we measure the latency of user + interactions by Responsiveness.UserInteraction.MaxEventDuration and we + deduct a budget from the original value. If the latency value is below the + budget, it will be treated as 0 ms. Each type of interaction has its own + budget. + </summary> + </metric> + <metric + name="SubFrame.InteractiveTiming.WorstUserInteractionLatencyOverBudget.TotalEventduration"> + <summary> + The maximum value of user interaction latency above budget of a page load + in AMP subframes, in ms. For this metric, we measure the latency of user + interactions by Responsiveness.UserInteraction.TotalEventDuration and we + deduct a budget from the original value. If the latency value is below the + budget, it will be treated as 0 ms. Each type of interaction has its own + budget. + </summary> + </metric> + <metric name="SubFrame.LayoutInstability.AverageCumulativeShiftScore.SessionWindow.Gap5000ms"> <obsolete> Deprecated 06/2021. @@ -683,6 +832,27 @@ be describing additional metrics about the same event. </metric> </event> +<event name="Android.DarkTheme.AutoDarkMode"> + <owner>nemco@google.com</owner> + <owner>wenyufu@chromium.org</owner> + <summary> + Recorded when the user changes auto-dark theming for a site through the app + menu. + </summary> + <metric name="DisabledByUser" enum="Boolean"> + <summary> + A boolean signaling that auto-dark theming has been disabled. + </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> + </metric> +</event> + <event name="Android.MultiWindowChangeActivity"> <owner>gangwu@chromium.org</owner> <owner>fgorski@chromium.org</owner> @@ -2031,6 +2201,25 @@ be describing additional metrics about the same event. </metric> </event> +<event name="AutofillAssistant.Timing"> + <owner>arbesser@google.com</owner> + <owner>hluca@google.com</owner> + <owner>sandromaggi@google.com</owner> + <metric name="TriggerConditionEvaluationMs"> + <summary> + The time it took to evaluate the trigger conditions, in milliseconds. Only + successful evaluations are recorded. + </summary> + <aggregation> + <history> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> +</event> + <event name="BackForwardCacheDisabledForRenderFrameHostReason"> <owner>altimin@chromium.org</owner> <owner>hajimehoshi@chromium.org</owner> @@ -2071,6 +2260,28 @@ be describing additional metrics about the same event. </metric> </event> +<event name="BackForwardCacheDisallowActivationReason"> + <owner>altimin@chromium.org</owner> + <owner>hajimehoshi@chromium.org</owner> + <owner>fergal@chromium.org</owner> + <summary> + Recorded at a history commit for each reason passed to + RenderFrameHost::IsInactiveAndDisallowActivation. The source IDs match with + the source IDs of HistoryNavigation events. + </summary> + <metric name="Reason" enum="BackForwardCacheDisallowActivationReason"> + <summary> + For history navigations, records the reason passed to + RenderFrameHost::IsInactiveAndDisallowActivation. + + The metric is recorded when a history navigation commits and emits a + sample for each reason. One history navigation can emit multiple reasons, + and these reasons are recorded as multiple events with the same source ID + based on the navigation ID. + </summary> + </metric> +</event> + <event name="BackgroundFetch"> <owner>nator@chromium.org</owner> <owner>rayankans@chromium.org</owner> @@ -3969,15 +4180,56 @@ be describing additional metrics about the same event. </history> </aggregation> </metric> + <metric name="InstallReason" enum="InstallReason"> + <summary> + An enum that records the reason why the app was installed. + </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> + </metric> <metric name="InstallSource" enum="InstallSource"> + <obsolete> + Removed in M96. Replaced with InstallReason. + </obsolete> <summary> An enum that records how the app was installed. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> + </metric> + <metric name="InstallSource2" enum="InstallSource2"> + <summary> + An enum that records where the app was installed. + </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> <metric name="InstallTime" enum="InstallTime"> <summary> An enum that records when the app was installed. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> <metric name="UserDeviceMatrix" enum="UserDeviceMatrix"> <summary> @@ -4018,6 +4270,13 @@ be describing additional metrics about the same event. <summary> An enum that records where the app was launched. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> <metric name="UserDeviceMatrix" enum="UserDeviceMatrix"> <summary> @@ -4058,6 +4317,13 @@ be describing additional metrics about the same event. <summary> An enum that records how the app was uninstalled. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> <metric name="UserDeviceMatrix" enum="UserDeviceMatrix"> <summary> @@ -4099,6 +4365,13 @@ be describing additional metrics about the same event. <summary> The milliseconds that the app was used. </summary> + <aggregation> + <history> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> </metric> <metric name="UserDeviceMatrix" enum="UserDeviceMatrix"> <summary> @@ -4713,6 +4986,20 @@ be describing additional metrics about the same event. </metric> </event> +<event name="CrossOriginSubframeWithoutEmbeddingControl"> + <owner>clamy@chromium.org</owner> + <summary> + Recorded when a subframe is embedded in a cross-origin context without + having a CSP frame-ancestor header or an XFO header. + </summary> + <metric name="SubframeEmbedded"> + <summary> + Mesaures the number of pages with subframes embedded in cross-origin + contexts without having a CSP frame-ancestor header or an XFO header. + </summary> + </metric> +</event> + <event name="DataReductionProxy" singular="True"> <owner>robertogden@chromium.org</owner> <summary> @@ -5564,6 +5851,18 @@ be describing additional metrics about the same event. </history> </aggregation> </metric> + <metric name="PinchInputType" enum="EventLatencyPinchInputType"> + <summary> + Type of the input device for pinch events. + </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> + </metric> <metric name="RendererCompositorFinishedToActivation"> <summary> The time from when the event processing is finished on the renderer @@ -5856,7 +6155,7 @@ be describing additional metrics about the same event. </metric> <metric name="ScrollInputType" enum="EventLatencyScrollInputType"> <summary> - Type of the input device for scroll and pinch events. + Type of the input device for scroll events. </summary> <aggregation> <history> @@ -6809,6 +7108,118 @@ be describing additional metrics about the same event. </history> </aggregation> </metric> + <metric name="SmoothnessBad"> + <summary> + The percentage of sliding windows with bad smoothness, or a + PercentDroppedFrames of 12% to 25%. + </summary> + <aggregation> + <history> + <index fields="profile.country"/> + <index fields="profile.form_factor"/> + <index fields="profile.system_ram"/> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> + <metric name="SmoothnessGood"> + <summary> + The percentage of sliding windows with good smoothness, or a + PercentDroppedFrames of 3% to 6%. + </summary> + <aggregation> + <history> + <index fields="profile.country"/> + <index fields="profile.form_factor"/> + <index fields="profile.system_ram"/> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> + <metric name="SmoothnessOkay"> + <summary> + The percentage of sliding windows with okay smoothness, or a + PercentDroppedFrames of 6% to 12%. + </summary> + <aggregation> + <history> + <index fields="profile.country"/> + <index fields="profile.form_factor"/> + <index fields="profile.system_ram"/> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> + <metric name="SmoothnessVeryBad25to50"> + <summary> + The percentage of sliding windows with a subset of very bad smoothness, or + a PercentDroppedFrames of 25% to 50%. + </summary> + <aggregation> + <history> + <index fields="profile.country"/> + <index fields="profile.form_factor"/> + <index fields="profile.system_ram"/> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> + <metric name="SmoothnessVeryBad50to75"> + <summary> + The percentage of sliding windows with a subset of very bad smoothness, or + a PercentDroppedFrames of 50% to 75%. + </summary> + <aggregation> + <history> + <index fields="profile.country"/> + <index fields="profile.form_factor"/> + <index fields="profile.system_ram"/> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> + <metric name="SmoothnessVeryBad75to100"> + <summary> + The percentage of sliding windows with a subset of very bad smoothness, or + a PercentDroppedFrames of 75% to 100%. + </summary> + <aggregation> + <history> + <index fields="profile.country"/> + <index fields="profile.form_factor"/> + <index fields="profile.system_ram"/> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> + <metric name="SmoothnessVeryGood"> + <summary> + The percentage of sliding windows with very good smoothness, or a + PercentDroppedFrames of 0% to 3%. + </summary> + <aggregation> + <history> + <index fields="profile.country"/> + <index fields="profile.form_factor"/> + <index fields="profile.system_ram"/> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> + </metric> <metric name="TimingSinceFCPWorstCase"> <summary> The Time From FCP when the worst case happened @@ -7393,6 +7804,40 @@ be describing additional metrics about the same event. </metric> </event> +<event name="HistoryClusters" singular="True"> + <owner>chrome-memories@google.com</owner> + <owner>mcrouse@chromium.org</owner> + <summary> + Metrics that capture the iteractions with HistoryClusters, or Journeys, This + will be recorded once per visit to the HistoryClusters UI and logged when + the UI is closed or navigated away from. + </summary> + <metric name="FinalState" enum="HistoryClustersFinalState"> + <summary> + The final state, or outcome, of an interaction on the HistoryClusters UI. + </summary> + </metric> + <metric name="InitialState" enum="HistoryClustersInitialState"> + <summary> + The initial state that describes how an interaction with the + HistoryClusters UI was started. + </summary> + </metric> + <metric name="NumQueries"> + <summary> + The number of times the user performed a query on the HistoryClusters UI + during this interaction. This can include partial queries that occur due + to the UI's query timing. + </summary> + </metric> + <metric name="NumTogglesToBasicHistory"> + <summary> + The number of times the user toggled to the basic history page during this + interaction with the HistoryClusters UI. + </summary> + </metric> +</event> + <event name="HistoryManipulationIntervention"> <owner>shivanisha@chromium.org</owner> <summary> @@ -7425,6 +7870,28 @@ be describing additional metrics about the same event. cumulative layout shift score described in the explainer. </summary> </metric> + <metric + name="AverageUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.MaxEventduration"> + <summary> + The average value of user interaction latency above budget of a page after + it is restored from the back-forward, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="AverageUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.TotalEventduration"> + <summary> + The average value of user interaction latency above budget of a page after + it is restored from the back-forward, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> <metric name="BackForwardCache.BlocklistedFeatures" enum="WebSchedulerTrackedFeature"> <summary> @@ -7497,6 +7964,18 @@ be describing additional metrics about the same event. cache and the first requestAnimationFrame time in milliseconds. </summary> </metric> + <metric name="ForegroundDurationAfterBackForwardCacheRestore"> + <summary> + For page loads that start in the foreground, measures the duration of time + in milliseconds until one of the following events occurs: the load of the + main resource fails, the page load is stopped, the tab hosting the page is + closed, the render process hosting the page goes away, a new navigation + which later commits is initiated in the same tab, or the tab hosting the + page is backgrounded. This metric has a very long tail, for pages that + spend a long period of time in the foreground. As such, use of the mean or + tail values are not recommended. + </summary> + </metric> <metric name="LastCommittedCrossDocumentNavigationSourceIdForTheSameDocument"> <summary> For history navigations and reloads, the source id of the previous @@ -7620,6 +8099,72 @@ be describing additional metrics about the same event. cache and the second requestAnimationFrame time in milliseconds. </summary> </metric> + <metric + name="SlowUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.HighPercentile.MaxEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page after it is restored from the back-forward, in ms. For + this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SlowUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.HighPercentile.TotalEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page after it is restored from the back-forward, in ms. For + this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SlowUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.HighPercentile2.MaxEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page after it is restored from the back-forward, in ms. For + this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SlowUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.HighPercentile2.TotalEventduration"> + <summary> + An approximation of high percentile of user interaction latency above + budget of a page after it is restored from the back-forward, in ms. For + this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SumOfUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.MaxEventduration"> + <summary> + The sum of user interaction latency above budget of a page after it is + restored from the back-forward, in ms. For this metric, we measure the + latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="SumOfUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.TotalEventduration"> + <summary> + The sum of user interaction latency above budget of a page after it is + restored from the back-forward, in ms. For this metric, we measure the + latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> <metric name="ThirdRequestAnimationFrameAfterBackForwardCacheRestore"> <summary> Measures the time duration between the page restore from back-forward @@ -7636,6 +8181,46 @@ be describing additional metrics about the same event. seconds. </summary> </metric> + <metric + name="WorstUserInteractionLatencyAfterBackForwardCacheRestore.MaxEventduration"> + <summary> + The maximum value of user interaction latency of a page after it is + restored from the back-forward, in ms. For this metric, we measure the + latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration. + </summary> + </metric> + <metric + name="WorstUserInteractionLatencyAfterBackForwardCacheRestore.TotalEventduration"> + <summary> + The maximum value of user interaction latency of a page after it is + restored from the back-forward, in ms. For this metric, we measure the + latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration. + </summary> + </metric> + <metric + name="WorstUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.MaxEventduration"> + <summary> + The maximum value of user interaction latency above budget of a page after + it is restored from the back-forward, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we reduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="WorstUserInteractionLatencyOverBudgetAfterBackForwardCacheRestore.TotalEventduration"> + <summary> + The maximum value of user interaction latency above budget of a page after + it is restored from the back-forward, in ms. For this metric, we measure + the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we reduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> </event> <event name="Identifiability"> @@ -7767,6 +8352,13 @@ be describing additional metrics about the same event. <summary> The type of the assistive suggestion which is triggered. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> </event> @@ -7884,28 +8476,55 @@ be describing additional metrics about the same event. True if the page was added by the user tapping on the Messages prompt to save to Reading List. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> </event> <event name="IOS.PageReadability"> <owner>thegreenfrog@chromium.org</owner> <summary> - Logged when the Distilibility score of the current page is returned. - Muliplied by 10X to get tenth digit granularity. 0.1 granularity will be - recorded for scores between 0.5 and 1.5. Otherwise, the granularity will be - 0.5. + Logged when the Distilibility score of the current page is returned and the + Reading List Message is shown. Muliplied by 10X to get tenth digit + granularity. 0.1 granularity will be recorded for scores between 0.5 and + 1.5. Otherwise, the granularity will be 0.5. </summary> + <metric name="DidAccept" enum="Boolean"> + <summary> + True if the user tapped on the Messages prompt to save the current page to + Reading List. + </summary> + </metric> <metric name="DistilibilityLongScore"> <summary> Distilibility score value indicating the "long readability" of the page. </summary> + <aggregation> + <history> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> </metric> <metric name="DistilibilityScore"> <summary> Distilibility score value indicating the "readability" of the page. </summary> + <aggregation> + <history> + <statistics> + <quantiles type="std-percentiles"/> + </statistics> + </history> + </aggregation> </metric> </event> @@ -9417,6 +10036,13 @@ be describing additional metrics about the same event. Encryption type of the audio stream such as whether audio is encrypted and if so whether it has clear lead. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> <metric name="ContainerName"> <summary> @@ -9475,6 +10101,13 @@ be describing additional metrics about the same event. Type of media::Renderer used for the playback. In most cases we do not support dynamically changing RendererType during one playback. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> <metric name="TimeToFirstFrame"> <summary> @@ -9506,6 +10139,13 @@ be describing additional metrics about the same event. Encryption type of the video stream such as whether video is encrypted and if so whether it has clear lead. </summary> + <aggregation> + <history> + <statistics> + <enumeration/> + </statistics> + </history> + </aggregation> </metric> </event> @@ -9657,11 +10297,17 @@ be describing additional metrics about the same event. </summary> </metric> <metric name="Net"> + <obsolete> + Deprecated as of 09/2021. + </obsolete> <summary> Measure of memory allocated by network sockets and caches. </summary> </metric> <metric name="Net.UrlRequestContext"> + <obsolete> + Deprecated as of 09/2021. + </obsolete> <summary> Measure of memory allocated by all network requests. </summary> @@ -10607,6 +11253,9 @@ be describing additional metrics about the same event. Metrics associated with main frame navigation. </summary> <metric name="EarlyHintsForFinalRequest"> + <obsolete> + Deprecated 09/2021 + </obsolete> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -10616,6 +11265,9 @@ be describing additional metrics about the same event. </summary> </metric> <metric name="EarlyHintsForFirstRequest"> + <obsolete> + Deprecated 09/2021 + </obsolete> <owner>nhiroki@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -10851,7 +11503,11 @@ be describing additional metrics about the same event. </metric> <metric name="IsRoaming" enum="Boolean"> <summary> - Whether the device was roaming when the background task ran. + Whether the device was roaming when the background task ran. This field is + only set if we can determine whether the network was roaming or not. This + means in cases where the HTTP probe was cancelled or we ecountered an + error while getting whether the network is roaming or not that this field + will be null. </summary> </metric> <metric name="LocalHourOfDayStart"> @@ -11052,6 +11708,9 @@ be describing additional metrics about the same event. </event> <event name="OptimizationGuideAutotuning"> + <obsolete> + Removed 8/2021. + </obsolete> <owner>sophiechang@chromium.org</owner> <owner>mcrouse@chromium.org</owner> <summary> @@ -11070,6 +11729,28 @@ be describing additional metrics about the same event. </metric> </event> +<event name="PageContentAnnotations" singular="True"> + <owner>chrome-intelligence-core@google.com</owner> + <owner>mcrouse@chromium.org</owner> + <summary> + Metrics on the content annotations of the page, one record per page load + commit and has an annotation calculated on it. The metrics are recorded in a + RAPPOR-style with low-entropy so only aggregate analysis can be performed. + </summary> + <metric name="VisibilityScore"> + <summary> + Records a low entropy respresentation of the visibility score output by a + content annotations model. The low entropy value is calculated using a + RAPPOR-style calculation to enable analysis only on aggregated results. + The raw score is between 0 and 1, scaled to between 0 and 100. The score + is then placed into one of 16 linearly spaced buckets by dividing the + score by the bucket size and taking the floor. The resulting bucket value + has noise added with a probability of .5 where the noise is randomly + applied to each individual bit. + </summary> + </metric> +</event> + <event name="PageDomainInfo"> <owner>uthakore@chromium.org</owner> <owner>invernizzi@chromium.org</owner> @@ -11396,6 +12077,26 @@ be describing additional metrics about the same event. could be evicted by Android anytime after that happens. </summary> </metric> + <metric + name="InteractiveTiming.AverageUserInteractionLatencyOverBudget.MaxEventDuration"> + <summary> + The average value of user interaction latency above budget of a page load, + in ms. For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.AverageUserInteractionLatencyOverBudget.TotalEventDuration"> + <summary> + The average value of user interaction latency above budget of a page load, + in ms. For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> <metric name="InteractiveTiming.FirstInputDelay"> <obsolete> Deprecated on January 2019 in favor of InteractiveTiming.FirstInputDelay2, @@ -11681,6 +12382,70 @@ be describing additional metrics about the same event. </history> </aggregation> </metric> + <metric + name="InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile.MaxEventDuration"> + <summary> + An approximation of a high percentile of user interaction latency above + budget of a page load, in ms. For this metric, we measure the latency of + user interactions by Responsiveness.UserInteraction.MaxEventDuration and + we deduct a budget from the original value. If the latency value is below + the budget, it will be treated as 0 ms. Each type of interaction has its + own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile.TotalEventDuration"> + <summary> + An approximation of a high percentile of user interaction latency above + budget of a page load, in ms. For this metric, we measure the latency of + user interactions by Responsiveness.UserInteraction.TotalEventDuration and + we deduct a budget from the original value. If the latency value is below + the budget, it will be treated as 0 ms. Each type of interaction has its + own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile2.MaxEventDuration"> + <summary> + An approximation of a high percentile of user interaction latency above + budget of a page load, in ms. For this metric, we measure the latency of + user interactions by Responsiveness.UserInteraction.MaxEventDuration and + we deduct a budget from the original value. If the latency value is below + the budget, it will be treated as 0 ms. Each type of interaction has its + own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.SlowUserInteractionLatencyOverBudget.HighPercentile2.TotalEventDuration"> + <summary> + An approximation of a high percentile of user interaction latency above + budget of a page load, in ms. For this metric, we measure the latency of + user interactions by Responsiveness.UserInteraction.TotalEventDuration and + we deduct a budget from the original value. If the latency value is below + the budget, it will be treated as 0 ms. Each type of interaction has its + own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.SumOfUserInteractionLatencyOverBudget.MaxEventDuration"> + <summary> + The sum of user interaction latency above budget of a page load, in ms. + For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.SumOfUserInteractionLatencyOverBudget.TotalEventDuration"> + <summary> + The sum of user interaction latency above budget of a page load, in ms. + For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> <metric name="InteractiveTiming.TotalAdjustedInputDelay"> <summary> sum(max(Input Delay - 50, 0)). The Input Delay refers to the duration @@ -11709,6 +12474,71 @@ be describing additional metrics about the same event. </history> </aggregation> </metric> + <metric + name="InteractiveTiming.TotalUserInteractionLatencyOverBudget.MaxEventDuration"> + <obsolete> + Deprecated 10/2021. Replaced by + "InteractiveTiming.SumOfUserInteractionLatencyOverBudget.MaxEventDuration". + </obsolete> + <summary> + The sum of user interaction latency above budget of a page load, in ms. + For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.TotalUserInteractionLatencyOverBudget.TotalEventDuration"> + <obsolete> + Deprecated 10/2021. Replaced by + "InteractiveTiming.SumOfUserInteractionLatencyOverBudget.TotalEventDuration". + </obsolete> + <summary> + The sum of user interaction latency above budget of a page load, in ms. + For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric name="InteractiveTiming.WorstUserInteractionLatency.MaxEventDuration"> + <summary> + The maximum value of user interaction latency of a page load, in ms. For + this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration. Each type of interaction + has its own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.WorstUserInteractionLatency.TotalEventDuration"> + <summary> + The maximum value of user interaction latency of a page load, in ms. For + this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration. Each type of + interaction has its own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.WorstUserInteractionLatencyOverBudget.MaxEventDuration"> + <summary> + The maximum value of user interaction latency above budget of a page load, + in ms. For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.MaxEventDuration and we deduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> + <metric + name="InteractiveTiming.WorstUserInteractionLatencyOverBudget.TotalEventDuration"> + <summary> + The maximum value of user interaction latency above budget of a page load, + in ms. For this metric, we measure the latency of user interactions by + Responsiveness.UserInteraction.TotalEventDuration and we reduct a budget + from the original value. If the latency value is below the budget, it will + be treated as 0 ms. Each type of interaction has its own budget. + </summary> + </metric> <metric name="IsCrossProcessNavigation"> <owner>altimin@chromium.org</owner> <owner>arthursonzogni@chromium.org</owner> @@ -12123,6 +12953,17 @@ be describing additional metrics about the same event. </summary> </metric> <metric name="Net.ImageBytes"> + <obsolete> + Deprecated 09/2021 in favor of Net.ImageBytes2. + </obsolete> + <summary> + The total number of bytes loaded from the network for images on the page. + This is rounded down to the nearest exponential bucket (with a bucket + spacing factor of 1.3). On mobile this only records bytes up until the + page/app is backgrounded. + </summary> + </metric> + <metric name="Net.ImageBytes2"> <summary> The total number of bytes loaded from the network for images on the page. This is rounded down to the nearest exponential bucket (with a bucket @@ -12131,6 +12972,17 @@ be describing additional metrics about the same event. </summary> </metric> <metric name="Net.ImageSubframeBytes"> + <obsolete> + Deprecated 09/2021 in favor of Net.ImageSubframeBytes2. + </obsolete> + <summary> + The total number of bytes loaded from the network for images on the + subframes of the page. This is rounded down to the nearest exponential + bucket (with a bucket spacing factor of 1.3). On mobile this only records + bytes up until the page/app is backgrounded. + </summary> + </metric> + <metric name="Net.ImageSubframeBytes2"> <summary> The total number of bytes loaded from the network for images on the subframes of the page. This is rounded down to the nearest exponential @@ -12139,6 +12991,9 @@ be describing additional metrics about the same event. </summary> </metric> <metric name="Net.JavaScriptBytes"> + <obsolete> + Deprecated 09/2021 in favor of Net.JavaScriptBytes2. + </obsolete> <summary> The sum of decoded body lengths of all JavaScript resouces that completed loading on the page. This is rounded down to the nearest exponential @@ -12146,7 +13001,18 @@ be describing additional metrics about the same event. bytes up until the page/app is backgrounded. </summary> </metric> + <metric name="Net.JavaScriptBytes2"> + <summary> + The sum of decoded body lengths of all JavaScript resouces that completed + loading on the page. This is rounded down to the nearest exponential + bucket (with a bucket spacing factor of 1.3). On mobile this only records + bytes up until the page/app is backgrounded. + </summary> + </metric> <metric name="Net.JavaScriptMaxBytes"> + <obsolete> + Deprecated 09/2021 in favor of Net.JavaScriptMaxBytes2. + </obsolete> <summary> The max of decoded body lengths of all JavaScript resouces that completed loading on the page. This is rounded down to the nearest exponential @@ -12154,7 +13020,26 @@ be describing additional metrics about the same event. bytes up until the page/app is backgrounded. </summary> </metric> + <metric name="Net.JavaScriptMaxBytes2"> + <summary> + The max of decoded body lengths of all JavaScript resouces that completed + loading on the page. This is rounded down to the nearest exponential + bucket (with a bucket spacing factor of 1.3). On mobile this only records + bytes up until the page/app is backgrounded. + </summary> + </metric> <metric name="Net.MediaBytes"> + <obsolete> + Deprecated 09/2021 in favor of Net.MediaBytes2. + </obsolete> + <summary> + The total number of bytes loaded from the network for media (video, audio) + on the page. This is rounded down to the nearest exponential bucket (with + a bucket spacing factor of 1.3). On mobile this only records bytes up + until the page/app is backgrounded. + </summary> + </metric> + <metric name="Net.MediaBytes2"> <summary> The total number of bytes loaded from the network for media (video, audio) on the page. This is rounded down to the nearest exponential bucket (with @@ -12382,6 +13267,18 @@ be describing additional metrics about the same event. </history> </aggregation> </metric> + <metric + name="PaintTiming.NavigationToLargestContentfulPaint2.CrossSiteSubFrame"> + <summary> + Similar to PaintTiming.NavigationToLargestContentfulPaint2, this measures + the time in milliseconds from the navigation start of the top-level frame + to the time when the page first paints the largest content (text or image) + in the cross-site subframe which is the top candidate of largest + contentful paint. This metric is computed separately from the page-level + LCP, it's recorded even in page loads where the page-level LCP is not that + cross-site LCP. + </summary> + </metric> <metric name="PaintTiming.NavigationToLargestContentfulPaint2.MainFrame"> <summary> Measures the time in milliseconds from navigation timing's navigation @@ -12509,8 +13406,8 @@ be describing additional metrics about the same event. </event> <event name="PageLoad.ServiceWorkerControlled" singular="True"> - <owner>bmcquade@chromium.org</owner> - <owner>falken@chromium.org</owner> + <owner>wanderview@chromium.org</owner> + <owner>asamidoi@chromium.org</owner> <summary> Recorded for page loads controlled by a service worker. </summary> @@ -13075,6 +13972,9 @@ be describing additional metrics about the same event. </event> <event name="PerfectHeuristics" singular="True"> + <obsolete> + Implementation for these experiments were removed in M94. + </obsolete> <owner>dom@chromium.org</owner> <owner>chrome-loading@google.com</owner> <summary> @@ -13411,6 +14311,150 @@ be describing additional metrics about the same event. An enum of type PermissionSourceUI. The UI surface for this action. </summary> </metric> + <metric name="Stats.AllPrompts.Count"> + <summary> + Total number of prompts shown to the user in the last 28 days. The count + is bucketed. The bucket minimums being 20, 15, 12, 10, 9, 8, 7, 6, 5, 4 + and 0. The correct bucket is the first one that is smaller or equal to the + prompt count. + </summary> + </metric> + <metric name="Stats.AllPrompts.DenyRate"> + <summary> + What percentage of prompts from the last 28 days did the user deny. + Aggregated across all origins, all PermissionTypes and all + PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.AllPrompts.DismissRate"> + <summary> + What percentage of prompts from the last 28 days did the user dismiss. + Aggregated across all origins, all PermissionTypes and all + PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.AllPrompts.GrantRate"> + <summary> + What percentage of prompts from the last 28 days did the user grant. + Aggregated across all origins, all PermissionTypes and all + PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.AllPrompts.IgnoreRate"> + <summary> + What percentage of prompts from the last 28 days did the user ignore. + Aggregated across all origins, all PermissionTypes and all + PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.AllPromptsOfType.Count"> + <summary> + Total number of prompts shown to the user in the last 28 days for the + currently requested permission type. The count is bucketed. The bucket + minimums being 20, 15, 12, 10, 9, 8, 7, 6, 5, 4 and 0. The correct bucket + is the first one that is smaller or equal to the prompt count. + </summary> + </metric> + <metric name="Stats.AllPromptsOfType.DenyRate"> + <summary> + What percentage of prompts from the last 28 days did the user deny. + Aggregated across all origins, the current requested PermissionType and + all PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.AllPromptsOfType.DismissRate"> + <summary> + What percentage of prompts from the last 28 days did the user dismiss. + Aggregated across all origins, the current requested PermissionType and + all PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.AllPromptsOfType.GrantRate"> + <summary> + What percentage of prompts from the last 28 days did the user grant. + Aggregated across all origins, the current requested PermissionType and + all PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.AllPromptsOfType.IgnoreRate"> + <summary> + What percentage of prompts from the last 28 days did the user ignore. + Aggregated across all origins, the current requested PermissionType and + all PromptDisposition. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPrompts.Count"> + <summary> + Total number of loud UI prompts shown to the user in the last 28 days. The + count is bucketed. The bucket minimums being 20, 15, 12, 10, 9, 8, 7, 6, 5 + ,4 and 0. The correct bucket is the first one that is smaller or equal to + the prompt count. + </summary> + </metric> + <metric name="Stats.LoudPrompts.DenyRate"> + <summary> + What percentage of prompts from the last 28 days did the user deny. + Aggregated across all origins, all PermissionTypes and loud UI + PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPrompts.DismissRate"> + <summary> + What percentage of prompts from the last 28 days did the user dismiss. + Aggregated across all origins, all PermissionTypes and loud UI + PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPrompts.GrantRate"> + <summary> + What percentage of prompts from the last 28 days did the user grant. + Aggregated across all origins, all PermissionTypes and loud UI + PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPrompts.IgnoreRate"> + <summary> + What percentage of prompts from the last 28 days did the user ignore. + Aggregated across all origins, all PermissionTypes and loud UI + PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPromptsOfType.Count"> + <summary> + Total number of loud UI prompts shown to the user in the last 28 days for + the currently requested permission type. The count is bucketed. The bucket + minimums being 20, 15, 12, 10, 9, 8, 7, 6, 5, 4 and 0. The correct bucket + is the first one that is smaller or equal to the prompt count. + </summary> + </metric> + <metric name="Stats.LoudPromptsOfType.DenyRate"> + <summary> + What percentage of prompts from the last 28 days did the user deny. + Aggregated across all origins, currently requested PermissionType and loud + UI PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPromptsOfType.DismissRate"> + <summary> + What percentage of prompts from the last 28 days did the user dismiss. + Aggregated across all origins, currently requested PermissionType and loud + UI PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPromptsOfType.GrantRate"> + <summary> + What percentage of prompts from the last 28 days did the user grant. + Aggregated across all origins, currently requested PermissionType and loud + UI PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> + <metric name="Stats.LoudPromptsOfType.IgnoreRate"> + <summary> + What percentage of prompts from the last 28 days did the user ignore. + Aggregated across all origins, currently requested PermissionType and loud + UI PromptDispositions only. Rounded to the nearest 10%. + </summary> + </metric> <metric name="TimeToDecision"> <summary> Time (in milliseconds) taken by the user to make a decision on a @@ -13942,7 +14986,7 @@ be describing additional metrics about the same event. <event name="PrerenderPageLoad" singular="True"> <owner>ksakamoto@chromium.org</owner> - <owner>falken@chromium.org</owner> + <owner>nhiroki@chromium.org</owner> <summary> Metrics related to Prerender2 (https://docs.google.com/document/d/1P2VKCLpmnNm_cRAjUeE-bqLL0bslL_zKqiNeCzNom_w/edit?usp=sharing). @@ -15093,6 +16137,20 @@ be describing additional metrics about the same event. </metric> </event> +<event name="Shopping.WillSendRequest"> + <owner>wychen@chromium.org</owner> + <owner>yuezhanggg@chromium.org</owner> + <summary> + Recorded when an XHR is about to be sent. + </summary> + <metric name="IsAddToCart" enum="Boolean"> + <summary> + Whether the XHR is to add a product to a shopping cart. This has 50% + chance randomized. + </summary> + </metric> +</event> + <event name="SiteIsolation.XSD.Browser.Blocked"> <obsolete> Removed in June 2019 / M77. Some old data has been saved in a @@ -17787,7 +18845,7 @@ be describing additional metrics about the same event. <summary> Features of a web app recorded at most once per day if a user interacted with the web app. Recorded for installed and/or promotable (installable) web - apps unless noted otherwise on the metric. + apps unless noted otherwise on the metric. Keyed by start_url of the app. </summary> <metric name="BackgroundDuration"> <summary> diff --git a/chromium/tools/origin_trials/DIR_METADATA b/chromium/tools/origin_trials/DIR_METADATA new file mode 100644 index 00000000000..14641a38a90 --- /dev/null +++ b/chromium/tools/origin_trials/DIR_METADATA @@ -0,0 +1 @@ +mixins: "//third_party/blink/common/origin_trials/COMMON_METADATA" diff --git a/chromium/tools/perf/BUILD.gn b/chromium/tools/perf/BUILD.gn index 344de9f65dc..7f8fc6a1db6 100644 --- a/chromium/tools/perf/BUILD.gn +++ b/chromium/tools/perf/BUILD.gn @@ -2,15 +2,15 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -group("perf") { - testonly = true - data_deps = [ - ":perf_without_chrome", - "//tools/perf/chrome_telemetry_build:telemetry_chrome_test", - ] -} - -if (is_android) { +if (!is_android) { + group("perf") { + testonly = true + data_deps = [ + ":perf_without_chrome", + "//tools/perf/chrome_telemetry_build:telemetry_chrome_test", + ] + } +} else { template("perf_android_template") { forward_variables_from(invoker, [ "telemetry_target_suffix" ]) group(target_name) { diff --git a/chromium/tools/perf/chrome_telemetry_build/BUILD.gn b/chromium/tools/perf/chrome_telemetry_build/BUILD.gn index 902b24d2e2f..2d6c25ea2d0 100644 --- a/chromium/tools/perf/chrome_telemetry_build/BUILD.gn +++ b/chromium/tools/perf/chrome_telemetry_build/BUILD.gn @@ -7,6 +7,7 @@ import("//build/config/compiler/compiler.gni") if (is_android) { # Pull in enable_chrome_android_internal and public_android_sdk import("//build/config/android/config.gni") + import("//tools/perf/chrome_telemetry_build/android_browser_types.gni") } if (is_chromeos_device) { @@ -36,25 +37,7 @@ group("telemetry_chrome_test") { ] data = [] - if (is_android) { - # TODO(crbug.com/1213269): Remove these APK dependencies and fully switch to - # the separate Android targets below once all Android uses of the old target - # have been cleaned up. - data_deps += [ - ":telemetry_weblayer_apks", - "//android_webview:system_webview_apk", - "//android_webview/test:webview_instrumentation_apk", - "//android_webview/tools/system_webview_shell:system_webview_shell_apk", - "//chrome/android:chrome_public_apk", - "//chrome/android:monochrome_public_apk", - "//chrome/android:monochrome_public_bundle", - "//chrome/android/webapk/shell_apk:maps_go_webapk", - ] - - if (enable_chrome_android_internal) { - data_deps += [ "//clank:telemetry_clank_test" ] - } - } else if (!is_fuchsia) { + if (!is_fuchsia && !is_android) { data_deps += [ "//chrome" ] } @@ -143,6 +126,7 @@ if (is_android) { data_deps = [ ":telemetry_chrome_test", ":telemetry_weblayer_apks", + "//chrome/android:monochrome_public_apk", ] } @@ -178,6 +162,22 @@ if (is_android) { } } } + + # This group exists solely for performance testing. Ideally, perf testing + # would use the same split targets as other Telemetry-based tests, but + # switching has proven to be very difficult due to interactions with Pinpoint. + group("all_chrome_android_targets_for_perf_testing") { + testonly = true + data_deps = [ "//chrome/android/webapk/shell_apk:maps_go_webapk" ] + foreach(_target_suffix, telemetry_android_browser_target_suffixes) { + data_deps += [ ":telemetry_chrome_test${_target_suffix}" ] + } + if (enable_chrome_android_internal) { + foreach(_target_suffix, telemetry_clank_browser_target_suffixes) { + data_deps += [ ":telemetry_chrome_test${_target_suffix}" ] + } + } + } } group("telemetry_weblayer_apks") { diff --git a/chromium/tools/perf/contrib/media_router_benchmarks/BUILD.gn b/chromium/tools/perf/contrib/media_router_benchmarks/BUILD.gn deleted file mode 100644 index fcb1054e3a0..00000000000 --- a/chromium/tools/perf/contrib/media_router_benchmarks/BUILD.gn +++ /dev/null @@ -1,12 +0,0 @@ -# Copyright 2019 The Chromium Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. - -copy("telemetry_extension_resources") { - sources = [ - "extension/manifest.json", - "extension/script.js", - ] - outputs = - [ "$root_out_dir/media_router/telemetry_extension/{{source_file_part}}" ] -} diff --git a/chromium/tools/perf/contrib/vr_benchmarks/BUILD.gn b/chromium/tools/perf/contrib/vr_benchmarks/BUILD.gn index 9521351e7af..06b53cfc0a7 100644 --- a/chromium/tools/perf/contrib/vr_benchmarks/BUILD.gn +++ b/chromium/tools/perf/contrib/vr_benchmarks/BUILD.gn @@ -50,15 +50,15 @@ group("vr_perf_tests_base") { } } -group("vr_perf_tests") { - testonly = true - data_deps = [ - ":vr_perf_tests_base", - "//tools/perf:perf", - ] -} - -if (is_android) { +if (!is_android) { + group("vr_perf_tests") { + testonly = true + data_deps = [ + ":vr_perf_tests_base", + "//tools/perf:perf", + ] + } +} else { template("vr_perf_tests_android_template") { forward_variables_from(invoker, [ "telemetry_target_suffix" ]) group(target_name) { diff --git a/chromium/tools/polymer/polymer.py b/chromium/tools/polymer/polymer.py index 10141c11afb..99456a507d0 100644 --- a/chromium/tools/polymer/polymer.py +++ b/chromium/tools/polymer/polymer.py @@ -409,10 +409,15 @@ def _process_dom_module(js_file, html_file): # Ignore lines with an ignore annotation. IGNORE_LINE_REGEX = '\s*/\* #ignore \*/(\S|\s)*' + # Special syntax used for files using ES class syntax. (OOBE screens) + JS_IMPORTS_PLACEHOLDER_REGEX = '/* #js_imports_placeholder */'; + HTML_TEMPLATE_PLACEHOLDER_REGEX = '/* #html_template_placeholder */'; + with io.open(js_file, encoding='utf-8') as f: lines = f.readlines() imports_added = False + html_content_added = False iife_found = False cr_define_found = False cr_define_end_line = -1 @@ -431,17 +436,33 @@ def _process_dom_module(js_file, html_file): line = '\n'.join(js_imports) + '\n\n' cr_define_found = True imports_added = True + elif JS_IMPORTS_PLACEHOLDER_REGEX in line: + line = line.replace(JS_IMPORTS_PLACEHOLDER_REGEX, + '\n'.join(js_imports) + '\n') + imports_added = True elif 'Polymer({\n' in line: # Place the JS imports right before the opening "Polymer({" line. line = '\n'.join(js_imports) + '\n\n' + line imports_added = True - # Place the HTML content right after the opening "Polymer({" line. - # Note: There is currently an assumption that only one Polymer() declaration - # exists per file. - line = line.replace( - r'Polymer({', - 'Polymer({\n _template: html`%s`,' % html_template) + # Place the HTML content right after the opening "Polymer({" line if using + # the Polymer() factory method, or replace HTML_TEMPLATE_PLACEHOLDER_REGEX + # with the HTML content if the files is using ES6 class syntax. + # Note: There is currently an assumption that only one Polymer() declaration, + # or one class declaration exists per file. + error_message = """Multiple Polymer() declarations found, or mixed ES6 class + syntax with Polymer() declarations in the same file""" + if 'Polymer({' in line: + assert not html_content_added, error_message + line = line.replace( + r'Polymer({', + 'Polymer({\n _template: html`%s`,' % html_template) + html_content_added = True + elif HTML_TEMPLATE_PLACEHOLDER_REGEX in line: + assert not html_content_added, error_message + line = line.replace(HTML_TEMPLATE_PLACEHOLDER_REGEX, + 'static get template() {\n return html`%s`;\n }' % html_template) + html_content_added = True line = line.replace(EXPORT_LINE_REGEX, 'export') diff --git a/chromium/tools/polymer/polymer_test.py b/chromium/tools/polymer/polymer_test.py index 3eed6257a03..da164a9ba7f 100755 --- a/chromium/tools/polymer/polymer_test.py +++ b/chromium/tools/polymer/polymer_test.py @@ -54,6 +54,13 @@ class PolymerModulizerTest(unittest.TestCase): 'dom-module', 'dom_module.html', 'dom_module.js', 'dom_module.m.js', 'dom_module_expected.js') + # Test case where HTML is extracted from a Polymer2 <dom-module> that is + # using ES6 class syntax. + def testDomModuleWithClassSyntax(self): + self._run_test( + 'dom-module', 'dom_module.html', 'dom_module_with_class_syntax.js', + 'dom_module_with_class_syntax.m.js', 'dom_module_with_class_syntax_expected.js') + # Test case where a commented out HTML import exists in the original HTML # file. It is purposefully picked up and converted to a JS module, to address # a unique use case of the FilesApp where an HTML import does not actually diff --git a/chromium/tools/privacy_budget/DIR_METADATA b/chromium/tools/privacy_budget/DIR_METADATA index fe6ef770ce6..6d362b28079 100644 --- a/chromium/tools/privacy_budget/DIR_METADATA +++ b/chromium/tools/privacy_budget/DIR_METADATA @@ -1,4 +1 @@ -monorail: { - component: "Privacy>Fingerprinting" -} -team_email: "privacy-sandbox-dev@chromium.org" +mixins: "//third_party/blink/public/common/privacy_budget/COMMON_METADATA" diff --git a/chromium/tools/python/llvm_symbolizer.py b/chromium/tools/python/llvm_symbolizer.py index fd0df11bb1e..ac210784ee9 100644 --- a/chromium/tools/python/llvm_symbolizer.py +++ b/chromium/tools/python/llvm_symbolizer.py @@ -53,7 +53,10 @@ class LLVMSymbolizer(object): """ if os.path.isfile(_LLVM_SYMBOLIZER_PATH): self._llvm_symbolizer_subprocess = subprocess.Popen( - [_LLVM_SYMBOLIZER_PATH], stdout=subprocess.PIPE, stdin=subprocess.PIPE) + [_LLVM_SYMBOLIZER_PATH], + stdout=subprocess.PIPE, + stdin=subprocess.PIPE, + universal_newlines=True) else: logging.error('Cannot find llvm_symbolizer here: %s.' % _LLVM_SYMBOLIZER_PATH) @@ -92,19 +95,18 @@ class LLVMSymbolizer(object): or not _CheckValidAddr(addr) or not os.path.isfile(lib)): return [(_UNKNOWN, lib)] + proc = self._llvm_symbolizer_subprocess with self._lock: - self._llvm_symbolizer_subprocess.stdin.write('%s %s\n' % (lib, addr)) - self._llvm_symbolizer_subprocess.stdin.flush() - + proc.stdin.write('%s %s\n' % (lib, addr)) + proc.stdin.flush() result = [] - # Read till see new line, which is a symbol of end of output. - # One line of function name is always followed by one line of line number. + # Read until an empty line is observed, which indicates the end of the + # output. Each line with a function name is always followed by one line + # with the corresponding line number. while True: - line = self._llvm_symbolizer_subprocess.stdout.readline() + line = proc.stdout.readline() if line != '\n': - line_numbers = self._llvm_symbolizer_subprocess.stdout.readline() - result.append( - (line[:-1], - line_numbers[:-1])) + line_numbers = proc.stdout.readline() + result.append((line[:-1], line_numbers[:-1])) else: return result diff --git a/chromium/tools/resources/generate_resource_allowlist.py b/chromium/tools/resources/generate_resource_allowlist.py index 19b5d8e3e7f..3fb5ca91e1b 100755 --- a/chromium/tools/resources/generate_resource_allowlist.py +++ b/chromium/tools/resources/generate_resource_allowlist.py @@ -31,12 +31,14 @@ llvm_bindir = os.path.join(os.path.dirname(sys.argv[0]), '..', '..', def ExtractAllowlistFromFile(path, resource_ids): with open(path, 'rb') as f: data = f.read() - prefix = b'AllowlistedResource<' + # When symbol_level=0, only mangled names exist. + # E.g.: _ZN2ui19AllowlistedResourceILi22870EEEvv + prefix = b'AllowlistedResourceILi' start_idx = 0 while start_idx != -1: start_idx = data.find(prefix, start_idx) if start_idx != -1: - end_idx = data.find(b'>', start_idx) + end_idx = data.find(b'E', start_idx) resource_ids.add(int(data[start_idx + len(prefix):end_idx])) start_idx = end_idx @@ -133,9 +135,11 @@ def WriteResourceAllowlist(args): resource_ids.update(func(input)) - if len(resource_ids) == 0: - raise Exception('No debug info was dumped. Ensure GN arg "symbol_level" ' - '!= 0 and that the file is not stripped.') + # The last time this broke, exactly two resources were still being found. + if len(resource_ids) < 100: + raise Exception('Suspiciously few resources found. Likely an issue with ' + 'the regular expression in this script. Found: ' + + ','.join(sorted(resource_ids))) for id in sorted(resource_ids): args.output.write(str(id) + '\n') diff --git a/chromium/tools/run-swarmed.py b/chromium/tools/run-swarmed.py index 12248959746..fd5deae5521 100755 --- a/chromium/tools/run-swarmed.py +++ b/chromium/tools/run-swarmed.py @@ -31,6 +31,12 @@ import shutil import subprocess import sys +CHROMIUM_ROOT = os.path.join(os.path.dirname(__file__), os.pardir) +BUILD_DIR = os.path.join(CHROMIUM_ROOT, 'build') + +if BUILD_DIR not in sys.path: + sys.path.insert(0, BUILD_DIR) +import gn_helpers INTERNAL_ERROR_EXIT_CODE = -1000 @@ -49,20 +55,17 @@ def _Spawn(args): - The command line arguments object. """ index, args, cas_digest, swarming_command = args + runner_args = [] json_file = os.path.join(args.results, '%d.json' % index) trigger_args = [ 'tools/luci-go/swarming', 'trigger', '-S', 'https://chromium-swarm.appspot.com', - '-d', - 'pool=' + args.pool, '-digest', cas_digest, '-dump-json', json_file, - '-d', - 'os=' + args.swarming_os, '-tag=purpose:user-debug-run-swarmed', ] if args.target_os == 'fuchsia': @@ -72,25 +75,33 @@ def _Spawn(args): '-d', 'gpu=none', ] - if args.arch != 'detect': + elif args.target_os == 'android': + if args.arch == 'x86': + # No x86 Android devices are available in swarming. So assume we want to + # run on emulators when building for x86 on Android. + args.swarming_os = 'Linux' + args.pool = 'chromium.tests.avd' + # generic_android28 == Android P emulator. See //tools/android/avd/proto/ + # for other options. + runner_args.append( + '--avd-config=../../tools/android/avd/proto/generic_android28.textpb') + elif args.device_type is None and args.device_os is None: + # The aliases for device type are stored here: + # luci/appengine/swarming/ui2/modules/alias.js + # for example 'blueline' = 'Pixel 3' + trigger_args += ['-d', 'device_type=' + DEFAULT_ANDROID_DEVICE_TYPE] + elif args.arch != 'detect': trigger_args += [ '-d', 'cpu=' + args.arch, ] - # The aliases for device type are stored here: - # luci/appengine/swarming/ui2/modules/alias.js - # for example 'blueline' = 'Pixel 3' - if args.target_os == 'android': - if args.device_type is None and args.device_os is None: - trigger_args += ['-d', 'device_type=' + DEFAULT_ANDROID_DEVICE_TYPE] if args.device_type: trigger_args += ['-d', 'device_type=' + args.device_type] if args.device_os: trigger_args += ['-d', 'device_os=' + args.device_os] - runner_args = [] if not args.no_test_flags: # These flags are recognized by our test runners, but do not work # when running custom scripts. @@ -113,6 +124,8 @@ def _Spawn(args): if os.path.isfile(filter_file): runner_args.append('--test-launcher-filter-file=../../' + filter_file) + trigger_args.extend(['-d', 'os=' + args.swarming_os]) + trigger_args.extend(['-d', 'pool=' + args.pool]) trigger_args.extend(['--relative-cwd', args.out_dir, '--']) trigger_args.extend(swarming_command) trigger_args.extend(runner_args) @@ -203,14 +216,10 @@ def main(): args = parser.parse_args() + with open(os.path.join(args.out_dir, 'args.gn')) as f: + gn_args = gn_helpers.FromGNArgs(f.read()) + if args.target_os == 'detect': - with open(os.path.join(args.out_dir, 'args.gn')) as f: - gn_args = {} - for l in f: - l = l.split('#')[0].strip() - if not l: continue - k, v = map(str.strip, l.split('=', 1)) - gn_args[k] = v if 'target_os' in gn_args: args.target_os = gn_args['target_os'].strip('"') else: @@ -231,13 +240,16 @@ def main(): args.target_name = os.path.splitext(args.target_name)[0] # Determine the CPU architecture of the test binary, if not specified. - if args.arch == 'detect' and args.target_os not in ('android', 'mac', 'win'): - executable_info = subprocess.check_output( - ['file', os.path.join(args.out_dir, args.target_name)]) - if 'ARM aarch64' in executable_info: - args.arch = 'arm64', - else: - args.arch = 'x86-64' + if args.arch == 'detect': + if args.target_os not in ('android', 'mac', 'win'): + executable_info = subprocess.check_output( + ['file', os.path.join(args.out_dir, args.target_name)]) + if 'ARM aarch64' in executable_info: + args.arch = 'arm64', + else: + args.arch = 'x86-64' + elif args.target_os == 'android': + args.arch = gn_args.get('target_cpu', 'detect') mb_cmd = [sys.executable, 'tools/mb/mb.py', 'isolate'] if not args.build: diff --git a/chromium/tools/sort-headers.py b/chromium/tools/sort-headers.py deleted file mode 100755 index 09427aef2c2..00000000000 --- a/chromium/tools/sort-headers.py +++ /dev/null @@ -1,189 +0,0 @@ -#!/usr/bin/env python -# Copyright (c) 2012 The Chromium Authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. - -"""Given a filename as an argument, sort the #include/#imports in that file. - -Shows a diff and prompts for confirmation before doing the deed. -Works great with tools/git/for-all-touched-files.py. -""" - -from __future__ import print_function - -import optparse -import os -import sys - -from yes_no import YesNo - - -def IsInclude(line): - """Returns True if the line is an #include/#import/import line.""" - return any([line.startswith('#include '), line.startswith('#import '), - line.startswith('import ')]) - - -def IncludeCompareKey(line, for_blink): - """Sorting comparator key used for comparing two #include lines. - - Returns an integer, optionally followed by a string. The integer is used - for coarse sorting of different categories of headers, and the string is - used for fine sorting of headers within categeries. - """ - for prefix in ('#include ', '#import ', 'import '): - if line.startswith(prefix): - line = line[len(prefix):] - break - - if for_blink: - # Blink likes to have its "config.h" include first. - if line.startswith('"config.h"'): - return '0' - - # Blink sorts system headers after others. This is handled by sorting - # alphabetically so no need to do anything tricky. - return '1' + line - - # The win32 api has all sorts of implicit include order dependencies :-/ - # Give a few headers special sort keys that make sure they appear before all - # other headers. - if line.startswith('<windows.h>'): # Must be before e.g. shellapi.h - return '0' - if line.startswith('<atlbase.h>'): # Must be before atlapp.h. - return '1' + line - if line.startswith('<ole2.h>'): # Must be before e.g. intshcut.h - return '1' + line - if line.startswith('<unknwn.h>'): # Must be before e.g. intshcut.h - return '1' + line - - # C++ system headers should come after C system headers. - if line.startswith('<'): - if line.find('.h>') != -1: - return '2' + line.lower() - else: - return '3' + line.lower() - - return '4' + line - - -def SortHeader(infile, outfile, for_blink): - """Sorts the headers in infile, writing the sorted file to outfile.""" - def CompareKey(line): - return IncludeCompareKey(line, for_blink) - - for line in infile: - if IsInclude(line): - headerblock = [] - while IsInclude(line): - infile_ended_on_include_line = False - headerblock.append(line) - # Ensure we don't die due to trying to read beyond the end of the file. - try: - line = infile.next() - except StopIteration: - infile_ended_on_include_line = True - break - for header in sorted(headerblock, key=CompareKey): - outfile.write(header) - if infile_ended_on_include_line: - # We already wrote the last line above; exit to ensure it isn't written - # again. - return - # Intentionally fall through, to write the line that caused - # the above while loop to exit. - outfile.write(line) - - -def FixFileWithConfirmFunction(filename, confirm_function, - perform_safety_checks, for_blink=False): - """Creates a fixed version of the file, invokes |confirm_function| - to decide whether to use the new file, and cleans up. - - |confirm_function| takes two parameters, the original filename and - the fixed-up filename, and returns True to use the fixed-up file, - false to not use it. - - If |perform_safety_checks| is True, then the function checks whether it is - unsafe to reorder headers in this file and skips the reorder with a warning - message in that case. - """ - if perform_safety_checks and IsUnsafeToReorderHeaders(filename): - print( - 'Not reordering headers in %s as the script thinks that the ' - 'order of headers in this file is semantically significant.' % filename) - return - fixfilename = filename + '.new' - infile = open(filename, 'rb') - outfile = open(fixfilename, 'wb') - SortHeader(infile, outfile, for_blink) - infile.close() - outfile.close() # Important so the below diff gets the updated contents. - - try: - if confirm_function(filename, fixfilename): - if sys.platform == 'win32': - os.unlink(filename) - os.rename(fixfilename, filename) - finally: - try: - os.remove(fixfilename) - except OSError: - # If the file isn't there, we don't care. - pass - - -def DiffAndConfirm(filename, should_confirm, perform_safety_checks, for_blink): - """Shows a diff of what the tool would change the file named - filename to. Shows a confirmation prompt if should_confirm is true. - Saves the resulting file if should_confirm is false or the user - answers Y to the confirmation prompt. - """ - def ConfirmFunction(filename, fixfilename): - diff = os.system('diff -u %s %s' % (filename, fixfilename)) - if sys.platform != 'win32': - diff >>= 8 - if diff == 0: # Check exit code. - print('%s: no change' % filename) - return False - - return (not should_confirm or YesNo('Use new file (y/N)?')) - - FixFileWithConfirmFunction(filename, ConfirmFunction, perform_safety_checks, - for_blink) - -def IsUnsafeToReorderHeaders(filename): - # *_message_generator.cc is almost certainly a file that generates IPC - # definitions. Changes in include order in these files can result in them not - # building correctly. - if filename.find("message_generator.cc") != -1: - return True - return False - -def main(): - parser = optparse.OptionParser(usage='%prog filename1 filename2 ...') - parser.add_option('-f', '--force', action='store_false', default=True, - dest='should_confirm', - help='Turn off confirmation prompt.') - parser.add_option('--no_safety_checks', - action='store_false', default=True, - dest='perform_safety_checks', - help='Do not perform the safety checks via which this ' - 'script refuses to operate on files for which it thinks ' - 'the include ordering is semantically significant.') - parser.add_option('--for_blink', action='store_true', default=False, - dest='for_blink', help='Whether the blink header sorting ' - 'rules should be applied.') - opts, filenames = parser.parse_args() - - if len(filenames) < 1: - parser.print_help() - return 1 - - for filename in filenames: - DiffAndConfirm(filename, opts.should_confirm, opts.perform_safety_checks, - opts.for_blink) - - -if __name__ == '__main__': - sys.exit(main()) diff --git a/chromium/tools/symsrc/img_fingerprint.py b/chromium/tools/symsrc/img_fingerprint.py index 6b5cffa8bb1..6b9deb25bbc 100755 --- a/chromium/tools/symsrc/img_fingerprint.py +++ b/chromium/tools/symsrc/img_fingerprint.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright (c) 2011 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -18,7 +18,9 @@ import sys # Assume this script is under tools/symsrc/ _SCRIPT_DIR = os.path.dirname(__file__) _ROOT_DIR = os.path.join(_SCRIPT_DIR, os.pardir, os.pardir) -_PEFILE_DIR = os.path.join(_ROOT_DIR, 'third_party', 'pefile') +_PEFILE_DIR = os.path.join( + _ROOT_DIR, 'third_party', 'pefile_py3' if sys.version_info >= + (3, 0) else 'pefile') sys.path.insert(1, _PEFILE_DIR) diff --git a/chromium/tools/symsrc/pdb_fingerprint_from_img.py b/chromium/tools/symsrc/pdb_fingerprint_from_img.py index 837c4e79f30..d0da014a88a 100755 --- a/chromium/tools/symsrc/pdb_fingerprint_from_img.py +++ b/chromium/tools/symsrc/pdb_fingerprint_from_img.py @@ -1,9 +1,9 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright (c) 2011 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -"""This will retrieve a PDBs "fingerprint" from it's corresponding executable +"""This will retrieve a PDB's "fingerprint" from its corresponding executable image (.dll or .exe). This is used when retrieving the PDB from the symbol server. The .pdb (or cab compressed .pd_) is expected at a path like: foo.pdb/FINGERPRINT/foo.pdb @@ -20,7 +20,9 @@ import sys # Assume this script is under tools/symsrc/ _SCRIPT_DIR = os.path.dirname(__file__) _ROOT_DIR = os.path.join(_SCRIPT_DIR, os.pardir, os.pardir) -_PEFILE_DIR = os.path.join(_ROOT_DIR, 'third_party', 'pefile') +_PEFILE_DIR = os.path.join( + _ROOT_DIR, 'third_party', 'pefile_py3' if sys.version_info >= + (3, 0) else 'pefile') sys.path.insert(1, _PEFILE_DIR) @@ -50,13 +52,17 @@ def GetPDBInfoFromImg(filename): cv.PdbFileName = data[cv.sizeof():] guid = pefile.Structure(__GUID_format__) guid.__unpack__(cv.Signature) - guid.Data4_0 = ''.join("%02X" % ord(x) for x in guid.Data4[0:2]) - guid.Data4_1 = ''.join("%02X" % ord(x) for x in guid.Data4[2:]) - return ("%08X%04X%04X%s%s%d" % ( - guid.Data1, guid.Data2, guid.Data3, - guid.Data4_0, guid.Data4_1, cv.Age), - cv.PdbFileName.split('\x00', 1)[0]) + if not isinstance(guid.Data4[0], int): + # In non-py3 pefile, this is a list of bytes. + guid.Data4 = map(ord, guid.Data4) + + guid.Data4_0 = ''.join("%02X" % x for x in guid.Data4[0:2]) + guid.Data4_1 = ''.join("%02X" % x for x in guid.Data4[2:]) + + return ("%08X%04X%04X%s%s%d" % (guid.Data1, guid.Data2, guid.Data3, + guid.Data4_0, guid.Data4_1, cv.Age), + str(cv.PdbFileName.split(b'\x00', 1)[0].decode())) break diff --git a/chromium/tools/tracing/README.md b/chromium/tools/tracing/README.md index 51488623c5d..56edd8c0ffd 100644 --- a/chromium/tools/tracing/README.md +++ b/chromium/tools/tracing/README.md @@ -1,19 +1,324 @@ -# Perfetto Trace Collection Profiling for Chrome Developers -This tool provides a way for chrome developers to collect perfetto traces -and symbolize them. +# Chrome Tracing Tools - Guide -# Startup Tracing -The script profile_chrome_startup runs a chrome trace on android, locates the -trace file, and automatically copies it to a local folder. +The tools/tracing directory contains scripts for both recording and symbolizing +traces in proto file format. This doc outlines different use cases for the tool. +Each use case shows what arguments are most important for the script to work. +Run `tools/tracing/profile_chrome_startup --help` or +`tools/tracing/symbolize_trace --help` for more details on more command-line +flags. -Example Linux Platform Usage: +[TOC] + +## What's supported? + +Platform | Trace Recording | Trace Symbolization +-------- | ------------------------------- | ------------------- +Android | ✔️ | ✔️ +Linux | ❌ (use https://ui.perfetto.dev) | ✔️ +MacOS | ❌ (use https://ui.perfetto.dev) | ✔️ +Windows | ❌ | ❌ + +## **Profiling Chrome** + +**For local builds:** In order for this tool to work, make sure that a build +directory for Chrome exists and that Chrome is built with the gn arg +‘symbol_level’ >= 1. + +### **Android:** + +#### Setting up to collect profiles: + +Supported architectures for heap profiling: + +* Local builds: arm32, arm64, x86-64 + + * Even if arm32 is not used, ensure `symbol_level=1` is included in gn + args so that function names are included in symbol files. + * If an emulator is used, use x86-64 architecture. x86 architecture is not + supported for this. + * Prefer to use arm64/x86-64 builds since arm32 support is less stable. + * For arm32, set these gn args: `enable_profiling=true`, + `arm_use_thumb=false`, `is_component_build=false` and `symbol_level=1`. + * Alternatively for arm32 you can use `is_official_build=true`, + `symbol_level=1`. + +* Official builds: arm32, arm64, x86-64. + + * Official builds need to be installed from the play store. + * For arm32, only canary and dev channels are supported. + +Note: x86 architecture is not supported for this. + +Supported architectures for CPU profiling: + +* CPU profiling not supported on emulators. +* Official builds: arm32 and arm64. + + * Official builds need to be downloaded from the play store. + * For arm32, only canary and dev channels are supported. + +* Local builds: arm32 and arm64 + + * Include gn arg: `symbol_level=1` so that function names are included in + symbol files. For arm32, include the following gn args: + `is_official_build=true`, `symbol_level=1`. + +Setup steps: + +1. Build Chrome using x86-64 (with gn arg: `target_os="x64"` for local builds) + or other supported architectures. +1. Skip this step if heap profiling is not needed. Setup Chrome command line + for enabling heap profiling before starting Chrome: + + * Run: + + ``` + build/android/adb_chrome_public_command_line \ + --memlog-sampling-rate=1000000 --memlog=browser \ + --use-heap-profiling-proto-writer + ``` + + * Alternatively you can enable heap profiling from + chrome://memory-internals. + * For CPU sampling profiling, no Chrome command line setup is needed. + +1. Make sure that the Chrome browser installed has permission to access device + storage. Chrome needs permission to write traces to disk (outside data dir). + + * On your device/emulator with Chrome: Setting > Apps > App Info, then + click the Chrome app you want to profile. Click on App Permissions and + allow access to device storage. + +1. Build dump_syms by running: ninja -C out/build_dir dump_syms. This is needed + for official builds too. You need to setup a local directory with the same + `target_os` as the profiled device and set `is_debug=false` in gn args. + +#### Collecting profiles: + +##### Using Perfetto UI (https://ui.perfetto.dev): + +Heap profiling: + +* Enable memory-infra (high-overhead) for memory in Chrome categories and + collect traces. this would capture a profile every 10 seconds. + +CPU profiling: + +* For CPU profiling, enable cpu_profiler (high overhead) in Chrome categories + and collect traces. + +Note: Download and symbolize this profile using symbolization steps below. + +##### For local builds: + +1. Find the browser you want to profile. The `--browser` flag will be used to + select the browser. + + * Examples for local builds: `--browser=build` (for clankium), + `--browser=chromium` (for chromium), `--browser=beta`, + `--browser=stable`. `--help` will give a list of all possible browser + options. + +1. Run profile_chrome_startup: + + ``` + tools/tracing/profile_chrome_startup --symbolize \ + --local_build_dir=LOCAL_BUILD_DIR --browser=BROWSER \ + [--enable_profiler={memory,cpu}] + ``` + + Example heap profiling: + + ``` + tools/tracing/profile_chrome_startup --symbolize \ + --local_build_dir=out/Release --browser=build --enable_profiler=memory + ``` + + * When collecting heap profiles, samples are collected every 10 seconds. + Extend the time for heap profiling by setting the `--time` flag greater + than 10 seconds to actually collect heap samples. For example, + specifying `--time=300` will ensure heap samples are taken every 10 + seconds for five minutes. + +##### For official builds: + +1. Find the browser you want to profile. The `--browser` flag will be used to + select the browser. + + * Examples for official builds: `--browser=beta`, `--browser=canary`, + `--browser=stable`. `--help` will give a list of all possible browser + options. + +1. Run profile_chrome_startup: + + ``` + tools/tracing/profile_chrome_startup --symbolize \ + --dump_syms=DUMP_SYMS --browser=BROWSER [--enable_profiler={memory,cpu}] + ``` + + Example heap profiling: + + ``` + tools/tracing/profile_chrome_startup --symbolize \ + --dump_syms=out/Release/dump_syms \ + local_build_dir=out/Release --browser=stable --enable_profiler=memory + ``` + + * When collecting heap profiles, samples are collected every 10 seconds. + Extend the time for heap profiling by setting the `--time` flag greater + than 10 seconds to actually collect heap samples. For example, + specifying `--time=300` will ensure heap samples are taken every 10 + seconds for five minutes. + +**Notes:** + +* To specify the kind of profile to collect, the `--enable_profiler` flag is + needed. You can specify either `cpu` or `memory` or a comma-separated list + containing both as arguments. + +* To enable/disable specific Chrome categories while recording a trace, use + the `--chrome_categories flag`. + +* To view a symbolized trace automiatically after symbolization, you can pass + the `--view` flag to automatically open the symbolized trace in + https://ui.perfetto.dev. + +* For steps to save time on multiple runs, refer to **Caching Symbols for + Multiple Traces** section for additional flags to add to the command line. + +* In case dump_syms is not found by the script, specify the `--dump_syms` + flag. + +* It is not needed, but if you want to specify the directory to hold breakpad + files, use the `--breakpad_output_dir` flag. + +* If symbolization is not needed, the `--skip_symbolize` flag specifies that a + trace should skip symbolization after collection. If specified omit the + `--dump_syms` and `--local_build_dir` flags since symbolization is not + needed. + +### **For Mac and Linux:** + +#### Collecting profiles: + +##### Using Perfetto UI (https://ui.perfetto.dev): + +Heap profiling: + +* Enable memory-infra (high-overhead) for memory in Chrome categories and + collect traces. this would capture a profile every 10 seconds. + +CPU profiling: + +* For CPU profiling, enable cpu_profiler (high overhead) in Chrome categories + and collect traces. + +Note: Download and symbolize this profile using symbolization steps below. + +### **For Windows:** + +You can collect a trace using https://ui.perfetto.dev, but symbolizing on +Windows is not currently supported with this script. + +## **Symbolizing traces (Only works for proto traces)** + +### **Android, Linux, Mac:** + +#### For local builds: + +##### Symbolization setup: + +1. Build dump_syms by running: ninja -C out/build_dir dump_syms. +1. Find the trace you want to symbolize. + +##### Symbolizing: + +1. Run symbolize_trace: + +``` +tools/tracing/symbolize_trace [trace_file] --local_build_dir=LOCAL_BUILD_DIR ``` -tools/tracing/profile_chrome_startup --platform=android + +#### For official builds: + +1. Skip this step for Mac and Linux. Build dump_syms by running: ninja -C + out/build_dir dump_syms. +1. Run symbolize_trace: + +``` +tools/tracing/symbolize_trace [trace_file] ``` -# Future Work -We are planning to add symbolization support and trace collection for other -platforms. +* Include `--dump_syms=DUMP_SYMS` for Android. Mac and Linux official builds + do not require dump_syms, but for Android traces, a path to dump_syms should + be found. + +**Notes** + +* To view a symbolized trace automiatically after symbolization, you can pass + the `--view` flag to automatically open the symbolized trace in + https://ui.perfetto.dev. + +* For steps to save time on multiple runs, refer to **Caching Symbols for + Multiple Traces** section for additional flags to add to the command line. + +### **Windows and Chrome OS:** Not yet supported. + +## Caching Symbols for Multiple Traces: + +* To cache symbols for symbolizing different traces from the same build of + Chrome include the --breakpad_output_dir flag (this will work for both + `profile_chrome_startup` and `symbolize_trace` scripts). If + `--breakpad_output_dir` is specified in the first run, the flag can be + replaced with `--local_breakpad_dir` to save time in subsequent runs, by + using the breakpad symbols that have been stored. Ex: + + For `tools/tracing/profile_chrome_startup`: + + * 1st run: `tools/tracing/profile_chrome_startup + --breakpad_output_dir=/tmp` + + * Future runs: `tools/tracing/profile_chrome_startup + --local_breakpad_dir=/tmp` + + For `tools/tracing/symbolize_trace`: + + * 1st run: `tools/tracing/symbolize_trace [trace_file1] + --breakpad_output_dir=/tmp` + + * Future runs: `tools/tracing/symbolize_trace [trace_file2] + --local_breakpad_dir=/tmp` + +## Troubleshooting: + +* If `tools/tracing/profile_chrome_startup` gives `Error : Activity Class` or + the desired Chrome browser does not open: + + * Check that the browser given for the `--browser` flag matches the build + of the browser you want to profile. + +* If heap profiling gives and empty trace: + + * Make sure 'memory' is included as an argument for the + `--enable_profiler` flag. + * Make sure that the `--time` flag is set to a value greater than 10. + * Make sure Chrome is able to read the command line (give storage + permission, as outlined in steps to profile Chrome) and that Chrome is + restarted after setting the command line for memlog. + +* If symbolization fails because dump_syms cannot be found: + + * Make sure that the dump_syms binary you built is given for the + `--dump_syms` or that the binary can be found in the directory given for + `--local_build_dir` + +* If an error shows that no symbolizer is found: + + * Try building the trace_to_text tool in perfetto, using instructions + found here: https://perfetto.dev/docs/contributing/build-instructions. + You can try the script again, specifying the `--symbolizer` flag, or you + can use the trace_to_text tool directly by running: + `path/to/trace_to_text [trace_file]` See the google internal design doc for more details pertaining to this tool: https://docs.google.com/document/d/1BJPbcl5SPjOvuRuP1JSFAUPK3ZWNIS7j1h94rPHRzVE diff --git a/chromium/tools/tracing/breakpad_file_extractor.py b/chromium/tools/tracing/breakpad_file_extractor.py index 00719eae0ce..4f2aecbbb27 100644 --- a/chromium/tools/tracing/breakpad_file_extractor.py +++ b/chromium/tools/tracing/breakpad_file_extractor.py @@ -6,14 +6,23 @@ Uses dump_syms to extract breakpad symbol files """ import os +import sys import logging import subprocess +import rename_breakpad + +sys.path.insert( + 0, + os.path.join(os.path.dirname(__file__), os.pardir, os.pardir, 'third_party', + 'catapult', 'common', 'py_utils')) +from py_utils import tempfile_ext def ExtractBreakpadFiles(dump_syms_path, build_dir, breakpad_output_dir, - search_unstripped=True): + search_unstripped=True, + module_ids=None): """Uses dump_syms to extract breakpad files. Args: @@ -26,6 +35,9 @@ def ExtractBreakpadFiles(dump_syms_path, subdirectory or not. If specified and '|build_dir|/lib.unstripped' exists, dump_syms is run on this directory instead. If not specified, dump_syms is run on |build_dir|. + module_ids: A set of module IDs needed to symbolize the trace. Only extracts + breakpad on symbol binaries with a module ID in this set. Extracts all + symbols if |module_ids| is None. Returns: True if at least one breakpad file could be extracted from |build_dir|; @@ -58,35 +70,159 @@ def ExtractBreakpadFiles(dump_syms_path, for file_iter in os.listdir(symbol_dir): input_file_path = os.path.join(symbol_dir, file_iter) if os.path.isfile(input_file_path) and _IsValidBinaryPath(input_file_path): + if not _IsModuleNeededForSymbolization(dump_syms_path, module_ids, + input_file_path): + continue # Construct absolute file paths for input and output files. output_file_path = os.path.join(breakpad_output_dir, file_iter + '.breakpad') + + logging.debug('Extracting breakpad file from: ' + input_file_path) if _RunDumpSyms(dump_syms_binary, input_file_path, output_file_path): + logging.debug('Extracted breakpad to: ' + output_file_path) breakpad_file_count += 1 # Extracting breakpad symbols should be successful with at least one file. return breakpad_file_count > 0 -def _RunDumpSyms(dump_syms_binary, input_file_path, output_file_path): +def ExtractBreakpadOnSubtree(symbols_root, metadata, dump_syms_path): + """Converts symbol files in the given subtree into breakpad files. + + Args: + symbols_root: root of subtree containing symbol files to convert to + breakpad format. + metadata: trace metadata to extract module ids from. + dump_syms_path: local path to dump_syms binary. + + Raises: + Exception: if path to dump_syms binary not passed or no breakpad files + could be extracted from subtree. + """ + logging.debug('Converting symbols to breakpad format.') + if dump_syms_path is None: + raise Exception('Path to dump_syms binary is required for symbolizing ' + 'official Android traces. You can build dump_syms from ' + 'your local build directory with the right architecture ' + 'with: autoninja -C out_<arch>/Release dump_syms.') + + # Set of module IDs we need to symbolize. + module_ids = GetModuleIdsToSymbolize(metadata) + + did_extract = False + for root_dir, _, _ in os.walk(symbols_root, topdown=True): + root_path = os.path.abspath(root_dir) + did_extract |= ExtractBreakpadFiles(dump_syms_path, + root_path, + root_path, + search_unstripped=False, + module_ids=module_ids) + + if not did_extract: + raise Exception( + 'No breakpad symbols could be extracted from files in the subtree: ' + + symbols_root) + + +def GetModuleIdsToSymbolize(metadata): + """Returns module IDs needed for symbolization and logs breakpad message. + + We log the message before calling |ExtractBreakpadFiles| because otherwise + we will repeatedly log when |ExtractBreakpadOnSubtree| recursively runs + |ExtractBreakpadFiles|. + """ + module_ids = metadata.GetModuleIds() + + if module_ids is None: + logging.info('No specified modules to extract. Converting all symbol ' + 'binaries to breakpad.') + else: + logging.debug('Module IDs to symbolize: %s' % (module_ids)) + + return module_ids + + +def _IsModuleNeededForSymbolization(dump_syms_path, module_ids, symbol_binary): + """Determines if we should extract breakpad from symbol binary. + + If module_ids is None, then we extract breakpad on all symbol binaries. + Otherwise, we only extract breakpad on binaries with a module ID needed to + symbolize the trace. + + Args: + dump_syms_path: The path to the dump_syms binary that should be run. + module_ids: A set of module IDs needed to symbolize the trace. Only extracts + breakpad on symbol binaries with a module ID in this set. Extracts all + symbols if |module_ids| is None. + symbol_binary: Symbol binary file to symbolize trace. + + Returns: + True if symbols should be extracted to breakpad; false, otherwise. + """ + if module_ids is None: + return True + + # Only convert breakpad if binary has module ID we need to symbolize. + module_id = _GetModuleIDFromBinary(dump_syms_path, symbol_binary) + if module_id is None or module_id not in module_ids: + logging.debug('Skipping breakpad extraction for module (%s, %s) ' + 'since trace has no frames with this ID.' % + (module_id, symbol_binary)) + return False + return True + + +def _GetModuleIDFromBinary(dump_syms_path, symbol_binary): + """Gets module ID of symbol binary. + + Args: + dump_syms_path: The path to the dump_syms binary that should be run. + symbol_binary: path to symbol binary. + + Returns: + Module ID from symbol binary, or None if fails to extract. + """ + # Creates temp file because |_RunDumpSyms| pipes result into a file. + # After extracting the module ID, we do not need this output file. + with tempfile_ext.NamedTemporaryFile(mode='w+') as output_file: + output_file.close() # RunDumpsyms opens the file again. + if not _RunDumpSyms(dump_syms_path, + symbol_binary, + output_file.name, + only_module_header=True): + return None + return rename_breakpad.ExtractModuleIdIfValidBreakpad(output_file.name) + + +def _RunDumpSyms(dump_syms_binary, + input_file_path, + output_file_path, + only_module_header=False): """Runs the dump_syms binary on a file and outputs the resulting breakpad symbols to the specified file. Args: - cmd: The command to run dump_syms. - output_file_path: The file path for the output breakpad symbol file. + dump_syms_path: The path to the dump_syms binary that should be run. + input_file_path: Input file path to run dump_syms on. + output_file_path: Output file path to store result. + only_module_header: Only extracts the module header, if specified. Returns: True if the command succeeded and false otherwise. """ - cmd = [dump_syms_binary, input_file_path] + cmd = [dump_syms_binary] + if only_module_header: + cmd.append('-i') + cmd.append(input_file_path) + with open(output_file_path, 'w') as f: proc = subprocess.Popen(cmd, stdout=f, stderr=subprocess.PIPE) stderr = proc.communicate()[1] if proc.returncode != 0: logging.warning('%s', str(stderr)) - logging.debug('Could not create breakpad symbols %s', input_file_path) + logging.debug( + 'Dump_syms failed to extract information from symbol binary: ' + + input_file_path) return False - logging.debug('Created breakpad symbols from %s', input_file_path) return True diff --git a/chromium/tools/tracing/breakpad_file_extractor_unittest.py b/chromium/tools/tracing/breakpad_file_extractor_unittest.py index 6921f59b7bb..25a290b0423 100755 --- a/chromium/tools/tracing/breakpad_file_extractor_unittest.py +++ b/chromium/tools/tracing/breakpad_file_extractor_unittest.py @@ -40,11 +40,99 @@ class ExtractBreakpadTestCase(unittest.TestCase): with open(self.test_dump_syms_binary, 'w'): pass + # Stash function. + self.RunDumpSyms_stash = breakpad_file_extractor._RunDumpSyms + def tearDown(self): shutil.rmtree(self.test_build_dir) shutil.rmtree(self.test_breakpad_dir) shutil.rmtree(self.test_dump_syms_dir) + # Unstash function. + breakpad_file_extractor._RunDumpSyms = self.RunDumpSyms_stash + + def _setupSubtreeFiles(self): + # Create subtree directory structure. All files deleted when + # |test_breakpad_dir| is recursively deleted. + out = tempfile.mkdtemp(dir=self.test_breakpad_dir) + release = tempfile.mkdtemp(dir=out) + subdir = tempfile.mkdtemp(dir=release) + unstripped_dir = os.path.join(release, 'lib.unstripped') + os.mkdir(unstripped_dir) + + # Create symbol files. + symbol_files = [] + symbol_files.append(os.path.join(subdir, 'subdir.so')) + symbol_files.append(os.path.join(unstripped_dir, 'unstripped.so')) + symbol_files.append(os.path.join(unstripped_dir, 'unstripped2.so')) + + for new_file in symbol_files: + with open(new_file, 'w') as _: + pass + + # Build side effect mapping. + side_effect_map = { + symbol_files[0]: 'MODULE Android x86_64 34984AB4EF948C subdir.so', + symbol_files[1]: 'MODULE Android x86_64 34984AB4EF948D unstripped.so', + symbol_files[2]: 'MODULE Android x86_64 34984AB4EF949A unstripped2.so' + } + + return symbol_files, side_effect_map + + def _mockDumpSyms(self, side_effect_map): + def run_dumpsyms_side_effect(dump_syms_binary, + input_file_path, + output_file_path, + only_module_header=False): + self.assertEqual(self.test_dump_syms_binary, dump_syms_binary) + if only_module_header: + # Extract Module ID. + with open(output_file_path, 'w') as f: + # Write the correct module header into the output f + f.write(side_effect_map[input_file_path]) + else: + # Extract breakpads. + with open(output_file_path, 'w'): + pass + return True + + return run_dumpsyms_side_effect + + def _getExpectedModuleExtractionCalls(self, symbol_files): + expected_module_calls = [ + mock.call(self.test_dump_syms_binary, + symbol_fle, + mock.ANY, + only_module_header=True) for symbol_fle in symbol_files + ] + return expected_module_calls + + def _getExpectedBreakpadExtractionCalls(self, extracted_files, + breakpad_files): + expected_extract_calls = [ + mock.call(self.test_dump_syms_binary, extracted_file, + breakpad_files[file_iter]) + for file_iter, extracted_file in enumerate(extracted_files) + ] + return expected_extract_calls + + def _getAndEnsureExtractedBreakpadFiles(self, extracted_files): + breakpad_files = [] + for extracted_file in extracted_files: + breakpad_filename = os.path.basename(extracted_file) + '.breakpad' + breakpad_file = os.path.join(self.test_breakpad_dir, breakpad_filename) + assert (os.path.isfile(breakpad_file)) + breakpad_files.append(breakpad_file) + return breakpad_files + + def _getAndEnsureExpectedSubtreeBreakpadFiles(self, extracted_files): + breakpad_files = [] + for extracted_file in extracted_files: + breakpad_file = extracted_file + '.breakpad' + assert (os.path.isfile(breakpad_file)) + breakpad_files.append(breakpad_file) + return breakpad_files + def _checkExtractWithOneBinary(self, dump_syms_path, build_dir, breakpad_dir): # Create test file in |test_build_dir| and test file in |test_breakpad_dir|. test_input_file = tempfile.NamedTemporaryFile(suffix='.so', dir=build_dir) @@ -99,56 +187,34 @@ class ExtractBreakpadTestCase(unittest.TestCase): def testMultipleBinaryFiles(self): # Create files in |test_build_dir|. All files are removed when # |test_build_dir| is recursively deleted. - input_filenames = [] + symbol_files = [] so_file = os.path.join(self.test_build_dir, 'test_file.so') with open(so_file, 'w') as _: pass - input_filenames.append(so_file) + symbol_files.append(so_file) exe_file = os.path.join(self.test_build_dir, 'test_file.exe') with open(exe_file, 'w') as _: pass - input_filenames.append(exe_file) + symbol_files.append(exe_file) chrome_file = os.path.join(self.test_build_dir, 'chrome') with open(chrome_file, 'w') as _: pass - input_filenames.append(chrome_file) + symbol_files.append(chrome_file) # Form output file paths. - output_file_paths = [] - for file_iter in input_filenames: - input_file_name = os.path.split(file_iter)[1] - test_output_file_path = '{output_path}.breakpad'.format( - output_path=os.path.join(self.test_breakpad_dir, input_file_name)) - with open(test_output_file_path, 'w'): - pass - output_file_paths.append(test_output_file_path) - breakpad_file_extractor._RunDumpSyms = mock.MagicMock() + breakpad_file_extractor._RunDumpSyms = mock.MagicMock( + side_effect=self._mockDumpSyms({})) breakpad_file_extractor.ExtractBreakpadFiles(self.test_dump_syms_binary, self.test_build_dir, self.test_breakpad_dir) - # Check that each call expected call to _RunDumpSyms() has been made. - expected_calls = [ - mock.call(self.test_dump_syms_binary, input_filename, - output_file_paths[file_iter]) - for file_iter, input_filename in enumerate(input_filenames) - ] + # Check that each expected call to _RunDumpSyms() has been made. + breakpad_files = self._getAndEnsureExtractedBreakpadFiles(symbol_files) + expected_calls = self._getExpectedBreakpadExtractionCalls( + symbol_files, breakpad_files) breakpad_file_extractor._RunDumpSyms.assert_has_calls(expected_calls, any_order=True) - # Check that the expected files exist in the output directory. - expected_files = [ - os.path.basename(f) + '.breakpad' for f in input_filenames - ] - file_count = 0 - for filename in os.listdir(self.test_breakpad_dir): - file_path = os.path.join(self.test_breakpad_dir, filename) - if os.path.isfile(file_path): - file_count += 1 - self.assertEqual(file_count, 3) - self.assertEqual(set(expected_files), - set(os.listdir(self.test_breakpad_dir))) - def testDumpSymsNotFound(self): breakpad_file_extractor._RunDumpSyms = mock.MagicMock() exception_msg = 'dump_syms is missing.' @@ -233,6 +299,64 @@ class ExtractBreakpadTestCase(unittest.TestCase): os.remove(combined_file1) os.remove(combined_file2) + def testExtractOnSubtree(self): + # Setup subtree symbol files. + symbol_files, side_effect_map = self._setupSubtreeFiles() + subdir_symbols = symbol_files[0] + unstripped_symbols = symbol_files[1] + + # Setup metadata. + metadata = metadata_extractor.MetadataExtractor('trace_processor_shell', + 'trace_file.proto') + metadata.InitializeForTesting(modules={ + '/subdir.so': '34984AB4EF948D', + '/unstripped.so': '34984AB4EF948C' + }) + extracted_files = [subdir_symbols, unstripped_symbols] + + # Setup |_RunDumpSyms| mock for module ID optimization. + breakpad_file_extractor._RunDumpSyms = mock.MagicMock( + side_effect=self._mockDumpSyms(side_effect_map)) + breakpad_file_extractor.ExtractBreakpadOnSubtree(self.test_breakpad_dir, + metadata, + self.test_dump_syms_binary) + + # Ensure correct |_RunDumpSyms| calls. + expected_module_calls = self._getExpectedModuleExtractionCalls(symbol_files) + + breakpad_files = self._getAndEnsureExpectedSubtreeBreakpadFiles( + extracted_files) + expected_extract_calls = self._getExpectedBreakpadExtractionCalls( + extracted_files, breakpad_files) + + breakpad_file_extractor._RunDumpSyms.assert_has_calls( + expected_module_calls + expected_extract_calls, any_order=True) + + def testSubtreeNoFilesExtracted(self): + # Setup subtree symbol files. No files to be extracted. + symbol_files, side_effect_map = self._setupSubtreeFiles() + + # Empty set of module IDs to extract. Nothing should be extracted. + metadata = metadata_extractor.MetadataExtractor('trace_processor_shell', + 'trace_file.proto') + metadata.InitializeForTesting(modules={}) + + # Setup |_RunDumpSyms| mock for module ID optimization. + breakpad_file_extractor._RunDumpSyms = mock.MagicMock( + side_effect=self._mockDumpSyms(side_effect_map)) + exception_msg = ( + 'No breakpad symbols could be extracted from files in the subtree: ' + + self.test_breakpad_dir) + with self.assertRaises(Exception) as e: + breakpad_file_extractor.ExtractBreakpadOnSubtree( + self.test_breakpad_dir, metadata, self.test_dump_syms_binary) + self.assertIn(exception_msg, str(e.exception)) + + # Should be calls to extract module ID, but none to extract breakpad. + expected_module_calls = self._getExpectedModuleExtractionCalls(symbol_files) + breakpad_file_extractor._RunDumpSyms.assert_has_calls(expected_module_calls, + any_order=True) + if __name__ == "__main__": unittest.main() diff --git a/chromium/tools/tracing/metadata_extractor.py b/chromium/tools/tracing/metadata_extractor.py index 046577f9d9f..84370f7ca4e 100644 --- a/chromium/tools/tracing/metadata_extractor.py +++ b/chromium/tools/tracing/metadata_extractor.py @@ -86,10 +86,18 @@ class MetadataExtractor: def trace_file(self): return self._trace_file + def GetModuleIds(self): + """Returns set of all module IDs in |modules| field. + """ + self.Initialize() + if self.modules is None: + return None + return set(self.modules.values()) + def Initialize(self): """Extracts metadata from perfetto system trace. """ - # TODO(rhuckleberry): Implement Trace Processor method to run multiple + # TODO(crbug/1239694): Implement Trace Processor method to run multiple # SQL queries without processing trace for every query. if self._initialized: @@ -203,7 +211,7 @@ class MetadataExtractor: if ((row_name is None or row_name == '/missing') or (row_debug_id is None or row_debug_id == '/missing')): continue - module_map[row_name] = row_debug_id + module_map[row_name] = row_debug_id.upper() if not module_map: return None diff --git a/chromium/tools/tracing/metadata_extractor_unittest.py b/chromium/tools/tracing/metadata_extractor_unittest.py index 2f6256ae752..712a68ffdd4 100755 --- a/chromium/tools/tracing/metadata_extractor_unittest.py +++ b/chromium/tools/tracing/metadata_extractor_unittest.py @@ -124,6 +124,9 @@ class ExtractMetadataTestCase(unittest.TestCase): }, { 'name': '/missing', 'build_id': 'AB3288CDE3283' + }, { + 'name': '/chrome.so', + 'build_id': 'abcdef' }]) return params[args] @@ -137,7 +140,10 @@ class ExtractMetadataTestCase(unittest.TestCase): self.assertEqual(extractor.architecture, 'x86_64') self.assertEqual(extractor.bitness, '64') self.assertEqual(extractor.version_code, '857854') - self.assertEqual(extractor.modules, {'/libmonochrome.so': '3284389AB83CD'}) + self.assertEqual(extractor.modules, { + '/libmonochrome.so': '3284389AB83CD', + '/chrome.so': 'ABCDEF' + }) def testExtractMetadataEmptyList(self): def side_effect(*args): @@ -280,6 +286,29 @@ class ExtractMetadataTestCase(unittest.TestCase): extractor.Initialize() self.assertEqual(exception_msg, str(context.exception)) + def testGetModuleIds(self): + extractor = metadata_extractor.MetadataExtractor(self.trace_processor_path, + self.trace_file) + extractor.InitializeForTesting(modules={ + 'name': '13423EDFAB2', + 'name2': '321468945', + 'name3': '4093492737482' + }) + self.assertEqual(extractor.GetModuleIds(), + {'13423EDFAB2', '321468945', '4093492737482'}) + + def testGetModuleIdsEmpty(self): + extractor = metadata_extractor.MetadataExtractor(self.trace_processor_path, + self.trace_file) + extractor.InitializeForTesting(modules={}) + self.assertEqual(extractor.GetModuleIds(), set()) + + def testGetModuleIdsNone(self): + extractor = metadata_extractor.MetadataExtractor(self.trace_processor_path, + self.trace_file) + extractor.InitializeForTesting(modules=None) + self.assertEqual(extractor.GetModuleIds(), None) + if __name__ == '__main__': unittest.main() diff --git a/chromium/tools/tracing/profile_chrome_startup b/chromium/tools/tracing/profile_chrome_startup index 6107d782b71..539af6ed0ca 100755 --- a/chromium/tools/tracing/profile_chrome_startup +++ b/chromium/tools/tracing/profile_chrome_startup @@ -27,7 +27,6 @@ from profile_chrome import chrome_startup_tracing_agent def _CreateOptionParser(): - # TODO(rhuckleberry): Update description when adding script functionality. parser = optparse.OptionParser(description='Record Perfetto tracing profiles ' 'from Android browsers startup. See ' 'http://dev.chromium.org' @@ -59,7 +58,7 @@ def main(): # Run Tracing trace_file = None if options.platform.lower() == 'android': - # TODO(rhuckleberry): Fix manual tracing. Setting flag --time=0 stalls and fails + # TODO(crbug/1239748): Fix manual tracing. Setting flag --time=0 stalls and fails # to download the collected trace. trace_file = adb_profile_chrome_startup.ProfileChrome(options) else: diff --git a/chromium/tools/tracing/rename_breakpad.py b/chromium/tools/tracing/rename_breakpad.py index 26132126d97..95fbe099018 100644 --- a/chromium/tools/tracing/rename_breakpad.py +++ b/chromium/tools/tracing/rename_breakpad.py @@ -41,7 +41,7 @@ def RenameBreakpadFiles(breakpad_dir, breakpad_output_dir): logging.debug("File is not a breakpad file: " + file_path) continue - module_id = _ExtractModuleIdIfValidBreakpad(file_path) + module_id = ExtractModuleIdIfValidBreakpad(file_path) if module_id is None: logging.debug("Failed to extract file module id: " + file_path) continue @@ -60,12 +60,8 @@ def RenameBreakpadFiles(breakpad_dir, breakpad_output_dir): shutil.move(file_path, dest_path) - # TODO(rhuckleberry): After moving breakpad files we can be left with empty - # dirs. Clean up these empty dirs if user specifies |breakpad_output_dir|. - # Doesn't matter if |breakpad_output_dir| is a temporary directory. - -def _ExtractModuleIdIfValidBreakpad(file_path): +def ExtractModuleIdIfValidBreakpad(file_path): """Extracts breakpad file's module id if the file is valid. A breakpad file is valid for extracting its module id if it diff --git a/chromium/tools/tracing/symbol_fetcher.py b/chromium/tools/tracing/symbol_fetcher.py index 5dc69e12f5e..9503b586383 100644 --- a/chromium/tools/tracing/symbol_fetcher.py +++ b/chromium/tools/tracing/symbol_fetcher.py @@ -51,7 +51,8 @@ def GetTraceBreakpadSymbols(cloud_storage_bucket, # Obtain breakpad symbols by platform. if metadata.os_name == OSName.ANDROID: _GetAndroidSymbols(cloud_storage_bucket, metadata, breakpad_output_dir) - _ConvertSymbolsToBreakpad(breakpad_output_dir, dump_syms_path) + breakpad_file_extractor.ExtractBreakpadOnSubtree(breakpad_output_dir, + metadata, dump_syms_path) rename_breakpad.RenameBreakpadFiles(breakpad_output_dir, breakpad_output_dir) elif metadata.os_name == OSName.WINDOWS: @@ -218,38 +219,6 @@ def _FetchBreakpadSymbols(cloud_storage_bucket, metadata, breakpad_output_dir): raise Exception('Failed to find symbols on GCS: %s[.zip].' % (gcs_file)) -def _ConvertSymbolsToBreakpad(symbols_root, dump_syms_path): - """Converts symbol files in the given subtree into breakpad files. - - Args: - symbols_root: root of subtree containing symbol files to convert to - breakpad format. - dump_syms_path: local path to dump_syms binary. - - Raises: - Exception: if path to dump_syms binary not passed or no breakpad files - could be extracted from subtree. - """ - logging.debug('Converting symbols to breakpad format.') - if dump_syms_path is None: - raise Exception('Path to dump_syms binary is required for symbolizing ' - 'official Android traces. You can build dump_syms from ' - 'your local build directory with the right architecture ' - 'with: autoninja -C out_<arch>/Release dump_syms.') - did_extract = False - for root_dir, _, _ in os.walk(symbols_root, topdown=True): - root_path = os.path.abspath(root_dir) - # TODO(rhuckleberry): Only run dump_syms on files listed in trace's - # modules metadata to speed up breakpad extraction time. - did_extract |= breakpad_file_extractor.ExtractBreakpadFiles( - dump_syms_path, root_path, root_path, search_unstripped=False) - - if not did_extract: - raise Exception( - 'No breakpad symbols could be extracted from files in the subtree: ' + - symbols_root) - - def _FetchAndUnzipGCSFile(cloud_storage_bucket, gcs_file, gcs_output, output_dir): """Fetch file from GCS to local |gcs_output|, then unzip it into |output_dir|. diff --git a/chromium/tools/tracing/symbol_fetcher_unittest.py b/chromium/tools/tracing/symbol_fetcher_unittest.py index 1fdfb646c28..30198f1417c 100755 --- a/chromium/tools/tracing/symbol_fetcher_unittest.py +++ b/chromium/tools/tracing/symbol_fetcher_unittest.py @@ -273,8 +273,7 @@ class AndroidTestCase(SymbolFetcherTestBase): def _setUpBasicRunDumpSyms(self): """Sets up symbol files to run the |RunDumpSyms| function. - Basic file setup used across all (non-error) Android tests that do not - specifically test the |_ConvertSymbolsToBreakpad| function. + Basic file setup used across all (non-error) Android tests. """ extracted_files = [] extracted_files.append(os.path.join(self.unstripped_dir, 'unstripped.so')) @@ -380,7 +379,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code='358923') + version_code='358923', + modules=None) match_arch_folder = 'x86_64' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) @@ -396,12 +396,13 @@ class AndroidTestCase(SymbolFetcherTestBase): any_order=True) self._ensureRunDumpSymsAndRenameCalls(extract_files) - def testDifferentArchAndMatchingFolder(self): + def testCrossArchitecture(self): metadata = self._createMetadataExtractor(version_number='123', os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code='358923') + version_code='358923', + modules=None) match_arch_folder = 'next-x86' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) @@ -422,7 +423,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture=None, bitness='64', - version_code='358923') + version_code='358923', + modules=None) match_arch_folder = 'x86_64' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) @@ -441,7 +443,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code=None) + version_code=None, + modules=None) match_arch_folder = 'x86_64' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) @@ -460,7 +463,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code='328954') + version_code='328954', + modules=None) match_arch_folder = 'x86_64' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) @@ -481,7 +485,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code='358923') + version_code='358923', + modules=None) # Fails to fetch all 'version_codes.txt' files from GCS. symbol_fetcher._FetchGCSFile = mock.MagicMock(return_value=False) @@ -501,7 +506,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code='358923') + version_code='358923', + modules=None) # None of the 'version_codes.txt' files match the trace's version code. match_arch_folder = None # No valid paths can be None. symbol_fetcher._FetchGCSFile = mock.Mock( @@ -522,7 +528,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='armv7', bitness='64', - version_code='358923') + version_code='358923', + modules=None) match_arch_folder = 'next-arm_64' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) @@ -552,7 +559,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code='358923') + version_code='358923', + modules=None) match_arch_folder = 'x86_64' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) @@ -579,7 +587,8 @@ class AndroidTestCase(SymbolFetcherTestBase): os_name=OSName.ANDROID, architecture='x86_64', bitness='64', - version_code='358923') + version_code='358923', + modules=None) match_arch_folder = 'x86_64' symbol_fetcher._FetchGCSFile = mock.Mock( side_effect=self._mockVersionCodeFetcher(match_arch_folder, metadata)) diff --git a/chromium/tools/tracing/symbolize_trace.py b/chromium/tools/tracing/symbolize_trace.py index e753fc54b4d..582d822e2d5 100644 --- a/chromium/tools/tracing/symbolize_trace.py +++ b/chromium/tools/tracing/symbolize_trace.py @@ -93,13 +93,23 @@ def _EnsureBreakpadSymbols(trace_file, options): # |trace_file| can be symbolized using those symbols. if options.local_breakpad_dir is not None: return + + # Extract Metadata + logging.info('Extracting proto trace metadata.') + trace_metadata = metadata_extractor.MetadataExtractor( + options.trace_processor_path, trace_file) + trace_metadata.Initialize() + logging.info(trace_metadata) + if options.local_build_dir is not None: # Extract breakpad symbol files from binaries in |options.local_build_dir|. if not breakpad_file_extractor.ExtractBreakpadFiles( options.dump_syms_path, options.local_build_dir, options.breakpad_output_dir, - search_unstripped=True): + search_unstripped=True, + module_ids=breakpad_file_extractor.GetModuleIdsToSymbolize( + trace_metadata)): raise Exception( 'No breakpad symbols could be extracted from files in: %s xor %s' % (options.local_build_dir, @@ -109,13 +119,6 @@ def _EnsureBreakpadSymbols(trace_file, options): options.breakpad_output_dir) return - # Extract Metadata - logging.info('Extracting proto trace metadata.') - trace_metadata = metadata_extractor.MetadataExtractor( - options.trace_processor_path, trace_file) - trace_metadata.Initialize() - logging.info(trace_metadata) - # Fetch trace breakpad symbols from GCS logging.info('Fetching and extracting trace breakpad symbols.') symbol_fetcher.GetTraceBreakpadSymbols(options.cloud_storage_bucket, diff --git a/chromium/tools/traffic_annotation/auditor/BUILD.gn b/chromium/tools/traffic_annotation/auditor/BUILD.gn index eda3fb23ff6..2272f0ca764 100644 --- a/chromium/tools/traffic_annotation/auditor/BUILD.gn +++ b/chromium/tools/traffic_annotation/auditor/BUILD.gn @@ -2,130 +2,10 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -import("//testing/test.gni") -import("//third_party/protobuf/proto_library.gni") - # Works only on Windows and Linux. -assert(is_win || is_linux || is_chromeos) - -proto_library("chrome_settings_full_runtime") { - proto_out_dir = "/tools/traffic_annotation" - - cc_include = "components/policy/proto/policy_proto_export.h" - - sources = [ - "$root_gen_dir" + - "/components/policy/proto/cloud_policy_full_runtime.proto", - "$root_gen_dir" + - "/components/policy/proto/chrome_settings_full_runtime.proto", - "$root_gen_dir" + - "/components/policy/proto/policy_common_definitions_full_runtime.proto", - ] - - use_protobuf_full = true - - deps = [ - "//components/policy:full_runtime_code_generate", - "//third_party/protobuf:protobuf_full", - ] -} - -proto_library("traffic_annotation") { - sources = [ "//chrome/browser/privacy/traffic_annotation.proto" ] - - proto_out_dir = "tools/traffic_annotation" - - import_dirs = [ "$root_gen_dir" + "/components/policy/proto" ] - - deps = [ ":chrome_settings_full_runtime" ] - - use_protobuf_full = true -} - -source_set("auditor_sources") { - sources = [ - "../../../net/traffic_annotation/network_traffic_annotation.h", - "../../../net/traffic_annotation/network_traffic_annotation_test_helper.h", - "auditor_result.cc", - "auditor_result.h", - "instance.cc", - "instance.h", - "traffic_annotation_auditor.cc", - "traffic_annotation_auditor.h", - "traffic_annotation_exporter.cc", - "traffic_annotation_exporter.h", - "traffic_annotation_file_filter.cc", - "traffic_annotation_file_filter.h", - "traffic_annotation_id_checker.cc", - "traffic_annotation_id_checker.h", - ] - data = [ - "//chrome/VERSION", - "safe_list.txt", - "traffic_annotation_extractor_switches.txt", - ] - - public_deps = [ - ":traffic_annotation", - "//base", - "//net/traffic_annotation", - "//third_party/libxml:xml_reader", # Safe, consumes Chromium-produced file. - "//third_party/libxml:xml_writer", - "//third_party/protobuf:protobuf_full", - "//third_party/re2", - ] - - deps = [ "//build:chromeos_buildflags" ] -} +assert(is_win || is_linux) executable("traffic_annotation_auditor") { sources = [ "traffic_annotation_auditor_ui.cc" ] - deps = [ ":auditor_sources" ] -} - -test("traffic_annotation_auditor_unittests") { - sources = [ "traffic_annotation_auditor_unittest.cc" ] - data = [ - "//chrome/VERSION", - "../summary/annotations.xml", - "tests/annotations_diff12.txt", - "tests/annotations_diff13.txt", - "tests/annotations_diff23.txt", - "tests/annotations_sample1.xml", - "tests/annotations_sample2.xml", - "tests/annotations_sample3.xml", - "tests/extractor_outputs/bad_assignment.txt", - "tests/extractor_outputs/bad_call.txt", - "tests/extractor_outputs/bad_syntax_annotation1.txt", - "tests/extractor_outputs/bad_syntax_annotation2.txt", - "tests/extractor_outputs/bad_syntax_annotation3.txt", - "tests/extractor_outputs/bad_syntax_annotation4.txt", - "tests/extractor_outputs/fatal_annotation1.txt", - "tests/extractor_outputs/fatal_annotation2.txt", - "tests/extractor_outputs/fatal_annotation3.txt", - "tests/extractor_outputs/good_assignment.txt", - "tests/extractor_outputs/good_branched_completing_annotation.txt", - "tests/extractor_outputs/good_call.txt", - "tests/extractor_outputs/good_complete_annotation.txt", - "tests/extractor_outputs/good_completing_annotation.txt", - "tests/extractor_outputs/good_partial_annotation.txt", - "tests/extractor_outputs/good_test_annotation.txt", - "tests/extractor_outputs/missing_annotation.txt", - "tests/git_list.txt", - "tests/gn_list_negative.txt", - "tests/gn_list_positive.txt", - "tests/irrelevant_file_content.cc", - "tests/irrelevant_file_content.mm", - "tests/irrelevant_file_name.txt", - "tests/relevant_file_name_and_content.cc", - "tests/relevant_file_name_and_content.mm", - "tests/test_grouping.xml", - ] - deps = [ - ":auditor_sources", - "//base/test:run_all_unittests", - "//base/test:test_support", - "//testing/gmock", - "//testing/gtest", - ] + deps = [ "//build:buildflag_header_h" ] } diff --git a/chromium/tools/traffic_annotation/auditor/DEPS b/chromium/tools/traffic_annotation/auditor/DEPS deleted file mode 100644 index 461bca1f892..00000000000 --- a/chromium/tools/traffic_annotation/auditor/DEPS +++ /dev/null @@ -1,6 +0,0 @@ -include_rules = [ - "+components/policy/proto", - "+third_party/libxml/chromium", - "+third_party/protobuf/src/google", - "+third_party/re2", -] diff --git a/chromium/tools/traffic_annotation/auditor/README.md b/chromium/tools/traffic_annotation/auditor/README.md index 93a40209a1e..0a3e5518c1e 100644 --- a/chromium/tools/traffic_annotation/auditor/README.md +++ b/chromium/tools/traffic_annotation/auditor/README.md @@ -1,7 +1,7 @@ # Network Traffic Annotation Auditor THIS CODEBASE IS DEPRECATED. It will be removed soon(ish). The new -implementation can be found at tools/traffic_annotation/auditor/auditor.py. It +implementation can be found at `tools/traffic_annotation/auditor/auditor.py`. It is a drop-in replacement for traffic_annotation_auditor, so you can run it with the same command-line arguments, etc. @@ -9,47 +9,6 @@ the same command-line arguments, etc. time running auditor.py by default (to ensure it's relatively bug-free). --> -This binary runs extractor.py for extraction of Network Traffic Annotations -from chromium source code, collects and summarizes its outputs, and performs -tests and maintenance. -Please see `docs/network_traffic_annotations.md` for an introduction to network -traffic annotations. - -## Usage -`traffic_annotation_auditor [OPTIONS]... [path_filter]...` - -Extracts network traffic annotations from source files, tests them, and updates -`tools/traffic_annotation/summary/annotations.xml`. If path filter(s) are -specified, only those directories of the source will be analyzed. -Run `traffic_annotation_auditor --help` for options. - -Example: - `traffic_annotation_auditor --build-path=out/Debug` - -The binary for this file is checked out into -`tools/traffic_annotation/bin/[platform]`. This is only done for Linux and -Windows platforms now and will be extended to other platforms later. - -## Running -Before running, you need to build the COMPLETE chromium and pass the build path -to the executable. - -## Safe List -If there are files, paths, or specific functions that need to be exempted from -all or some tests, they can be added to the `safe_list.txt`. The file is comma -separated, specifying the safe lists based on -`AuditorException::ExceptionType` in -`tools/traffic_annotation/auditor/traffic_annotation_auditor.h`. -Use * as wildcard for zero or more characters when specifying file paths. - -Here are the exception types: -* `all`: Files and paths in this category are exempted from all tests. -* `missing`: Files and paths in this category can use the - MISSING_TRAFFIC_ANNOTATION tag. -* `mutable_tag`: Files and paths in this category can use the - CreateMutableNetworkTrafficAnnotationTag() function. -* `direct_assignment`: The functions in this category can assign a value - directly to a MutableNetworkTrafficAnnotationTag. This is controlled to - avoid assigning arbitrary values to mutable annotations. -* `test_annotation`: Files and paths in this category can use the - TRAFFIC_ANNOTATION_FOR_TESTS tag. +See +[tools/traffic_annotation/scripts/auditor/README.md](/tools/traffic_annotation/scripts/auditor/README.md) +for more details. diff --git a/chromium/tools/traffic_annotation/auditor/auditor_result.cc b/chromium/tools/traffic_annotation/auditor/auditor_result.cc deleted file mode 100644 index 2e52a0e4cff..00000000000 --- a/chromium/tools/traffic_annotation/auditor/auditor_result.cc +++ /dev/null @@ -1,231 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include <algorithm> - -#include "tools/traffic_annotation/auditor/auditor_result.h" - -#include "base/check_op.h" -#include "base/notreached.h" -#include "base/strings/stringprintf.h" - -const int AuditorResult::kNoCodeLineSpecified = -1; - -AuditorResult::AuditorResult(Type type, - const std::string& message, - const std::string& file_path, - int line) - : type_(type), file_path_(file_path), line_(line) { - DCHECK(line != kNoCodeLineSpecified || - type == AuditorResult::Type::RESULT_OK || - type == AuditorResult::Type::RESULT_IGNORE || - type == AuditorResult::Type::ERROR_FATAL || - type == AuditorResult::Type::ERROR_HASH_CODE_COLLISION || - type == AuditorResult::Type::ERROR_REPEATED_ID || - type == AuditorResult::Type::ERROR_MERGE_FAILED || - type == AuditorResult::Type::ERROR_ANNOTATIONS_XML_UPDATE || - type == AuditorResult::Type::ERROR_INVALID_OS || - type == AuditorResult::Type::ERROR_INVALID_ADDED_IN); - DCHECK(!message.empty() || type == AuditorResult::Type::RESULT_OK || - type == AuditorResult::Type::RESULT_IGNORE || - type == AuditorResult::Type::ERROR_MISSING_TAG_USED || - type == AuditorResult::Type::ERROR_NO_ANNOTATION || - type == AuditorResult::Type::ERROR_MISSING_SECOND_ID || - type == AuditorResult::Type::ERROR_DIRECT_ASSIGNMENT || - type == AuditorResult::Type::ERROR_TEST_ANNOTATION || - type == AuditorResult::Type::ERROR_INVALID_OS || - type == AuditorResult::Type::ERROR_INVALID_ADDED_IN || - type == AuditorResult::Type::ERROR_MUTABLE_TAG); - if (!message.empty()) - details_.push_back(message); -} - -AuditorResult::AuditorResult(Type type, const std::string& message) - : AuditorResult::AuditorResult(type, - message, - std::string(), - kNoCodeLineSpecified) {} - -AuditorResult::AuditorResult(Type type) - : AuditorResult::AuditorResult(type, - std::string(), - std::string(), - kNoCodeLineSpecified) {} - -AuditorResult::AuditorResult(const AuditorResult& other) = default; - -AuditorResult::~AuditorResult() = default; - -void AuditorResult::AddDetail(const std::string& message) { - details_.push_back(message); -} - -std::string AuditorResult::ToText() const { - switch (type_) { - case AuditorResult::Type::ERROR_FATAL: - DCHECK(!details_.empty()); - return details_[0]; - - case AuditorResult::Type::ERROR_MISSING_TAG_USED: - return base::StringPrintf( - "MISSING_TRAFFIC_ANNOTATION tag used in '%s', line %i.", - file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_NO_ANNOTATION: - return base::StringPrintf("Empty annotation in '%s', line %i.", - file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_SYNTAX: { - DCHECK(!details_.empty()); - std::string flat_message(details_[0]); - std::replace(flat_message.begin(), flat_message.end(), '\n', ' '); - return base::StringPrintf("Syntax error in '%s': %s", file_path_.c_str(), - flat_message.c_str()); - } - - case AuditorResult::Type::ERROR_RESERVED_ID_HASH_CODE: - DCHECK(!details_.empty()); - return base::StringPrintf( - "Id '%s' in '%s:%i' has a hash code equal to a reserved word and " - "should be changed.", - details_[0].c_str(), file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_DEPRECATED_ID_HASH_CODE: - DCHECK(!details_.empty()); - return base::StringPrintf( - "Id '%s' in '%s:%i' has a hash code equal to a deprecated id and " - "should be changed.", - details_[0].c_str(), file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_HASH_CODE_COLLISION: - DCHECK_EQ(details_.size(), 2u); - return base::StringPrintf( - "The following annotations have colliding hash codes and should be " - "updated: %s, %s.", - details_[0].c_str(), details_[1].c_str()); - - case AuditorResult::Type::ERROR_REPEATED_ID: - DCHECK_EQ(details_.size(), 2u); - return base::StringPrintf( - "The following annotations have equal ids and should be updated: " - "%s, %s.", - details_[0].c_str(), details_[1].c_str()); - - case AuditorResult::Type::ERROR_ID_INVALID_CHARACTER: - DCHECK(!details_.empty()); - return base::StringPrintf( - "Id '%s' in '%s:%i' contains an invalid character.", - details_[0].c_str(), file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_MISSING_ANNOTATION: - DCHECK(!details_.empty()); - return base::StringPrintf("Function '%s' in '%s:%i' requires annotation.", - details_[0].c_str(), file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_INCOMPLETE_ANNOTATION: - DCHECK(!details_.empty()); - return base::StringPrintf( - "Annotation at '%s:%i' has the following missing fields: %s", - file_path_.c_str(), line_, details_[0].c_str()); - - case AuditorResult::Type::ERROR_MISSING_SECOND_ID: - return base::StringPrintf( - "Second id of annotation at '%s:%i' should be updated as it has the " - "same hash code as the first one.", - file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_INCONSISTENT_ANNOTATION: - DCHECK(!details_.empty()); - return base::StringPrintf( - "Annotation at '%s:%i' has the following inconsistencies: %s", - file_path_.c_str(), line_, details_[0].c_str()); - - case AuditorResult::Type::ERROR_MISSING_GROUPING: - DCHECK(!details_.empty()); - return base::StringPrintf( - "Annotation at '%s:%i' with unique_id '%s' does not appear in " - "summary/grouping.xml. Add the annotation to an existing " - "group in summary/grouping.xml", - file_path_.c_str(), line_, details_[0].c_str()); - - case AuditorResult::Type::ERROR_MERGE_FAILED: - DCHECK(details_.size() == 3); - return base::StringPrintf( - "Annotations '%s' and '%s' cannot be merged due to the following " - "error(s): %s", - details_[1].c_str(), details_[2].c_str(), details_[0].c_str()); - - case AuditorResult::Type::ERROR_INCOMPLETED_ANNOTATION: - DCHECK(!details_.empty()); - return base::StringPrintf("Annotation '%s' is never completed.", - details_[0].c_str()); - - case AuditorResult::Type::ERROR_DIRECT_ASSIGNMENT: - return base::StringPrintf( - "Annotation at '%s:%i' is assigned without annotations API " - "functions.", - file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_ANNOTATIONS_XML_UPDATE: - DCHECK(!details_.empty()); - return base::StringPrintf( - "'tools/traffic_annotation/summary/annotations.xml' requires update. " - "It is recommended to run traffic_annotation_auditor locally to do " - "the updates automatically (please refer to tools/traffic_annotation/" - "auditor/README.md), but you can also apply the following edit(s) to " - "do it manually:%s\n\n If you are using build flags that modify " - "files (like jumbo), rerun the auditor using --all-files switch.", - details_[0].c_str()); - - case AuditorResult::Type::ERROR_TEST_ANNOTATION: - return base::StringPrintf("Annotation for tests is used in '%s:%i'.", - file_path_.c_str(), line_); - - case AuditorResult::Type::ERROR_INVALID_OS: - return base::StringPrintf("Invalid OS '%s' in annotation '%s' at %s", - details_[0].c_str(), details_[1].c_str(), - file_path_.c_str()); - - case AuditorResult::Type::ERROR_DEPRECATED_WITH_OS: - return base::StringPrintf( - "Annotation '%s' has a deprecation date and at least one active OS " - "at %s.", - details_[0].c_str(), file_path_.c_str()); - - case AuditorResult::Type::ERROR_INVALID_ADDED_IN: - return base::StringPrintf( - "Invalid or missing added_in_milestone '%s' in annotation '%s' at %s", - details_[0].c_str(), details_[1].c_str(), file_path_.c_str()); - - case AuditorResult::Type::ERROR_MUTABLE_TAG: - return base::StringPrintf( - "Calling CreateMutableNetworkTrafficAnnotationTag() is not " - "whitelisted at '%s:%i'", - file_path_.c_str(), line_); - - default: - return std::string(); - } -} - -std::string AuditorResult::ToShortText() const { - switch (type_) { - case AuditorResult::Type::ERROR_INCOMPLETE_ANNOTATION: - DCHECK(!details_.empty()); - return base::StringPrintf("the following fields are missing: %s", - details_[0].c_str()); - - case AuditorResult::Type::ERROR_INCONSISTENT_ANNOTATION: - DCHECK(!details_.empty()); - return base::StringPrintf("the following inconsistencies: %s", - details_[0].c_str()); - - case AuditorResult::Type::ERROR_MISSING_GROUPING: - return base::StringPrintf("missing from summary/grouping.xml"); - - default: - NOTREACHED(); - return std::string(); - } -} diff --git a/chromium/tools/traffic_annotation/auditor/auditor_result.h b/chromium/tools/traffic_annotation/auditor/auditor_result.h deleted file mode 100644 index c9e395168c5..00000000000 --- a/chromium/tools/traffic_annotation/auditor/auditor_result.h +++ /dev/null @@ -1,106 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef TOOLS_TRAFFIC_ANNOTATION_AUDITOR_AUDITOR_RESULT_H_ -#define TOOLS_TRAFFIC_ANNOTATION_AUDITOR_AUDITOR_RESULT_H_ - -#include <string> -#include <vector> - -// Holds the auditor processing results on one unit of annotation or function. -class AuditorResult { - public: - enum class Type { - RESULT_OK, // No error - RESULT_IGNORE, // The item does not require further processing. - ERROR_FATAL, // A fatal error that should stop process. - ERROR_MISSING_TAG_USED, // A function is called with - // MISSING_TRAFFIC_ANNOTATION tag. - ERROR_NO_ANNOTATION, // A function is called with NO_ANNOTATION tag. - // Deprecated, as NO_ANNOTATION is now undefined on - // supported platforms. - ERROR_SYNTAX, // Annotation syntax is not right. - ERROR_RESERVED_ID_HASH_CODE, // An id has a hash code equal to a reserved - // word. - ERROR_DEPRECATED_ID_HASH_CODE, // An id has a hash code equal to a - // deprecated one. - ERROR_HASH_CODE_COLLISION, // Two ids have equal hash codes. - ERROR_REPEATED_ID, // An id is used in two places without proper - // matching conditions. Proper conditions - // include cases that two annotations are - // completing each other or are different - // branches of one completing annotation. - ERROR_ID_INVALID_CHARACTER, // An id contanins a characer which is not - // alphanumeric or underline. - ERROR_MISSING_ANNOTATION, // A function that requires annotation is not - // annotated. - ERROR_MISSING_SECOND_ID, // Annotation does not have a valid second id. - ERROR_INCOMPLETE_ANNOTATION, // Annotation has some missing fields. - ERROR_INCONSISTENT_ANNOTATION, // Annotation has some inconsistent fields. - ERROR_MISSING_GROUPING, // Annotation is missing from - // summary/grouping.xml file. - ERROR_MERGE_FAILED, // Two annotations that are supposed to merge - // cannot merge. - ERROR_INCOMPLETED_ANNOTATION, // A partial or [branched_] completing - // annotation is not paired with any other - // annotation to be completed. - ERROR_DIRECT_ASSIGNMENT, // A value is directly assigned to a mutable - // annotation or annotation initialized with - // list expresssion. - ERROR_ANNOTATIONS_XML_UPDATE, // Annotations XML requires update. - ERROR_TEST_ANNOTATION, // Annotation for tests is used. - ERROR_INVALID_OS, // Invalid 'os_list' in annotations.xml - ERROR_DEPRECATED_WITH_OS, // Marked deprecated, but 'os_list' is not - // empty in annotations.xml. - ERROR_INVALID_ADDED_IN, // "added_in_milestone" attribute is invalid. - - // This is the python_script equivalent of ERROR_DIRECT_ASSIGNMENT. - // - // TODO(crbug/966883): remove ERROR_DIRECT_ASSIGNMENT and related code - // when done migrating to python_script. - ERROR_MUTABLE_TAG, // Can't create a - // |MutableNetworkTrafficAnnotationTag| from - // anywhere (except whitelisted files). - }; - - static const int kNoCodeLineSpecified; - - AuditorResult(Type type, - const std::string& message, - const std::string& file_path, - int line); - - AuditorResult(Type type, const std::string& message); - - AuditorResult(Type type); - - ~AuditorResult(); - - AuditorResult(const AuditorResult& other); - - void AddDetail(const std::string& message); - - Type type() const { return type_; } - - std::string file_path() const { return file_path_; } - void set_file_path(const std::string& file_path) { file_path_ = file_path; } - - // Formats the error message into one line of text. - std::string ToText() const; - - // Formats the error message into one line of text that just includes the - // error reason and not the annotations and files invloved. It can be used to - // create a new error based on another one. - std::string ToShortText() const; - - bool IsOK() { return type_ == Type::RESULT_OK; } - - private: - Type type_; - std::vector<std::string> details_; - std::string file_path_; - int line_; -}; - -#endif // TOOLS_TRAFFIC_ANNOTATION_AUDITOR_AUDITOR_RESULT_H_ diff --git a/chromium/tools/traffic_annotation/auditor/instance.cc b/chromium/tools/traffic_annotation/auditor/instance.cc deleted file mode 100644 index f363ff3031b..00000000000 --- a/chromium/tools/traffic_annotation/auditor/instance.cc +++ /dev/null @@ -1,753 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "tools/traffic_annotation/auditor/instance.h" - -#include "base/containers/contains.h" -#include "base/memory/ptr_util.h" -#include "base/strings/string_number_conversions.h" -#include "base/strings/stringprintf.h" -#include "net/traffic_annotation/network_traffic_annotation.h" -#include "net/traffic_annotation/network_traffic_annotation_test_helper.h" -#include "third_party/protobuf/src/google/protobuf/io/tokenizer.h" -#include "third_party/protobuf/src/google/protobuf/text_format.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_auditor.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_exporter.h" - -namespace { - -// This class receives parsing errors from google::protobuf::TextFormat::Parser -// which is used during protobuf deserialization. -class SimpleErrorCollector : public google::protobuf::io::ErrorCollector { - public: - SimpleErrorCollector(int proto_starting_line) - : google::protobuf::io::ErrorCollector(), - line_offset_(proto_starting_line) {} - - ~SimpleErrorCollector() override = default; - - void AddError(int line, - google::protobuf::io::ColumnNumber column, - const std::string& message) override { - AddMessage(line, column, message); - } - - void AddWarning(int line, - google::protobuf::io::ColumnNumber column, - const std::string& message) override { - AddMessage(line, column, message); - } - - std::string GetMessage() { return message_; } - - private: - void AddMessage(int line, - google::protobuf::io::ColumnNumber column, - const std::string& message) { - message_ += base::StringPrintf( - "%sLine %i, column %i, %s", message_.length() ? " " : "", - line_offset_ + line, static_cast<int>(column), message.c_str()); - } - - std::string message_; - int line_offset_; -}; - -// This macro merges the content of one string field from two annotations. -// DST->FLD is the destination field, and SRD->FLD is the source field. -#define MERGE_STRING_FIELDS(SRC, DST, FLD) \ - if (!SRC.FLD().empty()) { \ - if (!DST->FLD().empty()) { \ - DST->set_##FLD(base::StringPrintf("%s\n%s", SRC.FLD().c_str(), \ - DST->FLD().c_str())); \ - } else { \ - DST->set_##FLD(SRC.FLD()); \ - } \ - } - -std::map<int, std::string> kSemanticsFields = { - {traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kSenderFieldNumber, - "semantics::sender"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kDescriptionFieldNumber, - "semantics::description"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kTriggerFieldNumber, - "semantics::trigger"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kDataFieldNumber, - "semantics::data"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kDestinationFieldNumber, - "semantics::destination"}, -}; - -std::map<int, std::string> kPolicyFields = { - {traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesAllowedFieldNumber, - "policy::cookies_allowed"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesStoreFieldNumber, - "policy::cookies_store"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kSettingFieldNumber, - "policy::setting"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kChromePolicyFieldNumber, - "policy::chrome_policy"}, - {traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kPolicyExceptionJustificationFieldNumber, - "policy::policy_exception_justification"}, -}; - -std::vector<int> kChromePolicyFields = { - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kChromePolicyFieldNumber, - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kPolicyExceptionJustificationFieldNumber}; - -} // namespace - -AnnotationInstance::AnnotationInstance() - : type(Type::ANNOTATION_COMPLETE), - unique_id_hash_code(0), - second_id_hash_code(0), - archive_content_hash_code(0), - is_loaded_from_archive(false), - is_merged(false) {} - -AnnotationInstance::AnnotationInstance(const AnnotationInstance& other) - : AnnotationInstance() { - *this = other; -} - -AnnotationInstance& AnnotationInstance::operator=( - const AnnotationInstance& other) { - proto = other.proto; - type = other.type; - second_id = other.second_id; - unique_id_hash_code = other.unique_id_hash_code; - second_id_hash_code = other.second_id_hash_code; - archive_content_hash_code = other.archive_content_hash_code; - is_loaded_from_archive = other.is_loaded_from_archive; - is_merged = other.is_merged; - if (other.runtime_proto != nullptr) { - runtime_proto = base::WrapUnique(other.runtime_proto->New()); - runtime_proto->MergeFrom(*other.runtime_proto); - } - return *this; -} - -AnnotationInstance::~AnnotationInstance() = default; - -AuditorResult AnnotationInstance::Deserialize( - const std::vector<std::string>& serialized_lines, - int start_line, - int end_line) { - if (end_line - start_line < 6) { - return AuditorResult(AuditorResult::Type::ERROR_FATAL, - "Not enough lines to deserialize annotation."); - } - - // Extract header lines. - const std::string& file_path = serialized_lines[start_line++]; - int line_number; - base::StringToInt(serialized_lines[start_line++], &line_number); - std::string function_type = serialized_lines[start_line++]; - const std::string& unique_id = serialized_lines[start_line++]; - second_id = serialized_lines[start_line++]; - - // Decode function type. - if (function_type == "Definition") { - type = Type::ANNOTATION_COMPLETE; - } else if (function_type == "Partial") { - type = Type::ANNOTATION_PARTIAL; - } else if (function_type == "Completing") { - type = Type::ANNOTATION_COMPLETING; - } else if (function_type == "BranchedCompleting") { - type = Type::ANNOTATION_BRANCHED_COMPLETING; - } else if (function_type == "Mutable") { - return AuditorResult(AuditorResult::Type::ERROR_MUTABLE_TAG, "", file_path, - line_number); - } else { - return AuditorResult(AuditorResult::Type::ERROR_FATAL, - base::StringPrintf("Unexpected function type: %s", - function_type.c_str())); - } - - // Process test tags. - unique_id_hash_code = TrafficAnnotationAuditor::ComputeHashValue(unique_id); - if (unique_id_hash_code == TRAFFIC_ANNOTATION_FOR_TESTS.unique_id_hash_code || - unique_id_hash_code == - PARTIAL_TRAFFIC_ANNOTATION_FOR_TESTS.unique_id_hash_code) { - return AuditorResult(AuditorResult::Type::ERROR_TEST_ANNOTATION, "", - file_path, line_number); - } - - // Process missing tag. - if (unique_id_hash_code == MISSING_TRAFFIC_ANNOTATION.unique_id_hash_code) - return AuditorResult(AuditorResult::Type::ERROR_MISSING_TAG_USED, "", - file_path, line_number); - - // Decode serialized proto. - std::string annotation_text = ""; - while (start_line < end_line) { - annotation_text += serialized_lines[start_line++] + "\n"; - } - - SimpleErrorCollector error_collector(line_number); - google::protobuf::TextFormat::Parser parser; - parser.RecordErrorsTo(&error_collector); - - // We first try to deserialize the annotation using the runtime schema to - // check if the proto is valid on the latest version of the schema. - if (runtime_proto != nullptr) { - if (!parser.ParseFromString(annotation_text, runtime_proto.get())) { - return AuditorResult(AuditorResult::Type::ERROR_SYNTAX, - error_collector.GetMessage().c_str(), file_path, - line_number); - } - - // Add only set_unique_id to the runtime_proto, as we use it to serialize - // the annotation, and we don't want to serialize the traffic source. - auto* field = runtime_proto->GetDescriptor()->FindFieldByName("unique_id"); - runtime_proto->GetReflection()->SetString(runtime_proto.get(), field, - unique_id); - - // Once we've parsed using the runtime_proto, we can skip unknown fields - // since we've confirmed above that the proto is valid. - parser.AllowUnknownField(true); - } - - if (!parser.ParseFromString( - annotation_text, static_cast<google::protobuf::Message*>(&proto))) { - return AuditorResult(AuditorResult::Type::ERROR_SYNTAX, - error_collector.GetMessage().c_str(), file_path, - line_number); - } - - // We still use the static |proto| message, as accessing fields is cleaner - // and checked at compile time, whereas |runtime_proto| requires reflection. - // This is why we deserialize the annotation a second time above. - - // Add other fields. - traffic_annotation::NetworkTrafficAnnotation_TrafficSource* src = - proto.mutable_source(); - src->set_file(file_path); - src->set_line(line_number); - proto.set_unique_id(unique_id); - second_id_hash_code = TrafficAnnotationAuditor::ComputeHashValue(second_id); - - return AuditorResult(AuditorResult::Type::RESULT_OK); -} - -// Returns the proto field numbers of TrafficSemantics. -void AnnotationInstance::GetSemanticsFieldNumbers( - std::set<int>* field_numbers) const { - field_numbers->clear(); - - const traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics - semantics = proto.semantics(); - - if (!semantics.sender().empty()) - field_numbers->insert(semantics.kSenderFieldNumber); - - if (!semantics.description().empty()) - field_numbers->insert(semantics.kDescriptionFieldNumber); - - if (!semantics.trigger().empty()) - field_numbers->insert(semantics.kTriggerFieldNumber); - - if (!semantics.data().empty()) - field_numbers->insert(semantics.kDataFieldNumber); - - if (semantics.destination() != - traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_UNSPECIFIED) { - field_numbers->insert(semantics.kDestinationFieldNumber); - } -} - -// Returns the proto field numbers of TrafficPolicy. -void AnnotationInstance::GetPolicyFieldNumbers( - std::set<int>* field_numbers) const { - field_numbers->clear(); - - const traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy policy = - proto.policy(); - - // If cookies are not allowed, the negated value of the - // kCookiesAllowedFieldNumber is returned. As field numbers are positive, this - // will not collide with any other value. - if (policy.cookies_allowed() == - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_YES) { - field_numbers->insert(policy.kCookiesAllowedFieldNumber); - } else if (policy.cookies_allowed() == - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_NO) { - field_numbers->insert(-policy.kCookiesAllowedFieldNumber); - } - - if (!policy.cookies_store().empty()) - field_numbers->insert(policy.kCookiesStoreFieldNumber); - - if (!policy.setting().empty()) - field_numbers->insert(policy.kSettingFieldNumber); - - if (policy.chrome_policy_size()) - field_numbers->insert(policy.kChromePolicyFieldNumber); - - if (!policy.policy_exception_justification().empty()) - field_numbers->insert(policy.kPolicyExceptionJustificationFieldNumber); -} - -// Checks if an annotation has all required fields. -AuditorResult AnnotationInstance::IsComplete() const { - std::vector<std::string> unspecifieds; - std::string extra_texts; - - std::set<int> fields; - GetSemanticsFieldNumbers(&fields); - for (const auto& item : kSemanticsFields) { - if (!base::Contains(fields, item.first)) - unspecifieds.push_back(item.second); - } - - GetPolicyFieldNumbers(&fields); - for (const auto& item : kPolicyFields) { - if (!base::Contains(fields, item.first)) { - // If 'cookies_allowed = NO' is provided, ignore not having - // 'cookies_allowed = YES'. - if (item.first == - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesAllowedFieldNumber && - base::Contains(fields, -item.first)) - continue; - - // If |cookies_store| is not provided, ignore if 'cookies_allowed = NO' is - // in the list. - if (item.first == - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesStoreFieldNumber && - base::Contains( - fields, - -traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesAllowedFieldNumber)) - continue; - - // If either of |chrome_policy| or |policy_exception_justification| are - // avaliable, ignore not having the other one. - if (base::Contains(kChromePolicyFields, item.first) && - (base::Contains(fields, kChromePolicyFields[0]) || - base::Contains(fields, kChromePolicyFields[1]))) { - continue; - } - unspecifieds.push_back(item.second); - } - } - - if (!unspecifieds.size()) - return AuditorResult(AuditorResult::Type::RESULT_OK); - - std::string error_text; - for (const std::string& item : unspecifieds) - error_text += item + ", "; - error_text = error_text.substr(0, error_text.length() - 2); - return AuditorResult(AuditorResult::Type::ERROR_INCOMPLETE_ANNOTATION, - error_text, proto.source().file(), - proto.source().line()); -} - -// Checks if annotation fields are consistent. -AuditorResult AnnotationInstance::IsConsistent() const { - const traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy policy = - proto.policy(); - - if (policy.cookies_allowed() == - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_NO && - policy.cookies_store().size()) { - return AuditorResult( - AuditorResult::Type::ERROR_INCONSISTENT_ANNOTATION, - "Cookies store is specified while cookies are not allowed.", - proto.source().file(), proto.source().line()); - } - - if (policy.chrome_policy_size() && - policy.policy_exception_justification().size()) { - return AuditorResult( - AuditorResult::Type::ERROR_INCONSISTENT_ANNOTATION, - "Both chrome policies and policy exception justification are present.", - proto.source().file(), proto.source().line()); - } - - return AuditorResult(AuditorResult::Type::RESULT_OK); -} - -AuditorResult AnnotationInstance::InGroupingXML( - const std::set<std::string>& grouping_annotation_unique_ids) const { - const std::string& unique_id = proto.unique_id(); - - if (grouping_annotation_unique_ids.find(unique_id) == - grouping_annotation_unique_ids.end()) { - return AuditorResult(AuditorResult::Type::ERROR_MISSING_GROUPING, - unique_id.c_str(), proto.source().file(), - proto.source().line()); - } - return AuditorResult(AuditorResult::Type::RESULT_OK); -} - -bool AnnotationInstance::IsCompletableWith( - const AnnotationInstance& other) const { - if (type != AnnotationInstance::Type::ANNOTATION_PARTIAL || second_id.empty()) - return false; - if (other.type == AnnotationInstance::Type::ANNOTATION_COMPLETING) { - return second_id_hash_code == other.unique_id_hash_code; - } else if (other.type == - AnnotationInstance::Type::ANNOTATION_BRANCHED_COMPLETING) { - return second_id_hash_code == other.second_id_hash_code; - } else { - return false; - } -} - -AuditorResult AnnotationInstance::CreateCompleteAnnotation( - AnnotationInstance& completing_annotation, - AnnotationInstance* combination) const { - DCHECK(IsCompletableWith(completing_annotation)); - - // To keep the source information meta data, if completing annotation is of - // type COMPLETING, keep |this| as the main and the other as completing. - // But if compliting annotation is of type BRANCHED_COMPLETING, reverse - // the order. - const AnnotationInstance* other; - if (completing_annotation.type == - AnnotationInstance::Type::ANNOTATION_COMPLETING) { - *combination = *this; - other = &completing_annotation; - } else { - *combination = completing_annotation; - other = this; - } - - combination->is_merged = true; - combination->type = AnnotationInstance::Type::ANNOTATION_COMPLETE; - combination->second_id.clear(); - combination->second_id_hash_code = 0; - if (other->runtime_proto) { - if (!combination->runtime_proto) - combination->runtime_proto = - base::WrapUnique(other->runtime_proto->New()); - combination->runtime_proto->MergeFrom(*other->runtime_proto); - } - - // Update comment. - std::string new_comments = combination->proto.comments(); - if (!other->proto.comments().empty()) { - if (!new_comments.empty()) - new_comments += "\n"; - new_comments += other->proto.comments(); - } - if (!new_comments.empty()) - new_comments += "\n"; - new_comments += base::StringPrintf( - "This annotation is a merge of the following two annotations:\n" - "'%s' in '%s:%i' and '%s' in '%s:%i'.", - proto.unique_id().c_str(), proto.source().file().c_str(), - proto.source().line(), completing_annotation.proto.unique_id().c_str(), - completing_annotation.proto.source().file().c_str(), - completing_annotation.proto.source().line()); - combination->proto.set_comments(new_comments); - - // Copy TrafficSemantics. - const traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics - src_semantics = other->proto.semantics(); - traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics* dst_semantics = - combination->proto.mutable_semantics(); - - MERGE_STRING_FIELDS(src_semantics, dst_semantics, sender); - MERGE_STRING_FIELDS(src_semantics, dst_semantics, description); - MERGE_STRING_FIELDS(src_semantics, dst_semantics, trigger); - MERGE_STRING_FIELDS(src_semantics, dst_semantics, data); - MERGE_STRING_FIELDS(src_semantics, dst_semantics, destination_other); - - // If destination is not specified in dst_semantics, get it from - // src_semantics. If both are specified and they differ, issue error. - if (dst_semantics->destination() == - traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_UNSPECIFIED) { - dst_semantics->set_destination(src_semantics.destination()); - } else if ( - src_semantics.destination() != - traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_UNSPECIFIED && - src_semantics.destination() != dst_semantics->destination()) { - AuditorResult error( - AuditorResult::Type::ERROR_MERGE_FAILED, - "Annotations contain different semantics::destination values."); - error.AddDetail(proto.unique_id()); - error.AddDetail(completing_annotation.proto.unique_id()); - return error; - } - - // Copy TrafficPolicy. - const traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy src_policy = - other->proto.policy(); - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy* dst_policy = - combination->proto.mutable_policy(); - - MERGE_STRING_FIELDS(src_policy, dst_policy, cookies_store); - MERGE_STRING_FIELDS(src_policy, dst_policy, setting); - - // Set cookies_allowed to the superseding value of both. - dst_policy->set_cookies_allowed( - std::max(dst_policy->cookies_allowed(), src_policy.cookies_allowed())); - DCHECK_GT(traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_YES, - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_NO); - DCHECK_GT( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_NO, - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_UNSPECIFIED); - - for (int i = 0; i < src_policy.chrome_policy_size(); i++) - *dst_policy->add_chrome_policy() = src_policy.chrome_policy(i); - - if (!src_policy.policy_exception_justification().empty()) { - if (!dst_policy->policy_exception_justification().empty()) { - dst_policy->set_policy_exception_justification( - dst_policy->policy_exception_justification() + "\n"); - } - dst_policy->set_policy_exception_justification( - dst_policy->policy_exception_justification() + - src_policy.policy_exception_justification()); - } - - return AuditorResult::Type::RESULT_OK; -} - -int AnnotationInstance::GetContentHashCode() const { - if (is_loaded_from_archive) - return archive_content_hash_code; - - std::string content; - if (runtime_proto != nullptr) { - // We try to serialize using the runtime proto, to catch newly added fields. - google::protobuf::TextFormat::PrintToString(*runtime_proto, &content); - } else { - // Otherwise, we default back to using the static proto. - traffic_annotation::NetworkTrafficAnnotation source_free_proto = proto; - source_free_proto.clear_source(); - google::protobuf::TextFormat::PrintToString(source_free_proto, &content); - } - return TrafficAnnotationAuditor::ComputeHashValue(content); -} - -// static -AnnotationInstance AnnotationInstance::LoadFromArchive( - AnnotationInstance::Type type, - const std::string& unique_id, - int unique_id_hash_code, - int second_id_hash_code, - int content_hash_code, - const std::set<int>& semantics_fields, - const std::set<int>& policy_fields, - const std::string& file_path, - int added_in_milestone) { - AnnotationInstance annotation; - - annotation.is_loaded_from_archive = true; - annotation.type = type; - annotation.proto.set_unique_id(unique_id); - annotation.proto.mutable_source()->set_file(file_path); - annotation.unique_id_hash_code = unique_id_hash_code; - annotation.archive_added_in_milestone = added_in_milestone; - - if (annotation.NeedsTwoIDs()) { - annotation.second_id_hash_code = second_id_hash_code; - // As we don't have the actual second id, a generated value is written to - // ensure that the field is not empty. Current set of auditor tests and - // unittests just check if this field is not empty when a second id is - // required. Tests that are based on matching the ids (like - // partial/completing annotations) are based on the hash codes. - annotation.second_id = - base::StringPrintf("ARCHIVED_ID_%i", annotation.second_id_hash_code); - } - - annotation.archive_content_hash_code = content_hash_code; - - // The values of the semantics and policy are set so that the tests would know - // which fields were available before archive. - if (base::Contains( - semantics_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kSenderFieldNumber)) { - annotation.proto.mutable_semantics()->set_sender("[Archived]"); - } - - if (base::Contains( - semantics_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kDescriptionFieldNumber)) { - annotation.proto.mutable_semantics()->set_description("[Archived]"); - } - - if (base::Contains( - semantics_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kTriggerFieldNumber)) { - annotation.proto.mutable_semantics()->set_trigger("[Archived]"); - } - - if (base::Contains( - semantics_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kDataFieldNumber)) { - annotation.proto.mutable_semantics()->set_data("[Archived]"); - } - - if (base::Contains( - semantics_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficSemantics:: - kDestinationFieldNumber)) { - annotation.proto.mutable_semantics()->set_destination( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_WEBSITE); - } - - if (base::Contains( - policy_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesAllowedFieldNumber)) { - annotation.proto.mutable_policy()->set_cookies_allowed( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_YES); - } - - if (base::Contains( - policy_fields, - -traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesAllowedFieldNumber)) { - annotation.proto.mutable_policy()->set_cookies_allowed( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_NO); - } - - if (base::Contains( - policy_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kCookiesStoreFieldNumber)) { - annotation.proto.mutable_policy()->set_cookies_store("[Archived]"); - } - - if (base::Contains( - policy_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kSettingFieldNumber)) { - annotation.proto.mutable_policy()->set_setting("[Archived]"); - } - - if (base::Contains( - policy_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kChromePolicyFieldNumber)) { - annotation.proto.mutable_policy()->add_chrome_policy(); - } - - if (base::Contains( - policy_fields, - traffic_annotation::NetworkTrafficAnnotation_TrafficPolicy:: - kPolicyExceptionJustificationFieldNumber)) { - annotation.proto.mutable_policy()->set_policy_exception_justification( - "[Archived]"); - } - - return annotation; -} - -std::string AnnotationInstance::Serialize() const { - std::string text; - std::set<int> fields; - - text = base::StringPrintf( - "{\tType: %i\n" - "\tID: %s\n" - "\tHashcode 1: %i\n" - "\tHashcode 2: %i\n" - "\tFrom Archive: %i\n" - "\tSource File: %s\n", - static_cast<int>(type), proto.unique_id().c_str(), unique_id_hash_code, - second_id_hash_code, is_loaded_from_archive, - proto.source().file().c_str()); - - GetSemanticsFieldNumbers(&fields); - text += "\tSemantics: "; - for (int i : fields) - text += base::StringPrintf("%s,", kSemanticsFields[i].c_str()); - - GetPolicyFieldNumbers(&fields); - text += "\n\tPolicies: "; - for (int i : fields) { - text += base::StringPrintf("%s%s,", i < 0 ? "-" : "", - kPolicyFields[abs(i)].c_str()); - } - text += "\n}"; - - return text; -} - -std::ostream& operator<<(std::ostream& out, - const AnnotationInstance& instance) { - return out << instance.Serialize(); -} - -CallInstance::CallInstance() : line_number(0), is_annotated(false) {} - -CallInstance::CallInstance(const CallInstance& other) = default; - -CallInstance& CallInstance::operator=(const CallInstance& other) = default; - -AuditorResult CallInstance::Deserialize( - const std::vector<std::string>& serialized_lines, - int start_line, - int end_line) { - if (end_line - start_line != 4) { - return AuditorResult(AuditorResult::Type::ERROR_FATAL, - "Not enough lines to deserialize call."); - } - - file_path = serialized_lines[start_line++]; - int line_number_int; - base::StringToInt(serialized_lines[start_line++], &line_number_int); - line_number = static_cast<uint32_t>(line_number_int); - function_name = serialized_lines[start_line++]; - int is_annotated_int; - base::StringToInt(serialized_lines[start_line++], &is_annotated_int); - is_annotated = is_annotated_int != 0; - return AuditorResult(AuditorResult::Type::RESULT_OK); -} - -AssignmentInstance::AssignmentInstance() : line_number(0) {} - -AssignmentInstance::AssignmentInstance(const AssignmentInstance& other) - : file_path(other.file_path), line_number(other.line_number) {} - -AuditorResult AssignmentInstance::Deserialize( - const std::vector<std::string>& serialized_lines, - int start_line, - int end_line) { - if (end_line - start_line != 2) { - return AuditorResult(AuditorResult::Type::ERROR_FATAL, - "Not enough lines to deserialize assignment."); - } - file_path = serialized_lines[start_line++]; - int line_number_int; - base::StringToInt(serialized_lines[start_line++], &line_number_int); - line_number = static_cast<uint32_t>(line_number_int); - return AuditorResult(AuditorResult::Type::RESULT_OK); -} diff --git a/chromium/tools/traffic_annotation/auditor/instance.h b/chromium/tools/traffic_annotation/auditor/instance.h deleted file mode 100644 index 89c6e421ca4..00000000000 --- a/chromium/tools/traffic_annotation/auditor/instance.h +++ /dev/null @@ -1,206 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef TOOLS_TRAFFIC_ANNOTATION_AUDITOR_INSTANCE_H_ -#define TOOLS_TRAFFIC_ANNOTATION_AUDITOR_INSTANCE_H_ - -#include <vector> - -#include "base/version.h" -#include "tools/traffic_annotation/auditor/auditor_result.h" -#include "tools/traffic_annotation/traffic_annotation.pb.h" - -// Base class for Annotation and Call instances. -class InstanceBase { - public: - InstanceBase() {} - virtual ~InstanceBase() {} - virtual AuditorResult Deserialize( - const std::vector<std::string>& serialized_lines, - int start_line, - int end_line) = 0; -}; - -// Holds an instance of network traffic annotation. -class AnnotationInstance : public InstanceBase { - public: - // Annotation Type. - enum class Type { - ANNOTATION_COMPLETE, - ANNOTATION_PARTIAL, - ANNOTATION_COMPLETING, - ANNOTATION_BRANCHED_COMPLETING, - ANNOTATION_INSTANCE_TYPE_LAST = ANNOTATION_BRANCHED_COMPLETING - }; - - AnnotationInstance(); - AnnotationInstance(const AnnotationInstance& other); - AnnotationInstance& operator=(const AnnotationInstance& other); - ~AnnotationInstance() override; - - // Deserializes an instance from serialized lines of the text provided by the - // extractor. - // |serialized_lines| are read from |start_line| to |end_line| and should - // contain the following lines: - // 1- File path. - // 2- Name of the function including this annotation. - // 3- Line number. - // 4- Annotation function Type. - // 5- Unique id of annotation. - // 6- Completing id or group id, when applicable, empty otherwise. - // 7- Serialization of annotation text (several lines). - AuditorResult Deserialize(const std::vector<std::string>& serialized_lines, - int start_line, - int end_line) override; - - // Returns the proto field numbers of TrafficSemantics fields that are - // included in this annotation. - void GetSemanticsFieldNumbers(std::set<int>* field_numbers) const; - - // Returns the proto field numbers of TrafficPolicy fields that are included - // in this annotation. - // For the cookies_allowed field, if the value is YES, - // kCookiesAllowedFieldNumber is added to the set and if it is NO, - // -kCookiesAllowedFieldNumber is added. - void GetPolicyFieldNumbers(std::set<int>* field_numbers) const; - - // Loads annotation based on the data from archive in annotations.xml. - static AnnotationInstance LoadFromArchive( - AnnotationInstance::Type type, - const std::string& unique_id, - int unique_id_hash_code, - int second_id_hash_code, - int content_hash_code, - const std::set<int>& semantics_fields, - const std::set<int>& policy_fields, - const std::string& file_path, - int added_in_milestone); - - // Checks if an annotation has all required fields. - AuditorResult IsComplete() const; - - // Checks if annotation fields are consistent. - AuditorResult IsConsistent() const; - - // Checks if annotation appears in summary/grouping.xml - AuditorResult InGroupingXML( - const std::set<std::string>& grouping_annotation_unique_ids) const; - - // Checks to see if this annotation can be completed with the |other| - // annotation, based on their unique ids, types, and extra ids. |*this| should - // be of partial type and the |other| either COMPLETING or BRANCHED_COMPLETING - // type. - bool IsCompletableWith(const AnnotationInstance& other) const; - - // Tells if annotation requires two ids. All annotations have the unique id, - // but partial annotations also require the completing id, and branched - // completing annotations require the group id. - bool NeedsTwoIDs() const { - return type == Type::ANNOTATION_PARTIAL || - type == Type::ANNOTATION_BRANCHED_COMPLETING; - } - - // If annotation is loaded from archive, returns |archive_content_hash_code|. - // Otherwise computes a hashcode for the annotation content. Source field is - // not used in this computation as we don't need sensitivity to changes in - // source location, i.e. filepath, line number and function. - int GetContentHashCode() const; - - // Combines |*this| partial annotation with a completing/branched_completing - // annotation and returns the combined complete annotation. - AuditorResult CreateCompleteAnnotation( - AnnotationInstance& completing_annotation, - AnnotationInstance* combination) const; - - // Serializes to text for debugging and visualization. - std::string Serialize() const; - - // Protobuf of the annotation. - traffic_annotation::NetworkTrafficAnnotation proto; - - // Same message as |proto|, but with the schema loaded at runtime - // (using reflection) based on chrome_settings_full_runtime.proto. - std::unique_ptr<google::protobuf::Message> runtime_proto; - - // Type of the annotation. - Type type; - - // Extra id of the annotation (if available). This can be the completing id - // for partial annotations, or group id for branched completing annotations. - std::string second_id; - - // Hash codes of unique id and extra id (if available). - int unique_id_hash_code; - int second_id_hash_code; - - // The hash code of annotation content for archived annotations. - int archive_content_hash_code; - - // The milestone (Chrome version) where this annotation was first added to - // Chromium code. - int archive_added_in_milestone; - - // Flag stating if annotation is loaded from annotations.xml. - bool is_loaded_from_archive; - - // This annotation is generated from merging two other incomplete annotations. - bool is_merged; -}; - -std::ostream& operator<<(std::ostream& out, const AnnotationInstance& instance); - -// Holds an instance of calling a function that might have a network traffic -// annotation argument. -class CallInstance : public InstanceBase { - public: - CallInstance(); - CallInstance(const CallInstance& other); - CallInstance& operator=(const CallInstance& other); - - // Deserializes an instance from serialized lines of text provided by the - // extractor. - // |serialized_lines| are read from |start_line| to |end_line| and should - // contain the following lines: - // 1- File path. - // 2- Name of the function in which the call is made. - // 3- Name of the called function. - // 4- Does the call have an annotation? - AuditorResult Deserialize(const std::vector<std::string>& serialized_lines, - int start_line, - int end_line) override; - - std::string file_path; - uint32_t line_number; - - // Name of the function that may need annotation. - std::string function_name; - - // Is function |function_name| annotated? - bool is_annotated; -}; - -// Holds an instance of initializing a traffic annotation tag with list -// expressions or assignment of a value to |unique_id_hash_code| of the mutable -// ones, outside traffic annotation API functions. -class AssignmentInstance : public InstanceBase { - public: - AssignmentInstance(); - AssignmentInstance(const AssignmentInstance& other); - - // Deserializes an instance from serialized lines of text provided by the - // extractor. - // |serialized_lines| are read from |start_line| to |end_line| and should - // contain the following lines: - // 1- File path. - // 2- Name of the function in which the assignment is made. - // 3- Line number. - AuditorResult Deserialize(const std::vector<std::string>& serialized_lines, - int start_line, - int end_line) override; - - std::string file_path; - uint32_t line_number; -}; - -#endif // TOOLS_TRAFFIC_ANNOTATION_AUDITOR_INSTANCE_H_ diff --git a/chromium/tools/traffic_annotation/auditor/safe_list.txt b/chromium/tools/traffic_annotation/auditor/safe_list.txt index ff2cae192d9..496112f5f7b 100644 --- a/chromium/tools/traffic_annotation/auditor/safe_list.txt +++ b/chromium/tools/traffic_annotation/auditor/safe_list.txt @@ -1,7 +1,7 @@ # This is a comma separated file, specifying the safe list for network traffic # annotation auditor. Please refer to README.md for more details. -# Please remove content_browser_client_impl.cc after annotation is updated. all,tools/*,*test*,*fuzzer*,*mock*,*fake*,weblayer/* +all,net/android/java/src/org/chromium/net/NetworkTrafficAnnotationTag.java missing,remoting/host/token_validator_factory_impl.cc missing,components/cronet/cronet_url_request.cc missing,net/tools/quic/quic_http_proxy_backend_stream.cc @@ -9,8 +9,19 @@ missing,net/url_request/url_fetcher.cc missing,net/url_request/url_request_context.cc mutable_tag,components/download/internal/background_service/proto_conversions.cc mutable_tag,chrome/browser/media/router/providers/openscreen/platform/udp_socket.cc +mutable_tag,net/traffic_annotation/network_traffic_annotation.h test_annotation,components/safe_search_api/stub_url_checker.cc test_annotation,net/quic/quic_chromium_client_session_peer.cc test_annotation,net/tools/quic/quic_http_proxy_backend_stream.cc -# TODO(crbug.com/995852): Fix this Android-specific annotation. -all,chrome/browser/endpoint_fetcher/endpoint_fetcher.cc +# TODO(crbug.com/995852): Fix Android-specific annotations. +missing,chrome/browser/endpoint_fetcher/endpoint_fetcher.cc +missing,android_webview/browser/network_service/aw_proxy_config_monitor.cc +missing,chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc +missing,chrome/browser/android/feedback/connectivity_checker.cc +missing,chrome/browser/android/webapk/webapk_installer.cc +missing,net/proxy_resolution/proxy_config_service_android.cc +missing,chrome/android/features/tab_ui/java/src/or/chromium/chrome/browser/tasks/tab_management/suggestions/TabSuggestions.java +missing,chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/suggestions/TabSuggestionsServerFetcher.java +missing,chrome/browser/commerce/subscriptions/android/java/src/org/chromium/chrome/browser/subscriptions/CommerceSubscriptionsServiceProxy.java +missing,chrome/browser/page_annotations/android/java/src/org/chromium/chrome/browser/page_annotations/PageAnnotationsServiceProxy.java +missing,chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/state/StorePersistedTabData.java diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc b/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc deleted file mode 100644 index b65bd7c204b..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc +++ /dev/null @@ -1,797 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "tools/traffic_annotation/auditor/traffic_annotation_auditor.h" - -#include <stdio.h> - -#include "base/containers/contains.h" -#include "base/files/file_enumerator.h" -#include "base/files/file_util.h" -#include "base/logging.h" -#include "base/memory/ptr_util.h" -#include "base/process/launch.h" -#include "base/strings/string_split.h" -#include "base/strings/string_util.h" -#include "base/strings/stringprintf.h" -#include "base/strings/utf_string_conversions.h" -#include "build/build_config.h" -#include "net/traffic_annotation/network_traffic_annotation.h" -#include "net/traffic_annotation/network_traffic_annotation_test_helper.h" -#include "third_party/libxml/chromium/xml_reader.h" -#include "third_party/libxml/chromium/xml_writer.h" -#include "third_party/re2/src/re2/re2.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_file_filter.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_id_checker.h" - -namespace { - -// Recursively compute the hash code of the given string as in: -// "net/traffic_annotation/network_traffic_annotation.h" -uint32_t recursive_hash(const char* str, int N) { - if (N == 1) - return static_cast<uint32_t>(str[0]); - else - return (recursive_hash(str, N - 1) * 31 + str[N - 1]) % 138003713; -} - -std::map<int, std::string> kReservedAnnotations = { - {TRAFFIC_ANNOTATION_FOR_TESTS.unique_id_hash_code, "test"}, - {PARTIAL_TRAFFIC_ANNOTATION_FOR_TESTS.unique_id_hash_code, "test_partial"}, - {MISSING_TRAFFIC_ANNOTATION.unique_id_hash_code, "missing"}}; - -struct AnnotationID { - // Two ids can be the same in the following cases: - // 1- One is extra id of a partial annotation, and the other is either the - // unique id of a completing annotation, or extra id of a partial or - // branched completing annotation - // 2- Both are extra ids of branched completing annotations. - // The following Type value facilitate these checks. - enum class Type { kPatrialExtra, kCompletingMain, kBranchedExtra, kOther }; - Type type; - std::string text; - int hash; - AnnotationInstance* instance; -}; - -const std::string kBlockTypes[] = {"ASSIGNMENT", "ANNOTATION", "CALL"}; - -const base::FilePath kSafeListPath = - base::FilePath(FILE_PATH_LITERAL("tools")) - .Append(FILE_PATH_LITERAL("traffic_annotation")) - .Append(FILE_PATH_LITERAL("auditor")) - .Append(FILE_PATH_LITERAL("safe_list.txt")); - -const base::FilePath kExtractorScript = - base::FilePath(FILE_PATH_LITERAL("tools")) - .Append(FILE_PATH_LITERAL("traffic_annotation")) - .Append(FILE_PATH_LITERAL("scripts")) - .Append(FILE_PATH_LITERAL("extractor.py")); - -const base::FilePath kGroupingXmlPath = - base::FilePath(FILE_PATH_LITERAL("tools")) - .Append(FILE_PATH_LITERAL("traffic_annotation")) - .Append(FILE_PATH_LITERAL("summary")) - .Append(FILE_PATH_LITERAL("grouping.xml")); - -// Checks if the list of |path_filters| include the given |file_path|, or there -// are path filters which are a folder (don't have a '.' in their name), and -// match the file name. -// TODO(https://crbug.com/690323): Update to a more general policy. -bool PathFiltersMatch(const std::vector<std::string>& path_filters, - const std::string file_path) { - if (base::Contains(path_filters, file_path)) - return true; - for (const std::string& path_filter : path_filters) { - if (path_filter.find(".") == std::string::npos && - file_path.substr(0, path_filter.length()) == path_filter) { - return true; - } - } - return false; -} - -// If normalized |file_path| starts with |base_directory|, returns the -// relative path to |file_path|, otherwise the original |file_path| is returned. -std::string MakeRelativePath(const base::FilePath& base_directory, - const std::string& file_path) { - DCHECK(base_directory.IsAbsolute()); - -#if defined(OS_WIN) - base::FilePath converted_file_path = base::FilePath( - base::FilePath::StringPieceType((base::UTF8ToWide(file_path)))); -#else - base::FilePath converted_file_path(file_path); -#endif - converted_file_path = base::MakeAbsoluteFilePath(converted_file_path); - base::FilePath normalized_path; - if (base::NormalizeFilePath(converted_file_path, &normalized_path) && - normalized_path.IsAbsolute()) { - normalized_path = normalized_path.NormalizePathSeparatorsTo('/'); - std::string file_str = normalized_path.MaybeAsASCII(); - std::string base_str = base_directory.MaybeAsASCII(); - if (file_str.find(base_str) == 0) { - return file_str.substr(base_str.length() + 1, - file_str.length() - base_str.length() - 1); - } - } - return file_path; -} - -} // namespace - -TrafficAnnotationAuditor::TrafficAnnotationAuditor( - const base::FilePath& source_path, - const base::FilePath& build_path, - const std::vector<std::string>& path_filters) - : source_path_(source_path), - build_path_(build_path), - path_filters_(path_filters), - exporter_(source_path), - safe_list_loaded_(false) { - DCHECK(!source_path.empty()); - DCHECK(!build_path.empty()); - - // Get absolute source path. - base::FilePath original_path; - base::GetCurrentDirectory(&original_path); - base::SetCurrentDirectory(source_path_); - base::GetCurrentDirectory(&absolute_source_path_); - base::SetCurrentDirectory(original_path); - absolute_source_path_ = absolute_source_path_.NormalizePathSeparatorsTo('/'); - DCHECK(absolute_source_path_.IsAbsolute()); - - // Load a live version traffic_annotation.proto from source files. - google::protobuf::compiler::DiskSourceTree source_tree; - base::FilePath absolute_build_path_ = - build_path_.IsAbsolute() ? build_path_ - : absolute_source_path_.Append(build_path_); - source_tree.MapPath("", - absolute_source_path_.Append(FILE_PATH_LITERAL("chrome")) - .Append(FILE_PATH_LITERAL("browser")) - .Append(FILE_PATH_LITERAL("privacy")) - .MaybeAsASCII()); - source_tree.MapPath("", absolute_build_path_.Append(FILE_PATH_LITERAL("gen")) - .Append(FILE_PATH_LITERAL("components")) - .Append(FILE_PATH_LITERAL("policy")) - .Append(FILE_PATH_LITERAL("proto")) - .MaybeAsASCII()); - google::protobuf::compiler::SourceTreeDescriptorDatabase db(&source_tree); - descriptor_pool_ = std::make_unique<google::protobuf::DescriptorPool>(&db); - auto* fd = descriptor_pool_->FindFileByName("traffic_annotation.proto"); - if (fd != nullptr) { - // If we manage to load the proto file, then we load the runtime message. - auto* descriptor = fd->FindMessageTypeByName("NetworkTrafficAnnotation"); - annotation_prototype_ = - base::WrapUnique(message_factory_.GetPrototype(descriptor)->New()); - } else { - LOG(WARNING) << "traffic_annotation.proto failed to load at runtime, " - << "reverting to using static proto."; - } -} - -TrafficAnnotationAuditor::~TrafficAnnotationAuditor() = default; - -// static -int TrafficAnnotationAuditor::ComputeHashValue(const std::string& unique_id) { - return unique_id.length() ? static_cast<int>(recursive_hash( - unique_id.c_str(), unique_id.length())) - : -1; -} - -bool TrafficAnnotationAuditor::RunExtractor( - bool filter_files_based_on_heuristics, - bool use_compile_commands, - const base::FilePath& errors_file, - int* exit_code) { - if (!safe_list_loaded_ && !LoadSafeList()) - return false; - - // Get list of files/folders to process. - std::vector<std::string> file_paths; - GenerateFilesListForExtractor(filter_files_based_on_heuristics, - use_compile_commands, &file_paths); - if (file_paths.empty()) - return true; - - // Create a file to pass options to the extractor script. - base::FilePath options_filepath; - if (!base::CreateTemporaryFile(&options_filepath)) { - LOG(ERROR) << "Could not create temporary options file."; - return false; - } - FILE* options_file = base::OpenFile(options_filepath, "wt"); - if (!options_file) { - LOG(ERROR) << "Could not open temporary options file."; - return false; - } - - // Write some options to the file for the python extractor. - WritePythonScriptOptions(options_file); - - // Write the file paths. - for (const std::string& file_path : file_paths) - fprintf(options_file, "%s ", file_path.c_str()); - - base::CloseFile(options_file); - - base::CommandLine cmdline( - base::MakeAbsoluteFilePath(source_path_.Append(kExtractorScript))); -#if defined(OS_WIN) - cmdline.PrependWrapper(L"python.bat"); -#endif - cmdline.AppendArg(base::StringPrintf( - "--options-file=%s", options_filepath.MaybeAsASCII().c_str())); - - // Change current folder to source before running the command as it expects to - // be run from there. - base::FilePath original_path; - base::GetCurrentDirectory(&original_path); - base::SetCurrentDirectory(source_path_); - bool result = base::GetAppOutputWithExitCode(cmdline, &extractor_raw_output_, - exit_code); - - // If the extractor had no output, it means that the script running it could - // not perform the task. - if (extractor_raw_output_.empty()) { - result = false; - } - - if (!result) { - std::string tool_errors; - std::string options_file_text; - - base::GetAppOutputAndError(cmdline, &tool_errors); - - if (!base::ReadFileToString(options_filepath, &options_file_text)) - options_file_text = "Could not read options file."; - - std::string error_message = base::StringPrintf( - "Calling extractor returned false from %s\nCommandline: %s\n\n" - "Returned output: %s\n\nPartial options file: %s\n", - source_path_.MaybeAsASCII().c_str(), -#if defined(OS_WIN) - base::WideToUTF8(cmdline.GetCommandLineString()).c_str(), -#else - cmdline.GetCommandLineString().c_str(), -#endif - tool_errors.c_str(), options_file_text.substr(0, 1024).c_str()); - - if (errors_file.empty()) { - LOG(ERROR) << error_message; - } else { - if (base::WriteFile(errors_file, error_message.c_str(), - error_message.length()) == -1) { - LOG(ERROR) << "Writing error message to file failed:\n" - << error_message; - } - } - } - - base::SetCurrentDirectory(original_path); - base::DeleteFile(options_filepath); - - return result; -} - -void TrafficAnnotationAuditor::WritePythonScriptOptions(FILE* options_file) { - fprintf(options_file, "--generate-compdb --build-path=%s ", - build_path_.MaybeAsASCII().c_str()); -} - -void TrafficAnnotationAuditor::GenerateFilesListForExtractor( - bool filter_files_based_on_heuristics, - bool use_compile_commands, - std::vector<std::string>* file_paths) { - TrafficAnnotationFileFilter filter; - // If no path filter is provided, get all relevant files, except the safe - // listed ones. - if (path_filters_.empty()) { - filter.GetRelevantFiles( - source_path_, - safe_list_[static_cast<int>(AuditorException::ExceptionType::ALL)], "", - file_paths); - return; - } - - base::FilePath original_path; - base::GetCurrentDirectory(&original_path); - base::SetCurrentDirectory(source_path_); - - for (const auto& path_filter : path_filters_) { -#if defined(OS_WIN) - base::FilePath path = base::FilePath( - base::FilePath::StringPieceType((base::UTF8ToWide(path_filter)))); -#else - base::FilePath path = base::FilePath(path_filter); -#endif - - // If path filter is a directory, add its relevent, not safe-listed - // contents. - if (base::DirectoryExists(path)) { - filter.GetRelevantFiles( - source_path_, - safe_list_[static_cast<int>(AuditorException::ExceptionType::ALL)], - path_filter, file_paths); - } else if (base::PathExists(path) && - !TrafficAnnotationAuditor::IsSafeListed( - path_filter, AuditorException::ExceptionType::ALL) && - filter.IsFileRelevant(path_filter)) { - file_paths->push_back(path_filter); - } - } - - base::SetCurrentDirectory(original_path); -} - -bool TrafficAnnotationAuditor::IsSafeListed( - const std::string& file_path, - AuditorException::ExceptionType exception_type) { - if (!safe_list_loaded_ && !LoadSafeList()) - return false; - const std::vector<std::string>& safe_list = - safe_list_[static_cast<int>(exception_type)]; - - for (const std::string& ignore_pattern : safe_list) { - if (re2::RE2::FullMatch(file_path, ignore_pattern)) - return true; - } - - // If the given filepath did not match the rules with the specified type, - // check it with rules of type 'ALL' as well. - if (exception_type != AuditorException::ExceptionType::ALL) - return IsSafeListed(file_path, AuditorException::ExceptionType::ALL); - return false; -} - -std::unique_ptr<google::protobuf::Message> -TrafficAnnotationAuditor::CreateAnnotationProto() { - if (annotation_prototype_ != nullptr) { - return base::WrapUnique(annotation_prototype_->New()); - } - return nullptr; -} - -bool TrafficAnnotationAuditor::ParseExtractorRawOutput() { - if (!safe_list_loaded_ && !LoadSafeList()) - return false; - // Remove possible carriage return characters before splitting lines. - std::string temp_string; - base::RemoveChars(extractor_raw_output_, "\r", &temp_string); - std::vector<std::string> lines = base::SplitString( - temp_string, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL); - for (unsigned int current = 0; current < lines.size(); current++) { - // All blocks reported by extractor start with '====', so we can ignore - // all lines that do not start with a '='. - if (lines[current].empty() || lines[current][0] != '=') - continue; - - std::string block_type; - std::string end_marker; - for (const std::string& item : kBlockTypes) { - if (lines[current] == - base::StringPrintf("==== NEW %s ====", item.c_str())) { - end_marker = base::StringPrintf("==== %s ENDS ====", item.c_str()); - block_type = item; - break; - } - } - - // If not starting a valid block, ignore the line. - if (block_type.empty()) - continue; - - // Get the block. - current++; - unsigned int end_line = current; - while (end_line < lines.size() && lines[end_line] != end_marker) - end_line++; - if (end_line == lines.size()) { - LOG(ERROR) << "Block starting at line " << current - << " is not ended by the appropriate tag."; - return false; - } - - // Deserialize and handle errors. - AuditorResult result(AuditorResult::Type::RESULT_OK); - - if (block_type == "ANNOTATION") { - AnnotationInstance new_annotation; - new_annotation.runtime_proto = CreateAnnotationProto(); - result = new_annotation.Deserialize(lines, current, end_line); - std::string file_path = result.IsOK() - ? new_annotation.proto.source().file() - : result.file_path(); - file_path = MakeRelativePath(absolute_source_path_, file_path); - if (IsSafeListed(file_path, AuditorException::ExceptionType::ALL)) - result = AuditorResult(AuditorResult::Type::RESULT_IGNORE); - switch (result.type()) { - case AuditorResult::Type::RESULT_OK: - new_annotation.proto.mutable_source()->set_file(file_path); - extracted_annotations_.push_back(new_annotation); - break; - case AuditorResult::Type::ERROR_MISSING_TAG_USED: - if (IsSafeListed(file_path, AuditorException::ExceptionType::MISSING)) - result = AuditorResult(AuditorResult::Type::RESULT_IGNORE); - break; - case AuditorResult::Type::ERROR_TEST_ANNOTATION: - if (IsSafeListed(file_path, - AuditorException::ExceptionType::TEST_ANNOTATION)) { - result = AuditorResult(AuditorResult::Type::RESULT_IGNORE); - } - break; - case AuditorResult::Type::ERROR_MUTABLE_TAG: - if (IsSafeListed(file_path, - AuditorException::ExceptionType::MUTABLE_TAG)) { - result = AuditorResult(AuditorResult::Type::RESULT_IGNORE); - } - break; - default: - break; - } - } else if (block_type == "CALL") { - CallInstance new_call; - result = new_call.Deserialize(lines, current, end_line); - new_call.file_path = - MakeRelativePath(absolute_source_path_, new_call.file_path); - if (IsSafeListed(new_call.file_path, - AuditorException::ExceptionType::ALL)) { - result = AuditorResult(AuditorResult::Type::RESULT_IGNORE); - } - if (result.IsOK()) - extracted_calls_.push_back(new_call); - } else if (block_type == "ASSIGNMENT") { - AssignmentInstance new_assignment; - result = new_assignment.Deserialize(lines, current, end_line); - new_assignment.file_path = - MakeRelativePath(absolute_source_path_, new_assignment.file_path); - if (IsSafeListed(new_assignment.file_path, - AuditorException::ExceptionType::DIRECT_ASSIGNMENT)) { - result = AuditorResult(AuditorResult::Type::RESULT_IGNORE); - } else if (result.IsOK()) { - result = AuditorResult(AuditorResult::Type::ERROR_DIRECT_ASSIGNMENT, - std::string(), new_assignment.file_path, - new_assignment.line_number); - } - } else { - NOTREACHED(); - } - - switch (result.type()) { - case AuditorResult::Type::RESULT_OK: - case AuditorResult::Type::RESULT_IGNORE: - break; - case AuditorResult::Type::ERROR_FATAL: { - LOG(ERROR) << "Aborting after line " << current - << " because: " << result.ToText().c_str(); - return false; - } - default: - if (!IsSafeListed(result.file_path(), - AuditorException::ExceptionType::ALL)) { - errors_.push_back(result); - } - } - - current = end_line; - } // for - - return true; -} - -bool TrafficAnnotationAuditor::LoadSafeList() { - base::FilePath safe_list_file = - base::MakeAbsoluteFilePath(source_path_.Append(kSafeListPath)); - - std::string file_content; - if (!base::ReadFileToString(safe_list_file, &file_content)) { - LOG(ERROR) << "Could not read " << kSafeListPath.MaybeAsASCII(); - return false; - } - - base::RemoveChars(file_content, "\r", &file_content); - std::vector<std::string> lines = base::SplitString( - file_content, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL); - - for (const std::string& line : lines) { - // Ignore comments and empty lines. - if (!line.length() || line[0] == '#') - continue; - - std::vector<std::string> tokens = base::SplitString( - line, ",", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL); - - // Expect a type and at least one value in each line. - if (tokens.size() < 2) { - LOG(ERROR) << "Unexpected syntax in safe_list.txt, line: " << line; - return false; - } - - AuditorException::ExceptionType exception_type; - if (!AuditorException::TypeFromString(tokens[0], &exception_type)) { - LOG(ERROR) << "Unexpected type in safe_list.txt line: " << line; - return false; - } - for (unsigned i = 1; i < tokens.size(); i++) { - // Convert the rest of the line into re2 patterns, making dots as fixed - // characters and asterisks as wildcards. - // Note that all file paths are converted to Linux style before checking. - if (!base::ContainsOnlyChars( - base::ToLowerASCII(tokens[i]), - "0123456789_abcdefghijklmnopqrstuvwxyz.*/:@")) { - LOG(ERROR) << "Unexpected character in safe_list.txt token: " - << tokens[i]; - return false; - } - std::string pattern; - base::ReplaceChars(tokens[i], ".", "[.]", &pattern); - base::ReplaceChars(pattern, "*", ".*", &pattern); - safe_list_[static_cast<int>(exception_type)].push_back(pattern); - } - } - - safe_list_loaded_ = true; - return true; -} - -// static -const std::map<int, std::string>& -TrafficAnnotationAuditor::GetReservedIDsMap() { - return kReservedAnnotations; -} - -// static -std::set<int> TrafficAnnotationAuditor::GetReservedIDsSet() { - std::set<int> reserved_ids; - for (const auto& item : kReservedAnnotations) - reserved_ids.insert(item.first); - return reserved_ids; -} - -void TrafficAnnotationAuditor::CheckAllRequiredFunctionsAreAnnotated() { - for (const CallInstance& call : extracted_calls_) { - if (!call.is_annotated && !CheckIfCallCanBeUnannotated(call)) { - errors_.push_back( - AuditorResult(AuditorResult::Type::ERROR_MISSING_ANNOTATION, - call.function_name, call.file_path, call.line_number)); - } - } -} - -bool TrafficAnnotationAuditor::CheckIfCallCanBeUnannotated( - const CallInstance& call) { - if (IsSafeListed(call.file_path, AuditorException::ExceptionType::MISSING)) - return true; - - // Unittests should be all annotated. Although this can be detected using gn, - // doing that would be very slow. The alternative solution would be to bypass - // every file including test or unittest, but in this case there might be some - // ambiguity in what should be annotated and what not. - if (call.file_path.find("unittest") != std::string::npos) - return false; - - // Already checked? - if (base::Contains(checked_dependencies_, call.file_path)) - return checked_dependencies_[call.file_path]; - - std::string gn_output; - if (gn_file_for_test_.empty()) { - // Check if the file including this function is part of Chrome build. - const base::CommandLine::CharType* args[] = { -#if defined(OS_WIN) - FILE_PATH_LITERAL("buildtools/win/gn.exe"), -#elif defined(OS_MAC) - FILE_PATH_LITERAL("buildtools/mac/gn"), -#elif defined(OS_LINUX) || defined(OS_CHROMEOS) - FILE_PATH_LITERAL("buildtools/linux64/gn"), -#else - // Fallback to using PATH to find gn. - FILE_PATH_LITERAL("gn"), -#endif - FILE_PATH_LITERAL("refs"), - FILE_PATH_LITERAL("--all") - }; - - base::CommandLine cmdline(3, args); - cmdline.AppendArgPath(build_path_); - cmdline.AppendArg(call.file_path); - - base::FilePath original_path; - base::GetCurrentDirectory(&original_path); - base::SetCurrentDirectory(source_path_); - if (!base::GetAppOutput(cmdline, &gn_output)) { - LOG(ERROR) << "Could not run gn to get dependencies."; - gn_output.clear(); - } - base::SetCurrentDirectory(original_path); - } else { - if (!base::ReadFileToString(gn_file_for_test_, &gn_output)) { - LOG(ERROR) << "Could not load mock gn output file from " - << gn_file_for_test_.MaybeAsASCII().c_str(); - gn_output.clear(); - } - } - - checked_dependencies_[call.file_path] = - gn_output.length() && - gn_output.find("//chrome:chrome") == std::string::npos; - - return checked_dependencies_[call.file_path]; -} - -void TrafficAnnotationAuditor::CheckAnnotationsContents() { - std::vector<AnnotationInstance*> partial_annotations; - std::vector<AnnotationInstance*> completing_annotations; - std::vector<AnnotationInstance> new_annotations; - - // Process complete annotations and separate the others. - for (AnnotationInstance& instance : extracted_annotations_) { - switch (instance.type) { - case AnnotationInstance::Type::ANNOTATION_COMPLETE: { - // Instances loaded from archive are already checked before archiving. - if (instance.is_loaded_from_archive) - continue; - AuditorResult result = instance.IsComplete(); - if (result.IsOK()) - result = instance.IsConsistent(); - if (result.IsOK()) - result = instance.InGroupingXML(grouped_annotation_unique_ids_); - if (!result.IsOK()) - errors_.push_back(result); - break; - } - case AnnotationInstance::Type::ANNOTATION_PARTIAL: - partial_annotations.push_back(&instance); - break; - default: - completing_annotations.push_back(&instance); - } - } - - std::set<AnnotationInstance*> used_completing_annotations; - - for (AnnotationInstance* partial : partial_annotations) { - bool found_a_pair = false; - for (AnnotationInstance* completing : completing_annotations) { - if (partial->IsCompletableWith(*completing)) { - found_a_pair = true; - used_completing_annotations.insert(completing); - - // Instances loaded from archive are already checked before archiving. - if (partial->is_loaded_from_archive && - completing->is_loaded_from_archive) { - break; - } - - AnnotationInstance completed; - AuditorResult result = - partial->CreateCompleteAnnotation(*completing, &completed); - - if (result.IsOK()) - result = completed.IsComplete(); - - if (result.IsOK()) - result = completed.IsConsistent(); - - if (result.IsOK()) - result = completed.InGroupingXML(grouped_annotation_unique_ids_); - - if (result.IsOK()) { - new_annotations.push_back(completed); - } else { - result = AuditorResult(AuditorResult::Type::ERROR_MERGE_FAILED, - result.ToShortText()); - result.AddDetail(partial->proto.unique_id()); - result.AddDetail(completing->proto.unique_id()); - errors_.push_back(result); - } - } - } - - if (!found_a_pair) { - errors_.push_back( - AuditorResult(AuditorResult::Type::ERROR_INCOMPLETED_ANNOTATION, - partial->proto.unique_id())); - } - } - - for (AnnotationInstance* instance : completing_annotations) { - if (!base::Contains(used_completing_annotations, instance)) { - errors_.push_back( - AuditorResult(AuditorResult::Type::ERROR_INCOMPLETED_ANNOTATION, - instance->proto.unique_id())); - } - } - - if (new_annotations.size()) - extracted_annotations_.insert(extracted_annotations_.end(), - new_annotations.begin(), - new_annotations.end()); -} - -void TrafficAnnotationAuditor::AddMissingAnnotations() { - for (const auto& item : exporter_.GetArchivedAnnotations()) { - if (item.second.deprecation_date.empty() && - exporter_.MatchesCurrentPlatform(item.second) && - !item.second.file_path.empty() && - !PathFiltersMatch(path_filters_, item.second.file_path)) { - extracted_annotations_.push_back(AnnotationInstance::LoadFromArchive( - item.second.type, item.first, item.second.unique_id_hash_code, - item.second.second_id_hash_code, item.second.content_hash_code, - item.second.semantics_fields, item.second.policy_fields, - item.second.file_path, item.second.added_in_milestone)); - } - } -} - -bool TrafficAnnotationAuditor::GetGroupingAnnotationsUniqueIDs( - base::FilePath grouping_xml_path, - std::set<std::string>* annotation_unique_ids) const { - XmlReader reader; - if (!reader.LoadFile(grouping_xml_path.MaybeAsASCII())) { - LOG(ERROR) << "Could not load '" << grouping_xml_path.MaybeAsASCII() - << "'."; - return false; - } - - bool all_ok = true; - while (reader.Read()) { - if (reader.IsClosingElement() || reader.NodeName() != "traffic_annotation") - continue; - - std::string unique_id; - all_ok &= reader.NodeAttribute("unique_id", &unique_id); - annotation_unique_ids->insert(unique_id); - } - return all_ok; -} - -bool TrafficAnnotationAuditor::RunAllChecks( - bool report_xml_updates) { - if (exporter_.GetArchivedAnnotations().empty() && - !exporter_.LoadAnnotationsXML()) { - return false; - } - - std::set<int> deprecated_ids; - exporter_.GetDeprecatedHashCodes(&deprecated_ids); - - if (!GetGroupingAnnotationsUniqueIDs(source_path_.Append(kGroupingXmlPath), - &grouped_annotation_unique_ids_)) { - return false; - } - - if (!path_filters_.empty()) - AddMissingAnnotations(); - - TrafficAnnotationIDChecker id_checker(GetReservedIDsSet(), deprecated_ids); - id_checker.Load(extracted_annotations_); - id_checker.CheckIDs(&errors_); - - // Only check annotation contents if IDs are all OK, because if there are - // id errors, there might be some mismatching annotations and irrelevant - // content errors. - if (errors_.empty()) - CheckAnnotationsContents(); - - CheckAllRequiredFunctionsAreAnnotated(); - - if (errors_.empty()) { - exporter_.UpdateAnnotations(extracted_annotations_, GetReservedIDsMap(), - &errors_); - } - - // If |report_xml_updates| is true, check annotations.xml whether or not it is - // modified, as there might be format differences with exporter outputs due to - // manual updates. - if (report_xml_updates) { - std::string updates = exporter_.GetRequiredUpdates(); - if (!updates.empty()) { - errors_.push_back(AuditorResult( - AuditorResult::Type::ERROR_ANNOTATIONS_XML_UPDATE, updates)); - } - } - - return true; -} diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor.h b/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor.h deleted file mode 100644 index 099e5dd9938..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor.h +++ /dev/null @@ -1,220 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef TOOLS_TRAFFIC_ANNOTATION_AUDITOR_TRAFFIC_ANNOTATION_AUDITOR_H_ -#define TOOLS_TRAFFIC_ANNOTATION_AUDITOR_TRAFFIC_ANNOTATION_AUDITOR_H_ - -#include <vector> - -#include "base/command_line.h" -#include "base/files/file_path.h" -#include "third_party/protobuf/src/google/protobuf/compiler/importer.h" -#include "third_party/protobuf/src/google/protobuf/dynamic_message.h" -#include "tools/traffic_annotation/auditor/auditor_result.h" -#include "tools/traffic_annotation/auditor/instance.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_exporter.h" -#include "tools/traffic_annotation/traffic_annotation.pb.h" - -// Holds an item of safe list rules for auditor. -struct AuditorException { - enum class ExceptionType { - ALL, // Ignore all errors (doesn't check the files at all). - MISSING, // Ignore missing annotations. - DIRECT_ASSIGNMENT, // Ignore direct assignment of annotation value. - TEST_ANNOTATION, // Ignore usages of annotation for tests. - MUTABLE_TAG, // Ignore CreateMutableNetworkTrafficAnnotationTag(). - EXCEPTION_TYPE_LAST = MUTABLE_TAG, - } type; - - static bool TypeFromString(const std::string& type_string, - ExceptionType* type_value) { - if (type_string == "all") { - *type_value = ExceptionType::ALL; - } else if (type_string == "missing") { - *type_value = ExceptionType::MISSING; - } else if (type_string == "direct_assignment") { - *type_value = ExceptionType::DIRECT_ASSIGNMENT; - } else if (type_string == "test_annotation") { - *type_value = ExceptionType::TEST_ANNOTATION; - } else if (type_string == "mutable_tag") { - *type_value = ExceptionType::MUTABLE_TAG; - } else { - return false; - } - return true; - } -}; - - -class TrafficAnnotationAuditor { - public: - // Creates an auditor object, storing the following paths: - // |source_path|: Path to the src directory. - // |build_path|: Path to a compiled build directory. - // |path_filters|: Filters to limit where we're scanning the source. - TrafficAnnotationAuditor(const base::FilePath& source_path, - const base::FilePath& build_path, - const std::vector<std::string>& path_filters); - ~TrafficAnnotationAuditor(); - - // Runs extractor.py and puts its output in |extractor_raw_output_|. If - // |filter_files_based_on_heuristics| flag is set, the list of files will be - // received from repository and heuristically filtered to only process the - // relevant files. If |use_compile_commands| flag is set, the list of files is - // extracted from compile_commands.json instead of git and will not be - // filtered. If the extractor returns errors, the tool is run again to record - // errors. Errors are written to |errors_file| if it is not empty, otherwise - // LOG(ERROR). - bool RunExtractor(bool filter_files_based_on_heuristics, - bool use_compile_commands, - const base::FilePath& errors_file, - int* exit_code); - - // Parses the output of extractor.py (|extractor_raw_output_|) and populates - // |extracted_annotations_|, |extracted_calls_|, and |errors_|. - // Errors include not finding the file, incorrect content, or missing or not - // provided annotations. - bool ParseExtractorRawOutput(); - - // Computes the hash value of a traffic annotation unique id. - static int ComputeHashValue(const std::string& unique_id); - - // Loads the safe list file and populates |safe_list_|. - bool LoadSafeList(); - - // Checks to see if a |file_path| matches a safe list with given type. - bool IsSafeListed(const std::string& file_path, - AuditorException::ExceptionType exception_type); - - // Checks to see if annotation contents are valid. Complete annotations should - // have all required fields and be consistent, and incomplete annotations - // should be completed with each other. Merges all matching incomplete - // annotations and adds them to |extracted_annotations_|, adds errors - // to |errors| and purges all incomplete annotations. - void CheckAnnotationsContents(); - - // Checks to see if all functions that need annotations have one. - void CheckAllRequiredFunctionsAreAnnotated(); - - // Checks if a call instance can stay not annotated. - bool CheckIfCallCanBeUnannotated(const CallInstance& call); - - // Performs all checks on extracted annotations and calls. The input path - // filters are passed so that the data for files that were not tested would be - // read from annotations.xml. If |report_xml_updates| is set and - // annotations.xml requires updates, the updates are added to |errors_|. - bool RunAllChecks(bool report_xml_updates); - - // Returns a mapping of reserved unique ids' hash codes to the unique ids' - // texts. This list includes all unique ids that are defined in - // net/traffic_annotation/network_traffic_annotation.h and - // net/traffic_annotation/network_traffic_annotation_test_helper.h - static const std::map<int, std::string>& GetReservedIDsMap(); - - // Returns a set of reserved unique ids' hash codes. This set includes all - // unique ids that are defined in - // net/traffic_annotation/network_traffic_annotation.h and - // net/traffic_annotation/network_traffic_annotation_test_helper.h - static std::set<int> GetReservedIDsSet(); - - std::string extractor_raw_output() const { return extractor_raw_output_; } - - void set_extractor_raw_output(const std::string& raw_output) { - extractor_raw_output_ = raw_output; - } - - const std::vector<AnnotationInstance>& extracted_annotations() const { - return extracted_annotations_; - } - - void SetExtractedAnnotationsForTesting( - const std::vector<AnnotationInstance>& annotations) { - extracted_annotations_ = annotations; - } - - void SetExtractedCallsForTesting(const std::vector<CallInstance>& calls) { - extracted_calls_ = calls; - } - - void SetGroupedAnnotationUniqueIDsForTesting( - std::set<std::string>& annotation_unique_ids) { - grouped_annotation_unique_ids_ = annotation_unique_ids; - } - - const std::vector<CallInstance>& extracted_calls() const { - return extracted_calls_; - } - - const std::vector<AuditorResult>& errors() const { return errors_; } - - const TrafficAnnotationExporter& exporter() const { return exporter_; } - - void ClearErrorsForTesting() { errors_.clear(); } - - void ClearCheckedDependenciesForTesting() { checked_dependencies_.clear(); } - - // Sets the path to a file that would be used to mock the output of - // 'gn refs --all [build directory] [file path]' in tests. - void SetGnFileForTesting(const base::FilePath& file_path) { - gn_file_for_test_ = file_path; - } - - void ClearPathFilters() { path_filters_.clear(); } - - std::unique_ptr<google::protobuf::Message> CreateAnnotationProto(); - - // Produces the set of annotation unique_ids that appear in grouping.xml - // Returns false if grouping.xml cannot be loaded. - bool GetGroupingAnnotationsUniqueIDs( - base::FilePath grouping_xml_path, - std::set<std::string>* annotation_unique_ids) const; - - private: - const base::FilePath source_path_; - const base::FilePath build_path_; - std::vector<std::string> path_filters_; - std::set<std::string> grouped_annotation_unique_ids_; - - // Variables used to dynamic the NetworkTrafficAnnotation proto. - std::unique_ptr<google::protobuf::DescriptorPool> descriptor_pool_; - google::protobuf::DynamicMessageFactory message_factory_; - std::unique_ptr<google::protobuf::Message> annotation_prototype_; - - base::FilePath absolute_source_path_; - - TrafficAnnotationExporter exporter_; - - std::string extractor_raw_output_; - std::vector<AnnotationInstance> extracted_annotations_; - std::vector<CallInstance> extracted_calls_; - std::vector<AuditorResult> errors_; - - bool safe_list_loaded_; - std::vector<std::string> - safe_list_[static_cast<int>( - AuditorException::ExceptionType::EXCEPTION_TYPE_LAST) + - 1]; - - // Adds all archived annotations (from annotations.xml) that match the - // following features, to |extracted_annotations_|: - // 1- Not deprecated. - // 2- OS list includes current platform. - // 2- Has a path (is not a reserved word). - // 3- Path matches an item in |path_filters_|. - void AddMissingAnnotations(); - - // Generates files list to run extractor on. Please refer to RunExtractor - // function's comment. - void GenerateFilesListForExtractor(bool filter_files_based_on_heuristics, - bool use_compile_commands, - std::vector<std::string>* file_paths); - - // Write flags to the options file, for RunExtractor. - void WritePythonScriptOptions(FILE* options_file); - - base::FilePath gn_file_for_test_; - std::map<std::string, bool> checked_dependencies_; -}; - -#endif // TOOLS_TRAFFIC_ANNOTATION_AUDITOR_TRAFFIC_ANNOTATION_AUDITOR_H_ diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc b/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc index 4a9e4664e24..1771f637644 100644 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc +++ b/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc @@ -2,318 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include <stdlib.h> +#include <stdio.h> -#include "base/files/file_util.h" -#include "base/logging.h" -#include "base/strings/string_number_conversions.h" -#include "base/strings/string_split.h" -#include "base/strings/string_util.h" -#include "base/strings/stringprintf.h" -#include "base/strings/utf_string_conversions.h" #include "build/build_config.h" -#include "net/traffic_annotation/network_traffic_annotation.h" -#include "net/traffic_annotation/network_traffic_annotation_test_helper.h" -#include "third_party/protobuf/src/google/protobuf/reflection.h" -#include "third_party/protobuf/src/google/protobuf/text_format.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_auditor.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_exporter.h" - -namespace { - -// extractor.py returns 2 if it has a parsing error (from invalid C++ source -// code). Even in error-resilient mode, this should cause a CQ failure. -const int EX_PARSE_ERROR = 2; - -const char* HELP_TEXT = R"( -Traffic Annotation Auditor -Extracts network traffic annotations from the repository, audits them for errors -and coverage, produces reports, and updates related files. - -Usage: traffic_annotation_auditor [OPTION]... [path_filters] - -Extracts network traffic annotations from source files. If path filter(s) are -specified, only those directories of the source will be analyzed. - -Options: - -h, --help Shows help. - --build-path Path to the build directory. - --source-path Optional path to the src directory. If not provided and - build-path is available, assumed to be 'build-path/../..', - otherwise current directory. - --extractor-output Optional path to the temporary file that extracted - annotations will be stored into. - --extractor-input Optional path to the file that temporary extracted - annotations are already stored in. If this is provided, - the extractor is not run and this is used as input. - --no-filtering Optional flag asking the tool to run on the whole - repository without text filtering files. - --all-files Optional flag asking to use compile_commands.json instead - of git to get the list of files that will be checked. - This flag is useful when using build flags that change - files, like jumbo. This flag slows down the execution as - it checks every compiled file. When enabled, path_filters - are ignored. - --test-only Optional flag to request just running tests and not - updating any file. If not specified, - 'tools/traffic_annotation/summary/annotations.xml' might - get updated. - --errors-file Optional file path for possible errors. If not specified, - errors are dumped to LOG(ERROR). - --no-missing-error Optional argument, resulting in just issuing a warning for - functions that miss annotation and not an error. - --summary-file Optional path to the output file with all annotations. - --annotations-file Optional path to a TSV output file with all annotations. - --limit Limit for the maximum number of returned errors. - Use 0 for unlimited. - --error-resilient Optional flag, stating not to return error in exit code if - auditor fails to perform the tests. This flag can be used - for trybots to avoid spamming when tests cannot run. - path_filters Optional paths to filter which files the tool is run on. - It can also include deleted files names when auditor is - run on a partial repository. These are ignored if all of - the following are true: - - Not using --extractor-input - - Using --no-filtering OR --all-files - - Using the python extractor - -Example: - traffic_annotation_auditor --build-path=out/Release -)"; - -const std::string kCodeSearchLink("https://cs.chromium.org/chromium/src/"); - -} // namespace - -// Writes a summary of annotations, calls, and errors. -bool WriteSummaryFile(const base::FilePath& filepath, - const std::vector<AnnotationInstance>& annotations, - const std::vector<CallInstance>& calls, - const std::vector<AuditorResult>& errors) { - std::string report; - std::vector<std::string> items; - - report = "[Errors]\n"; - for (const auto& error : errors) - items.push_back(error.ToText()); - std::sort(items.begin(), items.end()); - for (const std::string& item : items) - report += item + "\n"; - - report += "\n[Annotations]\n"; - items.clear(); - for (const auto& instance : annotations) { - std::string serialized; - google::protobuf::TextFormat::PrintToString(instance.proto, &serialized); - items.push_back(serialized + - "\n----------------------------------------\n"); - } - std::sort(items.begin(), items.end()); - for (const std::string& item : items) - report += item; - - report += "\n[Calls]\n"; - items.clear(); - for (const auto& instance : calls) { - items.push_back(base::StringPrintf( - "File:%s:%i\nFunction:%s\nAnnotated: %i\n", instance.file_path.c_str(), - instance.line_number, instance.function_name.c_str(), - instance.is_annotated)); - } - std::sort(items.begin(), items.end()); - for (const std::string& item : items) - report += item; - - return base::WriteFile(filepath, report.c_str(), report.length()) != -1; -} - -// Changes double quotations to single quotations, and adds quotations if the -// text includes end of lines or tabs. -std::string UpdateTextForTSV(std::string text) { - base::ReplaceChars(text, "\"", "'", &text); - if (text.find('\n') != std::string::npos || - text.find('\t') != std::string::npos) - return base::StringPrintf("\"%s\"", text.c_str()); - return text; -} - -// TODO(rhalavati): Update this function to extract the policy name and value -// directly from the ChromeSettingsProto object (gen/components/policy/proto/ -// chrome_settings.proto). Since ChromeSettingsProto has over 300+ -// implementations, the required output is now extracted from debug output as -// the debug output has the following format: -// POLICY_NAME { -// ... -// POLICY_NAME: POLICY_VALUE (policy value may extend to several lines.) -// } -std::string PolicyToText(std::string debug_string) { - std::vector<std::string> lines = base::SplitString( - debug_string, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL); - DCHECK(lines.size() && lines[0].length() > 3); - DCHECK_EQ(lines[0].substr(lines[0].length() - 2, 2), " {"); - // Get the title, remove the open curly bracket. - std::string title = lines[0].substr(0, lines[0].length() - 2); - std::string output; - // Find the first line that has the title in it, keep adding all next lines - // to have the full value description. - for (unsigned int i = 1; i < lines.size(); i++) { - if (!output.empty()) { - output += lines[i] + " "; - } else if (lines[i].find(title) != std::string::npos) { - output += lines[i] + " "; - } - } - - // Trim trailing spaces and at most one curly bracket. - base::TrimString(output, " ", &output); - DCHECK(!output.empty()); - if (output[output.length() - 1] == '}') - output.pop_back(); - base::TrimString(output, " ", &output); - - return output; -} - -// Writes a TSV file of all annotations and their content. -bool WriteAnnotationsFile(const base::FilePath& filepath, - const std::vector<AnnotationInstance>& annotations, - const std::vector<std::string>& missing_ids) { - std::vector<std::string> lines; - std::string title = - "Unique ID\tLast Update\tSender\tDescription\tTrigger\tData\t" - "Destination\tCookies Allowed\tCookies Store\tSetting\tChrome Policy\t" - "Comments\tSource File\tID Hash Code\tContent Hash Code"; - - for (auto& instance : annotations) { - if (instance.type != AnnotationInstance::Type::ANNOTATION_COMPLETE) - continue; - // Unique ID - std::string line = instance.proto.unique_id(); - - // Place holder for Last Update Date, will be updated in the scripts. - line += "\t"; - - // Semantics. - const auto semantics = instance.proto.semantics(); - line += base::StringPrintf("\t%s", semantics.sender().c_str()); - line += base::StringPrintf( - "\t%s", UpdateTextForTSV(semantics.description()).c_str()); - line += base::StringPrintf("\t%s", - UpdateTextForTSV(semantics.trigger()).c_str()); - line += - base::StringPrintf("\t%s", UpdateTextForTSV(semantics.data()).c_str()); - switch (semantics.destination()) { - case traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_WEBSITE: - line += "\tWebsite"; - break; - case traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_GOOGLE_OWNED_SERVICE: - line += "\tGoogle"; - break; - case traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_LOCAL: - line += "\tLocal"; - break; - case traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_OTHER: - if (!semantics.destination_other().empty()) { - line += "\t"; - line += UpdateTextForTSV(base::StringPrintf( - "Other: %s", semantics.destination_other().c_str())); - } else { - line += "\tOther"; - } - break; - - default: - NOTREACHED(); - line += "\tInvalid value"; - } - - // Policy. - const auto policy = instance.proto.policy(); - line += - policy.cookies_allowed() == - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_YES - ? "\tYes" - : "\tNo"; - line += base::StringPrintf( - "\t%s", UpdateTextForTSV(policy.cookies_store()).c_str()); - line += - base::StringPrintf("\t%s", UpdateTextForTSV(policy.setting()).c_str()); - - // Chrome Policies. Read them from the runtime protobuf (using reflection), - // not from the compiled-in proto schema. - // - // This is because the compiled-in proto may be missing some policies that - // have been added since the last traffic_annotation_auditor build. This - // codepath would crash if it used only the compiled-in proto, as - // PolicyToText() expects a certain format from DebugString(). - std::string policies_text; - const auto* runtime_policy_field = - instance.runtime_proto->GetDescriptor()->FindFieldByName("policy"); -// Dirty hack: GetMessage() is a macro in windows_types.h, which causes a -// compile failure on Windows. -#undef GetMessage - const auto& runtime_policy = - instance.runtime_proto->GetReflection()->GetMessage( - *instance.runtime_proto, runtime_policy_field); - const auto* runtime_chrome_policy_field = - runtime_policy.GetDescriptor()->FindFieldByName("chrome_policy"); - const auto& runtime_chrome_policy = - runtime_policy.GetReflection() - ->GetRepeatedFieldRef<google::protobuf::Message>( - runtime_policy, runtime_chrome_policy_field); - if (!runtime_chrome_policy.empty()) { - bool first = true; - for (const auto& msg : runtime_chrome_policy) { - if (first) - first = false; - else - policies_text += "\n"; - policies_text += PolicyToText(msg.DebugString()); - } - } else { - policies_text = policy.policy_exception_justification(); - } - line += base::StringPrintf("\t%s", UpdateTextForTSV(policies_text).c_str()); - - // Comments. - line += "\t" + UpdateTextForTSV(instance.proto.comments()); - - // Source. - const auto source = instance.proto.source(); - line += base::StringPrintf("\t%s%s?l=%i", kCodeSearchLink.c_str(), - source.file().c_str(), source.line()); - - // ID Hash code. - line += base::StringPrintf("\t%i", instance.unique_id_hash_code); - - // Content Hash code. - line += base::StringPrintf("\t%i", instance.GetContentHashCode()); - - lines.push_back(line); - } - - // Add missing annotations. - int columns = std::count(title.begin(), title.end(), '\t'); - std::string tabs(columns, '\t'); - - for (const std::string& id : missing_ids) { - lines.push_back(id + tabs); - } - - std::sort(lines.begin(), lines.end()); - lines.insert(lines.begin(), title); - std::string report; - for (const std::string& line : lines) { - report += line + "\n"; - } - - return base::WriteFile(filepath, report.c_str(), report.length()) != -1; -} #if defined(OS_WIN) int wmain(int argc, wchar_t* argv[]) { @@ -321,193 +12,9 @@ int wmain(int argc, wchar_t* argv[]) { int main(int argc, char* argv[]) { #endif printf( - "Starting traffic annotation auditor. This may take from a few " - "minutes to a few hours based on the scope of the test.\n"); - - // Parse switches. - base::CommandLine command_line = base::CommandLine(argc, argv); - if (command_line.HasSwitch("help") || command_line.HasSwitch("h") || - argc == 1) { - printf("%s", HELP_TEXT); - return EXIT_FAILURE; - } - - base::FilePath build_path = command_line.GetSwitchValuePath("build-path"); - base::FilePath source_path = command_line.GetSwitchValuePath("source-path"); - base::FilePath extractor_output = - command_line.GetSwitchValuePath("extractor-output"); - base::FilePath extractor_input = - command_line.GetSwitchValuePath("extractor-input"); - base::FilePath errors_file = command_line.GetSwitchValuePath("errors-file"); - bool filter_files = !command_line.HasSwitch("no-filtering"); - bool all_files = command_line.HasSwitch("all-files"); - bool test_only = command_line.HasSwitch("test-only"); - bool no_missing_error = command_line.HasSwitch("no-missing-error"); - base::FilePath summary_file = command_line.GetSwitchValuePath("summary-file"); - base::FilePath annotations_file = - command_line.GetSwitchValuePath("annotations-file"); - std::vector<std::string> path_filters; - int outputs_limit = 0; - if (command_line.HasSwitch("limit")) { - if (!base::StringToInt(command_line.GetSwitchValueNative("limit"), - &outputs_limit) || - outputs_limit < 0) { - LOG(ERROR) - << "The value for 'limit' switch should be a positive integer."; - - // This error is always enforced, as it is a commandline switch. - return EXIT_FAILURE; - } - } - - // If 'error-resilient' switch is provided, 0 will be returned in case of - // operational errors, otherwise 1. - bool error_resilient = command_line.HasSwitch("error-resilient"); - int error_value = error_resilient ? EXIT_SUCCESS : EXIT_FAILURE; - -#if defined(OS_WIN) - for (const auto& path : command_line.GetArgs()) { - std::string repaired_path(base::WideToASCII(path)); - base::ReplaceChars(repaired_path, "\\", "/", &repaired_path); - path_filters.push_back(repaired_path); - } -#else - path_filters = command_line.GetArgs(); -#endif - - // Get build directory, if it is empty issue an error. - if (build_path.empty()) { - LOG(ERROR) - << "You must specify a compiled build directory to run the auditor.\n"; - - // This error is always enforced, as it is a commandline switch. - return EXIT_FAILURE; - } - - // If source path is not provided, guess it using build path. - if (source_path.empty()) { - source_path = build_path.Append(base::FilePath::kParentDirectory) - .Append(base::FilePath::kParentDirectory); - } - - TrafficAnnotationAuditor auditor(source_path, build_path, path_filters); - - // Extract annotations. - if (extractor_input.empty()) { - // We ignore any path filters when all files are requested. - if (!filter_files || all_files) { - LOG(WARNING) << "The path_filters input is being ignored."; - auditor.ClearPathFilters(); - } - - int extractor_exit_code = EXIT_SUCCESS; - if (!auditor.RunExtractor(filter_files, all_files, errors_file, - &extractor_exit_code)) { - LOG(ERROR) << "Failed to run extractor.py. (exit code " - << extractor_exit_code << ")"; - // Parsing errors cause failures, even in error-resilient mode. - if (extractor_exit_code == EX_PARSE_ERROR) { - LOG(ERROR) << "The Traffic Annotation Auditor failed to parse a " - << "network annotation definition. (see CppParsingError " - << "above)"; - return EX_PARSE_ERROR; - } - return error_value; - } - - // Write extractor output if requested. - if (!extractor_output.empty()) { - std::string raw_output = auditor.extractor_raw_output(); - base::WriteFile(extractor_output, raw_output.c_str(), - raw_output.length()); - } - } else { - std::string raw_output; - if (!base::ReadFileToString(extractor_input, &raw_output)) { - LOG(ERROR) << "Could not read input file: " - << extractor_input.value().c_str(); - return error_value; - } else { - auditor.set_extractor_raw_output(raw_output); - } - } - - // Process extractor output. - if (!auditor.ParseExtractorRawOutput()) - return error_value; - - // Perform checks. - if (!auditor.RunAllChecks(test_only)) { - LOG(ERROR) << "Running checks failed."; - return error_value; - } - - // Write the summary file. - if (!summary_file.empty() && - !WriteSummaryFile(summary_file, auditor.extracted_annotations(), - auditor.extracted_calls(), auditor.errors())) { - LOG(ERROR) << "Could not write summary file."; - return error_value; - } - - // Write annotations TSV file. - if (!annotations_file.empty()) { - std::vector<std::string> missing_ids; - if (!auditor.exporter().GetOtherPlatformsAnnotationIDs(&missing_ids) || - !WriteAnnotationsFile(annotations_file, auditor.extracted_annotations(), - missing_ids)) { - LOG(ERROR) << "Could not write TSV file."; - return error_value; - } - } - - const std::vector<AuditorResult>& raw_errors = auditor.errors(); - - std::vector<AuditorResult> errors; - std::vector<AuditorResult> warnings; - std::set<AuditorResult::Type> warning_types; - - if (no_missing_error) { - warning_types.insert(AuditorResult::Type::ERROR_MISSING_ANNOTATION); - warning_types.insert(AuditorResult::Type::ERROR_NO_ANNOTATION); - } - - for (const AuditorResult& result : raw_errors) { - if (base::Contains(warning_types, result.type())) - warnings.push_back(result); - else - errors.push_back(result); - } - - // Update annotations.xml if everything else is OK and the auditor is not - // run in test-only mode. - if (errors.empty() && !test_only) { - if (!auditor.exporter().SaveAnnotationsXML()) { - LOG(ERROR) << "Could not update annotations XML."; - return error_value; - } - } - - // Dump Warnings and Errors to stdout. - int remaining_outputs = - outputs_limit ? outputs_limit - : static_cast<int>(errors.size() + warnings.size()); - if (errors.size()) { - printf("[Errors]\n"); - for (int i = 0; i < static_cast<int>(errors.size()) && remaining_outputs; - i++, remaining_outputs--) { - printf(" (%i)\t%s\n", i + 1, errors[i].ToText().c_str()); - } - } - if (warnings.size() && remaining_outputs) { - printf("[Warnings]\n"); - for (int i = 0; i < static_cast<int>(warnings.size()) && remaining_outputs; - i++, remaining_outputs--) { - printf(" (%i)\t%s\n", i + 1, warnings[i].ToText().c_str()); - } - } - if (warnings.empty() && errors.empty()) - printf("Traffic annotations are all OK.\n"); - - return static_cast<int>(errors.size()); + "traffic_annotation_auditor has been removed from the codebase. Please " + "use auditor.py instead.\n" + "See tools/traffic_annotation/scripts/auditor/README.md for " + "instructions.\n"); + return 1; } diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc b/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc deleted file mode 100644 index 6be347d917a..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc +++ /dev/null @@ -1,999 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "tools/traffic_annotation/auditor/traffic_annotation_auditor.h" - -#include "base/containers/contains.h" -#include "base/files/file_path.h" -#include "base/files/file_util.h" -#include "base/logging.h" -#include "base/memory/ptr_util.h" -#include "base/path_service.h" -#include "base/strings/string_split.h" -#include "base/strings/string_util.h" -#include "base/strings/stringprintf.h" -#include "base/strings/utf_string_conversions.h" -#include "build/build_config.h" -#include "net/traffic_annotation/network_traffic_annotation.h" -#include "net/traffic_annotation/network_traffic_annotation_test_helper.h" -#include "testing/gmock/include/gmock/gmock.h" -#include "testing/gtest/include/gtest/gtest.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_exporter.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_file_filter.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_id_checker.h" - -namespace { - -#define TEST_HASH_CODE(X) \ - EXPECT_EQ(TrafficAnnotationAuditor::ComputeHashValue(X), \ - net::DefineNetworkTrafficAnnotation(X, "").unique_id_hash_code); \ - LOG(INFO) << "ComputeHashValue('" X "') = " \ - << net::DefineNetworkTrafficAnnotation(X, "").unique_id_hash_code - -const char* kIrrelevantFiles[] = { - "tools/traffic_annotation/auditor/tests/git_list.txt", - "tools/traffic_annotation/auditor/tests/irrelevant_file_content.cc", - "tools/traffic_annotation/auditor/tests/irrelevant_file_content.mm", - "tools/traffic_annotation/auditor/tests/irrelevant_file_name.txt"}; - -const char* kRelevantFiles[] = { - "tools/traffic_annotation/auditor/tests/relevant_file_name_and_content.cc", - "tools/traffic_annotation/auditor/tests/relevant_file_name_and_content.mm"}; - -const base::FilePath kTestsFolder = - base::FilePath(FILE_PATH_LITERAL("tools")) - .Append(FILE_PATH_LITERAL("traffic_annotation")) - .Append(FILE_PATH_LITERAL("auditor")) - .Append(FILE_PATH_LITERAL("tests")); - -const std::set<int> kDummyDeprecatedIDs = {100, 101, 102}; -} // namespace - -class TrafficAnnotationAuditorTest : public ::testing::Test { - public: - void SetUp() override { - if (!base::PathService::Get(base::DIR_SOURCE_ROOT, &source_path_)) { - LOG(ERROR) << "Could not get current directory to find source path."; - return; - } - - base::FilePath build_path; - if (!base::PathService::Get(base::DIR_EXE, &build_path)) { - LOG(ERROR) << "Could not get executable directory to find build path."; - return; - } - - tests_folder_ = source_path_.Append(kTestsFolder); - std::vector<std::string> path_filters; - - auditor_ = std::make_unique<TrafficAnnotationAuditor>( - source_path_, build_path, path_filters); - - id_checker_ = std::make_unique<TrafficAnnotationIDChecker>( - TrafficAnnotationAuditor::GetReservedIDsSet(), kDummyDeprecatedIDs); - } - - const base::FilePath source_path() const { return source_path_; } - const base::FilePath tests_folder() const { return tests_folder_; } - TrafficAnnotationAuditor& auditor() { return *auditor_; } - TrafficAnnotationIDChecker& id_checker() { return *id_checker_; } - std::vector<AuditorResult>* errors() { return &errors_; } - - protected: - // Deserializes an annotation or a call instance from a sample file similar to - // extractor outputs. - AuditorResult::Type Deserialize(const std::string& file_name, - InstanceBase* instance); - - // Creates a complete annotation instance using sample files. - AnnotationInstance CreateAnnotationInstanceSample(); - AnnotationInstance CreateAnnotationInstanceSample( - AnnotationInstance::Type type, - int unique_id); - AnnotationInstance CreateAnnotationInstanceSample( - AnnotationInstance::Type type, - int unique_id, - int second_id); - - void SetAnnotationForTesting(const AnnotationInstance& instance) { - std::vector<AnnotationInstance> annotations; - annotations.push_back(instance); - auditor_->SetExtractedAnnotationsForTesting(annotations); - auditor_->ClearErrorsForTesting(); - } - - void RunIDChecker(const AnnotationInstance& instance) { - std::vector<AnnotationInstance> annotations; - annotations.push_back(instance); - errors_.clear(); - id_checker_->Load(annotations); - id_checker_->CheckIDs(&errors_); - } - - private: - base::FilePath source_path_; - base::FilePath tests_folder_; - std::unique_ptr<TrafficAnnotationAuditor> auditor_; - std::unique_ptr<TrafficAnnotationIDChecker> id_checker_; - std::vector<AuditorResult> errors_; -}; - -AuditorResult::Type TrafficAnnotationAuditorTest::Deserialize( - const std::string& file_name, - InstanceBase* instance) { - std::string file_content; - EXPECT_TRUE(base::ReadFileToString( - tests_folder_.Append(FILE_PATH_LITERAL("extractor_outputs")) - .AppendASCII(file_name), - &file_content)) - << file_name; - base::RemoveChars(file_content, "\r", &file_content); - std::vector<std::string> lines = base::SplitString( - file_content, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL); - - return instance->Deserialize(lines, 0, static_cast<int>(lines.size())).type(); -} - -AnnotationInstance -TrafficAnnotationAuditorTest::CreateAnnotationInstanceSample() { - AnnotationInstance instance; - EXPECT_EQ(Deserialize("good_complete_annotation.txt", &instance), - AuditorResult::Type::RESULT_OK); - return instance; -} - -AnnotationInstance TrafficAnnotationAuditorTest::CreateAnnotationInstanceSample( - AnnotationInstance::Type type, - int unique_id) { - return CreateAnnotationInstanceSample(type, unique_id, 0); -} - -AnnotationInstance TrafficAnnotationAuditorTest::CreateAnnotationInstanceSample( - AnnotationInstance::Type type, - int unique_id, - int second_id) { - AnnotationInstance instance = CreateAnnotationInstanceSample(); - instance.type = type; - instance.unique_id_hash_code = unique_id; - instance.proto.set_unique_id(base::StringPrintf("S%i", unique_id)); - if (second_id) { - instance.second_id = base::StringPrintf("S%i", second_id); - instance.second_id_hash_code = second_id; - } else { - instance.second_id.clear(); - instance.second_id_hash_code = 0; - } - return instance; -} - -// Tests if the two hash computation functions have the same result. -TEST_F(TrafficAnnotationAuditorTest, HashFunctionCheck) { - TEST_HASH_CODE("test"); - TEST_HASH_CODE("unique_id"); - TEST_HASH_CODE("123_id"); - TEST_HASH_CODE("ID123"); - TEST_HASH_CODE( - "a_unique_looooooooooooooooooooooooooooooooooooooooooooooooooooooong_id"); - TEST_HASH_CODE(u8"bébé"); -} - -// Tests if TrafficAnnotationFileFilter::GetFilesFromGit function returns -// correct files given a mock git list file. It also inherently checks -// TrafficAnnotationFileFilter::IsFileRelevant. -TEST_F(TrafficAnnotationAuditorTest, GetFilesFromGit) { - TrafficAnnotationFileFilter filter; - filter.SetGitFileForTesting( - tests_folder().Append(FILE_PATH_LITERAL("git_list.txt"))); - filter.GetFilesFromGit(source_path()); - - const std::vector<std::string> git_files = filter.git_files(); - - EXPECT_EQ(git_files.size(), base::size(kRelevantFiles)); - for (const char* filepath : kRelevantFiles) { - EXPECT_TRUE(base::Contains(git_files, filepath)); - } - - for (const char* filepath : kIrrelevantFiles) { - EXPECT_FALSE(base::Contains(git_files, filepath)); - } -} - -// Tests if TrafficAnnotationFileFilter::GetRelevantFiles gives the correct list -// of files, given a mock git list file. -TEST_F(TrafficAnnotationAuditorTest, RelevantFilesReceived) { - TrafficAnnotationFileFilter filter; - filter.SetGitFileForTesting( - tests_folder().Append(FILE_PATH_LITERAL("git_list.txt"))); - filter.GetFilesFromGit(source_path()); - - unsigned int git_files_count = filter.git_files().size(); - - std::vector<std::string> ignore_list; - std::vector<std::string> file_paths; - - // Check if all files are returned with no ignore list and directory. - filter.GetRelevantFiles(base::FilePath(), ignore_list, "", &file_paths); - EXPECT_EQ(file_paths.size(), git_files_count); - - // Check if a file is ignored if it is added to ignore list. - ignore_list.push_back(file_paths[0]); - file_paths.clear(); - filter.GetRelevantFiles(base::FilePath(), ignore_list, "", &file_paths); - EXPECT_EQ(file_paths.size(), git_files_count - 1); - EXPECT_FALSE(base::Contains(file_paths, ignore_list[0])); - - // Check if files are filtered based on given directory. - ignore_list.clear(); - file_paths.clear(); - filter.GetRelevantFiles(base::FilePath(), ignore_list, - "tools/traffic_annotation", &file_paths); - EXPECT_EQ(file_paths.size(), git_files_count); - file_paths.clear(); - filter.GetRelevantFiles(base::FilePath(), ignore_list, "content", - &file_paths); - EXPECT_EQ(file_paths.size(), 0u); -} - -// Tests if TrafficAnnotationFileFilter::IsSafeListed works as expected. -// Inherently checks if TrafficAnnotationFileFilter::LoadSafeList works and -// AuditorException rules are correctly deserialized. -TEST_F(TrafficAnnotationAuditorTest, IsSafeListed) { - for (unsigned int i = 0; - i < static_cast<unsigned int>( - AuditorException::ExceptionType::EXCEPTION_TYPE_LAST); - i++) { - AuditorException::ExceptionType type = - static_cast<AuditorException::ExceptionType>(i); - // Anything in /tools directory is safelisted for all types. - EXPECT_TRUE(auditor().IsSafeListed("tools/something.cc", type)); - EXPECT_TRUE(auditor().IsSafeListed("tools/somewhere/something.mm", type)); - - // Anything in a general folder is not safelisted for any type - EXPECT_FALSE(auditor().IsSafeListed("something.cc", type)); - EXPECT_FALSE(auditor().IsSafeListed("content/something.mm", type)); - } - - // Files defining missing annotation functions in net/ are exceptions of - // 'missing' type. - EXPECT_TRUE(auditor().IsSafeListed("net/url_request/url_fetcher.cc", - AuditorException::ExceptionType::MISSING)); - EXPECT_TRUE(auditor().IsSafeListed("net/url_request/url_request_context.cc", - AuditorException::ExceptionType::MISSING)); - - // Files having the word test in their full path can have annotation for - // tests. - EXPECT_FALSE( - auditor().IsSafeListed("net/url_request/url_fetcher.cc", - AuditorException::ExceptionType::TEST_ANNOTATION)); - EXPECT_TRUE( - auditor().IsSafeListed("chrome/browser/test_something.cc", - AuditorException::ExceptionType::TEST_ANNOTATION)); - EXPECT_TRUE( - auditor().IsSafeListed("test/send_something.cc", - AuditorException::ExceptionType::TEST_ANNOTATION)); -} - -// Tests if annotation instances are correctly deserialized. -TEST_F(TrafficAnnotationAuditorTest, AnnotationDeserialization) { - struct AnnotationSample { - std::string file_name; - AuditorResult::Type result_type; - AnnotationInstance::Type type; - }; - - AnnotationSample test_cases[] = { - {"good_complete_annotation.txt", AuditorResult::Type::RESULT_OK, - AnnotationInstance::Type::ANNOTATION_COMPLETE}, - {"good_branched_completing_annotation.txt", - AuditorResult::Type::RESULT_OK, - AnnotationInstance::Type::ANNOTATION_BRANCHED_COMPLETING}, - {"good_completing_annotation.txt", AuditorResult::Type::RESULT_OK, - AnnotationInstance::Type::ANNOTATION_COMPLETING}, - {"good_partial_annotation.txt", AuditorResult::Type::RESULT_OK, - AnnotationInstance::Type::ANNOTATION_PARTIAL}, - {"good_test_annotation.txt", AuditorResult::Type::ERROR_TEST_ANNOTATION}, - {"missing_annotation.txt", AuditorResult::Type::ERROR_MISSING_TAG_USED}, - {"fatal_annotation1.txt", AuditorResult::Type::ERROR_FATAL}, - {"fatal_annotation2.txt", AuditorResult::Type::ERROR_FATAL}, - {"fatal_annotation3.txt", AuditorResult::Type::ERROR_FATAL}, - {"bad_syntax_annotation1.txt", AuditorResult::Type::ERROR_SYNTAX}, - {"bad_syntax_annotation2.txt", AuditorResult::Type::ERROR_SYNTAX}, - {"bad_syntax_annotation3.txt", AuditorResult::Type::ERROR_SYNTAX}, - {"bad_syntax_annotation4.txt", AuditorResult::Type::ERROR_SYNTAX}, - }; - - for (const auto& test_case : test_cases) { - // Check if deserialization result is as expected. - AnnotationInstance annotation; - AuditorResult::Type result_type = - Deserialize(test_case.file_name, &annotation); - EXPECT_EQ(result_type, test_case.result_type) << test_case.file_name; - - if (result_type == AuditorResult::Type::RESULT_OK) - EXPECT_EQ(annotation.type, test_case.type); - - // Content checks for one complete sample. - if (test_case.file_name != "good_complete_annotation.txt") - continue; - - EXPECT_EQ(annotation.proto.unique_id(), - "supervised_user_refresh_token_fetcher"); - EXPECT_EQ(annotation.proto.source().file(), - "chrome/browser/supervised_user/legacy/" - "supervised_user_refresh_token_fetcher.cc"); - EXPECT_EQ(annotation.proto.source().line(), 166); - EXPECT_EQ(annotation.proto.semantics().sender(), "Supervised Users"); - EXPECT_EQ(annotation.proto.policy().cookies_allowed(), 1); - } -} - -// Tests if call instances are correctly deserialized. -TEST_F(TrafficAnnotationAuditorTest, CallDeserialization) { - struct CallSample { - std::string file_name; - AuditorResult::Type result_type; - }; - - CallSample test_cases[] = { - {"good_call.txt", AuditorResult::Type::RESULT_OK}, - {"bad_call.txt", AuditorResult::Type::ERROR_FATAL}, - }; - - for (const auto& test_case : test_cases) { - // Check if deserialization result is as expected. - CallInstance call; - AuditorResult::Type result_type = Deserialize(test_case.file_name, &call); - EXPECT_EQ(result_type, test_case.result_type); - - // Content checks for one complete sample. - if (test_case.file_name != "good_call.txt") - continue; - - EXPECT_EQ(call.file_path, "headless/public/util/http_url_fetcher.cc"); - EXPECT_EQ(call.line_number, 100u); - EXPECT_EQ(call.function_name, "net::URLRequestContext::CreateRequest"); - EXPECT_EQ(call.is_annotated, true); - } -} - -// Tests if call instances are correctly deserialized. -TEST_F(TrafficAnnotationAuditorTest, AssignmentDeserialization) { - struct Assignmentample { - std::string file_name; - AuditorResult::Type result_type; - }; - - Assignmentample test_cases[] = { - {"good_assignment.txt", AuditorResult::Type::RESULT_OK}, - {"bad_assignment.txt", AuditorResult::Type::ERROR_FATAL}, - }; - - for (const auto& test_case : test_cases) { - // Check if deserialization result is as expected. - AssignmentInstance assignment; - AuditorResult::Type result_type = - Deserialize(test_case.file_name, &assignment); - SCOPED_TRACE(test_case.file_name); - EXPECT_EQ(result_type, test_case.result_type); - } -} - -// Tests if TrafficAnnotationAuditor::GetReservedIDsMap has all known ids and -// they have correct text. -TEST_F(TrafficAnnotationAuditorTest, GetReservedIDsCoverage) { - int expected_ids[] = { - TRAFFIC_ANNOTATION_FOR_TESTS.unique_id_hash_code, - PARTIAL_TRAFFIC_ANNOTATION_FOR_TESTS.unique_id_hash_code, - MISSING_TRAFFIC_ANNOTATION.unique_id_hash_code}; - - std::map<int, std::string> reserved_words = - TrafficAnnotationAuditor::GetReservedIDsMap(); - - for (int id : expected_ids) { - EXPECT_TRUE(base::Contains(reserved_words, id)); - EXPECT_EQ(id, TrafficAnnotationAuditor::ComputeHashValue( - reserved_words.find(id)->second)); - } -} - -// Tests if use of reserved ids are detected. -TEST_F(TrafficAnnotationAuditorTest, CheckReservedIDsUsageDetection) { - for (const auto& reserved_id : auditor().GetReservedIDsSet()) { - RunIDChecker(CreateAnnotationInstanceSample( - AnnotationInstance::Type::ANNOTATION_COMPLETE, reserved_id)); - EXPECT_EQ(1u, errors()->size()); - EXPECT_EQ(AuditorResult::Type::ERROR_RESERVED_ID_HASH_CODE, - (*errors())[0].type()); - - RunIDChecker(CreateAnnotationInstanceSample( - AnnotationInstance::Type::ANNOTATION_PARTIAL, 1, reserved_id)); - EXPECT_EQ(1u, errors()->size()); - EXPECT_EQ(AuditorResult::Type::ERROR_RESERVED_ID_HASH_CODE, - (*errors())[0].type()); - } -} - -// Tests if use of deprecated ids are detected. -TEST_F(TrafficAnnotationAuditorTest, CheckDeprecatedIDsUsageDetection) { - for (const auto& deprecated_id : kDummyDeprecatedIDs) { - RunIDChecker(CreateAnnotationInstanceSample( - AnnotationInstance::Type::ANNOTATION_COMPLETE, deprecated_id)); - EXPECT_EQ(1u, errors()->size()); - EXPECT_EQ(AuditorResult::Type::ERROR_DEPRECATED_ID_HASH_CODE, - (*errors())[0].type()); - - RunIDChecker(CreateAnnotationInstanceSample( - AnnotationInstance::Type::ANNOTATION_PARTIAL, 1, deprecated_id)); - EXPECT_EQ(1u, errors()->size()); - EXPECT_EQ(AuditorResult::Type::ERROR_DEPRECATED_ID_HASH_CODE, - (*errors())[0].type()); - } -} - -// Tests if use of repeated ids are detected. -TEST_F(TrafficAnnotationAuditorTest, CheckRepeatedIDsDetection) { - std::vector<AnnotationInstance> annotations; - - // Check if several different hash codes result in no error. - for (int i = 0; i < 10; i++) { - annotations.push_back(CreateAnnotationInstanceSample( - AnnotationInstance::Type::ANNOTATION_COMPLETE, i)); - } - id_checker().Load(annotations); - errors()->clear(); - id_checker().CheckIDs(errors()); - EXPECT_EQ(0u, errors()->size()); - - // Check if repeating the same hash codes results in errors. - annotations.clear(); - for (int i = 0; i < 10; i++) { - annotations.push_back(CreateAnnotationInstanceSample( - AnnotationInstance::Type::ANNOTATION_COMPLETE, i)); - annotations.push_back(annotations.back()); - } - id_checker().Load(annotations); - errors()->clear(); - id_checker().CheckIDs(errors()); - EXPECT_EQ(10u, errors()->size()); - for (const auto& error : *errors()) { - EXPECT_EQ(error.type(), AuditorResult::Type::ERROR_REPEATED_ID); - } -} - -// Tests if having the same unique id and second id is detected. -TEST_F(TrafficAnnotationAuditorTest, CheckSimilarUniqueAndSecondIDsDetection) { - const int last_type = - static_cast<int>(AnnotationInstance::Type::ANNOTATION_INSTANCE_TYPE_LAST); - for (int type = 0; type <= last_type; type++) { - AnnotationInstance instance = CreateAnnotationInstanceSample( - static_cast<AnnotationInstance::Type>(type), 1, 1); - RunIDChecker(instance); - EXPECT_EQ(instance.NeedsTwoIDs() ? 1u : 0u, errors()->size()) << type; - } -} - -// Tests Unique id and Second id collision cases. -TEST_F(TrafficAnnotationAuditorTest, CheckDuplicateIDsDetection) { - const int last_type = - static_cast<int>(AnnotationInstance::Type::ANNOTATION_INSTANCE_TYPE_LAST); - - for (int type1 = 0; type1 < last_type; type1++) { - for (int type2 = type1; type2 <= last_type; type2++) { - for (int id1 = 1; id1 < 5; id1++) { - for (int id2 = 1; id2 < 5; id2++) { - for (int id3 = 1; id3 < 5; id3++) { - for (int id4 = 1; id4 < 5; id4++) { - SCOPED_TRACE( - base::StringPrintf("Testing (%i, %i, %i, %i, %i, %i).", type1, - type2, id1, id2, id3, id4)); - - AnnotationInstance instance1 = CreateAnnotationInstanceSample( - static_cast<AnnotationInstance::Type>(type1), id1, id2); - AnnotationInstance instance2 = CreateAnnotationInstanceSample( - static_cast<AnnotationInstance::Type>(type2), id3, id4); - std::vector<AnnotationInstance> annotations; - annotations.push_back(instance1); - annotations.push_back(instance2); - id_checker().Load(annotations); - errors()->clear(); - id_checker().CheckIDs(errors()); - - std::set<int> unique_ids; - bool first_needs_two = instance1.NeedsTwoIDs(); - bool second_needs_two = instance2.NeedsTwoIDs(); - unique_ids.insert(id1); - if (first_needs_two) - unique_ids.insert(id2); - unique_ids.insert(id3); - if (second_needs_two) - unique_ids.insert(id4); - - if (first_needs_two && second_needs_two) { - // If both need two ids, either the 4 ids should be different, - // or the second ids should be equal and both annotations should - // be of types partial or branched completing. - if (unique_ids.size() == 4) { - EXPECT_TRUE(errors()->empty()); - } else if (unique_ids.size() == 3) { - bool acceptable = - (id2 == id4) && - (type1 == - static_cast<int>( - AnnotationInstance::Type::ANNOTATION_PARTIAL) || - type1 == static_cast<int>( - AnnotationInstance::Type:: - ANNOTATION_BRANCHED_COMPLETING)) && - (type2 == - static_cast<int>( - AnnotationInstance::Type::ANNOTATION_PARTIAL) || - type2 == static_cast<int>( - AnnotationInstance::Type:: - ANNOTATION_BRANCHED_COMPLETING)); - - EXPECT_EQ(acceptable, errors()->empty()); - } else { - EXPECT_FALSE(errors()->empty()); - } - } else if (first_needs_two && !second_needs_two) { - // If just the first one needs two ids, then either the 3 ids - // should be different or the first annotation would be partial - // and the second completing, with one common id. - if (unique_ids.size() == 3) { - EXPECT_TRUE(errors()->empty()); - } else if (unique_ids.size() == 2) { - bool acceptable = - (id2 == id3) && - (type1 == - static_cast<int>( - AnnotationInstance::Type::ANNOTATION_PARTIAL) && - type2 == static_cast<int>(AnnotationInstance::Type:: - ANNOTATION_COMPLETING)); - EXPECT_EQ(errors()->empty(), acceptable); - } else { - EXPECT_FALSE(errors()->empty()); - } - } else if (!first_needs_two && second_needs_two) { - // Can only be valid if all 3 are different. - EXPECT_EQ(unique_ids.size() == 3, errors()->empty()); - } else { - // If none requires two ids, it can only be valid if ids are - // different. - EXPECT_EQ(unique_ids.size() == 2, errors()->empty()); - } - } - } - } - } - } - } -} - -// Tests if IDs format is correctly checked. -TEST_F(TrafficAnnotationAuditorTest, CheckIDsFormat) { - std::map<std::string, bool> test_cases = { - {"ID1", true}, {"id2", true}, {"Id_3", true}, - {"ID?4", false}, {"ID:5", false}, {"ID>>6", false}, - }; - - AnnotationInstance instance = CreateAnnotationInstanceSample(); - for (const auto& test_case : test_cases) { - // Set type to complete to require just unique id. - instance.type = AnnotationInstance::Type::ANNOTATION_COMPLETE; - instance.proto.set_unique_id(test_case.first); - instance.unique_id_hash_code = 1; - RunIDChecker(instance); - EXPECT_EQ(test_case.second ? 0u : 1u, errors()->size()) << test_case.first; - - // Set type to partial to require both ids. - instance.type = AnnotationInstance::Type::ANNOTATION_PARTIAL; - instance.proto.set_unique_id("Something_Good"); - instance.second_id = test_case.first; - instance.unique_id_hash_code = 1; - instance.second_id_hash_code = 2; - RunIDChecker(instance); - EXPECT_EQ(test_case.second ? 0u : 1u, errors()->size()) << test_case.first; - } - - // Test all cases together. - std::vector<AnnotationInstance> annotations; - instance.type = AnnotationInstance::Type::ANNOTATION_COMPLETE; - instance.unique_id_hash_code = 1; - - unsigned int false_samples_count = 0; - for (const auto& test_case : test_cases) { - instance.proto.set_unique_id(test_case.first); - instance.unique_id_hash_code++; - annotations.push_back(instance); - if (!test_case.second) - false_samples_count++; - } - id_checker().Load(annotations); - errors()->clear(); - id_checker().CheckIDs(errors()); - EXPECT_EQ(false_samples_count, errors()->size()); -} - -// Tests if TrafficAnnotationAuditor::CheckAllRequiredFunctionsAreAnnotated -// results are as expected. It also inherently checks -// TrafficAnnotationAuditor::CheckIfCallCanBeUnannotated. -TEST_F(TrafficAnnotationAuditorTest, CheckAllRequiredFunctionsAreAnnotated) { - std::string file_paths[] = {"net/url_request/url_fetcher.cc", - "net/url_request/url_request_context.cc", - "net/url_request/other_file.cc", - "somewhere_else.cc", "something_unittest.cc"}; - std::vector<CallInstance> calls(1); - CallInstance& call = calls[0]; - - for (const std::string& file_path : file_paths) { - for (int annotated = 0; annotated < 2; annotated++) { - for (int dependent = 0; dependent < 2; dependent++) { - SCOPED_TRACE(base::StringPrintf( - "Testing (%s, %i, %i).", file_path.c_str(), annotated, dependent)); - call.file_path = file_path; - call.function_name = "net::URLFetcher::Create"; - call.is_annotated = annotated; - auditor().SetGnFileForTesting(tests_folder().Append( - dependent ? FILE_PATH_LITERAL("gn_list_positive.txt") - : FILE_PATH_LITERAL("gn_list_negative.txt"))); - - auditor().ClearErrorsForTesting(); - auditor().SetExtractedCallsForTesting(calls); - auditor().ClearCheckedDependenciesForTesting(); - auditor().CheckAllRequiredFunctionsAreAnnotated(); - // Error should be issued if all the following is met: - // 1- Function is not annotated. - // 2- chrome::chrome depends on it. - // 3- The filepath is not safelisted. - bool is_unittest = file_path.find("unittest") != std::string::npos; - bool is_safelist = - file_path == "net/url_request/url_fetcher.cc" || - file_path == "net/url_request/url_request_context.cc" || - is_unittest; - EXPECT_EQ(auditor().errors().size() == 1, - !annotated && dependent && !is_safelist) - << base::StringPrintf( - "Annotated:%i, Depending:%i, IsUnitTest:%i, " - "IsSafeListed:%i", - annotated, dependent, is_unittest, is_safelist); - } - } - } -} - -// Tests if TrafficAnnotationAuditor::CheckAnnotationsContents works as -// expected for COMPLETE annotations. It also inherently checks -// TrafficAnnotationAuditor::IsAnnotationComplete and -// TrafficAnnotationAuditor::IsAnnotationConsistent and -// TrafficAnnotationAuditor::InGroupingXML. -TEST_F(TrafficAnnotationAuditorTest, CheckCompleteAnnotations) { - AnnotationInstance instance = CreateAnnotationInstanceSample(); - - base::FilePath grouping_xml_path = - tests_folder().Append(FILE_PATH_LITERAL("test_grouping.xml")); - std::set<std::string> annotation_unique_ids; - bool success = auditor().GetGroupingAnnotationsUniqueIDs( - grouping_xml_path, &annotation_unique_ids); - EXPECT_TRUE(success); - EXPECT_THAT(annotation_unique_ids, - testing::UnorderedElementsAre( - "foobar_policy_fetcher", "foobar_info_fetcher", - "fizzbuzz_handle_front_end_messages", - "fizzbuzz_hard_coded_data_source", "fizzbuzz_http_handler", - "widget_grabber")); - auditor().SetGroupedAnnotationUniqueIDsForTesting(annotation_unique_ids); - // Set unique id to be something in `tests/test_grouping.xml`. - instance.proto.set_unique_id("foobar_policy_fetcher"); - - std::vector<AnnotationInstance> annotations; - unsigned int expected_errors_count = 0; - - for (int test_no = 0;; test_no++) { - AnnotationInstance test_case = instance; - bool expect_error = true; - std::string test_description; - test_case.unique_id_hash_code = test_no; - switch (test_no) { - case 0: - test_description = "All fields OK."; - expect_error = false; - break; - case 1: - test_description = "Missing semantics::sender."; - test_case.proto.mutable_semantics()->clear_sender(); - break; - case 2: - test_description = "Missing semantics::description."; - test_case.proto.mutable_semantics()->clear_description(); - break; - case 3: - test_description = "Missing semantics::trigger."; - test_case.proto.mutable_semantics()->clear_trigger(); - break; - case 4: - test_description = "Missing semantics::data."; - test_case.proto.mutable_semantics()->clear_data(); - break; - case 5: - test_description = "Missing semantics::destination."; - test_case.proto.mutable_semantics()->clear_destination(); - break; - case 6: - test_description = "Missing policy::cookies_allowed."; - test_case.proto.mutable_policy()->set_cookies_allowed( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_UNSPECIFIED); - break; - case 7: - test_description = - "policy::cookies_allowed = NO with existing policy::cookies_store."; - test_case.proto.mutable_policy()->set_cookies_allowed( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_NO); - test_case.proto.mutable_policy()->set_cookies_store("somewhere"); - break; - case 8: - test_description = - "policy::cookies_allowed = NO and no policy::cookies_store."; - test_case.proto.mutable_policy()->set_cookies_allowed( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_NO); - test_case.proto.mutable_policy()->clear_cookies_store(); - expect_error = false; - break; - case 9: - test_description = - "policy::cookies_allowed = YES and policy::cookies_store exists."; - test_case.proto.mutable_policy()->set_cookies_allowed( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_YES); - test_case.proto.mutable_policy()->set_cookies_store("somewhere"); - expect_error = false; - break; - case 10: - test_description = - "policy::cookies_allowed = YES and no policy::cookies_store."; - test_case.proto.mutable_policy()->set_cookies_allowed( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficPolicy_CookiesAllowed_YES); - test_case.proto.mutable_policy()->clear_cookies_store(); - break; - case 11: - test_description = "Missing policy::settings."; - test_case.proto.mutable_policy()->clear_setting(); - break; - case 12: - test_description = - "Missing policy::chrome_policy and " - "policy::policy_exception_justification."; - test_case.proto.mutable_policy()->clear_chrome_policy(); - test_case.proto.mutable_policy() - ->clear_policy_exception_justification(); - break; - case 13: - test_description = - "Missing policy::chrome_policy and existing " - "policy::policy_exception_justification."; - test_case.proto.mutable_policy()->clear_chrome_policy(); - test_case.proto.mutable_policy()->set_policy_exception_justification( - "Because!"); - expect_error = false; - break; - case 14: - test_description = - "Existing policy::chrome_policy and no " - "policy::policy_exception_justification."; - test_case.proto.mutable_policy()->add_chrome_policy(); - test_case.proto.mutable_policy() - ->clear_policy_exception_justification(); - expect_error = false; - break; - case 15: - test_description = - "Existing policy::chrome_policy and existing" - "policy::policy_exception_justification."; - test_case.proto.mutable_policy()->add_chrome_policy(); - test_case.proto.mutable_policy()->set_policy_exception_justification( - "Because!"); - break; - - default: - // Trigger stop. - test_no = -1; - break; - } - if (test_no < 0) - break; - SCOPED_TRACE(base::StringPrintf("Testing: %s", test_description.c_str())); - SetAnnotationForTesting(test_case); - auditor().CheckAnnotationsContents(); - - EXPECT_EQ(auditor().errors().size(), expect_error ? 1u : 0u); - annotations.push_back(test_case); - if (expect_error) - expected_errors_count++; - } - - // Check All. - auditor().SetExtractedAnnotationsForTesting(annotations); - auditor().ClearErrorsForTesting(); - auditor().CheckAnnotationsContents(); - EXPECT_EQ(auditor().errors().size(), expected_errors_count); -} - -// Tests if AnnotationInstance::IsCompletableWith works as expected. -TEST_F(TrafficAnnotationAuditorTest, IsCompletableWith) { - const int last_type = - static_cast<int>(AnnotationInstance::Type::ANNOTATION_INSTANCE_TYPE_LAST); - for (int type1 = 0; type1 < last_type; type1++) { - for (int type2 = 0; type2 <= last_type; type2++) { - // Iterate all combination of common/specified ids. - for (int ids = 0; ids < 256; ids++) { - AnnotationInstance instance1 = CreateAnnotationInstanceSample( - static_cast<AnnotationInstance::Type>(type1), ids % 4, - (ids >> 2) % 4); - AnnotationInstance instance2 = CreateAnnotationInstanceSample( - static_cast<AnnotationInstance::Type>(type2), (ids >> 4) % 4, - (ids >> 6)); - - bool expectation = false; - // It's compatible only if the first one is partial and has second_id, - // and the second one is either completing with matching unique id, or - // branched completing with matching second id. - if (instance1.type == AnnotationInstance::Type::ANNOTATION_PARTIAL && - !instance1.second_id.empty()) { - expectation |= - (instance2.type == - AnnotationInstance::Type::ANNOTATION_COMPLETING && - instance1.second_id_hash_code == instance2.unique_id_hash_code); - expectation |= - (instance2.type == - AnnotationInstance::Type::ANNOTATION_BRANCHED_COMPLETING && - instance1.second_id_hash_code == instance2.second_id_hash_code); - } - EXPECT_EQ(instance1.IsCompletableWith(instance2), expectation); - } - } - } -} - -// Tests if AnnotationInstance::CreateCompleteAnnotation works as -// expected. -TEST_F(TrafficAnnotationAuditorTest, CreateCompleteAnnotation) { - AnnotationInstance instance = CreateAnnotationInstanceSample(); - AnnotationInstance other = instance; - - instance.proto.clear_semantics(); - other.proto.clear_policy(); - - AnnotationInstance combination; - - // Partial and Completing. - instance.type = AnnotationInstance::Type::ANNOTATION_PARTIAL; - other.type = AnnotationInstance::Type::ANNOTATION_COMPLETING; - instance.second_id_hash_code = 1; - instance.second_id = "SomeID"; - other.unique_id_hash_code = 1; - EXPECT_EQ(instance.CreateCompleteAnnotation(other, &combination).type(), - AuditorResult::Type::RESULT_OK); - EXPECT_EQ(combination.unique_id_hash_code, instance.unique_id_hash_code); - - // Partial and Branched Completing. - other.type = AnnotationInstance::Type::ANNOTATION_BRANCHED_COMPLETING; - instance.second_id_hash_code = 1; - other.second_id_hash_code = 1; - other.second_id = "SomeID"; - EXPECT_EQ(instance.CreateCompleteAnnotation(other, &combination).type(), - AuditorResult::Type::RESULT_OK); - EXPECT_EQ(combination.unique_id_hash_code, other.unique_id_hash_code); - - // Inconsistent field. - other = instance; - other.type = AnnotationInstance::Type::ANNOTATION_BRANCHED_COMPLETING; - instance.second_id_hash_code = 1; - other.second_id_hash_code = 1; - other.second_id = "SomeID"; - instance.proto.mutable_semantics()->set_destination( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_WEBSITE); - other.proto.mutable_semantics()->set_destination( - traffic_annotation:: - NetworkTrafficAnnotation_TrafficSemantics_Destination_LOCAL); - EXPECT_NE(instance.CreateCompleteAnnotation(other, &combination).type(), - AuditorResult::Type::RESULT_OK); -} - -// Tests if Annotations.xml has proper content. -TEST_F(TrafficAnnotationAuditorTest, AnnotationsXML) { - TrafficAnnotationExporter exporter(source_path()); - - EXPECT_TRUE(exporter.LoadAnnotationsXML()); - exporter.CheckArchivedAnnotations(errors()); - EXPECT_TRUE(errors()->empty()); -} - -// Tests if 'annotations.xml' is read and has at least one item. -TEST_F(TrafficAnnotationAuditorTest, AnnotationsXMLLines) { - TrafficAnnotationExporter exporter(source_path()); - EXPECT_LE(1u, exporter.GetXMLItemsCountForTesting()); -} - -// Tests if 'annotations.xml' changes are correctly reported. -TEST_F(TrafficAnnotationAuditorTest, AnnotationsXMLDifferences) { - TrafficAnnotationExporter exporter(source_path()); - - std::string xml1; - std::string xml2; - std::string xml3; - - EXPECT_TRUE(base::ReadFileToString( - base::MakeAbsoluteFilePath( - tests_folder().Append(FILE_PATH_LITERAL("annotations_sample1.xml"))), - &xml1)); - EXPECT_TRUE(base::ReadFileToString( - base::MakeAbsoluteFilePath( - tests_folder().Append(FILE_PATH_LITERAL("annotations_sample2.xml"))), - &xml2)); - EXPECT_TRUE(base::ReadFileToString( - base::MakeAbsoluteFilePath( - tests_folder().Append(FILE_PATH_LITERAL("annotations_sample3.xml"))), - &xml3)); - - std::string diff12 = exporter.GetXMLDifferencesForTesting(xml1, xml2); - std::string diff13 = exporter.GetXMLDifferencesForTesting(xml1, xml3); - std::string diff23 = exporter.GetXMLDifferencesForTesting(xml2, xml3); - - std::string expected_diff12; - std::string expected_diff13; - std::string expected_diff23; - - EXPECT_TRUE(base::ReadFileToString( - base::MakeAbsoluteFilePath( - tests_folder().Append(FILE_PATH_LITERAL("annotations_diff12.txt"))), - &expected_diff12)); - EXPECT_TRUE(base::ReadFileToString( - base::MakeAbsoluteFilePath( - tests_folder().Append(FILE_PATH_LITERAL("annotations_diff13.txt"))), - &expected_diff13)); - EXPECT_TRUE(base::ReadFileToString( - base::MakeAbsoluteFilePath( - tests_folder().Append(FILE_PATH_LITERAL("annotations_diff23.txt"))), - &expected_diff23)); - - EXPECT_EQ(diff12, expected_diff12); - EXPECT_EQ(diff13, expected_diff13); - EXPECT_EQ(diff23, expected_diff23); -} - -// Tests if an 'annotation' is in 'test_grouping.xml' or not. -TEST_F(TrafficAnnotationAuditorTest, AnnotationGrouping) { - AnnotationInstance instance = CreateAnnotationInstanceSample(); - instance.type = AnnotationInstance::Type::ANNOTATION_COMPLETE; - - base::FilePath grouping_xml_path = - tests_folder().Append(FILE_PATH_LITERAL("test_grouping.xml")); - - std::set<std::string> annotation_unique_ids; - bool success = auditor().GetGroupingAnnotationsUniqueIDs( - grouping_xml_path, &annotation_unique_ids); - - EXPECT_TRUE(success); - EXPECT_THAT(annotation_unique_ids, - testing::UnorderedElementsAre( - "foobar_policy_fetcher", "foobar_info_fetcher", - "fizzbuzz_handle_front_end_messages", - "fizzbuzz_hard_coded_data_source", "fizzbuzz_http_handler", - "widget_grabber")); - - // Test 'annotation' with unique id "empty" is not in 'test_grouping.xml' - instance.proto.set_unique_id("empty"); - AuditorResult::Type returned_type = - instance.InGroupingXML(annotation_unique_ids).type(); - EXPECT_EQ(returned_type, AuditorResult::Type::ERROR_MISSING_GROUPING); - - // Test 'annotation' with unique id "foobar_policy_fetcher" is in - // 'test_grouping.xml' - instance.proto.set_unique_id("foobar_policy_fetcher"); - returned_type = instance.InGroupingXML(annotation_unique_ids).type(); - EXPECT_EQ(returned_type, AuditorResult::Type::RESULT_OK); -} diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc b/chromium/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc deleted file mode 100644 index c0c034ef805..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc +++ /dev/null @@ -1,557 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "tools/traffic_annotation/auditor/traffic_annotation_exporter.h" - -#include <ctime> - -#include "base/containers/cxx20_erase.h" -#include "base/files/file_util.h" -#include "base/logging.h" -#include "base/strings/string_number_conversions.h" -#include "base/strings/string_split.h" -#include "base/strings/stringprintf.h" -#include "base/time/time.h" -#include "build/build_config.h" -#include "third_party/libxml/chromium/xml_reader.h" -#include "third_party/libxml/chromium/xml_writer.h" -#include "third_party/protobuf/src/google/protobuf/text_format.h" -#include "tools/traffic_annotation/auditor/traffic_annotation_auditor.h" - -namespace { - -const char* kXmlComment = - "<!--\n" - "Copyright 2017 The Chromium Authors. All rights reserved.\n" - "Use of this source code is governed by a BSD-style license that can be\n" - "found in the LICENSE file.\n" - "\nRefer to README.md for content description and update process.\n" - "-->\n\n"; - -const base::FilePath kAnnotationsXmlPath = - base::FilePath(FILE_PATH_LITERAL("tools")) - .Append(FILE_PATH_LITERAL("traffic_annotation")) - .Append(FILE_PATH_LITERAL("summary")) - .Append(FILE_PATH_LITERAL("annotations.xml")); - -const base::FilePath kGroupingXmlPath = - base::FilePath(FILE_PATH_LITERAL("tools")) - .Append(FILE_PATH_LITERAL("traffic_annotation")) - .Append(FILE_PATH_LITERAL("summary")) - .Append(FILE_PATH_LITERAL("grouping.xml")); - -const base::FilePath kChromeVersionPath = - base::FilePath(FILE_PATH_LITERAL("chrome")) - .Append(FILE_PATH_LITERAL("VERSION")); - -// Extracts annotation id from a line of XML. Expects to have the line in the -// following format: <... id="..." .../> -// TODO(rhalavati): Use real XML parsing. -std::string GetAnnotationID(const std::string& xml_line) { - std::string::size_type start = xml_line.find("id=\""); - if (start == std::string::npos) - return ""; - - start += 4; - std::string::size_type end = xml_line.find("\"", start); - if (end == std::string::npos) - return ""; - - return xml_line.substr(start, end - start); -} - -// Extracts a map of XML items, keyed by their 'id' tags, from a serialized XML. -void ExtractXMLItems(const std::string& serialized_xml, - std::map<std::string, std::string>* items) { - std::vector<std::string> lines = base::SplitString( - serialized_xml, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL); - for (const std::string& line : lines) { - std::string id = GetAnnotationID(line); - if (!id.empty()) - items->insert(std::make_pair(id, line)); - } -} - -// Parses the contents of the chrome/VERSION file, which contains the current -// chrome version. Returns the number on the MAJOR=... line, i.e. the milestone -// number. -// -// If parsing fails, returns -1. -int GetMajorVersion(const std::string& version_file_contents) { - static const char prefix[] = "MAJOR="; - size_t pos = version_file_contents.find(prefix); - if (pos == std::string::npos) - return -1; - int version = 0; - base::StringToInt( - base::StringPiece(version_file_contents.c_str() + pos + strlen(prefix)), - &version); - return version > 0 ? version : -1; -} - -} // namespace - -TrafficAnnotationExporter::ArchivedAnnotation::ArchivedAnnotation() - : type(AnnotationInstance::Type::ANNOTATION_COMPLETE), - unique_id_hash_code(-1), - second_id_hash_code(-1), - content_hash_code(-1) {} - -TrafficAnnotationExporter::ArchivedAnnotation::ArchivedAnnotation( - const TrafficAnnotationExporter::ArchivedAnnotation& other) = default; - -TrafficAnnotationExporter::ArchivedAnnotation::~ArchivedAnnotation() = default; - -TrafficAnnotationExporter::TrafficAnnotationExporter( - const base::FilePath& source_path) - : source_path_(source_path), modified_(false) { - all_supported_platforms_.push_back("linux"); - all_supported_platforms_.push_back("windows"); -#if defined(OS_LINUX) || defined(OS_CHROMEOS) - current_platform_ = "linux"; -#elif defined(OS_WIN) - current_platform_ = "windows"; -#else - NOTREACHED() << "Other platforms are not supported yet."; - current_platform_ = "undefined"; -#endif -} - -TrafficAnnotationExporter::~TrafficAnnotationExporter() = default; - -bool TrafficAnnotationExporter::LoadAnnotationsXML() { - std::string version_file_contents; - base::FilePath version_file_path = - base::MakeAbsoluteFilePath(source_path_.Append(kChromeVersionPath)); - if (!base::ReadFileToString(version_file_path, &version_file_contents)) { - LOG(ERROR) << "Could not load '" << source_path_.Append(kChromeVersionPath) - << "'."; - return false; - } - current_milestone_ = GetMajorVersion(version_file_contents); - if (current_milestone_ <= 0) { - LOG(ERROR) << "Failed to parse '" << source_path_.Append(kChromeVersionPath) - << "'."; - return false; - } - - archive_.clear(); - XmlReader reader; - if (!reader.LoadFile( - source_path_.Append(kAnnotationsXmlPath).MaybeAsASCII())) { - LOG(ERROR) << "Could not load '" - << source_path_.Append(kAnnotationsXmlPath).MaybeAsASCII() - << "'."; - return false; - } - - bool all_ok = false; - while (reader.Read()) { - all_ok = true; - if (reader.NodeName() != "item") - continue; - - ArchivedAnnotation item; - std::string temp_str; - int temp_int = 0; - std::string unique_id; - - all_ok &= reader.NodeAttribute("id", &unique_id); - all_ok &= reader.NodeAttribute("hash_code", &temp_str) && - base::StringToInt(temp_str, &item.unique_id_hash_code); - all_ok &= reader.NodeAttribute("type", &temp_str) && - base::StringToInt(temp_str, &temp_int); - item.type = static_cast<AnnotationInstance::Type>(temp_int); - - if (reader.NodeAttribute("second_id", &temp_str)) - all_ok &= base::StringToInt(temp_str, &item.second_id_hash_code); - - if (all_ok && reader.NodeAttribute("content_hash_code", &temp_str)) - all_ok &= base::StringToInt(temp_str, &item.content_hash_code); - else - item.content_hash_code = -1; - - reader.NodeAttribute("deprecated", &item.deprecation_date); - - if (reader.NodeAttribute("os_list", &temp_str)) { - item.os_list = base::SplitString(temp_str, ",", base::TRIM_WHITESPACE, - base::SPLIT_WANT_NONEMPTY); - } - - if (reader.NodeAttribute("semantics_fields", &temp_str)) { - std::vector<std::string> temp_list = base::SplitString( - temp_str, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY); - for (std::string field : temp_list) { - base::StringToInt(field, &temp_int); - item.semantics_fields.insert(temp_int); - } - } - - if (reader.NodeAttribute("policy_fields", &temp_str)) { - std::vector<std::string> temp_list = base::SplitString( - temp_str, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY); - for (std::string field : temp_list) { - base::StringToInt(field, &temp_int); - item.policy_fields.insert(temp_int); - } - } - - all_ok &= reader.NodeAttribute("file_path", &item.file_path); - - std::string added_in_str; - if (reader.NodeAttribute("added_in_milestone", &added_in_str)) { - base::StringToInt(added_in_str, &item.added_in_milestone); - } else { - item.added_in_milestone = -1; - } - - if (!all_ok) { - LOG(ERROR) << "Unexpected format in annotations.xml."; - break; - } - - archive_.insert(std::make_pair(unique_id, item)); - } - - modified_ = false; - return all_ok; -} - -void TrafficAnnotationExporter::UpdateAnnotations( - const std::vector<AnnotationInstance>& annotations, - const std::map<int, std::string>& reserved_ids, - std::vector<AuditorResult>* errors) { - CHECK(!archive_.empty()); - DCHECK(errors); - - std::set<int> current_platform_hashcodes; - - // Iterate annotations extracted from the code, and add/update them in the - // reported list, if required. - for (AnnotationInstance annotation : annotations) { - // Annotations.XML only stores raw annotations. - if (annotation.is_merged) - continue; - - int content_hash_code = annotation.GetContentHashCode(); - // If annotation unique id is already in the imported annotations list, - // check if other fields have changed. - if (base::Contains(archive_, annotation.proto.unique_id())) { - ArchivedAnnotation* current = &archive_[annotation.proto.unique_id()]; - - // Check second id. - if (current->second_id_hash_code != - archive_[annotation.proto.unique_id()].second_id_hash_code) { - archive_[annotation.proto.unique_id()].second_id_hash_code = - current->second_id_hash_code; - modified_ = true; - } - - // Check platform. - if (!base::Contains(current->os_list, current_platform_)) { - current->os_list.push_back(current_platform_); - modified_ = true; - } - - // Check content (including policy and semnantic fields). - if (current->content_hash_code != content_hash_code) { - current->content_hash_code = content_hash_code; - modified_ = true; - } - - // Check file path. - if (current->file_path != annotation.proto.source().file()) { - current->file_path = annotation.proto.source().file(); - modified_ = true; - } - } else { - // If annotation is new, add it and assume it is on all platforms. Tests - // running on other platforms will request updating this if required. - ArchivedAnnotation new_item; - new_item.type = annotation.type; - new_item.unique_id_hash_code = annotation.unique_id_hash_code; - if (annotation.NeedsTwoIDs()) - new_item.second_id_hash_code = annotation.second_id_hash_code; - new_item.content_hash_code = content_hash_code; - new_item.os_list = all_supported_platforms_; - new_item.added_in_milestone = current_milestone_; - if (annotation.type != AnnotationInstance::Type::ANNOTATION_COMPLETE) { - annotation.GetSemanticsFieldNumbers(&new_item.semantics_fields); - annotation.GetPolicyFieldNumbers(&new_item.policy_fields); - } - new_item.file_path = annotation.proto.source().file(); - archive_[annotation.proto.unique_id()] = new_item; - modified_ = true; - } - current_platform_hashcodes.insert(annotation.unique_id_hash_code); - } - - // If a none-reserved annotation is removed from current platform, update it. - for (auto& item : archive_) { - if (base::Contains(item.second.os_list, current_platform_) && - item.second.content_hash_code != -1 && - !base::Contains(current_platform_hashcodes, - item.second.unique_id_hash_code)) { - base::Erase(item.second.os_list, current_platform_); - modified_ = true; - } - } - - // If there is a new reserved id, add it. - for (const auto& item : reserved_ids) { - if (!base::Contains(archive_, item.second)) { - ArchivedAnnotation new_item; - new_item.unique_id_hash_code = item.first; - new_item.os_list = all_supported_platforms_; - archive_[item.second] = new_item; - modified_ = true; - } - } - - // If there are annotations that are not used in any OS, set the deprecation - // flag. - for (auto& item : archive_) { - if (item.second.os_list.empty() && item.second.deprecation_date.empty()) { - base::Time::Exploded now; - base::Time::Now().UTCExplode(&now); - item.second.deprecation_date = base::StringPrintf( - "%i-%02i-%02i", now.year, now.month, now.day_of_month); - item.second.file_path = ""; - item.second.semantics_fields.clear(); - item.second.policy_fields.clear(); - modified_ = true; - } - } - - CheckArchivedAnnotations(errors); -} - -std::string TrafficAnnotationExporter::GenerateSerializedXML() const { - XmlWriter writer; - writer.StartWriting(); - writer.AppendElementContent(kXmlComment); - writer.StartElement("annotations"); - - for (const auto& item : archive_) { - writer.StartElement("item"); - writer.AddAttribute("id", item.first); - writer.AddAttribute("added_in_milestone", - base::NumberToString(item.second.added_in_milestone)); - - writer.AddAttribute( - "hash_code", base::StringPrintf("%i", item.second.unique_id_hash_code)); - writer.AddAttribute("type", base::StringPrintf("%i", item.second.type)); - - if (item.second.second_id_hash_code != -1) - writer.AddAttribute( - "second_id", - base::StringPrintf("%i", item.second.second_id_hash_code)); - - if (!item.second.deprecation_date.empty()) - writer.AddAttribute("deprecated", item.second.deprecation_date); - - if (item.second.content_hash_code == -1) - writer.AddAttribute("reserved", "1"); - else - writer.AddAttribute( - "content_hash_code", - base::StringPrintf("%i", item.second.content_hash_code)); - - // Write OS list. - if (!item.second.os_list.empty()) { - std::string text; - for (const std::string& platform : item.second.os_list) - text += platform + ","; - text.pop_back(); - writer.AddAttribute("os_list", text); - } - - // Write semantics list (for incomplete annotations). - if (!item.second.semantics_fields.empty()) { - std::string text; - for (int field : item.second.semantics_fields) - text += base::StringPrintf("%i,", field); - text.pop_back(); - writer.AddAttribute("semantics_fields", text); - } - - // Write policy list (for incomplete annotations). - if (!item.second.policy_fields.empty()) { - std::string text; - for (int field : item.second.policy_fields) - text += base::StringPrintf("%i,", field); - text.pop_back(); - writer.AddAttribute("policy_fields", text); - } - - writer.AddAttribute("file_path", item.second.file_path); - - writer.EndElement(); - } - writer.EndElement(); - - writer.StopWriting(); - - return writer.GetWrittenString(); -} - -bool TrafficAnnotationExporter::SaveAnnotationsXML() const { - std::string xml_content = GenerateSerializedXML(); - - return base::WriteFile(source_path_.Append(kAnnotationsXmlPath), - xml_content.c_str(), xml_content.length()) != -1; -} - -void TrafficAnnotationExporter::GetDeprecatedHashCodes( - std::set<int>* hash_codes) { - CHECK(!archive_.empty()); - - hash_codes->clear(); - for (const auto& item : archive_) { - if (!item.second.deprecation_date.empty()) - hash_codes->insert(item.second.unique_id_hash_code); - } -} - -void TrafficAnnotationExporter::CheckArchivedAnnotations( - std::vector<AuditorResult>* errors) { - DCHECK(errors); - // Check for annotation hash code duplications. - std::map<int, std::string> used_codes; - for (auto& item : archive_) { - if (base::Contains(used_codes, item.second.unique_id_hash_code)) { - AuditorResult error(AuditorResult::Type::ERROR_HASH_CODE_COLLISION); - error.AddDetail(used_codes[item.second.unique_id_hash_code]); - error.AddDetail(item.first); - errors->push_back(std::move(error)); - } else { - used_codes[item.second.unique_id_hash_code] = item.first; - } - } - - // Check for coexistence of OS(es) and deprecation date. - for (auto& item : archive_) { - if (!item.second.deprecation_date.empty() && !item.second.os_list.empty()) { - errors->push_back( - AuditorResult(AuditorResult::Type::ERROR_DEPRECATED_WITH_OS, - item.first, kAnnotationsXmlPath.MaybeAsASCII(), - AuditorResult::kNoCodeLineSpecified)); - } - } - - // Check that listed OSes are valid. - for (const auto& pair : archive_) { - for (const auto& os : pair.second.os_list) { - if (!base::Contains(all_supported_platforms_, os)) { - AuditorResult error(AuditorResult::Type::ERROR_INVALID_OS, - std::string(), kAnnotationsXmlPath.MaybeAsASCII(), - AuditorResult::kNoCodeLineSpecified); - error.AddDetail(os); - error.AddDetail(pair.first); - errors->push_back(std::move(error)); - } - } - } - - // Check for consistency of "added_in_milestone" attribute. - for (const auto& pair : archive_) { - if (pair.second.added_in_milestone < 62) { - AuditorResult error(AuditorResult::Type::ERROR_INVALID_ADDED_IN, - std::string(), kAnnotationsXmlPath.MaybeAsASCII(), - AuditorResult::kNoCodeLineSpecified); - error.AddDetail(base::NumberToString(pair.second.added_in_milestone)); - error.AddDetail(pair.first); - errors->push_back(std::move(error)); - } - } -} - -unsigned TrafficAnnotationExporter::GetXMLItemsCountForTesting() { - std::string xml_content; - if (!base::ReadFileToString( - base::MakeAbsoluteFilePath(source_path_.Append(kAnnotationsXmlPath)), - &xml_content)) { - LOG(ERROR) << "Could not read 'annotations.xml'."; - return 0; - } - - std::map<std::string, std::string> lines; - ExtractXMLItems(xml_content, &lines); - return lines.size(); -} - -std::string TrafficAnnotationExporter::GetRequiredUpdates() { - std::string old_xml; - if (!base::ReadFileToString( - base::MakeAbsoluteFilePath(source_path_.Append(kAnnotationsXmlPath)), - &old_xml)) { - return "Could not generate required changes."; - } - - return GetXMLDifferences(old_xml, GenerateSerializedXML()); -} - -std::string TrafficAnnotationExporter::GetXMLDifferences( - const std::string& old_xml, - const std::string& new_xml) { - std::map<std::string, std::string> old_items; - ExtractXMLItems(old_xml, &old_items); - std::set<std::string> old_keys; - std::transform(old_items.begin(), old_items.end(), - std::inserter(old_keys, old_keys.end()), - [](auto pair) { return pair.first; }); - - std::map<std::string, std::string> new_items; - ExtractXMLItems(new_xml, &new_items); - std::set<std::string> new_keys; - std::transform(new_items.begin(), new_items.end(), - std::inserter(new_keys, new_keys.end()), - [](auto pair) { return pair.first; }); - - std::set<std::string> added_items; - std::set<std::string> removed_items; - - std::set_difference(new_keys.begin(), new_keys.end(), old_keys.begin(), - old_keys.end(), - std::inserter(added_items, added_items.begin())); - std::set_difference(old_keys.begin(), old_keys.end(), new_keys.begin(), - new_keys.end(), - std::inserter(removed_items, removed_items.begin())); - - std::string message; - - for (const std::string& id : added_items) { - message += base::StringPrintf("\n\tAdd line: '%s'", new_items[id].c_str()); - } - - for (const std::string& id : removed_items) { - message += - base::StringPrintf("\n\tRemove line: '%s'", old_items[id].c_str()); - } - - for (const std::string& id : old_keys) { - if (base::Contains(new_items, id) && old_items[id] != new_items[id]) { - message += - base::StringPrintf("\n\tUpdate line: '%s' --> '%s'", - old_items[id].c_str(), new_items[id].c_str()); - } - } - - return message; -} - -bool TrafficAnnotationExporter::GetOtherPlatformsAnnotationIDs( - std::vector<std::string>* ids) const { - if (archive_.empty()) - return false; - - ids->clear(); - for (const std::pair<const std::string, ArchivedAnnotation>& item : - archive_) { - if (item.second.deprecation_date.empty() && - !MatchesCurrentPlatform(item.second)) - ids->push_back(item.first); - } - return true; -} diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_exporter.h b/chromium/tools/traffic_annotation/auditor/traffic_annotation_exporter.h deleted file mode 100644 index 355e0e481ac..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_exporter.h +++ /dev/null @@ -1,108 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef TOOLS_TRAFFIC_ANNOTATION_AUDITOR_TRAFFIC_ANNOTATION_EXPORTER_H_ -#define TOOLS_TRAFFIC_ANNOTATION_AUDITOR_TRAFFIC_ANNOTATION_EXPORTER_H_ - -#include <map> -#include <set> -#include <vector> - -#include "base/containers/contains.h" -#include "base/files/file_path.h" -#include "tools/traffic_annotation/auditor/instance.h" - -class TrafficAnnotationExporter { - public: - struct ArchivedAnnotation { - ArchivedAnnotation(); - ArchivedAnnotation(const ArchivedAnnotation& other); - ~ArchivedAnnotation(); - - AnnotationInstance::Type type; - - int unique_id_hash_code; - int second_id_hash_code; - int content_hash_code; - - std::string deprecation_date; - std::vector<std::string> os_list; - - std::set<int> semantics_fields; - std::set<int> policy_fields; - std::string file_path; - - int added_in_milestone = 0; - }; - - TrafficAnnotationExporter(const base::FilePath& source_path); - ~TrafficAnnotationExporter(); - TrafficAnnotationExporter(const TrafficAnnotationExporter&) = delete; - TrafficAnnotationExporter(TrafficAnnotationExporter&&) = delete; - - // Loads annotations from annotations.xml file into |archive_|, and populates - // |current_milestone_|. - bool LoadAnnotationsXML(); - - // Updates |archive_| with current set of extracted annotations and reserved - // ids. Sets the |modified_| flag if any item is updated. Appends errors to - // |errors|. - void UpdateAnnotations(const std::vector<AnnotationInstance>& annotations, - const std::map<int, std::string>& reserved_ids, - std::vector<AuditorResult>* errors); - - // Saves |archive_| into annotations.xml. - bool SaveAnnotationsXML() const; - - // Returns the required updates for annotations.xml. - std::string GetRequiredUpdates(); - - // Produces the list of deprecated hash codes. Requires annotations.xml to be - // loaded. - void GetDeprecatedHashCodes(std::set<int>* hash_codes); - - bool modified() const { return modified_; } - - // Runs tests on content of |archive_|. - void CheckArchivedAnnotations(std::vector<AuditorResult>* errors); - - const std::map<std::string, ArchivedAnnotation>& GetArchivedAnnotations() - const { - return archive_; - } - - // Checks if the current platform is in the os list of archived annotation. - bool MatchesCurrentPlatform(const ArchivedAnnotation& annotation) const { - return base::Contains(annotation.os_list, current_platform_); - } - - // Produces the list of annotations that are not defined in this platform. - // Returns false if annotations.xml is not loaded. - bool GetOtherPlatformsAnnotationIDs(std::vector<std::string>* ids) const; - - // Returns the number of items in annotations.xml for testing. - unsigned GetXMLItemsCountForTesting(); - - std::string GetXMLDifferencesForTesting(const std::string& old_xml, - const std::string& new_xml) { - return GetXMLDifferences(old_xml, new_xml); - } - - private: - // Generates a text serialized XML for current report items. - std::string GenerateSerializedXML() const; - - // Returns the required updates to convert one serialized XML to another. - std::string GetXMLDifferences(const std::string& old_xml, - const std::string& new_xml); - - std::vector<std::string> all_supported_platforms_; - std::map<std::string, ArchivedAnnotation> archive_; - const base::FilePath source_path_; - std::string current_platform_; - int current_milestone_; - bool modified_; -}; - -#endif // TOOLS_TRAFFIC_ANNOTATION_AUDITOR_TRAFFIC_ANNOTATION_EXPORTER_H_ diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_extractor_switches.txt b/chromium/tools/traffic_annotation/auditor/traffic_annotation_extractor_switches.txt deleted file mode 100644 index 2b5676e9772..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_extractor_switches.txt +++ /dev/null @@ -1,4 +0,0 @@ --Wno-comment --Wno-tautological-unsigned-enum-zero-compare --Wno-tautological-constant-compare --Wno-error=unknown-warning-option diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_file_filter.cc b/chromium/tools/traffic_annotation/auditor/traffic_annotation_file_filter.cc deleted file mode 100644 index fa8f6f73c1c..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_file_filter.cc +++ /dev/null @@ -1,155 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "tools/traffic_annotation/auditor/traffic_annotation_file_filter.h" - -#include <fstream> - -#include "base/command_line.h" -#include "base/files/file_path.h" -#include "base/files/file_util.h" -#include "base/logging.h" -#include "base/process/launch.h" -#include "base/strings/string_split.h" -#include "base/strings/string_util.h" -#include "base/strings/utf_string_conversions.h" -#include "build/build_config.h" -#include "third_party/re2/src/re2/re2.h" - -namespace { - -// List of keywords that indicate a file may be related to network traffic -// annotations. This list includes all keywords related to defining annotations -// and all functions that need one. -const char* kRelevantKeywords[] = { - "network_traffic_annotation", - "network_traffic_annotation_test_helper", - "NetworkTrafficAnnotationTag", - "PartialNetworkTrafficAnnotationTag", - "DefineNetworkTrafficAnnotation", - "DefinePartialNetworkTrafficAnnotation", - "CompleteNetworkTrafficAnnotation", - "BranchedCompleteNetworkTrafficAnnotation", - "CreateMutableNetworkTrafficAnnotationTag", - "NO_TRAFFIC_ANNOTATION_YET", - "MISSING_TRAFFIC_ANNOTATION", - "TRAFFIC_ANNOTATION_FOR_TESTS", - "PARTIAL_TRAFFIC_ANNOTATION_FOR_TESTS", - "URLFetcher::Create", // This one is used with class as it's too generic. - "CreateRequest", // URLRequestContext:: - nullptr // End Marker -}; - -} // namespace - -TrafficAnnotationFileFilter::TrafficAnnotationFileFilter() = default; - -TrafficAnnotationFileFilter::~TrafficAnnotationFileFilter() = default; - -void TrafficAnnotationFileFilter::GetFilesFromGit( - const base::FilePath& source_path) { - // Change directory to source path to access git and check files. - base::FilePath original_path; - base::GetCurrentDirectory(&original_path); - base::SetCurrentDirectory(source_path); - - std::string git_list; - if (git_file_for_test_.empty()) { - const base::CommandLine::CharType* args[] = -#if defined(OS_WIN) - {FILE_PATH_LITERAL("git.bat"), FILE_PATH_LITERAL("ls-files")}; -#else - {"git", "ls-files"}; -#endif - base::CommandLine cmdline(2, args); - - // Get list of files from git. - if (!base::GetAppOutput(cmdline, &git_list)) { - LOG(ERROR) << "Could not get files from git."; - git_list.clear(); - } - } else { - if (!base::ReadFileToString(git_file_for_test_, &git_list)) { - LOG(ERROR) << "Could not load mock git list file from " - << git_file_for_test_.MaybeAsASCII().c_str(); - git_list.clear(); - } - } - - for (const std::string& file_path : base::SplitString( - git_list, "\n", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL)) { - if (IsFileRelevant(file_path)) - git_files_.push_back(std::move(file_path)); - } - - base::SetCurrentDirectory(original_path); -} - -bool TrafficAnnotationFileFilter::IsFileRelevant(const std::string& file_path) { - // Check file extension. - int pos = file_path.length() - 3; - - if (pos < 0 || (strcmp(".mm", file_path.c_str() + pos) && - strcmp(".cc", file_path.c_str() + pos))) { - return false; - } - - // Ignore test files to speed up the tests. They would be only tested when - // filters are disabled. - pos = file_path.length() - 7; - if (pos >= 0 && (!strcmp("test.cc", file_path.c_str() + pos) || - !strcmp("test.mm", file_path.c_str() + pos))) { - return false; - } - - base::FilePath converted_file_path = -#if defined(OS_WIN) - base::FilePath( - base::FilePath::StringPieceType(base::UTF8ToWide(file_path))); -#else - base::FilePath(base::FilePath::StringPieceType(file_path)); -#endif - - // Check file content. - std::string file_content; - if (!base::ReadFileToString(converted_file_path, &file_content)) { - LOG(ERROR) << "Could not open file: " << file_path; - return false; - } - - for (int i = 0; kRelevantKeywords[i]; i++) { - if (file_content.find(kRelevantKeywords[i]) != std::string::npos) - return true; - } - - return false; -} - -void TrafficAnnotationFileFilter::GetRelevantFiles( - const base::FilePath& source_path, - const std::vector<std::string>& ignore_list, - std::string directory_name, - std::vector<std::string>* file_paths) { - if (!git_files_.size()) - GetFilesFromGit(source_path); - -#if defined(FILE_PATH_USES_WIN_SEPARATORS) - std::replace(directory_name.begin(), directory_name.end(), L'\\', L'/'); -#endif - - size_t name_length = directory_name.length(); - for (const std::string& file_path : git_files_) { - if (!strncmp(file_path.c_str(), directory_name.c_str(), name_length)) { - bool ignore = false; - for (const std::string& ignore_pattern : ignore_list) { - if (re2::RE2::FullMatch(file_path.c_str(), ignore_pattern)) { - ignore = true; - break; - } - } - if (!ignore) - file_paths->push_back(file_path); - } - } -} diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_file_filter.h b/chromium/tools/traffic_annotation/auditor/traffic_annotation_file_filter.h deleted file mode 100644 index 467ed0ae9f9..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_file_filter.h +++ /dev/null @@ -1,53 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef TRAFFIC_ANNOTATION_FILE_FILTER_H_ -#define TRAFFIC_ANNOTATION_FILE_FILTER_H_ - -#include <string> -#include <vector> - -#include "base/files/file_path.h" - -// Provides the list of files that might be relevant to network traffic -// annotation by matching filename and searching for keywords in the file -// content. -// The file should end with either .cc or .mm and the content should include a -// keyword specifying definition of network traffic annotations or the name of -// a function that needs annotation. -class TrafficAnnotationFileFilter { - public: - TrafficAnnotationFileFilter(); - ~TrafficAnnotationFileFilter(); - - // Adds the list of relevant files in the given |directory_name| to the - // |file_paths|. If |directory_name| is empty, all files are returned. - // |source_path| should be the repository source directory, e.g. C:/src. - // |ignore_list| provides a list of partial paths to ignore. - void GetRelevantFiles(const base::FilePath& source_path, - const std::vector<std::string>& ignore_list, - std::string directory_name, - std::vector<std::string>* file_paths); - - // Checks the name and content of a file and returns true if it is relevant. - bool IsFileRelevant(const std::string& file_path); - - // Gets the list of all relevant files in the repository and stores them in - // |git_files|. - void GetFilesFromGit(const base::FilePath& source_path); - - // Sets the path to a file that would be used to mock the output of - // 'git ls-files' in tests. - void SetGitFileForTesting(const base::FilePath& file_path) { - git_file_for_test_ = file_path; - } - - const std::vector<std::string>& git_files() { return git_files_; } - - private: - std::vector<std::string> git_files_; - base::FilePath git_file_for_test_; -}; - -#endif // TRAFFIC_ANNOTATION_FILE_FILTER_H_
\ No newline at end of file diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_id_checker.cc b/chromium/tools/traffic_annotation/auditor/traffic_annotation_id_checker.cc deleted file mode 100644 index c3b88804f0a..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_id_checker.cc +++ /dev/null @@ -1,190 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "tools/traffic_annotation/auditor/traffic_annotation_id_checker.h" - -#include "base/containers/contains.h" -#include "base/strings/string_util.h" -#include "base/strings/stringprintf.h" - -TrafficAnnotationIDChecker::TrafficAnnotationIDChecker( - const std::set<int>& reserved_ids, - const std::set<int>& deprecated_ids) - : deprecated_ids_(deprecated_ids), reserved_ids_(reserved_ids) {} - -TrafficAnnotationIDChecker::~TrafficAnnotationIDChecker() = default; - -void TrafficAnnotationIDChecker::Load( - const std::vector<AnnotationInstance>& extracted_annotations) { - annotations_.clear(); - for (const AnnotationInstance& instance : extracted_annotations) { - AnnotationItem item; - item.type = instance.type; - item.ids[0].hash_code = instance.unique_id_hash_code; - item.ids[0].text = instance.proto.unique_id(); - if (instance.NeedsTwoIDs()) { - item.ids_count = 2; - item.ids[1].hash_code = instance.second_id_hash_code; - item.ids[1].text = instance.second_id; - } else { - item.ids_count = 1; - } - item.file_path = instance.proto.source().file(); - item.line_number = instance.proto.source().line(); - item.loaded_from_archive = instance.is_loaded_from_archive; - annotations_.push_back(item); - } -} - -void TrafficAnnotationIDChecker::CheckIDs(std::vector<AuditorResult>* errors) { - CheckIDsFormat(errors); - CheckForSecondIDs(errors); - CheckForInvalidValues( - reserved_ids_, AuditorResult::Type::ERROR_RESERVED_ID_HASH_CODE, errors); - CheckForInvalidValues(deprecated_ids_, - AuditorResult::Type::ERROR_DEPRECATED_ID_HASH_CODE, - errors); - CheckForHashCollisions(errors); - CheckForInvalidRepeatedIDs(errors); -} - -void TrafficAnnotationIDChecker::CheckForInvalidValues( - const std::set<int>& invalid_set, - AuditorResult::Type error_type, - std::vector<AuditorResult>* errors) { - for (AnnotationItem& item : annotations_) { - for (int i = 0; i < item.ids_count; i++) { - if (base::Contains(invalid_set, item.ids[i].hash_code)) { - errors->push_back(AuditorResult(error_type, item.ids[i].text, - item.file_path, item.line_number)); - } - } - } -} - -void TrafficAnnotationIDChecker::CheckForSecondIDs( - std::vector<AuditorResult>* errors) { - for (AnnotationItem& item : annotations_) { - if (item.ids_count == 2 && - (item.ids[1].text.empty() || - item.ids[0].hash_code == item.ids[1].hash_code)) { - errors->push_back( - AuditorResult(AuditorResult::Type::ERROR_MISSING_SECOND_ID, - std::string(), item.file_path, item.line_number)); - // Remove this id from next tests. - item.ids_count = 0; - } - } -} - -void TrafficAnnotationIDChecker::CheckForHashCollisions( - std::vector<AuditorResult>* errors) { - std::map<int, std::string> collisions; - for (AnnotationItem& item : annotations_) { - for (int i = 0; i < item.ids_count; i++) { - if (!base::Contains(collisions, item.ids[i].hash_code)) { - // If item is loaded from archive, and it is the second id, do not keep - // the id for checks. Archive just keeps the hash code of the second id - // and the text value of it is not correct. - if (!item.loaded_from_archive || !i) { - collisions.insert( - std::make_pair(item.ids[i].hash_code, item.ids[i].text)); - } - } else { - if (item.loaded_from_archive && i) - continue; - if (item.ids[i].text != collisions[item.ids[i].hash_code]) { - AuditorResult error(AuditorResult::Type::ERROR_HASH_CODE_COLLISION, - item.ids[i].text); - error.AddDetail(collisions[item.ids[i].hash_code]); - errors->push_back(error); - } - } - } - } -} - -void TrafficAnnotationIDChecker::CheckForInvalidRepeatedIDs( - std::vector<AuditorResult>* errors) { - std::map<int, AnnotationItem*> first_ids; - std::map<int, AnnotationItem*> second_ids; - - // Check if first ids are unique. - for (AnnotationItem& item : annotations_) { - if (!base::Contains(first_ids, item.ids[0].hash_code)) { - first_ids[item.ids[0].hash_code] = &item; - } else { - errors->push_back(CreateRepeatedIDError( - item.ids[0].text, item, *first_ids[item.ids[0].hash_code])); - } - } - - // If a second id is equal to a first id, owner of the second id should be of - // type PARTIAL and owner of the first id should be of type COMPLETING. - for (AnnotationItem& item : annotations_) { - if (item.ids_count == 2 && - base::Contains(first_ids, item.ids[1].hash_code)) { - if (item.type != AnnotationInstance::Type::ANNOTATION_PARTIAL || - first_ids[item.ids[1].hash_code]->type != - AnnotationInstance::Type::ANNOTATION_COMPLETING) { - errors->push_back(CreateRepeatedIDError( - item.ids[1].text, item, *first_ids[item.ids[1].hash_code])); - } - } - } - - // If two second ids are equal, they should be either PARTIAL or - // BRANCHED_COMPLETING. - for (AnnotationItem& item : annotations_) { - if (item.ids_count != 2) - continue; - if (!base::Contains(second_ids, item.ids[1].hash_code)) { - second_ids[item.ids[1].hash_code] = &item; - } else { - AnnotationInstance::Type other_type = - second_ids[item.ids[1].hash_code]->type; - if ((item.type != AnnotationInstance::Type::ANNOTATION_PARTIAL && - item.type != - AnnotationInstance::Type::ANNOTATION_BRANCHED_COMPLETING) || - (other_type != AnnotationInstance::Type::ANNOTATION_PARTIAL && - other_type != - AnnotationInstance::Type::ANNOTATION_BRANCHED_COMPLETING)) { - errors->push_back(CreateRepeatedIDError( - item.ids[1].text, item, *second_ids[item.ids[1].hash_code])); - } - } - } -} - -void TrafficAnnotationIDChecker::CheckIDsFormat( - std::vector<AuditorResult>* errors) { - for (AnnotationItem& item : annotations_) { - bool any_failed = false; - for (int i = 0; i < item.ids_count; i++) { - if (!base::ContainsOnlyChars(base::ToLowerASCII(item.ids[i].text), - "0123456789_abcdefghijklmnopqrstuvwxyz")) { - errors->push_back( - AuditorResult(AuditorResult::Type::ERROR_ID_INVALID_CHARACTER, - item.ids[i].text, item.file_path, item.line_number)); - any_failed = true; - } - } - // Remove this id from next tests. - if (any_failed) - item.ids_count = 0; - } -} - -AuditorResult TrafficAnnotationIDChecker::CreateRepeatedIDError( - const std::string& common_id, - const AnnotationItem& item1, - const AnnotationItem& item2) { - AuditorResult error( - AuditorResult::Type::ERROR_REPEATED_ID, - base::StringPrintf("%s in '%s:%i'", common_id.c_str(), - item1.file_path.c_str(), item1.line_number)); - error.AddDetail(base::StringPrintf("'%s:%i'", item2.file_path.c_str(), - item2.line_number)); - return error; -} diff --git a/chromium/tools/traffic_annotation/auditor/traffic_annotation_id_checker.h b/chromium/tools/traffic_annotation/auditor/traffic_annotation_id_checker.h deleted file mode 100644 index 4f3660520c0..00000000000 --- a/chromium/tools/traffic_annotation/auditor/traffic_annotation_id_checker.h +++ /dev/null @@ -1,70 +0,0 @@ -// Copyright 2017 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef TRAFFIC_ANNOTATION_ID_CHECKER_H_ -#define TRAFFIC_ANNOTATION_ID_CHECKER_H_ - -#include <set> -#include <vector> - -#include "tools/traffic_annotation/auditor/instance.h" - -// Performs all tests that are required to ensure that annotations have correct -// ids. -class TrafficAnnotationIDChecker { - public: - TrafficAnnotationIDChecker(const std::set<int>& reserved_ids, - const std::set<int>& deprecated_ids); - ~TrafficAnnotationIDChecker(); - - // Loads |extracted_annotations| into |annotations_|; - void Load(const std::vector<AnnotationInstance>& extracted_annotations); - - // Checks loaded |annotations_| for all sort of ID related errors and writes - // errors to |errors|. - void CheckIDs(std::vector<AuditorResult>* errors); - - private: - // TODO(https://crbug.com/690323): Merge struct with AnnotationInstance. - struct AnnotationItem { - struct { - std::string text; - int hash_code; - } ids[2]; - int ids_count; // Number of existing ids (1 or 2). - AnnotationInstance::Type type; - std::string file_path; - int line_number; - bool loaded_from_archive; - }; - - // Checks if the ids in |invalid_set| are not used in annotations. If found, - // creates an error with |error_type| and writes it to |errors|. - void CheckForInvalidValues(const std::set<int>& invalid_set, - AuditorResult::Type error_type, - std::vector<AuditorResult>* errors); - - // Check if annotations that need two ids, have two and the second one is - // different from their unique id. - void CheckForSecondIDs(std::vector<AuditorResult>* errors); - - // Checks if there are ids with colliding hash values. - void CheckForHashCollisions(std::vector<AuditorResult>* errors); - - // Checks if there are invalid repeated ids. - void CheckForInvalidRepeatedIDs(std::vector<AuditorResult>* errors); - - // Checks if ids only include alphanumeric characters and underline. - void CheckIDsFormat(std::vector<AuditorResult>* errors); - - AuditorResult CreateRepeatedIDError(const std::string& common_id, - const AnnotationItem& item1, - const AnnotationItem& item2); - - std::vector<AnnotationItem> annotations_; - std::set<int> deprecated_ids_; - std::set<int> reserved_ids_; -}; - -#endif // TRAFFIC_ANNOTATION_ID_CHECKER_H_
\ No newline at end of file diff --git a/chromium/tools/traffic_annotation/bin/README.md b/chromium/tools/traffic_annotation/bin/README.md index b191c551bb7..46f8551e324 100644 --- a/chromium/tools/traffic_annotation/bin/README.md +++ b/chromium/tools/traffic_annotation/bin/README.md @@ -59,5 +59,5 @@ and land the resulting CL. The following line will be updated by the above script, and the modified README should be committed along with the updated .sha1 checksums. -LASTCHANGE=08e1d61372f41498f01361807b498b6f083f425a-refs/heads/master@{#902419} +LASTCHANGE=cdc4b63690632690274f67929ce0a49720eb1af3-refs/heads/main@{#913784} LASTCHANGE_YEAR=2021 diff --git a/chromium/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1 b/chromium/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1 index 2753d4e3678..7918b2c0ce8 100644 --- a/chromium/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1 +++ b/chromium/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1 @@ -1 +1 @@ -705e6bca3d8da6b5a78dd62947f08308b26510be
\ No newline at end of file +d6f4d194a53be2fa152ad77642e1bb90e2cebe86
\ No newline at end of file diff --git a/chromium/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1 b/chromium/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1 index eaf42c14bfd..bcdc300ba17 100644 --- a/chromium/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1 +++ b/chromium/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1 @@ -1 +1 @@ -f4362222ab0503dfb92582e300c71420642e220b
\ No newline at end of file +6b6864f1c8afbcdae654582e5f3309d7b1d5a6ad
\ No newline at end of file diff --git a/chromium/tools/traffic_annotation/scripts/annotation_tokenizer.py b/chromium/tools/traffic_annotation/scripts/annotation_tokenizer.py index eba91132c89..06a5d1ae4c0 100644 --- a/chromium/tools/traffic_annotation/scripts/annotation_tokenizer.py +++ b/chromium/tools/traffic_annotation/scripts/annotation_tokenizer.py @@ -6,7 +6,7 @@ A tokenizer for traffic annotation definitions. """ -from collections import namedtuple +from typing import NamedTuple, Optional import re @@ -19,10 +19,19 @@ import re TOKEN_REGEXEN = [ # Comma for separating args. ('comma', re.compile(r'(,)')), - # String literal. "string" or R"(string)". - ('string_literal', - re.compile(r'"((?:[^"]|\\.)*?)"|R"\((.*?)\)"', re.DOTALL)), - # C++ identifier. + # String literal. "string" or R"(string)". In Java, this will incorrectly + # accept R-strings, which aren't part of the language's syntax. But since + # that wouldn't compile anyways, we can just ignore this issue. + ('string_literal', re.compile(r'"((?:[^"]|\\.)*?)"|R"\((.*?)\)"', + re.DOTALL)), + # The '+' operator, for string concatenation. Java doesn't have multi-line + # string literals, so this is the only way to keep long strings readable. It + # doesn't incur a runtime cost, since the Java compiler is smart enough to + # concat the string literals at compile time. See "constant expressions" in + # the JLS: + # https://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.28 + ('plus', re.compile(r'(\+)')), + # C++ or Java identifier. ('symbol', re.compile(r'([a-zA-Z_][a-zA-Z_0-9]*)')), # Left parenthesis. ('left_paren', re.compile(r'(\()')), @@ -33,11 +42,15 @@ TOKEN_REGEXEN = [ # Number of characters to include in the context (for error reporting). CONTEXT_LENGTH = 20 -Token = namedtuple('Token', ['type', 'value', 'pos']) +class Token(NamedTuple): + type: str + value: str + pos: int -class CppParsingError(Exception): - """An error during C++ parsing/tokenizing.""" + +class SourceCodeParsingError(Exception): + """An error during C++ or Java parsing/tokenizing.""" def __init__(self, expected_type, body, pos, file_path, line_number): context = body[pos:pos + CONTEXT_LENGTH] @@ -65,8 +78,8 @@ class Tokenizer: return # Skip whitespace to make the error message more useful. pos = self._skip_whitespace() - raise CppParsingError(expected_type, self.body, pos, self.file_path, - self.line_number) + raise SourceCodeParsingError(expected_type, self.body, pos, self.file_path, + self.line_number) def _skip_whitespace(self): """Return the position of the first non-whitespace character from here.""" @@ -90,7 +103,7 @@ class Tokenizer: return token - def maybe_advance(self, expected_type): + def maybe_advance(self, expected_type: str) -> Optional[str]: """Advance the tokenizer by one token if it has |expected_type|. Args: @@ -106,7 +119,7 @@ class Tokenizer: return token.value return None - def advance(self, expected_type): + def advance(self, expected_type: str) -> str: """Advance the tokenizer by one token, asserting its type. Throws an error if the token at point has the wrong type. diff --git a/chromium/tools/traffic_annotation/scripts/annotation_tokenizer_test.py b/chromium/tools/traffic_annotation/scripts/annotation_tokenizer_test.py index d417b23b835..b9db52335c2 100755 --- a/chromium/tools/traffic_annotation/scripts/annotation_tokenizer_test.py +++ b/chromium/tools/traffic_annotation/scripts/annotation_tokenizer_test.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -9,7 +9,7 @@ Unit tests for annotation_tokenizer.py. import unittest -from annotation_tokenizer import Tokenizer, CppParsingError +from annotation_tokenizer import Tokenizer, SourceCodeParsingError class AnnotationTokenizerTest(unittest.TestCase): @@ -54,6 +54,14 @@ class AnnotationTokenizerTest(unittest.TestCase): self.assertEqual(')', tokenizer.advance('right_paren')) self.assertEqual(')', tokenizer.advance('right_paren')) + def testConcatenatedStrings(self): + tokenizer = Tokenizer('"hello " + "world" + "!"', 'foo.java', 22) + self.assertEqual('hello ', tokenizer.advance('string_literal')) + self.assertEqual('+', tokenizer.advance('plus')) + self.assertEqual('world', tokenizer.advance('string_literal')) + self.assertEqual('+', tokenizer.advance('plus')) + self.assertEqual('!', tokenizer.advance('string_literal')) + def testAdvanceMultiline(self): tokenizer = Tokenizer('\n\tR"(the quick\nbrown\nfox)"', 'foo.txt', 33) self.assertEqual( @@ -62,19 +70,19 @@ class AnnotationTokenizerTest(unittest.TestCase): def testAdvanceErrorPaths(self): tokenizer = Tokenizer(' hello , ', 'foo.txt', 33) tokenizer.advance('symbol') - with self.assertRaisesRegexp(CppParsingError, + with self.assertRaisesRegexp(SourceCodeParsingError, 'Expected symbol.+at foo.txt:33'): # There are no more tokens. tokenizer.advance('symbol') tokenizer = Tokenizer('"hello"', 'foo.txt', 33) - with self.assertRaisesRegexp(CppParsingError, + with self.assertRaisesRegexp(SourceCodeParsingError, 'Expected comma.+at foo.txt:33'): # The type doesn't match. tokenizer.advance('comma') tokenizer = Tokenizer('{', 'foo.txt', 33) - with self.assertRaisesRegexp(CppParsingError, + with self.assertRaisesRegexp(SourceCodeParsingError, 'Expected string_literal.+at foo.txt:33'): # Not a valid token at all. tokenizer.advance('string_literal') diff --git a/chromium/tools/traffic_annotation/scripts/auditor/README.md b/chromium/tools/traffic_annotation/scripts/auditor/README.md new file mode 100644 index 00000000000..629b50f5b50 --- /dev/null +++ b/chromium/tools/traffic_annotation/scripts/auditor/README.md @@ -0,0 +1,42 @@ +# Network Traffic Annotation Auditor + +This script runs extractor.py to extract Network Traffic Annotations +from chromium source code, collects and summarizes its outputs, and performs +tests and maintenance. + +Please see `docs/network_traffic_annotations.md` for an introduction to network +traffic annotations. + +## Usage + +`vpython3 ./tools/traffic_annotation/scripts/auditor/auditor.py [OPTIONS]... [path_filter]...` + +Extracts network traffic annotations from source files, tests them, and updates +`tools/traffic_annotation/summary/annotations.xml`. If path filter(s) are +specified, only those directories of the source will be analyzed. +Run `./tools/traffic_annotation/scripts/auditor/auditor.py --help` for options. + +Example: + `vpython3 ./tools/traffic_annotation/scripts/auditor/auditor.py --build-path=out/Debug` + +## Running + +Before running, you need to build the `chrome` target, and pass the build path +to the executable. + +## Safe List + +If there are files, paths, or specific functions that need to be exempted from +all or some tests, they can be added to the `safe_list.txt`. The file is comma +separated, specifying the safe lists based on `ExceptionType` in `auditor.py`. + +Use * as wildcard for zero or more characters when specifying file paths. + +Here are the exception types: +* `all`: Files and paths in this category are exempted from all tests. +* `missing`: Files and paths in this category can use the + MISSING_TRAFFIC_ANNOTATION tag. +* `mutable_tag`: Files and paths in this category can use the + CreateMutableNetworkTrafficAnnotationTag() function. +* `test_annotation`: Files and paths in this category can use the + TRAFFIC_ANNOTATION_FOR_TESTS tag. diff --git a/chromium/tools/traffic_annotation/scripts/auditor/auditor.py b/chromium/tools/traffic_annotation/scripts/auditor/auditor.py index f3b47c58bfa..3cc9ba66d59 100755 --- a/chromium/tools/traffic_annotation/scripts/auditor/auditor.py +++ b/chromium/tools/traffic_annotation/scripts/auditor/auditor.py @@ -57,7 +57,14 @@ NO_ANNOTATION_ID = UniqueId("undefined") RESERVED_IDS = TEST_IDS + [MISSING_ID, NO_ANNOTATION_ID] # Host platforms that support running auditor.py. -SUPPORTED_PLATFORMS = ["linux", "windows"] +SUPPORTED_PLATFORMS = ["linux", "windows", "android"] + +# These platforms populate the "os_list" field in annotations.xml for +# newly-added annotations (i.e., assume they're present on these platforms). +# +# Android isn't completely supported yet, so exclude it for now. +# TODO(crbug.com/1231780): Revisit this once Android support is complete. +DEFAULT_OS_LIST = ["linux", "windows"] # Earliest valid milestone for added_in_milestone in annotations.xml. MIN_MILESTONE = 62 @@ -81,6 +88,31 @@ logging.basicConfig( logger = logging.getLogger(__name__) +def get_current_platform(build_path: Optional[Path] = None) -> str: + """Return the target platform of |build_path| based on heuristics.""" + # Use host platform as the source of truth (in most cases). + current_platform: str = platform.system().lower() + + if current_platform == "linux" and build_path is not None: + # It could be an Android build directory, being compiled from a Linux host. + # Look for a target_os="android" line in args.gn. + try: + gn_args = (build_path / "args.gn").read_text(encoding="utf-8") + pattern = re.compile(r"^\s*target_os\s*=\s*\"android\"\s*$", re.MULTILINE) + if pattern.search(gn_args): + current_platform = "android" + except (ValueError, OSError): + logger.info(e.value) + # Maybe the file's absent, or it can't be decoded as UTF-8, or something. + # It's probably not Android in that case. + pass + + if current_platform not in SUPPORTED_PLATFORMS: + raise ValueError("Unsupported platform {}".format(current_platform)) + + return current_platform + + def twos_complement_8bit(b: int) -> int: """Interprets b like a signed 8-bit integer, possibly changing its sign. @@ -290,7 +322,7 @@ def write_annotations_tsv_file(file_path: Path, annotations: List["Annotation"], lines.insert(0, title) report = "\n".join(lines) + "\n" - file_path.write_text(report, "utf-8") + file_path.write_text(report, encoding="utf-8") class AuditorError: @@ -409,7 +441,6 @@ class AuditorError: self.file_path, self.line)) if self.type == AuditorError.Type.NO_ANNOTATION: - # TODO(nicolaso): We should ignore this error on Android for now. return "NO_ANNOTATION: Empty annotation in '{}:{}'.".format( self.file_path, self.line) @@ -776,13 +807,14 @@ class Annotation: self.file = file_path self.line = line_number - if serialized_annotation.type_name == "Mutable": + if serialized_annotation.type_name == extractor.AnnotationType.MUTABLE: return [ AuditorError(AuditorError.Type.MUTABLE_TAG, "", file_path, line_number) ] - self.type = Annotation.Type.from_string(serialized_annotation.type_name) + self.type = Annotation.Type.from_string( + serialized_annotation.type_name.value) self.unique_id = serialized_annotation.unique_id self.second_id = serialized_annotation.extra_id self.second_id_hash_code = compute_hash_value(self.second_id) @@ -913,9 +945,10 @@ class FileFilter: git_file_for_testing: If present, use this .txt file to mock the output of `git ls-files`.""" - def __init__(self): + def __init__(self, accepted_suffixes: List[str]): self.git_files: List[Path] = [] - self.git_file_for_testing: Optional[str] = None + self.git_file_for_testing: Optional[Path] = None + self.accepted_suffixes = accepted_suffixes def get_source_files(self, safe_list: SafeList, prefix: str) -> List[Path]: """Returns a filtered list of files in the prefix directory. @@ -940,25 +973,17 @@ class FileFilter: continue file_paths.append(file_path) - # TODO(nicolaso): Also filter files by content, like the C++ auditor. - # Empirically, this seems to save ~10s when parsing the whole codebase (22s - # without pre-filtering, 12s with pre-filtering). Maybe the regexen in - # extractor.py can be tweaked for performance instead? - # - # Also, the performance impact is probably smaller if the files aren't in - # the disk cache from a previous run. - return file_paths def _is_supported_source_file(self, file_path: Path) -> bool: """Returns true if file_path looks like a non-test C++/Obj-C++ file.""" # Check file extension. - if file_path.suffix not in [".cc", ".mm"]: + if file_path.suffix not in self.accepted_suffixes: return False # Ignore test files to speed up the tests. They would be only tested when # filters are disabled. - if file_path.stem.endswith("test"): + if re.search(r'test$', file_path.stem, re.IGNORECASE): return False return True @@ -973,8 +998,7 @@ class FileFilter: if self.git_file_for_testing is not None: # Get list of files from git_list.txt (or similar). - with open(self.git_file_for_testing) as f: - lines = [l.rstrip() for l in f.readlines()] + lines = self.git_file_for_testing.read_text(encoding="utf-8").splitlines() else: # Get list of files from git. if platform.system() == "Windows": @@ -1215,35 +1239,43 @@ class ArchivedAnnotation: class Exporter: """Handles loading and saving ArchivedAnnotations in annotations.xml.""" - ANNOTATIONS_XML_PATH = (SCRIPT_DIR.parent.parent / "summary" / - "annotations.xml") + SUMMARY_DIR = SCRIPT_DIR.parent.parent / "summary" GROUPING_XML_PATH = SCRIPT_DIR.parent.parent / "summary" / "grouping.xml" - def __init__(self): + def __init__(self, current_platform: str): self.archive: Dict[UniqueId, ArchivedAnnotation] = {} - self._current_platform = platform.system().lower() - if self._current_platform not in SUPPORTED_PLATFORMS: - raise ValueError("Unsupported platform {}".format(self._current_platform)) - - with open(SRC_DIR / "chrome" / "VERSION") as f: - contents = f.read() - m = re.search(r'MAJOR=(\d+)', contents) - if not m: - raise ValueError( - "Unable to extract MAJOR=... version from chrome/VERSION") - self._current_milestone = int(m.group(1)) + assert current_platform in SUPPORTED_PLATFORMS + self._current_platform = current_platform + + contents = (SRC_DIR / "chrome" / "VERSION").read_text(encoding="utf-8") + m = re.search(r'MAJOR=(\d+)', contents) + if not m: + raise ValueError( + "Unable to extract MAJOR=... version from chrome/VERSION") + self._current_milestone = int(m.group(1)) + + if self._current_platform == "android": + # Use a separate file for Android until the CQ/waterfall checks are stable + # enough, to avoid confusing CL authors. + # + # TODO(crbug.com/1231780): Merge this with annotations.xml once the + # checks are working well on Android. + self.annotations_xml_path = (Exporter.SUMMARY_DIR / + "annotations_android.xml") + else: + self.annotations_xml_path = Exporter.SUMMARY_DIR / "annotations.xml" def load_annotations_xml(self) -> None: """Loads annotations from annotations.xml into self.archive using ArchivedAnnotation objects.""" logger.info("Parsing {}.".format( - Exporter.ANNOTATIONS_XML_PATH.relative_to(SRC_DIR))) + self.annotations_xml_path.relative_to(SRC_DIR))) self.archive = {} - tree = xml.etree.ElementTree.parse(Exporter.ANNOTATIONS_XML_PATH) + tree = xml.etree.ElementTree.parse(self.annotations_xml_path) root = tree.getroot() for item in root.iter("item"): @@ -1298,6 +1330,12 @@ class Exporter: current_platform_hashcodes: Set[HashCode] = set() + # Don't include android in the os_list for new annotations, unless we're + # touching annotations_android.xml. + default_os_list = DEFAULT_OS_LIST + if self._current_platform not in default_os_list: + default_os_list = [self._current_platform] + for annotation in annotations: # annotations.xml only stores raw annotations. if annotation.is_merged: @@ -1315,13 +1353,13 @@ class Exporter: archived.content_hash_code = annotation.get_content_hash_code() else: # If annotation is new, add it and assume it is on all platforms. Tests - # running on other platforms will request updating this if required.: + # running on other platforms will request updating this if required. new_item = ArchivedAnnotation( type=annotation.type, id=annotation.unique_id, hash_code=annotation.unique_id_hash_code, content_hash_code=annotation.get_content_hash_code(), - os_list=SUPPORTED_PLATFORMS, + os_list=default_os_list, added_in_milestone=self._current_milestone, file_path=annotation.file) if annotation.needs_two_ids(): @@ -1350,7 +1388,7 @@ class Exporter: added_in_milestone=self._current_milestone, hash_code=compute_hash_value(reserved_id), reserved=True, - os_list=SUPPORTED_PLATFORMS, + os_list=default_os_list, file_path="") # If there are annotations that are not used on any OS, set the deprecation @@ -1444,7 +1482,7 @@ class Exporter: if archived.deprecated and archived.os_list: errors.append( AuditorError(AuditorError.Type.DEPRECATED_WITH_OS, unique_id, - Exporter.ANNOTATIONS_XML_PATH)) + self.annotations_xml_path)) # Check that listed OSes are valid. for unique_id, archived in self.archive.items(): @@ -1452,14 +1490,14 @@ class Exporter: if os not in SUPPORTED_PLATFORMS: errors.append( AuditorError(AuditorError.Type.INVALID_OS, "", - Exporter.ANNOTATIONS_XML_PATH, 0, os, unique_id)) + self.annotations_xml_path, 0, os, unique_id)) # Check for consistency of "added_in_milestone" attribute. for unique_id, archived in self.archive.items(): if archived.added_in_milestone < MIN_MILESTONE: errors.append( AuditorError(AuditorError.Type.INVALID_ADDED_IN, "", - Exporter.ANNOTATIONS_XML_PATH, 0, + self.annotations_xml_path, 0, str(archived.added_in_milestone), unique_id)) return errors @@ -1467,9 +1505,9 @@ class Exporter: def save_annotations_xml(self) -> None: """Saves self._archive into annotations.xml""" logger.info("Saving annotations to {}.".format( - Exporter.ANNOTATIONS_XML_PATH.relative_to(SRC_DIR))) + self.annotations_xml_path.relative_to(SRC_DIR))) xml_str = self._generate_serialized_xml() - Exporter.ANNOTATIONS_XML_PATH.write_text(xml_str) + self.annotations_xml_path.write_text(xml_str, encoding="utf-8") def get_deprecated_ids(self) -> List[UniqueId]: """Produces the list of deprecated unique ids. Requires that annotations.xml @@ -1507,10 +1545,9 @@ class Exporter: """Returns the required updates to go from one state to another in annotations.xml""" logger.info("Computing required updates for {}.".format( - Exporter.ANNOTATIONS_XML_PATH.relative_to(SRC_DIR))) - - old_xml = Exporter.ANNOTATIONS_XML_PATH.read_text("utf-8") + self.annotations_xml_path.relative_to(SRC_DIR))) + old_xml = self.annotations_xml_path.read_text(encoding="utf-8") new_xml = self._generate_serialized_xml() return Exporter._get_xml_differences(old_xml, new_xml) @@ -1522,7 +1559,9 @@ class Auditor: SAFE_LIST_PATH = (SRC_DIR / "tools" / "traffic_annotation" / "auditor" / "safe_list.txt") - def __init__(self): + def __init__(self, current_platform: str, no_filtering: bool = False): + self.no_filtering = no_filtering + self.extracted_annotations: List[Annotation] = [] self.partial_annotations: List[Annotation] = [] @@ -1530,8 +1569,13 @@ class Auditor: self._safe_list: SafeList = {} - self.exporter = Exporter() - self.file_filter = FileFilter() + self.exporter = Exporter(current_platform) + + accepted_suffixes = [".cc", ".mm"] + if current_platform == "android": + accepted_suffixes.append(".java") + + self.file_filter = FileFilter(accepted_suffixes) def _get_safe_list(self) -> SafeList: """Lazily loads safe_list.txt and returns it.""" @@ -1541,34 +1585,34 @@ class Auditor: self._safe_list = dict((t, []) for t in ExceptionType) # Ignore safe_list.txt while testing. - if self.file_filter.git_file_for_testing: + if self.file_filter.git_file_for_testing is not None: return self._safe_list logger.info("Parsing {}.".format( Auditor.SAFE_LIST_PATH.relative_to(SRC_DIR))) - with open(Auditor.SAFE_LIST_PATH) as f: - for line in f.readlines(): - # Ignore comments and empty lines. - line = line.rstrip() - if not line or line.startswith("#"): - continue - # Expect a type, and at least 1 value on each line. - tokens = line.split(",") - assert len(tokens) >= 2, \ - "Unexpected syntax in safe_list.txt, line: {}".format(line) - - exception_type = ExceptionType(tokens[0]) - valid_characters = "0123456789_abcdefghijklmnopqrstuvwxyz.*/:@" - for token in tokens[1:]: - token = token.strip() - # Convert the rest of the line into re.Patterns, marking dots as fixed - # characters and asterisks as wildcards. - assert all(c in valid_characters for c in token), \ - "Unexpected character in safe_list.txt token: '{}'".format(token) - token = token.replace(".", "\\.") - token = token.replace("*", ".*") - self._safe_list[exception_type].append(re.compile(token)) + lines = Auditor.SAFE_LIST_PATH.read_text(encoding="utf-8").splitlines() + for line in lines: + # Ignore comments and empty lines. + line = line.rstrip() + if not line or line.startswith("#"): + continue + + # Expect a type, and at least 1 value on each line. + tokens = line.split(",") + assert len(tokens) >= 2, \ + "Unexpected syntax in safe_list.txt, line: {}".format(line) + + exception_type = ExceptionType(tokens[0]) + for token in tokens[1:]: + token = token.strip() + # Convert the rest of the line into re.Patterns, marking dots as fixed + # characters and asterisks as wildcards. + assert re.match(r'^[0-9a-zA-Z_.*/:@]+$', token), \ + "Unexpected character in safe_list.txt token: '{}'".format(token) + token = token.replace(".", "\\.") + token = token.replace("*", ".*") + self._safe_list[exception_type].append(re.compile(token)) return self._safe_list @@ -1593,7 +1637,7 @@ class Auditor: build_path: Path Path to a directory where Chrome was built (e.g., out/Release) path_filters: List[str] - If this list is empty, parse all .cc files in the repository. + If this list is empty, parse all .cc/.mm/.java files in the repository. Returns: A list of all network traffic annotation instances found within a list of @@ -1613,33 +1657,44 @@ class Auditor: files = self.file_filter.get_source_files(safe_list, "") # Skip compdb generation while testing to speed up tests. - if self.file_filter.git_file_for_testing: + if self.file_filter.git_file_for_testing is not None: compdb_files = None else: logger.info("Generating compile_commands.json") tools = NetworkTrafficAnnotationTools(str(build_path)) compdb_files = tools.GetCompDBFiles(not skip_compdb) + suffixes = '/'.join(self.file_filter.accepted_suffixes) if path_filters: - logger.info("Parsing valid .cc/.mm files in the Chromium repository, " - "that match any of these prefixes: {}".format(path_filters)) + logger.info("Parsing valid {} files in the Chromium repository, " + "that match any of these prefixes: {}".format( + suffixes, path_filters)) else: - logger.info("Parsing all valid .cc/.mm files in the Chromium " - "repository.") + logger.info("Parsing all valid {} files in the Chromium " + "repository.".format(suffixes)) all_annotations = [] for relative_path in files: absolute_path = SRC_DIR / relative_path - # Skip files based on compdb and path_filters. - if (compdb_files is not None and str(absolute_path) not in compdb_files): + + # Skip files based on compdb and path_filters. Java files aren't in + # compile_commands.json, so don't check those. + if (absolute_path.suffix != ".java" and compdb_files is not None + and str(absolute_path) not in compdb_files): continue if (path_filters and not self._path_filters_match(path_filters, relative_path)): continue - # Extract annotations from the .cc file. This will throw a CppParsingError - # if the format is invalid. + # Pre-filter files based on their content, using a fast regex. When files + # are already in memory from the disk cache, this saves ~10 seconds. + if (not self.no_filtering + and not extractor.may_contain_annotations(absolute_path)): + continue + + # Extract annotations from the .cc/.mm/.java file. This will throw a + # SourceCodeParsingError if the format is invalid. annotations = extractor.extract_annotations(absolute_path) if annotations: all_annotations.extend(annotations) @@ -1847,8 +1902,9 @@ class Auditor: if path_filters: self._add_missing_annotations(path_filters) - logger.info("Checking the validity of annotations extracted from .cc/.mm " - "files.") + suffixes = '/'.join(self.file_filter.accepted_suffixes) + logger.info("Checking the validity of annotations extracted from {} " + "files.".format(suffixes)) deprecated_ids = self.exporter.get_deprecated_ids() id_checker = IdChecker(RESERVED_IDS, deprecated_ids) @@ -1901,7 +1957,8 @@ class AuditorUI: # Exposed for testing. self.traffic_annotation = self.import_compiled_proto() - self.auditor = Auditor() + self.auditor = Auditor(get_current_platform(self.build_path), + self.no_filtering) def import_compiled_proto(self) -> Any: """Global import from function. |self.build_path| is needed to perform diff --git a/chromium/tools/traffic_annotation/scripts/auditor/auditor_tests.py b/chromium/tools/traffic_annotation/scripts/auditor/auditor_tests.py index 912b4b21537..c858e00b2a6 100755 --- a/chromium/tools/traffic_annotation/scripts/auditor/auditor_tests.py +++ b/chromium/tools/traffic_annotation/scripts/auditor/auditor_tests.py @@ -38,8 +38,7 @@ class AuditorTest(unittest.TestCase): no_filtering=False, test_only=True) self.auditor = self.auditor_ui.auditor - self.auditor.file_filter.git_file_for_testing = os.path.join( - TESTS_DIR, "git_list.txt") + self.auditor.file_filter.git_file_for_testing = TESTS_DIR / "git_list.txt" all_annotations = self.auditor.run_extractor(self.auditor_ui.build_path, self.auditor_ui.path_filters, @@ -57,13 +56,15 @@ class AuditorTest(unittest.TestCase): def deserialize(self, file_name: str) -> Tuple[Annotation, List[AuditorError]]: file_path = CPP_TESTS_DIR / "extractor_outputs" / file_name - with open(file_path) as f: - lines = [l.rstrip() for l in f.readlines()] + lines = file_path.read_text(encoding="utf-8").splitlines() annotation = Annotation() - extracted_annotation = extractor.Annotation(file_path=lines[0], + language = extractor.LANGUAGE_MAPPING[Path(lines[0]).suffix] + type_name = extractor.AnnotationType(lines[2]) + extracted_annotation = extractor.Annotation(language=language, + file_path=lines[0], line_number=int(lines[1]), - type_name=lines[2], + type_name=type_name, unique_id=lines[3], extra_id=lines[4], text="\n".join(lines[5:])) @@ -111,8 +112,8 @@ class AuditorTest(unittest.TestCase): """Tests that FileFilter.get_files_from_git() returns correct files given a mock git_list.txt file. It also inherently checks FileFilter._is_supported_source_file().""" - filter = FileFilter() - filter.git_file_for_testing = os.path.join(CPP_TESTS_DIR, "git_list.txt") + filter = FileFilter([".cc", ".mm"]) + filter.git_file_for_testing = CPP_TESTS_DIR / "git_list.txt" filter.get_files_from_git() relevant_files = [ @@ -132,8 +133,8 @@ class AuditorTest(unittest.TestCase): def test_get_source_files(self): """Tests that FileFilter.get_source_files() gives the correct list of files, given a mock git_list.txt file.""" - filter = FileFilter() - filter.git_file_for_testing = os.path.join(CPP_TESTS_DIR, "git_list.txt") + filter = FileFilter([".cc", ".mm"]) + filter.git_file_for_testing = CPP_TESTS_DIR / "git_list.txt" filter.get_files_from_git() # Check if all files are returned with no ignore list and directory. @@ -159,7 +160,7 @@ class AuditorTest(unittest.TestCase): def test_is_safelisted(self): """Tests if Auditor._is_safe_listed() works as expected. Inherently checks Auditor.load_safe_list() as well.""" - auditor = Auditor() # use the real safe_list.txt + auditor = Auditor(get_current_platform()) # use the real safe_list.txt for t in ExceptionType: # Anything in /tools directory is safelisted for all types. self.assertTrue(auditor._is_safe_listed(Path("tools/something.cc"), t)) @@ -635,38 +636,37 @@ class AuditorTest(unittest.TestCase): def test_annotations_xml(self): """Tests is annotations.xml has proper content.""" # annotations.xml should parse without errors. - exporter = Exporter() + exporter = Exporter(get_current_platform()) exporter.load_annotations_xml() errors = exporter.check_archived_annotations() self.assertEqual([], errors) # The content of annotations.xml shouldn't change when writing it. - with open(Exporter.ANNOTATIONS_XML_PATH) as f: - old_xml = f.read() + old_xml = exporter.annotations_xml_path.read_text(encoding="utf-8") new_xml = exporter._generate_serialized_xml() self.assertEqual(old_xml, new_xml) def test_annotations_xml_differences(self): """Tests if annotations.xml changes are correctly reported.""" - exporter = Exporter() + exporter = Exporter(get_current_platform()) - with open(os.path.join(CPP_TESTS_DIR, "annotations_sample1.xml")) as f: - xml1 = f.read() - with open(os.path.join(CPP_TESTS_DIR, "annotations_sample2.xml")) as f: - xml2 = f.read() - with open(os.path.join(CPP_TESTS_DIR, "annotations_sample3.xml")) as f: - xml3 = f.read() + xml1 = (CPP_TESTS_DIR / + "annotations_sample1.xml").read_text(encoding="utf-8") + xml2 = (CPP_TESTS_DIR / + "annotations_sample2.xml").read_text(encoding="utf-8") + xml3 = (CPP_TESTS_DIR / + "annotations_sample3.xml").read_text(encoding="utf-8") diff12 = exporter._get_xml_differences(xml1, xml2) diff13 = exporter._get_xml_differences(xml1, xml3) diff23 = exporter._get_xml_differences(xml2, xml3) - with open(os.path.join(CPP_TESTS_DIR, "annotations_diff12.txt")) as f: - expected_diff12 = f.read() - with open(os.path.join(CPP_TESTS_DIR, "annotations_diff13.txt")) as f: - expected_diff13 = f.read() - with open(os.path.join(CPP_TESTS_DIR, "annotations_diff23.txt")) as f: - expected_diff23 = f.read() + expected_diff12 = (CPP_TESTS_DIR / + "annotations_diff12.txt").read_text(encoding="utf-8") + expected_diff13 = (CPP_TESTS_DIR / + "annotations_diff13.txt").read_text(encoding="utf-8") + expected_diff23 = (CPP_TESTS_DIR / + "annotations_diff23.txt").read_text(encoding="utf-8") self.assertEqual(expected_diff12, diff12) self.assertEqual(expected_diff13, diff13) diff --git a/chromium/tools/traffic_annotation/scripts/extractor.py b/chromium/tools/traffic_annotation/scripts/extractor.py index 3bbb09f093e..0b28e7210dd 100755 --- a/chromium/tools/traffic_annotation/scripts/extractor.py +++ b/chromium/tools/traffic_annotation/scripts/extractor.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -10,37 +10,102 @@ Extracts network traffic annotation definitions from C++ source code. from __future__ import print_function import argparse -import os import re import sys import traceback from annotation_tools import NetworkTrafficAnnotationTools -from annotation_tokenizer import Tokenizer, CppParsingError +from annotation_tokenizer import Tokenizer, SourceCodeParsingError + +from enum import Enum +from pathlib import Path +from typing import List, Dict, NamedTuple + + +class AnnotationType(Enum): + COMPLETE = 'Definition' + PARTIAL = 'Partial' + COMPLETING = 'Completing' + BRANCHED_COMPLETING = 'BranchedCompleting' + MUTABLE = 'Mutable' + + +class Language(NamedTuple): + """Info on how to parse a given programming language's source code.""" + # Human-readable name, for debugging. + name: str + # Maps definition function names to the type of annotation they define. + annotation_types: Dict[str, AnnotationType] + # Regex that matches an annotation definition. Capture group 1 of this regex + # should contain a function name that can be mapped via annotation_types. + call_detection_regex: re.Pattern # Exit code for parsing errors. Other runtime errors return 1. EX_PARSE_ERROR = 2 -ANNOTATION_TYPES = { - 'DefineNetworkTrafficAnnotation': 'Definition', - 'DefinePartialNetworkTrafficAnnotation': 'Partial', - 'CompleteNetworkTrafficAnnotation': 'Completing', - 'BranchedCompleteNetworkTrafficAnnotation': 'BranchedCompleting', - 'CreateMutableNetworkTrafficAnnotationTag': 'Mutable', +# A regex that scans more quickly than the other regexen below, for +# pre-filtering. A first pass will check for these strings, and skip any files +# that don't contain them. Keep this regex simple, so it's fast. +# +# N.B.: this regex MUST match anything that would be matched by the other +# regexen below, or we will get false negatives (i.e., we will miss some +# annotations because pre-filtering is too strict). +PREFILTER_REGEX = re.compile(r''' + TrafficAnnotation | TRAFFIC_ANNOTATION +''', re.VERBOSE | re.IGNORECASE) + +# Language definition for C++ source files. +CPP_ANNOTATION_TYPES = { + 'DefineNetworkTrafficAnnotation': AnnotationType.COMPLETE, + 'DefinePartialNetworkTrafficAnnotation': AnnotationType.PARTIAL, + 'CompleteNetworkTrafficAnnotation': AnnotationType.COMPLETING, + 'BranchedCompleteNetworkTrafficAnnotation': + AnnotationType.BRANCHED_COMPLETING, + 'CreateMutableNetworkTrafficAnnotationTag': AnnotationType.MUTABLE, } -# Regex that matches an annotation definition. -CALL_DETECTION_REGEX = re.compile(r''' - \b - # Look for one of the tracked function names. - # Capture group 1. - ( - ''' + ('|'.join(ANNOTATION_TYPES.keys())) + r''' - ) - # Followed by a left-paren. - \s* - \( -''', re.VERBOSE | re.DOTALL) +CPP_LANGUAGE = Language(name='C++', + annotation_types=CPP_ANNOTATION_TYPES, + call_detection_regex=re.compile( + r''' + \b + # Look for one of the tracked function names. + # Capture group 1: function name. + ( + ''' + ('|'.join(CPP_ANNOTATION_TYPES.keys())) + r''' + ) + # Followed by a left-paren. + \s* + \( + ''', re.VERBOSE | re.DOTALL)) + +# Language definition for Java source files. +JAVA_ANNOTATION_TYPES = { + 'createComplete': AnnotationType.COMPLETE, +} + +JAVA_LANGUAGE = Language(name='Java', + annotation_types=JAVA_ANNOTATION_TYPES, + call_detection_regex=re.compile( + r''' + \b + # Look for a string like NetworkTrafficAnnotationTag.<methodName> + NetworkTrafficAnnotationTag \s* \. \s* + # Capture group 1: method name. + ( + ''' + ('|'.join(JAVA_ANNOTATION_TYPES.keys())) + r''' + ) + # Followed by a left-paren. + \s* + \( + ''', re.VERBOSE | re.DOTALL)) + +# Maps file extensions to their Language definition. +LANGUAGE_MAPPING: Dict[str, Language] = { + '.cc': CPP_LANGUAGE, + '.mm': CPP_LANGUAGE, + '.java': JAVA_LANGUAGE, +} # Regex that matches an annotation that should only be used in test files. TEST_ANNOTATION_REGEX = re.compile( @@ -53,17 +118,27 @@ MISSING_ANNOTATION_REGEX = re.compile(r'\bMISSING_TRAFFIC_ANNOTATION\b') # don't require Network Traffic Annotations compliance. (e.g. iOS) NO_ANNOTATION_REGEX = re.compile(r'\bNO_TRAFFIC_ANNOTATION_YET\b') +# List of supported file extensions for source code. +SUPPORTED_EXTENSIONS = set(LANGUAGE_MAPPING.keys()) + class Annotation: """A network annotation definition in C++ code.""" - def __init__(self, file_path, line_number, type_name='', unique_id='', - extra_id='', text=''): + def __init__(self, + language: Language, + file_path: Path, + line_number: int, + type_name: AnnotationType, + unique_id='', + extra_id='', + text=''): """Constructs an Annotation object with the given field values. Args: file_path: Path to the file that contains this annotation. """ + self.language = language self.file_path = file_path self.line_number = line_number self.type_name = type_name @@ -71,15 +146,14 @@ class Annotation: self.extra_id = extra_id self.text = text - def parse_definition(self, re_match): + def parse_definition(self, re_match: re.Match): """Parses the annotation and populates object fields. Args: - file_path: Path to the file that contains this annotation. - re_match: A MatchObject obtained from CALL_DETECTION_REGEX. + re_match: A Match obtained from the Language's call_detection_regex. """ definition_function = re_match.group(1) - self.type_name = ANNOTATION_TYPES[definition_function] + self.type_name = self.language.annotation_types[definition_function] # Parse the arguments given to the definition function, populating # |unique_id|, |text| and (possibly) |extra_id|. @@ -87,39 +161,44 @@ class Annotation: self._parse_body(body) - def extractor_output_string(self): + def extractor_output_string(self) -> str: """Returns a string formatted for output.""" - return "\n".join(map(str, [ - "==== NEW ANNOTATION ====", - self.file_path, - self.line_number, - self.type_name, - self.unique_id, - self.extra_id, - self.text, - "==== ANNOTATION ENDS ====", - ])) - - def _parse_body(self, body): + return '\n'.join( + map(str, [ + '==== NEW ANNOTATION ====', + self.file_path, + self.line_number, + self.type_name.value, + self.unique_id, + self.extra_id, + self.text, + '==== ANNOTATION ENDS ====', + ])) + + def _parse_body(self, body: str): """Tokenizes and parses the arguments given to the definition function.""" # Don't bother parsing CreateMutableNetworkTrafficAnnotationTag(), we don't # care about its arguments anyways. - if self.type_name == 'Mutable': + if self.type_name == AnnotationType.MUTABLE: return tokenizer = Tokenizer(body, self.file_path, self.line_number) # unique_id - self.unique_id = tokenizer.advance('string_literal') + self.unique_id = self._parse_string(tokenizer) tokenizer.advance('comma') # extra_id (Partial/BranchedCompleting) - if self.type_name == 'Partial' or self.type_name == 'BranchedCompleting': - self.extra_id = tokenizer.advance('string_literal') + if self.type_name in [ + AnnotationType.PARTIAL, AnnotationType.BRANCHED_COMPLETING + ]: + self.extra_id = self._parse_string(tokenizer) tokenizer.advance('comma') # partial_annotation (Completing/BranchedCompleting) - if self.type_name == 'Completing' or self.type_name == 'BranchedCompleting': + if self.type_name in [ + AnnotationType.COMPLETING, AnnotationType.BRANCHED_COMPLETING + ]: # Skip the |partial_annotation| argument. It can be a variable_name, or a # FunctionName(), so skip the parentheses if they're there. tokenizer.advance('symbol') @@ -128,11 +207,26 @@ class Annotation: tokenizer.advance('comma') # proto text - self.text = tokenizer.advance('string_literal') + self.text = self._parse_string(tokenizer) # The function call should end here without any more arguments. assert tokenizer.advance('right_paren') + def _parse_string(self, tokenizer: Tokenizer) -> str: + """Parse a string value. + + It could be a string literal by itself, or multiple string literals + concatenated together. Add a newline to the string for each + concatenation.""" + text = tokenizer.advance('string_literal') + while True: + # Perform concatenations. + if tokenizer.maybe_advance('plus') is None: + break + text += '\n' + text += tokenizer.advance('string_literal') + return text + def get_line_number_at(string, pos): """Find the line number for the char at position |pos|. 1-indexed.""" @@ -159,26 +253,34 @@ def is_inside_comment(string, pos): # TODO(crbug/966883): Add multi-line comment support. -def extract_annotations(file_path): +def may_contain_annotations(file_path: Path) -> bool: + """Returns False if |file_path| is guaranteed not to contain annotations. + + This runs much faster than extract_annotations(), and is meant for + pre-filtering. If this returns True, then |file_path| *might* contain + annotations. Call extract_annotations() to know for sure.""" + return bool(PREFILTER_REGEX.search(file_path.read_text(encoding="utf-8"))) + + +def extract_annotations(file_path: Path) -> List[Annotation]: """Extracts and returns annotations from the file at |file_path|.""" - if sys.version_info.major >= 3: - # In Python 3, contents is a unicode string decoded from UTF-8 file - # contents. - with open(file_path, encoding="utf-8") as f: - contents = f.read() - else: - # In Python 2, contents is a byte-string. - with open(file_path) as f: - contents = f.read() + if file_path.suffix not in LANGUAGE_MAPPING: + raise ValueError("Unrecognized extension '{}' for file '{}'.".format( + file_path.suffix, str(file_path))) + + language = LANGUAGE_MAPPING[file_path.suffix] + + contents = file_path.read_text(encoding="utf-8") defs = [] # Check for function calls (e.g. DefineNetworkTrafficAnnotation(...)) - for re_match in CALL_DETECTION_REGEX.finditer(contents): + for re_match in language.call_detection_regex.finditer(contents): if is_inside_comment(re_match.string, re_match.start()): continue line_number = get_line_number_at(contents, re_match.start()) - annotation = Annotation(file_path, line_number) + annotation = Annotation(language, file_path, line_number, + AnnotationType.COMPLETE) annotation.parse_definition(re_match) defs.append(annotation) @@ -190,17 +292,21 @@ def extract_annotations(file_path): is_partial = bool(re_match.group(1)) if is_partial: - type_name = 'Partial' + type_name = AnnotationType.PARTIAL unique_id = 'test_partial' extra_id = 'test' else: - type_name = 'Definition' + type_name = AnnotationType.COMPLETE unique_id = 'test' extra_id = '' annotation = Annotation( - file_path, line_number, type_name=type_name, - unique_id=unique_id, extra_id=extra_id, + language, + file_path, + line_number, + type_name=type_name, + unique_id=unique_id, + extra_id=extra_id, text='Traffic annotation for unit, browser and other tests') defs.append(annotation) @@ -210,9 +316,12 @@ def extract_annotations(file_path): continue line_number = get_line_number_at(contents, re_match.start()) - annotation = Annotation( - file_path, line_number, type_name='Definition', unique_id='missing', - text='Function called without traffic annotation.') + annotation = Annotation(language, + file_path, + line_number, + type_name=AnnotationType.COMPLETE, + unique_id='missing', + text='Function called without traffic annotation.') defs.append(annotation) # Check for NO_TRAFFIC_ANNOTATION_YET. @@ -221,9 +330,10 @@ def extract_annotations(file_path): continue line_number = get_line_number_at(contents, re_match.start()) - annotation = Annotation(file_path, + annotation = Annotation(language, + file_path, line_number, - type_name='Definition', + type_name=AnnotationType.COMPLETE, unique_id='undefined', text='Nothing here yet.') defs.append(annotation) @@ -233,15 +343,16 @@ def extract_annotations(file_path): def main(): parser = argparse.ArgumentParser() - parser.add_argument( - '--options-file', - help='optional file to read options from') + parser.add_argument('--options-file', + type=Path, + help='optional file to read options from') args, argv = parser.parse_known_args() - if args.options_file: - argv = open(args.options_file).read().split() + if args.options_file is not None: + argv = args.options_file.read_text(encoding="utf-8").split() parser.add_argument( '--build-path', + type=Path, help='Specifies a compiled build directory, e.g. out/Debug.') parser.add_argument( '--generate-compdb', action='store_true', @@ -249,24 +360,27 @@ def main(): parser.add_argument( '--no-filter', action='store_true', help='Do not filter files based on compdb entries') - parser.add_argument( - 'file_paths', nargs='+', help='List of files to process.') + parser.add_argument('file_paths', + nargs='+', + type=Path, + help='List of files to process.') args = parser.parse_args(argv) - tools = NetworkTrafficAnnotationTools(args.build_path) - compdb_files = tools.GetCompDBFiles(args.generate_compdb) + if not args.no_filter: + tools = NetworkTrafficAnnotationTools(args.build_path) + compdb_files = tools.GetCompDBFiles(args.generate_compdb) annotation_definitions = [] # Parse all the files. # TODO(crbug/966883): Do this in parallel. for file_path in args.file_paths: - if not args.no_filter and os.path.abspath(file_path) not in compdb_files: + if not args.no_filter and file_path.resolve() not in compdb_files: continue try: annotation_definitions.extend(extract_annotations(file_path)) - except CppParsingError: + except SourceCodeParsingError: traceback.print_exc() return EX_PARSE_ERROR diff --git a/chromium/tools/traffic_annotation/scripts/extractor_test.py b/chromium/tools/traffic_annotation/scripts/extractor_test.py index 9a847210f28..571ef8b0f13 100755 --- a/chromium/tools/traffic_annotation/scripts/extractor_test.py +++ b/chromium/tools/traffic_annotation/scripts/extractor_test.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright 2019 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -10,32 +10,40 @@ Unit tests for extractor.py. from __future__ import print_function import argparse -import glob import os import unittest import re import subprocess +from glob import glob +from pathlib import Path +from typing import Tuple -def run_extractor(file, *extra_args): - script_path = os.path.join('..', 'extractor.py') - cmd_line = ("python", script_path, '--no-filter', file) + extra_args +# Path to the directory where this script is. +SCRIPT_DIR = Path(__file__).resolve().parent + + +def run_extractor(file_path: Path) -> Tuple[bytes, bytes]: + script_path = Path('../extractor.py') + cmd_line = ('python3', str(script_path), '--no-filter', file_path) return subprocess.Popen( cmd_line, stdout=subprocess.PIPE, stderr=subprocess.PIPE) -def get_expected_files(source_file): - stdout_file = re.sub(r'\.cc$', '-stdout.txt', source_file) - stderr_file = re.sub(r'\.cc$', '-stderr.txt', source_file) +def get_expected_files(source_file: Path) -> Path: + stdout_file = (source_file.with_stem('%s-stdout' % + source_file.stem).with_suffix('.txt')) + stderr_file = (source_file.with_stem('%s-stderr' % + source_file.stem).with_suffix('.txt')) return (stdout_file, stderr_file) -def dos2unix(str): - """Convers CRLF to LF.""" - return str.replace('\r\n', '\n') +def dos2unix(body: str): + """Converts CRLF to LF.""" + return body.replace('\r\n', '\n') -def remove_tracebacks(str): +def remove_tracebacks(body: str): """Removes python tracebacks from the string.""" regex = re.compile( r''' @@ -44,24 +52,23 @@ def remove_tracebacks(str): # Followed by lines that begin with whitespace. ((\s.*)?\n)*''', re.MULTILINE | re.VERBOSE) - return re.sub(regex, '', str) + return re.sub(regex, '', body) class ExtractorTest(unittest.TestCase): def testExtractor(self): - for source_file in glob.glob('*.cc'): - if source_file.startswith('test_'): + files = list(Path(f) for f in glob('*.cc') + glob('*.java')) + for source_file in files: + if source_file.stem.startswith('test_'): continue print("Running test on %s..." % source_file) (stdout_file, stderr_file) = get_expected_files(source_file) - with open(stdout_file) as f: - expected_stdout = dos2unix(f.read()) - with open(stderr_file) as f: - expected_stderr = dos2unix(f.read()) + expected_stdout = dos2unix(stdout_file.read_text()) + expected_stderr = dos2unix(stderr_file.read_text()) proc = run_extractor(source_file) - (stdout, stderr) = map(dos2unix, proc.communicate()) + (stdout, stderr) = (dos2unix(b.decode()) for b in proc.communicate()) self.assertEqual(expected_stderr, remove_tracebacks(stderr)) expected_returncode = 2 if expected_stderr else 0 @@ -70,15 +77,15 @@ class ExtractorTest(unittest.TestCase): def generate_expected_files(): - for source_file in glob.glob('*.cc'): + files = list(Path(f) + for f in glob('*.java')) # glob('*.cc') + glob('*.java')) + for source_file in files: proc = run_extractor(source_file) - (stdout, stderr) = proc.communicate() + (stdout, stderr) = (b.decode() for b in proc.communicate()) (stdout_file, stderr_file) = get_expected_files(source_file) - with open(stdout_file, "w") as f: - f.write(stdout) - with open(stderr_file, "w") as f: - f.write(remove_tracebacks(stderr)) + stdout_file.write_text(stdout) + stderr_file.write_text(stderr) if __name__ == '__main__': @@ -90,12 +97,13 @@ if __name__ == '__main__': args = parser.parse_args() # Set directory for both test and gen command to the test_data folder. - os.chdir(os.path.join(os.path.dirname(__file__), 'test_data')) + os.chdir(Path(__file__).resolve().parent / 'test_data') - # Run the extractor script with --generate-compdb to ensure the - # compile_commands.json file exists in the default output directory. - proc = run_extractor(os.devnull, '--generate-compdb') - proc.communicate() # Wait until extractor finishes running. + # XXX + # # Run the extractor script with --generate-compdb to ensure the + # # compile_commands.json file exists in the default output directory. + # proc = run_extractor(os.devnull, '--generate-compdb') + # proc.communicate() # Wait until extractor finishes running. if args.generate_expected_files: generate_expected_files() diff --git a/chromium/tools/traffic_annotation/scripts/test_data/ValidFile-stderr.txt b/chromium/tools/traffic_annotation/scripts/test_data/ValidFile-stderr.txt new file mode 100644 index 00000000000..e69de29bb2d --- /dev/null +++ b/chromium/tools/traffic_annotation/scripts/test_data/ValidFile-stderr.txt diff --git a/chromium/tools/traffic_annotation/scripts/test_data/ValidFile-stdout.txt b/chromium/tools/traffic_annotation/scripts/test_data/ValidFile-stdout.txt new file mode 100644 index 00000000000..7eb4b687a63 --- /dev/null +++ b/chromium/tools/traffic_annotation/scripts/test_data/ValidFile-stdout.txt @@ -0,0 +1,48 @@ +==== NEW ANNOTATION ==== +ValidFile.java +13 +Definition +id1 + +semantics { +sender: 'sender1' +description: 'desc1' +trigger: 'trigger1' +data: 'data1' +destination: GOOGLE_OWNED_SERVICE +} +policy { +cookies_allowed: NO +setting: 'setting1' +chrome_policy { +SpellCheckServiceEnabled { +SpellCheckServiceEnabled: false +} +} +} +comments: 'comment1' +==== ANNOTATION ENDS ==== +==== NEW ANNOTATION ==== +ValidFile.java +40 +Definition +test + +Traffic annotation for unit, browser and other tests +==== ANNOTATION ENDS ==== +==== NEW ANNOTATION ==== +ValidFile.java +39 +Definition +missing + +Function called without traffic annotation. +==== ANNOTATION ENDS ==== +==== NEW ANNOTATION ==== +ValidFile.java +38 +Definition +undefined + +Nothing here yet. +==== ANNOTATION ENDS ==== diff --git a/chromium/tools/traffic_annotation/scripts/test_data/ValidFile.java b/chromium/tools/traffic_annotation/scripts/test_data/ValidFile.java new file mode 100644 index 00000000000..3df6c946140 --- /dev/null +++ b/chromium/tools/traffic_annotation/scripts/test_data/ValidFile.java @@ -0,0 +1,41 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +// This file provides samples for testing the extractor.py script. + +/** + * Example class that contains a NetworkTrafficAnnotationTag definition. + */ +public class ValidFile { + private static final NetworkTrafficAnnotationTag TRAFFIC_ANNOTATION = + NetworkTrafficAnnotationTag.createComplete("id1", + "semantics {" + + "sender: 'sender1'" + + "description: 'desc1'" + + "trigger: 'trigger1'" + + "data: 'data1'" + + "destination: GOOGLE_OWNED_SERVICE" + + "}" + + "policy {" + + "cookies_allowed: NO" + + "setting: 'setting1'" + + "chrome_policy {" + + "SpellCheckServiceEnabled {" + + "SpellCheckServiceEnabled: false" + + "}" + + "}" + + "}" + + "comments: 'comment1'"); + + private void doSomethingWith(NetworkTrafficAnnotationTag annotation) { + // ... + } + + public void fooBar() { + doSomethingWith(TRAFFIC_ANNOTATION); + doSomethingWith(NetworkTrafficAnnotationTag.NO_TRAFFIC_ANNOTATION_YET); + doSomethingWith(NetworkTrafficAnnotationTag.MISSING_TRAFFIC_ANNOTATION); + doSomethingWith(NetworkTrafficAnnotationTag.TRAFFIC_ANNOTATION_FOR_TESTS); + } +} diff --git a/chromium/tools/traffic_annotation/scripts/test_data/too_few_args-stderr.txt b/chromium/tools/traffic_annotation/scripts/test_data/too_few_args-stderr.txt index 5bd69a7b1e2..98055845b18 100644 --- a/chromium/tools/traffic_annotation/scripts/test_data/too_few_args-stderr.txt +++ b/chromium/tools/traffic_annotation/scripts/test_data/too_few_args-stderr.txt @@ -1,3 +1,3 @@ -CppParsingError: Expected comma in annotation definition at too_few_args.cc:8. +annotation_tokenizer.SourceCodeParsingError: Expected comma in annotation definition at too_few_args.cc:8. near '); ' diff --git a/chromium/tools/traffic_annotation/scripts/test_data/wrong_arg_type-stderr.txt b/chromium/tools/traffic_annotation/scripts/test_data/wrong_arg_type-stderr.txt index d0c93d752d8..f197a0c0c4b 100644 --- a/chromium/tools/traffic_annotation/scripts/test_data/wrong_arg_type-stderr.txt +++ b/chromium/tools/traffic_annotation/scripts/test_data/wrong_arg_type-stderr.txt @@ -1,2 +1,2 @@ -CppParsingError: Expected string_literal in annotation definition at wrong_arg_type.cc:8. +annotation_tokenizer.SourceCodeParsingError: Expected string_literal in annotation definition at wrong_arg_type.cc:8. near 'should_be_a_string_l' diff --git a/chromium/tools/traffic_annotation/summary/annotations.xml b/chromium/tools/traffic_annotation/summary/annotations.xml index d2f3cff209f..abdd2ff4b15 100644 --- a/chromium/tools/traffic_annotation/summary/annotations.xml +++ b/chromium/tools/traffic_annotation/summary/annotations.xml @@ -13,6 +13,8 @@ Refer to README.md for content description and update process. <item id="adb_client_socket" added_in_milestone="65" hash_code="87775794" type="0" content_hash_code="56654828" os_list="linux,windows" file_path="chrome/browser/devtools/device/adb/adb_client_socket.cc"/> <item id="affiliation_lookup" added_in_milestone="62" hash_code="111904019" type="0" deprecated="2021-07-27" content_hash_code="81061452" file_path=""/> <item id="affiliation_lookup_by_hash" added_in_milestone="87" hash_code="57748571" type="0" content_hash_code="40566404" os_list="linux,windows" file_path="components/password_manager/core/browser/site_affiliation/hash_affiliation_fetcher.cc"/> + <item id="aggregation_service_helper_keys" added_in_milestone="96" hash_code="49783589" type="0" content_hash_code="68319105" os_list="linux,windows" file_path="content/browser/aggregation_service/aggregation_service_network_fetcher_impl.cc"/> + <item id="aggregation_service_report" added_in_milestone="95" hash_code="95942194" type="0" content_hash_code="44673922" os_list="linux,windows" file_path="content/browser/aggregation_service/aggregatable_report_sender.cc"/> <item id="android_device_manager_socket" added_in_milestone="65" hash_code="37249086" type="0" content_hash_code="6436865" os_list="linux,windows" file_path="chrome/browser/devtools/device/android_device_manager.cc"/> <item id="android_web_socket" added_in_milestone="65" hash_code="39356976" type="0" content_hash_code="12310113" os_list="linux,windows" file_path="chrome/browser/devtools/device/android_web_socket.cc"/> <item id="appcache_update_job" added_in_milestone="62" hash_code="25790702" type="0" content_hash_code="27424887" os_list="linux,windows" file_path="content/browser/appcache/appcache_update_url_loader_request.cc"/> @@ -25,7 +27,6 @@ Refer to README.md for content description and update process. <item id="backdrop_collection_names_download" added_in_milestone="68" hash_code="49246286" type="0" content_hash_code="93501319" os_list="linux,windows" file_path="chrome/browser/search/background/ntp_background_service.cc"/> <item id="backdrop_next_image_download" added_in_milestone="77" hash_code="7754485" type="0" content_hash_code="98537970" os_list="linux,windows" file_path="chrome/browser/search/background/ntp_background_service.cc"/> <item id="background_fetch_context" added_in_milestone="62" hash_code="16469669" type="0" content_hash_code="52235434" os_list="linux,windows" file_path="content/browser/background_fetch/background_fetch_delegate_proxy.cc"/> - <item id="background_performance_tracer" added_in_milestone="62" hash_code="84575287" type="0" content_hash_code="120154250" os_list="linux,windows" file_path="chrome/browser/tracing/crash_service_uploader.cc"/> <item id="bidirectional_stream" added_in_milestone="67" hash_code="108665132" type="0" content_hash_code="130038340" os_list="linux,windows" file_path="net/http/bidirectional_stream.cc"/> <item id="blink_extension_resource_loader" added_in_milestone="63" hash_code="84165821" type="0" content_hash_code="63536185" os_list="linux,windows" file_path="third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc"/> <item id="blink_resource_loader" added_in_milestone="62" hash_code="101845102" type="0" content_hash_code="75331172" os_list="linux,windows" file_path="third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc"/> @@ -63,7 +64,7 @@ Refer to README.md for content description and update process. <item id="content_hash_verification_job" added_in_milestone="62" hash_code="64733114" type="0" content_hash_code="127912411" os_list="linux,windows" file_path="extensions/browser/content_hash_fetcher.cc"/> <item id="content_resource_fetcher" added_in_milestone="63" hash_code="70796791" type="0" deprecated="2017-09-16" content_hash_code="135648626" file_path=""/> <item id="content_suggestion_get_favicon" added_in_milestone="62" hash_code="16653985" type="0" content_hash_code="134280933" os_list="linux,windows" file_path="components/ntp_snippets/content_suggestions_service.cc"/> - <item id="conversion_measurement_report" added_in_milestone="84" hash_code="113422320" type="0" content_hash_code="60688877" os_list="linux,windows" file_path="content/browser/conversions/conversion_network_sender_impl.cc"/> + <item id="conversion_measurement_report" added_in_milestone="84" hash_code="113422320" type="0" content_hash_code="102111798" os_list="linux,windows" file_path="content/browser/attribution_reporting/attribution_network_sender_impl.cc"/> <item id="credenential_avatar" added_in_milestone="62" hash_code="53695122" type="0" content_hash_code="113035371" os_list="linux,windows" file_path="chrome/browser/ui/passwords/account_avatar_fetcher.cc"/> <item id="cros_recovery_image_download" added_in_milestone="62" hash_code="101725581" type="0" content_hash_code="10999698" os_list="linux,windows" file_path="chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc"/> <item id="cryptauth_device_sync_tickle" added_in_milestone="62" hash_code="96565489" type="1" second_id="29188932" deprecated="2018-03-15" content_hash_code="115714668" file_path=""/> @@ -178,7 +179,7 @@ Refer to README.md for content description and update process. <item id="kids_chrome_management_client_classify_url" added_in_milestone="77" hash_code="109987793" type="0" deprecated="2019-07-30" content_hash_code="112740597" file_path=""/> <item id="lib_address_input" added_in_milestone="62" hash_code="50816767" type="0" content_hash_code="57977576" os_list="linux,windows" file_path="third_party/libaddressinput/chromium/chrome_metadata_source.cc"/> <item id="litepages_robots_rules" added_in_milestone="89" hash_code="50910588" type="0" content_hash_code="72567080" os_list="linux,windows" file_path="chrome/browser/subresource_redirect/origin_robots_rules.cc"/> - <item id="load_autofill_gstatic_data" added_in_milestone="78" hash_code="119416099" type="0" content_hash_code="8433621" os_list="linux,windows" file_path="chrome/browser/autofill/autofill_gstatic_reader.cc"/> + <item id="load_autofill_gstatic_data" added_in_milestone="78" hash_code="119416099" type="0" content_hash_code="128051538" os_list="linux,windows" file_path="chrome/browser/autofill/autofill_gstatic_reader.cc"/> <item id="logo_service" added_in_milestone="73" hash_code="35473769" type="0" content_hash_code="20271299" os_list="linux,windows" file_path="components/search_provider_logos/logo_service_impl.cc"/> <item id="logo_tracker" added_in_milestone="62" hash_code="36859107" type="0" deprecated="2018-12-07" content_hash_code="67588075" file_path=""/> <item id="lookup_single_password_leak" added_in_milestone="78" hash_code="16927377" type="0" content_hash_code="12158296" os_list="linux,windows" file_path="components/password_manager/core/browser/leak_detection/leak_detection_request.cc"/> @@ -214,7 +215,7 @@ Refer to README.md for content description and update process. <item id="ocsp_start_url_request" added_in_milestone="62" hash_code="60921996" type="0" deprecated="2020-04-28" content_hash_code="6288676" file_path=""/> <item id="offline_prefetch" added_in_milestone="62" hash_code="19185953" type="0" content_hash_code="112039446" os_list="linux,windows" file_path="components/offline_pages/core/prefetch/prefetch_request_fetcher.cc"/> <item id="omnibox_documentsuggest" added_in_milestone="69" hash_code="6055066" type="0" content_hash_code="126973249" os_list="linux,windows" file_path="components/omnibox/browser/document_suggestions_service.cc"/> - <item id="omnibox_navigation_observer" added_in_milestone="62" hash_code="61684939" type="0" content_hash_code="2642036" os_list="linux,windows" file_path="chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc"/> + <item id="omnibox_navigation_observer" added_in_milestone="62" hash_code="61684939" type="0" content_hash_code="70941231" os_list="linux,windows" file_path="chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc"/> <item id="omnibox_result_change" added_in_milestone="62" hash_code="73107389" type="0" content_hash_code="24802647" os_list="linux,windows" file_path="chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc"/> <item id="omnibox_suggest" added_in_milestone="62" hash_code="47815025" type="0" content_hash_code="86297726" os_list="linux,windows" file_path="components/omnibox/browser/search_provider.cc"/> <item id="omnibox_suggest_deletion" added_in_milestone="62" hash_code="84212388" type="0" content_hash_code="24981550" os_list="linux,windows" file_path="components/omnibox/browser/base_search_provider.cc"/> @@ -304,7 +305,7 @@ Refer to README.md for content description and update process. <item id="safe_browsing_feedback" added_in_milestone="62" hash_code="44583821" type="0" content_hash_code="27116846" os_list="linux,windows" file_path="chrome/browser/safe_browsing/download_protection/download_feedback.cc"/> <item id="safe_browsing_get_full_hash" added_in_milestone="62" hash_code="68745894" type="0" deprecated="2018-08-14" content_hash_code="21739198" file_path=""/> <item id="safe_browsing_incident" added_in_milestone="62" hash_code="124950347" type="0" content_hash_code="7306531" os_list="linux,windows" file_path="chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc"/> - <item id="safe_browsing_module_loader" added_in_milestone="62" hash_code="6019475" type="0" content_hash_code="49511650" os_list="linux,windows" file_path="components/safe_browsing/content/browser/client_side_model_loader.cc"/> + <item id="safe_browsing_module_loader" added_in_milestone="62" hash_code="6019475" type="0" deprecated="2021-10-01" content_hash_code="49511650" file_path=""/> <item id="safe_browsing_realtime_url_lookup" added_in_milestone="78" hash_code="119324658" type="0" content_hash_code="71236226" os_list="linux,windows" file_path="components/safe_browsing/core/browser/realtime/url_lookup_service.cc"/> <item id="safe_browsing_v4_get_hash" added_in_milestone="62" hash_code="8561691" type="0" content_hash_code="132435617" os_list="linux,windows" file_path="components/safe_browsing/core/browser/db/v4_get_hash_protocol_manager.cc"/> <item id="safe_browsing_v4_update" added_in_milestone="70" hash_code="82509217" type="0" content_hash_code="5247849" os_list="linux,windows" file_path="components/safe_browsing/core/browser/db/v4_update_protocol_manager.cc"/> @@ -315,13 +316,14 @@ Refer to README.md for content description and update process. <item id="sct_auditing" added_in_milestone="87" hash_code="48603483" type="0" content_hash_code="43567503" os_list="linux,windows" file_path="chrome/browser/ssl/sct_reporting_service.cc"/> <item id="sdch_dictionary_fetch" added_in_milestone="62" hash_code="47152935" type="0" deprecated="2017-09-16" content_hash_code="16764294" file_path=""/> <item id="search_prefetch_service" added_in_milestone="88" hash_code="108986091" type="0" content_hash_code="125257414" os_list="windows,linux" file_path="chrome/browser/prefetch/search_prefetch/base_search_prefetch_request.cc"/> - <item id="search_suggest_service" added_in_milestone="73" hash_code="57785193" type="0" content_hash_code="132247652" os_list="linux,windows" file_path="chrome/browser/search/search_suggest/search_suggest_loader_impl.cc"/> + <item id="search_suggest_service" added_in_milestone="73" hash_code="57785193" type="0" deprecated="2021-09-02" content_hash_code="132247652" file_path=""/> <item id="security_key_socket" added_in_milestone="66" hash_code="31074955" type="0" content_hash_code="13741232" os_list="linux,windows" file_path="remoting/host/security_key/security_key_socket.cc"/> <item id="send_message_express" added_in_milestone="85" hash_code="23527666" type="0" deprecated="2020-09-21" content_hash_code="96850228" file_path=""/> <item id="service_worker_navigation_preload" added_in_milestone="63" hash_code="129872904" type="0" content_hash_code="79473248" os_list="linux,windows" file_path="content/browser/service_worker/service_worker_fetch_dispatcher.cc"/> <item id="service_worker_script_load" added_in_milestone="90" hash_code="21498113" type="0" content_hash_code="56275791" os_list="linux,windows" file_path="content/browser/service_worker/service_worker_new_script_fetcher.cc"/> <item id="service_worker_update_checker" added_in_milestone="71" hash_code="130931413" type="0" content_hash_code="32441998" os_list="linux,windows" file_path="content/browser/service_worker/service_worker_single_script_update_checker.cc"/> <item id="services_http_server_error_response" added_in_milestone="68" hash_code="59302801" type="0" content_hash_code="127774041" os_list="linux,windows" file_path="services/network/public/cpp/server/http_server.cc"/> + <item id="shared_storage_worklet_module_script_downloader" added_in_milestone="95" hash_code="79084529" type="0" content_hash_code="57126817" os_list="linux,windows" file_path="content/services/shared_storage_worklet/module_script_downloader.cc"/> <item id="sigined_exchange_cert_fetcher" added_in_milestone="66" hash_code="79442849" type="0" content_hash_code="8138156" os_list="linux,windows" file_path="content/browser/web_package/signed_exchange_cert_fetcher.cc"/> <item id="sigined_exchange_validity_pinger" added_in_milestone="75" hash_code="57114284" type="0" content_hash_code="119482488" os_list="linux,windows" file_path="content/browser/web_package/signed_exchange_validity_pinger.cc"/> <item id="signed_in_profile_avatar" added_in_milestone="62" hash_code="108903331" type="0" content_hash_code="72850619" os_list="linux,windows" file_path="chrome/browser/profiles/profile_downloader.cc"/> diff --git a/chromium/tools/traffic_annotation/summary/annotations_android.xml b/chromium/tools/traffic_annotation/summary/annotations_android.xml new file mode 100644 index 00000000000..31d1caeb4ed --- /dev/null +++ b/chromium/tools/traffic_annotation/summary/annotations_android.xml @@ -0,0 +1,406 @@ +<?xml version="1.0"?> +<!-- +Copyright 2017 The Chromium Authors. All rights reserved. +Use of this source code is governed by a BSD-style license that can be +found in the LICENSE file. + +Refer to README.md for content description and update process. +--> + +<annotations> + <item id="CRD_relay_session_request" added_in_milestone="62" hash_code="24058523" type="0" deprecated="2019-07-22" content_hash_code="36997811" file_path=""/> + <item id="accounts_image_fetcher" added_in_milestone="66" hash_code="98658519" type="0" content_hash_code="45432230" os_list="linux,windows,android" file_path="components/signin/internal/identity_manager/account_fetcher_service.cc"/> + <item id="adb_client_socket" added_in_milestone="65" hash_code="87775794" type="0" content_hash_code="56654828" os_list="linux,windows" file_path="chrome/browser/devtools/device/adb/adb_client_socket.cc"/> + <item id="affiliation_lookup" added_in_milestone="62" hash_code="111904019" type="0" deprecated="2021-07-27" content_hash_code="81061452" file_path=""/> + <item id="affiliation_lookup_by_hash" added_in_milestone="87" hash_code="57748571" type="0" content_hash_code="40566404" os_list="linux,windows,android" file_path="components/password_manager/core/browser/site_affiliation/hash_affiliation_fetcher.cc"/> + <item id="aggregation_service_report" added_in_milestone="95" hash_code="95942194" type="0" content_hash_code="44673922" os_list="linux,windows,android" file_path="content/browser/aggregation_service/aggregatable_report_sender.cc"/> + <item id="android_device_manager_socket" added_in_milestone="65" hash_code="37249086" type="0" content_hash_code="6436865" os_list="linux,windows" file_path="chrome/browser/devtools/device/android_device_manager.cc"/> + <item id="android_web_socket" added_in_milestone="65" hash_code="39356976" type="0" content_hash_code="12310113" os_list="linux,windows" file_path="chrome/browser/devtools/device/android_web_socket.cc"/> + <item id="appcache_update_job" added_in_milestone="62" hash_code="25790702" type="0" content_hash_code="27424887" os_list="linux,windows,android" file_path="content/browser/appcache/appcache_update_url_loader_request.cc"/> + <item id="auction_downloader" added_in_milestone="92" hash_code="27833508" type="0" content_hash_code="118747666" os_list="linux,windows,android" file_path="content/services/auction_worklet/auction_downloader.cc"/> + <item id="auction_report_sender" added_in_milestone="92" hash_code="96136865" type="0" content_hash_code="62368950" os_list="linux,windows,android" file_path="content/browser/interest_group/ad_auction_service_impl.cc"/> + <item id="autofill_image_fetcher_card_art_image" added_in_milestone="93" hash_code="90561372" type="0" content_hash_code="24622412" os_list="linux,windows,android" file_path="components/autofill/core/browser/ui/autofill_image_fetcher.cc"/> + <item id="autofill_query" added_in_milestone="62" hash_code="88863520" type="0" content_hash_code="15563339" os_list="linux,windows,android" file_path="components/autofill/core/browser/autofill_download_manager.cc"/> + <item id="autofill_upload" added_in_milestone="62" hash_code="104798869" type="0" content_hash_code="110634763" os_list="linux,windows,android" file_path="components/autofill/core/browser/autofill_download_manager.cc"/> + <item id="backdrop_collection_images_download" added_in_milestone="68" hash_code="34767164" type="0" content_hash_code="62971406" os_list="linux,windows" file_path="chrome/browser/search/background/ntp_background_service.cc"/> + <item id="backdrop_collection_names_download" added_in_milestone="68" hash_code="49246286" type="0" content_hash_code="93501319" os_list="linux,windows" file_path="chrome/browser/search/background/ntp_background_service.cc"/> + <item id="backdrop_next_image_download" added_in_milestone="77" hash_code="7754485" type="0" content_hash_code="98537970" os_list="linux,windows" file_path="chrome/browser/search/background/ntp_background_service.cc"/> + <item id="background_fetch_context" added_in_milestone="62" hash_code="16469669" type="0" content_hash_code="52235434" os_list="linux,windows,android" file_path="content/browser/background_fetch/background_fetch_delegate_proxy.cc"/> + <item id="background_performance_tracer" added_in_milestone="62" hash_code="84575287" type="0" content_hash_code="120154250" os_list="linux,windows,android" file_path="chrome/browser/tracing/crash_service_uploader.cc"/> + <item id="bidirectional_stream" added_in_milestone="67" hash_code="108665132" type="0" content_hash_code="130038340" os_list="linux,windows,android" file_path="net/http/bidirectional_stream.cc"/> + <item id="blink_extension_resource_loader" added_in_milestone="63" hash_code="84165821" type="0" content_hash_code="63536185" os_list="linux,windows,android" file_path="third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc"/> + <item id="blink_resource_loader" added_in_milestone="62" hash_code="101845102" type="0" content_hash_code="75331172" os_list="linux,windows,android" file_path="third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc"/> + <item id="blob_read" added_in_milestone="62" hash_code="112303907" type="0" deprecated="2019-08-09" content_hash_code="135449692" file_path=""/> + <item id="blob_reader" added_in_milestone="62" hash_code="5154306" type="0" deprecated="2018-06-14" content_hash_code="39702178" file_path=""/> + <item id="bluetooth_socket" added_in_milestone="65" hash_code="94099818" type="0" content_hash_code="30932349" os_list="linux,windows,android" file_path="device/bluetooth/bluetooth_socket_net.cc"/> + <item id="box_access_token_fetcher" added_in_milestone="89" hash_code="90263263" type="0" content_hash_code="120150044" os_list="linux,windows" file_path="chrome/browser/enterprise/connectors/file_system/access_token_fetcher.cc"/> + <item id="brandcode_config" added_in_milestone="62" hash_code="109679553" type="0" content_hash_code="128843792" os_list="linux,windows" file_path="chrome/browser/profile_resetter/brandcode_config_fetcher.cc"/> + <item id="browser_switcher_ieem_sitelist" added_in_milestone="72" hash_code="97159948" type="0" content_hash_code="129062966" os_list="linux,windows" file_path="chrome/browser/browser_switcher/browser_switcher_service.cc"/> + <item id="cablev2_websocket_from_authenticator" added_in_milestone="87" hash_code="28613769" type="0" content_hash_code="119863612" os_list="linux,windows,android" file_path="device/fido/cable/v2_authenticator.cc"/> + <item id="cablev2_websocket_from_client" added_in_milestone="86" hash_code="3464399" type="0" content_hash_code="116618103" os_list="windows,linux" file_path="device/fido/cable/fido_tunnel_device.cc"/> + <item id="captive_portal_service" added_in_milestone="62" hash_code="88754904" type="0" content_hash_code="70737580" os_list="linux,windows" file_path="components/captive_portal/content/captive_portal_service.cc"/> + <item id="cast_channel_send" added_in_milestone="66" hash_code="103172229" type="0" deprecated="2018-08-23" content_hash_code="33946302" file_path=""/> + <item id="cast_keep_alive_delegate" added_in_milestone="66" hash_code="134755844" type="0" deprecated="2018-08-23" content_hash_code="66118796" file_path=""/> + <item id="cast_message_handler" added_in_milestone="66" hash_code="87558948" type="0" deprecated="2018-08-23" content_hash_code="49684899" file_path=""/> + <item id="cast_socket" added_in_milestone="66" hash_code="115192205" type="0" content_hash_code="42881651" os_list="linux,windows,android" file_path="components/cast_channel/cast_socket.cc"/> + <item id="cast_udp_socket" added_in_milestone="66" hash_code="22573197" type="0" content_hash_code="75328301" os_list="linux,windows,android" file_path="components/mirroring/service/udp_socket_client.cc"/> + <item id="cast_udp_transport" added_in_milestone="65" hash_code="5576536" type="0" content_hash_code="107643273" os_list="linux,windows,android" file_path="media/cast/net/udp_transport_impl.cc"/> + <item id="certificate_verifier_url_loader" added_in_milestone="80" hash_code="80134684" type="0" content_hash_code="92630208" os_list="linux,windows,android" file_path="services/cert_verifier/cert_net_url_loader/cert_net_fetcher_url_loader.cc"/> + <item id="certificate_verifier_url_request" added_in_milestone="80" hash_code="85988208" type="0" content_hash_code="59262468" os_list="linux,windows,android" file_path="net/cert_net/cert_net_fetcher_url_request.cc"/> + <item id="chrome_HaTS_service" added_in_milestone="83" hash_code="136028241" type="0" deprecated="2021-02-03" content_hash_code="68990360" file_path=""/> + <item id="chrome_apps_socket_api" added_in_milestone="65" hash_code="8591273" type="0" content_hash_code="130709397" os_list="linux,windows" file_path="extensions/browser/api/socket/socket.cc"/> + <item id="chrome_cart_discounts_lookup" added_in_milestone="92" hash_code="44551896" type="0" content_hash_code="95675425" os_list="linux,windows" file_path="chrome/browser/cart/cart_discount_fetcher.cc"/> + <item id="chrome_cart_get_discounted_link" added_in_milestone="92" hash_code="58596544" type="0" content_hash_code="86139104" os_list="linux,windows" file_path="chrome/browser/cart/cart_discount_link_fetcher.cc"/> + <item id="chrome_cleaner" added_in_milestone="63" hash_code="27071967" type="0" content_hash_code="111240292" os_list="windows" file_path="chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_fetcher_win.cc"/> + <item id="chrome_cleanup_report" added_in_milestone="70" hash_code="71102679" type="0" content_hash_code="130565656" os_list="windows" file_path="chrome/chrome_cleaner/logging/cleaner_logging_service.cc"/> + <item id="chrome_feedback_report_app" added_in_milestone="62" hash_code="134729048" type="0" content_hash_code="79660618" os_list="linux,windows,android" file_path="components/feedback/feedback_uploader.cc"/> + <item id="chrome_variations_service" added_in_milestone="62" hash_code="115188287" type="0" content_hash_code="16094337" os_list="linux,windows,android" file_path="components/variations/service/variations_service.cc"/> + <item id="client_download_request" added_in_milestone="62" hash_code="125522256" type="0" content_hash_code="79464901" os_list="linux,windows" file_path="chrome/browser/safe_browsing/download_protection/check_client_download_request_base.cc"/> + <item id="cloud_print" added_in_milestone="65" hash_code="111712433" type="2" content_hash_code="60926140" os_list="linux,windows" semantics_fields="1,5" policy_fields="-1,3,4" file_path="chrome/service/cloud_print/cloud_print_url_fetcher.cc"/> + <item id="cloud_print_backend" added_in_milestone="62" hash_code="71578042" type="1" second_id="111712433" content_hash_code="85425333" os_list="linux,windows" semantics_fields="2,3,4" file_path="chrome/service/cloud_print/cloud_print_proxy_backend.cc"/> + <item id="cloud_print_credential_update" added_in_milestone="66" hash_code="137420486" type="0" content_hash_code="1179808" os_list="linux,windows" file_path="chrome/service/cloud_print/cloud_print_proxy_backend.cc"/> + <item id="cloud_print_proxy" added_in_milestone="62" hash_code="50859288" type="1" second_id="111712433" content_hash_code="90868083" os_list="linux,windows" semantics_fields="2,3,4" file_path="chrome/service/cloud_print/cloud_print_proxy.cc"/> + <item id="cloud_speech_recognition" added_in_milestone="85" hash_code="61001455" type="0" content_hash_code="114921835" os_list="linux,windows" file_path="chrome/services/speech/cloud_speech_recognition_client.cc"/> + <item id="content_hash_verification_job" added_in_milestone="62" hash_code="64733114" type="0" content_hash_code="127912411" os_list="linux,windows" file_path="extensions/browser/content_hash_fetcher.cc"/> + <item id="content_resource_fetcher" added_in_milestone="63" hash_code="70796791" type="0" deprecated="2017-09-16" content_hash_code="135648626" file_path=""/> + <item id="content_suggestion_get_favicon" added_in_milestone="62" hash_code="16653985" type="0" content_hash_code="134280933" os_list="linux,windows,android" file_path="components/ntp_snippets/content_suggestions_service.cc"/> + <item id="conversion_measurement_report" added_in_milestone="84" hash_code="113422320" type="0" content_hash_code="102111798" os_list="linux,windows,android" file_path="content/browser/conversions/conversion_network_sender_impl.cc"/> + <item id="credenential_avatar" added_in_milestone="62" hash_code="53695122" type="0" content_hash_code="113035371" os_list="linux,windows,android" file_path="chrome/browser/ui/passwords/account_avatar_fetcher.cc"/> + <item id="cros_recovery_image_download" added_in_milestone="62" hash_code="101725581" type="0" content_hash_code="10999698" os_list="linux,windows" file_path="chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc"/> + <item id="cryptauth_device_sync_tickle" added_in_milestone="62" hash_code="96565489" type="1" second_id="29188932" deprecated="2018-03-15" content_hash_code="115714668" file_path=""/> + <item id="cryptauth_enrollment_flow_finish" added_in_milestone="62" hash_code="54836939" type="1" second_id="29188932" deprecated="2018-04-04" content_hash_code="17060642" file_path=""/> + <item id="cryptauth_enrollment_flow_setup" added_in_milestone="62" hash_code="84889397" type="1" second_id="29188932" deprecated="2018-04-04" content_hash_code="128348931" file_path=""/> + <item id="cryptauth_find_eligible_for_promotion" added_in_milestone="62" hash_code="20053290" type="1" second_id="29188932" deprecated="2018-04-04" content_hash_code="93687383" file_path=""/> + <item id="cryptauth_find_eligible_unlock_devices" added_in_milestone="62" hash_code="120000562" type="1" second_id="29188932" deprecated="2018-04-04" content_hash_code="46773475" file_path=""/> + <item id="cryptauth_get_my_devices" added_in_milestone="62" hash_code="136498680" type="1" second_id="29188932" deprecated="2018-04-04" content_hash_code="73842435" file_path=""/> + <item id="cryptauth_toggle_easyunlock" added_in_milestone="62" hash_code="25204343" type="1" second_id="29188932" deprecated="2018-04-04" content_hash_code="13570943" file_path=""/> + <item id="data_reduction_proxy_config" added_in_milestone="62" hash_code="485305" type="0" deprecated="2021-01-25" content_hash_code="134075813" file_path=""/> + <item id="data_reduction_proxy_pingback" added_in_milestone="62" hash_code="68561428" type="0" deprecated="2019-09-17" content_hash_code="78407792" file_path=""/> + <item id="data_reduction_proxy_secure_proxy_check" added_in_milestone="62" hash_code="131236802" type="0" deprecated="2020-03-13" content_hash_code="122297136" file_path=""/> + <item id="data_reduction_proxy_warmup" added_in_milestone="62" hash_code="8250451" type="0" deprecated="2020-03-13" content_hash_code="6321249" file_path=""/> + <item id="desktop_ios_promotion" added_in_milestone="63" hash_code="13694792" type="0" deprecated="2018-11-04" content_hash_code="19776951" file_path=""/> + <item id="desktop_screenshot_save" added_in_milestone="94" hash_code="18870110" type="0" content_hash_code="26509513" os_list="linux,windows" file_path="chrome/browser/ui/views/sharing_hub/screenshot/screenshot_captured_bubble.cc"/> + <item id="device_geolocation_request" added_in_milestone="62" hash_code="77673751" type="0" deprecated="2017-10-20" content_hash_code="97181773" file_path=""/> + <item id="device_management_service" added_in_milestone="62" hash_code="117782019" type="0" content_hash_code="104419970" os_list="linux,windows,android" file_path="components/policy/core/common/cloud/device_management_service.cc"/> + <item id="devtools_cdp_network_resource" added_in_milestone="87" hash_code="60744935" type="0" content_hash_code="85833926" os_list="linux,windows,android" file_path="content/browser/devtools/protocol/devtools_network_resource_loader.cc"/> + <item id="devtools_free_data_source" added_in_milestone="62" hash_code="22774132" type="0" content_hash_code="35733000" os_list="linux,windows" file_path="chrome/browser/ui/webui/devtools_ui_data_source.cc"/> + <item id="devtools_handle_front_end_messages" added_in_milestone="62" hash_code="135636011" type="0" content_hash_code="76808593" os_list="linux,windows,android" file_path="content/shell/browser/shell_devtools_bindings.cc"/> + <item id="devtools_hard_coded_data_source" added_in_milestone="62" hash_code="111565057" type="0" content_hash_code="75183720" os_list="linux,windows" file_path="chrome/browser/ui/webui/devtools_ui_data_source.cc"/> + <item id="devtools_http_handler" added_in_milestone="66" hash_code="49160454" type="0" content_hash_code="88414393" os_list="linux,windows,android" file_path="content/browser/devtools/devtools_http_handler.cc"/> + <item id="devtools_interceptor" added_in_milestone="62" hash_code="98123737" type="0" deprecated="2019-07-31" content_hash_code="64591843" file_path=""/> + <item id="devtools_network_resource" added_in_milestone="62" hash_code="129652775" type="0" content_hash_code="32810159" os_list="linux,windows" file_path="chrome/browser/devtools/devtools_ui_bindings.cc"/> + <item id="devtools_proxy_config" added_in_milestone="85" hash_code="79904729" type="0" content_hash_code="31996982" os_list="linux,windows,android" file_path="content/browser/devtools/protocol/target_handler.cc"/> + <item id="dial_get_app_info" added_in_milestone="65" hash_code="15952025" type="0" deprecated="2018-02-27" content_hash_code="90542080" file_path=""/> + <item id="dial_get_device_description" added_in_milestone="62" hash_code="50422598" type="0" deprecated="2018-02-27" content_hash_code="129827780" file_path=""/> + <item id="dial_url_fetcher" added_in_milestone="67" hash_code="41424546" type="0" content_hash_code="129828432" os_list="linux,windows" file_path="chrome/browser/media/router/discovery/dial/dial_url_fetcher.cc"/> + <item id="digital_asset_links" added_in_milestone="90" hash_code="134272131" type="0" content_hash_code="13554846" os_list="linux,windows,android" file_path="components/digital_asset_links/digital_asset_links_handler.cc"/> + <item id="direct_sockets" added_in_milestone="88" hash_code="32472991" type="0" content_hash_code="64752301" os_list="linux,windows" file_path="content/browser/direct_sockets/direct_sockets_service_impl.cc"/> + <item id="dns_over_https" added_in_milestone="66" hash_code="79895226" type="0" content_hash_code="45123510" os_list="linux,windows,android" file_path="net/dns/dns_transaction.cc"/> + <item id="dns_transaction" added_in_milestone="65" hash_code="79227717" type="0" content_hash_code="132206495" os_list="linux,windows,android" file_path="net/dns/dns_transaction.cc"/> + <item id="dom_distiller" added_in_milestone="62" hash_code="3989826" type="0" content_hash_code="106153970" os_list="linux,windows,android" file_path="components/dom_distiller/core/distiller_url_fetcher.cc"/> + <item id="domain_reliability_report_upload" added_in_milestone="62" hash_code="108804096" type="0" content_hash_code="35902036" os_list="linux,windows,android" file_path="components/domain_reliability/uploader.cc"/> + <item id="domain_security_policy" added_in_milestone="62" hash_code="77597059" type="0" content_hash_code="30916983" os_list="linux,windows,android" file_path="services/network/network_context.cc"/> + <item id="doodle_fetcher" added_in_milestone="62" hash_code="97199008" type="0" deprecated="2017-08-28" content_hash_code="87981692" file_path=""/> + <item id="doodle_service" added_in_milestone="62" hash_code="41154842" type="0" deprecated="2017-08-28" content_hash_code="28273962" file_path=""/> + <item id="download_internals_webui_source" added_in_milestone="66" hash_code="38670228" type="0" content_hash_code="129391056" os_list="linux,windows,android" file_path="chrome/browser/ui/webui/download_internals/download_internals_ui_message_handler.cc"/> + <item id="download_manager_resume" added_in_milestone="62" hash_code="35380758" type="0" content_hash_code="41227674" os_list="linux,windows,android" file_path="components/download/internal/common/download_item_impl.cc"/> + <item id="download_recovery_component" added_in_milestone="71" hash_code="131711536" type="0" content_hash_code="3243311" os_list="windows" file_path="chrome/chrome_cleaner/components/recovery_component.cc"/> + <item id="download_web_contents_frame" added_in_milestone="62" hash_code="56351037" type="0" content_hash_code="3657889" os_list="linux,windows,android" file_path="content/browser/web_contents/web_contents_impl.cc"/> + <item id="downloads_api_run_async" added_in_milestone="62" hash_code="121068967" type="0" content_hash_code="9280914" os_list="linux,windows" file_path="chrome/browser/extensions/api/downloads/downloads_api.cc"/> + <item id="downloads_dom_handler" added_in_milestone="73" hash_code="95951029" type="0" content_hash_code="137150731" os_list="linux,windows" file_path="chrome/browser/ui/webui/downloads/downloads_dom_handler.cc"/> + <item id="drag_download_file" added_in_milestone="62" hash_code="95910019" type="0" content_hash_code="126492858" os_list="linux,windows,android" file_path="content/browser/download/drag_download_file.cc"/> + <item id="drive_service" added_in_milestone="90" hash_code="56074781" type="0" content_hash_code="94248995" os_list="linux,windows" file_path="chrome/browser/new_tab_page/modules/drive/drive_service.cc"/> + <item id="early_hints_preload" added_in_milestone="91" hash_code="35266994" type="0" content_hash_code="42984058" os_list="linux,windows,android" file_path="content/browser/loader/navigation_early_hints_manager.cc"/> + <item id="enterprise_safe_browsing_realtime_url_lookup" added_in_milestone="86" hash_code="22262963" type="0" content_hash_code="14052810" os_list="linux,windows" file_path="chrome/browser/safe_browsing/chrome_enterprise_url_lookup_service.cc"/> + <item id="expect_ct_reporter" added_in_milestone="69" hash_code="23537266" type="0" content_hash_code="130492494" os_list="linux,windows,android" file_path="services/network/expect_ct_reporter.cc"/> + <item id="extension_blacklist" added_in_milestone="62" hash_code="59592717" type="0" content_hash_code="116742516" os_list="linux,windows" file_path="chrome/browser/extensions/blocklist_state_fetcher.cc"/> + <item id="extension_crx_fetcher" added_in_milestone="62" hash_code="21145003" type="0" content_hash_code="79150319" os_list="linux,windows" file_path="extensions/browser/updater/extension_downloader.cc"/> + <item id="extension_install_signer" added_in_milestone="62" hash_code="50464499" type="0" content_hash_code="106712014" os_list="linux,windows" file_path="chrome/browser/extensions/install_signer.cc"/> + <item id="extension_manifest_fetcher" added_in_milestone="62" hash_code="5151071" type="0" content_hash_code="93862569" os_list="linux,windows" file_path="extensions/browser/updater/extension_downloader.cc"/> + <item id="external_policy_fetcher" added_in_milestone="62" hash_code="9459438" type="0" content_hash_code="64260484" os_list="linux,windows" file_path="components/policy/core/common/cloud/external_policy_data_fetcher.cc"/> + <item id="favicon_loader" added_in_milestone="63" hash_code="112189210" type="0" content_hash_code="70773116" os_list="linux,windows,android" file_path="third_party/blink/renderer/platform/loader/fetch/url_loader/web_url_loader.cc"/> + <item id="feed_image_fetcher" added_in_milestone="68" hash_code="87439531" type="0" deprecated="2019-01-04" content_hash_code="26756208" file_path=""/> + <item id="file_system_connector_to_box" added_in_milestone="89" hash_code="29061438" type="1" second_id="29188932" content_hash_code="39353559" os_list="linux,windows" semantics_fields="1,2,3,4,5" policy_fields="-1,3,4" file_path="chrome/browser/enterprise/connectors/file_system/box_api_call_flow.cc"/> + <item id="floc_event_logger" added_in_milestone="89" hash_code="86015226" type="1" second_id="13704791" content_hash_code="68024778" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="3" file_path="chrome/browser/federated_learning/floc_event_logger.cc"/> + <item id="floc_id_provider_impl" added_in_milestone="85" hash_code="103052331" type="1" second_id="13704791" deprecated="2021-01-05" content_hash_code="41421380" file_path=""/> + <item id="floc_remote_permission_service" added_in_milestone="85" hash_code="13704791" type="2" content_hash_code="86293622" os_list="linux,windows,android" semantics_fields="1,5" policy_fields="1,2,4" file_path="chrome/browser/federated_learning/floc_remote_permission_service.cc"/> + <item id="ftl_messaging_client_ack_messages" added_in_milestone="86" hash_code="55663676" type="0" content_hash_code="20913627" os_list="linux,windows,android" file_path="remoting/signaling/ftl_messaging_client.cc"/> + <item id="ftl_messaging_client_receive_messages" added_in_milestone="86" hash_code="136248372" type="0" content_hash_code="36609143" os_list="linux,windows,android" file_path="remoting/signaling/ftl_messaging_client.cc"/> + <item id="ftl_messaging_client_send_messages" added_in_milestone="86" hash_code="48924790" type="0" content_hash_code="6841587" os_list="linux,windows,android" file_path="remoting/signaling/ftl_messaging_client.cc"/> + <item id="ftl_registration_manager" added_in_milestone="86" hash_code="38256901" type="0" content_hash_code="12581281" os_list="linux,windows,android" file_path="remoting/signaling/ftl_registration_manager.cc"/> + <item id="gaia_auth_check_connection_info" added_in_milestone="62" hash_code="4598626" type="0" content_hash_code="57347000" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_exchange_cookies" added_in_milestone="62" hash_code="134289752" type="0" deprecated="2018-09-11" content_hash_code="66433230" file_path=""/> + <item id="gaia_auth_exchange_device_id" added_in_milestone="62" hash_code="39877119" type="0" content_hash_code="61857947" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_fetch_for_uber" added_in_milestone="62" hash_code="97978464" type="0" content_hash_code="28006265" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_get_user_info" added_in_milestone="62" hash_code="82167736" type="0" content_hash_code="4695017" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_list_accounts" added_in_milestone="62" hash_code="35565745" type="0" content_hash_code="93669150" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_log_out" added_in_milestone="62" hash_code="116426676" type="0" content_hash_code="91154233" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_login" added_in_milestone="62" hash_code="91597383" type="0" content_hash_code="111911548" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_merge_sessions" added_in_milestone="62" hash_code="26216847" type="0" content_hash_code="30423843" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_multilogin" added_in_milestone="70" hash_code="31445884" type="0" content_hash_code="77730858" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_auth_revoke_token" added_in_milestone="62" hash_code="133982351" type="0" content_hash_code="96665330" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_cookie_manager_external_cc_result" added_in_milestone="62" hash_code="4300475" type="0" content_hash_code="31188375" os_list="linux,windows,android" file_path="components/signin/internal/identity_manager/gaia_cookie_manager_service.cc"/> + <item id="gaia_create_reauth_proof_token_for_parent" added_in_milestone="80" hash_code="67750043" type="0" content_hash_code="103500636" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_auth_fetcher.cc"/> + <item id="gaia_oauth_client_get_account_capabilities" added_in_milestone="93" hash_code="87437888" type="0" content_hash_code="51145869" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_oauth_client.cc"/> + <item id="gaia_oauth_client_get_token_info" added_in_milestone="62" hash_code="32585152" type="0" content_hash_code="128143346" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_oauth_client.cc"/> + <item id="gaia_oauth_client_get_tokens" added_in_milestone="62" hash_code="5637379" type="0" content_hash_code="12099176" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_oauth_client.cc"/> + <item id="gaia_oauth_client_get_user_info" added_in_milestone="62" hash_code="83476155" type="0" content_hash_code="35159007" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_oauth_client.cc"/> + <item id="gaia_oauth_client_refresh_token" added_in_milestone="62" hash_code="82462683" type="0" content_hash_code="22305252" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_oauth_client.cc"/> + <item id="gcd_rest_client" added_in_milestone="71" hash_code="105985951" type="0" deprecated="2018-10-17" content_hash_code="70710803" file_path="remoting/host/gcd_rest_client.cc"/> + <item id="gcm_channel_status_request" added_in_milestone="62" hash_code="18300705" type="0" deprecated="2020-01-24" content_hash_code="53862393" file_path=""/> + <item id="gcm_checkin" added_in_milestone="62" hash_code="65957842" type="0" content_hash_code="98259579" os_list="linux,windows,android" file_path="google_apis/gcm/engine/checkin_request.cc"/> + <item id="gcm_connection_factory" added_in_milestone="66" hash_code="29057242" type="0" content_hash_code="75279835" os_list="linux,windows,android" file_path="google_apis/gcm/engine/connection_factory_impl.cc"/> + <item id="gcm_registration" added_in_milestone="62" hash_code="61656965" type="0" content_hash_code="113670632" os_list="linux,windows,android" file_path="google_apis/gcm/engine/registration_request.cc"/> + <item id="gcm_subscription" added_in_milestone="62" hash_code="56434025" type="0" deprecated="2019-04-10" content_hash_code="61632174" file_path=""/> + <item id="gcm_unregistration" added_in_milestone="62" hash_code="119542033" type="0" content_hash_code="30144127" os_list="linux,windows,android" file_path="google_apis/gcm/engine/unregistration_request.cc"/> + <item id="geo_language_provider" added_in_milestone="65" hash_code="52821843" type="1" second_id="96590038" content_hash_code="65327456" os_list="linux,windows,android" semantics_fields="1" policy_fields="3,4" file_path="components/language/content/browser/geo_language_provider.cc"/> + <item id="google_url_tracker" added_in_milestone="62" hash_code="5492492" type="0" deprecated="2019-08-01" content_hash_code="54474899" file_path=""/> + <item id="gstatic_change_password_override_urls" added_in_milestone="86" hash_code="135799714" type="0" deprecated="2021-07-12" content_hash_code="133151871" file_path=""/> + <item id="headless_url_request" added_in_milestone="62" hash_code="29865866" type="0" deprecated="2018-07-10" content_hash_code="76700151" file_path=""/> + <item id="heartbeat_sender" added_in_milestone="86" hash_code="4883150" type="0" content_hash_code="131927805" os_list="linux,windows" file_path="remoting/host/heartbeat_sender.cc"/> + <item id="hintsfetcher_gethintsrequest" added_in_milestone="75" hash_code="34557599" type="0" content_hash_code="57003380" os_list="linux,windows,android" file_path="components/optimization_guide/core/hints_fetcher.cc"/> + <item id="history_notice_utils_notice" added_in_milestone="62" hash_code="102595701" type="1" second_id="110307337" content_hash_code="130829410" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="4" file_path="components/browsing_data/core/history_notice_utils.cc"/> + <item id="history_notice_utils_popup" added_in_milestone="62" hash_code="80832574" type="1" second_id="110307337" content_hash_code="30618510" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="4" file_path="components/browsing_data/core/history_notice_utils.cc"/> + <item id="history_ui_favicon_request_handler_get_favicon" added_in_milestone="77" hash_code="17562717" type="0" content_hash_code="64054629" os_list="linux,windows,android" file_path="components/favicon/core/history_ui_favicon_request_handler_impl.cc"/> + <item id="http_server_error_response" added_in_milestone="66" hash_code="32197336" type="0" content_hash_code="61082230" os_list="linux,windows,android" file_path="net/server/http_server.cc"/> + <item id="https_server_previews_navigation" added_in_milestone="74" hash_code="35725390" type="0" deprecated="2020-04-23" content_hash_code="84423109" file_path="chrome/browser/previews/previews_lite_page_redirect_serving_url_loader.cc"/> + <item id="ice_config_fetcher" added_in_milestone="81" hash_code="137093034" type="0" deprecated="2020-10-13" content_hash_code="60051202" file_path="chrome/browser/sharing/webrtc/ice_config_fetcher.cc"/> + <item id="icon_cacher" added_in_milestone="62" hash_code="103133150" type="0" content_hash_code="116368348" os_list="linux,windows,android" file_path="components/ntp_tiles/icon_cacher_impl.cc"/> + <item id="icon_catcher_get_large_icon" added_in_milestone="62" hash_code="44494884" type="0" content_hash_code="98262037" os_list="linux,windows,android" file_path="components/ntp_tiles/icon_cacher_impl.cc"/> + <item id="image_annotation" added_in_milestone="73" hash_code="107881858" type="0" content_hash_code="76229990" os_list="linux,windows,android" file_path="services/image_annotation/annotator.cc"/> + <item id="indexed_db_internals_handler" added_in_milestone="62" hash_code="131180348" type="0" content_hash_code="59026406" os_list="linux,windows,android" file_path="content/browser/indexed_db/indexed_db_internals_ui.cc"/> + <item id="interest_feedv2_image_send" added_in_milestone="86" hash_code="92245202" type="0" content_hash_code="107508312" os_list="linux,windows,android" file_path="components/feed/core/v2/image_fetcher.cc"/> + <item id="interest_feedv2_send" added_in_milestone="83" hash_code="85742023" type="0" content_hash_code="49706671" os_list="linux,windows,android" file_path="components/feed/core/v2/feed_network_impl.cc"/> + <item id="interest_group_update_fetcher" added_in_milestone="94" hash_code="110915076" type="0" content_hash_code="41071213" os_list="linux,windows,android" file_path="content/browser/interest_group/interest_group_manager.cc"/> + <item id="intranet_redirect_detector" added_in_milestone="62" hash_code="21785164" type="0" content_hash_code="62025595" os_list="linux,windows" file_path="chrome/browser/intranet_redirect_detector.cc"/> + <item id="invalidation_service" added_in_milestone="62" hash_code="72354423" type="0" deprecated="2020-01-23" content_hash_code="78425687" file_path=""/> + <item id="javascript_report_error" added_in_milestone="87" hash_code="109607776" type="0" content_hash_code="7229012" os_list="linux" file_path="chrome/browser/error_reporting/chrome_js_error_report_processor_nonchromeos.cc"/> + <item id="lib_address_input" added_in_milestone="62" hash_code="50816767" type="0" content_hash_code="57977576" os_list="linux,windows,android" file_path="third_party/libaddressinput/chromium/chrome_metadata_source.cc"/> + <item id="litepages_robots_rules" added_in_milestone="89" hash_code="50910588" type="0" content_hash_code="72567080" os_list="linux,windows,android" file_path="chrome/browser/subresource_redirect/origin_robots_rules.cc"/> + <item id="load_autofill_gstatic_data" added_in_milestone="78" hash_code="119416099" type="0" content_hash_code="128051538" os_list="linux,windows,android" file_path="chrome/browser/autofill/autofill_gstatic_reader.cc"/> + <item id="logo_service" added_in_milestone="73" hash_code="35473769" type="0" content_hash_code="20271299" os_list="linux,windows,android" file_path="components/search_provider_logos/logo_service_impl.cc"/> + <item id="logo_tracker" added_in_milestone="62" hash_code="36859107" type="0" deprecated="2018-12-07" content_hash_code="67588075" file_path=""/> + <item id="lookup_single_password_leak" added_in_milestone="78" hash_code="16927377" type="0" content_hash_code="12158296" os_list="linux,windows,android" file_path="components/password_manager/core/browser/leak_detection/leak_detection_request.cc"/> + <item id="managed_configuration_loader" added_in_milestone="89" hash_code="77734467" type="0" content_hash_code="101566873" os_list="linux,windows" file_path="chrome/browser/device_api/managed_configuration_api.cc"/> + <item id="media_router_global_media_controls_image" added_in_milestone="81" hash_code="95983790" type="0" content_hash_code="48851217" os_list="linux,windows" file_path="chrome/browser/ui/global_media_controls/cast_media_notification_item.cc"/> + <item id="memories_remote_model_request" added_in_milestone="90" hash_code="41799176" type="0" content_hash_code="53277182" os_list="linux,windows,android" file_path="components/history_clusters/core/remote_clustering_backend.cc"/> + <item id="metrics_report_ukm" added_in_milestone="62" hash_code="727478" type="0" content_hash_code="8746987" os_list="linux,windows,android" file_path="components/metrics/net/net_metrics_log_uploader.cc"/> + <item id="metrics_report_uma" added_in_milestone="62" hash_code="727528" type="0" content_hash_code="10176197" os_list="linux,windows,android" file_path="components/metrics/net/net_metrics_log_uploader.cc"/> + <item id="mirroring_get_setup_info" added_in_milestone="68" hash_code="78447809" type="0" content_hash_code="64839410" os_list="windows,linux,android" file_path="components/mirroring/service/receiver_setup_querier.cc"/> + <item id="missing" added_in_milestone="62" hash_code="77012883" type="0" reserved="1" os_list="linux,windows" file_path=""/> + <item id="mojo_context_state" added_in_milestone="63" hash_code="93232258" type="0" deprecated="2017-10-20" content_hash_code="124821232" file_path=""/> + <item id="navigation_predictor_srp_prefetch" added_in_milestone="81" hash_code="57773453" type="0" content_hash_code="38811322" os_list="linux,windows,android" file_path="chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_tab_helper.cc"/> + <item id="navigation_url_loader" added_in_milestone="62" hash_code="63171670" type="0" content_hash_code="129352907" os_list="linux,windows,android" file_path="content/browser/loader/navigation_url_loader_impl.cc"/> + <item id="nearby_share_contacts" added_in_milestone="86" hash_code="91999155" type="1" second_id="29188932" deprecated="2020-09-21" content_hash_code="74684570" file_path=""/> + <item id="nearby_share_list_public_certificates" added_in_milestone="86" hash_code="123714070" type="1" second_id="29188932" deprecated="2020-09-21" content_hash_code="24145546" file_path=""/> + <item id="nearby_share_update_device" added_in_milestone="86" hash_code="30656793" type="1" second_id="29188932" deprecated="2020-09-21" content_hash_code="30624346" file_path=""/> + <item id="nearby_webrtc_connection" added_in_milestone="86" hash_code="37994740" type="0" deprecated="2020-09-21" content_hash_code="118366066" file_path=""/> + <item id="net_error_helper" added_in_milestone="63" hash_code="60071001" type="0" deprecated="2020-07-10" content_hash_code="68322861" file_path=""/> + <item id="network_location_provider" added_in_milestone="64" hash_code="23472048" type="1" second_id="96590038" content_hash_code="41087976" os_list="linux,windows" semantics_fields="1" policy_fields="3,4" file_path="services/device/geolocation/network_location_provider.cc"/> + <item id="network_location_request" added_in_milestone="65" hash_code="96590038" type="2" content_hash_code="80741011" os_list="linux,windows,android" semantics_fields="2,3,4,5" policy_fields="-1" file_path="services/device/geolocation/network_location_request.cc"/> + <item id="network_time_component" added_in_milestone="62" hash_code="46188932" type="0" content_hash_code="28051857" os_list="linux,windows,android" file_path="components/network_time/network_time_tracker.cc"/> + <item id="new_tab_page_handler" added_in_milestone="84" hash_code="48673144" type="0" content_hash_code="49174657" os_list="linux,windows" file_path="chrome/browser/ui/webui/new_tab_page/new_tab_page_handler.cc"/> + <item id="notification_client" added_in_milestone="79" hash_code="78479125" type="0" content_hash_code="129874070" os_list="linux,windows,android" file_path="remoting/client/notification/notification_client.cc"/> + <item id="ntp_contextual_suggestions_fetch" added_in_milestone="62" hash_code="95711309" type="0" deprecated="2019-04-18" content_hash_code="107035434" file_path=""/> + <item id="ntp_custom_background" added_in_milestone="76" hash_code="92125886" type="0" deprecated="2021-07-30" content_hash_code="61176452" file_path=""/> + <item id="ntp_custom_link_checker_request" added_in_milestone="71" hash_code="78408551" type="0" deprecated="2018-10-26" content_hash_code="13407730" file_path=""/> + <item id="ntp_snippets_fetch" added_in_milestone="62" hash_code="15418154" type="0" content_hash_code="10078959" os_list="linux,windows,android" file_path="components/ntp_snippets/remote/json_request.cc"/> + <item id="nux_ntp_background_preview" added_in_milestone="74" hash_code="124847649" type="0" content_hash_code="31404656" os_list="linux,windows" file_path="chrome/browser/ui/webui/welcome/ntp_background_fetcher.cc"/> + <item id="oauth2_access_token_fetcher" added_in_milestone="62" hash_code="27915688" type="0" content_hash_code="33501872" os_list="linux,windows,android" file_path="google_apis/gaia/gaia_access_token_fetcher.cc"/> + <item id="oauth2_api_call_flow" added_in_milestone="65" hash_code="29188932" type="2" content_hash_code="108831236" os_list="linux,windows,android" policy_fields="-1" file_path="google_apis/gaia/oauth2_api_call_flow.cc"/> + <item id="oauth2_mint_token_flow" added_in_milestone="62" hash_code="1112842" type="1" second_id="29188932" content_hash_code="91581432" os_list="linux,windows,android" semantics_fields="1,2,3,4,5" policy_fields="3,4" file_path="google_apis/gaia/oauth2_mint_token_flow.cc"/> + <item id="ocsp_start_url_loader" added_in_milestone="81" hash_code="3646641" type="0" deprecated="2020-04-28" content_hash_code="106270072" file_path=""/> + <item id="ocsp_start_url_request" added_in_milestone="62" hash_code="60921996" type="0" deprecated="2020-04-28" content_hash_code="6288676" file_path=""/> + <item id="offline_prefetch" added_in_milestone="62" hash_code="19185953" type="0" content_hash_code="112039446" os_list="linux,windows,android" file_path="components/offline_pages/core/prefetch/prefetch_request_fetcher.cc"/> + <item id="omnibox_documentsuggest" added_in_milestone="69" hash_code="6055066" type="0" content_hash_code="126973249" os_list="linux,windows,android" file_path="components/omnibox/browser/document_suggestions_service.cc"/> + <item id="omnibox_navigation_observer" added_in_milestone="62" hash_code="61684939" type="0" content_hash_code="2642036" os_list="linux,windows" file_path="chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc"/> + <item id="omnibox_result_change" added_in_milestone="62" hash_code="73107389" type="0" content_hash_code="24802647" os_list="linux,windows,android" file_path="chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc"/> + <item id="omnibox_suggest" added_in_milestone="62" hash_code="47815025" type="0" content_hash_code="86297726" os_list="linux,windows,android" file_path="components/omnibox/browser/search_provider.cc"/> + <item id="omnibox_suggest_deletion" added_in_milestone="62" hash_code="84212388" type="0" content_hash_code="24981550" os_list="linux,windows,android" file_path="components/omnibox/browser/base_search_provider.cc"/> + <item id="omnibox_zerosuggest" added_in_milestone="62" hash_code="7687691" type="0" content_hash_code="119419625" os_list="linux,windows,android" file_path="components/omnibox/browser/remote_suggestions_service.cc"/> + <item id="one_google_bar_service" added_in_milestone="62" hash_code="78917933" type="0" content_hash_code="46527252" os_list="linux,windows" file_path="chrome/browser/new_tab_page/one_google_bar/one_google_bar_loader_impl.cc"/> + <item id="open_screen_message" added_in_milestone="78" hash_code="95250780" type="0" deprecated="2020-02-13" content_hash_code="39027953" file_path=""/> + <item id="open_screen_tls_message" added_in_milestone="80" hash_code="61695471" type="0" deprecated="2020-02-13" content_hash_code="28355565" file_path=""/> + <item id="open_search" added_in_milestone="62" hash_code="107267424" type="0" content_hash_code="83025542" os_list="linux,windows,android" file_path="components/search_engines/template_url_fetcher.cc"/> + <item id="openscreen_message" added_in_milestone="83" hash_code="23036184" type="0" content_hash_code="124395439" os_list="linux,windows,android" file_path="components/openscreen_platform/udp_socket.cc"/> + <item id="openscreen_tls_message" added_in_milestone="83" hash_code="40127335" type="0" content_hash_code="15991338" os_list="linux,windows,android" file_path="components/openscreen_platform/tls_connection_factory.cc"/> + <item id="optimization_guide_model" added_in_milestone="79" hash_code="106373593" type="0" content_hash_code="32403047" os_list="linux,windows,android" file_path="components/optimization_guide/core/prediction_model_fetcher.cc"/> + <item id="optimization_guide_model_download" added_in_milestone="88" hash_code="100143055" type="0" content_hash_code="97983899" os_list="linux,windows,android" file_path="chrome/browser/optimization_guide/prediction/prediction_model_download_manager.cc"/> + <item id="origin_policy_loader" added_in_milestone="69" hash_code="6483617" type="0" content_hash_code="134028975" os_list="linux,windows,android" file_path="services/network/origin_policy/origin_policy_fetcher.cc"/> + <item id="parallel_download_job" added_in_milestone="62" hash_code="135118587" type="0" content_hash_code="105330419" os_list="linux,windows,android" file_path="components/download/internal/common/parallel_download_job.cc"/> + <item id="password_protection_request" added_in_milestone="62" hash_code="66322287" type="0" content_hash_code="25596947" os_list="linux,windows,android" file_path="components/safe_browsing/core/browser/password_protection/password_protection_request.cc"/> + <item id="password_requirements_spec_fetch" added_in_milestone="69" hash_code="69585116" type="0" content_hash_code="5591260" os_list="linux,windows,android" file_path="components/password_manager/core/browser/generation/password_requirements_spec_fetcher_impl.cc"/> + <item id="payment_instrument_icon_fetcher" added_in_milestone="62" hash_code="73309970" type="0" deprecated="2017-09-16" content_hash_code="84709873" file_path=""/> + <item id="payment_manifest_downloader" added_in_milestone="62" hash_code="84045030" type="0" content_hash_code="19293316" os_list="linux,windows,android" file_path="components/payments/core/payment_manifest_downloader.cc"/> + <item id="payments_sync_cards" added_in_milestone="62" hash_code="95588446" type="0" content_hash_code="56526513" os_list="linux,windows,android" file_path="components/autofill/core/browser/payments/payments_client.cc"/> + <item id="pdf_plugin_placeholder" added_in_milestone="63" hash_code="56866367" type="0" content_hash_code="16907221" os_list="linux,windows" file_path="chrome/browser/plugins/plugin_observer.cc"/> + <item id="pepper_tcp_socket" added_in_milestone="65" hash_code="120623198" type="0" content_hash_code="27489892" os_list="linux,windows" file_path="content/browser/renderer_host/pepper/pepper_socket_utils.cc"/> + <item id="pepper_udp_socket" added_in_milestone="70" hash_code="53512439" type="0" content_hash_code="7268418" os_list="linux,windows" file_path="content/browser/renderer_host/pepper/pepper_socket_utils.cc"/> + <item id="per_user_topic_registration_request" added_in_milestone="68" hash_code="10498172" type="0" content_hash_code="57098847" os_list="linux,windows,android" file_path="components/invalidation/impl/per_user_topic_subscription_request.cc"/> + <item id="permission_predictions" added_in_milestone="88" hash_code="89492280" type="0" content_hash_code="806663" os_list="linux,windows,android" file_path="components/permissions/prediction_service/prediction_service.cc"/> + <item id="permission_reporting" added_in_milestone="62" hash_code="131741641" type="0" deprecated="2018-03-06" content_hash_code="7213535" file_path=""/> + <item id="persist_blob_to_indexed_db" added_in_milestone="62" hash_code="32030464" type="0" deprecated="2018-08-13" content_hash_code="35410079" file_path=""/> + <item id="photos_service" added_in_milestone="94" hash_code="100936478" type="0" content_hash_code="91467634" os_list="linux,windows" file_path="chrome/browser/new_tab_page/modules/photos/photos_service.cc"/> + <item id="plugins_resource_service" added_in_milestone="62" hash_code="49601082" type="0" content_hash_code="6877335" os_list="linux,windows" file_path="chrome/browser/plugins/plugins_resource_service.cc"/> + <item id="popular_sites_fetch" added_in_milestone="62" hash_code="50755044" type="0" content_hash_code="6910083" os_list="linux,windows,android" file_path="components/ntp_tiles/popular_sites_impl.cc"/> + <item id="port_forwarding_controller_socket" added_in_milestone="65" hash_code="95075845" type="0" content_hash_code="122163428" os_list="linux,windows" file_path="chrome/browser/devtools/device/port_forwarding_controller.cc"/> + <item id="ppapi_download_request" added_in_milestone="62" hash_code="135967426" type="0" content_hash_code="131391591" os_list="linux,windows" file_path="chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc"/> + <item id="predictive_prefetch" added_in_milestone="85" hash_code="72157052" type="0" content_hash_code="28097398" os_list="linux,windows,android" file_path="chrome/browser/predictors/prefetch_manager.cc"/> + <item id="prefetch_download" added_in_milestone="62" hash_code="44583172" type="0" content_hash_code="21424542" os_list="linux,windows,android" file_path="components/offline_pages/core/prefetch/prefetch_downloader_impl.cc"/> + <item id="prefetch_proxy_canary_check" added_in_milestone="88" hash_code="9229948" type="0" content_hash_code="53040767" os_list="linux,windows,android" file_path="chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_origin_prober.cc"/> + <item id="prefetch_proxy_loader" added_in_milestone="88" hash_code="119210936" type="0" deprecated="2021-02-17" content_hash_code="18878601" file_path=""/> + <item id="prefetch_proxy_probe" added_in_milestone="88" hash_code="123387409" type="0" content_hash_code="1909853" os_list="linux,windows,android" file_path="chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_origin_prober.cc"/> + <item id="prefetch_visuals" added_in_milestone="75" hash_code="91068704" type="0" content_hash_code="90439946" os_list="linux,windows,android" file_path="components/offline_pages/core/prefetch/visuals_fetch_by_url.cc"/> + <item id="previews_litepage_origin_prober" added_in_milestone="78" hash_code="33703614" type="0" deprecated="2020-04-23" content_hash_code="116235355" file_path="chrome/browser/previews/previews_lite_page_redirect_url_loader.cc"/> + <item id="previews_litepage_prober" added_in_milestone="78" hash_code="33813109" type="0" deprecated="2020-04-23" content_hash_code="52572789" file_path="chrome/browser/previews/previews_lite_page_redirect_decider.cc"/> + <item id="previews_prober" added_in_milestone="77" hash_code="41010697" type="0" deprecated="2019-07-24" content_hash_code="51581107" file_path=""/> + <item id="printer_job_handler" added_in_milestone="62" hash_code="67638271" type="1" second_id="111712433" content_hash_code="75712693" os_list="linux,windows" semantics_fields="2,3,4" file_path="chrome/service/cloud_print/printer_job_handler.cc"/> + <item id="profile_avatar" added_in_milestone="62" hash_code="51164680" type="0" content_hash_code="113550845" os_list="linux,windows,android" file_path="chrome/browser/profiles/profile_avatar_downloader.cc"/> + <item id="profile_resetter_upload" added_in_milestone="62" hash_code="105330607" type="0" content_hash_code="129329171" os_list="linux,windows" file_path="chrome/browser/profile_resetter/reset_report_uploader.cc"/> + <item id="promo_service" added_in_milestone="72" hash_code="67052219" type="0" content_hash_code="32939033" os_list="linux,windows" file_path="chrome/browser/new_tab_page/promos/promo_service.cc"/> + <item id="proxy_config_direct" added_in_milestone="67" hash_code="119015679" type="0" content_hash_code="119931568" os_list="linux,windows,android" file_path="net/proxy_resolution/proxy_config_with_annotation.cc"/> + <item id="proxy_config_headless" added_in_milestone="67" hash_code="133221587" type="0" content_hash_code="77459277" os_list="linux,windows" file_path="headless/lib/browser/headless_request_context_manager.cc"/> + <item id="proxy_config_settings" added_in_milestone="67" hash_code="136468456" type="0" content_hash_code="19527377" os_list="linux,windows,android" file_path="components/proxy_config/pref_proxy_config_tracker_impl.cc"/> + <item id="proxy_config_system" added_in_milestone="67" hash_code="11258689" type="0" content_hash_code="77057929" os_list="linux,windows,android" file_path="net/proxy_resolution/configured_proxy_resolution_service.cc"/> + <item id="proxy_config_windows_resolver" added_in_milestone="86" hash_code="13924805" type="0" content_hash_code="123023599" os_list="windows" file_path="net/proxy_resolution/win/windows_system_proxy_resolution_request.cc"/> + <item id="proxy_script_fetcher" added_in_milestone="62" hash_code="37531401" type="0" deprecated="2018-03-16" content_hash_code="31866133" file_path=""/> + <item id="puch_client_channel" added_in_milestone="67" hash_code="34459548" type="0" deprecated="2020-01-23" content_hash_code="92475475" file_path=""/> + <item id="qr_code_save" added_in_milestone="84" hash_code="87963126" type="0" content_hash_code="72717245" os_list="linux,windows" file_path="chrome/browser/ui/views/qrcode_generator/qrcode_generator_bubble.cc"/> + <item id="query_tiles_fetcher" added_in_milestone="84" hash_code="10243490" type="0" content_hash_code="16824373" os_list="linux,windows,android" file_path="components/query_tiles/internal/tile_fetcher.cc"/> + <item id="query_tiles_image_loader" added_in_milestone="83" hash_code="95103115" type="0" content_hash_code="75070538" os_list="linux,windows,android" file_path="components/query_tiles/internal/cached_image_loader.cc"/> + <item id="quic_chromium_incoming_pending_session" added_in_milestone="73" hash_code="120830730" type="0" content_hash_code="52904665" os_list="linux,windows,android" file_path="net/quic/quic_chromium_client_session.cc"/> + <item id="quic_chromium_incoming_session" added_in_milestone="66" hash_code="87635401" type="0" content_hash_code="78573093" os_list="linux,windows,android" file_path="net/quic/quic_chromium_client_session.cc"/> + <item id="quic_chromium_packet_writer" added_in_milestone="66" hash_code="20153177" type="0" content_hash_code="29657765" os_list="linux,windows,android" file_path="net/quic/quic_chromium_packet_writer.cc"/> + <item id="ranker_url_fetcher" added_in_milestone="62" hash_code="95682324" type="0" content_hash_code="45958626" os_list="linux,windows,android" file_path="components/assist_ranker/ranker_url_fetcher.cc"/> + <item id="receive_messages_express" added_in_milestone="85" hash_code="29506140" type="0" deprecated="2020-09-21" content_hash_code="38581365" file_path=""/> + <item id="refresh_token_annotation_request" added_in_milestone="62" hash_code="7433837" type="1" second_id="29188932" deprecated="2018-01-17" content_hash_code="137103383" file_path=""/> + <item id="remote_copy_message_handler" added_in_milestone="80" hash_code="80255301" type="0" content_hash_code="117673331" os_list="linux,windows" file_path="chrome/browser/sharing/shared_clipboard/remote_copy_message_handler.cc"/> + <item id="remote_suggestions_provider" added_in_milestone="62" hash_code="49544361" type="0" content_hash_code="126329742" os_list="linux,windows,android" file_path="components/ntp_snippets/remote/cached_image_fetcher.cc"/> + <item id="remoting_directory_delete_host" added_in_milestone="86" hash_code="89093734" type="0" content_hash_code="65893931" os_list="linux,windows,android" file_path="remoting/base/directory_service_client.cc"/> + <item id="remoting_directory_get_host_list" added_in_milestone="86" hash_code="93434368" type="0" content_hash_code="59980448" os_list="linux,windows,android" file_path="remoting/base/directory_service_client.cc"/> + <item id="remoting_directory_register_host" added_in_milestone="86" hash_code="117688925" type="0" content_hash_code="74224493" os_list="linux,windows,android" file_path="remoting/base/directory_service_client.cc"/> + <item id="remoting_ice_config_request" added_in_milestone="86" hash_code="88945310" type="0" content_hash_code="94742293" os_list="linux,windows,android" file_path="remoting/protocol/remoting_ice_config_request.cc"/> + <item id="remoting_log_to_server" added_in_milestone="86" hash_code="99742369" type="0" content_hash_code="117118166" os_list="linux,windows,android" file_path="remoting/signaling/remoting_log_to_server.cc"/> + <item id="remoting_register_support_host_request" added_in_milestone="86" hash_code="67117364" type="0" content_hash_code="15955284" os_list="linux,windows" file_path="remoting/host/remoting_register_support_host_request.cc"/> + <item id="remoting_telemetry_log_writer" added_in_milestone="86" hash_code="107268760" type="0" content_hash_code="81741595" os_list="linux,windows,android" file_path="remoting/base/telemetry_log_writer.cc"/> + <item id="render_view_context_menu" added_in_milestone="62" hash_code="25844439" type="0" content_hash_code="69471170" os_list="linux,windows" file_path="chrome/browser/renderer_context_menu/render_view_context_menu.cc"/> + <item id="renderer_initiated_download" added_in_milestone="62" hash_code="116443055" type="0" content_hash_code="37846436" os_list="linux,windows,android" file_path="content/browser/renderer_host/render_frame_host_impl.cc"/> + <item id="reporting" added_in_milestone="62" hash_code="109891200" type="0" content_hash_code="125758928" os_list="linux,windows,android" file_path="net/reporting/reporting_uploader.cc"/> + <item id="resource_dispatcher_host" added_in_milestone="62" hash_code="81157007" type="0" deprecated="2019-07-30" content_hash_code="35725167" file_path=""/> + <item id="resource_prefetch" added_in_milestone="62" hash_code="110815970" type="0" deprecated="2018-02-28" content_hash_code="39251261" file_path=""/> + <item id="rlz_ping" added_in_milestone="63" hash_code="99279418" type="0" content_hash_code="102108802" os_list="windows" file_path="rlz/lib/financial_ping.cc"/> + <item id="safe_browsing_backup_request" added_in_milestone="62" hash_code="106980485" type="0" deprecated="2018-08-14" content_hash_code="101760679" file_path=""/> + <item id="safe_browsing_binary_upload" added_in_milestone="78" hash_code="71663319" type="0" deprecated="2020-09-16" content_hash_code="105913171" file_path=""/> + <item id="safe_browsing_binary_upload_app" added_in_milestone="87" hash_code="4306022" type="0" content_hash_code="64626873" os_list="linux,windows" file_path="chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc"/> + <item id="safe_browsing_binary_upload_connector" added_in_milestone="87" hash_code="59568147" type="0" content_hash_code="52138007" os_list="linux,windows" file_path="chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc"/> + <item id="safe_browsing_cache_collector" added_in_milestone="62" hash_code="115907811" type="0" content_hash_code="62296373" os_list="linux,windows,android" file_path="components/safe_browsing/content/browser/threat_details_cache.cc"/> + <item id="safe_browsing_certificate_error_reporting" added_in_milestone="62" hash_code="66590631" type="0" content_hash_code="26108454" os_list="linux,windows,android" file_path="chrome/browser/ssl/certificate_error_reporter.cc"/> + <item id="safe_browsing_chunk_backup_request" added_in_milestone="62" hash_code="79957943" type="0" deprecated="2018-08-14" content_hash_code="133850277" file_path=""/> + <item id="safe_browsing_client_side_malware_detector" added_in_milestone="62" hash_code="102935425" type="0" deprecated="2019-12-07" content_hash_code="79591279" file_path=""/> + <item id="safe_browsing_client_side_phishing_detector" added_in_milestone="62" hash_code="1313982" type="0" content_hash_code="50199143" os_list="linux,windows,android" file_path="components/safe_browsing/content/browser/client_side_detection_service.cc"/> + <item id="safe_browsing_extended_reporting" added_in_milestone="62" hash_code="42848942" type="0" content_hash_code="81193513" os_list="linux,windows,android" file_path="components/safe_browsing/core/browser/ping_manager.cc"/> + <item id="safe_browsing_feedback" added_in_milestone="62" hash_code="44583821" type="0" content_hash_code="27116846" os_list="linux,windows" file_path="chrome/browser/safe_browsing/download_protection/download_feedback.cc"/> + <item id="safe_browsing_get_full_hash" added_in_milestone="62" hash_code="68745894" type="0" deprecated="2018-08-14" content_hash_code="21739198" file_path=""/> + <item id="safe_browsing_incident" added_in_milestone="62" hash_code="124950347" type="0" content_hash_code="7306531" os_list="linux,windows" file_path="chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc"/> + <item id="safe_browsing_module_loader" added_in_milestone="62" hash_code="6019475" type="0" content_hash_code="49511650" os_list="linux,windows,android" file_path="components/safe_browsing/content/browser/client_side_model_loader.cc"/> + <item id="safe_browsing_realtime_url_lookup" added_in_milestone="78" hash_code="119324658" type="0" content_hash_code="71236226" os_list="linux,windows,android" file_path="components/safe_browsing/core/browser/realtime/url_lookup_service.cc"/> + <item id="safe_browsing_v4_get_hash" added_in_milestone="62" hash_code="8561691" type="0" content_hash_code="132435617" os_list="linux,windows,android" file_path="components/safe_browsing/core/browser/db/v4_get_hash_protocol_manager.cc"/> + <item id="safe_browsing_v4_update" added_in_milestone="70" hash_code="82509217" type="0" content_hash_code="5247849" os_list="linux,windows,android" file_path="components/safe_browsing/core/browser/db/v4_update_protocol_manager.cc"/> + <item id="safe_search_service" added_in_milestone="70" hash_code="136386805" type="0" content_hash_code="127491095" os_list="linux,windows,android" file_path="components/policy/content/safe_search_service.cc"/> + <item id="safety_check_update_connectivity" added_in_milestone="84" hash_code="137724067" type="0" content_hash_code="30977369" os_list="linux,windows,android" file_path="components/safety_check/update_check_helper.cc"/> + <item id="sanitized_image_source" added_in_milestone="86" hash_code="36944304" type="0" content_hash_code="39770427" os_list="linux,windows" file_path="chrome/browser/ui/webui/sanitized_image_source.cc"/> + <item id="save_file_manager" added_in_milestone="62" hash_code="56275203" type="0" content_hash_code="56692339" os_list="linux,windows,android" file_path="content/browser/download/save_file_manager.cc"/> + <item id="sct_auditing" added_in_milestone="87" hash_code="48603483" type="0" content_hash_code="43567503" os_list="linux,windows,android" file_path="chrome/browser/ssl/sct_reporting_service.cc"/> + <item id="sdch_dictionary_fetch" added_in_milestone="62" hash_code="47152935" type="0" deprecated="2017-09-16" content_hash_code="16764294" file_path=""/> + <item id="search_prefetch_service" added_in_milestone="88" hash_code="108986091" type="0" content_hash_code="125257414" os_list="windows,linux,android" file_path="chrome/browser/prefetch/search_prefetch/base_search_prefetch_request.cc"/> + <item id="search_suggest_service" added_in_milestone="73" hash_code="57785193" type="0" deprecated="2021-09-02" content_hash_code="132247652" file_path=""/> + <item id="security_key_socket" added_in_milestone="66" hash_code="31074955" type="0" content_hash_code="13741232" os_list="linux,windows" file_path="remoting/host/security_key/security_key_socket.cc"/> + <item id="send_message_express" added_in_milestone="85" hash_code="23527666" type="0" deprecated="2020-09-21" content_hash_code="96850228" file_path=""/> + <item id="service_worker_navigation_preload" added_in_milestone="63" hash_code="129872904" type="0" content_hash_code="79473248" os_list="linux,windows,android" file_path="content/browser/service_worker/service_worker_fetch_dispatcher.cc"/> + <item id="service_worker_script_load" added_in_milestone="90" hash_code="21498113" type="0" content_hash_code="56275791" os_list="linux,windows,android" file_path="content/browser/service_worker/service_worker_new_script_fetcher.cc"/> + <item id="service_worker_update_checker" added_in_milestone="71" hash_code="130931413" type="0" content_hash_code="32441998" os_list="linux,windows,android" file_path="content/browser/service_worker/service_worker_single_script_update_checker.cc"/> + <item id="services_http_server_error_response" added_in_milestone="68" hash_code="59302801" type="0" content_hash_code="127774041" os_list="linux,windows,android" file_path="services/network/public/cpp/server/http_server.cc"/> + <item id="shared_storage_worklet_module_script_downloader" added_in_milestone="95" hash_code="79084529" type="0" content_hash_code="57126817" os_list="linux,windows,android" file_path="content/services/shared_storage_worklet/module_script_downloader.cc"/> + <item id="sigined_exchange_cert_fetcher" added_in_milestone="66" hash_code="79442849" type="0" content_hash_code="8138156" os_list="linux,windows,android" file_path="content/browser/web_package/signed_exchange_cert_fetcher.cc"/> + <item id="sigined_exchange_validity_pinger" added_in_milestone="75" hash_code="57114284" type="0" content_hash_code="119482488" os_list="linux,windows,android" file_path="content/browser/web_package/signed_exchange_validity_pinger.cc"/> + <item id="signed_in_profile_avatar" added_in_milestone="62" hash_code="108903331" type="0" content_hash_code="72850619" os_list="linux,windows,android" file_path="chrome/browser/profiles/profile_downloader.cc"/> + <item id="socket_bio_adapter" added_in_milestone="66" hash_code="516551" type="0" content_hash_code="21643352" os_list="linux,windows,android" file_path="net/socket/socket_bio_adapter.cc"/> + <item id="spdy_push_stream" added_in_milestone="67" hash_code="36915753" type="0" content_hash_code="69224629" os_list="linux,windows,android" file_path="net/spdy/spdy_session.cc"/> + <item id="spdy_session_control" added_in_milestone="66" hash_code="57143548" type="0" content_hash_code="29815792" os_list="linux,windows,android" file_path="net/spdy/spdy_session.cc"/> + <item id="speech_recognition_downstream" added_in_milestone="62" hash_code="26096088" type="0" content_hash_code="120733233" os_list="linux,windows" file_path="content/browser/speech/speech_recognition_engine.cc"/> + <item id="speech_recognition_upstream" added_in_milestone="62" hash_code="66846958" type="0" content_hash_code="7706219" os_list="linux,windows" file_path="content/browser/speech/speech_recognition_engine.cc"/> + <item id="spellcheck_hunspell_dictionary" added_in_milestone="62" hash_code="117649486" type="0" content_hash_code="45660952" os_list="linux,windows,android" file_path="chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc"/> + <item id="spellcheck_lookup" added_in_milestone="62" hash_code="132553989" type="0" content_hash_code="120395045" os_list="linux,windows" file_path="components/spellcheck/browser/spelling_service_client.cc"/> + <item id="ssl_hmac_channel_authenticator" added_in_milestone="66" hash_code="106124561" type="0" content_hash_code="110454877" os_list="linux,windows,android" file_path="remoting/protocol/ssl_hmac_channel_authenticator.cc"/> + <item id="ssl_name_mismatch_lookup" added_in_milestone="62" hash_code="114468207" type="0" content_hash_code="97619078" os_list="linux,windows,android" file_path="components/security_interstitials/content/common_name_mismatch_handler.cc"/> + <item id="stream_message_pipe_adapter" added_in_milestone="66" hash_code="71837756" type="0" content_hash_code="66212605" os_list="linux,windows,android" file_path="remoting/protocol/stream_message_pipe_adapter.cc"/> + <item id="stream_packet_socket" added_in_milestone="84" hash_code="38197513" type="0" content_hash_code="55116994" os_list="linux,windows,android" file_path="remoting/protocol/stream_packet_socket.cc"/> + <item id="suggestions_image_manager" added_in_milestone="62" hash_code="13211343" type="0" deprecated="2018-11-28" content_hash_code="36271280" file_path=""/> + <item id="suggestions_service" added_in_milestone="62" hash_code="35370363" type="0" deprecated="2021-07-08" content_hash_code="66296423" file_path=""/> + <item id="supervised_user_refresh_token_fetcher" added_in_milestone="62" hash_code="136117054" type="0" deprecated="2018-04-18" content_hash_code="101636136" file_path=""/> + <item id="supervised_user_url_filter" added_in_milestone="62" hash_code="14257952" type="0" deprecated="2019-07-30" content_hash_code="30470003" file_path=""/> + <item id="supervised_users_blacklist" added_in_milestone="62" hash_code="78544924" type="0" deprecated="2019-07-30" content_hash_code="10924669" file_path=""/> + <item id="sync_attachment_downloader" added_in_milestone="62" hash_code="26372521" type="0" deprecated="2018-02-08" content_hash_code="70097603" file_path=""/> + <item id="sync_attachment_uploader" added_in_milestone="62" hash_code="132657055" type="0" deprecated="2018-02-08" content_hash_code="25152853" file_path=""/> + <item id="sync_file_system" added_in_milestone="62" hash_code="102819690" type="0" content_hash_code="52153962" os_list="linux,windows" file_path="chrome/browser/sync_file_system/drive_backend/sync_engine.cc"/> + <item id="sync_http_bridge" added_in_milestone="62" hash_code="57144960" type="0" content_hash_code="32868346" os_list="linux,windows,android" file_path="components/sync/engine/net/http_bridge.cc"/> + <item id="sync_stop_reporter" added_in_milestone="62" hash_code="5021348" type="0" content_hash_code="56902850" os_list="linux,windows,android" file_path="components/sync/driver/sync_stopped_reporter.cc"/> + <item id="task_module_service" added_in_milestone="88" hash_code="50808258" type="0" content_hash_code="12116330" os_list="linux,windows" file_path="chrome/browser/new_tab_page/modules/task_module/task_module_service.cc"/> + <item id="test" added_in_milestone="62" hash_code="3556498" type="0" reserved="1" os_list="linux,windows" file_path=""/> + <item id="test_partial" added_in_milestone="62" hash_code="22096011" type="0" reserved="1" os_list="linux,windows" file_path=""/> + <item id="tethering_handler_socket" added_in_milestone="65" hash_code="113065062" type="0" content_hash_code="986296" os_list="linux,windows,android" file_path="content/browser/devtools/protocol/tethering_handler.cc"/> + <item id="thumbnail_source" added_in_milestone="62" hash_code="135251783" type="0" deprecated="2018-11-27" content_hash_code="31086298" file_path=""/> + <item id="translate_url_fetcher" added_in_milestone="62" hash_code="137116619" type="0" content_hash_code="104217506" os_list="linux,windows,android" file_path="components/translate/core/browser/translate_url_fetcher.cc"/> + <item id="trusted_vault_request" added_in_milestone="88" hash_code="30516662" type="0" content_hash_code="121167791" os_list="linux,windows,android" file_path="components/sync/trusted_vault/trusted_vault_request.cc"/> + <item id="ui_devtools_server" added_in_milestone="66" hash_code="4986170" type="0" content_hash_code="62670263" os_list="linux,windows,android" file_path="components/ui_devtools/devtools_server.cc"/> + <item id="undefined" added_in_milestone="62" hash_code="45578882" type="0" reserved="1" os_list="linux,windows" file_path=""/> + <item id="unwanted_software_report" added_in_milestone="70" hash_code="43759504" type="0" content_hash_code="59154788" os_list="windows" file_path="chrome/chrome_cleaner/logging/reporter_logging_service.cc"/> + <item id="update_client" added_in_milestone="74" hash_code="54845618" type="0" content_hash_code="86129031" os_list="linux,windows,android" file_path="components/update_client/net/network_impl.cc"/> + <item id="url_fetcher_downloader" added_in_milestone="62" hash_code="113231892" type="0" deprecated="2019-02-09" content_hash_code="61085066" file_path=""/> + <item id="url_prevision_fetcher" added_in_milestone="62" hash_code="118389509" type="0" content_hash_code="66145513" os_list="linux,windows,android" file_path="content/browser/media/url_provision_fetcher.cc"/> + <item id="user_info_fetcher" added_in_milestone="62" hash_code="22265491" type="0" content_hash_code="72016232" os_list="linux,windows,android" file_path="components/policy/core/common/cloud/user_info_fetcher.cc"/> + <item id="video_tutorial_fetcher" added_in_milestone="87" hash_code="69879956" type="0" content_hash_code="121911479" os_list="linux,windows,android" file_path="chrome/browser/video_tutorials/internal/tutorial_fetcher.cc"/> + <item id="web_app_origin_association_download" added_in_milestone="90" hash_code="128608592" type="0" content_hash_code="55648317" os_list="linux,windows,android" file_path="components/webapps/services/web_app_origin_association/web_app_origin_association_fetcher.cc"/> + <item id="web_bundle_loader" added_in_milestone="84" hash_code="114615359" type="0" content_hash_code="57390734" os_list="linux,windows,android" file_path="content/browser/web_package/web_bundle_utils.cc"/> + <item id="web_history_counter" added_in_milestone="62" hash_code="137457845" type="1" second_id="110307337" content_hash_code="49663381" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="4" file_path="components/browsing_data/core/counters/history_counter.cc"/> + <item id="web_history_delete_url" added_in_milestone="74" hash_code="41749213" type="1" second_id="110307337" content_hash_code="25943026" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="4" file_path="components/history/core/browser/history_service.cc"/> + <item id="web_history_expire" added_in_milestone="62" hash_code="60946824" type="1" second_id="110307337" content_hash_code="92626030" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="4" file_path="components/history/core/browser/browsing_history_service.cc"/> + <item id="web_history_expire_between_dates" added_in_milestone="62" hash_code="126122632" type="1" second_id="110307337" content_hash_code="34304787" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="4" file_path="components/history/core/browser/history_service.cc"/> + <item id="web_history_query" added_in_milestone="62" hash_code="17400350" type="1" second_id="110307337" content_hash_code="36075147" os_list="linux,windows,android" semantics_fields="2,3,4" policy_fields="4" file_path="components/history/core/browser/browsing_history_service.cc"/> + <item id="web_history_service" added_in_milestone="65" hash_code="110307337" type="2" content_hash_code="16140045" os_list="linux,windows,android" semantics_fields="1,5" policy_fields="-1,3" file_path="components/history/core/browser/web_history_service.cc"/> + <item id="web_push_message" added_in_milestone="77" hash_code="39886742" type="0" content_hash_code="110064650" os_list="linux,windows,android" file_path="chrome/browser/sharing/web_push/web_push_sender.cc"/> + <item id="webid" added_in_milestone="88" hash_code="113005423" type="0" content_hash_code="121729163" os_list="linux,windows,android" file_path="content/browser/webid/idp_network_request_manager.cc"/> + <item id="webrtc_event_log_uploader" added_in_milestone="67" hash_code="24186190" type="0" content_hash_code="11005245" os_list="linux,windows,android" file_path="chrome/browser/media/webrtc/webrtc_event_log_uploader.cc"/> + <item id="webrtc_log_upload" added_in_milestone="62" hash_code="62443804" type="0" content_hash_code="33661169" os_list="linux,windows,android" file_path="chrome/browser/media/webrtc/webrtc_log_uploader.cc"/> + <item id="webrtc_peer_connection" added_in_milestone="66" hash_code="63497370" type="0" content_hash_code="60553259" os_list="linux,windows,android" file_path="third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc"/> + <item id="websocket_basic_stream" added_in_milestone="66" hash_code="51586722" type="0" content_hash_code="68121427" os_list="linux,windows,android" file_path="net/websockets/websocket_basic_stream.cc"/> + <item id="websocket_stream" added_in_milestone="62" hash_code="17188928" type="0" content_hash_code="7250776" os_list="linux,windows,android" file_path="content/browser/websockets/websocket_connector_impl.cc"/> + <item id="webstore_data_fetcher" added_in_milestone="62" hash_code="26302604" type="0" content_hash_code="24000746" os_list="linux,windows" file_path="chrome/browser/extensions/webstore_data_fetcher.cc"/> + <item id="webstore_install_helper" added_in_milestone="62" hash_code="25921771" type="0" content_hash_code="10206361" os_list="linux,windows" file_path="chrome/browser/extensions/webstore_install_helper.cc"/> + <item id="webstore_installer" added_in_milestone="62" hash_code="18764319" type="0" content_hash_code="70871152" os_list="linux,windows" file_path="chrome/browser/extensions/webstore_installer.cc"/> + <item id="webui_content_scripts_download" added_in_milestone="62" hash_code="100545943" type="0" content_hash_code="119898059" os_list="linux,windows" file_path="extensions/browser/guest_view/web_view/web_ui/web_ui_url_fetcher.cc"/> + <item id="well_known_path_that_should_not_exist" added_in_milestone="86" hash_code="134618785" type="0" content_hash_code="55913167" os_list="linux,windows,android" file_path="components/password_manager/core/browser/well_known_change_password_state.cc"/> + <item id="whats_new_handler" added_in_milestone="94" hash_code="127739401" type="0" content_hash_code="94869759" os_list="linux,windows" file_path="chrome/browser/ui/webui/whats_new/whats_new_handler.cc"/> + <item id="worker_script_load" added_in_milestone="72" hash_code="72087791" type="0" content_hash_code="24889169" os_list="linux,windows,android" file_path="content/browser/worker_host/worker_script_fetcher.cc"/> + <item id="xmpp_signal_strategy" added_in_milestone="66" hash_code="88906454" type="0" deprecated="2019-07-16" content_hash_code="88958321" file_path=""/> + <item id="partner_bookmarks_reader_get_favicon" added_in_milestone="95" hash_code="117076039" type="0" content_hash_code="25601374" os_list="android" file_path="chrome/browser/android/bookmarks/partner_bookmarks_reader.cc"/> + <item id="contextual_search_resolve" added_in_milestone="95" hash_code="91714136" type="0" content_hash_code="132646203" os_list="android" file_path="chrome/browser/android/contextualsearch/contextual_search_delegate.cc"/> + <item id="customtabs_parallel_request" added_in_milestone="95" hash_code="100314494" type="0" content_hash_code="46579473" os_list="android" file_path="chrome/browser/android/customtabs/detached_resource_request.cc"/> + <item id="explore_sites_catalog_fetcher" added_in_milestone="95" hash_code="116379208" type="0" content_hash_code="83706664" os_list="android" file_path="chrome/browser/android/explore_sites/ntp_json_fetcher.cc"/> + <item id="chrome_android_hats" added_in_milestone="95" hash_code="101758430" type="0" content_hash_code="35444149" os_list="android" file_path="chrome/browser/android/survey/http_client_type.cc"/> + <item id="chime_sdk" added_in_milestone="95" hash_code="41918719" type="0" content_hash_code="18148506" os_list="android" file_path="chrome/browser/android/survey/http_client_type.cc"/> + <item id="download_manager_service_retry" added_in_milestone="95" hash_code="94349488" type="0" content_hash_code="17058904" os_list="android" file_path="chrome/browser/download/android/download_manager_service.cc"/> + <item id="download_bitmap" added_in_milestone="95" hash_code="43552293" type="0" content_hash_code="104001335" os_list="android" file_path="chrome/browser/share/bitmap_download_request.cc"/> + <item id="supervised_users_denylist" added_in_milestone="95" hash_code="16113717" type="0" content_hash_code="30325503" os_list="android" file_path="chrome/browser/supervised_user/supervised_user_service.cc"/> + <item id="autofill_service" added_in_milestone="95" hash_code="60564633" type="0" content_hash_code="107436856" os_list="android" file_path="components/autofill_assistant/browser/service/service_request_sender_impl.cc"/> + <item id="publish_note_request" added_in_milestone="95" hash_code="80314062" type="0" content_hash_code="32108728" os_list="android" file_path="components/content_creation/notes/core/server/notes_server_saver.cc"/> + <item id="cached_image_fetcher" added_in_milestone="95" hash_code="60854959" type="0" content_hash_code="104024621" os_list="android" file_path="components/image_fetcher/image_fetcher_bridge.cc"/> + <item id="explore_sites_image_fetcher" added_in_milestone="95" hash_code="43789757" type="0" content_hash_code="12081909" os_list="android" file_path="chrome/browser/android/explore_sites/explore_sites_bridge_experimental.cc"/> + <item id="explore_sites" added_in_milestone="95" hash_code="32926054" type="0" content_hash_code="14488420" os_list="android" file_path="chrome/browser/android/explore_sites/explore_sites_fetcher.cc"/> + <item id="rlz" added_in_milestone="95" hash_code="113024" type="0" content_hash_code="76646185" os_list="android" file_path="chrome/browser/android/rlz/rlz_ping_handler.cc"/> + <item id="family_info" added_in_milestone="95" hash_code="30913825" type="0" content_hash_code="25369370" os_list="android" file_path="chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc"/> + <item id="permission_request_creator" added_in_milestone="95" hash_code="43206794" type="0" content_hash_code="73571699" os_list="android" file_path="chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc"/> + <item id="kids_chrome_management_client_classify_url" added_in_milestone="95" hash_code="109987793" type="0" content_hash_code="112740597" os_list="android" file_path="chrome/browser/supervised_user/kids_chrome_management/kids_chrome_management_client.cc"/> + <item id="gstatic_onboarding_definition" added_in_milestone="95" hash_code="115438514" type="0" content_hash_code="98905665" os_list="android" file_path="components/autofill_assistant/browser/autofill_assistant_onboarding_fetcher.cc"/> + <item id="gstatic_change_password_scripts" added_in_milestone="95" hash_code="80087759" type="0" content_hash_code="64365159" os_list="android" file_path="components/password_manager/core/browser/password_scripts_fetcher_impl.cc"/> +</annotations> diff --git a/chromium/tools/traffic_annotation/summary/grouping.xml b/chromium/tools/traffic_annotation/summary/grouping.xml index 74c3dab2659..5968908d8c0 100644 --- a/chromium/tools/traffic_annotation/summary/grouping.xml +++ b/chromium/tools/traffic_annotation/summary/grouping.xml @@ -42,6 +42,7 @@ hidden="true" so that these annotations don't show up in the document. <traffic_annotation unique_id="auction_downloader"/> <traffic_annotation unique_id="auction_report_sender"/> <traffic_annotation unique_id="interest_group_update_fetcher"/> + <traffic_annotation unique_id="shared_storage_worklet_module_script_downloader"/> <traffic_annotation unique_id="prefetch_proxy_canary_check"/> <traffic_annotation unique_id="proxy_config_windows_resolver"/> <traffic_annotation unique_id="remoting_directory_delete_host"/> @@ -213,7 +214,6 @@ hidden="true" so that these annotations don't show up in the document. <traffic_annotation unique_id="safe_browsing_extended_reporting"/> <traffic_annotation unique_id="safe_browsing_feedback"/> <traffic_annotation unique_id="safe_browsing_incident"/> - <traffic_annotation unique_id="safe_browsing_module_loader"/> <traffic_annotation unique_id="safe_browsing_v4_get_hash"/> <traffic_annotation unique_id="safe_browsing_v4_update"/> <traffic_annotation unique_id="safe_browsing_binary_upload_app"/> @@ -231,6 +231,10 @@ hidden="true" so that these annotations don't show up in the document. <sender name="Federated Learning of Cohorts (FLoC)"> <traffic_annotation unique_id="floc_event_logger"/> </sender> + <sender name="Aggregation Service"> + <traffic_annotation unique_id="aggregation_service_helper_keys"/> + <traffic_annotation unique_id="aggregation_service_report"/> + </sender> </group> <group name="Identity and Security"> <sender name="Accounts, Identity, and Authentication"> @@ -341,7 +345,6 @@ hidden="true" so that these annotations don't show up in the document. <traffic_annotation unique_id="javascript_report_error"/> </sender> <sender name="Chrome Performance, Feedback, and Usage Statistics"> - <traffic_annotation unique_id="background_performance_tracer"/> <traffic_annotation unique_id="chrome_feedback_report_app"/> <traffic_annotation unique_id="metrics_report_ukm"/> <traffic_annotation unique_id="metrics_report_uma"/> @@ -388,7 +391,6 @@ hidden="true" so that these annotations don't show up in the document. <traffic_annotation unique_id="nux_ntp_background_preview"/> <traffic_annotation unique_id="photos_service"/> <traffic_annotation unique_id="popular_sites_fetch"/> - <traffic_annotation unique_id="search_suggest_service"/> <traffic_annotation unique_id="remote_suggestions_provider"/> <traffic_annotation unique_id="promo_service"/> <traffic_annotation unique_id="task_module_service"/> diff --git a/chromium/tools/translation/PRESUBMIT.py b/chromium/tools/translation/PRESUBMIT.py index 50e0eca79c1..8340eb3acfc 100644 --- a/chromium/tools/translation/PRESUBMIT.py +++ b/chromium/tools/translation/PRESUBMIT.py @@ -9,14 +9,27 @@ def _CommonChecks(input_api, output_api): results = [] # Run Pylint over the files in the directory. - pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api) + pylint_checks = input_api.canned_checks.GetPylint(input_api, + output_api, + version='2.6') results.extend(input_api.RunTests(pylint_checks)) # Run unittests. tests = input_api.canned_checks.GetUnitTestsInDirectory( - input_api, output_api, '.', [ r'^.+_unittest\.py$']) - tests.extend(input_api.canned_checks.GetUnitTestsInDirectory( - input_api, output_api, 'helper', [ r'^.+_unittest\.py$'])) + input_api, + output_api, + '.', [r'^.+_unittest\.py$'], + run_on_python2=False, + run_on_python3=True, + skip_shebang_check=True) + tests.extend( + input_api.canned_checks.GetUnitTestsInDirectory(input_api, + output_api, + 'helper', + [r'^.+_unittest\.py$'], + run_on_python2=False, + run_on_python3=True, + skip_shebang_check=True)) results.extend(input_api.RunTests(tests)) return results diff --git a/chromium/tools/translation/helper/translation_helper.py b/chromium/tools/translation/helper/translation_helper.py index 299e1dfc70f..5375da0fe65 100644 --- a/chromium/tools/translation/helper/translation_helper.py +++ b/chromium/tools/translation/helper/translation_helper.py @@ -16,7 +16,7 @@ if sys.version_info.major != 2: basestring = str # pylint: disable=redefined-builtin -class GRDFile(object): +class GRDFile: """Class representing a grd xml file. Attributes: diff --git a/chromium/tools/translation/helper/translation_helper_unittest.py b/chromium/tools/translation/helper/translation_helper_unittest.py index 329cef7d2b4..12295daa803 100644 --- a/chromium/tools/translation/helper/translation_helper_unittest.py +++ b/chromium/tools/translation/helper/translation_helper_unittest.py @@ -6,7 +6,6 @@ import unittest import os import sys -# pylint: disable=relative-import import translation_helper here = os.path.realpath(__file__) @@ -49,7 +48,7 @@ class TcHelperTest(unittest.TestCase): '%s needs to be updated. Please fix these issues:\n' ' - not_translated.grd is listed in the translation expectations, ' 'but this grd file does not exist.' % TRANSLATION_EXPECTATIONS, - context.exception.message) + str(context.exception)) # The expectations list an internal file (internal.grd), but the grd list # doesn't contain it. @@ -64,7 +63,7 @@ class TcHelperTest(unittest.TestCase): '%s needs to be updated. Please fix these issues:\n' ' - internal.grd is listed in translation expectations as an internal ' 'file to be ignored, but this grd file does not exist.' % - TRANSLATION_EXPECTATIONS, context.exception.message) + TRANSLATION_EXPECTATIONS, str(context.exception)) # The expectations list a translatable file (test.grd), but the grd list # doesn't contain it. @@ -79,7 +78,7 @@ class TcHelperTest(unittest.TestCase): '%s needs to be updated. Please fix these issues:\n' ' - test.grd is listed in the translation expectations, but this grd ' 'file does not exist.' % TRANSLATION_EXPECTATIONS, - context.exception.message) + str(context.exception)) # The grd list contains a file (part.grdp) that's not listed in translation # expectations. @@ -95,7 +94,7 @@ class TcHelperTest(unittest.TestCase): '%s needs to be updated. Please fix these issues:\n' ' - part.grdp appears to be translatable (because it contains <file> ' 'or <message> elements), but is not listed in the translation ' - 'expectations.' % TRANSLATION_EXPECTATIONS, context.exception.message) + 'expectations.' % TRANSLATION_EXPECTATIONS, str(context.exception)) if __name__ == '__main__': diff --git a/chromium/tools/translation/upload_screenshots.py b/chromium/tools/translation/upload_screenshots.py index 54f7b2c9817..117ecce63b7 100755 --- a/chromium/tools/translation/upload_screenshots.py +++ b/chromium/tools/translation/upload_screenshots.py @@ -17,6 +17,11 @@ It will attempt to upload the image anyways. """ from __future__ import print_function +try: + # In Python2, override input with raw_input for compatibility. + input = raw_input # pylint: disable=redefined-builtin +except NameError: + pass import argparse import sys @@ -58,7 +63,7 @@ else: def query_yes_no(question, default='no'): - """Ask a yes/no question via raw_input() and return their answer. + """Ask a yes/no question via input() and return their answer. "question" is a string that is presented to the user. "default" is the presumed answer if the user just hits <Enter>. @@ -79,13 +84,12 @@ def query_yes_no(question, default='no'): valid = {'yes': True, 'y': True, 'ye': True, 'no': False, 'n': False} while True: print(question, prompt) - choice = raw_input().lower() + choice = input().lower() if default is not None and choice == '': return valid[default] - elif choice in valid: + if choice in valid: return valid[choice] - else: - print("Please respond with 'yes' or 'no' (or 'y' or 'n').") + print("Please respond with 'yes' or 'no' (or 'y' or 'n').") def find_screenshots(repo_root, translation_expectations): @@ -156,16 +160,16 @@ def main(): "screenshot at path/to/file_grd/IDS_HELLO_WORLD.png.\n" "- If you added a new, uncommitted .grd file, `git add` it so that " "this script can pick up its screenshot directory.") - exit(0) + sys.exit(0) print('Found %d updated screenshot(s): ' % len(screenshots)) for s in screenshots: print(' %s' % s) print() - if not query_yes_no( - 'Do you want to upload these to Google Cloud Storage?\n\n' - 'FILES WILL BE PUBLIC, DO NOT UPLOAD ANYTHING CONFIDENTIAL.'): - exit(0) + if not query_yes_no('Do you want to upload these to Google Cloud Storage?\n\n' + 'FILES WILL BE VISIBLE TO A LARGE NUMBER OF PEOPLE. ' + 'DO NOT UPLOAD ANYTHING CONFIDENTIAL.'): + sys.exit(0) # Creating a standard gsutil object, assuming there are depot_tools # and everything related is set up already. @@ -184,7 +188,7 @@ def main(): gzip=None) != 0: print ('Error uploading screenshots. Try running ' '`download_from_google_storage --config`.') - exit(1) + sys.exit(1) print() print('Images are uploaded and their signatures are calculated:') @@ -199,7 +203,7 @@ def main(): # no-op. if not query_yes_no('Do you want to add these files to your CL?', default='yes'): - exit(0) + sys.exit(0) if not args.dry_run: git_helper.git_add(signatures, src_path) diff --git a/chromium/tools/translation/upload_screenshots_unittest.py b/chromium/tools/translation/upload_screenshots_unittest.py index 99b96950cd0..a96bf3ba257 100755 --- a/chromium/tools/translation/upload_screenshots_unittest.py +++ b/chromium/tools/translation/upload_screenshots_unittest.py @@ -19,11 +19,11 @@ class UploadTests(unittest.TestCase): screenshots = upload_screenshots.find_screenshots( testdata_path, os.path.join(testdata_path, 'translation_expectations.pyl')) - self.assertEquals(2, len(screenshots)) - self.assertEquals( + self.assertEqual(2, len(screenshots)) + self.assertEqual( os.path.join(testdata_path, 'test_grd', 'IDS_TEST_STRING1.png'), screenshots[0]) - self.assertEquals( + self.assertEqual( os.path.join(testdata_path, 'part_grdp', 'IDS_PART_STRING2.png'), screenshots[1]) diff --git a/chromium/tools/typescript/definitions/autofill_private.d.ts b/chromium/tools/typescript/definitions/autofill_private.d.ts new file mode 100644 index 00000000000..2183427f6c2 --- /dev/null +++ b/chromium/tools/typescript/definitions/autofill_private.d.ts @@ -0,0 +1,117 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/** @fileoverview Definitions for chrome.autofillPrivate API */ +// TODO(crbug.com/1203307): Auto-generate this file. + +import {ChromeEvent} from './chrome_event.js'; + +declare global { + export namespace chrome { + export namespace autofillPrivate { + + export enum AddressField { + HONORIFIC = 'HONORIFIC', + FULL_NAME = 'FULL_NAME', + COMPANY_NAME = 'COMPANY_NAME', + ADDRESS_LINES = 'ADDRESS_LINES', + ADDRESS_LEVEL_1 = 'ADDRESS_LEVEL_1', + ADDRESS_LEVEL_2 = 'ADDRESS_LEVEL_2', + ADDRESS_LEVEL_3 = 'ADDRESS_LEVEL_3', + POSTAL_CODE = 'POSTAL_CODE', + SORTING_CODE = 'SORTING_CODE', + COUNTRY_CODE = 'COUNTRY_CODE', + } + + export interface AutofillMetadata { + summaryLabel: string; + summarySublabel?: string; + isLocal?: boolean; + isCached?: boolean; + isMigratable?: boolean; + } + + export interface AddressEntry { + guid?: string; + fullNames?: Array<string>; + honorific?: string; + companyName?: string; + addressLines?: string; + addressLevel1?: string; + addressLevel2?: string; + addressLevel3?: string; + postalCode?: string; + sortingCode?: string; + countryCode?: string; + phoneNumbers?: Array<string>; + emailAddresses?: Array<string>; + languageCode?: string; + metadata?: AutofillMetadata; + } + + export interface CountryEntry { + name?: string; + countryCode?: string; + } + + export interface AddressComponent { + field: AddressField; + fieldName: string; + isLongField: boolean; + placeholder?: string; + } + + export interface AddressComponentRow { + row: Array<AddressComponent>; + } + + export interface AddressComponents { + components: Array<AddressComponentRow>; + languageCode: string; + } + + export interface CreditCardEntry { + guid?: string; + name?: string; + cardNumber?: string; + expirationMonth?: string; + expirationYear?: string; + nickname?: string; + metadata?: AutofillMetadata; + } + + export interface ValidatePhoneParams { + phoneNumbers: Array<string>; + indexOfNewNumber: number; + countryCode: string; + } + + export function saveAddress(address: AddressEntry): void; + export function getCountryList( + callback: (entries: Array<CountryEntry>) => void): void; + export function getAddressComponents( + countryCode: string, + callback: (components: AddressComponents) => void): void; + export function getAddressList( + callback: (entries: Array<AddressEntry>) => void): void; + export function saveCreditCard(card: CreditCardEntry): void; + export function removeEntry(guid: string): void; + export function validatePhoneNumbers( + params: ValidatePhoneParams, + callback: (numbers: Array<string>) => void): void; + export function getCreditCardList( + callback: (entries: Array<CreditCardEntry>) => void): void; + export function maskCreditCard(guid: string): void; + export function migrateCreditCards(): void; + export function logServerCardLinkClicked(): void; + export function setCreditCardFIDOAuthEnabledState(enabled: boolean): void; + export function getUpiIdList(callback: (items: Array<string>) => void): + void; + + export const onPersonalDataChanged: ChromeEvent< + (addresses: Array<AddressEntry>, + creditCards: Array<CreditCardEntry>) => void>; + } + } +} diff --git a/chromium/tools/typescript/definitions/bookmark_manager_private.d.ts b/chromium/tools/typescript/definitions/bookmark_manager_private.d.ts index e832a928789..00ed54863d1 100644 --- a/chromium/tools/typescript/definitions/bookmark_manager_private.d.ts +++ b/chromium/tools/typescript/definitions/bookmark_manager_private.d.ts @@ -44,7 +44,7 @@ declare global { export function undo(): void; export function redo(): void; - type DragData = { + export type DragData = { elements: chrome.bookmarks.BookmarkTreeNode[]|null; sameProfile: boolean; }; diff --git a/chromium/tools/typescript/definitions/language_settings_private.d.ts b/chromium/tools/typescript/definitions/language_settings_private.d.ts new file mode 100644 index 00000000000..77393d1a3e8 --- /dev/null +++ b/chromium/tools/typescript/definitions/language_settings_private.d.ts @@ -0,0 +1,91 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/** @fileoverview Definitions for chrome.languageSettingsPrivate API */ +// TODO(crbug.com/1203307): Auto-generate this file. + +import {ChromeEvent} from './chrome_event.js'; + +declare global { + export namespace chrome { + export namespace languageSettingsPrivate { + export enum MoveType { + TOP = 'TOP', + UP = 'UP', + DOWN = 'DOWN', + UNKNOWN = 'UNKNOWN', + } + + export interface Language { + code: string; + displayName: string; + nativeDisplayName: string; + supportsUI?: boolean; + supportsSpellcheck?: boolean; + supportsTranslate?: boolean; + isProhibitedLanguage?: boolean; + } + + export interface SpellcheckDictionaryStatus { + languageCode: string; + isReady: boolean; + isDownloading?: boolean; + downloadFailed?: boolean; + } + + export interface InputMethod { + id: string; + displayName: string; + languageCodes: Array<string>; + tags: Array<string>; + enabled?: boolean; + hasOptionsPage?: boolean; + isProhibitedByPolicy?: boolean; + } + + export interface InputMethodLists { + componentExtensionImes: Array<InputMethod>; + thirdPartyExtensionImes: Array<InputMethod>; + } + + type StringArrayCallback = (strings: Array<string>) => void; + + export function getLanguageList( + callback: (languages: Array<Language>) => void): void; + export function enableLanguage(languageCode: string): void; + export function disableLanguage(languageCode: string): void; + export function setEnableTranslationForLanguage( + languageCode: string, enable: boolean): void; + export function moveLanguage(languageCode: string, moveType: MoveType): + void; + export function getAlwaysTranslateLanguages( + callback: StringArrayCallback): void; + export function setLanguageAlwaysTranslateState( + languageCode: string, alwaysTranslate: boolean): void; + export function getNeverTranslateLanguages(callback: StringArrayCallback): + void; + export function getSpellcheckDictionaryStatuses( + callback: (statuses: Array<SpellcheckDictionaryStatus>) => void): + void; + export function getSpellcheckWords(callback: StringArrayCallback): void; + export function addSpellcheckWord(word: string): void; + export function removeSpellcheckWord(word: string): void; + export function getTranslateTargetLanguage( + callback: (languageCode: string) => void): void; + export function setTranslateTargetLanguage(languageCode: string): void; + export function getInputMethodLists( + callback: (lists: InputMethodLists) => void): void; + export function addInputMethod(inputMethodId: string): void; + export function removeInputMethod(inputMethodId: string): void; + export function retryDownloadDictionary(languageCode: string): void; + + export const onSpellcheckDictionariesChanged: + ChromeEvent<(statuses: Array<SpellcheckDictionaryStatus>) => void>; + export const onCustomDictionaryChanged: + ChromeEvent<(added: Array<string>, removed: Array<string>) => void>; + export const onInputMethodAdded: ChromeEvent<(id: string) => void>; + export const onInputMethodRemoved: ChromeEvent<(id: string) => void>; + } + } +} diff --git a/chromium/tools/typescript/definitions/passwords_private.d.ts b/chromium/tools/typescript/definitions/passwords_private.d.ts new file mode 100644 index 00000000000..b23cf118c7c --- /dev/null +++ b/chromium/tools/typescript/definitions/passwords_private.d.ts @@ -0,0 +1,154 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/** @fileoverview Definitions for chrome.passwordsPrivate API */ +// TODO(crbug.com/1203307): Auto-generate this file. + +import {ChromeEvent} from './chrome_event.js'; + +declare global { + export namespace chrome { + export namespace passwordsPrivate { + export enum PlaintextReason { + VIEW = 'VIEW', + COPY = 'COPY', + EDIT = 'EDIT', + } + + export enum ExportProgressStatus { + NOT_STARTED = 'NOT_STARTED', + IN_PROGRESS = 'IN_PROGRESS', + SUCCEEDED = 'SUCCEEDED', + FAILED_CANCELLED = 'FAILED_CANCELLED', + FAILED_WRITE_FAILED = 'FAILED_WRITE_FAILED', + } + + export enum CompromiseType { + LEAKED = 'LEAKED', + PHISHED = 'PHISHED', + PHISHED_AND_LEAKED = 'PHISHED_AND_LEAKED', + } + + export enum PasswordCheckState { + IDLE = 'IDLE', + RUNNING = 'RUNNING', + CANCELED = 'CANCELED', + OFFLINE = 'OFFLINE', + SIGNED_OUT = 'SIGNED_OUT', + NO_PASSWORDS = 'NO_PASSWORDS', + QUOTA_LIMIT = 'QUOTA_LIMIT', + OTHER_ERROR = 'OTHER_ERROR', + } + + export interface UrlCollection { + origin: string; + shown: string; + link: string; + } + + export interface PasswordUiEntry { + urls: UrlCollection; + username: string; + federationText?: string; + id: number; + frontendId: number; + fromAccountStore: boolean; + } + + export interface ExceptionEntry { + urls: UrlCollection; + id: number; + frontendId: number; + fromAccountStore: boolean; + } + + export interface PasswordExportProgress { + status: ExportProgressStatus; + folderName?: string; + } + + export interface CompromisedInfo { + compromiseTime: number; + elapsedTimeSinceCompromise: string; + compromiseType: CompromiseType; + } + + export interface InsecureCredential { + id: number; + formattedOrigin: string; + detailedOrigin: string; + isAndroidCredential: boolean; + changePasswordUrl?: string; + signonRealm: string; + username: string; + password?: string; + compromisedInfo?: CompromisedInfo; + } + + export interface PasswordCheckStatus { + state: PasswordCheckState; + alreadyProcessed?: number; + remainingInQueue?: number; + elapsedTimeSinceLastCheck?: string; + } + + export function recordPasswordsPageAccessInSettings(): void; + export function changeSavedPassword( + ids: Array<number>, newUsername: string, newPassword: string, + callback?: () => void): void; + export function removeSavedPassword(id: number): void; + export function removeSavedPasswords(ids: Array<number>): void; + export function removePasswordException(id: number): void; + export function removePasswordExceptions(ids: Array<number>): void; + export function undoRemoveSavedPasswordOrException(): void; + export function requestPlaintextPassword( + id: number, reason: PlaintextReason, + callback: (password: string) => void): void; + export function getSavedPasswordList( + callback: (entries: Array<PasswordUiEntry>) => void): void; + export function getPasswordExceptionList( + callback: (entries: Array<ExceptionEntry>) => void): void; + export function movePasswordsToAccount(ids: Array<number>): void; + export function importPasswords(): void; + export function exportPasswords(callback: () => void): void; + export function requestExportProgressStatus( + callback: (status: ExportProgressStatus) => void): void; + export function cancelExportPasswords(): void; + export function isOptedInForAccountStorage( + callback: (isOptedIn: boolean) => void): void; + export function optInForAccountStorage(optIn: boolean): void; + export function getCompromisedCredentials( + callback: (credentials: Array<InsecureCredential>) => void): void; + export function getWeakCredentials( + callback: (credentials: Array<InsecureCredential>) => void): void; + export function getPlaintextInsecurePassword( + credential: InsecureCredential, reason: PlaintextReason, + callback: (credential: InsecureCredential) => void): void; + export function changeInsecureCredential( + credential: InsecureCredential, newPassword: string, + callback?: () => void): void; + export function removeInsecureCredential( + credential: InsecureCredential, callback?: () => void): void; + export function startPasswordCheck(callback?: () => void): void; + export function stopPasswordCheck(callback?: () => void): void; + export function getPasswordCheckStatus( + callback: (status: PasswordCheckStatus) => void): void; + + export const onSavedPasswordsListChanged: + ChromeEvent<(entries: Array<PasswordUiEntry>) => void>; + export const onPasswordExceptionsListChanged: + ChromeEvent<(entries: Array<ExceptionEntry>) => void>; + export const onPasswordsFileExportProgress: + ChromeEvent<(progress: PasswordExportProgress) => void>; + export const onAccountStorageOptInStateChanged: + ChromeEvent<(optInState: boolean) => void>; + export const onCompromisedCredentialsChanged: + ChromeEvent<(credentials: Array<InsecureCredential>) => void>; + export const onWeakCredentialsChanged: + ChromeEvent<(credentials: Array<InsecureCredential>) => void>; + export const onPasswordCheckStatusChanged: + ChromeEvent<(status: PasswordCheckStatus) => void>; + } + } +} diff --git a/chromium/tools/typescript/definitions/quick_unlock_private.d.ts b/chromium/tools/typescript/definitions/quick_unlock_private.d.ts new file mode 100644 index 00000000000..09545772e80 --- /dev/null +++ b/chromium/tools/typescript/definitions/quick_unlock_private.d.ts @@ -0,0 +1,18 @@ +// Copyright 2021 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +/** @fileoverview Definitions for chrome.quickUnlockPrivate API */ +// TODO(crbug.com/1203307): Auto-generate this file. + +declare namespace chrome { + export namespace quickUnlockPrivate { + export interface TokenInfo { + token: string; + lifetimeSeconds: number; + } + + export function getAuthToken( + accountPassword: string, onComplete: (info: TokenInfo) => void): void; + } +} diff --git a/chromium/tools/typescript/definitions/settings_private.d.ts b/chromium/tools/typescript/definitions/settings_private.d.ts index 6a6413888f4..9a5b972e3b6 100644 --- a/chromium/tools/typescript/definitions/settings_private.d.ts +++ b/chromium/tools/typescript/definitions/settings_private.d.ts @@ -5,48 +5,63 @@ /** @fileoverview Definitions for chrome.settingsPrivate API */ // TODO(crbug.com/1203307): Auto-generate this file. -declare namespace chrome { - export namespace settingsPrivate { - export enum PrefType { - BOOLEAN = 'BOOLEAN', - NUMBER = 'NUMBER', - STRING = 'STRING', - URL = 'URL', - LIST = 'LIST', - DICTIONARY = 'DICTIONARY', - } +import {ChromeEvent} from './chrome_event.js'; - export enum ControlledBy { - DEVICE_POLICY = 'DEVICE_POLICY', - USER_POLICY = 'USER_POLICY', - OWNER = 'OWNER', - PRIMARY_USER = 'PRIMARY_USER', - EXTENSION = 'EXTENSION', - PARENT = 'PARENT', - CHILD_RESTRICTION = 'CHILD_RESTRICTION', - } +declare global { + export namespace chrome { + export namespace settingsPrivate { + export enum PrefType { + BOOLEAN = 'BOOLEAN', + NUMBER = 'NUMBER', + STRING = 'STRING', + URL = 'URL', + LIST = 'LIST', + DICTIONARY = 'DICTIONARY', + } - export enum Enforcement { - ENFORCED = 'ENFORCED', - RECOMMENDED = 'RECOMMENDED', - PARENT_SUPERVISED = 'PARENT_SUPERVISED', - } + export enum ControlledBy { + DEVICE_POLICY = 'DEVICE_POLICY', + USER_POLICY = 'USER_POLICY', + OWNER = 'OWNER', + PRIMARY_USER = 'PRIMARY_USER', + EXTENSION = 'EXTENSION', + PARENT = 'PARENT', + CHILD_RESTRICTION = 'CHILD_RESTRICTION', + } - export interface PrefObject { - key: string; - type: PrefType; - value: any; - controlledBy?: ControlledBy; - controlledByName?: string; - enforcement?: Enforcement; - recommendedValue?: any; - userSelectableValues?: Array<any>; - userControlDisabled?: boolean; - extensionId?: string; - extensionCanBeDisabled?: boolean; - } + export enum Enforcement { + ENFORCED = 'ENFORCED', + RECOMMENDED = 'RECOMMENDED', + PARENT_SUPERVISED = 'PARENT_SUPERVISED', + } + + export interface PrefObject { + key: string; + type: PrefType; + value: any; + controlledBy?: ControlledBy; + controlledByName?: string; + enforcement?: Enforcement; + recommendedValue?: any; + userSelectableValues?: Array<any>; + userControlDisabled?: boolean; + extensionId?: string; + extensionCanBeDisabled?: boolean; + } - export function getDefaultZoom(callback: (zoom: number) => void): void; - export function setDefaultZoom(zoom: number): void; + type PrefsCallback = (prefs: Array<PrefObject>) => void; + + export function getAllPrefs(callback: PrefsCallback): void; + export function getPref( + name: string, callback: (pref: PrefObject) => void): void; + export function setPref( + name: string, value: any, pageId?: string, + callback?: (success: boolean) => void): void; + + export function getDefaultZoom(callback: (zoom: number) => void): void; + export function setDefaultZoom(zoom: number): void; + + export const onPrefsChanged: ChromeEvent<PrefsCallback>; + } } } diff --git a/chromium/tools/typescript/ts_definitions.gni b/chromium/tools/typescript/ts_definitions.gni index 7e3132308df..3127e50346f 100644 --- a/chromium/tools/typescript/ts_definitions.gni +++ b/chromium/tools/typescript/ts_definitions.gni @@ -52,6 +52,12 @@ template("ts_definitions") { } path_mappings = [ + "chrome://resources/*|" + + rebase_path("$root_gen_dir/ui/webui/resources/preprocessed/*", + target_gen_dir), + "//resources/*|" + + rebase_path("$root_gen_dir/ui/webui/resources/preprocessed/*", + target_gen_dir), "chrome://resources/polymer/v3_0/*|" + rebase_path("//third_party/polymer/v3_0/components-chromium/*", target_gen_dir), diff --git a/chromium/tools/typescript/tsconfig_base.json b/chromium/tools/typescript/tsconfig_base.json index 17bb7cb60d1..6b48ac0fef0 100644 --- a/chromium/tools/typescript/tsconfig_base.json +++ b/chromium/tools/typescript/tsconfig_base.json @@ -13,6 +13,7 @@ "noUncheckedIndexedAccess": true, "noUnusedLocals": true, "noUnusedParameters": true, - "strict": true + "strict": true, + "typeRoots": [] } } diff --git a/chromium/tools/v8_context_snapshot/BUILD.gn b/chromium/tools/v8_context_snapshot/BUILD.gn index 6e86a543558..6817e654af7 100644 --- a/chromium/tools/v8_context_snapshot/BUILD.gn +++ b/chromium/tools/v8_context_snapshot/BUILD.gn @@ -97,8 +97,8 @@ if (use_v8_context_snapshot) { visibility = [ ":*" ] # Only targets in this file can depend on this. if (is_win) { ldflags = [ "/OPT:NOICF" ] # link.exe, but also lld-link.exe. - } else if (is_apple) { - ldflags = [ "-Wl,-no_deduplicate" ] # ld64, and ld64.lld. + } else if (is_apple && !use_lld) { + ldflags = [ "-Wl,-no_deduplicate" ] # ld64. } else if (use_gold || use_lld) { ldflags = [ "-Wl,--icf=none" ] } diff --git a/chromium/tools/v8_context_snapshot/v8_context_snapshot.gni b/chromium/tools/v8_context_snapshot/v8_context_snapshot.gni index 811ab556625..193ace7fa42 100644 --- a/chromium/tools/v8_context_snapshot/v8_context_snapshot.gni +++ b/chromium/tools/v8_context_snapshot/v8_context_snapshot.gni @@ -30,6 +30,13 @@ declare_args() { } else if (v8_target_cpu == "arm64") { v8_context_snapshot_filename = "v8_context_snapshot.arm64.bin" } + } else if (is_android) { + if (v8_target_cpu == "arm" || v8_target_cpu == "x86" || + v8_target_cpu == "mipsel") { + v8_context_snapshot_filename = "v8_context_snapshot_32.bin" + } else { + v8_context_snapshot_filename = "v8_context_snapshot_64.bin" + } } else { v8_context_snapshot_filename = "v8_context_snapshot.bin" } diff --git a/chromium/tools/vim/PRESUBMIT.py b/chromium/tools/vim/PRESUBMIT.py index 06b5bd35e76..10dd9ac688c 100644 --- a/chromium/tools/vim/PRESUBMIT.py +++ b/chromium/tools/vim/PRESUBMIT.py @@ -27,8 +27,11 @@ def CheckChangeOnUpload(input_api, output_api): 'ninja_output.py' in affected_files or \ any([input_api.re.match(r'tests(/|\\)',f) for f in affected_files]): results += input_api.RunTests( - input_api.canned_checks.GetUnitTests(input_api, output_api, [ - 'tests/chromium.ycm_extra_conf_unittest.py' - ])) + input_api.canned_checks.GetUnitTests( + input_api, + output_api, ['tests/chromium.ycm_extra_conf_unittest.py'], + run_on_python2=False, + run_on_python3=True, + skip_shebang_check=True)) return results diff --git a/chromium/tools/vscode/settings.json5 b/chromium/tools/vscode/settings.json5 index cc9ba783cf8..eac6e6e1424 100644 --- a/chromium/tools/vscode/settings.json5 +++ b/chromium/tools/vscode/settings.json5 @@ -55,9 +55,8 @@ "C_Cpp.clang_format_path": "${workspaceFolder}/third_party/depot_tools/clang-format", "C_Cpp.clang_format_sortIncludes": true, "editor.formatOnSave": true, + "editor.formatOnSaveMode": "modifications", - // Optional: Only format modified lines instead of the whole file. - // "editor.formatOnSaveMode": "modifications", // Optional: Highlight current line at the left of the editor. // "editor.renderLineHighlight": "gutter", // Optional: Don't automatically add closing brackets. It gets in the way. diff --git a/chromium/tools/vscode/tasks.json5 b/chromium/tools/vscode/tasks.json5 index 57941b179af..704a28374c9 100644 --- a/chromium/tools/vscode/tasks.json5 +++ b/chromium/tools/vscode/tasks.json5 @@ -148,6 +148,11 @@ "label": "10-build_test_debug", "type": "shell", "command": "autoninja -C ${workspaceFolder}/out/Debug unit_tests components_unittests browser_tests" + }, + { + "label": "11-generate_compile_commands", + "type": "shell", + "command": "${workspaceFolder}/tools/clang/scripts/generate_compdb.py -p ${config:chrome.outputDir} > ${workspaceFolder}/compile_commands.json" } ] } diff --git a/chromium/tools/web_dev_style/js_checker.py b/chromium/tools/web_dev_style/js_checker.py index 47f86ec004f..2fcf4641fe7 100644 --- a/chromium/tools/web_dev_style/js_checker.py +++ b/chromium/tools/web_dev_style/js_checker.py @@ -21,8 +21,9 @@ class JSChecker(object): self.input_api.re, line_number, line, regex, message) def BindThisCheck(self, i, line): - return self.RegexCheck(i, line, r"(\.bind\(this)[^)]*\)", - "Prefer arrow (=>) functions over bind(this)"); + """Checks for usages of bind(this) with inlined functions.""" + return self.RegexCheck(i, line, r"\)(\.bind\(this)[^)]*\)", + "Prefer arrow (=>) functions over bind(this)") def ChromeSendCheck(self, i, line): """Checks for a particular misuse of "chrome.send".""" @@ -37,6 +38,10 @@ class JSChecker(object): ' // <if expr="chromeos">\n' + " // </if>\n") + def DebuggerCheck(self, i, line): + return self.RegexCheck(i, line, r"^\s*(debugger);", + "Debugger statements should be removed") + def EndJsDocCommentCheck(self, i, line): msg = "End JSDoc comments with */ instead of **/" def _check(regex): @@ -108,11 +113,13 @@ class JSChecker(object): for f in affected_js_files: error_lines = [] - for i, line in enumerate(f.NewContents(), start=1): + for i, line in f.ChangedContents(): error_lines += [ _f for _f in [ + self.BindThisCheck(i, line), self.ChromeSendCheck(i, line), self.CommentIfAndIncludeCheck(i, line), + self.DebuggerCheck(i, line), self.EndJsDocCommentCheck(i, line), self.ExtraDotInGenericCheck(i, line), self.InheritDocCheck(i, line), diff --git a/chromium/tools/web_dev_style/js_checker_test.py b/chromium/tools/web_dev_style/js_checker_test.py index 4f5bda60314..cfd3e2a6b28 100755 --- a/chromium/tools/web_dev_style/js_checker_test.py +++ b/chromium/tools/web_dev_style/js_checker_test.py @@ -25,6 +25,36 @@ class JsCheckerTest(unittest.TestCase): self.checker = js_checker.JSChecker(MockInputApi(), MockOutputApi()) + def ShouldFailDebuggerCheck(self, line): + error = self.checker.DebuggerCheck(1, line) + self.assertNotEqual("", error, "Should be flagged as style error: " + line) + highlight = test_util.GetHighlight(line, error).strip() + self.assertTrue(highlight.startswith("debugger")) + + def ShouldPassDebuggerCheck(self, line): + self.assertEqual("", self.checker.DebuggerCheck(1, line), + "Should not be flagged as style error: " + line) + + def testDebuggerFails(self): + lines = [ + "debugger;", + " debugger;", + ] + for line in lines: + self.ShouldFailDebuggerCheck(line) + + def testDebuggerPasses(self): + lines = [ + "// Test that it works in the debugger", + " // Test that it works in the debugger", + "debugger.debug(func);", + " debugger.debug(func);", + "console.log('debugger enabled');", + " console.log('debugger enabled');", + ] + for line in lines: + self.ShouldPassDebuggerCheck(line) + def ShouldFailBindThisCheck(self, line): error = self.checker.BindThisCheck(1, line) self.assertNotEqual("", error, "Should be flagged as style error: " + line) @@ -37,17 +67,19 @@ class JsCheckerTest(unittest.TestCase): def testBindThisFails(self): lines = [ - 'let bound = this.method_.bind(this);', - "document.addEventListener('click', this.onClick_.bind(this));", - 'this.api_.onEvent = this.onClick_.bind(this);', - 'this.api_.getThinger(this.gotThinger_.bind(this));', - 'this.api_.getThinger(this.gotThinger_.bind(this, param1, param2));', + 'this.api_.getThinger((function() {console.log(\'foo\');}).bind(this));', + 'this.api_.getThinger((function foo() {console.log(\'foo\');}).bind(this));', ] for line in lines: self.ShouldFailBindThisCheck(line) def testBindThisPasses(self): lines = [ + 'let bound = this.method_.bind(this);', + "document.addEventListener('click', this.onClick_.bind(this));", + 'this.api_.onEvent = this.onClick_.bind(this);', + 'this.api_.getThinger(this.gotThinger_.bind(this));', + 'this.api_.getThinger(this.gotThinger_.bind(this, param1, param2));', '// And in the darkness bind them.', 'this.methodName_.bind(scope, param)', ] diff --git a/chromium/tools/win/DebugVisualizers/blink.natvis b/chromium/tools/win/DebugVisualizers/blink.natvis index 21ac6c97869..9a44e6c0dff 100644 --- a/chromium/tools/win/DebugVisualizers/blink.natvis +++ b/chromium/tools/win/DebugVisualizers/blink.natvis @@ -1,6 +1,34 @@ <?xml version="1.0" encoding="utf-8" ?> <AutoVisualizer xmlns="http://schemas.microsoft.com/vstudio/debugger/natvis/2010"> + <!-- + !== USE_V8_OILPAN version of Member + !== Note: We need type cast to |raw_| because |raw_| is in base class + !== |cppgc::internal::MemberBase| instead of |BasicMember|. + !== See "v8/include/cppgc/member.h" + !--> + <Type Name="cppgc::internal::BasicMember<*>"> + <SmartPointer Usage="Minimal">($T1*)raw_</SmartPointer> + <DisplayString Condition="raw_ == 0">null</DisplayString> + <DisplayString>{*($T1*)raw_}</DisplayString> + <Expand> + <Item Name="Raw">($T1*)raw_</Item> + <ExpandedItem Condition="raw_ != 0">($T1*)raw_</ExpandedItem> + </Expand> + </Type> + <Type Name="cppgc::internal::BasicPersistent<*>"> + <SmartPointer Usage="Minimal">($T1*)raw_</SmartPointer> + <DisplayString Condition="raw_ == 0">null</DisplayString> + <DisplayString>{*($T1*)raw_}</DisplayString> + <Expand> + <Item Name="Raw">($T1*)raw_</Item> + <ExpandedItem Condition="raw_ != 0">($T1*)raw_</ExpandedItem> + </Expand> + </Type> + <!-- + !== !USE_V8_OILPAN version of Member + !== See "third_party/blink/renderer/platform/heap/impl/member.h" + !--> <Type Name="blink::MemberBase<*>"> <SmartPointer Usage="Minimal">raw_</SmartPointer> <DisplayString Condition="raw_ == 0">null</DisplayString> @@ -165,8 +193,8 @@ <Type Name="blink::ContainerNode"> <Expand> <LinkedListItems> - <HeadPointer>first_child_.raw_</HeadPointer> - <NextPointer>next_.raw_</NextPointer> + <HeadPointer>(blink::Node*)first_child_.raw_</HeadPointer> + <NextPointer>(blink::Node*)next_.raw_</NextPointer> <ValueNode>this</ValueNode> </LinkedListItems> </Expand> @@ -183,8 +211,8 @@ <Type Name="blink::LayoutObjectChildList"> <Expand> <LinkedListItems> - <HeadPointer>first_child_</HeadPointer> - <NextPointer>next_</NextPointer> + <HeadPointer>(blink::LayoutObject*)first_child_.raw_</HeadPointer> + <NextPointer>(blink::LayoutObject*)next_.raw_</NextPointer> <ValueNode>this</ValueNode> </LinkedListItems> </Expand> @@ -196,8 +224,8 @@ <Type Name="blink::InlineFlowBox"> <Expand> <LinkedListItems> - <HeadPointer>first_child_</HeadPointer> - <NextPointer>next_</NextPointer> + <HeadPointer>(blink::InlineFlowBox*)first_child_.raw_</HeadPointer> + <NextPointer>(blink::InlineFlowBox*)next_.raw_</NextPointer> <ValueNode>this</ValueNode> </LinkedListItems> </Expand> @@ -205,8 +233,8 @@ <Type Name="blink::InlineBoxList<blink::InlineFlowBox>"> <Expand> <LinkedListItems> - <HeadPointer>first_</HeadPointer> - <NextPointer>(blink::InlineFlowBox*)next_</NextPointer> + <HeadPointer>(blink::InlineFlowBox*)first_.raw_</HeadPointer> + <NextPointer>(blink::InlineFlowBox*)next_.raw_</NextPointer> <ValueNode>this</ValueNode> </LinkedListItems> </Expand> @@ -240,50 +268,46 @@ </Expand> </Type> <Type Name="blink::NGPhysicalFragment"> - <DisplayString>{(blink::NGPhysicalFragment::NGFragmentType)type_} {size_} {*layout_object_}</DisplayString> - <Expand> - <!-- Resolve subclasses because VS can't resolve without virtual functions --> - <ExpandedItem Condition="type_ == 0">(blink::NGPhysicalBoxFragment*)this</ExpandedItem> - <ExpandedItem Condition="type_ == 1">(blink::NGPhysicalTextFragment*)this</ExpandedItem> - <ExpandedItem Condition="type_ == 2">(blink::NGPhysicalLineBoxFragment*)this</ExpandedItem> - </Expand> + <Intrinsic Name="Type" Expression="(NGFragmentType)type_" /> + <!-- Resolve subclasses because VS can't resolve automatically when without virtual functions --> + <MostDerivedType Condition="Type() == kFragmentBox">(NGPhysicalBoxFragment*)this</MostDerivedType> + <MostDerivedType Condition="Type() == kFragmentLineBox">(NGPhysicalLineBoxFragment*)this</MostDerivedType> + <DisplayString>{Type()} {size_} {*layout_object_}</DisplayString> </Type> <Type Name="blink::NGPhysicalBoxFragment"> + <Intrinsic Name="BoxType" Expression="(NGBoxType)sub_type_" /> + <DisplayString>{BoxType()} {size_} {*layout_object_}</DisplayString> <Expand> - <Item Name="SubType">(blink::NGPhysicalFragment::NGBoxType)sub_type_</Item> + <Item Name="FragmentItems" Condition="const_has_fragment_items_"> + *(NGFragmentItems*)(&children_[const_num_children_]) + </Item> <Synthetic Name="Children"> - <DisplayString>{num_children_}</DisplayString> + <DisplayString>{const_num_children_}</DisplayString> <Expand> <ArrayItems> - <Size>num_children_</Size> + <Size>const_num_children_</Size> <ValuePointer>children_</ValuePointer> </ArrayItems> </Expand> </Synthetic> + <ExpandedItem>this,!</ExpandedItem> </Expand> </Type> <Type Name="blink::NGPhysicalLineBoxFragment"> - <Expand> - <Synthetic Name="Children"> - <DisplayString>{num_children_}</DisplayString> - <Expand> - <ArrayItems> - <Size>num_children_</Size> - <ValuePointer>children_</ValuePointer> - </ArrayItems> - </Expand> - </Synthetic> - </Expand> + <Intrinsic Name="LineBoxType" Expression="(NGLineBoxType)sub_type_" /> + <DisplayString>{LineBoxType()} {size_} {*layout_object_}</DisplayString> </Type> <Type Name="blink::NGFragmentItem"> + <Intrinsic Name="Type" Expression="(ItemType)type_" /> <Expand> - <Item Name="Type">(blink::NGFragmentItem::ItemType)type_</Item> - <Item Name="TextType" Condition="type_ == 0">(blink::NGTextType)sub_type_</Item> - <Item Name="Text" Condition="type_ == 0">text_</Item> - <Item Name="GeneratedText" Condition="type_ == 1">generated_text_</Item> - <Item Name="LineBoxType" Condition="type_ == 2">(NGPhysicalLineBoxFragment::NGLineBoxType)sub_type_</Item> - <Item Name="Line" Condition="type_ == 2">line_</Item> - <Item Name="Box" Condition="type_ == 3">box_</Item> + <Item Name="Type">Type()</Item> + <Item Name="TextType" Condition="Type() == kText">(blink::NGTextType)sub_type_</Item> + <Item Name="Text" Condition="Type() == kText">text_</Item> + <Item Name="SVGText" Condition="Type() == kSVGText">svg_text_</Item> + <Item Name="GeneratedText" Condition="Type() == kGeneratedText">generated_text_</Item> + <Item Name="LineBoxType" Condition="Type() == kLine">(NGPhysicalLineBoxFragment::NGLineBoxType)sub_type_</Item> + <Item Name="Line" Condition="Type() == kLine">line_</Item> + <Item Name="Box" Condition="Type() == kBox">box_</Item> <Item Name="layout_object_">layout_object_</Item> <Item Name="rect_">rect_</Item> <Item Name="ink_overflow_type_">(NGInkOverflow::Type)ink_overflow_type_</Item> diff --git a/chromium/tools/win/chromeexts/chrome_exts_command.h b/chromium/tools/win/chromeexts/chrome_exts_command.h index 0c484eb0950..7750bd1df78 100644 --- a/chromium/tools/win/chromeexts/chrome_exts_command.h +++ b/chromium/tools/win/chromeexts/chrome_exts_command.h @@ -43,6 +43,9 @@ class ChromeExtsCommand { return hr; } + ChromeExtsCommand(const ChromeExtsCommand&) = delete; + ChromeExtsCommand& operator=(const ChromeExtsCommand&) = delete; + virtual ~ChromeExtsCommand(); protected: @@ -72,8 +75,6 @@ class ChromeExtsCommand { base::CommandLine command_line_{base::CommandLine::NO_PROGRAM}; ComPtr<IDebugClient> debug_client_; ComPtr<IDebugControl> debug_control_; - - DISALLOW_COPY_AND_ASSIGN(ChromeExtsCommand); }; } // namespace chromeexts diff --git a/chromium/tools/win/chromeexts/commands/hwnd_command.h b/chromium/tools/win/chromeexts/commands/hwnd_command.h index b25fc3fef26..1a474a6c7c3 100644 --- a/chromium/tools/win/chromeexts/commands/hwnd_command.h +++ b/chromium/tools/win/chromeexts/commands/hwnd_command.h @@ -14,13 +14,14 @@ namespace chromeexts { class HwndCommand : public ChromeExtsCommand { public: HwndCommand(); + + HwndCommand(const HwndCommand&) = delete; + HwndCommand& operator=(const HwndCommand&) = delete; + ~HwndCommand() override; protected: HRESULT Execute() override; - - private: - DISALLOW_COPY_AND_ASSIGN(HwndCommand); }; } // namespace chromeexts |