summaryrefslogtreecommitdiff
path: root/chromium/tools/chrome_proxy/common
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2017-04-05 17:15:33 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2017-04-11 07:47:18 +0000
commit7324afb043a0b1e623d8e8eb906cdc53bdeb4685 (patch)
treea3fe2d74ea9c9e142c390dac4ca0e219382ace46 /chromium/tools/chrome_proxy/common
parent6a4cabb866f66d4128a97cdc6d9d08ce074f1247 (diff)
downloadqtwebengine-chromium-7324afb043a0b1e623d8e8eb906cdc53bdeb4685.tar.gz
BASELINE: Update Chromium to 58.0.3029.54
Change-Id: I67f57065a7afdc8e4614adb5c0230281428df4d1 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Diffstat (limited to 'chromium/tools/chrome_proxy/common')
-rw-r--r--chromium/tools/chrome_proxy/common/chrome_proxy_measurements.py11
1 files changed, 7 insertions, 4 deletions
diff --git a/chromium/tools/chrome_proxy/common/chrome_proxy_measurements.py b/chromium/tools/chrome_proxy/common/chrome_proxy_measurements.py
index 36b06143f14..b62920831eb 100644
--- a/chromium/tools/chrome_proxy/common/chrome_proxy_measurements.py
+++ b/chromium/tools/chrome_proxy/common/chrome_proxy_measurements.py
@@ -51,14 +51,16 @@ def WaitForViaHeader(tab, url="http://check.googlezip.net/test.html"):
'</body></html>'))
# Ensure the page has finished loading before attempting the DRP check.
- tab.WaitForJavaScriptExpression('performance.timing.loadEventEnd', 60)
+ tab.WaitForJavaScriptCondition('performance.timing.loadEventEnd', timeout=60)
expected_via_header = metrics.CHROME_PROXY_VIA_HEADER
if ChromeProxyValidation.extra_via_header:
expected_via_header = ChromeProxyValidation.extra_via_header
- tab.WaitForJavaScriptExpression(
- 'PollDRPCheck("%s", "%s")' % (url, expected_via_header), 60)
+ tab.WaitForJavaScriptCondition(
+ 'PollDRPCheck({{ url }}, {{ via_header }})',
+ url=url, via_header=expected_via_header,
+ timeout=60)
class ChromeProxyValidation(legacy_page_test.LegacyPageTest):
@@ -100,7 +102,8 @@ class ChromeProxyValidation(legacy_page_test.LegacyPageTest):
def ValidateAndMeasurePage(self, page, tab, results):
self._page = page
# Wait for the load event.
- tab.WaitForJavaScriptExpression('performance.timing.loadEventStart', 300)
+ tab.WaitForJavaScriptCondition(
+ 'performance.timing.loadEventStart', timeout=300)
assert self._metrics
self._metrics.Stop(page, tab)
if ChromeProxyValidation.extra_via_header: