diff options
| author | Szabolcs David <davidsz@inf.u-szeged.hu> | 2021-02-04 15:07:58 +0100 |
|---|---|---|
| committer | Szabolcs David <davidsz@inf.u-szeged.hu> | 2021-03-06 23:06:05 +0000 |
| commit | 7c8217b36a95e29f7a7832b177e3df8a33083654 (patch) | |
| tree | 00d4f2d04af868ecc37c3f6fdcb034812e15d150 /chromium/third_party | |
| parent | 486f3998cbe4c948a770f9171ca80bd090ef257e (diff) | |
| download | qtwebengine-chromium-7c8217b36a95e29f7a7832b177e3df8a33083654.tar.gz | |
[Backport] Remove mouse wheel handler DCHECK
In wheel handling, we assume that if a wheel event is set to
non-blocking it must not be the first in the sequence so the previous
event disposition should be available in mouse_wheel_result_.
In https://crbug.com/1069760 that was found not to be the case. The fix
there was to revert to the previous behavior which checked for whether
that was true (the underlying cause wasn't found) but a DCHECK was left
in. This trips up builds that have DCHECKs enabled as in
https://crbug.com/1156940.
Bug: 1156940,1069760
Change-Id: Ia2104bd22798257e9c413d3637bb47fe425d8013
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/third_party')
| -rw-r--r-- | chromium/third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chromium/third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc b/chromium/third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc index 31247e89e58..ea0c9e20170 100644 --- a/chromium/third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc +++ b/chromium/third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc @@ -896,7 +896,6 @@ InputHandlerProxy::EventDisposition InputHandlerProxy::HandleMouseWheel( DCHECK(wheel_event.phase != WebMouseWheelEvent::kPhaseNone || wheel_event.momentum_phase != WebMouseWheelEvent::kPhaseNone); - DCHECK(mouse_wheel_result_.has_value()); // TODO(bokan): This should never happen but after changing // mouse_event_result_ to a base::Optional, crashes indicate that it does // so |if| maintains prior behavior. https://crbug.com/1069760. |