summaryrefslogtreecommitdiff
path: root/chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2019-05-24 11:40:17 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2019-05-24 12:42:11 +0000
commit5d87695f37678f96492b258bbab36486c59866b4 (patch)
treebe9783bbaf04fb930c4d74ca9c00b5e7954c8bc6 /chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc
parent6c11fb357ec39bf087b8b632e2b1e375aef1b38b (diff)
downloadqtwebengine-chromium-5d87695f37678f96492b258bbab36486c59866b4.tar.gz
BASELINE: Update Chromium to 75.0.3770.56
Change-Id: I86d2007fd27a45d5797eee06f4c9369b8b50ac4f Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc')
-rw-r--r--chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc62
1 files changed, 29 insertions, 33 deletions
diff --git a/chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc b/chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc
index 849372c2853..c51983e8f97 100644
--- a/chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc
+++ b/chromium/third_party/blink/renderer/platform/graphics/logging_canvas.cc
@@ -39,8 +39,8 @@
#include "third_party/blink/renderer/platform/graphics/skia/image_pixel_locker.h"
#include "third_party/blink/renderer/platform/graphics/skia/skia_utils.h"
#include "third_party/blink/renderer/platform/image-encoders/image_encoder.h"
-#include "third_party/blink/renderer/platform/wtf/hex_number.h"
#include "third_party/blink/renderer/platform/wtf/text/base64.h"
+#include "third_party/blink/renderer/platform/wtf/text/string_builder.h"
#include "third_party/skia/include/core/SkImage.h"
#include "third_party/skia/include/core/SkImageInfo.h"
#include "third_party/skia/include/core/SkPaint.h"
@@ -65,7 +65,7 @@ struct VerbParams {
};
std::unique_ptr<JSONObject> ObjectForSkRect(const SkRect& rect) {
- std::unique_ptr<JSONObject> rect_item = JSONObject::Create();
+ auto rect_item = std::make_unique<JSONObject>();
rect_item->SetDouble("left", rect.left());
rect_item->SetDouble("top", rect.top());
rect_item->SetDouble("right", rect.right());
@@ -74,7 +74,7 @@ std::unique_ptr<JSONObject> ObjectForSkRect(const SkRect& rect) {
}
std::unique_ptr<JSONObject> ObjectForSkIRect(const SkIRect& rect) {
- std::unique_ptr<JSONObject> rect_item = JSONObject::Create();
+ auto rect_item = std::make_unique<JSONObject>();
rect_item->SetDouble("left", rect.left());
rect_item->SetDouble("top", rect.top());
rect_item->SetDouble("right", rect.right());
@@ -97,7 +97,7 @@ String PointModeName(SkCanvas::PointMode mode) {
}
std::unique_ptr<JSONObject> ObjectForSkPoint(const SkPoint& point) {
- std::unique_ptr<JSONObject> point_item = JSONObject::Create();
+ auto point_item = std::make_unique<JSONObject>();
point_item->SetDouble("x", point.x());
point_item->SetDouble("y", point.y());
return point_item;
@@ -105,7 +105,7 @@ std::unique_ptr<JSONObject> ObjectForSkPoint(const SkPoint& point) {
std::unique_ptr<JSONArray> ArrayForSkPoints(size_t count,
const SkPoint points[]) {
- std::unique_ptr<JSONArray> points_array_item = JSONArray::Create();
+ auto points_array_item = std::make_unique<JSONArray>();
for (size_t i = 0; i < count; ++i)
points_array_item->PushObject(ObjectForSkPoint(points[i]));
return points_array_item;
@@ -113,7 +113,7 @@ std::unique_ptr<JSONArray> ArrayForSkPoints(size_t count,
std::unique_ptr<JSONObject> ObjectForRadius(const SkRRect& rrect,
SkRRect::Corner corner) {
- std::unique_ptr<JSONObject> radius_item = JSONObject::Create();
+ auto radius_item = std::make_unique<JSONObject>();
SkVector radius = rrect.radii(corner);
radius_item->SetDouble("xRadius", radius.x());
radius_item->SetDouble("yRadius", radius.y());
@@ -157,7 +157,7 @@ String RadiusName(SkRRect::Corner corner) {
}
std::unique_ptr<JSONObject> ObjectForSkRRect(const SkRRect& rrect) {
- std::unique_ptr<JSONObject> rrect_item = JSONObject::Create();
+ auto rrect_item = std::make_unique<JSONObject>();
rrect_item->SetString("type", RrectTypeName(rrect.type()));
rrect_item->SetDouble("left", rrect.rect().left());
rrect_item->SetDouble("top", rrect.rect().top());
@@ -222,17 +222,17 @@ VerbParams SegmentParams(SkPath::Verb verb) {
}
std::unique_ptr<JSONObject> ObjectForSkPath(const SkPath& path) {
- std::unique_ptr<JSONObject> path_item = JSONObject::Create();
+ auto path_item = std::make_unique<JSONObject>();
path_item->SetString("fillType", FillTypeName(path.getFillType()));
path_item->SetString("convexity", ConvexityName(path.getConvexity()));
path_item->SetBoolean("isRect", path.isRect(nullptr));
SkPath::Iter iter(path, false);
SkPoint points[4];
- std::unique_ptr<JSONArray> path_points_array = JSONArray::Create();
+ auto path_points_array = std::make_unique<JSONArray>();
for (SkPath::Verb verb = iter.next(points, false); verb != SkPath::kDone_Verb;
verb = iter.next(points, false)) {
VerbParams verb_params = SegmentParams(verb);
- std::unique_ptr<JSONObject> path_point_item = JSONObject::Create();
+ auto path_point_item = std::make_unique<JSONObject>();
path_point_item->SetString("verb", verb_params.name);
DCHECK_LE(verb_params.point_count + verb_params.point_offset,
base::size(points));
@@ -280,7 +280,7 @@ std::unique_ptr<JSONObject> ObjectForBitmapData(const SkBitmap& bitmap) {
return nullptr;
}
- std::unique_ptr<JSONObject> data_item = JSONObject::Create();
+ auto data_item = std::make_unique<JSONObject>();
data_item->SetString(
"base64",
WTF::Base64Encode(reinterpret_cast<char*>(output.data()), output.size()));
@@ -289,7 +289,7 @@ std::unique_ptr<JSONObject> ObjectForBitmapData(const SkBitmap& bitmap) {
}
std::unique_ptr<JSONObject> ObjectForSkBitmap(const SkBitmap& bitmap) {
- std::unique_ptr<JSONObject> bitmap_item = JSONObject::Create();
+ auto bitmap_item = std::make_unique<JSONObject>();
bitmap_item->SetInteger("width", bitmap.width());
bitmap_item->SetInteger("height", bitmap.height());
bitmap_item->SetString("config", ColorTypeName(bitmap.colorType()));
@@ -302,7 +302,7 @@ std::unique_ptr<JSONObject> ObjectForSkBitmap(const SkBitmap& bitmap) {
}
std::unique_ptr<JSONObject> ObjectForSkImage(const SkImage* image) {
- std::unique_ptr<JSONObject> image_item = JSONObject::Create();
+ auto image_item = std::make_unique<JSONObject>();
image_item->SetInteger("width", image->width());
image_item->SetInteger("height", image->height());
image_item->SetBoolean("opaque", image->isOpaque());
@@ -311,43 +311,38 @@ std::unique_ptr<JSONObject> ObjectForSkImage(const SkImage* image) {
}
std::unique_ptr<JSONArray> ArrayForSkMatrix(const SkMatrix& matrix) {
- std::unique_ptr<JSONArray> matrix_array = JSONArray::Create();
+ auto matrix_array = std::make_unique<JSONArray>();
for (int i = 0; i < 9; ++i)
matrix_array->PushDouble(matrix[i]);
return matrix_array;
}
std::unique_ptr<JSONObject> ObjectForSkShader(const SkShader& shader) {
- std::unique_ptr<JSONObject> shader_item = JSONObject::Create();
- const SkMatrix local_matrix = shader.getLocalMatrix();
- if (!local_matrix.isIdentity())
- shader_item->SetArray("localMatrix", ArrayForSkMatrix(local_matrix));
- return shader_item;
+ return std::make_unique<JSONObject>();
}
-String StringForSkColor(const SkColor& color) {
+String StringForSkColor(SkColor color) {
// #AARRGGBB.
- Vector<LChar, 9> result;
- result.push_back('#');
- HexNumber::AppendUnsignedAsHex(color, result);
- return String(result.data(), result.size());
+ return String::Format("#%08X", color);
}
-void AppendFlagToString(String* flags_string, bool is_set, const String& name) {
+void AppendFlagToString(StringBuilder* flags_string,
+ bool is_set,
+ const StringView& name) {
if (!is_set)
return;
if (flags_string->length())
- flags_string->append("|");
- flags_string->append(name);
+ flags_string->Append("|");
+ flags_string->Append(name);
}
String StringForSkPaintFlags(const SkPaint& paint) {
if (!paint.isAntiAlias() && !paint.isDither())
return "none";
- String flags_string = "";
+ StringBuilder flags_string;
AppendFlagToString(&flags_string, paint.isAntiAlias(), "AntiAlias");
AppendFlagToString(&flags_string, paint.isDither(), "Dither");
- return flags_string;
+ return flags_string.ToString();
}
String FilterQualityName(SkFilterQuality filter_quality) {
@@ -409,7 +404,7 @@ String StyleName(SkPaint::Style style) {
}
std::unique_ptr<JSONObject> ObjectForSkPaint(const SkPaint& paint) {
- std::unique_ptr<JSONObject> paint_item = JSONObject::Create();
+ auto paint_item = std::make_unique<JSONObject>();
if (SkShader* shader = paint.getShader())
paint_item->SetObject("shader", ObjectForSkShader(*shader));
paint_item->SetString("color", StringForSkColor(paint.getColor()));
@@ -459,7 +454,7 @@ class AutoLogger
};
JSONObject* AutoLogger::LogItem(const String& name) {
- std::unique_ptr<JSONObject> item = JSONObject::Create();
+ auto item = std::make_unique<JSONObject>();
item->SetString("method", name);
log_item_ = std::move(item);
return log_item_.get();
@@ -467,13 +462,14 @@ JSONObject* AutoLogger::LogItem(const String& name) {
JSONObject* AutoLogger::LogItemWithParams(const String& name) {
JSONObject* item = LogItem(name);
- std::unique_ptr<JSONObject> params = JSONObject::Create();
+ auto params = std::make_unique<JSONObject>();
item->SetObject("params", std::move(params));
return item->GetJSONObject("params");
}
LoggingCanvas::LoggingCanvas()
- : InterceptingCanvasBase(999999, 999999), log_(JSONArray::Create()) {}
+ : InterceptingCanvasBase(999999, 999999),
+ log_(std::make_unique<JSONArray>()) {}
void LoggingCanvas::onDrawPaint(const SkPaint& paint) {
AutoLogger logger(this);