diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-01-23 17:21:03 +0100 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2020-01-23 16:25:15 +0000 |
commit | c551f43206405019121bd2b2c93714319a0a3300 (patch) | |
tree | 1f48c30631c421fd4bbb3c36da20183c8a2ed7d7 /chromium/third_party/blink/renderer/core/editing/finder | |
parent | 7961cea6d1041e3e454dae6a1da660b453efd238 (diff) | |
download | qtwebengine-chromium-c551f43206405019121bd2b2c93714319a0a3300.tar.gz |
BASELINE: Update Chromium to 79.0.3945.139
Change-Id: I336b7182fab9bca80b709682489c07db112eaca5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/third_party/blink/renderer/core/editing/finder')
6 files changed, 17 insertions, 13 deletions
diff --git a/chromium/third_party/blink/renderer/core/editing/finder/find_buffer.cc b/chromium/third_party/blink/renderer/core/editing/finder/find_buffer.cc index 8ef026b3d29..7c9dbdc4a0e 100644 --- a/chromium/third_party/blink/renderer/core/editing/finder/find_buffer.cc +++ b/chromium/third_party/blink/renderer/core/editing/finder/find_buffer.cc @@ -103,14 +103,15 @@ bool ShouldIgnoreContents(const Node& node) { return false; return (!element->ShouldSerializeEndTag() && !IsHTMLInputElement(*element)) || IsA<HTMLIFrameElement>(*element) || IsHTMLImageElement(*element) || - IsA<HTMLLegendElement>(*element) || IsHTMLMeterElement(*element) || - IsHTMLObjectElement(*element) || IsHTMLProgressElement(*element) || - (IsHTMLSelectElement(*element) && - ToHTMLSelectElement(*element).UsesMenuList()) || + IsA<HTMLLegendElement>(*element) || IsA<HTMLMeterElement>(*element) || + IsHTMLObjectElement(*element) || IsA<HTMLProgressElement>(*element) || + (IsA<HTMLSelectElement>(*element) && + To<HTMLSelectElement>(*element).UsesMenuList()) || IsHTMLStyleElement(*element) || IsHTMLScriptElement(*element) || IsHTMLVideoElement(*element) || IsA<HTMLAudioElement>(*element) || (element->GetDisplayLockContext() && - !element->GetDisplayLockContext()->IsActivatable()); + !element->GetDisplayLockContext()->IsActivatable( + DisplayLockActivationReason::kUser)); } Node* GetNonSearchableAncestor(const Node& node) { @@ -234,7 +235,7 @@ std::unique_ptr<FindBuffer::Results> FindBuffer::FindMatches( bool FindBuffer::PushScopedForcedUpdateIfNeeded(const Element& element) { if (auto* context = element.GetDisplayLockContext()) { - DCHECK(context->IsActivatable()); + DCHECK(context->IsActivatable(DisplayLockActivationReason::kUser)); scoped_forced_update_list_.push_back(context->GetScopedForcedUpdate()); return true; } @@ -244,7 +245,8 @@ bool FindBuffer::PushScopedForcedUpdateIfNeeded(const Element& element) { void FindBuffer::CollectScopedForcedUpdates(Node& start_node, const Node* search_range_end_node, const Node* node_after_block) { - if (!RuntimeEnabledFeatures::DisplayLockingEnabled()) + if (!RuntimeEnabledFeatures::DisplayLockingEnabled( + start_node.GetExecutionContext())) return; if (start_node.GetDocument().LockedDisplayLockCount() == start_node.GetDocument().ActivationBlockingDisplayLockCount()) diff --git a/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.cc b/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.cc index a67f6e0924a..ce853a58796 100644 --- a/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.cc +++ b/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.cc @@ -4,6 +4,7 @@ #include "third_party/blink/renderer/core/editing/finder/find_task_controller.h" +#include "third_party/blink/public/mojom/frame/find_in_page.mojom-blink.h" #include "third_party/blink/renderer/core/dom/document.h" #include "third_party/blink/renderer/core/dom/idle_request_options.h" #include "third_party/blink/renderer/core/dom/range.h" diff --git a/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.h b/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.h index 3f9b4844f8a..58e6c8394b4 100644 --- a/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.h +++ b/chromium/third_party/blink/renderer/core/editing/finder/find_task_controller.h @@ -5,7 +5,7 @@ #ifndef THIRD_PARTY_BLINK_RENDERER_CORE_EDITING_FINDER_FIND_TASK_CONTROLLER_H_ #define THIRD_PARTY_BLINK_RENDERER_CORE_EDITING_FINDER_FIND_TASK_CONTROLLER_H_ -#include "third_party/blink/public/mojom/frame/find_in_page.mojom-blink.h" +#include "third_party/blink/public/mojom/frame/find_in_page.mojom-blink-forward.h" #include "third_party/blink/renderer/core/core_export.h" #include "third_party/blink/renderer/core/editing/position.h" #include "third_party/blink/renderer/platform/heap/garbage_collected.h" @@ -20,7 +20,7 @@ class WebString; class WebLocalFrameImpl; class CORE_EXPORT FindTaskController final - : public GarbageCollectedFinalized<FindTaskController> { + : public GarbageCollected<FindTaskController> { public: FindTaskController(WebLocalFrameImpl& owner_frame, TextFinder& text_finder); diff --git a/chromium/third_party/blink/renderer/core/editing/finder/text_finder.cc b/chromium/third_party/blink/renderer/core/editing/finder/text_finder.cc index 4882a6cdfe8..a81b9b3c396 100644 --- a/chromium/third_party/blink/renderer/core/editing/finder/text_finder.cc +++ b/chromium/third_party/blink/renderer/core/editing/finder/text_finder.cc @@ -75,7 +75,8 @@ void TextFinder::FindMatch::Trace(Visitor* visitor) { static void ScrollToVisible(Range* match) { const Node& first_node = *match->FirstNode(); if (RuntimeEnabledFeatures::InvisibleDOMEnabled() || - RuntimeEnabledFeatures::DisplayLockingEnabled()) { + RuntimeEnabledFeatures::DisplayLockingEnabled( + first_node.GetExecutionContext())) { const EphemeralRangeInFlatTree range(match); if (InvisibleDOM::ActivateRangeIfNeeded(range) || DisplayLockUtilities::ActivateFindInPageMatchRangeIfNeeded(range)) diff --git a/chromium/third_party/blink/renderer/core/editing/finder/text_finder.h b/chromium/third_party/blink/renderer/core/editing/finder/text_finder.h index 63b260b33a7..c025a326699 100644 --- a/chromium/third_party/blink/renderer/core/editing/finder/text_finder.h +++ b/chromium/third_party/blink/renderer/core/editing/finder/text_finder.h @@ -32,7 +32,7 @@ #define THIRD_PARTY_BLINK_RENDERER_CORE_EDITING_FINDER_TEXT_FINDER_H_ #include "base/macros.h" -#include "third_party/blink/public/mojom/frame/find_in_page.mojom-blink.h" +#include "third_party/blink/public/mojom/frame/find_in_page.mojom-blink-forward.h" #include "third_party/blink/public/platform/web_float_point.h" #include "third_party/blink/renderer/core/core_export.h" #include "third_party/blink/renderer/platform/geometry/float_rect.h" @@ -51,8 +51,7 @@ struct WebFloatPoint; struct WebFloatRect; struct WebRect; -class CORE_EXPORT TextFinder final - : public GarbageCollectedFinalized<TextFinder> { +class CORE_EXPORT TextFinder final : public GarbageCollected<TextFinder> { public: bool Find(int identifier, const WebString& search_text, diff --git a/chromium/third_party/blink/renderer/core/editing/finder/text_finder_test.cc b/chromium/third_party/blink/renderer/core/editing/finder/text_finder_test.cc index f56e897421e..f45477f6d9b 100644 --- a/chromium/third_party/blink/renderer/core/editing/finder/text_finder_test.cc +++ b/chromium/third_party/blink/renderer/core/editing/finder/text_finder_test.cc @@ -5,6 +5,7 @@ #include "third_party/blink/renderer/core/editing/finder/text_finder.h" #include "testing/gtest/include/gtest/gtest.h" +#include "third_party/blink/public/mojom/frame/find_in_page.mojom-blink.h" #include "third_party/blink/public/platform/platform.h" #include "third_party/blink/public/platform/web_float_rect.h" #include "third_party/blink/public/web/web_document.h" |