diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-05-03 17:20:32 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2017-05-05 09:28:09 +0000 |
commit | bb09965444b5bb20b096a291445170876225268d (patch) | |
tree | b5f6596f7e6e941b1d7d72f0ce5181500c261529 /chromium/sandbox | |
parent | 7324afb043a0b1e623d8e8eb906cdc53bdeb4685 (diff) | |
download | qtwebengine-chromium-bb09965444b5bb20b096a291445170876225268d.tar.gz |
BASELINE: Update Chromium to 58.0.3029.98
Change-Id: Ib913750d687f29e036959c62a0cabf2412a8faa7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'chromium/sandbox')
-rw-r--r-- | chromium/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc | 13 | ||||
-rw-r--r-- | chromium/sandbox/linux/seccomp-bpf/sandbox_bpf.cc | 9 |
2 files changed, 0 insertions, 22 deletions
diff --git a/chromium/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc b/chromium/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc index fc0ecf2e326..404168ac9f2 100644 --- a/chromium/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc +++ b/chromium/sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc @@ -2192,19 +2192,6 @@ SANDBOX_DEATH_TEST( BPF_ASSERT(!sandbox.StartSandbox(SandboxBPF::SeccompLevel::SINGLE_THREADED)); } -// http://crbug.com/407357 -#if !defined(THREAD_SANITIZER) -SANDBOX_DEATH_TEST( - SandboxBPF, - StartSingleThreadedAsMultiThreaded, - DEATH_MESSAGE( - "Cannot start sandbox; process may be single-threaded when " - "reported as not")) { - SandboxBPF sandbox(new AllowAllPolicy()); - BPF_ASSERT(!sandbox.StartSandbox(SandboxBPF::SeccompLevel::MULTI_THREADED)); -} -#endif // !defined(THREAD_SANITIZER) - // A stub handler for the UnsafeTrap. Never called. intptr_t NoOpHandler(const struct arch_seccomp_data& args, void*) { return -1; diff --git a/chromium/sandbox/linux/seccomp-bpf/sandbox_bpf.cc b/chromium/sandbox/linux/seccomp-bpf/sandbox_bpf.cc index 4d8d4367130..3ab366a8e38 100644 --- a/chromium/sandbox/linux/seccomp-bpf/sandbox_bpf.cc +++ b/chromium/sandbox/linux/seccomp-bpf/sandbox_bpf.cc @@ -38,10 +38,6 @@ namespace { bool IsRunningOnValgrind() { return RUNNING_ON_VALGRIND; } -bool IsSingleThreaded(int proc_fd) { - return ThreadHelpers::IsSingleThreaded(proc_fd); -} - // Check if the kernel supports seccomp-filter (a.k.a. seccomp mode 2) via // prctl(). bool KernelSupportsSeccompBPF() { @@ -168,11 +164,6 @@ bool SandboxBPF::StartSandbox(SeccompLevel seccomp_level) { // process is single threaded. ThreadHelpers::AssertSingleThreaded(proc_fd_.get()); } else if (seccomp_level == SeccompLevel::MULTI_THREADED) { - if (IsSingleThreaded(proc_fd_.get())) { - SANDBOX_DIE("Cannot start sandbox; " - "process may be single-threaded when reported as not"); - return false; - } if (!supports_tsync) { SANDBOX_DIE("Cannot start sandbox; kernel does not support synchronizing " "filters for a threadgroup"); |