diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-01-31 16:33:43 +0100 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-02-06 16:33:22 +0000 |
commit | da51f56cc21233c2d30f0fe0d171727c3102b2e0 (patch) | |
tree | 4e579ab70ce4b19bee7984237f3ce05a96d59d83 /chromium/net/ftp | |
parent | c8c2d1901aec01e934adf561a9fdf0cc776cdef8 (diff) | |
download | qtwebengine-chromium-da51f56cc21233c2d30f0fe0d171727c3102b2e0.tar.gz |
BASELINE: Update Chromium to 65.0.3525.40
Also imports missing submodules
Change-Id: I36901b7c6a325cda3d2c10cedb2186c25af3b79b
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'chromium/net/ftp')
-rw-r--r-- | chromium/net/ftp/ftp_network_transaction.cc | 14 | ||||
-rw-r--r-- | chromium/net/ftp/ftp_network_transaction.h | 5 | ||||
-rw-r--r-- | chromium/net/ftp/ftp_network_transaction_unittest.cc | 36 | ||||
-rw-r--r-- | chromium/net/ftp/ftp_transaction.h | 4 |
4 files changed, 37 insertions, 22 deletions
diff --git a/chromium/net/ftp/ftp_network_transaction.cc b/chromium/net/ftp/ftp_network_transaction.cc index 566bbe4f5ad..e8ec85ab330 100644 --- a/chromium/net/ftp/ftp_network_transaction.cc +++ b/chromium/net/ftp/ftp_network_transaction.cc @@ -254,11 +254,14 @@ int FtpNetworkTransaction::Stop(int error) { return OK; } -int FtpNetworkTransaction::Start(const FtpRequestInfo* request_info, - const CompletionCallback& callback, - const NetLogWithSource& net_log) { +int FtpNetworkTransaction::Start( + const FtpRequestInfo* request_info, + const CompletionCallback& callback, + const NetLogWithSource& net_log, + const NetworkTrafficAnnotationTag& traffic_annotation) { net_log_ = net_log; request_ = request_info; + traffic_annotation_ = MutableNetworkTrafficAnnotationTag(traffic_annotation); ctrl_response_buffer_ = std::make_unique<FtpCtrlResponseBuffer>(net_log_); @@ -736,8 +739,9 @@ int FtpNetworkTransaction::DoCtrlReadComplete(int result) { int FtpNetworkTransaction::DoCtrlWrite() { next_state_ = STATE_CTRL_WRITE_COMPLETE; - return ctrl_socket_->Write( - write_buf_.get(), write_buf_->BytesRemaining(), io_callback_); + return ctrl_socket_->Write(write_buf_.get(), write_buf_->BytesRemaining(), + io_callback_, + NetworkTrafficAnnotationTag(traffic_annotation_)); } int FtpNetworkTransaction::DoCtrlWriteComplete(int result) { diff --git a/chromium/net/ftp/ftp_network_transaction.h b/chromium/net/ftp/ftp_network_transaction.h index 9731ae7ad8a..a6769ce4bba 100644 --- a/chromium/net/ftp/ftp_network_transaction.h +++ b/chromium/net/ftp/ftp_network_transaction.h @@ -22,6 +22,7 @@ #include "net/ftp/ftp_response_info.h" #include "net/ftp/ftp_transaction.h" #include "net/log/net_log_with_source.h" +#include "net/traffic_annotation/network_traffic_annotation.h" namespace net { @@ -39,7 +40,8 @@ class NET_EXPORT_PRIVATE FtpNetworkTransaction : public FtpTransaction { // FtpTransaction methods: int Start(const FtpRequestInfo* request_info, const CompletionCallback& callback, - const NetLogWithSource& net_log) override; + const NetLogWithSource& net_log, + const NetworkTrafficAnnotationTag& traffic_annotation) override; int RestartWithAuth(const AuthCredentials& credentials, const CompletionCallback& callback) override; int Read(IOBuffer* buf, @@ -204,6 +206,7 @@ class NET_EXPORT_PRIVATE FtpNetworkTransaction : public FtpTransaction { NetLogWithSource net_log_; const FtpRequestInfo* request_; + MutableNetworkTrafficAnnotationTag traffic_annotation_; FtpResponseInfo response_; // Cancels the outstanding request on destruction. diff --git a/chromium/net/ftp/ftp_network_transaction_unittest.cc b/chromium/net/ftp/ftp_network_transaction_unittest.cc index 9ca3f5e040a..b8bc320b737 100644 --- a/chromium/net/ftp/ftp_network_transaction_unittest.cc +++ b/chromium/net/ftp/ftp_network_transaction_unittest.cc @@ -16,6 +16,7 @@ #include "net/ftp/ftp_request_info.h" #include "net/socket/socket_test_util.h" #include "net/test/gtest_util.h" +#include "net/traffic_annotation/network_traffic_annotation_test_helper.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/platform_test.h" @@ -819,9 +820,10 @@ class FtpNetworkTransactionTest mock_socket_factory_->AddSocketDataProvider(data_socket.get()); FtpRequestInfo request_info = GetRequestInfo(request); EXPECT_EQ(LOAD_STATE_IDLE, transaction_->GetLoadState()); - ASSERT_EQ(ERR_IO_PENDING, - transaction_->Start(&request_info, callback_.callback(), - NetLogWithSource())); + ASSERT_EQ( + ERR_IO_PENDING, + transaction_->Start(&request_info, callback_.callback(), + NetLogWithSource(), TRAFFIC_ANNOTATION_FOR_TESTS)); EXPECT_NE(LOAD_STATE_IDLE, transaction_->GetLoadState()); ASSERT_EQ(expected_result, callback_.WaitForResult()); if (expected_result == OK) { @@ -870,9 +872,10 @@ TEST_P(FtpNetworkTransactionTest, FailedLookup) { host_resolver_->set_rules(rules.get()); EXPECT_EQ(LOAD_STATE_IDLE, transaction_->GetLoadState()); - ASSERT_EQ(ERR_IO_PENDING, - transaction_->Start(&request_info, callback_.callback(), - NetLogWithSource())); + ASSERT_EQ( + ERR_IO_PENDING, + transaction_->Start(&request_info, callback_.callback(), + NetLogWithSource(), TRAFFIC_ANNOTATION_FOR_TESTS)); ASSERT_THAT(callback_.WaitForResult(), IsError(ERR_NAME_NOT_RESOLVED)); EXPECT_EQ(LOAD_STATE_IDLE, transaction_->GetLoadState()); } @@ -1141,9 +1144,10 @@ TEST_P(FtpNetworkTransactionTest, DownloadTransactionEvilPasvUnsafeHost) { FtpRequestInfo request_info = GetRequestInfo("ftp://host/file"); // Start the transaction. - ASSERT_EQ(ERR_IO_PENDING, - transaction_->Start(&request_info, callback_.callback(), - NetLogWithSource())); + ASSERT_EQ( + ERR_IO_PENDING, + transaction_->Start(&request_info, callback_.callback(), + NetLogWithSource(), TRAFFIC_ANNOTATION_FOR_TESTS)); ASSERT_THAT(callback_.WaitForResult(), IsOk()); // The transaction fires the callback when we can start reading data. That @@ -1336,9 +1340,10 @@ TEST_P(FtpNetworkTransactionTest, EvilRestartUser) { FtpRequestInfo request_info = GetRequestInfo("ftp://host/file"); - ASSERT_EQ(ERR_IO_PENDING, - transaction_->Start(&request_info, callback_.callback(), - NetLogWithSource())); + ASSERT_EQ( + ERR_IO_PENDING, + transaction_->Start(&request_info, callback_.callback(), + NetLogWithSource(), TRAFFIC_ANNOTATION_FOR_TESTS)); ASSERT_THAT(callback_.WaitForResult(), IsError(ERR_FTP_FAILED)); MockRead ctrl_reads[] = { @@ -1369,9 +1374,10 @@ TEST_P(FtpNetworkTransactionTest, EvilRestartPassword) { FtpRequestInfo request_info = GetRequestInfo("ftp://host/file"); - ASSERT_EQ(ERR_IO_PENDING, - transaction_->Start(&request_info, callback_.callback(), - NetLogWithSource())); + ASSERT_EQ( + ERR_IO_PENDING, + transaction_->Start(&request_info, callback_.callback(), + NetLogWithSource(), TRAFFIC_ANNOTATION_FOR_TESTS)); ASSERT_THAT(callback_.WaitForResult(), IsError(ERR_FTP_FAILED)); MockRead ctrl_reads[] = { diff --git a/chromium/net/ftp/ftp_transaction.h b/chromium/net/ftp/ftp_transaction.h index 1da3aeff205..f037b99b456 100644 --- a/chromium/net/ftp/ftp_transaction.h +++ b/chromium/net/ftp/ftp_transaction.h @@ -11,6 +11,7 @@ #include "net/base/io_buffer.h" #include "net/base/load_states.h" #include "net/base/net_export.h" +#include "net/traffic_annotation/network_traffic_annotation.h" namespace net { @@ -42,7 +43,8 @@ class NET_EXPORT_PRIVATE FtpTransaction { // Profiling information for the request is saved to |net_log| if non-NULL. virtual int Start(const FtpRequestInfo* request_info, const CompletionCallback& callback, - const NetLogWithSource& net_log) = 0; + const NetLogWithSource& net_log, + const NetworkTrafficAnnotationTag& traffic_annotation) = 0; // Restarts the FTP transaction with authentication credentials. virtual int RestartWithAuth(const AuthCredentials& credentials, |