diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-08-28 15:28:34 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-08-28 13:54:51 +0000 |
commit | 2a19c63448c84c1805fb1a585c3651318bb86ca7 (patch) | |
tree | eb17888e8531aa6ee5e85721bd553b832a7e5156 /chromium/net/cookies | |
parent | b014812705fc80bff0a5c120dfcef88f349816dc (diff) | |
download | qtwebengine-chromium-2a19c63448c84c1805fb1a585c3651318bb86ca7.tar.gz |
BASELINE: Update Chromium to 69.0.3497.70
Change-Id: I2b7b56e4e7a8b26656930def0d4575dc32b900a0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/net/cookies')
-rw-r--r-- | chromium/net/cookies/canonical_cookie.cc | 14 | ||||
-rw-r--r-- | chromium/net/cookies/canonical_cookie_unittest.cc | 2 | ||||
-rw-r--r-- | chromium/net/cookies/cookie_monster.cc | 39 | ||||
-rw-r--r-- | chromium/net/cookies/cookie_monster_unittest.cc | 2 | ||||
-rw-r--r-- | chromium/net/cookies/cookie_util.h | 5 |
5 files changed, 35 insertions, 27 deletions
diff --git a/chromium/net/cookies/canonical_cookie.cc b/chromium/net/cookies/canonical_cookie.cc index ffd247ea73c..d3442c5c92d 100644 --- a/chromium/net/cookies/canonical_cookie.cc +++ b/chromium/net/cookies/canonical_cookie.cc @@ -63,8 +63,6 @@ namespace net { namespace { -const int kVlogSetCookies = 7; - // Determine the cookie domain to use for setting the specified cookie. bool GetCookieDomain(const GURL& url, const ParsedCookie& pc, @@ -195,18 +193,20 @@ std::unique_ptr<CanonicalCookie> CanonicalCookie::Create( ParsedCookie parsed_cookie(cookie_line); if (!parsed_cookie.IsValid()) { - VLOG(kVlogSetCookies) << "WARNING: Couldn't parse cookie"; + VLOG(net::cookie_util::kVlogSetCookies) << "WARNING: Couldn't parse cookie"; return nullptr; } if (options.exclude_httponly() && parsed_cookie.IsHttpOnly()) { - VLOG(kVlogSetCookies) << "Create() is not creating a httponly cookie"; + VLOG(net::cookie_util::kVlogSetCookies) + << "Create() is not creating a httponly cookie"; return nullptr; } std::string cookie_domain; if (!GetCookieDomain(url, parsed_cookie, &cookie_domain)) { - VLOG(kVlogSetCookies) << "Create() failed to get a cookie domain"; + VLOG(net::cookie_util::kVlogSetCookies) + << "Create() failed to get a cookie domain"; return nullptr; } @@ -215,7 +215,7 @@ std::unique_ptr<CanonicalCookie> CanonicalCookie::Create( // URL does not have a secure scheme, the cookie should be thrown away. // https://tools.ietf.org/html/draft-ietf-httpbis-cookie-alone if (parsed_cookie.IsSecure() && !url.SchemeIsCryptographic()) { - VLOG(kVlogSetCookies) + VLOG(net::cookie_util::kVlogSetCookies) << "Create() is trying to create a secure cookie from an insecure URL"; return nullptr; } @@ -236,7 +236,7 @@ std::unique_ptr<CanonicalCookie> CanonicalCookie::Create( bool is_cookie_valid = IsCookiePrefixValid(prefix, url, parsed_cookie); RecordCookiePrefixMetrics(prefix, is_cookie_valid); if (!is_cookie_valid) { - VLOG(kVlogSetCookies) + VLOG(net::cookie_util::kVlogSetCookies) << "Create() failed because the cookie violated prefix rules."; return nullptr; } diff --git a/chromium/net/cookies/canonical_cookie_unittest.cc b/chromium/net/cookies/canonical_cookie_unittest.cc index 97d25ef455b..31ee837cae7 100644 --- a/chromium/net/cookies/canonical_cookie_unittest.cc +++ b/chromium/net/cookies/canonical_cookie_unittest.cc @@ -4,7 +4,7 @@ #include "net/cookies/canonical_cookie.h" -#include "base/test/histogram_tester.h" +#include "base/test/metrics/histogram_tester.h" #include "net/cookies/cookie_constants.h" #include "net/cookies/cookie_options.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chromium/net/cookies/cookie_monster.cc b/chromium/net/cookies/cookie_monster.cc index 8218ee31292..3f7095682c8 100644 --- a/chromium/net/cookies/cookie_monster.cc +++ b/chromium/net/cookies/cookie_monster.cc @@ -188,10 +188,6 @@ struct OrderByCreationTimeDesc { } }; -// Constants for use in VLOG -const int kVlogPerCookieMonster = 1; -const int kVlogGarbageCollection = 5; -const int kVlogSetCookies = 7; // Mozilla sorts on the path length (longest first), and then it // sorts by creation time (oldest first). // The RFC says the sort order for the domain attribute is undefined. @@ -725,7 +721,8 @@ void CookieMonster::SetCookieWithOptions(const GURL& url, return; } - VLOG(kVlogSetCookies) << "SetCookie() line: " << cookie_line; + VLOG(net::cookie_util::kVlogSetCookies) + << "SetCookie() line: " << cookie_line; Time creation_time = CurrentTime(); last_time_seen_ = creation_time; @@ -734,7 +731,8 @@ void CookieMonster::SetCookieWithOptions(const GURL& url, CanonicalCookie::Create(url, cookie_line, creation_time, options)); if (!cc.get()) { - VLOG(kVlogSetCookies) << "WARNING: Failed to allocate CanonicalCookie"; + VLOG(net::cookie_util::kVlogSetCookies) + << "WARNING: Failed to allocate CanonicalCookie"; MaybeRunCookieCallback(std::move(callback), false); return; } @@ -1242,13 +1240,13 @@ void CookieMonster::SetCanonicalCookie(std::unique_ptr<CanonicalCookie> cc, "SetCookie() not clobbering httponly cookie or secure cookie for " "insecure scheme"; - VLOG(kVlogSetCookies) << error; + VLOG(net::cookie_util::kVlogSetCookies) << error; MaybeRunCookieCallback(std::move(callback), false); return; } - VLOG(kVlogSetCookies) << "SetCookie() key: " << key - << " cc: " << cc->DebugString(); + VLOG(net::cookie_util::kVlogSetCookies) + << "SetCookie() key: " << key << " cc: " << cc->DebugString(); // Realize that we might be setting an expired cookie, and the only point // was to delete the cookie which we've already done. @@ -1283,7 +1281,8 @@ void CookieMonster::SetCanonicalCookie(std::unique_ptr<CanonicalCookie> cc, InternalInsertCookie(key, std::move(cc), true); } else { - VLOG(kVlogSetCookies) << "SetCookie() not storing already expired cookie."; + VLOG(net::cookie_util::kVlogSetCookies) + << "SetCookie() not storing already expired cookie."; } // We assume that hopefully setting a cookie will be less common than @@ -1359,9 +1358,9 @@ void CookieMonster::InternalDeleteCookie(CookieMap::iterator it, "kChangeCauseMapping size should match DeletionCause size"); CanonicalCookie* cc = it->second.get(); - VLOG(kVlogSetCookies) << "InternalDeleteCookie()" - << ", cause:" << deletion_cause - << ", cc: " << cc->DebugString(); + VLOG(net::cookie_util::kVlogSetCookies) + << "InternalDeleteCookie()" + << ", cause:" << deletion_cause << ", cc: " << cc->DebugString(); if ((cc->IsPersistent() || persist_session_cookies_) && store_.get() && sync_to_store) @@ -1382,7 +1381,8 @@ size_t CookieMonster::GarbageCollect(const Time& current, // Collect garbage for this key, minding cookie priorities. if (cookies_.count(key) > kDomainMaxCookies) { - VLOG(kVlogGarbageCollection) << "GarbageCollect() key: " << key; + VLOG(net::cookie_util::kVlogGarbageCollection) + << "GarbageCollect() key: " << key; CookieItVector* cookie_its; @@ -1392,7 +1392,8 @@ size_t CookieMonster::GarbageCollect(const Time& current, GarbageCollectExpired(current, cookies_.equal_range(key), cookie_its); if (cookie_its->size() > kDomainMaxCookies) { - VLOG(kVlogGarbageCollection) << "Deep Garbage Collect domain."; + VLOG(net::cookie_util::kVlogGarbageCollection) + << "Deep Garbage Collect domain."; size_t purge_goal = cookie_its->size() - (kDomainMaxCookies - kDomainPurgeCookies); DCHECK(purge_goal > kDomainPurgeCookies); @@ -1470,7 +1471,8 @@ size_t CookieMonster::GarbageCollect(const Time& current, // Collect garbage for everything. With firefox style we want to preserve // cookies accessed in kSafeFromGlobalPurgeDays, otherwise evict. if (cookies_.size() > kMaxCookies && earliest_access_time_ < safe_date) { - VLOG(kVlogGarbageCollection) << "GarbageCollect() everything"; + VLOG(net::cookie_util::kVlogGarbageCollection) + << "GarbageCollect() everything"; CookieItVector cookie_its; num_deleted += GarbageCollectExpired( @@ -1478,7 +1480,8 @@ size_t CookieMonster::GarbageCollect(const Time& current, &cookie_its); if (cookie_its.size() > kMaxCookies) { - VLOG(kVlogGarbageCollection) << "Deep Garbage Collect everything."; + VLOG(net::cookie_util::kVlogGarbageCollection) + << "Deep Garbage Collect everything."; size_t purge_goal = cookie_its.size() - (kMaxCookies - kPurgeCookies); DCHECK(purge_goal > kPurgeCookies); @@ -1694,7 +1697,7 @@ bool CookieMonster::HasCookieableScheme(const GURL& url) { } // The scheme didn't match any in our whitelist. - VLOG(kVlogPerCookieMonster) + VLOG(net::cookie_util::kVlogPerCookieMonster) << "WARNING: Unsupported cookie scheme: " << url.scheme(); return false; } diff --git a/chromium/net/cookies/cookie_monster_unittest.cc b/chromium/net/cookies/cookie_monster_unittest.cc index a780371034a..6496003ae9b 100644 --- a/chromium/net/cookies/cookie_monster_unittest.cc +++ b/chromium/net/cookies/cookie_monster_unittest.cc @@ -25,7 +25,7 @@ #include "base/strings/string_split.h" #include "base/strings/string_tokenizer.h" #include "base/strings/stringprintf.h" -#include "base/test/histogram_tester.h" +#include "base/test/metrics/histogram_tester.h" #include "base/test/mock_callback.h" #include "base/threading/thread.h" #include "base/threading/thread_task_runner_handle.h" diff --git a/chromium/net/cookies/cookie_util.h b/chromium/net/cookies/cookie_util.h index 18a3bfbeb50..669457ba9be 100644 --- a/chromium/net/cookies/cookie_util.h +++ b/chromium/net/cookies/cookie_util.h @@ -18,6 +18,11 @@ class GURL; namespace net { namespace cookie_util { +// Constants for use in VLOG +const int kVlogPerCookieMonster = 1; +const int kVlogSetCookies = 7; +const int kVlogGarbageCollection = 5; + // Returns the effective TLD+1 for a given host. This only makes sense for http // and https schemes. For other schemes, the host will be returned unchanged // (minus any leading period). |