summaryrefslogtreecommitdiff
path: root/chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2018-08-24 12:15:48 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2018-08-28 13:30:04 +0000
commitb014812705fc80bff0a5c120dfcef88f349816dc (patch)
tree25a2e2d9fa285f1add86aa333389a839f81a39ae /chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc
parent9f4560b1027ae06fdb497023cdcaf91b8511fa74 (diff)
downloadqtwebengine-chromium-b014812705fc80bff0a5c120dfcef88f349816dc.tar.gz
BASELINE: Update Chromium to 68.0.3440.125
Change-Id: I23f19369e01f688e496f5bf179abb521ad73874f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc')
-rw-r--r--chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc26
1 files changed, 13 insertions, 13 deletions
diff --git a/chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc b/chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc
index 6cd303ffbb3..b18f49d21f8 100644
--- a/chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc
+++ b/chromium/content/renderer/media/webrtc/webrtc_audio_renderer.cc
@@ -39,7 +39,6 @@ const media::AudioParameters::Format kFormat =
media::AudioParameters::AUDIO_PCM_LOW_LATENCY;
const media::ChannelLayout kChannelLayout = media::CHANNEL_LAYOUT_STEREO;
const int kChannels = 2;
-const int kBitsPerSample = 16;
// Used for UMA histograms.
const int kRenderTimeHistogramMinMicroseconds = 100;
@@ -133,10 +132,9 @@ class SharedAudioRenderer : public MediaStreamAudioRenderer {
void SwitchOutputDevice(
const std::string& device_id,
- const url::Origin& security_origin,
const media::OutputDeviceStatusCB& callback) override {
DCHECK(thread_checker_.CalledOnValidThread());
- return delegate_->SwitchOutputDevice(device_id, security_origin, callback);
+ return delegate_->SwitchOutputDevice(device_id, callback);
}
base::TimeDelta GetCurrentRenderTime() const override {
@@ -166,8 +164,7 @@ WebRtcAudioRenderer::WebRtcAudioRenderer(
const blink::WebMediaStream& media_stream,
int source_render_frame_id,
int session_id,
- const std::string& device_id,
- const url::Origin& security_origin)
+ const std::string& device_id)
: state_(UNINITIALIZED),
source_render_frame_id_(source_render_frame_id),
session_id_(session_id),
@@ -176,9 +173,8 @@ WebRtcAudioRenderer::WebRtcAudioRenderer(
source_(nullptr),
play_ref_count_(0),
start_ref_count_(0),
- sink_params_(kFormat, kChannelLayout, 0, kBitsPerSample, 0),
- output_device_id_(device_id),
- security_origin_(security_origin) {
+ sink_params_(kFormat, kChannelLayout, 0, 0),
+ output_device_id_(device_id) {
WebRtcLogMessage(base::StringPrintf(
"WAR::WAR. source_render_frame_id=%d, session_id=%d, effects=%i",
source_render_frame_id, session_id, sink_params_.effects()));
@@ -203,7 +199,7 @@ bool WebRtcAudioRenderer::Initialize(WebRtcAudioRendererSource* source) {
sink_ = AudioDeviceFactory::NewAudioRendererSink(
AudioDeviceFactory::kSourceWebRtc, source_render_frame_id_, session_id_,
- output_device_id_, security_origin_);
+ output_device_id_);
if (sink_->GetOutputDeviceInfo().device_status() !=
media::OUTPUT_DEVICE_STATUS_OK) {
@@ -221,6 +217,7 @@ bool WebRtcAudioRenderer::Initialize(WebRtcAudioRendererSource* source) {
// User must call Play() before any audio can be heard.
state_ = PAUSED;
}
+ source_->SetOutputDeviceForAec(output_device_id_);
sink_->Start();
sink_->Play(); // Not all the sinks play on start.
@@ -374,21 +371,24 @@ bool WebRtcAudioRenderer::IsLocalRenderer() const {
void WebRtcAudioRenderer::SwitchOutputDevice(
const std::string& device_id,
- const url::Origin& security_origin,
const media::OutputDeviceStatusCB& callback) {
DVLOG(1) << "WebRtcAudioRenderer::SwitchOutputDevice()";
DCHECK(thread_checker_.CalledOnValidThread());
+ if (!source_) {
+ callback.Run(media::OUTPUT_DEVICE_STATUS_ERROR_INTERNAL);
+ return;
+ }
+
DCHECK_GE(session_id_, 0);
{
base::AutoLock auto_lock(lock_);
- DCHECK(source_);
DCHECK_NE(state_, UNINITIALIZED);
}
scoped_refptr<media::AudioRendererSink> new_sink =
AudioDeviceFactory::NewAudioRendererSink(
AudioDeviceFactory::kSourceWebRtc, source_render_frame_id_,
- session_id_, device_id, security_origin);
+ session_id_, device_id);
media::OutputDeviceStatus status =
new_sink->GetOutputDeviceInfo().device_status();
if (status != media::OUTPUT_DEVICE_STATUS_OK) {
@@ -403,11 +403,11 @@ void WebRtcAudioRenderer::SwitchOutputDevice(
sink_->Stop();
sink_ = new_sink;
output_device_id_ = device_id;
- security_origin_ = security_origin;
{
base::AutoLock auto_lock(lock_);
source_->AudioRendererThreadStopped();
}
+ source_->SetOutputDeviceForAec(output_device_id_);
PrepareSink();
sink_->Start();
sink_->Play(); // Not all the sinks play on start.