summaryrefslogtreecommitdiff
path: root/chromium/content/common/plugin_list_posix.cc
diff options
context:
space:
mode:
authorjered@chromium.org <jered@chromium.org>2013-10-01 01:33:30 +0000
committerJocelyn Turcotte <jocelyn.turcotte@digia.com>2014-02-12 10:36:55 +0100
commitafcf184b4a6daf90519a79f1fde5e2a8c026643c (patch)
treed7775a6e0f16acc825432dc03a85acaeab0059c9 /chromium/content/common/plugin_list_posix.cc
parentc08f8e4d6051af7a531ace9599009142da69b4a6 (diff)
downloadqtwebengine-chromium-afcf184b4a6daf90519a79f1fde5e2a8c026643c.tar.gz
[Backport] InstantExtended: Send search URLs to renderers.
Previously, navigations initiated by an instant renderer were bounced to the browser to be rebucketed into an instant or non-instant renderer. But navigations from non-instant renderers to instant URLs (i.e. privileged search page URLs) were not rebucketed, because the renderer had no knowledge of which URLs were instant URLs, and it would be too expensive to bounce ALL URLs. As a result, non-instant pages like google.com/setprefs could not redirect to instant pages like google.com/search. This change has InstantService tell renderers about URLs associated with the default search engine, and uses this knowledge to bounce renderer-initiated navigations to likely instant URLs from non-instant processes back into the browser for rebucketing. So now link clicks from non-instant pages to instant pages will put the destination pages into an instant process. Unfortunately, though, redirects are still broken. For example, 0. User clicks "Set preferences" button on an instant page. 1. Instant renderer bounces google.com/setprefs to the browser. 2. Browser says google.com/setprefs is not an instant URL, and assigns it to a non-instant renderer. 3. After rebucketing to the non-instant renderer, google.com/setprefs is marked as a browser initiated request(!) 4. /setprefs redirects to /search, which _is_ an instant URL, but because /setprefs is marked as browser initiated the non-instant renderer does not get a chance to bounce it back to the browser. I tried working around this by giving redirects a chance to bounce back to the browser in step #4, but this broke the signin process model in a scary way that I don't fully understand. It seems like the right fix here is going to need to EITHER follow the redirect chain in step #2 when determining if an URL is an instant URL, OR somehow flag the bounced redirect request for further inspection in step #3. This change also includes a small side benefit. Since renderers now know about instant URLs, we can suppress a flash of a baked-in error page in the event of an error while loading the InstantExtended new tab page. TEST=manual,unit,browsertest BUG=271088,223754 Review URL: https://codereview.chromium.org/23455047 Change-Id: I8a552e7d51d480c09efbfe77f5a2786f56d471ad git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226103 0039d316-1c4b-4281-b951-d872f2087c98 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Diffstat (limited to 'chromium/content/common/plugin_list_posix.cc')
0 files changed, 0 insertions, 0 deletions