summaryrefslogtreecommitdiff
path: root/chromium/content/browser/site_instance_impl_unittest.cc
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2018-08-24 12:15:48 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2018-08-28 13:30:04 +0000
commitb014812705fc80bff0a5c120dfcef88f349816dc (patch)
tree25a2e2d9fa285f1add86aa333389a839f81a39ae /chromium/content/browser/site_instance_impl_unittest.cc
parent9f4560b1027ae06fdb497023cdcaf91b8511fa74 (diff)
downloadqtwebengine-chromium-b014812705fc80bff0a5c120dfcef88f349816dc.tar.gz
BASELINE: Update Chromium to 68.0.3440.125
Change-Id: I23f19369e01f688e496f5bf179abb521ad73874f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/content/browser/site_instance_impl_unittest.cc')
-rw-r--r--chromium/content/browser/site_instance_impl_unittest.cc18
1 files changed, 10 insertions, 8 deletions
diff --git a/chromium/content/browser/site_instance_impl_unittest.cc b/chromium/content/browser/site_instance_impl_unittest.cc
index 95595ca8c75..effcb936cb2 100644
--- a/chromium/content/browser/site_instance_impl_unittest.cc
+++ b/chromium/content/browser/site_instance_impl_unittest.cc
@@ -107,7 +107,8 @@ class SiteInstanceTest : public testing::Test {
url::AddStandardScheme(kPrivilegedScheme, url::SCHEME_WITH_HOST);
url::AddStandardScheme(kChromeUIScheme, url::SCHEME_WITH_HOST);
- RenderProcessHostImpl::set_render_process_host_factory(&rph_factory_);
+ RenderProcessHostImpl::set_render_process_host_factory_for_testing(
+ &rph_factory_);
}
void TearDown() override {
@@ -115,7 +116,7 @@ class SiteInstanceTest : public testing::Test {
EXPECT_TRUE(RenderProcessHost::AllHostsIterator().IsAtEnd());
SetBrowserClientForTesting(old_browser_client_);
- RenderProcessHostImpl::set_render_process_host_factory(nullptr);
+ RenderProcessHostImpl::set_render_process_host_factory_for_testing(nullptr);
// http://crbug.com/143565 found SiteInstanceTest leaking an
// AppCacheDatabase. This happens because some part of the test indirectly
@@ -165,7 +166,7 @@ TEST_F(SiteInstanceTest, SiteInstanceDestructor) {
NavigationEntryImpl* e1 = new NavigationEntryImpl(
instance, url, Referrer(), base::string16(), ui::PAGE_TRANSITION_LINK,
- false);
+ false, nullptr /* blob_url_loader_factory */);
// Redundantly setting e1's SiteInstance shouldn't affect the ref count.
e1->set_site_instance(instance);
@@ -175,7 +176,7 @@ TEST_F(SiteInstanceTest, SiteInstanceDestructor) {
// Add a second reference
NavigationEntryImpl* e2 = new NavigationEntryImpl(
instance, url, Referrer(), base::string16(), ui::PAGE_TRANSITION_LINK,
- false);
+ false, nullptr /* blob_url_loader_factory */);
instance = nullptr;
EXPECT_EQ(0, browser_client()->GetAndClearSiteInstanceDeleteCount());
@@ -194,10 +195,10 @@ TEST_F(SiteInstanceTest, SiteInstanceDestructor) {
// Ensure that instances are deleted when their RenderViewHosts are gone.
std::unique_ptr<TestBrowserContext> browser_context(new TestBrowserContext());
{
- std::unique_ptr<WebContentsImpl> web_contents(static_cast<WebContentsImpl*>(
+ std::unique_ptr<WebContents> web_contents(
WebContents::Create(WebContents::CreateParams(
browser_context.get(),
- SiteInstance::Create(browser_context.get())))));
+ SiteInstance::Create(browser_context.get()))));
EXPECT_EQ(0, browser_client()->GetAndClearSiteInstanceDeleteCount());
EXPECT_EQ(0, browser_client()->GetAndClearBrowsingInstanceDeleteCount());
}
@@ -219,8 +220,9 @@ TEST_F(SiteInstanceTest, CloneNavigationEntry) {
std::unique_ptr<NavigationEntryImpl> e1 =
base::WrapUnique(new NavigationEntryImpl(
- SiteInstanceImpl::Create(nullptr), url, Referrer(),
- base::string16(), ui::PAGE_TRANSITION_LINK, false));
+ SiteInstanceImpl::Create(nullptr), url, Referrer(), base::string16(),
+ ui::PAGE_TRANSITION_LINK, false,
+ nullptr /* blob_url_loader_factory */));
// Clone the entry.
std::unique_ptr<NavigationEntryImpl> e2 = e1->Clone();