diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2021-10-26 13:57:00 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2021-11-02 11:31:01 +0000 |
commit | 1943b3c2a1dcee36c233724fc4ee7613d71b9cf6 (patch) | |
tree | 8c1b5f12357025c197da5427ae02cfdc2f3570d6 /chromium/content/browser/file_system_access/file_system_access_manager_impl_unittest.cc | |
parent | 21ba0c5d4bf8fba15dddd97cd693bad2358b77fd (diff) | |
download | qtwebengine-chromium-1943b3c2a1dcee36c233724fc4ee7613d71b9cf6.tar.gz |
BASELINE: Update Chromium to 94.0.4606.111
Change-Id: I924781584def20fc800bedf6ff41fdb96c438193
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/content/browser/file_system_access/file_system_access_manager_impl_unittest.cc')
-rw-r--r-- | chromium/content/browser/file_system_access/file_system_access_manager_impl_unittest.cc | 196 |
1 files changed, 102 insertions, 94 deletions
diff --git a/chromium/content/browser/file_system_access/file_system_access_manager_impl_unittest.cc b/chromium/content/browser/file_system_access/file_system_access_manager_impl_unittest.cc index ff6a79685be..0238d160d39 100644 --- a/chromium/content/browser/file_system_access/file_system_access_manager_impl_unittest.cc +++ b/chromium/content/browser/file_system_access/file_system_access_manager_impl_unittest.cc @@ -34,14 +34,17 @@ #include "mojo/public/mojom/base/file_info.mojom.h" #include "storage/browser/blob/blob_storage_context.h" #include "storage/browser/file_system/external_mount_points.h" +#include "storage/browser/quota/quota_manager_proxy.h" #include "storage/browser/test/async_file_test_helper.h" #include "storage/browser/test/test_file_system_context.h" #include "testing/gtest/include/gtest/gtest.h" +#include "third_party/blink/public/common/storage_key/storage_key.h" #include "third_party/blink/public/mojom/blob/blob.mojom.h" #include "third_party/blink/public/mojom/blob/serialized_blob.mojom.h" #include "third_party/blink/public/mojom/file_system_access/file_system_access_data_transfer_token.mojom.h" #include "third_party/blink/public/mojom/file_system_access/file_system_access_manager.mojom-forward.h" #include "third_party/blink/public/mojom/file_system_access/file_system_access_manager.mojom-shared.h" +#include "url/gurl.h" namespace content { @@ -181,12 +184,12 @@ class FileSystemAccessManagerImplTest : public testing::Test { EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, path, HandleType::kDirectory, + kTestStorageKey.origin(), path, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(grant)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, path, HandleType::kDirectory, + kTestStorageKey.origin(), path, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(grant)); @@ -212,7 +215,7 @@ class FileSystemAccessManagerImplTest : public testing::Test { })); serialize_loop.Run(); - manager_->DeserializeHandle(kTestOrigin, serialized, + manager_->DeserializeHandle(kTestStorageKey.origin(), serialized, token_remote.InitWithNewPipeAndPassReceiver()); base::RunLoop resolve_loop; FileSystemAccessTransferTokenImpl* result; @@ -242,14 +245,14 @@ class FileSystemAccessManagerImplTest : public testing::Test { EXPECT_CALL( permission_context_, GetReadPermissionGrant( - kTestOrigin, file_path, HandleType::kFile, + kTestStorageKey.origin(), file_path, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kDragAndDrop)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL( permission_context_, GetWritePermissionGrant( - kTestOrigin, file_path, HandleType::kFile, + kTestStorageKey.origin(), file_path, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kDragAndDrop)) .WillOnce(testing::Return(allow_grant_)); @@ -292,14 +295,14 @@ class FileSystemAccessManagerImplTest : public testing::Test { EXPECT_CALL( permission_context_, GetReadPermissionGrant( - kTestOrigin, dir_path, HandleType::kDirectory, + kTestStorageKey.origin(), dir_path, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kDragAndDrop)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL( permission_context_, GetWritePermissionGrant( - kTestOrigin, dir_path, HandleType::kDirectory, + kTestStorageKey.origin(), dir_path, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kDragAndDrop)) .WillOnce(testing::Return(allow_grant_)); @@ -340,12 +343,13 @@ class FileSystemAccessManagerImplTest : public testing::Test { protected: const GURL kTestURL = GURL("https://example.com/test"); - const url::Origin kTestOrigin = url::Origin::Create(kTestURL); + const blink::StorageKey kTestStorageKey = + blink::StorageKey::CreateFromStringForTesting("https://example.com/test"); const int kProcessId = 1; const int kFrameRoutingId = 2; - const GlobalFrameRoutingId kFrameId{kProcessId, kFrameRoutingId}; + const GlobalRenderFrameHostId kFrameId{kProcessId, kFrameRoutingId}; const FileSystemAccessManagerImpl::BindingContext kBindingContext = { - kTestOrigin, kTestURL, kFrameId}; + kTestStorageKey.origin(), kTestURL, kFrameId}; BrowserTaskEnvironment task_environment_; @@ -404,12 +408,12 @@ TEST_F(FileSystemAccessManagerImplTest, CreateFileEntryFromPath_Permissions) { EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(ask_grant_)); @@ -432,12 +436,12 @@ TEST_F(FileSystemAccessManagerImplTest, EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kSave)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kSave)) .WillOnce(testing::Return(allow_grant_)); @@ -460,12 +464,12 @@ TEST_F(FileSystemAccessManagerImplTest, EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kDirectory, + kTestStorageKey.origin(), kTestPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kDirectory, + kTestStorageKey.origin(), kTestPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(ask_grant_)); @@ -484,11 +488,11 @@ TEST_F(FileSystemAccessManagerImplTest, TEST_F(FileSystemAccessManagerImplTest, FileWriterSwapDeletedOnConnectionClose) { auto test_file_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test")); auto test_swap_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test.crswap")); ASSERT_EQ(base::File::FILE_OK, @@ -502,7 +506,7 @@ TEST_F(FileSystemAccessManagerImplTest, mojo::Remote<blink::mojom::FileSystemAccessFileWriter> writer_remote( manager_->CreateFileWriter(kBindingContext, test_file_url, test_swap_url, FileSystemAccessManagerImpl::SharedHandleState( - allow_grant_, allow_grant_, {}), + allow_grant_, allow_grant_), /*auto_close=*/false)); ASSERT_TRUE(writer_remote.is_bound()); @@ -521,11 +525,11 @@ TEST_F(FileSystemAccessManagerImplTest, TEST_F(FileSystemAccessManagerImplTest, FileWriterCloseDoesNotAbortOnDestruct) { auto test_file_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test")); auto test_swap_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test.crswap")); ASSERT_EQ(base::File::FILE_OK, @@ -535,7 +539,7 @@ TEST_F(FileSystemAccessManagerImplTest, FileWriterCloseDoesNotAbortOnDestruct) { mojo::Remote<blink::mojom::FileSystemAccessFileWriter> writer_remote( manager_->CreateFileWriter(kBindingContext, test_file_url, test_swap_url, FileSystemAccessManagerImpl::SharedHandleState( - allow_grant_, allow_grant_, {}), + allow_grant_, allow_grant_), /*auto_close=*/false)); ASSERT_TRUE(writer_remote.is_bound()); @@ -565,11 +569,11 @@ TEST_F(FileSystemAccessManagerImplTest, FileWriterCloseDoesNotAbortOnDestruct) { TEST_F(FileSystemAccessManagerImplTest, FileWriterNoWritesIfConnectionLostBeforeClose) { auto test_file_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test")); auto test_swap_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test.crswap")); ASSERT_EQ(base::File::FILE_OK, @@ -579,7 +583,7 @@ TEST_F(FileSystemAccessManagerImplTest, mojo::Remote<blink::mojom::FileSystemAccessFileWriter> writer_remote( manager_->CreateFileWriter(kBindingContext, test_file_url, test_swap_url, FileSystemAccessManagerImpl::SharedHandleState( - allow_grant_, allow_grant_, {}), + allow_grant_, allow_grant_), /*auto_close=*/false)); // Severs the mojo pipe. The writer should be destroyed. @@ -598,11 +602,11 @@ TEST_F(FileSystemAccessManagerImplTest, TEST_F(FileSystemAccessManagerImplTest, FileWriterAutoCloseIfConnectionLostBeforeClose) { auto test_file_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test")); auto test_swap_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTest, + kTestStorageKey, storage::kFileSystemTypeTest, base::FilePath::FromUTF8Unsafe("test.crswap")); ASSERT_EQ(base::File::FILE_OK, @@ -612,7 +616,7 @@ TEST_F(FileSystemAccessManagerImplTest, mojo::Remote<blink::mojom::FileSystemAccessFileWriter> writer_remote( manager_->CreateFileWriter(kBindingContext, test_file_url, test_swap_url, FileSystemAccessManagerImpl::SharedHandleState( - allow_grant_, allow_grant_, {}), + allow_grant_, allow_grant_), /*auto_close=*/true)); ASSERT_TRUE(writer_remote.is_bound()); @@ -641,11 +645,10 @@ TEST_F(FileSystemAccessManagerImplTest, TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_SandboxedFile) { auto test_file_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTemporary, + kTestStorageKey, storage::kFileSystemTypeTemporary, base::FilePath::FromUTF8Unsafe("test/foo/bar")); FileSystemAccessFileHandleImpl file(manager_.get(), kBindingContext, - test_file_url, - {ask_grant_, ask_grant_, {}}); + test_file_url, {ask_grant_, ask_grant_}); mojo::PendingRemote<blink::mojom::FileSystemAccessTransferToken> token_remote; manager_->CreateTransferToken(file, token_remote.InitWithNewPipeAndPassReceiver()); @@ -666,11 +669,10 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_SandboxedFile) { TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_SandboxedDirectory) { auto test_file_url = file_system_context_->CreateCrackedFileSystemURL( - kTestOrigin, storage::kFileSystemTypeTemporary, + kTestStorageKey, storage::kFileSystemTypeTemporary, base::FilePath::FromUTF8Unsafe("hello/world/")); - FileSystemAccessDirectoryHandleImpl directory(manager_.get(), kBindingContext, - test_file_url, - {ask_grant_, ask_grant_, {}}); + FileSystemAccessDirectoryHandleImpl directory( + manager_.get(), kBindingContext, test_file_url, {ask_grant_, ask_grant_}); mojo::PendingRemote<blink::mojom::FileSystemAccessTransferToken> token_remote; manager_->CreateTransferToken(directory, token_remote.InitWithNewPipeAndPassReceiver()); @@ -699,12 +701,12 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_Native_SingleFile) { // Expect calls to get grants when creating the initial handle. EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(grant)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(grant)); @@ -722,13 +724,13 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_Native_SingleFile) { EXPECT_CALL( permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant_)); EXPECT_CALL( permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant2_)); @@ -736,10 +738,10 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_Native_SingleFile) { SerializeAndDeserializeToken(std::move(token_remote)); ASSERT_TRUE(token); const storage::FileSystemURL& url = token->url(); - EXPECT_EQ(kTestOrigin, url.origin()); + EXPECT_TRUE(url.origin().opaque()); EXPECT_EQ(kTestPath, url.path()); EXPECT_EQ(storage::kFileSystemTypeLocal, url.type()); - EXPECT_EQ(storage::kFileSystemTypeIsolated, url.mount_type()); + EXPECT_EQ(storage::kFileSystemTypeLocal, url.mount_type()); EXPECT_EQ(HandleType::kFile, token->type()); EXPECT_EQ(ask_grant_, token->GetReadGrant()); EXPECT_EQ(ask_grant2_, token->GetWriteGrant()); @@ -758,13 +760,13 @@ TEST_F(FileSystemAccessManagerImplTest, EXPECT_CALL( permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kDirectory, + kTestStorageKey.origin(), kTestPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant_)); EXPECT_CALL( permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kDirectory, + kTestStorageKey.origin(), kTestPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant2_)); @@ -772,10 +774,10 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeAndDeserializeToken(std::move(token_remote)); ASSERT_TRUE(token); const storage::FileSystemURL& url = token->url(); - EXPECT_EQ(kTestOrigin, url.origin()); + EXPECT_TRUE(url.origin().opaque()); EXPECT_EQ(kTestPath, url.path()); EXPECT_EQ(storage::kFileSystemTypeLocal, url.type()); - EXPECT_EQ(storage::kFileSystemTypeIsolated, url.mount_type()); + EXPECT_EQ(storage::kFileSystemTypeLocal, url.mount_type()); EXPECT_EQ(HandleType::kDirectory, token->type()); EXPECT_EQ(ask_grant_, token->GetReadGrant()); EXPECT_EQ(ask_grant2_, token->GetWriteGrant()); @@ -813,13 +815,13 @@ TEST_F(FileSystemAccessManagerImplTest, EXPECT_CALL( permission_context_, GetReadPermissionGrant( - kTestOrigin, kDirectoryPath, HandleType::kDirectory, + kTestStorageKey.origin(), kDirectoryPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant_)); EXPECT_CALL( permission_context_, GetWritePermissionGrant( - kTestOrigin, kDirectoryPath, HandleType::kDirectory, + kTestStorageKey.origin(), kDirectoryPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant2_)); @@ -827,11 +829,11 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeAndDeserializeToken(std::move(token_remote)); ASSERT_TRUE(token); const storage::FileSystemURL& url = token->url(); - EXPECT_EQ(kTestOrigin, url.origin()); + EXPECT_TRUE(url.origin().opaque()); EXPECT_EQ(kDirectoryPath.Append(base::FilePath::FromUTF8Unsafe(kTestName)), url.path()); EXPECT_EQ(storage::kFileSystemTypeLocal, url.type()); - EXPECT_EQ(storage::kFileSystemTypeIsolated, url.mount_type()); + EXPECT_EQ(storage::kFileSystemTypeLocal, url.mount_type()); EXPECT_EQ(HandleType::kFile, token->type()); EXPECT_EQ(ask_grant_, token->GetReadGrant()); EXPECT_EQ(ask_grant2_, token->GetWriteGrant()); @@ -869,13 +871,13 @@ TEST_F(FileSystemAccessManagerImplTest, EXPECT_CALL( permission_context_, GetReadPermissionGrant( - kTestOrigin, kDirectoryPath, HandleType::kDirectory, + kTestStorageKey.origin(), kDirectoryPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant_)); EXPECT_CALL( permission_context_, GetWritePermissionGrant( - kTestOrigin, kDirectoryPath, HandleType::kDirectory, + kTestStorageKey.origin(), kDirectoryPath, HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant2_)); @@ -883,10 +885,10 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeAndDeserializeToken(std::move(token_remote)); ASSERT_TRUE(token); const storage::FileSystemURL& url = token->url(); - EXPECT_EQ(kTestOrigin, url.origin()); + EXPECT_TRUE(url.origin().opaque()); EXPECT_EQ(kDirectoryPath.AppendASCII(kTestName), url.path()); EXPECT_EQ(storage::kFileSystemTypeLocal, url.type()); - EXPECT_EQ(storage::kFileSystemTypeIsolated, url.mount_type()); + EXPECT_EQ(storage::kFileSystemTypeLocal, url.mount_type()); EXPECT_EQ(HandleType::kDirectory, token->type()); EXPECT_EQ(ask_grant_, token->GetReadGrant()); EXPECT_EQ(ask_grant2_, token->GetWriteGrant()); @@ -903,12 +905,12 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_ExternalFile) { // Expect calls to get grants when creating the initial handle. EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(grant)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(grant)); @@ -926,13 +928,13 @@ TEST_F(FileSystemAccessManagerImplTest, SerializeHandle_ExternalFile) { EXPECT_CALL( permission_context_, GetReadPermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant_)); EXPECT_CALL( permission_context_, GetWritePermissionGrant( - kTestOrigin, kTestPath, HandleType::kFile, + kTestStorageKey.origin(), kTestPath, HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kLoadFromStorage)) .WillOnce(testing::Return(ask_grant2_)); @@ -1121,12 +1123,13 @@ TEST_F(FileSystemAccessManagerImplTest, ChooseEntries_OpenFile) { mojo::Remote<blink::mojom::FileSystemAccessManager> manager_remote; FileSystemAccessManagerImpl::BindingContext binding_context = { - kTestOrigin, kTestURL, - web_contents_->GetMainFrame()->GetGlobalFrameRoutingId()}; + kTestStorageKey.origin(), kTestURL, + web_contents_->GetMainFrame()->GetGlobalId()}; manager_->BindReceiver(binding_context, manager_remote.BindNewPipeAndPassReceiver()); - EXPECT_CALL(permission_context_, CanObtainReadPermission(kTestOrigin)) + EXPECT_CALL(permission_context_, + CanObtainReadPermission(kTestStorageKey.origin())) .WillOnce(testing::Return(true)); EXPECT_CALL( @@ -1134,30 +1137,31 @@ TEST_F(FileSystemAccessManagerImplTest, ChooseEntries_OpenFile) { GetWellKnownDirectoryPath(blink::mojom::WellKnownDirectory::kDefault)) .WillOnce(testing::Return(base::FilePath())); EXPECT_CALL(permission_context_, - GetLastPickedDirectory(kTestOrigin, std::string())) + GetLastPickedDirectory(kTestStorageKey.origin(), std::string())) .WillOnce(testing::Return(PathInfo())); EXPECT_CALL(permission_context_, - SetLastPickedDirectory(kTestOrigin, std::string(), + SetLastPickedDirectory(kTestStorageKey.origin(), std::string(), test_file.DirName(), PathType::kLocal)); EXPECT_CALL( permission_context_, ConfirmSensitiveDirectoryAccess_( - kTestOrigin, FileSystemAccessPermissionContext::PathType::kLocal, - test_file, FileSystemAccessPermissionContext::HandleType::kFile, - web_contents_->GetMainFrame()->GetGlobalFrameRoutingId(), testing::_)) + kTestStorageKey.origin(), + FileSystemAccessPermissionContext::PathType::kLocal, test_file, + FileSystemAccessPermissionContext::HandleType::kFile, + web_contents_->GetMainFrame()->GetGlobalId(), testing::_)) .WillOnce(RunOnceCallback<5>(FileSystemAccessPermissionContext:: SensitiveDirectoryResult::kAllowed)); EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, test_file, + kTestStorageKey.origin(), test_file, FileSystemAccessPermissionContext::HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, test_file, + kTestStorageKey.origin(), test_file, FileSystemAccessPermissionContext::HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(allow_grant_)); @@ -1199,14 +1203,16 @@ TEST_F(FileSystemAccessManagerImplTest, ChooseEntries_SaveFile) { mojo::Remote<blink::mojom::FileSystemAccessManager> manager_remote; FileSystemAccessManagerImpl::BindingContext binding_context = { - kTestOrigin, kTestURL, - web_contents_->GetMainFrame()->GetGlobalFrameRoutingId()}; + kTestStorageKey.origin(), kTestURL, + web_contents_->GetMainFrame()->GetGlobalId()}; manager_->BindReceiver(binding_context, manager_remote.BindNewPipeAndPassReceiver()); - EXPECT_CALL(permission_context_, CanObtainReadPermission(kTestOrigin)) + EXPECT_CALL(permission_context_, + CanObtainReadPermission(kTestStorageKey.origin())) .WillOnce(testing::Return(true)); - EXPECT_CALL(permission_context_, CanObtainWritePermission(kTestOrigin)) + EXPECT_CALL(permission_context_, + CanObtainWritePermission(kTestStorageKey.origin())) .WillOnce(testing::Return(true)); EXPECT_CALL( @@ -1214,30 +1220,31 @@ TEST_F(FileSystemAccessManagerImplTest, ChooseEntries_SaveFile) { GetWellKnownDirectoryPath(blink::mojom::WellKnownDirectory::kDefault)) .WillOnce(testing::Return(base::FilePath())); EXPECT_CALL(permission_context_, - GetLastPickedDirectory(kTestOrigin, std::string())) + GetLastPickedDirectory(kTestStorageKey.origin(), std::string())) .WillOnce(testing::Return(PathInfo())); EXPECT_CALL(permission_context_, - SetLastPickedDirectory(kTestOrigin, std::string(), + SetLastPickedDirectory(kTestStorageKey.origin(), std::string(), test_file.DirName(), PathType::kLocal)); EXPECT_CALL( permission_context_, ConfirmSensitiveDirectoryAccess_( - kTestOrigin, FileSystemAccessPermissionContext::PathType::kLocal, - test_file, FileSystemAccessPermissionContext::HandleType::kFile, - web_contents_->GetMainFrame()->GetGlobalFrameRoutingId(), testing::_)) + kTestStorageKey.origin(), + FileSystemAccessPermissionContext::PathType::kLocal, test_file, + FileSystemAccessPermissionContext::HandleType::kFile, + web_contents_->GetMainFrame()->GetGlobalId(), testing::_)) .WillOnce(RunOnceCallback<5>(FileSystemAccessPermissionContext:: SensitiveDirectoryResult::kAllowed)); EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, test_file, + kTestStorageKey.origin(), test_file, FileSystemAccessPermissionContext::HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kSave)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, test_file, + kTestStorageKey.origin(), test_file, FileSystemAccessPermissionContext::HandleType::kFile, FileSystemAccessPermissionContext::UserAction::kSave)) .WillOnce(testing::Return(allow_grant_)); @@ -1278,12 +1285,13 @@ TEST_F(FileSystemAccessManagerImplTest, ChooseEntries_OpenDirectory) { mojo::Remote<blink::mojom::FileSystemAccessManager> manager_remote; FileSystemAccessManagerImpl::BindingContext binding_context = { - kTestOrigin, kTestURL, - web_contents_->GetMainFrame()->GetGlobalFrameRoutingId()}; + kTestStorageKey.origin(), kTestURL, + web_contents_->GetMainFrame()->GetGlobalId()}; manager_->BindReceiver(binding_context, manager_remote.BindNewPipeAndPassReceiver()); - EXPECT_CALL(permission_context_, CanObtainReadPermission(kTestOrigin)) + EXPECT_CALL(permission_context_, + CanObtainReadPermission(kTestStorageKey.origin())) .WillOnce(testing::Return(true)); EXPECT_CALL( @@ -1291,30 +1299,30 @@ TEST_F(FileSystemAccessManagerImplTest, ChooseEntries_OpenDirectory) { GetWellKnownDirectoryPath(blink::mojom::WellKnownDirectory::kDefault)) .WillOnce(testing::Return(base::FilePath())); EXPECT_CALL(permission_context_, - GetLastPickedDirectory(kTestOrigin, std::string())) + GetLastPickedDirectory(kTestStorageKey.origin(), std::string())) .WillOnce(testing::Return(PathInfo())); EXPECT_CALL(permission_context_, - SetLastPickedDirectory(kTestOrigin, std::string(), test_dir, - PathType::kLocal)); + SetLastPickedDirectory(kTestStorageKey.origin(), std::string(), + test_dir, PathType::kLocal)); - EXPECT_CALL( - permission_context_, - ConfirmSensitiveDirectoryAccess_( - kTestOrigin, FileSystemAccessPermissionContext::PathType::kLocal, - test_dir, FileSystemAccessPermissionContext::HandleType::kDirectory, - web_contents_->GetMainFrame()->GetGlobalFrameRoutingId(), testing::_)) + EXPECT_CALL(permission_context_, + ConfirmSensitiveDirectoryAccess_( + kTestStorageKey.origin(), + FileSystemAccessPermissionContext::PathType::kLocal, test_dir, + FileSystemAccessPermissionContext::HandleType::kDirectory, + web_contents_->GetMainFrame()->GetGlobalId(), testing::_)) .WillOnce(RunOnceCallback<5>(FileSystemAccessPermissionContext:: SensitiveDirectoryResult::kAllowed)); EXPECT_CALL(permission_context_, GetReadPermissionGrant( - kTestOrigin, test_dir, + kTestStorageKey.origin(), test_dir, FileSystemAccessPermissionContext::HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(allow_grant_)); EXPECT_CALL(permission_context_, GetWritePermissionGrant( - kTestOrigin, test_dir, + kTestStorageKey.origin(), test_dir, FileSystemAccessPermissionContext::HandleType::kDirectory, FileSystemAccessPermissionContext::UserAction::kOpen)) .WillOnce(testing::Return(allow_grant_)); @@ -1351,8 +1359,8 @@ TEST_F(FileSystemAccessManagerImplTest, ChooseEntries_InvalidStartInID) { mojo::Remote<blink::mojom::FileSystemAccessManager> manager_remote; FileSystemAccessManagerImpl::BindingContext binding_context = { - kTestOrigin, kTestURL, - web_contents_->GetMainFrame()->GetGlobalFrameRoutingId()}; + kTestStorageKey.origin(), kTestURL, + web_contents_->GetMainFrame()->GetGlobalId()}; manager_->BindReceiver(binding_context, manager_remote.BindNewPipeAndPassReceiver()); |