summaryrefslogtreecommitdiff
path: root/chromium/content/browser/cookie_store/cookie_change_subscription.cc
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2021-05-20 09:47:09 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2021-06-07 11:15:42 +0000
commit189d4fd8fad9e3c776873be51938cd31a42b6177 (patch)
tree6497caeff5e383937996768766ab3bb2081a40b2 /chromium/content/browser/cookie_store/cookie_change_subscription.cc
parent8bc75099d364490b22f43a7ce366b366c08f4164 (diff)
downloadqtwebengine-chromium-189d4fd8fad9e3c776873be51938cd31a42b6177.tar.gz
BASELINE: Update Chromium to 90.0.4430.221
Change-Id: Iff4d9d18d2fcf1a576f3b1f453010f744a232920 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/content/browser/cookie_store/cookie_change_subscription.cc')
-rw-r--r--chromium/content/browser/cookie_store/cookie_change_subscription.cc20
1 files changed, 18 insertions, 2 deletions
diff --git a/chromium/content/browser/cookie_store/cookie_change_subscription.cc b/chromium/content/browser/cookie_store/cookie_change_subscription.cc
index 6dff0ba3213..07b9b55f5fd 100644
--- a/chromium/content/browser/cookie_store/cookie_change_subscription.cc
+++ b/chromium/content/browser/cookie_store/cookie_change_subscription.cc
@@ -7,6 +7,9 @@
#include <utility>
#include "content/browser/cookie_store/cookie_change_subscriptions.pb.h"
+#include "net/cookies/cookie_constants.h"
+#include "net/cookies/cookie_util.h"
+#include "services/network/public/cpp/is_potentially_trustworthy.h"
namespace content {
@@ -164,11 +167,24 @@ bool CookieChangeSubscription::ShouldObserveChangeTo(
break;
}
+ // We assume that this is a same-site, same-party context.
net::CookieOptions net_options;
net_options.set_same_site_cookie_context(
net::CookieOptions::SameSiteCookieContext::MakeInclusive());
-
- return cookie.IncludeForRequestURL(url_, net_options, access_semantics)
+ net_options.set_same_party_cookie_context_type(
+ net::CookieOptions::SamePartyCookieContextType::kSameParty);
+ // It doesn't matter which we choose here, since both SameParty and SameSite
+ // semantics should allow this access. But we make a choice to be explicit.
+ net_options.set_is_in_nontrivial_first_party_set(true);
+
+ return cookie
+ .IncludeForRequestURL(
+ url_, net_options,
+ net::CookieAccessParams{
+ access_semantics,
+ network::IsUrlPotentiallyTrustworthy(url_),
+ net::cookie_util::GetSamePartyStatus(cookie, net_options),
+ })
.status.IsInclude();
}